[00:12:08] Gloria: Deployment for testing !== deployment to production, sadly. :-( [00:12:20] Test in production [00:12:36] <^d> Only place to test, duhhh [00:12:54] Yeah, duh. (he's called legoktm right now) [00:13:00] * James_F grins. [00:13:07] No, I'm ugh right now. [00:13:12] ;) [00:13:37] James_F: :-( [00:13:42] ugh is the new legoktm [00:13:44] Ugh, ugh. [00:13:54] ugh: You going by a three-letter monicker because you're hanging with ori who also is of three letters? :-) [00:13:54] This explains why you didn't answer my PM. [00:14:00] Hug is the new ugh. [00:14:00] Gah. [00:14:06] * James_F hugs guh. [00:14:15] (03CR) 10Aaron Schulz: [C: 04-2] "Looks redundant" [core] - 10https://gerrit.wikimedia.org/r/126666 (owner: 10Reedy) [00:14:18] But not ugh until this bug is fixed. [00:14:29] So many bugs. [00:14:57] (03PS27) 10Bsitu: Closing & Summarizing topic frontend changes [extensions/Flow] - 10https://gerrit.wikimedia.org/r/119640 [00:15:39] ugh: So in general will any JS/CSS change to these user pages take ten minutes to propagate? [00:15:58] No [00:16:13] Nice. [00:16:19] it should be instantaneous-ish +/- local browser caching [00:16:37] I have to go to dinner. [00:16:42] But I love you. [00:17:34] Gloria: We love you whether or not you go to dinner. [00:17:49] (03PS4) 10Kushal124: [WIP] Add review settings page [wikimedia/wikimania-scholarships] - 10https://gerrit.wikimedia.org/r/126833 [00:19:02] jdlrobson: hey, can you confirm mobilefrontend looks OK? [00:19:29] i just finished scapping the cherry-picks max added to the swat window [00:19:33] Gloria: The proper emoticon is ε> :-) [00:25:47] (03PS2) 10Esanders: Simplify VE inspector code by extending new MWLiveExtensionInspector [extensions/Math] - 10https://gerrit.wikimedia.org/r/126901 (owner: 10Jforrester) [00:28:28] (03PS3) 10Esanders: Simplify VE inspector code by extending new MWLiveExtensionInspector [extensions/Math] - 10https://gerrit.wikimedia.org/r/126901 (owner: 10Jforrester) [00:28:49] (03PS1) 10MaxSem: Calculate width properly if image is bounded by height only [extensions/PageImages] - 10https://gerrit.wikimedia.org/r/127190 [00:31:18] (03PS4) 10Esanders: Simplify VE inspector code by extending new MWLiveExtensionInspector [extensions/Math] - 10https://gerrit.wikimedia.org/r/126901 (owner: 10Jforrester) [00:41:11] (03PS5) 10Esanders: Simplify VE inspector code by extending new MWLiveExtensionInspector [extensions/Math] - 10https://gerrit.wikimedia.org/r/126901 (owner: 10Jforrester) [00:49:31] (03CR) 10Bsitu: [C: 04-1] "Some more fixes are on the way!" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/119640 (owner: 10Bsitu) [00:55:49] (03PS6) 10Esanders: Simplify VE inspector code by extending new MWLiveExtensionInspector [extensions/Math] - 10https://gerrit.wikimedia.org/r/126901 (owner: 10Jforrester) [02:17:14] (03PS1) 10BryanDavis: Exit with non-zero status on soft failure [tools/scap] - 10https://gerrit.wikimedia.org/r/127198 [02:42:57] (03PS2) 10BryanDavis: Improve error message when scap lock fails [tools/scap] - 10https://gerrit.wikimedia.org/r/126924 [02:57:25] (03PS1) 10BryanDavis: Convert scap-rebuild-cdbs to python [tools/scap] - 10https://gerrit.wikimedia.org/r/127199 [03:08:53] is there a canonical rc feed parser, or roll your own? [03:08:53] the irc rc feed [03:42:17] Project CirrusSearch-en.wikipedia.beta.wmflabs.org-linux-firefox build #11: STILL FAILING in 3 min 21 sec: https://integration.wikimedia.org/ci/job/CirrusSearch-en.wikipedia.beta.wmflabs.org-linux-firefox/11/ [03:42:17] * neverett: Don't add a filter if not needed [03:42:18] * neverett: Quoted searches with accents only find accented [03:45:22] (03PS12) 10EBernhardson: First stab at new template rendering in php [extensions/Flow] (frontend-rewrite) - 10https://gerrit.wikimedia.org/r/125358 [03:45:36] (03CR) 10jenkins-bot: [V: 04-1] First stab at new template rendering in php [extensions/Flow] (frontend-rewrite) - 10https://gerrit.wikimedia.org/r/125358 (owner: 10EBernhardson) [04:23:47] (03PS17) 10Mattflaschen: WIP: Refactor and add non-linear tours, with tests [extensions/GuidedTour] - 10https://gerrit.wikimedia.org/r/116228 [04:24:14] (03CR) 10jenkins-bot: [V: 04-1] WIP: Refactor and add non-linear tours, with tests [extensions/GuidedTour] - 10https://gerrit.wikimedia.org/r/116228 (owner: 10Mattflaschen) [04:25:33] (03CR) 10Krinkle: [C: 04-2] "This change modifies an upstream library for no good reason. The \r\n is a harmless but annoying side-effect that was genuinely part of pa" [core] - 10https://gerrit.wikimedia.org/r/125560 (owner: 10Umherirrender) [04:25:52] (03CR) 10Mattflaschen: "Unit tests are done. Next up is logging." [extensions/GuidedTour] - 10https://gerrit.wikimedia.org/r/116228 (owner: 10Mattflaschen) [04:30:48] (03PS5) 10Krinkle: Apply coding conventions for whitespaces [core] - 10https://gerrit.wikimedia.org/r/125328 (owner: 10Gerrit Patch Uploader) [04:30:58] (03CR) 10Krinkle: [C: 032] "Thanks!" [core] - 10https://gerrit.wikimedia.org/r/125328 (owner: 10Gerrit Patch Uploader) [04:35:06] (03Merged) 10jenkins-bot: Apply coding conventions for whitespaces [core] - 10https://gerrit.wikimedia.org/r/125328 (owner: 10Gerrit Patch Uploader) [04:35:38] (03PS18) 10Mattflaschen: WIP: Refactor and add non-linear tours, with tests [extensions/GuidedTour] - 10https://gerrit.wikimedia.org/r/116228 [04:38:22] (03CR) 10Mattflaschen: "Fixed the jshint. For the ones with a constructor call, I just suppressed the warning, since there is a different warning if you call a c" [extensions/GuidedTour] - 10https://gerrit.wikimedia.org/r/116228 (owner: 10Mattflaschen) [04:42:56] (03CR) 10Krinkle: [C: 04-1] "Right now both the way the code is written and how it is used in AbuseFilter don't scale well. It unconditionally overwrites the variable," (032 comments) [core] - 10https://gerrit.wikimedia.org/r/120811 (owner: 10Tinaj1234) [04:44:15] (03PS1) 10Severin Anatoliy: fix bug in 'savenewthread' action [extensions/WikiForum] - 10https://gerrit.wikimedia.org/r/127203 [04:45:07] (03PS2) 10Krinkle: HistoryAction: Implement a hook for extensions to add more tool links [core] - 10https://gerrit.wikimedia.org/r/120811 (owner: 10Tinaj1234) [04:45:36] (03CR) 10Severin Anatoliy: [C: 031] fix bug in 'savenewthread' action [extensions/WikiForum] - 10https://gerrit.wikimedia.org/r/127203 (owner: 10Severin Anatoliy) [04:45:42] (03CR) 10Krinkle: "Removed reference to AbuseFilter change from commit message, mentioning here instead: Listener in AbuseFilter extension is in change Ib89c" [core] - 10https://gerrit.wikimedia.org/r/120811 (owner: 10Tinaj1234) [04:46:49] (03PS4) 10Krinkle: Use hook to add a log link to History pages [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/120809 (owner: 10Tinaj1234) [04:47:15] (03CR) 10Krinkle: "Corrected grammar." (033 comments) [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/120809 (owner: 10Tinaj1234) [04:47:37] (03CR) 10Krinkle: "ping" [core] - 10https://gerrit.wikimedia.org/r/64569 (owner: 10Hashar) [04:51:30] (03PS6) 10Krinkle: Use personalised tokens for logged-out users that have a session already [core] - 10https://gerrit.wikimedia.org/r/76458 (owner: 10Parent5446) [04:53:28] (03PS4) 10Krinkle: mediawiki.Title.js: Correct documentation structure for Title.exist [core] - 10https://gerrit.wikimedia.org/r/125758 (owner: 10Jforrester) [04:55:37] (03CR) 10Krinkle: mediawiki.Title.js: Correct documentation structure for Title.exist (031 comment) [core] - 10https://gerrit.wikimedia.org/r/125758 (owner: 10Jforrester) [04:57:43] (03PS5) 10Krinkle: mediawiki.Title: Correct documentation structure for Title.exist [core] - 10https://gerrit.wikimedia.org/r/125758 (owner: 10Jforrester) [04:58:07] (03CR) 10Krinkle: [C: 032] mediawiki.Title: Correct documentation structure for Title.exist [core] - 10https://gerrit.wikimedia.org/r/125758 (owner: 10Jforrester) [05:01:29] (03PS3) 10BryanDavis: Enable customization of Vagrant and virtual machine [vagrant] - 10https://gerrit.wikimedia.org/r/121425 [05:01:31] (03CR) 10jenkins-bot: [V: 04-1] Enable customization of Vagrant and virtual machine [vagrant] - 10https://gerrit.wikimedia.org/r/121425 (owner: 10BryanDavis) [05:01:59] (03Merged) 10jenkins-bot: mediawiki.Title: Correct documentation structure for Title.exist [core] - 10https://gerrit.wikimedia.org/r/125758 (owner: 10Jforrester) [05:02:21] (03CR) 10Krinkle: "@Ori: But does it make sense for a local wiki (e.g. only Wikimedia, or certain third-parties) to use a different minifier than the default" [core] - 10https://gerrit.wikimedia.org/r/74293 (owner: 10MaxSem) [05:03:05] (03PS3) 10Krinkle: mwjsduck-gen: Don't fail when running from different directory, Windows fixes [core] - 10https://gerrit.wikimedia.org/r/125773 (owner: 10Bartosz Dziewoński) [05:04:04] (03PS4) 10BryanDavis: Enable customization of Vagrant and virtual machine [vagrant] - 10https://gerrit.wikimedia.org/r/121425 [05:06:08] (03CR) 10Krinkle: mwjsduck-gen: Don't fail when running from different directory, Windows fixes (031 comment) [core] - 10https://gerrit.wikimedia.org/r/125773 (owner: 10Bartosz Dziewoński) [05:07:06] (03CR) 10Krinkle: mwjsduck-gen: Don't fail when running from different directory, Windows fixes (031 comment) [core] - 10https://gerrit.wikimedia.org/r/125773 (owner: 10Bartosz Dziewoński) [05:08:58] (03Abandoned) 10Umherirrender: Fix line delimiter of sizzle.js inside jquery.js file [core] - 10https://gerrit.wikimedia.org/r/125560 (owner: 10Umherirrender) [05:25:33] (03PS1) 10MaxSem: Reorganize blacklisted selectors [extensions/TextExtracts] - 10https://gerrit.wikimedia.org/r/127206 [05:27:38] (03PS1) 10Severin Anatoliy: fix copy-past-mistakes [extensions/WikiForum] - 10https://gerrit.wikimedia.org/r/127207 [05:28:00] (03CR) 10Ori.livneh: "Cunningham's law. TimedMediaHandler will get fixed. I'd merge. I lose sleep over this." [core] - 10https://gerrit.wikimedia.org/r/127177 (owner: 10MaxSem) [05:28:45] (03CR) 10Severin Anatoliy: [C: 031] fix copy-past-mistakes [extensions/WikiForum] - 10https://gerrit.wikimedia.org/r/127207 (owner: 10Severin Anatoliy) [05:33:31] (03CR) 10Ori.livneh: "> If one is stable and good enough, surely we'd just adopt it in core?" [core] - 10https://gerrit.wikimedia.org/r/74293 (owner: 10MaxSem) [07:16:42] (03PS1) 10Daniel Friesen: (bug 64085) Make API action=rsd work on private wikis. [core] - 10https://gerrit.wikimedia.org/r/127208 [08:05:43] zz_sucheta: what is the procedure for merging pull requests from github? [08:05:51] oops, that was @zz_yuvipanda [08:37:29] (03PS1) 10Dan-nl: fix MediawikiTemplate::getTitle() method [extensions/GWToolset] - 10https://gerrit.wikimedia.org/r/127211 [08:53:11] Yippee, build fixed! [08:53:11] Project CirrusSearch-en.wikipedia.beta.wmflabs.org-linux-firefox build #12: FIXED in 31 sec: https://integration.wikimedia.org/ci/job/CirrusSearch-en.wikipedia.beta.wmflabs.org-linux-firefox/12/ [09:00:00] (03Abandoned) 10Mwalker: Moving stuff over from mw/etx/ocg [services/ocg-collection] (refs/meta/config) - 10https://gerrit.wikimedia.org/r/127173 (owner: 10Mwalker) [09:01:02] (03PS1) 10Hashar: Add timestamp and ansicolor to the console [integration/jenkins-job-builder-config] (cloudbees) - 10https://gerrit.wikimedia.org/r/127215 [09:01:26] Project UploadWizard-api-commons.wikimedia.beta.wmflabs.org build #1: FAILURE in 33 sec: https://integration.wikimedia.org/ci/job/UploadWizard-api-commons.wikimedia.beta.wmflabs.org/1/ [09:01:44] (03PS1) 10Shirayuki: i18n: Fix message key duplication "coll-notitle_title" [extensions/Collection] - 10https://gerrit.wikimedia.org/r/127216 [09:03:31] (03CR) 10Zfilipin: [C: 032] Add timestamp and ansicolor to the console [integration/jenkins-job-builder-config] (cloudbees) - 10https://gerrit.wikimedia.org/r/127215 (owner: 10Hashar) [09:03:51] (03Merged) 10jenkins-bot: Add timestamp and ansicolor to the console [integration/jenkins-job-builder-config] (cloudbees) - 10https://gerrit.wikimedia.org/r/127215 (owner: 10Hashar) [09:04:25] (03PS2) 10Hashar: Run browser tests on the local machine headlessly [integration/jenkins-job-builder-config] (cloudbees) - 10https://gerrit.wikimedia.org/r/127003 (owner: 10Zfilipin) [09:04:46] Project CirrusSearch-en.wikipedia.beta.wmflabs.org-linux-firefox build #13: FAILURE in 3 min 8 sec: https://integration.wikimedia.org/ci/job/CirrusSearch-en.wikipedia.beta.wmflabs.org-linux-firefox/13/ [09:04:49] (03CR) 10Hashar: [C: 032] "Nice catch :)" [integration/jenkins-job-builder-config] (cloudbees) - 10https://gerrit.wikimedia.org/r/127003 (owner: 10Zfilipin) [09:05:08] (03Merged) 10jenkins-bot: Run browser tests on the local machine headlessly [integration/jenkins-job-builder-config] (cloudbees) - 10https://gerrit.wikimedia.org/r/127003 (owner: 10Zfilipin) [09:06:17] Yippee, build fixed! [09:06:17] Project CirrusSearch-en.wikipedia.beta.wmflabs.org-linux-firefox build #14: FIXED in 33 sec: https://integration.wikimedia.org/ci/job/CirrusSearch-en.wikipedia.beta.wmflabs.org-linux-firefox/14/ [09:08:43] (03CR) 10Bartosz Dziewoński: "Thanks for the comments." (032 comments) [core] - 10https://gerrit.wikimedia.org/r/125773 (owner: 10Bartosz Dziewoński) [09:09:04] (03PS1) 10Hashar: Force cucumber to use colors [integration/jenkins-job-builder-config] (cloudbees) - 10https://gerrit.wikimedia.org/r/127217 [09:09:24] (03PS4) 10Bartosz Dziewoński: mwjsduck-gen: Don't fail when running from different directory [core] - 10https://gerrit.wikimedia.org/r/125773 [09:09:30] (03CR) 10Hashar: [C: 032] Force cucumber to use colors [integration/jenkins-job-builder-config] (cloudbees) - 10https://gerrit.wikimedia.org/r/127217 (owner: 10Hashar) [09:10:52] (03Merged) 10jenkins-bot: Force cucumber to use colors [integration/jenkins-job-builder-config] (cloudbees) - 10https://gerrit.wikimedia.org/r/127217 (owner: 10Hashar) [09:11:34] Project CirrusSearch-en.wikipedia.beta.wmflabs.org-linux-firefox build #15: SUCCESS in 2 min 17 sec: https://integration.wikimedia.org/ci/job/CirrusSearch-en.wikipedia.beta.wmflabs.org-linux-firefox/15/ [09:23:07] (03PS1) 10Zfilipin: Deleting all Internet Explorer and Chrome jobs [integration/jenkins-job-builder-config] (cloudbees) - 10https://gerrit.wikimedia.org/r/127219 [09:28:35] Project CirrusSearch-test2.wikipedia.org-linux-firefox build #1: SUCCESS in 43 sec: https://integration.wikimedia.org/ci/job/CirrusSearch-test2.wikipedia.org-linux-firefox/1/ [09:32:30] (03CR) 10Hashar: [C: 032] "Not going to be pushed because we have neither IE nor Chrome on Jenkins labs slaves." [integration/jenkins-job-builder-config] (cloudbees) - 10https://gerrit.wikimedia.org/r/127219 (owner: 10Zfilipin) [09:32:49] (03Merged) 10jenkins-bot: Deleting all Internet Explorer and Chrome jobs [integration/jenkins-job-builder-config] (cloudbees) - 10https://gerrit.wikimedia.org/r/127219 (owner: 10Zfilipin) [09:38:05] (03Abandoned) 10Bartosz Dziewoński: Fixed https mixed content bug. [core] - 10https://gerrit.wikimedia.org/r/125028 (owner: 10Gerrit Patch Uploader) [09:39:10] (03CR) 10Bartosz Dziewoński: [C: 032] Remove #bodyContent { width: 100%; } [core] - 10https://gerrit.wikimedia.org/r/120528 (owner: 10Gerrit Patch Uploader) [09:42:24] (03Merged) 10jenkins-bot: Remove #bodyContent { width: 100%; } [core] - 10https://gerrit.wikimedia.org/r/120528 (owner: 10Gerrit Patch Uploader) [09:43:21] (03PS1) 10Zfilipin: Added "browsertests-" to the beginning of every job [integration/jenkins-job-builder-config] (cloudbees) - 10https://gerrit.wikimedia.org/r/127221 [09:45:34] (03CR) 10Siebrand: [C: 032] i18n: Fix message key duplication "coll-notitle_title" [extensions/Collection] - 10https://gerrit.wikimedia.org/r/127216 (owner: 10Shirayuki) [09:45:50] (03Merged) 10jenkins-bot: i18n: Fix message key duplication "coll-notitle_title" [extensions/Collection] - 10https://gerrit.wikimedia.org/r/127216 (owner: 10Shirayuki) [09:47:30] (03CR) 10Hashar: [C: 032] Added "browsertests-" to the beginning of every job [integration/jenkins-job-builder-config] (cloudbees) - 10https://gerrit.wikimedia.org/r/127221 (owner: 10Zfilipin) [09:47:49] (03Merged) 10jenkins-bot: Added "browsertests-" to the beginning of every job [integration/jenkins-job-builder-config] (cloudbees) - 10https://gerrit.wikimedia.org/r/127221 (owner: 10Zfilipin) [09:48:52] Project browsertests-CirrusSearch-test2.wikipedia.org-linux-firefox build #1: FAILURE in 5.7 sec: https://integration.wikimedia.org/ci/job/browsertests-CirrusSearch-test2.wikipedia.org-linux-firefox/1/ [09:48:54] Project browsertests-CirrusSearch-en.wikipedia.beta.wmflabs.org-linux-firefox build #1: FAILURE in 5.8 sec: https://integration.wikimedia.org/ci/job/browsertests-CirrusSearch-en.wikipedia.beta.wmflabs.org-linux-firefox/1/ [09:49:17] (03CR) 10Siebrand: [C: 031] "L10n reviewed." [extensions/Flow] - 10https://gerrit.wikimedia.org/r/119640 (owner: 10Bsitu) [09:50:10] (03CR) 10Siebrand: [C: 031] "i18n/L10n reviewed." [wikimedia/wikimania-scholarships] - 10https://gerrit.wikimedia.org/r/126833 (owner: 10Kushal124) [09:52:57] (03PS13) 10Bartosz Dziewoński: Respect CheckUser permissions when linking [extensions/CheckUser] - 10https://gerrit.wikimedia.org/r/11562 (owner: 10saper) [09:54:31] (03CR) 10Bartosz Dziewoński: "Rebased, did not test. The conflicts were JSON messages and cleanup commits (761302d0c9e8, 0f9e5c64beb0f, followups)." [extensions/CheckUser] - 10https://gerrit.wikimedia.org/r/11562 (owner: 10saper) [09:55:15] (03CR) 10Siebrand: [C: 031] "L10n changes reviewed." [extensions/BetaFeatures] - 10https://gerrit.wikimedia.org/r/121876 (owner: 10Jforrester) [09:57:28] (03CR) 10Siebrand: [C: 032] Update documentation for $wgExtensionMessagesFiles [core] - 10https://gerrit.wikimedia.org/r/127152 (owner: 10PleaseStand) [09:57:42] (03PS1) 10Siebrand: Update documentation for $wgExtensionMessagesFiles [core] (REL1_23) - 10https://gerrit.wikimedia.org/r/127223 [10:02:02] (03Merged) 10jenkins-bot: Update documentation for $wgExtensionMessagesFiles [core] - 10https://gerrit.wikimedia.org/r/127152 (owner: 10PleaseStand) [10:08:40] (03CR) 10Fomafix: "This patch is superseded by Ife1cf74ca33b4f53ec052947bd8b7b2fd28705ce and If05afc14f7b1ff9b34d2daf293ade6cb6a97493e and can abandoned." (031 comment) [core] - 10https://gerrit.wikimedia.org/r/54896 (owner: 10Rahul21) [10:12:50] (03PS1) 10Zfilipin: Deleted job templates that are no longer used [integration/jenkins-job-builder-config] (cloudbees) - 10https://gerrit.wikimedia.org/r/127225 [10:13:20] (03PS2) 10Zfilipin: Deleted job templates that are no longer used [integration/jenkins-job-builder-config] (cloudbees) - 10https://gerrit.wikimedia.org/r/127225 [10:19:20] (03CR) 10Siebrand: "One possible issue inline. I think that should be callable." (031 comment) [core] - 10https://gerrit.wikimedia.org/r/127151 (owner: 10Umherirrender) [10:20:01] (03CR) 10Zfilipin: [C: 032] Deleted job templates that are no longer used [integration/jenkins-job-builder-config] (cloudbees) - 10https://gerrit.wikimedia.org/r/127225 (owner: 10Zfilipin) [10:20:21] (03Merged) 10jenkins-bot: Deleted job templates that are no longer used [integration/jenkins-job-builder-config] (cloudbees) - 10https://gerrit.wikimedia.org/r/127225 (owner: 10Zfilipin) [10:20:24] (03PS1) 10Zfilipin: Smoke feature needs @firefox tag to run on Wikimedia Jenkins [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/127226 [10:21:16] (03PS7) 10Gerrit Patch Uploader: Rework mediawiki.feedback.js [core] - 10https://gerrit.wikimedia.org/r/105457 [10:21:18] (03CR) 10Gerrit Patch Uploader: "This commit was uploaded using the Gerrit Patch Uploader [1]." [core] - 10https://gerrit.wikimedia.org/r/105457 (owner: 10Gerrit Patch Uploader) [10:26:28] (03CR) 10Siebrand: [C: 031] "i18n/L10n reviewed." [core] - 10https://gerrit.wikimedia.org/r/118113 (owner: 10Anomie) [10:37:25] (03CR) 10Addshore: [C: 032] "Commented inline regarding the callback / callable / Closure" (031 comment) [core] - 10https://gerrit.wikimedia.org/r/127151 (owner: 10Umherirrender) [10:38:14] (03CR) 10Siebrand: [C: 032] Fixed some @params documentation (maintenance) (031 comment) [core] - 10https://gerrit.wikimedia.org/r/127151 (owner: 10Umherirrender) [10:38:36] (03CR) 10Addshore: [C: 031] Update documentation for $wgExtensionMessagesFiles [core] (REL1_23) - 10https://gerrit.wikimedia.org/r/127223 (owner: 10Siebrand) [10:39:49] [= [10:40:50] (03Merged) 10jenkins-bot: Fixed some @params documentation (maintenance) [core] - 10https://gerrit.wikimedia.org/r/127151 (owner: 10Umherirrender) [10:44:51] Project browsertests-Translate-meta.wikimedia.org-linux-firefox build #1: SUCCESS in 1 min 8 sec: https://integration.wikimedia.org/ci/job/browsertests-Translate-meta.wikimedia.org-linux-firefox/1/ [10:49:03] Project browsertests-UniversalLanguageSelector-sandbox.translatewiki.net-linux-firefox build #1: SUCCESS in 1 min 6 sec: https://integration.wikimedia.org/ci/job/browsertests-UniversalLanguageSelector-sandbox.translatewiki.net-linux-firefox/1/ [10:51:24] Project browsertests-TwnMainPage-sandbox.translatewiki.net-linux-firefox build #1: FAILURE in 19 sec: https://integration.wikimedia.org/ci/job/browsertests-TwnMainPage-sandbox.translatewiki.net-linux-firefox/1/ [10:52:32] (03CR) 10KartikMistry: [C: 031] Smoke feature needs @firefox tag to run on Wikimedia Jenkins [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/127226 (owner: 10Zfilipin) [10:55:23] (03PS1) 10Hashar: Make pep8 jobs voting by default [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/127228 [10:56:03] (03CR) 10Hashar: [C: 032] Make pep8 jobs voting by default [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/127228 (owner: 10Hashar) [10:56:10] (03Merged) 10jenkins-bot: Make pep8 jobs voting by default [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/127228 (owner: 10Hashar) [10:58:25] Project browsertests-TwnMainPage-sandbox.translatewiki.net-linux-firefox build #2: STILL FAILING in 1 min 13 sec: https://integration.wikimedia.org/ci/job/browsertests-TwnMainPage-sandbox.translatewiki.net-linux-firefox/2/ [10:58:26] zeljko.filipin: All Selenium tests should run in Firefox [11:10:45] Project browsertests-TwnMainPage-sandbox.translatewiki.net-linux-firefox build #3: STILL FAILING in 5 min 41 sec: https://integration.wikimedia.org/ci/job/browsertests-TwnMainPage-sandbox.translatewiki.net-linux-firefox/3/ [11:18:43] Project browsertests-Translate-sandbox.translatewiki.net-linux-firefox build #1: FAILURE in 1 min 13 sec: https://integration.wikimedia.org/ci/job/browsertests-Translate-sandbox.translatewiki.net-linux-firefox/1/ [11:21:19] (03PS1) 10Hashar: Make pep8 jobs voting by default [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/127229 [11:23:08] (03PS2) 10Hashar: Make pyflakes jobs voting by default [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/127229 [11:23:16] (03CR) 10Hashar: [C: 032] Make pyflakes jobs voting by default [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/127229 (owner: 10Hashar) [11:23:24] (03Merged) 10jenkins-bot: Make pyflakes jobs voting by default [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/127229 (owner: 10Hashar) [11:30:13] Project browsertests-UniversalLanguageSelector-commons.wikimedia.beta.wmflabs.org-linux-firefox build #1: FAILURE in 2 min 2 sec: https://integration.wikimedia.org/ci/job/browsertests-UniversalLanguageSelector-commons.wikimedia.beta.wmflabs.org-linux-firefox/1/ [11:35:08] Project browsertests-Translate-sandbox.translatewiki.net-linux-firefox build #2: STILL FAILING in 14 min: https://integration.wikimedia.org/ci/job/browsertests-Translate-sandbox.translatewiki.net-linux-firefox/2/ [11:44:14] Project browsertests-UniversalLanguageSelector-commons.wikimedia.beta.wmflabs.org-linux-firefox build #2: STILL FAILING in 13 min: https://integration.wikimedia.org/ci/job/browsertests-UniversalLanguageSelector-commons.wikimedia.beta.wmflabs.org-linux-firefox/2/ [12:35:43] (03PS2) 10Hashar: Change messages for integration-zuul-layoutdiff [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/126845 [12:35:55] (03CR) 10jenkins-bot: [V: 04-1] Change messages for integration-zuul-layoutdiff [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/126845 (owner: 10Hashar) [12:37:36] (03PS3) 10Phuedx: Use "article" instead of "page" only on Wikipedia [extensions/GettingStarted] - 10https://gerrit.wikimedia.org/r/127030 [12:37:58] (03CR) 10Phuedx: "> We might want to make the suffix -wikipedia, rather than -article, so it's more future-proof if there is some other Wikipedia-specific v" [extensions/GettingStarted] - 10https://gerrit.wikimedia.org/r/127030 (owner: 10Phuedx) [12:39:45] (03CR) 10Phuedx: Use "article" instead of "page" only on Wikipedia (031 comment) [extensions/GettingStarted] - 10https://gerrit.wikimedia.org/r/127030 (owner: 10Phuedx) [12:48:02] (03PS3) 10Hashar: Change messages for integration-zuul-layoutdiff [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/126845 [12:50:50] (03CR) 10Hashar: [C: 032] Change messages for integration-zuul-layoutdiff [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/126845 (owner: 10Hashar) [12:50:57] (03Merged) 10jenkins-bot: Change messages for integration-zuul-layoutdiff [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/126845 (owner: 10Hashar) [12:52:12] (03CR) 10Manybubbles: [C: 04-1] Add an auxiliary text field [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/127140 (owner: 10Manybubbles) [12:56:41] Nemo_bis: The URL shortener was a Github service :P - http://git.io/ [12:58:27] URL shorteners are the devil [12:58:49] Nemo_bis: But both links would be equally ephemeral… [12:58:59] Nemo_bis: It only shortens github urls [12:59:35] I don't claim to be NPOV on this :) http://archiveteam.org/index.php?title=URLTeam [13:10:13] (03PS5) 10Hashar: 'recheck' by whitelisted users now runs tests [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/126838 [13:11:52] (03CR) 10Hashar: [C: 032] "Checked locally, sounds good." [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/126838 (owner: 10Hashar) [13:11:59] (03Merged) 10jenkins-bot: 'recheck' by whitelisted users now runs tests [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/126838 (owner: 10Hashar) [13:21:08] Nemo_bis: I'm not a fan of adding an extra tracking layer that obfuscates the url either [13:23:20] (03PS1) 10Manybubbles: Make HtmlFormatter return removed elements [core] - 10https://gerrit.wikimedia.org/r/127238 [13:23:55] (03PS6) 10Manybubbles: Add an auxiliary text field [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/127140 [13:24:14] (03CR) 10Manybubbles: "-1 until dependency is merged." [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/127140 (owner: 10Manybubbles) [13:30:05] (03PS1) 10Manybubbles: Always install php5-tidy [vagrant] - 10https://gerrit.wikimedia.org/r/127242 [13:31:38] (03PS2) 10Anomie: Make API action=rsd work on private wikis [core] - 10https://gerrit.wikimedia.org/r/127208 (owner: 10Daniel Friesen) [13:31:50] (03CR) 10Anomie: [C: 032] Make API action=rsd work on private wikis [core] - 10https://gerrit.wikimedia.org/r/127208 (owner: 10Daniel Friesen) [13:33:11] (03CR) 10Manybubbles: [C: 032] Smoke feature needs @firefox tag to run on Wikimedia Jenkins [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/127226 (owner: 10Zfilipin) [13:34:15] (03Merged) 10jenkins-bot: Smoke feature needs @firefox tag to run on Wikimedia Jenkins [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/127226 (owner: 10Zfilipin) [13:35:49] Project browsertests-CirrusSearch-en.wikipedia.beta.wmflabs.org-linux-firefox build #2: STILL FAILING in 52 sec: https://integration.wikimedia.org/ci/job/browsertests-CirrusSearch-en.wikipedia.beta.wmflabs.org-linux-firefox/2/ [13:35:50] zeljko.filipin: Smoke feature needs @firefox tag to run on Wikimedia Jenkins [13:35:53] Project browsertests-CirrusSearch-test2.wikipedia.org-linux-firefox build #2: STILL FAILING in 48 sec: https://integration.wikimedia.org/ci/job/browsertests-CirrusSearch-test2.wikipedia.org-linux-firefox/2/ [13:35:54] zeljko.filipin: Smoke feature needs @firefox tag to run on Wikimedia Jenkins [13:36:47] (03Merged) 10jenkins-bot: Make API action=rsd work on private wikis [core] - 10https://gerrit.wikimedia.org/r/127208 (owner: 10Daniel Friesen) [13:41:15] Project browsertests-CirrusSearch-en.wikipedia.beta.wmflabs.org-linux-firefox build #3: STILL FAILING in 39 sec: https://integration.wikimedia.org/ci/job/browsertests-CirrusSearch-en.wikipedia.beta.wmflabs.org-linux-firefox/3/ [13:42:16] Project browsertests-CirrusSearch-test2.wikipedia.org-linux-firefox build #3: STILL FAILING in 1 min 37 sec: https://integration.wikimedia.org/ci/job/browsertests-CirrusSearch-test2.wikipedia.org-linux-firefox/3/ [13:44:40] Yippee, build fixed! [13:44:41] Project browsertests-CirrusSearch-test2.wikipedia.org-linux-firefox build #4: FIXED in 38 sec: https://integration.wikimedia.org/ci/job/browsertests-CirrusSearch-test2.wikipedia.org-linux-firefox/4/ [13:46:54] Yippee, build fixed! [13:46:55] Project browsertests-CirrusSearch-en.wikipedia.beta.wmflabs.org-linux-firefox build #4: FIXED in 32 sec: https://integration.wikimedia.org/ci/job/browsertests-CirrusSearch-en.wikipedia.beta.wmflabs.org-linux-firefox/4/ [13:50:29] (03PS1) 10Amire80: Cleanup whitespace and comments [services/cxserver] - 10https://gerrit.wikimedia.org/r/127243 [13:55:39] (03PS4) 10Umherirrender: Fixed some @params documentation (includes/api) [core] - 10https://gerrit.wikimedia.org/r/126034 [13:57:54] (03CR) 10KartikMistry: [C: 032] Cleanup whitespace and comments [services/cxserver] - 10https://gerrit.wikimedia.org/r/127243 (owner: 10Amire80) [13:58:26] (03Merged) 10jenkins-bot: Cleanup whitespace and comments [services/cxserver] - 10https://gerrit.wikimedia.org/r/127243 (owner: 10Amire80) [14:24:11] (03CR) 10Manybubbles: [C: 031] "This works for me." [vagrant] - 10https://gerrit.wikimedia.org/r/121425 (owner: 10BryanDavis) [14:24:25] (03CR) 10Manybubbles: ".yaml, or whatever it is normally." [vagrant] - 10https://gerrit.wikimedia.org/r/121425 (owner: 10BryanDavis) [14:30:13] (03CR) 10Anomie: [C: 04-1] "I note this probably goes hand in hand with I8cdf7c43." (031 comment) [extensions/Scribunto] - 10https://gerrit.wikimedia.org/r/127161 (owner: 10Jackmcbarn) [14:31:10] anomie: when i try the code without my typo, it doesn't count as expensive [14:33:24] jackmcbarn: This still dies with a "too many expensive function calls" error for me: frame = mw.getCurrentFrame(); for i = 0, 1000 do pcall( frame.expandTemplate, frame, { title = "foo" .. i } ); mw.title.new( "foo" .. i ); end [14:35:40] anomie: you're missing a : before Foo in the expandTemplate call [14:35:48] you're expanding Template:Foo but checking Foo for existence [14:36:14] jackmcbarn: Doesn't make a difference [14:36:29] (03PS1) 10Bartosz Dziewoński: vector: Do styles the ResourceLoader way [core] - 10https://gerrit.wikimedia.org/r/127248 [14:42:47] (03CR) 10jenkins-bot: [V: 04-1] vector: Do styles the ResourceLoader way [core] - 10https://gerrit.wikimedia.org/r/127248 (owner: 10Bartosz Dziewoński) [14:43:52] (03CR) 10Anomie: [C: 032] Simplify SpecialVersion:listToText() [core] - 10https://gerrit.wikimedia.org/r/127115 (owner: 10Reedy) [14:44:03] anomie: yesterday i did something in lua (which i unfortunately didn't save) that got a title object for a different page without incrementing the expensive count [14:44:03] in any case, though, you can still text existence by pcall'ing the expandTemplate function and just looking at success of that [14:44:53] (03PS1) 10Bartosz Dziewoński: WebInstallerOutput: Fix path to jquery.js [core] - 10https://gerrit.wikimedia.org/r/127249 [14:45:10] (03Abandoned) 10Anomie: Fix PHP Notice on Special:Version with Scribunto enabled [extensions/Scribunto] - 10https://gerrit.wikimedia.org/r/127031 (owner: 10Reedy) [14:45:32] (03CR) 10Bartosz Dziewoński: "Follow-up: If40f479d." [core] - 10https://gerrit.wikimedia.org/r/123782 (owner: 10Jforrester) [14:45:34] (03CR) 10Bartosz Dziewoński: "Follow-up: If40f479d." [core] - 10https://gerrit.wikimedia.org/r/124821 (owner: 10Gerrit Patch Uploader) [14:45:55] anyone here? the installer is broken. [14:46:57] anomie: wanna look? [14:47:43] jackmcbarn: Yeah, which is why I commented that it goes hand in hand with your similar change to ParserFunctions. Both of which I'll defer to others on, as IIRC "expensive parser functions" were added explicitly because of #ifexists. [14:48:11] (03Merged) 10jenkins-bot: Simplify SpecialVersion:listToText() [core] - 10https://gerrit.wikimedia.org/r/127115 (owner: 10Reedy) [14:48:25] MatmaRex: I don't really know anything about the installer, but I can take a quick look if no one else is interested after SF has a chance to wake up. [14:48:50] i can just self-merge i guess, it's a trivial three-character change [14:48:58] (03CR) 10Jackmcbarn: Don't count loading titles as expensive (031 comment) [extensions/Scribunto] - 10https://gerrit.wikimedia.org/r/127161 (owner: 10Jackmcbarn) [14:49:01] doesn't work before, does work after [14:49:32] MatmaRex: I recommend against self-merges for actual code. [14:49:47] Even if they are trivial. [14:50:30] so do i, but this affects 1.23 too and i'd rather not have broken release candidates [14:51:35] anomie: do you have any idea what i might have done yesterday to get a title object without incrementing the count? [14:52:36] jackmcbarn: Called mw.title.new twice for the same title? [14:52:46] The second one doesn't increment the count. [14:52:59] anomie: i got a total of 0 for the whole page [14:53:04] (and i didn't call it on the same page i was on) [14:54:17] (03CR) 10Anomie: Don't count loading titles as expensive (031 comment) [extensions/Scribunto] - 10https://gerrit.wikimedia.org/r/127161 (owner: 10Jackmcbarn) [14:55:43] jackmcbarn: Accidentally used an invalid title? [14:56:32] i doubt it. i know i had something working, because i had a line above the call to mw.title.new. when i commented it out, i got 1 expensive parser function all, and when i uncommented it, i got 0 [14:57:26] (03PS2) 10Bartosz Dziewoński: WebInstallerOutput: Fix path to jquery.js [core] - 10https://gerrit.wikimedia.org/r/127249 [14:58:18] anomie: btw, i found another way to smuggle state between #invoke's [14:58:34] jackmcbarn: The only code paths I see that would result in mw.title.new not incrementing the expensive count are passing numeric 0, passing the id or title of the current page, passing an invalid title, passing an id or title you already fetched via mw.title.new or mw.title.makeSafe, or the old message object hacks. [14:58:38] jackmcbarn: Ugh. What now? [14:58:46] frame:preprocess('{{#invoke:some invalid module|that will throw an error}}') and look at the id of the script error element [14:58:53] it goes up by 1 for every error on the page [15:00:43] (using a slightly different string to preprocess in the 'setter' from the 'getter' to avoid caching) [15:01:30] (03PS2) 10Bartosz Dziewoński: vector: Do styles the ResourceLoader way [core] - 10https://gerrit.wikimedia.org/r/127248 [15:02:33] jackmcbarn: Super ugh, but I think easy to fix. Filed a bug already? [15:02:50] anomie: not yet. i think a fix for that would be, instead of using id's and then setting error data from javascript based on the id, embed the error data in a data-scribunto attribute or something [15:03:19] jackmcbarn: My plan is simpler: just use a random number for the error index. [15:03:51] Although I might turn out to like your data idea better [15:03:53] anomie: if you give me non-deterministic input, i can tell you 5 more ways to smuggle state [15:04:14] jackmcbarn: Oh? How so? [15:06:20] anomie: actually, that idea wouldn't work, but i just thought of yet another way [15:06:36] (03PS1) 10Hashar: Attempt to fix recheck for whitelisted user on 'test' [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/127252 [15:07:04] (03CR) 10Hashar: [C: 032] Attempt to fix recheck for whitelisted user on 'test' [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/127252 (owner: 10Hashar) [15:07:11] (03Merged) 10jenkins-bot: Attempt to fix recheck for whitelisted user on 'test' [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/127252 (owner: 10Hashar) [15:07:14] (03CR) 10jenkins-bot: [V: 04-1] vector: Do styles the ResourceLoader way [core] - 10https://gerrit.wikimedia.org/r/127248 (owner: 10Bartosz Dziewoński) [15:07:15] anomie: build some kind of horrible template that takes a long time to expand. look at the time before and after expanding it, and you'll know if it was expanded before [15:09:05] (alternatively, mw.loadData a module that runs for a long time before returning a value and do the same) [15:09:10] jackmcbarn: I'm inclined not to worry about methods that rely on "make the page really slow to load" [15:09:51] actually, you might not have to [15:10:15] * jackmcbarn builds an example [15:10:40] (03PS1) 10Bartosz Dziewoński: Test: Delete skins/vector/styles.less to see if LESS tests fail [core] - 10https://gerrit.wikimedia.org/r/127253 [15:11:04] (03CR) 10Hashar: "Original intent fixed up with https://gerrit.wikimedia.org/r/#/c/127252/" [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/126838 (owner: 10Hashar) [15:11:22] (03CR) 10Bartosz Dziewoński: [C: 04-2] Test: Delete skins/vector/styles.less to see if LESS tests fail [core] - 10https://gerrit.wikimedia.org/r/127253 (owner: 10Bartosz Dziewoński) [15:17:11] (03PS5) 10BryanDavis: Enable customization of Vagrant and virtual machine [vagrant] - 10https://gerrit.wikimedia.org/r/121425 [15:18:11] jackmcbarn: So did the 5 ways to pass state with a random number in the error id not pan out? [15:18:27] anomie: they relied on something that was already fixed [15:18:46] (03Abandoned) 10Bartosz Dziewoński: Test: Delete skins/vector/styles.less to see if LESS tests fail [core] - 10https://gerrit.wikimedia.org/r/127253 (owner: 10Bartosz Dziewoński) [15:19:13] jackmcbarn: Using a data property would allow faking up an error element in wikitext with malicious HTML in the data property [15:19:14] (03CR) 10Bartosz Dziewoński: "I have no idea why the tests are failing, but I don't see how it could be related to this patch…" [core] - 10https://gerrit.wikimedia.org/r/127248 (owner: 10Bartosz Dziewoński) [15:19:41] anomie: maybe do the escaping in the javascript instead of serverside then [15:20:26] anomie: also, see https://en.wikipedia.org/wiki/Module:Sandbox/Jackmcbarn , it doesn't have to take much time at all [15:22:16] Project browsertests-VisualEditor-en.wikipedia.beta.wmflabs.org-linux-firefox build #1: FAILURE in 39 sec: https://integration.wikimedia.org/ci/job/browsertests-VisualEditor-en.wikipedia.beta.wmflabs.org-linux-firefox/1/ [15:23:02] jackmcbarn: Can't really do the escaping in JS, see Scribunto_LuaError::getScriptTraceHtml [15:23:54] (03PS2) 10Chad: Remove 2 unused Special:Search hooks [core] - 10https://gerrit.wikimedia.org/r/126831 [15:24:27] anomie: maybe put the backtrace in a machine-readable format and let the js build the html? [15:24:39] (03CR) 10Chad: "PS2 was just a rebase." [core] - 10https://gerrit.wikimedia.org/r/126831 (owner: 10Chad) [15:25:51] <^d> We have way too many freaking hooks in Special:Search [15:31:35] (03CR) 10Siebrand: [C: 032] WebInstallerOutput: Fix path to jquery.js [core] - 10https://gerrit.wikimedia.org/r/127249 (owner: 10Bartosz Dziewoński) [15:31:52] (03PS3) 10Siebrand: WebInstallerOutput: Fix path to jquery.js [core] - 10https://gerrit.wikimedia.org/r/127249 (owner: 10Bartosz Dziewoński) [15:32:12] (03PS1) 10Siebrand: WebInstallerOutput: Fix path to jquery.js [core] (REL1_23) - 10https://gerrit.wikimedia.org/r/127257 [15:34:06] anomie: did you ever get a chance to look at https://gerrit.wikimedia.org/r/#/c/123671/ or https://gerrit.wikimedia.org/r/#/c/124620/ ? [15:34:25] (03PS1) 10Hashar: Code review by whitelisted users should triggers tests [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/127259 [15:34:52] (03PS6) 10BryanDavis: Enable customization of Vagrant and virtual machine [vagrant] - 10https://gerrit.wikimedia.org/r/121425 [15:34:56] (03CR) 10Hashar: [C: 04-2] "Do not submit. Zuul does not support it yet." [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/127259 (owner: 10Hashar) [15:41:17] Project browsertests-VisualEditor-en.wikipedia.beta.wmflabs.org-linux-firefox build #2: ABORTED in 3 min 1 sec: https://integration.wikimedia.org/ci/job/browsertests-VisualEditor-en.wikipedia.beta.wmflabs.org-linux-firefox/2/ [15:41:17] zeljko.filipin: [browser test] Run all Selenium tests in Firefox [15:41:43] (03CR) 10BryanDavis: Enable customization of Vagrant and virtual machine (032 comments) [vagrant] - 10https://gerrit.wikimedia.org/r/121425 (owner: 10BryanDavis) [15:41:46] (03PS7) 10BryanDavis: Enable customization of Vagrant and virtual machine [vagrant] - 10https://gerrit.wikimedia.org/r/121425 [15:46:25] (03PS8) 10Manybubbles: Enable customization of Vagrant and virtual machine [vagrant] - 10https://gerrit.wikimedia.org/r/121425 (owner: 10BryanDavis) [15:48:13] manybubbles: Thanks for the fix, but I think you snuck an extra file in there "Vagrant-extra.rb.old" [15:48:20] (03PS6) 10Phuedx: [WIP] Add a pre-edit anonymous signup invitation [extensions/GettingStarted] - 10https://gerrit.wikimedia.org/r/125730 [15:48:30] bd808: sorry [15:48:35] no worries [15:48:43] unsnuck [15:48:44] (03PS9) 10Manybubbles: Enable customization of Vagrant and virtual machine [vagrant] - 10https://gerrit.wikimedia.org/r/121425 (owner: 10BryanDavis) [15:49:04] Sweet. I'm done fscking with that by the way :) [15:49:22] Project browsertests-VisualEditor-en.wikipedia.beta.wmflabs.org-linux-firefox build #3: ABORTED in 8 min 6 sec: https://integration.wikimedia.org/ci/job/browsertests-VisualEditor-en.wikipedia.beta.wmflabs.org-linux-firefox/3/ [15:49:26] bd808: why the comment on ruby1.8? [15:49:35] my vagrant comes with ruby 2.0 [15:51:10] Ruby 1.9+ is supposed to have consistent ordering, but ... I'm running 1.9.3p392 and it doesn't. [15:51:20] * bd808 shurgs [15:51:35] * bd808 shrugs and shurgs [15:51:41] Project browsertests-VisualEditor-en.wikipedia.beta.wmflabs.org-linux-firefox build #4: ABORTED in 2 min 14 sec: https://integration.wikimedia.org/ci/job/browsertests-VisualEditor-en.wikipedia.beta.wmflabs.org-linux-firefox/4/ [15:52:27] I assumed I was running 1.8.something based on what I saw on stackoverflow [15:53:03] * bd808 codes ruby by cut-n-paste [15:54:20] (03PS1) 10Amire80: Cleanup SpecialAllmessages.php according to conventions [core] - 10https://gerrit.wikimedia.org/r/127266 [15:56:47] (03CR) 10Jforrester: [C: 032] WebInstallerOutput: Fix path to jquery.js [core] (REL1_23) - 10https://gerrit.wikimedia.org/r/127257 (owner: 10Siebrand) [15:59:46] (03Merged) 10jenkins-bot: WebInstallerOutput: Fix path to jquery.js [core] (REL1_23) - 10https://gerrit.wikimedia.org/r/127257 (owner: 10Siebrand) [16:08:54] (03PS2) 10Amire80: Cleanup SpecialAllmessages.php according to conventions [core] - 10https://gerrit.wikimedia.org/r/127266 [16:11:04] (03CR) 10Addshore: [C: 032] Cleanup SpecialAllmessages.php according to conventions [core] - 10https://gerrit.wikimedia.org/r/127266 (owner: 10Amire80) [16:14:04] (03Merged) 10jenkins-bot: Cleanup SpecialAllmessages.php according to conventions [core] - 10https://gerrit.wikimedia.org/r/127266 (owner: 10Amire80) [16:16:47] Yeah, who actually *learns* Ruby? [16:17:58] (03CR) 10QChris: Code review by whitelisted users should triggers tests (031 comment) [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/127259 (owner: 10Hashar) [16:20:12] guillom, hi, can you give admin permissions to fab.wmflabs.org ? I want to become admin, if only to see what options are available [16:20:29] (03CR) 10Aaron Schulz: [C: 032] Remove 2 unused Special:Search hooks [core] - 10https://gerrit.wikimedia.org/r/126831 (owner: 10Chad) [16:20:50] or bd808 ^^^^ [16:21:20] qgil: I probably can... let's try [16:22:25] qgil: {{done}} I think [16:22:39] bd808, let's see [16:23:27] bd808, yep, I see an "Administration" section in the sidebar. Thank you! [16:23:37] This part of the phabricator UI is kind of clunky. The left nav column ends up holding important links and my brain automatically ignores nav columns [16:23:45] (03Merged) 10jenkins-bot: Remove 2 unused Special:Search hooks [core] - 10https://gerrit.wikimedia.org/r/126831 (owner: 10Chad) [16:23:56] (03CR) 10Hashar: Code review by whitelisted users should triggers tests (031 comment) [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/127259 (owner: 10Hashar) [16:24:22] bd808, indeed, and this is why I'm becoming a friend of http://fab.wmflabs.org/settings/panel/home/ [16:26:13] * marktraceur logs in, sees weeks-old messages [16:26:14] Crap [16:26:26] Hey, awjr - finally coming back to your comments on http://fab.wmflabs.org/T44 [16:26:55] I think Mingle's concepts of "iteration" and other scheduling is just a fancy way of naming card types. [16:27:16] So you should be able to just file a tracking ticket, then make children cards of it be the iteration's tasks [16:27:30] Unless I'm missing something super-specific about iterations that I never knew about Mingle [16:27:50] (same with releases) [16:51:33] What wikis on beta use both VE and FR? [17:02:23] Yippee, build fixed! [17:02:24] Project browsertests-VisualEditor-en.wikipedia.beta.wmflabs.org-linux-firefox build #6: FIXED in 20 min: https://integration.wikimedia.org/ci/job/browsertests-VisualEditor-en.wikipedia.beta.wmflabs.org-linux-firefox/6/ [17:04:55] (03PS1) 10Umherirrender: Remove superfluous # at end of line from languages.inc [core] - 10https://gerrit.wikimedia.org/r/127274 [17:13:21] (03PS1) 10Umherirrender: Remove # from dataProvider [core] - 10https://gerrit.wikimedia.org/r/127276 [17:19:53] Krenair: Maybe a Wikibooks? [17:20:20] Wishful thinking maybe [17:26:02] marktraceur, meh, forgot my password, tried to reset, get an error page when trying to log in with the temp password [17:26:08] (Cannot contact the database server: Unknown database 'cswiki' (10.68.16.193)) [17:26:12] Hah [17:26:36] could try setting it with a maintenance script or something I guess [17:28:35] OK [17:28:44] How in the eff do I get to the wall in Phabricator [17:28:55] Every time I go to the site I want to get to the wall but I never can find the right link [17:29:14] AHA [17:29:17] It's in the project page. [17:30:22] meh, User::setPassword fails with that same DB error [17:32:38] marktraceur: remember to file a bug before you get used to the new interface and forget all the problems it originally caused you ;) [17:36:30] Nemo_bis: I mean, that makes sense, but is not intuitive if you're thinking that the workboards are an app [17:39:16] (03PS2) 10Ssmith: most things fixed from preceding comments. still need to fix map. pushing for review in interim to get working copy. [extensions/FundraisingChart] - 10https://gerrit.wikimedia.org/r/124774 [17:39:19] marktraceur: file file file [17:39:22] (03CR) 10jenkins-bot: [V: 04-1] most things fixed from preceding comments. still need to fix map. pushing for review in interim to get working copy. [extensions/FundraisingChart] - 10https://gerrit.wikimedia.org/r/124774 (owner: 10Ssmith) [17:39:30] I'm guessing that there is no full time UI/UX person working with the phabricator team. :) Their UI looks like something that a backend programmer would create. [17:41:05] I also don't really mind this particular thing? [17:41:10] bd808: as opposed to gerrit ;-) [17:41:15] (03CR) 10Krinkle: Make ResourceLoader minifiers extendable (031 comment) [core] - 10https://gerrit.wikimedia.org/r/74293 (owner: 10MaxSem) [17:42:52] (03PS25) 10Bsitu: Closing & reopening topic [extensions/Flow] - 10https://gerrit.wikimedia.org/r/118399 [17:45:00] chrismcmahon: Yeah :) or a stock bugzilla install or RT or ... [17:48:13] Does anyone know how to access the centralauth database on deployment-prep? [18:01:12] (03CR) 10MaxSem: [C: 032] Always install php5-tidy [vagrant] - 10https://gerrit.wikimedia.org/r/127242 (owner: 10Manybubbles) [18:01:16] (03Merged) 10jenkins-bot: Always install php5-tidy [vagrant] - 10https://gerrit.wikimedia.org/r/127242 (owner: 10Manybubbles) [18:01:32] thanks MaxSem [18:01:41] :) [18:02:33] (03PS1) 10Aaron Schulz: Made runParallelBatches() fully ses the status array on abort [core] - 10https://gerrit.wikimedia.org/r/127279 [18:02:58] marktraceur, fixed that damn error on beta by running a query to unattach my account on wikis which don't exist [18:04:05] (03PS2) 10Aaron Schulz: Made runParallelBatches() fully set the status array on abort [core] - 10https://gerrit.wikimedia.org/r/127279 [18:04:13] ^d: https://gerrit.wikimedia.org/r/#/c/127279/ [18:04:20] Krenair: Yay usability [18:04:54] (03CR) 10Krinkle: [C: 032] mwjsduck-gen: Don't fail when running from different directory [core] - 10https://gerrit.wikimedia.org/r/125773 (owner: 10Bartosz Dziewoński) [18:06:19] brion: is it ok if we talk here about architectural principles stuff? [18:06:27] sure [18:07:41] brion: So: you probably already know that I'll update https://www.mediawiki.org/wiki/Architecture_guidelines and also sort of make TL;DR cheat sheets, a poster, and a tutorial [18:07:48] woot [18:07:56] Project browsertests-UniversalLanguageSelector-sandbox.translatewiki.net-linux-firefox build #2: SUCCESS in 1 min 2 sec: https://integration.wikimedia.org/ci/job/browsertests-UniversalLanguageSelector-sandbox.translatewiki.net-linux-firefox/2/ [18:08:01] Sigh [18:08:20] brion: Currently I have sort of a set of values that seem like "yes, we are doing this right now" and a set that are more aspirational [18:08:30] and I wanted to get your take on what's what [18:08:35] (03Merged) 10jenkins-bot: mwjsduck-gen: Don't fail when running from different directory [core] - 10https://gerrit.wikimedia.org/r/125773 (owner: 10Bartosz Dziewoński) [18:08:35] heh :) [18:09:22] brion: so, here are the ~7 values that I think we have right now, divided up in a way that may change [18:09:38] * incremental change/backwards compat [18:09:38] ** interface changes [18:09:38] ** We value the time of our 3rd-party users [18:09:38] * YAGNI: inventorying current abstractions before adding more complexity [18:09:38] * data-driven change - do your homework, including "ok, how did we do?" [18:09:38] * secure [18:09:40] * performant [18:09:42] * multilingual (Chad's example about "will you need to do this on multiple wikis") [18:09:44] * pluggable and composable [18:09:46] ** Separation of concerns � UI and business logic [18:09:48] ** Separation of concerns � encapsulation versus value objects [18:10:13] all good sounding things [18:10:25] Descriptive vs prescriptive? [18:10:25] Questions: [18:10:25] * tests - prescriptiveish [18:10:25] * SOA - let's see [18:10:25] * dependency injection vs just-in-time (maybe part of how we do object design in encapsulation) [18:10:26] we might also want to consider antipatterns like NIH syndrome [18:10:47] that's "national institute of health", for those of you who don't know [18:10:56] is that sort of in "inventorying current abstractions before adding more complexity" .... inventorying existing options [18:10:57] heh [18:11:14] *nod* existing options may niclude third-party projects [18:11:19] (03CR) 10Chad: [C: 032] Made runParallelBatches() fully set the status array on abort [core] - 10https://gerrit.wikimedia.org/r/127279 (owner: 10Aaron Schulz) [18:11:23] * sumanah listens for more thoughts from brion  [18:11:27] on other values or combinations [18:11:28] just kidding, it's "not invented here" (i.e., the tendency programmers sometimes have to want to reinvent the wheel rather than to use readymade, battle-tested third-party components) [18:11:29] we have a bad history of tossing existing libraries out and making our own because they’re awkward or look scary :) [18:11:36] examples of good/bad case studies here? [18:12:20] some more positive examples include adoption of ogg code from a PEAR library [18:12:27] which we had to jump some hoops around [18:12:34] to make work but it did in the end [18:12:45] we also occasionly happen to t not use any kind of library and just ad-hoc'ing things into existance, but i've rather optimistic that there is progress on that front lately [18:12:47] we still don’t have a standard third-party mailer component though weh ave an optional one [18:13:11] and of course we have our own http wrapper that uses one of a couple of abstractions, but that’s not the end of the world :D [18:13:17] <^d> Well PEAR_Mail is only good for SMTP, right? [18:13:34] ^d: there’s non-SMTP mail? [18:13:36] like UUCP? [18:13:57] <^d> MW defaults would fall back to mail() and sendmail. [18:14:06] right, and sendmail talks SMTP :) [18:14:10] it’s all just interfaces to SMTP [18:14:25] brion: which http wrapper is that? [18:14:28] ( and of course we have our own http wrapper that uses one of a couple of abstractions, but that�s not the end of the world :D) [18:14:33] <^d> Also, I'll note that the HttpFunctions wasn't so much designed as an Http abstraction and more grew into one. A *long* time ago all it did was just dumbly fetch content and return it as a string. [18:14:36] (03Merged) 10jenkins-bot: Made runParallelBatches() fully set the status array on abort [core] - 10https://gerrit.wikimedia.org/r/127279 (owner: 10Aaron Schulz) [18:14:45] <^d> Then people added to it :) [18:14:53] ^d: true [18:15:03] sumanah: Http class in HttpFunctions.php [18:15:07] Ah, thank you. [18:15:18] * ebernhardson loves the error reporting from the Http class ;) [18:15:20] In http://aosabook.org/en/mailman.html there's an interesting bit about what their overriding concerns are: [18:15:22] yeah it did start out pretty simple and grew [18:15:23] "In the early Mailman 1 days, we had a lot of problems with messages getting lost, or bugs causing messages to be re-delivered over and over again. This prompted us to articulate two overriding principles that are critical to Mailman's ongoing success: [18:15:23] No message should ever be lost. [18:15:23] No message should ever be delivered more than once." [18:15:36] that’s sometimes a code smell, but iirc its api evolved reasonably well [18:15:37] now, you can argue as to whether they are achieving those goals [18:15:52] but they have them. I'm wondering whether we have similar key "never/always" rules to articulate [18:16:03] marktraceur, ffs. I thought I had fixed it, but I get the error when logging in [18:16:05] ooh that’s not a bad idea [18:16:07] Yes. [18:16:20] ‘never lose data destructively’ (unless you really need to) [18:16:21] 1) Never mame Brion unhappy or he kills a server kitten. [18:16:26] make [18:16:28] ‘audit logs for everything’ [18:16:39] ‘make it easy to use’ [18:16:39] Privacy. [18:16:47] <^d> ponies! [18:16:51] privacy within certain limits [18:17:02] A couple of us have been working on https://www.mediawiki.org/wiki/Principles [18:17:04] (for instance we expose IP addresses of non-logged-in users which is awful from a modern privacy perspective ;) [18:17:09] (this is part of "security" - https://www.mediawiki.org/wiki/Security_for_developers/Architecture#What_are_we_trying_to_protect.3F ) [18:17:22] It's from a user perspective though, not quite backend [18:17:24] ^d: ponies are on labs. and they are actually unicorns. [18:17:41] indeed; lies, all lies, about ponies [18:17:42] <^d> I like the [[Principles]] page though. [18:17:49] <^d> And they're good guiding principles. [18:17:55] <^d> Especially the ones under 1, 2 and 3. [18:18:29] Hmm. I could nitpick but I see the point of [[Principles]]. [18:19:01] brion: so I should also articulate the audiences I see for the architecture doc/poster/tutorial. I see ~4, all of the type "people who want to make big changes" [18:19:14] *nod* [18:19:36] 1. new WMF developer - needs to understand this as context to understand existing infrastructure, and possibly for planning to make her first big change [18:20:03] 2. seasoned Wikimedia developer, probably at WMF - can use this as a checklist/something to point at when planning and championing a change [18:20:38] Project browsertests-TwnMainPage-sandbox.translatewiki.net-linux-firefox build #4: STILL FAILING in 5 min 44 sec: https://integration.wikimedia.org/ci/job/browsertests-TwnMainPage-sandbox.translatewiki.net-linux-firefox/4/ [18:20:54] 3. newer volunteer developer - needs to understand this to understand what kinds of changes are more possible or less plausible, and how to advocate for them [18:21:34] 4. extreme newbie with a giant new idea he's enthusiastic about, that we need to gently reject with "that won't work for us" - needs to see why we are rejecting it [18:22:00] Where is the exception log on deployment-prep? [18:22:15] *nod* i like the idea of it as a scoping tool [18:22:24] what’s possible, what’s “really hard” :) [18:22:28] Krenair: /data/project/logs or /data/logs/project or something like that [18:22:29] what kind of changes are actually effectable [18:22:33] brion: I am happy to futz with these categories, but especially 1, 3, and 4 are why "we always do this, we never do that" can be helpful [18:22:37] wikitech says it's in /data/project/logs but it's not [18:23:16] tail: cannot open `/data/project/logs/exception.log' for reading: No such file or directory [18:23:44] Krenair: hm, the demuxer is writing logs to that directory though -- see fatal.log, centralauth.log, etc. [18:23:50] yes [18:23:55] Krenair: so maybe the error log destination for the 'exception' log is not set correctly [18:24:10] brion: ok. So, examples will be super handy here, to help different kinds of people understand. Like, with https://www.mediawiki.org/wiki/Architecture_guidelines#Incremental_change / backwards compatibility, what were times we did this well vs badly? [18:24:43] sumanah: so an example there might be the redoing of the file storage system [18:24:51] most of it was abstracted away so front-end code never had to touch it [18:24:55] Krenair: hm, logging-labs.php:$wgDebugLogGroups['exception-json'] = "udp://$wmfUdp2logDest/exception-json"; [18:25:03] but code that had to actually touch files got updated to use the new storage systems bit by bit [18:25:07] first, primary images and thumbs [18:25:13] then, things like math image generation [18:25:20] Krenair: labs doesn't override InitialiseSettings.php: 'exception' => "udp://$wmfUdp2logDest/exception". that should be correct... [18:26:02] (03CR) 10Trevor Parscal: [C: 032] Simplify VE inspector code by extending new MWLiveExtensionInspector [extensions/Math] - 10https://gerrit.wikimedia.org/r/126901 (owner: 10Jforrester) [18:26:05] sumanah: another example might be the echo notification system, which is being dropped in as a supplementary layer without fully replacing the user talk page notification system [18:26:14] eventually we’ll probably drop the old bits and merge them fully [18:26:20] (03CR) 10Ori.livneh: "Minor quibbles, but overall I'm willing to merge" (035 comments) [tools/scap] - 10https://gerrit.wikimedia.org/r/127199 (owner: 10BryanDavis) [18:26:32] brion: Oh interesting. How are we notifying (ha!) clients of the old system that it is slowly being deprecated? [18:27:05] or when we moved to ResourceLoader; initially some scripts were still loaded in the legacy fashion and we had a fairly long transition period where site scripts and gadgets got fixed up to play better with RL [18:27:13] ah notifying clients…. we’re probably horrible at that ;) [18:27:17] Project browsertests-UniversalLanguageSelector-commons.wikimedia.beta.wmflabs.org-linux-firefox build #3: STILL FAILING in 8 min 23 sec: https://integration.wikimedia.org/ci/job/browsertests-UniversalLanguageSelector-commons.wikimedia.beta.wmflabs.org-linux-firefox/3/ [18:27:21] (03Merged) 10jenkins-bot: Simplify VE inspector code by extending new MWLiveExtensionInspector [extensions/Math] - 10https://gerrit.wikimedia.org/r/126901 (owner: 10Jforrester) [18:27:26] (03PS3) 10Ori.livneh: Improve error message when scap lock fails [tools/scap] - 10https://gerrit.wikimedia.org/r/126924 (owner: 10BryanDavis) [18:28:00] Right. I think that "we are accidentally doing this slowly due to lack of programmer time" may feel similar to "6-month public comment and revision/migration period" but actually is not :/ [18:29:18] lol [18:29:26] there is some accidental overlap in those yes ;) [18:30:31] ori, production has an 'exception' log along with 'exception-json' [18:30:49] So brion I wanted to get your take on the "aspirational????" descriptive vs prescriptive bits [18:31:07] because I think it is fine to have a section in Arch guidelines saying "and we WANT to be like THIS but are not there yet" [18:31:58] so when we promote aspirational goals, there’s an implicit promise to support people working towards those goals [18:32:05] as long as we can provide that support then great :D [18:32:17] you make a strong point there [18:32:22] hmmm [18:33:03] So maybe tests/testability are the most likely thing to put in here [18:33:19] (03CR) 10Helder.wiki: [C: 031] WebInstallerOutput: Fix path to jquery.js [core] - 10https://gerrit.wikimedia.org/r/127249 (owner: 10Bartosz Dziewoński) [18:34:04] value: "we value having ways to systematically reason about the correctness of our code" [18:34:13] *nod* that’s a good one [18:34:19] promotes clean, well-factored code as well [18:34:44] cf tim’s recent post about quality of buffer code in various ssl libraries — readability and being able to reason about the code is important to review and security and maintenance [18:35:52] ori, ok, gave up trying to find the exception details and made the fix I suspected would work. I can at least log into the site now [18:36:27] (03CR) 10Ori.livneh: [C: 04-1] Improve error message when scap lock fails (031 comment) [tools/scap] - 10https://gerrit.wikimedia.org/r/126924 (owner: 10BryanDavis) [18:36:48] Project browsertests-VisualEditor-en.wikipedia.beta.wmflabs.org-linux-firefox build #7: FAILURE in 23 min: https://integration.wikimedia.org/ci/job/browsertests-VisualEditor-en.wikipedia.beta.wmflabs.org-linux-firefox/7/ [18:37:32] Project browsertests-CirrusSearch-test2.wikipedia.org-linux-firefox build #5: SUCCESS in 38 sec: https://integration.wikimedia.org/ci/job/browsertests-CirrusSearch-test2.wikipedia.org-linux-firefox/5/ [18:37:53] brion: can you link to that post by Tim? I may have missed it [18:38:03] lemme find it, i think it was on his blog [18:38:17] sumanah: http://tstarling.com/blog/2014/04/ssl-implementations-compared/ [18:38:20] (03PS1) 10Aaron Schulz: Bail out on FileBackend operations if the initial stat calls failed [core] - 10https://gerrit.wikimedia.org/r/127283 [18:38:31] mostly looking at buffer bounds checks in that particular case [18:38:46] but there are many classes of errors where clean code makes aworld of difference to spotting errors in review [18:39:04] * sumanah thinks about goto fail; [18:39:12] Krenair: if it's not too much trouble, can you file a bug for the missing exception log? [18:39:45] ^d: another one of these: https://gerrit.wikimedia.org/r/#/c/127283/ [18:39:50] 10 PRINT “PROGRAMMING IS HARD” [18:39:51] 20 GOTO 10 [18:40:14] i do *not* miss line numbers in basic [18:40:35] ori, https://bugzilla.wikimedia.org/show_bug.cgi?id=64100 [18:40:51] Krenair: danke [18:41:08] PROGRAMMING IS HARD [18:41:13] PROGRAMMING IS HARD [18:41:53] I recently posted: http://www.harihareswara.net/sumana/2014/04/06/0 "Yes, It Sucks And Is Not Your Fault" where the very first bullet point is " this is indeed hard; it's not your fault if you have trouble" [18:42:11] (03CR) 10Spage: [C: 032] "Thanks Jon!" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/125907 (owner: 10Jdlrobson) [18:42:17] whoops closed wrong window [18:43:10] (03Merged) 10jenkins-bot: Separate style modules from JS modules [extensions/Flow] - 10https://gerrit.wikimedia.org/r/125907 (owner: 10Jdlrobson) [18:43:11] brion: it is ok :-) so, I would love more examples of when we have done well vs badly on a few of these principles, specifically on pluggability/composability/extensibility [18:43:28] ah, good question [18:43:38] we’ve had mixed results with pluggable interfaces [18:43:55] the main being extension hooks [18:44:04] the actual hook mechanism is fantastic and very flexible [18:44:18] but often the hook positioning and paraemters are too low-level and it turns out to be hard to adapt them over time [18:44:28] (03CR) 10jenkins-bot: [V: 04-1] Bail out on FileBackend operations if the initial stat calls failed [core] - 10https://gerrit.wikimedia.org/r/127283 (owner: 10Aaron Schulz) [18:44:44] other things like media type handler classes seem to have worked pretty well [18:45:05] <^d> Hooks *or* pluggable polymorphic things. [18:45:06] though we will see how that fares when media people try to add things like 3d modeling :D [18:45:07] <^d> Never both [18:45:13] * ^d was just complaining to AaronSchulz about this this morning. [18:45:15] (03PS10) 10Ori.livneh: Enable customization of Vagrant and virtual machine [vagrant] - 10https://gerrit.wikimedia.org/r/121425 (owner: 10BryanDavis) [18:45:22] (03CR) 10Ori.livneh: [C: 032] "This is cool, thanks. Since we're heavily customizing Vagrant anyway, it'd be good to have Vagrant itself be smart enough to reload automa" [vagrant] - 10https://gerrit.wikimedia.org/r/121425 (owner: 10BryanDavis) [18:45:24] <^d> Search is an awful mixture of both and I hates it. [18:45:25] (03Merged) 10jenkins-bot: Enable customization of Vagrant and virtual machine [vagrant] - 10https://gerrit.wikimedia.org/r/121425 (owner: 10BryanDavis) [18:45:27] yeah, a hook to add a polymorphic object to a list is ok [18:45:28] Is there any issue with sticking live uncomitted changes on deployment-prep to debug stuff? [18:45:31] but don’t mix em up too much :D [18:45:49] ^d: i apologize, that was probably my fault from hacking things together in ‘05 [18:46:15] and that was a hack on top of the mysql 3 / mysql 4 split from ’03 or ‘04 [18:46:20] yuck :D [18:46:20] <^d> Apology accepted :) [18:47:27] so what is an example of us having done it right? [18:48:04] or substantially right [18:48:54] oh, I'm guessing bd808's change to using scrap instead of the NSF shared dir would stop me from doing this so easily [18:49:00] scap* [18:49:12] so my favorite traditional example is the old transition from cur/old tables to page/revision/text, which brought object intermediary interface in front of revisions [18:49:29] from there we were able to extend to sharded external storage with relatively little change to the rest of the code [18:49:37] and various funky compression techniques [18:49:53] that’s a case where we chose polymorphic objects over hooks and it worked out well [18:49:59] (well i’m not sure we had the hooks originally) [18:50:10] Project browsertests-Translate-meta.wikimedia.org-linux-firefox build #2: SUCCESS in 1 min 16 sec: https://integration.wikimedia.org/ci/job/browsertests-Translate-meta.wikimedia.org-linux-firefox/2/ [18:50:25] and now we’re looking at further decoupling that storage layer to a separate service [18:50:36] which feels like it won’t be too disruptive because we made good choices on that 10 years ago [18:50:59] o hi ori, bored? [18:51:14] on the other hand auth fixes have been weird because that interface sucked ;) [18:51:22] i have the weirdless LESS issue. why do the tests on https://gerrit.wikimedia.org/r/#/c/127248/ fail? [18:51:27] weirdest* [18:51:48] (03CR) 10Ori.livneh: [C: 04-1] Exit with non-zero status on soft failure (032 comments) [tools/scap] - 10https://gerrit.wikimedia.org/r/127198 (owner: 10BryanDavis) [18:52:01] * ori looks [18:53:12] Project browsertests-Translate-sandbox.translatewiki.net-linux-firefox build #3: STILL FAILING in 21 min: https://integration.wikimedia.org/ci/job/browsertests-Translate-sandbox.translatewiki.net-linux-firefox/3/ [18:53:21] brion: what sucked about the auth interface? I don't know this area as well [18:53:53] sumanah: basically it was put together without a good idea of the requirements. it turned out to work ok for initial version of CentralAuth but had some weaknesses for LDAP and other uses [18:54:13] lack of flexibility in the interface, assumptions made about flow of data [18:55:07] brion: what era was this? what year-range would I look up? [18:55:31] let’s see… centralauth went live around ’08ish? [18:55:32] (basically I suspect that the examples for some of these will be Dia dragrams I draw, along the lines of the Animaniacs' Good Idea/Bad Idea) [18:55:35] (03CR) 10MaxSem: [C: 032] Make HtmlFormatter return removed elements [core] - 10https://gerrit.wikimedia.org/r/127238 (owner: 10Manybubbles) [18:55:39] heh [18:56:14] Project browsertests-CirrusSearch-en.wikipedia.beta.wmflabs.org-linux-firefox build #5: FAILURE in 3 min 21 sec: https://integration.wikimedia.org/ci/job/browsertests-CirrusSearch-en.wikipedia.beta.wmflabs.org-linux-firefox/5/ [18:56:32] (03PS1) 10Cmcmahon: QA: replace xpath with css now that it is supported [extensions/Flow] - 10https://gerrit.wikimedia.org/r/127285 [18:57:38] (03CR) 10Cmcmahon: "tested with Firefox and Chrome on beta labs" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/127285 (owner: 10Cmcmahon) [18:57:39] brion: ok. And the transition from cur/old tables to page/revision/text - what era was that? [18:57:47] 10 years ago? [18:57:52] that was way back in ’04-05 [18:58:09] it was probably our first really successful big refactor [18:58:21] :) What do you think made that refactor work so well? [18:58:41] the experience of the horror of the pre-refactored code ;) [18:58:41] (OK. I've been interviewing you for like an hour, I will understand if you want to go grab some lunch) [18:58:56] (03Merged) 10jenkins-bot: Make HtmlFormatter return removed elements [core] - 10https://gerrit.wikimedia.org/r/127238 (owner: 10Manybubbles) [18:59:02] we saw exactly several problems it created, and devised a new data structure to solve those problems [18:59:12] then designed a code structure that would abstract most of the actual table bits [18:59:25] which turned out to be very extensible [18:59:32] how many people worked on it? and about how long did it take, from "we gotta fix this" to the finished fix? [18:59:34] MatmaRex: my hunch: it has to do with ResourceLoader::getLESSVars caching the value of $wgResourceLoaderLESSVars when it is first called in a local static variable [19:00:41] sumanah: iirc it was mostly be on the main code, with tim on the compression abstraction that was later extended to external storage [19:00:49] took a few months [19:01:01] times were still young and we were very much learning as we went :D [19:01:22] brion: it's inspiring in some ways :-) that things can work out well even when you're figuring it out as you go along [19:01:30] the actual data table conversion took a few days on the biggest wikis :D [19:01:47] "it was mostly be on the main code" - you meant "me", right? (we actually do have a MediaWiki contributor named Be, after all - Be Birchall, Hacker School alumna) [19:01:48] yep, not all of our early designs are winners but some have sustained the distance well [19:01:54] *me yes :D [19:02:01] typing is hard [19:02:05] it is! [19:02:45] (03CR) 10Manybubbles: "Removing merge block now that I97cf66014719244b8bb2b0509b419c82202bdb01 is in." [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/127140 (owner: 10Manybubbles) [19:02:54] brion: so do you think pair programming or finding a thought partner for big changes is a good idea? or to put it another way - when you look back at big changes that have worked vs not worked, is there a correlation with single champions vs cofounding pairs/teams? [19:03:48] sumanah: i haven’t done a lot of explicit pair programming, but running ideas past someone else and having a couple people working on something can do wonders yes! [19:04:03] RL was very much a small team effort for example as well [19:04:21] I'm trying to think of big changes that were just one person's brainchild & implementation [19:04:35] the biggest danger of single-person brainchild is in wandering off into the weeds and getting lost in details [19:04:46] which was some of my difficulty in the early CentralAuth & AuthPlugin creation [19:05:03] if i’d worked more directly with ryan and his ldap stuff at the time we might have made a better interface [19:05:23] in a sense one of our key architectural principles is "we're all in this together; act like it" [19:05:27] :D [19:05:28] i like [19:05:36] E Pluribus Unum [19:05:45] but, like, in a non-jingoistic way [19:06:21] as much as i love playing cowboy hero programmer (see my wacky javascript video player project ;) i find great benefit from working with other folks. feedback on even my cowboy projects is super-valuable [19:07:11] in part you gotta make sure somebody’s playing the part of the user/consumer [19:07:18] * ^d saddles up for some code review at Ranch Brion [19:07:20] <^d> ye-haw! [19:07:21] especially when you’re creating an api that’s going to be extensible [19:08:40] OK! So it is good to have these examples and I welcome more [19:09:03] but I should let you get lunch or whatnot [19:09:13] sandwich time :D [19:09:22] Much thanks [19:09:26] lemme know when you update the page i’ll take another pass over it [19:09:28] sure thing! [19:09:28] I also welcome examples from other people of course! [19:10:14] ok bbiab lunchies [19:16:06] (03PS1) 10Ori.livneh: Don't cache $wgResourceLoaderLESSVars in a static [core] - 10https://gerrit.wikimedia.org/r/127289 [19:18:34] MatmaRex: ^ I have to admit that I've been fast and loose in assuming that this is the issue. I haven't confirmed it definitively. Even if it is the issue, a better fix may be to change ResourceLoaderTestCase::setUp somehow. I have to look at something else at the moment but hopefully this is enough to unblock you, and if not feel free to poke me again. [19:19:06] whoo [19:19:12] yay, thanks [19:20:43] (03PS3) 10Ori.livneh: Make logging destinations configurable [tools/scap] - 10https://gerrit.wikimedia.org/r/125515 (owner: 10BryanDavis) [19:20:48] (03CR) 10Ori.livneh: [C: 032] Make logging destinations configurable [tools/scap] - 10https://gerrit.wikimedia.org/r/125515 (owner: 10BryanDavis) [19:21:49] (03Merged) 10jenkins-bot: Make logging destinations configurable [tools/scap] - 10https://gerrit.wikimedia.org/r/125515 (owner: 10BryanDavis) [19:21:57] (03CR) 10Chad: [C: 032] Add an auxiliary text field [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/127140 (owner: 10Manybubbles) [19:22:12] (03Merged) 10jenkins-bot: Add an auxiliary text field [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/127140 (owner: 10Manybubbles) [19:25:03] Why might FlaggablePageView::$article represent the "API" page on deployment-prep but not my local machine? [19:26:32] (03PS3) 10Bartosz Dziewoński: vector: Do styles the ResourceLoader way [core] - 10https://gerrit.wikimedia.org/r/127248 [19:28:42] (03CR) 10Hoo man: [C: 032] "Reasonable" [core] - 10https://gerrit.wikimedia.org/r/127289 (owner: 10Ori.livneh) [19:31:04] (03PS13) 10EBernhardson: First stab at new template rendering in php [extensions/Flow] (frontend-rewrite) - 10https://gerrit.wikimedia.org/r/125358 [19:32:01] (03Merged) 10jenkins-bot: Don't cache $wgResourceLoaderLESSVars in a static [core] - 10https://gerrit.wikimedia.org/r/127289 (owner: 10Ori.livneh) [19:33:42] (03CR) 10Bartosz Dziewoński: "Rebasing https://gerrit.wikimedia.org/r/#/c/127248/ on this made the tests pass, thanks!" [core] - 10https://gerrit.wikimedia.org/r/127289 (owner: 10Ori.livneh) [19:37:04] jdlrobson: What does this._super() do in MobileFrontend JS code? Does it call the parent class's implementation? [19:37:24] (03PS1) 10Aaron Schulz: Avoid image table updates on file upload failure [core] - 10https://gerrit.wikimedia.org/r/127326 [19:41:29] (03PS2) 10Aaron Schulz: Bail out on FileBackend operations if the initial stat calls failed [core] - 10https://gerrit.wikimedia.org/r/127283 [19:44:23] (03CR) 10Nikerabbit: [C: 032] Remove superfluous # at end of line from languages.inc [core] - 10https://gerrit.wikimedia.org/r/127274 (owner: 10Umherirrender) [19:44:55] (03CR) 10Nikerabbit: [C: 032] Remove # from dataProvider [core] - 10https://gerrit.wikimedia.org/r/127276 (owner: 10Umherirrender) [19:47:53] (03Merged) 10jenkins-bot: Remove superfluous # at end of line from languages.inc [core] - 10https://gerrit.wikimedia.org/r/127274 (owner: 10Umherirrender) [19:48:42] (03PS1) 10Bartosz Dziewoński: Expand the protocol for proto-relative links when printing [core] - 10https://gerrit.wikimedia.org/r/127345 [19:49:48] (03PS1) 10Hashar: Only notify #wikimedia-qa for browsertests results [integration/jenkins-job-builder-config] (cloudbees) - 10https://gerrit.wikimedia.org/r/127347 [19:49:51] brion: nice to hear that it won't be disruptive; the last notes on wiki didn't look that optimistic :) [19:50:18] (03Merged) 10jenkins-bot: Remove # from dataProvider [core] - 10https://gerrit.wikimedia.org/r/127276 (owner: 10Umherirrender) [19:51:02] (03CR) 10Cmcmahon: [C: 031] Only notify #wikimedia-qa for browsertests results [integration/jenkins-job-builder-config] (cloudbees) - 10https://gerrit.wikimedia.org/r/127347 (owner: 10Hashar) [19:51:06] (03CR) 10CSteipp: [C: 031] "Looks good, other than the quote format which is causing jenkins to fail it." [core] - 10https://gerrit.wikimedia.org/r/118110 (owner: 10Anomie) [19:54:43] (03PS2) 10Hashar: Only notify #wikimedia-qa for browsertests results [integration/jenkins-job-builder-config] (cloudbees) - 10https://gerrit.wikimedia.org/r/127347 [19:54:51] (03CR) 10Hashar: [C: 032] Only notify #wikimedia-qa for browsertests results [integration/jenkins-job-builder-config] (cloudbees) - 10https://gerrit.wikimedia.org/r/127347 (owner: 10Hashar) [19:55:11] (03Merged) 10jenkins-bot: Only notify #wikimedia-qa for browsertests results [integration/jenkins-job-builder-config] (cloudbees) - 10https://gerrit.wikimedia.org/r/127347 (owner: 10Hashar) [19:59:08] ori: I think we should be auditing more (all?) of our production code for https://bugzilla.wikimedia.org/show_bug.cgi?id=64101 [19:59:40] You and I accidentally discovered a similar issue in ULS a while ago, and now it turns out MobileFrontend has the same problem except an order of magnitude worse [19:59:51] Who knows where else this kind of stuff is hiding [20:00:40] (03CR) 10Spage: "Thanks. Is the disruptive version bump of everything in Gemfile.lock necessary? Supposedly the xpath support is in watir-webdriver 0.6.8," (031 comment) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/127285 (owner: 10Cmcmahon) [20:01:09] (03PS2) 10Spage: QA: replace xpath with css now that it is supported [extensions/Flow] - 10https://gerrit.wikimedia.org/r/127285 (owner: 10Cmcmahon) [20:02:57] (03PS1) 10Catrope: Update OOjs UI to v0.1.0-pre (989950a4db) [core] - 10https://gerrit.wikimedia.org/r/127349 [20:04:39] (03CR) 10Trevor Parscal: [C: 032] Update OOjs UI to v0.1.0-pre (989950a4db) [core] - 10https://gerrit.wikimedia.org/r/127349 (owner: 10Catrope) [20:06:09] (03CR) 10Swalling: [C: 04-1] "For some reason the button text is showing the string name not the contents. https://imgur.com/eJGiGiL" [extensions/GettingStarted] - 10https://gerrit.wikimedia.org/r/125730 (owner: 10Phuedx) [20:07:42] (03Merged) 10jenkins-bot: Update OOjs UI to v0.1.0-pre (989950a4db) [core] - 10https://gerrit.wikimedia.org/r/127349 (owner: 10Catrope) [20:12:51] (03PS1) 10Bartosz Dziewoński: jquery.suggestions: Handle CSS ellipsis when calculating suggestions' widths [core] - 10https://gerrit.wikimedia.org/r/127355 [20:13:04] Nemo_bis: ^ [20:13:07] (03PS1) 10Catrope: Add forgotten OOjs UI i18n files [core] - 10https://gerrit.wikimedia.org/r/127356 [20:13:14] i hate this module [20:14:07] (03PS1) 10Bartosz Dziewoński: mediawiki.searchSuggest: Show full article title as a tooltip for each suggestion [core] - 10https://gerrit.wikimedia.org/r/127358 [20:14:10] and this one too [20:14:32] they're a damned disgrace of a search suggestions [20:14:43] (03CR) 10Trevor Parscal: [C: 032] Add forgotten OOjs UI i18n files [core] - 10https://gerrit.wikimedia.org/r/127356 (owner: 10Catrope) [20:14:53] (i hate them so much i forget to grammar!) [20:18:00] (03CR) 10Manybubbles: [C: 031] "Implementation is crazy dom heckery but I verified it works." [core] - 10https://gerrit.wikimedia.org/r/127355 (owner: 10Bartosz Dziewoński) [20:18:16] (03PS3) 10Spage: QA: replace xpath with css now that it is supported [extensions/Flow] - 10https://gerrit.wikimedia.org/r/127285 (owner: 10Cmcmahon) [20:18:44] (03CR) 10Spage: [C: 032] "edit_existing.feature passes on Firefox." [extensions/Flow] - 10https://gerrit.wikimedia.org/r/127285 (owner: 10Cmcmahon) [20:19:09] (03PS4) 10Cmcmahon: QA: replace xpath with css now that it is supported [extensions/Flow] - 10https://gerrit.wikimedia.org/r/127285 [20:19:29] (03CR) 10Bartosz Dziewoński: "(Note to self, if this is to be backported per the milestone on the bug, https://gerrit.wikimedia.org/r/#/c/127289/ is a dependency.)" [core] - 10https://gerrit.wikimedia.org/r/127248 (owner: 10Bartosz Dziewoński) [20:19:43] Krenair: Did you figure out your live hack questions? The use os scap shouldn't change things, but the jenkins job does a `git pull` every ~10 minutes and I don't see any pull == rebase config there so it's probably not completely easy to accomplish. [20:19:58] RoanKattouw: 'reveals a total of 50 (!!)' :( [20:20:30] ori: It's possible some of them are in mutually exclusive situations, e.g. theme files [20:20:32] But still [20:20:58] bd808, in the end I just modified the file on deployment-apache01 and replayed the API request until I got the right server :/ [20:21:02] * MatmaRex wonders, 'fifty of what'? [20:21:15] (03Merged) 10jenkins-bot: Add forgotten OOjs UI i18n files [core] - 10https://gerrit.wikimedia.org/r/127356 (owner: 10Catrope) [20:21:26] MatmaRex: https://bugzilla.wikimedia.org/show_bug.cgi?id=64101#c0 [20:21:32] MatmaRex: Non-data-URI-embedded background images [20:21:36] <1KB icons, of course [20:21:47] (03PS5) 10Spage: QA: replace xpath with css now that it is supported [extensions/Flow] - 10https://gerrit.wikimedia.org/r/127285 (owner: 10Cmcmahon) [20:22:11] So lots of latency, in an extension that's designed for a platform that typically has horrible latency [20:22:11] (03CR) 10Spage: "Dueling commit messages only, carrying +2 forward :)" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/127285 (owner: 10Cmcmahon) [20:22:16] RoanKattouw: .background-image-svg is slightly broken right now, i have a patch for that pending [20:22:32] Well on my local system it manages to data-URI-embed correctly at least [20:22:33] (it doesn't embed one of the copies of svg background) [20:22:40] https://gerrit.wikimedia.org/r/#/c/127139/ [20:22:40] Oh, I see [20:22:45] Well, let me put it this way [20:22:55] (it intentionally doesn't embed the fallback afaik) [20:23:05] If you fail to publish /w/extensions/MobileFrontend on your web server, some version of the image displays [20:23:13] thanks MatmaRex ! [20:23:16] StevenW: poke me when you have a min [20:23:27] Which is more than can be said for the straight-up url() ones [20:23:46] (This is my favorite strategy for exposing these cases BTW, caused by my local directory structure) [20:23:52] (but that's not really related to that bug) [20:24:11] (my patch, that is) [20:25:09] Krenair: Sounds painful. Glad you got it to work. I'd be interested in gathering some requirements for that kind of debugging and seeing if we can make a test server to make it easier to accomplish. [20:25:09] * bd808 is not promising anything [20:25:39] ori: will do. In a meeting ATM [20:25:46] bd808, honestly I wasn't even sure I should have been doing debugging like that in deployment-prep :D [20:25:56] :) [20:27:00] Maybe after the hackathon we will have enough infrastructure in Vagrant to support complicated debugging (varnish, etc) [20:27:24] apropos of nothing, renaming 'deployment-prep' to 'beta-cluster' would really help people discover it [20:27:43] (03PS6) 10Cmcmahon: QA: replace xpath with css now that it is supported [extensions/Flow] - 10https://gerrit.wikimedia.org/r/127285 [20:27:48] (03CR) 10Cmcmahon: [C: 032] QA: replace xpath with css now that it is supported [extensions/Flow] - 10https://gerrit.wikimedia.org/r/127285 (owner: 10Cmcmahon) [20:27:58] ori: Agreed. Is that a "hard" problem? [20:28:10] (03Merged) 10jenkins-bot: QA: replace xpath with css now that it is supported [extensions/Flow] - 10https://gerrit.wikimedia.org/r/127285 (owner: 10Cmcmahon) [20:28:12] * bd808 thinks it might be [20:28:49] (03PS5) 10Ori.livneh: Improved HashRing usage in JobQueueFederated [core] - 10https://gerrit.wikimedia.org/r/124511 (owner: 10Aaron Schulz) [20:28:53] (03CR) 10Ori.livneh: [C: 032] Improved HashRing usage in JobQueueFederated [core] - 10https://gerrit.wikimedia.org/r/124511 (owner: 10Aaron Schulz) [20:31:04] bd808, renaming projects in nova? [20:31:12] yes [20:31:27] And/or making an alias I guess [20:33:17] (03Merged) 10jenkins-bot: Improved HashRing usage in JobQueueFederated [core] - 10https://gerrit.wikimedia.org/r/124511 (owner: 10Aaron Schulz) [20:34:46] (03CR) 10BryanDavis: "Ori: There's a really simple looking MIT licensed plugin at https://github.com/aidanns/vagrant-reload that claims to expose a `config.vm.p" [vagrant] - 10https://gerrit.wikimedia.org/r/121425 (owner: 10BryanDavis) [20:56:05] RoanKattouw_away: sorry delayed response but yeh _super calls parent [21:03:48] (03CR) 10Ori.livneh: "This is a good patch in that it works as advertised and in that the problem it sets out to solve is real. But I think it's vital to make t" [core] - 10https://gerrit.wikimedia.org/r/117438 (owner: 10Bartosz Dziewoński) [21:08:27] (03CR) 10Ori.livneh: "@bd808: See for a sample Puppet:Reports imple" [vagrant] - 10https://gerrit.wikimedia.org/r/121425 (owner: 10BryanDavis) [21:08:55] (03CR) 10GWicke: [WIP] Added VirtualRESTServiceClient/VirtualRESTService classes (033 comments) [core] - 10https://gerrit.wikimedia.org/r/110129 (owner: 10Aaron Schulz) [21:14:04] (03CR) 10QChris: Code review by whitelisted users should triggers tests (031 comment) [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/127259 (owner: 10Hashar) [21:18:34] (03CR) 10BryanDavis: "Inline response to Ori's question/statement." (031 comment) [tools/scap] - 10https://gerrit.wikimedia.org/r/126924 (owner: 10BryanDavis) [21:24:30] (03CR) 10Ori.livneh: Improve error message when scap lock fails (031 comment) [tools/scap] - 10https://gerrit.wikimedia.org/r/126924 (owner: 10BryanDavis) [21:24:35] ^ bd808 [21:24:43] * bd808 looks [21:25:12] (03CR) 10CSteipp: "Minor whitespace issue, and needs single quotes so jenkins is happy. Otherwise, unless there's concerns that this isn't the right approach" (031 comment) [core] - 10https://gerrit.wikimedia.org/r/118113 (owner: 10Anomie) [21:25:13] bd808: 'lock_fd' in the final line should be 'lockfile'; that's my typo [21:26:32] (03PS1) 10Gerrit Patch Uploader: Use static width for searchButton [core] - 10https://gerrit.wikimedia.org/r/127371 [21:26:34] (03CR) 10Gerrit Patch Uploader: "This commit was uploaded using the Gerrit Patch Uploader [1]." [core] - 10https://gerrit.wikimedia.org/r/127371 (owner: 10Gerrit Patch Uploader) [21:28:14] (03CR) 10CSteipp: "I also don't love the .html() call for security, but I don't think there's a way to exploit it. We just need to stay aware that if there's" [core] - 10https://gerrit.wikimedia.org/r/118113 (owner: 10Anomie) [21:31:41] (03PS4) 10BryanDavis: Improve error message when scap lock fails [tools/scap] - 10https://gerrit.wikimedia.org/r/126924 [21:36:32] (03CR) 10Bartosz Dziewoński: Use static width for searchButton (031 comment) [core] - 10https://gerrit.wikimedia.org/r/127371 (owner: 10Gerrit Patch Uploader) [21:38:21] (03CR) 10EBernhardson: [C: 032] Get Flow non-JavaScript mode into mobile [extensions/Flow] - 10https://gerrit.wikimedia.org/r/125908 (owner: 10Jdlrobson) [21:38:37] (03PS14) 10EBernhardson: First stab at new template rendering in php [extensions/Flow] (frontend-rewrite) - 10https://gerrit.wikimedia.org/r/125358 [21:38:40] (03Merged) 10jenkins-bot: Get Flow non-JavaScript mode into mobile [extensions/Flow] - 10https://gerrit.wikimedia.org/r/125908 (owner: 10Jdlrobson) [21:41:42] (03CR) 10Fomafix: Use static width for searchButton (031 comment) [core] - 10https://gerrit.wikimedia.org/r/127371 (owner: 10Gerrit Patch Uploader) [21:43:54] (03PS28) 10Bsitu: Closing & Summarizing topic frontend changes [extensions/Flow] - 10https://gerrit.wikimedia.org/r/119640 [21:55:12] (03PS1) 10Amire80: Remove two-dot ellipsis from the postbuild message [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/127376 [22:07:48] (03PS8) 10Bsitu: Add topic/post summary diff view [extensions/Flow] - 10https://gerrit.wikimedia.org/r/121128 [22:16:45] (03PS12) 10Bsitu: Add summarize/close/open topic to history/contribution [extensions/Flow] - 10https://gerrit.wikimedia.org/r/123123 [22:16:55] (03PS15) 10EBernhardson: First stab at new template rendering in php [extensions/Flow] (frontend-rewrite) - 10https://gerrit.wikimedia.org/r/125358 [22:30:56] (03PS19) 10Mattflaschen: WIP: Refactor and add non-linear tours, with tests [extensions/GuidedTour] - 10https://gerrit.wikimedia.org/r/116228 [22:31:21] (03CR) 10jenkins-bot: [V: 04-1] WIP: Refactor and add non-linear tours, with tests [extensions/GuidedTour] - 10https://gerrit.wikimedia.org/r/116228 (owner: 10Mattflaschen) [22:56:17] (03PS13) 10Legoktm: Make abstract Config class truly implementation-agnostic [core] - 10https://gerrit.wikimedia.org/r/109850 (owner: 10Ori.livneh) [23:05:28] (03CR) 10Legoktm: "PS13: Adds a ConfigFactory, and has GlobalVarConfig register a callback builder." [core] - 10https://gerrit.wikimedia.org/r/109850 (owner: 10Ori.livneh) [23:12:03] (03PS2) 10BryanDavis: Exit with non-zero status on soft failure [tools/scap] - 10https://gerrit.wikimedia.org/r/127198 [23:12:15] (03CR) 10BryanDavis: Exit with non-zero status on soft failure (031 comment) [tools/scap] - 10https://gerrit.wikimedia.org/r/127198 (owner: 10BryanDavis) [23:19:07] (03CR) 10Jdlrobson: [C: 04-1] "Apart from minor ws issues looks good." (031 comment) [core] - 10https://gerrit.wikimedia.org/r/127139 (owner: 10Bartosz Dziewoński) [23:20:39] (03PS1) 10Umherirrender: Fixed some @params documentation (includes/[cache|objectcache]) [core] - 10https://gerrit.wikimedia.org/r/127383 [23:24:53] (03CR) 10Jdlrobson: [C: 032] vector: Do styles the ResourceLoader way [core] - 10https://gerrit.wikimedia.org/r/127248 (owner: 10Bartosz Dziewoński) [23:28:10] (03Merged) 10jenkins-bot: vector: Do styles the ResourceLoader way [core] - 10https://gerrit.wikimedia.org/r/127248 (owner: 10Bartosz Dziewoński) [23:40:34] Hi. [23:44:45] Please merge https://gerrit.wikimedia.org/r/#/c/127278/ ASAP [23:44:56] (not urgent, but the author asked me to say "ASAP") [23:46:10] (03PS13) 10Bsitu: Add summarize/close/open topic to history/contribution [extensions/Flow] - 10https://gerrit.wikimedia.org/r/123123 [23:54:17] (03CR) 10Addshore: [C: 032] "A few things could be improved further but I am not going to block on them as this is a net plus!" (038 comments) [core] - 10https://gerrit.wikimedia.org/r/127383 (owner: 10Umherirrender)