[00:00:56] (03PS5) 10EBernhardson: [WIP] new json output [extensions/Flow] (frontend-rewrite) - 10https://gerrit.wikimedia.org/r/125348 [00:01:12] (03CR) 10jenkins-bot: [V: 04-1] [WIP] new json output [extensions/Flow] (frontend-rewrite) - 10https://gerrit.wikimedia.org/r/125348 (owner: 10EBernhardson) [00:02:28] (03CR) 10AndyRussG: "Rebasing..." [extensions/Campaigns] (wip/editorcampaigns) - 10https://gerrit.wikimedia.org/r/117380 (owner: 10AndyRussG) [00:05:25] (03PS6) 10EBernhardson: [WIP] new json output [extensions/Flow] (frontend-rewrite) - 10https://gerrit.wikimedia.org/r/125348 [00:09:01] (03CR) 10EBernhardson: [C: 032] [WIP] new json output [extensions/Flow] (frontend-rewrite) - 10https://gerrit.wikimedia.org/r/125348 (owner: 10EBernhardson) [00:09:15] (03Merged) 10jenkins-bot: [WIP] new json output [extensions/Flow] (frontend-rewrite) - 10https://gerrit.wikimedia.org/r/125348 (owner: 10EBernhardson) [00:10:42] (03CR) 10EBernhardson: [C: 032] "hope i actually imported the right stuff" [extensions/Flow] (frontend-rewrite) - 10https://gerrit.wikimedia.org/r/125357 (owner: 10EBernhardson) [00:10:57] (03Merged) 10jenkins-bot: Initial import of handlebars templates [extensions/Flow] (frontend-rewrite) - 10https://gerrit.wikimedia.org/r/125357 (owner: 10EBernhardson) [00:11:02] (03PS6) 10EBernhardson: First stab at new template rendering in php [extensions/Flow] (frontend-rewrite) - 10https://gerrit.wikimedia.org/r/125358 [00:13:18] (03PS8) 10AndyRussG: WIP Query API modules for campaigns and participants [extensions/Campaigns] (wip/editorcampaigns) - 10https://gerrit.wikimedia.org/r/117380 [00:18:31] (03PS4) 10Jdlrobson: Get Flow non-JavaScript mode into mobile [extensions/Flow] - 10https://gerrit.wikimedia.org/r/125908 [00:41:57] jdlrobson: https://gerrit.wikimedia.org/r/126881 [00:58:33] (03PS7) 10AndyRussG: WIP Inform user about campaign and allow opt-out [extensions/Campaigns] (wip/editorcampaigns) - 10https://gerrit.wikimedia.org/r/125360 [01:13:44] (03CR) 10AndyRussG: "Since the only file that needed updating had a gnarly merge conflict on rebase, I rolled both the rebase and update into this patch set." [extensions/Campaigns] (wip/editorcampaigns) - 10https://gerrit.wikimedia.org/r/125360 (owner: 10AndyRussG) [01:15:45] (03CR) 10AndyRussG: WIP Inform user about campaign and allow opt-out (032 comments) [extensions/Campaigns] (wip/editorcampaigns) - 10https://gerrit.wikimedia.org/r/125360 (owner: 10AndyRussG) [01:41:14] (03CR) 10Parent5446: [C: 031] Removed 'Remember my login' preference [core] - 10https://gerrit.wikimedia.org/r/94614 (owner: 1001tonythomas) [01:45:42] (03PS1) 10Jforrester: Update OOjs UI to v0.1.0-pre (9d291a9222) [core] - 10https://gerrit.wikimedia.org/r/126893 [01:46:48] (03CR) 10Catrope: [C: 032] Update OOjs UI to v0.1.0-pre (9d291a9222) [core] - 10https://gerrit.wikimedia.org/r/126893 (owner: 10Jforrester) [01:49:38] (03CR) 10Swalling: [C: 04-1] "This a WIP but I wanted to note that we probably don't want this to be a confirmation checkbox. Rather (as Legal approved) we can make thi" [extensions/Campaigns] (wip/editorcampaigns) - 10https://gerrit.wikimedia.org/r/125360 (owner: 10AndyRussG) [01:50:11] (03Merged) 10jenkins-bot: Update OOjs UI to v0.1.0-pre (9d291a9222) [core] - 10https://gerrit.wikimedia.org/r/126893 (owner: 10Jforrester) [01:51:26] legoktm: Thanks! [02:40:56] (03PS1) 10Jforrester: Simplify VE inspector code to base off MWLiveExtensionInspector [extensions/Math] - 10https://gerrit.wikimedia.org/r/126901 [02:58:13] (03PS1) 10Catrope: Update VE implementation to use model-only inpsectors [extensions/Math] (wmf/1.23wmf22) - 10https://gerrit.wikimedia.org/r/126909 [02:58:18] (03PS1) 10Catrope: Temporary hack for VE math inspector closing issues in 1.23wmf22; fixed in 1.24wmf1 [extensions/Math] (wmf/1.23wmf22) - 10https://gerrit.wikimedia.org/r/126910 [02:59:21] (03CR) 10Catrope: [C: 032] Update VE implementation to use model-only inpsectors [extensions/Math] (wmf/1.23wmf22) - 10https://gerrit.wikimedia.org/r/126909 (owner: 10Catrope) [02:59:36] (03CR) 10Catrope: [C: 032] Temporary hack for VE math inspector closing issues in 1.23wmf22; fixed in 1.24wmf1 [extensions/Math] (wmf/1.23wmf22) - 10https://gerrit.wikimedia.org/r/126910 (owner: 10Catrope) [03:01:34] (03Merged) 10jenkins-bot: Update VE implementation to use model-only inpsectors [extensions/Math] (wmf/1.23wmf22) - 10https://gerrit.wikimedia.org/r/126909 (owner: 10Catrope) [03:02:27] (03Merged) 10jenkins-bot: Temporary hack for VE math inspector closing issues in 1.23wmf22; fixed in 1.24wmf1 [extensions/Math] (wmf/1.23wmf22) - 10https://gerrit.wikimedia.org/r/126910 (owner: 10Catrope) [03:04:45] (03PS7) 10EBernhardson: First stab at new template rendering in php [extensions/Flow] (frontend-rewrite) - 10https://gerrit.wikimedia.org/r/125358 [03:16:10] (03PS1) 10Catrope: Update Math and VisualEditor extensions for cherry-picks to make VE math inspector work [core] (wmf/1.23wmf22) - 10https://gerrit.wikimedia.org/r/126913 [03:16:28] James_F: SWAT that ---^^ [03:19:38] (03CR) 10jenkins-bot: [V: 04-1] Update Math and VisualEditor extensions for cherry-picks to make VE math inspector work [core] (wmf/1.23wmf22) - 10https://gerrit.wikimedia.org/r/126913 (owner: 10Catrope) [03:20:02] (03PS2) 10Krinkle: mwext-VisualEditor-doc-publish: Simplify rsync calls [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/125546 (owner: 10Jforrester) [03:21:10] (03CR) 10Mwalker: [C: 032] Allow the CodeEditor in read only mode [extensions/CodeEditor] - 10https://gerrit.wikimedia.org/r/120397 (owner: 10TheDJ) [03:21:22] (03Merged) 10jenkins-bot: Allow the CodeEditor in read only mode [extensions/CodeEditor] - 10https://gerrit.wikimedia.org/r/120397 (owner: 10TheDJ) [03:21:57] (03CR) 10Krinkle: [C: 032] "Pushed 'mwext-VisualEditor-doc-publish'." [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/125546 (owner: 10Jforrester) [03:22:59] (03Merged) 10jenkins-bot: mwext-VisualEditor-doc-publish: Simplify rsync calls [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/125546 (owner: 10Jforrester) [03:24:14] (03PS3) 10Krinkle: Create a general jsduck test task and use it for OOjs and OOjs UI [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/125541 (owner: 10Jforrester) [03:44:56] (03CR) 10Ori.livneh: "I'm barely familiar with this code. Better commit messages would really help me get oriented, and it would give me a view into how you're " [core] - 10https://gerrit.wikimedia.org/r/126052 (owner: 10Aaron Schulz) [03:45:28] (03PS1) 10Krinkle: grunt: Add jsonlint [core] - 10https://gerrit.wikimedia.org/r/126918 [03:45:30] (03PS1) 10Krinkle: grunt: Update watch file patterns [core] - 10https://gerrit.wikimedia.org/r/126919 [03:49:22] (03CR) 10Krinkle: "Most of these pointed to example urls (example.org) or fake pages that don't exist ("Extension:BetaFeatures/Testing", "Extension:BetaFeatu" [extensions/BetaFeatures] - 10https://gerrit.wikimedia.org/r/126197 (owner: 10Krinkle) [03:52:01] (03PS2) 10Krinkle: Consistently use example.org in tests [extensions/BetaFeatures] - 10https://gerrit.wikimedia.org/r/126197 [03:55:14] (03CR) 10Krinkle: [C: 031] "We added a basic jsonlint job in Jenkins previously (runs as part of the generic *-jslint job), however when we switched mediawiki-core fr" [core] - 10https://gerrit.wikimedia.org/r/126918 (owner: 10Krinkle) [03:55:45] (03PS2) 10Krinkle: grunt: Update watch file patterns [core] - 10https://gerrit.wikimedia.org/r/126919 [03:57:53] (03CR) 10Krinkle: "This ensures our i18n json files, and package.json and lint config files (.jscsrc) are valid json. The only one we previously asserted are" [core] - 10https://gerrit.wikimedia.org/r/126918 (owner: 10Krinkle) [04:02:47] (03PS1) 10BryanDavis: Improve error message when scap lock fails [tools/scap] - 10https://gerrit.wikimedia.org/r/126924 [04:11:32] (03PS16) 10Mattflaschen: WIP: Refactor and add non-linear tours, with tests [extensions/GuidedTour] - 10https://gerrit.wikimedia.org/r/116228 [04:11:57] (03CR) 10jenkins-bot: [V: 04-1] WIP: Refactor and add non-linear tours, with tests [extensions/GuidedTour] - 10https://gerrit.wikimedia.org/r/116228 (owner: 10Mattflaschen) [04:13:35] (03PS8) 10EBernhardson: First stab at new template rendering in php [extensions/Flow] (frontend-rewrite) - 10https://gerrit.wikimedia.org/r/125358 [04:16:19] (03CR) 10Krinkle: Use ResourceLoader modules for style loading (034 comments) [extensions/SyntaxHighlight_GeSHi] - 10https://gerrit.wikimedia.org/r/126843 (owner: 10Bartosz Dziewoński) [04:18:10] (03CR) 10Mattflaschen: "I finished most of the QUnit tests. I don't have plans to add more for Step or StepBuilder, but I can if you see any where you think ther" [extensions/GuidedTour] - 10https://gerrit.wikimedia.org/r/116228 (owner: 10Mattflaschen) [04:21:54] (03CR) 10Krinkle: Use ResourceLoader modules for style loading (031 comment) [extensions/SyntaxHighlight_GeSHi] - 10https://gerrit.wikimedia.org/r/126843 (owner: 10Bartosz Dziewoński) [04:22:21] (03CR) 10Krinkle: Use ResourceLoader modules for style loading (031 comment) [extensions/SyntaxHighlight_GeSHi] - 10https://gerrit.wikimedia.org/r/126843 (owner: 10Bartosz Dziewoński) [04:24:30] (03CR) 10Krinkle: [C: 04-1] Use ResourceLoader modules for style loading (031 comment) [extensions/SyntaxHighlight_GeSHi] - 10https://gerrit.wikimedia.org/r/126843 (owner: 10Bartosz Dziewoński) [05:00:19] (03CR) 10Lydia Pintscher: [C: 04-1] "We've had this discussion on the mailing list, I believe? I'd like clarification on use-cases for example. To me they seem to overlap with" [core] - 10https://gerrit.wikimedia.org/r/109853 (owner: 10Yurik) [05:07:08] (03CR) 10Jforrester: [C: 032] "Very well." [extensions/BetaFeatures] - 10https://gerrit.wikimedia.org/r/126197 (owner: 10Krinkle) [05:07:14] (03Merged) 10jenkins-bot: Consistently use example.org in tests [extensions/BetaFeatures] - 10https://gerrit.wikimedia.org/r/126197 (owner: 10Krinkle) [05:12:05] (03CR) 10Jforrester: [C: 032] grunt: Update watch file patterns [core] - 10https://gerrit.wikimedia.org/r/126919 (owner: 10Krinkle) [05:12:55] (03CR) 10Jforrester: [C: 032] grunt: Add jsonlint [core] - 10https://gerrit.wikimedia.org/r/126918 (owner: 10Krinkle) [05:16:11] (03Merged) 10jenkins-bot: grunt: Add jsonlint [core] - 10https://gerrit.wikimedia.org/r/126918 (owner: 10Krinkle) [05:16:23] (03Merged) 10jenkins-bot: grunt: Update watch file patterns [core] - 10https://gerrit.wikimedia.org/r/126919 (owner: 10Krinkle) [05:33:00] (03CR) 10Ori.livneh: [C: 031] Remove logging level from colorized logs [tools/scap] - 10https://gerrit.wikimedia.org/r/126851 (owner: 10BryanDavis) [05:54:54] (03PS2) 10Nemo bis: [WIP] Review settings page [wikimedia/wikimania-scholarships] - 10https://gerrit.wikimedia.org/r/126816 (owner: 10Kushal124) [05:58:25] (03CR) 10Siebrand: [C: 04-1] "i18n/L10n reviewed." (033 comments) [wikimedia/wikimania-scholarships] - 10https://gerrit.wikimedia.org/r/126816 (owner: 10Kushal124) [06:02:36] (03CR) 10Siebrand: [C: 031] "i18n/L10n reviewed." [extensions/Campaigns] (wip/editorcampaigns) - 10https://gerrit.wikimedia.org/r/125360 (owner: 10AndyRussG) [06:07:29] (03CR) 10Siebrand: "I reported bug 64045 requesting a more generic implementation as Antoine suggests." [core] - 10https://gerrit.wikimedia.org/r/125050 (owner: 10Jforrester) [06:08:27] (03CR) 10Siebrand: [C: 032] Properly deprecate the SpecialVersionExtensionTypes hook [core] - 10https://gerrit.wikimedia.org/r/126121 (owner: 10Bartosz Dziewoński) [06:11:55] (03Merged) 10jenkins-bot: Properly deprecate the SpecialVersionExtensionTypes hook [core] - 10https://gerrit.wikimedia.org/r/126121 (owner: 10Bartosz Dziewoński) [06:12:12] (03Merged) 10jenkins-bot: Consistently use '@deprecated since ' [core] - 10https://gerrit.wikimedia.org/r/126122 (owner: 10Bartosz Dziewoński) [06:14:28] (03CR) 10Siebrand: [C: 04-1] "i18n/L10n reviewed." (031 comment) [extensions/Thanks] - 10https://gerrit.wikimedia.org/r/125941 (owner: 10Wctaiwan) [06:16:27] (03CR) 10Siebrand: [C: 031] "L10n reviewed." [extensions/Flow] - 10https://gerrit.wikimedia.org/r/119640 (owner: 10Bsitu) [06:17:57] (03CR) 10Siebrand: [C: 031] "i18n/L10n reviewed." [core] - 10https://gerrit.wikimedia.org/r/5130 (owner: 10Joancreus) [06:18:53] (03CR) 10Siebrand: [C: 031] "i18n/L10n reviewed." [extensions/Flow] - 10https://gerrit.wikimedia.org/r/118399 (owner: 10Bsitu) [06:26:49] (03PS2) 10Severin Anatoliy: Fix render WikiForumList to display 'Posted by' link [extensions/WikiForum] - 10https://gerrit.wikimedia.org/r/120352 [06:47:34] (03PS3) 10Krinkle: Remove deprecated function mw.util.toggleToc [core] - 10https://gerrit.wikimedia.org/r/110680 (owner: 10Gerrit Patch Uploader) [06:48:25] (03CR) 10Krinkle: [C: 031] Remove deprecated function mw.util.toggleToc [core] - 10https://gerrit.wikimedia.org/r/110680 (owner: 10Gerrit Patch Uploader) [06:48:32] (03CR) 10Krinkle: "Untested." [core] - 10https://gerrit.wikimedia.org/r/110680 (owner: 10Gerrit Patch Uploader) [06:53:17] (03CR) 10jenkins-bot: [V: 04-1] Remove deprecated function mw.util.toggleToc [core] - 10https://gerrit.wikimedia.org/r/110680 (owner: 10Gerrit Patch Uploader) [07:04:45] (03CR) 10Ori.livneh: [C: 04-1] "* Calls to getLive* should be wrapped with a try / catch (I flagged a couple of spots, but there are others)" (037 comments) [core] - 10https://gerrit.wikimedia.org/r/124511 (owner: 10Aaron Schulz) [07:26:45] (03Abandoned) 10Severin Anatoliy: Fix render WikiForumList to display 'Posted by' link [extensions/WikiForum] - 10https://gerrit.wikimedia.org/r/120352 (owner: 10Severin Anatoliy) [07:37:55] (03Abandoned) 10Kushal124: [WIP] Review settings page [wikimedia/wikimania-scholarships] - 10https://gerrit.wikimedia.org/r/126816 (owner: 10Kushal124) [07:39:20] (03CR) 10Siebrand: [C: 04-1] "Please add message documentation in qqq.json when adding message keys. See https://www.mediawiki.org/wiki/I18n#Message_documentation for d" [wikimedia/wikimania-scholarships] - 10https://gerrit.wikimedia.org/r/126833 (owner: 10Kushal124) [07:48:40] (03CR) 10Siebrand: Commit files needed to create VideoJsPlayer (031 comment) [extensions/VideoJsPlayer] - 10https://gerrit.wikimedia.org/r/117019 (owner: 10AalekhN) [07:49:06] (03CR) 10Siebrand: "Needs rebase (JSON i18n)." [extensions/Flow] - 10https://gerrit.wikimedia.org/r/116786 (owner: 10Spage) [08:23:14] (03CR) 10AndyRussG: [C: 032] "Way to go!" [extensions/EducationProgram] - 10https://gerrit.wikimedia.org/r/124771 (owner: 10J-squared) [08:23:24] (03Merged) 10jenkins-bot: Update default end date for new courses [extensions/EducationProgram] - 10https://gerrit.wikimedia.org/r/124771 (owner: 10J-squared) [08:41:15] (03PS5) 10Dan-nl: Do not overwrite content from community members/bots on re-upload [extensions/GWToolset] - 10https://gerrit.wikimedia.org/r/124347 [08:42:18] (03CR) 10Dan-nl: "* addressed ps4 comment regarding the explanation next to the" [extensions/GWToolset] - 10https://gerrit.wikimedia.org/r/124347 (owner: 10Dan-nl) [08:42:58] (03PS1) 10Shirayuki: i18n: Add full-stop for consistency [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/126933 [08:51:18] (03CR) 10AndyRussG: [C: 04-1] "Almost...! Here's a corner case: Special:Contributions still links to a student profile for users who are enrolled in too many current cou" (031 comment) [extensions/EducationProgram] - 10https://gerrit.wikimedia.org/r/121107 (owner: 10Ragesoss) [08:59:17] any javascript gurus around? [09:02:34] found it [09:02:47] (03PS1) 10Daniel Kinzler: Consistent handlign of multiple keys in Message. [core] - 10https://gerrit.wikimedia.org/r/126936 [09:02:52] (03CR) 10Gilles: "This is the first GWToolset changeset that I look at. I couldn't find the unit tests for the extension, are there any? Having a test case " [extensions/GWToolset] - 10https://gerrit.wikimedia.org/r/124376 (owner: 10Dan-nl) [09:04:26] (03CR) 10Mxn: [C: 04-1] "A couple additional changes are required, because rs.js was split into sr.js and sr-cyr.js, and vn.js was renamed vi.js:" [core] - 10https://gerrit.wikimedia.org/r/126236 (owner: 10Prtksxna) [09:07:11] (03CR) 10Gilles: [C: 032] version update [extensions/GWToolset] - 10https://gerrit.wikimedia.org/r/125922 (owner: 10Dan-nl) [09:07:17] (03Merged) 10jenkins-bot: version update [extensions/GWToolset] - 10https://gerrit.wikimedia.org/r/125922 (owner: 10Dan-nl) [09:10:31] (03CR) 10Gilles: "Can you give me some context about what the Campaigns page is, its history and relationship with UploadWizard?" [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/125913 (owner: 10Dan-nl) [09:13:52] (03CR) 10Gilles: "Similarly difficult to review due to lack of unit test. If you're resource/time constrained and can't afford to spend time writing unit te" [extensions/GWToolset] - 10https://gerrit.wikimedia.org/r/125552 (owner: 10Dan-nl) [09:14:31] (03PS2) 10Addshore: Consistent handling of multiple keys in Message. [core] - 10https://gerrit.wikimedia.org/r/126936 (owner: 10Daniel Kinzler) [09:19:15] (03PS4) 10Addshore: Finish removing boolean return values from JobQueue code [core] - 10https://gerrit.wikimedia.org/r/126746 (owner: 10Thiemo Mättig (WMDE)) [09:20:21] (03CR) 10AndyRussG: [C: 031] "Looks fine, just have to rebase..." [extensions/EducationProgram] - 10https://gerrit.wikimedia.org/r/123365 (owner: 10Ragesoss) [09:29:03] (03CR) 10Aklapper: "Kushal124: For future reference, amending instead of abandoning is welcome: https://www.mediawiki.org/wiki/Git/Tutorial#Amending_a_change" [wikimedia/wikimania-scholarships] - 10https://gerrit.wikimedia.org/r/126816 (owner: 10Kushal124) [09:31:57] (03CR) 10Siebrand: [C: 032] i18n: Add full-stop for consistency [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/126933 (owner: 10Shirayuki) [09:32:01] (03Merged) 10jenkins-bot: i18n: Add full-stop for consistency [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/126933 (owner: 10Shirayuki) [09:40:55] (03CR) 10Dan-nl: "i’m not that familiar with the history of the Campaign namespace in regards to UploadWizard. i do know that it’s being used in conjunction" [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/125913 (owner: 10Dan-nl) [09:46:13] (03PS1) 10UltrasonicNXT: Fix bug with the WikiForumList tag [extensions/WikiForum] - 10https://gerrit.wikimedia.org/r/126940 [09:48:37] (03CR) 10UltrasonicNXT: "Done here: https://gerrit.wikimedia.org/r/#/c/126940/ :)" [extensions/WikiForum] - 10https://gerrit.wikimedia.org/r/120352 (owner: 10Severin Anatoliy) [09:50:20] (03PS2) 10UltrasonicNXT: Fix bug with the WikiForumList tag [extensions/WikiForum] - 10https://gerrit.wikimedia.org/r/126940 [09:50:31] (03PS4) 10Prtksxna: Update moment.js to 2.6.0 [core] - 10https://gerrit.wikimedia.org/r/126236 [09:50:34] (03CR) 10UltrasonicNXT: [C: 032 V: 032] Fix bug with the WikiForumList tag [extensions/WikiForum] - 10https://gerrit.wikimedia.org/r/126940 (owner: 10UltrasonicNXT) [09:53:08] Project CirrusSearch-en.wikipedia.beta.wmflabs.org-linux-firefox build #1: ABORTED in 54 sec: https://integration.wikimedia.org/ci/job/CirrusSearch-en.wikipedia.beta.wmflabs.org-linux-firefox/1/ [09:56:11] (03CR) 10jenkins-bot: [V: 04-1] Update moment.js to 2.6.0 [core] - 10https://gerrit.wikimedia.org/r/126236 (owner: 10Prtksxna) [09:56:52] Project CirrusSearch-en.wikipedia.beta.wmflabs.org-linux-firefox build #2: FAILURE in 1 min 4 sec: https://integration.wikimedia.org/ci/job/CirrusSearch-en.wikipedia.beta.wmflabs.org-linux-firefox/2/ [09:58:17] (03CR) 10Mxn: "rs.js needs to be deleted and removed from Resources.php." [core] - 10https://gerrit.wikimedia.org/r/126236 (owner: 10Prtksxna) [09:58:47] (03PS1) 10Thiemo Mättig (WMDE): ApiSandbox broken because of undefined variable [extensions/ApiSandbox] - 10https://gerrit.wikimedia.org/r/126942 [09:59:00] (03PS1) 10Hashar: Tie browsertests jobs to wmflabs slaves [integration/jenkins-job-builder-config] (cloudbees) - 10https://gerrit.wikimedia.org/r/126943 [09:59:54] (03PS5) 10Prtksxna: Update moment.js to 2.6.0 [core] - 10https://gerrit.wikimedia.org/r/126236 [10:00:20] Project CirrusSearch-en.wikipedia.beta.wmflabs.org-linux-firefox build #3: STILL FAILING in 11 sec: https://integration.wikimedia.org/ci/job/CirrusSearch-en.wikipedia.beta.wmflabs.org-linux-firefox/3/ [10:00:42] (03PS1) 10Hashar: Remove ruby 2.1.1 when running on wmflabs [integration/jenkins-job-builder-config] (cloudbees) - 10https://gerrit.wikimedia.org/r/126945 [10:01:02] (03PS6) 10Prtksxna: Update moment.js to 2.6.0 [core] - 10https://gerrit.wikimedia.org/r/126236 [10:01:59] (03PS2) 10Thiemo Mättig (WMDE): ApiSandbox broken because of undefined variable [extensions/ApiSandbox] - 10https://gerrit.wikimedia.org/r/126942 [10:05:05] (03PS1) 10Hashar: Install gems in a shared dir [integration/jenkins-job-builder-config] (cloudbees) - 10https://gerrit.wikimedia.org/r/126946 [10:05:41] Project CirrusSearch-en.wikipedia.beta.wmflabs.org-linux-firefox build #4: ABORTED in 2 min 12 sec: https://integration.wikimedia.org/ci/job/CirrusSearch-en.wikipedia.beta.wmflabs.org-linux-firefox/4/ [10:06:27] (03PS1) 10Hashar: Make bundle install verbose! [integration/jenkins-job-builder-config] (cloudbees) - 10https://gerrit.wikimedia.org/r/126947 [10:07:24] (03PS2) 10Hashar: Make bundle install verbose! [integration/jenkins-job-builder-config] (cloudbees) - 10https://gerrit.wikimedia.org/r/126947 [10:08:13] (03CR) 10Addshore: [C: 032] ApiSandbox broken because of undefined variable [extensions/ApiSandbox] - 10https://gerrit.wikimedia.org/r/126942 (owner: 10Thiemo Mättig (WMDE)) [10:08:16] (03Merged) 10jenkins-bot: ApiSandbox broken because of undefined variable [extensions/ApiSandbox] - 10https://gerrit.wikimedia.org/r/126942 (owner: 10Thiemo Mättig (WMDE)) [10:08:42] (03CR) 10Mxn: [C: 031] "Thanks!" [core] - 10https://gerrit.wikimedia.org/r/126236 (owner: 10Prtksxna) [10:10:09] Project CirrusSearch-en.wikipedia.beta.wmflabs.org-linux-firefox build #5: STILL FAILING in 3 min 28 sec: https://integration.wikimedia.org/ci/job/CirrusSearch-en.wikipedia.beta.wmflabs.org-linux-firefox/5/ [10:19:05] (03PS1) 10Hashar: Explicitly use gem version 1.9.3 [integration/jenkins-job-builder-config] (cloudbees) - 10https://gerrit.wikimedia.org/r/126948 [10:21:54] (03CR) 10Dan-nl: "thanks for taking a look at it. there are no unit tests at the moment. i will upload, a bit later today, an xml dataset that you can use o" [extensions/GWToolset] - 10https://gerrit.wikimedia.org/r/124376 (owner: 10Dan-nl) [10:22:07] Project CirrusSearch-en.wikipedia.beta.wmflabs.org-linux-firefox build #6: STILL FAILING in 2 min 51 sec: https://integration.wikimedia.org/ci/job/CirrusSearch-en.wikipedia.beta.wmflabs.org-linux-firefox/6/ [10:23:21] (03CR) 10Dan-nl: "thanks for taking the time to review. i will upload, a bit later today, an xml dataset that you can use on the beta cluster to test the is" [extensions/GWToolset] - 10https://gerrit.wikimedia.org/r/125552 (owner: 10Dan-nl) [10:29:41] (03CR) 10Gilles: [C: 04-1] "As far as I can see the special page is defined in the Campaigns extension: https://www.mediawiki.org/wiki/Extension:Campaigns" [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/125913 (owner: 10Dan-nl) [10:29:51] (03PS1) 10Umherirrender: Fixes to Special:TrackingCategories [core] - 10https://gerrit.wikimedia.org/r/126950 [10:30:32] (03CR) 10Umherirrender: [C: 031] "Looks good, but I have make a follow-up I88322512db5c4baedc5c571ce9ccbcd0caebb61d to fix some problems, when the {{-check goes live, becau" [core] - 10https://gerrit.wikimedia.org/r/124784 (owner: 10Brian Wolff) [10:31:21] Project CirrusSearch-en.wikipedia.beta.wmflabs.org-linux-firefox build #7: ABORTED in 1 min 39 sec: https://integration.wikimedia.org/ci/job/CirrusSearch-en.wikipedia.beta.wmflabs.org-linux-firefox/7/ [10:32:38] (03CR) 10Nikerabbit: "Please join to the discussion in bug 63897." [core] - 10https://gerrit.wikimedia.org/r/126936 (owner: 10Daniel Kinzler) [10:33:15] (03PS2) 10Hashar: Use gem 1.9.3 and the installed bundler version [integration/jenkins-job-builder-config] (cloudbees) - 10https://gerrit.wikimedia.org/r/126948 [10:33:29] (03PS2) 10Umherirrender: Fixes to Special:TrackingCategories [core] - 10https://gerrit.wikimedia.org/r/126950 [10:35:08] (03PS3) 10Umherirrender: Fixes to Special:TrackingCategories [core] - 10https://gerrit.wikimedia.org/r/126950 [10:35:58] (03CR) 10Umherirrender: "Patch Set 2: Removed double inContentLanguage from Patch Set 1" [core] - 10https://gerrit.wikimedia.org/r/126950 (owner: 10Umherirrender) [10:35:59] Project CirrusSearch-en.wikipedia.beta.wmflabs.org-linux-firefox build #8: STILL FAILING in 4 min 26 sec: https://integration.wikimedia.org/ci/job/CirrusSearch-en.wikipedia.beta.wmflabs.org-linux-firefox/8/ [10:37:26] (03PS1) 10Severin Anatoliy: fix calling show() of non-object [extensions/WikiForum] - 10https://gerrit.wikimedia.org/r/126952 [10:37:28] (03PS2) 10Hashar: Tie browsertests jobs to wmflabs slaves [integration/jenkins-job-builder-config] (cloudbees) - 10https://gerrit.wikimedia.org/r/126943 [10:37:31] (03PS3) 10Hashar: Use gem 1.9.3 and the installed bundler version [integration/jenkins-job-builder-config] (cloudbees) - 10https://gerrit.wikimedia.org/r/126948 [10:37:34] (03PS2) 10Hashar: Install gems in a shared dir [integration/jenkins-job-builder-config] (cloudbees) - 10https://gerrit.wikimedia.org/r/126946 [10:37:37] (03PS3) 10Hashar: Make bundle install verbose! [integration/jenkins-job-builder-config] (cloudbees) - 10https://gerrit.wikimedia.org/r/126947 [10:37:40] (03PS2) 10Hashar: Remove ruby 2.1.1 when running on wmflabs [integration/jenkins-job-builder-config] (cloudbees) - 10https://gerrit.wikimedia.org/r/126945 [10:39:47] (03CR) 10Severin Anatoliy: [C: 031] fix calling show() of non-object [extensions/WikiForum] - 10https://gerrit.wikimedia.org/r/126952 (owner: 10Severin Anatoliy) [10:47:47] (03CR) 10Daniel Kinzler: [C: 032] Remove FakeTitle [core] - 10https://gerrit.wikimedia.org/r/126749 (owner: 10Chad) [10:48:39] (03CR) 10jenkins-bot: [V: 04-1] Remove FakeTitle [core] - 10https://gerrit.wikimedia.org/r/126749 (owner: 10Chad) [10:48:46] (03CR) 10Daniel Kinzler: [C: 031] "This patch was originally by me, so i abviously think it's fine :)" [core] - 10https://gerrit.wikimedia.org/r/126666 (owner: 10Reedy) [10:48:48] (03CR) 10Umherirrender: "Maybe add also the result of ParserOutput::getJsConfigVars?" [core] - 10https://gerrit.wikimedia.org/r/126848 (owner: 10Bartosz Dziewoński) [10:50:13] (03PS1) 10Hashar: Make the ircbot publisher a macro [integration/jenkins-job-builder-config] (cloudbees) - 10https://gerrit.wikimedia.org/r/126955 [10:52:21] (03CR) 10Hashar: "Should be a noop. The integration-jjb-config-diff job is bugged, it does the diff against the tip of the branch and not against the previo" [integration/jenkins-job-builder-config] (cloudbees) - 10https://gerrit.wikimedia.org/r/126955 (owner: 10Hashar) [10:54:33] (03CR) 10Umherirrender: [C: 031] Use ResourceLoader::makeComment to embed page title in wiki modules [core] - 10https://gerrit.wikimedia.org/r/125562 (owner: 10Ori.livneh) [11:06:22] (03PS4) 10Zfilipin: Use gem 1.9.3 and the installed bundler version [integration/jenkins-job-builder-config] (cloudbees) - 10https://gerrit.wikimedia.org/r/126948 (owner: 10Hashar) [11:07:01] (03CR) 10Zfilipin: [C: 032] Use gem 1.9.3 and the installed bundler version [integration/jenkins-job-builder-config] (cloudbees) - 10https://gerrit.wikimedia.org/r/126948 (owner: 10Hashar) [11:07:04] (03CR) 10jenkins-bot: [V: 04-1] Use gem 1.9.3 and the installed bundler version [integration/jenkins-job-builder-config] (cloudbees) - 10https://gerrit.wikimedia.org/r/126948 (owner: 10Hashar) [11:15:45] (03PS3) 10Zfilipin: Install gems in a shared dir [integration/jenkins-job-builder-config] (cloudbees) - 10https://gerrit.wikimedia.org/r/126946 (owner: 10Hashar) [11:15:48] (03PS1) 10Hashar: JJB conf diff now done against parent commit [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/126959 [11:16:13] (03CR) 10Zfilipin: [C: 032] Install gems in a shared dir [integration/jenkins-job-builder-config] (cloudbees) - 10https://gerrit.wikimedia.org/r/126946 (owner: 10Hashar) [11:17:58] (03PS3) 10Zfilipin: Tie browsertests jobs to wmflabs slaves [integration/jenkins-job-builder-config] (cloudbees) - 10https://gerrit.wikimedia.org/r/126943 (owner: 10Hashar) [11:18:01] (03CR) 10Hashar: [C: 032] JJB conf diff now done against parent commit [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/126959 (owner: 10Hashar) [11:18:32] (03PS4) 10Zfilipin: Make bundle install verbose! [integration/jenkins-job-builder-config] (cloudbees) - 10https://gerrit.wikimedia.org/r/126947 (owner: 10Hashar) [11:18:35] (03Merged) 10jenkins-bot: JJB conf diff now done against parent commit [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/126959 (owner: 10Hashar) [11:18:44] (03PS3) 10Zfilipin: Remove ruby 2.1.1 when running on wmflabs [integration/jenkins-job-builder-config] (cloudbees) - 10https://gerrit.wikimedia.org/r/126945 (owner: 10Hashar) [11:19:29] (03CR) 10Zfilipin: [C: 032] Make bundle install verbose! [integration/jenkins-job-builder-config] (cloudbees) - 10https://gerrit.wikimedia.org/r/126947 (owner: 10Hashar) [11:19:57] (03CR) 10Zfilipin: [C: 032] Remove ruby 2.1.1 when running on wmflabs [integration/jenkins-job-builder-config] (cloudbees) - 10https://gerrit.wikimedia.org/r/126945 (owner: 10Hashar) [11:21:38] (03CR) 10Zfilipin: [C: 032] Tie browsertests jobs to wmflabs slaves [integration/jenkins-job-builder-config] (cloudbees) - 10https://gerrit.wikimedia.org/r/126943 (owner: 10Hashar) [11:22:16] (03CR) 10Zfilipin: [C: 032] Tie browsertests jobs to wmflabs slaves [integration/jenkins-job-builder-config] (cloudbees) - 10https://gerrit.wikimedia.org/r/126943 (owner: 10Hashar) [11:22:53] (03Merged) 10jenkins-bot: Tie browsertests jobs to wmflabs slaves [integration/jenkins-job-builder-config] (cloudbees) - 10https://gerrit.wikimedia.org/r/126943 (owner: 10Hashar) [11:23:05] (03PS4) 10Zfilipin: Install gems in a shared dir [integration/jenkins-job-builder-config] (cloudbees) - 10https://gerrit.wikimedia.org/r/126946 (owner: 10Hashar) [11:23:09] (03PS4) 10Hashar: Remove ruby 2.1.1 when running on wmflabs [integration/jenkins-job-builder-config] (cloudbees) - 10https://gerrit.wikimedia.org/r/126945 [11:23:53] (03PS5) 10Hashar: Install gems in a shared dir [integration/jenkins-job-builder-config] (cloudbees) - 10https://gerrit.wikimedia.org/r/126946 [11:24:04] (03PS5) 10Hashar: Make bundle install verbose! [integration/jenkins-job-builder-config] (cloudbees) - 10https://gerrit.wikimedia.org/r/126947 [11:24:12] (03PS5) 10Hashar: Use gem 1.9.3 and the installed bundler version [integration/jenkins-job-builder-config] (cloudbees) - 10https://gerrit.wikimedia.org/r/126948 [11:24:16] (03PS2) 10Hashar: Make the ircbot publisher a macro [integration/jenkins-job-builder-config] (cloudbees) - 10https://gerrit.wikimedia.org/r/126955 [11:27:14] (03CR) 10Zfilipin: [C: 032] Install gems in a shared dir [integration/jenkins-job-builder-config] (cloudbees) - 10https://gerrit.wikimedia.org/r/126946 (owner: 10Hashar) [11:27:35] (03Merged) 10jenkins-bot: Install gems in a shared dir [integration/jenkins-job-builder-config] (cloudbees) - 10https://gerrit.wikimedia.org/r/126946 (owner: 10Hashar) [11:27:38] (03Merged) 10jenkins-bot: Make bundle install verbose! [integration/jenkins-job-builder-config] (cloudbees) - 10https://gerrit.wikimedia.org/r/126947 (owner: 10Hashar) [11:27:41] (03Merged) 10jenkins-bot: Use gem 1.9.3 and the installed bundler version [integration/jenkins-job-builder-config] (cloudbees) - 10https://gerrit.wikimedia.org/r/126948 (owner: 10Hashar) [11:30:28] (03PS3) 10Zfilipin: Make the ircbot publisher a macro [integration/jenkins-job-builder-config] (cloudbees) - 10https://gerrit.wikimedia.org/r/126955 (owner: 10Hashar) [11:31:49] (03CR) 10Zfilipin: [C: 032] Make the ircbot publisher a macro [integration/jenkins-job-builder-config] (cloudbees) - 10https://gerrit.wikimedia.org/r/126955 (owner: 10Hashar) [11:32:24] (03Merged) 10jenkins-bot: Make the ircbot publisher a macro [integration/jenkins-job-builder-config] (cloudbees) - 10https://gerrit.wikimedia.org/r/126955 (owner: 10Hashar) [11:33:08] Is there a way to add a preference/setting to a BetaFeature? I ask for https://bugzilla.wikimedia.org/63508#c4 [12:08:47] YuviPanda: hi [12:19:27] (03PS1) 10Reedy: Parameter type hints [extensions/CSS] - 10https://gerrit.wikimedia.org/r/126964 [12:20:36] (03PS1) 10Physikerwelt: URL to Mathimage [extensions/Math] (dev) - 10https://gerrit.wikimedia.org/r/126965 [12:23:26] (03PS2) 10Physikerwelt: URL to Mathimage [extensions/Math] (dev) - 10https://gerrit.wikimedia.org/r/126965 [12:27:49] (03PS3) 10Umherirrender: Fixed some @params documentation (includes/api) [core] - 10https://gerrit.wikimedia.org/r/126034 [12:28:20] (03PS1) 10Umherirrender: Fixed some @params documentation (languages) [core] - 10https://gerrit.wikimedia.org/r/126966 [12:35:35] (03PS1) 10Umherirrender: Fixed some @params documentation (skins) [core] - 10https://gerrit.wikimedia.org/r/126967 [12:40:06] hi liangent [12:42:36] YuviPanda: see https://bugzilla.wikimedia.org/show_bug.cgi?id=64051 [12:42:46] I was afraid I couldn't describe the bug clearly [12:42:59] liangent: just looking at it. I guess the appropriate thing to do is to not show the pencil icon at all if there is no section header [12:43:11] liangent: Main Pages should get special handling though, I think. [12:43:52] YuviPanda: well from the other side "why main pages need special handling" [12:44:04] can't it be done on site with css etc? [12:44:16] liangent: because MobileFrontend handles them specially :( action=mobileview does some special things for Main Pages [12:48:50] YuviPanda: that is, everything is in section id="0" ? [12:49:43] hm anyway that's useful in mobilefrontend itself, because they collapse other sections [12:49:43] liangent: yeah, and looks like it also strips divs that aren't specifically marked as mobile optimized [12:49:46] liangent: https://en.wikipedia.org/wiki/Special:ApiSandbox#action=mobileview&format=json&page=Main%20Page§ions=0&prop=displaytitle&onlyrequestedsections= [12:52:25] YuviPanda: so I created User:Liangent/首页 (wikitext {{Wikipedia:首页}} ) and had a look at it in the app: it seems the app doesn't strip class="nomobile"? [12:53:00] liangent: yeah, haven't synced css between app and MF yet. [12:53:14] liangent: although I'm not sure if nomobile is supposed to be stripped server side or not [12:53:56] YuviPanda: by looking at it I caught https://bugzilla.wikimedia.org/show_bug.cgi?id=64052 [12:54:44] wait wait whaaaat [12:54:57] and actually https://zh.m.wikipedia.org/wiki/User:Liangent/%E9%A6%96%E9%A1%B5 is pretty mobile usable [12:54:58] liangent: test page link? User:Liangent/首页? [12:55:14] right [12:55:19] let me see that on the app [12:55:52] (03CR) 10Physikerwelt: [C: 032] URL to Mathimage [extensions/Math] (dev) - 10https://gerrit.wikimedia.org/r/126965 (owner: 10Physikerwelt) [12:56:01] (03Merged) 10jenkins-bot: URL to Mathimage [extensions/Math] (dev) - 10https://gerrit.wikimedia.org/r/126965 (owner: 10Physikerwelt) [12:56:18] YuviPanda: did you get stuck in inputting "首页" into the app :p [12:56:37] liangent: I didn't even try :D copy pasted the URL, emailed it to myself, now waiting for the email to show up :P [12:56:48] showed up [12:57:15] liangent: ok, can repro [12:57:28] liangent: hmm, so how is it fully expanded in MF? [12:57:43] * YuviPanda checks mobileview output [12:59:43] hmm, https://zh.wikipedia.org/w/api.php?format=json&page=User:Liangent/%E9%A6%96%E9%A1%B5&action=mobileview§ions=all§ionprop=line|level&prop=text [13:00:35] YuviPanda: another test page https://zh.m.wikipedia.org/wiki/User:Liangent/hX [13:01:23] "I didn't even try :D copy pasted the URL, emailed it to myself, now waiting for the email to show up :P" << I like to do this by creating a qr and scanning it in my phone [13:01:44] liangent: damn, next time! [13:01:48] (03CR) 10Hashar: "Whenever someone copy paste the output of a scap run, the coloring information is lost :)" [tools/scap] - 10https://gerrit.wikimedia.org/r/126851 (owner: 10BryanDavis) [13:01:51] liangent: hmm, so https://zh.wikipedia.org/w/api.php?format=json&page=User:Liangent/%E9%A6%96%E9%A1%B5&action=mobileview§ions=all§ionprop=line|level&prop=text|sections [13:02:18] liangent: actually, https://zh.wikipedia.org/w/api.php?format=json&page=User:Liangent/%E9%A6%96%E9%A1%B5&action=mobileview§ions=all§ionprop=line|level&prop=text|sections&noheadings= [13:02:26] liangent: so that's the output I work off [13:02:57] liangent: also when you view that Mobile page, are you logged into the mobile website? [13:03:38] YuviPanda: "also when you view that (which?) Mobile page (app or zh.m.xxx?)" [13:04:13] (03PS1) 10Prtksxna: DONT MERGE/REVIEW - Pref for testing on chicken [extensions/Popups] - 10https://gerrit.wikimedia.org/r/126970 [13:04:18] (03CR) 10jenkins-bot: [V: 04-1] DONT MERGE/REVIEW - Pref for testing on chicken [extensions/Popups] - 10https://gerrit.wikimedia.org/r/126970 (owner: 10Prtksxna) [13:04:31] (03PS3) 10PleaseStand: JSON i18n shim: Only register LocalisationCacheRecache handler once [core] - 10https://gerrit.wikimedia.org/r/125706 [13:05:05] (03CR) 10Manybubbles: "Can we revive this one? At its heart it is something we want. Bryan's arguments about composing Vagrantfiles being somewhat limited are " [vagrant] - 10https://gerrit.wikimedia.org/r/121425 (owner: 10BryanDavis) [13:06:49] (03CR) 10PleaseStand: JSON i18n shim: Only register LocalisationCacheRecache handler once (031 comment) [core] - 10https://gerrit.wikimedia.org/r/125706 (owner: 10PleaseStand) [13:07:44] (03CR) 10Siebrand: "Very nice. Some inline comments." (0310 comments) [core] - 10https://gerrit.wikimedia.org/r/126966 (owner: 10Umherirrender) [13:08:07] (03CR) 10PleaseStand: "Note: I renamed --update-shim option back to --shim-only, so the shell script in Siebrand's comment would have to be adjusted accordingly." [core] - 10https://gerrit.wikimedia.org/r/125706 (owner: 10PleaseStand) [13:08:41] liangent: zh.m.xxx [13:09:25] logged in [13:09:28] YuviPanda: ^ [13:09:41] liangent: ah, hmm. [13:10:03] liangent: I have no idea why MF doesn't display pencil icons there, and also no idea why I'm getting network errors. I'll investigate [13:10:17] liangent: AHA! found it [13:10:52] liangent: so, because it is a template expansion that gives it the 'sections', MF borks [13:11:06] liangent: so it sees the tags, marks them as sections, gives them a section ID [13:11:30] liangent: while mediawiki only counts one section and doesn't return anything useful, and hence error. network error is 'misleading' there [13:11:32] YuviPanda: not really try https://zh.m.wikipedia.org/wiki/User:Liangent/hX [13:11:54] liangent: if I tap the edit icon for section 0 on the original page, it gives me {{Wikipedia:xx}} [13:12:41] (03CR) 10Siebrand: [C: 031] JSON i18n shim: Only register LocalisationCacheRecache handler once [core] - 10https://gerrit.wikimedia.org/r/125706 (owner: 10PleaseStand) [13:14:23] liangent: right. again, I think this is a difference in how mobileview sees 'section number' (based off HTML parsing) and how mediawiki sees them [13:14:50] https://zh.wikipedia.org/w/api.php?format=json&page=User:Liangent/hX&action=mobileview§ions=all§ionprop=line|level&prop=text|sections&noheadings= gives me 5 sections [13:15:00] YuviPanda: well MF editor handles that correctly [13:15:39] liangent: yeah, and I have to figure out what that is using. [13:16:07] (03CR) 10Kushal124: "Hi Siebrand. I will take a note of it." [wikimedia/wikimania-scholarships] - 10https://gerrit.wikimedia.org/r/126833 (owner: 10Kushal124) [13:16:07] (03CR) 10Siebrand: [C: 032] Fixed some @params documentation (skins) [core] - 10https://gerrit.wikimedia.org/r/126967 (owner: 10Umherirrender) [13:16:07] (03PS13) 10Kushal124: Make review settings configurable [wikimedia/wikimania-scholarships] - 10https://gerrit.wikimedia.org/r/125372 [13:16:18] liangent: hmm, what do you get when you try to edit 'hx2' in MF editor? [13:16:23] I can't edit that page since it's your user page [13:17:49] liangent: brb, phonecall [13:17:50] YuviPanda: it doesn't show a pencil for that heading [13:18:28] YuviPanda: http://imagebin.org/306135 [13:18:41] (03Merged) 10jenkins-bot: Fixed some @params documentation (skins) [core] - 10https://gerrit.wikimedia.org/r/126967 (owner: 10Umherirrender) [13:18:49] YuviPanda: http://imagebin.org/306136 [13:19:09] (03PS1) 10Hashar: /var/lock/scap is now configurable via lock_file [tools/scap] - 10https://gerrit.wikimedia.org/r/126973 [13:19:18] YuviPanda: url for the second image is https://zh.m.wikipedia.org/wiki/User:Liangent/hX#editor/2 [13:22:26] (03CR) 10KartikMistry: [C: 031] "LGTM." [core] - 10https://gerrit.wikimedia.org/r/124158 (owner: 10Amire80) [13:23:46] (03PS2) 10Hashar: /var/lock/scap is now configurable via lock_file [tools/scap] - 10https://gerrit.wikimedia.org/r/126973 [13:24:02] (03CR) 10Hashar: "Moved the default to scap/config.py :-D" [tools/scap] - 10https://gerrit.wikimedia.org/r/126973 (owner: 10Hashar) [13:26:20] (03PS1) 10Manybubbles: Don't add a filter if not needed [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/126975 [13:32:05] (03PS2) 10Umherirrender: Fixed some @params documentation (languages) [core] - 10https://gerrit.wikimedia.org/r/126966 [13:32:39] (03CR) 10Umherirrender: "Patch Set 2: Addressed inline comments" (0310 comments) [core] - 10https://gerrit.wikimedia.org/r/126966 (owner: 10Umherirrender) [13:32:57] (03PS3) 10Umherirrender: Fixed some @params documentation (languages) [core] - 10https://gerrit.wikimedia.org/r/126966 [13:35:49] (03CR) 10BryanDavis: [C: 032] /var/lock/scap is now configurable via lock_file [tools/scap] - 10https://gerrit.wikimedia.org/r/126973 (owner: 10Hashar) [13:36:09] (03Merged) 10jenkins-bot: /var/lock/scap is now configurable via lock_file [tools/scap] - 10https://gerrit.wikimedia.org/r/126973 (owner: 10Hashar) [13:36:31] (03CR) 10Nikerabbit: "Do they really store l10n data in JavaScript code?" [core] - 10https://gerrit.wikimedia.org/r/126236 (owner: 10Prtksxna) [13:39:26] (03PS7) 10Nemo bis: Update moment.js to 2.6.0 [core] - 10https://gerrit.wikimedia.org/r/126236 (owner: 10Prtksxna) [13:40:00] (03CR) 10Nemo bis: "Please don't use URL shorteners, they are ephemeral and commit messages last forever." [core] - 10https://gerrit.wikimedia.org/r/126236 (owner: 10Prtksxna) [13:48:46] (03CR) 10PleaseStand: "Any other reason for the -1?" (031 comment) [core] - 10https://gerrit.wikimedia.org/r/125925 (owner: 10PleaseStand) [13:52:35] liangent: back! [13:52:42] liangent: I'll poke the MF folks and find out why the changes. [13:52:54] liangent: and add the code to treat main pages differently [13:52:59] (03PS1) 10Alex Monk: Add preference to disable leaving warning while editing [core] - 10https://gerrit.wikimedia.org/r/126977 [13:56:14] (03CR) 10Hashar: Improve error message when scap lock fails (031 comment) [tools/scap] - 10https://gerrit.wikimedia.org/r/126924 (owner: 10BryanDavis) [13:58:43] (03CR) 10Siebrand: "i18n/L10n reviewed. Fine." [core] - 10https://gerrit.wikimedia.org/r/126977 (owner: 10Alex Monk) [13:58:53] YuviPanda: that hX issue is not on main page only... [13:59:12] liangent: true, but it's the most obvious place. [14:01:45] (03CR) 10Siebrand: [C: 032] Fixed some @params documentation (languages) [core] - 10https://gerrit.wikimedia.org/r/126966 (owner: 10Umherirrender) [14:02:14] YuviPanda: it isn't. MF doesn't emit
s other than id="0" for the real main page [14:02:31] and people won't write a lot {{:{{MediaWiki:MainPage}}}} like me [14:04:41] (03Merged) 10jenkins-bot: Fixed some @params documentation (languages) [core] - 10https://gerrit.wikimedia.org/r/126966 (owner: 10Umherirrender) [14:05:19] liangent: aah, hmm. Either way, I'll wait till MF folks come back up and ask them [14:05:21] liangent: I'll follow up! [14:05:32] (03CR) 10Hashar: "The email-ext provides more settings http://ci.openstack.org/jenkins-job-builder/publishers.html#publishers.email-ext . It is probably a g" (033 comments) [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/126870 (owner: 10BryanDavis) [14:06:06] liangent: I've to head out for some food now, I'll brb in a few hours. [14:06:42] liangent: also, looks like we won't have time for proper variant support in the first version :( But I added partial displaytitle support, so if you have it set in your user pref and log in it should 'work'. [14:07:07] YuviPanda: what is "partial" [14:12:12] YuviPanda: and can you fix those crashes before the first version ... I'm still getting some from time to time [14:23:59] liangent: I've not been able to reproduce them accurately :( Might be xposed causing it? [14:26:19] (03CR) 10Nikerabbit: [C: 032] Skip loading PHP shims for JSON i18n files (031 comment) [core] - 10https://gerrit.wikimedia.org/r/125925 (owner: 10PleaseStand) [14:26:22] (03CR) 10Umherirrender: "Already exists as 'useeditwarning', in that case the whole module is not loaded." [core] - 10https://gerrit.wikimedia.org/r/126977 (owner: 10Alex Monk) [14:28:13] (03PS1) 10Anomie: API: Warn when unsupported PHP array syntax is used [core] - 10https://gerrit.wikimedia.org/r/126990 [14:29:34] (03Merged) 10jenkins-bot: Skip loading PHP shims for JSON i18n files [core] - 10https://gerrit.wikimedia.org/r/125925 (owner: 10PleaseStand) [14:31:39] (03PS1) 10Umherirrender: Fixed some @params documentation (tests) [core] - 10https://gerrit.wikimedia.org/r/126991 [14:32:13] (03CR) 10Bartosz Dziewoński: [C: 032] Use ResourceLoader::makeComment to embed page title in wiki modules [core] - 10https://gerrit.wikimedia.org/r/125562 (owner: 10Ori.livneh) [14:36:13] (03Merged) 10jenkins-bot: Use ResourceLoader::makeComment to embed page title in wiki modules [core] - 10https://gerrit.wikimedia.org/r/125562 (owner: 10Ori.livneh) [14:37:15] (03CR) 10Dan-nl: "ja, that is confusing. i’m also not 100% familiar with the entire process, but i checked out the Campaign extension and it isn’t adding a " [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/125913 (owner: 10Dan-nl) [14:43:54] (03CR) 10Bartosz Dziewoński: [C: 032] Update moment.js to 2.6.0 [core] - 10https://gerrit.wikimedia.org/r/126236 (owner: 10Prtksxna) [14:44:44] (03Abandoned) 10Alex Monk: Add preference to disable leaving warning while editing [core] - 10https://gerrit.wikimedia.org/r/126977 (owner: 10Alex Monk) [14:47:09] (03Merged) 10jenkins-bot: Update moment.js to 2.6.0 [core] - 10https://gerrit.wikimedia.org/r/126236 (owner: 10Prtksxna) [14:51:16] (03PS2) 10Bartosz Dziewoński: Remove FakeTitle [core] - 10https://gerrit.wikimedia.org/r/126749 (owner: 10Chad) [14:51:18] (03CR) 10jenkins-bot: [V: 04-1] Remove FakeTitle [core] - 10https://gerrit.wikimedia.org/r/126749 (owner: 10Chad) [14:51:28] (03PS2) 10BryanDavis: [WIP] Add review settings page [wikimedia/wikimania-scholarships] - 10https://gerrit.wikimedia.org/r/126833 (owner: 10Kushal124) [14:51:35] (03PS3) 10Bartosz Dziewoński: Remove FakeTitle [core] - 10https://gerrit.wikimedia.org/r/126749 (owner: 10Chad) [14:52:05] (03CR) 10Bartosz Dziewoński: [C: 032] "Rebased, +2 per Daniel." [core] - 10https://gerrit.wikimedia.org/r/126749 (owner: 10Chad) [14:55:13] (03CR) 10Hashar: [C: 04-1] "The downstream job can be triggered as a build step of the parent job by using the parameterized trigger plugin http://ci.openstack.org/je" (031 comment) [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/126870 (owner: 10BryanDavis) [14:55:47] (03Merged) 10jenkins-bot: Remove FakeTitle [core] - 10https://gerrit.wikimedia.org/r/126749 (owner: 10Chad) [14:56:25] (03PS3) 10Kushal124: [WIP] Add review settings page [wikimedia/wikimania-scholarships] - 10https://gerrit.wikimedia.org/r/126833 [15:02:09] (03PS1) 10Manybubbles: Quoted searches with accents only find accented [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/126995 [15:02:31] (03PS2) 10Manybubbles: Quoted searches with accents only find accented [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/126995 [15:04:30] (03PS1) 10Matthias Mullie: [WIP] search [extensions/Flow] - 10https://gerrit.wikimedia.org/r/126996 [15:16:37] (03CR) 10PiRSquared17: [C: 04-1] "This can be abandoned since we just ended up adding it to the IWM (I took TTO's advice)" [extensions/WikimediaMaintenance] - 10https://gerrit.wikimedia.org/r/112920 (owner: 10Gerrit Patch Uploader) [15:24:00] (03PS4) 10Bartosz Dziewoński: Remove deprecated function mw.util.toggleToc [core] - 10https://gerrit.wikimedia.org/r/110680 (owner: 10Gerrit Patch Uploader) [15:24:02] (03PS1) 10Bartosz Dziewoński: mediawiki.toc.test: Cleanup [core] - 10https://gerrit.wikimedia.org/r/126997 [15:24:16] (03CR) 10Bartosz Dziewoński: "The tests were failing because the mediawiki.toc module was not loaded on the QUnit test page :)" [core] - 10https://gerrit.wikimedia.org/r/110680 (owner: 10Gerrit Patch Uploader) [15:29:15] (03CR) 10Bartosz Dziewoński: [C: 032] "Tests pass now and everything works as expected in manual testing. You've actually prompted me to work on bug 24134 :)" [core] - 10https://gerrit.wikimedia.org/r/110680 (owner: 10Gerrit Patch Uploader) [15:32:29] (03Merged) 10jenkins-bot: Remove deprecated function mw.util.toggleToc [core] - 10https://gerrit.wikimedia.org/r/110680 (owner: 10Gerrit Patch Uploader) [15:40:51] Project CirrusSearch-en.wikipedia.beta.wmflabs.org-linux-firefox build #9: STILL FAILING in 3 min 27 sec: https://integration.wikimedia.org/ci/job/CirrusSearch-en.wikipedia.beta.wmflabs.org-linux-firefox/9/ [15:42:37] (03CR) 10Anomie: [C: 032] Update Math and VisualEditor extensions for cherry-picks to make VE math inspector work [core] (wmf/1.23wmf22) - 10https://gerrit.wikimedia.org/r/126913 (owner: 10Catrope) [15:45:35] (03Merged) 10jenkins-bot: Update Math and VisualEditor extensions for cherry-picks to make VE math inspector work [core] (wmf/1.23wmf22) - 10https://gerrit.wikimedia.org/r/126913 (owner: 10Catrope) [15:58:10] (03CR) 10Dan-nl: "added a sample dataset and step-by-step instructions to bug 63646" [extensions/GWToolset] - 10https://gerrit.wikimedia.org/r/124376 (owner: 10Dan-nl) [16:00:21] (03PS5) 10Wctaiwan: Change UI of special page and support Flow Thanks [extensions/Thanks] - 10https://gerrit.wikimedia.org/r/125941 [16:00:21] (03CR) 10Wctaiwan: Change UI of special page and support Flow Thanks (031 comment) [extensions/Thanks] - 10https://gerrit.wikimedia.org/r/125941 (owner: 10Wctaiwan) [16:03:44] (03CR) 10Dan-nl: "added a sample dataset and step-by-step instructions to bug 63822" [extensions/GWToolset] - 10https://gerrit.wikimedia.org/r/125552 (owner: 10Dan-nl) [16:09:40] (03PS5) 10Phuedx: [WIP] Add a pre-edit anonymous signup invitation [extensions/GettingStarted] - 10https://gerrit.wikimedia.org/r/125730 [16:09:42] (03PS5) 10Phuedx: Generate a token and use it to bucket users [extensions/GettingStarted] - 10https://gerrit.wikimedia.org/r/125188 [16:15:33] (03Abandoned) 10Alexander.lehmann: XML export inserted. Therefore a special page created. [extensions/PubSubHubbub] - 10https://gerrit.wikimedia.org/r/124862 (owner: 10Alexander.lehmann) [16:24:05] (03PS1) 10Zfilipin: Run browser tests on the local machine headlessly [integration/jenkins-job-builder-config] (cloudbees) - 10https://gerrit.wikimedia.org/r/127003 [16:31:54] (03CR) 10BryanDavis: "> Whenever someone copy paste the output of a scap run, the coloring information is lost :)" [tools/scap] - 10https://gerrit.wikimedia.org/r/126851 (owner: 10BryanDavis) [16:33:44] (03CR) 10Ori.livneh: "Yes, when was the last time you were looking at a log and thought, "oh, if only I knew the log level of this record!"" [tools/scap] - 10https://gerrit.wikimedia.org/r/126851 (owner: 10BryanDavis) [16:36:33] (03CR) 10Ori.livneh: Enable customization of Vagrant and virtual machine (031 comment) [vagrant] - 10https://gerrit.wikimedia.org/r/121425 (owner: 10BryanDavis) [16:49:44] (03CR) 10BryanDavis: [C: 04-1] "I talked this over with Ori on irc. He'd like to see better type management, so I'm going to rework to use json/yaml/ruby for setting valu" [vagrant] - 10https://gerrit.wikimedia.org/r/121425 (owner: 10BryanDavis) [16:54:24] (03Abandoned) 10MaxSem: Fix response time extraction, again [extensions/ApiSandbox] - 10https://gerrit.wikimedia.org/r/126842 (owner: 10MaxSem) [16:59:26] (03CR) 10MaxSem: [C: 032] Removed 'Remember my login' preference [core] - 10https://gerrit.wikimedia.org/r/94614 (owner: 1001tonythomas) [17:00:14] Greetings. In a few minutes, we'll start a session to discuss https://www.mediawiki.org/wiki/Requests_for_comment/Phabricator over in #wikimedia-office . If you have questions, comments, concerns, you should join, and if you've never heard of it, you should probably join too. This is about replacing many tools currently used for development (including bugzilla) by one integrated tool. [17:02:44] (03Merged) 10jenkins-bot: Removed 'Remember my login' preference [core] - 10https://gerrit.wikimedia.org/r/94614 (owner: 1001tonythomas) [17:07:44] (03CR) 10Aaron Schulz: Improved HashRing usage in JobQueueFederated (032 comments) [core] - 10https://gerrit.wikimedia.org/r/124511 (owner: 10Aaron Schulz) [17:09:56] (03Abandoned) 10Krinkle: [WIP] Investigate swinging qunit test failure [core] - 10https://gerrit.wikimedia.org/r/124372 (owner: 10Krinkle) [17:15:24] (03CR) 10MaxSem: [C: 032] Rewrite getParamInfo() to actually handle caching and continuation [extensions/ApiSandbox] - 10https://gerrit.wikimedia.org/r/124334 (owner: 10Bartosz Dziewoński) [17:15:27] (03Merged) 10jenkins-bot: Rewrite getParamInfo() to actually handle caching and continuation [extensions/ApiSandbox] - 10https://gerrit.wikimedia.org/r/124334 (owner: 10Bartosz Dziewoński) [17:17:42] (03CR) 10Krinkle: [C: 032] mediawiki.toc.test: Cleanup [core] - 10https://gerrit.wikimedia.org/r/126997 (owner: 10Bartosz Dziewoński) [17:20:57] (03Merged) 10jenkins-bot: mediawiki.toc.test: Cleanup [core] - 10https://gerrit.wikimedia.org/r/126997 (owner: 10Bartosz Dziewoński) [17:22:48] (03PS4) 10Aaron Schulz: Improved HashRing usage in JobQueueFederated [core] - 10https://gerrit.wikimedia.org/r/124511 [17:29:55] (03CR) 10Anomie: [C: 04-1] "SecurePoll needs more features :(" [core] - 10https://gerrit.wikimedia.org/r/118110 (owner: 10Anomie) [17:39:28] (03PS2) 10Aaron Schulz: Support tighter rate limiting for "non-standard" thumbnails [core] - 10https://gerrit.wikimedia.org/r/126052 [17:40:34] (03PS2) 10Aaron Schulz: [WIP] Added support for CDN-only thumbnail storage [core] - 10https://gerrit.wikimedia.org/r/126210 [17:54:28] (03PS1) 10MaxSem: ApiSandbox broken because of undefined variable [extensions/ApiSandbox] (wmf/1.23wmf22) - 10https://gerrit.wikimedia.org/r/127017 [17:54:52] (03CR) 10MaxSem: [C: 032] ApiSandbox broken because of undefined variable [extensions/ApiSandbox] (wmf/1.23wmf22) - 10https://gerrit.wikimedia.org/r/127017 (owner: 10MaxSem) [17:54:55] (03Merged) 10jenkins-bot: ApiSandbox broken because of undefined variable [extensions/ApiSandbox] (wmf/1.23wmf22) - 10https://gerrit.wikimedia.org/r/127017 (owner: 10MaxSem) [17:57:01] (03PS1) 10MaxSem: Cherrypick https://gerrit.wikimedia.org/r/#/c/127017/ [core] (wmf/1.23wmf22) - 10https://gerrit.wikimedia.org/r/127018 [17:59:31] (03PS1) 10Siebrand: Skip loading PHP shims for JSON i18n files [core] (REL1_23) - 10https://gerrit.wikimedia.org/r/127020 [18:04:04] is dbname always $langwiki? [18:04:09] at least for wikipedia? [18:04:59] pretty sure [18:05:13] sister projects have names like enwikinews [18:06:10] (03CR) 10UltrasonicNXT: [C: 032 V: 032] "Must have missed this, thanks for spotting this!" [extensions/WikiForum] - 10https://gerrit.wikimedia.org/r/126952 (owner: 10Severin Anatoliy) [18:06:47] (03CR) 10Siebrand: [C: 031] "i18n/L10n reviewed." [extensions/Thanks] - 10https://gerrit.wikimedia.org/r/125941 (owner: 10Wctaiwan) [18:07:56] bawolff: yeah, ok! [18:07:57] (03CR) 10Siebrand: [C: 031] "L10n reviewed." [wikimedia/wikimania-scholarships] - 10https://gerrit.wikimedia.org/r/126833 (owner: 10Kushal124) [18:08:08] this is just for the app, so I'll just hard code it and have a large WARNING around it [18:12:33] (03CR) 10BryanDavis: [WIP] Add review settings page (031 comment) [wikimedia/wikimania-scholarships] - 10https://gerrit.wikimedia.org/r/126833 (owner: 10Kushal124) [18:13:30] (03CR) 10Hashar: [C: 031] "ori> every time someone paste me a multiple megabytes console log from Jenkins!!!" [tools/scap] - 10https://gerrit.wikimedia.org/r/126851 (owner: 10BryanDavis) [18:25:35] (03CR) 10Siebrand: [C: 04-1] "More Yay! 1 comment." (031 comment) [core] - 10https://gerrit.wikimedia.org/r/126991 (owner: 10Umherirrender) [18:29:49] (03PS2) 10BryanDavis: Run scap when config or code is updated [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/126870 [18:42:17] Project CirrusSearch-en.wikipedia.beta.wmflabs.org-linux-firefox build #10: STILL FAILING in 3 min 24 sec: https://integration.wikimedia.org/ci/job/CirrusSearch-en.wikipedia.beta.wmflabs.org-linux-firefox/10/ [18:44:20] (03PS2) 10Umherirrender: Fixed some @params documentation (tests) [core] - 10https://gerrit.wikimedia.org/r/126991 [18:44:56] (03CR) 10Umherirrender: "Patch Set 2: Addressed inline comment" (031 comment) [core] - 10https://gerrit.wikimedia.org/r/126991 (owner: 10Umherirrender) [18:44:58] (03CR) 10Siebrand: [C: 032] Fixed some @params documentation (tests) [core] - 10https://gerrit.wikimedia.org/r/126991 (owner: 10Umherirrender) [18:48:22] (03PS1) 10Phuedx: Use "article" instead of "page" on en Wikipedia [extensions/GettingStarted] - 10https://gerrit.wikimedia.org/r/127030 [18:49:02] (03PS1) 10Reedy: Fix PHP Notice on Special:Version with Scribunto enabled [extensions/Scribunto] - 10https://gerrit.wikimedia.org/r/127031 [18:49:31] (03Merged) 10jenkins-bot: Fixed some @params documentation (tests) [core] - 10https://gerrit.wikimedia.org/r/126991 (owner: 10Umherirrender) [18:55:35] (03PS2) 10Swalling: Use "article" instead of "page" on English Wikipedia only [extensions/GettingStarted] - 10https://gerrit.wikimedia.org/r/127030 (owner: 10Phuedx) [18:56:12] (03CR) 10Siebrand: Use "article" instead of "page" on English Wikipedia only (031 comment) [extensions/GettingStarted] - 10https://gerrit.wikimedia.org/r/127030 (owner: 10Phuedx) [19:01:07] cheers for https://gerrit.wikimedia.org/r/#/c/127017/ MaxSem :) [19:03:29] (03PS1) 10Reedy: Simplify SpecialVersion:listToText() [core] - 10https://gerrit.wikimedia.org/r/127115 [19:09:36] (03PS1) 10Bartosz Dziewoński: The $CHANGEDORCREATED parameter to the 'enotif_body' message will not be removed in 1.23 [core] - 10https://gerrit.wikimedia.org/r/127124 [19:09:51] (03CR) 10Bartosz Dziewoński: "Clearly we don't want to do this, I submitted https://gerrit.wikimedia.org/r/127124 instead to remove the removal note." [core] - 10https://gerrit.wikimedia.org/r/126126 (owner: 10Bartosz Dziewoński) [19:10:29] (03CR) 10Bartosz Dziewoński: "Regardless, maybe we should fuzzy this message in the languages I listed to possibly convince translators to actually update it? :)" [core] - 10https://gerrit.wikimedia.org/r/126126 (owner: 10Bartosz Dziewoński) [19:13:35] (03PS2) 10Bartosz Dziewoński: The $CHANGEDORCREATED parameter to the 'enotif_body' message will not be removed in 1.23 [core] - 10https://gerrit.wikimedia.org/r/127124 [19:14:04] (03CR) 10Nemo bis: "They *are* fuzzied. Sometimes three times. https://translatewiki.net/w/i.php?title=Special:Translations&message=MediaWiki%3AEnotif_body" [core] - 10https://gerrit.wikimedia.org/r/126126 (owner: 10Bartosz Dziewoński) [19:19:58] (03PS11) 10Anomie: HTMLForm: Add "cloner" type [core] - 10https://gerrit.wikimedia.org/r/118113 [19:20:00] (03PS10) 10Anomie: Release notes for recent HTMLForm changes [core] - 10https://gerrit.wikimedia.org/r/118114 [19:20:02] (03PS8) 10Anomie: HTMLForm: Add hide-if [core] - 10https://gerrit.wikimedia.org/r/118110 [19:20:58] (03CR) 10Jforrester: "In that case, remove them. There is no hope." [core] - 10https://gerrit.wikimedia.org/r/126126 (owner: 10Bartosz Dziewoński) [19:23:11] (03CR) 10Mattflaschen: "We might want to make the suffix -wikipedia, rather than -article, so it's more future-proof if there is some other Wikipedia-specific var" [extensions/GettingStarted] - 10https://gerrit.wikimedia.org/r/127030 (owner: 10Phuedx) [19:31:38] (03CR) 10jenkins-bot: [V: 04-1] HTMLForm: Add "cloner" type [core] - 10https://gerrit.wikimedia.org/r/118113 (owner: 10Anomie) [19:32:16] (03CR) 10jenkins-bot: [V: 04-1] HTMLForm: Add hide-if [core] - 10https://gerrit.wikimedia.org/r/118110 (owner: 10Anomie) [19:32:22] (03CR) 10Raimond Spekking: [C: 031] The $CHANGEDORCREATED parameter to the 'enotif_body' message will not be removed in 1.23 [core] - 10https://gerrit.wikimedia.org/r/127124 (owner: 10Bartosz Dziewoński) [19:36:19] (03CR) 10Brian Wolff: [C: 032] "Thanks for the patch." [core] - 10https://gerrit.wikimedia.org/r/120767 (owner: 10Robert Vogel) [19:36:45] (03PS3) 10Bartosz Dziewoński: Use ResourceLoader modules for style loading [extensions/SyntaxHighlight_GeSHi] - 10https://gerrit.wikimedia.org/r/126843 [19:37:20] (03CR) 10Bartosz Dziewoński: Use ResourceLoader modules for style loading (035 comments) [extensions/SyntaxHighlight_GeSHi] - 10https://gerrit.wikimedia.org/r/126843 (owner: 10Bartosz Dziewoński) [19:37:29] (03PS1) 10Nemo bis: Remove font choices from REL1_23 branch while the implementation is unstable [core] (REL1_23) - 10https://gerrit.wikimedia.org/r/127132 [19:38:01] oh shit, it's thursday already ... [19:39:30] (03CR) 10Bartosz Dziewoński: Use ResourceLoader modules for style loading (031 comment) [extensions/SyntaxHighlight_GeSHi] - 10https://gerrit.wikimedia.org/r/126843 (owner: 10Bartosz Dziewoński) [19:39:39] (03Merged) 10jenkins-bot: includes/Linker.php: Added hook for "Media:" links [core] - 10https://gerrit.wikimedia.org/r/120767 (owner: 10Robert Vogel) [19:41:14] (03CR) 10Thiemo Mättig (WMDE): "Note that getExtensionData() returns null for non-existing properties but getProperty() returns false. This leads to some confusion." [core] - 10https://gerrit.wikimedia.org/r/126216 (owner: 10Adrian Lang) [19:42:44] (03CR) 10Bartosz Dziewoński: [C: 032] "I'm not a fan of diverging release branches from master like this, but it seems like the best course of action right now." [core] (REL1_23) - 10https://gerrit.wikimedia.org/r/127132 (owner: 10Nemo bis) [19:45:45] (03Merged) 10jenkins-bot: Remove font choices from REL1_23 branch while the implementation is unstable [core] (REL1_23) - 10https://gerrit.wikimedia.org/r/127132 (owner: 10Nemo bis) [19:48:01] anyone any good with maintenance scripts ? [19:48:20] https://bugzilla.wikimedia.org/show_bug.cgi?id=63915 this could use some help. [19:48:40] leaving a few 100 mathjax users hanging is not really nice [19:48:58] or thousands. /me has no idea how many there are [19:49:45] <^d> I wrote most of the maintenance scripts. [19:49:46] I stopped reading at "If we need to purge every page that contains math..." and shuddered [19:49:54] Isn't there already a script to do this [19:50:01] <^d> For changing user prefs? [19:50:03] <^d> Yeah, should be [19:50:31] userOptions.php [19:58:19] bawolff: yeah one problem, it writes 1 value, and we need to write two.. [19:58:52] also the purge is only needed if you are switching to a new mode. [19:59:18] it might be smart to do that at some time, but since no one is useing that mode right now, it is less urgent [20:00:24] i wish fred hadn't approved it... this could have been handled smarter... [20:12:58] (03CR) 10TheDJ: "i propose the following for draftsstorage:" [core] - 10https://gerrit.wikimedia.org/r/5130 (owner: 10Joancreus) [20:15:36] (03PS1) 10Bartosz Dziewoński: mediawiki.mixins.less: Correctly embed images in .background-image-svg [core] - 10https://gerrit.wikimedia.org/r/127139 [20:18:09] (03CR) 10Bartosz Dziewoński: [C: 032] "Looks straightforward." [core] - 10https://gerrit.wikimedia.org/r/115095 (owner: 10Legoktm) [20:21:34] (03Merged) 10jenkins-bot: Add 'mw-anonuserlink' class for anonymous users [core] - 10https://gerrit.wikimedia.org/r/115095 (owner: 10Legoktm) [20:22:20] (03PS1) 10Manybubbles: Move some page text into another field [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/127140 [20:25:42] spagewmf: hey, could you look at my fix for https://bugzilla.wikimedia.org/show_bug.cgi?id=63606 ("Create account's Simple captcha is badly laid out in latest .mw-ui-vform")? i think we should do this in time for 1.23 release [20:25:44] superm401: ^ [20:26:19] (03CR) 10Manybubbles: [C: 04-1] Move some page text into another field [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/127140 (owner: 10Manybubbles) [20:28:44] (03PS4) 10Chad: Clean up job queue length script [extensions/WikimediaMaintenance] - 10https://gerrit.wikimedia.org/r/126145 [20:31:05] (03PS2) 10Manybubbles: Start building an auxiliary text field [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/127140 [20:32:49] (03PS1) 10MaxSem: Cherrypick https://gerrit.wikimedia.org/r/#/c/127010/ [core] (wmf/1.24wmf1) - 10https://gerrit.wikimedia.org/r/127144 [20:35:11] (03CR) 10EBernhardson: [C: 032] API list=flow: Don't set _element directly [extensions/Flow] - 10https://gerrit.wikimedia.org/r/126192 (owner: 10Legoktm) [20:35:20] (03PS1) 10MaxSem: Cherrypick https://gerrit.wikimedia.org/r/#/c/127010/ [core] (wmf/1.23wmf22) - 10https://gerrit.wikimedia.org/r/127145 [20:38:02] (03CR) 10EBernhardson: [C: 032] API: Don't set _element directly, part two [extensions/Flow] - 10https://gerrit.wikimedia.org/r/126198 (owner: 10Legoktm) [20:39:04] (03PS3) 10Manybubbles: Start building an auxiliary text field [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/127140 [20:39:38] (03PS4) 10Manybubbles: Start building an auxiliary text field [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/127140 [20:40:10] (03Abandoned) 10EBernhardson: Relegate binary uuid's to the backend storage [extensions/Flow] - 10https://gerrit.wikimedia.org/r/125767 (owner: 10EBernhardson) [20:40:33] (03CR) 10EBernhardson: "this patch was previously If2a9ab9e6c2da305f2d488691f8bd3e291753d96 somehow the Change-Id changed." [extensions/Flow] - 10https://gerrit.wikimedia.org/r/126815 (owner: 10EBernhardson) [20:41:11] (03CR) 10Legoktm: [C: 04-1] "Also needs a rebase." (031 comment) [extensions/BetaFeatures] - 10https://gerrit.wikimedia.org/r/121876 (owner: 10Jforrester) [20:41:54] (03CR) 10Chad: [C: 032 V: 032] Stop using SearchEngine::userHighlightPrefs() [extensions/SphinxSearch] - 10https://gerrit.wikimedia.org/r/126186 (owner: 10Chad) [20:42:46] any suggestions for how to speed up Linker::userToolLinks ? Rendering a discussion with 58 different users results in this less than desirable profile: http://i.imgur.com/uTseme3.png [20:43:33] that works out to ~23 ms for each user passed into Linker::userToolLinks [20:44:50] iirc nike had a blog post about it [20:46:07] ebernhardson: Are the User objects you are feeding it already have the user id preloaded? [20:46:19] If not, probably more efficient to get that data in batch [20:46:57] ah no it was 20 KiB memory not 20 ms :) and another Linker https://gerrit.wikimedia.org/r/#/c/29879/2/utils/MessageTable.php,cm [20:47:27] or wait, that method takes a user id, so that query wouldn't be in the profiling [20:47:30] so ignore me :) [20:48:14] (03CR) 10Aaron Schulz: [C: 032] Clean up job queue length script [extensions/WikimediaMaintenance] - 10https://gerrit.wikimedia.org/r/126145 (owner: 10Chad) [20:48:18] (03Merged) 10jenkins-bot: Clean up job queue length script [extensions/WikimediaMaintenance] - 10https://gerrit.wikimedia.org/r/126145 (owner: 10Chad) [20:48:50] (03PS5) 10Manybubbles: Add an auxiliary text field [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/127140 [20:50:09] (03Abandoned) 10Manybubbles: Don't search text wrapped in nosearch class [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/112500 (owner: 10Manybubbles) [20:50:13] bawolff: hmm, we have the user id and user name, but not sure it both are loaded will check [20:50:34] (03PS1) 10Umherirrender: Fixed some @params documentation (maintenance) [core] - 10https://gerrit.wikimedia.org/r/127151 [20:50:53] bawolff: oh :) [20:51:58] (03PS1) 10PleaseStand: Update documentation for $wgExtensionMessagesFiles [core] - 10https://gerrit.wikimedia.org/r/127152 [20:54:04] (03CR) 10PleaseStand: "Doc fix: Id8212fca" [core] - 10https://gerrit.wikimedia.org/r/125925 (owner: 10PleaseStand) [20:55:51] ebernhardson: isn't it possible to precache the "redlink state" of all the pages this is going to link to? [20:57:00] yeah, using a LinkBatch object. That would probably speed things up quite a bit [20:58:24] ebernhardson: and i think blockLink() should be using linkKnown() instead of link() [20:58:49] (since it currently does a lot of unnecessary work to verify that 'Block' is in fact a valid special page name) [20:59:48] ebernhardson: can you try this and see if it actually speeds anything up? [21:00:51] MatmaRex: thats already been done through linkbatch [21:01:01] MatmaRex: this is just rendering, no db queries [21:01:45] * ebernhardson even wrote a nifty profile visualization for you all so you can see when queries are being run in relation to your other code :) [21:03:08] ebernhardson: hmm, you sure? this userTalkLink() takes silly long compared to the other methods [21:04:12] ebernhardson: another optimization would be caching all the wfMessage(...)->escaped() calls. we do that in some places where we reuse the same messages a lot, ChangesList for example i think [21:04:16] MatmaRex: yes i'm sure, its rediculously obvious in the profile visualization i built if your doing queries or if they are all batched up front [21:04:32] bawolff: i remember asking you a few months ago about why #ifexist is expensive and regular links aren't, and you said it's because regular links can be checked all at once, but #ifexist's can't. what about transclusions though? they have to be checked individually, but they're not expensive [21:04:54] and in fact you can abuse transclusions to simulate an ifexist without incrementing the expensive count [21:05:08] might #ifexist not need to count as expensive? [21:05:38] (03CR) 10Anomie: [C: 04-1] "This breaks the code in common/Hooks.php that tries to unset this. I'll have a look at the bug tomorrow probably." [extensions/Scribunto] - 10https://gerrit.wikimedia.org/r/127031 (owner: 10Reedy) [21:05:50] jackmcbarn: hmm, good question [21:06:19] and doesn't the same logic apply to mw.title.new? [21:06:25] (03CR) 10Reedy: "I've actually fixed Special:Version too in https://gerrit.wikimedia.org/r/127115" [extensions/Scribunto] - 10https://gerrit.wikimedia.org/r/127031 (owner: 10Reedy) [21:06:29] I imagine people tend to push the boundry a lot more with #ifexists then transclusions (Just a guess) [21:07:41] mw.title.new does increment expensive count [21:08:23] right [21:08:27] i'm saying it shouldn't either [21:09:07] How would you simulate #ifexist using templates? [21:10:06] (03CR) 10Bartosz Dziewoński: "We probably could, but I think that should be under another prop name." [core] - 10https://gerrit.wikimedia.org/r/126848 (owner: 10Bartosz Dziewoński) [21:10:18] bawolff: try to transclude it and see if the output is [[Template:template name]] [21:10:35] jackmcbarn: oh yeah, I guess you can do that now easily with lua [21:11:14] jackmcbarn: I don't really know the answer to your question, perhaps try asking Tim-away [21:13:29] also, i notice calling frame:expandTemplate{name = 'X1'} before mw.title.new('Template:X1') makes the latter not count as expensive anymore [21:15:06] mw.title.new only counts things as expensive if it has to go to the db to get the info, the expandTemplate already does that [21:16:10] I see what you mean about mw.title.new seeming kind of silly, if expandTempalte doesn't count [21:17:28] i think part of the issue is right now horrifically slow things like PAGESINCAT count the same as things that happen all the time, like title lookups [21:17:31] .... [21:24:08] (03PS1) 10Jackmcbarn: Don't count #ifexist as expensive anymore [extensions/ParserFunctions] - 10https://gerrit.wikimedia.org/r/127160 [21:27:20] (03PS2) 10Legoktm: API: Add prop=flowinfo to detect if Flow is enabled on a page [extensions/Flow] - 10https://gerrit.wikimedia.org/r/111255 [21:27:37] (03CR) 10Legoktm: API: Add prop=flowinfo to detect if Flow is enabled on a page [extensions/Flow] - 10https://gerrit.wikimedia.org/r/111255 (owner: 10Legoktm) [21:34:03] (03CR) 10Chad: [C: 032] Quoted searches with accents only find accented [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/126995 (owner: 10Manybubbles) [21:34:11] (03Merged) 10jenkins-bot: Quoted searches with accents only find accented [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/126995 (owner: 10Manybubbles) [21:36:51] MaxSem: ping [21:37:00] pong [21:37:05] (03PS1) 10Jackmcbarn: Don't count loading titles as expensive [extensions/Scribunto] - 10https://gerrit.wikimedia.org/r/127161 [21:37:35] I have a user with a too large watch list. According to https://www.mediawiki.org/wiki/Thread:Project:Support_desk/how_to_empty_a_too_large_watchlist_%3F you can empty it? [21:38:49] sjoerddebruin: does the api work for you? [21:39:00] I don't have experience jackmcbarn [21:39:21] (03CR) 10jenkins-bot: [V: 04-1] Don't count loading titles as expensive [extensions/Scribunto] - 10https://gerrit.wikimedia.org/r/127161 (owner: 10Jackmcbarn) [21:39:41] sjoerddebruin, I don't have server access ATM, you'll have to ask someone else:( [21:40:05] Do you know somebody? [21:40:25] sjoerddebruin: your best bet is to use the api and do it yourself. go to Special:ApiSandbox and get a partial list through query, then unwatch the ones you get [21:40:30] repeat until you can get to the raw watchlist [21:40:51] sjoerddebruin, ask at #wikimedia-operations [21:41:49] MaxSem: Okay, thanks. [21:42:29] (03CR) 10Chad: [C: 032] Don't add a filter if not needed [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/126975 (owner: 10Manybubbles) [21:42:38] (03Merged) 10jenkins-bot: Don't add a filter if not needed [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/126975 (owner: 10Manybubbles) [21:45:33] (03PS2) 10Jackmcbarn: Don't count loading titles as expensive [extensions/Scribunto] - 10https://gerrit.wikimedia.org/r/127161 [21:47:46] (03CR) 10jenkins-bot: [V: 04-1] Don't count loading titles as expensive [extensions/Scribunto] - 10https://gerrit.wikimedia.org/r/127161 (owner: 10Jackmcbarn) [21:50:00] (03PS3) 10Jackmcbarn: Don't count loading titles as expensive [extensions/Scribunto] - 10https://gerrit.wikimedia.org/r/127161 [21:51:27] (03CR) 10jenkins-bot: [V: 04-1] Don't count loading titles as expensive [extensions/Scribunto] - 10https://gerrit.wikimedia.org/r/127161 (owner: 10Jackmcbarn) [21:52:24] (03PS4) 10Jackmcbarn: Don't count loading titles as expensive [extensions/Scribunto] - 10https://gerrit.wikimedia.org/r/127161 [21:54:56] (03CR) 10Jdlrobson: "Bueller! :)" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/125907 (owner: 10Jdlrobson) [21:56:14] (03CR) 10Legoktm: API: Add prop=flowinfo to detect if Flow is enabled on a page (033 comments) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/111255 (owner: 10Legoktm) [22:03:32] (03CR) 10Swalling: [C: 04-1] "Can we please discuss this in an appropriate bug report first?" [core] - 10https://gerrit.wikimedia.org/r/125980 (owner: 10Gerrit Patch Uploader) [22:11:46] (03PS2) 10BryanDavis: Remove logging level from colorized logs [tools/scap] - 10https://gerrit.wikimedia.org/r/126851 [22:12:41] (03CR) 10BryanDavis: [C: 032] "+1 +1 == +2" [tools/scap] - 10https://gerrit.wikimedia.org/r/126851 (owner: 10BryanDavis) [22:12:50] (03Merged) 10jenkins-bot: Remove logging level from colorized logs [tools/scap] - 10https://gerrit.wikimedia.org/r/126851 (owner: 10BryanDavis) [22:17:43] (03CR) 10Jorm: "Can we see some before/after screenshots of this change?" [core] - 10https://gerrit.wikimedia.org/r/125980 (owner: 10Gerrit Patch Uploader) [22:17:51] (03CR) 10Swalling: "Ping?" [extensions/GettingStarted] - 10https://gerrit.wikimedia.org/r/122856 (owner: 10Phuedx) [22:20:51] (03PS3) 10Jforrester: Remove the "About Beta Features" and "discuss Beta Features" links [extensions/BetaFeatures] - 10https://gerrit.wikimedia.org/r/121876 [22:20:53] (03CR) 10jenkins-bot: [V: 04-1] Remove the "About Beta Features" and "discuss Beta Features" links [extensions/BetaFeatures] - 10https://gerrit.wikimedia.org/r/121876 (owner: 10Jforrester) [22:21:02] (03CR) 10Jforrester: Remove the "About Beta Features" and "discuss Beta Features" links (031 comment) [extensions/BetaFeatures] - 10https://gerrit.wikimedia.org/r/121876 (owner: 10Jforrester) [22:23:39] (03PS4) 10Jforrester: Remove the "About Beta Features" and "discuss Beta Features" links [extensions/BetaFeatures] - 10https://gerrit.wikimedia.org/r/121876 [22:30:31] ori, pizzzacat is wanting to do something in node that requires mongodb -- it looks like you wrote a mongodb puppet module -- I was wondering where you've used that? [22:31:02] *and the general amount of pain running a mongodb install will cause [22:33:55] (03PS1) 10Mwalker: Moving stuff over from mw/etx/ocg [services/ocg-collection] (refs/meta/config) - 10https://gerrit.wikimedia.org/r/127173 [22:34:07] (03CR) 10Mwalker: [C: 032 V: 032] Moving stuff over from mw/etx/ocg [services/ocg-collection] (refs/meta/config) - 10https://gerrit.wikimedia.org/r/127173 (owner: 10Mwalker) [22:40:37] mwalker: it was provisioned on vanadium before. i think it's a pretty good module -- it's pretty thin as you can see. it's a rewrite of a generic one that we were using previously. [22:41:03] i think as long as the version of mongo that we have packaged in apt works, it'd be pretty painless [22:43:00] heh; fair enough [22:43:08] do you know if we still are using it anywhere? [22:56:38] greg-g: https://gerrit.wikimedia.org/r/#/c/94614/ was merged [22:56:46] I think this will rollout next week with the train? [22:59:18] StevenW: starting next thursday, yeah (ie: the next train, not the one that left this morning) [22:59:23] ok [22:59:32] (03CR) 10Edokter: "I have to make a bug report for every change? Seems redundant." [core] - 10https://gerrit.wikimedia.org/r/125980 (owner: 10Gerrit Patch Uploader) [22:59:53] StevenW: I haven't really looked at it, but backports are available as always :) [23:07:11] (03PS1) 10Ori.livneh: Add GlobalCssJs [core] (wmf/1.24wmf1) - 10https://gerrit.wikimedia.org/r/127176 [23:07:47] (03PS1) 10MaxSem: Boil the oceans and kill ResourceLoaderGetStartupModules [core] - 10https://gerrit.wikimedia.org/r/127177 [23:07:57] greg-g: we're not in a hurry on that. It's just Preferences clean up [23:08:04] ori: getting close to the 30 day mark of the conf change in https://bugzilla.wikimedia.org/show_bug.cgi?id=61227 [23:08:37] (03CR) 10MaxSem: [C: 04-2] "Pending a discussion." [core] - 10https://gerrit.wikimedia.org/r/127177 (owner: 10MaxSem) [23:09:01] StevenW: /me nods [23:09:21] since parser cache is stored for 30 days (longer than most other stuff, rev cache is only 7) then most still should be in the new format by now [23:09:31] StevenW: You'll need a backport to 1.24wmf1 to meet the timeline in your email. [23:09:59] (03CR) 10Ori.livneh: [C: 032] Cherrypick https://gerrit.wikimedia.org/r/#/c/127017/ [core] (wmf/1.23wmf22) - 10https://gerrit.wikimedia.org/r/127018 (owner: 10MaxSem) [23:11:15] mw.o and testwikis went to 1.24wmf1 today. That patch will be in 1.24wmf2 by default which will hit test/wm.o next Thursday. [23:11:47] MaxSem: is https://gerrit.wikimedia.org/r/#/c/124272/ good to go from your perspective? [23:12:13] you -1'd it before, so a +1 would be useful as an indication [23:12:43] ori, yes - I specifically nominated it for deployment to be around [23:12:56] * ori nods [23:13:09] (03Merged) 10jenkins-bot: Cherrypick https://gerrit.wikimedia.org/r/#/c/127017/ [core] (wmf/1.23wmf22) - 10https://gerrit.wikimedia.org/r/127018 (owner: 10MaxSem) [23:13:24] MaxSem: Thanks for merging https://gerrit.wikimedia.org/r/#/c/94614/ :-) [23:15:19] (03CR) 10MZMcBride: "The logic here is pretty twisted. I can't imagine this change being merged." [extensions/ParserFunctions] - 10https://gerrit.wikimedia.org/r/127160 (owner: 10Jackmcbarn) [23:16:30] (03CR) 10Legoktm: [C: 031] Add GlobalCssJs [core] (wmf/1.24wmf1) - 10https://gerrit.wikimedia.org/r/127176 (owner: 10Ori.livneh) [23:19:26] (03CR) 10Ori.livneh: [C: 032] Cherrypick https://gerrit.wikimedia.org/r/#/c/127010/ [core] (wmf/1.24wmf1) - 10https://gerrit.wikimedia.org/r/127144 (owner: 10MaxSem) [23:19:42] (03CR) 10Ori.livneh: [C: 032] Cherrypick https://gerrit.wikimedia.org/r/#/c/127010/ [core] (wmf/1.23wmf22) - 10https://gerrit.wikimedia.org/r/127145 (owner: 10MaxSem) [23:21:22] (03PS1) 10Legoktm: Add GlobalCssJs [tools/release] - 10https://gerrit.wikimedia.org/r/127181 [23:23:29] (03Merged) 10jenkins-bot: Cherrypick https://gerrit.wikimedia.org/r/#/c/127010/ [core] (wmf/1.24wmf1) - 10https://gerrit.wikimedia.org/r/127144 (owner: 10MaxSem) [23:23:45] (03Merged) 10jenkins-bot: Cherrypick https://gerrit.wikimedia.org/r/#/c/127010/ [core] (wmf/1.23wmf22) - 10https://gerrit.wikimedia.org/r/127145 (owner: 10MaxSem) [23:24:00] (03PS9) 10EBernhardson: First stab at new template rendering in php [extensions/Flow] (frontend-rewrite) - 10https://gerrit.wikimedia.org/r/125358 [23:31:18] (03PS2) 10Ori.livneh: Add GlobalCssJs [core] (wmf/1.24wmf1) - 10https://gerrit.wikimedia.org/r/127176 [23:31:22] (03CR) 10Ori.livneh: [C: 032] Add GlobalCssJs [core] (wmf/1.24wmf1) - 10https://gerrit.wikimedia.org/r/127176 (owner: 10Ori.livneh) [23:32:00] (03CR) 10Ori.livneh: [C: 032] Add GlobalCssJs [tools/release] - 10https://gerrit.wikimedia.org/r/127181 (owner: 10Legoktm) [23:33:20] (03Merged) 10jenkins-bot: Add GlobalCssJs [tools/release] - 10https://gerrit.wikimedia.org/r/127181 (owner: 10Legoktm) [23:35:34] (03Merged) 10jenkins-bot: Add GlobalCssJs [core] (wmf/1.24wmf1) - 10https://gerrit.wikimedia.org/r/127176 (owner: 10Ori.livneh) [23:38:09] (03PS10) 10EBernhardson: First stab at new template rendering in php [extensions/Flow] (frontend-rewrite) - 10https://gerrit.wikimedia.org/r/125358 [23:38:24] (03CR) 10jenkins-bot: [V: 04-1] First stab at new template rendering in php [extensions/Flow] (frontend-rewrite) - 10https://gerrit.wikimedia.org/r/125358 (owner: 10EBernhardson) [23:40:37] (03PS11) 10EBernhardson: First stab at new template rendering in php [extensions/Flow] (frontend-rewrite) - 10https://gerrit.wikimedia.org/r/125358 [23:43:23] (03PS1) 10Ori.livneh: Add GlobalCssJs [core] (wmf/1.23wmf22) - 10https://gerrit.wikimedia.org/r/127183 [23:45:08] (03CR) 10Ori.livneh: [C: 032 V: 032] Add GlobalCssJs [core] (wmf/1.23wmf22) - 10https://gerrit.wikimedia.org/r/127183 (owner: 10Ori.livneh) [23:52:18] GlobalCssJs is actually happening. [23:52:20] This is pretty exciting. [23:52:48] Of course this means I've jinxed it and now it'll explode. [23:54:25] only test & test2