[00:02:10] (03CR) 10CSteipp: "It would be much more useful if these could be run against non production sites, so they can be verified in development instead of after a" [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/125740 (owner: 10Zfilipin) [00:09:24] (03CR) 10Bsitu: "What we save to cache is a copy of the database row via toStorageRow(), this only has the binary value of a UUID. Every time we load data" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/123691 (owner: 10Matthias Mullie) [00:11:57] (03CR) 10Mwalker: Preserve textarea state when building WikiEditor UI (031 comment) [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/124567 (owner: 10TheDJ) [00:14:16] (03PS1) 10Ori.livneh: HHVM: Add static.mime-types.hdf [vagrant] - 10https://gerrit.wikimedia.org/r/126176 [00:14:43] (03CR) 10Ori.livneh: [C: 032] HHVM: Add static.mime-types.hdf [vagrant] - 10https://gerrit.wikimedia.org/r/126176 (owner: 10Ori.livneh) [00:14:46] (03Merged) 10jenkins-bot: HHVM: Add static.mime-types.hdf [vagrant] - 10https://gerrit.wikimedia.org/r/126176 (owner: 10Ori.livneh) [00:21:31] (03PS1) 10Chad: Get rid of Title::indexTitle and Title::getIndexTitle() [core] - 10https://gerrit.wikimedia.org/r/126177 [00:22:20] (03PS1) 10Legoktm: API: Use a standard edit token [extensions/Flow] - 10https://gerrit.wikimedia.org/r/126179 [00:24:14] (03CR) 10EBernhardson: "there is another patch i'm working on to make the cache store alphadecimal's, so conversion will only happen when loading from database. " (032 comments) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/123691 (owner: 10Matthias Mullie) [00:31:31] why does "img { vertical-align: middle }" exist? [00:39:23] (03PS1) 10Aaron Schulz: Fixed broken filebackend test for "describe" [core] - 10https://gerrit.wikimedia.org/r/126183 [00:48:31] (03CR) 10Adamw: "soulless ding: please remove .idea files, and add .jshintignore for the 3rd-party stuff that the linter is choking on." [extensions/FundraisingChart] - 10https://gerrit.wikimedia.org/r/124774 (owner: 10Ssmith) [00:52:22] (03PS1) 10Chad: Stop using SearchEngine::userHighlightPrefs() [extensions/SphinxSearch] - 10https://gerrit.wikimedia.org/r/126186 [00:56:23] (03CR) 10Adamw: [C: 04-1] "I would quite merge it, just kill those .idea's first" (034 comments) [extensions/FundraisingChart] - 10https://gerrit.wikimedia.org/r/124774 (owner: 10Ssmith) [00:57:51] (03CR) 10Bsitu: [C: 04-1] Separate style modules from JS modules (032 comments) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/125907 (owner: 10Jdlrobson) [01:56:27] (03CR) 10Springle: "Bug 63917 schema change is done." [extensions/Flow] - 10https://gerrit.wikimedia.org/r/110090 (owner: 10Werdna) [02:14:27] (03PS1) 10Ori.livneh: Only run landscape-sysinfo where available [vagrant] - 10https://gerrit.wikimedia.org/r/126189 [02:14:40] (03CR) 10Ori.livneh: [C: 032] Only run landscape-sysinfo where available [vagrant] - 10https://gerrit.wikimedia.org/r/126189 (owner: 10Ori.livneh) [02:14:43] (03Merged) 10jenkins-bot: Only run landscape-sysinfo where available [vagrant] - 10https://gerrit.wikimedia.org/r/126189 (owner: 10Ori.livneh) [03:32:49] (03PS1) 10Legoktm: API list=flow: Don't set _element directly [extensions/Flow] - 10https://gerrit.wikimedia.org/r/126192 [03:51:03] (03CR) 10Parent5446: "It's an unfortunate design, but Anomie is still correct. If you look at the ApiBase code, it calls functions on $mMainModule that are only" [core] - 10https://gerrit.wikimedia.org/r/120827 (owner: 10Thiemo Mättig (WMDE)) [05:02:14] (03PS1) 10Krinkle: Resolve redirects for mediawiki.org (mediawiki.org -> www.mediawiki.org) [extensions/BetaFeatures] - 10https://gerrit.wikimedia.org/r/126196 [05:02:16] (03PS1) 10Krinkle: Consistently use example.org in tests [extensions/BetaFeatures] - 10https://gerrit.wikimedia.org/r/126197 [05:02:24] (03CR) 10jenkins-bot: [V: 04-1] Consistently use example.org in tests [extensions/BetaFeatures] - 10https://gerrit.wikimedia.org/r/126197 (owner: 10Krinkle) [05:05:05] (03PS1) 10Legoktm: API: Don't set _element directly, part two [extensions/Flow] - 10https://gerrit.wikimedia.org/r/126198 [05:08:24] (03CR) 10Krinkle: JSON i18n shim: Only register LocalisationCacheRecache handler once (031 comment) [core] - 10https://gerrit.wikimedia.org/r/125706 (owner: 10PleaseStand) [05:10:21] (03PS2) 10Umherirrender: Add @since to Skin::getAllowedSkins [core] - 10https://gerrit.wikimedia.org/r/126037 [05:33:54] (03CR) 10Legoktm: [C: 032] Add @since to Skin::getAllowedSkins [core] - 10https://gerrit.wikimedia.org/r/126037 (owner: 10Umherirrender) [05:34:13] (03PS1) 10Legoktm: Add @since to Skin::getAllowedSkins [core] (REL1_23) - 10https://gerrit.wikimedia.org/r/126200 [05:34:22] (03CR) 10Legoktm: [C: 032] Add @since to Skin::getAllowedSkins [core] (REL1_23) - 10https://gerrit.wikimedia.org/r/126200 (owner: 10Legoktm) [05:35:59] (03PS21) 1001tonythomas: Removed 'Remember my login' preference [core] - 10https://gerrit.wikimedia.org/r/94614 [05:37:49] (03CR) 10jenkins-bot: [V: 04-1] Removed 'Remember my login' preference [core] - 10https://gerrit.wikimedia.org/r/94614 (owner: 1001tonythomas) [05:38:39] (03Merged) 10jenkins-bot: Add @since to Skin::getAllowedSkins [core] - 10https://gerrit.wikimedia.org/r/126037 (owner: 10Umherirrender) [05:39:58] (03Merged) 10jenkins-bot: Add @since to Skin::getAllowedSkins [core] (REL1_23) - 10https://gerrit.wikimedia.org/r/126200 (owner: 10Legoktm) [05:44:09] (03PS2) 10EBernhardson: Serialize UUID objects directly into cache [extensions/Flow] - 10https://gerrit.wikimedia.org/r/125767 [05:44:26] (03CR) 10jenkins-bot: [V: 04-1] Serialize UUID objects directly into cache [extensions/Flow] - 10https://gerrit.wikimedia.org/r/125767 (owner: 10EBernhardson) [05:44:59] (03PS3) 10EBernhardson: Relegate binary uuid's to the backend storage [extensions/Flow] - 10https://gerrit.wikimedia.org/r/125767 [05:45:15] (03CR) 10jenkins-bot: [V: 04-1] Relegate binary uuid's to the backend storage [extensions/Flow] - 10https://gerrit.wikimedia.org/r/125767 (owner: 10EBernhardson) [05:48:15] (03CR) 10AndyRussG: WIP Domain layer and DB persistence with data mapper (032 comments) [extensions/Campaigns] (wip/editorcampaigns) - 10https://gerrit.wikimedia.org/r/123781 (owner: 10AndyRussG) [05:51:07] (03CR) 10EBernhardson: [C: 04-1] "still isn't working right, perhaps this needs a different approach?" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/125767 (owner: 10EBernhardson) [06:13:30] (03PS1) 10Legoktm: [WIP/POC] Live notifications of new notifications [extensions/Echo] - 10https://gerrit.wikimedia.org/r/126201 [06:13:40] (03CR) 10jenkins-bot: [V: 04-1] [WIP/POC] Live notifications of new notifications [extensions/Echo] - 10https://gerrit.wikimedia.org/r/126201 (owner: 10Legoktm) [06:14:35] (03PS2) 10Legoktm: [WIP/POC] Live notifications of new notifications [extensions/Echo] - 10https://gerrit.wikimedia.org/r/126201 [06:17:13] (03PS3) 10Legoktm: [POC] Live notifications of new notifications [extensions/Echo] - 10https://gerrit.wikimedia.org/r/126201 [06:17:20] (03Abandoned) 10Legoktm: [POC] Live notifications of new notifications [extensions/Echo] - 10https://gerrit.wikimedia.org/r/126201 (owner: 10Legoktm) [06:20:03] (03PS3) 10Jlloyd: Add notification when a student's assigned article's talk page has been edited [extensions/EducationProgram] - 10https://gerrit.wikimedia.org/r/118101 [06:24:59] (03CR) 10Nemo bis: [C: 04-1] "See previous comment" [extensions/EducationProgram] - 10https://gerrit.wikimedia.org/r/118101 (owner: 10Jlloyd) [06:28:49] (03CR) 10Jlloyd: "This patch was just a rebase. I'm sending up the corrected patch (with a better commit message) now." [extensions/EducationProgram] - 10https://gerrit.wikimedia.org/r/118101 (owner: 10Jlloyd) [06:30:58] (03PS4) 10Jlloyd: Add notifications for article talk page changes [extensions/EducationProgram] - 10https://gerrit.wikimedia.org/r/118101 [06:31:02] (03CR) 10jenkins-bot: [V: 04-1] Add notifications for article talk page changes [extensions/EducationProgram] - 10https://gerrit.wikimedia.org/r/118101 (owner: 10Jlloyd) [06:32:48] (03PS5) 10Jlloyd: Add notifications for article page changes [extensions/EducationProgram] - 10https://gerrit.wikimedia.org/r/118101 [06:37:01] (03PS6) 10Jlloyd: Add notifications for article page changes [extensions/EducationProgram] - 10https://gerrit.wikimedia.org/r/118101 [06:37:06] (03CR) 10jenkins-bot: [V: 04-1] Add notifications for article page changes [extensions/EducationProgram] - 10https://gerrit.wikimedia.org/r/118101 (owner: 10Jlloyd) [06:40:50] (03PS2) 10TheDJ: Preserve textarea state when building WikiEditor UI [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/124567 [06:57:20] (03PS7) 10Jlloyd: Add notifications for article page changes [extensions/EducationProgram] - 10https://gerrit.wikimedia.org/r/118101 [06:57:23] (03CR) 10jenkins-bot: [V: 04-1] Add notifications for article page changes [extensions/EducationProgram] - 10https://gerrit.wikimedia.org/r/118101 (owner: 10Jlloyd) [07:05:47] (03PS22) 1001tonythomas: Removed 'Remember my login' preference [core] - 10https://gerrit.wikimedia.org/r/94614 [07:07:07] (03PS1) 10Ori.livneh: Make sure ~vagrant/.gem is owned by vagrant:vagrant [vagrant] - 10https://gerrit.wikimedia.org/r/126207 [07:08:04] (03CR) 10jenkins-bot: [V: 04-1] Removed 'Remember my login' preference [core] - 10https://gerrit.wikimedia.org/r/94614 (owner: 1001tonythomas) [07:10:57] (03PS2) 10Ori.livneh: Make sure ~vagrant/.gem is owned by vagrant:vagrant [vagrant] - 10https://gerrit.wikimedia.org/r/126207 [07:20:09] (03CR) 10Adamw: "Hehe, I'm really running out of things to pick on." [extensions/Campaigns] (wip/editorcampaigns) - 10https://gerrit.wikimedia.org/r/123781 (owner: 10AndyRussG) [07:22:17] (03PS23) 1001tonythomas: Removed 'Remember my login' preference [core] - 10https://gerrit.wikimedia.org/r/94614 [07:30:36] (03PS10) 10AndyRussG: WIP Domain layer and DB persistence with data mapper [extensions/Campaigns] (wip/editorcampaigns) - 10https://gerrit.wikimedia.org/r/123781 [07:34:17] (03CR) 10AndyRussG: "This patch set includes just the improvement in TypesafeEnum and a minor change to the domain's outward-facing interface." [extensions/Campaigns] (wip/editorcampaigns) - 10https://gerrit.wikimedia.org/r/123781 (owner: 10AndyRussG) [07:43:27] (03PS5) 10AndyRussG: Participation on create account via campaign url [extensions/Campaigns] (wip/editorcampaigns) - 10https://gerrit.wikimedia.org/r/119258 [07:44:06] (03CR) 10AndyRussG: "This patch set is just a rebase." [extensions/Campaigns] (wip/editorcampaigns) - 10https://gerrit.wikimedia.org/r/119258 (owner: 10AndyRussG) [07:46:09] (03PS6) 10AndyRussG: WIP Participation on create account via campaign url [extensions/Campaigns] (wip/editorcampaigns) - 10https://gerrit.wikimedia.org/r/119258 [07:48:57] (03CR) 10Siebrand: [C: 04-1] "Per Timo's inline comment." [core] - 10https://gerrit.wikimedia.org/r/125706 (owner: 10PleaseStand) [08:26:14] (03PS1) 10Aaron Schulz: Added support for CDN-only thumbnail storage [core] - 10https://gerrit.wikimedia.org/r/126210 [08:35:55] (03CR) 10Hashar: "Fair enough and good for me. Giving Ori a change to review as well :-)" [tools/scap] - 10https://gerrit.wikimedia.org/r/125515 (owner: 10BryanDavis) [08:42:45] (03CR) 10Legoktm: Make abstract Config class truly implementation-agnostic (031 comment) [core] - 10https://gerrit.wikimedia.org/r/109850 (owner: 10Ori.livneh) [08:46:59] (03PS7) 10AndyRussG: WIP Participation on create account via campaign url [extensions/Campaigns] (wip/editorcampaigns) - 10https://gerrit.wikimedia.org/r/119258 [08:49:16] (03CR) 10TheDJ: [C: 04-1] "There are some outstanding issues as mentioned in PS15." [core] - 10https://gerrit.wikimedia.org/r/53968 (owner: 10Eranroz) [08:50:07] (03CR) 10Siebrand: [C: 031] "i18n/L10n reviewed." [extensions/EducationProgram] - 10https://gerrit.wikimedia.org/r/118101 (owner: 10Jlloyd) [09:31:52] (03PS1) 10Adrian Lang: Add ParserOutput::unsetProperty, add tests [core] - 10https://gerrit.wikimedia.org/r/126216 [09:46:42] (03CR) 10Addshore: [C: 032] Refactor API code and fix invalid input handling [extensions/Thanks] - 10https://gerrit.wikimedia.org/r/125940 (owner: 10Wctaiwan) [09:47:00] (03Merged) 10jenkins-bot: Refactor API code and fix invalid input handling [extensions/Thanks] - 10https://gerrit.wikimedia.org/r/125940 (owner: 10Wctaiwan) [10:12:22] (03CR) 10Fomafix: "The module mediawiki.toc gets not loaded on live preview because of bug 24134." [core] - 10https://gerrit.wikimedia.org/r/110680 (owner: 10Gerrit Patch Uploader) [10:15:25] (03PS4) 10Phuedx: [WIP] Add a pre-edit anonymous signup invitation [extensions/GettingStarted] - 10https://gerrit.wikimedia.org/r/125730 [10:17:53] (03PS3) 10Daniel Kinzler: Changing a message's lang must reset cached text. [core] - 10https://gerrit.wikimedia.org/r/125388 [10:57:46] (03CR) 10QChris: [C: 032] reapply scores on trivial rebases/patchsets [All-Projects] (refs/meta/config) - 10https://gerrit.wikimedia.org/r/124891 (owner: 10Hashar) [10:59:48] legoktm: Hi! You around ? [11:03:26] (03PS1) 10QChris: [DO NOT SUBMIT] Score Test 1/2 [test/gerrit-ping] - 10https://gerrit.wikimedia.org/r/126224 [11:03:28] (03PS1) 10QChris: [DO NOT SUBMIT] Score Test 2/2 [test/gerrit-ping] - 10https://gerrit.wikimedia.org/r/126225 [11:04:12] (03CR) 10QChris: [C: 031 V: 031] [DO NOT SUBMIT] Score Test 2/2 [test/gerrit-ping] - 10https://gerrit.wikimedia.org/r/126225 (owner: 10QChris) [11:04:49] (03PS2) 10QChris: [DO NOT SUBMIT] Score test 2/2 [test/gerrit-ping] - 10https://gerrit.wikimedia.org/r/126225 [11:05:51] (03PS2) 10QChris: [DO NOT SUBMIT] Score Test 1/2 [test/gerrit-ping] - 10https://gerrit.wikimedia.org/r/126224 [11:06:08] (03CR) 10QChris: [V: 031] [DO NOT SUBMIT] Score test 2/2 [test/gerrit-ping] - 10https://gerrit.wikimedia.org/r/126225 (owner: 10QChris) [11:06:12] (03PS3) 10QChris: [DO NOT SUBMIT] Score test 2/2 [test/gerrit-ping] - 10https://gerrit.wikimedia.org/r/126225 [11:06:33] (03Abandoned) 10QChris: [DO NOT SUBMIT] Score test 2/2 [test/gerrit-ping] - 10https://gerrit.wikimedia.org/r/126225 (owner: 10QChris) [11:06:42] (03Abandoned) 10QChris: [DO NOT SUBMIT] Score Test 1/2 [test/gerrit-ping] - 10https://gerrit.wikimedia.org/r/126224 (owner: 10QChris) [11:18:19] (03CR) 10Prtksxna: "Abandoning this patch. The relevant fix is now at - https://gerrit.wikimedia.org/r/#/c/126226/" [extensions/TextExtracts] - 10https://gerrit.wikimedia.org/r/125689 (owner: 10Prtksxna) [11:18:30] (03Abandoned) 10Prtksxna: Add classes and elements to the exclusion list [extensions/TextExtracts] - 10https://gerrit.wikimedia.org/r/125689 (owner: 10Prtksxna) [11:22:43] (03PS1) 10Hashar: Zuul status page: version and last reconfig [integration/docroot] - 10https://gerrit.wikimedia.org/r/126228 [11:30:12] (03CR) 10Hashar: [C: 032] "Upgraded Zuul" [integration/docroot] - 10https://gerrit.wikimedia.org/r/126228 (owner: 10Hashar) [11:30:38] (03PS2) 10Hashar: Zuul status page: version and last reconfig [integration/docroot] - 10https://gerrit.wikimedia.org/r/126228 [11:30:54] (03CR) 10Hashar: [C: 032] Zuul status page: version and last reconfig [integration/docroot] - 10https://gerrit.wikimedia.org/r/126228 (owner: 10Hashar) [11:30:57] (03Merged) 10jenkins-bot: Zuul status page: version and last reconfig [integration/docroot] - 10https://gerrit.wikimedia.org/r/126228 (owner: 10Hashar) [11:31:39] (03CR) 10Hashar: "Yields:" [integration/docroot] - 10https://gerrit.wikimedia.org/r/126228 (owner: 10Hashar) [11:35:09] hi I want to start contributing to wikimedia, any links for how to get started? [12:03:18] (03CR) 10Thiemo Mättig (WMDE): [C: 031] "I checked and yes, the LinksUpdate class is able to delete properties from the page_props table. See the line $this->incrTableUpdate( 'pag" [core] - 10https://gerrit.wikimedia.org/r/126216 (owner: 10Adrian Lang) [12:15:51] (03CR) 10Siebrand: [C: 04-1] "Per PS1. qqq missing." [extensions/GettingStarted] - 10https://gerrit.wikimedia.org/r/125730 (owner: 10Phuedx) [12:20:21] (03CR) 10Siebrand: [C: 031] "L10n reviewed." [extensions/Flow] - 10https://gerrit.wikimedia.org/r/119640 (owner: 10Bsitu) [12:21:50] mishravikas: https://www.mediawiki.org/wiki/How_to_become_a_MediaWiki_hacker [12:22:35] mishravikas: my recommendation is to think of some new feature you want in mediawiki, then find out how to write that as an extension [12:23:15] DanielK_WMDE: ok thanks for the help [12:23:39] mishravikas: also, note the difference between Wikimedia and MediaWiki ;) [12:24:34] DanielK_WMDE: oh yes :p [12:25:23] mishravikas: ...and thus, #mediawiki vs. #wikimedia-dev [12:58:14] (03PS1) 10Prtksxna: Update moment.js to 2.6.0 [core] - 10https://gerrit.wikimedia.org/r/126236 [13:00:47] (03PS2) 10Prtksxna: Update moment.js to 2.6.0 [core] - 10https://gerrit.wikimedia.org/r/126236 [13:03:42] (03PS1) 10Matthias Mullie: Fix 2 typos in ForceSearchIndex option descriptions [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/126239 [13:15:28] (03CR) 10Anomie: "> You did read my comment, did you? Making a base class depend on it's child is wrong." [core] - 10https://gerrit.wikimedia.org/r/120827 (owner: 10Thiemo Mättig (WMDE)) [13:20:46] (03CR) 10Manybubbles: [C: 032] Fix 2 typos in ForceSearchIndex option descriptions [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/126239 (owner: 10Matthias Mullie) [13:20:51] (03Merged) 10jenkins-bot: Fix 2 typos in ForceSearchIndex option descriptions [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/126239 (owner: 10Matthias Mullie) [13:23:30] (03CR) 10Nikerabbit: [C: 032] Changing a message's lang must reset cached text. [core] - 10https://gerrit.wikimedia.org/r/125388 (owner: 10Daniel Kinzler) [13:26:45] (03Merged) 10jenkins-bot: Changing a message's lang must reset cached text. [core] - 10https://gerrit.wikimedia.org/r/125388 (owner: 10Daniel Kinzler) [13:35:19] (03PS1) 10Matthias Mullie: Fix some typos in ForceSearchIndex options descriptions [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/126246 [13:36:54] (03CR) 10Prtksxna: [C: 032 V: 032] "Works! I am sorry for the delay, I must've not tested this properly." [extensions/Popups] - 10https://gerrit.wikimedia.org/r/123790 (owner: 10JGonera) [13:41:10] (03CR) 10Thiemo Mättig (WMDE): "I still have a hard time to understand what the code is supposed to do. So yes, revamping this is very helpful." (034 comments) [core] - 10https://gerrit.wikimedia.org/r/121604 (owner: 10Adrian Lang) [13:49:46] (03CR) 10Nikerabbit: [C: 04-1] Skip loading PHP shims for JSON i18n files [core] - 10https://gerrit.wikimedia.org/r/125925 (owner: 10PleaseStand) [13:51:25] (03PS5) 10Thiemo Mättig (WMDE): Use precise ApiMain/ApiQuery type hints in all API modules [core] - 10https://gerrit.wikimedia.org/r/120827 [13:52:30] (03CR) 10Yuvipanda: [C: 032] Fix some typos in ForceSearchIndex options descriptions [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/126246 (owner: 10Matthias Mullie) [13:52:39] (03Merged) 10jenkins-bot: Fix some typos in ForceSearchIndex options descriptions [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/126246 (owner: 10Matthias Mullie) [13:56:35] (03CR) 10Anomie: [C: 032] "Ok, let's do this." (031 comment) [core] - 10https://gerrit.wikimedia.org/r/123518 (owner: 10PleaseStand) [13:57:27] (03CR) 10jenkins-bot: [V: 04-1] FormatJson: Make it possible to change the indent string [core] - 10https://gerrit.wikimedia.org/r/123518 (owner: 10PleaseStand) [13:59:05] (03PS3) 10Anomie: FormatJson: Make it possible to change the indent string [core] - 10https://gerrit.wikimedia.org/r/123518 (owner: 10PleaseStand) [13:59:18] (03CR) 10Umherirrender: "Doing it as in setExtensionData looks better in my opinion (a given null as value trigger a unset)" [core] - 10https://gerrit.wikimedia.org/r/126216 (owner: 10Adrian Lang) [14:00:11] (03CR) 10Thiemo Mättig (WMDE): "I refuse to make a broken design worse and therefor removed ApiBase from this patch. Feel free to submit your own." [core] - 10https://gerrit.wikimedia.org/r/120827 (owner: 10Thiemo Mättig (WMDE)) [14:00:22] (03PS4) 10Anomie: FormatJson: Make it possible to change the indent string [core] - 10https://gerrit.wikimedia.org/r/123518 (owner: 10PleaseStand) [14:00:58] (03CR) 10Anomie: [C: 032] "PS3: Rebase for RELEASE-NOTES-1.23" [core] - 10https://gerrit.wikimedia.org/r/123518 (owner: 10PleaseStand) [14:01:32] (03PS3) 10Umherirrender: Fix RevDel_RevisionItem::getAuthorNameField to work for ips [core] - 10https://gerrit.wikimedia.org/r/125568 [14:06:30] (03Merged) 10jenkins-bot: FormatJson: Make it possible to change the indent string [core] - 10https://gerrit.wikimedia.org/r/123518 (owner: 10PleaseStand) [14:07:51] (03PS3) 10Siebrand: Update moment.js to 2.6.0 [core] - 10https://gerrit.wikimedia.org/r/126236 (owner: 10Prtksxna) [14:08:45] (03CR) 1001tonythomas: "Rebased! Please comment if anything more needs to be done here" [core] - 10https://gerrit.wikimedia.org/r/94614 (owner: 1001tonythomas) [14:11:53] (03CR) 10Siebrand: [C: 04-1] "Please change this to use JSON based i18n with $wgMessagesDirs instead of $wgExtensionMessagesFiles." [extensions/Petition] - 10https://gerrit.wikimedia.org/r/126011 (owner: 10Pcoombe) [14:14:44] (03CR) 10Siebrand: Commit work so far (033 comments) [extensions/Petition] - 10https://gerrit.wikimedia.org/r/126011 (owner: 10Pcoombe) [14:19:49] (03PS1) 10Siebrand: FormatJson: Make it possible to change the indent string [core] (REL1_23) - 10https://gerrit.wikimedia.org/r/126253 [14:22:13] (03CR) 10Anomie: API list=flow: Don't set _element directly (032 comments) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/126192 (owner: 10Legoktm) [14:25:15] (03CR) 10Anomie: [C: 031] "Please do! Who's in charge of the 1.23 release?" [core] (REL1_23) - 10https://gerrit.wikimedia.org/r/126253 (owner: 10Siebrand) [14:25:44] (03CR) 10Siebrand: "Mark/Markus, but you can just merge this, Anomie." [core] (REL1_23) - 10https://gerrit.wikimedia.org/r/126253 (owner: 10Siebrand) [14:27:38] (03CR) 10Siebrand: [C: 032] Moved 'Edit review' user preferences into the 'Recent changes' tab [extensions/FlaggedRevs] - 10https://gerrit.wikimedia.org/r/125996 (owner: 10Tinaj1234) [14:27:44] (03Merged) 10jenkins-bot: Moved 'Edit review' user preferences into the 'Recent changes' tab [extensions/FlaggedRevs] - 10https://gerrit.wikimedia.org/r/125996 (owner: 10Tinaj1234) [14:29:01] (03PS1) 10Thiemo Mättig (WMDE): Documentation for page_props getter in ParserOutput [core] - 10https://gerrit.wikimedia.org/r/126254 [14:30:57] (03PS1) 10Odder: Update my e-mail address used for Gerrit [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/126255 [14:33:35] (03PS1) 10Manybubbles: Tag all cirrus browser tests with @phantomjs [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/126256 [14:38:47] (03CR) 10Zfilipin: [C: 032] Tag all cirrus browser tests with @phantomjs [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/126256 (owner: 10Manybubbles) [14:38:56] (03Merged) 10jenkins-bot: Tag all cirrus browser tests with @phantomjs [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/126256 (owner: 10Manybubbles) [14:43:09] (03PS1) 10Zfilipin: Run only scenarios tagged both @clean and @phantomjs [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/126258 [14:45:23] (03CR) 10Siebrand: "Looks like there's only 1 extension in Gerrit that actually uses this: Lingo. That extension hasn't been worked on for a while, as it also" [core] - 10https://gerrit.wikimedia.org/r/126121 (owner: 10Bartosz Dziewoński) [14:53:01] (03PS2) 10Pcoombe: Initial commit [extensions/Petition] - 10https://gerrit.wikimedia.org/r/126011 [14:56:03] (03CR) 10Siebrand: [C: 04-1] Make the global objects documentation consistent in Setup.php (031 comment) [core] - 10https://gerrit.wikimedia.org/r/122875 (owner: 10IAlex) [14:57:25] (03CR) 10Siebrand: [C: 031] "i18n/L10n reviewed." [extensions/TimelineTable] - 10https://gerrit.wikimedia.org/r/38485 (owner: 10thibaultmarin) [15:07:28] (03CR) 10Pcoombe: "comment replies" (0315 comments) [extensions/Petition] - 10https://gerrit.wikimedia.org/r/126011 (owner: 10Pcoombe) [15:13:50] (03CR) 10Jforrester: [C: 032] Resolve redirects for mediawiki.org (mediawiki.org -> www.mediawiki.org) [extensions/BetaFeatures] - 10https://gerrit.wikimedia.org/r/126196 (owner: 10Krinkle) [15:13:57] (03Merged) 10jenkins-bot: Resolve redirects for mediawiki.org (mediawiki.org -> www.mediawiki.org) [extensions/BetaFeatures] - 10https://gerrit.wikimedia.org/r/126196 (owner: 10Krinkle) [15:15:46] (03CR) 10Jforrester: "This loses the relative structure (Foo vs. Talk:Foo), the structure (Extension:Foo) and the domain (mediawiki.org) from this implicit docu" [extensions/BetaFeatures] - 10https://gerrit.wikimedia.org/r/126197 (owner: 10Krinkle) [15:21:48] (03CR) 10Jforrester: [C: 032] "Per http://lists.wikimedia.org/pipermail/wikitech-l/2014-April/076002.html – we'll need to remove this from the 1.24 release notes, though" [core] (REL1_23) - 10https://gerrit.wikimedia.org/r/126253 (owner: 10Siebrand) [15:25:12] (03Merged) 10jenkins-bot: FormatJson: Make it possible to change the indent string [core] (REL1_23) - 10https://gerrit.wikimedia.org/r/126253 (owner: 10Siebrand) [15:25:17] (03PS1) 10Jforrester: Remove bug 63444 RELEASE-NOTES-1.24 duplicate of RELEASE-NOTES-1.23 [core] - 10https://gerrit.wikimedia.org/r/126266 [15:25:38] (03CR) 10Siebrand: [C: 032] Remove bug 63444 RELEASE-NOTES-1.24 duplicate of RELEASE-NOTES-1.23 [core] - 10https://gerrit.wikimedia.org/r/126266 (owner: 10Jforrester) [15:25:46] siebrand: Thanks! [15:25:48] (03CR) 10Mwjames: "Adding Stephan to this thread since he is the maintainer of the Lingo extension." [core] - 10https://gerrit.wikimedia.org/r/126121 (owner: 10Bartosz Dziewoński) [15:26:22] (03CR) 10Jforrester: "Done in 5c6b0d0fe1413." [core] (REL1_23) - 10https://gerrit.wikimedia.org/r/126253 (owner: 10Siebrand) [15:30:49] (03Merged) 10jenkins-bot: Remove bug 63444 RELEASE-NOTES-1.24 duplicate of RELEASE-NOTES-1.23 [core] - 10https://gerrit.wikimedia.org/r/126266 (owner: 10Jforrester) [15:36:01] (03PS1) 10Jforrester: Update OOjs UI to v0.1.0-pre (5c1c6de63a) [core] - 10https://gerrit.wikimedia.org/r/126376 [15:36:22] Hi there [15:36:32] I may have found a huge hole in oversight [15:36:54] <^d> That's no good :( [15:37:18] not at all... it is exposed through Popups [15:37:36] Who can I talk to? [15:38:00] <^d> Best idea is either to submit a bug in Bugzilla to the "Security" component or send an e-mail to security@wikimedia.org [15:38:30] OK, I think I'll fire an email [15:39:28] (03PS1) 10Manybubbles: Add URL parameter to turn on new highlighter [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/126423 [15:39:59] (03CR) 10Siebrand: [C: 031] "i18n/L10n reviewed." (031 comment) [extensions/Petition] - 10https://gerrit.wikimedia.org/r/126011 (owner: 10Pcoombe) [15:41:06] through... Popups? [15:42:43] yes [15:43:40] whci probably means it's a leak in the API [15:44:26] (03PS1) 10Hashar: .gitreview file for the cloudbees branch [integration/jenkins-job-builder-config] (cloudbees) - 10https://gerrit.wikimedia.org/r/126489 [15:45:10] (03CR) 10Matthias Mullie: [C: 031] "Haven't tested, but LGTM" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/125947 (owner: 10Legoktm) [15:45:46] mail sent [15:46:13] (03CR) 10Zfilipin: [C: 032] .gitreview file for the cloudbees branch [integration/jenkins-job-builder-config] (cloudbees) - 10https://gerrit.wikimedia.org/r/126489 (owner: 10Hashar) [15:46:36] (03Merged) 10jenkins-bot: .gitreview file for the cloudbees branch [integration/jenkins-job-builder-config] (cloudbees) - 10https://gerrit.wikimedia.org/r/126489 (owner: 10Hashar) [15:47:21] <^d> Edokter: Just saw it hit the list, thanks for reporting. [15:47:41] no problem, hope you can reproduce. [15:49:46] (03CR) 10WikidataJenkins: "Build Successful" [extensions/PubSubHubbub] - 10https://gerrit.wikimedia.org/r/126538 (owner: 10L10n-bot) [15:49:54] (03PS1) 10Hashar: Merge Zeljko branch 'cloudbees' [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/126563 [15:50:18] (03CR) 10Ori.livneh: [C: 032] Make sure ~vagrant/.gem is owned by vagrant:vagrant [vagrant] - 10https://gerrit.wikimedia.org/r/126207 (owner: 10Ori.livneh) [15:50:27] (03Merged) 10jenkins-bot: Make sure ~vagrant/.gem is owned by vagrant:vagrant [vagrant] - 10https://gerrit.wikimedia.org/r/126207 (owner: 10Ori.livneh) [15:50:39] (03CR) 10jenkins-bot: [V: 04-1] Merge Zeljko branch 'cloudbees' [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/126563 (owner: 10Hashar) [15:52:40] (03Abandoned) 10Hashar: Merge Zeljko branch 'cloudbees' [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/126563 (owner: 10Hashar) [15:53:32] (03PS1) 10Daniel Kinzler: Log Redis errors when failing to post jobs. [core] (wmf/1.23wmf19) - 10https://gerrit.wikimedia.org/r/126611 [15:54:03] DanielK_WMDE: only wmf19? [15:54:14] <^d> siebrand: About? [15:54:15] ori: don't ask me why. [15:54:43] anomie: we are investiagting an issue we have with job queues on wikidata. could you have a look at https://gerrit.wikimedia.org/r/#/c/126611/ ? we need more data in the logs. [15:54:44] * ori doesn't. [15:54:51] :P [15:59:40] (03CR) 10EBernhardson: "I should point out some of these api methods are going away, or being heavily refactored soon. Parts of that are in https://gerrit.wikime" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/126192 (owner: 10Legoktm) [16:01:12] (03CR) 10EBernhardson: "to clarify, by api methods i don't mean the ones called against the api, i mean the methods in the various implementations that output api" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/126192 (owner: 10Legoktm) [16:02:42] (03PS1) 10Anomie: Actually put release note for bug 63444 in RELEASE-NOTES-1.23 in master [core] - 10https://gerrit.wikimedia.org/r/126664 [16:03:09] (03CR) 10Anomie: [C: 032] "Simple doc update" [core] - 10https://gerrit.wikimedia.org/r/126664 (owner: 10Anomie) [16:06:59] (03Merged) 10jenkins-bot: Actually put release note for bug 63444 in RELEASE-NOTES-1.23 in master [core] - 10https://gerrit.wikimedia.org/r/126664 (owner: 10Anomie) [16:07:34] (03PS2) 10Daniel Kinzler: Log Redis errors when failing to post jobs. [core] (wmf/1.23wmf19) - 10https://gerrit.wikimedia.org/r/126611 [16:26:17] (03PS1) 10Reedy: Log Redis errors when failing to post jobs. [core] - 10https://gerrit.wikimedia.org/r/126666 [16:27:01] (03CR) 10Reedy: "1.23wmf19 isn't currently deployed. 1.23wmf21 and 1.23wmf22 are" [core] (wmf/1.23wmf19) - 10https://gerrit.wikimedia.org/r/126611 (owner: 10Daniel Kinzler) [16:27:13] (03Abandoned) 10Reedy: Log Redis errors when failing to post jobs. [core] (wmf/1.23wmf19) - 10https://gerrit.wikimedia.org/r/126611 (owner: 10Daniel Kinzler) [16:27:35] (03PS1) 10Reedy: Log Redis errors when failing to post jobs. [core] (wmf/1.23wmf21) - 10https://gerrit.wikimedia.org/r/126667 [16:29:11] (03CR) 10Reedy: [C: 032] Log Redis errors when failing to post jobs. [core] (wmf/1.23wmf21) - 10https://gerrit.wikimedia.org/r/126667 (owner: 10Reedy) [16:29:31] (03PS2) 10Umherirrender: Fixed some @params documentation [core] - 10https://gerrit.wikimedia.org/r/126034 [16:33:48] (03CR) 10jenkins-bot: [V: 04-1] Log Redis errors when failing to post jobs. [core] (wmf/1.23wmf21) - 10https://gerrit.wikimedia.org/r/126667 (owner: 10Reedy) [16:34:38] (03CR) 10Reedy: [V: 032] Log Redis errors when failing to post jobs. [core] (wmf/1.23wmf21) - 10https://gerrit.wikimedia.org/r/126667 (owner: 10Reedy) [16:35:05] (03PS9) 10Physikerwelt: WIP: Using DB2 as Database backend. [extensions/MathSearch] - 10https://gerrit.wikimedia.org/r/116929 [16:35:26] (03PS1) 10Reedy: Log Redis errors when failing to post jobs. [core] (wmf/1.23wmf22) - 10https://gerrit.wikimedia.org/r/126670 [16:35:35] (03CR) 10Reedy: [C: 032 V: 032] Log Redis errors when failing to post jobs. [core] (wmf/1.23wmf22) - 10https://gerrit.wikimedia.org/r/126670 (owner: 10Reedy) [16:38:53] (03CR) 10jenkins-bot: [V: 04-1] WIP: Using DB2 as Database backend. [extensions/MathSearch] - 10https://gerrit.wikimedia.org/r/116929 (owner: 10Physikerwelt) [16:40:26] (03PS10) 10Physikerwelt: WIP: Using DB2 as Database backend. [extensions/MathSearch] - 10https://gerrit.wikimedia.org/r/116929 [16:40:30] (03CR) 10jenkins-bot: [V: 04-1] WIP: Using DB2 as Database backend. [extensions/MathSearch] - 10https://gerrit.wikimedia.org/r/116929 (owner: 10Physikerwelt) [17:21:15] (03PS1) 10Umherirrender: Allow LogEntry::setRelations to work with array(tag => value) [core] - 10https://gerrit.wikimedia.org/r/126724 [17:31:56] (03CR) 10Reedy: "bug 64007" [core] - 10https://gerrit.wikimedia.org/r/123498 (owner: 10Aaron Schulz) [17:35:50] (03CR) 10Legoktm: API list=flow: Don't set _element directly (031 comment) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/126192 (owner: 10Legoktm) [17:39:44] aude, Reedy: any news? [17:39:51] DanielK_WMDE: AaronSchulz broke it [17:40:07] we got it [17:40:15] https://gerrit.wikimedia.org/r/#/c/123498/ [17:40:45] Reedy: :P [17:41:11] DanielK_WMDE: Amusingly, open JobQueueGroup.php in PhpStorm, and PhpStorm knew it was a potential error [17:41:31] (03PS1) 10Reedy: Revert "Removed useless JobQueue return values" [core] - 10https://gerrit.wikimedia.org/r/126731 [17:41:54] (03PS2) 10Reedy: Revert "Removed useless JobQueue return values" [core] - 10https://gerrit.wikimedia.org/r/126731 [17:42:07] Reedy: seems easier to just change that method [17:42:16] though reverting branch is fine [17:42:32] [18:41:10] god. who merged this? this is wrong. [17:42:32] [18:41:18] just revert https://github.com/wikimedia/mediawiki-core/commit/bc8c89d2df39d64f15770d29874904ebcff2f131 [17:42:33] [18:41:20] it's wrong. [17:42:49] Reedy, AaronSchulz: uh, yea, the return value was redundant, but still - there was an error reported by redis, no? [17:42:57] so there must be an underlieing issue? [17:43:18] There's a false positive of an error [17:43:22] (03CR) 10Aude: [C: 032] "JobQueueGroup is incompatible with this change and is therefore breaking things" [core] - 10https://gerrit.wikimedia.org/r/126731 (owner: 10Reedy) [17:43:40] hrrrm. [17:43:46] yay :P [17:44:20] (03PS1) 10Reedy: Revert "Removed useless JobQueue return values" [core] (wmf/1.23wmf22) - 10https://gerrit.wikimedia.org/r/126737 [17:44:36] (03CR) 10Aude: [C: 032] Revert "Removed useless JobQueue return values" [core] (wmf/1.23wmf22) - 10https://gerrit.wikimedia.org/r/126737 (owner: 10Reedy) [17:48:58] (03PS4) 10Daniel Kinzler: (bug 58032) introducing pp_sortkey. [core] - 10https://gerrit.wikimedia.org/r/122349 [17:50:09] (03Merged) 10jenkins-bot: Revert "Removed useless JobQueue return values" [core] - 10https://gerrit.wikimedia.org/r/126731 (owner: 10Reedy) [17:50:32] (03Merged) 10jenkins-bot: Revert "Removed useless JobQueue return values" [core] (wmf/1.23wmf22) - 10https://gerrit.wikimedia.org/r/126737 (owner: 10Reedy) [17:51:35] hmm [17:56:54] (03PS1) 10Aaron Schulz: Revert "Revert "Removed useless JobQueue return values"" [core] - 10https://gerrit.wikimedia.org/r/126741 [17:59:50] (03CR) 10Aaron Schulz: "No this isn't related to that." [core] - 10https://gerrit.wikimedia.org/r/125895 (owner: 10Aaron Schulz) [18:04:15] (03PS2) 10Chad: Get rid of Title::indexTitle and Title::getIndexTitle() [core] - 10https://gerrit.wikimedia.org/r/126177 [18:06:10] (03CR) 10Nikerabbit: [C: 031] Allow LogEntry::setRelations to work with array(tag => value) [core] - 10https://gerrit.wikimedia.org/r/126724 (owner: 10Umherirrender) [18:08:28] (03PS1) 10UltrasonicNXT: Fix errors with foreach statement [extensions/SocialProfile] - 10https://gerrit.wikimedia.org/r/126745 [18:09:12] (03CR) 10Aaron Schulz: [C: 032] Get rid of Title::indexTitle and Title::getIndexTitle() [core] - 10https://gerrit.wikimedia.org/r/126177 (owner: 10Chad) [18:09:16] (03PS1) 10Thiemo Mättig (WMDE): Finish removing boolean return values from JobQueue code [core] - 10https://gerrit.wikimedia.org/r/126746 [18:10:18] (03PS2) 10Catrope: Update OOjs UI to v0.1.0-pre (c58b498573) [core] - 10https://gerrit.wikimedia.org/r/126376 (owner: 10Jforrester) [18:10:49] (03CR) 10Jforrester: [C: 032] Update OOjs UI to v0.1.0-pre (c58b498573) [core] - 10https://gerrit.wikimedia.org/r/126376 (owner: 10Jforrester) [18:11:15] (03PS1) 10Chad: Remove FakeTitle [core] - 10https://gerrit.wikimedia.org/r/126749 [18:11:18] ^d: https://gerrit.wikimedia.org/r/#/c/126741/1 heh [18:11:43] <^d> rvv. [18:12:19] (03CR) 10Thiemo Mättig (WMDE): "I created a possible follow-up to this patch that fixes the problem we had, see I19fe58a939706d3f7594d937e0bcad6d97c52a50." [core] - 10https://gerrit.wikimedia.org/r/123498 (owner: 10Aaron Schulz) [18:16:21] (03Merged) 10jenkins-bot: Get rid of Title::indexTitle and Title::getIndexTitle() [core] - 10https://gerrit.wikimedia.org/r/126177 (owner: 10Chad) [18:16:49] (03CR) 10jenkins-bot: [V: 04-1] Finish removing boolean return values from JobQueue code [core] - 10https://gerrit.wikimedia.org/r/126746 (owner: 10Thiemo Mättig (WMDE)) [18:17:56] (03Merged) 10jenkins-bot: Update OOjs UI to v0.1.0-pre (c58b498573) [core] - 10https://gerrit.wikimedia.org/r/126376 (owner: 10Jforrester) [18:22:40] (03PS2) 10Aaron Schulz: Revert "Revert "Removed useless JobQueue return values"" [core] - 10https://gerrit.wikimedia.org/r/126741 [18:23:20] ^d: I guess https://gerrit.wikimedia.org/r/#/c/126746/1 can be rebased on top of that [18:26:17] (03PS1) 10Deepali: Set a default value for $wgBookManagerv2JsonFrontend [extensions/BookManagerv2] - 10https://gerrit.wikimedia.org/r/126805 [18:27:03] (03PS4) 10Spage: Add Parsoid's CSS modules [extensions/Flow] - 10https://gerrit.wikimedia.org/r/124787 [18:27:16] (03PS2) 10Deepali: Set a default value for $wgBookManagerv2JsonFrontend [extensions/BookManagerv2] - 10https://gerrit.wikimedia.org/r/126805 [18:29:13] (03CR) 10Spage: "PS2 adds Parsoid styles using the hook. The Parsoid change is merged, so 'ext.parsoid.styles' is ready for use." (032 comments) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/124787 (owner: 10Spage) [18:30:37] (03PS1) 10EBernhardson: Resolve batch query and only replace red links [extensions/Flow] - 10https://gerrit.wikimedia.org/r/126809 [18:30:53] (03CR) 10jenkins-bot: [V: 04-1] Resolve batch query and only replace red links [extensions/Flow] - 10https://gerrit.wikimedia.org/r/126809 (owner: 10EBernhardson) [18:30:56] (03PS1) 10Manybubbles: Allow user configured refresh interval [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/126810 [18:31:05] (03CR) 10Chad: [C: 032] Revert "Revert "Removed useless JobQueue return values"" [core] - 10https://gerrit.wikimedia.org/r/126741 (owner: 10Aaron Schulz) [18:34:04] (03CR) 10Chad: Allow user configured refresh interval (031 comment) [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/126810 (owner: 10Manybubbles) [18:34:15] (03Merged) 10jenkins-bot: Revert "Revert "Removed useless JobQueue return values"" [core] - 10https://gerrit.wikimedia.org/r/126741 (owner: 10Aaron Schulz) [18:34:38] (03PS1) 10EBernhardson: Use Templating::userToolLinks to call Linker less often [extensions/Flow] - 10https://gerrit.wikimedia.org/r/126812 [18:34:42] (03CR) 10Chad: [C: 032] Add URL parameter to turn on new highlighter [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/126423 (owner: 10Manybubbles) [18:35:56] (03Merged) 10jenkins-bot: Add URL parameter to turn on new highlighter [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/126423 (owner: 10Manybubbles) [18:35:58] (03PS2) 10EBernhardson: Resolve batch query and only replace red links [extensions/Flow] - 10https://gerrit.wikimedia.org/r/126809 [18:36:48] (03PS2) 10Manybubbles: Allow user configured refresh interval [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/126810 [18:37:02] (03CR) 10Manybubbles: Allow user configured refresh interval (031 comment) [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/126810 (owner: 10Manybubbles) [18:37:54] (03PS4) 10EBernhardson: UUID revamp [extensions/Flow] - 10https://gerrit.wikimedia.org/r/123691 (owner: 10Matthias Mullie) [18:37:57] (03PS1) 10EBernhardson: Relegate binary uuid's to the backend storage [extensions/Flow] - 10https://gerrit.wikimedia.org/r/126815 [18:40:12] (03PS1) 10Kushal124: [WIP]Review settings page [wikimedia/wikimania-scholarships] - 10https://gerrit.wikimedia.org/r/126816 [18:46:09] (03CR) 10Spage: "action=history already works, and includes/FlowActions.php maps board-history to history "for backwards compatibility". So what is this f" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/111924 (owner: 10Legoktm) [18:46:32] (03PS5) 10EBernhardson: UUID revamp [extensions/Flow] - 10https://gerrit.wikimedia.org/r/123691 (owner: 10Matthias Mullie) [18:46:35] (03PS2) 10EBernhardson: Relegate binary uuid's to the backend storage [extensions/Flow] - 10https://gerrit.wikimedia.org/r/126815 [18:48:48] (03PS10) 10Kushal124: [WIP]Make page for configuring review settings. [wikimedia/wikimania-scholarships] - 10https://gerrit.wikimedia.org/r/125372 [18:48:56] (03CR) 10Ori.livneh: [C: 04-1] Make logging destinations configurable (032 comments) [tools/scap] - 10https://gerrit.wikimedia.org/r/125515 (owner: 10BryanDavis) [18:50:20] (03PS3) 10Siebrand: Localisation updates from https://translatewiki.net. [core] - 10https://gerrit.wikimedia.org/r/126814 (owner: 10L10n-bot) [18:50:48] (03Abandoned) 10Siebrand: Localisation updates from https://translatewiki.net. [core] - 10https://gerrit.wikimedia.org/r/126814 (owner: 10L10n-bot) [18:50:59] (03CR) 10Aaron Schulz: "This needs a rebase now" [core] - 10https://gerrit.wikimedia.org/r/126746 (owner: 10Thiemo Mättig (WMDE)) [19:07:26] (03PS2) 10Thiemo Mättig (WMDE): Finish removing boolean return values from JobQueue code [core] - 10https://gerrit.wikimedia.org/r/126746 [19:12:53] (03CR) 10Thiemo Mättig (WMDE): "Rebased. As I said, feel free to hujack this patch. ;-)" (031 comment) [core] - 10https://gerrit.wikimedia.org/r/126746 (owner: 10Thiemo Mättig (WMDE)) [19:14:04] (03CR) 10Chad: [C: 032] Allow user configured refresh interval [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/126810 (owner: 10Manybubbles) [19:14:12] (03Merged) 10jenkins-bot: Allow user configured refresh interval [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/126810 (owner: 10Manybubbles) [19:35:02] (03CR) 10Mwalker: [C: 032] "Tested to work in Firefox and Google Chrome. If it doesn't work for IE users it should not affect them beyond not working..." [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/124567 (owner: 10TheDJ) [19:35:08] (03Merged) 10jenkins-bot: Preserve textarea state when building WikiEditor UI [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/124567 (owner: 10TheDJ) [19:35:27] (03PS1) 10Chad: Remove 2 unused Special:Search hooks [core] - 10https://gerrit.wikimedia.org/r/126831 [19:40:29] (03CR) 10Hashar: [C: 04-1] "The email address needs to be added to the other pipeline as well :-D Sorry." (032 comments) [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/126255 (owner: 10Odder) [19:43:06] (03PS1) 10Kushal124: [WIP] Add review settings page [wikimedia/wikimania-scholarships] - 10https://gerrit.wikimedia.org/r/126833 [19:46:50] (03Abandoned) 10Kushal124: [WIP]Make page for configuring review settings. [wikimedia/wikimania-scholarships] - 10https://gerrit.wikimedia.org/r/125372 (owner: 10Kushal124) [19:47:34] (03Restored) 10Kushal124: [WIP]Make page for configuring review settings. [wikimedia/wikimania-scholarships] - 10https://gerrit.wikimedia.org/r/125372 (owner: 10Kushal124) [19:50:06] (03CR) 10Mwalker: [C: 032] "Testing locally; this didn't break IE7; but I didn't see the original issue either (could not reproduce the bug)." [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/124607 (owner: 10TheDJ) [19:50:21] (03Merged) 10jenkins-bot: Cleanup borders of wikiEditor [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/124607 (owner: 10TheDJ) [19:52:46] (03PS11) 10BryanDavis: Make review settings configurable [wikimedia/wikimania-scholarships] - 10https://gerrit.wikimedia.org/r/125372 (owner: 10Kushal124) [19:52:56] (03PS12) 10Kushal124: Make review settings configurable [wikimedia/wikimania-scholarships] - 10https://gerrit.wikimedia.org/r/125372 [19:53:00] (03PS1) 10Daniel Kinzler: Allow Status::hasMessage to work with Message objects. [core] - 10https://gerrit.wikimedia.org/r/126836 [19:53:17] (03PS2) 10Odder: Update Tomasz Kozlowski e-mail used for Gerrit [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/126255 [20:03:46] (03PS1) 10Hashar: 'recheck' by whitelisted users now runs tests [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/126838 [20:03:53] (03CR) 10Mwalker: "Ahh; I've been subtly annoyed by this bug for a long time. Thanks!" (031 comment) [extensions/CodeEditor] - 10https://gerrit.wikimedia.org/r/120397 (owner: 10TheDJ) [20:03:55] (03CR) 10jenkins-bot: [V: 04-1] 'recheck' by whitelisted users now runs tests [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/126838 (owner: 10Hashar) [20:04:44] (03PS3) 10Aaron Schulz: Finish removing boolean return values from JobQueue code [core] - 10https://gerrit.wikimedia.org/r/126746 (owner: 10Thiemo Mättig (WMDE)) [20:06:31] (03PS2) 10Hashar: 'recheck' by whitelisted users now runs tests [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/126838 [20:07:36] (03CR) 10Hashar: [C: 04-2] "Please please do NOT deploy this. Gotta be tested." [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/126838 (owner: 10Hashar) [20:13:28] (03PS3) 10QChris: 'recheck' by whitelisted users now runs tests [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/126838 (owner: 10Hashar) [20:21:23] (03CR) 10Thiemo Mättig (WMDE): [C: 031] Finish removing boolean return values from JobQueue code [core] - 10https://gerrit.wikimedia.org/r/126746 (owner: 10Thiemo Mättig (WMDE)) [20:27:19] (03PS4) 10Hashar: 'recheck' by whitelisted users now runs tests [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/126838 [20:32:50] (03CR) 10JGonera: [C: 032] HtmlFormatter fixes [core] - 10https://gerrit.wikimedia.org/r/125929 (owner: 10MaxSem) [20:36:01] (03Merged) 10jenkins-bot: HtmlFormatter fixes [core] - 10https://gerrit.wikimedia.org/r/125929 (owner: 10MaxSem) [20:36:49] (03PS2) 10Brian Wolff: Make Special:TrackingCategories fully detect namespace switching [core] - 10https://gerrit.wikimedia.org/r/124784 [20:39:51] (03PS1) 10MaxSem: Fix response time extraction, again [extensions/ApiSandbox] - 10https://gerrit.wikimedia.org/r/126842 [20:44:12] ori: have a moment to help with EL debugging? My events hit varnishcsa but seem to get filtered out (not hitting the db or vanadium:8600). Totally fine if you're busy (I'll figure something out) or point me to some other individual person [20:44:42] (03CR) 10Hashar: [C: 032] "Excellent, thanks." [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/126255 (owner: 10Odder) [20:44:50] (03Merged) 10jenkins-bot: Update Tomasz Kozlowski e-mail used for Gerrit [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/126255 (owner: 10Odder) [20:45:09] (03PS1) 10Bartosz Dziewoński: Use ResourceLoader modules for style loading [extensions/SyntaxHighlight_GeSHi] - 10https://gerrit.wikimedia.org/r/126843 [20:45:13] ha [20:45:16] ^ sexy code [20:45:27] * MatmaRex officially considers himself a ResourceLoader expert [20:45:41] (03CR) 10Hashar: "deployed" [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/126255 (owner: 10Odder) [20:45:56] mwalker: thx for merging wikieditor patches ! [20:46:40] MatmaRex: hah ! [20:47:08] this was actually a bit simpler than i expected [20:47:17] (03PS1) 10Brian Wolff: Output info in update.php for skipped updates due to shared tables [core] - 10https://gerrit.wikimedia.org/r/126844 [20:47:29] i hope i didn't introduce any crazy performance regressions, it seemed to work fast enough (once cached that is) [20:47:52] (03PS2) 10BryanDavis: Make logging destinations configurable [tools/scap] - 10https://gerrit.wikimedia.org/r/125515 [20:48:03] MatmaRex: Well those are scary words :P [20:48:05] (03CR) 10MaxSem: "Ping." [core] - 10https://gerrit.wikimedia.org/r/74293 (owner: 10MaxSem) [20:48:12] (03CR) 10BryanDavis: Make logging destinations configurable (031 comment) [tools/scap] - 10https://gerrit.wikimedia.org/r/125515 (owner: 10BryanDavis) [20:49:02] (03CR) 10Bartosz Dziewoński: "Will need careful review for performance regressions from someone who knows RL better than I do. It seems to work well in my testing, and " [extensions/SyntaxHighlight_GeSHi] - 10https://gerrit.wikimedia.org/r/126843 (owner: 10Bartosz Dziewoński) [20:49:06] (03PS1) 10Hashar: Change messages for integration-zuul-layoutdiff [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/126845 [20:49:15] (03CR) 10jenkins-bot: [V: 04-1] Change messages for integration-zuul-layoutdiff [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/126845 (owner: 10Hashar) [20:54:59] AaronSchulz: https://www.mediawiki.org/wiki/Talk:Requests_for_comment/Simplify_thumbnail_cache you have new comments from Bergsma [20:58:21] Discussing image quality reduction RfC in #wikimedia-mobile in a few minutes [20:59:20] (03PS3) 10Jdlrobson: Get Flow non-JavaScript mode into mobile [extensions/Flow] - 10https://gerrit.wikimedia.org/r/125908 [21:00:27] er, I meant -office [21:01:35] brion - hi there [21:01:46] brion: join us in #wikimedia-office for the meeting? [21:03:06] (03PS1) 10EBernhardson: Slightly faster uuid -> timestamp conversion [extensions/Flow] - 10https://gerrit.wikimedia.org/r/126847 [21:09:10] (03CR) 10Brion VIBBER: "Narrowly speaking this sounds handy, though I agree with Tim that it'd be better to use a couple of quality classes ('low', 'high') rather" [core] - 10https://gerrit.wikimedia.org/r/119661 (owner: 10Yurik) [21:13:14] (03PS25) 10Bsitu: Closing & Summarizing topic frontend changes [extensions/Flow] - 10https://gerrit.wikimedia.org/r/119640 [21:13:22] (03CR) 10jenkins-bot: [V: 04-1] Closing & Summarizing topic frontend changes [extensions/Flow] - 10https://gerrit.wikimedia.org/r/119640 (owner: 10Bsitu) [21:14:02] (03CR) 10Brian Wolff: Allow mobile to reduce image quality (032 comments) [core] - 10https://gerrit.wikimedia.org/r/119661 (owner: 10Yurik) [21:14:51] (03CR) 10Tim Starling: [C: 04-1] "I would say two classes: "low", presumably meaning 30, or parameter absent which implicitly means high. Also, I think you should remove th" [core] - 10https://gerrit.wikimedia.org/r/119661 (owner: 10Yurik) [21:21:31] (03PS2) 10Bartosz Dziewoński: Use ResourceLoader modules for style loading [extensions/SyntaxHighlight_GeSHi] - 10https://gerrit.wikimedia.org/r/126843 [21:21:38] (03CR) 10Brian Wolff: [C: 04-1] "Sorry, one other thing, could the message 'gwtoolset-reupload-media' be changed to mention the file will only be overwritten if it hasn't " [extensions/GWToolset] - 10https://gerrit.wikimedia.org/r/124347 (owner: 10Dan-nl) [21:25:31] (03PS1) 10Bartosz Dziewoński: ApiParse: Add prop=modules [core] - 10https://gerrit.wikimedia.org/r/126848 [21:34:32] (03PS23) 10Bsitu: Closing & reopening topic [extensions/Flow] - 10https://gerrit.wikimedia.org/r/118399 [21:36:58] (03PS8) 10EBernhardson: Initial import of handlebars templates [extensions/Flow] (frontend-rewrite) - 10https://gerrit.wikimedia.org/r/125357 [21:37:14] (03CR) 10jenkins-bot: [V: 04-1] Initial import of handlebars templates [extensions/Flow] (frontend-rewrite) - 10https://gerrit.wikimedia.org/r/125357 (owner: 10EBernhardson) [21:39:04] (03PS5) 10EBernhardson: First stab at new template rendering in php [extensions/Flow] (frontend-rewrite) - 10https://gerrit.wikimedia.org/r/125358 [21:39:07] (03PS24) 10Bsitu: Closing & reopening topic [extensions/Flow] - 10https://gerrit.wikimedia.org/r/118399 [21:39:23] (03CR) 10jenkins-bot: [V: 04-1] First stab at new template rendering in php [extensions/Flow] (frontend-rewrite) - 10https://gerrit.wikimedia.org/r/125358 (owner: 10EBernhardson) [21:45:42] (03PS17) 10Alex Monk: mediawiki.action.edit: Autosave edit textareas in localStorage [core] - 10https://gerrit.wikimedia.org/r/5130 (owner: 10Joancreus) [21:46:22] ^d: https://gerrit.wikimedia.org/r/#/c/126183/ trivial [21:46:31] (03CR) 10Alex Monk: [C: 04-1] "So I think stuff that's left from TheDJ's notes:" [core] - 10https://gerrit.wikimedia.org/r/5130 (owner: 10Joancreus) [21:46:47] (03PS1) 10BryanDavis: Remove logging level from colorized logs [tools/scap] - 10https://gerrit.wikimedia.org/r/126851 [21:46:49] (03CR) 10jenkins-bot: [V: 04-1] mediawiki.action.edit: Autosave edit textareas in localStorage [core] - 10https://gerrit.wikimedia.org/r/5130 (owner: 10Joancreus) [21:46:55] ^d: btw, after you import and start the VM, you will need to run <> [21:47:13] that should start all the daemons and servers [21:47:17] * ^d nods [21:47:19] <^d> Importing it now [21:47:29] (03CR) 10Chad: [C: 032] Fixed broken filebackend test for "describe" [core] - 10https://gerrit.wikimedia.org/r/126183 (owner: 10Aaron Schulz) [21:49:41] (03CR) 10Chad: [C: 032] Output info in update.php for skipped updates due to shared tables [core] - 10https://gerrit.wikimedia.org/r/126844 (owner: 10Brian Wolff) [21:50:11] i need a Krinkle or an equivalent person. :( [21:50:39] (03Merged) 10jenkins-bot: Fixed broken filebackend test for "describe" [core] - 10https://gerrit.wikimedia.org/r/126183 (owner: 10Aaron Schulz) [21:50:59] That could mean so many things. [21:51:05] MatmaRex: What's yer problem [21:51:25] marktraceur: https://gerrit.wikimedia.org/r/126843 and https://gerrit.wikimedia.org/r/126127 [21:51:49] (03PS26) 10Bsitu: Closing & Summarizing topic frontend changes [extensions/Flow] - 10https://gerrit.wikimedia.org/r/119640 [21:51:51] scary ResourceLoader and wikibits stuff. [21:52:20] (03Merged) 10jenkins-bot: Output info in update.php for skipped updates due to shared tables [core] - 10https://gerrit.wikimedia.org/r/126844 (owner: 10Brian Wolff) [21:52:55] (03CR) 10Bartosz Dziewoński: "The current patchset will actually need a review for invalidation issues, as I killed all the module mtime building parts that were too sl" [extensions/SyntaxHighlight_GeSHi] - 10https://gerrit.wikimedia.org/r/126843 (owner: 10Bartosz Dziewoński) [21:53:14] You're really selling it [21:53:28] don't i. [21:54:18] (03PS6) 10TheDJ: Allow the CodeEditor in read only mode [extensions/CodeEditor] - 10https://gerrit.wikimedia.org/r/120397 [21:59:15] (03PS7) 10Bsitu: Add 'edit topic summary' no javascript support [extensions/Flow] - 10https://gerrit.wikimedia.org/r/120485 [21:59:38] ^d: so you can authenticate just fine? [22:00:33] * ^d twiddles thumbs a bit [22:04:18] <^d> AaronSchulz: How can I test from the vm? I'm having networking troubles routing from my host OS. [22:05:04] ^d: do you have host 8082 (or something) going to guest 8080? [22:05:16] the guest is not listening on 80 fyi [22:05:27] <^d> Dur, that'd make sense. [22:05:28] well the service there [22:05:53] <> [22:08:30] <^d> auth'd fine now [22:08:30] <^d> thanks [22:09:13] TrevorParscal: Thank you! [22:09:17] (re skin sys RfC) [22:09:31] This makes me happy [22:09:50] I may buy you some sparkling water or other fun beverage in celebration [22:11:44] (03CR) 10EBernhardson: [C: 032] "Merging for now, in talks with lightncandy developer about a proper upstream version." [extensions/Flow] (frontend-rewrite) - 10https://gerrit.wikimedia.org/r/125352 (owner: 10EBernhardson) [22:11:59] (03CR) 10jenkins-bot: [V: 04-1] Add SafeString output for custom helpers [extensions/Flow] (frontend-rewrite) - 10https://gerrit.wikimedia.org/r/125352 (owner: 10EBernhardson) [22:12:09] sumanah: happy I've made you happy :) [22:12:13] (03CR) 10EBernhardson: [C: 032] Accept scope parameter for partial template expansion [extensions/Flow] (frontend-rewrite) - 10https://gerrit.wikimedia.org/r/125350 (owner: 10EBernhardson) [22:12:29] (03CR) 10jenkins-bot: [V: 04-1] Accept scope parameter for partial template expansion [extensions/Flow] (frontend-rewrite) - 10https://gerrit.wikimedia.org/r/125350 (owner: 10EBernhardson) [22:18:38] i can't seem to figure this out .... say i have 2 branches in gerrit (master and frontend-rewrite). master has a bunch of new commits that arn't in the frontend-rewrite branch, but if i try and rebase frontend-rewrite ontop of master and `git review` it wants to submit all those patches as if they were new [22:18:51] so, tl/dr: how do i merge master into my side branch inside gerrit? [22:23:39] ebernhardson: git merge --squash? [22:24:22] ori: oh duh ... i wasn't generating a merge commit. that will probably work better :) [22:24:46] i was just rebasing it into the history [22:26:50] (03PS7) 10Bsitu: Add topic/post summary diff view [extensions/Flow] - 10https://gerrit.wikimedia.org/r/121128 [22:27:05] (03PS1) 10EBernhardson: Merge remote-tracking branch 'gerrit/master' into frontend-rewrite [extensions/Flow] (frontend-rewrite) - 10https://gerrit.wikimedia.org/r/126857 [22:27:20] (03CR) 10EBernhardson: [C: 032] Merge remote-tracking branch 'gerrit/master' into frontend-rewrite [extensions/Flow] (frontend-rewrite) - 10https://gerrit.wikimedia.org/r/126857 (owner: 10EBernhardson) [22:27:36] (03Merged) 10jenkins-bot: Merge remote-tracking branch 'gerrit/master' into frontend-rewrite [extensions/Flow] (frontend-rewrite) - 10https://gerrit.wikimedia.org/r/126857 (owner: 10EBernhardson) [22:27:50] (03PS3) 10EBernhardson: Add SafeString output for custom helpers [extensions/Flow] (frontend-rewrite) - 10https://gerrit.wikimedia.org/r/125352 [22:28:39] (03PS3) 10EBernhardson: Accept scope parameter for partial template expansion [extensions/Flow] (frontend-rewrite) - 10https://gerrit.wikimedia.org/r/125350 [22:29:23] (03CR) 10EBernhardson: Accept scope parameter for partial template expansion [extensions/Flow] (frontend-rewrite) - 10https://gerrit.wikimedia.org/r/125350 (owner: 10EBernhardson) [22:29:29] (03CR) 10EBernhardson: [C: 032] Accept scope parameter for partial template expansion [extensions/Flow] (frontend-rewrite) - 10https://gerrit.wikimedia.org/r/125350 (owner: 10EBernhardson) [22:29:42] (03Merged) 10jenkins-bot: Accept scope parameter for partial template expansion [extensions/Flow] (frontend-rewrite) - 10https://gerrit.wikimedia.org/r/125350 (owner: 10EBernhardson) [22:30:00] (03CR) 10EBernhardson: Add SafeString output for custom helpers [extensions/Flow] (frontend-rewrite) - 10https://gerrit.wikimedia.org/r/125352 (owner: 10EBernhardson) [22:30:06] (03CR) 10EBernhardson: [C: 032] Add SafeString output for custom helpers [extensions/Flow] (frontend-rewrite) - 10https://gerrit.wikimedia.org/r/125352 (owner: 10EBernhardson) [22:30:27] (03Merged) 10jenkins-bot: Add SafeString output for custom helpers [extensions/Flow] (frontend-rewrite) - 10https://gerrit.wikimedia.org/r/125352 (owner: 10EBernhardson) [22:30:44] (03PS9) 10EBernhardson: Initial import of handlebars templates [extensions/Flow] (frontend-rewrite) - 10https://gerrit.wikimedia.org/r/125357 [22:35:12] jdlrobson: https://gerrit.wikimedia.org/r/126858 fixes a bug I happened to notice on beta labs [22:35:28] RoanKattouw: which bug? [22:35:40] JS error in redlinks.js [22:35:44] mmm.. why would it need user ? [22:35:54] Because it calls mw.user.isAnon() [22:35:59] oohh of course [22:36:01] got it [22:36:11] thanks RoanKattouw :) [22:36:12] So the JS error is that function not being present yet :) [22:36:54] * RoanKattouw hopes it merges quickly because it's blocking testing of mobile VE [22:36:58] RoanKattouw! [22:37:04] MatmaRex! [22:37:20] RoanKattouw: https://gerrit.wikimedia.org/r/126843 is something perfect for you to look at. :D [22:38:11] OMFG [22:38:25] This is *exactly* the use case I had in mind when I added the modules array to ParserOutput [22:38:35] I just never got around to doing it [22:38:46] yay [22:38:53] :D [22:41:35] MatmaRex: I'm putting it on my list of stuff to do on Friday [22:41:55] RoanKattouw: thanks :) [22:41:57] Because today is a Wednesday which means I get to clean up random messes before the wmf1 cut [22:42:15] RoanKattouw: think that list will also have space to include https://bugzilla.wikimedia.org/show_bug.cgi?id=63964 ? (wikibugs deprecations) [22:42:49] He's gonna stab me for this, but can you give that one to Krinkle|detached ? [22:43:04] i want to consult this with someone, since i don't want to just undeprecate everything [22:43:28] heh, sure, if i have the opportunity [22:43:29] MatmaRex: Krinkle|detached has been working on finding out exactly what deprecation notices will affect what and working to fix them. [22:43:39] MatmaRex: Un-deprecating will get -2'ed I'd imagine, however. [22:44:03] James_F: well, moving the cleanup date to some later MW version, not undeprecating [22:44:19] i don't want to have 1.23 released with code that says "REMOVE THIS IN 1.23" [22:44:22] MatmaRex: Or to 1.24wmfN for N>1. [22:44:39] 1.23 won't get released for a few weeks. We have time. [22:44:40] and this is exactly what's about to happen right now [22:44:49] "About to"? [22:44:54] End of May != now. [22:45:00] Patience. :-) [22:45:06] James_F: i also don't want to remove things like this after we push out release candidates [22:45:23] because that would make the point of creating them entirely moot [22:45:40] MatmaRex: Well, that's more a problem for MW's maintainers. Maybe they should have followed-up on these beforehand. [22:45:45] * James_F|Away runs. [22:45:47] and we're supposed to push one out like next week [22:46:10] James_F|Away: poking maintainers of this code is exactly what i'm doing right now :> [22:48:38] MatmaRex: it will make the startup module explode [22:48:41] in size, i mean [22:50:07] ori: eh, not really. that's like 50 modules tops [22:50:30] wikieditor has almost as many [22:51:44] (03PS1) 10Msaunier: User.php: Adds a read-only page whitelist, $wgWhitelistRead [core] - 10https://gerrit.wikimedia.org/r/126860 [22:51:57] (okay, it's actually 222 modules, which still sounds mostly reasonable to me) [22:52:00] <^d> James_F|Away: Releases are boring. master or gtfo. [22:52:04] <^d> :) [22:52:29] there's something a bit regrettable, though, about having to declare modules for each language, when what you'd really like to do is say "ext.geshi.language.(lang) should be served with the css for lang" [22:53:09] i think we should add a hook for resourceloader that fires when a nonexistent module has been requested [22:53:10] (it's ~45% of the startup module for me on a wiki with 6 extensions installed, including syntaxhighlight) [22:53:26] that extensions can use to supply an implementation [22:53:41] (03CR) 10Msaunier: "This patch adds a read-only whitelist for pages that overrides all other permissions. This allows the administrator of a private wiki with" [core] - 10https://gerrit.wikimedia.org/r/126860 (owner: 10Msaunier) [22:54:03] (03PS3) 10Wctaiwan: Change UI of special page and support Flow Thanks [extensions/Thanks] - 10https://gerrit.wikimedia.org/r/125941 [22:54:13] ori: just look at https://www.mediawiki.org/w/load.php?debug=false&lang=en&modules=startup&only=scripts&skin=vector&* – this will be very far from "exploding" the size [22:54:43] more like a 20% increase. :) [22:55:09] ori: but yeah, this isn't very pretty. if you can figure out something like that hook, i'd love to use it [22:55:50] ori: but i don't think resourceloader currently allows dynamically registering modules at all (other than via the hook i used), and some parts of it might assume that the list of modules is known [22:56:23] (i'm pretty sure client-side mediawiki.js assumes that right now) [22:57:48] public function onResourceLoaderMissingModule( $moduleName, ResourceLoader &$resourceLoader ) { if ( preg_match( 'ext\.geshi\.language.(.+)', $moduleName, $matches ) { return array( ... ); } } [22:57:54] it's funny how our unit tests require a configured MW install ;) [22:59:09] ori: That only works if the first reference to the module occurs server-side though :) [22:59:35] And is generally nightmarish when combined with the current principles of the startup module [22:59:54] RoanKattouw: well, rather than decline to request missing modules from the server, we could submit them [23:00:26] Right [23:00:44] But then we'd never know their timestamp and always have to ask the server about them [23:00:47] i think it's the right approach. it's a bit bizarre that you'd have to iterate over every possible variation in advance just so that resourceloader finds it [23:01:18] ugh, yeah. the timestamp thing is an issue. [23:01:20] Yeah [23:01:36] I mean I like the idea in principle, but there are nontrivial issues [23:03:14] Hello! [23:03:46] (03PS4) 10Wctaiwan: Change UI of special page and support Flow Thanks [extensions/Thanks] - 10https://gerrit.wikimedia.org/r/125941 [23:03:48] RoanKattouw: why don't we use etags again? [23:03:52] msaunier: hi [23:04:28] (03CR) 10Spage: [C: 04-1] "Viewing boards and topics works with this. Fix Resources.php and I think it's good to go." (032 comments) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/125907 (owner: 10Jdlrobson) [23:04:50] (03PS1) 10Mwalker: Updating MultiMediaViewer [core] (wmf/1.23wmf22) - 10https://gerrit.wikimedia.org/r/126866 [23:05:05] ori: eh, isn't adding more modules rather cheap? [23:05:18] So, I have written a (very small) patch to User.php that allows for a page whitelist, and the Gerrit guide suggests that I ask here for reviewers. [23:05:35] The Change-Id is: I19be33be0429f82edc52046798e2403a4309ac37 [23:05:51] ori: i suppose we could "bundle" styles for less often used languages in one module (or a few) [23:05:54] hi msaunier [23:05:56] CSteipp [23:05:59] CSteipp [23:06:22] Hm? [23:06:26] Whoops. It appears that CSteipp is responsible for security, so I went ahead and added him, [23:06:40] *Pasted in a Car :-S [23:06:44] !g I19be33be0429f82edc52046798e2403a4309ac37 [23:06:44] https://gerrit.wikimedia.org/r/#q,I19be33be0429f82edc52046798e2403a4309ac37,n,z [23:06:50] (03CR) 10Wctaiwan: Change UI of special page and support Flow Thanks (033 comments) [extensions/Thanks] - 10https://gerrit.wikimedia.org/r/125941 (owner: 10Wctaiwan) [23:07:05] Should I add anyone else? [23:07:23] msaunier: People are looking at it now I'm sure :) [23:07:26] (I am!) [23:07:50] (03CR) 10Mwalker: [C: 032] Updating MultiMediaViewer [core] (wmf/1.23wmf22) - 10https://gerrit.wikimedia.org/r/126866 (owner: 10Mwalker) [23:07:54] Nice. Hopefully it meets with your approval, this is my first patch to this project. [23:08:46] I think there will be some issues with it. [23:08:49] But it's a good start! [23:08:51] MatmaRex: $ curl -s https://dpaste.de/M2p3/raw | gzip - | wc -c [23:08:51] 1038 [23:09:07] (03PS3) 10Jdlrobson: Separate style modules from JS modules [extensions/Flow] - 10https://gerrit.wikimedia.org/r/125907 [23:09:11] msaunier: Can I ask if this is something you wanted to add yourself, or if it's something you saw a bug or request for? [23:09:18] so, 1 kilobyte. not awful, but still a little regrettable [23:10:28] marktraceur: This is a change that I originated for an internal project, it was the only way that I could figure to make a private OpenID-only wiki function. [23:10:47] (03Merged) 10jenkins-bot: Updating MultiMediaViewer [core] (wmf/1.23wmf22) - 10https://gerrit.wikimedia.org/r/126866 (owner: 10Mwalker) [23:11:11] msaunier: hmm, but wgWhitelistRead works already [23:11:21] msaunier: Have you considered making this an extension instead of a core change? [23:11:31] msaunier: are you sure it's not the OpenID stuff bypassing the normal checks for it, somehow? [23:11:31] Oh, well, there you go. [23:11:49] (it's used by Title::checkReadPermissions) [23:12:02] (which is honestly a very stupid place to put logic like this, but eh) [23:12:13] MatmaRex: As opposed to the user class? I'll take it. [23:13:35] The problem is that when you make a wiki private, users lose access to the core pages needed to make the OpenID extension work, and there's not really a way to surgically regrant them access. I fugured it'd work best as a core patch because this is a problem that will likely affect other authentication methods as well. [23:14:10] msaunier: yeah, but i mean that we apparently already have the logic to handle exactly that [23:14:13] msaunier: Which pages are those? [23:14:15] !wg WhitelistRead [23:14:15] https://www.mediawiki.org/wiki/Manual:%24wgWhitelistRead [23:14:24] Maybe the issue is that those pages are in the wrong place. [23:14:27] now i'm wondering why would that logic not work with openid [23:16:27] (03PS1) 10Bsitu: Wrong data type passed to cache::getLastRevisionFor() [extensions/Flow] - 10https://gerrit.wikimedia.org/r/126868 [23:16:38] RoanKattouw: alternately extensions could be permitted to register wildcard modules [23:16:41] msaunier: It would help if you could document why wgWhitelistRead doesn't work in your case. I agree with Max, it should work already. But since you've run into issues with it, let's make sure to document those. [23:16:53] (03CR) 10Bartosz Dziewoński: "I don't really care, I just did this to clean up the @deprecated notices :)" [core] - 10https://gerrit.wikimedia.org/r/126121 (owner: 10Bartosz Dziewoński) [23:16:55] RoanKattouw: $wgResourceModules[ 'ext.geshi.language.*' ] = array( ... ) [23:17:37] and there would be some protocol for how resourceloader passes the dynamic suffix to the module implementation constructor [23:17:48] Right [23:18:00] ori: hmmmm. at this point we might make it a parameter to the class constructor or something. [23:18:11] Yeah I was about to say [23:18:20] hey... um err is the phpunit.phar bug still unresolved? Looks open in bugzilla: https://bugzilla.wikimedia.org/show_bug.cgi?id=58881 [23:18:21] At that point what I think we really need is parameterized modules [23:18:25] and let mw.loader.load / addModules() pass parameters [23:18:26] yeah [23:18:26] yeah [23:18:32] but this smells. :) [23:18:37] module names are split on ':' (say) [23:18:58] https://bits.wikimedia.org/www.mediawiki.org/load.php?debug=false&lang=en&modules=ext.geshi.language:php [23:19:23] super scary [23:19:56] s/scary/fun/ [23:20:22] Honestly, did not see that. Wow. I wrote that patch about a month ago and never checked to see if that variable was in use, or if maybe it already did *exactly* what I was trying to accomplish. [23:20:37] I'll try unpatching my local instance and see what happens... [23:23:47] (03PS10) 10EBernhardson: Initial import of handlebars templates [extensions/Flow] (frontend-rewrite) - 10https://gerrit.wikimedia.org/r/125357 [23:24:52] msaunier: :D [23:24:54] (03CR) 10EBernhardson: [C: 032] Wrong data type passed to cache::getLastRevisionFor() [extensions/Flow] - 10https://gerrit.wikimedia.org/r/126868 (owner: 10Bsitu) [23:25:08] (03PS1) 10BryanDavis: Run scap when config or code is updated [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/126870 [23:25:11] (03Merged) 10jenkins-bot: Wrong data type passed to cache::getLastRevisionFor() [extensions/Flow] - 10https://gerrit.wikimedia.org/r/126868 (owner: 10Bsitu) [23:27:20] sleepytime for me. good night [23:28:06] Totally works. Consider my patch withdrawn. Thanks, all! [23:28:43] (03Abandoned) 10Msaunier: User.php: Adds a read-only page whitelist, $wgWhitelistRead [core] - 10https://gerrit.wikimedia.org/r/126860 (owner: 10Msaunier) [23:29:15] (03CR) 10BryanDavis: [C: 04-1] "I need to discuss this with Antione before it is merged." (034 comments) [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/126870 (owner: 10BryanDavis) [23:33:11] (03PS11) 10Bsitu: Add summarize/close/open topic to history/contribution [extensions/Flow] - 10https://gerrit.wikimedia.org/r/123123 [23:43:27] ^d: You're not wrong, you're just… :-) [23:48:00] (03CR) 10MarkTraceur: [C: 032] "Agreed with hashar, but this is good enough. Forward!" [core] - 10https://gerrit.wikimedia.org/r/125050 (owner: 10Jforrester) [23:51:18] (03PS2) 10EBernhardson: [WIP] new json output [extensions/Flow] (frontend-rewrite) - 10https://gerrit.wikimedia.org/r/125348 [23:51:21] (03Merged) 10jenkins-bot: Use new banana checker as a linter to avoid lacking qqq messages [core] - 10https://gerrit.wikimedia.org/r/125050 (owner: 10Jforrester) [23:52:41] (03CR) 10jenkins-bot: [V: 04-1] [WIP] new json output [extensions/Flow] (frontend-rewrite) - 10https://gerrit.wikimedia.org/r/125348 (owner: 10EBernhardson) [23:54:46] (03PS7) 10AndyRussG: WIP Query API modules for campaigns and participants [extensions/Campaigns] (wip/editorcampaigns) - 10https://gerrit.wikimedia.org/r/117380 [23:56:53] (03PS3) 10EBernhardson: [WIP] new json output [extensions/Flow] (frontend-rewrite) - 10https://gerrit.wikimedia.org/r/125348 [23:57:09] (03CR) 10jenkins-bot: [V: 04-1] [WIP] new json output [extensions/Flow] (frontend-rewrite) - 10https://gerrit.wikimedia.org/r/125348 (owner: 10EBernhardson) [23:59:37] (03PS4) 10EBernhardson: [WIP] new json output [extensions/Flow] (frontend-rewrite) - 10https://gerrit.wikimedia.org/r/125348 [23:59:54] (03CR) 10jenkins-bot: [V: 04-1] [WIP] new json output [extensions/Flow] (frontend-rewrite) - 10https://gerrit.wikimedia.org/r/125348 (owner: 10EBernhardson)