[00:04:21] <grrrit-wm>	 (03PS1) 10BryanDavis: Add puppet documentation job for mediawiki-vagrant [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/125919 
[00:04:24] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] Add puppet documentation job for mediawiki-vagrant [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/125919 (owner: 10BryanDavis)
[00:10:52] <grrrit-wm>	 (03CR) 10Spage: [C: 04-1] "Yay!" (034 comments) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/125907 (owner: 10Jdlrobson)
[00:14:32] <grrrit-wm>	 (03PS2) 10BryanDavis: Add puppet documentation job for mediawiki-vagrant [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/125919 
[00:30:55] <grrrit-wm>	 (03PS1) 10Dan-nl: version update [extensions/GWToolset] - 10https://gerrit.wikimedia.org/r/125922 
[00:31:21] <grrrit-wm>	 (03CR) 10Ori.livneh: [C: 031] "Cool beans" [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/125919 (owner: 10BryanDavis)
[00:33:38] <grrrit-wm>	 (03PS2) 10Ori.livneh: Make profiling to UDP work again [core] - 10https://gerrit.wikimedia.org/r/125770 (owner: 10IAlex)
[00:35:08] <grrrit-wm>	 (03PS1) 10PleaseStand: Skip loading PHP shims for JSON i18n files [core] - 10https://gerrit.wikimedia.org/r/125925 
[00:38:02] <grrrit-wm>	 (03PS2) 10PleaseStand: Skip loading PHP shims for JSON i18n files [core] - 10https://gerrit.wikimedia.org/r/125925 
[00:48:54] <AaronSchulz>	 ^d: << curl -i -H 'X-Storage-User: test:tester' -H 'X-Storage-Pass: testing' http://127.0.0.1:8082/auth/v1.0 >> works for me OK
[00:49:19] * AaronSchulz  creates a SAIO .ova file ;)

[00:49:55] <AaronSchulz>	 I used 4 disks instead of just partitions like instructions had cause I felt like it
[00:59:38] <^d>	 AaronSchulz: <3
[00:59:44] <^d>	 I won't hose this .ova, I promise
[00:59:45] <^d>	 :)
[01:01:47] <grrrit-wm>	 (03CR) 10Jdlrobson: Separate style modules from JS modules (033 comments) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/125907 (owner: 10Jdlrobson)
[01:06:56] <grrrit-wm>	 (03CR) 10Aaron Schulz: [C: 032] Make profiling to UDP work again [core] - 10https://gerrit.wikimedia.org/r/125770 (owner: 10IAlex)
[01:07:05] <grrrit-wm>	 (03PS2) 10PleaseStand: JSON i18n shim: Only register LocalisationCacheRecache handler once [core] - 10https://gerrit.wikimedia.org/r/125706 
[01:08:53] <grrrit-wm>	 (03CR) 10Mwalker: [C: 04-1] "I like it!" (031 comment) [core] - 10https://gerrit.wikimedia.org/r/120396 (owner: 10TheDJ)
[01:08:58] <AaronSchulz>	 ^d: https://gerrit.wikimedia.org/r/#/c/125518/ is a simple try/catch
[01:09:39] <grrrit-wm>	 (03CR) 10Chad: [C: 032] Avoid site outages due to broken job queues [core] - 10https://gerrit.wikimedia.org/r/125518 (owner: 10Aaron Schulz)
[01:11:19] <grrrit-wm>	 (03Merged) 10jenkins-bot: Make profiling to UDP work again [core] - 10https://gerrit.wikimedia.org/r/125770 (owner: 10IAlex)
[01:12:55] <grrrit-wm>	 (03PS22) 10Bsitu: Closing & Summarizing topic frontend changes [extensions/Flow] - 10https://gerrit.wikimedia.org/r/119640 
[01:13:25] <grrrit-wm>	 (03CR) 10Chad: [C: 032] Better test case for word splitting in js [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/125764 (owner: 10Manybubbles)
[01:13:31] <grrrit-wm>	 (03Merged) 10jenkins-bot: Avoid site outages due to broken job queues [core] - 10https://gerrit.wikimedia.org/r/125518 (owner: 10Aaron Schulz)
[01:14:14] <grrrit-wm>	 (03PS23) 10Bsitu: Closing & Summarizing topic frontend changes [extensions/Flow] - 10https://gerrit.wikimedia.org/r/119640 
[01:14:42] <grrrit-wm>	 (03Merged) 10jenkins-bot: Better test case for word splitting in js [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/125764 (owner: 10Manybubbles)
[01:16:03] <grrrit-wm>	 (03CR) 10EBernhardson: Separate style modules from JS modules (031 comment) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/125907 (owner: 10Jdlrobson)
[01:17:35] <grrrit-wm>	 (03CR) 10PleaseStand: JSON i18n shim: Only register LocalisationCacheRecache handler once (032 comments) [core] - 10https://gerrit.wikimedia.org/r/125706 (owner: 10PleaseStand)
[01:22:56] <grrrit-wm>	 (03CR) 10Bsitu: "* Moved summary inside title bar container, clicking on summary would open/collapse topic" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/119640 (owner: 10Bsitu)
[01:25:37] * AaronSchulz  heads out

[01:29:45] <grrrit-wm>	 (03CR) 10Werdna: Fix a few bugs where Flow was not working on pristine pages. (032 comments) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/123812 (owner: 10Werdna)
[01:30:50] <grrrit-wm>	 (03PS5) 10EBernhardson: Initial import of handlebars templates [extensions/Flow] (frontend-rewrite) - 10https://gerrit.wikimedia.org/r/125357 
[01:31:06] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] Initial import of handlebars templates [extensions/Flow] (frontend-rewrite) - 10https://gerrit.wikimedia.org/r/125357 (owner: 10EBernhardson)
[01:31:09] <grrrit-wm>	 (03PS1) 10Bsitu: Fix unittest in ApiFlowThankIntegrationTest.php [extensions/Thanks] - 10https://gerrit.wikimedia.org/r/125928 
[01:31:26] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] Fix unittest in ApiFlowThankIntegrationTest.php [extensions/Thanks] - 10https://gerrit.wikimedia.org/r/125928 (owner: 10Bsitu)
[01:32:52] <grrrit-wm>	 (03PS1) 10MaxSem: HtmlFormatter fixes [core] - 10https://gerrit.wikimedia.org/r/125929 
[01:33:40] <grrrit-wm>	 (03PS1) 10EBernhardson: Only you can prevent logspam [extensions/Flow] (wmf/1.23wmf21) - 10https://gerrit.wikimedia.org/r/125930 
[01:44:24] <grrrit-wm>	 (03CR) 10Kaldari: [C: 031] "Looks good. I don't know much about HtmlFormatter, so I'm just going to +1 for now in case someone else knows better." [core] - 10https://gerrit.wikimedia.org/r/125929 (owner: 10MaxSem)
[01:44:53] <grrrit-wm>	 (03PS2) 10Bsitu: Fix unit test in ApiFlowThankIntegrationTest.php [extensions/Thanks] - 10https://gerrit.wikimedia.org/r/125928 
[01:49:02] <grrrit-wm>	 (03CR) 10Springle: [C: 04-2] "Whatever the cause of the original poolcounter issue and concurrent slow queries on dbd1006 at the time, FORCE INDEX is not the answer her" [core] - 10https://gerrit.wikimedia.org/r/125719 (owner: 10ArielGlenn)
[01:52:53] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] Fix unit test in ApiFlowThankIntegrationTest.php [extensions/Thanks] - 10https://gerrit.wikimedia.org/r/125928 (owner: 10Bsitu)
[01:54:09] <grrrit-wm>	 (03PS1) 10Esanders: Update VE implementation to use model-only inpsectors [extensions/Math] - 10https://gerrit.wikimedia.org/r/125933 
[01:54:45] <hexmode>	 ^d: around?
[01:54:53] <^d>	 -ish. sup?
[01:55:45] <hexmode>	 ^d: I pushed REL1_23 on the some wrong commits in the extensions repos
[01:55:54] <hexmode>	 ^d: and now I can't move it
[01:56:11] <^d>	 Delete the branch from the UI?
[01:56:34] <hexmode>	 hrm...
[01:57:31] <hexmode>	 ^d: ok, but there isn't a magic bit I need you to set, right?
[01:57:47] <^d>	 Shouldn't be.... If so we'll fix that.
[01:57:48] <^d>	 :)
[01:57:52] <hexmode>	 :)
[01:58:33] <Gloria>	 Delete all the bits.
[01:58:44] <hexmode>	 ^d: hints for where to look in gerrit ui?
[01:59:04] <grrrit-wm>	 (03PS1) 10EBernhardson: Dont pass objects through the api query [extensions/Thanks] - 10https://gerrit.wikimedia.org/r/125934 
[01:59:20] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] Dont pass objects through the api query [extensions/Thanks] - 10https://gerrit.wikimedia.org/r/125934 (owner: 10EBernhardson)
[01:59:26] <^d>	 hexmode: Bring up a repo's config, click "Branches" -- you'll end up at a URL similar to https://gerrit.wikimedia.org/r/#/admin/projects/mediawiki/core,branches
[01:59:30] <^d>	 (that's for mw/core)
[01:59:51] <^d>	 https://gerrit.wikimedia.org/r/#/admin/projects/mediawiki/extensions/GeoData,branches - random extension
[02:00:30] <grrrit-wm>	 (03CR) 10EBernhardson: [C: 032 V: 032] "Test error is unrelated to this patch and exists in the master branch." [extensions/Thanks] - 10https://gerrit.wikimedia.org/r/125928 (owner: 10Bsitu)
[02:00:45] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] Fix unit test in ApiFlowThankIntegrationTest.php [extensions/Thanks] - 10https://gerrit.wikimedia.org/r/125928 (owner: 10Bsitu)
[02:01:18] <hexmode>	 ^d: permission requested.  Error says "not found or you do not have permission"
[02:01:27] <^d>	 Blarggghhhh
[02:01:46] <hexmode>	 I need "push" rights?
[02:01:57] * werdna  pushes hexmode 

[02:02:07] <werdna>	 hey people, how's it going
[02:02:09] <hexmode>	 (that's the git push reponsee, anyway)
[02:02:22] * hexmode  pushes werdna into the pool

[02:02:50] <^d>	 hexmode: Technically you need one of two things. Either force pushes (so you can `git push -f origin :refs/heads/REL1_23`
[02:02:55] <^d>	 Which would force-push to delete it.
[02:03:05] <^d>	 Or we can grant you Owner rights which will let you do it via the UI.
[02:03:14] <^d>	 Gerrit's "Owner" permission annoys the snot out of me.
[02:03:54] <^d>	 Oh, you should have "Owner"
[02:03:58] <^d>	 Can you do it via the UI?
[02:04:08] <ebernhardson>	 can i override jenkins -1? the above patch( https://gerrit.wikimedia.org/r/125928 ) i tried but i only have a 'publish' button
[02:04:21] <ebernhardson>	 same with bsitu
[02:04:32] <hexmode>	 ^d: let me try force push first
[02:04:52] <ebernhardson>	 or maybe it is, hmm
[02:04:57] <^d>	 Well force pushes are a new ACL entry. I'd rather avoid them because they're...dangerous.
[02:05:08] <^d>	 If you've already got owner I'd recommend doing it via the UI if you can
[02:05:46] <ebernhardson>	 yea nm with my problem i'm just impatient :P  i think its working
[02:06:01] <hexmode>	 ^d: k, trying
[02:08:40] <hexmode>	 ^d: worked.  Hopefully only a handful need fixing.  tyvm
[02:08:54] <^d>	 yw.
[02:36:48] <werdna>	 Hey anybody know how I can return a template from a parser function and have it not break
[02:37:46] <werdna>	 never mind, got it
[02:38:50] <grrrit-wm>	 (03CR) 10Springle: [C: 031] "+1 to the schema change and query, but the wise eye of a Dev should +2 the PHP stuff :-)" [core] - 10https://gerrit.wikimedia.org/r/122349 (owner: 10Daniel Kinzler)
[02:40:45] <grrrit-wm>	 (03CR) 10Chad: [C: 04-1] "Updater code reviewed, all ok. Nitpick in release notes. LinksUpdate(Test) needs review still." (031 comment) [core] - 10https://gerrit.wikimedia.org/r/122349 (owner: 10Daniel Kinzler)
[02:41:14] <^demon|away>	 springle: There's most of your requested review :)
[02:42:45] <^demon|away>	 And actually, I'm pretty sure LinksUpdate is ok too, but I'm in dinner mode now
[02:51:48] <grrrit-wm>	 (03CR) 10Springle: "This change set is languishing." [core] - 10https://gerrit.wikimedia.org/r/48661 (owner: 10Alex Monk)
[02:53:35] <springle>	 ^demon|away: thanks :)
[02:54:19] <^demon|away>	 np
[03:38:09] <grrrit-wm>	 (03PS1) 10Wctaiwan: Call getAlphadecimal() directly in ThanksHooks [extensions/Thanks] - 10https://gerrit.wikimedia.org/r/125938 
[03:39:57] <grrrit-wm>	 (03CR) 10Legoktm: [C: 032] Call getAlphadecimal() directly in ThanksHooks [extensions/Thanks] - 10https://gerrit.wikimedia.org/r/125938 (owner: 10Wctaiwan)
[03:40:12] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] Call getAlphadecimal() directly in ThanksHooks [extensions/Thanks] - 10https://gerrit.wikimedia.org/r/125938 (owner: 10Wctaiwan)
[03:49:08] <grrrit-wm>	 (03PS2) 10Wctaiwan: Call getAlphadecimal() directly [extensions/Thanks] - 10https://gerrit.wikimedia.org/r/125938 
[03:51:34] <grrrit-wm>	 (03PS3) 10Wctaiwan: Call getAlphadecimal() directly [extensions/Thanks] - 10https://gerrit.wikimedia.org/r/125938 
[03:52:35] <grrrit-wm>	 (03PS2) 10EBernhardson: Dont pass objects through the api query [extensions/Thanks] - 10https://gerrit.wikimedia.org/r/125934 
[03:53:33] <grrrit-wm>	 (03PS15) 10thibaultmarin: (extension/TimelineTable) Refactoring and cleanup [extensions/TimelineTable] - 10https://gerrit.wikimedia.org/r/38485 
[03:54:02] <grrrit-wm>	 (03PS4) 10EBernhardson: Call getAlphadecimal() directly [extensions/Thanks] - 10https://gerrit.wikimedia.org/r/125938 (owner: 10Wctaiwan)
[03:56:47] <grrrit-wm>	 (03PS4) 10Deepali: Remove edit toolbar from the editing form [extensions/BookManagerv2] - 10https://gerrit.wikimedia.org/r/120573 
[03:56:53] <grrrit-wm>	 (03CR) 10EBernhardson: [C: 032] Call getAlphadecimal() directly [extensions/Thanks] - 10https://gerrit.wikimedia.org/r/125938 (owner: 10Wctaiwan)
[03:57:09] <grrrit-wm>	 (03Merged) 10jenkins-bot: Call getAlphadecimal() directly [extensions/Thanks] - 10https://gerrit.wikimedia.org/r/125938 (owner: 10Wctaiwan)
[03:57:21] <grrrit-wm>	 (03Abandoned) 10EBernhardson: Dont pass objects through the api query [extensions/Thanks] - 10https://gerrit.wikimedia.org/r/125934 (owner: 10EBernhardson)
[03:57:38] <grrrit-wm>	 (03CR) 10Deepali: "Mentioned dependency on I6bde992eb63ed48ceea05d1c10b21564aad7cbbe in the commit message." [extensions/BookManagerv2] - 10https://gerrit.wikimedia.org/r/120573 (owner: 10Deepali)
[03:58:09] <grrrit-wm>	 (03PS18) 10Wctaiwan: Change UI of special page and support Flow Thanks [extensions/Thanks] - 10https://gerrit.wikimedia.org/r/119879 
[04:04:06] <grrrit-wm>	 (03CR) 10thibaultmarin: "Reviewing whitespace is great but I wish there was some flexibility in the indentation (mine was not less readable, was consistent and was" (031 comment) [extensions/TimelineTable] - 10https://gerrit.wikimedia.org/r/38485 (owner: 10thibaultmarin)
[04:32:53] <grrrit-wm>	 (03PS1) 10EBernhardson: Log more information about request failure [extensions/Flow] - 10https://gerrit.wikimedia.org/r/125939 
[04:34:43] <grrrit-wm>	 (03PS1) 10Wctaiwan: Refactor API code and fix invalid input handling [extensions/Thanks] - 10https://gerrit.wikimedia.org/r/125940 
[04:38:55] <grrrit-wm>	 (03PS1) 10Wctaiwan: Change UI of special page and support Flow Thanks [extensions/Thanks] - 10https://gerrit.wikimedia.org/r/125941 
[04:41:24] <grrrit-wm>	 (03PS2) 10EBernhardson: Log more information about request failure [extensions/Flow] - 10https://gerrit.wikimedia.org/r/125939 
[04:43:06] <grrrit-wm>	 (03PS2) 10Wctaiwan: Change UI of special page and support Flow Thanks [extensions/Thanks] - 10https://gerrit.wikimedia.org/r/125941 
[04:44:44] <grrrit-wm>	 (03Abandoned) 10Wctaiwan: Change UI of special page and support Flow Thanks [extensions/Thanks] - 10https://gerrit.wikimedia.org/r/119879 (owner: 10Wctaiwan)
[04:49:32] <grrrit-wm>	 (03PS1) 10Chad: Move WikiLove preference from Misc. to Editing tab [extensions/WikiLove] - 10https://gerrit.wikimedia.org/r/125942 
[04:55:09] <grrrit-wm>	 (03Abandoned) 10ArielGlenn: use the right index for page_restriction query, see rt #167081 [core] - 10https://gerrit.wikimedia.org/r/125719 (owner: 10ArielGlenn)
[05:10:52] <grrrit-wm>	 (03PS1) 10EBernhardson: Include xhprof module properly [vagrant] - 10https://gerrit.wikimedia.org/r/125943 
[05:27:30] <Gloria>	 ^d: Hey. Thanks for the WikiLove patch.
[05:28:02] <Gloria>	 https://www.mediawiki.org/wiki/Requests_for_comment/Redesign_user_preferences#Background has a pretty screenshot now.
[05:28:31] <Gloria>	 ^d: Is it easy to rename users in Gerrit/LDAP/whatever? Like if I wanted "01tonythomas" to be "Tony Thomas"?
[05:28:47] <Gloria>	 I think you renamed.
[05:29:51] <Gloria>	 I guess Siebrand changed e-mail addresses.
[05:34:02] <Gloria>	 Around mid-March 2014.
[05:37:58] <^d>	 Gloria: No, it's not easy :(
[05:38:06] <^d>	 It can be done, but requires opsen.
[05:38:45] * ^d  yawns, wanders away from IRC for the night

[05:38:54] <Gloria>	 :-(
[05:47:09] <grrrit-wm>	 (03CR) 10Siebrand: [C: 031] Skip loading PHP shims for JSON i18n files [core] - 10https://gerrit.wikimedia.org/r/125925 (owner: 10PleaseStand)
[05:47:53] <grrrit-wm>	 (03PS4) 10AndyRussG: WIP Update Campaigns database schema [extensions/Campaigns] (wip/editorcampaigns) - 10https://gerrit.wikimedia.org/r/122223 
[05:52:19] <grrrit-wm>	 (03CR) 10Siebrand: "Very nice work, PleaseStand. Will test in a few hours. When this gets merged, I'll make an effort to update all the shims in Gerrit and a " [core] - 10https://gerrit.wikimedia.org/r/125706 (owner: 10PleaseStand)
[05:52:29] <grrrit-wm>	 (03PS1) 10Deepali: Warn user that changes will not be saved if s/he navigates away from JSON editor [extensions/BookManagerv2] - 10https://gerrit.wikimedia.org/r/125945 
[05:52:34] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] Warn user that changes will not be saved if s/he navigates away from JSON editor [extensions/BookManagerv2] - 10https://gerrit.wikimedia.org/r/125945 (owner: 10Deepali)
[05:52:46] <grrrit-wm>	 (03CR) 10AndyRussG: WIP Domain layer and DB persistence with data mapper (032 comments) [extensions/Campaigns] (wip/editorcampaigns) - 10https://gerrit.wikimedia.org/r/123781 (owner: 10AndyRussG)
[05:54:57] <grrrit-wm>	 (03CR) 10Nemo bis: [C: 031] "Even better, reuses an existing section. [[MediaWiki:Wikilove-enable-preference/qqq]] doesn't mention preferences tab so nothing to change" [extensions/WikiLove] - 10https://gerrit.wikimedia.org/r/125942 (owner: 10Chad)
[05:56:03] <grrrit-wm>	 (03PS2) 10Deepali: Warn user that changes will not be saved if s/he navigates away from JSON editor [extensions/BookManagerv2] - 10https://gerrit.wikimedia.org/r/125945 
[06:00:28] <grrrit-wm>	 (03PS8) 10AndyRussG: WIP Domain layer and DB persistence with data mapper [extensions/Campaigns] (wip/editorcampaigns) - 10https://gerrit.wikimedia.org/r/123781 
[06:00:40] <grrrit-wm>	 (03CR) 10EBernhardson: [C: 04-1] "values loaded from the database(primary source) are still cached as binary, need to figure out best place for the conversion that doesn't " [extensions/Flow] - 10https://gerrit.wikimedia.org/r/125767 (owner: 10EBernhardson)
[06:01:18] <grrrit-wm>	 (03CR) 10AndyRussG: "Just rebasing..." [extensions/Campaigns] (wip/editorcampaigns) - 10https://gerrit.wikimedia.org/r/123781 (owner: 10AndyRussG)
[06:06:03] <grrrit-wm>	 (03PS9) 10AndyRussG: WIP Domain layer and DB persistence with data mapper [extensions/Campaigns] (wip/editorcampaigns) - 10https://gerrit.wikimedia.org/r/123781 
[06:12:34] <grrrit-wm>	 (03PS4) 10AndyRussG: Participation on create account via campaign url [extensions/Campaigns] (wip/editorcampaigns) - 10https://gerrit.wikimedia.org/r/119258 
[06:13:25] <grrrit-wm>	 (03CR) 10AndyRussG: "Rebasing..." [extensions/Campaigns] (wip/editorcampaigns) - 10https://gerrit.wikimedia.org/r/119258 (owner: 10AndyRussG)
[06:17:32] <grrrit-wm>	 (03CR) 10Nikerabbit: [C: 031] Make enhanced recent changes and extended watchlist default [core] - 10https://gerrit.wikimedia.org/r/124302 (owner: 10Nemo bis)
[06:24:57] <grrrit-wm>	 (03PS2) 10Jdlrobson: Separate style modules from JS modules [extensions/Flow] - 10https://gerrit.wikimedia.org/r/125907 
[06:27:58] <grrrit-wm>	 (03CR) 10Jdlrobson: Separate style modules from JS modules (031 comment) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/125907 (owner: 10Jdlrobson)
[06:29:30] <grrrit-wm>	 (03CR) 10Nikerabbit: "Tested and works, but see inline comment." (031 comment) [core] - 10https://gerrit.wikimedia.org/r/125925 (owner: 10PleaseStand)
[06:32:06] <grrrit-wm>	 (03PS1) 10Legoktm: isFeatureEnabled: Return false if the feature is not whitelisted [extensions/BetaFeatures] - 10https://gerrit.wikimedia.org/r/125946 
[06:37:46] <grrrit-wm>	 (03Abandoned) 10Legoktm: API: Remove 'flowaction' parameter from list=flow [extensions/Flow] - 10https://gerrit.wikimedia.org/r/123174 (owner: 10Legoktm)
[06:47:35] <grrrit-wm>	 (03PS6) 10TheDJ: New hook for readonly editpages [core] - 10https://gerrit.wikimedia.org/r/120396 
[06:49:29] <grrrit-wm>	 (03PS1) 10Legoktm: API: Document 'flowaction' parameter values for list=flow [extensions/Flow] - 10https://gerrit.wikimedia.org/r/125947 
[07:07:15] <grrrit-wm>	 (03CR) 1001tonythomas: [C: 031] "Tested ! Good to go." [extensions/WikiLove] - 10https://gerrit.wikimedia.org/r/125942 (owner: 10Chad)
[07:10:29] <grrrit-wm>	 (03PS1) 10TheDJ: [Do not merge] Do not pass editpage by reference in hooks [core] - 10https://gerrit.wikimedia.org/r/125951 
[07:11:05] <grrrit-wm>	 (03CR) 10TheDJ: "I see i corrected the wrong hook in the previous patch." (031 comment) [core] - 10https://gerrit.wikimedia.org/r/120396 (owner: 10TheDJ)
[07:24:42] <grrrit-wm>	 (03CR) 10Legoktm: [C: 032] Move WikiLove preference from Misc. to Editing tab [extensions/WikiLove] - 10https://gerrit.wikimedia.org/r/125942 (owner: 10Chad)
[07:24:44] <grrrit-wm>	 (03Merged) 10jenkins-bot: Move WikiLove preference from Misc. to Editing tab [extensions/WikiLove] - 10https://gerrit.wikimedia.org/r/125942 (owner: 10Chad)
[07:37:14] <grrrit-wm>	 (03CR) 10Physikerwelt: "Hi," [extensions/Math] - 10https://gerrit.wikimedia.org/r/124805 (owner: 10Physikerwelt)
[07:37:21] <grrrit-wm>	 (03PS1) 10Legoktm: TopicBlock: fix renerTopicAPI to output history if requested [extensions/Flow] - 10https://gerrit.wikimedia.org/r/125953 
[07:37:34] <grrrit-wm>	 (03PS2) 10Legoktm: TopicBlock: fix renderTopicAPI to output history if requested [extensions/Flow] - 10https://gerrit.wikimedia.org/r/125953 
[07:38:55] <grrrit-wm>	 (03PS3) 10Zfilipin: The first Selenium test: CentralAuth log in [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/125740 
[07:39:48] <grrrit-wm>	 (03CR) 10Zfilipin: "Hoo man: how do you suggest to change the test then?" [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/125740 (owner: 10Zfilipin)
[07:41:25] <grrrit-wm>	 (03PS6) 10Physikerwelt: WIP: Changes in Database Layout for Math2.0 [extensions/Math] - 10https://gerrit.wikimedia.org/r/124805 
[07:41:38] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] WIP: Changes in Database Layout for Math2.0 [extensions/Math] - 10https://gerrit.wikimedia.org/r/124805 (owner: 10Physikerwelt)
[07:42:22] <grrrit-wm>	 (03CR) 10Zfilipin: "Jon, I would be glad to pair with you on this, but I think it would be easier for you to arrange a pairing session with Juliusz. He is in " [ruby/api] - 10https://gerrit.wikimedia.org/r/125010 (owner: 10Jdlrobson)
[07:49:22] <grrrit-wm>	 (03CR) 10Legoktm: [C: 032] Fixed some @params documentation [core] - 10https://gerrit.wikimedia.org/r/125852 (owner: 10Umherirrender)
[07:52:36] <grrrit-wm>	 (03Merged) 10jenkins-bot: Fixed some @params documentation [core] - 10https://gerrit.wikimedia.org/r/125852 (owner: 10Umherirrender)
[08:06:48] <tonythomas>	 Gloria: Hi ! Mzmcbride ! you around /?
[08:15:35] <tonythomas>	 Hi! I was going through this bug, on removing the Education Program extensions, "did you know"  user preference from the misc tab. Since there is an increased motion to remove the misc tab alogether from preferences. Will it be ok to move the entire education program checkboxes like 'Show a link to your courses at the top of every page." to the appearance
[08:15:35] <tonythomas>	 tab? 
[08:16:01] <tonythomas>	 bug - https://bugzilla.wikimedia.org/show_bug.cgi?id=52759
[08:19:46] <Nemo_bis>	 *click*
[08:21:04] <tonythomas>	 Nemo_bis:  hi! should all the misc prefs of eduaction program be shifted to appearance ? 
[08:21:19] <sjoerddebruin>	 All?
[08:21:25] <Nemo_bis>	 2 https://en.wikipedia.org/wiki/Special:Preferences#mw-prefsection-misc
[08:22:05] <Nemo_bis>	 should be ok I guess, as long as it comes after Math
[08:22:13] <tonythomas>	 there are two more actually! 
[08:22:33] <tonythomas>	 I mean, the preferences 
[08:22:43] <Nemo_bis>	 hopefully the extension will soon be removed anyway
[08:22:52] <ori>	 Nemo_bis: could you help me identify the feature shown in <https://www.youtube.com/watch?v=k9-6HH_Itps> ?
[08:23:08] <tonythomas>	 Nemo_bis:  ok. I will move it rightaway 
[08:23:49] <Nemo_bis>	 ori: I have a blindness to animat* on screen but let's see
[08:24:39] <Nemo_bis>	 ori: I'm not sure what you mean, the image zoom?
[08:24:47] <ori>	 Nemo_bis: yes
[08:24:55] <Nemo_bis>	 I suppose it's the slideshow gadget
[08:29:23] <ori>	 Nemo_bis: yes, i think you're right
[08:32:05] <grrrit-wm>	 (03PS9) 10IAlex: Improve UDP logging code [core] - 10https://gerrit.wikimedia.org/r/125436 
[08:37:13] <grrrit-wm>	 (03PS1) 1001tonythomas: Moved EducationProgram preferences to Appearance tab [extensions/EducationProgram] - 10https://gerrit.wikimedia.org/r/125959 
[08:37:24] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] Moved EducationProgram preferences to Appearance tab [extensions/EducationProgram] - 10https://gerrit.wikimedia.org/r/125959 (owner: 1001tonythomas)
[08:42:33] <grrrit-wm>	 (03CR) 1001tonythomas: "Donnno why, but jenkins complains about some changes to errors in some js file, which was untouched." [extensions/EducationProgram] - 10https://gerrit.wikimedia.org/r/125959 (owner: 1001tonythomas)
[08:44:44] <ori>	 (Nemo_bis: thanks)
[08:45:10] <tonythomas>	 Nemo_bis:  looks like Jenkins got a lot of errors in some js file there. 
[08:45:23] <tonythomas>	 https://gerrit.wikimedia.org/r/#/c/125959/
[08:45:32] <tonythomas>	 any thoughts /? 
[08:46:46] <tonythomas>	 looks like it lacks the .jshintrc file 
[08:46:49] <tonythomas>	 hum! 
[08:48:07] <grrrit-wm>	 (03CR) 10Nikerabbit: "Is this related to the "Uncommitted DB writes" debugging?" (032 comments) [core] - 10https://gerrit.wikimedia.org/r/125895 (owner: 10Aaron Schulz)
[08:55:27] <grrrit-wm>	 (03CR) 1001tonythomas: "Anything more to be done here ?" [extensions/InputBox] - 10https://gerrit.wikimedia.org/r/120487 (owner: 1001tonythomas)
[09:01:07] <grrrit-wm>	 (03CR) 1001tonythomas: "@Nemo: In that case, I think it would be better to leave the email confirmation too in the User Profile. I think it doesn't look too fitti" [core] - 10https://gerrit.wikimedia.org/r/125762 (owner: 1001tonythomas)
[09:02:07] <grrrit-wm>	 (03PS1) 10Shirayuki: i18n: Add missing messages [extensions/WikiForum] - 10https://gerrit.wikimedia.org/r/125960 
[09:02:09] <grrrit-wm>	 (03CR) 10Nemo bis: "Tony, you're right. Can you amend the patch? I've not tested it, either." [core] - 10https://gerrit.wikimedia.org/r/125762 (owner: 1001tonythomas)
[09:04:41] <grrrit-wm>	 (03PS8) 10Hiong3-eng5: MW WLD prefix compatibility fix [extensions/WikiLexicalData] - 10https://gerrit.wikimedia.org/r/119446 
[09:05:46] <tonythomas>	 Nemo_bis: ok! I will amend it.
[09:07:51] <grrrit-wm>	 (03PS2) 10Nemo bis: Moved EducationProgram preferences to Appearance tab [extensions/EducationProgram] - 10https://gerrit.wikimedia.org/r/125959 (owner: 1001tonythomas)
[09:07:58] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] Moved EducationProgram preferences to Appearance tab [extensions/EducationProgram] - 10https://gerrit.wikimedia.org/r/125959 (owner: 1001tonythomas)
[09:08:34] <tonythomas>	 Nemo_bis: Looks like we need to add the jshintrc file there ?
[09:11:07] <Nemo_bis>	 tonythomas: sorry, I have no idea
[09:11:15] <Nemo_bis>	 but there is a bugzilla report with workarounds IIRC
[09:12:00] <grrrit-wm>	 (03PS7) 10Physikerwelt: WIP: Changes in Database Layout for Math2.0 [extensions/Math] - 10https://gerrit.wikimedia.org/r/124805 
[09:12:12] <tonythomas>	 Nemo_bis: yeah !!! and there is no .jshintrc file in the extension though. 
[09:12:55] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] WIP: Changes in Database Layout for Math2.0 [extensions/Math] - 10https://gerrit.wikimedia.org/r/124805 (owner: 10Physikerwelt)
[09:31:59] <grrrit-wm>	 (03PS9) 10Phuedx: Delete the post-edit cookie using the correct domain [core] - 10https://gerrit.wikimedia.org/r/122423 
[09:32:01] <grrrit-wm>	 (03PS14) 10Phuedx: Add the mw.cookie module [core] - 10https://gerrit.wikimedia.org/r/120806 
[09:32:16] <grrrit-wm>	 (03PS3) 1001tonythomas: Create "Following changes" (notifications) tab from "watchlist" [core] - 10https://gerrit.wikimedia.org/r/125762 
[09:33:05] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] Delete the post-edit cookie using the correct domain [core] - 10https://gerrit.wikimedia.org/r/122423 (owner: 10Phuedx)
[09:33:37] <grrrit-wm>	 (03CR) 10Siebrand: [C: 04-1] "enableDykSetting should also be removed from EducationProgram.setting.php, not?" [extensions/EducationProgram] - 10https://gerrit.wikimedia.org/r/125959 (owner: 1001tonythomas)
[09:33:55] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] Add the mw.cookie module [core] - 10https://gerrit.wikimedia.org/r/120806 (owner: 10Phuedx)
[09:35:07] <grrrit-wm>	 (03CR) 1001tonythomas: "A small note:" [core] - 10https://gerrit.wikimedia.org/r/125762 (owner: 1001tonythomas)
[09:35:32] <grrrit-wm>	 (03CR) 10Siebrand: [C: 04-1] "i18n/L10n reviewed." (032 comments) [extensions/WikiForum] - 10https://gerrit.wikimedia.org/r/125960 (owner: 10Shirayuki)
[09:37:27] <grrrit-wm>	 (03PS3) 1001tonythomas: Moved EducationProgram preferences to Appearance tab [extensions/EducationProgram] - 10https://gerrit.wikimedia.org/r/125959 
[09:37:37] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] Moved EducationProgram preferences to Appearance tab [extensions/EducationProgram] - 10https://gerrit.wikimedia.org/r/125959 (owner: 1001tonythomas)
[09:38:23] <grrrit-wm>	 (03CR) 1001tonythomas: "@Siebrand: done. But jenkins is still not satisfied" [extensions/EducationProgram] - 10https://gerrit.wikimedia.org/r/125959 (owner: 1001tonythomas)
[09:38:28] <grrrit-wm>	 (03CR) 10Siebrand: [C: 031] "i18n/L10n reviewed." [core] - 10https://gerrit.wikimedia.org/r/125762 (owner: 1001tonythomas)
[09:38:57] <grrrit-wm>	 (03CR) 10Siebrand: "@tony: Jenkins needs to be instructed to not vote on failing jslint jobs." [extensions/EducationProgram] - 10https://gerrit.wikimedia.org/r/125959 (owner: 1001tonythomas)
[09:39:13] <grrrit-wm>	 (03PS10) 10Phuedx: Delete the post-edit cookie using the correct domain [core] - 10https://gerrit.wikimedia.org/r/122423 
[09:39:15] <grrrit-wm>	 (03PS15) 10Phuedx: Add the mw.cookie module [core] - 10https://gerrit.wikimedia.org/r/120806 
[09:39:34] <grrrit-wm>	 (03CR) 10Siebrand: [C: 031] "i18n/L10n reviewed." [extensions/EducationProgram] - 10https://gerrit.wikimedia.org/r/125959 (owner: 1001tonythomas)
[09:39:55] <grrrit-wm>	 (03PS1) 10Matthias Mullie: Alphanumeric is now the commonly no-conversion-needed format [extensions/Flow] - 10https://gerrit.wikimedia.org/r/125962 
[09:39:58] <grrrit-wm>	 (03PS1) 10Matthias Mullie: Fix potential issue in ::convertUUIDs [extensions/Flow] - 10https://gerrit.wikimedia.org/r/125963 
[09:40:01] <grrrit-wm>	 (03PS1) 10Matthias Mullie: Alnum in cache [extensions/Flow] - 10https://gerrit.wikimedia.org/r/125964 
[09:40:19] <grrrit-wm>	 (03CR) 10Matthias Mullie: [C: 04-2] "Favor https://gerrit.wikimedia.org/r/#/c/125767/ over this one" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/125964 (owner: 10Matthias Mullie)
[09:41:16] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] Alphanumeric is now the commonly no-conversion-needed format [extensions/Flow] - 10https://gerrit.wikimedia.org/r/125962 (owner: 10Matthias Mullie)
[09:41:20] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] Fix potential issue in ::convertUUIDs [extensions/Flow] - 10https://gerrit.wikimedia.org/r/125963 (owner: 10Matthias Mullie)
[09:41:24] <grrrit-wm>	 (03CR) 10Nemo bis: [C: 031] "Tony, yes, ideally. However I don't consider it a blocker for merge of this change; you can open an enhancement request after this is merg" [core] - 10https://gerrit.wikimedia.org/r/125762 (owner: 1001tonythomas)
[09:41:26] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] Alnum in cache [extensions/Flow] - 10https://gerrit.wikimedia.org/r/125964 (owner: 10Matthias Mullie)
[09:43:40] <grrrit-wm>	 (03CR) 1001tonythomas: "@Nemo: ok. Lets wait for this to get merged." [core] - 10https://gerrit.wikimedia.org/r/125762 (owner: 1001tonythomas)
[09:44:14] <grrrit-wm>	 (03Abandoned) 10Matthias Mullie: Alphanumeric is now the commonly no-conversion-needed format [extensions/Flow] - 10https://gerrit.wikimedia.org/r/125962 (owner: 10Matthias Mullie)
[09:46:08] <grrrit-wm>	 (03PS2) 10Matthias Mullie: Fix potential issue in ::convertUUIDs [extensions/Flow] - 10https://gerrit.wikimedia.org/r/125963 
[09:52:26] <grrrit-wm>	 (03CR) 10Siebrand: [C: 04-1] "i18n/L10n reviewed." (033 comments) [extensions/Thanks] - 10https://gerrit.wikimedia.org/r/125941 (owner: 10Wctaiwan)
[09:55:33] <grrrit-wm>	 (03CR) 10Siebrand: [C: 031] "L10n reviewed." [extensions/Flow] - 10https://gerrit.wikimedia.org/r/119640 (owner: 10Bsitu)
[10:03:15] <grrrit-wm>	 (03PS8) 10Physikerwelt: WIP: Changes in Database Layout for Math2.0 [extensions/Math] - 10https://gerrit.wikimedia.org/r/124805 
[10:04:14] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] WIP: Changes in Database Layout for Math2.0 [extensions/Math] - 10https://gerrit.wikimedia.org/r/124805 (owner: 10Physikerwelt)
[10:22:33] <grrrit-wm>	 (03CR) 10Siebrand: [C: 031] "I've tested the updated script and prepared some commands to update all Gerrit extensions. This would make changes to a little under 600 e" [core] - 10https://gerrit.wikimedia.org/r/125706 (owner: 10PleaseStand)
[10:29:32] <grrrit-wm>	 (03CR) 10Siebrand: [C: 031] "i18n/L10n reviewed." [extensions/Flow] - 10https://gerrit.wikimedia.org/r/118399 (owner: 10Bsitu)
[10:41:40] <grrrit-wm>	 (03CR) 10Siebrand: [C: 032 V: 032] Localisation updates from https://translatewiki.net. [core] - 10https://gerrit.wikimedia.org/r/125967 (owner: 10L10n-bot)
[10:41:52] <grrrit-wm>	 (03PS10) 10Siebrand: Use new banana checker as a linter to avoid lacking qqq messages [core] - 10https://gerrit.wikimedia.org/r/125050 (owner: 10Jforrester)
[10:44:42] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] Use new banana checker as a linter to avoid lacking qqq messages [core] - 10https://gerrit.wikimedia.org/r/125050 (owner: 10Jforrester)
[10:45:46] <grrrit-wm>	 (03CR) 10Siebrand: [C: 031] "Let's merge this (and backport to REL1_23) after it's been rebased." [core] - 10https://gerrit.wikimedia.org/r/84303 (owner: 10TTO)
[10:46:45] <grrrit-wm>	 (03CR) 10Siebrand: "recheck" [core] - 10https://gerrit.wikimedia.org/r/125050 (owner: 10Jforrester)
[10:46:56] <grrrit-wm>	 (03PS2) 10Shirayuki: i18n: Add missing messages [extensions/WikiForum] - 10https://gerrit.wikimedia.org/r/125960 
[10:47:46] <grrrit-wm>	 (03CR) 10Siebrand: [C: 032] i18n: Add missing messages [extensions/WikiForum] - 10https://gerrit.wikimedia.org/r/125960 (owner: 10Shirayuki)
[10:47:48] <grrrit-wm>	 (03Merged) 10jenkins-bot: i18n: Add missing messages [extensions/WikiForum] - 10https://gerrit.wikimedia.org/r/125960 (owner: 10Shirayuki)
[11:02:02] <prtksxna>	 MaxSem: Should I create a new file in mw-config just with that array? Should I move the others too?
[11:02:29] <MaxSem>	 file? why?
[11:03:12] <prtksxna>	 MaxSem: Just append to index.php?
[11:03:27] <prtksxna>	 Its not an override?
[11:03:48] <MaxSem>	 index.php?
[11:06:44] <grrrit-wm>	 (03PS1) 10Hashar: Jobs for MediaWiki REL1_23 branch [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/125969 
[11:07:38] <grrrit-wm>	 (03PS2) 10Hashar: Job for MediaWiki REL1_23 branch [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/125969 
[11:07:55] <grrrit-wm>	 (03CR) 10Hashar: [C: 032] Job for MediaWiki REL1_23 branch [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/125969 (owner: 10Hashar)
[11:08:53] <grrrit-wm>	 (03Merged) 10jenkins-bot: Job for MediaWiki REL1_23 branch [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/125969 (owner: 10Hashar)
[11:10:25] <grrrit-wm>	 (03PS1) 10Hashar: MediaWiki REL1_23 has been cut [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/125970 
[11:10:35] <grrrit-wm>	 (03CR) 10Hashar: [C: 032] MediaWiki REL1_23 has been cut [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/125970 (owner: 10Hashar)
[11:10:48] <grrrit-wm>	 (03Merged) 10jenkins-bot: MediaWiki REL1_23 has been cut [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/125970 (owner: 10Hashar)
[11:28:02] <grrrit-wm>	 (03CR) 10Hashar: "Refreshed the three jobs:" [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/125411 (owner: 10Hashar)
[11:39:35] <grrrit-wm>	 (03CR) 10Hashar: [C: 04-1] "The copy-to-master Jenkins wrapper does not let us strip a path prefix, so the URL will end up with /rdoc/ which is not idea :-/ operati" (031 comment) [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/125919 (owner: 10BryanDavis)
[11:42:46] <grrrit-wm>	 (03PS6) 10Hashar: Cucumber should only run tests tagged both @clean and (@firefox or @phantomjs) [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/125386 (owner: 10Zfilipin)
[11:43:56] <grrrit-wm>	 (03PS7) 10Hashar: Cucumber should only run tests tagged both @clean and (@firefox or @phantomjs) [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/125386 (owner: 10Zfilipin)
[11:44:03] <grrrit-wm>	 (03CR) 10KartikMistry: [C: 031] "LGTM; ie rebased." [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/125386 (owner: 10Zfilipin)
[11:44:25] <grrrit-wm>	 (03CR) 10Hashar: [C: 032] "confirmed --tags are joined with a AND (a OR is done by passing multiples tags separated by commas)" [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/125386 (owner: 10Zfilipin)
[11:45:36] <grrrit-wm>	 (03Merged) 10jenkins-bot: Cucumber should only run tests tagged both @clean and (@firefox or @phantomjs) [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/125386 (owner: 10Zfilipin)
[11:56:29] <grrrit-wm>	 (03CR) 10Yuvipanda: "mediawiki-config has these under wmgMFRemovableClasses, is that still applicable / working? Shouldn't that be split out perhaps?" [extensions/TextExtracts] - 10https://gerrit.wikimedia.org/r/125689 (owner: 10Prtksxna)
[11:59:08] <grrrit-wm>	 (03PS9) 10Physikerwelt: WIP: Changes in Database Layout for Math2.0 [extensions/Math] - 10https://gerrit.wikimedia.org/r/124805 
[12:00:02] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] WIP: Changes in Database Layout for Math2.0 [extensions/Math] - 10https://gerrit.wikimedia.org/r/124805 (owner: 10Physikerwelt)
[12:07:09] <grrrit-wm>	 (03CR) 10Frédéric Wang: WIP: Changes in Database Layout for Math2.0 (0310 comments) [extensions/Math] - 10https://gerrit.wikimedia.org/r/124805 (owner: 10Physikerwelt)
[12:32:26] <grrrit-wm>	 (03CR) 10Edokter: "Stumbling in because I was looking if thre was a bug for the mw-ui-button text color (too light), but never mind that." [core] - 10https://gerrit.wikimedia.org/r/116725 (owner: 10Deepali)
[12:44:41] <grrrit-wm>	 (03PS1) 10Gerrit Patch Uploader: Give darker text color to mw-ui-button [core] - 10https://gerrit.wikimedia.org/r/125980 
[12:44:43] <grrrit-wm>	 (03CR) 10Gerrit Patch Uploader: "This commit was uploaded using the Gerrit Patch Uploader [1]." [core] - 10https://gerrit.wikimedia.org/r/125980 (owner: 10Gerrit Patch Uploader)
[12:44:46] <grrrit-wm>	 (03PS1) 10UltrasonicNXT: Word break in very long usernames in the sidebar [extensions/MediaWikiChat] - 10https://gerrit.wikimedia.org/r/125981 
[12:45:33] <grrrit-wm>	 (03PS2) 10Edokter: Give darker text color to mw-ui-button [core] - 10https://gerrit.wikimedia.org/r/125980 (owner: 10Gerrit Patch Uploader)
[12:50:25] <grrrit-wm>	 (03CR) 10Lord Farin: WIP: Changes in Database Layout for Math2.0 (036 comments) [extensions/Math] - 10https://gerrit.wikimedia.org/r/124805 (owner: 10Physikerwelt)
[13:20:01] <grrrit-wm>	 (03PS17) 10TheDJ: Add pagination support to watchlist editor [core] - 10https://gerrit.wikimedia.org/r/53968 (owner: 10Eranroz)
[13:29:39] <grrrit-wm>	 (03PS18) 10TheDJ: Add pagination support to watchlist editor [core] - 10https://gerrit.wikimedia.org/r/53968 (owner: 10Eranroz)
[13:30:29] <grrrit-wm>	 (03CR) 10TheDJ: "Rebased and cleaned up a few of the CS problems." (033 comments) [core] - 10https://gerrit.wikimedia.org/r/53968 (owner: 10Eranroz)
[13:31:00] <grrrit-wm>	 (03CR) 10Hoo man: [C: 04-1] "The URLs need to be configurable somehow (it should be possible to run these tests on a local install). If you want to make something Wiki" [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/125740 (owner: 10Zfilipin)
[13:34:53] <grrrit-wm>	 (03CR) 10Ragesoss: [C: 031] "I tested this, and it works as expected locally. I also reviewed the code, and everything looks good to me, but I'll wait to Adam or Andre" [extensions/EducationProgram] - 10https://gerrit.wikimedia.org/r/125959 (owner: 1001tonythomas)
[14:14:01] <grrrit-wm>	 (03PS10) 10Physikerwelt: WIP: Changes in Database Layout for Math2.0 [extensions/Math] - 10https://gerrit.wikimedia.org/r/124805 
[14:16:35] <grrrit-wm>	 (03PS1) 10Anomie: Update Legal's ContactPage messages [extensions/WikimediaMessages] - 10https://gerrit.wikimedia.org/r/125994 
[14:21:11] <grrrit-wm>	 (03PS1) 10Tinaj1234: Moved 'Edit review' user preferences into the 'Recent changes' tab [extensions/FlaggedRevs] - 10https://gerrit.wikimedia.org/r/125996 
[14:23:57] <grrrit-wm>	 (03PS11) 10Physikerwelt: WIP: Changes in Database Layout for Math2.0 [extensions/Math] - 10https://gerrit.wikimedia.org/r/124805 
[14:28:24] <grrrit-wm>	 (03PS4) 10Physikerwelt: WIP: Using DB2 as Database backend. [extensions/MathSearch] - 10https://gerrit.wikimedia.org/r/116929 
[14:28:27] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] WIP: Using DB2 as Database backend. [extensions/MathSearch] - 10https://gerrit.wikimedia.org/r/116929 (owner: 10Physikerwelt)
[14:32:23] <grrrit-wm>	 (03PS5) 10Physikerwelt: WIP: Using DB2 as Database backend. [extensions/MathSearch] - 10https://gerrit.wikimedia.org/r/116929 
[14:32:25] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] WIP: Using DB2 as Database backend. [extensions/MathSearch] - 10https://gerrit.wikimedia.org/r/116929 (owner: 10Physikerwelt)
[14:35:24] <grrrit-wm>	 (03CR) 10Siebrand: [C: 032] Update Legal's ContactPage messages [extensions/WikimediaMessages] - 10https://gerrit.wikimedia.org/r/125994 (owner: 10Anomie)
[14:35:29] <grrrit-wm>	 (03Merged) 10jenkins-bot: Update Legal's ContactPage messages [extensions/WikimediaMessages] - 10https://gerrit.wikimedia.org/r/125994 (owner: 10Anomie)
[14:40:46] <grrrit-wm>	 (03CR) 10Frédéric Wang: WIP: Changes in Database Layout for Math2.0 (031 comment) [extensions/Math] - 10https://gerrit.wikimedia.org/r/124805 (owner: 10Physikerwelt)
[14:41:02] <grrrit-wm>	 (03PS6) 10Physikerwelt: WIP: Using DB2 as Database backend. [extensions/MathSearch] - 10https://gerrit.wikimedia.org/r/116929 
[14:41:04] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] WIP: Using DB2 as Database backend. [extensions/MathSearch] - 10https://gerrit.wikimedia.org/r/116929 (owner: 10Physikerwelt)
[14:42:37] <grrrit-wm>	 (03PS7) 10Physikerwelt: WIP: Using DB2 as Database backend. [extensions/MathSearch] - 10https://gerrit.wikimedia.org/r/116929 
[14:42:43] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] WIP: Using DB2 as Database backend. [extensions/MathSearch] - 10https://gerrit.wikimedia.org/r/116929 (owner: 10Physikerwelt)
[14:46:40] <grrrit-wm>	 (03PS8) 10Physikerwelt: WIP: Using DB2 as Database backend. [extensions/MathSearch] - 10https://gerrit.wikimedia.org/r/116929 
[14:46:45] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] WIP: Using DB2 as Database backend. [extensions/MathSearch] - 10https://gerrit.wikimedia.org/r/116929 (owner: 10Physikerwelt)
[14:52:56] <Nikerabbit>	 manybubbles: thanks!
[14:53:14] <manybubbles>	 Nikerabbit: thanks for all your work on it
[14:53:55] <grrrit-wm>	 (03PS1) 10Matthias Mullie: Fix "Notice: Undefined index: analysis" [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/126001 
[14:54:03] <grrrit-wm>	 (03CR) 10Fomafix: wpSummaryLabel and wpSummary in one line with full width (032 comments) [core] - 10https://gerrit.wikimedia.org/r/118246 (owner: 10Gerrit Patch Uploader)
[15:01:29] <grrrit-wm>	 (03CR) 10Anomie: [C: 032] Only you can prevent logspam [extensions/Flow] (wmf/1.23wmf21) - 10https://gerrit.wikimedia.org/r/125930 (owner: 10EBernhardson)
[15:02:19] <grrrit-wm>	 (03Merged) 10jenkins-bot: Only you can prevent logspam [extensions/Flow] (wmf/1.23wmf21) - 10https://gerrit.wikimedia.org/r/125930 (owner: 10EBernhardson)
[15:03:29] <grrrit-wm>	 (03PS1) 10Pcoombe: HTMLForm: fix double escaping of checkbox labels in vform [core] - 10https://gerrit.wikimedia.org/r/126004 
[15:06:59] <grrrit-wm>	 (03PS1) 10Anomie: Update Flow for SWAT deploy [core] (wmf/1.23wmf19) - 10https://gerrit.wikimedia.org/r/126005 
[15:07:26] <grrrit-wm>	 (03Abandoned) 10Anomie: Update Flow for SWAT deploy [core] (wmf/1.23wmf19) - 10https://gerrit.wikimedia.org/r/126005 (owner: 10Anomie)
[15:10:25] <grrrit-wm>	 (03PS1) 10Anomie: Update Flow for SWAT deploy [core] (wmf/1.23wmf21) - 10https://gerrit.wikimedia.org/r/126006 
[15:10:38] <grrrit-wm>	 (03CR) 10Anomie: [C: 032 V: 032] Update Flow for SWAT deploy [core] (wmf/1.23wmf21) - 10https://gerrit.wikimedia.org/r/126006 (owner: 10Anomie)
[15:10:58] <grrrit-wm>	 (03CR) 10Physikerwelt: WIP: Changes in Database Layout for Math2.0 (031 comment) [extensions/Math] - 10https://gerrit.wikimedia.org/r/124805 (owner: 10Physikerwelt)
[15:15:15] <grrrit-wm>	 (03PS2) 10Umherirrender: HTMLSelectOtherFields: Have 'other' always as first element [core] - 10https://gerrit.wikimedia.org/r/125209 
[15:16:31] <guillom>	 qgil: hello; are we doing appear.in or hangout?
[15:16:41] <qgil>	 guillom, hangout
[15:16:47] <guillom>	 qgil: ok, omw
[15:17:05] <grrrit-wm>	 (03Abandoned) 10Matthias Mullie: Fix "Notice: Undefined index: analysis" [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/126001 (owner: 10Matthias Mullie)
[15:18:52] <guillom>	 qgil: andre and I are there alone
[15:18:54] <qgil>	 andre__, guillom are you finding the hangout?
[15:19:07] <grrrit-wm>	 (03PS2) 10Phuedx: [WIP] Add a pre-edit anonymous signup invitation. [extensions/GettingStarted] - 10https://gerrit.wikimedia.org/r/125730 
[15:19:08] <andre__>	 qgil: we have found the hangout, but has it found you?
[15:19:08] <qgil>	 hm
[15:19:13] <guillom>	 using the link in the calendar invite
[15:19:17] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] [WIP] Add a pre-edit anonymous signup invitation. [extensions/GettingStarted] - 10https://gerrit.wikimedia.org/r/125730 (owner: 10Phuedx)
[15:23:12] <grrrit-wm>	 (03CR) 1001tonythomas: "needs removal of prefs-flaggedrevs from i18n files" (031 comment) [extensions/FlaggedRevs] - 10https://gerrit.wikimedia.org/r/125996 (owner: 10Tinaj1234)
[15:32:50] <grrrit-wm>	 (03CR) 10Jforrester: [C: 032] isFeatureEnabled: Return false if the feature is not whitelisted [extensions/BetaFeatures] - 10https://gerrit.wikimedia.org/r/125946 (owner: 10Legoktm)
[15:33:05] <grrrit-wm>	 (03Merged) 10jenkins-bot: isFeatureEnabled: Return false if the feature is not whitelisted [extensions/BetaFeatures] - 10https://gerrit.wikimedia.org/r/125946 (owner: 10Legoktm)
[15:33:33] <grrrit-wm>	 (03CR) 10Manybubbles: "Sorry! The Cirrus and Elastica plugins are really interrelated and have to move in lock step. Mediawiki doesn't give me an easy way to f" [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/126001 (owner: 10Matthias Mullie)
[15:37:38] <grrrit-wm>	 (03CR) 10Hashar: [C: 031] "Sounds good to me. Not sure you want to log at debug level by default though." [tools/scap] - 10https://gerrit.wikimedia.org/r/125515 (owner: 10BryanDavis)
[15:39:49] <grrrit-wm>	 (03CR) 10BryanDavis: "Raising the default logging level is likely to happen in a follow on patch at some point that makes '-v','--verbose' and/or '--debug' flag" [tools/scap] - 10https://gerrit.wikimedia.org/r/125515 (owner: 10BryanDavis)
[15:48:59] <grrrit-wm>	 (03PS2) 10Umherirrender: Remove unneeded rc_cur_time key from RCCacheEntryFactoryTest [core] - 10https://gerrit.wikimedia.org/r/125772 
[16:09:40] <grrrit-wm>	 (03CR) 10Anomie: [C: 032] Accept mw.title object as the title argument of frame:expandTemplate() [extensions/Scribunto] - 10https://gerrit.wikimedia.org/r/125207 (owner: 10Happy5214)
[16:10:57] <grrrit-wm>	 (03PS1) 10Pcoombe: Commit work so far [extensions/Petition] - 10https://gerrit.wikimedia.org/r/126011 
[16:11:27] <grrrit-wm>	 (03Merged) 10jenkins-bot: Accept mw.title object as the title argument of frame:expandTemplate() [extensions/Scribunto] - 10https://gerrit.wikimedia.org/r/125207 (owner: 10Happy5214)
[16:16:13] <grrrit-wm>	 (03PS2) 10Tinaj1234: Moved 'Edit review' user preferences into the 'Recent changes' tab [extensions/FlaggedRevs] - 10https://gerrit.wikimedia.org/r/125996 
[16:24:40] <grrrit-wm>	 (03PS1) 10Cscott: Sync up with Parsoid parserTests. [core] - 10https://gerrit.wikimedia.org/r/126013 
[16:24:42] <grrrit-wm>	 (03CR) 10Anomie: [C: 04-1] Use precise ApiMain/ApiQuery type hints in all API modules (035 comments) [core] - 10https://gerrit.wikimedia.org/r/120827 (owner: 10Thiemo Mättig (WMDE))
[16:31:22] <grrrit-wm>	 (03CR) 10Subramanya Sastry: [C: 032] Sync up with Parsoid parserTests. [core] - 10https://gerrit.wikimedia.org/r/126013 (owner: 10Cscott)
[16:34:13] <grrrit-wm>	 (03Merged) 10jenkins-bot: Sync up with Parsoid parserTests. [core] - 10https://gerrit.wikimedia.org/r/126013 (owner: 10Cscott)
[16:34:37] <grrrit-wm>	 (03CR) 1001tonythomas: [C: 031] "Tested. ready to go!" [extensions/FlaggedRevs] - 10https://gerrit.wikimedia.org/r/125996 (owner: 10Tinaj1234)
[16:38:31] <grrrit-wm>	 (03CR) 10Jdlrobson: "The name is lowercase due to Daniel Friesen's comment on https://gerrit.wikimedia.org/r/#/c/118347/" [skins/Modern] - 10https://gerrit.wikimedia.org/r/119885 (owner: 10Jdlrobson)
[16:47:05] <grrrit-wm>	 (03CR) 10GWicke: [C: 032] Handle conflicting image format options in predictable way. [core] - 10https://gerrit.wikimedia.org/r/119332 (owner: 10Cscott)
[16:50:40] <grrrit-wm>	 (03Merged) 10jenkins-bot: Handle conflicting image format options in predictable way. [core] - 10https://gerrit.wikimedia.org/r/119332 (owner: 10Cscott)
[16:52:08] <grrrit-wm>	 (03PS9) 10Kushal124: Make review settings configurable [wikimedia/wikimania-scholarships] - 10https://gerrit.wikimedia.org/r/125372 
[16:55:53] <Tuxedo_>	 hello, test
[17:00:02] <grrrit-wm>	 (03CR) 10Aaron Schulz: Improve UDP logging code (031 comment) [core] - 10https://gerrit.wikimedia.org/r/125436 (owner: 10IAlex)
[17:00:19] <Tuxedo_>	 Sometimes while running importImages against a file in a directory
[17:00:20] <Tuxedo_>	 there is an error, e.g.:
[17:00:22] <Tuxedo_>	 php importImages.php /tmp/dir --overwrite --user="Tux" --comment="Tux"
[17:00:23] <Tuxedo_>	 line 7: 81123 Segmentation fault: 11
[17:00:25] <Tuxedo_>	 Yet, the file is succesfully imported.
[17:00:49] <Tuxedo_>	 Line 7 is:
[17:00:50] <Tuxedo_>	 $optionsWithArgs = array( 'extensions', 'comment', 'comment-file', 'comment-ext', 'user', 'license' );
[17:01:06] <Tuxedo_>	 Can I safely ignore this error?
[17:01:24] <grrrit-wm>	 (03PS6) 10Kushal124: Fix validation error messages. [wikimedia/wikimania-scholarships] - 10https://gerrit.wikimedia.org/r/122123 
[17:07:41] <jackmcbarn>	 anomie: what are your thoughts on https://bugzilla.wikimedia.org/show_bug.cgi?id=63944 ?
[17:08:33] <grrrit-wm>	 (03CR) 10UltrasonicNXT: [C: 032 V: 032] Word break in very long usernames in the sidebar [extensions/MediaWikiChat] - 10https://gerrit.wikimedia.org/r/125981 (owner: 10UltrasonicNXT)
[17:10:01] <grrrit-wm>	 (03CR) 10Chad: [C: 032] Fix validation error messages. [wikimedia/wikimania-scholarships] - 10https://gerrit.wikimedia.org/r/122123 (owner: 10Kushal124)
[17:10:05] <grrrit-wm>	 (03Merged) 10jenkins-bot: Fix validation error messages. [wikimedia/wikimania-scholarships] - 10https://gerrit.wikimedia.org/r/122123 (owner: 10Kushal124)
[17:11:43] <grrrit-wm>	 (03CR) 10GWicke: [C: 031] Use square bounding boxes for default-sized thumbnails [core] - 10https://gerrit.wikimedia.org/r/123683 (owner: 10Cscott)
[17:16:53] <grrrit-wm>	 (03CR) 10Kushal124: "Chad: Thanks for the review :)" [wikimedia/wikimania-scholarships] - 10https://gerrit.wikimedia.org/r/122123 (owner: 10Kushal124)
[17:21:42] <grrrit-wm>	 (03PS1) 10BryanDavis: Add consistent punctuation to error messages [wikimedia/wikimania-scholarships] - 10https://gerrit.wikimedia.org/r/126023 
[17:24:28] <grrrit-wm>	 (03PS2) 10Jdlrobson: Get Flow non-JavaScript mode into mobile [extensions/Flow] - 10https://gerrit.wikimedia.org/r/125908 
[17:34:08] <grrrit-wm>	 (03CR) 10Swalling: "Comments inline, including a small style change and copy updates made after conferring with Moiz and Howie." (034 comments) [extensions/GettingStarted] - 10https://gerrit.wikimedia.org/r/125730 (owner: 10Phuedx)
[17:34:19] <StevenW>	 phuedx: ^
[17:34:22] <phuedx>	 thanks StevenW
[17:36:20] <hoo>	 wait... what "require mysql_wmf::client" on the bastion hosts... *sigh*
[17:37:31] <grrrit-wm>	 (03PS5) 10SG: mw-ui-button: Revamp the LESS to be simpler, and improve cross-browser support [core] - 10https://gerrit.wikimedia.org/r/123804 
[17:45:01] <grrrit-wm>	 (03CR) 10SG: "Fixed a couple of bugs. It's in a reviewable state now." [core] - 10https://gerrit.wikimedia.org/r/123804 (owner: 10SG)
[17:53:56] <grrrit-wm>	 (03CR) 10Bsitu: "Showed the latest UI to Maryana, something to change:" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/119640 (owner: 10Bsitu)
[17:54:59] <grrrit-wm>	 (03PS6) 10EBernhardson: Initial import of handlebars templates [extensions/Flow] (frontend-rewrite) - 10https://gerrit.wikimedia.org/r/125357 
[17:55:00] * ebernhardson  sighs .. gerrit always wants to autocomplete owner:self into something not self

[17:55:32] <grrrit-wm>	 (03CR) 10EBernhardson: [C: 032] Make various checks optional based on environment vars [extensions/Flow] - 10https://gerrit.wikimedia.org/r/125901 (owner: 10EBernhardson)
[17:55:41] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] Initial import of handlebars templates [extensions/Flow] (frontend-rewrite) - 10https://gerrit.wikimedia.org/r/125357 (owner: 10EBernhardson)
[17:55:53] <grrrit-wm>	 (03Merged) 10jenkins-bot: Make various checks optional based on environment vars [extensions/Flow] - 10https://gerrit.wikimedia.org/r/125901 (owner: 10EBernhardson)
[18:02:19] <grrrit-wm>	 (03PS7) 10EBernhardson: Initial import of handlebars templates [extensions/Flow] (frontend-rewrite) - 10https://gerrit.wikimedia.org/r/125357 
[18:02:31] <grrrit-wm>	 (03PS3) 10Bsitu: Provide better URLs to IRC rcfeed [extensions/Flow] - 10https://gerrit.wikimedia.org/r/123114 (owner: 10EBernhardson)
[18:02:56] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] Provide better URLs to IRC rcfeed [extensions/Flow] - 10https://gerrit.wikimedia.org/r/123114 (owner: 10EBernhardson)
[18:07:49] <grrrit-wm>	 (03PS1) 10Jforrester: Update OOjs UI to v0.1.0-pre (8197f2cd2e) [core] - 10https://gerrit.wikimedia.org/r/126032 
[18:11:33] <grrrit-wm>	 (03CR) 10Adamw: [C: 04-1] "couple little things..." (0314 comments) [extensions/Petition] - 10https://gerrit.wikimedia.org/r/126011 (owner: 10Pcoombe)
[18:12:46] <grrrit-wm>	 (03CR) 10Adamw: "please fix the commit message as well" [extensions/Petition] - 10https://gerrit.wikimedia.org/r/126011 (owner: 10Pcoombe)
[18:13:10] <grrrit-wm>	 (03PS1) 10Umherirrender: Fixed some @params documentation [core] - 10https://gerrit.wikimedia.org/r/126034 
[18:15:59] <grrrit-wm>	 (03CR) 10Mwalker: [C: 032] "Regarding the other hook... ick... but this is good! *high five*" [core] - 10https://gerrit.wikimedia.org/r/120396 (owner: 10TheDJ)
[18:18:34] <grrrit-wm>	 (03CR) 10Adamw: [C: 032] Moved EducationProgram preferences to Appearance tab [extensions/EducationProgram] - 10https://gerrit.wikimedia.org/r/125959 (owner: 1001tonythomas)
[18:18:48] <grrrit-wm>	 (03CR) 10Adamw: "Thank you for the cleanup!" [extensions/EducationProgram] - 10https://gerrit.wikimedia.org/r/125959 (owner: 1001tonythomas)
[18:18:54] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] Moved EducationProgram preferences to Appearance tab [extensions/EducationProgram] - 10https://gerrit.wikimedia.org/r/125959 (owner: 1001tonythomas)
[18:19:26] <thedj>	 so did we fork to 1.24  now ?
[18:23:33] <grrrit-wm>	 (03PS1) 10Umherirrender: Add @since to Skin::getAllowedSkins [core] - 10https://gerrit.wikimedia.org/r/126037 
[18:26:21] <grrrit-wm>	 (03CR) 10EBernhardson: [C: 032] Prevent PHPUnit from stringifying UUID instances [extensions/Flow] - 10https://gerrit.wikimedia.org/r/125912 (owner: 10EBernhardson)
[18:26:38] <grrrit-wm>	 (03Merged) 10jenkins-bot: Prevent PHPUnit from stringifying UUID instances [extensions/Flow] - 10https://gerrit.wikimedia.org/r/125912 (owner: 10EBernhardson)
[18:26:57] <grrrit-wm>	 (03PS14) 10Bartosz Dziewoński: New language variant 'en-x-piglatin' for easier variant testing [core] - 10https://gerrit.wikimedia.org/r/72053 (owner: 10Liangent)
[18:26:59] <grrrit-wm>	 (03PS7) 10Bartosz Dziewoński: LanguageConverter fixes to eliminate parser test failures [core] - 10https://gerrit.wikimedia.org/r/76341 (owner: 10Liangent)
[18:28:00] <grrrit-wm>	 (03CR) 10Bartosz Dziewoński: "Rebased, still needs work. The current RFC on language converter will probably help." [core] - 10https://gerrit.wikimedia.org/r/76341 (owner: 10Liangent)
[18:28:05] <grrrit-wm>	 (03CR) 10Bartosz Dziewoński: "Rebased, still needs work. The current RFC on language converter will probably help." [core] - 10https://gerrit.wikimedia.org/r/72053 (owner: 10Liangent)
[18:28:52] <grrrit-wm>	 (03PS1) 10Umherirrender: Avoid implict User::__toString [core] - 10https://gerrit.wikimedia.org/r/126041 
[18:29:17] <grrrit-wm>	 (03PS5) 10TheDJ: Allow the CodeEditor in read only mode [extensions/CodeEditor] - 10https://gerrit.wikimedia.org/r/120397 
[18:37:27] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] New language variant 'en-x-piglatin' for easier variant testing [core] - 10https://gerrit.wikimedia.org/r/72053 (owner: 10Liangent)
[18:38:35] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] LanguageConverter fixes to eliminate parser test failures [core] - 10https://gerrit.wikimedia.org/r/76341 (owner: 10Liangent)
[18:40:03] <grrrit-wm>	 (03CR) 10Jdlrobson: "This patchset is very scary and without a CSS regression test infrastructure I'm scared we might accidentally break something if this was " [core] - 10https://gerrit.wikimedia.org/r/123804 (owner: 10SG)
[18:41:45] <grrrit-wm>	 (03CR) 10Nikerabbit: [C: 04-1] Changing a message's lang must reset cached text. (031 comment) [core] - 10https://gerrit.wikimedia.org/r/125388 (owner: 10Daniel Kinzler)
[18:43:29] <grrrit-wm>	 (03CR) 10Esanders: [C: 032] Update OOjs UI to v0.1.0-pre (8197f2cd2e) [core] - 10https://gerrit.wikimedia.org/r/126032 (owner: 10Jforrester)
[18:46:51] <grrrit-wm>	 (03Merged) 10jenkins-bot: Update OOjs UI to v0.1.0-pre (8197f2cd2e) [core] - 10https://gerrit.wikimedia.org/r/126032 (owner: 10Jforrester)
[18:47:29] <grrrit-wm>	 (03PS1) 10Reedy: Declaration of ProofreadPageContent::preloadTransform() must be compatible with that of Content::preloadTransform(). [extensions/ProofreadPage] - 10https://gerrit.wikimedia.org/r/126045 
[18:48:54] <grrrit-wm>	 (03CR) 10Reedy: "Extension(s) weren't updated for these changes. See bug 63958" [core] - 10https://gerrit.wikimedia.org/r/116482 (owner: 10Jackmcbarn)
[18:50:02] <jackmcbarn>	 Reedy: is there a good way to find that type of issue ahead of time?
[18:50:33] <Reedy>	 In PhpStorm you can go Right Click -> Go To -> Implementations
[18:50:56] <Reedy>	 Grepping all the extensions for "function preloadTransform" should've found it at least
[18:51:25] <grrrit-wm>	 (03CR) 10Greg Grossmeier: ""Extension(s) weren't updated for these changes."" [core] - 10https://gerrit.wikimedia.org/r/116482 (owner: 10Jackmcbarn)
[18:51:26] <jackmcbarn>	 Reedy: is there a way to grep all extensions without downloading them all locally?
[18:51:38] <grrrit-wm>	 (03PS1) 10Chad: Followup af6d9aba: $search is a string, not an object [core] - 10https://gerrit.wikimedia.org/r/126046 
[18:51:55] <grrrit-wm>	 (03CR) 10Chad: [C: 032] Declaration of ProofreadPageContent::preloadTransform() must be compatible with that of Content::preloadTransform(). [extensions/ProofreadPage] - 10https://gerrit.wikimedia.org/r/126045 (owner: 10Reedy)
[18:52:11] <Reedy>	 jackmcbarn: I think you can do it with the right syntax on github
[18:52:36] <grrrit-wm>	 (03CR) 10Thiemo Mättig (WMDE): "Good catches, thanks. I run an other regex to make sure these are the only two places where doc and code got out of sync." (031 comment) [core] - 10https://gerrit.wikimedia.org/r/120827 (owner: 10Thiemo Mättig (WMDE))
[18:52:48] <grrrit-wm>	 (03CR) 10Jdlrobson: Separate style modules from JS modules (031 comment) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/125907 (owner: 10Jdlrobson)
[18:52:53] <grrrit-wm>	 (03Merged) 10jenkins-bot: Declaration of ProofreadPageContent::preloadTransform() must be compatible with that of Content::preloadTransform(). [extensions/ProofreadPage] - 10https://gerrit.wikimedia.org/r/126045 (owner: 10Reedy)
[18:52:57] <Tpt>	 Reedy: Thanks a lot for the fix to ProofreadPage.
[18:54:34] <grrrit-wm>	 (03PS4) 10Thiemo Mättig (WMDE): Use precise ApiMain/ApiQuery type hints in all API modules [core] - 10https://gerrit.wikimedia.org/r/120827 
[18:56:29] <grrrit-wm>	 (03PS1) 10Reedy: Declaration of ProofreadPageContent::preloadTransform() must be compatible with that of Content::preloadTransform(). [extensions/ProofreadPage] (wmf/1.23wmf22) - 10https://gerrit.wikimedia.org/r/126049 
[18:56:39] <qgil>	 gwicke, subbu https://plus.google.com/hangouts/_/hoaevent/AP36tYeIm4TUbruMG_LeFEyMQIrqhvf5ruQKE20HZ-3WPHWcVMUn9A
[18:56:56] <grrrit-wm>	 (03PS3) 10J-squared: Set the default end date for new courses as six months from present [extensions/EducationProgram] - 10https://gerrit.wikimedia.org/r/124771 
[18:57:24] <grrrit-wm>	 (03PS24) 10Bsitu: Closing & Summarizing topic frontend changes [extensions/Flow] - 10https://gerrit.wikimedia.org/r/119640 
[18:57:37] <Reedy>	 Tpt: It seems it already has a REL1_23 branch
[18:57:38] <Reedy>	 This branch is 0 commits ahead and 196 commits behind master
[18:57:39] <Reedy>	 :(
[18:58:18] <Tpt>	 Reedy: ProofreadPage?
[18:58:18] <grrrit-wm>	 (03CR) 10J-squared: "Updated the commit message with the bug number and changed the variable formatting to constant." [extensions/EducationProgram] - 10https://gerrit.wikimedia.org/r/124771 (owner: 10J-squared)
[18:58:24] <Reedy>	 Yup, seemingly
[18:58:34] <Reedy>	 https://github.com/wikimedia/mediawiki-extensions-ProofreadPage/tree/REL1_23
[18:58:55] <Tpt>	 Reedy: I believe it's a mistake.
[18:59:09] <Reedy>	 I'm just looking how to force update it
[19:00:08] <Tpt>	 Reedy: We might maybe delete it (I don't think it's used by anyone)
[19:02:29] <Reedy>	 ^d: Can we get force update enabled on the proofreadpage repo temporarily please?
[19:02:30] <grrrit-wm>	 (03PS1) 10Tpt: Fills $params to recursive calls of preloadTransform [extensions/ProofreadPage] - 10https://gerrit.wikimedia.org/r/126051 
[19:02:55] <grrrit-wm>	 (03PS4) 10EBernhardson: Provide better URLs to IRC rcfeed [extensions/Flow] - 10https://gerrit.wikimedia.org/r/123114 
[19:03:03] <qgil>	 Parsoid internals the talk, right now at https://plus.google.com/events/cjo2nmv8jr79k85urg6dvfrvvl0
[19:03:05] <grrrit-wm>	 (03PS3) 10Phuedx: [WIP] Add a pre-edit anonymous signup invitation [extensions/GettingStarted] - 10https://gerrit.wikimedia.org/r/125730 
[19:03:11] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] Provide better URLs to IRC rcfeed [extensions/Flow] - 10https://gerrit.wikimedia.org/r/123114 (owner: 10EBernhardson)
[19:03:23] <grrrit-wm>	 (03PS1) 10Aaron Schulz: Support tighter rate limiting for "non-standard" thumbnails [core] - 10https://gerrit.wikimedia.org/r/126052 
[19:04:28] <^d>	 Reedy: Done.
[19:04:34] <grrrit-wm>	 (03CR) 10Reedy: [C: 032] Declaration of ProofreadPageContent::preloadTransform() must be compatible with that of Content::preloadTransform(). [extensions/ProofreadPage] (wmf/1.23wmf22) - 10https://gerrit.wikimedia.org/r/126049 (owner: 10Reedy)
[19:04:41] <grrrit-wm>	 (03Merged) 10jenkins-bot: Declaration of ProofreadPageContent::preloadTransform() must be compatible with that of Content::preloadTransform(). [extensions/ProofreadPage] (wmf/1.23wmf22) - 10https://gerrit.wikimedia.org/r/126049 (owner: 10Reedy)
[19:04:49] <Reedy>	 To ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/ProofreadPage.git
[19:04:49] <Reedy>	    ba7dad6..3e202b9  REL1_23 -> REL1_23
[19:05:39] <Reedy>	 ^d: Done too. Can be disabled now. Thanks
[19:05:39] <Reedy>	 https://github.com/wikimedia/mediawiki-extensions-ProofreadPage/tree/REL1_23
[19:06:01] <^d>	 done done
[19:06:09] <grrrit-wm>	 (03PS1) 10Reedy: Update ProofreadPage [core] (wmf/1.23wmf22) - 10https://gerrit.wikimedia.org/r/126053 
[19:06:25] <grrrit-wm>	 (03CR) 10Reedy: [C: 032 V: 032] Update ProofreadPage [core] (wmf/1.23wmf22) - 10https://gerrit.wikimedia.org/r/126053 (owner: 10Reedy)
[19:06:52] <grrrit-wm>	 (03CR) 1001tonythomas: "Even after +2, jenkin's not starting the gate submit jobs. :(" [extensions/EducationProgram] - 10https://gerrit.wikimedia.org/r/125959 (owner: 1001tonythomas)
[19:07:13] <marcoil>	 qgil: which channel to interact with the tech talk? We're all getting non-interactive youtube instead of hangout
[19:08:04] <qgil>	 marcoil, sorry, it's the first time we try this combination. Please try https://plus.google.com/hangouts/_/hoaevent/AP36tYeIm4TUbruMG_LeFEyMQIrqhvf5ruQKE20HZ-3WPHWcVMUn9A
[19:08:54] <grrrit-wm>	 (03CR) 10Umherirrender: [C: 031] One more bump for 1.24 [core] - 10https://gerrit.wikimedia.org/r/125766 (owner: 10IAlex)
[19:08:56] <marcoil>	 cscott: ^^
[19:09:02] <grrrit-wm>	 (03CR) 10SG: "Not really. I've already split it up into the chunks I could. I advise everyone to test these changes on whatever platforms they can, as t" [core] - 10https://gerrit.wikimedia.org/r/123804 (owner: 10SG)
[19:10:30] <grrrit-wm>	 (03CR) 10SG: "Also, we need to stop using <input[type=button|submit]> in place of <button>. While these changes support that usage, it doesn't work as w" [core] - 10https://gerrit.wikimedia.org/r/123804 (owner: 10SG)
[19:10:41] <grrrit-wm>	 (03Abandoned) 10Tpt: Fills $params to recursive calls of preloadTransform [extensions/ProofreadPage] - 10https://gerrit.wikimedia.org/r/126051 (owner: 10Tpt)
[19:11:26] <grrrit-wm>	 (03PS2) 10Umherirrender: Avoid implict User::__toString in SpecialContributions.php [core] - 10https://gerrit.wikimedia.org/r/126041 
[19:11:57] <grrrit-wm>	 (03CR) 10Reedy: [C: 032] Followup af6d9aba: $search is a string, not an object [core] - 10https://gerrit.wikimedia.org/r/126046 (owner: 10Chad)
[19:12:04] <grrrit-wm>	 (03PS1) 10Reedy: Followup af6d9aba: $search is a string, not an object [core] (wmf/1.23wmf22) - 10https://gerrit.wikimedia.org/r/126054 
[19:12:32] <grrrit-wm>	 (03CR) 10Reedy: [C: 032] Followup af6d9aba: $search is a string, not an object [core] (wmf/1.23wmf22) - 10https://gerrit.wikimedia.org/r/126054 (owner: 10Reedy)
[19:15:51] <grrrit-wm>	 (03CR) 10Nemo bis: "Filed as bug 63959; needs V+2" [extensions/EducationProgram] - 10https://gerrit.wikimedia.org/r/125959 (owner: 1001tonythomas)
[19:16:54] <grrrit-wm>	 (03Merged) 10jenkins-bot: Followup af6d9aba: $search is a string, not an object [core] - 10https://gerrit.wikimedia.org/r/126046 (owner: 10Chad)
[19:17:01] <grrrit-wm>	 (03CR) 10Bartosz Dziewoński: "Umm, no, it's the <button> tag that doesn't work well in old browsers – IE6 not only has styling issues (I think), but also incorrectly su" [core] - 10https://gerrit.wikimedia.org/r/123804 (owner: 10SG)
[19:18:30] <grrrit-wm>	 (03Merged) 10jenkins-bot: Followup af6d9aba: $search is a string, not an object [core] (wmf/1.23wmf22) - 10https://gerrit.wikimedia.org/r/126054 (owner: 10Reedy)
[19:19:02] <grrrit-wm>	 (03CR) 10Bartosz Dziewoński: [C: 032] Avoid implict User::__toString in SpecialContributions.php [core] - 10https://gerrit.wikimedia.org/r/126041 (owner: 10Umherirrender)
[19:19:23] <grrrit-wm>	 (03CR) 10AndyRussG: "Thanks! Yeah, this is an intermittent Jenkins issue. Most of the time jslint passes fine, but sometimes..." [extensions/EducationProgram] - 10https://gerrit.wikimedia.org/r/125959 (owner: 1001tonythomas)
[19:23:08] <grrrit-wm>	 (03Merged) 10jenkins-bot: Avoid implict User::__toString in SpecialContributions.php [core] - 10https://gerrit.wikimedia.org/r/126041 (owner: 10Umherirrender)
[19:27:56] <grrrit-wm>	 (03CR) 10Adamw: [V: 032] "fool the Jenk" [extensions/EducationProgram] - 10https://gerrit.wikimedia.org/r/125959 (owner: 1001tonythomas)
[19:28:35] <grrrit-wm>	 (03PS1) 10Umherirrender: Remove redirectToFragment() from wikibits.js [core] - 10https://gerrit.wikimedia.org/r/126060 
[19:28:37] <jackmcbarn>	 Reedy: your patch doesn't pass params through to the other calls
[19:28:57] <Reedy>	 jackmcbarn: I was fixing the fatal
[19:29:03] <Reedy>	 Tpt has already made a change to do that
[19:29:41] <jackmcbarn>	 hmm, he abandoned it
[19:29:45] <jackmcbarn>	 Tpt: why?
[19:30:09] <Tpt>	 Reedy, jackmcbarn: I've just abandonned it because I'm not sure about how to do it: pass it only to the page body or to the three text areas (header, body, footer)
[19:30:22] <jackmcbarn>	 Tpt: it was right as you had it
[19:31:08] <Reedy>	 :)
[19:31:24] <grrrit-wm>	 (03Restored) 10Tpt: Fills $params to recursive calls of preloadTransform [extensions/ProofreadPage] - 10https://gerrit.wikimedia.org/r/126051 (owner: 10Tpt)
[19:31:37] <Tpt>	 jackmcbarn: I've just restored it. Feel free to +1
[19:31:58] <grrrit-wm>	 (03CR) 10Jackmcbarn: [C: 031] Fills $params to recursive calls of preloadTransform [extensions/ProofreadPage] - 10https://gerrit.wikimedia.org/r/126051 (owner: 10Tpt)
[19:32:22] <grrrit-wm>	 (03CR) 10Tpt: [C: 032] "Reviewed by Jackmcbarn" [extensions/ProofreadPage] - 10https://gerrit.wikimedia.org/r/126051 (owner: 10Tpt)
[19:32:30] <Tpt>	 jackmcbarn: Thanks
[19:32:35] <jackmcbarn>	 np
[19:32:49] <grrrit-wm>	 (03Merged) 10jenkins-bot: Fills $params to recursive calls of preloadTransform [extensions/ProofreadPage] - 10https://gerrit.wikimedia.org/r/126051 (owner: 10Tpt)
[19:37:02] <grrrit-wm>	 (03PS5) 10EBernhardson: Provide better URLs to IRC rcfeed [extensions/Flow] - 10https://gerrit.wikimedia.org/r/123114 
[19:37:05] <grrrit-wm>	 (03PS1) 10EBernhardson: Update argument checks in link building [extensions/Flow] - 10https://gerrit.wikimedia.org/r/126063 
[19:37:08] <grrrit-wm>	 (03PS1) 10EBernhardson: Repair checkuser unit test [extensions/Flow] - 10https://gerrit.wikimedia.org/r/126064 
[19:37:26] <YuviPanda>	 anyone around who can tell me about page protection levels?
[19:37:29] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] Provide better URLs to IRC rcfeed [extensions/Flow] - 10https://gerrit.wikimedia.org/r/123114 (owner: 10EBernhardson)
[19:37:34] <YuviPanda>	 for edit protection, can more than one level of protection be applied?
[19:37:52] <YuviPanda>	 protection levels are just 'autoconfirmed', 'sysop', etc, right? not multiple ones?
[19:37:57] <grrrit-wm>	 (03CR) 10Anomie: [C: 04-2] "Sorry, but saying that ApiBase::getMain() doesn't return an ApiMain gets a -1 from me. Since you seem uninterested in making that change, " [core] - 10https://gerrit.wikimedia.org/r/120827 (owner: 10Thiemo Mättig (WMDE))
[19:39:20] <MatmaRex>	 YuviPanda: the UI allows for only one kind of protection for each protected action, yes
[19:39:30] <legoktm>	 YuviPanda: nope, there can be arbitrary protection levels like "templateeditor" on enwiki
[19:39:30] <YuviPanda>	 MatmaRex: right.
[19:39:33] <MatmaRex>	 YuviPanda: the database schema allows for more than one, and there's a bug open to allow that in the UI
[19:39:38] <YuviPanda>	 oh
[19:39:46] <YuviPanda>	 so the API returns a list, usually with only one item.
[19:39:56] <YuviPanda>	 legoktm: right, that's fine. the question is the number
[19:40:02] <MatmaRex>	 YuviPanda: e.g. to keep indefinite autoconfirmed protection when applying expiring sysop protection
[19:40:08] <YuviPanda>	 aaha!
[19:40:09] <YuviPanda>	 right.
[19:40:11] <YuviPanda>	 that makes sense.
[19:40:20] <legoktm>	 YuviPanda: also, you might find a few old articles that show duplicate protection levels because they're still stored in the page_restrictions column and in the page_restrictions table
[19:40:23] <MatmaRex>	 (i don't have the number hand,y but i'm pretty sure it's filed)
[19:40:33] <YuviPanda>	 right
[19:40:46] <YuviPanda>	 so in the app I'm better off assuming the protections is a list and not a string
[19:42:08] <qgil>	 any questions about Parsoid internals for subbu gwicke ?
[19:46:17] <BlastHardcheese>	 people in here might find this relevant http://blog.detectify.com/post/82370846588/how-we-got-read-access-on-googles-production-servers
[19:48:20] <grrrit-wm>	 (03CR) 10SG: "I'm referring to styling issues with using complex CSS rules involving attribute selectors. I may have mitigated these issues with my late" [core] - 10https://gerrit.wikimedia.org/r/123804 (owner: 10SG)
[19:49:49] <Tuxedo_>	 Maybe someone can advise me on the following: I run 'php importImages.php /tmp/img --user=Tux' in the maintenance direcrory. Whenever I do this I get an error like "Importing Xyz.jpg...Segmentation fault: 11". Yet, the image is imported and appears in the wiki, oddly without the "delete" tab in the File:Xyz.jpg page. However, the file can be deleted further down the page via the 'delete all' link next to the thumb. So it works, but 
[19:51:11] <Tuxedo_>	 What user should importImages.php normally be run as?
[19:52:48] <grrrit-wm>	 (03CR) 10Spage: [C: 032] "I don't understand the mocking, butCheckUser tests failed before, pass now. Note Jenkins mwext-Flow-testextensions-master job doesn't run " [extensions/Flow] - 10https://gerrit.wikimedia.org/r/126064 (owner: 10EBernhardson)
[19:54:25] <grrrit-wm>	 (03CR) 10AndyRussG: [C: 04-1] "Almost...!" (032 comments) [extensions/EducationProgram] - 10https://gerrit.wikimedia.org/r/124771 (owner: 10J-squared)
[19:58:15] <grrrit-wm>	 (03CR) 10Bsitu: [C: 032] TopicBlock: fix renderTopicAPI to output history if requested [extensions/Flow] - 10https://gerrit.wikimedia.org/r/125953 (owner: 10Legoktm)
[19:58:36] <YuviPanda>	 oh, jenkins was stuck
[19:58:41] <grrrit-wm>	 (03Merged) 10jenkins-bot: TopicBlock: fix renderTopicAPI to output history if requested [extensions/Flow] - 10https://gerrit.wikimedia.org/r/125953 (owner: 10Legoktm)
[20:00:19] <grrrit-wm>	 (03PS11) 10Jforrester: Use new banana checker as a linter to avoid lacking qqq messages [core] - 10https://gerrit.wikimedia.org/r/125050 
[20:01:06] <grrrit-wm>	 (03CR) 10Jforrester: "Note that 'recheck' only runs the V+1 pipeline, not the V+2 pipeline, so it won't catch errors that require code execution like banana che" [core] - 10https://gerrit.wikimedia.org/r/125050 (owner: 10Jforrester)
[20:01:32] <grrrit-wm>	 (03CR) 10AndyRussG: Participation on create account via campaign url (032 comments) [extensions/Campaigns] (wip/editorcampaigns) - 10https://gerrit.wikimedia.org/r/119258 (owner: 10AndyRussG)
[20:03:14] <grrrit-wm>	 (03CR) 10Bsitu: [C: 032] Update argument checks in link building [extensions/Flow] - 10https://gerrit.wikimedia.org/r/126063 (owner: 10EBernhardson)
[20:03:37] <grrrit-wm>	 (03Merged) 10jenkins-bot: Update argument checks in link building [extensions/Flow] - 10https://gerrit.wikimedia.org/r/126063 (owner: 10EBernhardson)
[20:03:40] <grrrit-wm>	 (03Merged) 10jenkins-bot: Repair checkuser unit test [extensions/Flow] - 10https://gerrit.wikimedia.org/r/126064 (owner: 10EBernhardson)
[20:09:45] <grrrit-wm>	 (03PS1) 10EBernhardson: More dependencies for Flow [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/126091 
[20:10:29] <grrrit-wm>	 (03CR) 10Ori.livneh: [C: 032] Include xhprof module properly [vagrant] - 10https://gerrit.wikimedia.org/r/125943 (owner: 10EBernhardson)
[20:10:32] <grrrit-wm>	 (03PS2) 10EBernhardson: More dependencies for Flow [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/126091 
[20:10:37] <grrrit-wm>	 (03Merged) 10jenkins-bot: Include xhprof module properly [vagrant] - 10https://gerrit.wikimedia.org/r/125943 (owner: 10EBernhardson)
[20:10:50] <grrrit-wm>	 (03CR) 10EBernhardson: [C: 032] More dependencies for Flow [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/126091 (owner: 10EBernhardson)
[20:11:42] <grrrit-wm>	 (03Merged) 10jenkins-bot: More dependencies for Flow [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/126091 (owner: 10EBernhardson)
[20:14:56] <grrrit-wm>	 (03PS6) 10EBernhardson: Provide better URLs to IRC rcfeed [extensions/Flow] - 10https://gerrit.wikimedia.org/r/123114 
[20:15:13] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] Provide better URLs to IRC rcfeed [extensions/Flow] - 10https://gerrit.wikimedia.org/r/123114 (owner: 10EBernhardson)
[20:17:05] <grrrit-wm>	 (03Abandoned) 10Raimond Spekking: Localisation updates from https://translatewiki.net. [extensions/WikiForum] - 10https://gerrit.wikimedia.org/r/126109 (owner: 10L10n-bot)
[20:17:32] <grrrit-wm>	 (03PS4) 10J-squared: Update default end date for new courses [extensions/EducationProgram] - 10https://gerrit.wikimedia.org/r/124771 
[20:22:17] <grrrit-wm>	 (03CR) 10J-squared: "Thanks for the comments! I reformatted the commit message and made the duration variable a PHP constant. Any preferences for accessing it " [extensions/EducationProgram] - 10https://gerrit.wikimedia.org/r/124771 (owner: 10J-squared)
[20:25:30] <grrrit-wm>	 (03Abandoned) 10MaxSem: Test commit -01 - branch creation. [extensions/ApiSandbox] - 10https://gerrit.wikimedia.org/r/125878 (owner: 10Sirtomash)
[20:30:45] <grrrit-wm>	 (03PS1) 10Bartosz Dziewoński: Properly deprecate the SpecialVersionExtensionTypes hook [core] - 10https://gerrit.wikimedia.org/r/126121 
[20:30:47] <grrrit-wm>	 (03PS1) 10Bartosz Dziewoński: Consistently use '@deprecated since <version>' [core] - 10https://gerrit.wikimedia.org/r/126122 
[20:30:49] <grrrit-wm>	 (03PS1) 10Bartosz Dziewoński: Add 'since <version>' to @deprecated annotations [core] - 10https://gerrit.wikimedia.org/r/126123 
[20:31:05] <MatmaRex>	 ^ easy merges!
[20:34:41] <grrrit-wm>	 (03PS6) 10Bsitu: Add 'edit topic summary' no javascript support [extensions/Flow] - 10https://gerrit.wikimedia.org/r/120485 
[20:37:44] <grrrit-wm>	 (03PS1) 10Bartosz Dziewoński: Remove the $CHANGEDORCREATED parameter to the 'enotif_body' message [core] - 10https://gerrit.wikimedia.org/r/126126 
[20:38:28] <grrrit-wm>	 (03CR) 10AndyRussG: "Cool! Yeah, I think self:: would be standard fare here." [extensions/EducationProgram] - 10https://gerrit.wikimedia.org/r/124771 (owner: 10J-squared)
[20:38:33] <grrrit-wm>	 (03PS2) 10Bartosz Dziewoński: Remove the $CHANGEDORCREATED parameter to the 'enotif_body' message [core] - 10https://gerrit.wikimedia.org/r/126126 
[20:39:49] <grrrit-wm>	 (03CR) 10Bartosz Dziewoński: [C: 04-1] "I'm not sure if this is a good idea given how many usages there still are… Thoughts? Do we go ahead anyway? Do we undeprecate it?" [core] - 10https://gerrit.wikimedia.org/r/126126 (owner: 10Bartosz Dziewoński)
[20:40:01] <grrrit-wm>	 (03PS5) 10J-squared: Update default end date for new courses [extensions/EducationProgram] - 10https://gerrit.wikimedia.org/r/124771 
[20:43:12] <grrrit-wm>	 (03CR) 10Nemo bis: "Promises should be kept, but I see no benefit in removing that innocent line of BC code." [core] - 10https://gerrit.wikimedia.org/r/126126 (owner: 10Bartosz Dziewoński)
[20:43:29] <grrrit-wm>	 (03CR) 10Raimond Spekking: [C: 04-1] "Wouldn't this break all customizations of third party wikis, would it?" [core] - 10https://gerrit.wikimedia.org/r/126126 (owner: 10Bartosz Dziewoński)
[20:43:33] <grrrit-wm>	 (03PS1) 10Bartosz Dziewoński: wikibits.js: Remove deprecated stuff slated for removal in MW 1.23 [core] - 10https://gerrit.wikimedia.org/r/126127 
[20:43:49] <grrrit-wm>	 (03CR) 10Bartosz Dziewoński: [C: 04-1] "This looks like a very bad idea. I'm submitting this only to highlight just how bad it is. I'll file a bug about what to do with these." [core] - 10https://gerrit.wikimedia.org/r/126127 (owner: 10Bartosz Dziewoński)
[20:45:02] <grrrit-wm>	 (03CR) 10Bartosz Dziewoński: "Not sure about 'all', but it will break customizations that used this key." [core] - 10https://gerrit.wikimedia.org/r/126126 (owner: 10Bartosz Dziewoński)
[20:46:57] <grrrit-wm>	 (03CR) 10Bartosz Dziewoński: "This was apparently removed once before and restored per bug 42941." [core] - 10https://gerrit.wikimedia.org/r/126126 (owner: 10Bartosz Dziewoński)
[20:49:19] <grrrit-wm>	 (03CR) 10Siebrand: [C: 032] Consistently use '@deprecated since <version>' [core] - 10https://gerrit.wikimedia.org/r/126122 (owner: 10Bartosz Dziewoński)
[20:51:46] <grrrit-wm>	 (03CR) 10Bartosz Dziewoński: [C: 04-2] wikibits.js: Remove deprecated stuff slated for removal in MW 1.23 [core] - 10https://gerrit.wikimedia.org/r/126127 (owner: 10Bartosz Dziewoński)
[20:55:44] <grrrit-wm>	 (03CR) 10Bartosz Dziewoński: [C: 032] Remove redirectToFragment() from wikibits.js [core] - 10https://gerrit.wikimedia.org/r/126060 (owner: 10Umherirrender)
[20:58:01] <grrrit-wm>	 (03CR) 10Siebrand: [C: 032] Add consistent punctuation to error messages [wikimedia/wikimania-scholarships] - 10https://gerrit.wikimedia.org/r/126023 (owner: 10BryanDavis)
[20:58:16] <grrrit-wm>	 (03Merged) 10jenkins-bot: Add consistent punctuation to error messages [wikimedia/wikimania-scholarships] - 10https://gerrit.wikimedia.org/r/126023 (owner: 10BryanDavis)
[21:03:16] <grrrit-wm>	 (03CR) 10Bartosz Dziewoński: "Filed bug 63964 to discuss this." [core] - 10https://gerrit.wikimedia.org/r/126127 (owner: 10Bartosz Dziewoński)
[21:08:02] <grrrit-wm>	 (03PS3) 10Bsitu: Add Sorting to topic list based on last updated timestamp [extensions/Flow] - 10https://gerrit.wikimedia.org/r/124644 
[21:11:20] <grrrit-wm>	 (03PS4) 10Nemo bis: Use an actual URL for helppage in enotif_body [core] - 10https://gerrit.wikimedia.org/r/125219 
[21:14:58] <grrrit-wm>	 (03PS12) 10Jforrester: Use new banana checker as a linter to avoid lacking qqq messages [core] - 10https://gerrit.wikimedia.org/r/125050 
[21:16:49] <grrrit-wm>	 (03Merged) 10jenkins-bot: Remove redirectToFragment() from wikibits.js [core] - 10https://gerrit.wikimedia.org/r/126060 (owner: 10Umherirrender)
[21:19:04] <grrrit-wm>	 (03CR) 10Siebrand: [C: 031] "Pretty cool. If the test overlords agree, I support merging this." [core] - 10https://gerrit.wikimedia.org/r/125050 (owner: 10Jforrester)
[21:19:16] <James_F>	 siebrand: We do. :-)
[21:19:28] <James_F>	 siebrand: Given that Timo and I wrote the checker…
[21:20:47] <grrrit-wm>	 (03PS3) 10BryanDavis: Add puppet documentation job for mediawiki-vagrant [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/125919 
[21:22:08] <grrrit-wm>	 (03CR) 10Hashar: [C: 031] "Good! Wanna deploy it?" [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/125919 (owner: 10BryanDavis)
[21:22:46] <grrrit-wm>	 (03PS1) 10Ori.livneh: Update HHVM setup for HHVM 3 [vagrant] - 10https://gerrit.wikimedia.org/r/126133 
[21:24:16] <grrrit-wm>	 (03PS2) 10Ori.livneh: Update HHVM setup for HHVM 3 [vagrant] - 10https://gerrit.wikimedia.org/r/126133 
[21:26:19] <grrrit-wm>	 (03CR) 10Nemo bis: Use an actual URL for helppage in enotif_body (031 comment) [core] - 10https://gerrit.wikimedia.org/r/125219 (owner: 10Nemo bis)
[21:26:21] <grrrit-wm>	 (03CR) 10Ori.livneh: [C: 032] Update HHVM setup for HHVM 3 [vagrant] - 10https://gerrit.wikimedia.org/r/126133 (owner: 10Ori.livneh)
[21:26:43] <grrrit-wm>	 (03Merged) 10jenkins-bot: Update HHVM setup for HHVM 3 [vagrant] - 10https://gerrit.wikimedia.org/r/126133 (owner: 10Ori.livneh)
[21:26:59] <grrrit-wm>	 (03CR) 10Hashar: "I would rather see a generic banana jenkins job template which we could apply on all repositories using i18n messages. Good though :D" [core] - 10https://gerrit.wikimedia.org/r/125050 (owner: 10Jforrester)
[21:30:19] <grrrit-wm>	 (03CR) 10Ori.livneh: "Yes! :D" [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/125919 (owner: 10BryanDavis)
[21:33:33] <jackmcbarn>	 why does https://en.wikipedia.org/wiki/&apos; give a bad title error, but calling mw.title.new('&apos;') give me the title for the ' page?
[21:36:14] <grrrit-wm>	 (03PS5) 10Nemo bis: Use an actual URL for helppage in enotif_body [core] - 10https://gerrit.wikimedia.org/r/125219 
[21:36:57] <grrrit-wm>	 (03PS1) 10Ori.livneh: Revert "Bundle vagrant-vbguest plugin" [vagrant] - 10https://gerrit.wikimedia.org/r/126137 
[21:37:30] <grrrit-wm>	 (03PS2) 10Ori.livneh: Revert "Bundle vagrant-vbguest plugin" [vagrant] - 10https://gerrit.wikimedia.org/r/126137 
[21:37:45] <grrrit-wm>	 (03CR) 10Ori.livneh: "Bryan, thoughts?" [vagrant] - 10https://gerrit.wikimedia.org/r/126137 (owner: 10Ori.livneh)
[21:37:57] <ori>	 bd808: ^ when you have a chance
[21:38:40] <ori>	 i updated the bug with the full log of an attempt to provision a new instance
[21:39:08] <ori>	 i tried to work around it in various ways but the only thing that worked was disabling the plugin :/
[21:39:32] <YuviPanda>	 who provisions new instances anyway? 
[21:40:33] * bd808  goes to read the bug

[21:43:04] <bd808>	 ori: So basically we will replace one kind of broken with another? The problem today is upstream https://www.virtualbox.org/ticket/12879
[21:43:50] <bd808>	 The original problem I thought was that the image we specify has really old extensions baked in
[21:47:21] <grrrit-wm>	 (03CR) 10BryanDavis: "I guess I'm ok with it. The more invasive change would be to work around the upstream bug (https://www.virtualbox.org/ticket/12879 - Can't" [vagrant] - 10https://gerrit.wikimedia.org/r/126137 (owner: 10Ori.livneh)
[21:48:24] <grrrit-wm>	 (03PS1) 10Legoktm: Whitelist wctaiwan [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/126140 
[21:59:51] <grrrit-wm>	 (03CR) 10Thiemo Mättig (WMDE): "You did read my comment, did you? Making a base class depend on it's child is wrong." [core] - 10https://gerrit.wikimedia.org/r/120827 (owner: 10Thiemo Mättig (WMDE))
[22:03:44] <grrrit-wm>	 (03CR) 10Aldnonymous: [C: 031] Remove default group assignment [extensions/CheckUser] - 10https://gerrit.wikimedia.org/r/124324 (owner: 10John F. Lewis)
[22:05:52] <grrrit-wm>	 (03PS3) 10EBernhardson: UUID revamp [extensions/Flow] - 10https://gerrit.wikimedia.org/r/123691 (owner: 10Matthias Mullie)
[22:07:34] <grrrit-wm>	 (03PS1) 10Chad: Clean up job queue length script [extensions/WikimediaMaintenance] - 10https://gerrit.wikimedia.org/r/126145 
[22:09:32] <grrrit-wm>	 (03PS2) 10Chad: Clean up job queue length script [extensions/WikimediaMaintenance] - 10https://gerrit.wikimedia.org/r/126145 
[22:11:21] <grrrit-wm>	 (03CR) 10Mwalker: [C: 04-1] Preserve textarea state when building WikiEditor UI (031 comment) [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/124567 (owner: 10TheDJ)
[22:13:57] <grrrit-wm>	 (03Abandoned) 10Jforrester: tests to compare En, Qqq and messages.inc [core] - 10https://gerrit.wikimedia.org/r/5550 (owner: 10Hashar)
[22:15:20] <grrrit-wm>	 (03CR) 10Legoktm: [C: 04-1] "Not sure this is a good idea." [extensions/CheckUser] - 10https://gerrit.wikimedia.org/r/124324 (owner: 10John F. Lewis)
[22:23:27] <grrrit-wm>	 (03CR) 10Legoktm: [C: 04-1] "+1, just needs to be updated for the new i18n structure." [core] - 10https://gerrit.wikimedia.org/r/94614 (owner: 1001tonythomas)
[22:25:08] <grrrit-wm>	 (03CR) 10Legoktm: Clean up job queue length script (031 comment) [extensions/WikimediaMaintenance] - 10https://gerrit.wikimedia.org/r/126145 (owner: 10Chad)
[22:35:14] <grrrit-wm>	 (03CR) 10Hashar: [C: 032] Whitelist wctaiwan [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/126140 (owner: 10Legoktm)
[22:35:30] <grrrit-wm>	 (03Merged) 10jenkins-bot: Whitelist wctaiwan [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/126140 (owner: 10Legoktm)
[22:35:41] <YuviPanda>	 marktraceur: tgr you might be interested in https://bugzilla.wikimedia.org/show_bug.cgi?id=63873
[22:35:48] <grrrit-wm>	 (03CR) 10Hashar: "deployed. Thank you!" [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/126140 (owner: 10Legoktm)
[22:36:04] <grrrit-wm>	 (03PS3) 10Chad: Clean up job queue length script [extensions/WikimediaMaintenance] - 10https://gerrit.wikimedia.org/r/126145 
[22:36:17] <^d>	 legoktm: Thanks for the cr.
[22:36:25] <legoktm>	 np :)
[22:36:52] <marktraceur>	 YuviPanda: Ahhhrgh.
[22:36:55] <tgr>	 YuviPanda: we are thinking about how to get rid of moment.js actually
[22:37:04] <YuviPanda>	 tgr: yeah, but hopefully with a replacement :)
[22:37:11] <tgr>	 it's huge and we use it exactly one time in MediaViewer
[22:37:12] <^d>	 YuviPanda: Displaytitle bug is ew.
[22:37:20] <^d>	 Either A) I fix it just in Cirrus. This is easy.
[22:37:26] <^d>	 Or I fix it in core, which will be ugly.
[22:37:26] <tgr>	 but thanks
[22:37:35] <YuviPanda>	 tgr: it's also being used by other extensions.
[22:37:38] <^d>	 I could easily hack around it in Cirrus.
[22:37:50] <YuviPanda>	 ^d: fix it in cirrus, raise new bug for core?
[22:37:52] <grrrit-wm>	 (03CR) 10Bsitu: Standardize URL generation (031 comment) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/121855 (owner: 10EBernhardson)
[22:38:01] <YuviPanda>	 ^d: unless fix in cirrus is too ugly
[22:38:08] <^d>	 It's easy to fix both places.
[22:38:12] <^d>	 I don't *like* the core fix.
[22:38:16] <YuviPanda>	 aah :D
[22:38:21] <^d>	 Either I'd have to parse the page or hit page_props.
[22:38:26] <^d>	 Extra db queries are ugly.
[22:38:29] <^d>	 Ohhhh, duh.
[22:38:33] <^d>	 I'll override it.
[22:38:36] <^d>	 Silly me.
[22:38:49] * YuviPanda  gives ^d the silly hat

[22:38:50] <grrrit-wm>	 (03PS1) 10BryanDavis: Enable mediawiki-vagrant-puppet-doc on postmerge [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/126150 
[22:39:04] <^d>	 I should eat.
[22:39:04] <grrrit-wm>	 (03CR) 10Bsitu: [C: 04-1] "Getting a notice on Special:Recentchanges: Notice: Undefined index: flow-workflow-change in /var/www/wikimedia-git-repos/core/extensions/F" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/121855 (owner: 10EBernhardson)
[22:39:13] <YuviPanda>	 ^d: I should sleep
[22:39:15] <^d>	 YuviPanda: Core change will be a db query.
[22:39:20] <YuviPanda>	 oh damn, it's 4:10 AM!
[22:39:21] <^d>	 Cirrus will override it.
[22:39:48] <grrrit-wm>	 (03CR) 10BryanDavis: "Job created: https://integration.wikimedia.org/ci/job/mediawiki-vagrant-puppet-doc" [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/125919 (owner: 10BryanDavis)
[22:39:48] <YuviPanda>	 ^d: so overall 1 extra db hit?
[22:39:57] <^d>	 YuviPanda: Per result.
[22:39:58] <YuviPanda>	 ^d: at one time, and not per query, I guess.
[22:40:01] <YuviPanda>	 ^d: right.
[22:40:18] <grrrit-wm>	 (03PS2) 10Hashar: Enable mediawiki-vagrant-puppet-doc on postmerge [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/126150 (owner: 10BryanDavis)
[22:40:22] <YuviPanda>	 ^d: but this happens on save or somesuch, and not in query time?
[22:40:33] <^d>	 Other option is attempt parser cache and give up pretty quickly if we can't find it.
[22:40:36] <grrrit-wm>	 (03CR) 10Hashar: [C: 032] "rebased. Congratulations!" [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/126150 (owner: 10BryanDavis)
[22:40:43] * YuviPanda  has never looked into the search stuff

[22:40:52] <grrrit-wm>	 (03Merged) 10jenkins-bot: Enable mediawiki-vagrant-puppet-doc on postmerge [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/126150 (owner: 10BryanDavis)
[22:41:04] <YuviPanda>	 ^d: oh. that might end up having inconsistent results at places.
[22:41:08] <YuviPanda>	 but then again, this is mediawiki
[22:41:09] <^d>	 YuviPanda: I can do that in Cirrus to save it at indexing time and just return it. That's quick and easy.
[22:41:27] <^d>	 The core search implementation's too weak to store it.
[22:41:37] <^d>	 I hate it :p
[22:42:10] <grrrit-wm>	 (03PS4) 10Hashar: Add puppet documentation job for mediawiki-vagrant [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/125919 (owner: 10BryanDavis)
[22:42:59] <YuviPanda>	 ok, sleep time! 
[22:43:20] <grrrit-wm>	 (03CR) 10Hashar: [C: 032] "Job has been deployed by Bryan and registered in Zuul config." [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/125919 (owner: 10BryanDavis)
[22:44:12] <grrrit-wm>	 (03Merged) 10jenkins-bot: Add puppet documentation job for mediawiki-vagrant [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/125919 (owner: 10BryanDavis)
[22:50:30] <jackmcbarn>	 oh good. another way to smuggle data between #invoke's
[22:50:32] <jackmcbarn>	 https://dpaste.de/ntxK
[23:03:00] <grrrit-wm>	 (03CR) 10Ori.livneh: "I propose we simply wait until the fix makes its way to an official VirtualBox release, at which point we'll simply specify it as the mini" [vagrant] - 10https://gerrit.wikimedia.org/r/126137 (owner: 10Ori.livneh)
[23:07:09] <grrrit-wm>	 (03CR) 10Aaron Schulz: Clean up job queue length script (031 comment) [extensions/WikimediaMaintenance] - 10https://gerrit.wikimedia.org/r/126145 (owner: 10Chad)
[23:09:02] <grrrit-wm>	 (03PS1) 10Mwalker: MultiMediaViewer: Fix issues with file page link [core] (wmf/1.23wmf22) - 10https://gerrit.wikimedia.org/r/126160 
[23:09:42] <grrrit-wm>	 (03CR) 10Mwalker: [C: 032] MultiMediaViewer: Fix issues with file page link [core] (wmf/1.23wmf22) - 10https://gerrit.wikimedia.org/r/126160 (owner: 10Mwalker)
[23:10:31] <grrrit-wm>	 (03CR) 10BryanDavis: [C: 032] "Works for me. We can revert the revert when upstream is less broken." [vagrant] - 10https://gerrit.wikimedia.org/r/126137 (owner: 10Ori.livneh)
[23:12:33] <grrrit-wm>	 (03Merged) 10jenkins-bot: Revert "Bundle vagrant-vbguest plugin" [vagrant] - 10https://gerrit.wikimedia.org/r/126137 (owner: 10Ori.livneh)
[23:14:14] <grrrit-wm>	 (03Merged) 10jenkins-bot: MultiMediaViewer: Fix issues with file page link [core] (wmf/1.23wmf22) - 10https://gerrit.wikimedia.org/r/126160 (owner: 10Mwalker)
[23:16:33] <grrrit-wm>	 (03CR) 10Hashar: "Doc generated at https://doc.wikimedia.org/mediawiki-vagrant/" [vagrant] - 10https://gerrit.wikimedia.org/r/126137 (owner: 10Ori.livneh)
[23:22:12] <grrrit-wm>	 (03PS1) 10Trevor Parscal: Update for 126166 in VE Core [extensions/Math] - 10https://gerrit.wikimedia.org/r/126167 
[23:23:57] <grrrit-wm>	 (03CR) 10Trevor Parscal: [C: 032] Update VE implementation to use model-only inpsectors [extensions/Math] - 10https://gerrit.wikimedia.org/r/125933 (owner: 10Esanders)
[23:25:09] <grrrit-wm>	 (03Merged) 10jenkins-bot: Update VE implementation to use model-only inpsectors [extensions/Math] - 10https://gerrit.wikimedia.org/r/125933 (owner: 10Esanders)
[23:40:03] <grrrit-wm>	 (03CR) 10BryanDavis: "> I'd like to follow-up with another patch that makes the HHVM config a" [vagrant] - 10https://gerrit.wikimedia.org/r/126133 (owner: 10Ori.livneh)
[23:49:28] <grrrit-wm>	 (03CR) 10Adamw: [C: 031] "Would merge!" (032 comments) [extensions/Campaigns] (wip/editorcampaigns) - 10https://gerrit.wikimedia.org/r/123781 (owner: 10AndyRussG)
[23:55:07] <grrrit-wm>	 (03CR) 10Cscott: [C: 04-1] "Getting there, a few minor things." (034 comments) [core] - 10https://gerrit.wikimedia.org/r/102475 (owner: 10Tpt)
[23:59:16] <grrrit-wm>	 (03CR) 10Aaron Schulz: [C: 04-1] Improve UDP logging code (031 comment) [core] - 10https://gerrit.wikimedia.org/r/125436 (owner: 10IAlex)