[00:05:30] ^d: hey, you around? [00:05:40] ^d: wanna share your thoughts on https://gerrit.wikimedia.org/r/#/c/125565/ ? [00:11:00] MatmaRex, do you know why disabling JS and searching stops an exact match from redirecting you to the given page rather than showing the full search results? [00:11:54] Krenair: yes, it's implemented that way [00:12:16] Krenair: i've been concinved that it's less annoying than always redirecting you to the page with no easy way to perform fulltext search [00:12:32] Krenair: (yes, this code is my doing) [00:12:47] Okay. Thanks MatmaRex [00:13:03] Krenair: the initial version had two buttons visible for JS-less users, "Go" and "Search" [00:13:45] Krenair: https://gerrit.wikimedia.org/r/#/c/82100/ [00:14:42] there was a lengthy discussion there between mostly me, daniel and jon [00:15:00] i've seen some people complain about this behavior since, though :( [00:17:16] (03PS2) 10Reedy: Normalise comments in Setup.php [core] - 10https://gerrit.wikimedia.org/r/125677 (owner: 10IAlex) [00:17:20] (03CR) 10Reedy: [C: 032] Normalise comments in Setup.php [core] - 10https://gerrit.wikimedia.org/r/125677 (owner: 10IAlex) [00:20:55] (03PS4) 10Wctaiwan: HTMLForm vform styling [core] - 10https://gerrit.wikimedia.org/r/124383 [00:22:00] (03Merged) 10jenkins-bot: Normalise comments in Setup.php [core] - 10https://gerrit.wikimedia.org/r/125677 (owner: 10IAlex) [00:26:46] (03CR) 10Reedy: "We're up to 1.23wmf22... There'd be nothing wrong with branching REL1_23 against what 1.23wmf22 was branched from, lining up any backports" [core] - 10https://gerrit.wikimedia.org/r/118345 (owner: 10Jdlrobson) [00:29:38] Sounds like 1.23 is being branched later [00:31:01] (03CR) 10MarkAHershberger: "Reedy, Ask Markus about branching. I'm ok with you doing it, but he wanted to get some experience with this and his walk-through would he" [core] - 10https://gerrit.wikimedia.org/r/118345 (owner: 10Jdlrobson) [00:37:14] (03CR) 10Reedy: "The physical branching is just:" [core] - 10https://gerrit.wikimedia.org/r/118345 (owner: 10Jdlrobson) [00:38:26] (03CR) 10Reedy: "Either way, I'm not too fussed about who does it. Just getting it done is the main thing" [core] - 10https://gerrit.wikimedia.org/r/118345 (owner: 10Jdlrobson) [00:41:41] (03PS5) 10Wctaiwan: HTMLForm vform styling [core] - 10https://gerrit.wikimedia.org/r/124383 [00:48:40] (03CR) 10Wctaiwan: HTMLForm vform styling (037 comments) [core] - 10https://gerrit.wikimedia.org/r/124383 (owner: 10Wctaiwan) [01:22:08] (03PS1) 10Jackmcbarn: Add name to nosuchfunction and nosuchmodule errors [extensions/Scribunto] - 10https://gerrit.wikimedia.org/r/125683 [01:24:21] (03CR) 10jenkins-bot: [V: 04-1] Add name to nosuchfunction and nosuchmodule errors [extensions/Scribunto] - 10https://gerrit.wikimedia.org/r/125683 (owner: 10Jackmcbarn) [01:25:54] (03PS2) 10Jackmcbarn: Add name to nosuchfunction and nosuchmodule errors [extensions/Scribunto] - 10https://gerrit.wikimedia.org/r/125683 [01:34:10] Hi everyone. I need some problem-solving ideas, if anyone's got some. The page in question is: http://www.uesp.net/wiki/File:SurveyResult_Advertising.png [01:34:44] Looking at it, the problem will be obvious. The image is blank, right-clicking on the file and selecting Save Link As produces no effect. [01:35:02] But if you single-click on the file, the image displays fine. [01:35:32] I've looked at the file on the server, I've done a manual ImageMagick convert, all that stuff works out fine. [01:35:35] So...what gives? [01:42:04] RobinHood70: it's your ad blocker [01:42:06] turn it off [01:42:34] (and remove the note there. i'd do it but i don't want to reveal my IP) [01:44:13] Wow, you're right. I just opened it in Firefox and it's fine. Never thought of that. Thanks! [01:44:58] np [02:45:32] Reedy: ping [02:45:41] also ^demon|away [02:46:00] https://gerrit.wikimedia.org/r/#/c/31887/ was merged, so why not https://gerrit.wikimedia.org/r/#/c/112920/ ? [02:55:53] (03CR) 10Amire80: [C: 032] Namespace translation for Latvian [extensions/Scribunto] - 10https://gerrit.wikimedia.org/r/125680 (owner: 10Odder) [02:57:57] (03Merged) 10jenkins-bot: Namespace translation for Latvian [extensions/Scribunto] - 10https://gerrit.wikimedia.org/r/125680 (owner: 10Odder) [03:10:42] (03CR) 10Legoktm: [C: 032] ChangesListSpecialPage: Implement two new hooks superseding 4 old ones [core] - 10https://gerrit.wikimedia.org/r/106279 (owner: 10Bartosz Dziewoński) [03:13:56] (03Merged) 10jenkins-bot: ChangesListSpecialPage: Implement two new hooks superseding 4 old ones [core] - 10https://gerrit.wikimedia.org/r/106279 (owner: 10Bartosz Dziewoński) [03:26:33] (03PS4) 10Mwjames: Some cosmetics + basic test coverage [extensions/Bootstrap] - 10https://gerrit.wikimedia.org/r/125678 [03:28:42] (03PS1) 10Gnosygnu: v1.4.2.1 [xowa] - 10https://gerrit.wikimedia.org/r/125685 [03:29:37] (03CR) 10Gnosygnu: [C: 032 V: 032] "approving own commit" [xowa] - 10https://gerrit.wikimedia.org/r/125685 (owner: 10Gnosygnu) [03:34:58] (03CR) 10Mwjames: "Just pumping up the coverage which is currently at around ~68% while most new code comes from added tests." [extensions/Bootstrap] - 10https://gerrit.wikimedia.org/r/125678 (owner: 10Mwjames) [03:47:45] (03PS4) 10Prtksxna: Use document.createElementNS for svg:image [extensions/Popups] - 10https://gerrit.wikimedia.org/r/122352 [03:48:31] (03CR) 10Prtksxna: Use document.createElementNS for svg:image (033 comments) [extensions/Popups] - 10https://gerrit.wikimedia.org/r/122352 (owner: 10Prtksxna) [04:44:02] (03PS1) 10Hiong3-eng5: docgen output directory [extensions/WikiLexicalData] - 10https://gerrit.wikimedia.org/r/125688 [04:49:34] (03CR) 10Hiong3-eng5: "This is the bug that prevents us from generating our documentation." [extensions/WikiLexicalData] - 10https://gerrit.wikimedia.org/r/125688 (owner: 10Hiong3-eng5) [05:17:23] (03PS1) 10Prtksxna: Add classes and elements to the exclusion list [extensions/TextExtracts] - 10https://gerrit.wikimedia.org/r/125689 [05:29:59] (03PS2) 10IAlex: Make the global objects documentation consistent in Setup.php [core] - 10https://gerrit.wikimedia.org/r/122875 [05:30:27] (03PS2) 10IAlex: Remove isset() check in Sanitizer::setupAttributeWhitelist() [core] - 10https://gerrit.wikimedia.org/r/124157 [06:01:28] (03PS1) 10Prtksxna: Fix border issue with non-flipped landscape hovercards [extensions/Popups] - 10https://gerrit.wikimedia.org/r/125690 [06:08:28] (03CR) 10Quiddity: [C: 031] ".topbanner removes the ToC templates on Wikivoyage (eg https://en.wikivoyage.org/wiki/Moon )." [extensions/TextExtracts] - 10https://gerrit.wikimedia.org/r/125689 (owner: 10Prtksxna) [06:11:09] (03CR) 10Legoktm: [C: 032] "Thanks!" [extensions/GlobalCssJs] - 10https://gerrit.wikimedia.org/r/125571 (owner: 10Ori.livneh) [06:11:11] (03Merged) 10jenkins-bot: lowerInitialCamelCase module names [extensions/GlobalCssJs] - 10https://gerrit.wikimedia.org/r/125571 (owner: 10Ori.livneh) [06:17:47] (03PS4) 10Ori.livneh: Profiler class refactoring [core] - 10https://gerrit.wikimedia.org/r/125059 (owner: 10Aaron Schulz) [06:32:17] (03PS3) 10Nemo bis: Remove edit toolbar from the editing form [extensions/BookManagerv2] - 10https://gerrit.wikimedia.org/r/120573 (owner: 10Deepali) [06:32:44] (03CR) 10Nemo bis: "Thanks for your patches. If this depends on I6bde992eb63ed48ceea05d1c10b21564aad7cbbe it's better to clearly state so in the commit messag" [extensions/BookManagerv2] - 10https://gerrit.wikimedia.org/r/120573 (owner: 10Deepali) [06:35:46] (03CR) 10Nemo bis: "Welcome in gerrit/MediaWiki. :) When you no longer need the test patchset, you can click the "abandon" button." [test/mediawiki/extensions/examples] - 10https://gerrit.wikimedia.org/r/124857 (owner: 10Dsulej) [06:38:31] (03PS6) 10Nemo bis: [WIP] Make review setting configurable [wikimedia/wikimania-scholarships] - 10https://gerrit.wikimedia.org/r/125372 (owner: 10Kushal124) [06:39:42] (03CR) 10Nemo bis: "Hello, thanks for your patch. I'm adding a couple reviewers." [extensions/OAuth] - 10https://gerrit.wikimedia.org/r/124134 (owner: 10Renoirb) [07:06:25] (03PS1) 10Amire80: CamelCase for the special page name [extensions/Renameuser] - 10https://gerrit.wikimedia.org/r/125691 [07:06:30] (03PS1) 10Amire80: Add a full stop in the end of problemchanges-none [extensions/FlaggedRevs] - 10https://gerrit.wikimedia.org/r/125692 [07:17:27] (03CR) 10Krinkle: [C: 04-1] Add a status bar to the CodeEditor (038 comments) [extensions/CodeEditor] - 10https://gerrit.wikimedia.org/r/122601 (owner: 10TheDJ) [07:18:45] (03CR) 10Krinkle: Add a status bar to the CodeEditor (031 comment) [extensions/CodeEditor] - 10https://gerrit.wikimedia.org/r/122601 (owner: 10TheDJ) [07:22:49] (03CR) 10Nemo bis: [C: 04-1] "Thanks for your patch. I find the commit message quite lacking, see https://www.mediawiki.org/wiki/Gerrit/Commit_message_guidelines for in" [extensions/EducationProgram] - 10https://gerrit.wikimedia.org/r/118101 (owner: 10Jlloyd) [07:23:53] (03PS1) 10Fo0bar: Version 2.4.1 [extensions/SecureHTML] - 10https://gerrit.wikimedia.org/r/125693 [07:24:15] (03CR) 10Fo0bar: [C: 032 V: 032] Version 2.4.1 [extensions/SecureHTML] - 10https://gerrit.wikimedia.org/r/125693 (owner: 10Fo0bar) [07:24:35] (03CR) 10Nemo bis: "Thanks for your patch again. :) Needs rebase now. :( https://www.mediawiki.org/wiki/Gerrit/Advanced_usage#Build_failed_due_to_merge_confli" [extensions/WikiForum] - 10https://gerrit.wikimedia.org/r/120352 (owner: 10Severin Anatoliy) [07:25:23] (03CR) 10Nemo bis: "Thanks for your patch. For rebasing instructions, see https://www.mediawiki.org/wiki/Gerrit/Advanced_usage#Build_failed_due_to_merge_confl" [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/122242 (owner: 10TyA) [07:36:05] (03PS1) 10Fo0bar: Version 2.2 [extensions/GoogleSiteSearch] - 10https://gerrit.wikimedia.org/r/125694 [07:36:32] (03CR) 10Fo0bar: [C: 032 V: 032] Version 2.2 [extensions/GoogleSiteSearch] - 10https://gerrit.wikimedia.org/r/125694 (owner: 10Fo0bar) [07:47:07] (03PS6) 10TheDJ: Add a status bar to the CodeEditor [extensions/CodeEditor] - 10https://gerrit.wikimedia.org/r/122601 [07:47:27] (03CR) 10TheDJ: Add a status bar to the CodeEditor (039 comments) [extensions/CodeEditor] - 10https://gerrit.wikimedia.org/r/122601 (owner: 10TheDJ) [07:48:46] (03CR) 10TheDJ: [C: 032] Use document.createElementNS for svg:image [extensions/Popups] - 10https://gerrit.wikimedia.org/r/122352 (owner: 10Prtksxna) [07:48:52] (03Merged) 10jenkins-bot: Use document.createElementNS for svg:image [extensions/Popups] - 10https://gerrit.wikimedia.org/r/122352 (owner: 10Prtksxna) [08:40:45] (03CR) 10Addshore: [C: 032] Fix incorrect usage of Title::newFromText [extensions/Echo] - 10https://gerrit.wikimedia.org/r/116273 (owner: 10Legoktm) [08:40:56] (03Merged) 10jenkins-bot: Fix incorrect usage of Title::newFromText [extensions/Echo] - 10https://gerrit.wikimedia.org/r/116273 (owner: 10Legoktm) [08:49:22] (03CR) 10Siebrand: [C: 031] "i18n/L10n reviewed." [extensions/Flow] - 10https://gerrit.wikimedia.org/r/121306 (owner: 10Wctaiwan) [08:51:06] (03CR) 10Siebrand: [C: 032] Add a full stop in the end of problemchanges-none [extensions/FlaggedRevs] - 10https://gerrit.wikimedia.org/r/125692 (owner: 10Amire80) [08:51:13] (03Merged) 10jenkins-bot: Add a full stop in the end of problemchanges-none [extensions/FlaggedRevs] - 10https://gerrit.wikimedia.org/r/125692 (owner: 10Amire80) [08:52:13] (03CR) 10Siebrand: [C: 032] CamelCase for the special page name [extensions/Renameuser] - 10https://gerrit.wikimedia.org/r/125691 (owner: 10Amire80) [08:52:15] (03Merged) 10jenkins-bot: CamelCase for the special page name [extensions/Renameuser] - 10https://gerrit.wikimedia.org/r/125691 (owner: 10Amire80) [08:53:09] (03PS1) 10Pastakhov: fix variables (version 1.1.0) [extensions/PhpTags] - 10https://gerrit.wikimedia.org/r/125696 [08:53:15] (03CR) 10jenkins-bot: [V: 04-1] fix variables (version 1.1.0) [extensions/PhpTags] - 10https://gerrit.wikimedia.org/r/125696 (owner: 10Pastakhov) [08:53:36] (03CR) 10Siebrand: [C: 031] "L10n reviewed." [extensions/Scribunto] - 10https://gerrit.wikimedia.org/r/125683 (owner: 10Jackmcbarn) [09:09:31] (03PS1) 10UltrasonicNXT: Fix a few new 2.0 bugs [extensions/WikiForum] - 10https://gerrit.wikimedia.org/r/125698 [09:09:45] (03CR) 10UltrasonicNXT: [V: 032] Fix a few new 2.0 bugs [extensions/WikiForum] - 10https://gerrit.wikimedia.org/r/125698 (owner: 10UltrasonicNXT) [09:09:54] (03CR) 10UltrasonicNXT: [C: 032] Fix a few new 2.0 bugs [extensions/WikiForum] - 10https://gerrit.wikimedia.org/r/125698 (owner: 10UltrasonicNXT) [09:22:01] (03PS2) 10Pastakhov: fix variables (version 1.1.0) [extensions/PhpTags] - 10https://gerrit.wikimedia.org/r/125696 [09:38:06] how does our geoip database work actually ? [09:38:22] where is the data coming from ? [09:45:55] maxmind [09:48:01] Tim-away: thx ! [09:48:40] Is there a way to avoid "mentioning" (Echo) the user when using linking to a user page? [09:52:04] http://www.maxmind.com/en/correction there, that takes care of that then :D [09:53:22] liangent: https://en.wikipedia.org/wiki/Template:Noping [09:54:16] liangent: it uses a fullurl generated external link. [09:56:27] (03PS6) 10Bartosz Dziewoński: Create Parser::stripOuterParagraph to avoid code duplication [core] - 10https://gerrit.wikimedia.org/r/114942 [09:56:28] thedj: thanks and does "signature" in "It is not necessary to use this template if you are not signing your post, as Echo mentions only work with a signature included." include ~~~~~ ? [09:56:42] thedj: I mean what if I use {{subst:user:liangent/sign}} ~~~~~ instead of ~~~~ ? [09:57:32] to be honest, i wouldn't know what will happen in that case. [09:57:54] thedj: I'm actually trying to use {{user}} [09:58:50] (03CR) 10Bartosz Dziewoński: "Changed the behavior per Anomie and added some tests." [core] - 10https://gerrit.wikimedia.org/r/114942 (owner: 10Bartosz Dziewoński) [10:01:27] (03CR) 10TTO: "Jon is apparently not interested in this patch, despite having been pinged on two separate occasions. I'm inclined to continue without him" [core] - 10https://gerrit.wikimedia.org/r/111390 (owner: 10TTO) [10:12:36] (03CR) 10TheDJ: "Hmm, this just doesn't make me happy. I mean, isn't it better to have a micro extension that does this just for wikisource, rather than pu" [core] - 10https://gerrit.wikimedia.org/r/111390 (owner: 10TTO) [10:28:56] (03PS3) 10Pastakhov: fix variables (version 1.1.0) [extensions/PhpTags] - 10https://gerrit.wikimedia.org/r/125696 [10:39:25] (03CR) 10Bartosz Dziewoński: [C: 04-1] "And the implementation will need to be moved to MediaWikiTitleCodec::splitTitleString. It actually seems to implement parts of what this p" [core] - 10https://gerrit.wikimedia.org/r/43166 (owner: 10VitaliyFilippov) [10:43:45] (03CR) 10TTO: "It could probably be done. In fact, I started work on such a thing a while ago. However, it's quite unclear how to do it "cleanly". Also, " [core] - 10https://gerrit.wikimedia.org/r/111390 (owner: 10TTO) [11:07:58] (03PS2) 10Daniel Kinzler: Changing a message's lang must reset cached text. [core] - 10https://gerrit.wikimedia.org/r/125388 [11:18:58] (03CR) 10Daniel Kinzler: [C: 04-1] "Please operate on COntent objects, not native data, wherever possible." (034 comments) [core] - 10https://gerrit.wikimedia.org/r/125681 (owner: 10MarkAHershberger) [11:21:11] (03CR) 10Daniel Kinzler: "> Just adding &uselang=[language] to the end of the URL without wgLoginLanguageSelector does not work." [core] - 10https://gerrit.wikimedia.org/r/120475 (owner: 10Stepzhou) [11:46:26] (03PS1) 10PleaseStand: generateJsonI18n.php: Improve shim performance [core] - 10https://gerrit.wikimedia.org/r/125706 [12:03:49] (03CR) 10Siebrand: "I think it would be good to have a bug for this." (031 comment) [core] - 10https://gerrit.wikimedia.org/r/125706 (owner: 10PleaseStand) [12:04:49] (03PS1) 10Prtksxna: [wip] different thumbnail for small images [extensions/Popups] - 10https://gerrit.wikimedia.org/r/125707 [12:04:56] (03CR) 10jenkins-bot: [V: 04-1] [wip] different thumbnail for small images [extensions/Popups] - 10https://gerrit.wikimedia.org/r/125707 (owner: 10Prtksxna) [12:09:18] (03PS1) 10Matthias Mullie: Fix stored CU data by adding version number & revision id [extensions/Flow] - 10https://gerrit.wikimedia.org/r/125708 [12:12:36] (03CR) 10Siebrand: [C: 04-1] "I'm against using hidden parameters. They will only be used by an extremely small incrowd (possibly you alone, since there isn't even an o" [core] - 10https://gerrit.wikimedia.org/r/125674 (owner: 10Jackmcbarn) [12:15:42] (03CR) 10Siebrand: [C: 04-1] "Per Niklas and TTO. Please simplify the copy by adding 2parameters:" [core] - 10https://gerrit.wikimedia.org/r/83662 (owner: 10Jforrester) [12:20:04] (03CR) 10Siebrand: [C: 031] "L10n reviewed." [extensions/PhpTags] - 10https://gerrit.wikimedia.org/r/125696 (owner: 10Pastakhov) [12:23:08] (03PS1) 10Matthias Mullie: Add CheckUserQuery, making CU stuff a bit more like all other Query & Formatters [extensions/Flow] - 10https://gerrit.wikimedia.org/r/125710 [12:23:11] (03PS1) 10Matthias Mullie: Make buildActionLinks accept FormatterRow instead of some specific arguments [extensions/Flow] - 10https://gerrit.wikimedia.org/r/125711 [12:23:16] (03PS3) 10TheDJ: Prevent style jumping in WikiEditor [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/124734 [12:24:55] (03CR) 10Prtksxna: [V: 04-1] [wip] different thumbnail for small images [extensions/Popups] - 10https://gerrit.wikimedia.org/r/125707 (owner: 10Prtksxna) [12:25:16] (03CR) 10Siebrand: Rewrite (032 comments) [extensions/WikiForum] - 10https://gerrit.wikimedia.org/r/116258 (owner: 10UltrasonicNXT) [12:29:23] (03CR) 10Siebrand: [C: 031] "L10n reviewed." [extensions/Flow] - 10https://gerrit.wikimedia.org/r/119640 (owner: 10Bsitu) [12:32:59] (03CR) 10TheDJ: "@Krinkle, so where do you propose we add this exactly ? There are a few options..." (031 comment) [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/69896 (owner: 10Alex Monk) [12:35:53] (03CR) 10Faidon Liambotis: "Brad or Ori, can you review/merge this if it's right? This is actually a problem in production right now. I don't trust myself enough to m" [core] - 10https://gerrit.wikimedia.org/r/121912 (owner: 10Brian Wolff) [12:44:09] (03PS1) 10Addshore: Fix CS double space in TitleValue return [core] - 10https://gerrit.wikimedia.org/r/125712 [12:48:45] (03PS5) 10Robert Vogel: includes/Linker.php: Added hook for "Media:" links [core] - 10https://gerrit.wikimedia.org/r/120767 [12:49:05] (03PS2) 10Reedy: Cache RecentChanges Atom feed in varnish for 15 seconds [core] - 10https://gerrit.wikimedia.org/r/121912 (owner: 10Brian Wolff) [12:50:56] (03CR) 10jenkins-bot: [V: 04-1] Cache RecentChanges Atom feed in varnish for 15 seconds [core] - 10https://gerrit.wikimedia.org/r/121912 (owner: 10Brian Wolff) [12:51:10] (03PS3) 10Reedy: Cache RecentChanges Atom feed in varnish for 15 seconds [core] - 10https://gerrit.wikimedia.org/r/121912 (owner: 10Brian Wolff) [12:53:27] (03CR) 10Siebrand: [C: 032] Fix CS double space in TitleValue return [core] - 10https://gerrit.wikimedia.org/r/125712 (owner: 10Addshore) [12:54:17] (03CR) 10Reedy: [C: 032] Cache RecentChanges Atom feed in varnish for 15 seconds [core] - 10https://gerrit.wikimedia.org/r/121912 (owner: 10Brian Wolff) [12:55:15] (03CR) 10Siebrand: [C: 031] "i18n/L10n reviewed." [core] - 10https://gerrit.wikimedia.org/r/118113 (owner: 10Anomie) [12:55:35] (03CR) 10Nikerabbit: [C: 04-1] generateJsonI18n.php: Improve shim performance (031 comment) [core] - 10https://gerrit.wikimedia.org/r/125706 (owner: 10PleaseStand) [12:56:39] (03Merged) 10jenkins-bot: Fix CS double space in TitleValue return [core] - 10https://gerrit.wikimedia.org/r/125712 (owner: 10Addshore) [12:56:53] (03Merged) 10jenkins-bot: Cache RecentChanges Atom feed in varnish for 15 seconds [core] - 10https://gerrit.wikimedia.org/r/121912 (owner: 10Brian Wolff) [12:59:22] (03PS4) 10Siebrand: Fixed some @params documentation [core] - 10https://gerrit.wikimedia.org/r/125253 (owner: 10Umherirrender) [12:59:30] (03CR) 10Siebrand: [C: 032] Fixed some @params documentation [core] - 10https://gerrit.wikimedia.org/r/125253 (owner: 10Umherirrender) [12:59:37] (03CR) 10Siebrand: Fixed some @params documentation (031 comment) [core] - 10https://gerrit.wikimedia.org/r/125253 (owner: 10Umherirrender) [12:59:39] (03PS1) 10Reedy: Cache RecentChanges Atom feed in varnish for 15 seconds [core] (wmf/1.23wmf21) - 10https://gerrit.wikimedia.org/r/125714 [13:00:34] (03PS1) 10Reedy: Cache RecentChanges Atom feed in varnish for 15 seconds [core] (wmf/1.23wmf22) - 10https://gerrit.wikimedia.org/r/125716 [13:04:24] (03CR) 10Robert Vogel: "I just changed the order of the attributes. Therefore no modification of parserTests.txt was necessary. Thanks for the hint." [core] - 10https://gerrit.wikimedia.org/r/120767 (owner: 10Robert Vogel) [13:05:07] (03Merged) 10jenkins-bot: Fixed some @params documentation [core] - 10https://gerrit.wikimedia.org/r/125253 (owner: 10Umherirrender) [13:07:41] (03PS7) 10Gerrit Patch Uploader: wpSummaryLabel and wpSummary in one line with full width [core] - 10https://gerrit.wikimedia.org/r/118246 [13:07:43] (03CR) 10Gerrit Patch Uploader: "This commit was uploaded using the Gerrit Patch Uploader [1]." [core] - 10https://gerrit.wikimedia.org/r/118246 (owner: 10Gerrit Patch Uploader) [13:10:45] (03PS1) 10UltrasonicNXT: Don't parse smileys when wrapped in nowiki tags [extensions/MediaWikiChat] - 10https://gerrit.wikimedia.org/r/125718 [13:11:33] (03CR) 10PleaseStand: generateJsonI18n.php: Improve shim performance (031 comment) [core] - 10https://gerrit.wikimedia.org/r/125706 (owner: 10PleaseStand) [13:11:52] (03CR) 10UltrasonicNXT: Rewrite (031 comment) [extensions/WikiForum] - 10https://gerrit.wikimedia.org/r/116258 (owner: 10UltrasonicNXT) [13:12:03] (03CR) 10UltrasonicNXT: [C: 032 V: 032] Don't parse smileys when wrapped in nowiki tags [extensions/MediaWikiChat] - 10https://gerrit.wikimedia.org/r/125718 (owner: 10UltrasonicNXT) [13:16:46] (03CR) 10Nikerabbit: "Good finding." (031 comment) [core] - 10https://gerrit.wikimedia.org/r/125706 (owner: 10PleaseStand) [13:19:10] (03CR) 10Reedy: [C: 032 V: 032] Cache RecentChanges Atom feed in varnish for 15 seconds [core] (wmf/1.23wmf21) - 10https://gerrit.wikimedia.org/r/125714 (owner: 10Reedy) [13:19:22] (03CR) 10Reedy: [C: 032 V: 032] Cache RecentChanges Atom feed in varnish for 15 seconds [core] (wmf/1.23wmf22) - 10https://gerrit.wikimedia.org/r/125716 (owner: 10Reedy) [13:21:30] (03PS2) 10Manybubbles: Add a max offset parameter [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/125364 [13:22:17] (03CR) 10Manybubbles: "Amended to do what lsearchd does. We could probably also show the user an actual message instead." [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/125364 (owner: 10Manybubbles) [13:24:30] (03PS1) 10ArielGlenn: use the right index for page_restriction query, see rt #167081 [core] - 10https://gerrit.wikimedia.org/r/125719 [13:25:53] (03PS2) 10Matthias Mullie: Some changes to diff & hist links [extensions/Flow] - 10https://gerrit.wikimedia.org/r/123214 [13:27:18] (03PS1) 10Matthias Mullie: Add missing ContributionsRow to autoloader [extensions/Flow] - 10https://gerrit.wikimedia.org/r/125720 [13:43:36] (03CR) 10Reedy: "mysql:wikiadmin@db1023 [frwiki]> explain SELECT /* Title::loadRestrictions */ pr_type,pr_expiry,pr_level,pr_cascade FROM `page_restriction" [core] - 10https://gerrit.wikimedia.org/r/125719 (owner: 10ArielGlenn) [13:55:55] (03PS2) 10Matthias Mullie: Add "cur" & "prev" difflinks in history, similar to article history [extensions/Flow] - 10https://gerrit.wikimedia.org/r/123215 [13:55:58] (03PS2) 10Matthias Mullie: Remove some of the magic in formatTimestamp [extensions/Flow] - 10https://gerrit.wikimedia.org/r/123216 [13:56:24] (03CR) 10Chad: [C: 032] Add a max offset parameter [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/125364 (owner: 10Manybubbles) [13:56:41] (03Merged) 10jenkins-bot: Add a max offset parameter [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/125364 (owner: 10Manybubbles) [13:57:33] (03CR) 10Matthias Mullie: "Siebrand: it's used as alt-text for the timestamp-link on Special:RecentChanges (although some links are about to change in a later patch " [extensions/Flow] - 10https://gerrit.wikimedia.org/r/123216 (owner: 10Matthias Mullie) [14:02:53] (03PS2) 10Matthias Mullie: Make timestamps link to the revision at that particular point in time [extensions/Flow] - 10https://gerrit.wikimedia.org/r/123217 [14:03:33] (03CR) 10Matthias Mullie: "I've only rebased against current master & parent patches so far; I'll update to match changes in 121855 once that makes it in." [extensions/Flow] - 10https://gerrit.wikimedia.org/r/123217 (owner: 10Matthias Mullie) [14:05:28] (03PS1) 10Manybubbles: Move articles out of features directory [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/125724 [14:14:14] (03CR) 10Matthias Mullie: Add CheckUserQuery, making CU stuff a bit more like all other Query & Formatters (031 comment) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/125710 (owner: 10Matthias Mullie) [14:14:17] (03CR) 10Siebrand: [C: 031] "i18n/L10n reviewed." [extensions/Flow] - 10https://gerrit.wikimedia.org/r/123217 (owner: 10Matthias Mullie) [14:17:17] (03CR) 10Siebrand: [C: 031] "i18n/L10n reviewed." [extensions/Flow] - 10https://gerrit.wikimedia.org/r/123216 (owner: 10Matthias Mullie) [14:18:17] (03PS2) 10Matthias Mullie: (bug 63901) Fix stored CU data by adding version number & revision id [extensions/Flow] - 10https://gerrit.wikimedia.org/r/125708 [14:20:06] (03PS4) 10Umherirrender: Avoid using raw sql in SpecialUndelete.php [core] - 10https://gerrit.wikimedia.org/r/124659 [14:23:37] (03CR) 10Siebrand: [C: 031] "i18n/L10n reviewed." [core] - 10https://gerrit.wikimedia.org/r/117438 (owner: 10Bartosz Dziewoński) [14:24:30] (03CR) 10Siebrand: [C: 04-1] "i18n/L10n reviewed." [extensions/CodeEditor] - 10https://gerrit.wikimedia.org/r/125195 (owner: 10TheDJ) [14:24:59] Reedy: https://gerrit.wikimedia.org/r/#/c/112920/ can be merged? [14:31:37] (03CR) 10Anomie: [C: 032] Add name to nosuchfunction and nosuchmodule errors [extensions/Scribunto] - 10https://gerrit.wikimedia.org/r/125683 (owner: 10Jackmcbarn) [14:33:56] (03Merged) 10jenkins-bot: Add name to nosuchfunction and nosuchmodule errors [extensions/Scribunto] - 10https://gerrit.wikimedia.org/r/125683 (owner: 10Jackmcbarn) [14:46:36] (03PS3) 10AndyRussG: WIP Inform user about campaign and allow opt-out [extensions/Campaigns] (wip/editorcampaigns) - 10https://gerrit.wikimedia.org/r/125360 [14:46:53] (03CR) 10jenkins-bot: [V: 04-1] WIP Inform user about campaign and allow opt-out [extensions/Campaigns] (wip/editorcampaigns) - 10https://gerrit.wikimedia.org/r/125360 (owner: 10AndyRussG) [14:50:21] (03CR) 10Zfilipin: [C: 031] Move articles out of features directory [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/125724 (owner: 10Manybubbles) [14:54:05] (03CR) 10Chad: [C: 032] Move articles out of features directory [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/125724 (owner: 10Manybubbles) [14:54:10] (03PS4) 10AndyRussG: WIP Inform user about campaign and allow opt-out [extensions/Campaigns] (wip/editorcampaigns) - 10https://gerrit.wikimedia.org/r/125360 [14:54:17] (03CR) 10jenkins-bot: [V: 04-1] WIP Inform user about campaign and allow opt-out [extensions/Campaigns] (wip/editorcampaigns) - 10https://gerrit.wikimedia.org/r/125360 (owner: 10AndyRussG) [14:54:20] (03Merged) 10jenkins-bot: Move articles out of features directory [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/125724 (owner: 10Manybubbles) [14:58:29] (03PS5) 10AndyRussG: WIP Inform user about campaign and allow opt-out [extensions/Campaigns] (wip/editorcampaigns) - 10https://gerrit.wikimedia.org/r/125360 [14:58:32] (03PS4) 10TheDJ: [Do not merge] Allow the CodeEditor in read only mode [extensions/CodeEditor] - 10https://gerrit.wikimedia.org/r/120397 [14:58:58] (03PS14) 10TheDJ: [WIP] Additional CodeEditor buttons [extensions/CodeEditor] - 10https://gerrit.wikimedia.org/r/104512 [15:01:00] (03CR) 10Siebrand: WIP Inform user about campaign and allow opt-out (031 comment) [extensions/Campaigns] (wip/editorcampaigns) - 10https://gerrit.wikimedia.org/r/125360 (owner: 10AndyRussG) [15:01:13] (03CR) 10Siebrand: [C: 04-1] "i18n/L10n reviewed." [extensions/Campaigns] (wip/editorcampaigns) - 10https://gerrit.wikimedia.org/r/125360 (owner: 10AndyRussG) [15:02:11] (03PS1) 10Manybubbles: SWAT Update Cirrus [core] (wmf/1.23wmf21) - 10https://gerrit.wikimedia.org/r/125729 [15:02:23] (03CR) 10Manybubbles: [C: 032] SWAT Update Cirrus [core] (wmf/1.23wmf21) - 10https://gerrit.wikimedia.org/r/125729 (owner: 10Manybubbles) [15:02:38] (03CR) 10Siebrand: WIP Inform user about campaign and allow opt-out (033 comments) [extensions/Campaigns] (wip/editorcampaigns) - 10https://gerrit.wikimedia.org/r/125360 (owner: 10AndyRussG) [15:06:50] (03Merged) 10jenkins-bot: SWAT Update Cirrus [core] (wmf/1.23wmf21) - 10https://gerrit.wikimedia.org/r/125729 (owner: 10Manybubbles) [15:16:56] (03PS4) 10Phuedx: Generate a token and use it to bucket users [extensions/GettingStarted] - 10https://gerrit.wikimedia.org/r/125188 [15:16:58] (03PS1) 10Phuedx: [WIP] Add a pre-edit anonymous signup invitation. [extensions/GettingStarted] - 10https://gerrit.wikimedia.org/r/125730 [15:19:21] (03CR) 10KartikMistry: "Simple patch. Ping? :)" [core] - 10https://gerrit.wikimedia.org/r/122730 (owner: 10KartikMistry) [15:20:23] (03CR) 10Siebrand: [C: 04-1] "i18n/L10n reviewed." (031 comment) [extensions/GettingStarted] - 10https://gerrit.wikimedia.org/r/125730 (owner: 10Phuedx) [15:21:33] (03PS1) 10Manybubbles: Switch all English wikis to aggressive splitting [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/125731 [15:22:37] (03CR) 10TheDJ: "I'm not sure, if it is this patch, but it seems something is broken now. I can no longer get mathjax to work on beta labs:" [extensions/Math] - 10https://gerrit.wikimedia.org/r/110226 (owner: 10Physikerwelt) [15:23:09] Reedy: just so you know, it seems that mathjax in master is currently broken. [15:24:59] :( [15:28:02] Reedy: and i'm out all night, so i can't fix it, but i pingend frederic and left a message on the review i suspect [15:28:21] (03CR) 10Reedy: "Should I just branch?" [core] - 10https://gerrit.wikimedia.org/r/118345 (owner: 10Jdlrobson) [15:37:23] (03PS1) 10Reedy: Bump 1.24 [core] - 10https://gerrit.wikimedia.org/r/125735 [15:40:06] (03PS2) 10Cscott: Use square bounding boxes for default-sized thumbnails [core] - 10https://gerrit.wikimedia.org/r/123683 [15:41:28] (03PS3) 10Cscott: Use square bounding boxes for default-sized thumbnails [core] - 10https://gerrit.wikimedia.org/r/123683 [15:42:45] (03CR) 10Mglaser: "According to the release timeline, branching should be announced in advance: http://www.mediawiki.org/wiki/Project:Release_management/Rele" [core] - 10https://gerrit.wikimedia.org/r/118345 (owner: 10Jdlrobson) [15:46:08] (03CR) 10Reedy: "1.24 is yet to be branched, but it should be from the starting point of 1.23wmf22 (then any backports ontop)... So could be merged anytime" [core] - 10https://gerrit.wikimedia.org/r/125735 (owner: 10Reedy) [15:47:30] (03CR) 10Reedy: [C: 031] Bump 1.24 [core] - 10https://gerrit.wikimedia.org/r/125735 (owner: 10Reedy) [15:48:21] Reedy, how urgent is the need for a new branch? [15:48:31] mglaser: Not very [15:48:34] according to the "rules", we'd have to announce this one week in advance [15:48:39] o_0 [15:48:47] It'd be nice just not to diverge too much and have a tonne of backports to then bring in [15:49:15] We can upgrade master to 1.24 without the branch [15:49:37] ok. I'll announce it today and then we'll do the actual branching next Monday [15:50:12] so after branching all I have to do is change the version number back to 1.23? [15:52:31] hexmode, any thoughts on this? [15:58:02] (03PS6) 10AndyRussG: WIP Inform user about campaign and allow opt-out [extensions/Campaigns] (wip/editorcampaigns) - 10https://gerrit.wikimedia.org/r/125360 [15:58:34] mglaser: No... [15:58:51] Reedy: :) [15:59:02] I'd just branch using 58a58fb1f3337a995c053a8a93b2aa9b27f17326 [15:59:10] ok [15:59:12] Which is the point at which 1.23wmf22 was branched [15:59:19] Anything past that in master is 1.24 unless backported [15:59:33] ok, understood. Thanks, Reedy [16:00:28] (03CR) 10CSteipp: "Thanks! That makes a lot of very helpful additions. One minor comment inline, and there were several whitespaces that should be tabs inste" (031 comment) [extensions/OAuth] - 10https://gerrit.wikimedia.org/r/124134 (owner: 10Renoirb) [16:00:30] (03CR) 10Siebrand: [C: 032] "Go!" [core] - 10https://gerrit.wikimedia.org/r/125735 (owner: 10Reedy) [16:00:35] :D :D [16:00:42] * Reedy hugs siebrand [16:00:59] Reedy: I thought you'd self merged. [16:01:14] Reedy: I was disappointed that transltaewiki.net couldn't run 1.24 yet. [16:01:18] I probably would've done [16:01:19] (03CR) 10Renoirb: "Good to know about the whitespace policy, I haven't thought of that." [extensions/OAuth] - 10https://gerrit.wikimedia.org/r/124134 (owner: 10Renoirb) [16:03:31] (03Merged) 10jenkins-bot: Bump 1.24 [core] - 10https://gerrit.wikimedia.org/r/125735 (owner: 10Reedy) [16:05:15] (03CR) 10Siebrand: [C: 031] "i18n/L10n reviewed. 1 inline comment left; I don't know what the UI texts should be." (031 comment) [extensions/Campaigns] (wip/editorcampaigns) - 10https://gerrit.wikimedia.org/r/125360 (owner: 10AndyRussG) [16:08:08] (03CR) 10Reedy: [C: 031] "Core is bumped to 1.24alpha" [core] - 10https://gerrit.wikimedia.org/r/118345 (owner: 10Jdlrobson) [16:08:29] (03CR) 10AndyRussG: WIP Inform user about campaign and allow opt-out (031 comment) [extensions/Campaigns] (wip/editorcampaigns) - 10https://gerrit.wikimedia.org/r/125360 (owner: 10AndyRussG) [16:08:40] (03PS1) 10Zfilipin: The first Selenium test: CentralAuth log in [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/125740 [16:13:42] (03CR) 10Cscott: "Tim Starling: ping?" [core] - 10https://gerrit.wikimedia.org/r/123683 (owner: 10Cscott) [16:14:43] (03CR) 10Jforrester: "Yeah, the checker as written only checks for existence, not contents of the message. Adding that to the list." [core] - 10https://gerrit.wikimedia.org/r/125050 (owner: 10Jforrester) [16:14:52] (03PS7) 10Jforrester: Use new banana checker as a linter to avoid lacking qqq messages [core] - 10https://gerrit.wikimedia.org/r/125050 [16:15:49] (03PS2) 10Zfilipin: The first Selenium test: CentralAuth log in [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/125740 [16:16:11] (03CR) 10jenkins-bot: [V: 04-1] The first Selenium test: CentralAuth log in [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/125740 (owner: 10Zfilipin) [16:19:14] (03CR) 10Reedy: "Any reason this can't be merged?" [skins/CologneBlue] - 10https://gerrit.wikimedia.org/r/119884 (owner: 10Jdlrobson) [16:19:24] (03CR) 10Reedy: "Any reason this can't be merged?" [skins/Modern] - 10https://gerrit.wikimedia.org/r/119885 (owner: 10Jdlrobson) [16:20:42] (03CR) 10jenkins-bot: [V: 04-1] Use new banana checker as a linter to avoid lacking qqq messages [core] - 10https://gerrit.wikimedia.org/r/125050 (owner: 10Jforrester) [16:21:08] (03CR) 10AndyRussG: [C: 04-1] "Looks good! My only comment is about the constant (mentioned in our meeting)." (031 comment) [extensions/EducationProgram] - 10https://gerrit.wikimedia.org/r/124771 (owner: 10J-squared) [16:34:07] (03CR) 10Ori.livneh: "Let's do it" [core] - 10https://gerrit.wikimedia.org/r/117672 (owner: 10Ori.livneh) [16:37:20] (03CR) 10Hoo man: [C: 04-1] "I don't think this belongs into CentralAuth as long as it has hard coded domain names (test2.wikipedia) in it" [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/125740 (owner: 10Zfilipin) [16:37:53] (03CR) 10Umherirrender: "You missed the version string in PHPVersionError - the same procedure as every relase ... - Icc3d612d401c7c2a91678a4a5dc4a228383452e6" [core] - 10https://gerrit.wikimedia.org/r/125735 (owner: 10Reedy) [16:39:19] (03PS4) 10Umherirrender: document.createElementNS is null or not an object in IE8 [core] - 10https://gerrit.wikimedia.org/r/124905 [16:40:08] (03PS1) 10Reedy: Couple more 1.24 bumps [core] - 10https://gerrit.wikimedia.org/r/125750 [16:40:21] (03CR) 10Reedy: "I don't think it is currently documented, no." [core] - 10https://gerrit.wikimedia.org/r/125735 (owner: 10Reedy) [16:46:32] (03CR) 10Bartosz Dziewoński: [C: 04-1] "Will need another rebase before we can merge it, plus the release notes I mentioned." [core] - 10https://gerrit.wikimedia.org/r/110680 (owner: 10Gerrit Patch Uploader) [16:46:57] (03PS5) 10Ori.livneh: Profiler class refactoring [core] - 10https://gerrit.wikimedia.org/r/125059 (owner: 10Aaron Schulz) [16:47:02] (03CR) 10Ori.livneh: [C: 032] Profiler class refactoring [core] - 10https://gerrit.wikimedia.org/r/125059 (owner: 10Aaron Schulz) [16:50:01] (03CR) 10Chad: "Why do we need to wait between announcing the branch and branching?" [core] - 10https://gerrit.wikimedia.org/r/118345 (owner: 10Jdlrobson) [16:51:07] (03Merged) 10jenkins-bot: Profiler class refactoring [core] - 10https://gerrit.wikimedia.org/r/125059 (owner: 10Aaron Schulz) [16:51:57] (03PS6) 10Ori.livneh: Commit DB changes as normal on exception-based GUI errors [core] - 10https://gerrit.wikimedia.org/r/116625 (owner: 10Aaron Schulz) [16:52:02] (03CR) 10Ori.livneh: [C: 032] Commit DB changes as normal on exception-based GUI errors [core] - 10https://gerrit.wikimedia.org/r/116625 (owner: 10Aaron Schulz) [16:53:43] (03CR) 10Chad: [C: 032] Switch all English wikis to aggressive splitting [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/125731 (owner: 10Manybubbles) [16:53:48] (03CR) 10MarkTraceur: "-1.5 because James_F thinks "web" should be on by default for the echo preference." [extensions/BetaFeatures] - 10https://gerrit.wikimedia.org/r/84625 (owner: 10MarkTraceur) [16:54:12] (03CR) 10EBernhardson: [C: 031] "IE8 doesn't support SVG so this seems reasonable." [core] - 10https://gerrit.wikimedia.org/r/124905 (owner: 10Umherirrender) [16:54:19] (03Merged) 10jenkins-bot: Switch all English wikis to aggressive splitting [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/125731 (owner: 10Manybubbles) [16:54:54] (03CR) 10Stepzhou: "All the actual new user language setting is done in addNewAccount(). addNewAccount() is called after the user clicks "Create Your Account." [core] - 10https://gerrit.wikimedia.org/r/120475 (owner: 10Stepzhou) [16:55:38] (03CR) 10VitaliyFilippov: "These are both new features added recently?" [core] - 10https://gerrit.wikimedia.org/r/43166 (owner: 10VitaliyFilippov) [16:56:28] (03Merged) 10jenkins-bot: Commit DB changes as normal on exception-based GUI errors [core] - 10https://gerrit.wikimedia.org/r/116625 (owner: 10Aaron Schulz) [16:59:08] ori: how far did you get on https://gerrit.wikimedia.org/r/#/c/124511/ ? [16:59:12] (03PS1) 10UltrasonicNXT: Nowiki tags now work fully, and minor simplify [extensions/MediaWikiChat] - 10https://gerrit.wikimedia.org/r/125751 [16:59:22] (03CR) 10UltrasonicNXT: [C: 032 V: 032] Nowiki tags now work fully, and minor simplify [extensions/MediaWikiChat] - 10https://gerrit.wikimedia.org/r/125751 (owner: 10UltrasonicNXT) [17:01:37] (03CR) 10Bartosz Dziewoński: [C: 032] document.createElementNS is null or not an object in IE8 [core] - 10https://gerrit.wikimedia.org/r/124905 (owner: 10Umherirrender) [17:04:09] DanielK_WMDE: around? [17:04:47] (03Merged) 10jenkins-bot: document.createElementNS is null or not an object in IE8 [core] - 10https://gerrit.wikimedia.org/r/124905 (owner: 10Umherirrender) [17:05:12] DanielK_WMDE: i'm looking at MediaWikiTitleCodec::splitTitleString, and it throws a MalformedTitleException for every possible bad title condition – what do you think about creating a separate error class for each one? it would be useful to distinguish them in the UI in some cases [17:07:20] ori: I remember you were about to make a comment but we resolved that IRL [17:09:46] (03CR) 10Siebrand: [C: 032] Couple more 1.24 bumps [core] - 10https://gerrit.wikimedia.org/r/125750 (owner: 10Reedy) [17:12:24] (03PS2) 10EBernhardson: Add CheckUserQuery, making CU stuff a bit more like all other Query & Formatters [extensions/Flow] - 10https://gerrit.wikimedia.org/r/125710 (owner: 10Matthias Mullie) [17:12:55] (03Merged) 10jenkins-bot: Couple more 1.24 bumps [core] - 10https://gerrit.wikimedia.org/r/125750 (owner: 10Reedy) [17:23:13] (03CR) 10EBernhardson: Add CheckUserQuery, making CU stuff a bit more like all other Query & Formatters (031 comment) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/125710 (owner: 10Matthias Mullie) [17:24:08] AaronSchulz: no further (yet) [17:25:20] (03CR) 10EBernhardson: [C: 032] (bug 63901) Fix stored CU data by adding version number & revision id [extensions/Flow] - 10https://gerrit.wikimedia.org/r/125708 (owner: 10Matthias Mullie) [17:25:35] (03Merged) 10jenkins-bot: (bug 63901) Fix stored CU data by adding version number & revision id [extensions/Flow] - 10https://gerrit.wikimedia.org/r/125708 (owner: 10Matthias Mullie) [17:33:45] (03CR) 10Mattflaschen: [C: 04-1] "Followup to our discussion on IRC. As noted, I think the launcher/edit click listener code should be in a separate module." (037 comments) [extensions/GettingStarted] - 10https://gerrit.wikimedia.org/r/125730 (owner: 10Phuedx) [17:33:59] thanks superm401 [17:34:00] reading now [17:35:47] (03CR) 10Kipcool: [C: 032 V: 032] docgen output directory [extensions/WikiLexicalData] - 10https://gerrit.wikimedia.org/r/125688 (owner: 10Hiong3-eng5) [17:37:02] (03CR) 10Matthias Mullie: Add CheckUserQuery, making CU stuff a bit more like all other Query & Formatters (031 comment) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/125710 (owner: 10Matthias Mullie) [17:38:35] (03PS3) 10Matthias Mullie: Add CheckUserQuery, making CU stuff a bit more like all other Query & Formatters [extensions/Flow] - 10https://gerrit.wikimedia.org/r/125710 [17:41:13] (03CR) 10Umherirrender: "Should @var documentation not in the format "type $var" instead of "$var type"? I have no preferred way." [core] - 10https://gerrit.wikimedia.org/r/122875 (owner: 10IAlex) [17:43:18] (03PS1) 10UltrasonicNXT: Minor change, but it makes it prettier [extensions/MediaWikiChat] - 10https://gerrit.wikimedia.org/r/125756 [17:43:51] (03CR) 10UltrasonicNXT: [C: 032 V: 032] Minor change, but it makes it prettier [extensions/MediaWikiChat] - 10https://gerrit.wikimedia.org/r/125756 (owner: 10UltrasonicNXT) [17:44:53] (03CR) 10Bartosz Dziewoński: [C: 04-1] "Why is the 'cologneblue' in filename lowercase?" (031 comment) [skins/CologneBlue] - 10https://gerrit.wikimedia.org/r/119884 (owner: 10Jdlrobson) [17:45:11] (03CR) 10Bartosz Dziewoński: "Uses old i18n format?" [skins/Modern] - 10https://gerrit.wikimedia.org/r/119885 (owner: 10Jdlrobson) [17:45:19] (03CR) 10Bartosz Dziewoński: "Also uses old i18n format apparently." [skins/CologneBlue] - 10https://gerrit.wikimedia.org/r/119884 (owner: 10Jdlrobson) [17:48:03] (03CR) 10EBernhardson: [C: 032] Add CheckUserQuery, making CU stuff a bit more like all other Query & Formatters [extensions/Flow] - 10https://gerrit.wikimedia.org/r/125710 (owner: 10Matthias Mullie) [17:48:18] (03Merged) 10jenkins-bot: Add CheckUserQuery, making CU stuff a bit more like all other Query & Formatters [extensions/Flow] - 10https://gerrit.wikimedia.org/r/125710 (owner: 10Matthias Mullie) [17:48:27] (03PS2) 10EBernhardson: Make buildActionLinks accept FormatterRow instead of some specific arguments [extensions/Flow] - 10https://gerrit.wikimedia.org/r/125711 (owner: 10Matthias Mullie) [17:48:56] (03CR) 10EBernhardson: [C: 032] Make buildActionLinks accept FormatterRow instead of some specific arguments [extensions/Flow] - 10https://gerrit.wikimedia.org/r/125711 (owner: 10Matthias Mullie) [17:49:10] (03Merged) 10jenkins-bot: Make buildActionLinks accept FormatterRow instead of some specific arguments [extensions/Flow] - 10https://gerrit.wikimedia.org/r/125711 (owner: 10Matthias Mullie) [17:50:12] (03CR) 10Bartosz Dziewoński: "It seems we already have RELEASE-NOTES-1.24 on master and stuff… The point of announcing the branch would be that people would know when t" [core] - 10https://gerrit.wikimedia.org/r/118345 (owner: 10Jdlrobson) [17:52:58] (03PS30) 10Spage: Extract wiki and external links, file and template usages from text. [extensions/Flow] - 10https://gerrit.wikimedia.org/r/110090 (owner: 10Werdna) [17:53:19] (03CR) 10jenkins-bot: [V: 04-1] Extract wiki and external links, file and template usages from text. [extensions/Flow] - 10https://gerrit.wikimedia.org/r/110090 (owner: 10Werdna) [17:55:03] (03PS1) 10Jforrester: mediawiki.Title.js: Correct documentation structure for Title.exist [core] - 10https://gerrit.wikimedia.org/r/125758 [17:56:51] (03CR) 10Bartosz Dziewoński: [C: 04-1] mediawiki.Title.js: Correct documentation structure for Title.exist (033 comments) [core] - 10https://gerrit.wikimedia.org/r/125758 (owner: 10Jforrester) [17:57:48] (03CR) 10Siebrand: [WIP] Add a pre-edit anonymous signup invitation. (031 comment) [extensions/GettingStarted] - 10https://gerrit.wikimedia.org/r/125730 (owner: 10Phuedx) [17:58:39] (03PS2) 10CSteipp: Prevent GC during phpunit shutdown [core] - 10https://gerrit.wikimedia.org/r/123146 [18:00:47] MatmaRex: In what way is the indentation wrong? [18:00:56] James_F: spaces instead of tabs [18:01:13] MatmaRex: Ah, bloody "helpful" clipboards. [18:01:25] (03CR) 10Siebrand: "After today's export, about 40 undocumented messages in the MediaWiki installer remain. For those that wish to contribute, here's a list o" [core] - 10https://gerrit.wikimedia.org/r/125050 (owner: 10Jforrester) [18:01:49] MatmaRex: Also, yes, the tabs were intentional to split out the @example. [18:01:55] (03CR) 10jenkins-bot: [V: 04-1] mediawiki.Title.js: Correct documentation structure for Title.exist [core] - 10https://gerrit.wikimedia.org/r/125758 (owner: 10Jforrester) [18:02:02] (03CR) 10Mglaser: "I'll do the branching right now." [core] - 10https://gerrit.wikimedia.org/r/118345 (owner: 10Jdlrobson) [18:02:11] (03PS1) 10Bartosz Dziewoński: .gitreview: Adjust default branch for REL1_23 [core] (REL1_23) - 10https://gerrit.wikimedia.org/r/125759 [18:02:36] (03CR) 10Bartosz Dziewoński: "It's already branched :)" [core] - 10https://gerrit.wikimedia.org/r/118345 (owner: 10Jdlrobson) [18:02:37] MatmaRex: What do we use instead of @example for JSDuck 4? [18:02:40] (03CR) 10Chad: [C: 032] .gitreview: Adjust default branch for REL1_23 [core] (REL1_23) - 10https://gerrit.wikimedia.org/r/125759 (owner: 10Bartosz Dziewoński) [18:02:59] (03PS8) 10Siebrand: Use new banana checker as a linter to avoid lacking qqq messages [core] - 10https://gerrit.wikimedia.org/r/125050 (owner: 10Jforrester) [18:03:18] James_F: plaintext, i think :) [18:03:35] James_F: jquery.spinner for example has just "Example:" and an indented block of code [18:04:39] (03CR) 10Swalling: [WIP] Add a pre-edit anonymous signup invitation. (031 comment) [extensions/GettingStarted] - 10https://gerrit.wikimedia.org/r/125730 (owner: 10Phuedx) [18:04:58] MatmaRex: Plaintext on what, though? Just endless lines after @property? [18:05:13] (03PS1) 10Jdlrobson: Allow localization of LESS files on a per module basis [core] - 10https://gerrit.wikimedia.org/r/125760 [18:05:30] James_F: probably. i dunno, i don't really like jsduck a lot and prefer to avoid it if possible :) [18:06:57] (03CR) 10Bartosz Dziewoński: "This looks like something that should be backported to 1.23?" [core] - 10https://gerrit.wikimedia.org/r/116625 (owner: 10Aaron Schulz) [18:07:23] (03PS1) 10Bartosz Dziewoński: document.createElementNS is null or not an object in IE8 [core] (REL1_23) - 10https://gerrit.wikimedia.org/r/125761 [18:07:25] (03PS1) 1001tonythomas: Moved "Email options" preference to separate "Notifications" tab. [core] - 10https://gerrit.wikimedia.org/r/125762 [18:07:32] (03CR) 10Bartosz Dziewoński: [C: 032] document.createElementNS is null or not an object in IE8 [core] (REL1_23) - 10https://gerrit.wikimedia.org/r/125761 (owner: 10Bartosz Dziewoński) [18:08:26] MatmaRex : did you branch REL1_23? [18:08:30] (03Merged) 10jenkins-bot: .gitreview: Adjust default branch for REL1_23 [core] (REL1_23) - 10https://gerrit.wikimedia.org/r/125759 (owner: 10Bartosz Dziewoński) [18:09:06] mglaser: yes, i tried to restore sanity after people turned master into 1.24 without branching 1.23 [18:09:39] MatmaRex : there was some discussion about this here: https://gerrit.wikimedia.org/r/#/c/118345/ [18:09:48] i know, i replied there. [18:10:19] (03CR) 10Mglaser: "Branch created by Bartosz Dziewoński. Thanks!" [core] - 10https://gerrit.wikimedia.org/r/118345 (owner: 10Jdlrobson) [18:10:57] (03PS3) 10Bartosz Dziewoński: Remove jquery.delayedBind module [core] - 10https://gerrit.wikimedia.org/r/114955 [18:10:58] MatmaRex : ok, cool, so I don't need to do the job ;) [18:11:12] (03CR) 10Bartosz Dziewoński: "REL1_23 is branched now, this is good to merge (after rebasing)." [core] - 10https://gerrit.wikimedia.org/r/114955 (owner: 10Bartosz Dziewoński) [18:11:18] (03CR) 10Bartosz Dziewoński: "REL1_23 is branched now, this is good to merge (after rebasing)." [core] - 10https://gerrit.wikimedia.org/r/118733 (owner: 10Bartosz Dziewoński) [18:11:49] (03CR) 10jenkins-bot: [V: 04-1] Use new banana checker as a linter to avoid lacking qqq messages [core] - 10https://gerrit.wikimedia.org/r/125050 (owner: 10Jforrester) [18:12:33] (03PS1) 10Manybubbles: Better test case for word splitting in js [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/125764 [18:13:03] siebrand: around? [18:13:15] (03CR) 10jenkins-bot: [V: 04-1] Remove jquery.delayedBind module [core] - 10https://gerrit.wikimedia.org/r/114955 (owner: 10Bartosz Dziewoński) [18:13:48] (03CR) 10jenkins-bot: [V: 04-1] Allow localization of LESS files on a per module basis [core] - 10https://gerrit.wikimedia.org/r/125760 (owner: 10Jdlrobson) [18:15:42] (03Merged) 10jenkins-bot: document.createElementNS is null or not an object in IE8 [core] (REL1_23) - 10https://gerrit.wikimedia.org/r/125761 (owner: 10Bartosz Dziewoński) [18:17:53] (03CR) 10Liangent: [C: 031] "Looks sane." [extensions/Scribunto] - 10https://gerrit.wikimedia.org/r/125207 (owner: 10Happy5214) [18:19:29] (03PS4) 10Bartosz Dziewoński: Remove jquery.delayedBind module [core] - 10https://gerrit.wikimedia.org/r/114955 [18:20:01] (03CR) 10Bartosz Dziewoński: [C: 031] Remove jquery.delayedBind module [core] - 10https://gerrit.wikimedia.org/r/114955 (owner: 10Bartosz Dziewoński) [18:20:29] (03CR) 10Bartosz Dziewoński: "I don't think anything on Wikimedia wikis ever used this." [core] - 10https://gerrit.wikimedia.org/r/114955 (owner: 10Bartosz Dziewoński) [18:20:43] (03PS8) 10IAlex: Improve UDP logging code [core] - 10https://gerrit.wikimedia.org/r/125436 [18:20:56] (03CR) 10Merlijn van Deen: "Looks good to me overall, but my php-fu is weak." [extensions/OAuth] - 10https://gerrit.wikimedia.org/r/124134 (owner: 10Renoirb) [18:21:14] (03PS2) 10Jforrester: mediawiki.Title.js: Correct documentation structure for Title.exist [core] - 10https://gerrit.wikimedia.org/r/125758 [18:21:49] (03CR) 10Jforrester: mediawiki.Title.js: Correct documentation structure for Title.exist (033 comments) [core] - 10https://gerrit.wikimedia.org/r/125758 (owner: 10Jforrester) [18:22:11] (03CR) 10Jdlrobson: "(Test fails due to variable not existing outside scope of RL module but please review if this is a sane approach or not...)" [core] - 10https://gerrit.wikimedia.org/r/125760 (owner: 10Jdlrobson) [18:23:20] (03PS1) 10IAlex: One more bump for 1.24 [core] - 10https://gerrit.wikimedia.org/r/125766 [18:24:03] (03CR) 10Chad: [C: 032] Remove jquery.delayedBind module [core] - 10https://gerrit.wikimedia.org/r/114955 (owner: 10Bartosz Dziewoński) [18:24:23] (03PS7) 10Kushal124: Make review settings configurable [wikimedia/wikimania-scholarships] - 10https://gerrit.wikimedia.org/r/125372 [18:25:28] (03PS1) 10EBernhardson: Serialize UUID objects directly into cache [extensions/Flow] - 10https://gerrit.wikimedia.org/r/125767 [18:30:10] (03Merged) 10jenkins-bot: Remove jquery.delayedBind module [core] - 10https://gerrit.wikimedia.org/r/114955 (owner: 10Bartosz Dziewoński) [18:32:21] (03CR) 10Jackmcbarn: "I had thought of including the action in the default messages, but the action names aren't localized, so it wouldn't be right in any other" [core] - 10https://gerrit.wikimedia.org/r/125674 (owner: 10Jackmcbarn) [18:32:46] (03CR) 10Jdlrobson: "Zflipin could you help me out here? I don't write Ruby so I don't really know what I'm doing here... :-/" [ruby/api] - 10https://gerrit.wikimedia.org/r/125010 (owner: 10Jdlrobson) [18:33:13] (03PS1) 10Umherirrender: Drop rc_cur_time from recentchanges [core] - 10https://gerrit.wikimedia.org/r/125769 [18:33:17] (03PS7) 10Bartosz Dziewoński: mediawiki.api: Remove deprecated function parameters [core] - 10https://gerrit.wikimedia.org/r/118733 [18:33:46] (03CR) 10Bartosz Dziewoński: [C: 04-1] "Ori, how is the usage stats thing going?" [core] - 10https://gerrit.wikimedia.org/r/118733 (owner: 10Bartosz Dziewoński) [18:35:23] (03PS3) 10EBernhardson: Some changes to diff & hist links [extensions/Flow] - 10https://gerrit.wikimedia.org/r/123214 (owner: 10Matthias Mullie) [18:37:10] (03PS8) 10Kushal124: Make review settings configurable [wikimedia/wikimania-scholarships] - 10https://gerrit.wikimedia.org/r/125372 [18:39:20] (03CR) 10EBernhardson: [C: 032] Some changes to diff & hist links [extensions/Flow] - 10https://gerrit.wikimedia.org/r/123214 (owner: 10Matthias Mullie) [18:39:28] (03PS3) 10EBernhardson: Add "cur" & "prev" difflinks in history, similar to article history [extensions/Flow] - 10https://gerrit.wikimedia.org/r/123215 (owner: 10Matthias Mullie) [18:39:34] (03Merged) 10jenkins-bot: Some changes to diff & hist links [extensions/Flow] - 10https://gerrit.wikimedia.org/r/123214 (owner: 10Matthias Mullie) [18:40:04] (03CR) 10EBernhardson: [C: 032] Add "cur" & "prev" difflinks in history, similar to article history [extensions/Flow] - 10https://gerrit.wikimedia.org/r/123215 (owner: 10Matthias Mullie) [18:40:12] (03PS3) 10EBernhardson: Remove some of the magic in formatTimestamp [extensions/Flow] - 10https://gerrit.wikimedia.org/r/123216 (owner: 10Matthias Mullie) [18:40:17] (03Merged) 10jenkins-bot: Add "cur" & "prev" difflinks in history, similar to article history [extensions/Flow] - 10https://gerrit.wikimedia.org/r/123215 (owner: 10Matthias Mullie) [18:40:20] (03CR) 10jenkins-bot: [V: 04-1] Drop rc_cur_time from recentchanges [core] - 10https://gerrit.wikimedia.org/r/125769 (owner: 10Umherirrender) [18:42:45] (03CR) 10EBernhardson: [C: 032] Remove some of the magic in formatTimestamp [extensions/Flow] - 10https://gerrit.wikimedia.org/r/123216 (owner: 10Matthias Mullie) [18:42:53] (03PS3) 10EBernhardson: Make timestamps link to the revision at that particular point in time [extensions/Flow] - 10https://gerrit.wikimedia.org/r/123217 (owner: 10Matthias Mullie) [18:43:00] (03Merged) 10jenkins-bot: Remove some of the magic in formatTimestamp [extensions/Flow] - 10https://gerrit.wikimedia.org/r/123216 (owner: 10Matthias Mullie) [18:44:05] (03CR) 10EBernhardson: [C: 032] Make timestamps link to the revision at that particular point in time [extensions/Flow] - 10https://gerrit.wikimedia.org/r/123217 (owner: 10Matthias Mullie) [18:44:19] (03Merged) 10jenkins-bot: Make timestamps link to the revision at that particular point in time [extensions/Flow] - 10https://gerrit.wikimedia.org/r/123217 (owner: 10Matthias Mullie) [18:45:32] (03PS2) 10Umherirrender: Drop rc_cur_time from recentchanges [core] - 10https://gerrit.wikimedia.org/r/125769 [18:46:13] (03CR) 10Umherirrender: "Patch Set 2: Fixed missing column, removed trailing space" [core] - 10https://gerrit.wikimedia.org/r/125769 (owner: 10Umherirrender) [18:46:37] (03PS1) 10IAlex: Make profiling to UDP work again [core] - 10https://gerrit.wikimedia.org/r/125770 [18:48:30] (03CR) 10EBernhardson: [C: 032] Add flowaction param to flow query api calls [extensions/Flow] - 10https://gerrit.wikimedia.org/r/124386 (owner: 10Bsitu) [18:48:58] (03CR) 10EBernhardson: [C: 032] Load only header data from API when editting header [extensions/Flow] - 10https://gerrit.wikimedia.org/r/124781 (owner: 10Bsitu) [18:50:30] (03Merged) 10jenkins-bot: Add flowaction param to flow query api calls [extensions/Flow] - 10https://gerrit.wikimedia.org/r/124386 (owner: 10Bsitu) [18:50:53] (03Merged) 10jenkins-bot: Load only header data from API when editting header [extensions/Flow] - 10https://gerrit.wikimedia.org/r/124781 (owner: 10Bsitu) [18:50:56] (03CR) 10Bartosz Dziewoński: "I was pondering doing something similar once, and at the time I thought that creating a LESS wrapper function for wfMessage() could be the" [core] - 10https://gerrit.wikimedia.org/r/125760 (owner: 10Jdlrobson) [18:50:58] (03CR) 10EBernhardson: [C: 032] Update post/header revision storage search key [extensions/Flow] - 10https://gerrit.wikimedia.org/r/117099 (owner: 10Bsitu) [18:51:14] (03Merged) 10jenkins-bot: Update post/header revision storage search key [extensions/Flow] - 10https://gerrit.wikimedia.org/r/117099 (owner: 10Bsitu) [18:52:20] (03PS1) 10Umherirrender: Remove unneeded rc_cur_time from RCCacheEntryFactoryTest [core] - 10https://gerrit.wikimedia.org/r/125772 [18:53:32] James_F: hm, mwjsduck-gen appears to be a little borked. [18:53:54] MatmaRex: Eh. Maybe. I blame Krinkle|detached. [18:53:57] http://pastebin.com/r3LCnuwG [18:54:14] (i know, Windows; but i can't run it :D how can that even work?) [18:54:49] (03CR) 10Umherirrender: "Was added with I873f6b86007000a94337f0c963df4bf8fec5b715, but patch set was older than the remove from sql in I4a9c2fa813d1f25dfb755e564f7" [core] - 10https://gerrit.wikimedia.org/r/125772 (owner: 10Umherirrender) [18:59:11] (03CR) 10Bsitu: Fix a few bugs where Flow was not working on pristine pages. (034 comments) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/123812 (owner: 10Werdna) [19:03:43] (03CR) 10Umherirrender: "Have somebody a hex editor to check if http://code.jquery.com/jquery-1.8.3.js contains \r\n? I am not sure, if my ide would change the lin" [core] - 10https://gerrit.wikimedia.org/r/125560 (owner: 10Umherirrender) [19:04:28] (03PS1) 10Bartosz Dziewoński: mwjsduck-gen: Don't fail when running from different directory, Windows fixes [core] - 10https://gerrit.wikimedia.org/r/125773 [19:04:33] James_F: ^ [19:05:28] (03PS2) 10Bartosz Dziewoński: mwjsduck-gen: Don't fail when running from different directory, Windows fixes [core] - 10https://gerrit.wikimedia.org/r/125773 [19:06:03] (03CR) 10Nikerabbit: [C: 04-1] mediawiki.Title.js: Correct documentation structure for Title.exist (031 comment) [core] - 10https://gerrit.wikimedia.org/r/125758 (owner: 10Jforrester) [19:07:26] (03CR) 10EBernhardson: Add topic summary revision type (032 comments) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/117357 (owner: 10Bsitu) [19:07:36] (03CR) 10Hashar: "Christian wrote an email to wikitech-l about this http://lists.wikimedia.org/pipermail/wikitech-l/2014-April/075918.html "Keeping Code-Rev" [All-Projects] (refs/meta/config) - 10https://gerrit.wikimedia.org/r/124891 (owner: 10Hashar) [19:09:32] (03PS3) 10Wctaiwan: Fix a few bugs where Flow was not working on pristine pages. [extensions/Flow] - 10https://gerrit.wikimedia.org/r/123812 (owner: 10Werdna) [19:10:29] (03CR) 10Wctaiwan: "Tested to confirm that the issue with creating a header has been fixed. Haven't tested the other parts." [extensions/Flow] - 10https://gerrit.wikimedia.org/r/123812 (owner: 10Werdna) [19:14:40] (03PS1) 10Mwalker: Updating DI for WP currencies [core] (fundraising/REL1_22) - 10https://gerrit.wikimedia.org/r/125777 [19:14:42] (03PS1) 10Lewis Cawte: Update default interwiki lists. Remove various links that no longer work or seem to point to anywhere it is easy to create an interwiki for. Updated various links to use pretty URL or new structures protocols and some to point where the new equivalent sit [core] - 10https://gerrit.wikimedia.org/r/125778 [19:15:33] Reedy, how safe is it to run the make-extension-branches script? I wonder if it will take a long time to run? [19:15:47] (03CR) 10jenkins-bot: [V: 04-1] Updating DI for WP currencies [core] (fundraising/REL1_22) - 10https://gerrit.wikimedia.org/r/125777 (owner: 10Mwalker) [19:16:27] It's not going to be quick, but it shouldn't take too long [19:17:22] (03Abandoned) 10Mwalker: Updating DI for WP currencies [core] (fundraising/REL1_22) - 10https://gerrit.wikimedia.org/r/125777 (owner: 10Mwalker) [19:17:34] (03PS1) 10Mwalker: Updating DI for WorldPay currencies [core] (fundraising/REL1_22) - 10https://gerrit.wikimedia.org/r/125779 [19:18:40] (03CR) 10jenkins-bot: [V: 04-1] Updating DI for WorldPay currencies [core] (fundraising/REL1_22) - 10https://gerrit.wikimedia.org/r/125779 (owner: 10Mwalker) [19:19:58] (03PS3) 10Jforrester: mediawiki.Title.js: Correct documentation structure for Title.exist [core] - 10https://gerrit.wikimedia.org/r/125758 [19:20:44] MatmaRex: Do we support Windows for development (as opposed to deployment)? [19:21:07] James_F: why not? i use it [19:21:30] MatmaRex: I've not seen Windows-compatible concerns raised before. [19:21:31] Reedy: ok :) [19:21:57] James_F: i suppose i could just always `cd maintenance` before running jsduck, that works for me [19:22:12] MatmaRex: Yeah; it's what I've been doing. :-) [19:22:17] i'm not entirely sure why it doesn't "just work" [19:22:22] MatmaRex: And it's what Jenkins does. [19:22:25] it also used to work before ;) [19:22:37] (it = `sh maintenance/mwjsduck-gen`) [19:22:39] MatmaRex: Windows: Putting the "Erk" into "It Should Just Work"™. :-) [19:24:10] (03CR) 10Nikerabbit: [C: 031] mediawiki.Title.js: Correct documentation structure for Title.exist [core] - 10https://gerrit.wikimedia.org/r/125758 (owner: 10Jforrester) [19:24:51] (03PS2) 10Lewis Cawte: Update default interwiki lists. Remove various links that no longer work or seem to point to anywhere it is easy to create an interwiki for. Updated various links to use pretty URL or new structures protocols and some to point where the new equivalent sit [core] - 10https://gerrit.wikimedia.org/r/125778 [19:25:08] (03PS3) 10Lewis Cawte: Update default interwiki lists. Remove various links that no longer work or seem to point to anywhere it is easy to create an interwiki for. Updated various links to use pretty URL or new structures protocols and some to point where the new equivalent sit [core] - 10https://gerrit.wikimedia.org/r/125778 [19:25:24] Lcawte: Argh, \n\n please. ;-) [19:25:42] I added a new line in patch set 3? [19:26:07] Lcawte: You need to add two, not just one. [19:26:15] Lcawte: I can fix it for you if you want. :-) [19:26:31] <^d> I'M GOING TO MERGE BEFORE JAMES_F CAN UPDATE [19:26:34] <^d> JUST TO BUG HIM [19:26:43] (03PS4) 10Jforrester: Update default interwiki lists [core] - 10https://gerrit.wikimedia.org/r/125778 (owner: 10Lewis Cawte) [19:26:44] Ah... yeah, had to do it through Gerrit and I thought gerrit would be smart when I edited in my browser but apparently not. [19:26:46] (03CR) 10BryanDavis: "A few more comments." (033 comments) [wikimedia/wikimania-scholarships] - 10https://gerrit.wikimedia.org/r/125372 (owner: 10Kushal124) [19:26:50] ^d: GLWT. :-P [19:27:01] <^d> I shall merge PS3 then. [19:27:06] <^d> AND IGNORE YOUR AWFUL PS4 [19:27:12] Yeah yeah. [19:27:15] Would of done it via cli but I'm not sure how to do that stuff on Windows... [19:27:32] <^d> JAMES_F [19:27:33] <^d> I'M [19:27:34] <^d> NOT [19:27:35] <^d> SURE [19:27:44] <^d> WHY [19:27:44] <^d> YOU [19:27:44] <^d> [19:27:44] <^d> LIKE [19:27:44] <^d> SO [19:27:46] <^d> MANY [19:27:48] <^d> NEWLINES [19:27:50] <^d> [19:27:52] <^d> [19:27:54] <^d> -Chad [19:28:19] So apparently commit messages don't wrap either? [19:28:24] Lcawte: Indeed. [19:28:26] <^d> Why would they? [19:28:39] ^d: My next step is to make a failing V-1 test for commit message line length > 100 chars. :-) [19:28:41] Because the page is only so long? [19:28:56] <^d> James_F: You need a new spare project. $wasteOfTime++ [19:28:58] <^d> Auto-wrapping is for MS Word. [19:29:09] That has annoyed me several times. (gerrit gui edits not wrapping) [19:29:25] <^d> With any bit of luck we won't use gerrit much longer. [19:29:31] <^d> And then we can complain about line wrapping in $newTool [19:30:06] What's newTool, or haven't we decided yet? [19:30:17] plop [19:30:23] <^d> Lcawte: Hence the variable name. [19:30:26] Lcawte: possibly phabricator, I think [19:30:28] <^d> Probably phabricator. [19:30:39] <^d> Unless someone comes up with some magic solution in the next while. [19:31:20] Can I have the name of whatever we're going to use after that so I can be up to date by the time we switch to the third one? :) [19:31:30] (03PS1) 10SG: mw-ui mixins: More colors, more browser helper mixins [core] - 10https://gerrit.wikimedia.org/r/125781 [19:31:53] <^d> Lcawte: As soon as anyone else knows what it'll be, sure :) [19:32:03] <^d> But if you read above...."Probably phabricator" [19:35:00] ^d: Making people happy makes me happy. :-) [19:36:01] (03PS4) 10SG: mw-ui-button: Revamp the LESS to be simpler, and improve cross-browser support [core] - 10https://gerrit.wikimedia.org/r/123804 [19:36:39] oh yay, I've now made my first commit to MW-Core :) [19:37:32] (03PS1) 10SG: Improve rendering of Living Style Guide sections, examples, and modifiers. [core] - 10https://gerrit.wikimedia.org/r/125783 [19:37:49] Lcawte: I think someone will have to +2 your PS to get the same merged into MW-core [19:38:45] Yep, but for now I can say I've tried to contribute to core :) [19:39:03] (03CR) 10SG: "Split from https://gerrit.wikimedia.org/r/#/c/123804/" [core] - 10https://gerrit.wikimedia.org/r/125781 (owner: 10SG) [19:39:18] (03CR) 10SG: "Split into https://gerrit.wikimedia.org/r/#/c/125781/" [core] - 10https://gerrit.wikimedia.org/r/123804 (owner: 10SG) [19:39:51] Lcawte: of course :) Adding some more reviewers will be a good idea though [19:40:27] (03CR) 10Bartosz Dziewoński: "I like this, and it seems to work well, but it's going to cause problems for wikis which replace the default text with, for example, "Afin" [core] - 10https://gerrit.wikimedia.org/r/118246 (owner: 10Gerrit Patch Uploader) [19:40:43] Who /should/ I add... [19:42:18] You have a bugzilla bug for this ? [19:45:55] Not that I know of... [19:46:07] (03PS1) 10SG: Add mediawiki.ui.enhance.js in mediawiki.ui.js module [core] - 10https://gerrit.wikimedia.org/r/125836 [19:46:27] (03CR) 10GWicke: [C: 031] "Looks ok to me, but I'm not 100% sure if unsetting the height is the cleanest solution." [core] - 10https://gerrit.wikimedia.org/r/116995 (owner: 10Cscott) [19:48:56] (03PS2) 10BryanDavis: wfStripIllegalFilenameChars truncates title [extensions/GWToolset] - 10https://gerrit.wikimedia.org/r/125401 (owner: 10Dan-nl) [19:49:16] (03PS1) 10Umherirrender: Fixed @params documentation [core] - 10https://gerrit.wikimedia.org/r/125852 [19:52:20] (03PS2) 10Umherirrender: Fixed some @params documentation [core] - 10https://gerrit.wikimedia.org/r/125852 [19:53:13] clap clap Lcawte :) [19:53:28] (03CR) 10jenkins-bot: [V: 04-1] Add mediawiki.ui.enhance.js in mediawiki.ui.js module [core] - 10https://gerrit.wikimedia.org/r/125836 (owner: 10SG) [19:53:48] and no, we can't tell you what will come after phabricator, we're not that good at planning :) [19:54:33] AaronSchulz: does https://gerrit.wikimedia.org/r/#/c/116995/4/includes/filerepo/file/File.php look sane to you? [19:55:00] I +1ed that patch, but am not sure if unset is the best solution there [19:55:41] (03CR) 10BryanDavis: [C: 032] wfStripIllegalFilenameChars truncates title [extensions/GWToolset] - 10https://gerrit.wikimedia.org/r/125401 (owner: 10Dan-nl) [19:56:04] (03CR) 10Bartosz Dziewoński: [C: 04-1] "This will not work because mediawiki.ui was so far treated as a style-only module (like skin modules, for example) and added on pages usin" [core] - 10https://gerrit.wikimedia.org/r/125836 (owner: 10SG) [19:57:32] (03Merged) 10jenkins-bot: wfStripIllegalFilenameChars truncates title [extensions/GWToolset] - 10https://gerrit.wikimedia.org/r/125401 (owner: 10Dan-nl) [20:04:20] (03CR) 10Aaron Schulz: [C: 032] Ignore height as well as width for framed images. [core] - 10https://gerrit.wikimedia.org/r/116995 (owner: 10Cscott) [20:07:19] (03CR) 10Bartosz Dziewoński: "Yes." [core] - 10https://gerrit.wikimedia.org/r/43166 (owner: 10VitaliyFilippov) [20:08:00] (03Merged) 10jenkins-bot: Ignore height as well as width for framed images. [core] - 10https://gerrit.wikimedia.org/r/116995 (owner: 10Cscott) [20:16:09] (03PS2) 10Gerrit Patch Uploader: Remove deprecated function mw.util.toggleToc [core] - 10https://gerrit.wikimedia.org/r/110680 [20:16:11] (03CR) 10Gerrit Patch Uploader: "This commit was uploaded using the Gerrit Patch Uploader [1]." [core] - 10https://gerrit.wikimedia.org/r/110680 (owner: 10Gerrit Patch Uploader) [20:16:55] (03CR) 10EBernhardson: Fix a few bugs where Flow was not working on pristine pages. (031 comment) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/123812 (owner: 10Werdna) [20:17:05] (03CR) 10SG: "So, what's the correct solution? To change the instances of addModuleStyles to addModules for mediawiki.ui?" [core] - 10https://gerrit.wikimedia.org/r/125836 (owner: 10SG) [20:17:39] (03PS1) 10Bsitu: remove reference to getIdColumn() [extensions/Flow] - 10https://gerrit.wikimedia.org/r/125866 [20:21:46] (03CR) 10EBernhardson: [C: 032] remove reference to getIdColumn() [extensions/Flow] - 10https://gerrit.wikimedia.org/r/125866 (owner: 10Bsitu) [20:23:49] (03PS1) 10Chad: delayedBind isn't used anymore (nor does it exist) [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/125867 [20:24:38] (03CR) 10Bartosz Dziewoński: [C: 032] delayedBind isn't used anymore (nor does it exist) [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/125867 (owner: 10Chad) [20:26:10] (03CR) 10Fomafix: "There is no deterioration on https://fr.wikipedia.org/w/index.php?title=Hoedillus_sexpunctatus&action=edit&uselang=fr compared to now. The" [core] - 10https://gerrit.wikimedia.org/r/118246 (owner: 10Gerrit Patch Uploader) [20:26:26] (03Merged) 10jenkins-bot: delayedBind isn't used anymore (nor does it exist) [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/125867 (owner: 10Chad) [20:26:56] (03Abandoned) 10Mwalker: Updating DI for WorldPay currencies [core] (fundraising/REL1_22) - 10https://gerrit.wikimedia.org/r/125779 (owner: 10Mwalker) [20:27:31] AaronSchulz, thanks re https://gerrit.wikimedia.org/r/116995 [20:27:32] (03Merged) 10jenkins-bot: remove reference to getIdColumn() [extensions/Flow] - 10https://gerrit.wikimedia.org/r/125866 (owner: 10Bsitu) [20:27:38] (03PS1) 10Mwalker: Updating DonationInterface for WOrldPay currencies [core] (fundraising/REL1_22) - 10https://gerrit.wikimedia.org/r/125868 [20:27:51] (03CR) 10Nemo bis: "I think most of the misssing ones are the tog-* from includes/Preferences.php?" [core] - 10https://gerrit.wikimedia.org/r/125050 (owner: 10Jforrester) [20:27:55] (03CR) 10Bartosz Dziewoński: "Oh, huh, I didn't notice that you added that to this patch. Hmm." [core] - 10https://gerrit.wikimedia.org/r/118246 (owner: 10Gerrit Patch Uploader) [20:28:48] (03CR) 10jenkins-bot: [V: 04-1] Updating DonationInterface for WOrldPay currencies [core] (fundraising/REL1_22) - 10https://gerrit.wikimedia.org/r/125868 (owner: 10Mwalker) [20:31:18] MatmaRex: https://gerrit.wikimedia.org/r/#/c/117672/ [20:31:18] Nemo_bis: Umm. You know that the missing ones are shown in the log for NPM? [20:31:20] Nemo_bis: https://integration.wikimedia.org/ci/job/mediawiki-core-npm/457/console [20:31:53] (03CR) 10Bartosz Dziewoński: "No, to add this as a separate module and explicitly include it in places where you want to use it." [core] - 10https://gerrit.wikimedia.org/r/125836 (owner: 10SG) [20:32:16] (03PS9) 10Jforrester: Use new banana checker as a linter to avoid lacking qqq messages [core] - 10https://gerrit.wikimedia.org/r/125050 [20:32:47] ori: i can merge it now, but don't blame me when everything breaks [20:32:51] (03PS1) 10Mwalker: Updating DonationInterface for WOrldPay currencies [core] (fundraising/REL1_22) - 10https://gerrit.wikimedia.org/r/125869 [20:32:51] i'd wait until 27th [20:34:03] (03Abandoned) 10Mwalker: Updating DonationInterface for WOrldPay currencies [core] (fundraising/REL1_22) - 10https://gerrit.wikimedia.org/r/125868 (owner: 10Mwalker) [20:34:11] MatmaRex: why would anything break? i'm not going to cherry-pick it into wmf18 [20:34:19] (03CR) 10SG: "D'oh. I've been working on Flow long enough that it didn't even look weird to me. I'll rectify those." [core] - 10https://gerrit.wikimedia.org/r/125836 (owner: 10SG) [20:35:01] MatmaRex: the rollout of a new branch updates file mtimes & thus rl modules [20:35:11] MatmaRex: so i don't see how anything would break [20:35:38] (03CR) 10Nemo bis: "Ahem, I originally only wanted to keep the email address preference in "personal" section but I ended up making more extensive changes. I " [core] - 10https://gerrit.wikimedia.org/r/125762 (owner: 1001tonythomas) [20:35:45] ori: if we merge it now, it'll go into production on 22 april, while the change this depends on left production on 27 march - we should have 30 days between the two (or so i've been told) [20:36:11] (03PS2) 10Nemo bis: Create "Following changes" (notifications) tab from "watchlist" [core] - 10https://gerrit.wikimedia.org/r/125762 (owner: 1001tonythomas) [20:36:26] (03PS2) 10SG: Add mediawiki.ui.enhance.js in mediawiki.ui.js module [core] - 10https://gerrit.wikimedia.org/r/125836 [20:36:44] (03CR) 10Mwalker: [C: 032 V: 032] Updating DonationInterface for WOrldPay currencies [core] (fundraising/REL1_22) - 10https://gerrit.wikimedia.org/r/125869 (owner: 10Mwalker) [20:37:21] MatmaRex: it's the text cache that is 30 days, not bits [20:38:34] ori: ugh, then i have no idea why we waiting with this patch for half a month instead of five minutes if it doesn't depend on html cache expiring [20:39:02] MatmaRex: yeah. It was just confusion on me / Krinkle's part [20:39:28] heh. okay [20:39:35] needs backport to 1.23 too, i suppose? [20:39:35] (03CR) 10EBernhardson: [C: 04-1] "This one needs a fun rebase :) Another patch we just merged, https://gerrit.wikimedia.org/r/#/c/117099/, changed some parts of the storag" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/120734 (owner: 10Werdna) [20:39:41] hmm [20:40:13] (03CR) 10Bartosz Dziewoński: "Turns out that this doesn't actually depends on the HTML caches expiring and should have been merged a month ago." [core] - 10https://gerrit.wikimedia.org/r/117672 (owner: 10Ori.livneh) [20:40:21] MatmaRex: hang on [20:40:28] okay [20:40:44] (03CR) 10jenkins-bot: [V: 04-1] Use new banana checker as a linter to avoid lacking qqq messages [core] - 10https://gerrit.wikimedia.org/r/125050 (owner: 10Jforrester) [20:41:00] MatmaRex: yeah, ok. that's right. [20:41:14] (03CR) 10EBernhardson: UUID revamp (031 comment) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/123691 (owner: 10Matthias Mullie) [20:41:17] (03CR) 10Bartosz Dziewoński: [C: 032] ResourceLoader::makeLoaderImplementScript: Bind args as '$' and 'jQuery' [core] - 10https://gerrit.wikimedia.org/r/117672 (owner: 10Ori.livneh) [20:41:25] (03PS1) 10Bartosz Dziewoński: ResourceLoader::makeLoaderImplementScript: Bind args as '$' and 'jQuery' [core] (REL1_23) - 10https://gerrit.wikimedia.org/r/125872 [20:41:29] thanks [20:41:34] (03CR) 10Bartosz Dziewoński: [C: 032] ResourceLoader::makeLoaderImplementScript: Bind args as '$' and 'jQuery' [core] (REL1_23) - 10https://gerrit.wikimedia.org/r/125872 (owner: 10Bartosz Dziewoński) [20:41:38] my pleasure [20:41:46] (03PS3) 10SG: Add mediawiki.ui.enhance.js in mediawiki.ui.js module [core] - 10https://gerrit.wikimedia.org/r/125836 [20:42:50] (03PS4) 10SG: Add mediawiki.ui.enhance.js in mediawiki.ui.js module [core] - 10https://gerrit.wikimedia.org/r/125836 [20:44:03] (03CR) 10SG: "Should be better now. I'm not adding any actual usage of this yet; that would come in a separate patch. This is waiting for a couple of ot" [core] - 10https://gerrit.wikimedia.org/r/125836 (owner: 10SG) [20:45:16] (03CR) 10Bartosz Dziewoński: [C: 031] Remove deprecated function mw.util.toggleToc [core] - 10https://gerrit.wikimedia.org/r/110680 (owner: 10Gerrit Patch Uploader) [20:46:03] (03CR) 10jenkins-bot: [V: 04-1] Add mediawiki.ui.enhance.js in mediawiki.ui.js module [core] - 10https://gerrit.wikimedia.org/r/125836 (owner: 10SG) [20:46:54] (03PS1) 10Jforrester: Cliinstaller.php docs: Note config-install-extensions is used too [core] - 10https://gerrit.wikimedia.org/r/125873 [20:48:40] (03CR) 10Chad: [C: 032] Cliinstaller.php docs: Note config-install-extensions is used too [core] - 10https://gerrit.wikimedia.org/r/125873 (owner: 10Jforrester) [20:50:33] (03CR) 10Jforrester: "@Nemo:" [core] - 10https://gerrit.wikimedia.org/r/125050 (owner: 10Jforrester) [20:53:50] (03Merged) 10jenkins-bot: ResourceLoader::makeLoaderImplementScript: Bind args as '$' and 'jQuery' [core] - 10https://gerrit.wikimedia.org/r/117672 (owner: 10Ori.livneh) [20:55:42] (03Merged) 10jenkins-bot: ResourceLoader::makeLoaderImplementScript: Bind args as '$' and 'jQuery' [core] (REL1_23) - 10https://gerrit.wikimedia.org/r/125872 (owner: 10Bartosz Dziewoński) [20:55:47] (03PS1) 10Cscott: Update release notes to describe user-visible change to framed images. [core] - 10https://gerrit.wikimedia.org/r/125876 [20:56:54] (03CR) 10jenkins-bot: [V: 04-1] Add mediawiki.ui.enhance.js in mediawiki.ui.js module [core] - 10https://gerrit.wikimedia.org/r/125836 (owner: 10SG) [21:00:05] (03PS1) 10Sirtomash: Test commit -01 - branch creation. [extensions/ApiSandbox] - 10https://gerrit.wikimedia.org/r/125878 [21:00:22] (03Merged) 10jenkins-bot: Cliinstaller.php docs: Note config-install-extensions is used too [core] - 10https://gerrit.wikimedia.org/r/125873 (owner: 10Jforrester) [21:07:20] (03CR) 10EBernhardson: [C: 04-1] Add Sorting to topic list based on last updated timestamp (032 comments) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/124644 (owner: 10Bsitu) [21:09:13] (03PS3) 10Tim Starling: Prevent GC during phpunit shutdown [core] - 10https://gerrit.wikimedia.org/r/123146 (owner: 10CSteipp) [21:09:21] (03CR) 10Tim Starling: [C: 032] Prevent GC during phpunit shutdown [core] - 10https://gerrit.wikimedia.org/r/123146 (owner: 10CSteipp) [21:10:35] (03CR) 10Sirtomash: [C: 031] "SUper good code" [extensions/ApiSandbox] - 10https://gerrit.wikimedia.org/r/125878 (owner: 10Sirtomash) [21:11:45] (03CR) 10EBernhardson: Add rev_type to lastRevCache key (031 comment) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/123144 (owner: 10Bsitu) [21:12:25] (03CR) 10Aaron Schulz: [C: 032] Update release notes to describe user-visible change to framed images. [core] - 10https://gerrit.wikimedia.org/r/125876 (owner: 10Cscott) [21:14:44] (03Merged) 10jenkins-bot: Prevent GC during phpunit shutdown [core] - 10https://gerrit.wikimedia.org/r/123146 (owner: 10CSteipp) [21:15:11] (03PS4) 10EBernhardson: Add rev_type to lastRevCache key [extensions/Flow] - 10https://gerrit.wikimedia.org/r/123144 (owner: 10Bsitu) [21:15:25] (03CR) 10EBernhardson: [C: 032] Add rev_type to lastRevCache key [extensions/Flow] - 10https://gerrit.wikimedia.org/r/123144 (owner: 10Bsitu) [21:15:49] (03CR) 10EBernhardson: [C: 032] Use of new OutputPage() is deprecated [extensions/Flow] - 10https://gerrit.wikimedia.org/r/125345 (owner: 10Bsitu) [21:16:22] (03Merged) 10jenkins-bot: Update release notes to describe user-visible change to framed images. [core] - 10https://gerrit.wikimedia.org/r/125876 (owner: 10Cscott) [21:16:24] (03CR) 10EBernhardson: [C: 032] Add missing ContributionsRow to autoloader [extensions/Flow] - 10https://gerrit.wikimedia.org/r/125720 (owner: 10Matthias Mullie) [21:17:39] (03Merged) 10jenkins-bot: Add rev_type to lastRevCache key [extensions/Flow] - 10https://gerrit.wikimedia.org/r/123144 (owner: 10Bsitu) [21:17:42] (03Merged) 10jenkins-bot: Use of new OutputPage() is deprecated [extensions/Flow] - 10https://gerrit.wikimedia.org/r/125345 (owner: 10Bsitu) [21:18:44] (03CR) 10Bartosz Dziewoński: "This patch really scares me. :)" (032 comments) [core] - 10https://gerrit.wikimedia.org/r/118246 (owner: 10Gerrit Patch Uploader) [21:19:11] (03PS2) 10EBernhardson: API: Set 'missing': '', instead of 'missing': 'missing' [extensions/Flow] - 10https://gerrit.wikimedia.org/r/123178 (owner: 10Legoktm) [21:19:39] (03CR) 10EBernhardson: [C: 032] "PS2: reparented against master" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/123178 (owner: 10Legoktm) [21:21:01] (03Merged) 10jenkins-bot: Add missing ContributionsRow to autoloader [extensions/Flow] - 10https://gerrit.wikimedia.org/r/125720 (owner: 10Matthias Mullie) [21:21:31] (03Merged) 10jenkins-bot: API: Set 'missing': '', instead of 'missing': 'missing' [extensions/Flow] - 10https://gerrit.wikimedia.org/r/123178 (owner: 10Legoktm) [21:22:16] (03PS29) 10EBernhardson: Add topic summary revision type [extensions/Flow] - 10https://gerrit.wikimedia.org/r/117357 (owner: 10Bsitu) [21:22:30] (03CR) 10EBernhardson: [C: 032] Add topic summary revision type [extensions/Flow] - 10https://gerrit.wikimedia.org/r/117357 (owner: 10Bsitu) [21:22:43] (03PS22) 10EBernhardson: Closing & reopening topic [extensions/Flow] - 10https://gerrit.wikimedia.org/r/118399 (owner: 10Bsitu) [21:23:30] (03PS2) 10Sirtomash: Test commit -01 - branch creation. [extensions/ApiSandbox] - 10https://gerrit.wikimedia.org/r/125878 [21:23:42] (03Merged) 10jenkins-bot: Add topic summary revision type [extensions/Flow] - 10https://gerrit.wikimedia.org/r/117357 (owner: 10Bsitu) [21:25:02] (03CR) 10Sirtomash: [C: 031] Test commit -01 - branch creation. [extensions/ApiSandbox] - 10https://gerrit.wikimedia.org/r/125878 (owner: 10Sirtomash) [21:26:57] (03PS1) 10EBernhardson: 'summary' field is required for ApiFlowEditTopicSummary [extensions/Flow] - 10https://gerrit.wikimedia.org/r/125881 [21:27:21] (03CR) 10Bsitu: [C: 032] 'summary' field is required for ApiFlowEditTopicSummary [extensions/Flow] - 10https://gerrit.wikimedia.org/r/125881 (owner: 10EBernhardson) [21:27:36] (03Merged) 10jenkins-bot: 'summary' field is required for ApiFlowEditTopicSummary [extensions/Flow] - 10https://gerrit.wikimedia.org/r/125881 (owner: 10EBernhardson) [21:41:17] (03PS20) 10Bsitu: Drop table: flow_header_revision [extensions/Flow] - 10https://gerrit.wikimedia.org/r/117115 [21:41:17] x§ [21:41:19] Erm, oops. [21:48:57] (03PS21) 10EBernhardson: Closing & Summarizing topic frontend changes [extensions/Flow] - 10https://gerrit.wikimedia.org/r/119640 (owner: 10Bsitu) [21:52:39] (03CR) 10Edokter: "Are you sure you want to store default CSS in Resources.php instead of variables.less?" [core] - 10https://gerrit.wikimedia.org/r/125760 (owner: 10Jdlrobson) [21:56:19] (03CR) 10EBernhardson: [C: 04-1] "The flow-topic-summary div gets output for everything, probably ok but it has 10px of padding that throws everything else off" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/119640 (owner: 10Bsitu) [22:00:18] (03PS5) 10SG: Add mediawiki.ui.enhance.js in mediawiki.ui.js module [core] - 10https://gerrit.wikimedia.org/r/125836 [22:02:14] (03CR) 10EBernhardson: "The patches to rename the various history actions to 'history' is complete, this should be able to go through now." [extensions/Flow] - 10https://gerrit.wikimedia.org/r/111924 (owner: 10Legoktm) [22:03:09] (03PS31) 10Spage: Extract wiki and external links, file and template usages from text. [extensions/Flow] - 10https://gerrit.wikimedia.org/r/110090 (owner: 10Werdna) [22:03:16] (03CR) 10jenkins-bot: [V: 04-1] Extract wiki and external links, file and template usages from text. [extensions/Flow] - 10https://gerrit.wikimedia.org/r/110090 (owner: 10Werdna) [22:04:20] (03PS32) 10Spage: Extract wiki and external links, file and template usages from text. [extensions/Flow] - 10https://gerrit.wikimedia.org/r/110090 (owner: 10Werdna) [22:04:23] (03CR) 10jenkins-bot: [V: 04-1] Extract wiki and external links, file and template usages from text. [extensions/Flow] - 10https://gerrit.wikimedia.org/r/110090 (owner: 10Werdna) [22:05:12] (03CR) 10EBernhardson: "ping, can we send this through?" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/123114 (owner: 10EBernhardson) [22:06:10] (03CR) 10jenkins-bot: [V: 04-1] Add mediawiki.ui.enhance.js in mediawiki.ui.js module [core] - 10https://gerrit.wikimedia.org/r/125836 (owner: 10SG) [22:06:13] (03CR) 10Jdlrobson: "I'm not sure - but I'm open to whether that is a good thing or a bad thing - I think there is something nice about keeping this in a modul" [core] - 10https://gerrit.wikimedia.org/r/125760 (owner: 10Jdlrobson) [22:06:59] (03PS33) 10Spage: Extract wiki and external links, file and template usages from text. [extensions/Flow] - 10https://gerrit.wikimedia.org/r/110090 (owner: 10Werdna) [22:07:05] (03CR) 10jenkins-bot: [V: 04-1] Extract wiki and external links, file and template usages from text. [extensions/Flow] - 10https://gerrit.wikimedia.org/r/110090 (owner: 10Werdna) [22:07:14] (03CR) 10EBernhardson: API: Remove 'flowaction' parameter from list=flow (031 comment) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/123174 (owner: 10Legoktm) [22:08:00] (03PS6) 10SG: Add mediawiki.ui.enhance.js in mediawiki.ui.js module [core] - 10https://gerrit.wikimedia.org/r/125836 [22:09:46] (03CR) 10EBernhardson: "note that the entire PostActionMenu will probably be deleted with the new frontend rewrite" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/121707 (owner: 10Bsitu) [22:18:57] (03PS4) 10EBernhardson: Fix a few bugs where Flow was not working on pristine pages. [extensions/Flow] - 10https://gerrit.wikimedia.org/r/123812 (owner: 10Werdna) [22:19:26] (03CR) 10EBernhardson: [C: 032] "PS4: Adjusted BoardHistoryQuery to still throw an exception if nothing is found" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/123812 (owner: 10Werdna) [22:19:41] (03Merged) 10jenkins-bot: Fix a few bugs where Flow was not working on pristine pages. [extensions/Flow] - 10https://gerrit.wikimedia.org/r/123812 (owner: 10Werdna) [22:20:39] (03CR) 10EBernhardson: "Everything is in place, this patch is now ready to be merged and should go out with this thursday's deploy train." [extensions/Flow] - 10https://gerrit.wikimedia.org/r/115576 (owner: 10EBernhardson) [22:24:00] (03CR) 10Chad: [C: 031] "My inclination is no, only do it on actual rebases, but what do I know? :)" [All-Projects] (refs/meta/config) - 10https://gerrit.wikimedia.org/r/124891 (owner: 10Hashar) [22:24:50] (03CR) 10EBernhardson: "I'm indecisive, tbh i'm thinking proxy objects are the wrong direction, but could be convinced." [extensions/Flow] - 10https://gerrit.wikimedia.org/r/125228 (owner: 10Matthias Mullie) [22:30:44] (03CR) 10EBernhardson: [C: 031] "looks good to me, parent patch will hopefully be merged soon." [extensions/Flow] - 10https://gerrit.wikimedia.org/r/121306 (owner: 10Wctaiwan) [22:37:01] (03CR) 10EBernhardson: "filed request for table creation in production at https://bugzilla.wikimedia.org/show_bug.cgi?id=63917" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/110090 (owner: 10Werdna) [22:37:36] (03CR) 10TTO: [C: 04-1] "Mostly redundant to I6c1eb3aba6cc55d1313f6d249510a03e4b8e6f13" [core] - 10https://gerrit.wikimedia.org/r/125778 (owner: 10Lewis Cawte) [22:39:04] (03CR) 10Spage: [C: 04-1] "After fixing the function name, it's working for me locally in conjunction with gerrit 115860 in core, despite the two warnings from Refer" (033 comments) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/110090 (owner: 10Werdna) [22:45:00] (03CR) 10Lewis Cawte: "Wasn't aware that patchset existed. I started this back early last summer and found the half finished diff today, saw there had been no ch" [core] - 10https://gerrit.wikimedia.org/r/125778 (owner: 10Lewis Cawte) [22:49:24] (03PS1) 10Aaron Schulz: More Profiler class refactoring [core] - 10https://gerrit.wikimedia.org/r/125895 [22:50:27] ^d: https://gerrit.wikimedia.org/r/#/c/125528/ & https://gerrit.wikimedia.org/r/#/c/125529/ [22:52:05] (03CR) 10Spage: [C: 031] "Works for me in conjunction with the change to Flow gerrit 110090, Special:WhatLinksHere displays a link to the specific post on the Flow " [core] - 10https://gerrit.wikimedia.org/r/115860 (owner: 10Werdna) [22:54:34] (03CR) 10Chad: [C: 032] Use standard "GetLocalFileCopy" pool name [extensions/PagedTiffHandler] - 10https://gerrit.wikimedia.org/r/125528 (owner: 10Aaron Schulz) [22:54:40] (03CR) 10Chad: [C: 032] Use standard "GetLocalFileCopy" pool name [extensions/PdfHandler] - 10https://gerrit.wikimedia.org/r/125529 (owner: 10Aaron Schulz) [22:54:43] (03Merged) 10jenkins-bot: Use standard "GetLocalFileCopy" pool name [extensions/PdfHandler] - 10https://gerrit.wikimedia.org/r/125529 (owner: 10Aaron Schulz) [22:54:45] (03Merged) 10jenkins-bot: Use standard "GetLocalFileCopy" pool name [extensions/PagedTiffHandler] - 10https://gerrit.wikimedia.org/r/125528 (owner: 10Aaron Schulz) [22:57:47] (03PS2) 10Aaron Schulz: More Profiler class refactoring [core] - 10https://gerrit.wikimedia.org/r/125895 [23:08:03] (03PS3) 10Ori.livneh: Revert body font stack to be just sans-serif [core] (wmf/1.23wmf22) - 10https://gerrit.wikimedia.org/r/125447 (owner: 10Bartosz Dziewoński) [23:08:25] (03CR) 10Ori.livneh: [C: 032] Revert body font stack to be just sans-serif [core] (wmf/1.23wmf22) - 10https://gerrit.wikimedia.org/r/125447 (owner: 10Bartosz Dziewoński) [23:13:02] (03CR) 10jenkins-bot: [V: 04-1] Revert body font stack to be just sans-serif [core] (wmf/1.23wmf22) - 10https://gerrit.wikimedia.org/r/125447 (owner: 10Bartosz Dziewoński) [23:13:29] (03Merged) 10jenkins-bot: Revert body font stack to be just sans-serif [core] (wmf/1.23wmf22) - 10https://gerrit.wikimedia.org/r/125447 (owner: 10Bartosz Dziewoński) [23:15:44] (03CR) 10MaxSem: [C: 04-1] "Please add these to mediawiki-config instead because they're site-specific (yeah, there are already some rules like this but they should b" [extensions/TextExtracts] - 10https://gerrit.wikimedia.org/r/125689 (owner: 10Prtksxna) [23:17:24] (03PS3) 10EBernhardson: Initial import of handlebars templates [extensions/Flow] (frontend-rewrite) - 10https://gerrit.wikimedia.org/r/125357 [23:17:55] (03PS1) 10EBernhardson: Make various checks optional based on environment vars [extensions/Flow] - 10https://gerrit.wikimedia.org/r/125901 [23:18:27] (03CR) 10jenkins-bot: [V: 04-1] Initial import of handlebars templates [extensions/Flow] (frontend-rewrite) - 10https://gerrit.wikimedia.org/r/125357 (owner: 10EBernhardson) [23:18:43] (03PS2) 10EBernhardson: Make various checks optional based on environment vars [extensions/Flow] - 10https://gerrit.wikimedia.org/r/125901 [23:21:56] (03PS3) 10EBernhardson: First stab at new template rendering in php [extensions/Flow] (frontend-rewrite) - 10https://gerrit.wikimedia.org/r/125358 [23:23:38] (03CR) 10jenkins-bot: [V: 04-1] First stab at new template rendering in php [extensions/Flow] (frontend-rewrite) - 10https://gerrit.wikimedia.org/r/125358 (owner: 10EBernhardson) [23:25:05] (03PS4) 10EBernhardson: First stab at new template rendering in php [extensions/Flow] (frontend-rewrite) - 10https://gerrit.wikimedia.org/r/125358 [23:25:08] (03PS4) 10EBernhardson: Initial import of handlebars templates [extensions/Flow] (frontend-rewrite) - 10https://gerrit.wikimedia.org/r/125357 [23:26:02] (03CR) 10jenkins-bot: [V: 04-1] Initial import of handlebars templates [extensions/Flow] (frontend-rewrite) - 10https://gerrit.wikimedia.org/r/125357 (owner: 10EBernhardson) [23:26:13] (03PS1) 10Jdlrobson: Separate style modules from JS modules [extensions/Flow] - 10https://gerrit.wikimedia.org/r/125907 [23:26:16] (03PS1) 10Jdlrobson: Get Flow non-JavaScript mode into mobile [extensions/Flow] - 10https://gerrit.wikimedia.org/r/125908 [23:27:19] (03PS1) 10Ori.livneh: Update VisualEditor for cherry-picks from master [core] (wmf/1.23wmf22) - 10https://gerrit.wikimedia.org/r/125910 [23:27:54] (03CR) 10Ori.livneh: [C: 032] Update VisualEditor for cherry-picks from master [core] (wmf/1.23wmf22) - 10https://gerrit.wikimedia.org/r/125910 (owner: 10Ori.livneh) [23:29:42] (03CR) 10SG: [C: 031] Separate style modules from JS modules [extensions/Flow] - 10https://gerrit.wikimedia.org/r/125907 (owner: 10Jdlrobson) [23:31:54] (03CR) 10SG: "I don't know about completely hiding .flow-tipsy. It is used (in a really weird way) in the current version of Flow to show the drop downs" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/125908 (owner: 10Jdlrobson) [23:31:57] (03PS1) 10EBernhardson: Prevent PHPUnit from stringifying UUID instances [extensions/Flow] - 10https://gerrit.wikimedia.org/r/125912 [23:32:05] (03CR) 10jenkins-bot: [V: 04-1] Prevent PHPUnit from stringifying UUID instances [extensions/Flow] - 10https://gerrit.wikimedia.org/r/125912 (owner: 10EBernhardson) [23:32:50] (03Merged) 10jenkins-bot: Update VisualEditor for cherry-picks from master [core] (wmf/1.23wmf22) - 10https://gerrit.wikimedia.org/r/125910 (owner: 10Ori.livneh) [23:33:27] (03CR) 10Jdlrobson: "Tipsy isn't currently available in mobile mode (we load a subset of all JavaScript which excludes this)" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/125908 (owner: 10Jdlrobson) [23:36:05] (03CR) 10SG: [C: 032] Get Flow non-JavaScript mode into mobile [extensions/Flow] - 10https://gerrit.wikimedia.org/r/125908 (owner: 10Jdlrobson) [23:38:40] (03PS2) 10EBernhardson: Prevent PHPUnit from stringifying UUID instances [extensions/Flow] - 10https://gerrit.wikimedia.org/r/125912 [23:39:22] (03PS1) 10Dan-nl: UploadWizard is missing a SpecialPageAlias for Campaigns [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/125913 [23:45:47] https://gerrit.wikimedia.org/r/125907 < can i get a +2 can i get a +2 what what ebernhardson