[00:28:01] (03CR) 10Parent5446: [C: 032] "Might as well just upgrade my +1." [core] - 10https://gerrit.wikimedia.org/r/65446 (owner: 10Waldir) [00:29:56] (03CR) 10Parent5446: [C: 031] "Haven't tested" [core] - 10https://gerrit.wikimedia.org/r/122664 (owner: 10Adamw) [00:31:16] (03Merged) 10jenkins-bot: Rename Skin::getUsableSkins() to Skin::getAllowedSkins() [core] - 10https://gerrit.wikimedia.org/r/65446 (owner: 10Waldir) [00:58:27] (03CR) 10Aaron Schulz: [C: 032] Fixing bug #63738: Debug msg not showing correctly [core] - 10https://gerrit.wikimedia.org/r/125566 (owner: 10Taueres) [01:01:35] (03Merged) 10jenkins-bot: Fixing bug #63738: Debug msg not showing correctly [core] - 10https://gerrit.wikimedia.org/r/125566 (owner: 10Taueres) [01:47:27] (03CR) 10Legoktm: Rename Skin::getUsableSkins() to Skin::getAllowedSkins() (031 comment) [core] - 10https://gerrit.wikimedia.org/r/65446 (owner: 10Waldir) [01:49:12] (03PS1) 10Legoktm: Fix deprecation notice for Skin::getUsableSkins to say 1.23 [core] - 10https://gerrit.wikimedia.org/r/125576 [02:25:31] (03PS1) 10Prtksxna: Position hovercard according to mouse position [extensions/Popups] - 10https://gerrit.wikimedia.org/r/125577 [02:36:42] (03PS1) 10Prtksxna: Fix redirect for `info-link` [extensions/Popups] - 10https://gerrit.wikimedia.org/r/125578 [02:37:40] (03CR) 10Quiddity: [C: 031] Fix redirect for `info-link` [extensions/Popups] - 10https://gerrit.wikimedia.org/r/125578 (owner: 10Prtksxna) [06:55:39] (03CR) 10Yuvipanda: [C: 032] Fix redirect for `info-link` [extensions/Popups] - 10https://gerrit.wikimedia.org/r/125578 (owner: 10Prtksxna) [06:55:42] (03Merged) 10jenkins-bot: Fix redirect for `info-link` [extensions/Popups] - 10https://gerrit.wikimedia.org/r/125578 (owner: 10Prtksxna) [08:22:04] (03Abandoned) 10TheDJ: Switch a few test cases back into es5 mode [core] - 10https://gerrit.wikimedia.org/r/125397 (owner: 10TheDJ) [08:40:20] (03CR) 10TheDJ: [C: 031] Add jquery.accessKeyLabel javascript module [core] - 10https://gerrit.wikimedia.org/r/125426 (owner: 10Umherirrender) [08:48:10] (03CR) 10KartikMistry: [C: 031] "LGTM." [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/125386 (owner: 10Zfilipin) [08:52:46] (03CR) 10TheDJ: [C: 04-1] Use document.createElementNS for svg image (033 comments) [extensions/Popups] - 10https://gerrit.wikimedia.org/r/122352 (owner: 10Prtksxna) [09:01:11] (03CR) 10TheDJ: "The label pushes the checkboxes aside, for me in Safari 7, due to larger height. Is that intentional ?" [core] - 10https://gerrit.wikimedia.org/r/118246 (owner: 10Gerrit Patch Uploader) [09:05:27] (03CR) 10TheDJ: [C: 032] mw.hook: Use hasOwnProperty [core] - 10https://gerrit.wikimedia.org/r/123856 (owner: 10Gerrit Patch Uploader) [09:08:30] (03Merged) 10jenkins-bot: mw.hook: Use hasOwnProperty [core] - 10https://gerrit.wikimedia.org/r/123856 (owner: 10Gerrit Patch Uploader) [09:09:57] (03PS6) 10TheDJ: All toggles for makeCollapsible should use the pointer cursor. [core] - 10https://gerrit.wikimedia.org/r/74391 [09:11:09] (03Abandoned) 10TheDJ: Accessibility: Don't remove outlines from focusable elems [core] - 10https://gerrit.wikimedia.org/r/119998 (owner: 10TheDJ) [09:33:12] (03PS5) 10TheDJ: Add a status bar to the CodeEditor [extensions/CodeEditor] - 10https://gerrit.wikimedia.org/r/122601 [09:33:56] (03Abandoned) 10TheDJ: CodeEditor: Add a status bar with line and columncount [extensions/CodeEditor] - 10https://gerrit.wikimedia.org/r/118989 (owner: 10TheDJ) [09:42:47] (03CR) 10Umherirrender: Rename Skin::getUsableSkins() to Skin::getAllowedSkins() (031 comment) [core] - 10https://gerrit.wikimedia.org/r/65446 (owner: 10Waldir) [10:57:46] (03PS1) 10Mwjames: Apparently no one is looking at [0] so I'll have to do it on my own. [skins/chameleon] (refs/meta/config) - 10https://gerrit.wikimedia.org/r/125581 [10:59:46] (03CR) 10Mwjames: "How is to review this now? I'm starting to dislike the WMF workflow here ..." [skins/chameleon] (refs/meta/config) - 10https://gerrit.wikimedia.org/r/125581 (owner: 10Mwjames) [11:00:02] (03Abandoned) 10Mwjames: Apparently no one is looking at [0] so I'll have to do it on my own. [skins/chameleon] (refs/meta/config) - 10https://gerrit.wikimedia.org/r/125581 (owner: 10Mwjames) [11:00:31] (03CR) 10Mwjames: "What a ...." [skins/chameleon] (refs/meta/config) - 10https://gerrit.wikimedia.org/r/125581 (owner: 10Mwjames) [11:10:09] (03CR) 10TheDJ: [C: 04-1] "This creates a title attribute where there previously might not have been one." [core] - 10https://gerrit.wikimedia.org/r/125426 (owner: 10Umherirrender) [11:21:13] (03PS2) 10TheDJ: Prevent style jumping in WikiEditor [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/124734 [11:37:32] (03PS6) 10Bartosz Dziewoński: Check normalization rules of usernames during signup via AJAX [core] - 10https://gerrit.wikimedia.org/r/117438 [11:38:37] (03CR) 10jenkins-bot: [V: 04-1] Check normalization rules of usernames during signup via AJAX [core] - 10https://gerrit.wikimedia.org/r/117438 (owner: 10Bartosz Dziewoński) [11:40:43] (03CR) 10Bartosz Dziewoński: "Added basic client-side checks using mediawiki.Title." [core] - 10https://gerrit.wikimedia.org/r/117438 (owner: 10Bartosz Dziewoński) [11:47:07] (03PS7) 10Bartosz Dziewoński: Check normalization rules of usernames during signup via AJAX [core] - 10https://gerrit.wikimedia.org/r/117438 [13:13:06] (03PS1) 10Shirayuki: i18n tweaks [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/125582 [14:02:31] (03PS2) 10Parent5446: Fix deprecation notice for Skin::getUsableSkins to say 1.23 [core] - 10https://gerrit.wikimedia.org/r/125576 (owner: 10Legoktm) [14:02:34] (03CR) 10Parent5446: [C: 032] Fix deprecation notice for Skin::getUsableSkins to say 1.23 [core] - 10https://gerrit.wikimedia.org/r/125576 (owner: 10Legoktm) [14:06:45] (03Merged) 10jenkins-bot: Fix deprecation notice for Skin::getUsableSkins to say 1.23 [core] - 10https://gerrit.wikimedia.org/r/125576 (owner: 10Legoktm) [15:28:58] (03PS3) 10Reedy: Add SelfLinkBeginHook [core] - 10https://gerrit.wikimedia.org/r/124149 (owner: 10Cicalese) [15:29:52] (03CR) 10Reedy: [C: 04-1] "This hook should be documented in docs/hooks.txt" [core] - 10https://gerrit.wikimedia.org/r/124149 (owner: 10Cicalese) [15:31:21] (03PS2) 10Reedy: Format archive and filearchive revision delete log entries [core] - 10https://gerrit.wikimedia.org/r/125572 (owner: 10Umherirrender) [15:32:08] (03CR) 10Reedy: [C: 032] Format archive and filearchive revision delete log entries [core] - 10https://gerrit.wikimedia.org/r/125572 (owner: 10Umherirrender) [15:35:47] (03Merged) 10jenkins-bot: Format archive and filearchive revision delete log entries [core] - 10https://gerrit.wikimedia.org/r/125572 (owner: 10Umherirrender) [15:36:47] (03CR) 10Reedy: [C: 04-1] Add 'messages used' comment (031 comment) [core] - 10https://gerrit.wikimedia.org/r/125567 (owner: 10Umherirrender) [15:37:42] (03CR) 10Alex Monk: [C: 032] i18n tweaks [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/125582 (owner: 10Shirayuki) [15:37:49] (03Merged) 10jenkins-bot: i18n tweaks [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/125582 (owner: 10Shirayuki) [15:45:53] (03PS2) 10Umherirrender: Add 'messages used' comment [core] - 10https://gerrit.wikimedia.org/r/125567 [15:47:03] (03CR) 10Umherirrender: "Patch Set 2: Fixed missing r" [core] - 10https://gerrit.wikimedia.org/r/125567 (owner: 10Umherirrender) [15:47:10] (03PS3) 10Umherirrender: Add 'messages used' comment [core] - 10https://gerrit.wikimedia.org/r/125567 [15:53:18] seen bawolff? [16:18:03] (03PS4) 10Cicalese: Add SelfLinkBeginHook [core] - 10https://gerrit.wikimedia.org/r/124149 [16:20:33] (03CR) 10Umherirrender: "One comment and would be nice to have this also on Special:DeletedContributions" (031 comment) [core] - 10https://gerrit.wikimedia.org/r/117854 (owner: 10Ganeshaditya1) [16:23:17] (03CR) 10Ganeshaditya1: "Do I need to file that requirement as a bug or just work on it and send a patch with no bug number ?" [core] - 10https://gerrit.wikimedia.org/r/117854 (owner: 10Ganeshaditya1) [16:28:23] (03CR) 10Umherirrender: "In my opinion it is okay to submit patches without a bug." [core] - 10https://gerrit.wikimedia.org/r/117854 (owner: 10Ganeshaditya1) [16:44:19] (03PS2) 10Umherirrender: Fix RevDel_RevisionItem::getAuthorNameField to work for ips [core] - 10https://gerrit.wikimedia.org/r/125568 [16:44:39] (03CR) 10Umherirrender: "Patch Set 2: Expand commit message" [core] - 10https://gerrit.wikimedia.org/r/125568 (owner: 10Umherirrender) [16:59:01] (03CR) 10Nikerabbit: [C: 032] Add 'messages used' comment [core] - 10https://gerrit.wikimedia.org/r/125567 (owner: 10Umherirrender) [17:01:51] (03Merged) 10jenkins-bot: Add 'messages used' comment [core] - 10https://gerrit.wikimedia.org/r/125567 (owner: 10Umherirrender) [17:37:19] (03PS3) 10TheDJ: Apply coding conventions for whitespaces [core] - 10https://gerrit.wikimedia.org/r/125328 (owner: 10Gerrit Patch Uploader) [17:40:01] (03PS5) 10TheDJ: Fix IE9's lack of support for console.warn.apply [core] - 10https://gerrit.wikimedia.org/r/125197 (owner: 10MarkAHershberger) [17:46:57] (03CR) 10jenkins-bot: [V: 04-1] Fix IE9's lack of support for console.warn.apply [core] - 10https://gerrit.wikimedia.org/r/125197 (owner: 10MarkAHershberger) [18:03:23] (03PS4) 10Gerrit Patch Uploader: Apply coding conventions for whitespaces [core] - 10https://gerrit.wikimedia.org/r/125328 [18:03:25] (03CR) 10Gerrit Patch Uploader: "This commit was uploaded using the Gerrit Patch Uploader [1]." [core] - 10https://gerrit.wikimedia.org/r/125328 (owner: 10Gerrit Patch Uploader) [18:21:37] (03CR) 10Ganeshaditya1: "Also just for the record .. In the special:deletedContributions page the checking of whether the user name supplied is valid or not should" [core] - 10https://gerrit.wikimedia.org/r/117854 (owner: 10Ganeshaditya1) [18:24:27] (03PS6) 10Gerrit Patch Uploader: wpSummaryLabel and wpSummary in one line with full width [core] - 10https://gerrit.wikimedia.org/r/118246 [18:24:29] (03CR) 10Gerrit Patch Uploader: "This commit was uploaded using the Gerrit Patch Uploader [1]." [core] - 10https://gerrit.wikimedia.org/r/118246 (owner: 10Gerrit Patch Uploader) [18:24:45] (03CR) 10Fomafix: "It is not intentional to push the checkboxes aside." [core] - 10https://gerrit.wikimedia.org/r/118246 (owner: 10Gerrit Patch Uploader) [18:37:04] (03PS1) 10Fo0bar: Use FormatJson::encode() for escaping template JS [extensions/GoogleSiteSearch] - 10https://gerrit.wikimedia.org/r/125583 [18:45:00] (03CR) 10Fo0bar: [C: 032 V: 032] Use FormatJson::encode() for escaping template JS [extensions/GoogleSiteSearch] - 10https://gerrit.wikimedia.org/r/125583 (owner: 10Fo0bar) [18:46:46] (03PS1) 10Fo0bar: Allow template use on HTTPS sites [extensions/GoogleSiteSearch] - 10https://gerrit.wikimedia.org/r/125584 [18:46:58] (03CR) 10Fo0bar: [C: 032 V: 032] Allow template use on HTTPS sites [extensions/GoogleSiteSearch] - 10https://gerrit.wikimedia.org/r/125584 (owner: 10Fo0bar) [18:54:42] (03CR) 10TheDJ: [C: 04-1] "I found a few more potential problems:" [core] - 10https://gerrit.wikimedia.org/r/5130 (owner: 10Joancreus) [19:06:18] (03PS1) 10Fo0bar: Global $wgGoogleSiteSearchCharset in GoogleSiteSearch() [extensions/GoogleSiteSearch] - 10https://gerrit.wikimedia.org/r/125585 [19:07:07] (03CR) 10Fo0bar: [C: 032 V: 032] Global $wgGoogleSiteSearchCharset in GoogleSiteSearch() [extensions/GoogleSiteSearch] - 10https://gerrit.wikimedia.org/r/125585 (owner: 10Fo0bar) [19:25:22] (03PS1) 10Jackmcbarn: Include action in permission error messages [core] - 10https://gerrit.wikimedia.org/r/125674 [19:31:30] (03PS2) 10Jackmcbarn: Include action in permission error messages [core] - 10https://gerrit.wikimedia.org/r/125674 [19:34:29] (03PS1) 10Fo0bar: Fix PHP Undefined notices [extensions/SecureHTML] - 10https://gerrit.wikimedia.org/r/125676 [19:34:48] (03CR) 10Fo0bar: [C: 032 V: 032] Fix PHP Undefined notices [extensions/SecureHTML] - 10https://gerrit.wikimedia.org/r/125676 (owner: 10Fo0bar) [19:37:50] (03CR) 10jenkins-bot: [V: 04-1] Include action in permission error messages [core] - 10https://gerrit.wikimedia.org/r/125674 (owner: 10Jackmcbarn) [19:50:35] (03PS3) 10Jackmcbarn: Include action in permission error messages [core] - 10https://gerrit.wikimedia.org/r/125674 [19:56:20] (03CR) 10jenkins-bot: [V: 04-1] Include action in permission error messages [core] - 10https://gerrit.wikimedia.org/r/125674 (owner: 10Jackmcbarn) [19:57:43] (03PS4) 10Jackmcbarn: Include action in permission error messages [core] - 10https://gerrit.wikimedia.org/r/125674 [20:05:32] (03PS6) 10IAlex: Improve UDP logging code [core] - 10https://gerrit.wikimedia.org/r/125436 [20:05:37] (03PS7) 10IAlex: Improve UDP logging code [core] - 10https://gerrit.wikimedia.org/r/125436 [20:05:56] (03CR) 10IAlex: Improve UDP logging code (031 comment) [core] - 10https://gerrit.wikimedia.org/r/125436 (owner: 10IAlex) [20:07:43] (03CR) 10Tpt: [C: 031] "Looks good and works fine with ProofreadPage" [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/124607 (owner: 10TheDJ) [20:10:41] (03PS1) 10IAlex: Normalise comments in Setup.php [core] - 10https://gerrit.wikimedia.org/r/125677 [20:10:47] (03CR) 10Tpt: "I believe you have done a typo error." (031 comment) [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/124734 (owner: 10TheDJ) [20:17:12] (03PS2) 10Amire80: Add talk link to excontentauthor [core] - 10https://gerrit.wikimedia.org/r/124158 [20:25:09] (03PS1) 10Mwjames: Some cosmetics + basic test coverage [extensions/Bootstrap] - 10https://gerrit.wikimedia.org/r/125678 [20:29:50] (03PS1) 10Mwjames: Update due to Bootstrap changes [skins/chameleon] - 10https://gerrit.wikimedia.org/r/125679 [20:52:37] (03CR) 10Umherirrender: "I see no reason to have another check there." [core] - 10https://gerrit.wikimedia.org/r/117854 (owner: 10Ganeshaditya1) [21:03:58] (03PS2) 10Mwjames: Some cosmetics + basic test coverage [extensions/Bootstrap] - 10https://gerrit.wikimedia.org/r/125678 [21:04:22] (03CR) 10Bartosz Dziewoński: "Needs rebase (again), the format of i18n messages have changed (all hail glorious JSON future)." [extensions/CheckUser] - 10https://gerrit.wikimedia.org/r/11562 (owner: 10saper) [21:20:53] (03PS1) 10Odder: Namespace translation for Latvian [extensions/Scribunto] - 10https://gerrit.wikimedia.org/r/125680 [21:44:27] (03PS3) 10Mwjames: Some cosmetics + basic test coverage [extensions/Bootstrap] - 10https://gerrit.wikimedia.org/r/125678 [21:45:27] (03CR) 10Stepzhou: "I did the following tests with ULS. Everything worked as expected." [core] - 10https://gerrit.wikimedia.org/r/120475 (owner: 10Stepzhou) [22:26:09] (03CR) 10Chad: "It's been a few weeks. Has anyone begun the process of cutting a REL1_23 so we can go ahead and get this in master?" [core] - 10https://gerrit.wikimedia.org/r/118345 (owner: 10Jdlrobson) [22:27:14] (03CR) 10Chad: [C: 032] Wrap djvu large local copy downloads in pool counter [core] - 10https://gerrit.wikimedia.org/r/125527 (owner: 10Aaron Schulz) [22:27:57] (03CR) 10Chad: [C: 032] Made preloadFileStat/preloadCache actually work for FileBackendMultiWrite [core] - 10https://gerrit.wikimedia.org/r/125574 (owner: 10Aaron Schulz) [22:28:14] (03CR) 10Chad: [C: 032] PrefixSearch: Remove unnecessary wfSuppressWarnings() [core] - 10https://gerrit.wikimedia.org/r/125513 (owner: 10Bartosz Dziewoński) [22:28:41] (03PS3) 10Wctaiwan: HTMLForm vform styling [core] - 10https://gerrit.wikimedia.org/r/124383 [22:30:44] (03Merged) 10jenkins-bot: Wrap djvu large local copy downloads in pool counter [core] - 10https://gerrit.wikimedia.org/r/125527 (owner: 10Aaron Schulz) [22:31:01] (03Merged) 10jenkins-bot: Made preloadFileStat/preloadCache actually work for FileBackendMultiWrite [core] - 10https://gerrit.wikimedia.org/r/125574 (owner: 10Aaron Schulz) [22:31:13] (03PS4) 10Chad: Add columns option to Special:PrefixIndex [core] - 10https://gerrit.wikimedia.org/r/110987 (owner: 10Yuvipanda) [22:31:34] (03CR) 10Chad: [C: 032] Add columns option to Special:PrefixIndex [core] - 10https://gerrit.wikimedia.org/r/110987 (owner: 10Yuvipanda) [22:32:07] (03Merged) 10jenkins-bot: PrefixSearch: Remove unnecessary wfSuppressWarnings() [core] - 10https://gerrit.wikimedia.org/r/125513 (owner: 10Bartosz Dziewoński) [22:41:00] (03Merged) 10jenkins-bot: Add columns option to Special:PrefixIndex [core] - 10https://gerrit.wikimedia.org/r/110987 (owner: 10Yuvipanda) [23:58:36] (03PS1) 10MarkAHershberger: Allow fixDoubleRedirects (and others) to find redirect loops [core] - 10https://gerrit.wikimedia.org/r/125681