[00:00:40] (03CR) 10jenkins-bot: [V: 04-1] Support JSDuck v5.x [core] - 10https://gerrit.wikimedia.org/r/125524 (owner: 10Jforrester) [00:00:47] (03Merged) 10jenkins-bot: Make DjVu metadata be stored as serialized PHP array. [core] - 10https://gerrit.wikimedia.org/r/99544 (owner: 10Brian Wolff) [00:01:04] (03Merged) 10jenkins-bot: Fix KSS mediawiki.ui style guide (docs) [core] - 10https://gerrit.wikimedia.org/r/125511 (owner: 10JGonera) [00:01:08] (03CR) 10jenkins-bot: [V: 04-1] doc: Fix errored variadic symbol on mediawiki.action.edit addButtons [core] - 10https://gerrit.wikimedia.org/r/125525 (owner: 10Jforrester) [00:02:28] (03CR) 10jenkins-bot: [V: 04-1] Use new banana checker as a linter to avoid lacking qqq messages [core] - 10https://gerrit.wikimedia.org/r/125050 (owner: 10Jforrester) [00:03:08] AaronSchulz: looks OK; have you tested it? [00:03:47] (03Merged) 10jenkins-bot: Update OOjs UI to v0.1.0-pre (eca1fc20e7) [core] - 10https://gerrit.wikimedia.org/r/125536 (owner: 10Catrope) [00:03:49] (03Merged) 10jenkins-bot: Update QUnit from v1.11.0 to v1.14.0 [core] - 10https://gerrit.wikimedia.org/r/125533 (owner: 10Krinkle) [00:03:49] ori: not really :) [00:04:09] AaronSchulz: OK, I'll do that then [00:06:19] (03PS5) 10Robmoen: Create base UI module. [extensions/UploadWizard] (oojsify) - 10https://gerrit.wikimedia.org/r/123818 [00:08:40] (03CR) 10Robmoen: [C: 04-1] "WIP: Still writing bits for dialog." [extensions/UploadWizard] (oojsify) - 10https://gerrit.wikimedia.org/r/123818 (owner: 10Robmoen) [00:10:28] (03PS1) 10Jforrester: Switch MediaWiki core's jsduck-publish task over to using the refreshed script [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/125540 [00:10:31] (03PS1) 10Jforrester: Create a general jsduck test task and use it for OOjs and OOjs UI [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/125541 [00:10:34] (03PS1) 10Jforrester: Create a general jsduck publish task and use it for OOjs and OOjs UI [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/125542 [00:10:37] (03PS1) 10Jforrester: Create a demos publishing task for OOjs UI [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/125543 [00:15:32] (03CR) 10Cscott: "Running a modified dumpGrepper against enwiki-20140304-pages-articles.xml.bz2:" [core] - 10https://gerrit.wikimedia.org/r/119332 (owner: 10Cscott) [00:17:12] (03PS2) 10Krinkle: mediawiki-core-jsduck-publish: Switch over to using the refreshed script [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/125540 (owner: 10Jforrester) [00:17:40] (03PS2) 10Krinkle: Create a general jsduck test task and use it for OOjs and OOjs UI [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/125541 (owner: 10Jforrester) [00:18:03] (03PS2) 10Krinkle: Create jsduck-publish tasks for OOjs and OOjs UI [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/125542 (owner: 10Jforrester) [00:18:07] (03PS3) 10Krinkle: Create jsduck-publish tasks for OOjs and OOjs UI [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/125542 (owner: 10Jforrester) [00:18:24] (03PS2) 10Krinkle: Create a demos-publish task for OOjs UI [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/125543 (owner: 10Jforrester) [00:18:27] (03PS3) 10Krinkle: Create a demos-publish task for OOjs UI [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/125543 (owner: 10Jforrester) [00:22:11] (03CR) 10EBernhardson: Standardize URL generation (0312 comments) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/121855 (owner: 10EBernhardson) [00:24:13] (03PS7) 10EBernhardson: Standardize URL generation [extensions/Flow] - 10https://gerrit.wikimedia.org/r/121855 [00:30:31] (03PS2) 10Krinkle: Support JSDuck v5.x [core] - 10https://gerrit.wikimedia.org/r/125524 (owner: 10Jforrester) [00:37:11] (03CR) 10jenkins-bot: [V: 04-1] Support JSDuck v5.x [core] - 10https://gerrit.wikimedia.org/r/125524 (owner: 10Jforrester) [00:39:43] (03PS3) 10Jforrester: mediawiki-core-jsduck: Switch over to using the refreshed script [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/125540 [00:40:22] RoanKattouw: is there a reference extension I could look at that demonstrates how localization for new extensions (that don't need to be backward-compatible with the old PHP-array-based i18n format) should be written? [00:40:48] ori: MultiMediaViewer, I think? [00:40:50] RoanKattouw: I only know of migrated extensions, and I'm not sure which bits of i18n code are simply there for backward-compatibility reasons [00:40:52] There are a few others that dropped compat [00:40:52] hmm [00:40:53] * ori looks [00:41:09] AIUI though just eradicating .i18n.php and any references to it should be enough [00:41:35] Also note that extensions that define magic words or other non-message i18n things still need a PHP file [00:41:55] i almost wish i didn't need i18n, the only thing in this extension that needs to be localized is the description in the extension credits [00:42:08] $wgExtensionMessagesFiles['MultimediaViewer'] = __DIR__ . '/MultimediaViewer.i18n.php'; [00:43:30] Hmm [00:43:36] Maybe it was another extension [00:43:50] so I need to declare $wgMessagesDirs['MyExtensions'], but not $wgExtensionMessagesFiles, right? [00:43:50] In any case, if you remove the .i18n.php file and references to it you should be set [00:43:54] Yes [00:43:57] (03PS1) 10Jforrester: mwext-VisualEditor-doc-publish: Simplify rsync calls [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/125546 [00:43:59] cool, thanks for your help [00:44:08] And then create i18n/{en,qqq}.json and you should be all set [00:44:12] * ori nods [00:46:47] (03PS3) 10Krinkle: Support JSDuck v5.x [core] - 10https://gerrit.wikimedia.org/r/125524 (owner: 10Jforrester) [00:51:06] (03PS1) 10Krinkle: Clean up unused symlink and fixup comment [integration/docroot] - 10https://gerrit.wikimedia.org/r/125547 [00:51:10] (03CR) 10Krinkle: [C: 032] Support JSDuck v5.x [core] - 10https://gerrit.wikimedia.org/r/125524 (owner: 10Jforrester) [00:52:19] (03CR) 10TTO: "To decide? What is there for the translators to decide?" [core] - 10https://gerrit.wikimedia.org/r/83662 (owner: 10Jforrester) [00:53:41] (03PS1) 10Hiong3-eng5: DownloadScriptPath [extensions/WikiLexicalData] - 10https://gerrit.wikimedia.org/r/125548 [00:53:52] (03CR) 10Krinkle: [C: 032] Clean up unused symlink and fixup comment [integration/docroot] - 10https://gerrit.wikimedia.org/r/125547 (owner: 10Krinkle) [00:53:55] (03Merged) 10jenkins-bot: Clean up unused symlink and fixup comment [integration/docroot] - 10https://gerrit.wikimedia.org/r/125547 (owner: 10Krinkle) [00:53:58] (03Merged) 10jenkins-bot: Support JSDuck v5.x [core] - 10https://gerrit.wikimedia.org/r/125524 (owner: 10Jforrester) [00:54:14] (03PS2) 10Krinkle: doc: Fix errored variadic symbol on mediawiki.action.edit addButtons [core] - 10https://gerrit.wikimedia.org/r/125525 (owner: 10Jforrester) [00:57:50] (03CR) 10Krinkle: [C: 032] "Deployed 'mediawiki-core-jsduck' and 'mediawiki-core-jsduck-publish'." [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/125540 (owner: 10Jforrester) [00:58:34] (03Merged) 10jenkins-bot: mediawiki-core-jsduck: Switch over to using the refreshed script [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/125540 (owner: 10Jforrester) [00:58:52] (03CR) 10Krinkle: [C: 032] "Nice catch." [core] - 10https://gerrit.wikimedia.org/r/125525 (owner: 10Jforrester) [01:01:40] (03Merged) 10jenkins-bot: doc: Fix errored variadic symbol on mediawiki.action.edit addButtons [core] - 10https://gerrit.wikimedia.org/r/125525 (owner: 10Jforrester) [01:26:11] (03PS1) 10Spage: Fix styleguide generation [core] - 10https://gerrit.wikimedia.org/r/125550 [01:27:15] (03CR) 10jenkins-bot: [V: 04-1] Fix styleguide generation [core] - 10https://gerrit.wikimedia.org/r/125550 (owner: 10Spage) [01:46:11] (03PS2) 10Spage: Fix styleguide generation [core] - 10https://gerrit.wikimedia.org/r/125550 [01:47:14] (03CR) 10jenkins-bot: [V: 04-1] Fix styleguide generation [core] - 10https://gerrit.wikimedia.org/r/125550 (owner: 10Spage) [01:55:41] (03Abandoned) 10Spage: Fix styleguide generation [core] - 10https://gerrit.wikimedia.org/r/125550 (owner: 10Spage) [01:57:47] (03CR) 10Legoktm: [C: 032] "A few days late. Thank you!" [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/120334 (owner: 10Wctaiwan) [01:57:59] (03Merged) 10jenkins-bot: Add ability to deliver to all pages in a category [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/120334 (owner: 10Wctaiwan) [02:01:01] o: [02:10:51] (03CR) 10Emufarmers: [C: 031] "Didn't test, but this seems like a good change to the Thanks workflowflowFlow." [extensions/Thanks] - 10https://gerrit.wikimedia.org/r/119879 (owner: 10Wctaiwan) [02:17:41] (03CR) 10Legoktm: "Looks good, just one question." (032 comments) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/121306 (owner: 10Wctaiwan) [02:18:05] (03PS3) 10Dan-nl: don’t place sub-template into main template when no value is present [extensions/GWToolset] - 10https://gerrit.wikimedia.org/r/124376 [02:18:31] (03CR) 10Dan-nl: "* ps3 was rebased" [extensions/GWToolset] - 10https://gerrit.wikimedia.org/r/124376 (owner: 10Dan-nl) [02:26:53] (03PS12) 10Wctaiwan: Implement a redirector at Special:Flow [extensions/Flow] - 10https://gerrit.wikimedia.org/r/121306 [02:28:32] (03PS13) 10Wctaiwan: Implement a redirector at Special:Flow [extensions/Flow] - 10https://gerrit.wikimedia.org/r/121306 [02:29:14] (03CR) 10Wctaiwan: Implement a redirector at Special:Flow (032 comments) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/121306 (owner: 10Wctaiwan) [02:40:50] (03PS1) 10Dan-nl: auto-add additional mediawiki template parameters as creator template values [extensions/GWToolset] - 10https://gerrit.wikimedia.org/r/125552 [02:44:23] (03PS8) 10EBernhardson: Standardize URL generation [extensions/Flow] - 10https://gerrit.wikimedia.org/r/121855 [02:45:01] (03CR) 10Legoktm: [C: 031] "Looks good, haven't tested yet." (031 comment) [extensions/Thanks] - 10https://gerrit.wikimedia.org/r/119879 (owner: 10Wctaiwan) [02:50:26] (03PS14) 10Wctaiwan: Implement a redirector at Special:Flow [extensions/Flow] - 10https://gerrit.wikimedia.org/r/121306 [02:57:33] (03CR) 10Mattflaschen: [C: 04-1] "I'll re-review this in detail later. However, so I don't forget, please add it to RELEASE-NOTES-1.23 , under features." (031 comment) [core] - 10https://gerrit.wikimedia.org/r/120806 (owner: 10Phuedx) [03:10:28] (03CR) 10Brian Wolff: [C: 04-1] "Oh right. I think this should just go back to looking for {{. A false positive on the check doesnt really matter. Ill change the patch." [core] - 10https://gerrit.wikimedia.org/r/124784 (owner: 10Brian Wolff) [03:27:47] (03CR) 10SG: [C: 032] Convert {#custom}...{/custom} helpers to be more like handlebars-2.0 [extensions/Flow] (frontend-rewrite) - 10https://gerrit.wikimedia.org/r/125355 (owner: 10EBernhardson) [03:28:03] (03Merged) 10jenkins-bot: Convert {#custom}...{/custom} helpers to be more like handlebars-2.0 [extensions/Flow] (frontend-rewrite) - 10https://gerrit.wikimedia.org/r/125355 (owner: 10EBernhardson) [03:32:55] (03CR) 10SG: [C: 04-1] "I'd like to see some PHPdoc tags describing LCSafeString and how to use it. I can assume it's "return new LCSafeString(str);", but still." [extensions/Flow] (frontend-rewrite) - 10https://gerrit.wikimedia.org/r/125352 (owner: 10EBernhardson) [03:54:56] (03PS17) 10Wctaiwan: Change UI of special page and support Flow Thanks [extensions/Thanks] - 10https://gerrit.wikimedia.org/r/119879 [03:55:17] (03CR) 10Wctaiwan: Change UI of special page and support Flow Thanks (031 comment) [extensions/Thanks] - 10https://gerrit.wikimedia.org/r/119879 (owner: 10Wctaiwan) [05:10:47] (03CR) 10Shirayuki: "qqq of "yourdiff" is empty, but it doesn't appear in banana:core log." [core] - 10https://gerrit.wikimedia.org/r/125050 (owner: 10Jforrester) [05:18:13] (03PS1) 10Hiong3-eng5: NS DefinedMeaning Title defaults to DM id - expression [extensions/WikiLexicalData] - 10https://gerrit.wikimedia.org/r/125558 [07:25:22] (03PS5) 10Umherirrender: Add jquery.accessKeyLabel javascript module [core] - 10https://gerrit.wikimedia.org/r/125426 [07:26:02] (03CR) 10Umherirrender: "Patch Set 5: Removed a comment" (031 comment) [core] - 10https://gerrit.wikimedia.org/r/125426 (owner: 10Umherirrender) [07:33:43] (03CR) 10Legoktm: [C: 031] "@Se4598: Thank you!" [extensions/GlobalCssJs] - 10https://gerrit.wikimedia.org/r/120333 (owner: 10Legoktm) [07:40:05] (03CR) 10Nikerabbit: Add jquery.accessKeyLabel javascript module (031 comment) [core] - 10https://gerrit.wikimedia.org/r/125426 (owner: 10Umherirrender) [07:57:25] (03PS1) 10Umherirrender: Fix line delimiter of sizzle.js inside jquery.js file [core] - 10https://gerrit.wikimedia.org/r/125560 [08:02:17] (03PS6) 10Umherirrender: Add jquery.accessKeyLabel javascript module [core] - 10https://gerrit.wikimedia.org/r/125426 [08:09:17] (03PS1) 10Legoktm: Fix grammar [extensions/GlobalCssJs] - 10https://gerrit.wikimedia.org/r/125561 [08:20:46] (03PS1) 10Ori.livneh: Use ResourceLoader::makeComment to embed page title in wiki modules [core] - 10https://gerrit.wikimedia.org/r/125562 [08:40:17] (03CR) 10Ori.livneh: [C: 032] Fix grammar [extensions/GlobalCssJs] - 10https://gerrit.wikimedia.org/r/125561 (owner: 10Legoktm) [08:40:19] (03Merged) 10jenkins-bot: Fix grammar [extensions/GlobalCssJs] - 10https://gerrit.wikimedia.org/r/125561 (owner: 10Legoktm) [08:56:41] (03CR) 10UltrasonicNXT: "Ok, I've actually decided there's quite a bit more to do, so I'll ad you back in later :)" [extensions/WikiForum] - 10https://gerrit.wikimedia.org/r/116258 (owner: 10UltrasonicNXT) [10:38:08] (03CR) 10TheDJ: "This should be done upstream." [core] - 10https://gerrit.wikimedia.org/r/125560 (owner: 10Umherirrender) [11:18:37] (03PS1) 10Bartosz Dziewoński: [poc] Autocomplete special pages' subpages in search suggestions [core] - 10https://gerrit.wikimedia.org/r/125565 [11:18:44] manybubbles: thoughts about this? :D ^ [11:30:39] (03CR) 10Umherirrender: "Using the version from [1] does not have the problem, but I was not sure, if there is no other changes, so I have using the regex replace " [core] - 10https://gerrit.wikimedia.org/r/125560 (owner: 10Umherirrender) [12:53:06] thedj: Jij zit natuurlijk al bijna in Duitsland.... [12:58:46] (03CR) 10Bartosz Dziewoński: [C: 032] Make .mw-ui-button height the same for all buttons [core] - 10https://gerrit.wikimedia.org/r/117107 (owner: 10JGonera) [13:00:54] (03CR) 10Nemo bis: "Received this by email:" [extensions/FormelApplet] - 10https://gerrit.wikimedia.org/r/69985 (owner: 10Rudolf.grossmann) [13:01:56] (03Merged) 10jenkins-bot: Make .mw-ui-button height the same for all buttons [core] - 10https://gerrit.wikimedia.org/r/117107 (owner: 10JGonera) [13:02:11] (03CR) 10Nemo bis: "Yes, when you submit a new patch please abandon this one. If you only need to add one line it will be easy, but you need to use proper sof" [extensions/FormelApplet] - 10https://gerrit.wikimedia.org/r/69985 (owner: 10Rudolf.grossmann) [13:09:30] (03PS19) 10Bartosz Dziewoński: Display a warning when the user name looked up is not registered [core] - 10https://gerrit.wikimedia.org/r/117854 (owner: 10Ganeshaditya1) [13:10:25] (03CR) 10Bartosz Dziewoński: [C: 032] "Rebased again, fixed whitespace and a typo in the message. Thanks for the patch!" [core] - 10https://gerrit.wikimedia.org/r/117854 (owner: 10Ganeshaditya1) [13:12:26] (03CR) 10Bartosz Dziewoński: "Was this aiming to fix bug 63805? It was marked as RESOLVED INVALID." [core] - 10https://gerrit.wikimedia.org/r/125397 (owner: 10TheDJ) [13:13:36] (03PS1) 10Taueres: Fixing bug #63738: Debug msg not showing correctly [core] - 10https://gerrit.wikimedia.org/r/125566 [13:14:42] (03Merged) 10jenkins-bot: Display a warning when the user name looked up is not registered [core] - 10https://gerrit.wikimedia.org/r/117854 (owner: 10Ganeshaditya1) [13:18:44] (03CR) 10Bartosz Dziewoński: [C: 04-1] Fix incorrect usage of Title::newFromText [extensions/Echo] - 10https://gerrit.wikimedia.org/r/116273 (owner: 10Legoktm) [13:31:39] (03PS2) 10Nemo bis: Use an actual URL for helppage in enotif_body [core] - 10https://gerrit.wikimedia.org/r/125219 [13:32:44] (03CR) 10jenkins-bot: [V: 04-1] Use an actual URL for helppage in enotif_body [core] - 10https://gerrit.wikimedia.org/r/125219 (owner: 10Nemo bis) [13:33:06] (03CR) 10Bartosz Dziewoński: "This fixed bug 62292, the reference to it somehow disappeared from the commit message with one of the patchsets here." [core] - 10https://gerrit.wikimedia.org/r/117107 (owner: 10JGonera) [14:01:55] (03CR) 10Nemo bis: [C: 04-1] "You seem to have doubled the file for some reason." [extensions/FormelApplet] - 10https://gerrit.wikimedia.org/r/79156 (owner: 10Rudolf.grossmann) [14:03:45] (03PS3) 10Nemo bis: Use an actual URL for helppage in enotif_body [core] - 10https://gerrit.wikimedia.org/r/125219 [14:17:28] (03PS3) 10Mwjames: Add NavbarHorizontalTest [skins/chameleon] - 10https://gerrit.wikimedia.org/r/125363 [14:28:08] (03PS4) 10Mwjames: Add NavbarHorizontalTest [skins/chameleon] - 10https://gerrit.wikimedia.org/r/125363 [15:37:34] slacking [15:38:12] MatmaRex: the above is the helppage bug I was talking of btw; it will also need to be backported [15:56:28] (03CR) 10Nemo bis: "Added Krenair because he fixed bug 43282" [core] - 10https://gerrit.wikimedia.org/r/39845 (owner: 10Legoktm) [16:14:08] Nemo_bis: hm? [16:14:20] ah, https://gerrit.wikimedia.org/r/#/c/125219/ i suppose [16:18:09] yes [16:20:53] ugh, \n newlines make it really not fun to review i18n changes now :( [16:21:51] indeed [16:22:02] or to make them, for that matter [16:22:22] I suspect it's a subtle strategy to force devs to split messages [16:25:31] we could probably write "\n\" [17:02:22] (03CR) 10Kipcool: [C: 032 V: 032] "I agree with the change :)" [extensions/WikiLexicalData] - 10https://gerrit.wikimedia.org/r/125558 (owner: 10Hiong3-eng5) [17:04:02] (03CR) 10Kipcool: [C: 032 V: 032] DownloadScriptPath [extensions/WikiLexicalData] - 10https://gerrit.wikimedia.org/r/125548 (owner: 10Hiong3-eng5) [17:14:02] (03PS18) 10UltrasonicNXT: Rewrite [extensions/WikiForum] - 10https://gerrit.wikimedia.org/r/116258 [17:14:04] (03CR) 10jenkins-bot: [V: 04-1] Rewrite [extensions/WikiForum] - 10https://gerrit.wikimedia.org/r/116258 (owner: 10UltrasonicNXT) [17:39:34] (03PS19) 10UltrasonicNXT: Rewrite [extensions/WikiForum] - 10https://gerrit.wikimedia.org/r/116258 [17:39:36] (03CR) 10jenkins-bot: [V: 04-1] Rewrite [extensions/WikiForum] - 10https://gerrit.wikimedia.org/r/116258 (owner: 10UltrasonicNXT) [17:39:42] (03CR) 10Ori.livneh: [C: 04-1] Add links to Global CSS/JS on Special:Preferences (031 comment) [extensions/GlobalCssJs] - 10https://gerrit.wikimedia.org/r/120333 (owner: 10Legoktm) [17:40:23] Nemo_bis: I'll merge https://gerrit.wikimedia.org/r/#/c/119216/ if you fix it; it's a good patch [17:42:20] ori: yes, thank you for your comment there, it was reassuring :) [17:42:49] oh, I hadn't seen the -2 was lifted [17:44:44] Nemo_bis: "a -2, in fact, declares in advance of closure that there is a consensus for merge" [17:45:46] *cough* *cough* [17:46:01] I don't think the first of the two conditions is satisfied here :P oh well [17:46:17] (03PS20) 10UltrasonicNXT: Rewrite [extensions/WikiForum] - 10https://gerrit.wikimedia.org/r/116258 [17:47:49] (03CR) 10UltrasonicNXT: [C: 032 V: 032] "Jack reckons I can go on with this, so here we go!" [extensions/WikiForum] - 10https://gerrit.wikimedia.org/r/116258 (owner: 10UltrasonicNXT) [17:51:23] MatmaRex: re: https://gerrit.wikimedia.org/r/#/c/117438/ (check normalization rules) -- any reason not to check if ( username.charAt( 0 ) !== username.charAt( 0 ).toLocaleUpperCase() ) { .. } before launching a request to the api? [17:52:02] you hardly need the backend for that [17:53:02] i'll comment on the patch [17:53:11] ori: i really don't want to stick this login in the frontend, keeping things like that synchronised sucks [17:53:11] (03CR) 10Ori.livneh: [C: 04-1] "any reason not to check if ( username.charAt( 0 ) !== username.charAt( 0 ).toLocaleUpperCase() ) { .. } before launching a request to the " [core] - 10https://gerrit.wikimedia.org/r/117438 (owner: 10Bartosz Dziewoński) [17:53:27] and it'd be totally rad to allow lowercase-first usernames one day [17:53:32] there's a bug for that or two [17:53:54] we can do that check of course, or just use mw.Title [17:54:14] (unless it doesn't support that… keeping things synchronised is hard) [17:54:48] ori: do you think these api queries could become a performance concern? [17:55:28] MatmaRex: it's not a performance 'concern' so much as a missed opportunity to improve latency substantially for what must be a fairly common case [17:55:46] it's not going to take down the cluster if that's what you mean :P [17:58:11] hmph, mw.Title doesn't handle the capitalising at all [17:58:41] or maybe it does [17:59:55] ori: do you think we can assume that mw.Title will not cause any false negatives? (it will not fail to parse any valid username) [18:01:21] ori: if yes, then we could and should probably check if mw.Title.newFromText( 'User:' + username ).getText() === username [18:01:30] (or something along these lines) [18:03:14] MatmaRex: I am looking at the code for mw.Title and I think all of the reasons that would cause it to fail to parse the username will also cause the backend to reject the username [18:03:38] MatmaRex: so that's even better -- it makes the range of issues that are caught client-side even wider [18:06:49] let's try that [18:07:00] ori: brb, i'll submit a patch in a second [18:08:43] (03CR) 10Apsdehal: "I need some guidance regarding the patch to work on this." [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/101178 (owner: 10Apsdehal) [18:11:30] (03CR) 10Bartosz Dziewoński: [C: 04-1] "Per our IRC chat, let's go further and first use mw.Title to check for invalid/canonicalized usernames before we re-check with the server." [core] - 10https://gerrit.wikimedia.org/r/117438 (owner: 10Bartosz Dziewoński) [18:14:06] (03CR) 10Umherirrender: "Was added with I841b03895e1189c47307fefb1516c4c7c4102e25, so adding saper and chad as reviewer" [core] - 10https://gerrit.wikimedia.org/r/125566 (owner: 10Taueres) [18:15:41] ori: hmm, actually. checking for normalization client-side could "suppress" errors about the username being taken, if the warning about normalization would be shown [18:16:52] so basically, if we want to do this, we'd have to further separate the warnings and the errors here [18:17:31] and the current promise-based internals won't really work anymore… [18:21:36] well, I think we really want to nail the UX down [18:22:30] IMO we should just #wpName2:first-letter { text-transform: capitalize; } [18:22:46] supported by all browsers including old versions of IE [18:23:28] upon submit we'd cast the initial letter to uppercase if it wasn't inputted as such (since text-transform only affects appearance) [18:23:45] that might be annoying, but i dunno [18:23:51] would that work for turkish wikis, though? :P [18:25:09] turkish may need some special-casing, yeah [18:25:15] ori: actually, :first-letter won't work on an i think, will it? [18:25:40] there are not "letters", there's just the input box [18:26:45] so maybe doing it in JS is the right thing [18:26:53] with a keypress handler, that is [18:27:30] i mean, the annoying thing IMO is that we force you to have an initial cap. but this patch isn't changing that one way or another. it's really a question of how we communicate that to the user in a manner that doesn't make it even more annoying [18:27:38] i agree with you that finding it out *after* registration is especially annoying [18:27:39] ori: have you ever came upon a website that asks you to input a telephone number, and uses some shitty library to "format" it inside of the input? dunno about you, but me, that drives me mad [18:27:52] i probably would have not gone with 'Ori.livneh' if i knew that in 2006 or whatever [18:27:54] it might work in this case, it's a lot simpler [18:28:04] but it still… irks me. [18:28:17] could we make a contenteditable span and set text-transform on it, or would that be even less compatible? [18:28:47] jackmcbarn: interesting, but yeah, i suspect it would be harder to make that work consistently than a keypress handler that actually transforms the value [18:28:48] jackmcbarn: both :first-letter and text-transform are problematic with dynamic content (or at least used to be last time i tried that) [18:29:01] might even work these days, but who knows [18:29:28] MatmaRex: i still like my initial suggestion, which is to show a warning if the user backspaces over the capitalization [18:30:06] kinda like most mobile input interfaces will normalize 'ill' to "I'll" when you hit space, but if you backspace it goes back to 'ill' [18:30:45] for english, i mean [18:31:33] personally the only time i've seen autocorrect done somewhat right was in Microsoft Word, and these guys have spend a lot of time just building a text editor ;) [18:33:56] eh, i'm old-fashioned i guess, i also prefer text to icons for conveying information… [18:36:15] i hate that you got the wmf runaround for those patches since they're thoughtful and well-implemented. so i'm motivated to merge them. but i think it's one of those cases where quibbling a little over the how the interface should behave may actually be worthwhile, as annoying as that can be.. [18:36:46] merge it, rather [18:42:34] ori: do you think it might be worth it to remove the interface part for now (for warnings) and possibly run some tests to see which interface would actually work? [18:42:51] ori: or, at least run some logging to see how often people actually type in lowercase usernames [18:44:19] MatmaRex: the latter would be easy to implement, but what would it tell us? [18:44:44] how would we act differently based on the result? [18:44:54] it might tell us whether we should care ;) [18:45:13] we should care [18:45:31] i mean, you're arguing that we should care, too [18:46:44] i mean, all the ideas that we've considered are consistent on this point: if you type in a name that is valid and requires no normalization then you're not shown any warnings [18:47:37] A/B testing the two concrete implementation proposals (warnings box vs autocorrect) should be simple enough (if someone implements the second one) [18:48:00] A/B testing something vs nothing would be even simpler [18:48:04] so it's not a question of whether it's OK to degrade experience for some users in exchange for improving it for others (which would call for some data analysis). it's a question of whether it's cool to implicitly assume that normalization is OK, and not let the user reconsider. even if it's a minority of cases it's kind of a severe defect (i think you are arguing that as well) so that's why i say it's worth doing [18:48:17] i suppose we could check whether people end up creating the account with the warning, and whether they actually use them afterwards [18:49:11] * ori nods [18:49:12] (not sure how meaningful the results would be…) [18:49:30] probably more meaningful than just wild guessing [18:51:42] i dunno. poorly-defined research is worse than agnosticism [18:52:02] and i don't think anyone will put in the work in advance to define it rigorously [18:52:08] so actually, i think i'm ok with merging your patch [18:52:21] Hey all. [18:52:23] because that's probably the best way to force us to think about it [18:53:05] I wonder, I am wondering if somebody converted from MySQL to PostgreSQL and successfully migrated an existing MW site? [18:53:36] maybe we should collect a little bit of data about how many users input an initial lowercase. just knowing what % of new signups will see a warning is significant [18:53:49] * ori should stop hmming and hawing [18:54:21] i dunno myself [18:54:42] * MatmaRex hates design stuffs [18:58:18] gotta run but i'll think about it more and reply on the patch [18:58:40] thanks [18:58:58] thanks for the patience [19:23:33] (03CR) 10saper: [C: 031] "Thanks! This is embarassing... Thanks for tracking this down!" [core] - 10https://gerrit.wikimedia.org/r/125566 (owner: 10Taueres) [19:33:43] renoirb: iirc there is a manual page for it, isn't there? [19:34:15] not many do such a crazy thing ;) , so your best bet is reading the docs and editing them when you find mistakes/report your experience on talk page [19:34:26] be ready to breakage [19:34:28] Nemo_bis: indeed. [19:34:42] My question is whether somebody here actually did [19:34:52] (03PS4) 10Legoktm: Add links to Global CSS/JS on Special:Preferences [extensions/GlobalCssJs] - 10https://gerrit.wikimedia.org/r/120333 [19:35:11] wiki pages are nice and I contribute whenever I can when its relevant. [19:35:27] (03CR) 10Legoktm: Add links to Global CSS/JS on Special:Preferences (031 comment) [extensions/GlobalCssJs] - 10https://gerrit.wikimedia.org/r/120333 (owner: 10Legoktm) [19:35:37] unlikely you'll find someone here; IMHO asking on specific talk pages is better [19:40:46] (03PS1) 10Umherirrender: Add 'messages used' comment [core] - 10https://gerrit.wikimedia.org/r/125567 [20:31:36] (03PS5) 10Alex Monk: Have action=info check protected namespaces [core] - 10https://gerrit.wikimedia.org/r/39845 (owner: 10Legoktm) [20:32:39] (03CR) 10Alex Monk: [C: 04-1] "* Duplicates info" [core] - 10https://gerrit.wikimedia.org/r/39845 (owner: 10Legoktm) [20:36:00] (03CR) 10Alex Monk: Have action=info check protected namespaces (031 comment) [core] - 10https://gerrit.wikimedia.org/r/39845 (owner: 10Legoktm) [20:36:45] (03CR) 10Alex Monk: "To fix the issue with the default i18n namespace, could just make a protect-level-editinterface message" [core] - 10https://gerrit.wikimedia.org/r/39845 (owner: 10Legoktm) [20:41:29] (03PS1) 10Umherirrender: Fix RevDel_RevisionItem::getAuthorNameField to work for ips [core] - 10https://gerrit.wikimedia.org/r/125568 [20:44:23] (03CR) 10Umherirrender: "Was changed by aaron on r100326" [core] - 10https://gerrit.wikimedia.org/r/125568 (owner: 10Umherirrender) [20:58:04] (03PS1) 10UltrasonicNXT: Fix reply & thread wikitext parsing [extensions/WikiForum] - 10https://gerrit.wikimedia.org/r/125569 [20:58:31] (03CR) 10UltrasonicNXT: [C: 032 V: 032] Fix reply & thread wikitext parsing [extensions/WikiForum] - 10https://gerrit.wikimedia.org/r/125569 (owner: 10UltrasonicNXT) [21:09:52] ori? [21:12:11] (03PS1) 10Legoktm: Only display editnotice if $wgAllowUserJs/Css are true [extensions/GlobalCssJs] - 10https://gerrit.wikimedia.org/r/125570 [21:17:34] (03PS5) 10Ori.livneh: Add links to Global CSS/JS on Special:Preferences [extensions/GlobalCssJs] - 10https://gerrit.wikimedia.org/r/120333 (owner: 10Legoktm) [21:18:27] (03PS2) 10Legoktm: Fix incorrect usage of Title::newFromText [extensions/Echo] - 10https://gerrit.wikimedia.org/r/116273 [21:18:46] (03CR) 10Legoktm: Fix incorrect usage of Title::newFromText (031 comment) [extensions/Echo] - 10https://gerrit.wikimedia.org/r/116273 (owner: 10Legoktm) [21:18:56] (03PS3) 10Legoktm: Fix incorrect usage of Title::newFromText [extensions/Echo] - 10https://gerrit.wikimedia.org/r/116273 [21:18:59] (03CR) 10Helder.wiki: [C: 031] Only display editnotice if $wgAllowUserJs/Css are true [extensions/GlobalCssJs] - 10https://gerrit.wikimedia.org/r/125570 (owner: 10Legoktm) [21:22:52] (03CR) 10Ori.livneh: [C: 032] Add links to Global CSS/JS on Special:Preferences [extensions/GlobalCssJs] - 10https://gerrit.wikimedia.org/r/120333 (owner: 10Legoktm) [21:22:54] (03Merged) 10jenkins-bot: Add links to Global CSS/JS on Special:Preferences [extensions/GlobalCssJs] - 10https://gerrit.wikimedia.org/r/120333 (owner: 10Legoktm) [21:24:48] (03CR) 10Helder.wiki: [C: 031] Add support for MediaWiki:Global-$skinname.js/css [extensions/GlobalCssJs] - 10https://gerrit.wikimedia.org/r/114896 (owner: 10Legoktm) [21:54:00] (03PS1) 10Ori.livneh: lowerInitialCamelCase module names [extensions/GlobalCssJs] - 10https://gerrit.wikimedia.org/r/125571 [22:14:26] (03PS1) 10Umherirrender: Format archive and filearchive revision delete log entries [core] - 10https://gerrit.wikimedia.org/r/125572 [22:28:10] (03PS1) 10Aaron Schulz: [WIP] Added path encoding to FileBackendStore for Windows support [core] - 10https://gerrit.wikimedia.org/r/125573 [22:34:35] (03PS2) 10Aaron Schulz: [WIP] Added path encoding to FileBackendStore for Windows support [core] - 10https://gerrit.wikimedia.org/r/125573 [22:35:17] (03CR) 10AndyRussG: "Thanks!!! I'll remove the historical participations data with a view to adding it back in with a separate table once the requirements have" (0334 comments) [extensions/Campaigns] (wip/editorcampaigns) - 10https://gerrit.wikimedia.org/r/123781 (owner: 10AndyRussG) [22:43:30] (03PS1) 10Aaron Schulz: Made preloadFileStat/preloadCache actually work for FileBackendMultiWrite [core] - 10https://gerrit.wikimedia.org/r/125574 [22:57:40] (03PS3) 10Aaron Schulz: [WIP] Added path encoding to FileBackendStore for Windows support [core] - 10https://gerrit.wikimedia.org/r/125573