[00:00:35] (03CR) 10Krinkle: "Unless you intentionally added less specific syntax, there is no reason to have this interpreted as less. Might as well roundtrip it to gz" [core] - 10https://gerrit.wikimedia.org/r/110908 (owner: 10Isarra) [00:01:21] (03PS1) 10BryanDavis: Fix IRCSocketHandler to work from Jenkins [tools/scap] - 10https://gerrit.wikimedia.org/r/125359 [00:02:21] (03PS1) 10AndyRussG: WIP Inform user about campaign and allow opt-out [extensions/Campaigns] (wip/editorcampaigns) - 10https://gerrit.wikimedia.org/r/125360 [00:02:25] (03CR) 10jenkins-bot: [V: 04-1] WIP Inform user about campaign and allow opt-out [extensions/Campaigns] (wip/editorcampaigns) - 10https://gerrit.wikimedia.org/r/125360 (owner: 10AndyRussG) [00:03:37] (03CR) 10Krinkle: "Where do you intend to use this by the way? Given that this is something that would be part of the skin (not loaded as its own module, bec" [core] - 10https://gerrit.wikimedia.org/r/110908 (owner: 10Isarra) [00:05:37] (03CR) 10Ori.livneh: [C: 04-2] "I don't think this is right. The crux of the optimization here is that "it's not cheating if you don't get caught" -- that is, we can misr" [core] - 10https://gerrit.wikimedia.org/r/72534 (owner: 10Hoo man) [00:05:56] (03PS2) 10AndyRussG: WIP Inform user about campaign and allow opt-out [extensions/Campaigns] (wip/editorcampaigns) - 10https://gerrit.wikimedia.org/r/125360 [00:09:25] (03PS1) 10Aaron Schulz: Avoid making cycles which leak in HHVM [extensions/FlaggedRevs] - 10https://gerrit.wikimedia.org/r/125361 [00:10:58] (03CR) 10Hoo man: "I don't really think that strict consistency is needed over here (for what purpose?). Also changing the format of the array can be an addi" [core] - 10https://gerrit.wikimedia.org/r/72534 (owner: 10Hoo man) [00:15:36] (03CR) 10Krinkle: "That would be redundant (and possibly less efficient) given gzip doing for us that already (and it'd probably keep the code simpler when n" [core] - 10https://gerrit.wikimedia.org/r/72534 (owner: 10Hoo man) [00:17:04] (03CR) 10Ori.livneh: [C: 04-1] "@Hoo: No, don't kill it. I'll think it over in light of the follow-up comments." [core] - 10https://gerrit.wikimedia.org/r/72534 (owner: 10Hoo man) [00:18:20] (03CR) 10Adamw: "Brilliant! I haven't reviewed includes/persistence/internal/db or the tests yet, otherwise it looks mergeable." (0331 comments) [extensions/Campaigns] (wip/editorcampaigns) - 10https://gerrit.wikimedia.org/r/123781 (owner: 10AndyRussG) [00:18:51] (03PS1) 10Mwjames: Add NavbarHorizontalTest [skins/chameleon] - 10https://gerrit.wikimedia.org/r/125363 [00:19:37] (03CR) 10BryanDavis: "Tested with manual edit on deployment-bastion" [tools/scap] - 10https://gerrit.wikimedia.org/r/125359 (owner: 10BryanDavis) [00:19:47] (03CR) 10Ori.livneh: [C: 031] Commit DB changes as normal on exception-based GUI errors [core] - 10https://gerrit.wikimedia.org/r/116625 (owner: 10Aaron Schulz) [00:21:19] (03PS21) 10Bsitu: Closing & reopening topic [extensions/Flow] - 10https://gerrit.wikimedia.org/r/118399 [00:23:14] (03CR) 10Ori.livneh: [C: 04-1] Fix IRCSocketHandler to work from Jenkins (031 comment) [tools/scap] - 10https://gerrit.wikimedia.org/r/125359 (owner: 10BryanDavis) [00:23:23] (03PS2) 10Mwjames: Add NavbarHorizontalTest [skins/chameleon] - 10https://gerrit.wikimedia.org/r/125363 [00:23:28] (03CR) 10Aaron Schulz: [WIP] Added HHVM support (032 comments) [php/FastStringSearch] - 10https://gerrit.wikimedia.org/r/120469 (owner: 10Aaron Schulz) [00:28:02] superm401, do you know what happened to the makefile for mediawiki.ui? [00:28:16] i.e. how do I run make kss now? [00:28:36] (03PS6) 10JGonera: Make .mw-ui-button height the same for all buttons [core] - 10https://gerrit.wikimedia.org/r/117107 [00:29:03] (03CR) 10JGonera: Make .mw-ui-button height the same for all buttons (031 comment) [core] - 10https://gerrit.wikimedia.org/r/117107 (owner: 10JGonera) [00:42:29] (03PS2) 10Bsitu: Add rev_type to lastRevCache key [extensions/Flow] - 10https://gerrit.wikimedia.org/r/123144 [00:44:15] (03PS2) 10BryanDavis: Fix IRCSocketHandler to work from Jenkins [tools/scap] - 10https://gerrit.wikimedia.org/r/125359 [00:45:40] (03CR) 10BryanDavis: Fix IRCSocketHandler to work from Jenkins (031 comment) [tools/scap] - 10https://gerrit.wikimedia.org/r/125359 (owner: 10BryanDavis) [01:01:27] (03CR) 10Ori.livneh: [C: 04-1] Fix IRCSocketHandler to work from Jenkins (031 comment) [tools/scap] - 10https://gerrit.wikimedia.org/r/125359 (owner: 10BryanDavis) [01:04:37] (03CR) 10BryanDavis: Fix IRCSocketHandler to work from Jenkins (031 comment) [tools/scap] - 10https://gerrit.wikimedia.org/r/125359 (owner: 10BryanDavis) [01:05:00] (03PS3) 10BryanDavis: Fix IRCSocketHandler to work from Jenkins [tools/scap] - 10https://gerrit.wikimedia.org/r/125359 [01:06:32] (03PS1) 10Manybubbles: Add a max offset parameter [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/125364 [01:07:49] (03CR) 10Spage: "Had trouble running it, question about approach." (032 comments) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/123874 (owner: 10Bencmq) [01:12:28] (03CR) 10Manybubbles: "I wonder, now that I've done this, if this isn't better to do in core. It is worse for Elasticsearch then the other backends, mostly beca" [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/125364 (owner: 10Manybubbles) [01:18:11] (03PS1) 10Bsitu: Revert "Use merge() to update cache data" [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/125365 [01:18:59] (03PS2) 10Bsitu: Revert "Use merge() to update cache data" [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/125365 [01:19:25] (03CR) 10Bsitu: "I just realize this would cause a problem. The $update is just a partial update. If there is no data in cache, it should not add the par" [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/125243 (owner: 10Bsitu) [01:19:55] (03CR) 10Bsitu: [C: 032] Revert "Use merge() to update cache data" [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/125365 (owner: 10Bsitu) [01:19:59] (03Merged) 10jenkins-bot: Revert "Use merge() to update cache data" [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/125365 (owner: 10Bsitu) [01:20:14] (03CR) 10Ori.livneh: [C: 032] Fix IRCSocketHandler to work from Jenkins [tools/scap] - 10https://gerrit.wikimedia.org/r/125359 (owner: 10BryanDavis) [01:20:26] (03Merged) 10jenkins-bot: Fix IRCSocketHandler to work from Jenkins [tools/scap] - 10https://gerrit.wikimedia.org/r/125359 (owner: 10BryanDavis) [01:28:22] (03PS1) 10Bsitu: Use merge() to update cache [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/125366 [01:29:01] (03PS8) 10Krinkle: [WIP] Investigate swinging qunit test failure [core] - 10https://gerrit.wikimedia.org/r/124372 [01:39:09] (03CR) 10Foxtrott: Add NavbarHorizontalTest (031 comment) [skins/chameleon] - 10https://gerrit.wikimedia.org/r/125363 (owner: 10Mwjames) [01:55:32] (03PS2) 10MZMcBride: Check for existence before seeing if its an array in variable expansion [extensions/Flow] (frontend-rewrite) - 10https://gerrit.wikimedia.org/r/125351 (owner: 10EBernhardson) [02:06:09] jgonera, it was moved to docs/kss/Makefile in the same commit as the src/lib split [02:14:15] James_F, by the way, re your commit. make kss requires passing the URL of load.php as an environment variable. [02:14:24] This should be more obvious, but if you do that it will work. [02:23:46] jgonera, FYI, I'm doing a commit to fix the build. [02:39:38] (03PS1) 10Mattflaschen: Fix make kss build and explain environment variable in README [core] - 10https://gerrit.wikimedia.org/r/125368 [02:40:00] (03CR) 10Stevenroddis: "$iframeUrl = 'https://creativecommons.org/license/?' ." [core] - 10https://gerrit.wikimedia.org/r/125027 (owner: 10Gerrit Patch Uploader) [02:40:54] ori_: Thanks for https://bugzilla.wikimedia.org/show_bug.cgi?id=57891#c45 ! [02:43:16] (03CR) 10Mattflaschen: "I think there is also a cron job that updates http://tools.wmflabs.org/styleguide/ . This will have to be updated." [core] - 10https://gerrit.wikimedia.org/r/125368 (owner: 10Mattflaschen) [03:04:01] (03PS1) 1001tonythomas: Moved "Date format" user preference to "Appearence" tab [core] - 10https://gerrit.wikimedia.org/r/125370 [03:45:08] (03PS2) 1001tonythomas: Moved "Date format" user preference to "Appearence" tab [core] - 10https://gerrit.wikimedia.org/r/125370 [03:53:55] (03PS14) 10Mattflaschen: WIP: Refactor and add non-linear tours [extensions/GuidedTour] - 10https://gerrit.wikimedia.org/r/116228 [03:54:23] (03CR) 10jenkins-bot: [V: 04-1] WIP: Refactor and add non-linear tours [extensions/GuidedTour] - 10https://gerrit.wikimedia.org/r/116228 (owner: 10Mattflaschen) [03:55:44] (03PS1) 10Hiong3-eng5: SpecialLanguages 1.22 and below compatibility [extensions/WikiLexicalData] - 10https://gerrit.wikimedia.org/r/125371 [03:56:56] (03PS15) 10Mattflaschen: WIP: Refactor and add non-linear tours [extensions/GuidedTour] - 10https://gerrit.wikimedia.org/r/116228 [03:57:50] (03CR) 10Mattflaschen: "Changed to use transition instead of skip (per our discussion), and fixed an inconsistency with skipBeforeShow vs. SKIP_BEFORE_SHOW, and a" [extensions/GuidedTour] - 10https://gerrit.wikimedia.org/r/116228 (owner: 10Mattflaschen) [03:58:24] (03CR) 10Mattflaschen: WIP: Refactor and add non-linear tours (034 comments) [extensions/GuidedTour] - 10https://gerrit.wikimedia.org/r/116228 (owner: 10Mattflaschen) [04:06:57] (03PS5) 10Mattflaschen: Update firsteditve [extensions/GuidedTour] - 10https://gerrit.wikimedia.org/r/123171 [04:09:00] (03PS3) 10KartikMistry: Disable heartbeats for development environment [services/cxserver] - 10https://gerrit.wikimedia.org/r/124519 [04:12:12] bd808: by the way, the vagrant vbguest plugin has been breaking vagrant on macs [04:12:28] oh? [04:12:35] That's lame [04:12:46] It "works for me" but... [04:12:59] legoktm had it too, so did i, so did StevenW [04:13:08] i think there's a bug report [04:13:16] but i don't know that there's much we could do [04:13:17] ori_: I'm actually on fedora [04:13:34] legoktm: oh? [04:13:41] I don't think I've upgraded vagrant on my work laptop for a while [04:13:43] yeah :P [04:13:59] bd808: i think the culprit may be virtualbox [04:14:20] but i'm not sure. if you get a chance, upgrade both and destroy / create [04:14:29] (03CR) 10Mattflaschen: "Updated to use transition" [extensions/GuidedTour] - 10https://gerrit.wikimedia.org/r/123171 (owner: 10Mattflaschen) [04:16:12] * bd808 is afraid to breaking his vms [04:16:35] I try it on my non-work laptop first [04:18:01] Yikes. It looks like we need to do a vagrant bug day soon [04:32:50] (03PS1) 10Kushal124: [WIP]Make review setting configurable [wikimedia/wikimania-scholarships] - 10https://gerrit.wikimedia.org/r/125372 [04:33:18] (03CR) 10AndyRussG: "See https://gerrit.wikimedia.org/r/#/c/123781/ for a different approach following comments here and on IRC." [extensions/Campaigns] (wip/editorcampaigns) - 10https://gerrit.wikimedia.org/r/116221 (owner: 10AndyRussG) [04:56:45] (03PS2) 10Kushal124: [WIP]Make review setting configurable [wikimedia/wikimania-scholarships] - 10https://gerrit.wikimedia.org/r/125372 [04:56:57] (03CR) 10Kipcool: "Nice!" [extensions/WikiLexicalData] - 10https://gerrit.wikimedia.org/r/125371 (owner: 10Hiong3-eng5) [04:57:29] (03PS2) 10Hiong3-eng5: getPageTitle/getTitle 1.22 and below compatibility [extensions/WikiLexicalData] - 10https://gerrit.wikimedia.org/r/125371 [04:58:51] (03CR) 10Hiong3-eng5: "Kindly check for errors. I do not see any more problems here." [extensions/WikiLexicalData] - 10https://gerrit.wikimedia.org/r/125371 (owner: 10Hiong3-eng5) [05:00:00] (03PS3) 10Kushal124: [WIP]Make review setting configurable [wikimedia/wikimania-scholarships] - 10https://gerrit.wikimedia.org/r/125372 [05:00:55] (03CR) 10Hiong3-eng5: "Sorry Kip, just saw your comment, If you have time, can you change version checking for me, I do not have time to correct it now. gotta go" [extensions/WikiLexicalData] - 10https://gerrit.wikimedia.org/r/125371 (owner: 10Hiong3-eng5) [05:10:18] (03CR) 10Werdna: [C: 031] "LGTM" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/123144 (owner: 10Bsitu) [05:10:37] (03CR) 10Aaron Schulz: [C: 032] Use merge() to update cache [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/125366 (owner: 10Bsitu) [05:10:42] (03Merged) 10jenkins-bot: Use merge() to update cache [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/125366 (owner: 10Bsitu) [05:11:01] (03CR) 10Werdna: [C: 031] Use of new OutputPage() is deprecated [extensions/Flow] - 10https://gerrit.wikimedia.org/r/125345 (owner: 10Bsitu) [05:13:11] (03CR) 10Werdna: [C: 031] TopKIndex.replaceInIndex has incorrect return value in callback [extensions/Flow] - 10https://gerrit.wikimedia.org/r/124514 (owner: 10Bsitu) [05:14:43] (03CR) 10BryanDavis: "Great start." (035 comments) [wikimedia/wikimania-scholarships] - 10https://gerrit.wikimedia.org/r/125372 (owner: 10Kushal124) [05:24:25] (03CR) 10Nemo bis: "Filed as bug 63805..." [core] - 10https://gerrit.wikimedia.org/r/125337 (owner: 10Ganeshaditya1) [05:24:41] (03CR) 10Nemo bis: "Bug 63805" [core] - 10https://gerrit.wikimedia.org/r/116527 (owner: 10Krinkle) [05:29:28] (03CR) 10Werdna: [C: 031] "LGTM, but I guess you should coordinate w/ Erik's UrlGenerator changes in change 121855." [extensions/Flow] - 10https://gerrit.wikimedia.org/r/123217 (owner: 10Matthias Mullie) [05:45:35] (03CR) 10Werdna: "Haven't reviewed it line by line but overall I really like the approach and I think it's more or less spot on." (034 comments) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/121855 (owner: 10EBernhardson) [05:47:25] (03CR) 10Werdna: Add Parsoid's CSS modules (032 comments) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/124787 (owner: 10Spage) [05:53:45] (03PS2) 10EBernhardson: Accept scope parameter for partial template expansion [extensions/Flow] (frontend-rewrite) - 10https://gerrit.wikimedia.org/r/125350 [05:53:49] (03PS2) 10EBernhardson: Include LightnCandy vendor files [extensions/Flow] (frontend-rewrite) - 10https://gerrit.wikimedia.org/r/125349 [05:54:32] (03PS3) 10EBernhardson: Check for existance before seeing if its an array in variable expansion [extensions/Flow] (frontend-rewrite) - 10https://gerrit.wikimedia.org/r/125351 [05:55:11] (03PS2) 10EBernhardson: Add SafeString output for custom helpers [extensions/Flow] (frontend-rewrite) - 10https://gerrit.wikimedia.org/r/125352 [05:55:49] (03PS2) 10EBernhardson: Convert {#custom}...{/custom} helpers to be more like handlebars-2.0 [extensions/Flow] (frontend-rewrite) - 10https://gerrit.wikimedia.org/r/125355 [05:59:16] (03PS2) 10EBernhardson: Add @root special variable to access root scope [extensions/Flow] (frontend-rewrite) - 10https://gerrit.wikimedia.org/r/125356 [06:09:04] (03PS2) 10EBernhardson: First stab at new template rendering in php [extensions/Flow] (frontend-rewrite) - 10https://gerrit.wikimedia.org/r/125358 [06:09:07] (03PS2) 10EBernhardson: Initial import of handlebars templates [extensions/Flow] (frontend-rewrite) - 10https://gerrit.wikimedia.org/r/125357 [06:09:33] (03CR) 10jenkins-bot: [V: 04-1] Initial import of handlebars templates [extensions/Flow] (frontend-rewrite) - 10https://gerrit.wikimedia.org/r/125357 (owner: 10EBernhardson) [06:09:40] (03CR) 10Siebrand: [C: 032 V: 032] Clarify the "Watchlist-details" message [core] - 10https://gerrit.wikimedia.org/r/125337 (owner: 10Ganeshaditya1) [06:24:11] (03Abandoned) 10EBernhardson: Check for existance before seeing if its an array in variable expansion [extensions/Flow] (frontend-rewrite) - 10https://gerrit.wikimedia.org/r/125351 (owner: 10EBernhardson) [06:24:42] (03Abandoned) 10EBernhardson: More SafeString for lightncandy [extensions/Flow] (frontend-rewrite) - 10https://gerrit.wikimedia.org/r/125354 (owner: 10EBernhardson) [06:25:37] (03CR) 10TTO: "PiRSquared: I suggest to just go ahead and add c: to the interwiki map for now. If the world blows up, so be it; but that won't happen, in" [extensions/WikimediaMaintenance] - 10https://gerrit.wikimedia.org/r/112920 (owner: 10Gerrit Patch Uploader) [06:27:19] (03CR) 10Siebrand: [C: 032] "There's no need to remove qqq entries in future patch sets. See https://www.mediawiki.org/wiki/I18n#Removing_existing_messages for details" [core] - 10https://gerrit.wikimedia.org/r/125370 (owner: 1001tonythomas) [06:29:12] (03CR) 10Siebrand: [C: 031] "i18n/L10n reviewed." [extensions/Flow] - 10https://gerrit.wikimedia.org/r/118399 (owner: 10Bsitu) [06:31:57] (03CR) 10Siebrand: [C: 04-1] "i18n/L10n reviewed." (032 comments) [extensions/Campaigns] (wip/editorcampaigns) - 10https://gerrit.wikimedia.org/r/125360 (owner: 10AndyRussG) [06:59:53] (03PS1) 10Nikerabbit: Make compatible with MediaWiki 1.22 [extensions/InviteSignup] - 10https://gerrit.wikimedia.org/r/125374 [07:00:25] (03CR) 10Nikerabbit: [C: 032 V: 032] Make compatible with MediaWiki 1.22 [extensions/InviteSignup] - 10https://gerrit.wikimedia.org/r/125374 (owner: 10Nikerabbit) [07:17:25] (03CR) 10KartikMistry: [C: 04-1] "Broken." [services/cxserver] - 10https://gerrit.wikimedia.org/r/124519 (owner: 10KartikMistry) [07:19:35] (03PS3) 10Hiong3-eng5: getPageTitle/getTitle 1.22 and below compatibility [extensions/WikiLexicalData] - 10https://gerrit.wikimedia.org/r/125371 [07:20:25] (03CR) 10Hiong3-eng5: "Made the changes, kindly recheck the code. Thanks!" [extensions/WikiLexicalData] - 10https://gerrit.wikimedia.org/r/125371 (owner: 10Hiong3-eng5) [08:00:56] (03CR) 10Nikerabbit: [C: 032] Fix typo in comment [core] - 10https://gerrit.wikimedia.org/r/125330 (owner: 10Siebrand) [08:13:38] (03CR) 10Hashar: [C: 04-1] "Since the content is being reverted to sans-serif, I would revert the header back to sans-serif as well. Ie remove the stack from @content" (032 comments) [core] - 10https://gerrit.wikimedia.org/r/124475 (owner: 10Odder) [08:21:01] (03CR) 10Matthias Mullie: Add topic summary revision type (032 comments) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/117357 (owner: 10Bsitu) [08:24:26] (03PS2) 10Matthias Mullie: Some clean up to header [extensions/Flow] - 10https://gerrit.wikimedia.org/r/125240 (owner: 10Bsitu) [08:24:46] (03CR) 10Matthias Mullie: [C: 032] Some clean up to header [extensions/Flow] - 10https://gerrit.wikimedia.org/r/125240 (owner: 10Bsitu) [08:25:00] (03Merged) 10jenkins-bot: Some clean up to header [extensions/Flow] - 10https://gerrit.wikimedia.org/r/125240 (owner: 10Bsitu) [08:56:43] (03PS5) 10Gerrit Patch Uploader: Rework mediawiki.feedback.js [core] - 10https://gerrit.wikimedia.org/r/105457 [08:56:45] (03CR) 10Gerrit Patch Uploader: "This commit was uploaded using the Gerrit Patch Uploader [1]." [core] - 10https://gerrit.wikimedia.org/r/105457 (owner: 10Gerrit Patch Uploader) [08:58:01] (03CR) 10jenkins-bot: [V: 04-1] Rework mediawiki.feedback.js [core] - 10https://gerrit.wikimedia.org/r/105457 (owner: 10Gerrit Patch Uploader) [09:06:23] (03PS2) 10Gerrit Patch Uploader: Apply coding conventions for whitespaces [core] - 10https://gerrit.wikimedia.org/r/125328 [09:06:25] (03CR) 10Gerrit Patch Uploader: "This commit was uploaded using the Gerrit Patch Uploader [1]." [core] - 10https://gerrit.wikimedia.org/r/125328 (owner: 10Gerrit Patch Uploader) [09:07:41] (03CR) 10jenkins-bot: [V: 04-1] Apply coding conventions for whitespaces [core] - 10https://gerrit.wikimedia.org/r/125328 (owner: 10Gerrit Patch Uploader) [09:07:43] (03CR) 10Odder: "I have no intention of modifying anything else with this patch; as I said before, I'm trying to do one thing at a time. Please submit your" [core] - 10https://gerrit.wikimedia.org/r/124475 (owner: 10Odder) [09:13:15] (03PS4) 10Kushal124: [WIP]Make review setting configurable [wikimedia/wikimania-scholarships] - 10https://gerrit.wikimedia.org/r/125372 [09:15:17] (03PS5) 10Kushal124: [WIP]Make review setting configurable [wikimedia/wikimania-scholarships] - 10https://gerrit.wikimedia.org/r/125372 [09:18:03] (03CR) 10Kushal124: "@Bryan Made changes as suggested." (031 comment) [wikimedia/wikimania-scholarships] - 10https://gerrit.wikimedia.org/r/125372 (owner: 10Kushal124) [09:19:57] (03PS3) 10Gerrit Patch Uploader: Exclude user interface elements in content from selection [core] - 10https://gerrit.wikimedia.org/r/110186 [09:19:59] (03CR) 10Gerrit Patch Uploader: "This commit was uploaded using the Gerrit Patch Uploader [1]." [core] - 10https://gerrit.wikimedia.org/r/110186 (owner: 10Gerrit Patch Uploader) [09:26:49] (03PS5) 10Gerrit Patch Uploader: wpSummaryLabel and wpSummary in one line with full width [core] - 10https://gerrit.wikimedia.org/r/118246 [09:26:51] (03CR) 10Gerrit Patch Uploader: "This commit was uploaded using the Gerrit Patch Uploader [1]." [core] - 10https://gerrit.wikimedia.org/r/118246 (owner: 10Gerrit Patch Uploader) [09:27:43] (03CR) 10Matthias Mullie: [C: 04-1] Add rev_type to lastRevCache key (031 comment) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/123144 (owner: 10Bsitu) [09:35:38] (03CR) 10Odder: Revert font stack to be just sans-serif (032 comments) [core] - 10https://gerrit.wikimedia.org/r/124475 (owner: 10Odder) [09:44:50] (03CR) 10Matthias Mullie: "Just some quick notes, haven't done thorough review yet" (034 comments) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/121855 (owner: 10EBernhardson) [09:46:33] (03PS2) 10Adrian Lang: Correct CompletenessTest::walkTheObject behaviour wrt breadcrumb [core] - 10https://gerrit.wikimedia.org/r/121604 [10:00:50] (03PS2) 10Gerrit Patch Uploader: Remove #bodyContent { width: 100%; } [core] - 10https://gerrit.wikimedia.org/r/120528 [10:00:52] (03CR) 10Gerrit Patch Uploader: "This commit was uploaded using the Gerrit Patch Uploader [1]." [core] - 10https://gerrit.wikimedia.org/r/120528 (owner: 10Gerrit Patch Uploader) [10:04:09] (03CR) 10Nemo bis: Revert font stack to be just sans-serif (031 comment) [core] - 10https://gerrit.wikimedia.org/r/124475 (owner: 10Odder) [10:06:36] (03CR) 10Matthias Mullie: "This is still WIP. The patch should work already, but I have not thoroughly tested it, there's undoubtedly some things to be cleaned up, a" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/125228 (owner: 10Matthias Mullie) [10:07:01] (03PS7) 10Phuedx: Delete the post-edit cookie using the correct domain [core] - 10https://gerrit.wikimedia.org/r/122423 [10:07:03] (03PS11) 10Phuedx: Add the mw.cookie module [core] - 10https://gerrit.wikimedia.org/r/120806 [10:12:37] (03PS1) 10Zfilipin: Cucumber should only run tests tagged both @clean and @firefox or @phantomjs [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/125386 [10:13:09] (03PS2) 10Zfilipin: Cucumber should only run tests tagged both @clean and @firefox or @phantomjs [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/125386 [10:13:26] (03CR) 10jenkins-bot: [V: 04-1] Add the mw.cookie module [core] - 10https://gerrit.wikimedia.org/r/120806 (owner: 10Phuedx) [10:15:28] (03CR) 10jenkins-bot: [V: 04-1] Delete the post-edit cookie using the correct domain [core] - 10https://gerrit.wikimedia.org/r/122423 (owner: 10Phuedx) [10:17:04] (03PS1) 10Pginer: Grid system for mediawiki.ui [core] - 10https://gerrit.wikimedia.org/r/125387 [10:18:20] (03PS3) 10Zfilipin: Cucumber should only run tests tagged both @clean and @firefox or @phantomjs [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/125386 [10:18:45] (03PS4) 10Zfilipin: Cucumber should only run tests tagged both @clean and (@firefox or @phantomjs) [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/125386 [10:21:44] (03CR) 10Siebrand: Grid system for mediawiki.ui (031 comment) [core] - 10https://gerrit.wikimedia.org/r/125387 (owner: 10Pginer) [10:22:16] (03PS1) 10Daniel Kinzler: Changing a message's lang must reset cached text. [core] - 10https://gerrit.wikimedia.org/r/125388 [10:22:19] (03CR) 10KartikMistry: Grid system for mediawiki.ui (032 comments) [core] - 10https://gerrit.wikimedia.org/r/125387 (owner: 10Pginer) [10:26:53] (03PS2) 10Pginer: Grid system for mediawiki.ui [core] - 10https://gerrit.wikimedia.org/r/125387 [10:58:45] (03PS8) 10Phuedx: Delete the post-edit cookie using the correct domain [core] - 10https://gerrit.wikimedia.org/r/122423 [10:58:47] (03PS12) 10Phuedx: Add the mw.cookie module [core] - 10https://gerrit.wikimedia.org/r/120806 [11:00:16] (03PS1) 10Aude: Add method to get EnhancedChanges cache grouping key [core] - 10https://gerrit.wikimedia.org/r/125391 [11:06:02] (03CR) 10Nikerabbit: [C: 04-1] "Please fix inContentLanguage as well." [core] - 10https://gerrit.wikimedia.org/r/125388 (owner: 10Daniel Kinzler) [11:28:25] (03PS2) 10Hashar: Add checks for WikiForum extension [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/124731 (owner: 10Addshore) [11:28:38] (03CR) 10Hashar: [C: 032] Add checks for WikiForum extension [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/124731 (owner: 10Addshore) [11:29:24] (03Merged) 10jenkins-bot: Add checks for WikiForum extension [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/124731 (owner: 10Addshore) [11:30:14] (03PS3) 10Hashar: Add trigger for WikiForum checks [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/124732 (owner: 10Addshore) [11:35:57] (03PS1) 10Prtksxna: Replace animiationend with setTimeout [extensions/Popups] - 10https://gerrit.wikimedia.org/r/125392 [11:36:09] (03PS4) 10Hashar: Add trigger for WikiForum checks [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/124732 (owner: 10Addshore) [11:37:51] (03CR) 10Hashar: [C: 032] Add trigger for WikiForum checks [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/124732 (owner: 10Addshore) [11:38:01] (03Merged) 10jenkins-bot: Add trigger for WikiForum checks [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/124732 (owner: 10Addshore) [11:38:54] (03CR) 10Hashar: "deployed" [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/124732 (owner: 10Addshore) [11:39:14] (03CR) 10Prtksxna: "This is a quick fix for IE9" [extensions/Popups] - 10https://gerrit.wikimedia.org/r/125392 (owner: 10Prtksxna) [11:50:20] (03CR) 10Nikerabbit: "The longest unchanging parts are "{{fullurl:Special:UserLogin/signup|returnto={{FULLPAGENAMEE}}" which can be supplied as $-type variable" [core] - 10https://gerrit.wikimedia.org/r/83662 (owner: 10Jforrester) [11:50:32] (03CR) 10Addshore: "zuul / jenkins seems to have got stuck" [core] - 10https://gerrit.wikimedia.org/r/125330 (owner: 10Siebrand) [11:50:36] (03PS2) 10Addshore: Fix typo in comment [core] - 10https://gerrit.wikimedia.org/r/125330 (owner: 10Siebrand) [11:50:40] (03CR) 10Addshore: [C: 032] Fix typo in comment [core] - 10https://gerrit.wikimedia.org/r/125330 (owner: 10Siebrand) [11:51:41] (03CR) 10Mwjames: Add NavbarHorizontalTest (031 comment) [skins/chameleon] - 10https://gerrit.wikimedia.org/r/125363 (owner: 10Mwjames) [11:53:59] (03CR) 10Bartosz Dziewoński: [C: 04-1] Make .mw-ui-button height the same for all buttons (031 comment) [core] - 10https://gerrit.wikimedia.org/r/117107 (owner: 10JGonera) [12:17:52] (03CR) 10Hashar: [C: 032] "Yes that should be enough :-] Deploying." [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/125344 (owner: 10AndyRussG) [12:18:09] (03PS2) 10Hashar: Trigger unit tests for the Campaigns extension [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/125344 (owner: 10AndyRussG) [12:18:17] (03CR) 10Hashar: [C: 032] Trigger unit tests for the Campaigns extension [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/125344 (owner: 10AndyRussG) [12:18:27] (03Merged) 10jenkins-bot: Trigger unit tests for the Campaigns extension [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/125344 (owner: 10AndyRussG) [12:19:17] (03Restored) 10Hashar: Jenkins job validation (DO NOT SUBMIT) [extensions/Campaigns] - 10https://gerrit.wikimedia.org/r/70381 (owner: 10Hashar) [12:19:22] (03PS2) 10Hashar: Jenkins job validation (DO NOT SUBMIT) [extensions/Campaigns] - 10https://gerrit.wikimedia.org/r/70381 [12:21:16] (03CR) 10Hashar: "Tests are passing. I created the dummy change https://gerrit.wikimedia.org/r/#/c/70381/ which triggered the successful job https://integra" [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/125344 (owner: 10AndyRussG) [12:21:19] (03CR) 10jenkins-bot: [V: 04-1] Add the mw.cookie module [core] - 10https://gerrit.wikimedia.org/r/120806 (owner: 10Phuedx) [12:21:21] (03CR) 10jenkins-bot: [V: 04-1] Moved "Date format" user preference to "Appearence" tab [core] - 10https://gerrit.wikimedia.org/r/125370 (owner: 1001tonythomas) [12:21:27] (03Abandoned) 10Hashar: Jenkins job validation (DO NOT SUBMIT) [extensions/Campaigns] - 10https://gerrit.wikimedia.org/r/70381 (owner: 10Hashar) [12:37:26] (03Abandoned) 10Aude: (bug 43506) Fix pager in Special:Categories, make offset default param [core] - 10https://gerrit.wikimedia.org/r/41215 (owner: 10Aude) [12:38:48] (03CR) 10Aude: "typo" (031 comment) [core] - 10https://gerrit.wikimedia.org/r/125370 (owner: 1001tonythomas) [12:39:01] (03PS1) 10Hashar: Make mwext-InputBox-jslint voting [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/125393 [12:39:21] (03CR) 10Hashar: [C: 032] Make mwext-InputBox-jslint voting [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/125393 (owner: 10Hashar) [12:39:31] (03Merged) 10jenkins-bot: Make mwext-InputBox-jslint voting [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/125393 (owner: 10Hashar) [12:42:05] Krinkle|detached: [12:42:29] jslint for core broke due to the es3 option [12:43:46] (03PS1) 10Manybubbles: send_some improvements [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/125394 [12:44:17] it's just an informational message that is emitted, but informationals cannot be ignored i think and neither is jenkins ignoreing them. [12:47:47] (03PS2) 10Manybubbles: send_some improvements [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/125394 [12:49:43] (03CR) 10Manybubbles: "After this fix I reran it. 50% of enwiki's traffic pushed us to 45% load. Obviously not good enough but much better then before." [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/125394 (owner: 10Manybubbles) [12:53:22] thedj: I filed it yesterday https://bugzilla.wikimedia.org/show_bug.cgi?id=63805 [12:53:54] Nemo_bis: yeah, i think we might have to revert. i'm updating the ticket [12:54:16] oh wait, no. found a cure [12:54:20] (03PS1) 10Manybubbles: Prefer title for prefix search match [extensions/CirrusSearch] (wmf/1.23wmf21) - 10https://gerrit.wikimedia.org/r/125395 [12:54:49] (03PS1) 10Manybubbles: Add support for the experimental highlighter [extensions/CirrusSearch] (wmf/1.23wmf21) - 10https://gerrit.wikimedia.org/r/125396 [12:58:47] (03PS1) 10TheDJ: Switch a few test cases back into es5 mode [core] - 10https://gerrit.wikimedia.org/r/125397 [13:03:40] (03PS2) 10TheDJ: Switch a few test cases back into es5 mode [core] - 10https://gerrit.wikimedia.org/r/125397 [13:04:57] someone wanna review that and unbreak core ? ^^^^ [13:09:55] (03PS3) 10Bartosz Dziewoński: Moved "Date format" user preference to "Appearance" tab [core] - 10https://gerrit.wikimedia.org/r/125370 (owner: 1001tonythomas) [13:10:07] (03CR) 10Bartosz Dziewoński: [C: 032 V: 032] "Per Siebrand." [core] - 10https://gerrit.wikimedia.org/r/125370 (owner: 1001tonythomas) [13:28:58] (03Draft1) 10Addshore: Add extension composer-install bash script [integration/jenkins] - 10https://gerrit.wikimedia.org/r/125041 [13:29:03] (03PS2) 10Addshore: Add extension composer-install bash script [integration/jenkins] - 10https://gerrit.wikimedia.org/r/125041 [13:29:09] (03CR) 10Addshore: "This is untested" [integration/jenkins] - 10https://gerrit.wikimedia.org/r/125041 (owner: 10Addshore) [13:29:12] (03Draft3) 10Addshore: Add composer-install-extensions builder [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/125042 [13:29:16] (03PS4) 10Addshore: Add composer-install-extensions builder [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/125042 [13:29:20] (03CR) 10Addshore: "This is untested" [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/125042 (owner: 10Addshore) [13:41:34] (03PS1) 10Zfilipin: Releasing patch version 0.1.2 [ruby/api] - 10https://gerrit.wikimedia.org/r/125398 [13:41:47] (03CR) 10Umherirrender: "replay to inline comments" (033 comments) [core] - 10https://gerrit.wikimedia.org/r/125253 (owner: 10Umherirrender) [13:42:01] (03CR) 10Zfilipin: [C: 032] Releasing patch version 0.1.2 [ruby/api] - 10https://gerrit.wikimedia.org/r/125398 (owner: 10Zfilipin) [13:42:03] (03Merged) 10jenkins-bot: Releasing patch version 0.1.2 [ruby/api] - 10https://gerrit.wikimedia.org/r/125398 (owner: 10Zfilipin) [13:50:03] (03CR) 10Chad: Add a max offset parameter (031 comment) [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/125364 (owner: 10Manybubbles) [13:52:09] (03PS3) 10Manybubbles: Faster, more stable browser tests [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/124385 [13:53:40] (03CR) 10Manybubbles: Faster, more stable browser tests [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/124385 (owner: 10Manybubbles) [14:18:56] (03PS1) 10Dan-nl: wfStripIllegalFilenameChars truncates title [extensions/GWToolset] - 10https://gerrit.wikimedia.org/r/125401 [14:35:53] (03CR) 10Chad: [C: 032] Prefer title for prefix search match [extensions/CirrusSearch] (wmf/1.23wmf21) - 10https://gerrit.wikimedia.org/r/125395 (owner: 10Manybubbles) [14:36:03] (03Merged) 10jenkins-bot: Prefer title for prefix search match [extensions/CirrusSearch] (wmf/1.23wmf21) - 10https://gerrit.wikimedia.org/r/125395 (owner: 10Manybubbles) [14:37:35] (03CR) 10Chad: [C: 032] Add support for the experimental highlighter [extensions/CirrusSearch] (wmf/1.23wmf21) - 10https://gerrit.wikimedia.org/r/125396 (owner: 10Manybubbles) [14:37:44] (03Merged) 10jenkins-bot: Add support for the experimental highlighter [extensions/CirrusSearch] (wmf/1.23wmf21) - 10https://gerrit.wikimedia.org/r/125396 (owner: 10Manybubbles) [14:38:01] (03CR) 10Shirayuki: "Wow!" [core] - 10https://gerrit.wikimedia.org/r/125050 (owner: 10Jforrester) [14:39:18] (03CR) 10Chad: [C: 032] Faster, more stable browser tests [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/124385 (owner: 10Manybubbles) [14:39:26] (03Merged) 10jenkins-bot: Faster, more stable browser tests [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/124385 (owner: 10Manybubbles) [14:44:16] (03CR) 10Anomie: [C: 04-1] "Good catch! But neither of those make a whole lot of sense, really. The intention here is to turn "

foo

" into "foo", but neither tra" [core] - 10https://gerrit.wikimedia.org/r/114942 (owner: 10Bartosz Dziewoński) [14:49:21] (03PS10) 10Anomie: HTMLForm: Add "cloner" type [core] - 10https://gerrit.wikimedia.org/r/118113 [14:49:23] (03PS9) 10Anomie: Release notes for recent HTMLForm changes [core] - 10https://gerrit.wikimedia.org/r/118114 [14:49:25] (03PS7) 10Anomie: HTMLForm: Add hide-if [core] - 10https://gerrit.wikimedia.org/r/118110 [14:54:10] (03PS3) 10Anomie: API: Make more continuations unique [core] - 10https://gerrit.wikimedia.org/r/103589 [14:54:24] (03CR) 10Anomie: "PS3: Rebase" [core] - 10https://gerrit.wikimedia.org/r/103589 (owner: 10Anomie) [14:55:10] (03PS3) 10Pginer: Grid system for mediawiki.ui [core] - 10https://gerrit.wikimedia.org/r/125387 [14:58:31] (03PS5) 10Anomie: Commit DB changes as normal on exception-based GUI errors [core] - 10https://gerrit.wikimedia.org/r/116625 (owner: 10Aaron Schulz) [15:00:26] (03CR) 10Anomie: [C: 031] "Code looks like it'll work, haven't tested." [core] - 10https://gerrit.wikimedia.org/r/116625 (owner: 10Aaron Schulz) [15:08:58] (03PS1) 10Hashar: qa/browsertests Gemfile has been moved [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/125405 [15:09:19] (03PS2) 10Hashar: qa/browsertests Gemfile has been moved [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/125405 [15:11:28] (03PS5) 10Zfilipin: Cucumber should only run tests tagged both @clean and (@firefox or @phantomjs) [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/125386 [15:18:49] (03PS3) 10Hashar: qa/browsertests Gemfile has been moved [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/125405 [15:27:58] (03PS4) 10Hashar: qa/browsertests Gemfile has been moved [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/125405 [15:29:49] (03CR) 10Hashar: [C: 032] "Confirmed it fix the postmerge and build jobs." [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/125405 (owner: 10Hashar) [15:30:30] (03Merged) 10jenkins-bot: qa/browsertests Gemfile has been moved [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/125405 (owner: 10Hashar) [15:38:22] (03PS1) 10Manybubbles: Small docs fix [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/125409 [15:48:50] (03PS1) 10Hashar: browsertests: bundle install gems in shared dir [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/125411 [15:49:27] (03CR) 10Hashar: "For the browsertests-qa-* jobs that is done by follow up https://gerrit.wikimedia.org/r/#/c/125411/" [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/112682 (owner: 10Hashar) [15:49:56] (03CR) 10Hashar: "Will look at that on monday evening. Too late to play with that on a friday night :]" [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/125411 (owner: 10Hashar) [15:51:29] (03CR) 10Manybubbles: [C: 032] browsertests: bundle install gems in shared dir [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/125411 (owner: 10Hashar) [15:51:45] (03CR) 10Hashar: "Added myself as a reviewer as a reminder. Might look at it next Tuesday." [core] - 10https://gerrit.wikimedia.org/r/102475 (owner: 10Tpt) [15:52:11] (03Merged) 10jenkins-bot: browsertests: bundle install gems in shared dir [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/125411 (owner: 10Hashar) [16:02:16] (03CR) 10Kipcool: [C: 032 V: 032] "I also didn't have time ;)" [extensions/WikiLexicalData] - 10https://gerrit.wikimedia.org/r/125371 (owner: 10Hiong3-eng5) [16:27:56] (03CR) 10Chad: [C: 032 V: 032] Small docs fix [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/125409 (owner: 10Manybubbles) [16:28:18] (03CR) 10Chad: [C: 032] Strip citation links (like [1], [2], etc) from HTML [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/123878 (owner: 10Chad) [16:28:27] (03Merged) 10jenkins-bot: Strip citation links (like [1], [2], etc) from HTML [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/123878 (owner: 10Chad) [16:29:13] (03CR) 10Chad: [C: 032] send_some improvements [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/125394 (owner: 10Manybubbles) [16:29:21] (03Merged) 10jenkins-bot: send_some improvements [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/125394 (owner: 10Manybubbles) [16:57:48] Hey I am working on this patch that uses mediawiki api "users" I am sending the ususers as the username entered. The usersignup and account creation js page has a similar scenario [16:58:50] and it does two checks on the returned object . the returned object.invalid != undefined and returned object.userid != undefined. [16:59:10] Both seem identical to me.. could some one tell me the difference between these two conditions ? [16:59:37] I mean I am confused what does the invalid part stand for ? [17:02:51] (03PS3) 10Krinkle: IEFixes: Clean up duplicate variables [core] - 10https://gerrit.wikimedia.org/r/125249 [17:03:00] (03PS4) 10Krinkle: IEFixes.js: Remove relativeforfloats() as it doesn't work [core] - 10https://gerrit.wikimedia.org/r/125250 [17:04:47] (03CR) 10Krinkle: [C: 04-1] "Good in general, but a bit confusing atm." (031 comment) [core] - 10https://gerrit.wikimedia.org/r/125397 (owner: 10TheDJ) [17:05:07] (03PS3) 10Krinkle: Switch a few test cases back into es5 mode [core] - 10https://gerrit.wikimedia.org/r/125397 (owner: 10TheDJ) [17:06:07] (03CR) 10SirComputer: [C: 031] "I think it all looks good, and it's been quite a while since a response was given on this." [core] - 10https://gerrit.wikimedia.org/r/111532 (owner: 10UltrasonicNXT) [17:06:55] (03CR) 10jenkins-bot: [V: 04-1] API: Make more continuations unique [core] - 10https://gerrit.wikimedia.org/r/103589 (owner: 10Anomie) [17:07:46] Hey could some one tell me what the invalid member stands for in the object returned by query to users mediawiki API ? Like when is it defined and when is it undefined ? [17:10:34] Come one people some one respond !! Even the api guide to users API doesn't state anything about this !! [17:12:38] (03PS2) 10EBernhardson: Strip extended handlebars comments [extensions/Flow] (frontend-rewrite) - 10https://gerrit.wikimedia.org/r/125353 [17:14:44] (03CR) 10jenkins-bot: [V: 04-1] IEFixes: Clean up duplicate variables [core] - 10https://gerrit.wikimedia.org/r/125249 (owner: 10Krinkle) [17:15:49] (03PS6) 10Krinkle: Rework mediawiki.feedback.js [core] - 10https://gerrit.wikimedia.org/r/105457 (owner: 10Gerrit Patch Uploader) [17:22:34] (03PS1) 10Umherirrender: Add jquery.accessKeyLabel javascript module [core] - 10https://gerrit.wikimedia.org/r/125426 [17:27:18] (03CR) 10Krinkle: "recheck" [core] - 10https://gerrit.wikimedia.org/r/105457 (owner: 10Gerrit Patch Uploader) [17:28:22] (03CR) 10jenkins-bot: [V: 04-1] Add jquery.accessKeyLabel javascript module [core] - 10https://gerrit.wikimedia.org/r/125426 (owner: 10Umherirrender) [17:28:24] (03CR) 10jenkins-bot: [V: 04-1] Rework mediawiki.feedback.js [core] - 10https://gerrit.wikimedia.org/r/105457 (owner: 10Gerrit Patch Uploader) [17:32:12] greg-g, hi? [17:35:11] greg-g, nevermind :) [17:36:47] (03CR) 10Krinkle: [C: 04-1] "Initial -1 for code conventions, and documentation syntax seems made up (doesn't parse in jsduck)." (037 comments) [core] - 10https://gerrit.wikimedia.org/r/125426 (owner: 10Umherirrender) [17:36:57] (03CR) 10Krinkle: "recheck" [core] - 10https://gerrit.wikimedia.org/r/125426 (owner: 10Umherirrender) [17:39:16] (03PS7) 10Ori.livneh: ResourceLoader::makeLoaderImplementScript: Bind args as '$' and 'jQuery' [core] - 10https://gerrit.wikimedia.org/r/117672 [17:39:51] (03CR) 10Ori.livneh: "It's been thirty days now since I0c9edac35 has been merged, so this is good to go." [core] - 10https://gerrit.wikimedia.org/r/117672 (owner: 10Ori.livneh) [17:40:11] (03CR) 10jenkins-bot: [V: 04-1] ResourceLoader::makeLoaderImplementScript: Bind args as '$' and 'jQuery' [core] - 10https://gerrit.wikimedia.org/r/117672 (owner: 10Ori.livneh) [17:40:27] (03PS8) 10Ori.livneh: ResourceLoader::makeLoaderImplementScript: Bind args as '$' and 'jQuery' [core] - 10https://gerrit.wikimedia.org/r/117672 [17:42:06] (03CR) 10Krinkle: "recheck" [core] - 10https://gerrit.wikimedia.org/r/105457 (owner: 10Gerrit Patch Uploader) [17:43:46] (03CR) 10Martineznovo: Avoid making a derivative request to Special:RunJobs when the job queue is empty (031 comment) [core] - 10https://gerrit.wikimedia.org/r/124629 (owner: 10Aaron Schulz) [17:46:02] (03CR) 10jenkins-bot: [V: 04-1] ResourceLoader::makeLoaderImplementScript: Bind args as '$' and 'jQuery' [core] - 10https://gerrit.wikimedia.org/r/117672 (owner: 10Ori.livneh) [17:46:16] (03CR) 10Jforrester: "@Nikerabbit: I think adding $1s adds unnecessary complexity." [core] - 10https://gerrit.wikimedia.org/r/83662 (owner: 10Jforrester) [17:46:50] Krinkle: 17:42:10 Fatal error: Unable to find local grunt. ? [17:51:29] ori_: Link? [17:51:40] (03PS2) 10Umherirrender: Add jquery.accessKeyLabel javascript module [core] - 10https://gerrit.wikimedia.org/r/125426 [17:51:44] Krinkle: https://integration.wikimedia.org/ci/job/mediawiki-core-qunit/19083/console [17:51:47] Krinkle: https://integration.wikimedia.org/ci/job/mediawiki-core-qunit/19083/console [17:51:49] that [17:52:05] (03CR) 10Umherirrender: "Patch Set 2: Fixed spacing, add suppressWarnings/restoreWarnings calls and addressed inline comments" (037 comments) [core] - 10https://gerrit.wikimedia.org/r/125426 (owner: 10Umherirrender) [17:52:20] ori_: Right, grunt-cli must've made a breaking change without fucking documenting it [17:52:24] I upgraded that to fix a minor bug [17:52:25] crap [17:52:26] On it [17:52:58] Only affects jobs using wmfgrunt without local npm (e.g. only the mw-qunit jobs) [17:53:08] (03CR) 10Jforrester: "@Shirayuki: Suggestions (or patches!) welcome – https://github.com/jdforrester/grunt-banana-checker etc. Things I've thought of adding inc" [core] - 10https://gerrit.wikimedia.org/r/125050 (owner: 10Jforrester) [17:57:17] (03CR) 10jenkins-bot: [V: 04-1] Add jquery.accessKeyLabel javascript module [core] - 10https://gerrit.wikimedia.org/r/125426 (owner: 10Umherirrender) [17:57:38] (03CR) 10Nikerabbit: "It doesn't add complexity. Just moves it around. I prefer that the complexity is in the code rathar than in front of hundreds of translato" [core] - 10https://gerrit.wikimedia.org/r/83662 (owner: 10Jforrester) [17:58:38] (03CR) 10Jforrester: "It binds complexity into the code rather than leaving it to the translators to decide." [core] - 10https://gerrit.wikimedia.org/r/83662 (owner: 10Jforrester) [18:07:13] (03PS1) 10Krinkle: grunt: Make grunt basedir and Gruntfile.js parent dir the same [integration/jenkins] - 10https://gerrit.wikimedia.org/r/125430 [18:07:38] (03CR) 10Krinkle: [C: 032] grunt: Make grunt basedir and Gruntfile.js parent dir the same [integration/jenkins] - 10https://gerrit.wikimedia.org/r/125430 (owner: 10Krinkle) [18:07:41] (03PS2) 10Krinkle: grunt: Make grunt basedir and Gruntfile.js parent dir the same [integration/jenkins] - 10https://gerrit.wikimedia.org/r/125430 [18:07:44] (03CR) 10Krinkle: [C: 032] grunt: Make grunt basedir and Gruntfile.js parent dir the same [integration/jenkins] - 10https://gerrit.wikimedia.org/r/125430 (owner: 10Krinkle) [18:07:47] (03Merged) 10jenkins-bot: grunt: Make grunt basedir and Gruntfile.js parent dir the same [integration/jenkins] - 10https://gerrit.wikimedia.org/r/125430 (owner: 10Krinkle) [18:09:25] (03PS9) 10Krinkle: ResourceLoader::makeLoaderImplementScript: Bind args as '$' and 'jQuery' [core] - 10https://gerrit.wikimedia.org/r/117672 (owner: 10Ori.livneh) [18:12:19] (03CR) 10Krinkle: Add jquery.accessKeyLabel javascript module (032 comments) [core] - 10https://gerrit.wikimedia.org/r/125426 (owner: 10Umherirrender) [18:14:01] (03PS1) 10Krinkle: grunt: Update include paths [integration/jenkins] - 10https://gerrit.wikimedia.org/r/125432 [18:14:09] (03CR) 10Krinkle: [C: 032] grunt: Update include paths [integration/jenkins] - 10https://gerrit.wikimedia.org/r/125432 (owner: 10Krinkle) [18:14:13] (03Merged) 10jenkins-bot: grunt: Update include paths [integration/jenkins] - 10https://gerrit.wikimedia.org/r/125432 (owner: 10Krinkle) [18:15:04] (03CR) 10MarkAHershberger: "@krinkle, I don't expect you to write it, but since you have more experience in this area, could you point to an example of this so that " [extensions/LiquidThreads] - 10https://gerrit.wikimedia.org/r/123836 (owner: 10Adi.iiita) [18:15:14] (03PS10) 10Krinkle: ResourceLoader::makeLoaderImplementScript: Bind args as '$' and 'jQuery' [core] - 10https://gerrit.wikimedia.org/r/117672 (owner: 10Ori.livneh) [18:17:15] (03PS3) 10Bsitu: Add rev_type to lastRevCache key [extensions/Flow] - 10https://gerrit.wikimedia.org/r/123144 [18:17:50] (03CR) 10Krinkle: "This is basic event handling and DOM manipulation (event.preventDefault(), event.stopPropagation(), and inputElement.disabled = true. Any " [extensions/LiquidThreads] - 10https://gerrit.wikimedia.org/r/123836 (owner: 10Adi.iiita) [18:20:38] (03PS4) 10Krinkle: IEFixes: Clean up duplicate variables [core] - 10https://gerrit.wikimedia.org/r/125249 [18:20:47] (03PS5) 10Krinkle: IEFixes.js: Remove relativeforfloats() as it doesn't work [core] - 10https://gerrit.wikimedia.org/r/125250 [18:20:57] (03PS6) 10Krinkle: IEFixes: Remove relativeforfloats() as it doesn't work [core] - 10https://gerrit.wikimedia.org/r/125250 [18:22:31] (03PS3) 10Umherirrender: Add jquery.accessKeyLabel javascript module [core] - 10https://gerrit.wikimedia.org/r/125426 [18:23:20] (03CR) 10Umherirrender: "Patch Set 3: Addressed inline comments" (032 comments) [core] - 10https://gerrit.wikimedia.org/r/125426 (owner: 10Umherirrender) [18:24:10] (03CR) 10Aaron Schulz: [C: 04-1] API: Make more continuations unique (031 comment) [core] - 10https://gerrit.wikimedia.org/r/103589 (owner: 10Anomie) [18:25:04] (03CR) 10Aaron Schulz: [C: 032] API: Make more continuations unique (031 comment) [core] - 10https://gerrit.wikimedia.org/r/103589 (owner: 10Anomie) [18:26:38] (03PS2) 10Ori.livneh: Avoid making cycles which leak in HHVM [extensions/FlaggedRevs] - 10https://gerrit.wikimedia.org/r/125361 (owner: 10Aaron Schulz) [18:26:45] (03CR) 10Ori.livneh: [C: 032] Avoid making cycles which leak in HHVM [extensions/FlaggedRevs] - 10https://gerrit.wikimedia.org/r/125361 (owner: 10Aaron Schulz) [18:26:59] (03Merged) 10jenkins-bot: Avoid making cycles which leak in HHVM [extensions/FlaggedRevs] - 10https://gerrit.wikimedia.org/r/125361 (owner: 10Aaron Schulz) [18:29:18] (03Merged) 10jenkins-bot: API: Make more continuations unique [core] - 10https://gerrit.wikimedia.org/r/103589 (owner: 10Anomie) [18:30:25] (03CR) 10jenkins-bot: [V: 04-1] IEFixes: Remove relativeforfloats() as it doesn't work [core] - 10https://gerrit.wikimedia.org/r/125250 (owner: 10Krinkle) [18:30:37] (03CR) 10Aaron Schulz: [C: 04-1] "Needs rebase as well :)" [core] - 10https://gerrit.wikimedia.org/r/111954 (owner: 10Anomie) [18:31:26] (03CR) 10jenkins-bot: [V: 04-1] Add jquery.accessKeyLabel javascript module [core] - 10https://gerrit.wikimedia.org/r/125426 (owner: 10Umherirrender) [18:32:56] (03PS7) 10Krinkle: IEFixes: Remove relativeforfloats() as it doesn't work [core] - 10https://gerrit.wikimedia.org/r/125250 [18:37:14] (03CR) 10EBernhardson: [C: 032] "No new code, straight vendor import." [extensions/Flow] (frontend-rewrite) - 10https://gerrit.wikimedia.org/r/125349 (owner: 10EBernhardson) [18:37:51] (03Merged) 10jenkins-bot: Include LightnCandy vendor files [extensions/Flow] (frontend-rewrite) - 10https://gerrit.wikimedia.org/r/125349 (owner: 10EBernhardson) [18:40:58] (03PS1) 10Krinkle: qunit: Remove race condition in 'test.mediawiki.qunit.testrunner' [core] - 10https://gerrit.wikimedia.org/r/125434 [18:41:08] (03PS1) 10Aaron Schulz: Revert "Work around HHVM bug with stdin/stdout in proc_open()" [core] - 10https://gerrit.wikimedia.org/r/125435 [18:41:23] (03CR) 10Bartosz Dziewoński: "I've read the entire wikitech-l thread (89 emails as of writing) and pondered this carefully. My summary of the situation is:" [core] - 10https://gerrit.wikimedia.org/r/124475 (owner: 10Odder) [18:41:36] (03CR) 10Umherirrender: "jenkins failure is bug 63579" [core] - 10https://gerrit.wikimedia.org/r/125426 (owner: 10Umherirrender) [18:41:48] (03CR) 10Bartosz Dziewoński: [C: 032 V: 032] Revert font stack to be just sans-serif [core] - 10https://gerrit.wikimedia.org/r/124475 (owner: 10Odder) [18:42:05] (03PS13) 10Krinkle: Add the mw.cookie module [core] - 10https://gerrit.wikimedia.org/r/120806 (owner: 10Phuedx) [18:42:33] (03CR) 10Krinkle: "Excuse the build failures. QUnit testing is under maintenance and not going as planned." [core] - 10https://gerrit.wikimedia.org/r/120806 (owner: 10Phuedx) [18:45:44] (03PS1) 10IAlex: Improve UDP logging code [core] - 10https://gerrit.wikimedia.org/r/125436 [18:46:03] (03PS2) 10IAlex: Improve UDP logging code [core] - 10https://gerrit.wikimedia.org/r/125436 [18:49:48] (03CR) 10Swalling: "Bartosz: thanks for the considered, factual take on the matter. I appreciate you taking the time to read up on everything." [core] - 10https://gerrit.wikimedia.org/r/124475 (owner: 10Odder) [18:53:29] (03PS1) 10Krinkle: Lower defaut timeout from 360 minutes to 30 minutes [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/125438 [18:58:30] (03CR) 10SG: [C: 032] Add @root special variable to access root scope [extensions/Flow] (frontend-rewrite) - 10https://gerrit.wikimedia.org/r/125356 (owner: 10EBernhardson) [18:58:54] (03Merged) 10jenkins-bot: Add @root special variable to access root scope [extensions/Flow] (frontend-rewrite) - 10https://gerrit.wikimedia.org/r/125356 (owner: 10EBernhardson) [19:04:26] (03CR) 10Eloquence: "The commit message is still inaccurate, since the changeset only touches the body fonts (which were sans serif fonts, just explicitly spec" [core] - 10https://gerrit.wikimedia.org/r/124475 (owner: 10Odder) [19:06:06] (03CR) 10Jforrester: [C: 032] IEFixes: Clean up duplicate variables [core] - 10https://gerrit.wikimedia.org/r/125249 (owner: 10Krinkle) [19:09:35] (03CR) 10jenkins-bot: [V: 04-1] IEFixes: Clean up duplicate variables [core] - 10https://gerrit.wikimedia.org/r/125249 (owner: 10Krinkle) [19:10:31] (03CR) 10BryanDavis: "A couple of trivial comments inline. I'm looking forward to seeing the next steps for this." (032 comments) [wikimedia/wikimania-scholarships] - 10https://gerrit.wikimedia.org/r/125372 (owner: 10Kushal124) [19:10:34] (03CR) 10Krinkle: [C: 032] "Pushed 'mediawiki-core-qunit'" [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/125438 (owner: 10Krinkle) [19:10:39] (03CR) 10Krinkle: "Pushed 'analytics-kraken'." [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/125438 (owner: 10Krinkle) [19:11:18] (03Merged) 10jenkins-bot: Lower defaut timeout from 360 minutes to 30 minutes [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/125438 (owner: 10Krinkle) [19:11:58] (03PS2) 10Krinkle: (DRAFT) Hotfix: grunt-lib-phantomjs Date mockery protection [integration/jenkins] - 10https://gerrit.wikimedia.org/r/125039 [19:12:03] (03Abandoned) 10Krinkle: (DRAFT) Hotfix: grunt-lib-phantomjs Date mockery protection [integration/jenkins] - 10https://gerrit.wikimedia.org/r/125039 (owner: 10Krinkle) [19:13:06] (03CR) 10Hashar: "The beta jobs are updated as well, I dont think any of them ever hit 30 minutes." [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/125438 (owner: 10Krinkle) [19:13:37] (03PS1) 10MarkAHershberger: Provide RequestContext from fixDoubleRedirects [core] (REL1_19) - 10https://gerrit.wikimedia.org/r/125445 [19:13:44] (03CR) 10Jforrester: [C: 032] IEFixes: Clean up duplicate variables [core] - 10https://gerrit.wikimedia.org/r/125249 (owner: 10Krinkle) [19:14:19] (03PS1) 10MarkAHershberger: Provide RequestContext from fixDoubleRedirects [core] (REL1_22) - 10https://gerrit.wikimedia.org/r/125446 [19:14:28] (03CR) 10Hashar: "Oh and to have Jenkins Job Builder to run in parallel you can give a try at https://review.openstack.org/#/c/75514/ Then use --threads=0" [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/125438 (owner: 10Krinkle) [19:15:00] (03PS1) 10Bartosz Dziewoński: Revert font stack to be just sans-serif [core] (wmf/1.23wmf22) - 10https://gerrit.wikimedia.org/r/125447 [19:15:03] (03PS1) 10MarkAHershberger: Provide RequestContext from fixDoubleRedirects [core] (REL1_21) - 10https://gerrit.wikimedia.org/r/125448 [19:15:55] (03PS9) 10Krinkle: [WIP] Investigate swinging qunit test failure [core] - 10https://gerrit.wikimedia.org/r/124372 [19:16:43] (03CR) 10Bartosz Dziewoński: "Per Greg and Steven, we probably want to backport this change "one branch back" and then let it roll out with the deployment train." [core] (wmf/1.23wmf22) - 10https://gerrit.wikimedia.org/r/125447 (owner: 10Bartosz Dziewoński) [19:17:44] MatmaRex: Like last week, I'll volunteer to do the SWAT deploy on Monday [19:17:56] I have a number of VE cherry-picks too [19:18:06] RoanKattouw: right, i'll leave this to you and greg :) [19:18:36] (03CR) 10Hashar: "> The commit message is still inaccurate, since the changeset only touches the body fonts (which were sans serif fonts, just explicitly sp" [core] - 10https://gerrit.wikimedia.org/r/124475 (owner: 10Odder) [19:18:55] (03PS3) 10EBernhardson: Convert {#custom}...{/custom} helpers to be more like handlebars-2.0 [extensions/Flow] (frontend-rewrite) - 10https://gerrit.wikimedia.org/r/125355 [19:19:56] MatmaRex: I'm just reminding myself that I need to write up a list of commits before it gets out of control :) [19:20:05] RoanKattouw: thanks man, I'll add it to the calendar now [19:20:15] (03PS2) 10Swalling: Revert body font stack to be just sans-serif [core] (wmf/1.23wmf22) - 10https://gerrit.wikimedia.org/r/125447 (owner: 10Bartosz Dziewoński) [19:20:19] (03Merged) 10jenkins-bot: IEFixes: Clean up duplicate variables [core] - 10https://gerrit.wikimedia.org/r/125249 (owner: 10Krinkle) [19:21:43] (03CR) 10Jforrester: [C: 032] IEFixes: Remove relativeforfloats() as it doesn't work [core] - 10https://gerrit.wikimedia.org/r/125250 (owner: 10Krinkle) [19:21:45] (03CR) 10Bartosz Dziewoński: "This only touches the body text (it's now "sans-serif"); heading text is still using the serif fonts after this change. I didn't want to m" [core] - 10https://gerrit.wikimedia.org/r/124475 (owner: 10Odder) [19:24:25] (03CR) 10Krinkle: "Shouldn't this go into includes/ somewhere?" [core] - 10https://gerrit.wikimedia.org/r/119939 (owner: 10BryanDavis) [19:25:40] greg-g: Oh, you put it in the 8am window [19:25:45] Well in that case I ain't doing it :) [19:25:56] O [19:26:20] I'll still put the VE stuff in the 4pm window and do that window [19:26:34] RoanKattouw: just moved it, that was a mistake :) [19:27:50] Oh hah [19:27:58] I by no means claim ownership of deploying that change [19:28:08] But I guess Bryan might be less comfortable deploying CSS changes than me :) [19:28:08] (03Merged) 10jenkins-bot: IEFixes: Remove relativeforfloats() as it doesn't work [core] - 10https://gerrit.wikimedia.org/r/125250 (owner: 10Krinkle) [19:29:15] (03CR) 10jenkins-bot: [V: 04-1] [WIP] Investigate swinging qunit test failure [core] - 10https://gerrit.wikimedia.org/r/124372 (owner: 10Krinkle) [19:29:46] (03CR) 10Umherirrender: "By the way: The current way does not respect aliases or localised version of NAMESPACE. It is also valid to wrote {{ NAMESPACE }} or to us" [core] - 10https://gerrit.wikimedia.org/r/124784 (owner: 10Brian Wolff) [19:30:37] (03CR) 10Aaron Schulz: [C: 04-1] Improve UDP logging code (032 comments) [core] - 10https://gerrit.wikimedia.org/r/125436 (owner: 10IAlex) [19:32:05] (03PS10) 10Krinkle: [WIP] Investigate swinging qunit test failure [core] - 10https://gerrit.wikimedia.org/r/124372 [19:33:56] (03PS11) 10Krinkle: [WIP] Investigate swinging qunit test failure [core] - 10https://gerrit.wikimedia.org/r/124372 [19:34:38] (03PS12) 10Krinkle: [WIP] Investigate swinging qunit test failure [core] - 10https://gerrit.wikimedia.org/r/124372 [19:35:11] (03Abandoned) 10Jackmcbarn: Allow transcluding Special:Gadgets [extensions/Gadgets] - 10https://gerrit.wikimedia.org/r/97787 (owner: 10Jackmcbarn) [19:35:54] (03PS3) 10Anomie: API: Refactor continuation code and add to purge, watch, etc. [core] - 10https://gerrit.wikimedia.org/r/111954 [19:36:09] (03CR) 10Anomie: "PS3: Rebase" [core] - 10https://gerrit.wikimedia.org/r/111954 (owner: 10Anomie) [19:38:01] (03PS3) 10EBernhardson: Strip extended handlebars comments [extensions/Flow] (frontend-rewrite) - 10https://gerrit.wikimedia.org/r/125353 [19:38:06] (03CR) 10jenkins-bot: [V: 04-1] Strip extended handlebars comments [extensions/Flow] (frontend-rewrite) - 10https://gerrit.wikimedia.org/r/125353 (owner: 10EBernhardson) [19:39:08] (03PS4) 10EBernhardson: Strip extended handlebars comments [extensions/Flow] (frontend-rewrite) - 10https://gerrit.wikimedia.org/r/125353 [19:39:36] (03PS3) 10IAlex: Improve UDP logging code [core] - 10https://gerrit.wikimedia.org/r/125436 [19:39:45] (03PS4) 10IAlex: Improve UDP logging code [core] - 10https://gerrit.wikimedia.org/r/125436 [19:41:01] (03PS5) 10IAlex: Improve UDP logging code [core] - 10https://gerrit.wikimedia.org/r/125436 [19:42:17] (03CR) 10IAlex: Improve UDP logging code (032 comments) [core] - 10https://gerrit.wikimedia.org/r/125436 (owner: 10IAlex) [19:42:48] (03CR) 10SG: [C: 032] Strip extended handlebars comments [extensions/Flow] (frontend-rewrite) - 10https://gerrit.wikimedia.org/r/125353 (owner: 10EBernhardson) [19:43:04] (03Merged) 10jenkins-bot: Strip extended handlebars comments [extensions/Flow] (frontend-rewrite) - 10https://gerrit.wikimedia.org/r/125353 (owner: 10EBernhardson) [19:43:12] (03CR) 10jenkins-bot: [V: 04-1] API: Refactor continuation code and add to purge, watch, etc. [core] - 10https://gerrit.wikimedia.org/r/111954 (owner: 10Anomie) [19:46:48] (03PS13) 10Krinkle: [WIP] Investigate swinging qunit test failure [core] - 10https://gerrit.wikimedia.org/r/124372 [19:47:14] (03CR) 10Spage: [C: 04-1] "Basically OK, vform is a bit of a rat's nest. It's trying to support lots of core forms but in fact few have been converted to it (just lo" (038 comments) [core] - 10https://gerrit.wikimedia.org/r/124383 (owner: 10Wctaiwan) [19:50:34] (03CR) 10BryanDavis: "> Shouldn't this go into includes/ somewhere?" [core] - 10https://gerrit.wikimedia.org/r/119939 (owner: 10BryanDavis) [19:50:43] (03CR) 10Jforrester: "Why on Earth is this attempt at documentation not just using the existing https://doc.wikimedia.org/ system?" [core] - 10https://gerrit.wikimedia.org/r/125368 (owner: 10Mattflaschen) [19:55:06] (03CR) 10Swalling: "KSS is for generating a living style guide, with button examples and much more design-oriented documentation. Can doc.wikimedia.org do tha" [core] - 10https://gerrit.wikimedia.org/r/125368 (owner: 10Mattflaschen) [19:56:19] (03CR) 10Jforrester: "https://doc.wikimedia.org/ can take arbitrary HTML and JS in each of the sub-directories." [core] - 10https://gerrit.wikimedia.org/r/125368 (owner: 10Mattflaschen) [20:03:01] (03PS18) 10Bsitu: Closing & Summarizing topic frontend changes [extensions/Flow] - 10https://gerrit.wikimedia.org/r/119640 [20:11:19] (03CR) 10Swalling: [C: 031] "Backport is fine with me though not required. Otherwise this won't go out until the 24th." [core] (wmf/1.23wmf22) - 10https://gerrit.wikimedia.org/r/125447 (owner: 10Bartosz Dziewoński) [20:14:00] (03CR) 10Adamw: "Finished reviewing, it looks great! I'll review again when it's out of WIP." (037 comments) [extensions/Campaigns] (wip/editorcampaigns) - 10https://gerrit.wikimedia.org/r/123781 (owner: 10AndyRussG) [20:16:05] (03PS19) 10Bsitu: Closing & Summarizing topic frontend changes [extensions/Flow] - 10https://gerrit.wikimedia.org/r/119640 [20:17:37] (03CR) 10Adamw: [C: 04-1] Participation on create account via campaign url (032 comments) [extensions/Campaigns] (wip/editorcampaigns) - 10https://gerrit.wikimedia.org/r/119258 (owner: 10AndyRussG) [20:25:07] (03CR) 10Bartosz Dziewoński: "1.23wmf18 has only left production on 27 March, so we might want to wait a few days more." [core] - 10https://gerrit.wikimedia.org/r/117672 (owner: 10Ori.livneh) [20:25:36] (03PS20) 10Bsitu: Closing & Summarizing topic frontend changes [extensions/Flow] - 10https://gerrit.wikimedia.org/r/119640 [20:27:55] (03CR) 10Bartosz Dziewoński: [C: 032] qunit: Remove race condition in 'test.mediawiki.qunit.testrunner' [core] - 10https://gerrit.wikimedia.org/r/125434 (owner: 10Krinkle) [20:31:15] (03Merged) 10jenkins-bot: qunit: Remove race condition in 'test.mediawiki.qunit.testrunner' [core] - 10https://gerrit.wikimedia.org/r/125434 (owner: 10Krinkle) [20:34:53] (03CR) 10Bartosz Dziewoński: ChangeEmail special page rewritten to use vforms. (034 comments) [core] - 10https://gerrit.wikimedia.org/r/121975 (owner: 10Ganeshaditya1) [20:36:47] (03CR) 10Bartosz Dziewoński: "zzz…" [core] - 10https://gerrit.wikimedia.org/r/106279 (owner: 10Bartosz Dziewoński) [20:42:04] (03CR) 10Aaron Schulz: [C: 031] API: Refactor continuation code and add to purge, watch, etc. [core] - 10https://gerrit.wikimedia.org/r/111954 (owner: 10Anomie) [20:53:35] (03PS1) 10Manybubbles: Add fetch_fields support [search/highlighter] - 10https://gerrit.wikimedia.org/r/125505 [20:55:03] (03PS13) 10Bartosz Dziewoński: ChangesListSpecialPage: Implement two new hooks superseding 4 old ones [core] - 10https://gerrit.wikimedia.org/r/106279 [20:58:05] (03CR) 10Bartosz Dziewoński: "Rebased. I'd really like to get this into 1.23, to sort of complete the cleanup." [core] - 10https://gerrit.wikimedia.org/r/106279 (owner: 10Bartosz Dziewoński) [21:03:08] (03CR) 10Manybubbles: [C: 032] Add fetch_fields support [search/highlighter] - 10https://gerrit.wikimedia.org/r/125505 (owner: 10Manybubbles) [21:07:58] (03PS1) 10Manybubbles: [maven-release-plugin] prepare release experimental-0.0.3 [search/highlighter] - 10https://gerrit.wikimedia.org/r/125508 [21:08:00] (03PS1) 10Manybubbles: [maven-release-plugin] prepare for next development iteration [search/highlighter] - 10https://gerrit.wikimedia.org/r/125509 [21:08:21] (03CR) 10Manybubbles: [C: 032 V: 032] "Merging release commits." [search/highlighter] - 10https://gerrit.wikimedia.org/r/125508 (owner: 10Manybubbles) [21:08:33] (03CR) 10Manybubbles: [C: 032 V: 032] "Merging release commits." [search/highlighter] - 10https://gerrit.wikimedia.org/r/125509 (owner: 10Manybubbles) [21:11:05] (03CR) 10JGonera: Make .mw-ui-button height the same for all buttons (031 comment) [core] - 10https://gerrit.wikimedia.org/r/117107 (owner: 10JGonera) [21:16:50] https://git.wikimedia.org/blob/operations%2Fmediawiki-config.git/471549f25d31df60aa98e1aa06cb9f205efcc9e6/wmf-config%2FCommonSettings.php#L606 [21:17:06] I think some of these should be moved to the relevant extensions.. [21:23:09] (03CR) 10Spage: "select control presentation notes." (031 comment) [core] - 10https://gerrit.wikimedia.org/r/124383 (owner: 10Wctaiwan) [21:26:33] (03PS7) 10JGonera: Make .mw-ui-button height the same for all buttons [core] - 10https://gerrit.wikimedia.org/r/117107 [21:26:35] (03PS1) 10JGonera: Fix KSS mediawiki.ui style guide (docs) [core] - 10https://gerrit.wikimedia.org/r/125511 [21:34:29] (03PS1) 10Manybubbles: Update installation instructions [search/highlighter] - 10https://gerrit.wikimedia.org/r/125512 [21:34:43] (03CR) 10Manybubbles: [C: 032 V: 032] Update installation instructions [search/highlighter] - 10https://gerrit.wikimedia.org/r/125512 (owner: 10Manybubbles) [21:42:53] (03PS1) 10Bartosz Dziewoński: PrefixSearch: Remove unnecessary wfSuppressWarnings() [core] - 10https://gerrit.wikimedia.org/r/125513 [21:43:47] (03CR) 10Bartosz Dziewoński: "At least it *seems* unnecessary…" [core] - 10https://gerrit.wikimedia.org/r/125513 (owner: 10Bartosz Dziewoński) [21:45:36] (03CR) 10Spage: "blue outline glow when active doesn't seem desirable. It's hard to evolve Agora styling from its limited beginnings." (031 comment) [core] - 10https://gerrit.wikimedia.org/r/124383 (owner: 10Wctaiwan) [21:45:51] (03PS1) 10BryanDavis: Make logging destinations configurable [tools/scap] - 10https://gerrit.wikimedia.org/r/125515 [21:50:11] (03PS5) 10BryanDavis: Make DjVu metadata be stored as serialized PHP array. [core] - 10https://gerrit.wikimedia.org/r/99544 (owner: 10Brian Wolff) [21:53:26] (03CR) 10Aaron Schulz: [C: 04-1] Improve UDP logging code (031 comment) [core] - 10https://gerrit.wikimedia.org/r/125436 (owner: 10IAlex) [21:54:03] (03CR) 10EBernhardson: [C: 032] TopKIndex.replaceInIndex has incorrect return value in callback [extensions/Flow] - 10https://gerrit.wikimedia.org/r/124514 (owner: 10Bsitu) [21:54:21] (03Merged) 10jenkins-bot: TopKIndex.replaceInIndex has incorrect return value in callback [extensions/Flow] - 10https://gerrit.wikimedia.org/r/124514 (owner: 10Bsitu) [22:00:20] (03PS1) 10Aaron Schulz: Avoid site outages due to broken job queues [core] - 10https://gerrit.wikimedia.org/r/125518 [22:07:21] (03PS2) 10Ori.livneh: Revert "Work around HHVM bug with stdin/stdout in proc_open()" [core] - 10https://gerrit.wikimedia.org/r/125435 (owner: 10Aaron Schulz) [22:07:25] (03CR) 10Ori.livneh: [C: 032] Revert "Work around HHVM bug with stdin/stdout in proc_open()" [core] - 10https://gerrit.wikimedia.org/r/125435 (owner: 10Aaron Schulz) [22:09:38] (03PS1) 10MarkAHershberger: Revert "Provide RequestContext from fixDoubleRedirects" [core] - 10https://gerrit.wikimedia.org/r/125521 [22:10:40] (03Abandoned) 10MarkAHershberger: Provide RequestContext from fixDoubleRedirects [core] (REL1_21) - 10https://gerrit.wikimedia.org/r/125448 (owner: 10MarkAHershberger) [22:11:11] (03Abandoned) 10MarkAHershberger: Provide RequestContext from fixDoubleRedirects [core] (REL1_22) - 10https://gerrit.wikimedia.org/r/125446 (owner: 10MarkAHershberger) [22:11:44] (03Abandoned) 10MarkAHershberger: Provide RequestContext from fixDoubleRedirects [core] (REL1_19) - 10https://gerrit.wikimedia.org/r/125445 (owner: 10MarkAHershberger) [22:29:53] (03CR) 10BryanDavis: "recheck" [core] - 10https://gerrit.wikimedia.org/r/99544 (owner: 10Brian Wolff) [22:41:23] (03CR) 10BryanDavis: [C: 032] Make DjVu metadata be stored as serialized PHP array. [core] - 10https://gerrit.wikimedia.org/r/99544 (owner: 10Brian Wolff) [22:41:51] (03Abandoned) 10Krinkle: [WIP] Support JSDuck v5.x [core] - 10https://gerrit.wikimedia.org/r/108053 (owner: 10Krinkle) [22:43:32] (03PS1) 10Jforrester: Support JSDuck v5.x [core] - 10https://gerrit.wikimedia.org/r/125524 [22:51:54] (03CR) 10Jdlrobson: [C: 032] Fix KSS mediawiki.ui style guide (docs) [core] - 10https://gerrit.wikimedia.org/r/125511 (owner: 10JGonera) [22:56:56] (03PS1) 10Jforrester: doc: Fix errored variadic symbol on mediawiki.action.edit addButtons [core] - 10https://gerrit.wikimedia.org/r/125525 [23:04:18] (03PS6) 10Jforrester: Use new banana checker as a linter to avoid lacking qqq messages [core] - 10https://gerrit.wikimedia.org/r/125050 [23:05:21] (03PS1) 10Aaron Schulz: Wrap djvu large local copy downloads in pool counter [core] - 10https://gerrit.wikimedia.org/r/125527 [23:06:50] (03PS1) 10Aaron Schulz: Use standard "GetLocalFileCopy" pool name [extensions/PagedTiffHandler] - 10https://gerrit.wikimedia.org/r/125528 [23:07:15] (03PS1) 10Aaron Schulz: Use standard "GetLocalFileCopy" pool name [extensions/PdfHandler] - 10https://gerrit.wikimedia.org/r/125529 [23:07:45] (03CR) 10Aaron Schulz: "Needs https://gerrit.wikimedia.org/r/#/c/125527/" [extensions/PagedTiffHandler] - 10https://gerrit.wikimedia.org/r/125528 (owner: 10Aaron Schulz) [23:07:53] (03CR) 10Aaron Schulz: "Needs https://gerrit.wikimedia.org/r/#/c/125527/" [extensions/PdfHandler] - 10https://gerrit.wikimedia.org/r/125529 (owner: 10Aaron Schulz) [23:09:28] (03CR) 10Jforrester: "@Nemo: Are you saying that this patch fixed bug 63805 and should have been tagged with it? The bug was created after this was landed…" [core] - 10https://gerrit.wikimedia.org/r/116527 (owner: 10Krinkle) [23:10:40] (03PS4) 10Krinkle: Switch a few test cases back into es5 mode [core] - 10https://gerrit.wikimedia.org/r/125397 (owner: 10TheDJ) [23:15:24] (03PS1) 10Krinkle: Update QUnit from v1.11.0 to v1.14.0 [core] - 10https://gerrit.wikimedia.org/r/125533 [23:18:35] (03PS2) 10Krinkle: Update QUnit from v1.11.0 to v1.14.0 [core] - 10https://gerrit.wikimedia.org/r/125533 [23:24:09] (03CR) 10CSteipp: "Html::element should correctly escape any attributes you pass in. If not, can you open a Security bug with details about what wasn't being" [extensions/HTMLTags] - 10https://gerrit.wikimedia.org/r/124995 (owner: 10Yaron Koren) [23:44:16] (03PS4) 10Krinkle: Add jquery.accessKeyLabel javascript module [core] - 10https://gerrit.wikimedia.org/r/125426 (owner: 10Umherirrender) [23:44:50] (03CR) 10Krinkle: "Added to jsduck index and confirmed syntax." (031 comment) [core] - 10https://gerrit.wikimedia.org/r/125426 (owner: 10Umherirrender) [23:48:38] (03PS1) 10Catrope: Update OOjs UI to v0.1.0-pre (eca1fc20e7) [core] - 10https://gerrit.wikimedia.org/r/125536 [23:49:15] (03CR) 10Esanders: [C: 032] Update OOjs UI to v0.1.0-pre (eca1fc20e7) [core] - 10https://gerrit.wikimedia.org/r/125536 (owner: 10Catrope) [23:49:53] (03CR) 10Ori.livneh: [C: 032] "I won't pretend to have reviewed every changed line in QUnit, but I am +2ing because: 1) things are pretty broken right now; 2) the change" [core] - 10https://gerrit.wikimedia.org/r/125533 (owner: 10Krinkle) [23:54:46] ori: please look at https://gerrit.wikimedia.org/r/#/c/125527/ when you get the chance [23:54:57] * AaronSchulz already did pdf/tiff [23:58:44] (03CR) 10jenkins-bot: [V: 04-1] Fix KSS mediawiki.ui style guide (docs) [core] - 10https://gerrit.wikimedia.org/r/125511 (owner: 10JGonera) [23:59:21] (03Merged) 10jenkins-bot: Revert "Work around HHVM bug with stdin/stdout in proc_open()" [core] - 10https://gerrit.wikimedia.org/r/125435 (owner: 10Aaron Schulz)