[00:00:40] (03CR) 10jenkins-bot: [V: 04-1] mediawiki.jqueryMsg: Don't throw parse errors in the user's face [core] - 10https://gerrit.wikimedia.org/r/113307 (owner: 10Bartosz Dziewoński) [00:00:50] (03PS1) 10Krinkle: (DRAFT) Hotfix: grunt-lib-phantomjs Date mockery protection [integration/jenkins] - 10https://gerrit.wikimedia.org/r/125039 [00:02:40] (03PS1) 10Krinkle: Add bin/phantomjs symlink to avoid having to figure out the deep path [integration/jenkins] - 10https://gerrit.wikimedia.org/r/125040 [00:03:13] (03PS2) 10Krinkle: Add bin/phantomjs symlink to deep node_modules path [integration/jenkins] - 10https://gerrit.wikimedia.org/r/125040 [00:03:22] (03CR) 10Krinkle: [C: 032] Add bin/phantomjs symlink to deep node_modules path [integration/jenkins] - 10https://gerrit.wikimedia.org/r/125040 (owner: 10Krinkle) [00:03:25] (03Merged) 10jenkins-bot: Add bin/phantomjs symlink to deep node_modules path [integration/jenkins] - 10https://gerrit.wikimedia.org/r/125040 (owner: 10Krinkle) [00:06:32] (03PS1) 10BryanDavis: Configuration for beta [tools/scap] - 10https://gerrit.wikimedia.org/r/125043 [00:07:36] (03PS6) 10Jforrester: jshint: Enable 'es3' option [core] - 10https://gerrit.wikimedia.org/r/116527 (owner: 10Krinkle) [00:08:16] (03CR) 10Krinkle: [C: 032] mediawiki.jqueryMsg: Don't throw parse errors in the user's face [core] - 10https://gerrit.wikimedia.org/r/113307 (owner: 10Bartosz Dziewoński) [00:08:44] (03CR) 10BryanDavis: [C: 032] "Self-merge as this only affects usage in wmflabs and I'd like to test it out there." [tools/scap] - 10https://gerrit.wikimedia.org/r/125043 (owner: 10BryanDavis) [00:09:47] (03Merged) 10jenkins-bot: Configuration for beta [tools/scap] - 10https://gerrit.wikimedia.org/r/125043 (owner: 10BryanDavis) [00:11:54] (03CR) 10jenkins-bot: [V: 04-1] mediawiki.jqueryMsg: Don't throw parse errors in the user's face [core] - 10https://gerrit.wikimedia.org/r/113307 (owner: 10Bartosz Dziewoński) [00:14:40] (03PS19) 10Bsitu: Closing & reopening topic [extensions/Flow] - 10https://gerrit.wikimedia.org/r/118399 [00:16:39] (03PS2) 10Jdlrobson: Typograhy Refresh - Apply line-height to correct ID [core] - 10https://gerrit.wikimedia.org/r/124866 (owner: 10Gerrit Patch Uploader) [00:16:45] (03PS3) 10Jdlrobson: Typography Refresh - Apply line-height to correct ID [core] - 10https://gerrit.wikimedia.org/r/124866 (owner: 10Gerrit Patch Uploader) [00:19:27] (03CR) 10Jdlrobson: [C: 032] Typography Refresh - Apply line-height to correct ID [core] - 10https://gerrit.wikimedia.org/r/124866 (owner: 10Gerrit Patch Uploader) [00:22:47] (03Merged) 10jenkins-bot: Typography Refresh - Apply line-height to correct ID [core] - 10https://gerrit.wikimedia.org/r/124866 (owner: 10Gerrit Patch Uploader) [00:25:34] (03PS1) 10Jforrester: Use new banana checker as a linter to avoid lacking qqq messages [core] - 10https://gerrit.wikimedia.org/r/125050 [00:30:05] (03CR) 10Jdlrobson: "Just want to get some kind of indication from Mark that he will remove his -2 when that day comes..." [core] - 10https://gerrit.wikimedia.org/r/118345 (owner: 10Jdlrobson) [00:32:23] (03CR) 10jenkins-bot: [V: 04-1] Use new banana checker as a linter to avoid lacking qqq messages [core] - 10https://gerrit.wikimedia.org/r/125050 (owner: 10Jforrester) [00:40:07] (03CR) 10Jforrester: "Can't be merged until all ~210 failing messages are fixed." [core] - 10https://gerrit.wikimedia.org/r/125050 (owner: 10Jforrester) [00:51:50] (03Abandoned) 10Aude: Remove RC_MOVE and RC_MOVE_OVER_REDIRECT grouping in EnhancedChangesList [core] - 10https://gerrit.wikimedia.org/r/124574 (owner: 10Aude) [00:58:27] (03PS1) 10Krinkle: Update tools/package.json to newer upstream versions [integration/jenkins] - 10https://gerrit.wikimedia.org/r/125052 [00:58:33] (03PS1) 10Jforrester: Update OOjs UI to v0.1.0-pre (ac6848398c) [core] - 10https://gerrit.wikimedia.org/r/125053 [01:01:29] (03PS2) 10Krinkle: Update tools/package.json to newer upstream versions [integration/jenkins] - 10https://gerrit.wikimedia.org/r/125052 [01:01:35] (03CR) 10Krinkle: [C: 032] Update tools/package.json to newer upstream versions [integration/jenkins] - 10https://gerrit.wikimedia.org/r/125052 (owner: 10Krinkle) [01:01:54] (03Merged) 10jenkins-bot: Update tools/package.json to newer upstream versions [integration/jenkins] - 10https://gerrit.wikimedia.org/r/125052 (owner: 10Krinkle) [01:07:41] (03PS8) 10Krinkle: mediawiki.special: Remove HTML backwards-compatibility styles [core] - 10https://gerrit.wikimedia.org/r/116790 (owner: 10Bartosz Dziewoński) [01:08:56] (03CR) 10Krinkle: [C: 032] Update OOjs UI to v0.1.0-pre (ac6848398c) [core] - 10https://gerrit.wikimedia.org/r/125053 (owner: 10Jforrester) [01:12:05] (03Merged) 10jenkins-bot: Update OOjs UI to v0.1.0-pre (ac6848398c) [core] - 10https://gerrit.wikimedia.org/r/125053 (owner: 10Jforrester) [01:51:38] (03Abandoned) 10Aude: Remove unused WMF-specific code [core] - 10https://gerrit.wikimedia.org/r/74337 (owner: 10Aude) [03:06:03] hi all [03:44:42] (03PS13) 10thibaultmarin: (extension/TimelineTable) Refactoring and cleanup [extensions/TimelineTable] - 10https://gerrit.wikimedia.org/r/38485 [03:47:36] (03CR) 10thibaultmarin: (extension/TimelineTable) Refactoring and cleanup (032 comments) [extensions/TimelineTable] - 10https://gerrit.wikimedia.org/r/38485 (owner: 10thibaultmarin) [04:40:36] (03PS1) 10Mwjames: Adds XmlLayoutFileValidityTest [skins/chameleon] - 10https://gerrit.wikimedia.org/r/125072 [04:41:15] (03PS13) 10Mattflaschen: WIP: Refactor and add non-linear tours [extensions/GuidedTour] - 10https://gerrit.wikimedia.org/r/116228 [04:43:21] (03CR) 10Mattflaschen: "> I like this approach. It might be worth extracting it into a utility function." [extensions/GuidedTour] - 10https://gerrit.wikimedia.org/r/116228 (owner: 10Mattflaschen) [04:47:21] (03PS3) 10Mattflaschen: Update firsteditve [extensions/GuidedTour] - 10https://gerrit.wikimedia.org/r/123171 [04:47:43] (03CR) 10jenkins-bot: [V: 04-1] Update firsteditve [extensions/GuidedTour] - 10https://gerrit.wikimedia.org/r/123171 (owner: 10Mattflaschen) [04:47:48] (03CR) 10Mattflaschen: "Rebased and retested. I confirmed it still works with the hook registration method change." [extensions/GuidedTour] - 10https://gerrit.wikimedia.org/r/123171 (owner: 10Mattflaschen) [04:49:05] (03CR) 10Mwjames: Adds XmlLayoutFileValidityTest (031 comment) [skins/chameleon] - 10https://gerrit.wikimedia.org/r/125072 (owner: 10Mwjames) [04:49:41] (03PS4) 10Mattflaschen: Update firsteditve [extensions/GuidedTour] - 10https://gerrit.wikimedia.org/r/123171 [04:50:10] (03CR) 10Mattflaschen: "I forgot to check jshint. Latest patch addresses phuedx's comment and should pass Jenkins." [extensions/GuidedTour] - 10https://gerrit.wikimedia.org/r/123171 (owner: 10Mattflaschen) [04:52:19] (03CR) 10Mwjames: "If you wanted to enforce a specific structure (nodes etc.), something like [0] should be used." [skins/chameleon] - 10https://gerrit.wikimedia.org/r/125072 (owner: 10Mwjames) [05:05:05] (03PS3) 10Umherirrender: Avoid using raw sql in SpecialUndelete.php [core] - 10https://gerrit.wikimedia.org/r/124659 [05:25:06] (03CR) 10Mwjames: "Stephan on a different note, I just saw an ought behaviour maybe you could verify that." [skins/chameleon] - 10https://gerrit.wikimedia.org/r/125072 (owner: 10Mwjames) [05:26:34] (03CR) 10Kelson: [C: 032 V: 032] "OK" [qrpedia] - 10https://gerrit.wikimedia.org/r/121661 (owner: 10Addshore) [05:26:38] (03Merged) 10jenkins-bot: General fixes and cleanup [qrpedia] - 10https://gerrit.wikimedia.org/r/121661 (owner: 10Addshore) [05:26:40] (03Merged) 10jenkins-bot: Format PHP code per MW conventions [qrpedia] - 10https://gerrit.wikimedia.org/r/124737 (owner: 10Addshore) [05:26:42] (03Merged) 10jenkins-bot: Use single quotes where possible [qrpedia] - 10https://gerrit.wikimedia.org/r/124741 (owner: 10Addshore) [05:26:44] (03Merged) 10jenkins-bot: Fix spelling errors in comments [qrpedia] - 10https://gerrit.wikimedia.org/r/124745 (owner: 10Addshore) [05:41:23] (03PS2) 10Ori.livneh: Avoid making a derivative request to Special:RunJobs when the job queue is empty [core] - 10https://gerrit.wikimedia.org/r/124629 (owner: 10Aaron Schulz) [05:42:24] (03CR) 10jenkins-bot: [V: 04-1] Avoid making a derivative request to Special:RunJobs when the job queue is empty [core] - 10https://gerrit.wikimedia.org/r/124629 (owner: 10Aaron Schulz) [05:43:24] it's a bit unfair when you get a -1 for changing a commit message [05:43:49] which is what happens when your change provides an occasion for jenkins to find out about a merge conflict [05:48:23] (03PS6) 10Worden.lee: Extend FauxRequest to allow fake uploaded files [core] - 10https://gerrit.wikimedia.org/r/66319 [05:50:10] (03PS3) 10Ori.livneh: Avoid making a derivative request to Special:RunJobs when the job queue is empty [core] - 10https://gerrit.wikimedia.org/r/124629 (owner: 10Aaron Schulz) [05:50:43] (03CR) 10Ori.livneh: [C: 032] Avoid making a derivative request to Special:RunJobs when the job queue is empty [core] - 10https://gerrit.wikimedia.org/r/124629 (owner: 10Aaron Schulz) [05:52:36] (03CR) 10Worden.lee: "Rebased." [core] - 10https://gerrit.wikimedia.org/r/66319 (owner: 10Worden.lee) [05:54:14] (03Merged) 10jenkins-bot: Avoid making a derivative request to Special:RunJobs when the job queue is empty [core] - 10https://gerrit.wikimedia.org/r/124629 (owner: 10Aaron Schulz) [05:58:15] (03CR) 10Ori.livneh: "Neglecting to check that the queue is nonempty before launching a derivative request is indeed an issue, but note that it is fixed by Icb9" [core] - 10https://gerrit.wikimedia.org/r/124470 (owner: 10Martineznovo) [06:10:06] uh, Houston, we have a problem. [06:10:08] https://www.wikidata.org/w/index.php?diff=119950873&oldid=119922542&rcid=120267995 [06:10:13] ori^ that i110n thing again [06:10:23] idk if it's Wikibase-specific [06:11:38] Jasper_Deng: i don't see it; what do i need to do to reproduce? [06:12:03] ori: https://www.wikidata.org/wiki/Special:RecentChanges [06:12:17] diffs broken too [06:12:26] ah, yep [06:12:44] greg-g, bd808|BUFFER ^ [06:13:03] I'll force an update [06:15:04] ugh [06:17:07] looks only wikibase related [06:19:02] ori: can you save the ExtensionMessages-1.23wmf21.php file as it is right now, plz? [06:20:03] * greg-g thought he was in -operations... [06:22:38] greg-g: sure, /home/ori/misc/ExtensionMessages-1.23wmf21.php-1397110856 [06:23:00] world-readable. do you have access to tin? do you need me to copy it elsewhere? [06:33:09] (03CR) 10Siebrand: "i18n/L10n reviewed. Looks like only parameter documentation is missing in qqq. I'll upload a patch revision with updated indentation." (031 comment) [extensions/TimelineTable] - 10https://gerrit.wikimedia.org/r/38485 (owner: 10thibaultmarin) [06:33:43] ori: I have access, thanks [06:37:56] (03PS14) 10Siebrand: (extension/TimelineTable) Refactoring and cleanup [extensions/TimelineTable] - 10https://gerrit.wikimedia.org/r/38485 (owner: 10thibaultmarin) [06:38:04] (03CR) 10Siebrand: "PS14 updates formatting." [extensions/TimelineTable] - 10https://gerrit.wikimedia.org/r/38485 (owner: 10thibaultmarin) [06:38:15] (03CR) 10Siebrand: [C: 04-1] "Per PS13 comment." [extensions/TimelineTable] - 10https://gerrit.wikimedia.org/r/38485 (owner: 10thibaultmarin) [06:44:33] (03CR) 10Siebrand: [C: 031] "i18n/L10n reviewed." [extensions/Flow] - 10https://gerrit.wikimedia.org/r/118399 (owner: 10Bsitu) [06:51:26] (03CR) 10Siebrand: use imagemap class for HTML rendering (032 comments) [extensions/GraphViz] - 10https://gerrit.wikimedia.org/r/111475 (owner: 10Welterkj) [06:51:50] (03PS1) 10Mwjames: Add .travis.yml [skins/chameleon] - 10https://gerrit.wikimedia.org/r/125074 [06:56:14] (03CR) 10Siebrand: [C: 032] Special:ListGroupRights: Add per-namespace restrictions and rights [core] - 10https://gerrit.wikimedia.org/r/40096 (owner: 10Alex Monk) [06:57:18] (03CR) 10Mwjames: "Should run [0] when a commit is posted to [1] and probably needs some fine tuning afterwards." [skins/chameleon] - 10https://gerrit.wikimedia.org/r/125074 (owner: 10Mwjames) [06:59:23] (03CR) 10Siebrand: "@Shirayuki: Feel like taking on a project?" [core] - 10https://gerrit.wikimedia.org/r/125050 (owner: 10Jforrester) [06:59:26] (03Merged) 10jenkins-bot: Special:ListGroupRights: Add per-namespace restrictions and rights [core] - 10https://gerrit.wikimedia.org/r/40096 (owner: 10Alex Monk) [07:08:27] (03PS1) 10Siebrand: Remove unused key usernamehasherror [core] - 10https://gerrit.wikimedia.org/r/125075 [07:12:51] (03PS1) 10Siebrand: Remove unused key uploadlog [core] - 10https://gerrit.wikimedia.org/r/125076 [07:15:37] (03PS1) 10Siebrand: Remove unused key uploadedfiles [core] - 10https://gerrit.wikimedia.org/r/125078 [07:16:43] wow siebrand, thanks for that merge; can you upgrade twn, I'm anxious to see it :) [07:17:02] Nemo_bis: It's in sandbox. [07:19:04] great [07:19:18] a bit ugly there because we have so many, but effective [07:20:03] (03PS2) 10Aaron Schulz: [WIP] Profiler class refactoring [core] - 10https://gerrit.wikimedia.org/r/125059 [07:20:19] (03PS1) 10Siebrand: Remove unused key uploadfromurl-queued [core] - 10https://gerrit.wikimedia.org/r/125079 [07:22:10] (03CR) 10jenkins-bot: [V: 04-1] Remove unused key uploadfromurl-queued [core] - 10https://gerrit.wikimedia.org/r/125079 (owner: 10Siebrand) [07:24:10] I do wonder if it's saying the truth about schema ns in http://meta.wikimedia.beta.wmflabs.org/wiki/Special:ListGroupRights [07:24:38] (03PS1) 10Siebrand: Remove unused key upload-unknown-size [core] - 10https://gerrit.wikimedia.org/r/125080 [07:24:45] Nemo_bis: that it's restricted to autoconfirmed? it's true [07:26:07] i'd link to the changeset but i just realized i self-merged it so instead i'll pretend i can't find it [07:26:44] dec 2012 tho, surely a statute of limitations applies [07:26:50] (03PS1) 10Siebrand: Remove unused key img-auth-bad-query-string [core] - 10https://gerrit.wikimedia.org/r/125081 [07:27:18] ok [07:27:53] (03CR) 10jenkins-bot: [V: 04-1] [WIP] Profiler class refactoring [core] - 10https://gerrit.wikimedia.org/r/125059 (owner: 10Aaron Schulz) [07:28:03] With all those namespace I'm a bit confused, we've seen action and mostly talk about new groups vs. new rights vs. flaggedrevs for Zero, Schema, Grants bla bla bla [07:28:21] Luckily there is someone who remembers :) [07:30:39] (03PS1) 10Hashar: Mark ContributionReporting has obsolete [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/125082 [07:30:48] (03CR) 10Hashar: [C: 032] Mark ContributionReporting has obsolete [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/125082 (owner: 10Hashar) [07:30:56] (03PS1) 10Siebrand: Remove unused key filehist-missing [core] - 10https://gerrit.wikimedia.org/r/125083 [07:33:59] (03PS1) 10Siebrand: Remove unused key usermailererror [core] - 10https://gerrit.wikimedia.org/r/125084 [07:35:41] (03PS1) 10Hashar: Jobs for mw/ext/TextExtracts [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/125085 [07:35:53] (03CR) 10Hashar: [C: 032] Jobs for mw/ext/TextExtracts [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/125085 (owner: 10Hashar) [07:36:45] (03PS2) 10Hashar: Mark ContributionReporting has obsolete [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/125082 [07:36:54] (03CR) 10Hashar: [C: 032] Mark ContributionReporting has obsolete [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/125082 (owner: 10Hashar) [07:37:17] (03Merged) 10jenkins-bot: Jobs for mw/ext/TextExtracts [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/125085 (owner: 10Hashar) [07:37:26] (03CR) 10TheDJ: [C: 032] jshint: Enable 'es3' option [core] - 10https://gerrit.wikimedia.org/r/116527 (owner: 10Krinkle) [07:37:50] (03PS1) 10Siebrand: Move key usermailererror here from core [extensions/ContactPage] - 10https://gerrit.wikimedia.org/r/125086 [07:37:52] (03PS1) 10Hashar: Trigger jobs for mw/ext/TextExtracts [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/125087 [07:38:06] (03CR) 10Hashar: [C: 032] Trigger jobs for mw/ext/TextExtracts [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/125087 (owner: 10Hashar) [07:38:37] (03Merged) 10jenkins-bot: Mark ContributionReporting has obsolete [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/125082 (owner: 10Hashar) [07:38:43] (03Merged) 10jenkins-bot: Trigger jobs for mw/ext/TextExtracts [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/125087 (owner: 10Hashar) [07:40:36] (03Merged) 10jenkins-bot: jshint: Enable 'es3' option [core] - 10https://gerrit.wikimedia.org/r/116527 (owner: 10Krinkle) [07:41:31] (03PS1) 10Hashar: Jenkins job validation (DO NOT SUBMIT) [extensions/TextExtracts] - 10https://gerrit.wikimedia.org/r/125088 [07:41:38] (03CR) 10jenkins-bot: [V: 04-1] Jenkins job validation (DO NOT SUBMIT) [extensions/TextExtracts] - 10https://gerrit.wikimedia.org/r/125088 (owner: 10Hashar) [07:42:34] (03PS2) 10Prtksxna: Stop checking for SVG support on every hover [extensions/Popups] - 10https://gerrit.wikimedia.org/r/124851 [07:42:36] (03PS2) 10Prtksxna: Remove confusing variable name [extensions/Popups] - 10https://gerrit.wikimedia.org/r/124853 [07:42:37] (03PS2) 10Prtksxna: Break ternary operations into multiple lines [extensions/Popups] - 10https://gerrit.wikimedia.org/r/124852 [07:42:39] (03PS1) 10Prtksxna: Update documentation for the createThumbnail method [extensions/Popups] - 10https://gerrit.wikimedia.org/r/125089 [07:42:56] (03PS1) 10Siebrand: Remove unused keys nowikiemailtitle and nowikiemailtext [core] - 10https://gerrit.wikimedia.org/r/125090 [07:49:29] (03PS1) 10Siebrand: Remove unused key enotif_mailer [core] - 10https://gerrit.wikimedia.org/r/125092 [07:51:03] (03PS2) 10Hashar: Jenkins job validation (DO NOT SUBMIT) [extensions/TextExtracts] - 10https://gerrit.wikimedia.org/r/125088 [07:51:28] (03Abandoned) 10Hashar: Jenkins job validation (DO NOT SUBMIT) [extensions/TextExtracts] - 10https://gerrit.wikimedia.org/r/125088 (owner: 10Hashar) [07:51:59] (03PS1) 10Siebrand: Remove unused key exblank [core] - 10https://gerrit.wikimedia.org/r/125093 [07:55:50] (03PS1) 10Siebrand: Remove unused key importnotext [core] - 10https://gerrit.wikimedia.org/r/125095 [07:57:36] (03PS1) 10Siebrand: Remove unused key importhistoryconflict [core] - 10https://gerrit.wikimedia.org/r/125097 [07:58:57] (03CR) 10Siebrand: "ContactPage change in https://gerrit.wikimedia.org/r/#/c/125086/1" [core] - 10https://gerrit.wikimedia.org/r/125084 (owner: 10Siebrand) [07:59:20] (03CR) 10PleaseStand: [C: 04-1] "Are you sure about 'nowikiemailtext'? It looks like the string 'nowikiemail' can be returned from SpecialEmailuser::getTarget(), and that " [core] - 10https://gerrit.wikimedia.org/r/125090 (owner: 10Siebrand) [08:00:06] (03CR) 10Siebrand: "Where can it be concatenated with the same text in the class you mention?" [core] - 10https://gerrit.wikimedia.org/r/125090 (owner: 10Siebrand) [08:00:40] (03CR) 10Siebrand: "Raimond: https://gerrit.wikimedia.org/r/#/c/125084/ should be merged first. After that, existing translations can be renamed." [extensions/ContactPage] - 10https://gerrit.wikimedia.org/r/125086 (owner: 10Siebrand) [08:03:59] (03CR) 10Siebrand: "Found it. Will abandon this one, and add documentation." [core] - 10https://gerrit.wikimedia.org/r/125090 (owner: 10Siebrand) [08:04:03] (03CR) 10jenkins-bot: [V: 04-1] Remove unused key importnotext [core] - 10https://gerrit.wikimedia.org/r/125095 (owner: 10Siebrand) [08:04:26] (03CR) 10Siebrand: "recheck" [core] - 10https://gerrit.wikimedia.org/r/125095 (owner: 10Siebrand) [08:06:31] (03PS1) 10Siebrand: Update documentation for used message keys in Special:Emailuser [core] - 10https://gerrit.wikimedia.org/r/125099 [08:08:01] (03PS2) 10Siebrand: Remove unused key nowikiemailtitle [core] - 10https://gerrit.wikimedia.org/r/125090 [08:08:21] (03CR) 10Siebrand: "Docs updated in https://gerrit.wikimedia.org/r/#/c/125099/" [core] - 10https://gerrit.wikimedia.org/r/125090 (owner: 10Siebrand) [08:09:53] (03CR) 10Siebrand: "Not fair. First Jenkins bugs, then it scores -1 on something unrelated." [core] - 10https://gerrit.wikimedia.org/r/125095 (owner: 10Siebrand) [08:10:12] (03CR) 10Siebrand: "recheck" [core] - 10https://gerrit.wikimedia.org/r/125079 (owner: 10Siebrand) [08:11:20] (03CR) 10jenkins-bot: [V: 04-1] Remove unused key uploadfromurl-queued [core] - 10https://gerrit.wikimedia.org/r/125079 (owner: 10Siebrand) [08:12:44] (03CR) 10Siebrand: "@hashar @krinkle: Can we please have Jenkins voting only where it is actually commenting on things relevant for the patch set?" [core] - 10https://gerrit.wikimedia.org/r/125079 (owner: 10Siebrand) [08:13:30] (03CR) 10Nemo bis: "I added a couple active qqq "translators". Summary: help is needed to add docs for the messages listed in red at https://integration.wikim" [core] - 10https://gerrit.wikimedia.org/r/125050 (owner: 10Jforrester) [08:14:45] (03CR) 10Raimond Spekking: [C: 032] Remove unused key usermailererror [core] - 10https://gerrit.wikimedia.org/r/125084 (owner: 10Siebrand) [08:15:32] (03CR) 10Raimond Spekking: Move key usermailererror here from core (031 comment) [extensions/ContactPage] - 10https://gerrit.wikimedia.org/r/125086 (owner: 10Siebrand) [08:17:10] (03PS2) 10Siebrand: Move key usermailererror here from core [extensions/ContactPage] - 10https://gerrit.wikimedia.org/r/125086 [08:17:22] (03CR) 10Siebrand: "PS2." (031 comment) [extensions/ContactPage] - 10https://gerrit.wikimedia.org/r/125086 (owner: 10Siebrand) [08:18:32] (03CR) 10Raimond Spekking: [C: 032] Move key usermailererror here from core [extensions/ContactPage] - 10https://gerrit.wikimedia.org/r/125086 (owner: 10Siebrand) [08:18:34] (03Merged) 10jenkins-bot: Move key usermailererror here from core [extensions/ContactPage] - 10https://gerrit.wikimedia.org/r/125086 (owner: 10Siebrand) [08:22:46] (03CR) 10Siebrand: "Please be aware that when I just started working on this, I found that a lot of the undocumented keys are actually no longer used, or hidd" [core] - 10https://gerrit.wikimedia.org/r/125050 (owner: 10Jforrester) [08:30:05] (03CR) 10QChris: [C: 031 V: 032] "Since there a few corner cases (hard to detect automatically)" [All-Projects] (refs/meta/config) - 10https://gerrit.wikimedia.org/r/124891 (owner: 10Hashar) [08:40:22] (03CR) 10Hashar: "I'd say yes as well. We might want to bring the topic on wikitech-l to advertise this change though." [All-Projects] (refs/meta/config) - 10https://gerrit.wikimedia.org/r/124891 (owner: 10Hashar) [08:47:44] (03CR) 10Mwjames: "I found out that when logged-out the following issue is reported:" [skins/chameleon] - 10https://gerrit.wikimedia.org/r/125072 (owner: 10Mwjames) [08:50:39] (03PS1) 10Santhosh: Segmentation: More fixes related to references at end of sentence [services/cxserver] - 10https://gerrit.wikimedia.org/r/125103 [08:51:08] (03CR) 10jenkins-bot: [V: 04-1] Segmentation: More fixes related to references at end of sentence [services/cxserver] - 10https://gerrit.wikimedia.org/r/125103 (owner: 10Santhosh) [08:52:28] ori: Why is there no owners group for wikiEditor in gerrit btw ? and do we have more extensions without groups ? [08:53:35] (03PS2) 10Santhosh: Segmentation: More fixes related to references at end of sentence [services/cxserver] - 10https://gerrit.wikimedia.org/r/125103 [08:55:05] (03CR) 10Foxtrott: [C: 032 V: 032] "There was a problem once that Bootstrap styles where loaded regardless of whether Chameleon was the selected skin or not. But that should " [skins/chameleon] - 10https://gerrit.wikimedia.org/r/125072 (owner: 10Mwjames) [08:56:28] thedj: dunno [09:01:52] (03PS1) 10Hashar: Typo for Zuul triggers in '{name}-maven-checkstyle' [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/125106 [09:01:55] (03PS1) 10Hashar: Make '{name}-maven-checkstyle' concurrent [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/125107 [09:10:05] (03CR) 10Foxtrott: "There is interference between lessc.php in the oyejorge module and the lessc.php used by MW. :(" [skins/chameleon] - 10https://gerrit.wikimedia.org/r/125072 (owner: 10Mwjames) [09:10:18] (03CR) 10KartikMistry: [C: 032] "Test passes. Manually tested with couple of articles which had issues earlier. All OK!" [services/cxserver] - 10https://gerrit.wikimedia.org/r/125103 (owner: 10Santhosh) [09:10:56] (03CR) 10Foxtrott: [C: 032 V: 032] Add .travis.yml [skins/chameleon] - 10https://gerrit.wikimedia.org/r/125074 (owner: 10Mwjames) [09:14:42] (03CR) 10Odder: "This patch has now been +1'd by six different people. Why isn't it merged yet?" [core] - 10https://gerrit.wikimedia.org/r/124475 (owner: 10Odder) [09:31:23] (03CR) 10Addshore: [C: 031] ":D" [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/125106 (owner: 10Hashar) [09:31:35] (03CR) 10Addshore: [C: 031] ":D" [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/125107 (owner: 10Hashar) [09:35:35] (03Merged) 10jenkins-bot: Segmentation: More fixes related to references at end of sentence [services/cxserver] - 10https://gerrit.wikimedia.org/r/125103 (owner: 10Santhosh) [09:45:35] (03CR) 10Matthias Mullie: Closing & reopening topic (031 comment) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/118399 (owner: 10Bsitu) [09:46:51] siebrand: around? :) [09:47:40] siebrand: https://gerrit.wikimedia.org/r/#/c/125075/1/languages/i18n/en.json does this need to be removed from messges.inc? or does that happen automatically? :P [09:50:16] (03CR) 10Hashar: [C: 032] "Deployed" [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/125106 (owner: 10Hashar) [09:50:26] (03CR) 10Hashar: [C: 032] "Deployed" [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/125107 (owner: 10Hashar) [09:51:08] (03Merged) 10jenkins-bot: Typo for Zuul triggers in '{name}-maven-checkstyle' [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/125106 (owner: 10Hashar) [09:51:11] (03Merged) 10jenkins-bot: Make '{name}-maven-checkstyle' concurrent [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/125107 (owner: 10Hashar) [09:53:51] addshore: messages.inc is no longer maintained after the JSON move. [09:54:19] so we can kill it? ;p [09:54:20] addshore: It's maintained in a file in the translatewiki repo (groups/MediaWiki/MediaWiki.yaml to be precise) [09:54:30] addshore: ialex is still attached to it... [09:55:12] addshore: https://gerrit.wikimedia.org/r/#/c/124165/ [09:55:13] but its fine for https://gerrit.wikimedia.org/r/#/c/125075 to go in without touching messges.inc then? :) [09:55:30] addshore: that is correct. [09:55:57] yum ;p [10:02:22] (03PS1) 10Siebrand: Place parenthesis outsoude of code tag [core] - 10https://gerrit.wikimedia.org/r/125124 [10:02:54] (03CR) 10Addshore: [C: 032] Remove unused key usernamehasherror [core] - 10https://gerrit.wikimedia.org/r/125075 (owner: 10Siebrand) [10:02:56] (03CR) 10Addshore: [C: 032] Remove unused key uploadlog [core] - 10https://gerrit.wikimedia.org/r/125076 (owner: 10Siebrand) [10:02:58] (03CR) 10Addshore: [C: 032] Remove unused key upload-unknown-size [core] - 10https://gerrit.wikimedia.org/r/125080 (owner: 10Siebrand) [10:03:00] (03CR) 10Addshore: [C: 032] Remove unused key img-auth-bad-query-string [core] - 10https://gerrit.wikimedia.org/r/125081 (owner: 10Siebrand) [10:03:02] (03CR) 10Addshore: [C: 032] Remove unused key filehist-missing [core] - 10https://gerrit.wikimedia.org/r/125083 (owner: 10Siebrand) [10:03:04] (03CR) 10Addshore: [C: 032] Remove unused key enotif_mailer [core] - 10https://gerrit.wikimedia.org/r/125092 (owner: 10Siebrand) [10:03:06] (03CR) 10Addshore: [C: 032] Remove unused key exblank [core] - 10https://gerrit.wikimedia.org/r/125093 (owner: 10Siebrand) [10:03:07] addshore: Awesome! [10:03:08] (03CR) 10Addshore: [C: 032] Remove unused key importhistoryconflict [core] - 10https://gerrit.wikimedia.org/r/125097 (owner: 10Siebrand) [10:03:10] (03CR) 10Addshore: [C: 032] Remove unused key importnotext [core] - 10https://gerrit.wikimedia.org/r/125095 (owner: 10Siebrand) [10:03:22] (03CR) 10Addshore: [C: 032] Remove unused key uploadfromurl-queued [core] - 10https://gerrit.wikimedia.org/r/125079 (owner: 10Siebrand) [10:03:58] (03CR) 10Addshore: [C: 032] Place parenthesis outsoude of code tag [core] - 10https://gerrit.wikimedia.org/r/125124 (owner: 10Siebrand) [10:04:36] (03CR) 10Addshore: [C: 032] Remove unused key nowikiemailtitle [core] - 10https://gerrit.wikimedia.org/r/125090 (owner: 10Siebrand) [10:05:04] (03CR) 10Addshore: ".." [core] - 10https://gerrit.wikimedia.org/r/125090 (owner: 10Siebrand) [10:06:40] (03CR) 10Addshore: [C: 04-2] "per https://gerrit.wikimedia.org/r/#/c/125099/1/includes/specials/SpecialEmailuser.php" [core] - 10https://gerrit.wikimedia.org/r/125090 (owner: 10Siebrand) [10:07:13] (03CR) 10Addshore: [C: 032] Update documentation for used message keys in Special:Emailuser [core] - 10https://gerrit.wikimedia.org/r/125099 (owner: 10Siebrand) [10:07:46] (03CR) 10Siebrand: "Adam: Initially this patch set removed two keys. Now only one remains, and as far as I can tell, that's really no longer used. I could of " [core] - 10https://gerrit.wikimedia.org/r/125090 (owner: 10Siebrand) [10:08:06] liangent: Can you please look at https://translatewiki.net/wiki/Thread:Support/Enable_syncing_of_zh-tw_and_zh-hk_for_MediaWiki ? [10:08:30] (03CR) 10Addshore: [C: 032] Remove unused key uploadedfiles [core] - 10https://gerrit.wikimedia.org/r/125078 (owner: 10Siebrand) [10:09:40] (03CR) 10jenkins-bot: [V: 04-1] Remove unused key usernamehasherror [core] - 10https://gerrit.wikimedia.org/r/125075 (owner: 10Siebrand) [10:10:32] (03PS1) 10Siebrand: Remove zh-[cn|tw] in favour of zh-han[s|t] [extensions/SocialProfile] - 10https://gerrit.wikimedia.org/r/125125 [10:10:38] (03CR) 10Addshore: [C: 032] "Indeed, I search for nowikiemailtext initially and couldn't find any usage." [core] - 10https://gerrit.wikimedia.org/r/125090 (owner: 10Siebrand) [10:11:24] (03PS1) 10Siebrand: Remove zh-[cn|tw] in favour of zh-han[s|t] [extensions/WYSIWYG] - 10https://gerrit.wikimedia.org/r/125126 [10:11:52] (03PS2) 10Addshore: Remove unused key usernamehasherror [core] - 10https://gerrit.wikimedia.org/r/125075 (owner: 10Siebrand) [10:11:57] (03CR) 10Addshore: [C: 032] Remove unused key usernamehasherror [core] - 10https://gerrit.wikimedia.org/r/125075 (owner: 10Siebrand) [10:13:11] (03PS1) 10Siebrand: Remove zh-[cn|tw] in favour of zh-han[s|t] [extensions/WikiLexicalData] - 10https://gerrit.wikimedia.org/r/125127 [10:13:51] (03PS1) 10Siebrand: Remove zh-[cn|tw] in favour of zh-han[s|t] [extensions/WhoIsWatching] - 10https://gerrit.wikimedia.org/r/125128 [10:14:12] siebrand: I knew that thread. wctaiwan talked with me about that post [10:14:52] (03PS1) 10Siebrand: Remove zh-[cn|tw] in favour of zh-han[s|t] [extensions/UserMerge] - 10https://gerrit.wikimedia.org/r/125129 [10:14:56] liangent: What are your thoughts? [10:15:13] (03Merged) 10jenkins-bot: Remove unused key uploadlog [core] - 10https://gerrit.wikimedia.org/r/125076 (owner: 10Siebrand) [10:15:15] (03CR) 10jenkins-bot: [V: 04-1] Remove unused key upload-unknown-size [core] - 10https://gerrit.wikimedia.org/r/125080 (owner: 10Siebrand) [10:15:15] liangent: I think we need fewer zh- locales, not more. [10:15:17] (03CR) 10jenkins-bot: [V: 04-1] Remove unused key img-auth-bad-query-string [core] - 10https://gerrit.wikimedia.org/r/125081 (owner: 10Siebrand) [10:15:19] (03CR) 10jenkins-bot: [V: 04-1] Place parenthesis outsoude of code tag [core] - 10https://gerrit.wikimedia.org/r/125124 (owner: 10Siebrand) [10:15:30] * siebrand screams at jenkins-bot. [10:16:11] siebrand: how do you determine unused ? [10:16:29] thedj: By grepping all of core and extensions and looking at the results. [10:16:29] addshore: or ^^^ [10:16:48] * addshore does the same [10:16:50] siebrand: there are differences between zh-tw and zh-hk, but we should only use them for messages where workaround is impossible [10:17:01] siebrand: be careful, i remember that the keys for prefs for instance are 'assembled' with string concats [10:17:11] thedj: Thanks for the tip. [10:18:00] (03CR) 10jenkins-bot: [V: 04-1] Remove zh-[cn|tw] in favour of zh-han[s|t] [extensions/WikiLexicalData] - 10https://gerrit.wikimedia.org/r/125127 (owner: 10Siebrand) [10:18:22] (03PS2) 10Addshore: Place parenthesis outsoude of code tag [core] - 10https://gerrit.wikimedia.org/r/125124 (owner: 10Siebrand) [10:18:27] (03CR) 10Addshore: [C: 032] Place parenthesis outsoude of code tag [core] - 10https://gerrit.wikimedia.org/r/125124 (owner: 10Siebrand) [10:20:03] (03PS1) 10Siebrand: Remove zh-[cn|tw] in favour of zh-han[s|t] [extensions/timeline] - 10https://gerrit.wikimedia.org/r/125131 [10:20:57] (03PS1) 10Ori.livneh: Spelling: 'Bishnupria Manipuri' => 'Bishnupriya Manipuri' [extensions/cldr] - 10https://gerrit.wikimedia.org/r/125132 [10:21:57] (03CR) 10jenkins-bot: [V: 04-1] Remove unused key filehist-missing [core] - 10https://gerrit.wikimedia.org/r/125083 (owner: 10Siebrand) [10:21:58] (03CR) 10jenkins-bot: [V: 04-1] Remove unused key usermailererror [core] - 10https://gerrit.wikimedia.org/r/125084 (owner: 10Siebrand) [10:22:28] (03PS1) 10Siebrand: Remove zh-[cn|tw] in favour of zh-han[s|t] [extensions/PrefSwitch] - 10https://gerrit.wikimedia.org/r/125134 [10:22:55] (03PS1) 10Siebrand: Remove zh-[cn|tw] in favour of zh-han[s|t] [extensions/SiteMatrix] - 10https://gerrit.wikimedia.org/r/125135 [10:24:05] (03PS2) 10Addshore: Remove unused key upload-unknown-size [core] - 10https://gerrit.wikimedia.org/r/125080 (owner: 10Siebrand) [10:24:09] (03CR) 10Addshore: [C: 032] Remove unused key upload-unknown-size [core] - 10https://gerrit.wikimedia.org/r/125080 (owner: 10Siebrand) [10:24:14] (03PS2) 10Addshore: Remove unused key img-auth-bad-query-string [core] - 10https://gerrit.wikimedia.org/r/125081 (owner: 10Siebrand) [10:24:20] (03CR) 10Addshore: [C: 032] Remove unused key img-auth-bad-query-string [core] - 10https://gerrit.wikimedia.org/r/125081 (owner: 10Siebrand) [10:24:37] (03PS2) 10Addshore: Remove unused key filehist-missing [core] - 10https://gerrit.wikimedia.org/r/125083 (owner: 10Siebrand) [10:24:42] (03CR) 10Addshore: [C: 032] Remove unused key filehist-missing [core] - 10https://gerrit.wikimedia.org/r/125083 (owner: 10Siebrand) [10:24:47] (03PS2) 10Addshore: Remove unused key usermailererror [core] - 10https://gerrit.wikimedia.org/r/125084 (owner: 10Siebrand) [10:24:52] (03CR) 10Addshore: [C: 032] Remove unused key usermailererror [core] - 10https://gerrit.wikimedia.org/r/125084 (owner: 10Siebrand) [10:26:50] (03Merged) 10jenkins-bot: Remove unused key enotif_mailer [core] - 10https://gerrit.wikimedia.org/r/125092 (owner: 10Siebrand) [10:26:53] (03Merged) 10jenkins-bot: Remove unused key exblank [core] - 10https://gerrit.wikimedia.org/r/125093 (owner: 10Siebrand) [10:28:24] (03Merged) 10jenkins-bot: Remove unused key importhistoryconflict [core] - 10https://gerrit.wikimedia.org/r/125097 (owner: 10Siebrand) [10:28:26] (03CR) 10jenkins-bot: [V: 04-1] Remove unused key importnotext [core] - 10https://gerrit.wikimedia.org/r/125095 (owner: 10Siebrand) [10:28:40] (03PS1) 10Siebrand: Remove zh-[cn|tw] in favour of zh-han[s|t] [extensions/ReplaceText] - 10https://gerrit.wikimedia.org/r/125140 [10:30:25] (03PS1) 10Siebrand: Remove zh-[cn|tw] in favour of zh-han[s|t] [extensions/GoogleMaps] - 10https://gerrit.wikimedia.org/r/125142 [10:32:41] (03PS1) 10Siebrand: Remove zh-[cn|tw] in favour of zh-han[s|t] [core] - 10https://gerrit.wikimedia.org/r/125143 [10:32:46] (03PS2) 10Addshore: Remove unused key importnotext [core] - 10https://gerrit.wikimedia.org/r/125095 (owner: 10Siebrand) [10:32:50] (03CR) 10Addshore: [C: 032] Remove unused key importnotext [core] - 10https://gerrit.wikimedia.org/r/125095 (owner: 10Siebrand) [10:33:00] (03Merged) 10jenkins-bot: Update documentation for used message keys in Special:Emailuser [core] - 10https://gerrit.wikimedia.org/r/125099 (owner: 10Siebrand) [10:33:02] (03Merged) 10jenkins-bot: Remove unused key uploadedfiles [core] - 10https://gerrit.wikimedia.org/r/125078 (owner: 10Siebrand) [10:33:32] (03PS1) 10Siebrand: Remove zh-[cn|tw] in favour of zh-han[s|t] [extensions/DataTransfer] - 10https://gerrit.wikimedia.org/r/125144 [10:34:22] (03CR) 10jenkins-bot: [V: 04-1] Remove unused key uploadfromurl-queued [core] - 10https://gerrit.wikimedia.org/r/125079 (owner: 10Siebrand) [10:34:27] (03PS1) 10Siebrand: Remove zh-[cn|tw] in favour of zh-han[s|t] [extensions/ExpandTemplates] - 10https://gerrit.wikimedia.org/r/125145 [10:35:54] (03PS1) 10Siebrand: Remove zh-[cn|tw] in favour of zh-han[s|t] [extensions/Quiz] - 10https://gerrit.wikimedia.org/r/125146 [10:35:56] (03CR) 10jenkins-bot: [V: 04-1] Remove unused key upload-unknown-size [core] - 10https://gerrit.wikimedia.org/r/125080 (owner: 10Siebrand) [10:35:58] (03CR) 10jenkins-bot: [V: 04-1] Remove unused key img-auth-bad-query-string [core] - 10https://gerrit.wikimedia.org/r/125081 (owner: 10Siebrand) [10:37:34] (03Merged) 10jenkins-bot: Remove unused key nowikiemailtitle [core] - 10https://gerrit.wikimedia.org/r/125090 (owner: 10Siebrand) [10:37:36] (03Merged) 10jenkins-bot: Remove unused key usernamehasherror [core] - 10https://gerrit.wikimedia.org/r/125075 (owner: 10Siebrand) [10:37:38] (03Merged) 10jenkins-bot: Place parenthesis outsoude of code tag [core] - 10https://gerrit.wikimedia.org/r/125124 (owner: 10Siebrand) [10:37:55] (03PS1) 10Siebrand: Remove zh-[cn|tw] in favour of zh-han[s|t] [extensions/DynamicPageList] - 10https://gerrit.wikimedia.org/r/125147 [10:38:40] (03PS1) 10Siebrand: Remove zh-[cn|tw] in favour of zh-han[s|t] [extensions/Math] - 10https://gerrit.wikimedia.org/r/125148 [10:39:24] (03PS1) 10Siebrand: Remove zh-[cn|tw] in favour of zh-han[s|t] [extensions/InputBox] - 10https://gerrit.wikimedia.org/r/125149 [10:40:10] (03CR) 10jenkins-bot: [V: 04-1] Remove unused key usermailererror [core] - 10https://gerrit.wikimedia.org/r/125084 (owner: 10Siebrand) [10:40:12] (03PS1) 10Siebrand: Remove zh-[cn|tw] in favour of zh-han[s|t] [extensions/CSS] - 10https://gerrit.wikimedia.org/r/125150 [10:41:05] (03PS1) 10Siebrand: Remove zh-[cn|tw] in favour of zh-han[s|t] [extensions/FlaggedRevs] - 10https://gerrit.wikimedia.org/r/125151 [10:42:40] (03PS1) 10Siebrand: Remove zh-[cn|tw] in favour of zh-han[s|t] [extensions/CategoryTests] - 10https://gerrit.wikimedia.org/r/125152 [10:43:38] (03CR) 10jenkins-bot: [V: 04-1] Remove unused key filehist-missing [core] - 10https://gerrit.wikimedia.org/r/125083 (owner: 10Siebrand) [10:43:51] (03PS1) 10Siebrand: Remove zh-[cn|tw] in favour of zh-han[s|t] [extensions/ArticleFeedback] - 10https://gerrit.wikimedia.org/r/125153 [10:44:22] (03PS1) 10Siebrand: Remove zh-[cn|tw] in favour of zh-han[s|t] [extensions/DisableAccount] - 10https://gerrit.wikimedia.org/r/125154 [10:45:06] (03PS1) 10Siebrand: Remove zh-[cn|tw] in favour of zh-han[s|t] [extensions/CategoryTree] - 10https://gerrit.wikimedia.org/r/125155 [10:47:10] (03PS1) 10Siebrand: Remove zh-[cn|tw] in favour of zh-han[s|t] [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/125156 [10:48:59] (03PS1) 10Siebrand: Remove zh-[cn|tw] in favour of zh-han[s|t] [extensions/WatchSubpages] - 10https://gerrit.wikimedia.org/r/125157 [10:50:15] (03PS2) 10Siebrand: Remove zh-[cn|tw] in favour of zh-han[s|t] [extensions/SocialProfile] - 10https://gerrit.wikimedia.org/r/125125 [10:52:21] (03PS1) 10Siebrand: Remove zh-[sg|hk] in favour of zh-han[s|t] [extensions/News] - 10https://gerrit.wikimedia.org/r/125158 [10:54:23] (03PS1) 10Siebrand: Remove zh-[sg|hk] in favour of zh-han[s|t] [extensions/WikimediaMessages] - 10https://gerrit.wikimedia.org/r/125159 [10:54:55] (03PS1) 10Siebrand: Remove zh-[sg|hk] in favour of zh-han[s|t] [extensions/SecurePoll] - 10https://gerrit.wikimedia.org/r/125160 [10:55:20] (03PS1) 10Siebrand: Remove zh-[sg|hk] in favour of zh-han[s|t] [extensions/MWSearch] - 10https://gerrit.wikimedia.org/r/125161 [10:56:30] (03PS1) 10Siebrand: Remove zh-[sg|hk] in favour of zh-han[s|t] [extensions/AuthorProtect] - 10https://gerrit.wikimedia.org/r/125163 [10:56:58] (03PS1) 10Siebrand: Remove zh-[sg|hk] in favour of zh-han[s|t] [extensions/AdminLinks] - 10https://gerrit.wikimedia.org/r/125164 [10:57:44] (03PS1) 10Siebrand: Remove zh-[sg|hk] in favour of zh-han[s|t] [extensions/ApprovedRevs] - 10https://gerrit.wikimedia.org/r/125165 [10:58:48] (03PS1) 10Siebrand: Remove zh-[sg|hk] in favour of zh-han[s|t] [extensions/APC] - 10https://gerrit.wikimedia.org/r/125166 [10:59:24] (03PS1) 10Siebrand: Remove zh-[sg|hk] in favour of zh-han[s|t] [extensions/AntiSpoof] - 10https://gerrit.wikimedia.org/r/125167 [11:04:07] (03CR) 10jenkins-bot: [V: 04-1] Remove unused key importnotext [core] - 10https://gerrit.wikimedia.org/r/125095 (owner: 10Siebrand) [11:05:09] (03Merged) 10jenkins-bot: Remove unused key importnotext [core] - 10https://gerrit.wikimedia.org/r/125095 (owner: 10Siebrand) [11:13:52] (03CR) 10Siebrand: "Given the Wikipedia page, and Ethnologue/ISO 639-3 http://www.ethnologue.com/language/bpy , I think we can even make it Bishnupriya." [extensions/cldr] - 10https://gerrit.wikimedia.org/r/125132 (owner: 10Ori.livneh) [11:52:16] (03CR) 10Siebrand: [V: 032] "Ignore unrelated Jenkins fail." [core] - 10https://gerrit.wikimedia.org/r/125083 (owner: 10Siebrand) [11:52:39] (03CR) 10Siebrand: [V: 032] "Ignore unrelated Jenkins fail." [core] - 10https://gerrit.wikimedia.org/r/125084 (owner: 10Siebrand) [11:53:20] (03CR) 10Siebrand: [V: 032] "Ignore unrelated Jenkins fail." [core] - 10https://gerrit.wikimedia.org/r/125079 (owner: 10Siebrand) [11:53:40] (03CR) 10Siebrand: [V: 032] "Ignore unrelated Jenkins fail." [core] - 10https://gerrit.wikimedia.org/r/125080 (owner: 10Siebrand) [11:54:03] (03CR) 10Siebrand: [V: 032] "Ignore unrelated Jenkins fail." [core] - 10https://gerrit.wikimedia.org/r/125081 (owner: 10Siebrand) [11:55:14] (03CR) 10Siebrand: [C: 04-1] XML export inserted. Therefore a special page created. [extensions/PubSubHubbub] - 10https://gerrit.wikimedia.org/r/124862 (owner: 10Alexander.lehmann) [11:59:11] (03PS3) 10Alexander.lehmann: XML export inserted. Therefore a special page created. [extensions/PubSubHubbub] - 10https://gerrit.wikimedia.org/r/124862 [12:00:47] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/PubSubHubbub] - 10https://gerrit.wikimedia.org/r/124862 (owner: 10Alexander.lehmann) [12:06:20] (03PS1) 10Siebrand: Fixes for messages quoting each other [core] - 10https://gerrit.wikimedia.org/r/125175 [12:08:36] (03PS1) 10Mwjames: Update .travis.yml [skins/chameleon] - 10https://gerrit.wikimedia.org/r/125176 [12:09:07] (03PS2) 10Siebrand: Fixes for messages quoting each other and punctuation [core] - 10https://gerrit.wikimedia.org/r/125175 [12:18:22] (03CR) 10Helder.wiki: "Shouldn't this patch be live on 1.23wmf17? The page" [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/114094 (owner: 10Ori.livneh) [12:18:50] This can't be normal https://www.mediawiki.org/w/index.php?title=Beta_Features/Nearby_Pages&action=history [12:26:28] (03CR) 10Siebrand: [C: 031] "i18n/L10n reviewed." [extensions/PubSubHubbub] - 10https://gerrit.wikimedia.org/r/124862 (owner: 10Alexander.lehmann) [12:53:08] (03PS1) 10QChris: Set uploader to current user in "patchset-created" event upon cherry-picking [gerrit] (wmf) - 10https://gerrit.wikimedia.org/r/125181 [12:53:46] (03CR) 10QChris: "Upstream change is at" [gerrit] (wmf) - 10https://gerrit.wikimedia.org/r/125181 (owner: 10QChris) [13:00:56] (03CR) 10Yuvipanda: "Why not just have protocol relative URLs?" [core] - 10https://gerrit.wikimedia.org/r/125028 (owner: 10Gerrit Patch Uploader) [13:08:05] (03CR) 10Isarra: [C: 031] Revert font stack to be just sans-serif [core] - 10https://gerrit.wikimedia.org/r/124475 (owner: 10Odder) [13:37:30] (03PS1) 10Phuedx: Generate a token and use it to bucket users [extensions/GettingStarted] - 10https://gerrit.wikimedia.org/r/125188 [13:37:34] (03CR) 10jenkins-bot: [V: 04-1] Generate a token and use it to bucket users [extensions/GettingStarted] - 10https://gerrit.wikimedia.org/r/125188 (owner: 10Phuedx) [13:39:48] (03PS2) 10Phuedx: Generate a token and use it to bucket users [extensions/GettingStarted] - 10https://gerrit.wikimedia.org/r/125188 [13:46:46] (03CR) 10Nikerabbit: Fix TODO about core using json (031 comment) [extensions/LocalisationUpdate] - 10https://gerrit.wikimedia.org/r/124884 (owner: 10Nikerabbit) [13:49:19] (03CR) 10QChris: "Upstream change has been merged." [gerrit] (wmf) - 10https://gerrit.wikimedia.org/r/125181 (owner: 10QChris) [13:53:15] (03CR) 10Dan-nl: Do not overwrite content from community members/bots on re-upload (032 comments) [extensions/GWToolset] - 10https://gerrit.wikimedia.org/r/124347 (owner: 10Dan-nl) [13:55:41] (03PS4) 10Dan-nl: Do not overwrite content from community members/bots on re-upload [extensions/GWToolset] - 10https://gerrit.wikimedia.org/r/124347 [14:04:59] (03CR) 10MarkAHershberger: "Just from looking at the patch, I don't see how you would get mixed content warnings. Note I haven't tested this, but it would be nice to" [core] - 10https://gerrit.wikimedia.org/r/125027 (owner: 10Gerrit Patch Uploader) [14:10:17] (03CR) 10Anomie: Commit DB changes as normal on exception-based GUI errors (031 comment) [core] - 10https://gerrit.wikimedia.org/r/116625 (owner: 10Aaron Schulz) [14:16:01] (03PS1) 10Nemo bis: Remove translations of ignored 'helppage' message [core] - 10https://gerrit.wikimedia.org/r/125191 [14:34:19] (03CR) 10Anomie: [C: 032] Restore text for "Other" reason on Special:Block reason list [core] - 10https://gerrit.wikimedia.org/r/124912 (owner: 10Umherirrender) [14:37:31] (03Merged) 10jenkins-bot: Restore text for "Other" reason on Special:Block reason list [core] - 10https://gerrit.wikimedia.org/r/124912 (owner: 10Umherirrender) [14:44:26] (03CR) 10Raimond Spekking: [C: 032] Remove zh-[cn|tw] in favour of zh-han[s|t] [extensions/Math] - 10https://gerrit.wikimedia.org/r/125148 (owner: 10Siebrand) [14:44:30] (03CR) 10KartikMistry: [C: 032] "LGTM." [extensions/LocalisationUpdate] - 10https://gerrit.wikimedia.org/r/124884 (owner: 10Nikerabbit) [14:44:33] (03CR) 10Raimond Spekking: [C: 032] Remove zh-[sg|hk] in favour of zh-han[s|t] [extensions/AntiSpoof] - 10https://gerrit.wikimedia.org/r/125167 (owner: 10Siebrand) [14:44:34] (03Merged) 10jenkins-bot: Fix TODO about core using json [extensions/LocalisationUpdate] - 10https://gerrit.wikimedia.org/r/124884 (owner: 10Nikerabbit) [14:44:39] (03CR) 10Raimond Spekking: [C: 032] Remove zh-[cn|tw] in favour of zh-han[s|t] [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/125156 (owner: 10Siebrand) [14:44:41] (03Merged) 10jenkins-bot: Remove zh-[sg|hk] in favour of zh-han[s|t] [extensions/AntiSpoof] - 10https://gerrit.wikimedia.org/r/125167 (owner: 10Siebrand) [14:44:46] (03CR) 10Raimond Spekking: [C: 032] Remove zh-[cn|tw] in favour of zh-han[s|t] [extensions/FlaggedRevs] - 10https://gerrit.wikimedia.org/r/125151 (owner: 10Siebrand) [14:44:49] (03Merged) 10jenkins-bot: Remove zh-[cn|tw] in favour of zh-han[s|t] [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/125156 (owner: 10Siebrand) [14:44:52] (03CR) 10Raimond Spekking: [C: 032] Remove zh-[sg|hk] in favour of zh-han[s|t] [extensions/APC] - 10https://gerrit.wikimedia.org/r/125166 (owner: 10Siebrand) [14:44:54] (03Merged) 10jenkins-bot: Remove zh-[cn|tw] in favour of zh-han[s|t] [extensions/FlaggedRevs] - 10https://gerrit.wikimedia.org/r/125151 (owner: 10Siebrand) [14:44:58] (03Merged) 10jenkins-bot: Remove zh-[sg|hk] in favour of zh-han[s|t] [extensions/APC] - 10https://gerrit.wikimedia.org/r/125166 (owner: 10Siebrand) [14:45:00] (03CR) 10Raimond Spekking: [C: 032] Remove zh-[sg|hk] in favour of zh-han[s|t] [extensions/ApprovedRevs] - 10https://gerrit.wikimedia.org/r/125165 (owner: 10Siebrand) [14:45:02] (03Merged) 10jenkins-bot: Remove zh-[sg|hk] in favour of zh-han[s|t] [extensions/ApprovedRevs] - 10https://gerrit.wikimedia.org/r/125165 (owner: 10Siebrand) [14:45:05] (03CR) 10Raimond Spekking: [C: 032] Remove zh-[sg|hk] in favour of zh-han[s|t] [extensions/AdminLinks] - 10https://gerrit.wikimedia.org/r/125164 (owner: 10Siebrand) [14:45:11] (03CR) 10Raimond Spekking: [C: 032] Remove zh-[sg|hk] in favour of zh-han[s|t] [extensions/MWSearch] - 10https://gerrit.wikimedia.org/r/125161 (owner: 10Siebrand) [14:45:17] (03CR) 10Raimond Spekking: [C: 032] Remove zh-[sg|hk] in favour of zh-han[s|t] [extensions/SecurePoll] - 10https://gerrit.wikimedia.org/r/125160 (owner: 10Siebrand) [14:45:22] (03CR) 10Raimond Spekking: [C: 032] Remove zh-[sg|hk] in favour of zh-han[s|t] [extensions/WikimediaMessages] - 10https://gerrit.wikimedia.org/r/125159 (owner: 10Siebrand) [14:45:32] (03CR) 10Raimond Spekking: [C: 032] Remove zh-[cn|tw] in favour of zh-han[s|t] [extensions/CategoryTree] - 10https://gerrit.wikimedia.org/r/125155 (owner: 10Siebrand) [14:45:36] (03CR) 10Raimond Spekking: [C: 032] Remove zh-[cn|tw] in favour of zh-han[s|t] [extensions/DisableAccount] - 10https://gerrit.wikimedia.org/r/125154 (owner: 10Siebrand) [14:45:42] (03CR) 10Raimond Spekking: [C: 032] Remove zh-[cn|tw] in favour of zh-han[s|t] [extensions/ArticleFeedback] - 10https://gerrit.wikimedia.org/r/125153 (owner: 10Siebrand) [14:45:48] (03CR) 10Raimond Spekking: [C: 032] Remove zh-[cn|tw] in favour of zh-han[s|t] [extensions/InputBox] - 10https://gerrit.wikimedia.org/r/125149 (owner: 10Siebrand) [14:45:58] (03CR) 10Raimond Spekking: [C: 032 V: 032] Remove zh-[sg|hk] in favour of zh-han[s|t] [extensions/AuthorProtect] - 10https://gerrit.wikimedia.org/r/125163 (owner: 10Siebrand) [14:46:00] (03Merged) 10jenkins-bot: Remove zh-[sg|hk] in favour of zh-han[s|t] [extensions/MWSearch] - 10https://gerrit.wikimedia.org/r/125161 (owner: 10Siebrand) [14:46:02] (03Merged) 10jenkins-bot: Remove zh-[sg|hk] in favour of zh-han[s|t] [extensions/AdminLinks] - 10https://gerrit.wikimedia.org/r/125164 (owner: 10Siebrand) [14:46:04] (03Merged) 10jenkins-bot: Remove zh-[cn|tw] in favour of zh-han[s|t] [extensions/Math] - 10https://gerrit.wikimedia.org/r/125148 (owner: 10Siebrand) [14:46:06] (03Merged) 10jenkins-bot: Remove zh-[sg|hk] in favour of zh-han[s|t] [extensions/SecurePoll] - 10https://gerrit.wikimedia.org/r/125160 (owner: 10Siebrand) [14:46:08] (03Merged) 10jenkins-bot: Remove zh-[sg|hk] in favour of zh-han[s|t] [extensions/WikimediaMessages] - 10https://gerrit.wikimedia.org/r/125159 (owner: 10Siebrand) [14:46:10] (03CR) 10Raimond Spekking: [C: 032 V: 032] Remove zh-[sg|hk] in favour of zh-han[s|t] [extensions/News] - 10https://gerrit.wikimedia.org/r/125158 (owner: 10Siebrand) [14:46:12] (03Merged) 10jenkins-bot: Remove zh-[cn|tw] in favour of zh-han[s|t] [extensions/CategoryTree] - 10https://gerrit.wikimedia.org/r/125155 (owner: 10Siebrand) [14:46:14] (03Merged) 10jenkins-bot: Remove zh-[cn|tw] in favour of zh-han[s|t] [extensions/DisableAccount] - 10https://gerrit.wikimedia.org/r/125154 (owner: 10Siebrand) [14:46:16] (03Merged) 10jenkins-bot: Remove zh-[cn|tw] in favour of zh-han[s|t] [extensions/ArticleFeedback] - 10https://gerrit.wikimedia.org/r/125153 (owner: 10Siebrand) [14:46:18] (03CR) 10Raimond Spekking: [C: 032] Remove zh-[cn|tw] in favour of zh-han[s|t] [extensions/Quiz] - 10https://gerrit.wikimedia.org/r/125146 (owner: 10Siebrand) [14:46:20] (03Merged) 10jenkins-bot: Remove zh-[cn|tw] in favour of zh-han[s|t] [extensions/InputBox] - 10https://gerrit.wikimedia.org/r/125149 (owner: 10Siebrand) [14:46:22] (03CR) 10Raimond Spekking: [C: 032] Remove zh-[cn|tw] in favour of zh-han[s|t] [extensions/ExpandTemplates] - 10https://gerrit.wikimedia.org/r/125145 (owner: 10Siebrand) [14:46:24] (03CR) 10Raimond Spekking: [C: 032] Remove zh-[cn|tw] in favour of zh-han[s|t] [core] - 10https://gerrit.wikimedia.org/r/125143 (owner: 10Siebrand) [14:46:32] (03CR) 10Raimond Spekking: [C: 032 V: 032] Remove zh-[cn|tw] in favour of zh-han[s|t] [extensions/SocialProfile] - 10https://gerrit.wikimedia.org/r/125125 (owner: 10Siebrand) [14:46:40] (03CR) 10Raimond Spekking: [C: 032 V: 032] Remove zh-[cn|tw] in favour of zh-han[s|t] [extensions/WatchSubpages] - 10https://gerrit.wikimedia.org/r/125157 (owner: 10Siebrand) [14:46:48] (03CR) 10Raimond Spekking: [C: 032 V: 032] Remove zh-[cn|tw] in favour of zh-han[s|t] [extensions/CategoryTests] - 10https://gerrit.wikimedia.org/r/125152 (owner: 10Siebrand) [14:46:55] (03CR) 10Raimond Spekking: [C: 032] Remove zh-[cn|tw] in favour of zh-han[s|t] [extensions/ReplaceText] - 10https://gerrit.wikimedia.org/r/125140 (owner: 10Siebrand) [14:47:11] (03Merged) 10jenkins-bot: Remove zh-[cn|tw] in favour of zh-han[s|t] [extensions/Quiz] - 10https://gerrit.wikimedia.org/r/125146 (owner: 10Siebrand) [14:47:13] (03Merged) 10jenkins-bot: Remove zh-[cn|tw] in favour of zh-han[s|t] [extensions/ExpandTemplates] - 10https://gerrit.wikimedia.org/r/125145 (owner: 10Siebrand) [14:47:14] so much spam [14:47:29] (03Merged) 10jenkins-bot: Remove zh-[cn|tw] in favour of zh-han[s|t] [extensions/ReplaceText] - 10https://gerrit.wikimedia.org/r/125140 (owner: 10Siebrand) [14:48:02] (03CR) 10Raimond Spekking: [C: 032 V: 032] Remove zh-[cn|tw] in favour of zh-han[s|t] [extensions/CSS] - 10https://gerrit.wikimedia.org/r/125150 (owner: 10Siebrand) [14:48:12] (03CR) 10Raimond Spekking: [C: 032 V: 032] Remove zh-[cn|tw] in favour of zh-han[s|t] [extensions/DynamicPageList] - 10https://gerrit.wikimedia.org/r/125147 (owner: 10Siebrand) [14:48:27] (03CR) 10Raimond Spekking: [C: 032 V: 032] Remove zh-[cn|tw] in favour of zh-han[s|t] [extensions/DataTransfer] - 10https://gerrit.wikimedia.org/r/125144 (owner: 10Siebrand) [14:48:34] (03CR) 10Raimond Spekking: [C: 032 V: 032] Remove zh-[cn|tw] in favour of zh-han[s|t] [extensions/GoogleMaps] - 10https://gerrit.wikimedia.org/r/125142 (owner: 10Siebrand) [14:48:47] (03CR) 10Raimond Spekking: [C: 032] Remove zh-[cn|tw] in favour of zh-han[s|t] [extensions/SiteMatrix] - 10https://gerrit.wikimedia.org/r/125135 (owner: 10Siebrand) [14:48:51] (03Merged) 10jenkins-bot: Remove zh-[cn|tw] in favour of zh-han[s|t] [extensions/SiteMatrix] - 10https://gerrit.wikimedia.org/r/125135 (owner: 10Siebrand) [14:49:03] (03CR) 10Raimond Spekking: [C: 032] Remove zh-[cn|tw] in favour of zh-han[s|t] [extensions/timeline] - 10https://gerrit.wikimedia.org/r/125131 (owner: 10Siebrand) [14:49:06] (03Merged) 10jenkins-bot: Remove zh-[cn|tw] in favour of zh-han[s|t] [extensions/timeline] - 10https://gerrit.wikimedia.org/r/125131 (owner: 10Siebrand) [14:49:20] (03CR) 10Raimond Spekking: [C: 032 V: 032] Remove zh-[cn|tw] in favour of zh-han[s|t] [extensions/PrefSwitch] - 10https://gerrit.wikimedia.org/r/125134 (owner: 10Siebrand) [14:49:41] (03Merged) 10jenkins-bot: Remove zh-[cn|tw] in favour of zh-han[s|t] [core] - 10https://gerrit.wikimedia.org/r/125143 (owner: 10Siebrand) [14:51:39] (03CR) 10Raimond Spekking: [C: 032] Remove zh-[cn|tw] in favour of zh-han[s|t] [extensions/UserMerge] - 10https://gerrit.wikimedia.org/r/125129 (owner: 10Siebrand) [14:51:43] (03Merged) 10jenkins-bot: Remove zh-[cn|tw] in favour of zh-han[s|t] [extensions/UserMerge] - 10https://gerrit.wikimedia.org/r/125129 (owner: 10Siebrand) [14:51:55] (03CR) 10Raimond Spekking: [C: 032 V: 032] Remove zh-[cn|tw] in favour of zh-han[s|t] [extensions/WikiLexicalData] - 10https://gerrit.wikimedia.org/r/125127 (owner: 10Siebrand) [14:52:03] (03CR) 10Raimond Spekking: [C: 032 V: 032] Remove zh-[cn|tw] in favour of zh-han[s|t] [extensions/WhoIsWatching] - 10https://gerrit.wikimedia.org/r/125128 (owner: 10Siebrand) [14:52:10] (03CR) 10Raimond Spekking: [C: 032 V: 032] Remove zh-[cn|tw] in favour of zh-han[s|t] [extensions/WYSIWYG] - 10https://gerrit.wikimedia.org/r/125126 (owner: 10Siebrand) [14:55:01] (03PS3) 10Phuedx: Generate a token and use it to bucket users [extensions/GettingStarted] - 10https://gerrit.wikimedia.org/r/125188 [15:16:47] (03PS1) 10TheDJ: [WIP] Add option to show all keyboard shortcuts [extensions/CodeEditor] - 10https://gerrit.wikimedia.org/r/125195 [15:23:37] (03PS1) 10MarkAHershberger: Fix IE9's lack of support for console.warn.apply [core] - 10https://gerrit.wikimedia.org/r/125197 [15:24:28] (03PS1) 10Hashar: dashboard: remove pmtpa beta cluster jobs [integration/docroot] - 10https://gerrit.wikimedia.org/r/125198 [15:24:36] (03CR) 10Hashar: [C: 032] dashboard: remove pmtpa beta cluster jobs [integration/docroot] - 10https://gerrit.wikimedia.org/r/125198 (owner: 10Hashar) [15:24:39] (03Merged) 10jenkins-bot: dashboard: remove pmtpa beta cluster jobs [integration/docroot] - 10https://gerrit.wikimedia.org/r/125198 (owner: 10Hashar) [15:25:00] (03CR) 10jenkins-bot: [V: 04-1] Fix IE9's lack of support for console.warn.apply [core] - 10https://gerrit.wikimedia.org/r/125197 (owner: 10MarkAHershberger) [15:27:41] (03CR) 10Raimond Spekking: [C: 032] Remove translations of ignored 'helppage' message [core] - 10https://gerrit.wikimedia.org/r/125191 (owner: 10Nemo bis) [15:31:25] (03Merged) 10jenkins-bot: Remove translations of ignored 'helppage' message [core] - 10https://gerrit.wikimedia.org/r/125191 (owner: 10Nemo bis) [15:31:56] (03CR) 10Zfilipin: [C: 04-1] Add API method for page protection (031 comment) [ruby/api] - 10https://gerrit.wikimedia.org/r/125010 (owner: 10Jdlrobson) [15:33:00] (03PS1) 10Happy5214: Accept mw.title object as the title argument of frame:expandTemplate() [extensions/Scribunto] - 10https://gerrit.wikimedia.org/r/125207 [15:35:01] (03PS1) 10Gerrit Patch Uploader: Change "Attribution/Share-Alike" to "Attribution-ShareAlike" [extensions/WikimediaMessages] - 10https://gerrit.wikimedia.org/r/125208 [15:35:03] (03CR) 10Gerrit Patch Uploader: "This commit was uploaded using the Gerrit Patch Uploader [1]." [extensions/WikimediaMessages] - 10https://gerrit.wikimedia.org/r/125208 (owner: 10Gerrit Patch Uploader) [15:35:42] (03CR) 10PiRSquared17: [C: 04-1] "-1 until someone confirms this change is even desired" [extensions/WikimediaMessages] - 10https://gerrit.wikimedia.org/r/125208 (owner: 10Gerrit Patch Uploader) [15:36:00] (03CR) 10Hashar: "Siebrand: the qunit jobs fails from time to time in jquery.makeCollapsible which is https://bugzilla.wikimedia.org/show_bug.cgi?id=63579" [core] - 10https://gerrit.wikimedia.org/r/125095 (owner: 10Siebrand) [15:36:06] (03CR) 10Siebrand: [WIP] Add option to show all keyboard shortcuts (031 comment) [extensions/CodeEditor] - 10https://gerrit.wikimedia.org/r/125195 (owner: 10TheDJ) [15:38:35] (03PS1) 10Umherirrender: HTMLSelectOtherFields: Have 'other' always as first element [core] - 10https://gerrit.wikimedia.org/r/125209 [15:39:08] (03CR) 10Siebrand: "It's the correct notation. The previous was incorrect, and en.json has already been updated. I don't think this change should be done dire" [extensions/WikimediaMessages] - 10https://gerrit.wikimedia.org/r/125208 (owner: 10Gerrit Patch Uploader) [15:41:13] (03CR) 10PiRSquared17: "Ah, I was unaware of that special page on TWN." [extensions/WikimediaMessages] - 10https://gerrit.wikimedia.org/r/125208 (owner: 10Gerrit Patch Uploader) [15:44:38] (03PS4) 10Jforrester: Follow-up: If985b16c – Vector external link change release notes [core] - 10https://gerrit.wikimedia.org/r/124618 (owner: 10Jdlrobson) [15:45:01] (03CR) 10PiRSquared17: "Siebrand: could you please make the change on TWN instead?" [extensions/WikimediaMessages] - 10https://gerrit.wikimedia.org/r/125208 (owner: 10Gerrit Patch Uploader) [15:45:23] (03PS2) 10MarkAHershberger: Fix IE9's lack of support for console.warn.apply [core] - 10https://gerrit.wikimedia.org/r/125197 [15:45:31] (03CR) 10jenkins-bot: [V: 04-1] Follow-up: If985b16c – Vector external link change release notes [core] - 10https://gerrit.wikimedia.org/r/124618 (owner: 10Jdlrobson) [15:45:33] (03CR) 10Jforrester: [C: 032] Follow-up: If985b16c – Vector external link change release notes [core] - 10https://gerrit.wikimedia.org/r/124618 (owner: 10Jdlrobson) [15:45:45] (03PS5) 10Jforrester: Follow-up: If985b16c – Vector external link change release notes [core] - 10https://gerrit.wikimedia.org/r/124618 (owner: 10Jdlrobson) [15:45:51] (03CR) 10Jforrester: [C: 032] Follow-up: If985b16c – Vector external link change release notes [core] - 10https://gerrit.wikimedia.org/r/124618 (owner: 10Jdlrobson) [15:47:29] (03CR) 10jenkins-bot: [V: 04-1] Fix IE9's lack of support for console.warn.apply [core] - 10https://gerrit.wikimedia.org/r/125197 (owner: 10MarkAHershberger) [15:54:00] (03CR) 10Bartosz Dziewoński: [V: 032] mediawiki.jqueryMsg: Don't throw parse errors in the user's face [core] - 10https://gerrit.wikimedia.org/r/113307 (owner: 10Bartosz Dziewoński) [15:54:20] (03CR) 10jenkins-bot: [V: 04-1] Follow-up: If985b16c – Vector external link change release notes [core] - 10https://gerrit.wikimedia.org/r/124618 (owner: 10Jdlrobson) [15:54:22] (03Merged) 10jenkins-bot: Follow-up: If985b16c – Vector external link change release notes [core] - 10https://gerrit.wikimedia.org/r/124618 (owner: 10Jdlrobson) [16:00:53] (03CR) 10Siebrand: "Done: https://translatewiki.net/wiki/Special:Contributions/Siebrand" [extensions/WikimediaMessages] - 10https://gerrit.wikimedia.org/r/125208 (owner: 10Gerrit Patch Uploader) [16:02:23] (03CR) 10Bartosz Dziewoński: "Because the wikitech-l discussion is still ongoing. I don't see a pressing need to resolve this right now, and the typography refresh stor" [core] - 10https://gerrit.wikimedia.org/r/124475 (owner: 10Odder) [16:15:48] (03PS1) 10Siebrand: Remove zh-tw in favour of zh-hant [extensions/ConditionalShowSection] - 10https://gerrit.wikimedia.org/r/125218 [16:16:13] (03CR) 10Siebrand: [C: 032 V: 032] Remove zh-tw in favour of zh-hant [extensions/ConditionalShowSection] - 10https://gerrit.wikimedia.org/r/125218 (owner: 10Siebrand) [16:17:34] (03PS1) 10Nemo bis: Use an actual URL for helppage in enotif_body [core] - 10https://gerrit.wikimedia.org/r/125219 [16:24:38] (03PS3) 10MarkAHershberger: Fix IE9's lack of support for console.warn.apply [core] - 10https://gerrit.wikimedia.org/r/125197 [16:25:31] (03CR) 10jenkins-bot: [V: 04-1] Fix IE9's lack of support for console.warn.apply [core] - 10https://gerrit.wikimedia.org/r/125197 (owner: 10MarkAHershberger) [16:30:18] (03PS4) 10MarkAHershberger: Fix IE9's lack of support for console.warn.apply [core] - 10https://gerrit.wikimedia.org/r/125197 [16:31:45] (03CR) 10jenkins-bot: [V: 04-1] Fix IE9's lack of support for console.warn.apply [core] - 10https://gerrit.wikimedia.org/r/125197 (owner: 10MarkAHershberger) [16:32:32] (03CR) 10Nemo bis: [C: 04-1] "Needs release notes if we pick this path. See question on the bug though." [core] - 10https://gerrit.wikimedia.org/r/125219 (owner: 10Nemo bis) [16:40:54] (03PS1) 10Manybubbles: Add max_fragments_scored [search/highlighter] - 10https://gerrit.wikimedia.org/r/125222 [16:48:30] (03CR) 10Bartosz Dziewoński: "Pinging, the branch has been cut now." [core] - 10https://gerrit.wikimedia.org/r/114942 (owner: 10Bartosz Dziewoński) [16:49:53] (03CR) 10Manybubbles: [C: 032] Add max_fragments_scored [search/highlighter] - 10https://gerrit.wikimedia.org/r/125222 (owner: 10Manybubbles) [16:50:33] (03CR) 10Bartosz Dziewoński: [C: 032] "Can be merged now, a new branch has been cut and all possible caches should expire on 13 April (this Sunday)." [core] - 10https://gerrit.wikimedia.org/r/116790 (owner: 10Bartosz Dziewoński) [16:53:47] (03Merged) 10jenkins-bot: mediawiki.special: Remove HTML backwards-compatibility styles [core] - 10https://gerrit.wikimedia.org/r/116790 (owner: 10Bartosz Dziewoński) [16:54:53] (03CR) 10Chad: [C: 032] Switch from full sentences on new highlighter [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/124860 (owner: 10Manybubbles) [16:55:04] (03Merged) 10jenkins-bot: Switch from full sentences on new highlighter [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/124860 (owner: 10Manybubbles) [16:56:27] thanks, ^d ! [16:57:52] (03CR) 10Chad: [C: 032] Use multiple rescores to apply script scoring [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/124994 (owner: 10Manybubbles) [16:58:00] (03Merged) 10jenkins-bot: Use multiple rescores to apply script scoring [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/124994 (owner: 10Manybubbles) [16:58:26] (03CR) 10Chad: [C: 032] Add get_wikitext and make logging optional [ruby/api] - 10https://gerrit.wikimedia.org/r/124384 (owner: 10Manybubbles) [16:58:30] (03Merged) 10jenkins-bot: Add get_wikitext and make logging optional [ruby/api] - 10https://gerrit.wikimedia.org/r/124384 (owner: 10Manybubbles) [17:02:24] (03CR) 10Chad: "We need to figure out a solution here." [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/112500 (owner: 10Manybubbles) [17:02:50] (03CR) 10Chad: [C: 032] Cirrus now needs the Cite extension for testing [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/124011 (owner: 10Manybubbles) [17:02:58] (03PS4) 10Chad: Cirrus now needs the Cite extension for testing [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/124011 (owner: 10Manybubbles) [17:03:05] (03CR) 10Chad: [C: 032] Cirrus now needs the Cite extension for testing [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/124011 (owner: 10Manybubbles) [17:03:59] (03Merged) 10jenkins-bot: Cirrus now needs the Cite extension for testing [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/124011 (owner: 10Manybubbles) [17:04:12] (03CR) 10Manybubbles: "I think, maybe, splitting the prose and non-prose data would help. I doubt it is perfect, but it'll pull lots of the annoying stuff at th" [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/112500 (owner: 10Manybubbles) [17:07:31] (03PS1) 10Kipcool: annotation buttons on the left they are more visible [extensions/WikiLexicalData] - 10https://gerrit.wikimedia.org/r/125227 [17:08:00] (03CR) 10Kipcool: [C: 032 V: 032] annotation buttons on the left they are more visible [extensions/WikiLexicalData] - 10https://gerrit.wikimedia.org/r/125227 (owner: 10Kipcool) [17:08:12] (03PS1) 10Matthias Mullie: Add (yet another) abstract collection class [extensions/Flow] - 10https://gerrit.wikimedia.org/r/125228 [17:09:07] (03CR) 10Matthias Mullie: "Input welcome ;)" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/125228 (owner: 10Matthias Mullie) [17:19:04] (03PS1) 10Manybubbles: Fix no match sentence fragmenter on short text [search/highlighter] - 10https://gerrit.wikimedia.org/r/125230 [17:20:15] (03CR) 10Manybubbles: [C: 032] Fix no match sentence fragmenter on short text [search/highlighter] - 10https://gerrit.wikimedia.org/r/125230 (owner: 10Manybubbles) [17:42:33] (03PS2) 10Robmoen: Create base UI module. [extensions/UploadWizard] (oojsify) - 10https://gerrit.wikimedia.org/r/123818 [17:44:52] (03PS3) 10Robmoen: Create base UI module. [extensions/UploadWizard] (oojsify) - 10https://gerrit.wikimedia.org/r/123818 [17:45:52] (03CR) 10Robmoen: [C: 04-1] "Still WIP. Loads more to do. UW is mostly working inside OO Dialog. :)" [extensions/UploadWizard] (oojsify) - 10https://gerrit.wikimedia.org/r/123818 (owner: 10Robmoen) [17:46:28] (03CR) 10Thiemo Mättig (WMDE): [C: 031] "I uploaded an image to illustrate what the patch really means: https://bugzilla.wikimedia.org/show_bug.cgi?id=59172#c10" [core] - 10https://gerrit.wikimedia.org/r/124827 (owner: 10Bartosz Dziewoński) [17:50:42] Hey am working on this patch and I need to create a form element. More specifically a textbox with labels and a submit button at the end. I was wondering if I should use a Xml::openElement or a html::element [17:51:18] Both seem to be doing the same thing the file I am working on uses Xml::openElement in one part which I am re-writting [17:56:52] aditya_sastry: in practice both should be equivalent, but we usually use the Html:: variants (unless actually dealing with XML, not HTML) [17:59:39] (03PS1) 10Umherirrender: Document new param of Title::countRevisionsBetween [core] - 10https://gerrit.wikimedia.org/r/125239 [18:02:03] (03PS1) 10Bsitu: Some clean up to header [extensions/Flow] - 10https://gerrit.wikimedia.org/r/125240 [18:02:06] (03CR) 10jenkins-bot: [V: 04-1] Some clean up to header [extensions/Flow] - 10https://gerrit.wikimedia.org/r/125240 (owner: 10Bsitu) [18:04:50] @MatmaRex the xml class submit button, label functions too .. Do I still need to use the Html::variants ? [18:05:06] aditya_sastry: no, generally no one cares [18:05:51] (03CR) 10Krinkle: "@Siebrand: There is no reasonable way to fully determine what does and does not affect a test. We already have job filtering (e.g. if no ." [core] - 10https://gerrit.wikimedia.org/r/125079 (owner: 10Siebrand) [18:06:03] @MatmaRex so I am going ahead turning all of these to html::elements. Thank you. [18:13:43] JeroenDeDauw, around? [18:15:15] (03CR) 10Jforrester: [C: 032] Fixes for messages quoting each other and punctuation [core] - 10https://gerrit.wikimedia.org/r/125175 (owner: 10Siebrand) [18:17:38] (03CR) 10PiRSquared17: "This change should be abandoned now that it has been fixed." [extensions/WikimediaMessages] - 10https://gerrit.wikimedia.org/r/125208 (owner: 10Gerrit Patch Uploader) [18:18:25] (03PS2) 10Krinkle: Use new banana checker as a linter to avoid lacking qqq messages [core] - 10https://gerrit.wikimedia.org/r/125050 (owner: 10Jforrester) [18:19:29] (03CR) 10jenkins-bot: [V: 04-1] Fixes for messages quoting each other and punctuation [core] - 10https://gerrit.wikimedia.org/r/125175 (owner: 10Siebrand) [18:20:35] (03CR) 10Jforrester: [C: 032] "*grumbles*" [core] - 10https://gerrit.wikimedia.org/r/125175 (owner: 10Siebrand) [18:23:49] (03Merged) 10jenkins-bot: Fixes for messages quoting each other and punctuation [core] - 10https://gerrit.wikimedia.org/r/125175 (owner: 10Siebrand) [18:23:52] (03PS1) 10Bsitu: Use merge() to update cache data [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/125243 [18:24:40] (03PS2) 10Bsitu: Use merge() to update cache data [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/125243 [18:24:53] (03CR) 10jenkins-bot: [V: 04-1] Use new banana checker as a linter to avoid lacking qqq messages [core] - 10https://gerrit.wikimedia.org/r/125050 (owner: 10Jforrester) [18:28:59] qgil: Once upon a time wasn't there a group of people who were a welcoming committee, basically, for new MW contributors? [18:29:15] I recall Valerie being on it, and myself [18:29:20] But don't remember the name [18:32:05] (03PS1) 10Reedy: Update MultimediaViewer to head of wmf/1.23wmf21 branch [core] (wmf/1.23wmf21) - 10https://gerrit.wikimedia.org/r/125244 [18:32:46] (03CR) 10Reedy: [C: 032 V: 032] Update MultimediaViewer to head of wmf/1.23wmf21 branch [core] (wmf/1.23wmf21) - 10https://gerrit.wikimedia.org/r/125244 (owner: 10Reedy) [18:33:54] Currently looking for page on mw.org with multiple images that is not [[Lightbox demo]], if anyone has ideas [18:34:09] (03Abandoned) 10Reedy: Update CentralAuth to pull the token reset maint. script [core] (wmf/1.23wmf20) - 10https://gerrit.wikimedia.org/r/124768 (owner: 10Hoo man) [18:34:52] (03PS1) 10Brian Wolff: Exclude external RC entries (e.g. Wikidata) from Special:ActiveUsers [core] - 10https://gerrit.wikimedia.org/r/125246 [18:38:01] anyone here speak german well? [18:39:18] <^demon> cscott: I can do WWII-era Hollywood impressions of a German. [18:39:26] cscott, lemme be your guinea pig [18:39:32] <^demon> That's about it though :( [18:40:00] cscott: how can I help? [18:40:04] andre__: https://bugzilla.wikimedia.org/show_bug.cgi?id=62258#c8 [18:40:25] bleh. filenames. [18:40:35] ^ there are about 20 pages on dewiki which use height bounds on images with the 'framed' option set, which is going to break in the next release [18:40:43] ah [18:40:47] they just need to be changed to use 'thumb' instead [18:41:04] which in almost every case is what the author really meant. [18:41:26] the official docs for the 'frame' option says it ignores any size specification and displayed an unscaled image [18:41:40] (03CR) 10Aaron Schulz: [C: 032] Exclude external RC entries (e.g. Wikidata) from Special:ActiveUsers [core] - 10https://gerrit.wikimedia.org/r/125246 (owner: 10Brian Wolff) [18:41:42] some people apparently figured out that there's a bug, and it doesn't actually ignore a height specification [18:42:10] but i'm hoping to fix that bug (https://gerrit.wikimedia.org/r/#/c/116995/) [18:43:06] i fixed "Gliederung des Feldheeres (Bundeswehr, Heeresstruktur 4)", "Hauptkirche Sankt Michaelis (Hamburg)", and "Ceylor" but it's hard going for me since i don't read german [18:43:40] and then i have to leave a commit message which is in english and that seems antisocial [18:44:06] hi marktraceur , we tried... but it requires more fuel and regular work: https://www.mediawiki.org/wiki/Greeters [18:44:24] cscott, I miss file endings in that list in https://bugzilla.wikimedia.org/show_bug.cgi?id=62258#c8 [18:44:42] (03Merged) 10jenkins-bot: Exclude external RC entries (e.g. Wikidata) from Special:ActiveUsers [core] - 10https://gerrit.wikimedia.org/r/125246 (owner: 10Brian Wolff) [18:44:50] or are those files all hosted on Commons and just embedded in de.wp? [18:45:00] andre__: sorry, the list is page title, and then image file name [18:45:02] cscott, any example link to an edit that you've made already [18:45:05] qgil: Mostly I was interested in the page because it's got multiple pictures on it [18:45:10] cscott, ah! [18:45:15] https://de.wikipedia.org/w/index.php?title=Hauptkirche_Sankt_Michaelis_%28Hamburg%29&diff=129396939&oldid=129292349 [18:45:19] (03PS1) 10Krinkle: IEFixes: Clean up duplicate variables [core] - 10https://gerrit.wikimedia.org/r/125249 [18:45:21] (03PS1) 10Krinkle: IEFixes.js: Remove relativeforfloats() as it doesn't work [core] - 10https://gerrit.wikimedia.org/r/125250 [18:45:39] marktraceur, interesting connection :) [18:46:55] cscott, let me fix the rest then [18:47:08] (that's what you wanted to hear, right? :P ) [18:48:10] (03CR) 10Brian Wolff: "Visual editor interacts with this in a way I forgot about - https://www.mediawiki.org/wiki/File:Example.png . On browsers not supporting v" [core] - 10https://gerrit.wikimedia.org/r/104182 (owner: 10TTO) [18:48:17] andre__: thanks so much! [18:48:22] cscott, np [18:48:35] andre__: can you just put a note in the bugzilla that you've done so? [18:48:37] (03PS2) 10Krinkle: IEFixes.js: Remove relativeforfloats() as it doesn't work [core] - 10https://gerrit.wikimedia.org/r/125250 [18:48:43] cscott, sure, will do [18:48:46] thanks [18:52:09] (03PS1) 10Umherirrender: Fixed some @params documentation [core] - 10https://gerrit.wikimedia.org/r/125253 [18:52:21] (03CR) 10Jforrester: [C: 032] IEFixes.js: Remove relativeforfloats() as it doesn't work [core] - 10https://gerrit.wikimedia.org/r/125250 (owner: 10Krinkle) [18:53:30] (03CR) 10Aaron Schulz: [C: 032] Document new param of Title::countRevisionsBetween [core] - 10https://gerrit.wikimedia.org/r/125239 (owner: 10Umherirrender) [18:53:40] (03CR) 10jenkins-bot: [V: 04-1] IEFixes: Clean up duplicate variables [core] - 10https://gerrit.wikimedia.org/r/125249 (owner: 10Krinkle) [18:57:07] (03Merged) 10jenkins-bot: Document new param of Title::countRevisionsBetween [core] - 10https://gerrit.wikimedia.org/r/125239 (owner: 10Umherirrender) [18:58:28] (03CR) 10jenkins-bot: [V: 04-1] Fixed some @params documentation [core] - 10https://gerrit.wikimedia.org/r/125253 (owner: 10Umherirrender) [18:58:55] (03PS1) 10Kipcool: i18n repaired [extensions/WikiLexicalData] - 10https://gerrit.wikimedia.org/r/125256 [18:59:25] (03CR) 10Kipcool: [C: 032 V: 032] i18n repaired [extensions/WikiLexicalData] - 10https://gerrit.wikimedia.org/r/125256 (owner: 10Kipcool) [18:59:31] (03PS2) 10Umherirrender: Fixed some @params documentation [core] - 10https://gerrit.wikimedia.org/r/125253 [19:00:48] (03PS1) 10Krinkle: Update grunt-cli and jshint to newer upstream versions [integration/jenkins] - 10https://gerrit.wikimedia.org/r/125257 [19:02:59] (03CR) 10Krinkle: [C: 032] "MediaWiki core (and other projects using grunt/npm) were already using jshint 2.4.x via grunt-contrib-jshint. This makes the raw -jslint j" [integration/jenkins] - 10https://gerrit.wikimedia.org/r/125257 (owner: 10Krinkle) [19:03:04] (03Merged) 10jenkins-bot: Update grunt-cli and jshint to newer upstream versions [integration/jenkins] - 10https://gerrit.wikimedia.org/r/125257 (owner: 10Krinkle) [19:03:20] (03PS1) 10Umherirrender: Remove trailing spaces from some language files [core] - 10https://gerrit.wikimedia.org/r/125259 [19:04:04] (03PS3) 10Aaron Schulz: Profiler class refactoring [core] - 10https://gerrit.wikimedia.org/r/125059 [19:05:30] (03PS2) 10Krinkle: IEFixes: Clean up duplicate variables [core] - 10https://gerrit.wikimedia.org/r/125249 [19:06:35] (03CR) 10jenkins-bot: [V: 04-1] Fixed some @params documentation [core] - 10https://gerrit.wikimedia.org/r/125253 (owner: 10Umherirrender) [19:08:08] (03PS3) 10Krinkle: IEFixes.js: Remove relativeforfloats() as it doesn't work [core] - 10https://gerrit.wikimedia.org/r/125250 [19:11:16] (03CR) 10jenkins-bot: [V: 04-1] Profiler class refactoring [core] - 10https://gerrit.wikimedia.org/r/125059 (owner: 10Aaron Schulz) [19:11:29] (03CR) 10Aaron Schulz: Commit DB changes as normal on exception-based GUI errors (031 comment) [core] - 10https://gerrit.wikimedia.org/r/116625 (owner: 10Aaron Schulz) [19:14:12] (03PS1) 10Krinkle: Update tests/frontend devDependencies [core] - 10https://gerrit.wikimedia.org/r/125263 [19:15:18] manybubbles: you being slow was a joke, right? [19:15:32] Nikerabbit: ? [19:15:35] I took days! [19:15:37] (03CR) 10Krinkle: [C: 032] mediawiki.api: Use FormData for POST requests when supported [core] - 10https://gerrit.wikimedia.org/r/116037 (owner: 10JGonera) [19:16:23] manybubbles: we were working on it for days, and you always gave comments few hours after when we were looking for them ;) [19:19:03] (03Merged) 10jenkins-bot: mediawiki.api: Use FormData for POST requests when supported [core] - 10https://gerrit.wikimedia.org/r/116037 (owner: 10JGonera) [19:20:12] (03CR) 10jenkins-bot: [V: 04-1] Update tests/frontend devDependencies [core] - 10https://gerrit.wikimedia.org/r/125263 (owner: 10Krinkle) [19:20:24] (03PS2) 10Krinkle: Update tests/frontend devDependencies [core] - 10https://gerrit.wikimedia.org/r/125263 [19:21:58] manybubbles: what's the jq package? [19:22:05] (03PS7) 10Krinkle: [WIP] Investigate swinging qunit test failure [core] - 10https://gerrit.wikimedia.org/r/124372 [19:22:15] (03CR) 10Krinkle: [C: 04-1] (DRAFT) Hotfix: grunt-lib-phantomjs Date mockery protection [integration/jenkins] - 10https://gerrit.wikimedia.org/r/125039 (owner: 10Krinkle) [19:22:40] jq implements a funky processing language on top of json. it is useful instead of awk hackery for getting data out of elasticsearch [19:22:50] we started using it before elasticsearch's _cat apis [19:22:57] (03CR) 10Nikerabbit: [C: 032] Remove trailing spaces from some language files [core] - 10https://gerrit.wikimedia.org/r/125259 (owner: 10Umherirrender) [19:23:13] and some of the scripts we have for it are more exact for what we need then the _cat apis [19:23:17] Nikerabbit: ^^ [19:23:26] manybubbles: oh I see [19:23:46] (03PS4) 10Aaron Schulz: Commit DB changes as normal on exception-based GUI errors [core] - 10https://gerrit.wikimedia.org/r/116625 [19:24:09] when you need to get the wikis with the top 10 average shard sizes, it does the job [19:25:13] (03CR) 10Bsitu: Implement a redirector at Special:Flow (031 comment) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/121306 (owner: 10Wctaiwan) [19:25:48] manybubbles: looks handy indeed, I'll remember that when I need to work with json stuff [19:25:53] yeah [19:25:55] ! [19:25:55] Hello, I'm wm-bot. The database for this channel is published at http://bots.wmflabs.org/~wm-bot/db/%23mediawiki.htm More about WM-Bot: https://meta.wikimedia.org/wiki/wm-bot [19:27:49] (03Merged) 10jenkins-bot: Remove trailing spaces from some language files [core] - 10https://gerrit.wikimedia.org/r/125259 (owner: 10Umherirrender) [19:28:54] (03CR) 10jenkins-bot: [V: 04-1] [WIP] Investigate swinging qunit test failure [core] - 10https://gerrit.wikimedia.org/r/124372 (owner: 10Krinkle) [19:29:05] (03PS3) 10Umherirrender: Fixed some @params documentation [core] - 10https://gerrit.wikimedia.org/r/125253 [19:32:27] (03PS11) 10Wctaiwan: Implement a redirector at Special:Flow [extensions/Flow] - 10https://gerrit.wikimedia.org/r/121306 [19:32:47] (03CR) 10Wctaiwan: Implement a redirector at Special:Flow (031 comment) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/121306 (owner: 10Wctaiwan) [19:38:44] Hey I was asked to do a rebase on this patch I was working on like at the end of this month. Now when I push the changed patch after rebase it is trying to send another commit by matma.rex [19:38:52] Is it fine if I send that commit too ? [19:39:02] end of previous month* [19:39:26] o hi. [19:39:44] mamamia: probably, but let's check before we do that [19:40:37] @MatmaRex its this common elements commit that you did on 29 th march. [19:41:00] mamamia: this usually happens if your local information is not up-to-date [19:41:27] @MatmaRex I just did a rebase for that .... So should I go ahead push it ? [19:41:28] that is, your local repository doesn't know where does this other commit come from [19:41:31] in a way [19:41:33] can you run `git fetch gerrit` first to (hopefully) update it? [19:41:57] generally, Gerrit makes things not behave very well sometimes. :/ [19:42:09] Is it going to download a lot of content cause am on my neighbour's wifi :P [19:42:33] it shouldn't [19:43:00] mamamia: you probably can just push that other commit anyway, in the worse case it'll create a new changeset on Gerrit that we'll just abandon [19:43:05] worst case* [19:44:46] (03PS1) 10Yuvipanda: Use simple JSON files to deliver config info to apps [extensions/MobileApp] - 10https://gerrit.wikimedia.org/r/125272 [19:44:52] MaxSem: ^ [19:45:32] MaxSem: trivial merge? [19:45:50] (03CR) 10MaxSem: [C: 032] Use simple JSON files to deliver config info to apps [extensions/MobileApp] - 10https://gerrit.wikimedia.org/r/125272 (owner: 10Yuvipanda) [19:45:56] MaxSem: woo! [19:45:57] ty! [19:46:32] MaxSem: no jenkins for it yet I think? [19:46:42] (03CR) 10Jforrester: [C: 032] Update tests/frontend devDependencies [core] - 10https://gerrit.wikimedia.org/r/125263 (owner: 10Krinkle) [19:47:47] (03CR) 10MaxSem: [V: 032] Use simple JSON files to deliver config info to apps [extensions/MobileApp] - 10https://gerrit.wikimedia.org/r/125272 (owner: 10Yuvipanda) [19:48:57] (03CR) 10Jforrester: Add script to send notifications for new features (031 comment) [extensions/BetaFeatures] - 10https://gerrit.wikimedia.org/r/84625 (owner: 10MarkTraceur) [19:49:47] (03PS7) 10Jforrester: Add script to send notifications for new features [extensions/BetaFeatures] - 10https://gerrit.wikimedia.org/r/84625 (owner: 10MarkTraceur) [19:49:49] (03CR) 10jenkins-bot: [V: 04-1] Add script to send notifications for new features [extensions/BetaFeatures] - 10https://gerrit.wikimedia.org/r/84625 (owner: 10MarkTraceur) [19:49:55] (03Merged) 10jenkins-bot: Update tests/frontend devDependencies [core] - 10https://gerrit.wikimedia.org/r/125263 (owner: 10Krinkle) [19:50:46] (03PS8) 10Jforrester: Add script to send notifications for new features [extensions/BetaFeatures] - 10https://gerrit.wikimedia.org/r/84625 (owner: 10MarkTraceur) [19:50:55] (03CR) 10Jforrester: "PS8 is a rebase." [extensions/BetaFeatures] - 10https://gerrit.wikimedia.org/r/84625 (owner: 10MarkTraceur) [19:52:33] legoktm: If you get https://gerrit.wikimedia.org/r/#/c/84625/ merged I love you forever. ;-) [19:52:55] I'll look at it tonight [19:53:06] I think the only thing left was the email messages [20:00:06] (03PS11) 10Ganeshaditya1: ChangeEmail special page rewritten to use vforms. [core] - 10https://gerrit.wikimedia.org/r/121975 [20:04:51] (03PS12) 10Ganeshaditya1: ChangeEmail special page rewritten to use vforms. [core] - 10https://gerrit.wikimedia.org/r/121975 [20:08:00] (03PS13) 10Ganeshaditya1: ChangeEmail special page rewritten to use vforms. [core] - 10https://gerrit.wikimedia.org/r/121975 [20:10:17] @Nikerabbit could you please check the file now ^ [20:11:47] @MatmaRex ^ [20:13:53] (03Abandoned) 10Raimond Spekking: Change "Attribution/Share-Alike" to "Attribution-ShareAlike" [extensions/WikimediaMessages] - 10https://gerrit.wikimedia.org/r/125208 (owner: 10Gerrit Patch Uploader) [20:15:33] @MatmaRex are you there ? You left comments on a previous patchset for that patch .. https://gerrit.wikimedia.org/r/121975 [20:23:39] (03PS1) 10Yuvipanda: Flip config var for anon editing in apps to allow [extensions/MobileApp] - 10https://gerrit.wikimedia.org/r/125275 [20:23:41] MaxSem: ^ trivial merge? [20:24:21] (03CR) 10Jforrester: [C: 032] IEFixes: Clean up duplicate variables [core] - 10https://gerrit.wikimedia.org/r/125249 (owner: 10Krinkle) [20:24:37] (03PS1) 10Manybubbles: Small changes to cirrus role [vagrant] - 10https://gerrit.wikimedia.org/r/125276 [20:24:44] (03CR) 10Jforrester: [C: 032] IEFixes.js: Remove relativeforfloats() as it doesn't work [core] - 10https://gerrit.wikimedia.org/r/125250 (owner: 10Krinkle) [20:25:20] (03CR) 10MaxSem: [C: 032 V: 032] Flip config var for anon editing in apps to allow [extensions/MobileApp] - 10https://gerrit.wikimedia.org/r/125275 (owner: 10Yuvipanda) [20:25:26] MaxSem: ty! [20:27:49] (03CR) 10jenkins-bot: [V: 04-1] IEFixes: Clean up duplicate variables [core] - 10https://gerrit.wikimedia.org/r/125249 (owner: 10Krinkle) [20:27:51] (03CR) 10jenkins-bot: [V: 04-1] IEFixes.js: Remove relativeforfloats() as it doesn't work [core] - 10https://gerrit.wikimedia.org/r/125250 (owner: 10Krinkle) [20:29:34] (03PS1) 10Manybubbles: Fix maintenance script when index has the alias [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/125295 [20:30:40] (03PS6) 10Jforrester: Better text for in core [core] - 10https://gerrit.wikimedia.org/r/83662 [20:31:05] (03CR) 10Jforrester: "PS6 is a revert to PS4, and a rebase onto the new i18n structure." [core] - 10https://gerrit.wikimedia.org/r/83662 (owner: 10Jforrester) [20:32:44] (03CR) 10WikidataJenkins: "Build Successful" [extensions/PubSubHubbub] - 10https://gerrit.wikimedia.org/r/125310 (owner: 10L10n-bot) [20:33:41] (03CR) 10Brian Wolff: "I doubt it makes much of a difference given how we use these functions, but wouldn't the no $ sign version be more "correct"." [core] - 10https://gerrit.wikimedia.org/r/114942 (owner: 10Bartosz Dziewoński) [20:35:42] legoktm: So I'm doing php maintenance/sendEchoNotifications.php --name="multimedia-viewer" and nothing is happenin' [20:35:55] (03CR) 10Jforrester: "Let's see if qunit passes this time." [core] - 10https://gerrit.wikimedia.org/r/125249 (owner: 10Krinkle) [20:35:56] My preference for the notification is on, and the preference is disabled for me [20:35:59] But no dice [20:36:35] marktraceur: and MMV is registering the betafeature? [20:36:47] Seems to be, it shows up in the BF page [20:37:12] Also no error complaining about invalid preference name [20:38:29] (03PS1) 10Foxtrott: bugfix ($this not allowed in closure); +2 more fixes [skins/chameleon] - 10https://gerrit.wikimedia.org/r/125324 [20:38:34] (03CR) 10Siebrand: "recheck" [core] - 10https://gerrit.wikimedia.org/r/125050 (owner: 10Jforrester) [20:39:04] Hm [20:39:22] (03CR) 10jenkins-bot: [V: 04-1] Use new banana checker as a linter to avoid lacking qqq messages [core] - 10https://gerrit.wikimedia.org/r/125050 (owner: 10Jforrester) [20:39:54] (03CR) 10Foxtrott: [C: 032 V: 032] bugfix ($this not allowed in closure); +2 more fixes [skins/chameleon] - 10https://gerrit.wikimedia.org/r/125324 (owner: 10Foxtrott) [20:42:16] ok, let me test it [20:42:30] I'm debugging too [20:42:34] The query looks good [20:42:38] But the foreach never runs for me [20:42:50] (03PS3) 10Jforrester: Use new banana checker as a linter to avoid lacking qqq messages [core] - 10https://gerrit.wikimedia.org/r/125050 [20:43:07] (03CR) 10Jforrester: "PS3 is a rebase. Down to 72 messages, yay." [core] - 10https://gerrit.wikimedia.org/r/125050 (owner: 10Jforrester) [20:43:09] wait but you said that it wasn't detecting invalid preference names [20:43:21] 29 +» » if ( !isset( $features[$pref] ) ) { [20:43:21] 30 +» » » throw new MWException( 'Preference given is not valid' ); [20:43:29] which makes it seem like the error is earlier [20:43:34] (03CR) 10Swalling: "@Nikerabbit" [core] - 10https://gerrit.wikimedia.org/r/83662 (owner: 10Jforrester) [20:44:37] No no [20:44:44] legoktm: The preference name is correct [20:44:55] I've determined that the query returns no rows for some reason [20:45:27] hrmmmmmmmm [20:46:59] Maybe something weird with makeList [20:47:02] (03CR) 10Siebrand: [C: 04-1] "Yay for consistency. Thanks for the effort. One optional comment and one, I think, real issue." (032 comments) [core] - 10https://gerrit.wikimedia.org/r/125253 (owner: 10Umherirrender) [20:47:31] Yeah, telling it just the string for web subscription makes it work [20:47:52] :| [20:47:57] (03CR) 10Siebrand: [C: 031] "i18n/L10n reviewed." [extensions/Flow] - 10https://gerrit.wikimedia.org/r/121306 (owner: 10Wctaiwan) [20:48:04] oh [20:48:11] I think [20:48:34] it has to be 'up_property = ' . $db->makeList [20:48:37] rather than => [20:48:50] (03CR) 10jenkins-bot: [V: 04-1] Use new banana checker as a linter to avoid lacking qqq messages [core] - 10https://gerrit.wikimedia.org/r/125050 (owner: 10Jforrester) [20:48:57] legoktm: No, 'cause up_value works fine... [20:49:02] (03CR) 10Siebrand: "Sorry. Thanks for spotting." [extensions/WikiLexicalData] - 10https://gerrit.wikimedia.org/r/125256 (owner: 10Kipcool) [20:49:37] OH, hm [20:49:42] I see what you mean [20:49:45] marktraceur: right, because that's just a simple string. but ->makeList is a raw mysql value which shouldn't be quoted [20:50:21] makeList( array( 'up_property' => 'echo-subscriptions-email-betafeatures', ...) ) maybe? [20:50:40] Hm, no. [20:50:43] You're probably right [20:50:47] (03PS1) 10Manybubbles: Fix a warning [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/125325 [20:51:19] Hey I am trying to push my old patch that I was working on .. I was asked to do a rebase as the messages have changed.. How ever when I did a rebase I keep getting this error [20:51:19] https://gerrit.wikimedia.org/r/121975 [20:51:31] sorry [20:51:33] I get this error [20:51:34] Auto-merging languages/messages/MessagesEn.php [20:51:34] CONFLICT (content): Merge conflict in languages/messages/MessagesEn.php [20:52:25] aditya_sastry: That's a normal part of the process. It means you have to manually fix conflicts [20:53:18] @bawolff well, all I did was git review -d 117854 and then git rebase master what conflicts do I need to resolve ? [20:53:35] aditya_sastry: Actually in this particular case, MessagesEn.php is gone now, as its languages/i18n/en.json [20:53:57] legoktm: I have it working, pushing now [20:54:07] :D [20:54:19] (03PS9) 10MarkTraceur: Add script to send notifications for new features [extensions/BetaFeatures] - 10https://gerrit.wikimedia.org/r/84625 [20:54:19] Basically you need to manually fix any conflicts with a text editor. Open up the files mentioned and look for lines with >>>>>, =====, and <<<<<< [20:54:37] @bawolff OMG :O when did that happen !! what changes do I need to make !! [20:55:04] (03CR) 10MarkTraceur: [C: 031] "Apart from the issue I just fixed, this looks crackerjack." [extensions/BetaFeatures] - 10https://gerrit.wikimedia.org/r/84625 (owner: 10MarkTraceur) [20:55:08] Those markers git adds when it can't figure out how to merge changes [20:55:28] (03PS12) 10Welterkj: use imagemap class for HTML rendering [extensions/GraphViz] - 10https://gerrit.wikimedia.org/r/111475 [20:55:48] In your particular case, during merging you have to move any messages you added so they are in languages/i18n/en.json instead of languages/messages/MessagesEn.php [20:56:12] Ohhh ! Can I just abandon this change and push a new patch ? [20:56:28] Is it fine with you guys ? [20:56:49] (03CR) 10MarkTraceur: [C: 04-1] "Actually wait, I don't see the betafeatures-echo-title message actually showing up. You may need to add it to the frontend messages somewh" [extensions/BetaFeatures] - 10https://gerrit.wikimedia.org/r/84625 (owner: 10MarkTraceur) [20:57:40] (03CR) 10Welterkj: "Removed mid-line tabs." (032 comments) [extensions/GraphViz] - 10https://gerrit.wikimedia.org/r/111475 (owner: 10Welterkj) [20:57:51] aditya_sastry: You can do a totally new patch if you want, but don't abandon the old one in gerrit, instead when submitting the new one, make sure in the commit message, the Change-Id: line at the bottom is exactly the same as the old patch on gerrit [20:58:03] *Change-id message at bottom of commit message [20:58:10] legoktm: Little l10n issue but otherwise awesome [20:58:32] aditya_sastry: For info on resolving conflicts, the best tutorial I could find was http://git-scm.com/book/en/Git-Branching-Basic-Branching-and-Merging#Basic-Merge-Conflicts (not quite exactly on the right topic, but close enough) [20:59:03] hmm [20:59:16] Echo should handle that serverside since it just returns rendered html [20:59:25] @bawolff I am fairly new to gerrit. I am new to git as well .. How do I make the change-id same for the new patch in gerrit ? [21:01:03] When you go to make your new patch and run git commit [21:01:13] and are typing in the commit message, just make sure the last line is [21:01:32] Change-Id: IAB34423 [21:01:50] Replacing the IAB34423 with whatever it is on the old patch [21:02:01] okay .. [21:02:36] (03PS1) 10Gerrit Patch Uploader: Apply coding convections for whitespaces [core] - 10https://gerrit.wikimedia.org/r/125328 [21:02:38] (03CR) 10Gerrit Patch Uploader: "This commit was uploaded using the Gerrit Patch Uploader [1]." [core] - 10https://gerrit.wikimedia.org/r/125328 (owner: 10Gerrit Patch Uploader) [21:03:31] aditya_sastry: And don't worry too much, worst case scenario it doesn't work correctly, we can always abandon the patch and try again [21:03:56] (03CR) 10jenkins-bot: [V: 04-1] Apply coding convections for whitespaces [core] - 10https://gerrit.wikimedia.org/r/125328 (owner: 10Gerrit Patch Uploader) [21:04:04] @bawolff yeah !! :) [21:22:01] @bawolf what happened to the message.inc file ? is it intact ? [21:22:14] (03CR) 10Aaron Schulz: [C: 032] Use merge() to update cache data [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/125243 (owner: 10Bsitu) [21:22:25] (03Merged) 10jenkins-bot: Use merge() to update cache data [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/125243 (owner: 10Bsitu) [21:22:47] bawolff: ^^ [21:23:02] aditya_sastry: Try typing "baw" and then pressing the tab key on your keyboard. :) [21:23:30] aditya_sastry: You don't have to update that file anymore [21:23:44] marktraceur, thats super cool man :) [21:24:02] bawolff, okay ! [21:28:03] (03PS1) 10Siebrand: Fix typo in comment [core] - 10https://gerrit.wikimedia.org/r/125330 [21:29:43] (03PS14) 10Ganeshaditya1: Display a warning when the user name looked up is not registered. [core] - 10https://gerrit.wikimedia.org/r/117854 [21:32:50] Where would i find the code that prints exceptions "safely"? i need to turn it off in dev [21:35:21] (03PS15) 10Ganeshaditya1: Display a warning when the user name looked up is not registered. [core] - 10https://gerrit.wikimedia.org/r/117854 [21:35:46] !gerrit 24276faf6835424f27a423778fd0049c7a21f9be [21:35:47] https://gerrit.wikimedia.org/r/#q,24276faf6835424f27a423778fd0049c7a21f9be,n,z [21:36:40] (03PS16) 10Ganeshaditya1: Display a warning when the user name looked up is not registered. [core] - 10https://gerrit.wikimedia.org/r/117854 [21:38:02] (03CR) 10Foxtrott: [C: 032 V: 032] "Don't have a real clue, but it sure looks good. :D" [skins/chameleon] - 10https://gerrit.wikimedia.org/r/125176 (owner: 10Mwjames) [21:38:04] (03CR) 10jenkins-bot: [V: 04-1] Display a warning when the user name looked up is not registered. [core] - 10https://gerrit.wikimedia.org/r/117854 (owner: 10Ganeshaditya1) [21:39:59] (03PS17) 10Ganeshaditya1: Display a warning when the user name looked up is not registered. [core] - 10https://gerrit.wikimedia.org/r/117854 [21:40:47] (03PS18) 10Ganeshaditya1: Display a warning when the user name looked up is not registered. [core] - 10https://gerrit.wikimedia.org/r/117854 [21:42:27] (03CR) 10jenkins-bot: [V: 04-1] Display a warning when the user name looked up is not registered. [core] - 10https://gerrit.wikimedia.org/r/117854 (owner: 10Ganeshaditya1) [21:42:39] ebernhardson: includes/exception/MWExceptionHandler.php [21:44:07] @jackmcbarn could you check out this patch now ? This is after the new message files have been introduced ^ [21:45:08] aditya_sastry: are you Ganeshaditya1? [21:45:27] yes [21:45:40] (03CR) 10Brian Wolff: "jslint unit test failure appears to have nothing to do with this patch" [core] - 10https://gerrit.wikimedia.org/r/117854 (owner: 10Ganeshaditya1) [21:46:42] (03PS13) 10Welterkj: use imagemap class for HTML rendering [extensions/GraphViz] - 10https://gerrit.wikimedia.org/r/111475 [21:48:46] (03CR) 10Siebrand: [C: 032 V: 032] Localisation updates from https://translatewiki.net. [core] - 10https://gerrit.wikimedia.org/r/125333 (owner: 10L10n-bot) [21:49:55] (03PS1) 10BryanDavis: Allow hyphen (-) in dsh hostnames [tools/scap] - 10https://gerrit.wikimedia.org/r/125334 [21:50:09] (03PS4) 10Siebrand: Use new banana checker as a linter to avoid lacking qqq messages [core] - 10https://gerrit.wikimedia.org/r/125050 (owner: 10Jforrester) [21:51:19] (03CR) 10BryanDavis: "Needed in beta. I tried this via a manual edit there." [tools/scap] - 10https://gerrit.wikimedia.org/r/125334 (owner: 10BryanDavis) [21:51:38] (03CR) 10Esanders: "fyi [BREAKING CHANGE] means... breaking change" [core] - 10https://gerrit.wikimedia.org/r/121537 (owner: 10Jforrester) [21:53:55] (03CR) 10Siebrand: [C: 031] "i18n/L10n reviewed." [extensions/GraphViz] - 10https://gerrit.wikimedia.org/r/111475 (owner: 10Welterkj) [21:56:54] (03CR) 10jenkins-bot: [V: 04-1] Use new banana checker as a linter to avoid lacking qqq messages [core] - 10https://gerrit.wikimedia.org/r/125050 (owner: 10Jforrester) [21:57:03] (03CR) 10Siebrand: "Ambiguous feelings. I think "Beta Features" should be "Beta features". Apparently it's been promoted to a Proper Noun now, which makes loc" [extensions/BetaFeatures] - 10https://gerrit.wikimedia.org/r/84625 (owner: 10MarkTraceur) [21:58:20] (03CR) 10TTO: "See bug 63666 and https://gerrit.wikimedia.org/r/124775 :)" [core] - 10https://gerrit.wikimedia.org/r/104182 (owner: 10TTO) [21:58:22] (03PS4) 10Robmoen: Create base UI module. [extensions/UploadWizard] (oojsify) - 10https://gerrit.wikimedia.org/r/123818 [21:58:38] (03CR) 10Robmoen: [C: 04-1] "WIP" [extensions/UploadWizard] (oojsify) - 10https://gerrit.wikimedia.org/r/123818 (owner: 10Robmoen) [22:02:14] (03CR) 10Siebrand: [C: 032 V: 032] Localisation updates from https://translatewiki.net. [core] - 10https://gerrit.wikimedia.org/r/125336 (owner: 10L10n-bot) [22:02:28] (03PS5) 10Siebrand: Use new banana checker as a linter to avoid lacking qqq messages [core] - 10https://gerrit.wikimedia.org/r/125050 (owner: 10Jforrester) [22:05:57] (03PS1) 10Ganeshaditya1: Changed the watchlist-detail message as required. [core] - 10https://gerrit.wikimedia.org/r/125337 [22:06:36] Krenair: pong [22:07:06] JeroenDeDauw, https://gerrit.wikimedia.org/r/#/c/125233/ [22:07:21] (03CR) 10jenkins-bot: [V: 04-1] Changed the watchlist-detail message as required. [core] - 10https://gerrit.wikimedia.org/r/125337 (owner: 10Ganeshaditya1) [22:07:57] @Nemo_bis https://gerrit.wikimedia.org/r/125337 [22:08:03] (03CR) 10Mwjames: "> Don't have a real clue, but it sure looks good. :D" [skins/chameleon] - 10https://gerrit.wikimedia.org/r/125176 (owner: 10Mwjames) [22:10:12] (03CR) 10jenkins-bot: [V: 04-1] Use new banana checker as a linter to avoid lacking qqq messages [core] - 10https://gerrit.wikimedia.org/r/125050 (owner: 10Jforrester) [22:11:07] aditya_sastry: Just for reference, the -1 on your changes aren't your fault, you can ignore them [22:11:18] Krenair: looks good, though I really am no longer up to speed with EP [22:11:25] There used to be more then one NS [22:11:29] Is there just one now? [22:11:34] JeroenDeDauw, there is the talk NS [22:11:34] Something's wrong with the jslint test page I guess ! [22:11:39] but I think that's fine [22:12:19] (03CR) 10Siebrand: [C: 04-1] "It looks like the script has an issue. Core obviously has 2 en.json files, and when langauges/i18n/en.json didn't yet pass, it looks like " [core] - 10https://gerrit.wikimedia.org/r/125050 (owner: 10Jforrester) [22:15:16] (03CR) 10Brian Wolff: "Recently all the patches submitted by (non-trusted) users have been failing the jslint tests on files not touched by the patch. Maybe this" [integration/jenkins] - 10https://gerrit.wikimedia.org/r/125257 (owner: 10Krinkle) [22:15:49] (03CR) 10Aaron Schulz: [C: 04-1] "Needs clearer use case IMO." [core] - 10https://gerrit.wikimedia.org/r/119002 (owner: 10devunt) [22:18:58] (03CR) 10Krinkle: "No, this is what fixes that by upgrading the jshint used by non-trusted users (node-jshint) to the same version we've been using in npm/gr" [integration/jenkins] - 10https://gerrit.wikimedia.org/r/125257 (owner: 10Krinkle) [22:22:46] (03CR) 10Krinkle: "Multiple tasks are executes in sequence. This is a trade off between not executing pointless tasks (e.g. installing mediawiki, setting up " [core] - 10https://gerrit.wikimedia.org/r/125050 (owner: 10Jforrester) [22:24:08] (03CR) 10Krinkle: "If you want to pursue one could try requesting a feature in upstream grunt to group tasks that are on the same "dependency" level (e.g. fa" [core] - 10https://gerrit.wikimedia.org/r/125050 (owner: 10Jforrester) [22:31:00] (03CR) 10Chad: [C: 032] Fix maintenance script when index has the alias [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/125295 (owner: 10Manybubbles) [22:31:10] (03Merged) 10jenkins-bot: Fix maintenance script when index has the alias [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/125295 (owner: 10Manybubbles) [22:31:12] (03CR) 10Chad: [C: 032] Fix a warning [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/125325 (owner: 10Manybubbles) [22:31:20] (03Merged) 10jenkins-bot: Fix a warning [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/125325 (owner: 10Manybubbles) [22:32:08] (03CR) 10Esanders: "https://bugzilla.wikimedia.org/show_bug.cgi?id=63791" [core] - 10https://gerrit.wikimedia.org/r/121537 (owner: 10Jforrester) [22:35:15] (03CR) 10Aaron Schulz: [C: 04-1] "Needs rebase" [core] - 10https://gerrit.wikimedia.org/r/103589 (owner: 10Anomie) [22:50:37] (03CR) 10Adamw: [C: 032] Merge changes from master into wip/editorcampaigns [extensions/Campaigns] (wip/editorcampaigns) - 10https://gerrit.wikimedia.org/r/122133 (owner: 10AndyRussG) [22:50:42] (03Merged) 10jenkins-bot: Merge changes from master into wip/editorcampaigns [extensions/Campaigns] (wip/editorcampaigns) - 10https://gerrit.wikimedia.org/r/122133 (owner: 10AndyRussG) [22:54:18] (03CR) 10Parent5446: [C: 04-1] Generic data store (038 comments) [core] - 10https://gerrit.wikimedia.org/r/79029 (owner: 10MaxSem) [22:58:17] (03CR) 10Brian Wolff: [C: 031] "I'm supportive of this patch. See my comment on the bug" [core] - 10https://gerrit.wikimedia.org/r/125219 (owner: 10Nemo bis) [22:59:54] (03CR) 10MaxSem: Generic data store (033 comments) [core] - 10https://gerrit.wikimedia.org/r/79029 (owner: 10MaxSem) [23:00:28] (03CR) 10Adamw: [C: 032] DI: global $wgCampaignsDI, improve tests and doc (032 comments) [extensions/Campaigns] (wip/editorcampaigns) - 10https://gerrit.wikimedia.org/r/123170 (owner: 10AndyRussG) [23:00:33] (03Merged) 10jenkins-bot: DI: global $wgCampaignsDI, improve tests and doc [extensions/Campaigns] (wip/editorcampaigns) - 10https://gerrit.wikimedia.org/r/123170 (owner: 10AndyRussG) [23:09:31] (03CR) 10Adamw: [C: 031] "Would +2, but is marked WIP" (031 comment) [extensions/Campaigns] (wip/editorcampaigns) - 10https://gerrit.wikimedia.org/r/122223 (owner: 10AndyRussG) [23:09:51] (03CR) 10Rillke: [C: 031] "of course" [core] - 10https://gerrit.wikimedia.org/r/125337 (owner: 10Ganeshaditya1) [23:12:20] (03PS2) 10Krinkle: jquery.suggestions: Debounce calls to $.suggestions.special [core] - 10https://gerrit.wikimedia.org/r/124827 (owner: 10Bartosz Dziewoński) [23:12:30] (03PS2) 10Rillke: Clarify the "Watchlist-details" message [core] - 10https://gerrit.wikimedia.org/r/125337 (owner: 10Ganeshaditya1) [23:13:03] (03CR) 10Krinkle: [C: 032] jquery.suggestions: Debounce calls to $.suggestions.special [core] - 10https://gerrit.wikimedia.org/r/124827 (owner: 10Bartosz Dziewoński) [23:15:16] (03CR) 10jenkins-bot: [V: 04-1] Clarify the "Watchlist-details" message [core] - 10https://gerrit.wikimedia.org/r/125337 (owner: 10Ganeshaditya1) [23:16:38] (03CR) 10Krinkle: "@MarkAHershberger : I don't think that's a reasonable solution. I don't want to down-talk this change, but since to clarify to you followi" [extensions/LiquidThreads] - 10https://gerrit.wikimedia.org/r/123836 (owner: 10Adi.iiita) [23:16:41] (03CR) 10Krinkle: [C: 04-1] LQT should not accept duplicate post [extensions/LiquidThreads] - 10https://gerrit.wikimedia.org/r/123836 (owner: 10Adi.iiita) [23:17:22] (03Merged) 10jenkins-bot: jquery.suggestions: Debounce calls to $.suggestions.special [core] - 10https://gerrit.wikimedia.org/r/124827 (owner: 10Bartosz Dziewoński) [23:20:54] (03PS1) 10AndyRussG: Trigger unit tests for the Campaigns extension [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/125344 [23:22:05] (03CR) 10Ori.livneh: [C: 032] Allow hyphen (-) in dsh hostnames [tools/scap] - 10https://gerrit.wikimedia.org/r/125334 (owner: 10BryanDavis) [23:22:17] (03Merged) 10jenkins-bot: Allow hyphen (-) in dsh hostnames [tools/scap] - 10https://gerrit.wikimedia.org/r/125334 (owner: 10BryanDavis) [23:22:40] ^demon|away: how do i update that frontend-rewrite branch you created? i thought i could do `git checkout gerrit/frontend-rewrite; git reset --hard gerrit/master; git review frontend-rewrite' to get it up-to-date with master...but that doesnt work :( [23:22:41] (03CR) 10Adamw: [C: 031] "Hopefully this is enuf!" [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/125344 (owner: 10AndyRussG) [23:23:04] * ebernhardson now notices away ... shucks [23:23:11] <^demon|away> Hmm? [23:23:12] <^demon|away> Pastebin? [23:24:07] (03PS1) 10Bsitu: Use of new OutputPage() is deprecated [extensions/Flow] - 10https://gerrit.wikimedia.org/r/125345 [23:26:37] (03CR) 10Rillke: [C: 031] "Build errors unrelated." [core] - 10https://gerrit.wikimedia.org/r/125337 (owner: 10Ganeshaditya1) [23:26:39] (03CR) 10Ori.livneh: [C: 032] Small changes to cirrus role [vagrant] - 10https://gerrit.wikimedia.org/r/125276 (owner: 10Manybubbles) [23:26:45] (03Merged) 10jenkins-bot: Small changes to cirrus role [vagrant] - 10https://gerrit.wikimedia.org/r/125276 (owner: 10Manybubbles) [23:35:15] ^demon|away: I had problems too. `git push origin frontend-rewrite` fails with "remote: To push into this reference you need 'Push' rights." [23:35:41] sec [23:35:46] er [23:35:57] Krinkle: Is https://gerrit.wikimedia.org/r/#/c/125257/ deployed yet then (I notice its merged)? Because patches by new users seem to still be failing pretty universially [23:36:20] erri [23:36:49] (03CR) 10Parent5446: Generic data store (033 comments) [core] - 10https://gerrit.wikimedia.org/r/79029 (owner: 10MaxSem) [23:36:59] ^demon|away: http://pastie.org/9071585 [23:38:12] (03PS13) 10Trevor Parscal: resourceloader: Optimize module registry sent in the startup module [core] - 10https://gerrit.wikimedia.org/r/72534 (owner: 10Hoo man) [23:38:31] (03PS1) 10Spage: Specify default-branch in .gitreview [extensions/Flow] (frontend-rewrite) - 10https://gerrit.wikimedia.org/r/125346 [23:38:36] <^demon|away> ebernhardson: Are all these commits on the branch you're wanting to commit? [23:38:45] <^demon|away> If not, I'd rebase on master first. [23:38:48] ^demon|away: no, those are the commits to master since this branch was cut [23:39:05] <^demon|away> Yeah then I'd rebase your branch on master. [23:39:10] <^demon|away> So you end up with a clean history to submit. [23:39:15] ^demon|away: theres nothing to rebase though, no new commits [23:39:18] i'll try anyways [23:40:18] ^demon|away: same output with rebase: http://pastie.org/9071590 [23:40:19] (03PS2) 10Spage: Specify default-branch in .gitreview [extensions/Flow] (frontend-rewrite) - 10https://gerrit.wikimedia.org/r/125346 [23:40:40] ebernhardson: ^ that seems based on latest origin/master [23:40:53] spagewmf: ooh, how you manage? [23:41:32] ebernhardson: I changed .gitreview, commited and did git review. Then did git rebase, and a second git review. [23:42:55] ebernhardson: when you checkout wmf/1.23wmf20 , it has a different .gitreview with a different defaultbranch line. That's why it works for you [23:45:27] (03CR) 10EBernhardson: [C: 032] Specify default-branch in .gitreview [extensions/Flow] (frontend-rewrite) - 10https://gerrit.wikimedia.org/r/125346 (owner: 10Spage) [23:45:40] (03Merged) 10jenkins-bot: Specify default-branch in .gitreview [extensions/Flow] (frontend-rewrite) - 10https://gerrit.wikimedia.org/r/125346 (owner: 10Spage) [23:45:59] atus [23:46:21] f'ing rebase .. might as well just cherry pick all these patches [23:48:03] because fancy aint just for vim: git log --oneline -12 new-json | tac | cut -d ' ' -f 1 | xargs git cherry-pick [23:49:45] * ebernhardson notes hes in the wrong room again :P [23:50:40] (03PS28) 10Bsitu: Add topic summary revision type [extensions/Flow] - 10https://gerrit.wikimedia.org/r/117357 [23:51:03] (03PS2) 10Ori.livneh: Removed $wgMaxBacklinksInvalidate [core] - 10https://gerrit.wikimedia.org/r/124782 (owner: 10Aaron Schulz) [23:51:45] (03PS1) 10EBernhardson: [WIP] new json output [extensions/Flow] (frontend-rewrite) - 10https://gerrit.wikimedia.org/r/125348 [23:51:48] (03PS1) 10EBernhardson: Include LightnCandy vendor files [extensions/Flow] (frontend-rewrite) - 10https://gerrit.wikimedia.org/r/125349 [23:51:51] (03PS1) 10EBernhardson: Accept scope parameter for partial template expansion [extensions/Flow] (frontend-rewrite) - 10https://gerrit.wikimedia.org/r/125350 [23:51:54] (03PS1) 10EBernhardson: Check for existance before seeing if its an array in variable expansion [extensions/Flow] (frontend-rewrite) - 10https://gerrit.wikimedia.org/r/125351 [23:51:57] (03PS1) 10EBernhardson: Add SafeString output for custom helpers [extensions/Flow] (frontend-rewrite) - 10https://gerrit.wikimedia.org/r/125352 [23:52:00] (03PS1) 10EBernhardson: Strip extended handlebars comments [extensions/Flow] (frontend-rewrite) - 10https://gerrit.wikimedia.org/r/125353 [23:52:03] (03PS1) 10EBernhardson: More SafeString for lightncandy [extensions/Flow] (frontend-rewrite) - 10https://gerrit.wikimedia.org/r/125354 [23:52:06] (03PS1) 10EBernhardson: Convert {#custom}...{/custom} helpers to be more like handlebars-2.0 [extensions/Flow] (frontend-rewrite) - 10https://gerrit.wikimedia.org/r/125355 [23:52:09] (03PS1) 10EBernhardson: Add @root special variable to access root scope [extensions/Flow] (frontend-rewrite) - 10https://gerrit.wikimedia.org/r/125356 [23:52:12] (03PS1) 10EBernhardson: Initial import of handlebars templates [extensions/Flow] (frontend-rewrite) - 10https://gerrit.wikimedia.org/r/125357 [23:52:15] (03PS1) 10EBernhardson: First stab at new template rendering in php [extensions/Flow] (frontend-rewrite) - 10https://gerrit.wikimedia.org/r/125358 [23:52:18] (03CR) 10jenkins-bot: [V: 04-1] Check for existance before seeing if its an array in variable expansion [extensions/Flow] (frontend-rewrite) - 10https://gerrit.wikimedia.org/r/125351 (owner: 10EBernhardson) [23:52:26] (03CR) 10jenkins-bot: [V: 04-1] [WIP] new json output [extensions/Flow] (frontend-rewrite) - 10https://gerrit.wikimedia.org/r/125348 (owner: 10EBernhardson) [23:52:37] (03CR) 10jenkins-bot: [V: 04-1] Include LightnCandy vendor files [extensions/Flow] (frontend-rewrite) - 10https://gerrit.wikimedia.org/r/125349 (owner: 10EBernhardson) [23:52:48] (03CR) 10jenkins-bot: [V: 04-1] Accept scope parameter for partial template expansion [extensions/Flow] (frontend-rewrite) - 10https://gerrit.wikimedia.org/r/125350 (owner: 10EBernhardson) [23:53:00] (03CR) 10jenkins-bot: [V: 04-1] Add SafeString output for custom helpers [extensions/Flow] (frontend-rewrite) - 10https://gerrit.wikimedia.org/r/125352 (owner: 10EBernhardson) [23:53:12] (03CR) 10jenkins-bot: [V: 04-1] Strip extended handlebars comments [extensions/Flow] (frontend-rewrite) - 10https://gerrit.wikimedia.org/r/125353 (owner: 10EBernhardson) [23:53:23] (03CR) 10jenkins-bot: [V: 04-1] More SafeString for lightncandy [extensions/Flow] (frontend-rewrite) - 10https://gerrit.wikimedia.org/r/125354 (owner: 10EBernhardson) [23:53:33] (03CR) 10jenkins-bot: [V: 04-1] Convert {#custom}...{/custom} helpers to be more like handlebars-2.0 [extensions/Flow] (frontend-rewrite) - 10https://gerrit.wikimedia.org/r/125355 (owner: 10EBernhardson) [23:53:44] (03CR) 10jenkins-bot: [V: 04-1] Add @root special variable to access root scope [extensions/Flow] (frontend-rewrite) - 10https://gerrit.wikimedia.org/r/125356 (owner: 10EBernhardson) [23:53:55] (03CR) 10jenkins-bot: [V: 04-1] Initial import of handlebars templates [extensions/Flow] (frontend-rewrite) - 10https://gerrit.wikimedia.org/r/125357 (owner: 10EBernhardson) [23:53:59] (03CR) 10jenkins-bot: [V: 04-1] First stab at new template rendering in php [extensions/Flow] (frontend-rewrite) - 10https://gerrit.wikimedia.org/r/125358 (owner: 10EBernhardson) [23:54:32] (03PS3) 10Ori.livneh: Removed $wgMaxBacklinksInvalidate [core] - 10https://gerrit.wikimedia.org/r/124782 (owner: 10Aaron Schulz) [23:54:38] (03CR) 10Ori.livneh: [C: 032] Removed $wgMaxBacklinksInvalidate [core] - 10https://gerrit.wikimedia.org/r/124782 (owner: 10Aaron Schulz) [23:55:38] (03PS20) 10Bsitu: Closing & reopening topic [extensions/Flow] - 10https://gerrit.wikimedia.org/r/118399 [23:58:41] (03Merged) 10jenkins-bot: Removed $wgMaxBacklinksInvalidate [core] - 10https://gerrit.wikimedia.org/r/124782 (owner: 10Aaron Schulz)