[00:01:55] (03PS4) 10Legoktm: PHPUnit mock builder doesnt accept leading \ [extensions/Thanks] - 10https://gerrit.wikimedia.org/r/123451 (owner: 10EBernhardson) [00:02:46] (03CR) 10Legoktm: [C: 032] PHPUnit mock builder doesnt accept leading \ [extensions/Thanks] - 10https://gerrit.wikimedia.org/r/123451 (owner: 10EBernhardson) [00:03:03] (03Merged) 10jenkins-bot: PHPUnit mock builder doesnt accept leading \ [extensions/Thanks] - 10https://gerrit.wikimedia.org/r/123451 (owner: 10EBernhardson) [00:04:04] (03CR) 10Legoktm: "Removing myself as a reviewer, feel free to add me back once this is no longer WIP." [extensions/WikiForum] - 10https://gerrit.wikimedia.org/r/116258 (owner: 10UltrasonicNXT) [00:10:06] (03CR) 10Jforrester: [C: 032] update-oojs.sh: Rewrite to fetch from npm repo instead of building from git [core] - 10https://gerrit.wikimedia.org/r/124479 (owner: 10Krinkle) [00:13:15] (03Merged) 10jenkins-bot: update-oojs.sh: Rewrite to fetch from npm repo instead of building from git [core] - 10https://gerrit.wikimedia.org/r/124479 (owner: 10Krinkle) [00:14:44] (03PS1) 10Shirayuki: i18n: fix spelling "occurred" [extensions/BlueSpiceFoundation] - 10https://gerrit.wikimedia.org/r/124501 [00:15:49] (03PS1) 10Ori.livneh: Add Kafka writer; move writer-specific imports to writers [extensions/EventLogging] - 10https://gerrit.wikimedia.org/r/124502 [00:16:06] (03PS1) 10TheDJ: Repair removeFromToolbar() to handle image buttons [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/124503 [00:19:08] (03CR) 10MaxSem: [C: 032] Maintain file order when iterating wikiversions.json [tools/scap] - 10https://gerrit.wikimedia.org/r/124500 (owner: 10BryanDavis) [00:19:19] (03Merged) 10jenkins-bot: Maintain file order when iterating wikiversions.json [tools/scap] - 10https://gerrit.wikimedia.org/r/124500 (owner: 10BryanDavis) [00:29:40] (03CR) 10Ori.livneh: "Should be reverted, IMO, per " [tools/scap] - 10https://gerrit.wikimedia.org/r/124500 (owner: 10BryanDavis) [00:31:40] (03CR) 10BryanDavis: "I will gladly revert as soon as I can confirm that a) this is the problem and b) find a fix for the root problem in mergeMessageFileList.p" [tools/scap] - 10https://gerrit.wikimedia.org/r/124500 (owner: 10BryanDavis) [00:32:07] (03PS2) 10Ori.livneh: Add Kafka writer; move writer-specific imports to writers [extensions/EventLogging] - 10https://gerrit.wikimedia.org/r/124502 [00:36:46] (03PS6) 10Krinkle: [WIP] Investigate swinging qunit test failure [core] - 10https://gerrit.wikimedia.org/r/124372 [00:37:06] Krinkle: is there an environment variable set for jenkins test runs that I can use to detect jenkins? [00:37:25] Krinkle: (Travis CI defines 'TRAVIS' for that reason) [00:37:45] ori: What are you doing that doesn't generically work? [00:37:56] https://integration.wikimedia.org/ci/job/mwext-EventLogging-tox-py27/3/console [00:38:17] testing that http_get, a wrapper for py2/3 http libs, works [00:38:34] for other tests that depend on http_get, i have a fixture that makes sure an actual request isn't needed [00:38:42] but then there's a test of http_get itself [00:39:57] ori: Why does the test fail though? [00:40:27] Krinkle: probably the test execution environment does not allow ports to be opened [00:40:56] Krinkle: the test suite actually launches a simple http server in a separate thread for that test [00:40:56] Are there other tests that interact with the server it thought it set up? [00:41:04] no, just that one. [00:41:24] everything else uses mocks/stubs for external resources [00:42:09] what about tests for the server itself (e.g. how it responds to request type X and Y), does it call those methods directly? Or are those not being tested, or don't need tests (write api only) [00:42:26] Anyway, you can use one of few env vars [00:42:31] though none are boolean for this purpose specifically [00:43:15] env.JENKINS_URL [00:43:18] end.WORKSPACE [00:43:26] Those are most commonly used for this purpose [00:43:29] env* [00:44:40] Krinkle: cool, thanks [00:47:00] ori: I'll be in San Francisco next week and am looking forward to sitting down with you to really get a bunch of performance guidelines stuff settled [00:49:59] sumanah: OK, let's rope in AaronSchulz too. Would you like to send an invite, or should I try to find a slot? [00:50:20] ori: if you would not mind finding a slot on Tues, Wed, Thurs or Fri, that would be delightful [00:50:36] sorry that I will be coming to you by way of Montreal, so, no NYC bagels or what have you [00:51:29] [1673cfdb] /wiki/Special:Version Exception from line 318 of /var/www/wiki/mediawiki/core/includes/MagicWord.php: Error: invalid magic word 'categorytree' [00:51:32] Noooooo my dev wiki! [00:52:05] sumanah: That city is still famous for its begals [00:53:46] sumanah: thanks! [00:54:10] bawolff: NYC for bagels, yeah. And Portland, Oregon for Voodoo Donuts [00:54:28] I mean montreal has famous begals too :P [00:55:07] ...Voodoo Donuts? [00:55:10] * Deskana googles. [00:55:36] Interesting. [00:55:40] lol "The magic is in the hole" [00:55:57] (03PS3) 10Ori.livneh: Add Kafka writer; move writer-specific imports to writers [extensions/EventLogging] - 10https://gerrit.wikimedia.org/r/124502 [00:56:25] bawolff: it does? I am ignorant. I should try a bagel while I am in Montreal [00:56:58] yeah, they're kind of the opposite of a new york style begal (I say style as I've never had a real new york begal) [00:57:10] Deskana: a few of us have submitted talks to Open Source Bridge (Portland, Oregon in late June) in case you want to submit something as well, perhaps about what you've learned about FLOSSy product management? People are interested in that topic, as I discovered in previous OSB years [00:57:41] I have graduation in July. Late June might be doable. [00:57:45] sumanah: Voodoo Donuts [00:57:50] copy paste fail [00:57:56] sumanah: https://en.wikipedia.org/wiki/Montreal-style_bagel [00:58:02] (03CR) 10Ori.livneh: [C: 032] Add Kafka writer; move writer-specific imports to writers [extensions/EventLogging] - 10https://gerrit.wikimedia.org/r/124502 (owner: 10Ori.livneh) [00:58:14] you know you're famous when you have a wikipedia article [00:58:30] Thank you bawolff! [00:58:43] oh no, don't tell me someone made an enwiki article about me [00:58:53] I meant for the begals [00:59:21] (03PS1) 10BryanDavis: Revert "Maintain file order when iterating wikiversions.json" [tools/scap] - 10https://gerrit.wikimedia.org/r/124508 [00:59:25] Got it :) [00:59:34] sumanah: One of the things I find quirky about this country is its federal nature. I am making it my goal to visit as many states as possible before I move abroad again. If I took a personal day at the end of that I could also visit Washington, and get two states in one! [00:59:51] True! I went to Seattle in January and found my experience nice [00:59:55] (03PS2) 10BryanDavis: Revert "Maintain file order when iterating wikiversions.json" [tools/scap] - 10https://gerrit.wikimedia.org/r/124508 [01:00:56] I have fond memories of visiting Seattle [01:01:06] Also a cool science fiction museum there [01:01:31] I am going to Ohio in May for a wedding, and we're flying back from Chicago, so I've booked a few days off and we're going to visit Illinois, Michigan, Indiana and Wisconsin too. [01:02:17] Deskana: Enjoy! I have loved my times visiting Madison, Wisconsin. There's a scifi convention there in late May [01:02:38] http://www.wiscon.info/ [01:02:49] (03PS5) 10Krinkle: qunit: Implement suppressWarnings/restoreWarnings [core] - 10https://gerrit.wikimedia.org/r/124374 [01:02:52] (03CR) 10Krinkle: [C: 031] qunit: Implement suppressWarnings/restoreWarnings [core] - 10https://gerrit.wikimedia.org/r/124374 (owner: 10Krinkle) [01:03:37] Deskana: if you want to get super sad you can go to Highland Park (near Chicago) where Aaron Swartz is buried [01:03:58] I had a moment of panic then because I read that as Aaron Schulz. [01:04:16] (we have that problem a fair amount) [01:04:41] Right, going home. [01:05:14] nod [01:05:15] night! [01:06:21] Speak to you soon! [01:10:09] /me is wondering if Reedy is also the Reedy he sees on the ChatSpike network [01:30:26] (03PS1) 10Yaron Koren: Changed subtitle for old revisions - patch by Eli Handel [extensions/ApprovedRevs] - 10https://gerrit.wikimedia.org/r/124509 [01:35:51] (03CR) 10Yaron Koren: [C: 032 V: 031] Changed subtitle for old revisions - patch by Eli Handel [extensions/ApprovedRevs] - 10https://gerrit.wikimedia.org/r/124509 (owner: 10Yaron Koren) [01:35:53] (03Merged) 10jenkins-bot: Changed subtitle for old revisions - patch by Eli Handel [extensions/ApprovedRevs] - 10https://gerrit.wikimedia.org/r/124509 (owner: 10Yaron Koren) [01:44:17] hmph, why are there so many pointless JSHint rules? [01:44:21] like "strings must use singlequote" [01:44:24] why do we care? [01:45:45] really, that's not allowed? We don't even care in php where there is a micro-performance difference. [01:53:49] (03PS1) 10Aaron Schulz: Improved HashRing usage in JobQueueFederated [core] - 10https://gerrit.wikimedia.org/r/124511 [01:57:40] (03PS1) 10Yaron Koren: Fix so that unapprovable pages won't show up in AR lists - patch by Eli Handel [extensions/ApprovedRevs] - 10https://gerrit.wikimedia.org/r/124512 [01:59:14] (03CR) 10jenkins-bot: [V: 04-1] Improved HashRing usage in JobQueueFederated [core] - 10https://gerrit.wikimedia.org/r/124511 (owner: 10Aaron Schulz) [02:03:20] (03CR) 10Yaron Koren: [C: 032 V: 031] Fix so that unapprovable pages won't show up in AR lists - patch by Eli Handel [extensions/ApprovedRevs] - 10https://gerrit.wikimedia.org/r/124512 (owner: 10Yaron Koren) [02:03:22] (03Merged) 10jenkins-bot: Fix so that unapprovable pages won't show up in AR lists - patch by Eli Handel [extensions/ApprovedRevs] - 10https://gerrit.wikimedia.org/r/124512 (owner: 10Yaron Koren) [02:04:30] bawolff: that's what the JSHint config file says [02:05:14] That seems silly. [02:05:40] But I guess I don't touch js stuff very often, so it doesn't matter that much to me [02:08:05] ah it was removed in more recent versions [02:08:11] should update the codebase I'm working on [02:21:38] (03PS4) 10Mattflaschen: Make .mw-ui-button height the same for all buttons [core] - 10https://gerrit.wikimedia.org/r/117107 (owner: 10JGonera) [02:21:50] jgonera: thanks for the email to the list [02:22:41] (03CR) 10jenkins-bot: [V: 04-1] Make .mw-ui-button height the same for all buttons [core] - 10https://gerrit.wikimedia.org/r/117107 (owner: 10JGonera) [02:31:19] (03CR) 10Brian Wolff: [C: 032] "Ok, lets do this." [core] - 10https://gerrit.wikimedia.org/r/104182 (owner: 10TTO) [02:34:36] (03Merged) 10jenkins-bot: Add extra views (tabs) for files in a foreign repository [core] - 10https://gerrit.wikimedia.org/r/104182 (owner: 10TTO) [02:40:14] (03CR) 10Mattflaschen: [C: 031] "Looks good. Bevel issue is fixed, height verified to match (including disabled)" [core] - 10https://gerrit.wikimedia.org/r/117107 (owner: 10JGonera) [02:50:11] (03PS2) 10Aaron Schulz: Improved HashRing usage in JobQueueFederated [core] - 10https://gerrit.wikimedia.org/r/124511 [02:51:28] (03CR) 10Ori.livneh: [C: 032] Revert "Maintain file order when iterating wikiversions.json" [tools/scap] - 10https://gerrit.wikimedia.org/r/124508 (owner: 10BryanDavis) [02:51:41] (03Merged) 10jenkins-bot: Revert "Maintain file order when iterating wikiversions.json" [tools/scap] - 10https://gerrit.wikimedia.org/r/124508 (owner: 10BryanDavis) [03:01:35] (03PS3) 10Aaron Schulz: Improved HashRing usage in JobQueueFederated [core] - 10https://gerrit.wikimedia.org/r/124511 [03:16:47] (03PS1) 10Bsitu: TopKIndex.replaceInIndex has incorrect return value in callback [extensions/Flow] - 10https://gerrit.wikimedia.org/r/124514 [03:32:14] (03CR) 10Catrope: [C: 032] resourceloader: Add unit test to ensure absence of illegal dependencies [core] - 10https://gerrit.wikimedia.org/r/121566 (owner: 10Krinkle) [03:33:00] (03CR) 10Catrope: [C: 032] resourceloader: Don't add superfluous line breaks and semicolons [core] - 10https://gerrit.wikimedia.org/r/123822 (owner: 10Krinkle) [03:33:04] (03CR) 10jenkins-bot: [V: 04-1] resourceloader: Add unit test to ensure absence of illegal dependencies [core] - 10https://gerrit.wikimedia.org/r/121566 (owner: 10Krinkle) [03:36:49] (03Merged) 10jenkins-bot: resourceloader: Don't add superfluous line breaks and semicolons [core] - 10https://gerrit.wikimedia.org/r/123822 (owner: 10Krinkle) [03:50:59] (03CR) 10MZMcBride: "This seems like a reasonable compromise to me. This allows us to move forward for now and we can figure out what to do more permanently in" [core] - 10https://gerrit.wikimedia.org/r/124475 (owner: 10Odder) [03:53:19] <^d> !font [03:56:33] (03PS2) 10Brian Wolff: Revert font stack to be just sans-serif [core] - 10https://gerrit.wikimedia.org/r/124475 (owner: 10Odder) [03:58:22] (03CR) 10Brian Wolff: "I changed the commit message slightly. I'm hoping my changes were "neutral". I just think its important to note that the patch is partiall" [core] - 10https://gerrit.wikimedia.org/r/124475 (owner: 10Odder) [03:58:50] ^d: We should make a picture encyclopedia [03:59:05] It will be easier to understand, and no pesky letters to fight about [03:59:15] <^d> I created a redirect today. [03:59:25] <^d> I was tired of typing [[Typography refresh]] [03:59:31] <^d> So I made [[OMGFONTS]] [04:00:23] lol [04:01:34] ASL wiki! [04:02:18] SignWriting! [04:02:29] oh crap, we're back to fonts again [04:03:12] bawolff: then you have to get rid of the community too [04:03:25] or are you suggesting that everything occur visually? [04:03:33] Jasper_Deng: No community = no text = no fonts to whine about! [04:03:54] Jasper_Deng: Just call it wiki-pictionary [04:04:30] Ok everyone, lets draw a picture of NPOV... [04:04:47] you see this would've been easier back in 2001. [04:05:01] The saying "A picture is worth a thousand words" is a one-way statement [04:05:16] <^d> Or we could all switch to screen readers. [04:05:24] <^d> No pictures or caring about how the text looks [04:05:26] <^d> Just *listen* [04:05:27] <^d> :D [04:05:55] how do you read usernames like yours? :P [04:06:02] that have ambiguous pronunciations [04:06:16] "The new values (#252525 on #FFFFFF) have a contrast ratio of 15.3:1, which is an AAA rating according to WCAG 2.0 1.4.6.[7] " <-- How was that even calculated. Wouldn't that vary depending on your colour space and gamma settings [04:06:37] demon seems pretty unambigious [04:06:49] Its even a real word [04:06:53] (03CR) 10Legoktm: [C: 031] "I think this is a reasonable compromise to have for the time being. There was a consensus that listing only non-free fonts was not accepta" [core] - 10https://gerrit.wikimedia.org/r/124475 (owner: 10Odder) [04:07:18] (03PS7) 10Santhosh: configure socket.io based on production/development evironment [services/cxserver] - 10https://gerrit.wikimedia.org/r/124315 (owner: 10KartikMistry) [04:07:20] bawolff: how do you pronounce & [04:07:22] ^* [04:07:28] (03CR) 10Santhosh: [C: 032] configure socket.io based on production/development evironment [services/cxserver] - 10https://gerrit.wikimedia.org/r/124315 (owner: 10KartikMistry) [04:07:30] I pronounce it as "hat demon" [04:07:37] * Jasper_Deng waits to be boxed by ^d [04:07:40] <^d> Jasper_Deng: Whatever you prefer. [04:07:54] (03Merged) 10jenkins-bot: configure socket.io based on production/development evironment [services/cxserver] - 10https://gerrit.wikimedia.org/r/124315 (owner: 10KartikMistry) [04:07:59] <^d> Caret demon, hat demon [04:08:14] I assumed the hat was silent [04:08:15] <^d> Philippe prefers making a visible hand motion in person swooshing up and down. [04:08:21] lol [04:08:30] (03CR) 10Legoktm: "To clarify, I don't think this is "counter to the last five months of testing via the Typography Refresh". This patch is intended to be a " [core] - 10https://gerrit.wikimedia.org/r/124475 (owner: 10Odder) [04:08:31] hhm, don't remember him doing that at the office [04:08:37] <^d> *swoosh* *swoosh* demon [04:08:58] next time I go there I should see that [04:09:02] <^d> I personally say "insert demon" [04:11:46] http://i.imgur.com/bLkPzN3.jpg [04:11:58] i would so order that for you, but it's not for sale [04:24:28] <^d> ori: Aw, it's cute :) [04:43:58] (03CR) 10Jasper Deng: [C: 031] "Personally I do not like the font, and while I think enwiki's community needs to give the team more respect, I also think fixing something" [core] - 10https://gerrit.wikimedia.org/r/124475 (owner: 10Odder) [04:49:38] (03PS12) 10Brian Wolff: Allow hiding patrol entries from Special:Log for all users [core] - 10https://gerrit.wikimedia.org/r/42279 [04:50:42] Jasper_Deng: You're probably right about it being the wrong place [04:51:01] I wonder how many people will see and comment on this gerrit [04:51:01] I would argue wikitech-l is the "right" place, but that's not really going anywhere [04:52:02] It will probably turn into a "gerrit vote" (e.g. Like the meta flow thing), which honestly isn't great, but meh [04:52:41] (03PS1) 10Pastakhov: fix page output (version 0.4) [extensions/Mpdf] - 10https://gerrit.wikimedia.org/r/124515 [04:52:49] if you consider a Gerrit vote to be a simple random sample, statistically I'm sure you still cannot reject the possibility that it actually doesn't have majority support [04:52:54] too small of a sample [04:53:03] if like the entire foundation voted, that would be a different story [04:53:25] I object to gerrit votes, as gerrit should not be an instrument for political debate [04:53:51] gerrit should be +1 I tested and it didn't explode. -1 this code sucks, go fix it, etc [04:53:54] imo [04:54:06] is this why some people are saying for gerrit to die in a fire? [04:54:15] No, that's for other reasons :) [04:54:15] no [04:54:26] (03CR) 10Pastakhov: [C: 032 V: 032] fix page output (version 0.4) [extensions/Mpdf] - 10https://gerrit.wikimedia.org/r/124515 (owner: 10Pastakhov) [04:55:02] And -1: I dislike the idea of this code does fit into it, once it turns into any sort of debate, it really should be bugzilla or mailing list depending on what sort of debate [04:55:17] * bawolff of course hasn't always followed that rule [04:55:17] bugzilla isn't even very great [04:55:21] not even a mailing list [04:55:28] b/c it's not everyone [04:55:51] Well I think it depends on the scope of the debate [04:55:54] <^d> Talking to everyone is impossible. [04:56:15] yeah, but more is always better [04:56:28] If its a minor argument say between 2 or 3 people that largely doesn't affect mediawiki development - bugzilla is great [04:56:38] <^d> What we need is something like Google News for Code Comments. [04:56:39] If its a major debate, mailing list is great [04:56:43] <^d> Creates an echo chamber. [04:56:48] <^d> Gives you only the results you want. [04:56:57] If everyone is pissed, well there's no good answer :) [04:56:57] +1 [04:57:08] too late to make that a gsoc thing though [04:57:31] (the consensus model of decision-making is at its worst when there's no... consensus in a situation where a decision must be made) [04:57:54] <^d> GSoC: "Create a way for people to to disagree but only see the responses that agree with you?" [04:58:15] Hey, I've seen less useful gsoc proposals [04:58:19] lol [04:58:41] <^d> bawolff: I was half-tempted to say "Like yours?" [04:58:44] <^d> But I loved yours. [04:58:50] <^d> ;-) [04:59:05] I was actually thinking I was setting myself up for that line when I typed that [04:59:29] And you better love mine, mentor :P [05:00:56] <^d> bawolff: Sure sure, typical student response. Blame the teacher! [05:01:48] Well I'm still here, so you must have done something right [05:09:02] hmm prop=contributors in the api looks like a kind of scary query if it was done on something like the sandbox [05:11:48] hi [05:12:10] i need some help getting familiar with the codebase of wikimedia [05:12:14] mediawiki [05:12:35] how it works and stuff like that [05:12:35] mayankmadan: Do you have any questions in particular, or an area you are curious about? [05:13:35] bawolff, i dont know where to start [05:14:50] mayankmadan: As a first step, maybe read over https://www.mediawiki.org/wiki/Manual:MediaWiki_architecture [05:17:56] MediaWiki is a big thing. https://www.mediawiki.org/wiki/Manual:MediaWiki_architecture contains an overview of the various parts. After you've read that, if you still want to dig deeper, I would recommend choosing some small part of MediaWiki to start with learning how it works. (Easier to learn things by breaking it up into small components) [05:25:53] thanks [05:36:36] (03CR) 10Prtksxna: "I'll do that as a separate commit against Bug:61267 along with the other fixes that you mentioned." [extensions/Popups] - 10https://gerrit.wikimedia.org/r/124296 (owner: 10Prtksxna) [05:56:41] (03PS1) 10KartikMistry: Disable heartbeats for development [services/cxserver] - 10https://gerrit.wikimedia.org/r/124519 [06:11:50] (03CR) 10Brian Wolff: [C: 04-1] "See inline" (036 comments) [extensions/GWToolset] - 10https://gerrit.wikimedia.org/r/124347 (owner: 10Dan-nl) [06:12:39] (03PS3) 10Brian Wolff: Do not overwrite content from community members/bots on re-upload [extensions/GWToolset] - 10https://gerrit.wikimedia.org/r/124347 (owner: 10Dan-nl) [06:13:51] thanks, google: http://i.imgur.com/gC5sNrq.png [06:14:26] ori: sounds super useful [06:14:41] * YuviPanda teleports self [06:14:42] 21 minutes! they are working on some awesome tech [06:14:57] (03CR) 10Brian Wolff: [C: 04-1] "I changed the commit message, as "protect" has a mediawiki jargon specific meaning." [extensions/GWToolset] - 10https://gerrit.wikimedia.org/r/124347 (owner: 10Dan-nl) [06:15:33] isn't 21m FTL? [06:16:36] hah! depends on the relative location of orbit, 20-40 mins [06:17:08] it would be very funny if it were actually 22 light-minutes away right now [06:17:10] right. [06:17:12] hehe [06:17:14] hmm, my googling said 34 minutes-51 minutes [06:17:34] bawolff: that's what you get for not being in san francisco; light is faster here [06:17:41] we should keep adjusting the traffic to match [06:17:48] EVERYTHING IS FASTER IN SF [06:17:55] except MW [06:18:22] ori: You can make it even faster: en.wikipedia.org/wiki/Speed of light?action=edit [06:18:36] YuviPanda: You're right beside ulsfo. It should be speedy for you :P [06:19:17] bawolff: https://www.mediawiki.org/wiki/Differences_between_Wikipedia,_Wikimedia,_MediaWiki,_and_wiki [06:19:18] :P [06:19:34] bawolff: also 'me' is still in India [06:19:59] * bawolff imagines you have instant commons on to save face :P [06:20:17] * YuviPanda gives bawolff a book [06:20:37] I thought I heard you were relocating to san fran. no? [06:21:27] YuviPanda: Is that like a computer without the backlight on the screen? [06:21:42] bawolff: yeah, my uni slowing things down with b'cracy [06:22:01] bawolff: yes, but has great battery life. Cheaper too, usually. [06:22:55] I've probably spent more on books over the last five years then my laptop that has lasted my five years (esp. with university text books) [06:24:34] bawolff: heh. [06:24:45] bawolff: I grew up on PDF 'books' so don't really buy paper ones [06:24:58] I love me my real paper [06:25:19] YuviPanda: any new RTL issues solved ? :) [06:25:22] I get very distracted by computers. Paper books are easier to concentrate on [06:25:35] matanya: oh yeah, a lot were fixed in the last few days. [06:25:49] bawolff: heh :D I've gotten used to reading when distracted [06:27:49] thanks YuviPanda [06:36:03] (03CR) 10Foxtrott: [C: 032 V: 032] Throw exception for inaccessible layoutfile [skins/chameleon] - 10https://gerrit.wikimedia.org/r/124496 (owner: 10Mwjames) [06:42:57] (03CR) 10Brian Wolff: "I haven't tested this yet, but 2 nitpicky little comments." (032 comments) [extensions/GWToolset] - 10https://gerrit.wikimedia.org/r/124376 (owner: 10Dan-nl) [06:43:28] (03PS2) 10KartikMistry: Increase heartbeats interval to 45s [services/cxserver] - 10https://gerrit.wikimedia.org/r/124519 [06:48:08] (03CR) 10MaxSem: [C: 04-1] "Needs tests." [core] - 10https://gerrit.wikimedia.org/r/123516 (owner: 10Jackmcbarn) [06:57:08] (03CR) 10Nemo bis: [C: 031] "Certainly progress, but more is required. See inline." (031 comment) [core] - 10https://gerrit.wikimedia.org/r/124475 (owner: 10Odder) [07:35:57] (03CR) 10Frédéric Wang: Fix: Allow
as valid Math output (032 comments) [extensions/Math] (math2_0_0) - 10https://gerrit.wikimedia.org/r/112325 (owner: 10Physikerwelt) [07:40:05] Nemo_bis: Well to be fair, I was essentially proposing a revert in one of my mailing list posts [07:41:16] bawolff: but only for the font part; not the colour and so on [07:42:43] The font is the only thing I actually notice [07:42:51] The other changes are small enough I don't really care [07:43:54] I'm honestly just annoyed at the entire thing [07:45:23] Although I must say, if it looked anything like the screenshots of what it supposed to look like, I'd be a lot more ok with it [08:00:51] (03PS12) 10Physikerwelt: remove armourMath and wgContLang (bug 60799) [extensions/Math] - 10https://gerrit.wikimedia.org/r/111119 [08:10:14] (03CR) 10Frédéric Wang: [C: 031] remove armourMath and wgContLang (bug 60799) [extensions/Math] - 10https://gerrit.wikimedia.org/r/111119 (owner: 10Physikerwelt) [08:15:24] https://www.mediawiki.org/wiki/Talk:Typography_refresh#kerning_.28Linux.2Ffirefox.29 <-- Now nobody can accuse my of not constructively describing what I don't like [08:15:47] Hi legoktm [08:17:16] hi bawolff [08:18:16] for some reason the server I was running ZNC on just rebooted... [08:18:55] btw I think some folks on commons were complaining about some sort of mass move tool you run dissapearing (Not sure if anyone has actually mentioned it to you) [08:19:49] yeah, they did [08:19:58] It got broken in the labs move and I haven't had a chance to fix it yet [08:20:14] I'm planning to just re-write it into a js gadget for them [08:21:34] * bawolff steps away from the font war, and goes to bed [08:21:58] :P [08:21:59] gnite badon [08:22:01] bah [08:22:04] gnite bawolff :) [08:22:15] night [08:33:49] (03PS1) 10TheDJ: Allow adaptive height of the toolbar sections [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/124525 [08:34:43] (03CR) 10Nemo bis: Remove troublesome fonts from font stack (031 comment) [core] - 10https://gerrit.wikimedia.org/r/124387 (owner: 10Jdlrobson) [08:36:58] (03CR) 10Odder: "I wanted to take one step at a time; please submit a new Gerrit patch to change one more thing — we're having enough trouble to change thi" [core] - 10https://gerrit.wikimedia.org/r/124475 (owner: 10Odder) [08:40:57] (03CR) 10Siebrand: Changed subtitle for old revisions - patch by Eli Handel (031 comment) [extensions/ApprovedRevs] - 10https://gerrit.wikimedia.org/r/124509 (owner: 10Yaron Koren) [08:42:31] (03PS1) 10Aude: Split part of EnhancedChangesList::recentChangesLine into new method [core] - 10https://gerrit.wikimedia.org/r/124527 [08:42:37] (03CR) 10Siebrand: [C: 032 V: 032] i18n: fix spelling "occurred" [extensions/BlueSpiceFoundation] - 10https://gerrit.wikimedia.org/r/124501 (owner: 10Shirayuki) [08:44:23] (03PS1) 10Siebrand: Fix spelling: occurred [extensions/WikiLexicalData] - 10https://gerrit.wikimedia.org/r/124528 [08:44:26] (03PS2) 10Aude: Split part of EnhancedChangesList::recentChangesLine into new method [core] - 10https://gerrit.wikimedia.org/r/124527 [08:44:43] (03PS1) 10Siebrand: Fix spelling: occurred [extensions/PHPExcel] - 10https://gerrit.wikimedia.org/r/124529 [08:45:53] (03PS3) 10Aude: Split part of EnhancedChangesList::recentChangesLine into new method [core] - 10https://gerrit.wikimedia.org/r/124527 [08:51:14] (03CR) 10jenkins-bot: [V: 04-1] Split part of EnhancedChangesList::recentChangesLine into new method [core] - 10https://gerrit.wikimedia.org/r/124527 (owner: 10Aude) [08:51:26] gah [08:51:58] ok, qunit [08:56:00] (03PS1) 10Siebrand: Fix spelling: occurred [extensions/WYSIWYG] - 10https://gerrit.wikimedia.org/r/124530 [08:56:23] (03PS1) 10Siebrand: Fix spelling: occurred [extensions/SwiftCloudFiles] - 10https://gerrit.wikimedia.org/r/124531 [08:57:13] (03PS1) 10Siebrand: Fix spelling: occurred [extensions/ConventionExtension] - 10https://gerrit.wikimedia.org/r/124532 [08:59:11] (03PS1) 10Siebrand: Fix spelling: occurred [extensions/LinkedWiki] - 10https://gerrit.wikimedia.org/r/124533 [08:59:40] (03PS1) 10Siebrand: Fix spelling: occurred [extensions/Drafts] - 10https://gerrit.wikimedia.org/r/124534 [09:02:03] (03PS1) 10Siebrand: Fix spelling: occurred [extensions/ErrorHandler] - 10https://gerrit.wikimedia.org/r/124536 [09:02:32] (03PS1) 10Siebrand: Fix spelling: occurred [extensions/GeoGebra] - 10https://gerrit.wikimedia.org/r/124537 [09:03:10] (03PS1) 10Siebrand: Fix spelling: occurred [extensions/SideBarMenu] - 10https://gerrit.wikimedia.org/r/124538 [09:03:41] (03PS1) 10Yuvipanda: Setup jslint for Wikipedia Android app [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/124539 [09:03:44] (03PS1) 10Siebrand: Fix spelling: occurred [extensions/ArticleFeedback] - 10https://gerrit.wikimedia.org/r/124540 [09:05:24] (03CR) 10IAlex: [C: 032 V: 032] Fix spelling: occurred [extensions/ErrorHandler] - 10https://gerrit.wikimedia.org/r/124536 (owner: 10Siebrand) [09:07:10] (03PS1) 10Siebrand: Fix spelling: occurred [core] - 10https://gerrit.wikimedia.org/r/124541 [09:08:12] (03CR) 10jenkins-bot: [V: 04-1] Fix spelling: occurred [core] - 10https://gerrit.wikimedia.org/r/124541 (owner: 10Siebrand) [09:09:07] (03PS2) 10Siebrand: Fix spelling: occurred [core] - 10https://gerrit.wikimedia.org/r/124541 [09:17:19] (03PS1) 10Siebrand: Fix spelling: occurred [extensions/SimpleFarm] - 10https://gerrit.wikimedia.org/r/124543 [09:20:23] (03PS1) 10Siebrand: Fix spelling: occurred [extensions/BlueSpiceExtensions] - 10https://gerrit.wikimedia.org/r/124547 [09:21:10] (03PS1) 10Siebrand: Fix spelling: occurred [extensions/WikiObjectModel] - 10https://gerrit.wikimedia.org/r/124548 [09:22:25] (03PS1) 10Siebrand: Fix spelling: occurred [extensions/Spreadsheet] - 10https://gerrit.wikimedia.org/r/124553 [09:31:08] (03CR) 10Siebrand: [C: 04-1] Removed unneeded spaces and colons in @param and friends (031 comment) [core] - 10https://gerrit.wikimedia.org/r/124366 (owner: 10Umherirrender) [09:31:45] (03PS5) 10Nik: Added documentation. [extensions/PubSubHubbub] - 10https://gerrit.wikimedia.org/r/124331 [09:32:27] (03CR) 10Thiemo Mättig (WMDE): Replace in_array( array_keys( ... ) ) with array_key_exists( ... ) (031 comment) [core] - 10https://gerrit.wikimedia.org/r/123106 (owner: 10Thiemo Mättig (WMDE)) [09:33:06] (03CR) 10Nik: [C: 032] Added documentation. [extensions/PubSubHubbub] - 10https://gerrit.wikimedia.org/r/124331 (owner: 10Nik) [09:33:08] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/PubSubHubbub] - 10https://gerrit.wikimedia.org/r/124331 (owner: 10Nik) [09:33:28] (03CR) 10Siebrand: [C: 031] "i18n/L10n looks okay." [core] - 10https://gerrit.wikimedia.org/r/119002 (owner: 10devunt) [09:34:41] (03CR) 10Addshore: [C: 032] Fix spelling: occurred [extensions/PHPExcel] - 10https://gerrit.wikimedia.org/r/124529 (owner: 10Siebrand) [09:34:43] (03Merged) 10jenkins-bot: Fix spelling: occurred [extensions/PHPExcel] - 10https://gerrit.wikimedia.org/r/124529 (owner: 10Siebrand) [09:35:00] (03CR) 10Addshore: [C: 032] Fix spelling: occurred [extensions/Drafts] - 10https://gerrit.wikimedia.org/r/124534 (owner: 10Siebrand) [09:35:05] (03Merged) 10jenkins-bot: Fix spelling: occurred [extensions/Drafts] - 10https://gerrit.wikimedia.org/r/124534 (owner: 10Siebrand) [09:35:19] (03CR) 10Addshore: [C: 032] Fix spelling: occurred [extensions/SideBarMenu] - 10https://gerrit.wikimedia.org/r/124538 (owner: 10Siebrand) [09:35:23] (03Merged) 10jenkins-bot: Fix spelling: occurred [extensions/SideBarMenu] - 10https://gerrit.wikimedia.org/r/124538 (owner: 10Siebrand) [09:35:25] addshore: Wee! [09:35:42] [= [09:35:57] addshore: https://gerrit.wikimedia.org/r/#/q/status:open+topic:L10n,n,z [09:36:09] (03CR) 10Addshore: [C: 032] Fix spelling: occurred [core] - 10https://gerrit.wikimedia.org/r/124541 (owner: 10Siebrand) [09:36:52] (03PS2) 10Addshore: Remove random unneeded tabs and spaces. [qrpedia] - 10https://gerrit.wikimedia.org/r/121660 [09:37:01] (03CR) 10Addshore: "PHPlint should now run" [qrpedia] - 10https://gerrit.wikimedia.org/r/121660 (owner: 10Addshore) [09:37:06] (03PS2) 10Addshore: General fixes and cleanup [qrpedia] - 10https://gerrit.wikimedia.org/r/121661 [09:37:11] (03CR) 10Addshore: "PHPlint should now run" [qrpedia] - 10https://gerrit.wikimedia.org/r/121661 (owner: 10Addshore) [09:37:18] (03CR) 10Siebrand: [C: 031] "i18n/L10n reviewed." [core] - 10https://gerrit.wikimedia.org/r/118113 (owner: 10Anomie) [09:38:17] (03CR) 10Siebrand: [C: 031] "i18n/L10n reviewed." [core] - 10https://gerrit.wikimedia.org/r/5130 (owner: 10Joancreus) [09:39:19] (03Merged) 10jenkins-bot: Fix spelling: occurred [core] - 10https://gerrit.wikimedia.org/r/124541 (owner: 10Siebrand) [09:39:30] (03PS2) 10Addshore: Fix whitespace [extensions/ConventionExtension] - 10https://gerrit.wikimedia.org/r/124532 (owner: 10Siebrand) [09:40:00] (03PS3) 10Addshore: Fix whitespace in ConferenceAuthor.php [extensions/ConventionExtension] - 10https://gerrit.wikimedia.org/r/124532 (owner: 10Siebrand) [09:40:18] (03CR) 10Hashar: [C: 04-1] "check -> check-voter :-)" (031 comment) [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/124539 (owner: 10Yuvipanda) [09:41:11] (03CR) 10Siebrand: [C: 04-1] "This needs to be rebased because the resources/ folder has been restructured recently." [core] - 10https://gerrit.wikimedia.org/r/5130 (owner: 10Joancreus) [09:41:49] (03PS2) 10Yuvipanda: Setup jslint for Wikipedia Android app [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/124539 [09:42:45] (03CR) 10Yuvipanda: "Fixed check-voter." [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/124539 (owner: 10Yuvipanda) [09:43:42] (03CR) 10Siebrand: "The spelling correction is still in there, it just drowned in the automatic removal of the apparently omnipresent trailing whitespace..." [extensions/ConventionExtension] - 10https://gerrit.wikimedia.org/r/124532 (owner: 10Siebrand) [09:44:08] (03PS1) 10Addshore: Add lint for Spreadsheet extension [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/124561 [09:44:24] (03CR) 10Hashar: "Great. Now we need Jenkins jobs! You can look at https://www.mediawiki.org/wiki/Continuous_integration/Tutorials/Adding_a_MediaWiki_extens" [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/124539 (owner: 10Yuvipanda) [09:45:15] (03PS1) 10Addshore: Add lint for WikiObjectModel extension [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/124562 [09:46:00] (03PS1) 10Addshore: Add lint for SimpleFarm extension [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/124563 [09:46:51] (03PS1) 10Addshore: Add lint for ArticleFeedback extension [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/124564 [09:47:21] (03CR) 10Hashar: [C: 032] "Deployed, will need Zuul configuration." [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/124561 (owner: 10Addshore) [09:47:31] (03CR) 10Siebrand: "How about adding RELEASE-NOTES for the bundled extensions in the extension folders? They can be less complex than the one for core, and fo" [core] - 10https://gerrit.wikimedia.org/r/124329 (owner: 10TheDJ) [09:47:57] (03PS1) 10Addshore: Add lint for ConventionExtension extension [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/124565 [09:48:14] (03Merged) 10jenkins-bot: Add lint for Spreadsheet extension [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/124561 (owner: 10Addshore) [09:49:26] (03PS1) 10Addshore: Add lint for GeoGebra extension [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/124566 [09:54:52] (03PS2) 10Hashar: Add lint for SimpleFarm extension [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/124563 (owner: 10Addshore) [09:54:55] (03PS2) 10Hashar: Add lint for WikiObjectModel extension [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/124562 (owner: 10Addshore) [09:54:58] (03PS2) 10Hashar: Add lint for GeoGebra extension [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/124566 (owner: 10Addshore) [09:55:01] (03PS2) 10Hashar: Add lint for ConventionExtension extension [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/124565 (owner: 10Addshore) [09:55:04] (03PS2) 10Hashar: Add lint for ArticleFeedback extension [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/124564 (owner: 10Addshore) [09:55:20] (03CR) 10Hashar: [C: 032] Add lint for WikiObjectModel extension [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/124562 (owner: 10Addshore) [09:55:23] (03CR) 10Hashar: [C: 032] Add lint for SimpleFarm extension [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/124563 (owner: 10Addshore) [09:55:26] (03CR) 10Hashar: [C: 032] Add lint for ArticleFeedback extension [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/124564 (owner: 10Addshore) [09:55:30] (03CR) 10Hashar: [C: 032] Add lint for ConventionExtension extension [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/124565 (owner: 10Addshore) [09:55:33] (03CR) 10Hashar: [C: 032] Add lint for GeoGebra extension [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/124566 (owner: 10Addshore) [09:58:45] (03Merged) 10jenkins-bot: Add lint for WikiObjectModel extension [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/124562 (owner: 10Addshore) [09:59:17] (03Merged) 10jenkins-bot: Add lint for SimpleFarm extension [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/124563 (owner: 10Addshore) [09:59:25] (03PS1) 10TheDJ: Preserve textarea state when building WikiEditor UI [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/124567 [09:59:52] (03PS1) 10Addshore: Add zull triggers for linting jobs [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/124568 [09:59:55] (03Merged) 10jenkins-bot: Add lint for ArticleFeedback extension [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/124564 (owner: 10Addshore) [10:00:11] (03PS2) 10Addshore: Add zuul triggers for linting jobs [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/124568 [10:00:56] (03Merged) 10jenkins-bot: Add lint for ConventionExtension extension [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/124565 (owner: 10Addshore) [10:01:05] (03Merged) 10jenkins-bot: Add lint for GeoGebra extension [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/124566 (owner: 10Addshore) [10:02:45] (03PS1) 10Addshore: Add zuul trigger for SwiftCloudFiles [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/124570 [10:05:00] (03PS2) 10Addshore: Add zuul triggers that are in jjbc but no zuul [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/124570 [10:05:03] (03PS1) 10Hashar: Make integration-jjb-config-test concurrent [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/124571 [10:05:08] (03CR) 10Hashar: [C: 032] Make integration-jjb-config-test concurrent [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/124571 (owner: 10Hashar) [10:05:30] (03CR) 10Hashar: [C: 032] Add zuul triggers for linting jobs [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/124568 (owner: 10Addshore) [10:05:40] (03Merged) 10jenkins-bot: Add zuul triggers for linting jobs [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/124568 (owner: 10Addshore) [10:05:43] (03CR) 10Addshore: "[=" [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/124571 (owner: 10Hashar) [10:05:51] (03Merged) 10jenkins-bot: Make integration-jjb-config-test concurrent [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/124571 (owner: 10Hashar) [10:07:54] (03PS3) 10Hashar: Add zuul triggers that are in jjbc but no zuul [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/124570 (owner: 10Addshore) [10:08:26] (03CR) 10Hashar: [C: 032] Add zuul triggers that are in jjbc but no zuul [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/124570 (owner: 10Addshore) [10:08:38] (03Merged) 10jenkins-bot: Add zuul triggers that are in jjbc but no zuul [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/124570 (owner: 10Addshore) [10:10:00] (03PS1) 10Aude: Remove grouping in EnhancedChangesList for RC_MOVE and RC_MOVE_OVER_REDIRECT [core] - 10https://gerrit.wikimedia.org/r/124574 [10:14:05] (03PS2) 10Nikerabbit: Remove grouping in EnhancedChangesList for RC_MOVE and RC_MOVE_OVER_REDIRECT [core] - 10https://gerrit.wikimedia.org/r/124574 (owner: 10Aude) [10:16:04] (03CR) 10Nikerabbit: Remove grouping in EnhancedChangesList for RC_MOVE and RC_MOVE_OVER_REDIRECT (032 comments) [core] - 10https://gerrit.wikimedia.org/r/124574 (owner: 10Aude) [10:18:26] (03CR) 10Addshore: [C: 04-1] Extension has moved to GitHub. Make that clearer (031 comment) [extensions/FacebookOpenGraph] - 10https://gerrit.wikimedia.org/r/123849 (owner: 10Siebrand) [10:18:39] (03CR) 10Siebrand: [C: 04-1] "Message documentation should be added for newly added message keys in qqq.json." (032 comments) [core] - 10https://gerrit.wikimedia.org/r/22699 (owner: 10Liangent) [10:18:50] (03PS4) 10Addshore: Fix whitespace and spelling in ConferenceAuthor.php [extensions/ConventionExtension] - 10https://gerrit.wikimedia.org/r/124532 (owner: 10Siebrand) [10:18:56] (03CR) 10jenkins-bot: [V: 04-1] Fix whitespace and spelling in ConferenceAuthor.php [extensions/ConventionExtension] - 10https://gerrit.wikimedia.org/r/124532 (owner: 10Siebrand) [10:19:10] (03CR) 10Siebrand: Extension has moved to GitHub. Make that clearer (031 comment) [extensions/FacebookOpenGraph] - 10https://gerrit.wikimedia.org/r/123849 (owner: 10Siebrand) [10:20:09] (03PS2) 10Siebrand: Extension has moved to GitHub. Make that clearer [extensions/FacebookOpenGraph] - 10https://gerrit.wikimedia.org/r/123849 [10:21:05] (03CR) 10Siebrand: [C: 032 V: 032] "Override Jenkins and self merge trivial changes." [extensions/ConventionExtension] - 10https://gerrit.wikimedia.org/r/124532 (owner: 10Siebrand) [10:22:00] (03PS2) 10Addshore: Fix spelling: 'occurred' [extensions/Spreadsheet] - 10https://gerrit.wikimedia.org/r/124553 (owner: 10Siebrand) [10:22:03] (03PS2) 10Addshore: Fix spelling: 'occurred' [extensions/WikiObjectModel] - 10https://gerrit.wikimedia.org/r/124548 (owner: 10Siebrand) [10:22:06] (03PS2) 10Addshore: Fix spelling: 'occurred' [extensions/SimpleFarm] - 10https://gerrit.wikimedia.org/r/124543 (owner: 10Siebrand) [10:22:11] (03PS2) 10Addshore: Fix spelling: 'occurred' [extensions/ArticleFeedback] - 10https://gerrit.wikimedia.org/r/124540 (owner: 10Siebrand) [10:22:13] (03CR) 10jenkins-bot: [V: 04-1] Fix spelling: 'occurred' [extensions/Spreadsheet] - 10https://gerrit.wikimedia.org/r/124553 (owner: 10Siebrand) [10:22:15] (03PS2) 10Addshore: Fix spelling: 'occurred' [extensions/GeoGebra] - 10https://gerrit.wikimedia.org/r/124537 (owner: 10Siebrand) [10:22:17] (03CR) 10jenkins-bot: [V: 04-1] Fix spelling: 'occurred' [extensions/ArticleFeedback] - 10https://gerrit.wikimedia.org/r/124540 (owner: 10Siebrand) [10:22:19] (03PS2) 10Addshore: Fix spelling: 'occurred' [extensions/SwiftCloudFiles] - 10https://gerrit.wikimedia.org/r/124531 (owner: 10Siebrand) [10:22:23] (03PS2) 10Addshore: Fix spelling: 'occurred' [extensions/WikiLexicalData] - 10https://gerrit.wikimedia.org/r/124528 (owner: 10Siebrand) [10:22:32] (03CR) 10Addshore: "PHP lint should now run" [extensions/Spreadsheet] - 10https://gerrit.wikimedia.org/r/124553 (owner: 10Siebrand) [10:22:35] (03CR) 10Addshore: "PHP lint should now run" [extensions/WikiObjectModel] - 10https://gerrit.wikimedia.org/r/124548 (owner: 10Siebrand) [10:22:38] (03CR) 10Addshore: "PHP lint should now run" [extensions/SimpleFarm] - 10https://gerrit.wikimedia.org/r/124543 (owner: 10Siebrand) [10:22:41] (03CR) 10Addshore: "PHP lint should now run" [extensions/ArticleFeedback] - 10https://gerrit.wikimedia.org/r/124540 (owner: 10Siebrand) [10:22:44] (03CR) 10Addshore: "PHP lint should now run" [extensions/GeoGebra] - 10https://gerrit.wikimedia.org/r/124537 (owner: 10Siebrand) [10:22:46] (03CR) 10Addshore: "PHP lint should now run" [extensions/SwiftCloudFiles] - 10https://gerrit.wikimedia.org/r/124531 (owner: 10Siebrand) [10:22:49] (03CR) 10Addshore: "PHP lint should now run" [extensions/WikiLexicalData] - 10https://gerrit.wikimedia.org/r/124528 (owner: 10Siebrand) [10:23:04] addshore: Nice work. [10:24:57] (03PS1) 10Addshore: stop voting for jsline Spreadhseet ext [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/124577 [10:26:19] (03PS2) 10Addshore: Stop voting for jslint checks on 2 failing exts [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/124577 [10:28:00] (03Merged) 10jenkins-bot: Fix spelling: 'occurred' [extensions/GeoGebra] - 10https://gerrit.wikimedia.org/r/124537 (owner: 10Siebrand) [10:28:06] (03CR) 10Addshore: [C: 032] Fix spelling: 'occurred' [extensions/WikiObjectModel] - 10https://gerrit.wikimedia.org/r/124548 (owner: 10Siebrand) [10:28:07] (03Merged) 10jenkins-bot: Fix spelling: 'occurred' [extensions/WikiObjectModel] - 10https://gerrit.wikimedia.org/r/124548 (owner: 10Siebrand) [10:28:07] (03PS3) 10Addshore: Fix spelling: 'occurred' and whitespace [extensions/SimpleFarm] - 10https://gerrit.wikimedia.org/r/124543 (owner: 10Siebrand) [10:28:08] (03CR) 10Addshore: [C: 032] Fix spelling: 'occurred' and whitespace [extensions/SimpleFarm] - 10https://gerrit.wikimedia.org/r/124543 (owner: 10Siebrand) [10:28:08] (03Merged) 10jenkins-bot: Fix spelling: 'occurred' and whitespace [extensions/SimpleFarm] - 10https://gerrit.wikimedia.org/r/124543 (owner: 10Siebrand) [10:28:17] (03CR) 10Addshore: [C: 032] Fix spelling: 'occurred' [extensions/SwiftCloudFiles] - 10https://gerrit.wikimedia.org/r/124531 (owner: 10Siebrand) [10:28:19] (03Merged) 10jenkins-bot: Fix spelling: 'occurred' [extensions/SwiftCloudFiles] - 10https://gerrit.wikimedia.org/r/124531 (owner: 10Siebrand) [10:28:21] (03Merged) 10jenkins-bot: Add modul namespace translation for bg [extensions/Scribunto] - 10https://gerrit.wikimedia.org/r/124330 (owner: 10Raimond Spekking) [10:28:36] (03CR) 10Bartosz Dziewoński: [C: 032] qunit: Implement suppressWarnings/restoreWarnings [core] - 10https://gerrit.wikimedia.org/r/124374 (owner: 10Krinkle) [10:28:43] (03PS3) 10Addshore: Fix whitespace and spelling: 'occurred' [extensions/WikiLexicalData] - 10https://gerrit.wikimedia.org/r/124528 (owner: 10Siebrand) [10:28:47] (03CR) 10Addshore: [C: 032] Fix whitespace and spelling: 'occurred' [extensions/WikiLexicalData] - 10https://gerrit.wikimedia.org/r/124528 (owner: 10Siebrand) [10:29:30] (03Merged) 10jenkins-bot: Fix whitespace and spelling: 'occurred' [extensions/WikiLexicalData] - 10https://gerrit.wikimedia.org/r/124528 (owner: 10Siebrand) [10:31:13] (03CR) 10Addshore: [C: 032] Fix spelling: occurred [extensions/LinkedWiki] - 10https://gerrit.wikimedia.org/r/124533 (owner: 10Siebrand) [10:31:15] (03Merged) 10jenkins-bot: Fix spelling: occurred [extensions/LinkedWiki] - 10https://gerrit.wikimedia.org/r/124533 (owner: 10Siebrand) [10:31:45] (03CR) 10Addshore: [C: 032 V: 032] "phplint passed" [extensions/ArticleFeedback] - 10https://gerrit.wikimedia.org/r/124540 (owner: 10Siebrand) [10:31:47] (03CR) 10jenkins-bot: [V: 04-1] qunit: Implement suppressWarnings/restoreWarnings [core] - 10https://gerrit.wikimedia.org/r/124374 (owner: 10Krinkle) [10:31:49] (03CR) 10jenkins-bot: [V: 04-1] Fix spelling: 'occurred' [extensions/ArticleFeedback] - 10https://gerrit.wikimedia.org/r/124540 (owner: 10Siebrand) [10:32:34] (03CR) 10Addshore: [C: 032 V: 032] "phplint passed" [extensions/Spreadsheet] - 10https://gerrit.wikimedia.org/r/124553 (owner: 10Siebrand) [10:32:36] (03CR) 10jenkins-bot: [V: 04-1] Fix spelling: 'occurred' [extensions/Spreadsheet] - 10https://gerrit.wikimedia.org/r/124553 (owner: 10Siebrand) [10:34:17] (03CR) 10Hashar: [C: 04-1] "nitpicking! :-]" (032 comments) [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/124577 (owner: 10Addshore) [10:35:31] (03PS1) 10Thiemo Mättig (WMDE): WebInstaller inline documentation cleanup [core] - 10https://gerrit.wikimedia.org/r/124580 [10:35:52] (03PS3) 10Addshore: Stop voting for jslint checks on 2 failing exts [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/124577 [10:36:35] (03PS4) 10Addshore: Stop voting for jslint checks on 2 failing exts [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/124577 [10:37:03] (03PS3) 10AndyRussG: WIP Update Campaigns database schema [extensions/Campaigns] (wip/editorcampaigns) - 10https://gerrit.wikimedia.org/r/122223 [10:37:10] (03CR) 10Hashar: [C: 032] "\O/" [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/124577 (owner: 10Addshore) [10:37:20] (03Merged) 10jenkins-bot: Stop voting for jslint checks on 2 failing exts [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/124577 (owner: 10Addshore) [10:37:27] (03PS3) 10Aude: Remove grouping in EnhancedChangesList for RC_MOVE and RC_MOVE_OVER_REDIRECT [core] - 10https://gerrit.wikimedia.org/r/124574 [10:39:07] (03PS1) 10Addshore: Add lint checks for WYSIWYG extension [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/124581 [10:40:29] (03PS1) 10Addshore: Add checks trigger for WYSIWYG extension [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/124582 [10:40:38] (03CR) 10Aude: Remove grouping in EnhancedChangesList for RC_MOVE and RC_MOVE_OVER_REDIRECT (032 comments) [core] - 10https://gerrit.wikimedia.org/r/124574 (owner: 10Aude) [10:41:04] (03PS1) 10Physikerwelt: Fix: Allow
as valid Math output [extensions/Math] - 10https://gerrit.wikimedia.org/r/124583 [10:41:11] (03CR) 10Aude: "We can probably follow up and remove handling of these types in more places, and maybe remove it entirely." [core] - 10https://gerrit.wikimedia.org/r/124574 (owner: 10Aude) [10:41:22] (03PS6) 10AndyRussG: WIP Domain layer and DB persistence with data mapper [extensions/Campaigns] (wip/editorcampaigns) - 10https://gerrit.wikimedia.org/r/123781 [10:42:29] (03Abandoned) 10Physikerwelt: Fix: Allow
as valid Math output [extensions/Math] (math2_0_0) - 10https://gerrit.wikimedia.org/r/112325 (owner: 10Physikerwelt) [10:42:52] (03CR) 10AndyRussG: "Rebased onto new version of schema change." [extensions/Campaigns] (wip/editorcampaigns) - 10https://gerrit.wikimedia.org/r/123781 (owner: 10AndyRussG) [10:44:29] (03Abandoned) 10Physikerwelt: Change database layout [extensions/Math] (math2_0_0) - 10https://gerrit.wikimedia.org/r/112326 (owner: 10Physikerwelt) [10:44:46] (03Abandoned) 10Physikerwelt: Introduce $wgMathValidModes to adjust the selectable math rendering modes in user preferences [extensions/Math] (math2_0_0) - 10https://gerrit.wikimedia.org/r/112327 (owner: 10Physikerwelt) [10:45:06] (03Abandoned) 10Physikerwelt: Introduce orthogonal option to enable MathJax [extensions/Math] (math2_0_0) - 10https://gerrit.wikimedia.org/r/112328 (owner: 10Physikerwelt) [10:45:36] (03PS7) 10Addshore: MW WLD prefix compatibility fix [extensions/WikiLexicalData] - 10https://gerrit.wikimedia.org/r/119446 (owner: 10Hiong3-eng5) [10:45:55] (03CR) 10Addshore: [C: 04-1] "needs a manual rebase" [extensions/WikiLexicalData] - 10https://gerrit.wikimedia.org/r/121853 (owner: 10Purodha) [10:51:16] (03PS7) 10AndyRussG: WIP Domain layer and DB persistence with data mapper [extensions/Campaigns] (wip/editorcampaigns) - 10https://gerrit.wikimedia.org/r/123781 [10:55:08] (03CR) 10Hashar: [C: 032] Add lint checks for WYSIWYG extension [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/124581 (owner: 10Addshore) [10:55:45] (03Merged) 10jenkins-bot: Add lint checks for WYSIWYG extension [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/124581 (owner: 10Addshore) [10:57:17] (03PS2) 10AndyRussG: Participation on create account via campaign url [extensions/Campaigns] (wip/editorcampaigns) - 10https://gerrit.wikimedia.org/r/119258 [10:58:02] (03CR) 10AndyRussG: "Rebased onto new domain and persistence layer patch." [extensions/Campaigns] (wip/editorcampaigns) - 10https://gerrit.wikimedia.org/r/119258 (owner: 10AndyRussG) [10:58:33] (03Abandoned) 10Hashar: Add checks trigger for WYSIWYG extension [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/124582 (owner: 10Addshore) [10:58:48] (03PS1) 10Hashar: Revert "Add lint checks for WYSIWYG extension" [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/124584 [10:59:00] (03CR) 10Addshore: [C: 031] Revert "Add lint checks for WYSIWYG extension" [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/124584 (owner: 10Hashar) [10:59:15] (03CR) 10Hashar: [C: 032] Revert "Add lint checks for WYSIWYG extension" [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/124584 (owner: 10Hashar) [11:00:04] (03Merged) 10jenkins-bot: Revert "Add lint checks for WYSIWYG extension" [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/124584 (owner: 10Hashar) [11:02:29] (03CR) 10Addshore: [C: 032 V: 032] Fix spelling: occurred [extensions/WYSIWYG] - 10https://gerrit.wikimedia.org/r/124530 (owner: 10Siebrand) [11:03:27] (03CR) 10Lord Farin: [C: 031] remove armourMath and wgContLang (bug 60799) [extensions/Math] - 10https://gerrit.wikimedia.org/r/111119 (owner: 10Physikerwelt) [11:07:39] (03CR) 10Frédéric Wang: [C: 031] Fix: Allow
as valid Math output (031 comment) [extensions/Math] - 10https://gerrit.wikimedia.org/r/124583 (owner: 10Physikerwelt) [11:12:10] (03CR) 10Lord Farin: [C: 031] Fix: Allow
as valid Math output [extensions/Math] - 10https://gerrit.wikimedia.org/r/124583 (owner: 10Physikerwelt) [11:12:32] (03PS3) 10AndyRussG: Participation on create account via campaign url [extensions/Campaigns] (wip/editorcampaigns) - 10https://gerrit.wikimedia.org/r/119258 [11:14:20] (03CR) 10AndyRussG: "Updated to use new domain layer." [extensions/Campaigns] (wip/editorcampaigns) - 10https://gerrit.wikimedia.org/r/119258 (owner: 10AndyRussG) [11:15:30] (03CR) 10Frédéric Wang: [C: 032] remove armourMath and wgContLang (bug 60799) [extensions/Math] - 10https://gerrit.wikimedia.org/r/111119 (owner: 10Physikerwelt) [11:16:25] (03Merged) 10jenkins-bot: remove armourMath and wgContLang (bug 60799) [extensions/Math] - 10https://gerrit.wikimedia.org/r/111119 (owner: 10Physikerwelt) [11:18:46] (03PS5) 10AndyRussG: WIP Query API modules for campaigns and participants [extensions/Campaigns] (wip/editorcampaigns) - 10https://gerrit.wikimedia.org/r/117380 [11:19:30] (03CR) 10AndyRussG: "Rebased..." [extensions/Campaigns] (wip/editorcampaigns) - 10https://gerrit.wikimedia.org/r/117380 (owner: 10AndyRussG) [11:24:50] (03PS3) 10KartikMistry: Move all test htmls to html files [services/cxserver] - 10https://gerrit.wikimedia.org/r/124298 (owner: 10Santhosh) [11:24:59] (03CR) 10Bartosz Dziewoński: [V: 032] "Jenkins lies, verified locally." [core] - 10https://gerrit.wikimedia.org/r/124374 (owner: 10Krinkle) [11:25:05] (03CR) 10Smuggli: [C: 032] Fix spelling: occurred [extensions/BlueSpiceExtensions] - 10https://gerrit.wikimedia.org/r/124547 (owner: 10Siebrand) [11:27:15] (03CR) 10Bartosz Dziewoński: [C: 04-1] "Needs rebase." [core] - 10https://gerrit.wikimedia.org/r/121566 (owner: 10Krinkle) [11:27:32] (03CR) 10Bartosz Dziewoński: [V: 032] "Jenkins issue is bug 63579." [core] - 10https://gerrit.wikimedia.org/r/111736 (owner: 10Parent5446) [11:29:26] (03CR) 10Bartosz Dziewoński: [V: 032] Fix typo in API doc [extensions/TextExtracts] - 10https://gerrit.wikimedia.org/r/124144 (owner: 10Grunny) [11:29:37] (03PS4) 10KartikMistry: Move all test htmls to html files [services/cxserver] - 10https://gerrit.wikimedia.org/r/124298 (owner: 10Santhosh) [11:30:38] (03CR) 10KartikMistry: [C: 032] "Tests OK. Thanks for simplifying it!" [services/cxserver] - 10https://gerrit.wikimedia.org/r/124298 (owner: 10Santhosh) [11:31:01] (03Merged) 10jenkins-bot: Move all test htmls to html files [services/cxserver] - 10https://gerrit.wikimedia.org/r/124298 (owner: 10Santhosh) [11:32:19] (03PS6) 10AndyRussG: WIP Query API modules for campaigns and participants [extensions/Campaigns] (wip/editorcampaigns) - 10https://gerrit.wikimedia.org/r/117380 [11:33:30] (03CR) 10AndyRussG: "Updated to use new domain layer." [extensions/Campaigns] (wip/editorcampaigns) - 10https://gerrit.wikimedia.org/r/117380 (owner: 10AndyRussG) [11:40:11] (03PS24) 10Liangent: Refactor ipboptions and Xml::listDropDown() [core] - 10https://gerrit.wikimedia.org/r/22699 [11:41:08] (03CR) 10Siebrand: [V: 032] "No Jenkins." [extensions/BlueSpiceExtensions] - 10https://gerrit.wikimedia.org/r/124547 (owner: 10Siebrand) [11:44:13] (03CR) 10Siebrand: Refactor ipboptions and Xml::listDropDown() (031 comment) [core] - 10https://gerrit.wikimedia.org/r/22699 (owner: 10Liangent) [11:44:19] (03CR) 10Siebrand: [C: 04-1] Refactor ipboptions and Xml::listDropDown() [core] - 10https://gerrit.wikimedia.org/r/22699 (owner: 10Liangent) [11:46:22] (03PS1) 10Hiong3-eng5: Defined Meaning Namespace using defined meaning id only. [extensions/WikiLexicalData] - 10https://gerrit.wikimedia.org/r/124585 [11:47:53] (03PS4) 10Aude: Remove RC_MOVE and RC_MOVE_OVER_REDIRECT grouping in EnhancedChangesList [core] - 10https://gerrit.wikimedia.org/r/124574 [11:53:17] (03PS25) 10Liangent: Refactor ipboptions and Xml::listDropDown() [core] - 10https://gerrit.wikimedia.org/r/22699 [11:54:21] (03PS26) 10Liangent: Refactor ipboptions and Xml::listDropDown() [core] - 10https://gerrit.wikimedia.org/r/22699 [11:57:03] (03PS4) 10Aude: Split part of EnhancedChangesList::recentChangesLine into new method [core] - 10https://gerrit.wikimedia.org/r/124527 [11:57:10] (03PS5) 10Aude: Remove RC_MOVE and RC_MOVE_OVER_REDIRECT grouping in EnhancedChangesList [core] - 10https://gerrit.wikimedia.org/r/124574 [12:04:49] (03CR) 10jenkins-bot: [V: 04-1] Split part of EnhancedChangesList::recentChangesLine into new method [core] - 10https://gerrit.wikimedia.org/r/124527 (owner: 10Aude) [12:04:58] (03CR) 10jenkins-bot: [V: 04-1] Remove RC_MOVE and RC_MOVE_OVER_REDIRECT grouping in EnhancedChangesList [core] - 10https://gerrit.wikimedia.org/r/124574 (owner: 10Aude) [12:07:37] (03PS1) 10Pastakhov: set edit section false (version 0.4.1) [extensions/Mpdf] - 10https://gerrit.wikimedia.org/r/124586 [12:08:29] (03CR) 10Pastakhov: [C: 032 V: 032] set edit section false (version 0.4.1) [extensions/Mpdf] - 10https://gerrit.wikimedia.org/r/124586 (owner: 10Pastakhov) [12:45:13] http://www.ie6death.com/ [12:45:18] KILL ALL THE IE6 SUPPORTS [12:48:39] (03PS1) 10Siebrand: Replace deprecated wfMsg* call [extensions/LogoFunctions] - 10https://gerrit.wikimedia.org/r/124588 [12:49:04] (03PS1) 10Siebrand: Fix grammar and punctuation [extensions/LogoFunctions] - 10https://gerrit.wikimedia.org/r/124589 [12:52:19] (03PS2) 10TheDJ: Add SVG versions of toolbar icons [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/97454 (owner: 10M4tx) [12:52:53] (03CR) 10TheDJ: "rebased and trailing whitespace removed" (031 comment) [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/97454 (owner: 10M4tx) [13:06:59] (03PS1) 10Siebrand: Update grammar and punctuation [extensions/Foxway] - 10https://gerrit.wikimedia.org/r/124592 [13:09:49] (03PS1) 10Siebrand: Wrap parameter in code tags [core] - 10https://gerrit.wikimedia.org/r/124593 [13:15:31] (03PS2) 10Siebrand: Update grammar and punctuation [extensions/Foxway] - 10https://gerrit.wikimedia.org/r/124592 [13:27:37] (03CR) 10Raimond Spekking: [C: 032 V: 032] Fix grammar and punctuation [extensions/LogoFunctions] - 10https://gerrit.wikimedia.org/r/124589 (owner: 10Siebrand) [13:34:23] (03CR) 10Alex Monk: [C: 031] Revert font stack to be just sans-serif [core] - 10https://gerrit.wikimedia.org/r/124475 (owner: 10Odder) [13:38:01] (03CR) 10Raimond Spekking: [C: 032 V: 032] Update grammar and punctuation [extensions/Foxway] - 10https://gerrit.wikimedia.org/r/124592 (owner: 10Siebrand) [13:38:19] (03PS1) 10Mwjames: Adds a $egChameleonExternalStyleModules [skins/chameleon] - 10https://gerrit.wikimedia.org/r/124596 [13:38:44] (03CR) 10Raimond Spekking: [C: 032] Wrap parameter in code tags [core] - 10https://gerrit.wikimedia.org/r/124593 (owner: 10Siebrand) [13:41:45] (03Merged) 10jenkins-bot: Wrap parameter in code tags [core] - 10https://gerrit.wikimedia.org/r/124593 (owner: 10Siebrand) [13:41:53] (03PS14) 10Alex Monk: mediawiki.action.edit: Autosave edit textareas in localStorage [core] - 10https://gerrit.wikimedia.org/r/5130 (owner: 10Joancreus) [13:42:46] (03CR) 10Aude: "unrelated issue in qunit" [core] - 10https://gerrit.wikimedia.org/r/124527 (owner: 10Aude) [13:43:08] (03CR) 10Aude: "unrelated issue in qunit" [core] - 10https://gerrit.wikimedia.org/r/124574 (owner: 10Aude) [13:43:38] (03CR) 10jenkins-bot: [V: 04-1] mediawiki.action.edit: Autosave edit textareas in localStorage [core] - 10https://gerrit.wikimedia.org/r/5130 (owner: 10Joancreus) [13:45:01] (03PS15) 10Alex Monk: mediawiki.action.edit: Autosave edit textareas in localStorage [core] - 10https://gerrit.wikimedia.org/r/5130 (owner: 10Joancreus) [13:52:15] (03CR) 10MZMcBride: "I agree with the one step approach." [core] - 10https://gerrit.wikimedia.org/r/124475 (owner: 10Odder) [14:01:28] (03PS2) 10Mwjames: Adds a $egChameleonExternalStyleModules [skins/chameleon] - 10https://gerrit.wikimedia.org/r/124596 [14:04:55] (03CR) 10UltrasonicNXT: "Sorry Legoktm, I reckon this is just about out of WIP now... I'd love some help from you/Jack testing :)" [extensions/WikiForum] - 10https://gerrit.wikimedia.org/r/116258 (owner: 10UltrasonicNXT) [14:07:48] manybubbles: what was fast [14:14:05] (03PS1) 10Matthias Mullie: Tweaks to FeatureIndex::findMulti [extensions/Flow] - 10https://gerrit.wikimedia.org/r/124602 [14:15:47] (03CR) 10Siebrand: [C: 031] "i18n/L10n reviewed." [core] - 10https://gerrit.wikimedia.org/r/5130 (owner: 10Joancreus) [14:15:53] Nikerabbit: I'm waiting on ops for something and trying to read some of the papers that describe some of the algorithms Lucene uses for correction - so this was lighter reading:) [14:17:27] (03PS23) 10Siebrand: Initial implementation of the JSON configuration store. [extensions/JsonConfig] - 10https://gerrit.wikimedia.org/r/98767 (owner: 10Yurik) [14:17:45] (03CR) 10Siebrand: [C: 031] "PS23: I thought I might as well add the i18n folder..." [extensions/JsonConfig] - 10https://gerrit.wikimedia.org/r/98767 (owner: 10Yurik) [14:22:21] (03CR) 10Mwjames: "This keeps exposing the BootstrapManager implementation [0] away from LocalSettings to minimize any possible incompatibilities in future." [skins/chameleon] - 10https://gerrit.wikimedia.org/r/124596 (owner: 10Mwjames) [14:22:47] (03PS24) 10Siebrand: Initial implementation of the JSON configuration store. [extensions/JsonConfig] - 10https://gerrit.wikimedia.org/r/98767 (owner: 10Yurik) [14:24:14] (03CR) 10Siebrand: "Please ignore PS21, 22, 23. They're nonsense. Comparison can be done from PS20->PS24." [extensions/JsonConfig] - 10https://gerrit.wikimedia.org/r/98767 (owner: 10Yurik) [14:41:01] (03CR) 10Nikerabbit: [C: 04-1] Replace deprecated wfMsg* call (031 comment) [extensions/LogoFunctions] - 10https://gerrit.wikimedia.org/r/124588 (owner: 10Siebrand) [14:44:33] (03PS2) 10Siebrand: Replace deprecated wfMsg* call [extensions/LogoFunctions] - 10https://gerrit.wikimedia.org/r/124588 [15:09:37] (03Restored) 10Physikerwelt: Introduce orthogonal option to enable MathJax [extensions/Math] - 10https://gerrit.wikimedia.org/r/110226 (owner: 10Physikerwelt) [15:11:06] (03PS6) 10Physikerwelt: $wgMathValidModes and orthogonal MathJax enabler [extensions/Math] - 10https://gerrit.wikimedia.org/r/110226 [15:11:39] (03PS2) 10Matthias Mullie: Tweaks to FeatureIndex::findMulti [extensions/Flow] - 10https://gerrit.wikimedia.org/r/124602 [15:12:19] (03CR) 10jenkins-bot: [V: 04-1] $wgMathValidModes and orthogonal MathJax enabler [extensions/Math] - 10https://gerrit.wikimedia.org/r/110226 (owner: 10Physikerwelt) [15:17:21] (03PS1) 10Siebrand: Correct phrasing of Attribution-ShareAlike [extensions/WikimediaMessages] - 10https://gerrit.wikimedia.org/r/124610 [15:20:45] (03CR) 10Frédéric Wang: $wgMathValidModes and orthogonal MathJax enabler (032 comments) [extensions/Math] - 10https://gerrit.wikimedia.org/r/110226 (owner: 10Physikerwelt) [15:22:04] (03CR) 10Physikerwelt: $wgMathValidModes and orthogonal MathJax enabler (032 comments) [extensions/Math] - 10https://gerrit.wikimedia.org/r/110226 (owner: 10Physikerwelt) [15:23:31] (03CR) 10Raimond Spekking: [C: 032] Correct phrasing of Attribution-ShareAlike [extensions/WikimediaMessages] - 10https://gerrit.wikimedia.org/r/124610 (owner: 10Siebrand) [15:23:33] (03Merged) 10jenkins-bot: Correct phrasing of Attribution-ShareAlike [extensions/WikimediaMessages] - 10https://gerrit.wikimedia.org/r/124610 (owner: 10Siebrand) [15:26:10] (03PS7) 10Physikerwelt: $wgMathValidModes and orthogonal MathJax enabler [extensions/Math] - 10https://gerrit.wikimedia.org/r/110226 [15:26:39] (03PS1) 10TheDJ: Fix trailing commas in MathJax wiki2jax [extensions/Math] - 10https://gerrit.wikimedia.org/r/124612 [15:27:57] (03CR) 10Physikerwelt: [C: 032] Fix trailing commas in MathJax wiki2jax [extensions/Math] - 10https://gerrit.wikimedia.org/r/124612 (owner: 10TheDJ) [15:29:05] (03Merged) 10jenkins-bot: Fix trailing commas in MathJax wiki2jax [extensions/Math] - 10https://gerrit.wikimedia.org/r/124612 (owner: 10TheDJ) [15:29:43] (03PS8) 10Physikerwelt: $wgMathValidModes and orthogonal MathJax enabler [extensions/Math] - 10https://gerrit.wikimedia.org/r/110226 [15:30:03] (03PS5) 10Umherirrender: Removed unneeded spaces and colons in @param and friends [core] - 10https://gerrit.wikimedia.org/r/124366 [15:31:14] (03CR) 10Umherirrender: "Patch Set 5: Fixed inline comments" (033 comments) [core] - 10https://gerrit.wikimedia.org/r/124366 (owner: 10Umherirrender) [15:31:24] (03PS2) 10Jackmcbarn: Make RECOVER_ORIG preserve extension tags [core] - 10https://gerrit.wikimedia.org/r/123516 [15:31:41] (03PS1) 10Siebrand: Remove title case for "trackingcategories-msg" [core] - 10https://gerrit.wikimedia.org/r/124613 [15:32:02] (03PS2) 10TheDJ: Cleanup borders of wikiEditor [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/124607 [15:32:59] (03CR) 10Raimond Spekking: [C: 032] Remove title case for "trackingcategories-msg" [core] - 10https://gerrit.wikimedia.org/r/124613 (owner: 10Siebrand) [15:34:12] (03CR) 10Chad: "One semi-minor question inline, otherwise lgtm." (031 comment) [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/123885 (owner: 10Manybubbles) [15:35:59] (03PS1) 10Siebrand: Reduce complexity of "noindex-category-desc" [core] - 10https://gerrit.wikimedia.org/r/124614 [15:37:15] (03Merged) 10jenkins-bot: Remove title case for "trackingcategories-msg" [core] - 10https://gerrit.wikimedia.org/r/124613 (owner: 10Siebrand) [15:37:46] (03PS1) 10Netbrain: Fixed issue where subpage didn't parse magic word like {{PAGENAME}} [extensions/SideBarMenu] - 10https://gerrit.wikimedia.org/r/124615 [15:38:00] (03CR) 10Netbrain: [C: 032 V: 032] Fixed issue where subpage didn't parse magic word like {{PAGENAME}} [extensions/SideBarMenu] - 10https://gerrit.wikimedia.org/r/124615 (owner: 10Netbrain) [15:40:16] (03CR) 10Chad: [C: 032] Prefer title for prefix search match [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/124344 (owner: 10Manybubbles) [15:40:36] (03Merged) 10jenkins-bot: Prefer title for prefix search match [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/124344 (owner: 10Manybubbles) [15:40:58] (03CR) 10Raimond Spekking: [C: 032] Reduce complexity of "noindex-category-desc" [core] - 10https://gerrit.wikimedia.org/r/124614 (owner: 10Siebrand) [15:41:59] (03CR) 10jenkins-bot: [V: 04-1] Reduce complexity of "noindex-category-desc" [core] - 10https://gerrit.wikimedia.org/r/124614 (owner: 10Siebrand) [15:42:36] (03CR) 10Siebrand: "The QUnit failure is not related to the contents of this patch set." [core] - 10https://gerrit.wikimedia.org/r/124614 (owner: 10Siebrand) [15:44:16] (03Merged) 10jenkins-bot: Reduce complexity of "noindex-category-desc" [core] - 10https://gerrit.wikimedia.org/r/124614 (owner: 10Siebrand) [15:44:48] (03CR) 10Frédéric Wang: [C: 032] $wgMathValidModes and orthogonal MathJax enabler [extensions/Math] - 10https://gerrit.wikimedia.org/r/110226 (owner: 10Physikerwelt) [15:45:26] (03CR) 10Addshore: [C: 032] Removed unneeded spaces and colons in @param and friends [core] - 10https://gerrit.wikimedia.org/r/124366 (owner: 10Umherirrender) [15:46:48] (03CR) 10TheDJ: [C: 04-1] "I think this should be in a separate module that is initiated from mediawiki.action.edit" [core] - 10https://gerrit.wikimedia.org/r/5130 (owner: 10Joancreus) [15:46:50] (03Merged) 10jenkins-bot: $wgMathValidModes and orthogonal MathJax enabler [extensions/Math] - 10https://gerrit.wikimedia.org/r/110226 (owner: 10Physikerwelt) [15:50:30] (03CR) 10jenkins-bot: [V: 04-1] Removed unneeded spaces and colons in @param and friends [core] - 10https://gerrit.wikimedia.org/r/124366 (owner: 10Umherirrender) [15:50:47] (03CR) 10TheDJ: "i'm not clear enough on what is going on here, do we have some example page or something ?" [extensions/Math] - 10https://gerrit.wikimedia.org/r/124583 (owner: 10Physikerwelt) [15:52:42] Engineering Community Team monthly meeting starting in 10 minutes in #wikimedia-office . Topics: https://www.mediawiki.org/wiki/Engineering_Community_Team/Meetings#2014-04-08 [15:54:20] (03PS1) 10Yuvipanda: Add jslint job for Wikipedia app [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/124617 [15:56:56] (03CR) 10Hashar: [C: 04-1] "https://integration.wikimedia.org/ci/job/integration-jjb-config-diff/84/console is not happy :-]" (031 comment) [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/124617 (owner: 10Yuvipanda) [15:57:18] (03CR) 10EBernhardson: Replace in_array( array_keys( ... ) ) with array_key_exists( ... ) (031 comment) [core] - 10https://gerrit.wikimedia.org/r/123106 (owner: 10Thiemo Mättig (WMDE)) [15:57:42] (03PS2) 10Yuvipanda: Add jslint job for Wikipedia app [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/124617 [16:00:18] (03CR) 10Hashar: "That creates a job named apps-android-wikipedia-jslint . You can get it deployed on Jenkins by following up the JJB tutorial https://www.m" [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/124617 (owner: 10Yuvipanda) [16:00:53] (03PS1) 10Jdlrobson: Follow up to If985b16c4f682d737683597ed80951c6d6644c8f [core] - 10https://gerrit.wikimedia.org/r/124618 [16:01:41] (03CR) 10Jdlrobson: [C: 04-1] "The selector need not be so strong (and if so should be clearly documented)" (031 comment) [core] - 10https://gerrit.wikimedia.org/r/124131 (owner: 10MaxSem) [16:02:43] jdlrobson: regarding https://gerrit.wikimedia.org/r/#/c/124486/, I've issue with fonts now on enwp, and I have no idea now how it's meant to look like; see http://imgur.com/a/dri88 [16:02:51] (03PS6) 10Addshore: Removed unneeded spaces and colons in @param and friends [core] - 10https://gerrit.wikimedia.org/r/124366 (owner: 10Umherirrender) [16:02:55] (03CR) 10Addshore: [C: 032] Removed unneeded spaces and colons in @param and friends [core] - 10https://gerrit.wikimedia.org/r/124366 (owner: 10Umherirrender) [16:03:21] currently the fat font I see it's rather bad for mi eyes [16:04:15] jdlrobson: is it meant to look like that? [16:04:21] ... [16:04:47] RoanKattouw_away: poke [16:05:46] (03PS1) 10Jackmcbarn: Allow calling #expr from Lua without the parser [extensions/ParserFunctions] - 10https://gerrit.wikimedia.org/r/124620 [16:06:53] (03CR) 10Chad: [C: 032] Set the "error" field in the right array [core] - 10https://gerrit.wikimedia.org/r/124394 (owner: 10Aaron Schulz) [16:07:34] (03CR) 10Hashar: [C: 032] "Deployed by Yuvi!" [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/124617 (owner: 10Yuvipanda) [16:07:41] (03CR) 10jenkins-bot: [V: 04-1] Removed unneeded spaces and colons in @param and friends [core] - 10https://gerrit.wikimedia.org/r/124366 (owner: 10Umherirrender) [16:07:43] (03CR) 10jenkins-bot: [V: 04-1] Follow up to If985b16c4f682d737683597ed80951c6d6644c8f [core] - 10https://gerrit.wikimedia.org/r/124618 (owner: 10Jdlrobson) [16:07:50] (03PS3) 10Hashar: Setup jslint for Wikipedia Android app [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/124539 (owner: 10Yuvipanda) [16:08:01] (03CR) 10MaxSem: [C: 04-1] "Release notes could use some improvement, looks good otherwise." (031 comment) [core] - 10https://gerrit.wikimedia.org/r/124618 (owner: 10Jdlrobson) [16:08:21] (03CR) 10Hashar: [C: 032] "Jobs created by Yuvi and deployed :-]" [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/124539 (owner: 10Yuvipanda) [16:08:25] (03Merged) 10jenkins-bot: Add jslint job for Wikipedia app [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/124617 (owner: 10Yuvipanda) [16:08:32] (03CR) 10Chad: [C: 032] Handle null file handles in UIDGenerator::_destruct() [core] - 10https://gerrit.wikimedia.org/r/124490 (owner: 10Aaron Schulz) [16:08:34] (03Abandoned) 10MaxSem: Restore explicit scoping for .external links [core] - 10https://gerrit.wikimedia.org/r/124131 (owner: 10MaxSem) [16:08:43] (03Merged) 10jenkins-bot: Setup jslint for Wikipedia Android app [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/124539 (owner: 10Yuvipanda) [16:09:31] (03CR) 10Chad: [C: 032] Removed useless JobQueue return values [core] - 10https://gerrit.wikimedia.org/r/123498 (owner: 10Aaron Schulz) [16:10:17] (03Merged) 10jenkins-bot: Set the "error" field in the right array [core] - 10https://gerrit.wikimedia.org/r/124394 (owner: 10Aaron Schulz) [16:10:35] (03CR) 10Chad: [C: 032] Made runJobs.php fully respect $wgJobBackoffThrottling [core] - 10https://gerrit.wikimedia.org/r/123504 (owner: 10Aaron Schulz) [16:11:24] (03CR) 10jenkins-bot: [V: 04-1] Handle null file handles in UIDGenerator::_destruct() [core] - 10https://gerrit.wikimedia.org/r/124490 (owner: 10Aaron Schulz) [16:12:01] (03PS2) 10Physikerwelt: Fix: Allow
as valid Math output [extensions/Math] - 10https://gerrit.wikimedia.org/r/124583 [16:12:18] (03CR) 10Chad: [C: 032] Added limit to countRevisionsBetween() for sanity [core] - 10https://gerrit.wikimedia.org/r/124476 (owner: 10Aaron Schulz) [16:13:00] (03Merged) 10jenkins-bot: Removed useless JobQueue return values [core] - 10https://gerrit.wikimedia.org/r/123498 (owner: 10Aaron Schulz) [16:13:16] (03CR) 10Physikerwelt: "@TheDJ: This change affects wikis that use LaTeXML as renderer only." [extensions/Math] - 10https://gerrit.wikimedia.org/r/124583 (owner: 10Physikerwelt) [16:13:29] (03PS3) 10Physikerwelt: Fix: Allow
as valid Math output [extensions/Math] - 10https://gerrit.wikimedia.org/r/124583 [16:13:45] (03PS2) 10Aaron Schulz: Handle null file handles in UIDGenerator::_destruct() [core] - 10https://gerrit.wikimedia.org/r/124490 [16:13:51] (03CR) 10Aaron Schulz: [C: 032] Handle null file handles in UIDGenerator::_destruct() [core] - 10https://gerrit.wikimedia.org/r/124490 (owner: 10Aaron Schulz) [16:15:32] (03Merged) 10jenkins-bot: Made runJobs.php fully respect $wgJobBackoffThrottling [core] - 10https://gerrit.wikimedia.org/r/123504 (owner: 10Aaron Schulz) [16:15:42] (03CR) 10Swalling: [C: 031] "Gender support added. Thanks for the help everyone." [extensions/GuidedTour] - 10https://gerrit.wikimedia.org/r/119261 (owner: 10Phuedx) [16:15:47] (03Merged) 10jenkins-bot: Added limit to countRevisionsBetween() for sanity [core] - 10https://gerrit.wikimedia.org/r/124476 (owner: 10Aaron Schulz) [16:17:09] Nemo_bis, ping. ECT meeting [16:20:35] (03CR) 10Frédéric Wang: [C: 031] "OK, looks good to me now. I guess you don't care if the namespace is not logged in the error message." [extensions/Math] - 10https://gerrit.wikimedia.org/r/124583 (owner: 10Physikerwelt) [16:22:27] (03PS4) 10Manybubbles: Add support for the experimental highlighter [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/123885 [16:23:50] qgil: pong? am I needed [16:24:09] (03CR) 10Edokter: [C: 031] "I don't agree with the 'free font' ideology; this is a technical issue. A single, global font stack is not feasable as non-latin scripts a" [core] - 10https://gerrit.wikimedia.org/r/124475 (owner: 10Odder) [16:24:12] * Nemo_bis thought it was just topic proposal [16:24:43] (03CR) 10Chad: [C: 032] Add support for the experimental highlighter [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/123885 (owner: 10Manybubbles) [16:25:08] Nemo_bis, hi, you proposed a topic for the ECT meeting happening now at #wikimedia-office , right [16:25:24] Nemo_bis, please show up and present the topic [16:25:42] (03CR) 10Swalling: "I will be removing my -2 only after we've heard from the designers on this. They need to participate in the Wikitech-l discussion, and sta" [core] - 10https://gerrit.wikimedia.org/r/124475 (owner: 10Odder) [16:25:59] (03CR) 10Isarra: "And one that works for every browser, every OS, every different font rendering setting in each? This isn't feasible. Language issues are b" [core] - 10https://gerrit.wikimedia.org/r/124475 (owner: 10Odder) [16:26:24] (03Merged) 10jenkins-bot: Add support for the experimental highlighter [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/123885 (owner: 10Manybubbles) [16:28:44] (03PS1) 10Cmcmahon: Update Ruby gems to repair broken upload steps [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/124625 [16:29:47] (03CR) 10Zfilipin: [C: 032] Update Ruby gems to repair broken upload steps [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/124625 (owner: 10Cmcmahon) [16:29:57] (03Merged) 10jenkins-bot: Update Ruby gems to repair broken upload steps [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/124625 (owner: 10Cmcmahon) [16:30:00] (03CR) 10Thiemo Mättig (WMDE): Replace in_array( array_keys( ... ) ) with array_key_exists( ... ) (031 comment) [core] - 10https://gerrit.wikimedia.org/r/123106 (owner: 10Thiemo Mättig (WMDE)) [16:30:06] (03PS1) 10Siebrand: Add some settings and quoted test in code tags [core] - 10https://gerrit.wikimedia.org/r/124626 [16:31:11] (03Merged) 10jenkins-bot: Handle null file handles in UIDGenerator::_destruct() [core] - 10https://gerrit.wikimedia.org/r/124490 (owner: 10Aaron Schulz) [16:32:57] (03PS1) 10BryanDavis: Compile wikiversions.json to cdb for local sync [tools/scap] - 10https://gerrit.wikimedia.org/r/124627 [16:33:18] (03CR) 10jenkins-bot: [V: 04-1] Compile wikiversions.json to cdb for local sync [tools/scap] - 10https://gerrit.wikimedia.org/r/124627 (owner: 10BryanDavis) [16:34:46] curious, does it seem odd to anyone to have a two line if statement, with only ') {' on the second line? I can't think i've seen that anywhere else in the codebase. typically broken into 3+ line if's with the closing ') {' still on a line of its own [16:34:58] (03CR) 10Chad: ""Removing the styles without their input is a rush job." No, it isn't. It's restoring the status quo." [core] - 10https://gerrit.wikimedia.org/r/124475 (owner: 10Odder) [16:34:59] if it doesn't fit in 1 line, that is [16:35:17] (03PS2) 10BryanDavis: Compile wikiversions.json to cdb for local sync [tools/scap] - 10https://gerrit.wikimedia.org/r/124627 [16:36:44] (03PS1) 10Aaron Schulz: Backoff doing job run requests when the queue is empty [core] - 10https://gerrit.wikimedia.org/r/124629 [16:39:52] bd808: so now the cdb files will get synced in the same rsync that changes the MW versions for a wiki phase? [16:40:42] (03CR) 10Mattflaschen: "Per our discussion, I'll add the state to the fire call." [extensions/GuidedTour] - 10https://gerrit.wikimedia.org/r/123171 (owner: 10Mattflaschen) [16:40:45] that might cause intermittent missing message and magic work exceptions on scap (which is why Reedy moved the sync_wikiversions to the end) [16:41:00] scap really needs to work in two phases I guess [16:41:33] since the cdb rebuilds have this problem too [16:41:46] thedj: do you have any concerns regarding the LaTeXML change (https://gerrit.wikimedia.org/r/#/c/124583/) [16:41:46] two phases will be needed for hhvm as well [16:42:00] (03CR) 10EBernhardson: Replace in_array( array_keys( ... ) ) with array_key_exists( ... ) (031 comment) [core] - 10https://gerrit.wikimedia.org/r/123106 (owner: 10Thiemo Mättig (WMDE)) [16:42:17] physikerwelt: nope, not really [16:43:35] ^d: https://gerrit.wikimedia.org/r/#/c/124629/ weee [16:45:03] AaronSchulz: So I'm trying to take care of that problem. The cdb is synced from tin to tin and removed from the rsync source dir on tin before syncing to the rsync slaves and the cluster. [16:46:11] As the comments in the python code suggest it would be nicer to compile the cdb only in tin's /usr/local/apache/common-local but to do that I'd need to add another shell entry point that can be called as the mwdeploy user. [16:46:18] Which seemed yucky [16:47:08] and by "cdb rebuild" I meant json->cdb [16:47:14] * bd808 nods [16:48:12] if we just had to resync cdb instead of rsync json + convert json -> cdb then using rsync flags would probably be good enough (e.g. the delay flags that copy to /tmp and rename everything at the last second) [16:48:22] So my patch does json->cdb for wikiversions in /a/common, copies everything to /u/lo/a/common-local, and the deletes /a/common/wikiversions.cdb [16:48:47] ideally we could stage the new code a safe directory, run scripts on that, and then locally rsync (or use rename tricks) on each host [16:48:48] (03CR) 10Mattflaschen: "We decided to remove the commented out VE stuff in setupStepTransitionListeners." [extensions/GuidedTour] - 10https://gerrit.wikimedia.org/r/116228 (owner: 10Mattflaschen) [16:51:49] (03CR) 10Nemo bis: "On one thing Steven is right: I'm going to add all the designers I know of to cc for this change. Those who are not on gerrit can't compla" [core] - 10https://gerrit.wikimedia.org/r/124475 (owner: 10Odder) [16:53:52] (03CR) 10Frédéric Wang: [C: 032] Fix: Allow
as valid Math output [extensions/Math] - 10https://gerrit.wikimedia.org/r/124583 (owner: 10Physikerwelt) [16:54:53] (03Merged) 10jenkins-bot: Fix: Allow
as valid Math output [extensions/Math] - 10https://gerrit.wikimedia.org/r/124583 (owner: 10Physikerwelt) [16:55:41] (03CR) 10Alex Monk: "I guess you could say that it's a flaw, but it's certainly not limited to small wikis." [core] - 10https://gerrit.wikimedia.org/r/95878 (owner: 10Alex Monk) [16:55:45] (03PS1) 10Aude: Update Wikidata build [core] (wmf/1.23wmf20) - 10https://gerrit.wikimedia.org/r/124638 [16:56:42] (03CR) 10Aude: [C: 032] Update Wikidata build [core] (wmf/1.23wmf20) - 10https://gerrit.wikimedia.org/r/124638 (owner: 10Aude) [16:59:00] AaronSchulz: Changing the process to stage > compile > deploy on each host should be possible with trebuchet. Ryan has lain some ground work for that workflow. [17:00:06] (03Merged) 10jenkins-bot: Update Wikidata build [core] (wmf/1.23wmf20) - 10https://gerrit.wikimedia.org/r/124638 (owner: 10Aude) [17:01:33] (03CR) 10Manybubbles: "Thanks! I don't _think_ they need it but they might one day..../" [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/124011 (owner: 10Manybubbles) [17:01:36] (03PS3) 10Manybubbles: Cirrus now needs the Cite extension for testing [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/124011 [17:04:09] (03CR) 10Chad: "More reviewers is just fine. I welcome more input." [core] - 10https://gerrit.wikimedia.org/r/124475 (owner: 10Odder) [17:18:54] (03PS1) 10Bsitu: Add Sorting to topic list based on last updated timestamp [extensions/Flow] - 10https://gerrit.wikimedia.org/r/124644 [17:24:32] (03PS1) 10Matthias Mullie: Fix DB-to-cache pipeline [extensions/Flow] - 10https://gerrit.wikimedia.org/r/124645 [17:25:00] (03PS2) 10Matthias Mullie: Fix DB-to-cache pipeline [extensions/Flow] - 10https://gerrit.wikimedia.org/r/124645 [17:27:26] (03CR) 10Cmcmahon: [C: 032] "Let's get Flow enabled on new talk pages first." [extensions/Flow] - 10https://gerrit.wikimedia.org/r/124339 (owner: 10Cmcmahon) [17:27:29] (03CR) 10jenkins-bot: [V: 04-1] Only run this test locally [extensions/Flow] - 10https://gerrit.wikimedia.org/r/124339 (owner: 10Cmcmahon) [17:28:39] (03PS16) 10Krinkle: mediawiki.action.edit: Autosave edit textareas in localStorage [core] - 10https://gerrit.wikimedia.org/r/5130 (owner: 10Joancreus) [17:29:54] (03CR) 10Krinkle: "Agree with the debouncing. See mw.loader.store for an example. You want to do two things: Debounce (don't do a localStorage write for ever" [core] - 10https://gerrit.wikimedia.org/r/5130 (owner: 10Joancreus) [17:30:03] (03CR) 10Matthias Mullie: "https://gerrit.wikimedia.org/r/#/c/124646/ should be merged as well, to clear bad caches on production" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/124645 (owner: 10Matthias Mullie) [17:35:09] ok. we got a bug in RL CSS minifier [17:35:43] thedj: So critical we must skip BZ? [17:35:55] no. [17:36:17] I'm still interested but would like it to be in BZ :) [17:36:57] thedj: *a* bug? i'm sure we have multiple. :D [17:37:07] !bug cssmin [17:37:07] https://bugzilla.wikimedia.org/buglist.cgi?quicksearch=cssmin [17:37:44] I thought our software was perfect [17:39:00] ticket created: https://bugzilla.wikimedia.org/show_bug.cgi?id=63688 [17:39:24] thedj: dddddupe! [17:39:26] Does anyone know how to determine the effective font in Chrome? Does http://stackoverflow.com/a/19555605/47773 still work? [17:39:27] (03PS3) 10Krinkle: Extension has moved to GitHub. Make that clearer [extensions/FacebookOpenGraph] - 10https://gerrit.wikimedia.org/r/123849 (owner: 10Siebrand) [17:39:30] If so, anyone know the minimum version. [17:40:32] thedj: https://bugzilla.wikimedia.org/show_bug.cgi?id=60077 [17:46:05] Nikerabbit: do you know what the "external source" mentioned in the edit summary here is? http://dev.translatewiki.net/w/i.php?title=MediaWiki:Morenotlisted/pl&diff=0&oldid=4605293 [17:46:10] MatmaRex: thx [17:46:29] MatmaRex: the repo [17:46:40] "the"? [17:46:41] notice the dev. [17:46:50] (03PS3) 10Aaron Schulz: Compile wikiversions.json to cdb for local sync [tools/scap] - 10https://gerrit.wikimedia.org/r/124627 (owner: 10BryanDavis) [17:47:03] i see the dev, but i got that link from an e-mail TWN sent me [17:47:15] i want to know where does that translation comes from, because it's bad [17:47:20] (03PS4) 10Aaron Schulz: Compile wikiversions.json to cdb for local sync [tools/scap] - 10https://gerrit.wikimedia.org/r/124627 (owner: 10BryanDavis) [17:47:36] it comes from twn, presumably [17:47:45] ah hm, someone changed the source too [17:47:46] meh [17:47:51] sorry for the email, it's https://bugzilla.wikimedia.org/show_bug.cgi?id=63678 (now fixed by puring the watchlist table) [17:47:51] too complicated, nevermind. :P [17:48:37] that someone is me btw [17:48:58] so if you want to punch/slap someone I'm here for you :) [17:49:44] AaronSchulz: Thanks for fixing my horrible spelling. I was rushing to submit during a brief period when my network was stable this morning. [17:51:05] (03PS4) 10Phuedx: Delete the post-edit cookie using the correct domain [core] - 10https://gerrit.wikimedia.org/r/122423 [17:51:07] (03PS7) 10Phuedx: Add the mw.cookie module [core] - 10https://gerrit.wikimedia.org/r/120806 [17:51:16] (03CR) 10Yurik: [C: 032] "time to stabilize it, patches are too hard to maintain" [extensions/JsonConfig] - 10https://gerrit.wikimedia.org/r/98767 (owner: 10Yurik) [17:53:04] (03Merged) 10jenkins-bot: Initial implementation of the JSON configuration store. [extensions/JsonConfig] - 10https://gerrit.wikimedia.org/r/98767 (owner: 10Yurik) [17:53:06] (03PS1) 10Matthias Mullie: Make FeatureIndex::getOffsetFromKey slightly more robust [extensions/Flow] - 10https://gerrit.wikimedia.org/r/124651 [17:56:08] (03CR) 10Phuedx: Add the mw.cookie module (0314 comments) [core] - 10https://gerrit.wikimedia.org/r/120806 (owner: 10Phuedx) [17:56:49] (03CR) 10Aaron Schulz: [C: 032] Compile wikiversions.json to cdb for local sync [tools/scap] - 10https://gerrit.wikimedia.org/r/124627 (owner: 10BryanDavis) [17:57:02] (03Merged) 10jenkins-bot: Compile wikiversions.json to cdb for local sync [tools/scap] - 10https://gerrit.wikimedia.org/r/124627 (owner: 10BryanDavis) [17:57:10] bd808|deploy: heh, I wasn't noticing the little unlink there before, I guess that makes sense [17:58:05] It's hacky :/ [17:58:29] But better than the prior bug of needing to scap twice :) [17:59:07] (03CR) 10jenkins-bot: [V: 04-1] Delete the post-edit cookie using the correct domain [core] - 10https://gerrit.wikimedia.org/r/122423 (owner: 10Phuedx) [17:59:09] (03CR) 10jenkins-bot: [V: 04-1] Add the mw.cookie module [core] - 10https://gerrit.wikimedia.org/r/120806 (owner: 10Phuedx) [17:59:25] (03PS9) 10Krinkle: Support directionality for reference [extensions/Cite] - 10https://gerrit.wikimedia.org/r/7738 (owner: 10Eranroz) [17:59:28] (03CR) 10jenkins-bot: [V: 04-1] Support directionality for reference [extensions/Cite] - 10https://gerrit.wikimedia.org/r/7738 (owner: 10Eranroz) [17:59:30] (03CR) 10EBernhardson: Fix DB-to-cache pipeline (031 comment) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/124645 (owner: 10Matthias Mullie) [18:00:29] (03PS3) 10Krinkle: Implement global user pages [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/7300 (owner: 10Szymon Świerkosz) [18:00:33] (03CR) 10jenkins-bot: [V: 04-1] Implement global user pages [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/7300 (owner: 10Szymon Świerkosz) [18:00:56] (03CR) 10Krinkle: "Status?" [extensions/SignupAPI] - 10https://gerrit.wikimedia.org/r/8002 (owner: 10Kaldari) [18:01:57] (03PS10) 10Krinkle: Filter Special:Newpages by page size [core] - 10https://gerrit.wikimedia.org/r/8036 (owner: 10Chughakshay16) [18:02:19] MatmaRex: whatever is in git [18:02:19] (03CR) 10Krinkle: "(moved from commit message as it doesn't belong there)" [core] - 10https://gerrit.wikimedia.org/r/8036 (owner: 10Chughakshay16) [18:02:47] (03PS1) 10Stefan.petrea: Changing PHPUnit to version 3.7.2 [core] - 10https://gerrit.wikimedia.org/r/124653 [18:03:07] (03CR) 10jenkins-bot: [V: 04-1] Filter Special:Newpages by page size [core] - 10https://gerrit.wikimedia.org/r/8036 (owner: 10Chughakshay16) [18:04:32] (03CR) 10Umherirrender: "Looks like jenkins does not love this change." [core] - 10https://gerrit.wikimedia.org/r/124366 (owner: 10Umherirrender) [18:04:44] (03PS14) 10Krinkle: Ajaxify watch links on SpecialUnwatchedpages [core] - 10https://gerrit.wikimedia.org/r/6143 (owner: 10Eranroz) [18:04:52] (03CR) 10EBernhardson: [C: 032] Make FeatureIndex::getOffsetFromKey slightly more robust [extensions/Flow] - 10https://gerrit.wikimedia.org/r/124651 (owner: 10Matthias Mullie) [18:05:52] (03PS1) 10Matthias Mullie: backingStoreFindMulti's shouldn't worry about writing to cache [extensions/Flow] - 10https://gerrit.wikimedia.org/r/124654 [18:06:13] (03CR) 10Krinkle: "Rebased to resolve conflicts with structure changes in the repository since." [core] - 10https://gerrit.wikimedia.org/r/6143 (owner: 10Eranroz) [18:06:56] (03CR) 10jenkins-bot: [V: 04-1] Ajaxify watch links on SpecialUnwatchedpages [core] - 10https://gerrit.wikimedia.org/r/6143 (owner: 10Eranroz) [18:06:58] (03PS15) 10Krinkle: Ajaxify watch links on SpecialUnwatchedpages [core] - 10https://gerrit.wikimedia.org/r/6143 (owner: 10Eranroz) [18:07:00] (03Merged) 10jenkins-bot: Make FeatureIndex::getOffsetFromKey slightly more robust [extensions/Flow] - 10https://gerrit.wikimedia.org/r/124651 (owner: 10Matthias Mullie) [18:07:14] (03CR) 10Krinkle: "move code to resources/src/" [core] - 10https://gerrit.wikimedia.org/r/6143 (owner: 10Eranroz) [18:08:35] (03CR) 10Bartosz Dziewoński: "(Responding since I've been added as a reviewer) Personally I have no strong feelings about this change, but I can abandon or merge it per" [core] - 10https://gerrit.wikimedia.org/r/124475 (owner: 10Odder) [18:08:50] (03CR) 10jenkins-bot: [V: 04-1] Ajaxify watch links on SpecialUnwatchedpages [core] - 10https://gerrit.wikimedia.org/r/6143 (owner: 10Eranroz) [18:11:04] (03CR) 10Thiemo Mättig (WMDE): Replace in_array( array_keys( ... ) ) with array_key_exists( ... ) (031 comment) [core] - 10https://gerrit.wikimedia.org/r/123106 (owner: 10Thiemo Mättig (WMDE)) [18:11:29] (03PS16) 10Krinkle: Ajaxify watch links on SpecialUnwatchedpages [core] - 10https://gerrit.wikimedia.org/r/6143 (owner: 10Eranroz) [18:11:31] (03PS3) 10Matthias Mullie: Fix DB-to-cache pipeline [extensions/Flow] - 10https://gerrit.wikimedia.org/r/124645 [18:12:19] (03CR) 10PleaseStand: "This is almost exactly the same change as I77be235a, which pins PHPUnit to version 3.7.30. Any reason an even older version of PHPUnit wou" [core] - 10https://gerrit.wikimedia.org/r/124653 (owner: 10Stefan.petrea) [18:13:05] (03CR) 10jenkins-bot: [V: 04-1] Ajaxify watch links on SpecialUnwatchedpages [core] - 10https://gerrit.wikimedia.org/r/6143 (owner: 10Eranroz) [18:13:07] (03CR) 10Krinkle: "Applied naming convention (special.unwatchedpages -> special.unwatchedPages). Added missing new line at EOF." [core] - 10https://gerrit.wikimedia.org/r/6143 (owner: 10Eranroz) [18:15:38] (03PS1) 10Matthias Mullie: Use UUID's built-in method to check if 2 UUIDs are the same [extensions/Flow] - 10https://gerrit.wikimedia.org/r/124656 [18:16:56] (03CR) 10Krinkle: Ajaxify watch links on SpecialUnwatchedpages (031 comment) [core] - 10https://gerrit.wikimedia.org/r/6143 (owner: 10Eranroz) [18:17:57] (03PS1) 10BryanDavis: Revert "Compile wikiversions.json to cdb for local sync" [tools/scap] - 10https://gerrit.wikimedia.org/r/124658 [18:18:04] (03CR) 10BryanDavis: [C: 032] Revert "Compile wikiversions.json to cdb for local sync" [tools/scap] - 10https://gerrit.wikimedia.org/r/124658 (owner: 10BryanDavis) [18:18:21] (03Merged) 10jenkins-bot: Revert "Compile wikiversions.json to cdb for local sync" [tools/scap] - 10https://gerrit.wikimedia.org/r/124658 (owner: 10BryanDavis) [18:19:40] (03CR) 10Bsitu: Fix DB-to-cache pipeline (031 comment) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/124645 (owner: 10Matthias Mullie) [18:20:48] (03PS1) 10Umherirrender: Avoid using raw sql in SpecialUndelete.php [core] - 10https://gerrit.wikimedia.org/r/124659 [18:20:59] (03CR) 10Matthias Mullie: Fix DB-to-cache pipeline (031 comment) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/124645 (owner: 10Matthias Mullie) [18:21:18] (03CR) 10Ori.livneh: "Looks good. Minor quibble inline." (031 comment) [tools/scap] - 10https://gerrit.wikimedia.org/r/124627 (owner: 10BryanDavis) [18:21:44] (03CR) 10Bartosz Dziewoński: [C: 032] Split part of EnhancedChangesList::recentChangesLine into new method [core] - 10https://gerrit.wikimedia.org/r/124527 (owner: 10Aude) [18:25:14] (03CR) 10jenkins-bot: [V: 04-1] Split part of EnhancedChangesList::recentChangesLine into new method [core] - 10https://gerrit.wikimedia.org/r/124527 (owner: 10Aude) [18:25:19] (03PS17) 10Eranroz: Ajaxify watch links on SpecialUnwatchedpages [core] - 10https://gerrit.wikimedia.org/r/6143 [18:27:10] (03CR) 10jenkins-bot: [V: 04-1] Ajaxify watch links on SpecialUnwatchedpages [core] - 10https://gerrit.wikimedia.org/r/6143 (owner: 10Eranroz) [18:27:42] (03CR) 10Bartosz Dziewoński: [V: 032] "Stupid bot" [core] - 10https://gerrit.wikimedia.org/r/124527 (owner: 10Aude) [18:28:08] (03CR) 10Ori.livneh: "..or not" [tools/scap] - 10https://gerrit.wikimedia.org/r/124627 (owner: 10BryanDavis) [18:30:03] (03CR) 10Bartosz Dziewoński: [C: 032] Update the firstedit tour's copy [extensions/GuidedTour] - 10https://gerrit.wikimedia.org/r/119261 (owner: 10Phuedx) [18:30:57] (03CR) 10jenkins-bot: [V: 04-1] Update the firstedit tour's copy [extensions/GuidedTour] - 10https://gerrit.wikimedia.org/r/119261 (owner: 10Phuedx) [18:32:30] (03CR) 10Bartosz Dziewoński: [V: 032] "Jenkins QUnit issue is bug 63579." [extensions/GuidedTour] - 10https://gerrit.wikimedia.org/r/119261 (owner: 10Phuedx) [18:33:50] (03PS1) 10Matthias Mullie: Fallback data should not just be added to cache, but CAS'ed [extensions/Flow] - 10https://gerrit.wikimedia.org/r/124660 [18:34:17] mwalker: ping re https://gerrit.wikimedia.org/r/#/c/118693 [18:36:33] (03CR) 10Jorm: "Hey guys!" [core] - 10https://gerrit.wikimedia.org/r/124475 (owner: 10Odder) [18:38:48] (03CR) 10Umherirrender: "For selectAndOther the message for the 'other' is missing, instead a empty item is there, for example the reason field on Special:Block." (031 comment) [core] - 10https://gerrit.wikimedia.org/r/114066 (owner: 10Anomie) [18:39:30] (03CR) 10Raimond Spekking: [C: 032] Add some settings and quoted test in code tags [core] - 10https://gerrit.wikimedia.org/r/124626 (owner: 10Siebrand) [18:40:55] (03CR) 10EBernhardson: [C: 032] Fallback data should not just be added to cache, but CAS'ed [extensions/Flow] - 10https://gerrit.wikimedia.org/r/124660 (owner: 10Matthias Mullie) [18:41:43] (03CR) 10EBernhardson: [C: 032] Use UUID's built-in method to check if 2 UUIDs are the same [extensions/Flow] - 10https://gerrit.wikimedia.org/r/124656 (owner: 10Matthias Mullie) [18:41:58] (03Merged) 10jenkins-bot: Use UUID's built-in method to check if 2 UUIDs are the same [extensions/Flow] - 10https://gerrit.wikimedia.org/r/124656 (owner: 10Matthias Mullie) [18:42:43] (03Merged) 10jenkins-bot: Add some settings and quoted test in code tags [core] - 10https://gerrit.wikimedia.org/r/124626 (owner: 10Siebrand) [18:45:03] (03PS16) 10UltrasonicNXT: Rewrite [extensions/WikiForum] - 10https://gerrit.wikimedia.org/r/116258 [18:45:25] (03PS18) 10Krinkle: Ajaxify watch links on SpecialUnwatchedpages [core] - 10https://gerrit.wikimedia.org/r/6143 (owner: 10Eranroz) [18:58:22] (03PS19) 10Krinkle: Ajaxify watch links on SpecialUnwatchedpages [core] - 10https://gerrit.wikimedia.org/r/6143 (owner: 10Eranroz) [18:59:36] (03PS20) 10Krinkle: SpecialUnwatchedpages: Ajaxify watch links [core] - 10https://gerrit.wikimedia.org/r/6143 (owner: 10Eranroz) [18:59:57] (03CR) 10Krinkle: "Added error handling (to simulate, add sleep(2); die; atop api.php)" [core] - 10https://gerrit.wikimedia.org/r/6143 (owner: 10Eranroz) [18:59:59] (03CR) 10Umherirrender: "The position of the 'other' also changed from the first to the last item. But that is not a problem, because the selectOrOther type also h" [core] - 10https://gerrit.wikimedia.org/r/114066 (owner: 10Anomie) [19:00:08] (03CR) 10Krinkle: SpecialUnwatchedpages: Ajaxify watch links (031 comment) [core] - 10https://gerrit.wikimedia.org/r/6143 (owner: 10Eranroz) [19:00:14] (03CR) 10Krinkle: SpecialUnwatchedpages: Ajaxify watch links (032 comments) [core] - 10https://gerrit.wikimedia.org/r/6143 (owner: 10Eranroz) [19:01:31] (03PS21) 10Krinkle: SpecialUnwatchedpages: Ajaxify watch links [core] - 10https://gerrit.wikimedia.org/r/6143 (owner: 10Eranroz) [19:02:11] (03PS2) 10Martineznovo: Added $wgRunJobsAsync to allow running jobs the old way [core] - 10https://gerrit.wikimedia.org/r/124470 [19:02:44] (03PS22) 10Krinkle: SpecialUnwatchedpages: Ajaxify watch links [core] - 10https://gerrit.wikimedia.org/r/6143 (owner: 10Eranroz) [19:03:36] (03CR) 10Martineznovo: Added $wgRunJobsAsync to allow running jobs the old way (031 comment) [core] - 10https://gerrit.wikimedia.org/r/124470 (owner: 10Martineznovo) [19:03:39] (03CR) 10jenkins-bot: [V: 04-1] Added $wgRunJobsAsync to allow running jobs the old way [core] - 10https://gerrit.wikimedia.org/r/124470 (owner: 10Martineznovo) [19:04:37] (03PS2) 10Matthias Mullie: Fallback data should not just be added to cache, but CAS'ed [extensions/Flow] - 10https://gerrit.wikimedia.org/r/124660 [19:05:00] (03PS6) 10MaxSem: Generic data store [core] - 10https://gerrit.wikimedia.org/r/79029 [19:08:12] (03PS23) 10Krinkle: SpecialUnwatchedpages: Ajaxify watch links [core] - 10https://gerrit.wikimedia.org/r/6143 (owner: 10Eranroz) [19:08:48] (03CR) 10Krinkle: [C: 031] "Finished rebasing, and adding of error handling and progress indicator. Would prefer a +1 from the author or another reviewer before I mer" [core] - 10https://gerrit.wikimedia.org/r/6143 (owner: 10Eranroz) [19:10:56] (03PS1) 10Umherirrender: Avoid using raw sql in LinksUpdate.php [core] - 10https://gerrit.wikimedia.org/r/124661 [19:17:21] (03CR) 10Siebrand: [C: 04-1] "This patch set should be updated for JSON based i18n." [core] - 10https://gerrit.wikimedia.org/r/43166 (owner: 10VitaliyFilippov) [19:19:40] (03PS17) 10UltrasonicNXT: Rewrite [extensions/WikiForum] - 10https://gerrit.wikimedia.org/r/116258 [19:19:44] (03PS3) 10Martineznovo: Added $wgRunJobsAsync to allow running jobs the old way [core] - 10https://gerrit.wikimedia.org/r/124470 [19:20:04] (03CR) 10Siebrand: [C: 032 V: 032] "Per https://bugzilla.wikimedia.org/show_bug.cgi?id=63374#c2" [extensions/FacebookOpenGraph] - 10https://gerrit.wikimedia.org/r/123849 (owner: 10Siebrand) [19:20:23] (03CR) 10Raimond Spekking: [C: 032 V: 032] Migrate to JSON i18n [extensions/SocialProfile] - 10https://gerrit.wikimedia.org/r/123850 (owner: 10Siebrand) [19:22:54] (03CR) 10Martineznovo: [C: 04-1] "Seriously, WHO CHANGED DEFAULTSETTINGS.PHP IN LESS THAN 24h?" [core] - 10https://gerrit.wikimedia.org/r/124470 (owner: 10Martineznovo) [19:25:02] (03CR) 10Siebrand: [C: 04-1] "L10n reviewed." (037 comments) [extensions/TimelineTable] - 10https://gerrit.wikimedia.org/r/38485 (owner: 10thibaultmarin) [19:26:45] (03CR) 10Siebrand: [C: 04-1] "This patch set should be updated to use JSON based i18n." [core] - 10https://gerrit.wikimedia.org/r/40096 (owner: 10Alex Monk) [19:30:48] (03CR) 10Siebrand: Generic data store (031 comment) [core] - 10https://gerrit.wikimedia.org/r/79029 (owner: 10MaxSem) [19:32:29] (03CR) 10TheDJ: "OK, with navigation popups, the title is blanked, and I get: The page "" was added to your watch list." [core] - 10https://gerrit.wikimedia.org/r/6143 (owner: 10Eranroz) [19:33:11] (03CR) 10MaxSem: Generic data store (031 comment) [core] - 10https://gerrit.wikimedia.org/r/79029 (owner: 10MaxSem) [19:43:20] (03CR) 10Siebrand: "Few nitpicks." (033 comments) [core] - 10https://gerrit.wikimedia.org/r/124580 (owner: 10Thiemo Mättig (WMDE)) [19:43:49] (03PS11) 10Alex Monk: Special:ListGroupRights: Add per-namespace restrictions and rights [core] - 10https://gerrit.wikimedia.org/r/40096 [19:52:22] (03CR) 10Siebrand: [C: 04-1] "I'd like to see some predictability to the ordering of the table rows. I tested the patch set on sandbox.translatewiki.net (still installe" [core] - 10https://gerrit.wikimedia.org/r/40096 (owner: 10Alex Monk) [19:52:37] (03CR) 10Siebrand: "Oh, URL: https://sandbox.translatewiki.net/wiki/Special:ListGroupRights" [core] - 10https://gerrit.wikimedia.org/r/40096 (owner: 10Alex Monk) [19:55:00] (03CR) 10Thiemo Mättig (WMDE): "Currently 297 PHP classes (on my development machine, which includes some extensions) start with a blank line. That's what the team told m" [core] - 10https://gerrit.wikimedia.org/r/124580 (owner: 10Thiemo Mättig (WMDE)) [19:57:08] (03CR) 10Jdlrobson: [C: 031] "For the record, I'm happy to +2 this if necessary but I still feel this is a short term crappy solution that doesn't truly promote unfree " (031 comment) [core] - 10https://gerrit.wikimedia.org/r/124475 (owner: 10Odder) [19:57:35] (03CR) 10Siebrand: [C: 031] "i18n/L10n reviewed." [core] - 10https://gerrit.wikimedia.org/r/5130 (owner: 10Joancreus) [19:58:52] (03CR) 10Siebrand: [C: 032] "When I see them, I remove them. I've removed a fair bunch of them from core. I'll keep removing them when I come across them. Not going to" [core] - 10https://gerrit.wikimedia.org/r/124580 (owner: 10Thiemo Mättig (WMDE)) [20:01:30] (03CR) 10Foxtrott: [C: 04-1] "I never liked those monstrous config arrays, wgResourceModules (as an example) is a nightmare." (034 comments) [skins/chameleon] - 10https://gerrit.wikimedia.org/r/124596 (owner: 10Mwjames) [20:01:43] (03PS4) 10EBernhardson: Warn when __toString is needed on UUID [extensions/Flow] - 10https://gerrit.wikimedia.org/r/123692 (owner: 10Matthias Mullie) [20:02:18] (03Merged) 10jenkins-bot: WebInstaller inline documentation cleanup [core] - 10https://gerrit.wikimedia.org/r/124580 (owner: 10Thiemo Mättig (WMDE)) [20:05:58] (03CR) 10EBernhardson: [C: 031] Tweaks to FeatureIndex::findMulti (032 comments) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/124602 (owner: 10Matthias Mullie) [20:06:12] (03CR) 10EBernhardson: [C: 031] backingStoreFindMulti's shouldn't worry about writing to cache [extensions/Flow] - 10https://gerrit.wikimedia.org/r/124654 (owner: 10Matthias Mullie) [20:06:30] (03CR) 10EBernhardson: [C: 031] Fallback data should not just be added to cache, but CAS'ed [extensions/Flow] - 10https://gerrit.wikimedia.org/r/124660 (owner: 10Matthias Mullie) [20:06:50] (03CR) 10EBernhardson: [C: 032] Warn when __toString is needed on UUID [extensions/Flow] - 10https://gerrit.wikimedia.org/r/123692 (owner: 10Matthias Mullie) [20:07:07] (03Merged) 10jenkins-bot: Warn when __toString is needed on UUID [extensions/Flow] - 10https://gerrit.wikimedia.org/r/123692 (owner: 10Matthias Mullie) [20:07:31] (03CR) 10EBernhardson: [C: 032] Fix DB-to-cache pipeline [extensions/Flow] - 10https://gerrit.wikimedia.org/r/124645 (owner: 10Matthias Mullie) [20:07:34] (03PS3) 10Aaron Schulz: Fallback data should not just be added to cache, but CAS'ed [extensions/Flow] - 10https://gerrit.wikimedia.org/r/124660 (owner: 10Matthias Mullie) [20:08:55] (03CR) 10EBernhardson: [C: 032] Use correct limits [extensions/Flow] - 10https://gerrit.wikimedia.org/r/124322 (owner: 10Matthias Mullie) [20:09:49] (03Merged) 10jenkins-bot: Fix DB-to-cache pipeline [extensions/Flow] - 10https://gerrit.wikimedia.org/r/124645 (owner: 10Matthias Mullie) [20:13:50] (03Merged) 10jenkins-bot: Use correct limits [extensions/Flow] - 10https://gerrit.wikimedia.org/r/124322 (owner: 10Matthias Mullie) [20:18:43] (03CR) 10Mwjames: Adds a $egChameleonExternalStyleModules (034 comments) [skins/chameleon] - 10https://gerrit.wikimedia.org/r/124596 (owner: 10Mwjames) [20:19:22] (03PS12) 10Alex Monk: Special:ListGroupRights: Add per-namespace restrictions and rights [core] - 10https://gerrit.wikimedia.org/r/40096 [20:19:44] (03CR) 10Alex Monk: "Sorted by namespace ID number" [core] - 10https://gerrit.wikimedia.org/r/40096 (owner: 10Alex Monk) [20:22:21] prtksxna, https://gerrit.wikimedia.org/r/#/c/123790/ works for me, are you sure it's not a browser cache issue? [20:26:13] (03CR) 10Stefan.petrea: "Sorry, wasn't aware of https://gerrit.wikimedia.org/r/#q,I77be235a,n,z ." [core] - 10https://gerrit.wikimedia.org/r/124653 (owner: 10Stefan.petrea) [20:28:22] (03Abandoned) 10Stefan.petrea: Changing PHPUnit to version 3.7.2 [core] - 10https://gerrit.wikimedia.org/r/124653 (owner: 10Stefan.petrea) [20:32:24] (03CR) 10Matthias Mullie: Tweaks to FeatureIndex::findMulti (032 comments) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/124602 (owner: 10Matthias Mullie) [20:32:28] (03PS3) 10Matthias Mullie: Tweaks to FeatureIndex::findMulti [extensions/Flow] - 10https://gerrit.wikimedia.org/r/124602 [20:33:05] (03PS1) 10Addshore: Add checks for WikiForum extension [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/124731 [20:34:13] (03PS1) 10Addshore: Add trigger for WikiForum checks [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/124732 [20:34:20] (03PS2) 10Addshore: Add trigger for WikiForum checks [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/124732 [20:36:40] (03CR) 10EBernhardson: [C: 032] Tweaks to FeatureIndex::findMulti [extensions/Flow] - 10https://gerrit.wikimedia.org/r/124602 (owner: 10Matthias Mullie) [20:36:47] (03PS2) 10EBernhardson: backingStoreFindMulti's shouldn't worry about writing to cache [extensions/Flow] - 10https://gerrit.wikimedia.org/r/124654 (owner: 10Matthias Mullie) [20:36:51] (03CR) 10EBernhardson: [C: 032] backingStoreFindMulti's shouldn't worry about writing to cache [extensions/Flow] - 10https://gerrit.wikimedia.org/r/124654 (owner: 10Matthias Mullie) [20:36:56] (03Merged) 10jenkins-bot: Tweaks to FeatureIndex::findMulti [extensions/Flow] - 10https://gerrit.wikimedia.org/r/124602 (owner: 10Matthias Mullie) [20:37:00] (03PS4) 10EBernhardson: Fallback data should not just be added to cache, but CAS'ed [extensions/Flow] - 10https://gerrit.wikimedia.org/r/124660 (owner: 10Matthias Mullie) [20:37:04] (03CR) 10EBernhardson: [C: 032] Fallback data should not just be added to cache, but CAS'ed [extensions/Flow] - 10https://gerrit.wikimedia.org/r/124660 (owner: 10Matthias Mullie) [20:37:12] (03PS5) 10JGonera: Make .mw-ui-button height the same for all buttons [core] - 10https://gerrit.wikimedia.org/r/117107 [20:37:41] superm401, rebased ^ [20:37:52] jgonera, thank you. [20:38:16] (03Merged) 10jenkins-bot: backingStoreFindMulti's shouldn't worry about writing to cache [extensions/Flow] - 10https://gerrit.wikimedia.org/r/124654 (owner: 10Matthias Mullie) [20:38:19] (03Merged) 10jenkins-bot: Fallback data should not just be added to cache, but CAS'ed [extensions/Flow] - 10https://gerrit.wikimedia.org/r/124660 (owner: 10Matthias Mullie) [20:43:17] (03PS3) 10Addshore: General fixes and cleanup [qrpedia] - 10https://gerrit.wikimedia.org/r/121661 [20:44:05] (03PS1) 10TheDJ: Prevent style jumping in WikiEditor [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/124734 [20:49:25] (03CR) 10Kipcool: "Man you're fast :)" [extensions/WikiLexicalData] - 10https://gerrit.wikimedia.org/r/124585 (owner: 10Hiong3-eng5) [20:49:33] WikiEditor spree :) [20:50:45] (03PS1) 10Jforrester: Update OOjs UI to v0.1.0-pre (70932872ba) [core] - 10https://gerrit.wikimedia.org/r/124735 [20:51:09] (03PS1) 10Foxtrott: bugfix (content text displayed above fixed head) [skins/chameleon] - 10https://gerrit.wikimedia.org/r/124736 [20:51:53] (03PS1) 10Addshore: Format PHP code per MW conventions [qrpedia] - 10https://gerrit.wikimedia.org/r/124737 [20:53:03] (03CR) 10Foxtrott: [C: 032 V: 032] bugfix (content text displayed above fixed head) [skins/chameleon] - 10https://gerrit.wikimedia.org/r/124736 (owner: 10Foxtrott) [21:02:29] (03Draft1) 10Addshore: Use single quotes where possible [qrpedia] - 10https://gerrit.wikimedia.org/r/124741 [21:02:58] (03PS4) 10Aaron Schulz: Added $wgRunJobsAsync to allow running jobs the old way [core] - 10https://gerrit.wikimedia.org/r/124470 (owner: 10Martineznovo) [21:04:00] (03CR) 10Aaron Schulz: "Removed unrelated changes" [core] - 10https://gerrit.wikimedia.org/r/124470 (owner: 10Martineznovo) [21:04:07] (03PS9) 10Krinkle: Use FormData in mw.Api when supported [core] - 10https://gerrit.wikimedia.org/r/116037 (owner: 10JGonera) [21:04:26] (03CR) 10Krinkle: "Rebased to account for directory structure change." [core] - 10https://gerrit.wikimedia.org/r/116037 (owner: 10JGonera) [21:04:31] (03CR) 10Aaron Schulz: Added $wgRunJobsAsync to allow running jobs the old way (031 comment) [core] - 10https://gerrit.wikimedia.org/r/124470 (owner: 10Martineznovo) [21:09:54] greg-g: So with this heartbleed thing, its only encryption keys that could be potentially compromised - so an attacker could remove the https encryption, and man-in-the-middle you like with normal http? It wouldn't allow someone to compromise somebody else's session unless they were listening in on the connection between other person and wmf servers? [21:09:56] (03CR) 10jenkins-bot: [V: 04-1] Added $wgRunJobsAsync to allow running jobs the old way [core] - 10https://gerrit.wikimedia.org/r/124470 (owner: 10Martineznovo) [21:10:51] (03CR) 10Aaron Schulz: "qunit failure here is just random" [core] - 10https://gerrit.wikimedia.org/r/124470 (owner: 10Martineznovo) [21:11:07] (03CR) 10Ori.livneh: "Krinkle's changes look good, but I want to amend once more and make the RegExp for the new format come first as a tiny optimization." [extensions/ApiSandbox] - 10https://gerrit.wikimedia.org/r/124392 (owner: 10Ori.livneh) [21:11:08] bawolff: IF they got our private cert they could impersonate us and get any person's username/password. In addition, they could get some other arbitrary datat that is in memory on the ssl terminators (other session tokens etc) [21:11:34] (03PS1) 10Addshore: Fix spelling errors in comments [qrpedia] - 10https://gerrit.wikimedia.org/r/124745 [21:11:36] That's some scary stuff right there [21:11:38] bawolff: and yeah, I believe that last part you said is right. It hink. [21:11:48] ish [21:12:11] minus my last sentence, that is :) [21:13:11] So assuming nobody set up a fake wmf server, this is basically equivalent of us saying we're doing https, when really we're doing http (from an attackers prespective) [21:17:56] MatmaRex: Hey, have you been using the new media viewer in Opera? We're wondering offhand whether it's working. [21:18:37] I can't think of any reason it wouldn't. [21:20:25] marktraceur: something shows up when i click it, but i'm not sure if it's supposed to look like what i see [21:20:29] also, how new is 'new'? [21:20:56] MatmaRex: "new" is relative, I suppose - the current incarnation of the design is about 5 months old but it's been in beta [21:20:56] ("when i click it" – "it" is any image of course) [21:21:16] It will be "new"ly default on Thursday (barring disaster (knock on wood)) for 0 days [21:21:26] Right [21:21:45] marktraceur: all i see is a zoomed out image on black background, with buttons to close and switch to fullscreen [21:21:50] MatmaRex: A black background, then later an image and a white bar at the bottom with some metadata? [21:21:52] nothing happens when i try scrolling down [21:21:53] Oh, hm. [21:21:57] Zoomed out meaning blurry? [21:22:04] zoomed in* D: [21:22:08] Same question [21:22:18] enlarged* [21:22:21] But not blurry. [21:22:38] lemme compare [21:23:13] I think you would know if it were blurry [21:23:18] So I'm going to go with no [21:24:33] (03CR) 10Kipcool: "@Hiong: According to the old scripts https://github.com/svn2github/wikia/blob/master/extensions/Wikidata/Database%20scripts/Incremental/27" [extensions/WikiLexicalData] - 10https://gerrit.wikimedia.org/r/119446 (owner: 10Hiong3-eng5) [21:24:45] yeah probably [21:24:54] oh hmm, the white information bar randomly loaded this time. [21:24:57] Hah [21:25:00] Encouraging [21:25:20] (03PS5) 10Nemo bis: Added $wgRunJobsAsync to allow running jobs the old way [core] - 10https://gerrit.wikimedia.org/r/124470 (owner: 10Martineznovo) [21:25:30] marktraceur: it apparently just takes an incredibly long time to load [21:25:43] MatmaRex: What's your connection like? [21:25:45] marktraceur: long enough for me not to be patient enough to see it happen [21:25:52] up to 1 mbps [21:25:59] Hm, that's not it then. [21:26:14] also, the image is, in fact, still blurred [21:26:19] screenshots time. [21:26:41] Hm. [21:27:31] oh wow, nevermind [21:27:33] it loaded D: [21:27:47] I guess it's just really slow [21:27:53] i was testing the infobox image at https://pl.wikipedia.org/wiki/Paweł_IV_(papież) [21:27:55] Maybe Opera doesn't like the multiple requests at once [21:28:21] it ws moslty the same on Opera 20 (so basically Chrome) [21:28:48] my connection is definitely slow, but this is weird [21:29:12] Opera 20 "basically Chrome", say Opera developers. [21:29:12] i'm not sure why the metadata took so long to load, though [21:29:18] * marktraceur writes this article [21:29:30] (03PS10) 10Krinkle: mediawiki.api: Use FormData for POST requests when supported [core] - 10https://gerrit.wikimedia.org/r/116037 (owner: 10JGonera) [21:30:06] i'd reall love to have time to properly investigate this… [21:30:43] (03PS1) 10Yuvipanda: Add triggers for flake8 jobs for python scripts in wikipedia app [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/124748 [21:30:46] (03PS1) 10Yuvipanda: Add flake8 job for python scripts in Android app [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/124749 [21:30:51] (03CR) 10jenkins-bot: [V: 04-1] Add triggers for flake8 jobs for python scripts in wikipedia app [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/124748 (owner: 10Yuvipanda) [21:31:17] (03PS2) 10Yuvipanda: Add triggers for flake8 jobs for python scripts in wikipedia app [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/124748 [21:31:25] (03CR) 10jenkins-bot: [V: 04-1] Added $wgRunJobsAsync to allow running jobs the old way [core] - 10https://gerrit.wikimedia.org/r/124470 (owner: 10Martineznovo) [21:31:42] marktraceur: the image takes absurdly long to switch to the higher resolution version, even after it's been cached [21:32:05] Huh. [21:32:22] We haven't had that issue here... [21:33:02] (03CR) 10Yuvipanda: "I have deployed the associated jenkins job https://gerrit.wikimedia.org/r/124749 but zuul needs to be merged + deployed and so does that o" [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/124748 (owner: 10Yuvipanda) [21:33:11] In fact I can load the image pretty fast on that page [21:35:07] Paweł IV .org/wiki/Paweł_IV_(papież)#gaussian-blur");" class="blurred"/> [21:35:13] wtf is class=blurred? [21:35:35] and, why is it still a 240px thumb… [21:35:41] (03CR) 10jenkins-bot: [V: 04-1] mediawiki.api: Use FormData for POST requests when supported [core] - 10https://gerrit.wikimedia.org/r/116037 (owner: 10JGonera) [21:36:24] MatmaRex: class="blurred" and the thumbnail are expected [21:36:39] We put a blurry image in first to give you some indication of what you're going to see [21:36:44] And to indicate loading progress [21:37:17] yeah, but it stays that way for me. :/ [21:38:10] marktraceur: http://i.imgur.com/uNF2jQw.jpg [21:38:12] (03PS4) 10Ori.livneh: Update request time scraping for compatibility with I895cd03f0 [extensions/ApiSandbox] - 10https://gerrit.wikimedia.org/r/124392 [21:38:59] (03PS5) 10Ori.livneh: Update request time scraping for compatibility with I895cd03f0 [extensions/ApiSandbox] - 10https://gerrit.wikimedia.org/r/124392 [21:39:10] (03PS6) 10Ori.livneh: Update request time scraping for compatibility with I895cd03f0 [extensions/ApiSandbox] - 10https://gerrit.wikimedia.org/r/124392 [21:39:16] marktraceur: where in the code is the src updated? i can't find it looking for 'src'… [21:39:38] (03CR) 10Mattflaschen: [C: 032] "Looks good. Tested in Iceweasel 24.4.0, Chromium 33.0.1750.152, IE 7, and IE 8." [extensions/GettingStarted] - 10https://gerrit.wikimedia.org/r/119972 (owner: 10Phuedx) [21:39:43] (03Merged) 10jenkins-bot: Update copy [extensions/GettingStarted] - 10https://gerrit.wikimedia.org/r/119972 (owner: 10Phuedx) [21:40:18] MatmaRex: We may totally replace the image attribute, not sure [21:40:31] But that doesn't look blurry to me [21:41:14] (03PS3) 10Mwjames: Adds a $egChameleonExternalStyleModules [skins/chameleon] - 10https://gerrit.wikimedia.org/r/124596 [21:41:47] marktraceur: compare to https://upload.wikimedia.org/wikipedia/commons/e/ec/Paul_IV_cropped.png [21:42:03] that's an upscaled 240px thumbnail [21:42:21] and i can't even find where you're building it. either i'm retarded or this code is [21:42:24] Gotcha [21:42:34] MatmaRex: Well, or both [21:42:35] marktraceur: ori: Do one or both of you have time for a quick brainstorm session ASAP to help me figure out what is up with phantomjs-qunit? As of yesterday, it is failing 50% of the time for all patches. Some kind of race condition in how we use sinon fakeclock in jquery.makeCollapse tests is causing the heartbeat poller to die and thus never callback and then it times out eventually [21:43:00] Krinkle: sure, should I come over? [21:43:04] Krinkle: Not really now [21:43:05] Been banging my head against it on and off yesterday, no progress so far. [21:43:18] OK [21:43:31] ori: I'll go there, in the hammock area [21:44:19] * marktraceur having issues now...apparently OutputPage#getWikiPage crashes magnificently when used on a SpecialPage [21:44:36] Original exception: [e1205c41] /wiki/index.php/Special:JavaScriptTest/qunit?debug=true Exception from line 118 of /home/marktraceur/projects/wikimedia/mediawiki/core/includes/WikiPage.php: Invalid or virtual namespace -1 given. [21:45:12] (03PS4) 10Mwjames: Adds a $egChameleonExternalStyleModules [skins/chameleon] - 10https://gerrit.wikimedia.org/r/124596 [21:45:13] I guess I'll try...catch but I hate that solution [21:48:33] (03PS1) 10CSteipp: Maintenance script for token resets [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/124752 [21:49:36] (03CR) 10Hiong3-eng5: "The error handling of the view function is amazing. Yes it redirected!" [extensions/WikiLexicalData] - 10https://gerrit.wikimedia.org/r/124585 (owner: 10Hiong3-eng5) [21:54:30] marktraceur: In theory I think WikiPage is supposed to be used for things like editing a page, which makes no sense for Special pages. But then all sorts of other methods started appearing there too [21:55:17] Heh [21:55:24] bawolff: So maybe the bug I filed is pretty useless, then [21:55:45] marktraceur: oh, also. there's no feedback for a long time after the initial click on the thumbnail. [21:55:57] MatmaRex: That should actually be fixed in latest master [21:57:07] marktraceur: Well I think the whole way WikiPage vs Article vs Title classes are divided up is kind of non-sensical [21:57:10] but that's a separate issue [21:57:23] Yeah. [21:57:54] especially the WikiPage vs Article split [21:58:32] marktraceur: please tell me WHY ARE THE FILE NAMES DIFFERENT THAN THE CLASS NAMES IN THEM (or prototype names or whatever) [21:58:46] i've gotten too used to being able to easily jump to thing when working on core MW :( [21:59:09] here i'm back to grepping for things like a neanderthal [22:00:11] (03CR) 10Aaron Schulz: [C: 04-1] Maintenance script for token resets (033 comments) [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/124752 (owner: 10CSteipp) [22:00:21] MatmaRex: Uh, it depends on the file I guess? [22:00:21] MatmaRex: Like how the MediaWiki class is in Wiki.php in core :P [22:00:36] (yeah, that's a lame example. People went and fixed all the other examples ;) [22:00:55] mmv.ui.js has mmv.ui.Element I guess but there's usually at least some correlation between file and class names. [22:01:15] marktraceur: mw.mmv.MultimediaViewer, for example [22:01:19] Ahhh. [22:01:22] Wait. [22:01:26] I thought that was MultimediaViewer. [22:01:27] bawolff: core has just that, and MWTImestamp and MWNamespace i think [22:01:53] addshore split pretty much all files which had more than one class in the last few months [22:01:53] Oh, it's in mmv.js [22:01:54] Yeah [22:01:59] Well some of the media handler classes are in things like Bitmap.php for BitmapHandler [22:01:59] MatmaRex: That's an easy patch [22:02:22] (03CR) 10Hoo man: "also per Aaron" (032 comments) [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/124752 (owner: 10CSteipp) [22:02:27] * addshore waves [22:03:22] * addshore feels like he might go and split more, as long as they get merged quickly ;p [22:03:34] ugh, why is MMVB.processThumbs called from the constructor [22:03:43] (03CR) 10Jackmcbarn: [C: 04-1] "Hold off on this for now." [core] - 10https://gerrit.wikimedia.org/r/123516 (owner: 10Jackmcbarn) [22:03:48] MatmaRex: Also grepping through filerepo/file/LocalFile.php for specific method name can get confusing with all those LocalFileFooBatch classes [22:03:50] why does so much happen in the constructor ;_; [22:04:03] bawolff: well thankfully i don't ever touch these. :D [22:04:08] MatmaRex: Patch away, sirrah [22:04:32] * MatmaRex is still trying to figure out where do the thumbs come from [22:04:52] MatmaRex: Probably something in mmv/provider [22:04:54] s [22:05:03] ...-s [22:05:05] so many .closest() calls… i wonder how long startup takes on Barack Obama? [22:05:18] mmv.provider.Image.js probably [22:05:21] Does MW expose the content model of a document to the JS anywhere? [22:05:56] mw.config.get( 'wgPageContentModel' ) ? [22:05:58] I think [22:06:20] Perfect, thanks bawolff [22:06:29] was looking for wgContentModel or something along those lines [22:06:37] (03PS1) 10Aaron Schulz: Fixed batching error in token reset script [core] - 10https://gerrit.wikimedia.org/r/124756 [22:07:05] I think there's a full list of the per-page wg things that get exposed to js in OutputPage somewhere [22:08:02] marktraceur: on a note unrelated to what i'm investigating, MMVB.processThumbs() looks like something too slow to run during what is essentially loading [22:08:05] or, like, at all [22:08:33] (it apparnetly happens the first time the user clicks any thumbnail, i think) [22:08:42] MatmaRex: You think we should just bind to all of the elements with event bubbling and check the whitelist then? [22:09:02] Er, all of the elements that match our initial selector. [22:09:11] (03PS2) 10CSteipp: Maintenance script for token resets [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/124752 [22:09:42] bawolff, hm okay, so I had thought the content model would help, but maybe not [22:09:46] JeroenDeDauw, around? [22:09:57] What are you looking to do, anyways? [22:10:10] bawolff, https://bugzilla.wikimedia.org/show_bug.cgi?id=53477 [22:10:42] (03CR) 10Hoo man: [C: 04-1] "Also still the nit picks from PS1 (if you care)" (032 comments) [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/124752 (owner: 10CSteipp) [22:10:46] marktraceur: do you really need the list of all thumbnails and their properties, while loading just one? what for? D: [22:11:12] MatmaRex: For hash changes it's useful because we need to find the right thumbnail to load [22:11:17] huh, the page content model is wikitext for those? That's not what i would expect [22:11:29] hm. [22:11:38] e.g. if someone comes to the page with #mediaviewer/File:Foobar.jpg we need to iterate over the list to find Foobar.jpg [22:12:26] (03PS3) 10CSteipp: Maintenance script for token resets [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/124752 [22:12:45] bawolff, yep [22:13:11] I guess you could just always check the namespace [22:13:36] (03CR) 10Hoo man: [C: 031] "Functionality should be fine (untested), still the nit picks from PS1, but those shouldn't block fast actions here" [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/124752 (owner: 10CSteipp) [22:14:27] (03CR) 10Aaron Schulz: [C: 032] Maintenance script for token resets [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/124752 (owner: 10CSteipp) [22:14:30] (03Merged) 10jenkins-bot: Maintenance script for token resets [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/124752 (owner: 10CSteipp) [22:15:43] marktraceur: MMVP.loadImageByTitle calls "viewer.loadImage( thumb.image, thumb.$thumb.clone()[ 0 ], true )", but loadImage() only accepts two arguments… [22:16:08] bawolff, I think checking wgIsArticle would be enough [22:16:16] Uhhhh. [22:16:27] MatmaRex: Probably legacy, then. Not sure what that used to do. [22:17:37] eh [22:19:01] Krenair: That doesn't seem that related. Its normal false on things like Special:MovePage/Some_article_here [22:19:21] bawolff, it is false on the Education Program pages though [22:19:47] Hmm, yeah I guess it is [22:20:35] (03PS5) 10Mwjames: Adds $egChameleonExternalStyleModules / $egChameleonExternalLessVariables [skins/chameleon] - 10https://gerrit.wikimedia.org/r/124596 [22:21:22] marktraceur: getQueryPage() logic in /resources/mmv/provider/mmv.provider.Api.js wouldn't be necessary if you used &indexpageids=1 in your api queries [22:22:11] (03CR) 10Mwjames: "Just was to lazy to open another change set just to add $egChameleonExternalLessVariables therefore PR5 adds the necessary test and featur" [skins/chameleon] - 10https://gerrit.wikimedia.org/r/124596 (owner: 10Mwjames) [22:22:25] Oh, whoa [22:22:45] TIL [22:23:29] ori, does requiring a Package in MWV automatically trigger apt-get update beforehand? [22:24:40] MatmaRex: I mean, we'd still need the logic, it would just be less shitty [22:26:08] marktraceur: oh, i discovered how to make the image "unblur". [22:26:13] make the browser window smaller. [22:26:20] making it larger doesn't seem to work, in fact. [22:27:11] MatmaRex: Both should be a resize event...weird [22:27:30] bawolff: Are you kidding me (re bugzilla) [22:27:41] marktraceur: can you sum up in one sentence what is mw.mmv.provider.Image aiming to do? [22:27:49] (03PS1) 10CSteipp: Maintenance script for token resets [extensions/CentralAuth] (wmf/1.23wmf20) - 10https://gerrit.wikimedia.org/r/124757 [22:28:01] MatmaRex: If that sentence is "Provide the image" is that not helpful [22:28:11] * marktraceur looks at code [22:28:19] (03PS1) 10CSteipp: Maintenance script for token resets [extensions/CentralAuth] (wmf/1.23wmf21) - 10https://gerrit.wikimedia.org/r/124758 [22:28:23] i'm mostly wondering why are there two modes [22:29:23] MatmaRex: You mean get and rawGet? [22:30:01] I hate our documentation so much [22:30:03] * marktraceur rewrites [22:30:04] marktraceur: i mean the if ( this.imagePreloadingSupported() ) [22:31:17] (03CR) 10Chad: Strip citation links (like [1], [2], etc) from HTML (031 comment) [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/123878 (owner: 10Chad) [22:31:25] marktraceur: also. trying to show a thumbnail fires 12 api requests [22:31:27] that's twelve [22:31:29] D: [22:31:37] Hm, I dunno [22:31:47] I think gi11es wrote that code [22:31:51] MatmaRex: that should be accurately called ajaxPreloadingSupported [22:31:59] since we do preloading either way [22:32:14] ajax preloading is needed to get detailed performance data [22:32:47] specifically to tell whether it was a varnish cache hit [22:33:01] * marktraceur feels dumb [22:34:22] (03CR) 10CSteipp: [C: 032] Maintenance script for token resets [extensions/CentralAuth] (wmf/1.23wmf21) - 10https://gerrit.wikimedia.org/r/124758 (owner: 10CSteipp) [22:34:24] (03Merged) 10jenkins-bot: Maintenance script for token resets [extensions/CentralAuth] (wmf/1.23wmf21) - 10https://gerrit.wikimedia.org/r/124758 (owner: 10CSteipp) [22:34:25] scary stuff. [22:35:09] it sure is [22:35:22] (03CR) 10CSteipp: [C: 032] Maintenance script for token resets [extensions/CentralAuth] (wmf/1.23wmf20) - 10https://gerrit.wikimedia.org/r/124757 (owner: 10CSteipp) [22:35:25] (03Merged) 10jenkins-bot: Maintenance script for token resets [extensions/CentralAuth] (wmf/1.23wmf20) - 10https://gerrit.wikimedia.org/r/124757 (owner: 10CSteipp) [22:35:34] but varnish misses were by far the largest performance problem for us so we really needed data on them [22:35:44] csteipp: Why both? [22:36:00] csteipp: https://gerrit.wikimedia.org/r/#/c/124756/ [22:36:03] marktraceur: btw, known issue at commons? "ncaught TypeError: Object # has no method 'intializeSelection' on mmv.ui.reuse.download.js:191" [22:36:08] re api requests, there are about 4 per image [22:36:12] * marktraceur weeps [22:36:15] s/ncaught/uncaught [22:36:17] depends on where you are testing [22:36:28] bawolff: I'm guessing they deployed their breaking change and we haven't dealt with it yet [22:36:30] the previous and next image are preloaded [22:36:35] hoo: Yeah, I didn't need to.. [22:36:48] tgr: This was on commons main page [22:36:50] (03PS3) 10Jackmcbarn: Make RECOVER_ORIG preserve extension tags [core] - 10https://gerrit.wikimedia.org/r/123516 [22:37:18] Wait, commons is on wmf20 I thought. [22:37:32] (03CR) 10Jackmcbarn: "Okay, all good now. I really don't like the way that test looks, but I can't think of a better solution." [core] - 10https://gerrit.wikimedia.org/r/123516 (owner: 10Jackmcbarn) [22:37:34] (03CR) 10Hoo man: [C: 032] Fixed batching error in token reset script [core] - 10https://gerrit.wikimedia.org/r/124756 (owner: 10Aaron Schulz) [22:37:43] marktraceur: nope, 1.23wmf21 [22:37:48] bawolff: sorry, was still talking to MatmaRex [22:37:50] Agh. [22:37:58] OK, bawolff, I'll sort that out next I guess [22:38:13] Commons is in the non-wikipedia pool, so deploys on tuesdays [22:38:35] there is a fix for the intializeSelection stuff in master, not sure how it got into the deploy branch though [22:38:38] Maybe...maybe there's something going on in an old branch but we've fixed it? I cannot find intializeSelection in our code in master. [22:38:41] Aha. [22:38:48] this was merged to core on monday or so [22:38:51] can anyone good with parser tests look at what i had to do in https://gerrit.wikimedia.org/r/123516 and see if there's a better way? [22:38:55] * marktraceur will find it for the SWATter [22:38:57] s. [22:39:31] tgr: marktraceur: eh, i'll dig into this one day [22:39:46] another suggestion, the progress bar is all but unnoticeable. [22:39:56] i only learned it exists when i saw the code that sets it. :P [22:40:18] jackmcbarn: wow, I've never even heard of the options disabled before [22:40:19] I think that's partly the idea [22:40:21] (03PS1) 10Addshore: Move ConverterRule class to its own file [core] - 10https://gerrit.wikimedia.org/r/124759 [22:40:44] MatmaRex: the problem is that most of the time we are not loading, usually [22:40:50] not the image, anyway [22:41:04] jackmcbarn: Oh, I see it disables the test (d'oh) [22:41:11] marktraceur: tgr: MMV is removing the usualy indicator of an image being loaded [22:41:19] (that is, the image showing up on screen line-by-line) [22:41:25] (03CR) 10jenkins-bot: [V: 04-1] Fixed batching error in token reset script [core] - 10https://gerrit.wikimedia.org/r/124756 (owner: 10Aaron Schulz) [22:41:25] for example when you are waiting for the scalers to render the thumbnail, the progress is stuck at 0% [22:41:38] you need to replace that with something equally visible [22:41:44] a static spinner would do, really [22:41:48] We have had this conversation *so* many times [22:41:51] but i see nothing move [22:41:59] there were hacks to make that look better, but they broke at some point [22:42:04] i honestly always thought that MMV just doesn't work [22:42:14] until debugging it now made me stick around until something actually happens [22:42:17] The current method is the way it is because we wanted perf data [22:42:33] but yeah, probably should be replaced with something static [22:42:35] i'd just slap a $.spinner() in the middle of the placeholder image or something [22:42:36] jackmcbarn: What exactly are you worried about with the parser test? it looks fine to me (except the trailing whitespace does stick out, but if its needed...) [22:42:43] MatmaRex: Which is what I did [22:42:45] But it was ugly [22:42:50] And then we took it out [22:42:50] bawolff: the current behavior sounds like it isn't exactly desired [22:43:06] (03PS2) 10Krinkle: Update OOjs UI to v0.1.0-pre (70932872ba) [core] - 10https://gerrit.wikimedia.org/r/124735 (owner: 10Jforrester) [22:43:06] not a spinner, but maybe a progress bar like the one in google image search [22:43:07] bawolff: the only thing i care about is that doesn't get expanded, but apparently i need to test the weird escaping along with it [22:43:14] jackmcbarn: oh I see [22:43:57] tgr: marktraceur: also, is it just me, or [22:44:02] Maybe msgnw was originally supposed to be like wfMsgNoTransform or something [22:44:09] (03CR) 10jenkins-bot: [V: 04-1] Make RECOVER_ORIG preserve extension tags [core] - 10https://gerrit.wikimedia.org/r/123516 (owner: 10Jackmcbarn) [22:44:15] oh come on... [22:44:24] what you are preloading the next image as you said [22:44:31] are you actually preloading the image? the picture? [22:44:32] MatmaRex: https://bugzilla.wikimedia.org/show_bug.cgi?id=59699 [22:44:38] oh. just qunit [22:44:45] MatmaRex: I think just the metadata [22:44:47] can i do recheck or does someone authorized have to do it? [22:44:48] Could be wrong [22:44:53] (03PS4) 10Brian Wolff: Make RECOVER_ORIG preserve extension tags [core] - 10https://gerrit.wikimedia.org/r/123516 (owner: 10Jackmcbarn) [22:44:56] we preload everything [22:44:58] Oh. [22:45:03] jackmcbarn: I just usually hit rebase [22:45:07] a thumbnail and a bunch of api requests [22:45:09] tgr: I thought we didn't get the go-ahead to pre-render thumbnails? [22:45:17] jackmcbarn: recheck doesn't seem to work for me half the time [22:45:20] my unscientific testing shows that the other image is actually loading [22:45:37] and loading two images at the same time is slower than loading just one on networks like mine… [22:45:37] marktraceur: no, but i don't think that's related [22:45:58] MatmaRex: in theory it should be queued [22:46:06] oh wait [22:46:23] we preload the fullscreen image as well and that one is not queued [22:46:26] is there a chance of qunit getting changed to non-voting until whatever's wrong with it gets fixed? [22:46:42] probably just should kill that, fullscreen is not used much anyway [22:46:55] tgr: :o [22:47:06] jackmcbarn: Krinkl.e and or.i are working on it [22:47:20] (unbreaking qunit, that is) [22:48:47] (03PS1) 10BryanDavis: Compile wikiversions.json to cdb on deploy server [tools/scap] - 10https://gerrit.wikimedia.org/r/124762 [22:49:44] (03PS3) 10Mattflaschen: Change config format to use full category page names [extensions/GettingStarted] - 10https://gerrit.wikimedia.org/r/122856 (owner: 10Phuedx) [22:49:48] (03CR) 10Legoktm: Generic data store (032 comments) [core] - 10https://gerrit.wikimedia.org/r/79029 (owner: 10MaxSem) [22:50:02] bawolff: do you think that test is ok? [22:50:43] jackmcbarn: probably (I think) [22:50:54] (03PS1) 10Addshore: Split CLDRPluralRuleEvaluator file [core] - 10https://gerrit.wikimedia.org/r/124764 [22:51:21] although there is a part of me that thinks this suggests that we should just remove msgnw as a feature altogether [22:51:50] bawolff: i'm not against that, but if we do that, then i can't test the change to RECOVER_ORIG at all (since all that would use it would be extensions) [22:53:41] okay, sleepytime. see you guys [22:55:45] (03CR) 10Mwalker: [C: 031] Preserve textarea state when building WikiEditor UI [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/124567 (owner: 10TheDJ) [22:56:31] (03PS1) 10Hoo man: Update CentralAuth to pull the token reset maint. script [core] (wmf/1.23wmf21) - 10https://gerrit.wikimedia.org/r/124766 [22:58:03] (03PS1) 10Hoo man: Update CentralAuth to pull the token reset maint. script [core] (wmf/1.23wmf20) - 10https://gerrit.wikimedia.org/r/124768 [22:58:37] (03PS1) 10Mattflaschen: Change GettingStarted config format to include namespace prefix [vagrant] - 10https://gerrit.wikimedia.org/r/124770 [22:59:40] (03CR) 10Mattflaschen: [C: 04-1] "ApiGettingStartedGetPages needs to be changed too." [extensions/GettingStarted] - 10https://gerrit.wikimedia.org/r/122856 (owner: 10Phuedx) [23:00:00] (03CR) 10CSteipp: [V: 032] Update CentralAuth to pull the token reset maint. script [core] (wmf/1.23wmf21) - 10https://gerrit.wikimedia.org/r/124766 (owner: 10Hoo man) [23:00:07] (03CR) 10CSteipp: [C: 032] Update CentralAuth to pull the token reset maint. script [core] (wmf/1.23wmf21) - 10https://gerrit.wikimedia.org/r/124766 (owner: 10Hoo man) [23:01:49] (03CR) 10Mattflaschen: [C: 04-2] "Blocked on I51860b76f82b8760bd30630bcf76a3b17e9a3b56" [vagrant] - 10https://gerrit.wikimedia.org/r/124770 (owner: 10Mattflaschen) [23:03:15] (03CR) 10jenkins-bot: [V: 04-1] Update CentralAuth to pull the token reset maint. script [core] (wmf/1.23wmf21) - 10https://gerrit.wikimedia.org/r/124766 (owner: 10Hoo man) [23:03:32] (03CR) 10Mattflaschen: "When this is done, we should get a deployment window to update the mediawiki-config from Wikidata. During the window, we can merge the "g" [extensions/GettingStarted] - 10https://gerrit.wikimedia.org/r/122856 (owner: 10Phuedx) [23:03:33] what [23:03:50] Is jenkins on the crack again? [23:03:59] (03PS1) 10J-squared: Set the default end date for new courses as six months from present [extensions/EducationProgram] - 10https://gerrit.wikimedia.org/r/124771 [23:04:27] (03CR) 10Hoo man: [C: 032] "Try this again..." [core] (wmf/1.23wmf21) - 10https://gerrit.wikimedia.org/r/124766 (owner: 10Hoo man) [23:04:51] (03CR) 10CSteipp: [V: 032] "qunit failed from phantom timeout." [core] (wmf/1.23wmf21) - 10https://gerrit.wikimedia.org/r/124766 (owner: 10Hoo man) [23:05:09] can also force merge, shouldn't be an issue here [23:05:27] (03CR) 10MaxSem: Generic data store (032 comments) [core] - 10https://gerrit.wikimedia.org/r/79029 (owner: 10MaxSem) [23:05:30] (03CR) 10Foxtrott: "One more comment." (031 comment) [skins/chameleon] - 10https://gerrit.wikimedia.org/r/124596 (owner: 10Mwjames) [23:05:58] csteipp: jenkins may have moved on to shooting heroin. I'm having a hard time keeping track. [23:09:51] (03PS2) 10J-squared: Set the default end date for new courses as six months from present [extensions/EducationProgram] - 10https://gerrit.wikimedia.org/r/124771 [23:10:07] cscott: s/again/still/ [23:10:15] !bug 63579 [23:10:15] https://bugzilla.wikimedia.org/buglist.cgi?quicksearch=63579 [23:10:16] (03PS1) 10Ssmith: most things fixed from preceding comments. still need to fix map. pushing for review in interim to get working copy. [extensions/FundraisingChart] - 10https://gerrit.wikimedia.org/r/124774 [23:10:19] (03CR) 10jenkins-bot: [V: 04-1] most things fixed from preceding comments. still need to fix map. pushing for review in interim to get working copy. [extensions/FundraisingChart] - 10https://gerrit.wikimedia.org/r/124774 (owner: 10Ssmith) [23:10:21] csteipp: ^ [23:10:48] MatmaRex: what? [23:11:07] who created the "block locally" checkbox for GlobalBlocking? [23:11:09] MatmaRex: what? [23:11:15] csteipp: jenkins/qunit being broken is bug 63579 [23:11:29] cscott: your nick is too close to csteipp, who complained about jenkins. :P [23:11:47] (03CR) 10Mwjames: "So you want?" [skins/chameleon] - 10https://gerrit.wikimedia.org/r/124596 (owner: 10Mwjames) [23:11:49] (03CR) 10J-squared: "This sets the default end date for a new course as six months in the future. Trello task: https://trello.com/c/576LGPhN/10-default-end-dat" (031 comment) [extensions/EducationProgram] - 10https://gerrit.wikimedia.org/r/124771 (owner: 10J-squared) [23:11:56] marktraceur: Oh looks like you're not the only one with WikiPage - https://bugzilla.wikimedia.org/show_bug.cgi?id=59788 [23:12:21] jenkins is a lovely and beautiful program which is compliant with all of the latest Java and XML Enterprise Standards. [23:13:08] (03CR) 10Foxtrott: "Yes, exactly." [skins/chameleon] - 10https://gerrit.wikimedia.org/r/124596 (owner: 10Mwjames) [23:14:38] (03CR) 10Mwjames: "But this means:" [skins/chameleon] - 10https://gerrit.wikimedia.org/r/124596 (owner: 10Mwjames) [23:14:41] (03CR) 10JGonera: "recheck" [core] - 10https://gerrit.wikimedia.org/r/116037 (owner: 10JGonera) [23:15:16] (03CR) 10Hoo man: [V: 032] Fixed batching error in token reset script [core] - 10https://gerrit.wikimedia.org/r/124756 (owner: 10Aaron Schulz) [23:16:04] bawolff: Want to dupe it? [23:17:27] I don't think its exactly the same. The later comments seem to suggest that WikiData just is going to do something different [23:19:01] (03Abandoned) 10BryanDavis: Make UIDGenerator cache files world writable [core] - 10https://gerrit.wikimedia.org/r/121549 (owner: 10BryanDavis) [23:19:17] * Risker waves. [23:19:31] hey Risker [23:19:54] Got the memo about resetting everyone's session cookies. Except now Wikipedia seems to be logging me out every other edit. [23:19:58] Whoa, a Risker. [23:20:04] Hm, greg-g ^^ [23:20:41] csteipp: ^ [23:20:59] just for the record, I'm fine with the basic principle here :) [23:21:43] In five minutes, Deskana will log in and ping me and the circle will be complete [23:23:59] oh hmm, I'm logged out again [23:24:09] Risker: Looks like its not just you :) [23:24:57] I'm still logged in... [23:25:36] I've only tried it on enwiki because it has a warning if you're about to save logged out... [23:25:56] I don't think Meta has that, nor the other places I go... [23:26:14] everywhere has it [23:26:21] (03PS2) 10Bsitu: Add Sorting to topic list based on last updated timestamp [extensions/Flow] - 10https://gerrit.wikimedia.org/r/124644 [23:26:37] bawolff: Is it still doing that if you log out and log back in? [23:27:37] csteipp: so far, not yet [23:27:42] (03PS1) 10Mwalker: Updating MultimediaViewer to 1.23wmf21 HEAD [core] (wmf/1.23wmf21) - 10https://gerrit.wikimedia.org/r/124777 [23:27:54] (03CR) 10Mwalker: [C: 032] Updating MultimediaViewer to 1.23wmf21 HEAD [core] (wmf/1.23wmf21) - 10https://gerrit.wikimedia.org/r/124777 (owner: 10Mwalker) [23:27:54] bawolff: so far you haven't been logged out? [23:28:16] not in the last 45 seconds [23:28:28] I haven't been logged out at all [23:28:45] marktraceur: You will sometime... in the next 5 days, depending on your gu_id. [23:29:01] Excellent. [23:30:37] (03PS2) 10Jdlrobson: Follow up to If985b16c4f682d737683597ed80951c6d6644c8f [core] - 10https://gerrit.wikimedia.org/r/124618 [23:32:00] (03CR) 10jenkins-bot: [V: 04-1] Updating MultimediaViewer to 1.23wmf21 HEAD [core] (wmf/1.23wmf21) - 10https://gerrit.wikimedia.org/r/124777 (owner: 10Mwalker) [23:32:02] (03Merged) 10jenkins-bot: Updating MultimediaViewer to 1.23wmf21 HEAD [core] (wmf/1.23wmf21) - 10https://gerrit.wikimedia.org/r/124777 (owner: 10Mwalker) [23:54:46] (03CR) 10Mwjames: "Will allow both just needed to rewrite the test to make sure that:" [skins/chameleon] - 10https://gerrit.wikimedia.org/r/124596 (owner: 10Mwjames) [23:57:38] (03PS6) 10Mwjames: Adds $egChameleonExternalStyleModules / $egChameleonExternalLessVariables [skins/chameleon] - 10https://gerrit.wikimedia.org/r/124596 [23:58:43] (03CR) 10Aaron Schulz: [C: 031] Compile wikiversions.json to cdb on deploy server [tools/scap] - 10https://gerrit.wikimedia.org/r/124762 (owner: 10BryanDavis)