[00:22:16] i think that did turn out to be a problem. ended up doing a null edit (added a period inside a CSS comment) [00:22:25] that maybe fixed it, now waiting on cache [00:23:16] (busting with a query param works but the page source still has the cached one. waiting for varnish) [00:24:08] jeremyb: oh that one [00:24:18] it's known and I have a patch in gerrit for a week or more [00:24:24] but nobodoy cares for it [00:24:42] jeremyb: https://gerrit.wikimedia.org/r/122222 [00:24:42] hoo: well i can at least read it and say it happened to me too [00:24:43] :P [00:29:28] hmm, maybe installing inkscape will make imagemagick not fail horribly at rendering SVGs [00:30:28] oh man, I love the analogy in 'homebrew' [00:31:42] Y u no use Linux? [00:37:17] (03PS1) 10Alex Monk: Move logic for checking CA status (locked or non-unified) to userBlockFlags [extensions/CheckUser] - 10https://gerrit.wikimedia.org/r/124280 [00:40:38] (03CR) 10Alex Monk: "Obviously, list of groups is a bit out of place for a "userBlockFlags" function... But it should probably be on both "get edits" and "get" [extensions/CheckUser] - 10https://gerrit.wikimedia.org/r/124280 (owner: 10Alex Monk) [01:04:39] (03PS2) 10Jackmcbarn: Allow passing parameters to preload [core] - 10https://gerrit.wikimedia.org/r/116482 [01:10:26] (03CR) 10jenkins-bot: [V: 04-1] Allow passing parameters to preload [core] - 10https://gerrit.wikimedia.org/r/116482 (owner: 10Jackmcbarn) [01:17:02] can anyone tell me why this qunit failed? https://integration.wikimedia.org/ci/job/mediawiki-core-qunit/18669/console [01:17:17] (for https://gerrit.wikimedia.org/r/#/c/116482/ ) [01:41:19] (03PS2) 10Werdna: Fix a few bugs where Flow was not working on pristine pages. [extensions/Flow] - 10https://gerrit.wikimedia.org/r/123812 [01:42:17] (03CR) 10Werdna: "Have added the BoardHistory check to renderAPI instead." [extensions/Flow] - 10https://gerrit.wikimedia.org/r/123812 (owner: 10Werdna) [01:49:22] (03CR) 10Werdna: [C: 032] Only you can prevent logspam [extensions/Flow] - 10https://gerrit.wikimedia.org/r/124039 (owner: 10EBernhardson) [01:53:51] (03CR) 10Brian Wolff: Allow passing parameters to preload (031 comment) [core] - 10https://gerrit.wikimedia.org/r/116482 (owner: 10Jackmcbarn) [01:54:36] (03CR) 10Brian Wolff: "recheck" [core] - 10https://gerrit.wikimedia.org/r/116482 (owner: 10Jackmcbarn) [02:02:45] (03CR) 10Brian Wolff: [C: 032] "This look fine to me. The array syntax is a little weird mediawiki wise, but I agree that avoiding the | escaping is worth it." [core] - 10https://gerrit.wikimedia.org/r/116482 (owner: 10Jackmcbarn) [02:05:33] (03PS5) 10Werdna: Implement multiPut method. [extensions/Flow] - 10https://gerrit.wikimedia.org/r/120734 [02:05:36] (03PS29) 10Werdna: Extract wiki and external links, file and template usages from text. [extensions/Flow] - 10https://gerrit.wikimedia.org/r/110090 [02:06:26] (03CR) 10Werdna: "PS29 is just a rebase too." [extensions/Flow] - 10https://gerrit.wikimedia.org/r/110090 (owner: 10Werdna) [02:06:51] (03CR) 10Werdna: "PS5 addresses Erik's concerns about function doc blocks." [extensions/Flow] - 10https://gerrit.wikimedia.org/r/120734 (owner: 10Werdna) [02:12:26] Krinkle|detached: https://integration.wikimedia.org/zuul/ looks kind of stalled [02:12:37] bawolff: that hasn't merged yet, and given jenkins' temper-tantrums for the past few minutes, i doubt it will get merged, at least not without another recheck [02:12:51] re bugzilla [02:12:56] jackmcbarn: jenkins has been linting it for about five minutes [02:13:15] one of the unit tests has a timeout that it hit last time it looks like. i'm worried it will hit it and fail againh [02:13:17] (03CR) 10Brian Wolff: [V: 032] "jenkins is being silly" [core] - 10https://gerrit.wikimedia.org/r/116482 (owner: 10Jackmcbarn) [02:14:23] Well qunit has been "timing out" off and on for the last couple weeks [02:14:57] zuul says your patch is stalled at lint ( https://integration.wikimedia.org/zuul/ ) which is just odd [02:15:30] i just wish jenkins could have its tantrums during business hours when someone's around to restart it [02:15:39] And so are all werdna's flow patches above. So something is weird with the jenkins [02:15:58] * werdna is pung [02:16:36] werdna: Just noting that its not just jackmcbarn's patch that jenkins is ignoring [02:16:45] we all broke it :) [02:18:58] jackmcbarn: Anyways, that's what is so good about having a button to merge things without jenkins blessings ;) [02:19:37] now to fight with the beta cluster [02:19:46] every single time i import something, it's slow for about an hour afterward [02:32:26] ugh right, I forgot that [] aren't allowed in external links on wiki w/o escaping [02:45:47] bawolff: %5B / %5D [02:45:51] just incase you needed to look it up [02:46:26] already did, but thanks [02:46:38] echo -n [] | hd [02:47:07] is a fast way to look up character codes [02:47:21] I don't have hd on my system [02:47:49] I usually use echo "print urlencode('[]');" | wikieval [02:48:12] bawolff: any idea why beta cluster doesn't have the change yet? [02:48:33] Because the first rule of beta cluster is that its always broken :P [02:48:52] yeah, I have no idea [02:49:30] hmm, I'm not getting any css on beta cluster [02:50:12] and now its not loading at all... [02:51:26] jackmcbarn: Special:Version says it should have your change [02:54:03] jackmcbarn: Actually no it doesn't [02:54:08] sorry, I read the wrong git hash [03:05:01] (03CR) 10Dan-nl: "does this patch need to first be checked out as its own branch or is it okay to commit directly against master?" [extensions/GWToolset] - 10https://gerrit.wikimedia.org/r/123157 (owner: 10Brian Wolff) [03:05:12] (03CR) 10Brian Wolff: [C: 04-1] "-1 for anomie's comment about the regex." (031 comment) [core] - 10https://gerrit.wikimedia.org/r/114942 (owner: 10Bartosz Dziewoński) [03:07:04] (03PS1) 10Gnosygnu: v1.4.1.1 [xowa] - 10https://gerrit.wikimedia.org/r/124282 [03:09:27] (03CR) 10Brian Wolff: "Do you mean "Topic" in gerrit? The topic thing is mostly meaningless and doesn't really matter." [extensions/GWToolset] - 10https://gerrit.wikimedia.org/r/123157 (owner: 10Brian Wolff) [03:13:25] (03CR) 10Gnosygnu: [C: 032 V: 032] "approving own commit" [xowa] - 10https://gerrit.wikimedia.org/r/124282 (owner: 10Gnosygnu) [03:16:09] bawolff: regarding https://bugzilla.wikimedia.org/show_bug.cgi?id=22683 , given that i have a new use i need RECOVER_ORIG to work right for (which fixes that bug as a side effect), do you think it'd be worth going through with? [03:17:48] wow, people keep pointing me at bugs today where I said stuff I totally didn't remember saying [03:19:03] present me thinks the backwards compatibility concerns that past me had were overrated [03:19:41] but I'd also advise seeing what some of the parser gurus think (and parsoid people like cscott) [03:20:11] * cscott perks up [03:22:07] oh wow, that's black magic [03:22:11] * cscott makes the sign of the cross [03:22:14] So i'd be in favour of just fixing the msgnw: bug (really make it everything), unless there are actually people relying on it [03:22:35] cscott: what's black magic? msgnw, original RECOVER_ORIG, the change, or all of the abov? [03:22:37] above [03:22:51] and honestly, I'd be surprised if people actually use msgnw:, let alone expect it to have the broken behaviour of not escaping extension tags [03:23:19] i didn't know msgnw existed until i found that bug [03:23:40] (and all the parser tests pass, so i know i'm not breaking anything too badly) [03:24:34] all of the above [03:24:42] i believe in fixing old brokenness [03:25:19] parsoid doesn't implement , RECOVER_ORIG, or msgnw currently -- so making the thing that we eventually have to implement more sane is a plus [03:25:42] (parsoid uses the PHP preprocessor for many things, including extensions and magic words) [03:26:21] can one/both of you leave a note to that effect on the gerrit change? [03:28:24] (03CR) 10Brian Wolff: [C: 031] "I haven't tested this yet, but I'm generally in favour of this change. I think its unlikely people are relying on the old behaviour (Altho" [core] - 10https://gerrit.wikimedia.org/r/123516 (owner: 10Jackmcbarn) [03:29:17] thanks [03:33:26] jackmcbarn: added a comment to bugzilla [03:53:37] (03CR) 10Legoktm: "Please let jenkins submit in the future so pre-merge tests aren't skipped." [core] - 10https://gerrit.wikimedia.org/r/121419 (owner: 10Kaldari) [04:01:20] (03CR) 10Brian Wolff: [C: 04-1] "One small thing + a question to the i18n folks about the message just to be double sure its ok." (033 comments) [core] - 10https://gerrit.wikimedia.org/r/104182 (owner: 10TTO) [04:41:41] (03PS3) 10Brian Wolff: includes/Linker.php: Added hook for "Media:" links [core] - 10https://gerrit.wikimedia.org/r/120767 (owner: 10Robert Vogel) [04:41:47] (03PS4) 10Brian Wolff: includes/Linker.php: Added hook for "Media:" links [core] - 10https://gerrit.wikimedia.org/r/120767 (owner: 10Robert Vogel) [04:45:35] Hmm, why does every single parser test fail for me locally? [04:49:18] (03CR) 10Brian Wolff: [C: 032] "Thanks for patch." [core] - 10https://gerrit.wikimedia.org/r/120767 (owner: 10Robert Vogel) [04:52:38] (03CR) 10Brian Wolff: [C: 04-1] "Guess I didn't give this a -1 last time. -1 for same reason as gerrit change 118822" [core] - 10https://gerrit.wikimedia.org/r/119350 (owner: 10Rahul mishra) [04:53:52] marktraceur: if you're around [04:54:03] Oh my. [04:54:15] it's not as big a patch as the line count makes it seem [04:54:37] Yeah [04:54:50] I think I will defer until tomorrow afternoon or Tuesday [04:55:00] I'm on "vacation" and I should probably be better about actually being on vacation. [04:55:57] ori: Do you have access/know how to give zuul whatever sort of kick it needs? [04:56:01] marktraceur: OK, no problem. Is it important that you be the person to review it, or could I nag someone else? Having it in will unblock me, since I'm currently debugging HHVM issues on Beta and this is coming up. [04:56:32] ori: Probably it should be OK for anyone else on the MM team to review. [04:56:51] cool, thanks. enjoy your vacation. [04:57:32] bawolff: access, yes -- know-how, no. I'd poke around but since hashar is likely to sign on in the next three or four hours anyway, I'd prefer to leave it to him. [04:58:29] Ok. I was going to go to bed pretty soon anyways, so I'm sure it will be fixed by the time I wake up :) [04:59:45] bawolff: yes, I'd imagine so. It's good to !log such things (on #wikimedia-operations) if you notice them. I'll do that now. [05:01:21] (03PS4) 10Umherirrender: Changed some comments from /// to /** @var */ [core] - 10https://gerrit.wikimedia.org/r/124167 [05:06:53] (03CR) 10Brian Wolff: [C: 04-1] "stat( $file->getRepo()->getFileSize( $file->getPath() ) ); would call stat on an integer (the file size). That doesn't sound right." [core] - 10https://gerrit.wikimedia.org/r/117027 (owner: 10AalekhN) [05:13:20] (03Abandoned) 10Brian Wolff: Add Symfony DI via Composer [extensions/Campaigns] (wip/editorcampaigns) - 10https://gerrit.wikimedia.org/r/115853 (owner: 10AndyRussG) [05:26:16] (03CR) 10AndyRussG: "Yeah, thanks Brian! Some RFCs about these issues coming soooon..." [extensions/Campaigns] (wip/editorcampaigns) - 10https://gerrit.wikimedia.org/r/115853 (owner: 10AndyRussG) [06:08:54] (03CR) 10KartikMistry: [C: 032] "Code LGTM. Test passes." [services/cxserver] - 10https://gerrit.wikimedia.org/r/123519 (owner: 10Santhosh) [06:11:12] (03CR) 10KartikMistry: [C: 032] "Code, tests LGTM." [services/cxserver] - 10https://gerrit.wikimedia.org/r/123522 (owner: 10Santhosh) [06:17:30] (03PS2) 10Santhosh: Segmentation: Handle the case of repeated references [services/cxserver] - 10https://gerrit.wikimedia.org/r/123596 [06:29:32] (03PS1) 10Divec: DONT MERGE: Proof of concept linear segmenter [services/cxserver] - 10https://gerrit.wikimedia.org/r/124287 [06:41:25] (03PS7) 10Physikerwelt: remove armourMath and wgContLang (bug 60799) [extensions/Math] (math2_0_0) - 10https://gerrit.wikimedia.org/r/112324 [06:44:31] (03PS2) 10Divec: DONT MERGE: Proof of concept linear segmenter [services/cxserver] - 10https://gerrit.wikimedia.org/r/124287 [06:55:28] (03PS14) 10Physikerwelt: Editbutton for math [extensions/Math] - 10https://gerrit.wikimedia.org/r/109923 [06:56:41] (03PS1) 10Deepali: Changed property name from publication_year to publication_date [extensions/BookManagerv2] - 10https://gerrit.wikimedia.org/r/124289 [07:42:00] (03CR) 10Dan-nl: [C: 032 V: 032] Make sure batch preview page shows correct link colour [extensions/GWToolset] - 10https://gerrit.wikimedia.org/r/123157 (owner: 10Brian Wolff) [07:52:52] (03CR) 10devunt: [C: 031] Changed some comments from /// to /** @var */ [core] - 10https://gerrit.wikimedia.org/r/124167 (owner: 10Umherirrender) [08:00:04] (03CR) 10Liangent: "@MatmaRex: It seems not working for release note conflicts across releases? (see above)" [core] - 10https://gerrit.wikimedia.org/r/87288 (owner: 10Liangent) [08:01:20] (03PS1) 10KartikMistry: Indentation fix in Logger.js [services/cxserver] - 10https://gerrit.wikimedia.org/r/124290 [08:05:10] (03CR) 10Frédéric Wang: [C: 032] remove armourMath and wgContLang (bug 60799) [extensions/Math] (math2_0_0) - 10https://gerrit.wikimedia.org/r/112324 (owner: 10Physikerwelt) [08:16:53] (03CR) 10Frédéric Wang: "I'm not familiar with the UI code, but I understand this is just moving the code button remove in 124142. So if nobody else complains, I'l" (033 comments) [extensions/Math] - 10https://gerrit.wikimedia.org/r/109923 (owner: 10Physikerwelt) [08:19:20] (03CR) 10Frédéric Wang: [C: 031] "This looks good to me." [core] - 10https://gerrit.wikimedia.org/r/124142 (owner: 10Physikerwelt) [08:20:35] (03PS6) 10TTO: Add extra views (tabs) for files in a foreign repository [core] - 10https://gerrit.wikimedia.org/r/104182 [08:21:48] (03CR) 10TTO: "Thanks for the review, Brian. Still waiting for i18n team feedback on your PS5 comment to en.json." [core] - 10https://gerrit.wikimedia.org/r/104182 (owner: 10TTO) [08:22:18] (03CR) 10Santhosh: [C: 032] Indentation fix in Logger.js [services/cxserver] - 10https://gerrit.wikimedia.org/r/124290 (owner: 10KartikMistry) [08:38:34] (03PS3) 10TheDJ: Add a status bar to the CodeEditor [extensions/CodeEditor] - 10https://gerrit.wikimedia.org/r/122601 [08:42:01] (03PS4) 10TheDJ: Add a status bar to the CodeEditor [extensions/CodeEditor] - 10https://gerrit.wikimedia.org/r/122601 [08:44:57] (03CR) 10PleaseStand: Move ExpandTemplates special into core (031 comment) [core] - 10https://gerrit.wikimedia.org/r/96810 (owner: 10UltrasonicNXT) [08:45:33] (03CR) 10TheDJ: [C: 04-1] Editbutton for math (031 comment) [extensions/Math] - 10https://gerrit.wikimedia.org/r/109923 (owner: 10Physikerwelt) [08:45:55] (03Merged) 10jenkins-bot: Only you can prevent logspam [extensions/Flow] - 10https://gerrit.wikimedia.org/r/124039 (owner: 10EBernhardson) [08:46:45] (03Merged) 10jenkins-bot: Segmentation: Fix the wrong usage of section types [services/cxserver] - 10https://gerrit.wikimedia.org/r/123519 (owner: 10Santhosh) [08:46:48] (03Merged) 10jenkins-bot: Segmentation: Reference handling improvements [services/cxserver] - 10https://gerrit.wikimedia.org/r/123522 (owner: 10Santhosh) [08:46:50] (03Merged) 10jenkins-bot: Indentation fix in Logger.js [services/cxserver] - 10https://gerrit.wikimedia.org/r/124290 (owner: 10KartikMistry) [08:47:36] (03CR) 10jenkins-bot: [V: 04-1] Extract wiki and external links, file and template usages from text. [extensions/Flow] - 10https://gerrit.wikimedia.org/r/110090 (owner: 10Werdna) [08:48:54] (03CR) 10MaxSem: [C: 032] Fix typo in API doc [extensions/TextExtracts] - 10https://gerrit.wikimedia.org/r/124144 (owner: 10Grunny) [08:51:26] (03Restored) 10Physikerwelt: remove armourMath and wgContLang (bug 60799) [extensions/Math] - 10https://gerrit.wikimedia.org/r/111119 (owner: 10Physikerwelt) [08:52:04] (03PS11) 10Physikerwelt: remove armourMath and wgContLang (bug 60799) [extensions/Math] - 10https://gerrit.wikimedia.org/r/111119 [08:53:23] (03CR) 10jenkins-bot: [V: 04-1] includes/Linker.php: Added hook for "Media:" links [core] - 10https://gerrit.wikimedia.org/r/120767 (owner: 10Robert Vogel) [08:56:59] (03CR) 10Frédéric Wang: [C: 031] "I leave some time to people to comment I will approve the change later." [extensions/Math] - 10https://gerrit.wikimedia.org/r/111119 (owner: 10Physikerwelt) [09:01:37] (03CR) 10Prtksxna: "Santhosh, could you please review and merge?" [extensions/Popups] - 10https://gerrit.wikimedia.org/r/123190 (owner: 10Santhosh) [09:02:32] (03CR) 10Addshore: [C: 031] "well, jenkins says yes now!" [core] - 10https://gerrit.wikimedia.org/r/124150 (owner: 10Aude) [09:03:33] (03CR) 10Prtksxna: "This is a work in progress and does not function at all. I was just breaking things into different files. No refactoring has happened yet." [extensions/Popups] - 10https://gerrit.wikimedia.org/r/117169 (owner: 10Prtksxna) [09:07:01] (03PS15) 10Physikerwelt: Editbutton for math [extensions/Math] - 10https://gerrit.wikimedia.org/r/109923 [09:12:37] (03CR) 10Frédéric Wang: [C: 031] Editbutton for math [extensions/Math] - 10https://gerrit.wikimedia.org/r/109923 (owner: 10Physikerwelt) [09:13:13] (03PS1) 10TheDJ: Convert MathJax enabler script to tabs [extensions/Math] - 10https://gerrit.wikimedia.org/r/124294 [09:13:31] (03CR) 10Nemo bis: "What to do with https://gerrit.wikimedia.org/r/#/q/status:open+topic:getPageTitle,n,z ?" [core] - 10https://gerrit.wikimedia.org/r/124130 (owner: 10MaxSem) [09:14:28] (03CR) 10MaxSem: "Leave it up to extension maintainers?" [core] - 10https://gerrit.wikimedia.org/r/124130 (owner: 10MaxSem) [09:16:20] (03CR) 10Nemo bis: "As in, abandon them all and let them restore if needed? :) If there was no movement in all these months I doubt something will magically h" [core] - 10https://gerrit.wikimedia.org/r/124130 (owner: 10MaxSem) [09:20:59] (03CR) 10Physikerwelt: [C: 031] "I'm fine with that. I think the coding convention for mathjax is different, but since this file is Mediaiki specific I don't see any reaso" [extensions/Math] - 10https://gerrit.wikimedia.org/r/124294 (owner: 10TheDJ) [09:21:17] (03CR) 10TheDJ: [C: 04-1] Editbutton for math (031 comment) [extensions/Math] - 10https://gerrit.wikimedia.org/r/109923 (owner: 10Physikerwelt) [09:25:17] (03CR) 10Physikerwelt: Editbutton for math (031 comment) [extensions/Math] - 10https://gerrit.wikimedia.org/r/109923 (owner: 10Physikerwelt) [09:26:15] (03CR) 10Frédéric Wang: [C: 031] Convert MathJax enabler script to tabs [extensions/Math] - 10https://gerrit.wikimedia.org/r/124294 (owner: 10TheDJ) [09:27:27] (03CR) 10Physikerwelt: [C: 032] Convert MathJax enabler script to tabs [extensions/Math] - 10https://gerrit.wikimedia.org/r/124294 (owner: 10TheDJ) [09:27:36] (03CR) 10Santhosh: "oh, I just wanted to avoid self merging." [extensions/Popups] - 10https://gerrit.wikimedia.org/r/123190 (owner: 10Santhosh) [09:28:10] (03PS16) 10Physikerwelt: Editbutton for math [extensions/Math] - 10https://gerrit.wikimedia.org/r/109923 [09:28:33] (03CR) 10Prtksxna: "Haha! I didn't want to merge my changes either, will ask Yuvi or S." [extensions/Popups] - 10https://gerrit.wikimedia.org/r/123190 (owner: 10Santhosh) [09:31:14] (03PS1) 10Prtksxna: Remove viewBox from SVG, not needed. [extensions/Popups] - 10https://gerrit.wikimedia.org/r/124296 [09:31:59] (03PS5) 10Bartosz Dziewoński: Create Parser::stripOuterParagraph to avoid code duplication [core] - 10https://gerrit.wikimedia.org/r/114942 [09:32:14] (03CR) 10Bartosz Dziewoński: Create Parser::stripOuterParagraph to avoid code duplication (032 comments) [core] - 10https://gerrit.wikimedia.org/r/114942 (owner: 10Bartosz Dziewoński) [09:32:22] (03CR) 10TheDJ: Editbutton for math (031 comment) [extensions/Math] - 10https://gerrit.wikimedia.org/r/109923 (owner: 10Physikerwelt) [09:33:03] (03CR) 10TheDJ: [C: 032] Editbutton for math [extensions/Math] - 10https://gerrit.wikimedia.org/r/109923 (owner: 10Physikerwelt) [09:33:20] (03CR) 10Bartosz Dziewoński: [C: 04-1] "Needs rebase." [extensions/Popups] - 10https://gerrit.wikimedia.org/r/123190 (owner: 10Santhosh) [09:33:55] (03CR) 10TTO: "https://commons.wikimedia.org/wiki/File:New_foreign_repo_file_tabs.png may be useful for any ambassadors/evangelism work" [core] - 10https://gerrit.wikimedia.org/r/104182 (owner: 10TTO) [09:33:57] (03Merged) 10jenkins-bot: Editbutton for math [extensions/Math] - 10https://gerrit.wikimedia.org/r/109923 (owner: 10Physikerwelt) [09:34:09] (03PS6) 10TheDJ: Remove button-math [core] - 10https://gerrit.wikimedia.org/r/124142 (owner: 10Physikerwelt) [09:34:22] (03CR) 10TheDJ: [C: 032] Remove button-math [core] - 10https://gerrit.wikimedia.org/r/124142 (owner: 10Physikerwelt) [09:36:22] hmm, we should expand mw.toolbar.addButtons, with an 'insertafter' field.. [09:38:37] (03Merged) 10jenkins-bot: Remove button-math [core] - 10https://gerrit.wikimedia.org/r/124142 (owner: 10Physikerwelt) [09:38:54] (03CR) 10jenkins-bot: [V: 04-1] Create Parser::stripOuterParagraph to avoid code duplication [core] - 10https://gerrit.wikimedia.org/r/114942 (owner: 10Bartosz Dziewoński) [09:39:44] (03CR) 10Siebrand: [C: 031] "i18n/L10n reviewed." (031 comment) [core] - 10https://gerrit.wikimedia.org/r/104182 (owner: 10TTO) [09:41:13] (03PS4) 10Prtksxna: Misc code formatting cleanup [extensions/Popups] - 10https://gerrit.wikimedia.org/r/123190 (owner: 10Santhosh) [09:49:27] (03PS3) 10Hashar: Add jobs for mediawiki-vagrant erblint and "rake lint" [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/109428 (owner: 10Adamw) [09:51:14] (03PS1) 10Santhosh: Move all test htmls to html files to avoid difficult to read escaped html [services/cxserver] - 10https://gerrit.wikimedia.org/r/124298 [09:51:34] (03CR) 10jenkins-bot: [V: 04-1] Move all test htmls to html files to avoid difficult to read escaped html [services/cxserver] - 10https://gerrit.wikimedia.org/r/124298 (owner: 10Santhosh) [09:52:28] (03PS2) 10Santhosh: Move all test htmls to html files to avoid difficult to read escaped html [services/cxserver] - 10https://gerrit.wikimedia.org/r/124298 [09:53:08] (03CR) 10Hashar: "We have puppet-lint installed on labs slaves now and two new job templates to run puppet-lint. Cleared up Adam -2 to be able to merge next" [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/109428 (owner: 10Adamw) [09:53:13] (03PS4) 10Hashar: Adds puppet jobs for mediawiki-vagrant [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/109428 (owner: 10Adamw) [09:53:50] (03PS3) 10Hashar: Run additional, non-voting lint jobs for mediawiki-vagrant [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/109430 (owner: 10Adamw) [09:54:26] (03CR) 10Siebrand: "How can this me merged with a change to MessagesEn.php? That file doesn't contain a $messages any more." [core] - 10https://gerrit.wikimedia.org/r/124142 (owner: 10Physikerwelt) [09:54:50] thedj: https://gerrit.wikimedia.org/r/#/c/124142/ is a bad merge. [09:55:37] (03CR) 10TTO: "Thanks, Siebrand. Any reason why messages.inc isn't deleted, as it will just get out of date?" [core] - 10https://gerrit.wikimedia.org/r/104182 (owner: 10TTO) [09:55:39] thedj: Oops. no change to $messages. My bad. Ignore htat :) [09:55:46] siebrand: :D [09:56:29] (03PS4) 10Hashar: Run additional, non-voting lint jobs for mediawiki-vagrant [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/109430 (owner: 10Adamw) [09:56:32] (03CR) 10Siebrand: "@TTO some may still be attached to it. See https://gerrit.wikimedia.org/r/#/c/124165/ . For now, I'm going to let it rot." [core] - 10https://gerrit.wikimedia.org/r/104182 (owner: 10TTO) [09:56:57] (03CR) 10Hashar: "Adjusted to use the new jobs defined by https://gerrit.wikimedia.org/r/#/c/109428/" [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/109430 (owner: 10Adamw) [09:57:05] (03CR) 10Siebrand: "Ugh. My bad, there was no change to $messages, but to magic words. Ignore the (other) rambling Dutchman." [core] - 10https://gerrit.wikimedia.org/r/124142 (owner: 10Physikerwelt) [09:57:33] (03CR) 10Hashar: [C: 032] Run additional, non-voting lint jobs for mediawiki-vagrant [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/109430 (owner: 10Adamw) [09:57:43] (03Merged) 10jenkins-bot: Run additional, non-voting lint jobs for mediawiki-vagrant [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/109430 (owner: 10Adamw) [09:57:46] (03CR) 10Hashar: [C: 032] Adds puppet jobs for mediawiki-vagrant [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/109428 (owner: 10Adamw) [09:58:31] (03Merged) 10jenkins-bot: Adds puppet jobs for mediawiki-vagrant [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/109428 (owner: 10Adamw) [09:59:35] (03Restored) 10Hashar: Jenkins job validation (DO NOT SUBMIT) [vagrant] - 10https://gerrit.wikimedia.org/r/57729 (owner: 10Hashar) [09:59:39] (03PS3) 10Hashar: Jenkins job validation (DO NOT SUBMIT) [vagrant] - 10https://gerrit.wikimedia.org/r/57729 [09:59:43] (03CR) 10jenkins-bot: [V: 04-1] Jenkins job validation (DO NOT SUBMIT) [vagrant] - 10https://gerrit.wikimedia.org/r/57729 (owner: 10Hashar) [10:00:15] (03Abandoned) 10Hashar: Jenkins job validation (DO NOT SUBMIT) [vagrant] - 10https://gerrit.wikimedia.org/r/57729 (owner: 10Hashar) [10:00:25] (03PS7) 10TTO: Add extra views (tabs) for files in a foreign repository [core] - 10https://gerrit.wikimedia.org/r/104182 [10:01:19] (03PS1) 10Siebrand: Remove misspelling [core] - 10https://gerrit.wikimedia.org/r/124301 [10:02:03] (03PS2) 10Siebrand: Remove misspelling for ExpandTemplates special page [core] - 10https://gerrit.wikimedia.org/r/124301 [10:02:24] (03CR) 10Siebrand: "Expantemplates misspelling addressed in https://gerrit.wikimedia.org/r/#/c/124301/" [core] - 10https://gerrit.wikimedia.org/r/96810 (owner: 10UltrasonicNXT) [10:03:01] (03CR) 10Siebrand: [C: 031] "i18n/L10n reviewed." [core] - 10https://gerrit.wikimedia.org/r/104182 (owner: 10TTO) [10:06:05] (03CR) 10Siebrand: [C: 031] "i18n/L10n reviewed." [core] - 10https://gerrit.wikimedia.org/r/117438 (owner: 10Bartosz Dziewoński) [10:07:22] (03CR) 10KartikMistry: [C: 032] "Code/Test passes. Debian article passes!" [services/cxserver] - 10https://gerrit.wikimedia.org/r/123596 (owner: 10Santhosh) [10:07:52] (03Merged) 10jenkins-bot: Segmentation: Handle the case of repeated references [services/cxserver] - 10https://gerrit.wikimedia.org/r/123596 (owner: 10Santhosh) [10:08:25] (03PS2) 10Alexander.lehmann: Added error handling to publishing changes. [extensions/PubSubHubbub] - 10https://gerrit.wikimedia.org/r/123227 (owner: 10Nik) [10:09:12] (03CR) 10Siebrand: [C: 031] "i18n/L10n reviewed." [extensions/Persona] - 10https://gerrit.wikimedia.org/r/124129 (owner: 10Stepzhou) [10:09:22] (03CR) 10Bartosz Dziewoński: Remove misspelling for ExpandTemplates special page (031 comment) [core] - 10https://gerrit.wikimedia.org/r/124301 (owner: 10Siebrand) [10:09:46] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/PubSubHubbub] - 10https://gerrit.wikimedia.org/r/123227 (owner: 10Nik) [10:10:08] MatmaRex: What do you mean with https://gerrit.wikimedia.org/r/#/c/124301/2//COMMIT_MSG ? [10:10:37] siebrand: the misspelling is missing a 'd'? [10:10:40] (03CR) 10Alexander.lehmann: [C: 032] Added error handling to publishing changes. [extensions/PubSubHubbub] - 10https://gerrit.wikimedia.org/r/123227 (owner: 10Nik) [10:11:11] (03PS7) 10TheDJ: MathJax: Listen for wikipage.content hook [extensions/Math] - 10https://gerrit.wikimedia.org/r/124064 [10:11:12] MatmaRex: Yes, and with the correct spelling, case changes in the Latin script are basically the same for special page aliases. [10:11:42] siebrand: ah, yes. i misunderstood you, then [10:11:51] https://translatewiki.net/wiki/Special:ExPaNdTeMpLaTeS [10:12:04] yep, i know it works this way :) [10:12:08] MatmaRex: Yeah, thought so. Thought I should clear it up. [10:12:25] (03CR) 10Bartosz Dziewoński: [C: 032] Remove misspelling for ExpandTemplates special page [core] - 10https://gerrit.wikimedia.org/r/124301 (owner: 10Siebrand) [10:14:45] (03PS1) 10Nemo bis: Make enhanced recent changes and extended watchlist default [core] - 10https://gerrit.wikimedia.org/r/124302 [10:15:19] (03CR) 10Bartosz Dziewoński: [C: 032] Misc code formatting cleanup [extensions/Popups] - 10https://gerrit.wikimedia.org/r/123190 (owner: 10Santhosh) [10:15:47] (03Merged) 10jenkins-bot: Remove misspelling for ExpandTemplates special page [core] - 10https://gerrit.wikimedia.org/r/124301 (owner: 10Siebrand) [10:15:58] (03CR) 10Frédéric Wang: [C: 031] MathJax: Listen for wikipage.content hook [extensions/Math] - 10https://gerrit.wikimedia.org/r/124064 (owner: 10TheDJ) [10:16:49] (03Merged) 10jenkins-bot: Misc code formatting cleanup [extensions/Popups] - 10https://gerrit.wikimedia.org/r/123190 (owner: 10Santhosh) [10:20:55] (03CR) 10jenkins-bot: [V: 04-1] Make enhanced recent changes and extended watchlist default [core] - 10https://gerrit.wikimedia.org/r/124302 (owner: 10Nemo bis) [10:24:25] (03CR) 10Bartosz Dziewoński: [C: 04-1] Caption of TOC in page content language instead of user language [core] - 10https://gerrit.wikimedia.org/r/108514 (owner: 10Gerrit Patch Uploader) [10:24:36] (03Abandoned) 10Bartosz Dziewoński: Caption of TOC in page content language instead of user language [core] - 10https://gerrit.wikimedia.org/r/108514 (owner: 10Gerrit Patch Uploader) [10:25:11] (03PS2) 10Nemo bis: Make enhanced recent changes and extended watchlist default [core] - 10https://gerrit.wikimedia.org/r/124302 [10:30:50] (03Abandoned) 10Bartosz Dziewoński: mediawiki.util: Clean up whitespace [core] - 10https://gerrit.wikimedia.org/r/123912 (owner: 10Krinkle) [10:32:08] (03PS1) 10TheDJ: Fix globals in strict mode [extensions/Math] - 10https://gerrit.wikimedia.org/r/124303 [10:39:55] (03PS1) 10Hashar: Initial Composer import (1.0.0-alpha8) [integration/composer] - 10https://gerrit.wikimedia.org/r/124304 [10:40:18] (03CR) 10Frédéric Wang: [C: 032] Fix globals in strict mode [extensions/Math] - 10https://gerrit.wikimedia.org/r/124303 (owner: 10TheDJ) [10:41:31] (03Merged) 10jenkins-bot: Fix globals in strict mode [extensions/Math] - 10https://gerrit.wikimedia.org/r/124303 (owner: 10TheDJ) [10:41:38] (03CR) 10Hashar: [C: 032 V: 032] "Merging to get it deployed on labs slaves" [integration/composer] - 10https://gerrit.wikimedia.org/r/124304 (owner: 10Hashar) [10:44:12] (03CR) 10Hashar: "will be deployed on labs instances with puppet change https://gerrit.wikimedia.org/r/#/c/124305/" [integration/composer] - 10https://gerrit.wikimedia.org/r/124304 (owner: 10Hashar) [10:48:34] (03CR) 10Phuedx: "Overall the changes from PS8 to PS12 look good. See inline for a handful of very minor comments." (034 comments) [extensions/GuidedTour] - 10https://gerrit.wikimedia.org/r/116228 (owner: 10Mattflaschen) [10:52:00] (03PS1) 10Hashar: Replace 'hasTox' label with 'contintLabsSlave' [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/124306 [10:56:03] (03PS1) 10Hashar: Replace 'hasNpm' label with 'contintLabsSlave' [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/124307 [10:56:45] (03CR) 10Hashar: [C: 032] Replace 'hasNpm' label with 'contintLabsSlave' [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/124307 (owner: 10Hashar) [10:56:52] (03CR) 10Hashar: [C: 032] Replace 'hasTox' label with 'contintLabsSlave' [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/124306 (owner: 10Hashar) [10:57:29] (03Merged) 10jenkins-bot: Replace 'hasTox' label with 'contintLabsSlave' [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/124306 (owner: 10Hashar) [10:58:04] (03Merged) 10jenkins-bot: Replace 'hasNpm' label with 'contintLabsSlave' [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/124307 (owner: 10Hashar) [11:11:55] (03PS6) 10Nik: Used a different hook to prevent Link headers from being generated twice. Rewrote test for Link header insertion. [extensions/PubSubHubbub] - 10https://gerrit.wikimedia.org/r/123590 [11:13:04] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/PubSubHubbub] - 10https://gerrit.wikimedia.org/r/123590 (owner: 10Nik) [11:14:00] (03PS7) 10Nik: Used a different hook to prevent Link headers from being generated twice. Rewrote test for Link header insertion. [extensions/PubSubHubbub] - 10https://gerrit.wikimedia.org/r/123590 [11:15:00] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/PubSubHubbub] - 10https://gerrit.wikimedia.org/r/123590 (owner: 10Nik) [11:49:07] (03PS1) 10Hashar: point hhvm stacktraces to workspace log dir [integration/jenkins] - 10https://gerrit.wikimedia.org/r/124313 [11:49:29] (03CR) 10Hashar: [C: 032] point hhvm stacktraces to workspace log dir [integration/jenkins] - 10https://gerrit.wikimedia.org/r/124313 (owner: 10Hashar) [11:49:32] (03Merged) 10jenkins-bot: point hhvm stacktraces to workspace log dir [integration/jenkins] - 10https://gerrit.wikimedia.org/r/124313 (owner: 10Hashar) [11:50:46] (03CR) 10Hashar: "Deployed using git-deploy on tin.eqiad.wmnet" [integration/jenkins] - 10https://gerrit.wikimedia.org/r/124313 (owner: 10Hashar) [12:10:07] (03CR) 10Aude: [C: 032] Changed some comments from /// to /** @var */ [core] - 10https://gerrit.wikimedia.org/r/124167 (owner: 10Umherirrender) [12:13:17] (03Merged) 10jenkins-bot: Changed some comments from /// to /** @var */ [core] - 10https://gerrit.wikimedia.org/r/124167 (owner: 10Umherirrender) [12:14:55] (03PS1) 10KartikMistry: WIP: configure socket.io logs [services/cxserver] - 10https://gerrit.wikimedia.org/r/124315 [12:16:20] (03CR) 10PiRSquared17: "TTO: since this is going nowhere, do you think we should just add to IWM? I'm convinced it would have iw_local set to 1 so my comment abov" [extensions/WikimediaMaintenance] - 10https://gerrit.wikimedia.org/r/112920 (owner: 10Gerrit Patch Uploader) [12:17:29] (03PS2) 10KartikMistry: WIP: configure socket.io logs [services/cxserver] - 10https://gerrit.wikimedia.org/r/124315 [12:25:32] (03CR) 10TTO: "Having thought about it some more, I don't think it matters which way this is done. Meta interwiki map, or dumpInterwiki - much of a muchn" [extensions/WikimediaMaintenance] - 10https://gerrit.wikimedia.org/r/112920 (owner: 10Gerrit Patch Uploader) [12:28:16] (03CR) 10Helder.wiki: Editbutton for math (031 comment) [extensions/Math] - 10https://gerrit.wikimedia.org/r/109923 (owner: 10Physikerwelt) [12:34:34] (03PS1) 10TheDJ: Add dependency for math edit button [extensions/Math] - 10https://gerrit.wikimedia.org/r/124318 [12:35:01] (03CR) 10TheDJ: "Good catch. follow up in https://gerrit.wikimedia.org/r/124318" [extensions/Math] - 10https://gerrit.wikimedia.org/r/109923 (owner: 10Physikerwelt) [12:35:29] (03CR) 10Alexander.lehmann: [C: 032] Used a different hook to prevent Link headers from being generated twice. Rewrote test for Link header insertion. [extensions/PubSubHubbub] - 10https://gerrit.wikimedia.org/r/123590 (owner: 10Nik) [12:36:13] (03CR) 10Aude: "we are still getting segmentation faults in mediawiki-core-regression job" [core] - 10https://gerrit.wikimedia.org/r/124150 (owner: 10Aude) [12:38:48] (03CR) 10Helder.wiki: "This probably makes the "if ( mw.toolbar ) { ... }" unnecessary on" [extensions/Math] - 10https://gerrit.wikimedia.org/r/124318 (owner: 10TheDJ) [12:39:27] (03CR) 10Helder.wiki: "I mean, once the dependency is loaded, it is safe to run mw.toolbar.addButton(...)" [extensions/Math] - 10https://gerrit.wikimedia.org/r/124318 (owner: 10TheDJ) [12:41:39] (03CR) 10Phuedx: [C: 04-1] "Apart from the build failures – I'm not sure that the QUnit failure was caused by this patch set – this looks good. Only a really minor in" (031 comment) [extensions/GuidedTour] - 10https://gerrit.wikimedia.org/r/123171 (owner: 10Mattflaschen) [12:42:21] (03PS1) 10TheDJ: Move betafeatures images into the images dir. [extensions/Math] - 10https://gerrit.wikimedia.org/r/124319 [12:44:38] (03PS2) 10TheDJ: Add dependency for math edit button [extensions/Math] - 10https://gerrit.wikimedia.org/r/124318 [12:48:02] (03CR) 10Helder.wiki: [C: 031] Add dependency for math edit button [extensions/Math] - 10https://gerrit.wikimedia.org/r/124318 (owner: 10TheDJ) [12:55:42] (03PS12) 1001tonythomas: Adding a JS Class to inputBox to grey out Submit button. [extensions/InputBox] - 10https://gerrit.wikimedia.org/r/120487 [13:12:48] (03PS1) 10Matthias Mullie: Use correct limits [extensions/Flow] - 10https://gerrit.wikimedia.org/r/124322 [13:13:52] (03CR) 10Physikerwelt: [C: 032] Move betafeatures images into the images dir. [extensions/Math] - 10https://gerrit.wikimedia.org/r/124319 (owner: 10TheDJ) [13:14:58] (03PS1) 10John F. Lewis: Remove default group assignment [extensions/CheckUser] - 10https://gerrit.wikimedia.org/r/124324 [13:15:03] (03PS3) 10Physikerwelt: Add dependency for math edit button [extensions/Math] - 10https://gerrit.wikimedia.org/r/124318 (owner: 10TheDJ) [13:15:17] (03CR) 10Daniel Kinzler: [C: 032] "Let's try this. Skipping tests is just bad." [core] - 10https://gerrit.wikimedia.org/r/124150 (owner: 10Aude) [13:17:16] (03CR) 10Daniel Kinzler: [C: 032] "Seems to be the right thing. I'll trust Anomie that it works. Would be nice to have test cases..." [core] - 10https://gerrit.wikimedia.org/r/120858 (owner: 10Umherirrender) [13:18:31] (03Merged) 10jenkins-bot: Revert "Temporarily remove tests added in I8eef5a165" [core] - 10https://gerrit.wikimedia.org/r/124150 (owner: 10Aude) [13:18:40] (03CR) 10Physikerwelt: [C: 031] Add dependency for math edit button [extensions/Math] - 10https://gerrit.wikimedia.org/r/124318 (owner: 10TheDJ) [13:19:52] (03Merged) 10jenkins-bot: Allow access to revision deleted wikitext on action=edit [core] - 10https://gerrit.wikimedia.org/r/120858 (owner: 10Umherirrender) [13:24:50] (03CR) 10Matthias Mullie: [C: 04-1] UUID revamp (031 comment) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/123691 (owner: 10Matthias Mullie) [13:25:23] (03CR) 10Lord Farin: [C: 031] Add dependency for math edit button [extensions/Math] - 10https://gerrit.wikimedia.org/r/124318 (owner: 10TheDJ) [13:29:07] (03CR) 10Lord Farin: "The return type of mathTagHook should be updated." (031 comment) [extensions/Math] - 10https://gerrit.wikimedia.org/r/111119 (owner: 10Physikerwelt) [13:34:46] (03PS3) 10KartikMistry: WIP: configure socket.io logs [services/cxserver] - 10https://gerrit.wikimedia.org/r/124315 [13:35:06] (03CR) 10jenkins-bot: [V: 04-1] WIP: configure socket.io logs [services/cxserver] - 10https://gerrit.wikimedia.org/r/124315 (owner: 10KartikMistry) [13:41:23] (03PS4) 10KartikMistry: WIP: configure socket.io logs [services/cxserver] - 10https://gerrit.wikimedia.org/r/124315 [13:42:18] (03PS5) 10KartikMistry: configure socket.io logs [services/cxserver] - 10https://gerrit.wikimedia.org/r/124315 [13:45:51] (03PS1) 10Hashar: Wrapper around tox for Wikimedia Jenkins [extensions/EventLogging] - 10https://gerrit.wikimedia.org/r/124325 [13:46:19] (03CR) 10Hashar: "Should let us add Jenkins jobs for flake8 and py27." [extensions/EventLogging] - 10https://gerrit.wikimedia.org/r/124325 (owner: 10Hashar) [13:56:08] Nemo_bis: change of plans. but if you need me, i'm here now. :P [14:01:38] (03PS1) 10Shirayuki: i18n: consistency tweaks [extensions/Persona] - 10https://gerrit.wikimedia.org/r/124326 [14:04:29] (03CR) 10Phuedx: "Mattflaschen: I think this is blocked on https://bugzilla.wikimedia.org/show_bug.cgi?id=63253." [extensions/GuidedTour] - 10https://gerrit.wikimedia.org/r/121585 (owner: 10Prtksxna) [14:07:08] (03PS1) 10Manybubbles: WIP: Font based segmenter [search/highlighter] - 10https://gerrit.wikimedia.org/r/124327 [14:07:25] (03CR) 10Manybubbles: [C: 04-1] "not done at all. Maybe too slow for actual use." [search/highlighter] - 10https://gerrit.wikimedia.org/r/124327 (owner: 10Manybubbles) [14:08:21] (03CR) 10jenkins-bot: [V: 04-1] WIP: Font based segmenter [search/highlighter] - 10https://gerrit.wikimedia.org/r/124327 (owner: 10Manybubbles) [14:11:11] (03PS1) 10Bartosz Dziewoński: ApiQueryDeletedrevs: Fix getDescription() docs [core] - 10https://gerrit.wikimedia.org/r/124328 [14:11:23] ^ trivial [14:12:41] (03PS1) 10TheDJ: Unmaintained modules were removed from WikiEditor [core] - 10https://gerrit.wikimedia.org/r/124329 [14:15:43] MatmaRex: thanks; no coding this afternoon for me [14:17:14] (03CR) 10Alex Monk: [C: 032] ApiQueryDeletedrevs: Fix getDescription() docs [core] - 10https://gerrit.wikimedia.org/r/124328 (owner: 10Bartosz Dziewoński) [14:20:04] (03Merged) 10jenkins-bot: ApiQueryDeletedrevs: Fix getDescription() docs [core] - 10https://gerrit.wikimedia.org/r/124328 (owner: 10Bartosz Dziewoński) [14:23:55] (03PS1) 10Raimond Spekking: Add modul namespace translation for bg [extensions/Scribunto] - 10https://gerrit.wikimedia.org/r/124330 [14:26:35] (03CR) 10Brian Wolff: [C: 04-1] "Ok. There are 4 parser tests that need to be updated (https://integration.wikimedia.org/ci/job/mediawiki-core-phpunit-parser/22224/console" [core] - 10https://gerrit.wikimedia.org/r/120767 (owner: 10Robert Vogel) [14:26:46] (03PS6) 10KartikMistry: configure socket.io logs [services/cxserver] - 10https://gerrit.wikimedia.org/r/124315 [14:30:15] (03CR) 10Brian Wolff: "They should generally be merged. Most of those extensions use per version branches, and even if we make this now only @deprecated, we shou" [core] - 10https://gerrit.wikimedia.org/r/124130 (owner: 10MaxSem) [14:37:59] (03PS1) 10Nik: Added documentation to main PubSubHubbub class. [extensions/PubSubHubbub] - 10https://gerrit.wikimedia.org/r/124331 [14:38:44] (03CR) 10Alex Monk: "Ugh, why did you have to rebase and make changes in the same PS?" [extensions/InputBox] - 10https://gerrit.wikimedia.org/r/120487 (owner: 1001tonythomas) [14:39:09] (03CR) 10WikidataJenkins: [V: 04-1] "Build Failed" [extensions/PubSubHubbub] - 10https://gerrit.wikimedia.org/r/124331 (owner: 10Nik) [14:39:36] (03CR) 10Alex Monk: "Any reply to my comment about the jshintrc file?" [extensions/InputBox] - 10https://gerrit.wikimedia.org/r/120487 (owner: 1001tonythomas) [14:45:05] (03CR) 10Nemo bis: "Then can someone go on a merge spree please? :) Most extensions' authors welcome technical maintenance/cleanup on their code from "special" [core] - 10https://gerrit.wikimedia.org/r/124130 (owner: 10MaxSem) [14:48:42] (03CR) 10Siebrand: [C: 04-1] "I'd like to see confirmation from someone who's actually done translations into Bulgarian. Kolega2357 has a self-assessed skill level of 1" [extensions/Scribunto] - 10https://gerrit.wikimedia.org/r/124330 (owner: 10Raimond Spekking) [14:53:25] (03CR) 10Siebrand: "Is this added to the core release notes because it's a bundled extension? Is there a policy for this somewhere, because it's new to me, an" [core] - 10https://gerrit.wikimedia.org/r/124329 (owner: 10TheDJ) [14:54:17] (03CR) 10Siebrand: Unmaintained modules were removed from WikiEditor (031 comment) [core] - 10https://gerrit.wikimedia.org/r/124329 (owner: 10TheDJ) [14:54:51] (03CR) 10Siebrand: [C: 032] i18n: consistency tweaks [extensions/Persona] - 10https://gerrit.wikimedia.org/r/124326 (owner: 10Shirayuki) [14:54:55] (03Merged) 10jenkins-bot: i18n: consistency tweaks [extensions/Persona] - 10https://gerrit.wikimedia.org/r/124326 (owner: 10Shirayuki) [14:55:56] Krenair: Hi ! You mean to split the addition of .jshintrc as a new PS right ? [14:56:06] regarding https://gerrit.wikimedia.org/r/#/c/120487/ [14:56:34] I guess. I'm not really sure why it was part of this patch [14:57:25] Krenair: actually, I had to add that file, as that was the first time JS was added into the inputbox extension [14:57:33] anyway, will submit a fresh one for that [14:57:54] (03CR) 10Siebrand: [C: 04-1] Display a warning when the user name looked up is not registered. [core] - 10https://gerrit.wikimedia.org/r/117854 (owner: 10Ganeshaditya1) [14:58:13] tonythomas, okay then, it's probably fine in this PS then [14:58:38] Krenair: ok. Then I will add it to the commit message then [14:59:00] (03CR) 10Manybubbles: "Poke. Anyone mind if I merge this? I know I was the last one to amend it but it was small. Maybe bd808 can test the amend?" [vagrant] - 10https://gerrit.wikimedia.org/r/121425 (owner: 10BryanDavis) [14:59:03] tonythomas, in future, please don't rebase in the same PS as you make other changes [14:59:04] (03PS13) 1001tonythomas: Adding a JS Class to inputBox to grey out Submit button. [extensions/InputBox] - 10https://gerrit.wikimedia.org/r/120487 [14:59:15] (03CR) 10Siebrand: [C: 04-1] "This patch set has to be updated for the JSON based i18n format." [extensions/Drafts] - 10https://gerrit.wikimedia.org/r/88895 (owner: 10Legoktm) [14:59:24] (03CR) 10Siebrand: [C: 04-1] "This patch set has to be updated for the JSON based i18n format." [extensions/SyntaxHighlight_GeSHi] - 10https://gerrit.wikimedia.org/r/114529 (owner: 10Jforrester) [14:59:36] Krenair: oh ! I never knew that could create difficulties. sure [14:59:37] (03CR) 10Siebrand: [C: 04-1] "This patch set has to be updated for the JSON based i18n format." [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/102076 (owner: 10TTO) [14:59:47] (03CR) 10Siebrand: [C: 04-1] "This patch set has to be updated for the JSON based i18n format." [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/77898 (owner: 10Nemo bis) [15:00:03] (03CR) 10Siebrand: [C: 04-1] "This patch set has to be updated for the JSON based i18n format." [core] - 10https://gerrit.wikimedia.org/r/119002 (owner: 10devunt) [15:00:39] (03CR) 10Siebrand: [C: 04-1] "This patch set has to be updated for the JSON based i18n format." [core] - 10https://gerrit.wikimedia.org/r/5130 (owner: 10Joancreus) [15:00:51] (03CR) 10Nemo bis: "I leave that to whoever/whenever wants to merge" [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/77898 (owner: 10Nemo bis) [15:01:07] (03CR) 10Siebrand: [C: 04-1] "This patch set has to be updated for the JSON based i18n format." [extensions/GraphViz] - 10https://gerrit.wikimedia.org/r/111475 (owner: 10Welterkj) [15:01:37] Krenair: The patch looks ok now ? [15:07:10] (03PS2) 10Nik: Added documentation. [extensions/PubSubHubbub] - 10https://gerrit.wikimedia.org/r/124331 [15:09:00] (03PS21) 10Siebrand: Initial implementation of the JSON configuration store. [extensions/JsonConfig] - 10https://gerrit.wikimedia.org/r/98767 (owner: 10Yurik) [15:09:24] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/PubSubHubbub] - 10https://gerrit.wikimedia.org/r/124331 (owner: 10Nik) [15:10:06] (03CR) 10Siebrand: "PS21: Now uses JSON i18n and ran code formatting on this." [extensions/JsonConfig] - 10https://gerrit.wikimedia.org/r/98767 (owner: 10Yurik) [15:10:33] (03CR) 10Alex Monk: [C: 032] Replace usage of SpecialPage::getTitle with getPageTitle [extensions/GlobalBlocking] - 10https://gerrit.wikimedia.org/r/103939 (owner: 10Legoktm) [15:10:37] (03Merged) 10jenkins-bot: Replace usage of SpecialPage::getTitle with getPageTitle [extensions/GlobalBlocking] - 10https://gerrit.wikimedia.org/r/103939 (owner: 10Legoktm) [15:16:45] (03CR) 10Alex Monk: [C: 032] Replace usage of SpecialPage::getTitle with getPageTitle [extensions/DisableAccount] - 10https://gerrit.wikimedia.org/r/103927 (owner: 10Legoktm) [15:16:47] (03CR) 10jenkins-bot: [V: 04-1] Replace usage of SpecialPage::getTitle with getPageTitle [extensions/DisableAccount] - 10https://gerrit.wikimedia.org/r/103927 (owner: 10Legoktm) [15:19:27] (03CR) 10PiRSquared17: "Sounds like a plan, but I don't know the reason for not having these in the interwiki map. Does anyone know? It seems the comment was adde" [extensions/WikimediaMaintenance] - 10https://gerrit.wikimedia.org/r/112920 (owner: 10Gerrit Patch Uploader) [15:20:00] (03Abandoned) 10Alex Monk: Replace usage of SpecialPage::getTitle with getPageTitle [extensions/DisableAccount] - 10https://gerrit.wikimedia.org/r/103927 (owner: 10Legoktm) [15:22:31] (03CR) 10BryanDavis: "manybubbles: It looks good to me. Ori probably got distracted by other shiny things before merging, but you might poke him to see if he st" [vagrant] - 10https://gerrit.wikimedia.org/r/121425 (owner: 10BryanDavis) [15:22:46] (03CR) 10Alex Monk: [C: 032] Replace usage of SpecialPage::getTitle with getPageTitle [extensions/DeleteBatch] - 10https://gerrit.wikimedia.org/r/103926 (owner: 10Legoktm) [15:22:48] (03Merged) 10jenkins-bot: Replace usage of SpecialPage::getTitle with getPageTitle [extensions/DeleteBatch] - 10https://gerrit.wikimedia.org/r/103926 (owner: 10Legoktm) [15:30:24] (03PS1) 10Bartosz Dziewoński: Rewrite getParamInfo() to actually handle caching and continuation [extensions/ApiSandbox] - 10https://gerrit.wikimedia.org/r/124334 [15:30:29] (03PS1) 10TheDJ: Fix broken span of label in WikiEditor toolbar [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/124335 [15:30:36] (03PS1) 10Nik: Added license file. [extensions/PubSubHubbub] - 10https://gerrit.wikimedia.org/r/124336 [15:31:23] (03CR) 10Nik: [C: 032 V: 032] Added license file. [extensions/PubSubHubbub] - 10https://gerrit.wikimedia.org/r/124336 (owner: 10Nik) [15:31:56] (03CR) 10WikidataJenkins: "Build Successful" [extensions/PubSubHubbub] - 10https://gerrit.wikimedia.org/r/124336 (owner: 10Nik) [15:32:55] (03PS2) 10TheDJ: Fix broken span of label in WikiEditor toolbar [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/124335 [15:36:33] (03PS1) 10Amire80: Change the text in the preferences to "trying this feature" [extensions/BetaFeatures] - 10https://gerrit.wikimedia.org/r/124337 [15:40:28] (03PS1) 10TheDJ: Toolbar: use CSS instead of valign on toolbar table [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/124338 [15:44:42] (03PS1) 10Cmcmahon: Only run this test locally [extensions/Flow] - 10https://gerrit.wikimedia.org/r/124339 [15:46:19] (03CR) 10Rillke: "Any reply to my comment about the jshintrc file?" [extensions/InputBox] - 10https://gerrit.wikimedia.org/r/120487 (owner: 1001tonythomas) [15:47:10] (03PS22) 10Siebrand: Initial implementation of the JSON configuration store. [extensions/JsonConfig] - 10https://gerrit.wikimedia.org/r/98767 (owner: 10Yurik) [15:47:13] (03CR) 10Jforrester: [C: 032] Change the text in the preferences to "trying this feature" [extensions/BetaFeatures] - 10https://gerrit.wikimedia.org/r/124337 (owner: 10Amire80) [15:47:19] (03Merged) 10jenkins-bot: Change the text in the preferences to "trying this feature" [extensions/BetaFeatures] - 10https://gerrit.wikimedia.org/r/124337 (owner: 10Amire80) [15:47:37] (03CR) 10Siebrand: "PS22 fixes some formatter screw-ups." [extensions/JsonConfig] - 10https://gerrit.wikimedia.org/r/98767 (owner: 10Yurik) [15:50:45] (03CR) 10Siebrand: [C: 04-1] "Please fix code sniffer warnings." (032 comments) [core] - 10https://gerrit.wikimedia.org/r/118798 (owner: 10Pubudu538) [15:51:42] (03CR) 1001tonythomas: "@Rilike:- We discussed over that in IRC. Since its the first time the extension is using JS, a separate PS is not needed ." [extensions/InputBox] - 10https://gerrit.wikimedia.org/r/120487 (owner: 1001tonythomas) [15:56:07] (03PS1) 10Matthias Mullie: (bug 63616) incorrect topic timestamp [extensions/Flow] - 10https://gerrit.wikimedia.org/r/124342 [16:01:27] (03PS1) 10Manybubbles: Prefer title for prefix search match [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/124344 [16:01:48] (03PS3) 10Alexander.lehmann: Added documentation. [extensions/PubSubHubbub] - 10https://gerrit.wikimedia.org/r/124331 (owner: 10Nik) [16:02:37] (03CR) 10Manybubbles: "If this looks good I'd like to see if I can backport it and get it out during a swat deploy because it is causing trouble on itwiki." [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/124344 (owner: 10Manybubbles) [16:03:00] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/PubSubHubbub] - 10https://gerrit.wikimedia.org/r/124331 (owner: 10Nik) [16:03:41] (03PS9) 1001tonythomas: Error Msg for missing db username & password when installing [core] - 10https://gerrit.wikimedia.org/r/118798 (owner: 10Pubudu538) [16:04:08] (03PS8) 10TheDJ: MathJax: Listen for wikipage.content hook [extensions/Math] - 10https://gerrit.wikimedia.org/r/124064 [16:06:00] (03CR) 10Frédéric Wang: [C: 032] MathJax: Listen for wikipage.content hook [extensions/Math] - 10https://gerrit.wikimedia.org/r/124064 (owner: 10TheDJ) [16:07:07] (03Merged) 10jenkins-bot: MathJax: Listen for wikipage.content hook [extensions/Math] - 10https://gerrit.wikimedia.org/r/124064 (owner: 10TheDJ) [16:07:10] siebrand: I split the lines as per your comment. Do those look good ? https://gerrit.wikimedia.org/r/#/c/118798/9/includes/installer/MysqlInstaller.php [16:09:49] tonythomas: I'd make that" $newValues = $this->setVarsFromRequest( array( \n elements \n ) ); [16:10:03] (03PS4) 10Alexander.lehmann: Added documentation. [extensions/PubSubHubbub] - 10https://gerrit.wikimedia.org/r/124331 (owner: 10Nik) [16:10:28] siebrand: ok. Will do that [16:10:35] tonythomas: Thank you. [16:10:54] siebrand: :) no probs [16:11:00] (03CR) 10Bartosz Dziewoński: [C: 032] Toolbar: use CSS instead of valign on toolbar table [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/124338 (owner: 10TheDJ) [16:11:03] (03Merged) 10jenkins-bot: Toolbar: use CSS instead of valign on toolbar table [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/124338 (owner: 10TheDJ) [16:11:05] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/PubSubHubbub] - 10https://gerrit.wikimedia.org/r/124331 (owner: 10Nik) [16:17:43] MatmaRex: re https://bugzilla.wikimedia.org/63535 : can I provide more debug info? [16:17:57] liangent: hah, i was just commenting [16:18:06] liangent: "Is the browser console for JavaScript (Ctrl+Shift+J) displaying anything interesting?" [16:19:48] MatmaRex: good question. it says "TypeError: mw.beta is undefined defaultTracking.js:5" [16:20:04] I assume it prevents javascript code from being executed [16:20:56] (03CR) 10Bartosz Dziewoński: Fix broken span of label in WikiEditor toolbar (031 comment) [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/124335 (owner: 10TheDJ) [16:21:31] liangent: huh. yeah, it probably stops anything else from running… i wonder what mw.beta is [16:21:44] or, in fact, wtf is defaultTracking [16:22:31] liangent: does the console link you to the actual file that errors out? [16:23:12] MatmaRex: see https://bugzilla.wikimedia.org/show_bug.cgi?id=63535#c5 [16:23:15] https://bits.wikimedia.org/static-1.23wmf20/extensions/VectorBeta/resources/compactPersonalBar/defaultTracking.js [16:23:33] I modified that bug accordingly [16:24:09] liangent: yay, thank you [16:24:48] (03PS1) 10Anomie: Stringify numbers in frame:callParserFunction [extensions/Scribunto] - 10https://gerrit.wikimedia.org/r/124346 [16:26:45] (03PS10) 10Alex Monk: Add auto-save feature for edit textareas, via localStorage [core] - 10https://gerrit.wikimedia.org/r/5130 (owner: 10Joancreus) [16:28:01] (03CR) 10Alex Monk: [C: 04-1] "This is a rebase, carrying over Timo's -1 from PS9" [core] - 10https://gerrit.wikimedia.org/r/5130 (owner: 10Joancreus) [16:28:03] (03PS1) 10Dan-nl: protect community member or bot added content [extensions/GWToolset] - 10https://gerrit.wikimedia.org/r/124347 [16:33:28] (03CR) 10jenkins-bot: [V: 04-1] Add auto-save feature for edit textareas, via localStorage [core] - 10https://gerrit.wikimedia.org/r/5130 (owner: 10Joancreus) [16:33:35] (03PS11) 10Alex Monk: Add auto-save feature for edit textareas, via localStorage [core] - 10https://gerrit.wikimedia.org/r/5130 (owner: 10Joancreus) [16:38:05] (03PS10) 1001tonythomas: Error Msg for missing db username & password when installing [core] - 10https://gerrit.wikimedia.org/r/118798 (owner: 10Pubudu538) [16:39:51] siebrand: https://gerrit.wikimedia.org/r/#/c/118798/10/includes/installer/MysqlInstaller.php looks good ? [16:40:15] (03CR) 10jenkins-bot: [V: 04-1] Add auto-save feature for edit textareas, via localStorage [core] - 10https://gerrit.wikimedia.org/r/5130 (owner: 10Joancreus) [16:41:51] (03CR) 10Alex Monk: "recheck" [core] - 10https://gerrit.wikimedia.org/r/5130 (owner: 10Joancreus) [16:42:21] tonythomas: 104 appears to have 1 ident too many, 105 has two too many, i.e. 105 has the level of 103, 104 should have one more. [16:42:46] tonythomas: Same on PostgresInstaller.php [16:44:08] (03PS1) 10Dan-nl: fix inconsistency in GWToolset directory reference [extensions/GWToolset] - 10https://gerrit.wikimedia.org/r/124351 [16:44:25] siebrand: will check that out [16:44:35] (03CR) 10Siebrand: "You can remove messages.inc from the patch set. It's no longer maintained." [core] - 10https://gerrit.wikimedia.org/r/5130 (owner: 10Joancreus) [16:45:07] (03CR) 10Siebrand: [C: 032] fix inconsistency in GWToolset directory reference [extensions/GWToolset] - 10https://gerrit.wikimedia.org/r/124351 (owner: 10Dan-nl) [16:45:11] (03Merged) 10jenkins-bot: fix inconsistency in GWToolset directory reference [extensions/GWToolset] - 10https://gerrit.wikimedia.org/r/124351 (owner: 10Dan-nl) [16:46:13] (03CR) 10Siebrand: [C: 031] "i18n/L10n reviewed." [core] - 10https://gerrit.wikimedia.org/r/5130 (owner: 10Joancreus) [16:47:39] (03PS11) 1001tonythomas: Error Msg for missing db username & password when installing [core] - 10https://gerrit.wikimedia.org/r/118798 (owner: 10Pubudu538) [16:48:19] siebrand: done ! [16:52:32] (03PS1) 10TheDJ: Fix infinite spinner in JS version of show changes [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/124352 [16:54:53] (03CR) 10Aaron Schulz: [C: 04-1] Move OAuth logs to another wiki (031 comment) [extensions/OAuth] - 10https://gerrit.wikimedia.org/r/122867 (owner: 10CSteipp) [16:55:55] (03CR) 10Siebrand: [C: 032] Error Msg for missing db username & password when installing [core] - 10https://gerrit.wikimedia.org/r/118798 (owner: 10Pubudu538) [16:59:00] (03Merged) 10jenkins-bot: Error Msg for missing db username & password when installing [core] - 10https://gerrit.wikimedia.org/r/118798 (owner: 10Pubudu538) [17:00:00] (03CR) 10Siebrand: "Why "try" and not "use"? Somehow that looks more positive to me. We're suffering from very cautious, wordy, and marketing scared wording." [extensions/BetaFeatures] - 10https://gerrit.wikimedia.org/r/124337 (owner: 10Amire80) [17:01:52] (03PS9) 10Wctaiwan: Implement a redirector at Special:Flow [extensions/Flow] - 10https://gerrit.wikimedia.org/r/121306 [17:02:01] (03CR) 10Amire80: "Because "users using" doesn't sounds so nice in English and even worse in some other languages." [extensions/BetaFeatures] - 10https://gerrit.wikimedia.org/r/124337 (owner: 10Amire80) [17:08:37] MatmaRex: and the driver to merge release-notes across releases? [17:08:38] (03PS16) 10Liangent: Support multiple collations at the same time [core] - 10https://gerrit.wikimedia.org/r/87288 [17:08:51] (03CR) 10Siebrand: "Than make it sounds less like they're on drugs and treat them as people? :)" [extensions/BetaFeatures] - 10https://gerrit.wikimedia.org/r/124337 (owner: 10Amire80) [17:09:33] liangent: hmm? [17:09:40] (03CR) 10Siebrand: [C: 031] "i18n/L10n reviewed." [extensions/Flow] - 10https://gerrit.wikimedia.org/r/121306 (owner: 10Wctaiwan) [17:09:57] liangent: i assume you're talking about https://github.com/MatmaRex/mediawikireleasenotes-driver ? [17:10:09] (03CR) 10Anomie: [C: 04-1] "Ugh, hacks. The way this really should work is that LocalSettings.php should just unset( $wgFilterLogTypes['patrol'] ) if it turns off $wg" (033 comments) [core] - 10https://gerrit.wikimedia.org/r/42279 (owner: 10Brian Wolff) [17:10:10] MatmaRex: ya [17:10:31] MatmaRex: It seems not working for release note conflicts across releases? [17:10:35] liangent: then i'm afraid git doesn't let you do that - if you have two separate files, you have no way to make git run your merge driver for them [17:10:39] ex https://gerrit.wikimedia.org/r/#/c/87273/ [17:10:44] or at least i haven't found any [17:11:20] i tried to mess around with git's rename detection, to make it think that RELEASE-NOTES-1.22 and RELEASE-NOTES-1.23 are actually the same file, but renamed, but didn't come up with anything that would work [17:12:32] MatmaRex: hm ok [17:13:31] (03CR) 10Siebrand: "You can safely remove the changes in messages.inc. The file is no longer maintained after the change to JSON based i18n." [core] - 10https://gerrit.wikimedia.org/r/87288 (owner: 10Liangent) [17:13:39] liangent: if you come up with a way i'd love to hear it :) [17:14:02] MatmaRex: I don't think I know git better than you [17:14:05] (03CR) 10Bartosz Dziewoński: [C: 04-1] "Behavior looks good to me, left some minor inline comments on the code. Thanks for working on this!" (038 comments) [core] - 10https://gerrit.wikimedia.org/r/121975 (owner: 10Ganeshaditya1) [17:14:18] I don't even know how to write a merge driver [17:15:20] neither did i until i spent way too much time deciphering the docs ;) [17:15:39] (03PS7) 10Liangent: Make zh@collation=pinyin and zh@collation=stroke collations usable [core] - 10https://gerrit.wikimedia.org/r/87273 [17:17:54] (03PS17) 10Liangent: Support multiple collations at the same time [core] - 10https://gerrit.wikimedia.org/r/87288 [17:23:42] (03PS2) 10Dan-nl: protect community member or bot added content [extensions/GWToolset] - 10https://gerrit.wikimedia.org/r/124347 [17:24:21] (03CR) 10Dan-nl: "* up’ed the required version to 1.23c" [extensions/GWToolset] - 10https://gerrit.wikimedia.org/r/124347 (owner: 10Dan-nl) [17:26:01] (03PS1) 10Bartosz Dziewoński: SimpleCaptcha: Move the equals sign inside the