[00:06:12] Hi Krinkle , can you please review this. https://gerrit.wikimedia.org/r/123836 [00:10:20] oops got dc [00:16:48] (03CR) 10Krinkle: [C: 04-1] "I haven't reviewed the server-side logic introduced in this proposed change extensively, but there's a few problems:" [extensions/LiquidThreads] - 10https://gerrit.wikimedia.org/r/123836 (owner: 10Adi.iiita) [00:23:01] (03PS7) 10Aaron Schulz: [WIP] Added VirtualRESTServiceClient/VirtualRESTService classes [core] - 10https://gerrit.wikimedia.org/r/110129 [00:35:12] (03PS12) 10Worden.lee: Refactor Special:Upload for extensibility [core] - 10https://gerrit.wikimedia.org/r/67173 [00:36:15] (03CR) 10jenkins-bot: [V: 04-1] Refactor Special:Upload for extensibility [core] - 10https://gerrit.wikimedia.org/r/67173 (owner: 10Worden.lee) [00:40:17] greg-g: ping? [00:52:26] (03PS1) 10EBernhardson: Only you can prevent logspam [extensions/Flow] - 10https://gerrit.wikimedia.org/r/124039 [00:56:16] (03CR) 10Manybubbles: [C: 031] "Makes sense to me." [extensions/GeoData] - 10https://gerrit.wikimedia.org/r/124008 (owner: 10MaxSem) [00:56:39] Hi [00:56:51] hexmode: Hi, you there? [00:56:56] is there a channel for the typography saga? [00:57:12] zeek_: I keep missing you [00:57:29] hexmode: Now, you wont. [00:57:32] :) [00:57:33] (03CR) 10Manybubbles: [C: 031] Use indexed bounding box [extensions/GeoData] - 10https://gerrit.wikimedia.org/r/124017 (owner: 10MaxSem) [00:57:54] hexmode: Sent a mail to you, please see [00:57:57] Edokter: there is a #wikimedia-design it seems [00:58:29] Edokter: not sure how many designers will be there right now though [00:59:09] hmm, not many... [00:59:32] still, something is brewing, jon just disable Liberation Sans on enwiki [01:01:35] . [01:05:15] * zeek_ is checking if I am connected [01:06:29] zeek_: reply sent. [01:06:36] onto another email now! [01:06:37] hexmode: Seen [01:09:45] (03CR) 10EBernhardson: Implement a redirector at Special:Flow (034 comments) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/121306 (owner: 10Wctaiwan) [01:10:33] (03PS1) 10Hoo man: Check for conflicting blocks after sanitizing the range [extensions/GlobalBlocking] - 10https://gerrit.wikimedia.org/r/124041 [01:15:35] goodnight [01:18:39] (03PS1) 10Hoo man: Respect "Block anonymous users only" for the local block as well [extensions/GlobalBlocking] - 10https://gerrit.wikimedia.org/r/124042 [01:22:10] hexmode: Added disable. [01:22:16] :) [01:23:56] (03PS4) 10Adi.iiita: LQT should not accept duplicate post [extensions/LiquidThreads] - 10https://gerrit.wikimedia.org/r/123836 [01:25:23] hexmode: ^ [01:25:57] yeah, I want to give Krinkle a chance to respond [01:26:19] Sure :) [01:27:08] What can I do next? [01:28:00] (03PS13) 10Worden.lee: Refactor Special:Upload for extensibility [core] - 10https://gerrit.wikimedia.org/r/67173 [01:29:12] (03CR) 10MarkAHershberger: [C: 031] "Krinkle, you make a good point about handling this on the browser side." [extensions/LiquidThreads] - 10https://gerrit.wikimedia.org/r/123836 (owner: 10Adi.iiita) [01:30:12] zeek_: For now, look at other LQT bugs. There are a few and every little bit helps. [01:30:25] Ok sure [01:31:07] zeek_: I did talk to Jamie "Mr. WikiApiary" but he is busy on vacation. :( I haven't had time to look at the bot code by myself yet. [01:32:40] (03CR) 10Worden.lee: "Patch set 13 is patch set 11, rebased and with very minor changes. Review would be very much appreciated - thanks!" [core] - 10https://gerrit.wikimedia.org/r/67173 (owner: 10Worden.lee) [01:33:28] hexmode: Ya, wish he was here. Can you guide me (or route me to someone) on working with PyWikiBot. I looked into it and I think I need a bot edit privilege on a wiki.. [01:34:12] zeek_: I can give you bot edit privs, but can you try working with a local wiki initally? [01:36:35] I want to do the same. I was asking for that in IRC but couldn't get much info that time. [01:36:56] Let me setup it and I'll get back to you. [01:37:40] hexmode: https://bugzilla.wikimedia.org/show_bug.cgi?id=63557 [01:37:44] reported [01:37:46] zeek_: just fyi, I'm glad you're adept enough to ask others for help in IRC when I'm not around. :) [01:38:05] zeek_: very wiki -- WP:BOLD [01:39:04] Thanks, now I think that time pywikibot people may be mostly AFK cause I work at odd time ^_^ [01:40:02] zeek_: I was working with someone in Australia and had to stay up late when I started on wiki stuff, so I know your pain. [01:41:39] hexmode: Yea, for me I have college in day so get only nights to work. [01:59:32] (03PS2) 10AndyRussG: WIP Domain layer and DB persistence with data mapper [extensions/Campaigns] (wip/editorcampaigns) - 10https://gerrit.wikimedia.org/r/123781 [02:06:07] (03CR) 10AalekhN: "This patch set awaits review , please review it." [extensions/ConfirmEdit] - 10https://gerrit.wikimedia.org/r/122126 (owner: 10AalekhN) [02:35:03] (03PS12) 10TTO: Allow additional interwiki prefixes on local interwiki links [core] - 10https://gerrit.wikimedia.org/r/113329 [02:36:13] mediawiki.org is missing interface messages again. [03:02:11] (03PS1) 10Robmoen: Fix documentation typo [core] - 10https://gerrit.wikimedia.org/r/124045 [03:11:16] (03PS4) 10AalekhN: Pass correct parameter to stat() in checkImages.php [core] - 10https://gerrit.wikimedia.org/r/117027 [03:28:52] Hi! did the i18n files of mediawiki.org got screwed up ? check https://www.mediawiki.org/wiki/MediaWiki [03:29:19] i see a lot of <whatlinkshere> [03:30:09] StevenW: am now [03:30:15] hexmode: pong [03:38:06] (03CR) 10Chad: [C: 04-1] Strip citation links (like [1], [2], etc) from HTML (031 comment) [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/123878 (owner: 10Chad) [03:38:33] (03CR) 10Chad: [C: 032] Use indexed bounding box [extensions/GeoData] - 10https://gerrit.wikimedia.org/r/124017 (owner: 10MaxSem) [03:38:42] (03Merged) 10jenkins-bot: Use indexed bounding box [extensions/GeoData] - 10https://gerrit.wikimedia.org/r/124017 (owner: 10MaxSem) [03:41:28] what version of mediawiki was {{#ifsubst:}} introduced and is there any documentation on it? [03:43:39] (03CR) 10Chad: Add support for the experimental highlighter (031 comment) [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/123885 (owner: 10Manybubbles) [05:28:30] (03PS1) 10Deepali: Populate metadata fields in navbar [extensions/BookManagerv2] - 10https://gerrit.wikimedia.org/r/124047 [05:37:48] (03PS5) 10Deepali: Display field "requiredness" on form [core] - 10https://gerrit.wikimedia.org/r/116230 [05:38:40] (03CR) 10Deepali: "Removed "Fix previous patches" from commit message." [core] - 10https://gerrit.wikimedia.org/r/116230 (owner: 10Deepali) [05:43:14] (03CR) 10EBernhardson: Fix a few bugs where Flow was not working on pristine pages. (031 comment) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/123812 (owner: 10Werdna) [06:11:27] (03PS3) 10AndyRussG: WIP Domain layer and DB persistence with data mapper [extensions/Campaigns] (wip/editorcampaigns) - 10https://gerrit.wikimedia.org/r/123781 [06:36:41] (03CR) 10Legoktm: Fix a few bugs where Flow was not working on pristine pages. (031 comment) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/123812 (owner: 10Werdna) [06:40:32] (03CR) 10Legoktm: API: Remove 'flowaction' parameter from list=flow (031 comment) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/123174 (owner: 10Legoktm) [06:58:53] (03PS1) 10IAlex: Fix usage of $wgDebugDumpSql [core] - 10https://gerrit.wikimedia.org/r/124048 [06:59:59] (03CR) 10IAlex: [C: 032] Fix documentation typo [core] - 10https://gerrit.wikimedia.org/r/124045 (owner: 10Robmoen) [07:03:01] (03Merged) 10jenkins-bot: Fix documentation typo [core] - 10https://gerrit.wikimedia.org/r/124045 (owner: 10Robmoen) [07:11:50] hey IAlex still exists [07:27:17] (03PS18) 10Tpt: Addition of a parser test for page= parameter of image inclusion [core] - 10https://gerrit.wikimedia.org/r/102475 [07:33:46] (03CR) 10jenkins-bot: [V: 04-1] Addition of a parser test for page= parameter of image inclusion [core] - 10https://gerrit.wikimedia.org/r/102475 (owner: 10Tpt) [07:39:09] (03PS19) 10Tpt: Addition of a parser test for page= parameter of image inclusion [core] - 10https://gerrit.wikimedia.org/r/102475 [07:45:17] (03CR) 10jenkins-bot: [V: 04-1] Addition of a parser test for page= parameter of image inclusion [core] - 10https://gerrit.wikimedia.org/r/102475 (owner: 10Tpt) [07:58:00] (03PS7) 10Physikerwelt: Fix MathJax centers equations [extensions/Math] - 10https://gerrit.wikimedia.org/r/119010 [08:00:23] (03PS20) 10Tpt: Addition of a parser test for page= parameter of image inclusion [core] - 10https://gerrit.wikimedia.org/r/102475 [08:06:21] (03CR) 10jenkins-bot: [V: 04-1] Addition of a parser test for page= parameter of image inclusion [core] - 10https://gerrit.wikimedia.org/r/102475 (owner: 10Tpt) [08:10:36] (03PS21) 10Tpt: Addition of a parser test for page= parameter of image inclusion [core] - 10https://gerrit.wikimedia.org/r/102475 [08:49:38] (03PS2) 10Gerrit Patch Uploader: Use hasOwnProperty to allow hooks with name of predefined methods [core] - 10https://gerrit.wikimedia.org/r/123856 [08:49:40] (03CR) 10Gerrit Patch Uploader: "This commit was uploaded using the Gerrit Patch Uploader [1]." [core] - 10https://gerrit.wikimedia.org/r/123856 (owner: 10Gerrit Patch Uploader) [08:51:31] (03CR) 10Fomafix: Use hasOwnProperty to allow hooks with name of predefined methods (031 comment) [core] - 10https://gerrit.wikimedia.org/r/123856 (owner: 10Gerrit Patch Uploader) [08:55:30] (03PS8) 10Physikerwelt: Fix MathJax centers equations [extensions/Math] - 10https://gerrit.wikimedia.org/r/119010 [09:04:22] (03CR) 10Physikerwelt: "Hi Frédéric," [extensions/Math] - 10https://gerrit.wikimedia.org/r/119010 (owner: 10Physikerwelt) [09:07:51] (03CR) 10Siebrand: [C: 032] Fix some minor HTML issues [extensions/GWToolset] - 10https://gerrit.wikimedia.org/r/124012 (owner: 10Brian Wolff) [09:07:58] (03Merged) 10jenkins-bot: Fix some minor HTML issues [extensions/GWToolset] - 10https://gerrit.wikimedia.org/r/124012 (owner: 10Brian Wolff) [09:08:09] (03PS1) 10IAlex: Correctly order AutoLoader class definitions [core] - 10https://gerrit.wikimedia.org/r/124051 [09:19:59] (03CR) 10Frédéric Wang: "Thanks." (033 comments) [extensions/Math] - 10https://gerrit.wikimedia.org/r/119010 (owner: 10Physikerwelt) [09:24:59] (03CR) 10Nikerabbit: [C: 032] Correctly order AutoLoader class definitions [core] - 10https://gerrit.wikimedia.org/r/124051 (owner: 10IAlex) [09:27:51] (03CR) 10jenkins-bot: [V: 04-1] Correctly order AutoLoader class definitions [core] - 10https://gerrit.wikimedia.org/r/124051 (owner: 10IAlex) [09:28:21] Hi! Nemo_bis [09:28:24] You around ? [09:46:38] (03CR) 10Siebrand: [C: 031] "i18n/L10n reviewed." [core] - 10https://gerrit.wikimedia.org/r/111096 (owner: 10Jackmcbarn) [09:47:27] tonythomas: no [09:50:12] (03CR) 10Siebrand: [C: 031] "i18n/L10n reviewed." [extensions/InputBox] - 10https://gerrit.wikimedia.org/r/97559 (owner: 10Jackmcbarn) [09:50:58] (03CR) 10TheDJ: "i like where this is going, i'm only slightly concerned with prepending display style... Does that happen only in display: block or in mis" (032 comments) [extensions/Math] - 10https://gerrit.wikimedia.org/r/119010 (owner: 10Physikerwelt) [09:58:12] (03PS1) 10TheDJ: Reset the fontstack of mathjax back to defaults [extensions/Math] - 10https://gerrit.wikimedia.org/r/124055 [09:58:27] (03CR) 10Siebrand: [C: 031] "i18n/L10n reviewed." [core] - 10https://gerrit.wikimedia.org/r/123837 (owner: 10Konarak) [10:00:29] (03CR) 10Siebrand: [C: 04-1] "See my request for a screenshot." [extensions/Flow] - 10https://gerrit.wikimedia.org/r/123216 (owner: 10Matthias Mullie) [10:05:28] (03CR) 10Frédéric Wang: "> i'm only slightly concerned with prepending display style... Does that happen only in display: block or in missing display attribute as " [extensions/Math] - 10https://gerrit.wikimedia.org/r/119010 (owner: 10Physikerwelt) [10:09:18] Nemo_bis: ok. catch ya later [10:09:42] (03CR) 10Lord Farin: Fix MathJax centers equations (032 comments) [extensions/Math] - 10https://gerrit.wikimedia.org/r/119010 (owner: 10Physikerwelt) [10:13:06] (03CR) 10Frédéric Wang: Fix MathJax centers equations (031 comment) [extensions/Math] - 10https://gerrit.wikimedia.org/r/119010 (owner: 10Physikerwelt) [10:15:22] (03CR) 10TheDJ: "it seems we lost the color and cancel Tex extensions in this change" [extensions/Math] - 10https://gerrit.wikimedia.org/r/109490 (owner: 10Physikerwelt) [10:17:52] (03CR) 10Physikerwelt: "thanks for your feedback." [extensions/Math] - 10https://gerrit.wikimedia.org/r/119010 (owner: 10Physikerwelt) [10:21:38] (03CR) 10Frédéric Wang: "> it seems we lost the color and cancel Tex extensions in this change" [extensions/Math] - 10https://gerrit.wikimedia.org/r/109490 (owner: 10Physikerwelt) [10:27:47] (03CR) 10Frédéric Wang: "I'm not sure about the MediaWiki API, but that might be possible." [extensions/Math] - 10https://gerrit.wikimedia.org/r/119010 (owner: 10Physikerwelt) [10:41:19] (03PS12) 10TheDJ: [WIP] Additional CodeEditor buttons [extensions/CodeEditor] - 10https://gerrit.wikimedia.org/r/104512 [10:41:21] (03CR) 10jenkins-bot: [V: 04-1] [WIP] Additional CodeEditor buttons [extensions/CodeEditor] - 10https://gerrit.wikimedia.org/r/104512 (owner: 10TheDJ) [10:48:23] (03CR) 10Lord Farin: "I'm not familiar with the intricacies of calling MathJax through its API, but I'm sure there are options that can be used to discern betwe" (031 comment) [extensions/Math] - 10https://gerrit.wikimedia.org/r/119010 (owner: 10Physikerwelt) [10:53:51] (03PS6) 10TheDJ: Improve the CodeEditor toolbar [extensions/CodeEditor] - 10https://gerrit.wikimedia.org/r/118993 [10:58:57] (03CR) 10Physikerwelt: "Do you think the css change should go into this commit?" (038 comments) [extensions/Math] - 10https://gerrit.wikimedia.org/r/119010 (owner: 10Physikerwelt) [11:00:50] (03PS7) 10TheDJ: Improve the CodeEditor toolbar [extensions/CodeEditor] - 10https://gerrit.wikimedia.org/r/118993 [11:01:48] i hate dependencies [11:21:51] (03PS9) 10Physikerwelt: Fix MathJax centers equations [extensions/Math] - 10https://gerrit.wikimedia.org/r/119010 [11:25:57] (03CR) 10Physikerwelt: "Frédéric:" [extensions/Math] - 10https://gerrit.wikimedia.org/r/119010 (owner: 10Physikerwelt) [11:26:24] (03PS10) 10Physikerwelt: Fix MathJax centers equations [extensions/Math] - 10https://gerrit.wikimedia.org/r/119010 [11:34:25] (03CR) 10Physikerwelt: [C: 031] "Is there an option that this change could cause inconstencies if users have installed differnt fonts on their local systems. I think this " [extensions/Math] - 10https://gerrit.wikimedia.org/r/124055 (owner: 10TheDJ) [11:35:32] (03PS8) 10TheDJ: Improve the CodeEditor toolbar [extensions/CodeEditor] - 10https://gerrit.wikimedia.org/r/118993 [11:41:48] (03PS13) 10TheDJ: [WIP] Additional CodeEditor buttons [extensions/CodeEditor] - 10https://gerrit.wikimedia.org/r/104512 [11:46:47] (03CR) 10TheDJ: "Yes, if Stix get updated, but people keep using the old version on their local machine for instance. But if this is what the community wan" [extensions/Math] - 10https://gerrit.wikimedia.org/r/124055 (owner: 10TheDJ) [11:49:37] physikerwelt: i'd really like that class in this patch please. or i'd like to have the follow up in gerrit. [11:50:35] basically, whatever is needed to approve them in one go [11:54:24] thedj OK I'll add them... the closer we get to math2.0 the better [11:55:00] physikerwelt: the edit button, the only problem outstanding is the icon in the addToToolbar right ? That's it. [11:55:17] (03CR) 10Physikerwelt: [C: 032] "ok... but I won't handle the bug reports on how to set up local fonts" [extensions/Math] - 10https://gerrit.wikimedia.org/r/124055 (owner: 10TheDJ) [11:55:45] ^^yes [11:55:55] looking [11:56:28] (03Merged) 10jenkins-bot: Reset the fontstack of mathjax back to defaults [extensions/Math] - 10https://gerrit.wikimedia.org/r/124055 (owner: 10TheDJ) [11:57:33] physikerwelt: but i think it might not be supported [11:58:12] ok but there might be option to get the localized messages in javascript [11:59:06] are you looking at this place https://gerrit.wikimedia.org/r/#/c/109493/2/includes/EditPage.php [12:02:30] https://gerrit.wikimedia.org/r/#/c/109923/ [12:03:09] i'll make some JS to load the button from an alternate location [12:03:15] depending on contentlanguage [12:04:03] or rahter, i even don't have to, since it seems there is no language that has this button translated [12:06:15] not in the button itself but in the description / tooltip 01https://gerrit.wikimedia.org/r/#/c/109493/2/includes/EditPage.php01 [12:08:12] yeah, but that's easy [12:09:40] (03PS9) 10TheDJ: WIP: Editbutton for math [extensions/Math] - 10https://gerrit.wikimedia.org/r/109923 (owner: 10Physikerwelt) [12:09:42] first a rebase [12:10:04] I did never test this sampleText: mw.message( 'math_sample' ).text(), [12:10:17] with different languages [12:44:45] (03PS11) 10Physikerwelt: Fix MathJax centers equations [extensions/Math] - 10https://gerrit.wikimedia.org/r/119010 [12:44:47] (03PS1) 10Physikerwelt: WIP: Add custom css rules [extensions/Math] - 10https://gerrit.wikimedia.org/r/124062 [12:46:15] (03PS10) 10TheDJ: WIP: Editbutton for math [extensions/Math] - 10https://gerrit.wikimedia.org/r/109923 (owner: 10Physikerwelt) [12:46:56] thedj: https://gerrit.wikimedia.org/r/#/c/124062/1/MathTexvc.php would that work for youß [12:46:59] ? [12:47:12] physikerwelt: few points in the previous editbutton patch. mw.msg() is a shortcut for mw.message()->text() [12:47:16] (03CR) 10jenkins-bot: [V: 04-1] WIP: Add custom css rules [extensions/Math] - 10https://gerrit.wikimedia.org/r/124062 (owner: 10Physikerwelt) [12:47:39] JS messages need to be in the messages array of the RL module [12:47:40] (03PS5) 10Prtksxna: Use escape key to hide popup [extensions/Popups] - 10https://gerrit.wikimedia.org/r/120343 [12:49:20] (03PS11) 10TheDJ: WIP: Editbutton for math [extensions/Math] - 10https://gerrit.wikimedia.org/r/109923 (owner: 10Physikerwelt) [12:49:43] (03CR) 10Prtksxna: Use escape key to hide popup (031 comment) [extensions/Popups] - 10https://gerrit.wikimedia.org/r/120343 (owner: 10Prtksxna) [12:58:29] (03PS2) 10Prtksxna: Misc code formatting cleanup [extensions/Popups] - 10https://gerrit.wikimedia.org/r/123190 (owner: 10Santhosh) [12:58:31] (03CR) 10jenkins-bot: [V: 04-1] Misc code formatting cleanup [extensions/Popups] - 10https://gerrit.wikimedia.org/r/123190 (owner: 10Santhosh) [12:58:43] (03CR) 10TheDJ: [C: 04-1] WIP: Add custom css rules (034 comments) [extensions/Math] - 10https://gerrit.wikimedia.org/r/124062 (owner: 10Physikerwelt) [12:59:21] hmm, after about 6 hours being awake, i should really eat breakfast [13:00:49] thedj: Why doesn't anyone on this channel not eat properly! [13:00:55] YuviPanda marktraceur [13:01:16] can you send food via irc? [13:01:57] physikerwelt: Wish I could :( [13:02:00] (03PS3) 10Prtksxna: Misc code formatting cleanup [extensions/Popups] - 10https://gerrit.wikimedia.org/r/123190 (owner: 10Santhosh) [13:02:44] prtksxna: we should file a bug report... I think that's one of the most wanted features;-) [13:03:02] physikerwelt: :) [13:03:13] physikerwelt: Or make a bot to remind people to eat after every n patches :P [13:03:26] YuviPanda: Why don't you add that to the gerrit bot? [13:03:49] I think jenkins can eat cookies [13:07:10] !jenkins [13:07:10] https://integration.wikimedia.org/ci/job/$1 [13:08:05] bootsnack [13:08:09] (03CR) 10TheDJ: Use escape key to hide popup (031 comment) [extensions/Popups] - 10https://gerrit.wikimedia.org/r/120343 (owner: 10Prtksxna) [13:08:24] prtksxna: if you fix that 1 letter, i'll +2 now :D [13:08:32] !jenkins help [13:08:32] https://integration.wikimedia.org/ci/job/help [13:09:01] thedj: Oops [13:09:07] thedj: fixing now [13:10:03] (03PS6) 10Prtksxna: Use escape key to hide popup [extensions/Popups] - 10https://gerrit.wikimedia.org/r/120343 [13:10:44] (03CR) 10Prtksxna: Use escape key to hide popup (031 comment) [extensions/Popups] - 10https://gerrit.wikimedia.org/r/120343 (owner: 10Prtksxna) [13:11:01] (03CR) 10Physikerwelt: WIP: Add custom css rules (034 comments) [extensions/Math] - 10https://gerrit.wikimedia.org/r/124062 (owner: 10Physikerwelt) [13:11:41] thedj: done [13:11:53] (03CR) 10TheDJ: [C: 032] Use escape key to hide popup [extensions/Popups] - 10https://gerrit.wikimedia.org/r/120343 (owner: 10Prtksxna) [13:12:21] thedj: could you please leave a comment here? https://bugzilla.wikimedia.org/show_bug.cgi?id=62948 [13:13:17] thedj: if I remove the img selector I need to specify the class [13:13:29] do you think this reads better [13:13:31] physikerwelt: from img.name to .name [13:13:53] ok thanks [13:14:48] prtksxna: will do. but i really need coffee and food now [13:15:20] thedj: The bot should just order food on your behalf :P [13:15:26] thedj: Sure, take your time [13:27:12] (03CR) 10Prtksxna: "This isn't working for me on MacOS/Chrome. I tried scrolling using the trackpad and the keyboard and the Popup shows up in both cases. Are" [extensions/Popups] - 10https://gerrit.wikimedia.org/r/123790 (owner: 10JGonera) [13:29:37] My laptop battery is about to die and this bus does not have a power point :( [13:44:13] (03CR) 10Frédéric Wang: "> I tried to explain why the user input has to be changed in the beginning and not just before calling the renderer" [extensions/Math] - 10https://gerrit.wikimedia.org/r/119010 (owner: 10Physikerwelt) [14:39:24] (03CR) 10Physikerwelt: "Hi Frédéric," [extensions/Math] - 10https://gerrit.wikimedia.org/r/119010 (owner: 10Physikerwelt) [14:56:43] (03CR) 10Frédéric Wang: "> the point is that for this change we do not want to change the database entries. Since there is no equation that uses the display attrib" [extensions/Math] - 10https://gerrit.wikimedia.org/r/119010 (owner: 10Physikerwelt) [15:42:03] zz_prtksxna: I'm happily munching on banana bread, tyvnm [15:42:10] Typo but it actually works [15:47:54] (03CR) 10Edokter: "Already merged I see. I wanted to ask:" [extensions/Math] - 10https://gerrit.wikimedia.org/r/124055 (owner: 10TheDJ) [15:49:46] (03PS1) 10TheDJ: Add the TeX color extension back [extensions/Math] - 10https://gerrit.wikimedia.org/r/124063 [15:58:48] (03CR) 10Frédéric Wang: Add the TeX color extension back (031 comment) [extensions/Math] - 10https://gerrit.wikimedia.org/r/124063 (owner: 10TheDJ) [16:01:57] (03PS2) 10TheDJ: Add the TeX color extension back [extensions/Math] - 10https://gerrit.wikimedia.org/r/124063 [16:02:43] (03CR) 10TheDJ: Add the TeX color extension back (031 comment) [extensions/Math] - 10https://gerrit.wikimedia.org/r/124063 (owner: 10TheDJ) [16:03:40] (03CR) 10Frédéric Wang: [C: 031] Add the TeX color extension back [extensions/Math] - 10https://gerrit.wikimedia.org/r/124063 (owner: 10TheDJ) [16:14:06] (03CR) 10Frédéric Wang: "(BTW, it would be great to cover these extensions in the testsuite)" [extensions/Math] - 10https://gerrit.wikimedia.org/r/124063 (owner: 10TheDJ) [16:20:06] (03CR) 10TheDJ: "The parser tests already include it I think. The other tests don't rely on the ResourceLoader Moritz told me today, so they wouldn't have " [extensions/Math] - 10https://gerrit.wikimedia.org/r/124063 (owner: 10TheDJ) [16:47:16] (03CR) 10Bartosz Dziewoński: [C: 031] "Brion, do you want to comment, or is this +2-able? I'm going to merge this if no rationale not to do that is provided." [core] - 10https://gerrit.wikimedia.org/r/113329 (owner: 10TTO) [17:04:44] (03CR) 10Bartosz Dziewoński: "I've never thought I will say this, but: +1 to everything Daniel said here." [core] - 10https://gerrit.wikimedia.org/r/123816 (owner: 10Jdlrobson) [17:18:47] (03PS1) 10TheDJ: MathJax: Listen for wikipage.content hook [extensions/Math] - 10https://gerrit.wikimedia.org/r/124064 [17:20:06] (03CR) 10jenkins-bot: [V: 04-1] MathJax: Listen for wikipage.content hook [extensions/Math] - 10https://gerrit.wikimedia.org/r/124064 (owner: 10TheDJ) [17:21:08] (03CR) 10TheDJ: [C: 04-1] MathJax: Listen for wikipage.content hook (031 comment) [extensions/Math] - 10https://gerrit.wikimedia.org/r/124064 (owner: 10TheDJ) [17:27:17] (03CR) 10Bartosz Dziewoński: MathJax: Listen for wikipage.content hook (031 comment) [extensions/Math] - 10https://gerrit.wikimedia.org/r/124064 (owner: 10TheDJ) [17:45:18] (03CR) 10Bartosz Dziewoński: [C: 04-1] "Mixins should definitely be hyphen-cased, I updated the code conventions to include this: https://www.mediawiki.org/wiki/Manual:Coding_con" (033 comments) [core] - 10https://gerrit.wikimedia.org/r/123804 (owner: 10SG) [17:49:37] (03PS1) 10Jeroen De Dauw: Fix path after file got moved [core] - 10https://gerrit.wikimedia.org/r/124065 [17:53:43] (03CR) 10Physikerwelt: [C: 032] Add the TeX color extension back [extensions/Math] - 10https://gerrit.wikimedia.org/r/124063 (owner: 10TheDJ) [17:54:53] (03Merged) 10jenkins-bot: Add the TeX color extension back [extensions/Math] - 10https://gerrit.wikimedia.org/r/124063 (owner: 10TheDJ) [18:11:53] (03CR) 10Physikerwelt: ">OK. So in that case why do we ever add the \displaystyle/\textstyle hack if the new modes are not actually expected to be used for now? w" [extensions/Math] - 10https://gerrit.wikimedia.org/r/119010 (owner: 10Physikerwelt) [18:12:59] (03PS2) 10Physikerwelt: Add custom css rules [extensions/Math] - 10https://gerrit.wikimedia.org/r/124062 [18:14:02] (03PS1) 10IAlex: Disabling profiling in the debug toolbar for ProfilerSimple (for now) [core] - 10https://gerrit.wikimedia.org/r/124066 [18:14:28] (03CR) 10Physikerwelt: "oups... I thought I had uploaded this commit earlier" [extensions/Math] - 10https://gerrit.wikimedia.org/r/124062 (owner: 10Physikerwelt) [18:15:03] (03CR) 10jenkins-bot: [V: 04-1] Add custom css rules [extensions/Math] - 10https://gerrit.wikimedia.org/r/124062 (owner: 10Physikerwelt) [18:16:15] (03PS5) 10thibaultmarin: A few improvements (windows compatibility): [extensions/PGFTikZ] - 10https://gerrit.wikimedia.org/r/120750 [18:20:08] (03PS3) 10Physikerwelt: Add custom css rules [extensions/Math] - 10https://gerrit.wikimedia.org/r/124062 [18:23:34] (03PS6) 10thibaultmarin: A few improvements (windows compatibility): [extensions/PGFTikZ] - 10https://gerrit.wikimedia.org/r/120750 [18:23:56] (03PS12) 10Physikerwelt: Fix MathJax centers equations [extensions/Math] - 10https://gerrit.wikimedia.org/r/119010 [18:24:20] (03PS4) 10Physikerwelt: Add custom css rules [extensions/Math] - 10https://gerrit.wikimedia.org/r/124062 [18:25:00] (03CR) 10Addshore: [C: 032] Fix path after file got moved [core] - 10https://gerrit.wikimedia.org/r/124065 (owner: 10Jeroen De Dauw) [18:27:19] (03CR) 10Umherirrender: "EditPage.php already contains a comment:" [core] - 10https://gerrit.wikimedia.org/r/120858 (owner: 10Umherirrender) [18:27:45] (03Merged) 10jenkins-bot: Fix path after file got moved [core] - 10https://gerrit.wikimedia.org/r/124065 (owner: 10Jeroen De Dauw) [18:29:31] (03PS12) 10Physikerwelt: WIP: Editbutton for math [extensions/Math] - 10https://gerrit.wikimedia.org/r/109923 [18:29:58] (03PS1) 10IAlex: Remove trailing line break check from MemcachedBagOStuff::debugLog() [core] - 10https://gerrit.wikimedia.org/r/124067 [18:30:15] (03PS2) 10IAlex: Correctly order AutoLoader class definitions [core] - 10https://gerrit.wikimedia.org/r/124051 [18:37:07] (03CR) 10Isarra: "What Daniel and Bartosz said." [core] - 10https://gerrit.wikimedia.org/r/123816 (owner: 10Jdlrobson) [18:42:02] (03CR) 10Siebrand: "This patch set has been idle for a long time with one or more open comments. It will be abandoned if there are no code updates within a we" [core] - 10https://gerrit.wikimedia.org/r/47373 (owner: 10Bouron) [18:42:17] (03CR) 10Siebrand: "This patch set has been idle for a long time with one or more open comments. It will be abandoned if there are no code updates within a we" [core] - 10https://gerrit.wikimedia.org/r/22699 (owner: 10Liangent) [18:42:24] (03CR) 10Siebrand: "This patch set has been idle for a long time with one or more open comments. It will be abandoned if there are no code updates within a we" [core] - 10https://gerrit.wikimedia.org/r/4051 (owner: 10Daniel Friesen) [18:42:34] (03CR) 10Siebrand: "This patch set has been idle for a long time with one or more open comments. It will be abandoned if there are no code updates within a we" [core] - 10https://gerrit.wikimedia.org/r/37685 (owner: 10Jarry1250) [18:42:44] (03CR) 10Siebrand: "This patch set has been idle for a long time with one or more open comments. It will be abandoned if there are no code updates within a we" [core] - 10https://gerrit.wikimedia.org/r/84212 (owner: 10Ara) [18:43:18] (03CR) 10Bartosz Dziewoński: [C: 032] Correctly order AutoLoader class definitions [core] - 10https://gerrit.wikimedia.org/r/124051 (owner: 10IAlex) [18:44:22] (03CR) 10Frédéric Wang: ">> OK. So in that case why do we ever add the \displaystyle/\textstyle hack if the new modes are not actually expected to be used for now?" [extensions/Math] - 10https://gerrit.wikimedia.org/r/119010 (owner: 10Physikerwelt) [18:44:30] (03Abandoned) 10Siebrand: (bug 47653) Processing foreign API files protocol-relative [core] - 10https://gerrit.wikimedia.org/r/61390 (owner: 10Kai Nissen (WMDE)) [18:44:50] (03Abandoned) 10Siebrand: (Bug 2700) Pre-save transform inside extension hooks [core] - 10https://gerrit.wikimedia.org/r/8784 (owner: 10Dan Collins) [18:45:53] (03CR) 10Siebrand: "This patch set has been idle for a long time with one or more open comments. It will be abandoned if there are no code updates within a we" [extensions/Cite] - 10https://gerrit.wikimedia.org/r/42880 (owner: 10Relwell) [18:46:04] (03CR) 10Siebrand: "This patch set has been idle for a long time with one or more open comments. It will be abandoned if there are no code updates within a we" [core] - 10https://gerrit.wikimedia.org/r/47442 (owner: 10Micke) [18:46:09] (03CR) 10Bartosz Dziewoński: "Filed bug 63579 about the failing tests." [core] - 10https://gerrit.wikimedia.org/r/124051 (owner: 10IAlex) [18:46:12] (03Merged) 10jenkins-bot: Correctly order AutoLoader class definitions [core] - 10https://gerrit.wikimedia.org/r/124051 (owner: 10IAlex) [18:46:21] (03CR) 10Siebrand: "This patch set has been idle for a long time with one or more open comments. It will be abandoned if there are no code updates within a we" [core] - 10https://gerrit.wikimedia.org/r/92677 (owner: 10Anomie) [18:46:51] (03CR) 10Siebrand: "This patch set has been idle for a long time with one or more open comments. It will be abandoned if there are no code updates within a we" [core] - 10https://gerrit.wikimedia.org/r/44397 (owner: 10VitaliyFilippov) [18:46:54] (03PS2) 10Gerrit Patch Uploader: Initialize tooltipAccessKeyPrefix on load instead of on domready [core] - 10https://gerrit.wikimedia.org/r/123780 [18:46:56] (03CR) 10Gerrit Patch Uploader: "This commit was uploaded using the Gerrit Patch Uploader [1]." [core] - 10https://gerrit.wikimedia.org/r/123780 (owner: 10Gerrit Patch Uploader) [18:47:00] (03CR) 10Siebrand: "This patch set has been idle for a long time with one or more open comments. It will be abandoned if there are no code updates within a we" [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/97999 (owner: 10Brian Wolff) [18:47:15] (03CR) 10Siebrand: "This patch set has been idle for a long time with one or more open comments. It will be abandoned if there are no code updates within a we" [extensions/IssueTracker] - 10https://gerrit.wikimedia.org/r/91565 (owner: 10leucosticte) [18:47:19] ugh, yeah, I need to fix that [18:47:50] (03CR) 10Siebrand: "This patch set has been idle for a long time with one or more open comments. It will be abandoned if there are no code updates within a we" [core] - 10https://gerrit.wikimedia.org/r/87288 (owner: 10Liangent) [18:48:00] (03CR) 10Siebrand: "This patch set has been idle for a long time with one or more open comments. It will be abandoned if there are no code updates within a we" [core] - 10https://gerrit.wikimedia.org/r/75079 (owner: 10Pginer) [18:48:18] (03CR) 10Siebrand: "This patch set has been idle for a long time with one or more open comments. It will be abandoned if there are no code updates within a we" [extensions/Agora] - 10https://gerrit.wikimedia.org/r/53353 (owner: 10Pginer) [18:48:29] (03CR) 10Siebrand: "This patch set has been idle for a long time with one or more open comments. It will be abandoned if there are no code updates within a we" [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/92468 (owner: 10Legoktm) [18:49:16] (03CR) 10Siebrand: "This patch set has been idle for a long time with one or more open comments. It will be abandoned if there are no code updates within a we" [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/101178 (owner: 10Apsdehal) [18:49:26] (03CR) 10Siebrand: "This patch set has been idle for a long time with one or more open comments. It will be abandoned if there are no code updates within a we" [extensions/Echo] - 10https://gerrit.wikimedia.org/r/91817 (owner: 10Legoktm) [18:49:37] (03CR) 10Siebrand: "This patch set has been idle for a long time with one or more open comments. It will be abandoned if there are no code updates within a we" [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/97628 (owner: 10Legoktm) [18:49:48] (03CR) 10Siebrand: "This patch set has been idle for a long time with one or more open comments. It will be abandoned if there are no code updates within a we" [core] - 10https://gerrit.wikimedia.org/r/96170 (owner: 10Legoktm) [18:49:59] (03CR) 10Siebrand: "This patch set has been idle for a long time with one or more open comments. It will be abandoned if there are no code updates within a we" [core] - 10https://gerrit.wikimedia.org/r/64533 (owner: 10Balloonguy) [18:50:11] (03CR) 10Siebrand: "This patch set has been idle for a long time with one or more open comments. It will be abandoned if there are no code updates within a we" [core] - 10https://gerrit.wikimedia.org/r/83584 (owner: 10Reedy) [18:50:25] (03CR) 10Siebrand: "This patch set has been idle for a long time with one or more open comments. It will be abandoned if there are no code updates within a we" [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/94691 (owner: 10Legoktm) [18:50:40] (03CR) 10Siebrand: "This patch set has been idle for a long time with one or more open comments. It will be abandoned if there are no code updates within a we" [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/87183 (owner: 10Legoktm) [18:51:01] (03CR) 10Siebrand: "This patch set has been idle for a long time with one or more open comments. It will be abandoned if there are no code updates within a we" [extensions/AzharAuth] - 10https://gerrit.wikimedia.org/r/110518 (owner: 10Dereckson) [18:51:42] (03CR) 10Ori.livneh: [C: 032] Flush logger before exit [tools/scap] - 10https://gerrit.wikimedia.org/r/124016 (owner: 10BryanDavis) [18:51:49] (03CR) 10Siebrand: [C: 04-1] "This patch set has to be updated. Release notes should be for 1.23." [core] - 10https://gerrit.wikimedia.org/r/87273 (owner: 10Liangent) [18:51:54] (03Merged) 10jenkins-bot: Flush logger before exit [tools/scap] - 10https://gerrit.wikimedia.org/r/124016 (owner: 10BryanDavis) [18:52:02] (03CR) 10Ori.livneh: [C: 032] Remove use of deprecated --extended flag with mwversionsinuse [tools/scap] - 10https://gerrit.wikimedia.org/r/124015 (owner: 10BryanDavis) [18:52:15] (03Merged) 10jenkins-bot: Remove use of deprecated --extended flag with mwversionsinuse [tools/scap] - 10https://gerrit.wikimedia.org/r/124015 (owner: 10BryanDavis) [18:52:31] (03CR) 10Siebrand: [C: 04-1] "This patch set should be updated as the i18n system has been updated." [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/94692 (owner: 10Legoktm) [18:53:21] (03CR) 10Siebrand: [C: 04-1] "This patch set should be rebased." [extensions/PerPageLicense] - 10https://gerrit.wikimedia.org/r/100202 (owner: 10leucosticte) [18:54:04] (03CR) 10Siebrand: [C: 032 V: 032] "Merging non-critical extension code." [extensions/ViewFiles] - 10https://gerrit.wikimedia.org/r/28799 (owner: 10leucosticte) [18:56:30] (03PS1) 10Siebrand: Update formatting [extensions/ViewFiles] - 10https://gerrit.wikimedia.org/r/124070 [18:57:37] (03PS1) 10Siebrand: Migrate to JSON i18n [extensions/ViewFiles] - 10https://gerrit.wikimedia.org/r/124071 [19:00:07] (03CR) 10Siebrand: "Can any of the people added as a reviewer to this patch set please review it? TIA!" [extensions/CategoryTree] - 10https://gerrit.wikimedia.org/r/99649 (owner: 10Gerrit Patch Uploader) [19:00:50] siebrand: [19:01:05] regarding https://gerrit.wikimedia.org/r/73708 [19:01:41] siebrand: it's "indef paused" per "Indefinitely paused until we can settle how this kind of use case should be presented in the API (refer to bug 50407 for further discussion)." [19:02:15] AzaToth: Then please abandon it. It can be re-activated at any time. [19:02:24] (03PS7) 10thibaultmarin: A few improvements (windows compatibility): [extensions/PGFTikZ] - 10https://gerrit.wikimedia.org/r/120750 [19:02:25] I've not abandoned it [19:02:40] (03CR) 10Siebrand: "This patch set should be updated and rebased. The i18n system has changed." [core] - 10https://gerrit.wikimedia.org/r/108487 (owner: 10Hydriz) [19:02:48] it's the higherups that hasn't been able to decide [19:02:58] (03CR) 10Siebrand: [C: 04-1] "This patch set should be updated and rebased. The i18n system has changed." [core] - 10https://gerrit.wikimedia.org/r/84194 (owner: 10TTO) [19:03:14] (03CR) 10Siebrand: [C: 04-1] "This patch set should be updated and rebased. The i18n system has changed." [core] - 10https://gerrit.wikimedia.org/r/109056 (owner: 10leucosticte) [19:03:43] (03PS3) 10Brian Wolff: Use hooks instead of $wgOut when $wgCategoryTreeForceHeaders is set [extensions/CategoryTree] - 10https://gerrit.wikimedia.org/r/99649 (owner: 10Gerrit Patch Uploader) [19:03:45] AzaToth: No problem. If you don't do it, I'll do it in a week or more. [19:03:45] I don't think it's fair to force me to abandon a patch just because Krinkle|detached hasn't made a decision yet [19:04:24] that sounds unfair [19:04:58] AzaToth: Yes, it does. [19:05:12] AzaToth: So you should keep bugging Krinkle|detached. [19:05:41] -2 due to a temporary external event does sound rather different from the normal somebody -1'd something and then original submitter never fixed it [19:05:42] AzaToth: Status quo however will not be that the patch set stays in limbo forever. [19:06:46] AzaToth: If Krinkle|detached cannot decide, there's always the possibility of bringing it to a larger forum, like wiitech-l. [19:06:53] true [19:07:21] but what does Nintendo have to do with it? [19:07:23] (03CR) 10Siebrand: [C: 04-1] "This patch set should be updated and rebased. The i18n system has changed." [core] - 10https://gerrit.wikimedia.org/r/106218 (owner: 10Parent5446) [19:08:05] huh? [19:08:16] (03CR) 10Physikerwelt: "You are right that merging the changes step by step produces additional overhead. However, the main goal of this change is to fix 61051. A" [extensions/Math] - 10https://gerrit.wikimedia.org/r/119010 (owner: 10Physikerwelt) [19:08:21] (03CR) 10Aaron Schulz: [C: 032] Remove trailing line break check from MemcachedBagOStuff::debugLog() [core] - 10https://gerrit.wikimedia.org/r/124067 (owner: 10IAlex) [19:08:23] bawolff: wiitech-l [19:08:36] oh, didn't see that [19:08:48] AzaToth, .... what does nintendo have to do with anything? [19:08:54] (03CR) 10Siebrand: "Can any of the people added as a reviewer to this patch set please review it and work towards merging it, or indicate what needs to be imp" [core] - 10https://gerrit.wikimedia.org/r/65446 (owner: 10Waldir) [19:08:57] Krenair: wiitech-l [19:09:12] oh [19:09:14] haha [19:10:11] wiitech-l is the super secret Nintendo mailing list the WMF cabel uses to make decisions it wants no one else have influence on. [19:11:25] (03Merged) 10jenkins-bot: Remove trailing line break check from MemcachedBagOStuff::debugLog() [core] - 10https://gerrit.wikimedia.org/r/124067 (owner: 10IAlex) [19:12:53] (03CR) 10Siebrand: [C: 031] "i18n/L10n reviewed." [extensions/PGFTikZ] - 10https://gerrit.wikimedia.org/r/120750 (owner: 10thibaultmarin) [19:14:12] (03PS1) 10Umherirrender: fix typo in comment in Preferences.php [core] - 10https://gerrit.wikimedia.org/r/124072 [19:15:57] siebrand: Well WMF has to discuss their high scores somewhere. [19:16:12] bawolff: ;) [19:17:12] you subscribe using elaborate gestures? [19:18:14] (03PS2) 10IAlex: fix typo in comment in Preferences.php [core] - 10https://gerrit.wikimedia.org/r/124072 (owner: 10Umherirrender) [19:18:17] (03CR) 10IAlex: [C: 032] fix typo in comment in Preferences.php [core] - 10https://gerrit.wikimedia.org/r/124072 (owner: 10Umherirrender) [19:22:08] (03CR) 10jenkins-bot: [V: 04-1] fix typo in comment in Preferences.php [core] - 10https://gerrit.wikimedia.org/r/124072 (owner: 10Umherirrender) [19:22:21] So many things wrong with inputbox [19:23:19] bawolff: you doing something on inputbox? [19:23:29] I'm reviewing jackmcbarn's patch [19:24:13] and in the process I'm discovering many a thing wrong with the inputbox code base [19:33:09] (03CR) 10Brian Wolff: [C: 04-1] "Some of the issues I found are probably the result of copying things from other parts of the extension, where the extension did things wro" (036 comments) [extensions/InputBox] - 10https://gerrit.wikimedia.org/r/97559 (owner: 10Jackmcbarn) [19:33:36] (03PS2) 10TheDJ: MathJax: Listen for wikipage.content hook [extensions/Math] - 10https://gerrit.wikimedia.org/r/124064 [19:33:52] (03CR) 10TheDJ: MathJax: Listen for wikipage.content hook (031 comment) [extensions/Math] - 10https://gerrit.wikimedia.org/r/124064 (owner: 10TheDJ) [19:34:46] (03CR) 10Frédéric Wang: "Thanks Moritz for the explanation. So your last comment seems to confirm that it is not a good idea to take the attribute for the math mod" [extensions/Math] - 10https://gerrit.wikimedia.org/r/119010 (owner: 10Physikerwelt) [19:37:23] (03CR) 10Siebrand: Allow InputBoxes to be used to move pages (031 comment) [extensions/InputBox] - 10https://gerrit.wikimedia.org/r/97559 (owner: 10Jackmcbarn) [19:40:27] Wow, mobile frontend really does take CR seriously [19:40:55] (03PS2) 10Alex Monk: Show pending changes notice about unstable transclusions in VE [extensions/FlaggedRevs] - 10https://gerrit.wikimedia.org/r/123875 [19:41:44] (03PS1) 10Siebrand: Use key names with the extension name as prefix [extensions/InputBox] - 10https://gerrit.wikimedia.org/r/124090 [19:44:03] (03CR) 10Siebrand: Use key names with the extension name as prefix (032 comments) [extensions/InputBox] - 10https://gerrit.wikimedia.org/r/124090 (owner: 10Siebrand) [19:45:52] (03CR) 10Brian Wolff: [C: 04-2] "I think this is a big enough change to the way MediaWiki does things, that it would need a mailing list thread on wikitech-l, with either " [core] - 10https://gerrit.wikimedia.org/r/109056 (owner: 10leucosticte) [19:55:03] (03CR) 10Hashar: "> Hashar, what is the effect exactly for having a blank .jshintrc? Does it use the out-of-the-box jshint defaults, or some Jenkins defaul" [extensions/ConfirmEdit] - 10https://gerrit.wikimedia.org/r/122126 (owner: 10AalekhN) [19:55:23] (03PS1) 10Umherirrender: Fix spacing after @param and friends in comments [core] - 10https://gerrit.wikimedia.org/r/124126 [19:59:31] (03CR) 10Brian Wolff: "What about "createarticle" message?" [extensions/InputBox] - 10https://gerrit.wikimedia.org/r/124090 (owner: 10Siebrand) [20:00:48] (03CR) 10Physikerwelt: "The point why I really want to merge this feature now is that we developed this feature 6 months ago and did not make any progress." [extensions/Math] - 10https://gerrit.wikimedia.org/r/119010 (owner: 10Physikerwelt) [20:00:53] (03PS2) 10Siebrand: Use key names with the extension name as prefix [extensions/InputBox] - 10https://gerrit.wikimedia.org/r/124090 [20:02:31] (03PS2) 10IAlex: Fix spacing after @param and friends in comments [core] - 10https://gerrit.wikimedia.org/r/124126 (owner: 10Umherirrender) [20:02:37] (03CR) 10IAlex: [C: 032] Fix spacing after @param and friends in comments [core] - 10https://gerrit.wikimedia.org/r/124126 (owner: 10Umherirrender) [20:06:36] (03CR) 10jenkins-bot: [V: 04-1] Fix spacing after @param and friends in comments [core] - 10https://gerrit.wikimedia.org/r/124126 (owner: 10Umherirrender) [20:07:50] (03CR) 10Brian Wolff: [C: 032 V: 032] "Take that qunit tests" [core] - 10https://gerrit.wikimedia.org/r/124126 (owner: 10Umherirrender) [20:08:42] thank you bawolff :) [20:09:03] That's the second patch I've seen fail on qunit tests for no reason whatsoever [20:09:24] bawolff: the other one was with my patch... [20:10:54] Actually the last other one I was thinking of was my patch - https://gerrit.wikimedia.org/r/#/c/116227/ [20:12:47] bugzilla and gerrit are unreachable for me... [20:13:36] thedj: They're fine for me [20:14:09] siebrand: Should I merge https://gerrit.wikimedia.org/r/#/c/124090/2 , or are you still going back and forth on bringing that one message into the extension? [20:14:34] bawolff: Was actually hoping for an opinion of you :) [20:14:36] it's been spotty for a week already. seems an issue in routing somewhere [20:15:12] You're the expert :P [20:16:15] bawolff: Okay :) [20:16:19] I honestly don't know. Thus far nobody seems to have complained about it, but it does violate the use a different message for every different place the string is used rule [20:16:42] bawolff: You can merge it without that addition. That would be a differnet reason for a change anyway, and worth of its own patch set. [20:17:16] (03CR) 10Brian Wolff: [C: 032] Use key names with the extension name as prefix [extensions/InputBox] - 10https://gerrit.wikimedia.org/r/124090 (owner: 10Siebrand) [20:17:18] (03Merged) 10jenkins-bot: Use key names with the extension name as prefix [extensions/InputBox] - 10https://gerrit.wikimedia.org/r/124090 (owner: 10Siebrand) [20:17:22] bawolff: The issue is that it's only used in core in a legacy class, which means it could be removed at some point, which makes the case for the extension having its own message for it better. [20:18:10] Oh, hmm, yeah that could be a nasty surprise at some later pont [20:18:13] *point [20:18:39] (03PS1) 10Umherirrender: Increase colspan for unattached rows on Special:CentralAuth [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/124127 [20:19:55] wait, where is postcomment used in core. grep cannot find it [20:25:44] (03Abandoned) 10Bartosz Dziewoński: Rename RedirectSpecialPage subclasses [core] - 10https://gerrit.wikimedia.org/r/106888 (owner: 10Bartosz Dziewoński) [20:40:07] siebrand: you missed the qqq version of the messages in inputbox [20:40:39] (03PS4) 10Jackmcbarn: Allow InputBoxes to be used to move pages [extensions/InputBox] - 10https://gerrit.wikimedia.org/r/97559 [20:41:09] (03CR) 10Jackmcbarn: "Can I save fixing the attachPrefix ickiness and the sane default page for a later commit?" [extensions/InputBox] - 10https://gerrit.wikimedia.org/r/97559 (owner: 10Jackmcbarn) [20:55:34] bawolff: ^ [20:56:27] jackmcbarn: Would you be able to pull the prefix part out of this patch, and add it back in in a later patch? [20:57:27] bawolff: well... the reason i wrote this needs it to have a prefix [20:58:05] What is the use case for this? [20:58:52] the one i had in mind was to move userspace AfC submissions under the generic name of User:/sandbox to Wikipedia talk:Articles for creation/Some legitimate name entered in the textbox [20:59:09] without the prefix, people would accidentally remove the "Wikipedia talk:Articles for creation/" part or otherwise screw it up [21:00:40] (03PS1) 10Stepzhou: Allow useres to associate Persona email to an existing account. [extensions/Persona] - 10https://gerrit.wikimedia.org/r/124128 [21:00:42] (03CR) 10jenkins-bot: [V: 04-1] Allow useres to associate Persona email to an existing account. [extensions/Persona] - 10https://gerrit.wikimedia.org/r/124128 (owner: 10Stepzhou) [21:01:41] jackmcbarn: I'd really prefer that you modified Special:MovePage in core instead. Modifying request parameters from an extension function seems really hacky [21:01:58] If this is for wikipedia, the core change would be deployed at the same time as the extension change anyways [21:02:00] kk [21:02:10] new hook, right? [21:02:24] or should i make onMediaWikiPerformAction get called on moves? [21:02:36] I was more thinking to change Special:MovePage to always pay attention to the prefix parameter [21:03:06] it seems just as icky to check for a prefix parameter there [21:03:21] e.g. line 77 of SpecialMovePage.php [21:03:46] Seems slightly nicer that the form would respond to the same parameters regardless of what extensions are installed [21:04:00] because other than this one specific case, when else would you want prefix=Wikipedia_talk:Articles_for_creation/&wpNewTitle=foo to do that? [21:04:03] that's how createpage does it too [21:04:14] (or is that another poorly coded thing about inputbox?) [21:04:35] yeah, and in the past createpage thing has caused confusion [21:05:13] for createpage there is at least a hook that's somewhat relavent, so I wouldn't call it necessarily bad [21:05:25] my only concern is it seems like it would have no use outside this extension, so i'm not sure it should be always-on in core [21:05:43] would a new hook be ok? [21:06:06] For a comparision, I believe that editintro parameter was essentially added to core explicitly for this extension [21:06:30] it makes sense for normal links to use editintro though. it makes no sense for normal links to use prefix [21:06:31] new hook would also be ok (I think just doing it always is simpler, but either should be fine) [21:07:04] I looked into IB recently [21:07:11] (Someone wanted it to submit to VE) [21:07:52] Unfortunately I found that it relies on extra parameters which have been added to action=edit [21:08:36] jackmcbarn: If you really want to use a hook, I would be fine with using onMediaWikiPerformAction, like the existing prefix thing does, but looking at $title parameter [21:09:32] (03PS1) 10Stepzhou: Allow users to associate Persona email to an existing account. [extensions/Persona] - 10https://gerrit.wikimedia.org/r/124129 [21:10:16] Krenair: My criticism of input box, is it was testing for a misspelled class variable, and whomever mis-spelled it, upon seeing the warnings, switched to using isset instead of fixing the spelling... [21:10:37] heh [21:14:36] (03Abandoned) 10Stepzhou: Allow useres to associate Persona email to an existing account. [extensions/Persona] - 10https://gerrit.wikimedia.org/r/124128 (owner: 10Stepzhou) [21:16:01] (03CR) 10Brian Wolff: [C: 04-1] "A couple of other minor things in inline comment." (035 comments) [extensions/InputBox] - 10https://gerrit.wikimedia.org/r/97559 (owner: 10Jackmcbarn) [21:23:22] bawolff: onMediaWikiPerformAction doesn't currently get called for special pages [21:23:42] oh *sigh* [21:23:51] of course it doesn't [21:23:55] new hook it is then, i guess [21:24:43] I guess that does make sense, you don't perform actions on special pages... [21:25:52] maybe you could use TestCanonicalRedirect [21:26:58] maybe SpecialPageBeforeExecute [21:28:01] yes, that one should work well [21:32:42] bawolff: btw, wpNewTitle needs the wp prefix because Special:MovePage uses it [21:33:19] https://bugzilla.wikimedia.org/show_bug.cgi?id=56025 Hey there I wanna work on this bug [21:33:36] Validate username using AJAX for password reset [21:33:37] aditya_sastry: what's your bugzilla username? [21:33:50] ganeshaditya1 [21:33:57] And I was wondering if there [21:34:10] Do I need to use this api hook for this http://www.mediawiki.org/wiki/API:Allusers [21:34:24] Hi aditya_sastry [21:34:27] or if there is a better way to check if the user name exists [21:34:29] jackmcbarn: I mean, inside the input box tag - like newtitle=foo gets turned into wpNewTitle=foo in the url [21:34:42] @Krenair hi. [21:35:07] Yes, it looks like you'll want to use allusers to check to see if the username exists [21:35:22] kk [21:35:52] aditya_sastry: it's assigned to you [21:36:43] @Krenair I was thinking that I would like get the first character of the user name typed and use that as a prefix to get all usernames [21:37:01] cause that seems to be better than getting all the usernames into client side ! [21:37:03] Yep, it supports that [21:37:30] @Krenair is it fine if I do it that way ? I am kinda new to mediawiki development .. [21:38:30] @Krenair also there is no dedicated js file to the passwordreset.php so should I implement this functionality in a new js file ? [21:38:33] I can't think of any problems with that [21:38:42] bawolff: you don't pass newtitle into the [21:38:50] you pass "default" [21:39:49] aditya_sastry, you'll want to make resources/mediawiki.special/mediawiki.special.passwordreset.js [21:40:52] @Krenair cool .. I will start working on the patch then. It should be done in a couple of hours cause its dinner time now. BTW whats your bugzilla id so I could add you as a reviewer. [21:41:26] Bugzilla ID for review? um, our code review goes through gerrit, not bugzilla. please don't post your patch on bugzilla [21:41:44] jackmcbarn: Right, I got confused by line 632. I think line 632 should be removed, along with mWpNewTitle member variable [21:41:45] You can add me to the gerrit reviewer list as 'Krenair' [21:41:46] I am sorry I meant gerrit. Not bugzilla [21:44:45] (03CR) 10Brian Wolff: Allow InputBoxes to be used to move pages (032 comments) [extensions/InputBox] - 10https://gerrit.wikimedia.org/r/97559 (owner: 10Jackmcbarn) [21:48:45] (03PS5) 10Jackmcbarn: Allow InputBoxes to be used to move pages [extensions/InputBox] - 10https://gerrit.wikimedia.org/r/97559 [21:51:08] (03PS2) 10Donyu: Allow users to associate Persona email to an existing account. [extensions/Persona] - 10https://gerrit.wikimedia.org/r/124129 (owner: 10Stepzhou) [21:52:02] (03PS1) 10MaxSem: Per wikitech-l, remove premature wfDeprecated() [core] - 10https://gerrit.wikimedia.org/r/124130 [21:53:40] (03CR) 10Siebrand: [C: 031] "i18n/L10n reviewed." [extensions/InputBox] - 10https://gerrit.wikimedia.org/r/97559 (owner: 10Jackmcbarn) [21:57:25] (03CR) 10Siebrand: [C: 04-1] "i18n/L10n reviewed." (031 comment) [extensions/Persona] - 10https://gerrit.wikimedia.org/r/124129 (owner: 10Stepzhou) [21:58:23] (03CR) 10Brian Wolff: [C: 032] "This sounds reasonable to me" [core] - 10https://gerrit.wikimedia.org/r/124130 (owner: 10MaxSem) [21:58:54] (03PS8) 10thibaultmarin: (extension/TimelineTable) Refactoring and cleanup [extensions/TimelineTable] - 10https://gerrit.wikimedia.org/r/38485 [22:01:22] (03Merged) 10jenkins-bot: Per wikitech-l, remove premature wfDeprecated() [core] - 10https://gerrit.wikimedia.org/r/124130 (owner: 10MaxSem) [22:06:26] ^ ugh, that's a really unhelpful commit title :( [22:06:46] * MatmaRex slaps MaxSem around a bit with a large trout [22:07:14] MUHAHA [22:08:22] (03PS9) 10thibaultmarin: (extension/TimelineTable) Refactoring and cleanup [extensions/TimelineTable] - 10https://gerrit.wikimedia.org/r/38485 [22:11:28] MaxSem: at least link the wikitech thread in the comments or sumfin'? [22:11:41] i'd -1 over that if i was faster. :P [22:12:05] Snooze, you lose :P [22:12:10] Couldn't you just update the commit message yourself? [22:12:15] Gerrit makes it fairly easy these days [22:12:23] Krenair: I +2'd it so its too late [22:12:25] (sorry) [22:12:34] Yeah I saw [22:13:07] Yeah sorry, I should have thought of asking for a wikitech archive link [22:13:39] meh [22:14:02] (03CR) 10Brian Wolff: "For reference, this is in reference to http://lists.wikimedia.org/pipermail/wikitech-l/2014-April/075681.html" [core] - 10https://gerrit.wikimedia.org/r/124130 (owner: 10MaxSem) [22:14:35] (03CR) 10Hashar: "That updates the dependencies for the browser job, I guess unit tests are in need of it as well aren't they :D Amending." [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/124011 (owner: 10Manybubbles) [22:14:55] (03PS2) 10Hashar: Cirrus now needs the Cite extension for testing [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/124011 (owner: 10Manybubbles) [22:17:33] (03PS3) 10Ori.livneh: Vector: Simply style external links [core] - 10https://gerrit.wikimedia.org/r/123817 (owner: 10Jdlrobson) [22:17:57] (03CR) 10Ori.livneh: [C: 032] Vector: Simply style external links [core] - 10https://gerrit.wikimedia.org/r/123817 (owner: 10Jdlrobson) [22:21:41] (03Merged) 10jenkins-bot: Vector: Simply style external links [core] - 10https://gerrit.wikimedia.org/r/123817 (owner: 10Jdlrobson) [22:22:53] (03PS3) 10Stepzhou: Allow users to associate Persona email to an existing account. [extensions/Persona] - 10https://gerrit.wikimedia.org/r/124129 [22:23:22] (03CR) 10MaxSem: Vector: Simply style external links (031 comment) [core] - 10https://gerrit.wikimedia.org/r/123817 (owner: 10Jdlrobson) [22:30:23] (03CR) 10Brian Wolff: [C: 04-1] "Minor thing, and then this should be ready to merge" (032 comments) [extensions/InputBox] - 10https://gerrit.wikimedia.org/r/97559 (owner: 10Jackmcbarn) [22:31:18] (03CR) 10Bartosz Dziewoński: "Release notes…" [core] - 10https://gerrit.wikimedia.org/r/123817 (owner: 10Jdlrobson) [22:33:23] Wow is the code to determine if ogg media type is video is ever hacky [22:34:22] (03PS1) 10MaxSem: Restore explicit scoping for .external links [core] - 10https://gerrit.wikimedia.org/r/124131 [22:36:51] (03CR) 10Ori.livneh: "Suggestion: automatically uppercase the initial letter as the user inputs it, like , but if the user backspace" [core] - 10https://gerrit.wikimedia.org/r/117438 (owner: 10Bartosz Dziewoński) [22:37:36] (03PS4) 10Ori.livneh: mediawiki.special: Kill width: 98% on borderless tables [core] - 10https://gerrit.wikimedia.org/r/116789 (owner: 10Bartosz Dziewoński) [22:37:41] (03CR) 10Ori.livneh: [C: 032] mediawiki.special: Kill width: 98% on borderless tables [core] - 10https://gerrit.wikimedia.org/r/116789 (owner: 10Bartosz Dziewoński) [22:41:53] (03Merged) 10jenkins-bot: mediawiki.special: Kill width: 98% on borderless tables [core] - 10https://gerrit.wikimedia.org/r/116789 (owner: 10Bartosz Dziewoński) [22:43:12] (03CR) 10Bartosz Dziewoński: "No way in hell am I writing a version of this that would work reliably for all the things a user and a browser might to do a textfield. I " [core] - 10https://gerrit.wikimedia.org/r/117438 (owner: 10Bartosz Dziewoński) [22:55:27] (03PS1) 10Brian Wolff: Fix capitalization and tests of $this->mId. [extensions/InputBox] - 10https://gerrit.wikimedia.org/r/124132 [22:56:09] (03PS10) 10thibaultmarin: (extension/TimelineTable) Refactoring and cleanup [extensions/TimelineTable] - 10https://gerrit.wikimedia.org/r/38485 [23:09:58] (03CR) 10Brian Wolff: [C: 031] "Tested on php 5.3, works fine. On PHP 5.3 there was no difference in my very very unscientific benchmark of seeing how fast $GLOBALS (Whic" [core] - 10https://gerrit.wikimedia.org/r/123518 (owner: 10PleaseStand) [23:21:11] (03CR) 10Hashar: "Thanks!" [tools/scap] - 10https://gerrit.wikimedia.org/r/124015 (owner: 10BryanDavis) [23:24:31] (03CR) 10Ori.livneh: [C: 031] "OK, it's just a thought. Anyways, +1 from me. Steven, what do you think?" [core] - 10https://gerrit.wikimedia.org/r/117438 (owner: 10Bartosz Dziewoński) [23:37:43] looks like we had quite a productive saturday so far [23:40:54] o hi thedj [23:41:11] thedj: is https://gerrit.wikimedia.org/r/#/c/124064/ mergeable? [23:42:58] MatmaRex: no [23:43:42] right. i was just wondering if you resolved your -1 from the first PS :) [23:44:20] (03CR) 10TheDJ: [C: 04-1] "I'd really like to see what Frederic has to say about the initial load event situation here." [extensions/Math] - 10https://gerrit.wikimedia.org/r/124064 (owner: 10TheDJ) [23:49:22] (03PS1) 10Bartosz Dziewoński: Remove unused 'prefs-beta' message [core] - 10https://gerrit.wikimedia.org/r/124133 [23:50:35] (03CR) 10Bartosz Dziewoński: "Somebody should probably grep extensions in Gerrit for this before merging, just in case." [core] - 10https://gerrit.wikimedia.org/r/124133 (owner: 10Bartosz Dziewoński) [23:52:09] @Krenair most of the patch is done and I am about to add the error message and I am removing any existing error messages from the page and am adding a error message with text 'nosuchuser'. Is this fine ? [23:53:29] @Krenair let me rephrase that. In case the user name entered doesnt exists, am removing any existing error messages on that page and am putting a new error message with text 'nosuchuser'. [23:54:16] @Krenair I have govt scheduled power cut in an hour so please respond soon. [23:54:34] aditya_sastry, I'm not sure that's a good idea [23:54:48] but it might be fine. If you upload it for review I'll take a look [23:55:18] @Krenair should I append the nosuchuser error to any existing error message ? [23:55:36] aditya_sastry, possibly, but it might already be there [23:56:54] (03PS1) 10Renoirb: Improving doc. on how OAuth is integrated in MW [extensions/OAuth] - 10https://gerrit.wikimedia.org/r/124134 [23:56:55] @Krenair hmm .. I will upload what I did then .. give me 15 minutes. I will think of how to deal with this situation when the power comes back later