[00:00:13] superm401: right. I think Munaf erred in using for 'stuff that's one level "down" but I'm going to override heading styling' [00:01:01] spagewmf, I think I could go either way for this particular one. It's arguable that the number is being highlighted, and effectively a headline over the details ('edits') [00:01:12] And there is an h2, which it's logically under. [00:01:50] spagewmf, does Linux Libertine actually work for you [00:01:52] ? [00:01:53] right, I don't know the HTML5 way to say this is a headline over its details, but don't worry about heading levels [00:04:04] superm401: I don't have it, I get ubuntu's fontconfig match for Times. The change does mean someone who used to get the old-style "up and down" numbers from Georgia might get boring Times-ish numbers [00:04:39] spagewmf, FYI, if you want to install it it's ttf-linux-libertine. [00:04:55] I think Firefox's font inspector might be broken. [00:05:36] a font named Libertine is against every moral fiber of my being :) [00:05:40] Ha [00:05:49] It's saying Liberation Sans too too for some reason. [00:06:34] I take it back, 2nd definition of libertine is "freethinker" [00:08:08] (03PS2) 10Krinkle: Update OOjs to v1.0.9 [core] - 10https://gerrit.wikimedia.org/r/123452 (owner: 10Jforrester) [00:08:12] (03PS3) 10Krinkle: Update OOjs to v1.0.9 [core] - 10https://gerrit.wikimedia.org/r/123452 (owner: 10Jforrester) [00:08:22] (03CR) 10Krinkle: [C: 032] Update OOjs to v1.0.9 [core] - 10https://gerrit.wikimedia.org/r/123452 (owner: 10Jforrester) [00:09:43] (03PS18) 10Bsitu: Closing & reopening topic [extensions/Flow] - 10https://gerrit.wikimedia.org/r/118399 [00:13:42] (03Merged) 10jenkins-bot: Update OOjs to v1.0.9 [core] - 10https://gerrit.wikimedia.org/r/123452 (owner: 10Jforrester) [00:17:29] (03CR) 10Mattflaschen: [C: 032] "Looks right, specificity is reasonable given need for override." [core] - 10https://gerrit.wikimedia.org/r/123478 (owner: 10Spage) [00:21:01] (03CR) 10jenkins-bot: [V: 04-1] Adapt signup form numbers to new Vector typography [core] - 10https://gerrit.wikimedia.org/r/123478 (owner: 10Spage) [00:25:23] (03PS1) 10Aaron Schulz: Added per-wiki queue stats information [core] - 10https://gerrit.wikimedia.org/r/123493 [00:25:34] (03PS5) 10CSteipp: Add maintenance script to copy db tables [extensions/OAuth] - 10https://gerrit.wikimedia.org/r/121131 [00:25:49] (03CR) 10CSteipp: Add maintenance script to copy db tables (033 comments) [extensions/OAuth] - 10https://gerrit.wikimedia.org/r/121131 (owner: 10CSteipp) [00:26:42] (03CR) 10GeorgeBarnick: [C: 031] Fix message parsing on Special:EditProfile/Special:UpdateProfile + fix all CSS loading calls to use addModuleStyles() instead of addModules( [extensions/SocialProfile] - 10https://gerrit.wikimedia.org/r/123468 (owner: 10Jack Phoenix) [00:29:08] (03CR) 10jenkins-bot: [V: 04-1] Added per-wiki queue stats information [core] - 10https://gerrit.wikimedia.org/r/123493 (owner: 10Aaron Schulz) [00:30:18] (03CR) 10Mattflaschen: "recheck" [core] - 10https://gerrit.wikimedia.org/r/123478 (owner: 10Spage) [00:31:15] (03PS16) 10Bsitu: Closing & Summarizing topic frontend changes [extensions/Flow] - 10https://gerrit.wikimedia.org/r/119640 [00:32:09] (03PS2) 10Mattflaschen: Adapt signup form numbers to new Vector typography [core] - 10https://gerrit.wikimedia.org/r/123478 (owner: 10Spage) [00:32:46] (03CR) 10Mattflaschen: [C: 032] "Looks like Jenkins may have had a one-off download glitch that caused the QUnit failure. Should not be related." [core] - 10https://gerrit.wikimedia.org/r/123478 (owner: 10Spage) [00:36:35] (03Merged) 10jenkins-bot: Adapt signup form numbers to new Vector typography [core] - 10https://gerrit.wikimedia.org/r/123478 (owner: 10Spage) [00:41:50] (03PS1) 10Aaron Schulz: Removed useless JobQueue return values [core] - 10https://gerrit.wikimedia.org/r/123498 [00:44:51] (03CR) 10Bsitu: Add workflow_type field (031 comment) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/122865 (owner: 10EBernhardson) [00:46:47] (03CR) 10Aaron Schulz: Add maintenance script to copy db tables (031 comment) [extensions/OAuth] - 10https://gerrit.wikimedia.org/r/121131 (owner: 10CSteipp) [00:49:15] (03CR) 10Trevor Parscal: [C: 032] Update OOjs UI to v0.1.0-pre (8986c46d35) [core] - 10https://gerrit.wikimedia.org/r/123167 (owner: 10Jforrester) [00:51:56] (03CR) 10Aaron Schulz: [C: 04-1] Add maintenance script to copy db tables (031 comment) [extensions/OAuth] - 10https://gerrit.wikimedia.org/r/121131 (owner: 10CSteipp) [00:52:24] (03Merged) 10jenkins-bot: Update OOjs UI to v0.1.0-pre (8986c46d35) [core] - 10https://gerrit.wikimedia.org/r/123167 (owner: 10Jforrester) [00:56:14] (03PS2) 10Aaron Schulz: Removed useless JobQueue return values [core] - 10https://gerrit.wikimedia.org/r/123498 [00:56:44] (03CR) 10Hiong3-eng5: "my reply" (034 comments) [extensions/WikiLexicalData] - 10https://gerrit.wikimedia.org/r/119446 (owner: 10Hiong3-eng5) [01:03:49] (03PS1) 10Bsitu: Undrop workflow_definition_id [extensions/Flow] - 10https://gerrit.wikimedia.org/r/123501 [01:05:19] (03PS1) 10Krinkle: mediawiki.html: Add missing @return documentation [core] - 10https://gerrit.wikimedia.org/r/123502 [01:05:55] (03CR) 10Bsitu: "I submitted a patch to add workflow_definition_id back: https://gerrit.wikimedia.org/r/#/c/123501/, it should be dropped in 115576. There" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/122865 (owner: 10EBernhardson) [01:14:38] (03PS5) 10Krinkle: Add extra views (tabs) for files in a foreign repository [core] - 10https://gerrit.wikimedia.org/r/104182 (owner: 10TTO) [01:14:57] (03CR) 10Krinkle: "Rebased to resolve conflict with i18n/*.json" [core] - 10https://gerrit.wikimedia.org/r/104182 (owner: 10TTO) [01:18:34] (03CR) 10Krinkle: [C: 031] "Not yet tested in IE, but code looks good and is correct if memory serves." [core] - 10https://gerrit.wikimedia.org/r/116227 (owner: 10Brian Wolff) [01:20:23] (03PS1) 10Aaron Schulz: Made runJobs.php fully respect $wgJobBackoffThrottling [core] - 10https://gerrit.wikimedia.org/r/123504 [01:20:45] (03PS2) 10Aaron Schulz: Added per-wiki queue stats information [core] - 10https://gerrit.wikimedia.org/r/123493 [02:09:40] (03CR) 10Mattflaschen: [C: 04-1] "Nice job; good use of SinonJS on the tests." (0314 comments) [core] - 10https://gerrit.wikimedia.org/r/120806 (owner: 10Phuedx) [02:25:15] (03PS1) 10Anorange0409: try [test/mediawiki/extensions/examples] - 10https://gerrit.wikimedia.org/r/123506 [03:15:11] spagewmf: Thanks for the comment on the design pattern library. :-) [03:17:20] Gloria: bug commenting is easy, implementing Special:DesignSamples/someRandomDocGenerator.html is the hard part :) [03:32:19] (03CR) 10Mattflaschen: "Also, please add this to RELEASE-NOTES-1.23, under features." [core] - 10https://gerrit.wikimedia.org/r/120806 (owner: 10Phuedx) [03:51:34] (03CR) 10Mattflaschen: "Please document how to delete cookies." (031 comment) [core] - 10https://gerrit.wikimedia.org/r/120806 (owner: 10Phuedx) [03:52:21] (03PS1) 10Jackmcbarn: Make RECOVER_ORIG preserve extension tags [core] - 10https://gerrit.wikimedia.org/r/123516 [03:55:44] (03CR) 10Mattflaschen: [C: 031] "Looks good, will test when mw.cookie is merged." [core] - 10https://gerrit.wikimedia.org/r/122423 (owner: 10Phuedx) [04:18:35] (03CR) 10Spage: "return;" (031 comment) [core] - 10https://gerrit.wikimedia.org/r/112641 (owner: 10Chad) [04:24:14] (03CR) 10Spage: [C: 032] "I'm +2ing this because ee-flow is crashing with "1054 Unknown column 'workflow_definition_id' in 'where clause'" on "SELECT * FROM `flow_w" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/123501 (owner: 10Bsitu) [04:24:31] (03Merged) 10jenkins-bot: Undrop workflow_definition_id [extensions/Flow] - 10https://gerrit.wikimedia.org/r/123501 (owner: 10Bsitu) [04:28:11] (03CR) 10Mattflaschen: [C: 04-1] "I also need to review in more depth (if someone doesn't beat me to it)." [core] - 10https://gerrit.wikimedia.org/r/122838 (owner: 10Phuedx) [04:45:20] (03PS1) 10PleaseStand: FormatJson: Make it possible to change the indent string [core] - 10https://gerrit.wikimedia.org/r/123518 [04:56:10] (03CR) 10Parent5446: [C: 04-1] Adds an --extension option to generateJsonI18n (034 comments) [core] - 10https://gerrit.wikimedia.org/r/122659 (owner: 10Adamw) [05:00:53] (03CR) 10Parent5446: [C: 04-1] Add --supplementary flag to generateJsonI18n (032 comments) [core] - 10https://gerrit.wikimedia.org/r/122664 (owner: 10Adamw) [05:01:26] (03PS1) 10Santhosh: Segmentation: Fix the wrong usage of section types [services/cxserver] - 10https://gerrit.wikimedia.org/r/123519 [05:05:35] (03CR) 10Gilles: [C: 031] Update jquery.fullscreen to newer version (fix IE11 support) [core] - 10https://gerrit.wikimedia.org/r/122648 (owner: 10Gilles) [05:08:31] (03PS2) 10PleaseStand: FormatJson: Make it possible to change the indent string [core] - 10https://gerrit.wikimedia.org/r/123518 [05:16:12] (03CR) 10Mattflaschen: "What do you mean, "it looks there is no localisation yet."? It seems to be working for me on the languages I tested (e.g. bottom of http:" [extensions/MwEmbedSupport] - 10https://gerrit.wikimedia.org/r/121950 (owner: 10Siebrand) [05:17:08] (03PS7) 10Bsitu: Add summarize/close/open topic to history/contribution [extensions/Flow] - 10https://gerrit.wikimedia.org/r/123123 [05:17:16] (03CR) 10jenkins-bot: [V: 04-1] Add summarize/close/open topic to history/contribution [extensions/Flow] - 10https://gerrit.wikimedia.org/r/123123 (owner: 10Bsitu) [05:17:26] (03CR) 10Bsitu: [C: 04-1] Add summarize/close/open topic to history/contribution [extensions/Flow] - 10https://gerrit.wikimedia.org/r/123123 (owner: 10Bsitu) [05:20:55] (03PS4) 10Bsitu: Add topic/post summary diff view [extensions/Flow] - 10https://gerrit.wikimedia.org/r/121128 [05:20:58] (03CR) 10jenkins-bot: [V: 04-1] Add topic/post summary diff view [extensions/Flow] - 10https://gerrit.wikimedia.org/r/121128 (owner: 10Bsitu) [05:21:44] (03CR) 10Bsitu: [C: 04-1] "new i18n message was lost during rebase, need to add them back" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/121128 (owner: 10Bsitu) [06:44:22] (03PS1) 10Santhosh: Segmentation: Reference handling improvements [services/cxserver] - 10https://gerrit.wikimedia.org/r/123522 [06:53:31] (03PS3) 10Physikerwelt: Improve UpdateMath script [extensions/MathSearch] - 10https://gerrit.wikimedia.org/r/123355 [06:54:14] (03CR) 10Physikerwelt: [C: 032] Improve UpdateMath script [extensions/MathSearch] - 10https://gerrit.wikimedia.org/r/123355 (owner: 10Physikerwelt) [06:54:18] (03Merged) 10jenkins-bot: Improve UpdateMath script [extensions/MathSearch] - 10https://gerrit.wikimedia.org/r/123355 (owner: 10Physikerwelt) [06:59:55] (03CR) 10Raimond Spekking: Changing audio/ directory to assets/ (031 comment) [extensions/MediaWikiChat] - 10https://gerrit.wikimedia.org/r/123425 (owner: 10GeorgeBarnick) [07:05:05] (03PS1) 10Raimond Spekking: Add newline at end of file to unbreak translatewiki.net scripts [extensions/BlueSpiceFoundation] - 10https://gerrit.wikimedia.org/r/123524 [07:05:18] (03CR) 10Raimond Spekking: [C: 032 V: 032] Add newline at end of file to unbreak translatewiki.net scripts [extensions/BlueSpiceFoundation] - 10https://gerrit.wikimedia.org/r/123524 (owner: 10Raimond Spekking) [07:14:21] (03CR) 10Siebrand: "Matt: It's working. It's just that the patch at the stage where I made that comment wasn't working yet." [extensions/MwEmbedSupport] - 10https://gerrit.wikimedia.org/r/121950 (owner: 10Siebrand) [07:28:19] (03PS1) 10Siebrand: Migrate to JSON i18n [extensions/LinkedWiki] - 10https://gerrit.wikimedia.org/r/123526 [07:31:06] (03CR) 10Nikerabbit: [C: 031] "Fortunately spaces and tabs evaluate to true in PHP so this degrades gracefully if extension tries to use this on older PHP." [core] - 10https://gerrit.wikimedia.org/r/123518 (owner: 10PleaseStand) [07:32:29] (03PS1) 10Siebrand: Migrate to JSON i18n [extensions/NSFileRepo] - 10https://gerrit.wikimedia.org/r/123527 [07:36:06] (03PS1) 10Siebrand: Migrate to JSON i18n [extensions/OfflineImportLexicon] - 10https://gerrit.wikimedia.org/r/123528 [07:37:34] (03PS1) 10Siebrand: Migrate to JSON i18n [extensions/skins] - 10https://gerrit.wikimedia.org/r/123529 [07:39:17] (03CR) 10Nikerabbit: [C: 032] mediawiki.html: Add missing @return documentation [core] - 10https://gerrit.wikimedia.org/r/123502 (owner: 10Krinkle) [07:39:20] (03PS1) 10Siebrand: Migrate to JSON i18n [extensions/ThemeDesigner] - 10https://gerrit.wikimedia.org/r/123530 [07:40:44] (03PS1) 10Siebrand: Migrate to JSON i18n [extensions/WebFonts] - 10https://gerrit.wikimedia.org/r/123531 [07:42:21] (03PS1) 10Siebrand: Migrate to JSON i18n [extensions/WYSIWYG] - 10https://gerrit.wikimedia.org/r/123532 [07:42:45] (03Merged) 10jenkins-bot: mediawiki.html: Add missing @return documentation [core] - 10https://gerrit.wikimedia.org/r/123502 (owner: 10Krinkle) [08:01:00] (03PS1) 10Hashar: puppetlint jobs for translatewiki repo [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/123535 [08:04:57] (03CR) 10Hashar: [C: 032] puppetlint jobs for translatewiki repo [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/123535 (owner: 10Hashar) [08:05:32] (03Merged) 10jenkins-bot: puppetlint jobs for translatewiki repo [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/123535 (owner: 10Hashar) [08:06:36] (03PS1) 10Siebrand: Migrate to JSON i18n [extensions/WikiLexicalData] - 10https://gerrit.wikimedia.org/r/123536 [08:06:53] (03PS1) 10Hashar: puppetlint jobs for translatewiki repo [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/123537 [08:08:05] (03CR) 10Hashar: [C: 032] puppetlint jobs for translatewiki repo [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/123537 (owner: 10Hashar) [08:08:09] (03Merged) 10jenkins-bot: puppetlint jobs for translatewiki repo [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/123537 (owner: 10Hashar) [08:09:12] (03PS2) 10Siebrand: Migrate to JSON i18n [extensions/WikiLexicalData] - 10https://gerrit.wikimedia.org/r/123536 [08:33:29] (03PS1) 10Siebrand: Migrate to JSON i18n [extensions/BlueSpiceFoundation] - 10https://gerrit.wikimedia.org/r/123539 [08:45:16] (03PS1) 10Siebrand: Replace deprecated/removed $wgExtensionAliasesFiles [extensions/BibManager] - 10https://gerrit.wikimedia.org/r/123541 [08:45:34] (03PS2) 10Siebrand: Replace deprecated/removed $wgExtensionAliasesFiles [extensions/BibManager] - 10https://gerrit.wikimedia.org/r/123541 [08:47:26] (03PS1) 10Siebrand: Replace deprecated/removed $wgExtensionAliasesFiles [extensions/FacebookOpenGraph] - 10https://gerrit.wikimedia.org/r/123543 [08:48:24] (03PS1) 10Siebrand: Replace deprecated/removed $wgExtensionAliasesFiles [extensions/LinkedWiki] - 10https://gerrit.wikimedia.org/r/123544 [08:48:41] (03PS6) 10Hiong3-eng5: MW WLD prefix compatibility fix [extensions/WikiLexicalData] - 10https://gerrit.wikimedia.org/r/119446 [08:49:07] (03PS1) 10Siebrand: Replace deprecated/removed $wgExtensionAliasesFiles [extensions/OdbcDatabase] - 10https://gerrit.wikimedia.org/r/123545 [08:49:39] (03PS1) 10Siebrand: Replace deprecated/removed $wgExtensionAliasesFiles [extensions/OfflineImportLexicon] - 10https://gerrit.wikimedia.org/r/123546 [08:50:41] (03PS1) 10Siebrand: Replace deprecated/removed $wgExtensionAliasesFiles [extensions/PdfExport] - 10https://gerrit.wikimedia.org/r/123547 [08:51:00] (03PS1) 10Siebrand: Replace deprecated/removed $wgExtensionAliasesFiles [extensions/SocialLogin] - 10https://gerrit.wikimedia.org/r/123548 [08:52:16] (03PS1) 10Siebrand: Replace deprecated/removed $wgExtensionAliasesFiles [extensions/UpdateMediaWiki] - 10https://gerrit.wikimedia.org/r/123550 [08:58:25] (03PS1) 10Siebrand: Migrate to JSON i18n [extensions/ArticleIndex] - 10https://gerrit.wikimedia.org/r/123551 [09:01:03] (03CR) 10Hiong3-eng5: "This change does have the ability to install multiple datasets for OmegaWiki. The problem is that all datasets have dmid of 0. I do not kn" [extensions/WikiLexicalData] - 10https://gerrit.wikimedia.org/r/119446 (owner: 10Hiong3-eng5) [09:01:28] (03PS1) 10Siebrand: Migrate to JSON i18n [extensions/Awesomeness] - 10https://gerrit.wikimedia.org/r/123552 [09:05:02] (03PS1) 10Siebrand: Migrate to JSON i18n [extensions/CategorySlideShow] - 10https://gerrit.wikimedia.org/r/123554 [09:09:32] (03PS1) 10Siebrand: Migrate to JSON i18n [extensions/CommunityApplications] - 10https://gerrit.wikimedia.org/r/123555 [09:12:28] (03PS1) 10Siebrand: Migrate to JSON i18n [extensions/examples] - 10https://gerrit.wikimedia.org/r/123556 [09:12:51] (03PS2) 10Siebrand: Migrate to JSON i18n [extensions/examples] - 10https://gerrit.wikimedia.org/r/123556 [09:37:38] (03PS1) 10Gerrit Patch Uploader: Deprecate mw.util.$content [core] - 10https://gerrit.wikimedia.org/r/123559 [09:37:41] (03CR) 10Gerrit Patch Uploader: "This commit was uploaded using the Gerrit Patch Uploader [1]." [core] - 10https://gerrit.wikimedia.org/r/123559 (owner: 10Gerrit Patch Uploader) [09:38:53] (03CR) 10jenkins-bot: [V: 04-1] Deprecate mw.util.$content [core] - 10https://gerrit.wikimedia.org/r/123559 (owner: 10Gerrit Patch Uploader) [09:41:41] (03PS1) 10Siebrand: Add $wgMessagesDirs [extensions/DynamicPageList] - 10https://gerrit.wikimedia.org/r/123561 [09:46:53] (03PS1) 10Siebrand: Migrate to JSON i18n [extensions/examples] - 10https://gerrit.wikimedia.org/r/123564 [09:48:50] (03PS3) 10Siebrand: Migrate to JSON i18n [extensions/examples] - 10https://gerrit.wikimedia.org/r/123556 [09:49:00] (03Abandoned) 10Siebrand: Migrate to JSON i18n [extensions/examples] - 10https://gerrit.wikimedia.org/r/123564 (owner: 10Siebrand) [09:49:33] (03PS2) 10Gerrit Patch Uploader: Deprecate mw.util.$content [core] - 10https://gerrit.wikimedia.org/r/123559 [09:49:35] (03CR) 10Gerrit Patch Uploader: "This commit was uploaded using the Gerrit Patch Uploader [1]." [core] - 10https://gerrit.wikimedia.org/r/123559 (owner: 10Gerrit Patch Uploader) [09:49:42] (03PS4) 10Siebrand: Migrate to JSON i18n [extensions/examples] - 10https://gerrit.wikimedia.org/r/123556 [09:52:39] (03PS1) 10Siebrand: Migrate to JSON i18n [extensions/FeedsFromPrivateWikis] - 10https://gerrit.wikimedia.org/r/123565 [09:57:16] unable access gerrit from the web currently [09:58:50] (03PS1) 10Siebrand: Fix loading of messages using $wgMessagesDirs [extensions/FlaggedRevs] - 10https://gerrit.wikimedia.org/r/123567 [09:59:41] wfm; usual temporary shocks I guess? [10:06:07] (03PS2) 10Phuedx: Sanity check category names at runtime [extensions/GettingStarted] - 10https://gerrit.wikimedia.org/r/122856 [10:11:09] (03PS2) 10Siebrand: Fix loading of messages using $wgMessagesDirs [extensions/FlaggedRevs] - 10https://gerrit.wikimedia.org/r/123567 [10:12:11] (03CR) 10Phuedx: "If I could somehow erase PS1, then I would… I'm not sure how I missed `!$title->inNamespace()` but I did." [extensions/GettingStarted] - 10https://gerrit.wikimedia.org/r/122856 (owner: 10Phuedx) [10:16:05] (03PS1) 10Nik: Added test group PubSubHubbub. [extensions/PubSubHubbub] - 10https://gerrit.wikimedia.org/r/123571 [10:16:26] (03CR) 10WikidataJenkins: "Build Failed" [extensions/PubSubHubbub] - 10https://gerrit.wikimedia.org/r/123571 (owner: 10Nik) [10:16:28] (03CR) 10Nik: [C: 032 V: 032] Added test group PubSubHubbub. [extensions/PubSubHubbub] - 10https://gerrit.wikimedia.org/r/123571 (owner: 10Nik) [10:16:54] (03PS1) 10Siebrand: Complete migration to JSON i18n [extensions/GlobalUserGroups] - 10https://gerrit.wikimedia.org/r/123572 [10:17:40] (03PS2) 10Siebrand: Complete migration to JSON i18n [extensions/GlobalUserGroups] - 10https://gerrit.wikimedia.org/r/123572 [10:19:57] (03CR) 10Prtksxna: "Thank you so much for this! I always get confused with a space after that function name, still getting used to this spacing convention :)" (032 comments) [extensions/Popups] - 10https://gerrit.wikimedia.org/r/123190 (owner: 10Santhosh) [10:20:41] (03PS1) 10Siebrand: Import globals consistently [extensions/HidePrefix] - 10https://gerrit.wikimedia.org/r/123574 [10:20:43] (03CR) 10WikidataJenkins: "Build Successful" [extensions/PubSubHubbub] - 10https://gerrit.wikimedia.org/r/123571 (owner: 10Nik) [10:22:19] (03PS1) 10Siebrand: Post $wgMessagesDirs above $wgExtensionMessagesFiles [extensions/HostStats] - 10https://gerrit.wikimedia.org/r/123577 [10:29:20] (03PS1) 10Siebrand: Migrate to JSON i18n [extensions/Interlanguage] - 10https://gerrit.wikimedia.org/r/123578 [10:31:02] (03PS1) 10Nik: Fixed PHPUnit tests. [extensions/PubSubHubbub] - 10https://gerrit.wikimedia.org/r/123579 [10:31:36] (03CR) 10WikidataJenkins: "Build Failed" [extensions/PubSubHubbub] - 10https://gerrit.wikimedia.org/r/123579 (owner: 10Nik) [10:36:35] (03CR) 10WikidataJenkins: [V: 04-1] "Build Failed" [extensions/PubSubHubbub] - 10https://gerrit.wikimedia.org/r/123579 (owner: 10Nik) [10:38:12] (03CR) 10Nik: [C: 032 V: 032] Fixed PHPUnit tests. [extensions/PubSubHubbub] - 10https://gerrit.wikimedia.org/r/123579 (owner: 10Nik) [10:43:09] (03PS2) 10Prtksxna: Use document.createElementNS for svg image [extensions/Popups] - 10https://gerrit.wikimedia.org/r/122352 [10:43:15] (03CR) 10jenkins-bot: [V: 04-1] Use document.createElementNS for svg image [extensions/Popups] - 10https://gerrit.wikimedia.org/r/122352 (owner: 10Prtksxna) [10:44:33] (03PS3) 10Prtksxna: Use document.createElementNS for svg image [extensions/Popups] - 10https://gerrit.wikimedia.org/r/122352 [10:44:42] (03CR) 10Prtksxna: Use document.createElementNS for svg image (031 comment) [extensions/Popups] - 10https://gerrit.wikimedia.org/r/122352 (owner: 10Prtksxna) [10:48:49] (03PS1) 10Siebrand: Migrate to JSON i18n [extensions/JsonData] - 10https://gerrit.wikimedia.org/r/123580 [10:52:11] (03PS1) 10Siebrand: Migrate to JSON i18n [extensions/Moodle] - 10https://gerrit.wikimedia.org/r/123581 [10:56:22] (03PS1) 10Siebrand: Some cleanup [extensions/NetworkAuth] - 10https://gerrit.wikimedia.org/r/123582 [10:58:07] (03PS1) 10Siebrand: Migrate to JSON i18n [extensions/Newsletter] - 10https://gerrit.wikimedia.org/r/123583 [11:02:45] (03PS1) 10Siebrand: Migrate to JSON i18n [extensions/skins] - 10https://gerrit.wikimedia.org/r/123584 [11:13:15] (03CR) 10Santhosh: Misc code formatting cleanup (032 comments) [extensions/Popups] - 10https://gerrit.wikimedia.org/r/123190 (owner: 10Santhosh) [11:14:16] (03PS1) 10Siebrand: Migrate to JSON i18n [extensions/QuizTabulate] - 10https://gerrit.wikimedia.org/r/123588 [11:16:30] (03PS1) 10Siebrand: Migrate to JSON i18n [extensions/RandomFeaturedUser] - 10https://gerrit.wikimedia.org/r/123589 [11:31:42] (03PS1) 10Nik: Used a different hook to prevent Link headers from being generated twice. [extensions/PubSubHubbub] - 10https://gerrit.wikimedia.org/r/123590 [11:32:07] (03CR) 10WikidataJenkins: [V: 04-1] "Build Failed" [extensions/PubSubHubbub] - 10https://gerrit.wikimedia.org/r/123590 (owner: 10Nik) [11:34:56] (03PS1) 10Siebrand: Use correct global [extensions/SideBarMenu] - 10https://gerrit.wikimedia.org/r/123593 [11:37:35] (03PS1) 10Ori.livneh: lint [vagrant] - 10https://gerrit.wikimedia.org/r/123594 [11:37:47] (03CR) 10Ori.livneh: [C: 032] lint [vagrant] - 10https://gerrit.wikimedia.org/r/123594 (owner: 10Ori.livneh) [11:38:00] (03PS1) 10Santhosh: Segmentation: Handle the case of repeated references [services/cxserver] - 10https://gerrit.wikimedia.org/r/123596 [11:38:37] (03PS1) 10Siebrand: Remove empty i18n file [extensions/SkelJS] - 10https://gerrit.wikimedia.org/r/123597 [11:40:33] (03PS2) 10Nik: Used a different hook to prevent Link headers from being generated twice. [extensions/PubSubHubbub] - 10https://gerrit.wikimedia.org/r/123590 [11:41:01] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/PubSubHubbub] - 10https://gerrit.wikimedia.org/r/123590 (owner: 10Nik) [11:45:36] (03PS1) 10Siebrand: Remove unneeded and/or duplicate globals [extensions/Offline] - 10https://gerrit.wikimedia.org/r/123599 [11:49:32] (03CR) 10Nikerabbit: [C: 04-1] Migrate to JSON i18n (032 comments) [extensions/Wikilog] - 10https://gerrit.wikimedia.org/r/123372 (owner: 10Siebrand) [11:51:02] (03CR) 10Nikerabbit: [C: 032] Migrate to JSON i18n [extensions/LinkedWiki] - 10https://gerrit.wikimedia.org/r/123526 (owner: 10Siebrand) [11:51:05] (03Merged) 10jenkins-bot: Migrate to JSON i18n [extensions/LinkedWiki] - 10https://gerrit.wikimedia.org/r/123526 (owner: 10Siebrand) [11:52:04] (03CR) 10Raimond Spekking: [C: 032 V: 032] Migrate to JSON i18n [extensions/ArticleIndex] - 10https://gerrit.wikimedia.org/r/123551 (owner: 10Siebrand) [11:52:49] (03CR) 10Raimond Spekking: [C: 032 V: 032] Migrate to JSON i18n [extensions/BlueSpiceFoundation] - 10https://gerrit.wikimedia.org/r/123539 (owner: 10Siebrand) [11:53:08] (03PS2) 10Siebrand: Migrate to JSON i18n [extensions/Wikilog] - 10https://gerrit.wikimedia.org/r/123372 [11:53:41] (03CR) 10Raimond Spekking: [C: 032 V: 032] Migrate to JSON i18n [extensions/WikiLexicalData] - 10https://gerrit.wikimedia.org/r/123536 (owner: 10Siebrand) [11:55:40] (03CR) 10Raimond Spekking: [C: 032 V: 032] Migrate to JSON i18n [extensions/ThemeDesigner] - 10https://gerrit.wikimedia.org/r/123530 (owner: 10Siebrand) [11:56:02] (03CR) 10Raimond Spekking: [C: 032] Migrate to JSON i18n [extensions/WebFonts] - 10https://gerrit.wikimedia.org/r/123531 (owner: 10Siebrand) [11:56:05] (03Merged) 10jenkins-bot: Migrate to JSON i18n [extensions/WebFonts] - 10https://gerrit.wikimedia.org/r/123531 (owner: 10Siebrand) [11:57:55] (03CR) 10Raimond Spekking: [C: 032 V: 032] Migrate to JSON i18n [extensions/OfflineImportLexicon] - 10https://gerrit.wikimedia.org/r/123528 (owner: 10Siebrand) [11:58:43] (03CR) 10Raimond Spekking: [C: 04-1] "Windows line endings." [extensions/WYSIWYG] - 10https://gerrit.wikimedia.org/r/123532 (owner: 10Siebrand) [11:58:55] (03PS1) 10Siebrand: Migrate to JSON i18n [extensions/Tabs] - 10https://gerrit.wikimedia.org/r/123602 [12:00:44] (03CR) 10Raimond Spekking: [C: 032 V: 032] Migrate to JSON i18n [extensions/NSFileRepo] - 10https://gerrit.wikimedia.org/r/123527 (owner: 10Siebrand) [12:02:05] (03CR) 10Raimond Spekking: [C: 04-1] "is this change necessary? Nimbus repo is now outside of the extension folder in a new /skin repo folder" [extensions/skins] - 10https://gerrit.wikimedia.org/r/123529 (owner: 10Siebrand) [12:02:42] (03CR) 10Siebrand: "If this is dead code, it should probably be removed. It is?" [extensions/skins] - 10https://gerrit.wikimedia.org/r/123529 (owner: 10Siebrand) [12:02:46] (03CR) 10Raimond Spekking: [C: 032] Migrate to JSON i18n [extensions/CommunityApplications] - 10https://gerrit.wikimedia.org/r/123555 (owner: 10Siebrand) [12:02:48] (03Merged) 10jenkins-bot: Migrate to JSON i18n [extensions/CommunityApplications] - 10https://gerrit.wikimedia.org/r/123555 (owner: 10Siebrand) [12:03:14] (03CR) 10Raimond Spekking: [C: 032 V: 032] Migrate to JSON i18n [extensions/CategorySlideShow] - 10https://gerrit.wikimedia.org/r/123554 (owner: 10Siebrand) [12:04:22] (03CR) 10Raimond Spekking: [C: 032 V: 032] Migrate to JSON i18n [extensions/Awesomeness] - 10https://gerrit.wikimedia.org/r/123552 (owner: 10Siebrand) [12:04:59] (03CR) 10Raimond Spekking: [C: 032 V: 032] Add $wgMessagesDirs [extensions/DynamicPageList] - 10https://gerrit.wikimedia.org/r/123561 (owner: 10Siebrand) [12:06:11] (03CR) 10Raimond Spekking: [C: 032 V: 032] Migrate to JSON i18n [extensions/FeedsFromPrivateWikis] - 10https://gerrit.wikimedia.org/r/123565 (owner: 10Siebrand) [12:06:32] (03CR) 10Santhosh: [C: 04-1] Segmentation: Handle the case of repeated references (031 comment) [services/cxserver] - 10https://gerrit.wikimedia.org/r/123596 (owner: 10Santhosh) [12:06:40] (03CR) 10Raimond Spekking: [C: 032 V: 032] Migrate to JSON i18n [extensions/examples] - 10https://gerrit.wikimedia.org/r/123556 (owner: 10Siebrand) [12:08:44] (03CR) 10Raimond Spekking: [C: 032] Fix loading of messages using $wgMessagesDirs [extensions/FlaggedRevs] - 10https://gerrit.wikimedia.org/r/123567 (owner: 10Siebrand) [12:08:49] (03Merged) 10jenkins-bot: Fix loading of messages using $wgMessagesDirs [extensions/FlaggedRevs] - 10https://gerrit.wikimedia.org/r/123567 (owner: 10Siebrand) [12:09:35] (03CR) 10Raimond Spekking: [C: 032 V: 032] Import globals consistently [extensions/HidePrefix] - 10https://gerrit.wikimedia.org/r/123574 (owner: 10Siebrand) [12:10:03] (03CR) 10Raimond Spekking: [C: 032 V: 032] Post $wgMessagesDirs above $wgExtensionMessagesFiles [extensions/HostStats] - 10https://gerrit.wikimedia.org/r/123577 (owner: 10Siebrand) [12:10:05] (03PS1) 10Siebrand: Migrate to JSON i18n [extensions/TimelineTable] - 10https://gerrit.wikimedia.org/r/123604 [12:11:41] (03PS1) 10Siebrand: Remove duplicate global [extensions/UIFeedback] - 10https://gerrit.wikimedia.org/r/123605 [12:14:45] (03CR) 10Nikerabbit: [C: 04-1] Migrate to JSON i18n (031 comment) [extensions/QuizTabulate] - 10https://gerrit.wikimedia.org/r/123588 (owner: 10Siebrand) [12:15:26] (03CR) 10Nikerabbit: [C: 032 V: 032] Migrate to JSON i18n [extensions/RandomFeaturedUser] - 10https://gerrit.wikimedia.org/r/123589 (owner: 10Siebrand) [12:16:54] (03PS1) 10Siebrand: Remove empty i18n file [extensions/Views] - 10https://gerrit.wikimedia.org/r/123608 [12:17:22] (03CR) 10Nikerabbit: [C: 032] Migrate to JSON i18n [extensions/JsonData] - 10https://gerrit.wikimedia.org/r/123580 (owner: 10Siebrand) [12:17:29] (03Merged) 10jenkins-bot: Migrate to JSON i18n [extensions/JsonData] - 10https://gerrit.wikimedia.org/r/123580 (owner: 10Siebrand) [12:18:06] (03CR) 10Nikerabbit: [C: 032] Migrate to JSON i18n [extensions/skins] - 10https://gerrit.wikimedia.org/r/123584 (owner: 10Siebrand) [12:18:09] (03Merged) 10jenkins-bot: Migrate to JSON i18n [extensions/skins] - 10https://gerrit.wikimedia.org/r/123584 (owner: 10Siebrand) [12:18:40] (03CR) 10Manybubbles: [C: 04-1] "small comments" (032 comments) [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/123115 (owner: 10Chad) [12:19:03] (03CR) 10Nikerabbit: [C: 032 V: 032] Remove empty i18n file [extensions/SkelJS] - 10https://gerrit.wikimedia.org/r/123597 (owner: 10Siebrand) [12:20:12] (03PS2) 10Siebrand: Migrate to JSON i18n [extensions/WYSIWYG] - 10https://gerrit.wikimedia.org/r/123532 [12:20:14] (03CR) 10Nikerabbit: [C: 032 V: 032] Migrate to JSON i18n [extensions/TimelineTable] - 10https://gerrit.wikimedia.org/r/123604 (owner: 10Siebrand) [12:22:02] (03CR) 10Nikerabbit: [C: 032] Replace deprecated/removed $wgExtensionAliasesFiles [extensions/LinkedWiki] - 10https://gerrit.wikimedia.org/r/123544 (owner: 10Siebrand) [12:22:04] (03Merged) 10jenkins-bot: Replace deprecated/removed $wgExtensionAliasesFiles [extensions/LinkedWiki] - 10https://gerrit.wikimedia.org/r/123544 (owner: 10Siebrand) [12:22:23] (03CR) 10Nikerabbit: [C: 032 V: 032] Replace deprecated/removed $wgExtensionAliasesFiles [extensions/OfflineImportLexicon] - 10https://gerrit.wikimedia.org/r/123546 (owner: 10Siebrand) [12:23:20] Anyone familiar with W0 around? [12:23:31] I'm wondering if maintenance/ETLZeroData.php is still being used. [12:23:59] (03CR) 10Raimond Spekking: [C: 032 V: 032] Migrate to JSON i18n [extensions/WYSIWYG] - 10https://gerrit.wikimedia.org/r/123532 (owner: 10Siebrand) [12:24:29] (03CR) 10Nikerabbit: [C: 032 V: 032] Migrate to JSON i18n [extensions/Interlanguage] - 10https://gerrit.wikimedia.org/r/123578 (owner: 10Siebrand) [12:25:04] (03CR) 10Nikerabbit: [C: 032 V: 032] Some cleanup [extensions/NetworkAuth] - 10https://gerrit.wikimedia.org/r/123582 (owner: 10Siebrand) [12:27:29] (03CR) 10Siebrand: Migrate to JSON i18n (031 comment) [extensions/QuizTabulate] - 10https://gerrit.wikimedia.org/r/123588 (owner: 10Siebrand) [12:28:45] (03CR) 10Raimond Spekking: [C: 032 V: 032] Migrate to JSON i18n [extensions/Moodle] - 10https://gerrit.wikimedia.org/r/123581 (owner: 10Siebrand) [12:28:50] (03PS2) 10Siebrand: Migrate to JSON i18n [extensions/QuizTabulate] - 10https://gerrit.wikimedia.org/r/123588 [12:29:14] (03CR) 10Raimond Spekking: [C: 032 V: 032] Migrate to JSON i18n [extensions/Newsletter] - 10https://gerrit.wikimedia.org/r/123583 (owner: 10Siebrand) [12:30:44] (03CR) 10Nikerabbit: [C: 04-1] "Variable name needs change." [extensions/BibManager] - 10https://gerrit.wikimedia.org/r/123541 (owner: 10Siebrand) [12:31:59] (03CR) 10Raimond Spekking: [C: 032 V: 032] Migrate to JSON i18n [extensions/Wikilog] - 10https://gerrit.wikimedia.org/r/123372 (owner: 10Siebrand) [12:32:02] (03PS1) 10Siebrand: Migrate to JSON i18n [extensions/WantedPagesFromNS] - 10https://gerrit.wikimedia.org/r/123611 [12:32:23] (03CR) 10Raimond Spekking: [C: 032 V: 032] Migrate to JSON i18n [extensions/Tabs] - 10https://gerrit.wikimedia.org/r/123602 (owner: 10Siebrand) [12:34:34] (03CR) 10Raimond Spekking: "See https://translatewiki.net/wiki/Thread:Support/Nimbus_skin_i18n_is_going_to_the_wrong_place#Nimbus_skin_i18n_is_going_to_the_wrong_plac" [extensions/skins] - 10https://gerrit.wikimedia.org/r/123529 (owner: 10Siebrand) [12:34:49] (03PS1) 10Nikerabbit: Use $specialPageAliases [extensions/LinkedWiki] - 10https://gerrit.wikimedia.org/r/123612 [12:36:42] (03PS1) 10Nikerabbit: Use $specialPageAliases [extensions/OfflineImportLexicon] - 10https://gerrit.wikimedia.org/r/123613 [12:37:02] (03PS1) 10Siebrand: Use unique identifier for InfoPage key [extensions/WikimediaIncubator] - 10https://gerrit.wikimedia.org/r/123614 [12:37:34] (03CR) 10WikidataJenkins: "Build Successful" [extensions/PubSubHubbub] - 10https://gerrit.wikimedia.org/r/123590 (owner: 10Nik) [12:39:21] (03CR) 10Manybubbles: [C: 031] "I don't have any objections. Funny: Cirrus actually does this in reverse as well. It has a search mode that always returns titles and it" [core] - 10https://gerrit.wikimedia.org/r/123118 (owner: 10MaxSem) [12:42:54] (03Abandoned) 10Siebrand: Migrate to JSON i18n [extensions/skins] - 10https://gerrit.wikimedia.org/r/123529 (owner: 10Siebrand) [12:43:00] (03PS2) 10Nikerabbit: Replace deprecated/removed $wgExtensionAliasesFiles [extensions/FacebookOpenGraph] - 10https://gerrit.wikimedia.org/r/123543 (owner: 10Siebrand) [12:43:37] (03CR) 10Nikerabbit: [C: 032 V: 032] Replace deprecated/removed $wgExtensionAliasesFiles [extensions/FacebookOpenGraph] - 10https://gerrit.wikimedia.org/r/123543 (owner: 10Siebrand) [12:44:04] (03PS1) 10Siebrand: Remove Nimbus skin - moved to another repo [extensions/skins] - 10https://gerrit.wikimedia.org/r/123625 [12:44:11] (03CR) 10WikidataJenkins: "Build Successful" [extensions/PubSubHubbub] - 10https://gerrit.wikimedia.org/r/123590 (owner: 10Nik) [12:45:36] (03PS2) 10Nikerabbit: Replace deprecated/removed $wgExtensionAliasesFiles [extensions/OdbcDatabase] - 10https://gerrit.wikimedia.org/r/123545 (owner: 10Siebrand) [12:45:49] (03CR) 10Nikerabbit: [C: 031] Replace deprecated/removed $wgExtensionAliasesFiles [extensions/OdbcDatabase] - 10https://gerrit.wikimedia.org/r/123545 (owner: 10Siebrand) [12:46:27] (03CR) 10Nikerabbit: [C: 032 V: 032] Replace deprecated/removed $wgExtensionAliasesFiles [extensions/PdfExport] - 10https://gerrit.wikimedia.org/r/123547 (owner: 10Siebrand) [12:46:31] (03PS1) 10Siebrand: Migrate to JSON i18n [extensions/WikiTwidget] - 10https://gerrit.wikimedia.org/r/123627 [12:48:09] (03CR) 10WikidataJenkins: "Build Successful" [extensions/PubSubHubbub] - 10https://gerrit.wikimedia.org/r/123590 (owner: 10Nik) [12:48:23] (03PS2) 10Nikerabbit: Replace deprecated/removed $wgExtensionAliasesFiles [extensions/SocialLogin] - 10https://gerrit.wikimedia.org/r/123548 (owner: 10Siebrand) [12:48:34] (03CR) 10Nikerabbit: [C: 031] Replace deprecated/removed $wgExtensionAliasesFiles [extensions/SocialLogin] - 10https://gerrit.wikimedia.org/r/123548 (owner: 10Siebrand) [12:51:21] (03PS2) 10Nikerabbit: Replace deprecated/removed $wgExtensionAliasesFiles [extensions/UpdateMediaWiki] - 10https://gerrit.wikimedia.org/r/123550 (owner: 10Siebrand) [12:51:39] (03CR) 10Nikerabbit: [C: 031] Replace deprecated/removed $wgExtensionAliasesFiles [extensions/UpdateMediaWiki] - 10https://gerrit.wikimedia.org/r/123550 (owner: 10Siebrand) [12:51:54] (03PS3) 10Siebrand: Replace deprecated/removed $wgExtensionAliasesFiles [extensions/BibManager] - 10https://gerrit.wikimedia.org/r/123541 [12:52:20] (03CR) 10Siebrand: "Variable name updated." [extensions/BibManager] - 10https://gerrit.wikimedia.org/r/123541 (owner: 10Siebrand) [12:52:27] (03CR) 10Raimond Spekking: [C: 032 V: 032] Migrate to JSON i18n [extensions/WikiTwidget] - 10https://gerrit.wikimedia.org/r/123627 (owner: 10Siebrand) [12:52:56] (03CR) 10Raimond Spekking: [C: 04-1] "Windows line endings" [extensions/WantedPagesFromNS] - 10https://gerrit.wikimedia.org/r/123611 (owner: 10Siebrand) [12:53:51] (03CR) 10Raimond Spekking: [C: 032 V: 032] Migrate to JSON i18n [extensions/QuizTabulate] - 10https://gerrit.wikimedia.org/r/123588 (owner: 10Siebrand) [12:53:58] (03PS2) 10Siebrand: Migrate to JSON i18n [extensions/WantedPagesFromNS] - 10https://gerrit.wikimedia.org/r/123611 [12:54:05] (03CR) 10Nikerabbit: [C: 032 V: 032] Complete migration to JSON i18n [extensions/GlobalUserGroups] - 10https://gerrit.wikimedia.org/r/123572 (owner: 10Siebrand) [12:54:25] (03CR) 10Raimond Spekking: [C: 032 V: 032] Migrate to JSON i18n [extensions/WantedPagesFromNS] - 10https://gerrit.wikimedia.org/r/123611 (owner: 10Siebrand) [12:58:13] (03PS1) 10Matthias Mullie: Fix path to patch-add_workflow_type.sqlite.sql [extensions/Flow] - 10https://gerrit.wikimedia.org/r/123630 [12:59:40] (03CR) 10Nikerabbit: [C: 032] Use correct global [extensions/SideBarMenu] - 10https://gerrit.wikimedia.org/r/123593 (owner: 10Siebrand) [12:59:46] (03Merged) 10jenkins-bot: Use correct global [extensions/SideBarMenu] - 10https://gerrit.wikimedia.org/r/123593 (owner: 10Siebrand) [12:59:55] (03CR) 10Nikerabbit: [C: 032] Remove unneeded and/or duplicate globals [extensions/Offline] - 10https://gerrit.wikimedia.org/r/123599 (owner: 10Siebrand) [12:59:57] (03Merged) 10jenkins-bot: Remove unneeded and/or duplicate globals [extensions/Offline] - 10https://gerrit.wikimedia.org/r/123599 (owner: 10Siebrand) [13:00:48] (03CR) 10Nikerabbit: [C: 032 V: 032] Replace deprecated/removed $wgExtensionAliasesFiles [extensions/BibManager] - 10https://gerrit.wikimedia.org/r/123541 (owner: 10Siebrand) [13:02:26] (03CR) 10Nikerabbit: [C: 032 V: 032] Remove duplicate global [extensions/UIFeedback] - 10https://gerrit.wikimedia.org/r/123605 (owner: 10Siebrand) [13:04:42] (03CR) 10Siebrand: [C: 032 V: 032] Replace deprecated/removed $wgExtensionAliasesFiles [extensions/OdbcDatabase] - 10https://gerrit.wikimedia.org/r/123545 (owner: 10Siebrand) [13:05:26] (03CR) 10Siebrand: [C: 032 V: 032] Replace deprecated/removed $wgExtensionAliasesFiles [extensions/SocialLogin] - 10https://gerrit.wikimedia.org/r/123548 (owner: 10Siebrand) [13:08:19] (03CR) 10Nikerabbit: [C: 032 V: 032] Remove empty i18n file [extensions/Views] - 10https://gerrit.wikimedia.org/r/123608 (owner: 10Siebrand) [13:10:33] (03CR) 10Nikerabbit: [C: 032] Use unique identifier for InfoPage key [extensions/WikimediaIncubator] - 10https://gerrit.wikimedia.org/r/123614 (owner: 10Siebrand) [13:10:35] (03Merged) 10jenkins-bot: Use unique identifier for InfoPage key [extensions/WikimediaIncubator] - 10https://gerrit.wikimedia.org/r/123614 (owner: 10Siebrand) [13:14:42] (03CR) 10Siebrand: [C: 032 V: 032] Replace deprecated/removed $wgExtensionAliasesFiles [extensions/UpdateMediaWiki] - 10https://gerrit.wikimedia.org/r/123550 (owner: 10Siebrand) [13:17:27] (03PS3) 10Nik: Used a different hook to prevent Link headers from being generated twice. [extensions/PubSubHubbub] - 10https://gerrit.wikimedia.org/r/123590 [13:18:27] (03CR) 10Matthias Mullie: Add workflow_type field (031 comment) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/122865 (owner: 10EBernhardson) [13:18:41] (03CR) 10WikidataJenkins: [V: 04-1] "Build Failed" [extensions/PubSubHubbub] - 10https://gerrit.wikimedia.org/r/123590 (owner: 10Nik) [13:19:29] (03PS4) 10Nik: Used a different hook to prevent Link headers from being generated twice. [extensions/PubSubHubbub] - 10https://gerrit.wikimedia.org/r/123590 [13:21:29] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/PubSubHubbub] - 10https://gerrit.wikimedia.org/r/123590 (owner: 10Nik) [13:24:06] (03PS5) 10Nik: Used a different hook to prevent Link headers from being generated twice. Rewrote test for Link header insertion. [extensions/PubSubHubbub] - 10https://gerrit.wikimedia.org/r/123590 [13:26:12] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/PubSubHubbub] - 10https://gerrit.wikimedia.org/r/123590 (owner: 10Nik) [13:27:07] (03PS1) 10Milimetric: Add limn mobile data tox job [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/123633 [13:29:38] (03CR) 10Hashar: [C: 032] Add limn mobile data tox job [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/123633 (owner: 10Milimetric) [13:29:57] (03Merged) 10jenkins-bot: Add limn mobile data tox job [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/123633 (owner: 10Milimetric) [13:30:00] (03CR) 10Nik: [C: 031 V: 031] Used a different hook to prevent Link headers from being generated twice. Rewrote test for Link header insertion. [extensions/PubSubHubbub] - 10https://gerrit.wikimedia.org/r/123590 (owner: 10Nik) [13:32:35] (03PS1) 10Milimetric: Add tox to analytics/limn-mobile-data [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/123634 [13:36:35] (03CR) 10Hashar: [C: 032] "Paired !" [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/123634 (owner: 10Milimetric) [13:36:42] (03PS1) 10Alexander.lehmann: insert wikibase test and configuration setup test [extensions/PubSubHubbub] - 10https://gerrit.wikimedia.org/r/123635 [13:38:15] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/PubSubHubbub] - 10https://gerrit.wikimedia.org/r/123635 (owner: 10Alexander.lehmann) [13:38:33] (03PS2) 10Alexander.lehmann: insert wikibase test and configuration setup test [extensions/PubSubHubbub] - 10https://gerrit.wikimedia.org/r/123635 [13:40:00] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/PubSubHubbub] - 10https://gerrit.wikimedia.org/r/123635 (owner: 10Alexander.lehmann) [13:43:29] (03CR) 10Nik: [C: 04-1] "Use tabs instead of spaces." [extensions/PubSubHubbub] - 10https://gerrit.wikimedia.org/r/123635 (owner: 10Alexander.lehmann) [13:45:07] (03Merged) 10jenkins-bot: Add tox to analytics/limn-mobile-data [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/123634 (owner: 10Milimetric) [13:46:14] (03PS3) 10Alexander.lehmann: Wikibase and configuration setup test inserted. [extensions/PubSubHubbub] - 10https://gerrit.wikimedia.org/r/123635 [13:47:27] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/PubSubHubbub] - 10https://gerrit.wikimedia.org/r/123635 (owner: 10Alexander.lehmann) [13:54:10] (03PS4) 10Alexander.lehmann: Wikibase and configuration setup test inserted. [extensions/PubSubHubbub] - 10https://gerrit.wikimedia.org/r/123635 [13:54:38] Nemo_bis: Hi! Jeff_Green [13:54:54] and I talked with Tyler on the swift mailer implemenation [13:55:00] Hi [13:55:13] you should check out the replies https://www.mediawiki.org/wiki/User_talk:Parent5446#Swift_Mailer_and_VERP__40928 [13:55:16] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/PubSubHubbub] - 10https://gerrit.wikimedia.org/r/123635 (owner: 10Alexander.lehmann) [13:55:58] If swift mailer needs to be implemented, then VERP should come out as its plugin [13:56:17] I already read that thread [13:56:32] Though now that you link it I notice it's in the wrong page, moving [13:57:22] (03PS5) 10Alexander.lehmann: Wikibase and configuration setup test inserted. [extensions/PubSubHubbub] - 10https://gerrit.wikimedia.org/r/123635 [13:57:27] Nemo_bis: donno why, but the link opens up for me. [13:57:49] anyway, we are still want some more feedback on shifting to swiftmailer [13:58:47] Nemo_bis: as, if it needs to be done first, before we start with VERP [13:59:01] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/PubSubHubbub] - 10https://gerrit.wikimedia.org/r/123635 (owner: 10Alexander.lehmann) [13:59:19] (03PS1) 10Tinaj1234: Added keyboard shortcut (ESC key) to close notifications flyout [extensions/Echo] - 10https://gerrit.wikimedia.org/r/123638 [13:59:24] (03CR) 10jenkins-bot: [V: 04-1] Added keyboard shortcut (ESC key) to close notifications flyout [extensions/Echo] - 10https://gerrit.wikimedia.org/r/123638 (owner: 10Tinaj1234) [13:59:32] tonythomas: then open a bug for the migration to SwiftMailer, add some people to cc and ask if it's a blocker for VERP or not [13:59:46] if nobody replies, or if there is no consensus on that, email wikitech [14:00:21] Nemo_bis: ok. I will do that. [14:02:22] (03PS2) 10Tinaj1234: Added keyboard shortcut (ESC key) to close notifications flyout [extensions/Echo] - 10https://gerrit.wikimedia.org/r/123638 [14:02:36] (03CR) 10Nik: [C: 032] Wikibase and configuration setup test inserted. [extensions/PubSubHubbub] - 10https://gerrit.wikimedia.org/r/123635 (owner: 10Alexander.lehmann) [14:02:54] (03CR) 10Nikerabbit: mediawiki.api: Refactor getToken and postWithToken methods (031 comment) [core] - 10https://gerrit.wikimedia.org/r/111636 (owner: 10Krinkle) [14:04:44] (03PS13) 10Wctaiwan: Change UI of special page and support Flow Thanks [extensions/Thanks] - 10https://gerrit.wikimedia.org/r/119879 [14:05:37] (03PS9) 10Wctaiwan: Add ability to deliver to all pages in a category [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/120334 [14:15:57] (03PS2) 10Nikerabbit: ApiFeedRecentChanges: Validate param target [core] - 10https://gerrit.wikimedia.org/r/121959 [14:16:25] Nemo_bis: done ! https://bugzilla.wikimedia.org/show_bug.cgi?id=63483 [14:17:21] good [14:19:39] Nemo_bis: Anyway, we are trying to test out swift mailer on one of the labs instance [14:31:57] (03PS2) 10Ottomata: Using 'www-data' as wikimetrics group when running in apache mode [vagrant] - 10https://gerrit.wikimedia.org/r/123303 [14:32:15] (03PS3) 10Ottomata: Using 'www-data' as wikimetrics group when running in apache mode [vagrant] - 10https://gerrit.wikimedia.org/r/123303 [14:32:20] (03CR) 10Ottomata: [C: 032 V: 032] Using 'www-data' as wikimetrics group when running in apache mode [vagrant] - 10https://gerrit.wikimedia.org/r/123303 (owner: 10Ottomata) [14:35:10] (03PS3) 10Phuedx: Make ResourceLoaderFileModule#getAllSkinStyles return all skin styles [core] - 10https://gerrit.wikimedia.org/r/122838 [14:45:49] (03CR) 10Anomie: [C: 031] "Looks good. Haven't tested." [core] - 10https://gerrit.wikimedia.org/r/123518 (owner: 10PleaseStand) [14:51:36] (03CR) 10Phuedx: "> I'm just worried about it changing the existing method, and not fully convinced it uses the right logic to read the 'styles' and 'skinSt" [core] - 10https://gerrit.wikimedia.org/r/122838 (owner: 10Phuedx) [14:52:36] (03PS1) 10Gerrit Patch Uploader: Add a dot at the end of the deprecate messages [core] - 10https://gerrit.wikimedia.org/r/123641 [14:52:38] (03CR) 10Gerrit Patch Uploader: "This commit was uploaded using the Gerrit Patch Uploader [1]." [core] - 10https://gerrit.wikimedia.org/r/123641 (owner: 10Gerrit Patch Uploader) [14:56:06] (03CR) 10Anomie: [C: 032] ApiFeedRecentChanges: Validate param target [core] - 10https://gerrit.wikimedia.org/r/121959 (owner: 10Nikerabbit) [14:58:48] (03CR) 10Bartosz Dziewoński: "Needs rebase." [extensions/GlobalCssJs] - 10https://gerrit.wikimedia.org/r/120333 (owner: 10Legoktm) [14:59:25] (03Merged) 10jenkins-bot: ApiFeedRecentChanges: Validate param target [core] - 10https://gerrit.wikimedia.org/r/121959 (owner: 10Nikerabbit) [15:00:22] (03PS1) 10Siebrand: Remove leading spaces in author name [extensions/BlueSpiceFoundation] - 10https://gerrit.wikimedia.org/r/123643 [15:00:38] (03CR) 10Siebrand: [C: 032 V: 032] Remove leading spaces in author name [extensions/BlueSpiceFoundation] - 10https://gerrit.wikimedia.org/r/123643 (owner: 10Siebrand) [15:02:40] (03PS1) 10TheDJ: WikiEditor: Remove old unmaintained ToC module [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/123645 [15:09:27] (03CR) 10Bartosz Dziewoński: [C: 04-1] "Like Nemo said, this should be done by fixing WatchAction.php to pass the constructed link to the message. This, in turn, should be done t" [core] - 10https://gerrit.wikimedia.org/r/122089 (owner: 10Konarak) [15:11:20] (03PS1) 10TheDJ: WikiEditor: Remove unmaintained template editor modules [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/123647 [15:12:15] (03PS1) 10TheDJ: WikiEditor: Remove unmaintained highlight plugin [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/123648 [15:13:06] (03PS1) 10TheDJ: WikiEditor: Remove unmaintained beta iframe mode [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/123649 [15:13:43] (03CR) 10jenkins-bot: [V: 04-1] WikiEditor: Remove unmaintained beta iframe mode [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/123649 (owner: 10TheDJ) [15:19:46] (03CR) 10Matthias Mullie: [C: 031] Drop table: flow_header_revision [extensions/Flow] - 10https://gerrit.wikimedia.org/r/117115 (owner: 10Bsitu) [15:20:58] (03PS2) 10TheDJ: WikiEditor: Remove unmaintained beta iframe mode [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/123649 [15:21:46] (03CR) 10Anomie: "Code seems ok, seems to work in some simple tests. But I wonder whether anyone is relying on the current behavior of msgnw, that this woul" [core] - 10https://gerrit.wikimedia.org/r/123516 (owner: 10Jackmcbarn) [15:26:08] (03CR) 10Anomie: "Third comment on this changeset. Paragraph after where I said "Not sure why this is marked WIP, but it's going in the right direction." th" [core] - 10https://gerrit.wikimedia.org/r/122566 (owner: 10TheDJ) [15:26:26] (03CR) 10Chad: Make it possible to take snapshots of your index (032 comments) [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/123115 (owner: 10Chad) [15:28:00] (03PS3) 10Chad: Make it possible to take snapshots of your index [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/123115 [15:35:26] (03PS3) 10Cscott: Add a new image option: "square" [core] - 10https://gerrit.wikimedia.org/r/120856 [15:37:48] (03PS1) 10Aude: Update Wikidata branch [tools/release] - 10https://gerrit.wikimedia.org/r/123655 [15:38:15] (03CR) 10Aude: "realize it's too late for this week, but need this next week" [tools/release] - 10https://gerrit.wikimedia.org/r/123655 (owner: 10Aude) [15:41:11] 3/names [15:41:13] meh [15:41:58] ^d: tried with newer versions of CirrusSearch but the new version doesn't seem to be able to talk to elastic search 1.0.0 or 1.1.0 - the resulting object seems to be NULL - not that familiar with PH [15:42:02] PHP [15:42:47] (03CR) 10Anomie: [C: 04-1] "Needs rebasing, and not just RELEASE-NOTES." (033 comments) [core] - 10https://gerrit.wikimedia.org/r/113525 (owner: 10Mattflaschen) [15:43:07] pomac: are you sure you updated Elastica and did you read docs around it [15:44:12] Nemo_bis: i updated it and did the submodule thing, didn't see any other documentation actually, clues? [15:49:15] (03CR) 10Anomie: [C: 031] "Seems good to me now. I'm not sure if discussion is still ongoing about srwhat or the like, so not +2ing." (031 comment) [core] - 10https://gerrit.wikimedia.org/r/123118 (owner: 10MaxSem) [15:49:34] Nemo_bis: ah, you mean that ealstica registers the Elasticsearch instance - it shows Elasticsearch 1.1.0 as being loaded [15:50:29] I have elastica c96fdbc and CirrusSearch 84ec7cb running now [15:50:50] (03PS3) 10TheDJ: API: Add timestamp of block to blockinfo [core] - 10https://gerrit.wikimedia.org/r/122566 [15:53:05] (03CR) 10Anomie: [C: 04-1] "Agree with Yuri. Also additional comments." (032 comments) [core] - 10https://gerrit.wikimedia.org/r/123367 (owner: 10Konarak) [15:53:07] (03PS4) 10Adamw: Adds an --extension option to generateJsonI18n [core] - 10https://gerrit.wikimedia.org/r/122659 [15:53:12] (03CR) 10Adamw: "Thanks for the review!" (033 comments) [core] - 10https://gerrit.wikimedia.org/r/122659 (owner: 10Adamw) [15:53:21] <^d> pomac: Hmm, we should support 1.x+ just fine. [15:53:28] <^d> We're using it in production. [15:53:39] (03PS4) 10Adamw: Add --supplementary flag to generateJsonI18n [core] - 10https://gerrit.wikimedia.org/r/122664 [15:53:44] (03CR) 10Cscott: [C: 04-2] "Rebased." [core] - 10https://gerrit.wikimedia.org/r/120856 (owner: 10Cscott) [15:53:48] ^d: yeah, it's weird... It doesn't get any data at all - i's like all the status info is NULL [15:54:08] <^d> What's null? [15:55:13] ^d: Basically the initial step in the setup breaks, the update-watcha-ma-call-it, it doesn't find the version of elasticsearch etc [15:55:31] <^d> Oh bleh, that's no good. Could you maybe pastebin what it looks like? [15:55:34] ^d I did some local changes to avoid the problems and it pushed data to the elastic search instance [15:56:11] (03CR) 10TheDJ: "i've not done the ApiQueryUserInfo changes, they seem to require changes to Block.php as well." [core] - 10https://gerrit.wikimedia.org/r/122566 (owner: 10TheDJ) [15:56:31] ^d: it's basically: php updateSearchIndexConfig.php and then the "version field" is empty so it fials [15:56:34] fails [15:56:58] ^d and bodging that check makes it continue, create data etc, but it fails on every check [15:57:54] ^d: as in, it's much more than just this, and i suspect that it's something a bit more specific - this is basically ubuntu 12.04 lts - and i don't know if they ruined something or not (eleasticsearch downloaded separately) [15:58:23] <^d> Hmmm :( [15:59:07] ^d: the 1.22 release, or how the numbering works on the mediawiki page, worked better than this but it's hard for me to know where changed. I updated elastica to latest git when it didn't seem to work with the 1.22 release [16:00:13] <^d> pomac: I doubt it would. Our master is tracking mediawiki core's master pretty closely right now. [16:00:18] ^d: I did have some oddities before, not being able to run the updateSearchIndexConfig.php direclty, but having to force create the index first and then fix it up and start over again [16:01:06] ^d: something else i could have missed, this is not a cluster, it basically only have one instance running... It's more of a test so far [16:01:52] <^d> If it's just a test I'd say upgrade your MediaWiki to git master instead of the 1.22 release :) [16:02:12] Uaaahh... outch ;) [16:03:01] ^d: What i did to play around was to try to, in vaidateIndexSettings, dump the settings variable with var_dump - it resulted in PHP printing "NULL" [16:03:45] ^d: which means that this->getSettings() would be returning NULL and thus... Explain why things arent falling in to place [16:05:13] <^d> Let's go back earlier to where you weren't able to fetch the version # [16:05:54] <^d> What happens if you var_dump() that first $result in checkElasticsearchVersion()? The one from Connection::getClient()->request( '_nodes' ); [16:06:18] <^d> Blah, $result = Connection::getClient()->request( '' ); [16:06:21] <^d> Wrong function [16:06:36] <^d> I'm curious what *that* $result is [16:07:12] (03PS5) 10Adamw: Add --supplementary flag to generateJsonI18n [core] - 10https://gerrit.wikimedia.org/r/122664 [16:09:17] ^d: heh... don't tell me that.... hold on [16:11:57] ^d: so... lets go back to the original problem, if it's still there - *gah* forgot about the damned webproxy settings and... *feeling the shame* [16:12:12] <^d> Is it working now? [16:13:05] ^d: when it doesn't try to use a proxy to access localhost? yes ;) [16:13:35] <^d> hehe good :) [16:14:12] ^d: so now i'm back to fidning the indexing odd - right now f.ex. it doesn't match the titles (I'm basically after a "normal install" as described in the README) [16:15:21] pomac: hey, ^d told me to talk to you if you need more help while he is on the bus [16:15:23] <^d> pomac: Well at least we can get results that aren't NULL :) I gotta run for a few. maybe manybubbles will be nice and lend a hand ;-) [16:15:24] ^d: and i'm correct to be suspicious - content_first == 65 entries, general_first = 3 entries [16:15:33] manybubbles: hehe [16:16:08] manybubbles: do you actually seed the articles with those steps? It feels like --skipParse needs --indexOnSkip or something like that [16:16:37] (we have ~11k pages, and i have, as stated, 65 + 3) [16:16:51] ^d: timezones are... hard sometimes [16:19:23] manybubbles: i use marvel to inspect the elasticsearch status, thats why i know - my original problem was that some pages doesn't seem to be indexed at all [16:20:07] pomac: sory, will read in a sec. in a meeting.... [16:20:21] manybubbles: fudging with the forceSearchIndex made it so that i could match pages but the word count was 0 - eventhough the page itself contains the word etc [16:20:33] (03CR) 10Anomie: "Well, that depends on whether you want to access $block->mTimestamp directly (it's "public", likely for really old BC) or if you want to a" [core] - 10https://gerrit.wikimedia.org/r/122566 (owner: 10TheDJ) [16:20:36] manybubbles: ah, np, it's 18:36 here... [16:36:38] manybubbles: Undefined property CirrusSearch::$showSuggestion in CirrusSearch/includes/CirrusSearch.php on ine 99 - known? [16:38:22] pomac: out of meeting [16:38:40] that undefined property - what version of Elastica and CirrusSearch plugin are you using? [16:38:46] Mediawiki 1.22, right? [16:38:56] And which version of Elasticsearch would help me too [16:40:05] manybubbles: mediawiki 1.22.5 - Elasticsearch 1.1.0 - Elastica (c96fdbc)CirrusSearch [16:40:22] (84ec7cb) [16:40:33] damn you linebreaks in the lines... [16:40:49] (03CR) 10Bartosz Dziewoński: [C: 031] "I wonder if there was a reason they were done this way. Looks good to me." [core] - 10https://gerrit.wikimedia.org/r/123641 (owner: 10Gerrit Patch Uploader) [16:43:50] pomac: so Elastica is the master branch - that might work but I did run all the integration test on the REL1_22 branch when I last updated it [16:44:42] manybubbles: i'm sorry, i think i have found it... For some reason the jobs aren't being run properly - And i don't know why! [16:45:01] manybubbles: Elastica *seems* to work, i run both at bleeding edge now though =) [16:45:11] yeah, that is what is going to production today [16:45:19] so it should work if you use bleeding edge mediawiki [16:45:32] manybubbles: i don't but it still seems to work [16:45:38] only problem is this line 99 [16:46:08] manybubbles: oh, and this jobs thing... [16:46:11] yeah, that came in 1.23 some where [16:46:25] if you _want_ to hack it just replace $this->showSuggestion with "true" [16:46:34] so jobs thing [16:46:52] do you have a cron job do your jobs or do you leave it default [16:47:40] manybubbles: i have left everything default, so i guess i should push this to a cronjob [16:48:55] (03PS12) 10Tpt: Addition of a parser test for page= parameter of image inclusion [core] - 10https://gerrit.wikimedia.org/r/102475 [16:50:13] pomac: I'm not a fan of the in process run jobs, but it should work. you might have to increase the memory you allocate to it with wgMaxShellMemory [16:50:27] the best thing is to try running the maintenance script manually and see if it complains [16:50:46] manybubbles: running it continiously now, working just fine, but i need to keep it in a cron or so [16:50:47] its difficult [16:51:05] (03CR) 10Daniel Friesen: [C: 04-1] "The wikipage.content hook doesn't cover all uses of mw.util.$content. The hook activates only on load and content area reload. But it's po" [core] - 10https://gerrit.wikimedia.org/r/123559 (owner: 10Gerrit Patch Uploader) [16:51:06] yeah, you can drop it in cron just with * * * * * [16:51:53] so running every second? ;) [16:52:03] every minute [16:52:20] but even every second wouldn't be too taxing on the machine [16:52:31] we run it in a while true loop, pretty much [16:52:41] but we reserve several machines for it. [16:52:51] not the cirrus jobs, all the jobs [16:54:46] anomie: re https://gerrit.wikimedia.org/r/#/c/123516/ , that change is actually a precursor to the unexpanded parameters in lua. it just happens to fix the other bug too (and i doubt it would break anything) [16:55:18] (03CR) 10jenkins-bot: [V: 04-1] Addition of a parser test for page= parameter of image inclusion [core] - 10https://gerrit.wikimedia.org/r/102475 (owner: 10Tpt) [16:55:57] manybubbles: nice, didn't know =/ [16:57:21] manybubbles: MUCH better, thank you! [16:57:21] I'm glad it is working for you [16:57:21] also, it'll make it much easier whenI update the REL1_22 branch [16:57:22] knowing that master "pretty much" works [16:57:39] manybubbles: Yeah, looks just fine, it just needs to keep indexing =) [16:58:29] manybubbles: 3628 queued jobs [16:58:30] when we first started it indexed in process but that was trouble [16:58:37] ah [16:58:48] manybubbles: i have pushed it down many times [16:58:48] how big is the wiki? [16:58:57] manybubbles: small, it has ~11k pages [16:59:04] manybubbles: i think that this is a old queue [16:59:10] might be [16:59:10] working through the jobs etc [16:59:12] yeah [16:59:21] so if it is running in cron it'll catch up [16:59:29] ehm [16:59:35] it seems to take one job per... wtf [16:59:43] need some settings [16:59:52] yeah, that is all configurable [17:00:52] sorry [17:00:59] (03PS1) 10Jackmcbarn: Allow fetching unexpanded arguments [core] - 10https://gerrit.wikimedia.org/r/123671 [17:04:15] (03PS6) 10Bartosz Dziewoński: mediawiki.jqueryMsg: Don't throw parse errors in the user's face [core] - 10https://gerrit.wikimedia.org/r/113307 [17:04:33] (03PS7) 10Bartosz Dziewoński: mediawiki.jqueryMsg: Don't throw parse errors in the user's face [core] - 10https://gerrit.wikimedia.org/r/113307 [17:05:03] (03CR) 10Bartosz Dziewoński: "Updated per Matt's comments, but I'm not entirely sure if this behavior is really correct…" [core] - 10https://gerrit.wikimedia.org/r/113307 (owner: 10Bartosz Dziewoński) [17:05:55] manybubbles: it's ok. now i just have to make this sane before i can go home and make some dinner [17:06:47] (03PS1) 10Jackmcbarn: Add frame.uargs (unexpanded arguments) [extensions/Scribunto] - 10https://gerrit.wikimedia.org/r/123672 [17:08:24] AaronSchulz: are you there? [17:08:49] is there a way to download all lua-modules from wikipeida (https://en.wikipedia.org/wiki/Wikipedia:Lua/Modules) my approach would be to filter the 19G dump file for ?number of module... but is there a better way? [17:12:14] physikerwelt: why do you want all of them? most won't be useful anywhere else [17:12:45] I just want to get rid of the errors [17:12:46] http://demo.formulasearchengine.com/index.php/Aeschylus [17:13:17] I downloaded all templates [17:14:12] physikerwelt: you're violating the copyrights of everyone whose contents you downloaded [17:14:16] it's all by-sa [17:14:18] you can't use by-nc-sa [17:16:18] manybubbles, ^d: thanks! ;) [17:16:25] time to go home... [17:17:37] jackmcbarn: oh you mean in the footer [17:17:41] yes [17:17:56] you're not allowed to license content under by-nc-sa if it was originally under by-sa [17:18:52] jackmcbarn: Why not? [17:18:52] ok thank you for the notice... I did not think about copyright at all [17:19:00] FoxT: it's a different license [17:19:07] -sa means it has to be relicensed under the same license [17:19:22] jackmcbarn: never mind. Didn't think about the 'SA' part [17:20:40] AaronSchulz: are you there? [17:21:20] * AaronSchulz is looking at https://gerrit.wikimedia.org/r/#/c/113525 [17:22:58] (03CR) 10Bartosz Dziewoński: [C: 032] "Tested on IE6 and saner browsers." [core] - 10https://gerrit.wikimedia.org/r/116227 (owner: 10Brian Wolff) [17:23:52] jackmcbarn: Thank you I fixed that [17:24:19] physikerwelt: now the license is gone completely [17:24:22] it needs to be by-sa [17:25:18] ok the footer it's said Content is available under Creative Commons Attribution-ShareAlike License unless otherwise noted. [17:26:05] (03CR) 10jenkins-bot: [V: 04-1] Use rgba() for gallery caption background instead of opacity [core] - 10https://gerrit.wikimedia.org/r/116227 (owner: 10Brian Wolff) [17:26:10] ok, looks good now [17:26:23] however you got the templates, that's probably the same way you want to get the modules [17:26:28] (03CR) 10Aaron Schulz: [C: 04-1] "The idea of the logging change in WikiPage looks fine, though I'm not quite sure why it was done in this exact way." (033 comments) [core] - 10https://gerrit.wikimedia.org/r/113525 (owner: 10Mattflaschen) [17:27:01] (03PS13) 10Tpt: Addition of a parser test for page= parameter of image inclusion [core] - 10https://gerrit.wikimedia.org/r/102475 [17:28:50] jackmcbarn: yes thank you.. that will take a while... there are only ca 35k content pages that contain math. with discussion and templates I have more than 1M pages now.. I'm courious what else will be needed [17:29:10] maybe a few local files [17:29:17] if you have instant commons on, you shouldn't need many files though [17:33:20] (03CR) 10jenkins-bot: [V: 04-1] Addition of a parser test for page= parameter of image inclusion [core] - 10https://gerrit.wikimedia.org/r/102475 (owner: 10Tpt) [17:38:06] (03CR) 10Bartosz Dziewoński: [C: 032] mediawiki.api: Refactor getToken and postWithToken methods [core] - 10https://gerrit.wikimedia.org/r/111636 (owner: 10Krinkle) [17:38:49] MatmaRex: do you know the answer to my question on that PS? [17:39:12] Nikerabbit: i don't think we've ever had a strong rule on this [17:39:37] one would generally use the spaceless version for simple expressions like arr[0], and the spaced version for weird things like what Krinkle does in that commit [17:39:58] MatmaRex: okay, I don't follow such rules [17:40:05] either there are spaces or there aren't [17:40:11] and I prefer to stick what I see most, no spaces [17:40:52] i don't really care one way or another, i'm not a huge fan of rigid code conventions for such things [17:41:18] MatmaRex: I am pedantic, I need rules to kill variation [17:41:21] (03Merged) 10jenkins-bot: mediawiki.api: Refactor getToken and postWithToken methods [core] - 10https://gerrit.wikimedia.org/r/111636 (owner: 10Krinkle) [17:43:10] (03PS1) 10Bartosz Dziewoński: shared.css: Move sup, sub styling from commonElements to shared styles [core] - 10https://gerrit.wikimedia.org/r/123677 [17:43:22] (03PS5) 10Bsitu: Add topic/post summary diff view [extensions/Flow] - 10https://gerrit.wikimedia.org/r/121128 [17:43:42] (03PS14) 10Tpt: Addition of a parser test for page= parameter of image inclusion [core] - 10https://gerrit.wikimedia.org/r/102475 [17:51:08] (03CR) 10jenkins-bot: [V: 04-1] Addition of a parser test for page= parameter of image inclusion [core] - 10https://gerrit.wikimedia.org/r/102475 (owner: 10Tpt) [17:54:16] (03PS1) 10Aude: Update Wikidata to use mw1.23-wmf21 branch [core] (wmf/1.23wmf21) - 10https://gerrit.wikimedia.org/r/123680 [17:54:30] (03PS6) 10CSteipp: Add maintenance script to copy db tables [extensions/OAuth] - 10https://gerrit.wikimedia.org/r/121131 [17:54:58] Reedy: ^ for test wikidata / test2 [17:55:26] renoirb: gah, I've been too busy lately (and before I was on vacation) [17:59:37] (03CR) 10Aaron Schulz: Add maintenance script to copy db tables (031 comment) [extensions/OAuth] - 10https://gerrit.wikimedia.org/r/121131 (owner: 10CSteipp) [18:01:43] Hi AaronSchulz glad to get news :) [18:02:44] ori: https://www.youtube.com/watch?v=4ol61-O6Sq4 [18:04:18] AaronSchulz, you have a few minutes to advise me on implementing SSO? [18:05:45] sso? [18:08:33] AaronSchulz; WebPlatform Docs to have a centralized auth system between apps (MediaWiki, and others). [18:09:51] ahh [18:11:05] I thought of using OAuth between them, and for some time that I create an authentication validator against MediaWiki. But pass all the rest though our own OAuth Authorization server [18:11:33] … i’m kinda newbie with that. I saw that you are author of the OAuth extension, Ryan told me you might have some pointers [18:12:50] (03CR) 10Reedy: [C: 032] Update Wikidata branch [tools/release] - 10https://gerrit.wikimedia.org/r/123655 (owner: 10Aude) [18:12:56] (03CR) 10Reedy: [C: 032 V: 032] Update Wikidata to use mw1.23-wmf21 branch [core] (wmf/1.23wmf21) - 10https://gerrit.wikimedia.org/r/123680 (owner: 10Aude) [18:13:50] (03Merged) 10jenkins-bot: Update Wikidata branch [tools/release] - 10https://gerrit.wikimedia.org/r/123655 (owner: 10Aude) [18:15:08] renoirb: you might want to talk to csteipp...using oauth for authentication is a bit scary to me [18:15:51] ok [18:16:24] I thought of using OAuth 2. [18:16:28] (03PS1) 10Manybubbles: Some version setting [search/highlighter] - 10https://gerrit.wikimedia.org/r/123682 [18:16:30] Through SSL etc. [18:17:17] csteipp: ohai :) [18:17:26] (03CR) 10Manybubbles: [C: 032] Some version setting [search/highlighter] - 10https://gerrit.wikimedia.org/r/123682 (owner: 10Manybubbles) [18:17:47] hey renoirb [18:19:23] We do have the /identify function that we hacked into our OAuth implementation which you can use for authentication. At the moment, we don't support OAuth 2. [18:20:15] i believe there now is oauth 3 [18:20:23] maybe not finalized, not sure [18:20:58] yeah, that’s what I saw [18:21:19] 2.0 is the current framework [18:21:38] I have an install of oauth-io/oauthd running. But it is useful only to provide an abstraction between authorized accounts. [18:21:51] * renoirb is not an expert. [18:22:23] This library seem to support OAuth v2 https://github.com/fkooman/php-oauth [18:22:23] in php [18:22:23] (03PS1) 10Cscott: Use square bounding boxes for default-sized thumbnails [core] - 10https://gerrit.wikimedia.org/r/123683 [18:23:28] Yep. renoirb, are you trying to authenticate to a wiki using OAuth2 (so you have another website providing identities, and the wiki creates users and lets them log in based on it)? [18:23:42] Or are you trying to make your wiki provide identities for another service? [18:24:02] can any +2'ers look at https://gerrit.wikimedia.org/r/#/c/97559/ ? it's been sitting around since november [18:25:44] Not sure which way, yet. I’d like to use our MW users and authenticate against it. But not use MW as the goto OAuth resource provider. [18:26:17] So, wiki to provide identities to another service. [18:27:21] I thought of creating a thin api endpoint over ssl, and it makes calls to MW api underthe hood. [18:27:37] (03PS4) 10Chad: Make it possible to take snapshots of your index and list them [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/123115 [18:28:19] renoirb: In that case, yeah, you can just point your OAuth2 service at mediawiki's user database and authenticate against it, and then you can use OAuth2 for sso to other sites. [18:28:42] (03PS3) 10Ori.livneh: Added per-wiki queue stats information [core] - 10https://gerrit.wikimedia.org/r/123493 (owner: 10Aaron Schulz) [18:30:27] At [0] OAuth/For_Developers, i se that indended users is NOT for Websites wanting single sign on? Which part? I think MW has many authentication extensions. I’m lost in which ones I could use… and what’s missing. [0]: https://www.mediawiki.org/wiki/OAuth/For_Developers [18:31:13] (03PS1) 10Physikerwelt: Update ExtractFeatures script [extensions/MathSearch] - 10https://gerrit.wikimedia.org/r/123686 [18:34:24] (03PS2) 10Cscott: Ignore height as well as width for framed images. [core] - 10https://gerrit.wikimedia.org/r/116995 [18:35:00] (03CR) 10Cscott: [C: 04-2] "Rebased. I think this is the wrong way to fix this bug, though; see comment 5 on bug 62258." [core] - 10https://gerrit.wikimedia.org/r/116995 (owner: 10Cscott) [18:40:35] (03CR) 10jenkins-bot: [V: 04-1] Ignore height as well as width for framed images. [core] - 10https://gerrit.wikimedia.org/r/116995 (owner: 10Cscott) [18:40:47] (03CR) 10Physikerwelt: [C: 032] Update ExtractFeatures script [extensions/MathSearch] - 10https://gerrit.wikimedia.org/r/123686 (owner: 10Physikerwelt) [18:41:01] (03PS5) 10CSteipp: Move OAuth logs to another wiki [extensions/OAuth] - 10https://gerrit.wikimedia.org/r/122867 [18:41:17] (03CR) 10CSteipp: Move OAuth logs to another wiki (037 comments) [extensions/OAuth] - 10https://gerrit.wikimedia.org/r/122867 (owner: 10CSteipp) [18:42:07] (03PS1) 10Manybubbles: Release plugin configuration [search/highlighter] - 10https://gerrit.wikimedia.org/r/123687 [18:42:28] (03PS1) 10Matthias Mullie: Remove couple of methods by using built-in sort [extensions/Flow] - 10https://gerrit.wikimedia.org/r/123688 [18:42:31] (03PS1) 10Matthias Mullie: Serialize UUID into something more compact [extensions/Flow] - 10https://gerrit.wikimedia.org/r/123689 [18:42:34] (03PS1) 10Matthias Mullie: hex2bin is slightly faster then pack [extensions/Flow] - 10https://gerrit.wikimedia.org/r/123690 [18:42:37] (03PS1) 10Matthias Mullie: UUID revamp [extensions/Flow] - 10https://gerrit.wikimedia.org/r/123691 [18:42:40] (03PS1) 10Matthias Mullie: Warn when __toString is needed on UUID [extensions/Flow] - 10https://gerrit.wikimedia.org/r/123692 [18:43:16] (03CR) 10jenkins-bot: [V: 04-1] hex2bin is slightly faster then pack [extensions/Flow] - 10https://gerrit.wikimedia.org/r/123690 (owner: 10Matthias Mullie) [18:43:26] (03CR) 10jenkins-bot: [V: 04-1] UUID revamp [extensions/Flow] - 10https://gerrit.wikimedia.org/r/123691 (owner: 10Matthias Mullie) [18:43:29] (03CR) 10jenkins-bot: [V: 04-1] Warn when __toString is needed on UUID [extensions/Flow] - 10https://gerrit.wikimedia.org/r/123692 (owner: 10Matthias Mullie) [18:43:32] (03PS7) 10CSteipp: Add maintenance script to copy db tables [extensions/OAuth] - 10https://gerrit.wikimedia.org/r/121131 [18:44:01] MatmaRex, could you explain your thoughts behind your comment on https://gerrit.wikimedia.org/r/#/c/123503/ please? ("Give the edit tab
  • closest to the collapsed tabs menu class=collapsible") [18:44:23] (03PS1) 10Manybubbles: [maven-release-plugin] prepare release experimental-0.0.1 [search/highlighter] - 10https://gerrit.wikimedia.org/r/123693 [18:44:25] (03PS1) 10Manybubbles: [maven-release-plugin] prepare for next development iteration [search/highlighter] - 10https://gerrit.wikimedia.org/r/123694 [18:45:03] Krenair: i haven't actually looked at the patch, does it do something else than i think it does? [18:45:10] nope [18:45:50] what i mean is, we shouldn't be hiding the most often clicked tab :) [18:46:02] (i have no stats to back that assertion up) [18:46:26] (03CR) 10Aaron Schulz: [C: 032] Add maintenance script to copy db tables [extensions/OAuth] - 10https://gerrit.wikimedia.org/r/121131 (owner: 10CSteipp) [18:46:33] (03Merged) 10jenkins-bot: Add maintenance script to copy db tables [extensions/OAuth] - 10https://gerrit.wikimedia.org/r/121131 (owner: 10CSteipp) [18:47:40] (03Abandoned) 10Matthias Mullie: hex2bin is slightly faster then pack [extensions/Flow] - 10https://gerrit.wikimedia.org/r/123690 (owner: 10Matthias Mullie) [18:47:44] (03PS3) 10Cscott: Ignore height as well as width for framed images. [core] - 10https://gerrit.wikimedia.org/r/116995 [18:50:00] (03CR) 10Cscott: "OK, this is a much better fix for this issue. We fix File::getUnscaledThumb() so that is actually returns an unscaled thumb in all instan" [core] - 10https://gerrit.wikimedia.org/r/116995 (owner: 10Cscott) [18:50:44] (03CR) 10Manybubbles: [C: 032] Release plugin configuration [search/highlighter] - 10https://gerrit.wikimedia.org/r/123687 (owner: 10Manybubbles) [18:50:47] (03CR) 10Manybubbles: [C: 032] [maven-release-plugin] prepare for next development iteration [search/highlighter] - 10https://gerrit.wikimedia.org/r/123694 (owner: 10Manybubbles) [18:50:49] (03CR) 10Manybubbles: [C: 032] [maven-release-plugin] prepare release experimental-0.0.1 [search/highlighter] - 10https://gerrit.wikimedia.org/r/123693 (owner: 10Manybubbles) [18:51:20] (03PS2) 10Matthias Mullie: UUID revamp [extensions/Flow] - 10https://gerrit.wikimedia.org/r/123691 [18:51:40] (03CR) 10jenkins-bot: [V: 04-1] [maven-release-plugin] prepare release experimental-0.0.1 [search/highlighter] - 10https://gerrit.wikimedia.org/r/123693 (owner: 10Manybubbles) [18:51:42] (03CR) 10jenkins-bot: [V: 04-1] [maven-release-plugin] prepare for next development iteration [search/highlighter] - 10https://gerrit.wikimedia.org/r/123694 (owner: 10Manybubbles) [18:53:30] (03CR) 10Manybubbles: "recheck" [search/highlighter] - 10https://gerrit.wikimedia.org/r/123693 (owner: 10Manybubbles) [18:54:19] (03CR) 10Manybubbles: [V: 032] [maven-release-plugin] prepare release experimental-0.0.1 [search/highlighter] - 10https://gerrit.wikimedia.org/r/123693 (owner: 10Manybubbles) [18:55:24] (03CR) 10Manybubbles: [V: 032] [maven-release-plugin] prepare for next development iteration [search/highlighter] - 10https://gerrit.wikimedia.org/r/123694 (owner: 10Manybubbles) [18:55:43] jenkins doesn't get to block maven's release commits.... [18:55:55] heh [18:57:46] (03PS4) 10Cscott: Ignore height as well as width for framed images. [core] - 10https://gerrit.wikimedia.org/r/116995 [18:58:36] csteipp: As I understood it, MW has already created a model for grants. [19:02:01] renoirb: In the current OAuth extension, yes [19:03:26] How do you use OAuth at WMF? [19:03:56] As I understand it, you set a wiki as the provider to authenticate against. And how do you authorize others to use the session? [19:04:02] csteipp ^ [19:04:37] The wiki handles authentication, and is the Identity provider (idp) [19:04:53] Other applications use OAuth to make authorized api calls on behalf of users [19:05:14] (OAuth is for authorized access, not authentication) [19:05:14] (03PS7) 10Brian Wolff: Use rgba() for gallery caption background instead of opacity [core] - 10https://gerrit.wikimedia.org/r/116227 [19:05:48] (03CR) 10Brian Wolff: "Rebase to redo unit tests. I think failure was unrelated to patch" [core] - 10https://gerrit.wikimedia.org/r/116227 (owner: 10Brian Wolff) [19:06:02] We added on /identify so an external application (that keeps its own concept of users) can know what wiki user they acting on behalf of [19:12:20] Howdy. [19:12:21] Is anyone here? [19:13:05] Why aren't the trackingcategories* messages displayed https://test.wikipedia.org/wiki/Special:TrackingCategories ? They do not exist on testwiki, but seem to be on translatewiki and in the i18n files [19:13:08] Is it l10n cache issue? [19:14:03] (03CR) 10Bartosz Dziewoński: "This doesn't actually depend on https://gerrit.wikimedia.org/r/#/c/120343/4 AFAICS, let's cut the dependency." [extensions/Popups] - 10https://gerrit.wikimedia.org/r/120344 (owner: 10Prtksxna) [19:14:04] They also all have "nodesc" ... [19:14:09] (03PS5) 10Prtksxna: Use tooltip role for Popups [extensions/Popups] - 10https://gerrit.wikimedia.org/r/120344 [19:14:13] (03CR) 10Bartosz Dziewoński: [C: 032] Use tooltip role for Popups [extensions/Popups] - 10https://gerrit.wikimedia.org/r/120344 (owner: 10Prtksxna) [19:14:20] (03Merged) 10jenkins-bot: Use tooltip role for Popups [extensions/Popups] - 10https://gerrit.wikimedia.org/r/120344 (owner: 10Prtksxna) [19:14:28] (03PS5) 10Bartosz Dziewoński: Use aria-hidden for popups [extensions/Popups] - 10https://gerrit.wikimedia.org/r/120345 (owner: 10Prtksxna) [19:14:33] (03CR) 10Bartosz Dziewoński: [C: 032] Use aria-hidden for popups [extensions/Popups] - 10https://gerrit.wikimedia.org/r/120345 (owner: 10Prtksxna) [19:14:39] (03Merged) 10jenkins-bot: Use aria-hidden for popups [extensions/Popups] - 10https://gerrit.wikimedia.org/r/120345 (owner: 10Prtksxna) [19:15:14] PiRSquared: this has happened a few times on testwiki, and usually seems to fix itself / be fixed before real deployment [19:15:16] Reedy: ^ [19:15:31] okay, MatmaRex [19:15:34] just wanted to be sure [19:17:02] Thanks csteipp, this enlightened the picture I had in mind!! [19:17:06] Very concise :) [19:20:19] (03CR) 10Manybubbles: [C: 032] Make it possible to take snapshots of your index and list them [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/123115 (owner: 10Chad) [19:20:34] (03Merged) 10jenkins-bot: Make it possible to take snapshots of your index and list them [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/123115 (owner: 10Chad) [19:22:28] (03PS8) 10Bsitu: Add summarize/close/open topic to history/contribution [extensions/Flow] - 10https://gerrit.wikimedia.org/r/123123 [19:37:12] (03PS2) 10Phuedx: Update the firstedit tour's copy [extensions/GuidedTour] - 10https://gerrit.wikimedia.org/r/119261 [19:40:25] (03CR) 10Bartosz Dziewoński: [C: 032] "Damned useless CI…" [core] - 10https://gerrit.wikimedia.org/r/116227 (owner: 10Brian Wolff) [19:43:29] (03Merged) 10jenkins-bot: Use rgba() for gallery caption background instead of opacity [core] - 10https://gerrit.wikimedia.org/r/116227 (owner: 10Brian Wolff) [19:52:21] (03PS1) 10AndyRussG: WIP Domain layer and DB persistence with data mapper [extensions/Campaigns] - 10https://gerrit.wikimedia.org/r/123779 [19:54:09] (03PS1) 10Gerrit Patch Uploader: Initialize tooltipAccessKeyPrefix on load instead of on domready [core] - 10https://gerrit.wikimedia.org/r/123780 [19:54:11] (03CR) 10Gerrit Patch Uploader: "This commit was uploaded using the Gerrit Patch Uploader [1]." [core] - 10https://gerrit.wikimedia.org/r/123780 (owner: 10Gerrit Patch Uploader) [19:55:57] (03Abandoned) 10AndyRussG: WIP Domain layer and DB persistence with data mapper [extensions/Campaigns] - 10https://gerrit.wikimedia.org/r/123779 (owner: 10AndyRussG) [19:57:18] (03PS1) 10AndyRussG: WIP Domain layer and DB persistence with data mapper [extensions/Campaigns] (wip/editorcampaigns) - 10https://gerrit.wikimedia.org/r/123781 [20:12:06] (03CR) 10Bartosz Dziewoński: "Why?" [core] - 10https://gerrit.wikimedia.org/r/123780 (owner: 10Gerrit Patch Uploader) [20:13:07] MatmaRex: do you know of any extensions (or worse, sites) using any of that WikiEditor stuff alpha stuff ? [20:13:38] nope [20:13:46] i'm pretty sure it's just bit rotting [20:14:07] if anyone is dumb enough to use it, then can stay on the old version, let's just put a notice on the extension's page on mw.org [20:14:25] thedj: ^ [20:15:23] MatmaRex: yeah, that was my line of thought as well [20:16:54] (03Restored) 10Bartosz Dziewoński: mediawiki.action.edit.js: remove a weird hack from 2010 [core] - 10https://gerrit.wikimedia.org/r/53029 (owner: 10Bartosz Dziewoński) [20:16:59] thedj: related ^ :) [20:17:18] the iframe reference in there ? [20:17:34] yeah, that was another one that needed to get done.. [20:18:03] yay \o/ [20:18:51] <^d> Nemo_bis: So I chatted with people re: interwiki search. I'm glad you guys wanna test it, but I think we're a little leery of exposing it to itwik* anons who won't understand the semi-brokenness. [20:19:15] <^d> I think we're gonna add a second beta feature to enable "experimental and mostly broken new search features" :) [20:19:20] <^d> So you guys can opt-in [20:19:29] Hm. :( Ok [20:19:46] Anons never complained about the feature in 2008–2009 by the way [20:20:14] <^d> Indeed, but I'd rather not risk breaking things for people who didn't ask for it and have no recourse to opt-out until it's fixed. [20:20:27] What can break? [20:20:38] <^d> I break interwiki searches all the time! :p [20:20:43] <^d> Confusing inconsistent results. [20:20:44] it.wiki has the wikidata search gadget enabled anyway [20:20:45] <^d> Weird UI quirks. [20:20:47] <^d> :) [20:20:58] That's not breaking anything they already have [20:21:42] It's like saying "I won't give you this diamond as gift because I'm afraid there is an imperfection in it and youy may be offended" ;) [20:21:58] But it's ok, progress! [20:22:03] <^d> I like polished diamonds :p [20:25:01] (03PS6) 10Wctaiwan: Implement a redirector at Special:Flow [extensions/Flow] - 10https://gerrit.wikimedia.org/r/121306 [20:34:54] (03PS4) 10Bartosz Dziewoński: mediawiki.action.edit.js: Remove WikiEditor iframe hack from 2010 [core] - 10https://gerrit.wikimedia.org/r/53029 [20:36:45] (03PS2) 10Jforrester: Split /resources into /resources/lib and /resources/src [core] - 10https://gerrit.wikimedia.org/r/123782 [20:37:48] (03CR) 10jenkins-bot: [V: 04-1] Split /resources into /resources/lib and /resources/src [core] - 10https://gerrit.wikimedia.org/r/123782 (owner: 10Jforrester) [20:38:13] <^d> Nemo_bis: You're right. No extra beta feature. [20:38:21] (03CR) 10TheDJ: [C: 031] "https://gerrit.wikimedia.org/r/123649" [core] - 10https://gerrit.wikimedia.org/r/53029 (owner: 10Bartosz Dziewoński) [20:39:37] (03CR) 10Bartosz Dziewoński: "Are you aware that there's a RFC on this?" [core] - 10https://gerrit.wikimedia.org/r/123782 (owner: 10Jforrester) [20:39:56] ^d: same one? Or just merging the existing config patch? :) [20:40:12] <^d> Probably just do it as-is. [20:40:17] (03CR) 10Bartosz Dziewoński: "https://www.mediawiki.org/wiki/Requests_for_comment/Isolate_custom_jQuery_libraries" [core] - 10https://gerrit.wikimedia.org/r/123782 (owner: 10Jforrester) [20:40:22] <^d> But tack some text on the box so people are aware it's super-alpha [20:40:29] rofl [20:40:30] The same standards of legibility should apply for a major website. This isn't some idiot's personal site from 1996 - this is a significant online resource and it should be presented with as much simplicity as possible. [20:40:41] just so we know :D [20:42:00] :D [20:44:29] this user is the only one with a proper argument so far: [20:44:31] It looks like the bold font is not loaded, and the italic font is not loaded. This causes faux-bold and faux-italics. Especially the faux-bold does not look good, see the bold "e". Also the normal "f". It creates a very busy, jagged and off-looking page. (Chrome + Windows = screenshot) [20:44:51] which is true and indeed looks terrible on Windows it seems. [20:45:33] <^d> Nemo_bis: If you could edit [[MediaWiki:Search-interwiki-caption]] on the various itwikis to be something like http://en.wikipedia.beta.wmflabs.org/w/index.php?title=MediaWiki:Search-interwiki-caption&action=edit, that'd be great [20:45:41] <^d> It'll look like http://en.wikipedia.beta.wmflabs.org/w/index.php?title=Special%3ASearch&profile=default&search=Testing&fulltext=Search [20:45:54] then again, which font doesn't look terrible on windows... [20:46:22] thedj: Times New Roman? [20:46:29] <^d> Comic Sans. [20:46:47] Dingbats? [20:46:50] ^d: I don't have such super-powers; I could translate it and let you add it, or I'd have to ask and it may take some days [20:47:12] *Wingdings [20:47:23] <^d> Nemo_bis: Hmm, maybe we can sneak it in via WikimediaMessages. [20:47:27] It's info about a software feature so it's entirely ok for you to edit [20:47:41] If you think it's easier that way, as you prefer [20:48:13] <^d> I dunno the italian. [20:48:13] <^d> :) [20:48:36] <^d> WikimediaMessages would be easiest. Then we have no edits to make. [20:48:56] Heh concept of "easiest" for devs with superpowers ;) [20:49:18] StevenW: do you have the numbers of the opt-in count to the beta before release ? [20:49:33] Per wiki or total? [20:49:40] total [20:49:53] Ah, last time we checked it was slightly more than 14,000 [20:52:41] ^d: something like this: Risultati dai progetti fratelli / Funzionalità preliminarissima! Prego pazientare mentre ne risolviamo gli errori. [20:54:02] (03CR) 10EBernhardson: [C: 04-1] Remove couple of methods by using built-in sort (031 comment) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/123688 (owner: 10Matthias Mullie) [20:54:05] <^d> {{done}} - https://it.wikipedia.org/wiki/MediaWiki:Search-interwiki-caption [20:55:21] (03CR) 10Jforrester: "No (and I'm slightly surprised; I don't consider code clean-up to need an RfC, really. :-))." [core] - 10https://gerrit.wikimedia.org/r/123782 (owner: 10Jforrester) [20:55:25] (03CR) 10EBernhardson: [C: 031] "Although, I'm not sure we should be serializing uuids anyways?" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/123689 (owner: 10Matthias Mullie) [20:56:27] (03PS3) 10Jforrester: Split /resources into /resources/lib and /resources/src [core] - 10https://gerrit.wikimedia.org/r/123782 [20:57:23] MatmaRex: The next phase discussed is to move e.g. jquery.arrowSteps to src/jquery.arrowSteps/ rather than have mixed /images/ directories. [20:58:44] would be nice if we could make automated export and publish of those components [20:59:09] thedj: You mean, move them all to their own repos? [20:59:21] thedj: That'd be great, yes. [20:59:41] thanks ^d [21:00:39] <^d> no problem. copying around to other itwik*s [21:01:15] James_F: as bower components... to github [21:01:41] with licenses and version numbers... [21:01:48] * thedj dreams [21:02:03] thedj: Eww, github. :-( [21:02:46] (03CR) 10jenkins-bot: [V: 04-1] Split /resources into /resources/lib and /resources/src [core] - 10https://gerrit.wikimedia.org/r/123782 (owner: 10Jforrester) [21:08:54] (03PS4) 10Jforrester: Split /resources into /resources/lib and /resources/src [core] - 10https://gerrit.wikimedia.org/r/123782 [21:11:16] (03CR) 10EBernhardson: [C: 04-1] UUID revamp (036 comments) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/123691 (owner: 10Matthias Mullie) [21:12:09] (03CR) 10EBernhardson: [C: 032] Warn when __toString is needed on UUID [extensions/Flow] - 10https://gerrit.wikimedia.org/r/123692 (owner: 10Matthias Mullie) [21:14:02] (03PS5) 10Jforrester: Split /resources into /resources/lib and /resources/src [core] - 10https://gerrit.wikimedia.org/r/123782 [21:20:14] (03CR) 10jenkins-bot: [V: 04-1] Split /resources into /resources/lib and /resources/src [core] - 10https://gerrit.wikimedia.org/r/123782 (owner: 10Jforrester) [21:21:06] superm401, I updated https://gerrit.wikimedia.org/r/#/c/117107/ sorry it took so long [21:21:38] jgonera, yep, I saw. I'll try to retest today or tomorrow. [21:21:51] sure, no rush, thanks [21:24:59] (03CR) 10EBernhardson: [C: 032] Fix path to patch-add_workflow_type.sqlite.sql [extensions/Flow] - 10https://gerrit.wikimedia.org/r/123630 (owner: 10Matthias Mullie) [21:25:14] (03Merged) 10jenkins-bot: Fix path to patch-add_workflow_type.sqlite.sql [extensions/Flow] - 10https://gerrit.wikimedia.org/r/123630 (owner: 10Matthias Mullie) [21:28:21] (03PS6) 10Jforrester: Split /resources into /resources/lib and /resources/src [core] - 10https://gerrit.wikimedia.org/r/123782 [21:41:47] (03PS9) 10Bsitu: Add summarize/close/open topic to history/contribution [extensions/Flow] - 10https://gerrit.wikimedia.org/r/123123 [21:42:12] (03PS4) 10Ori.livneh: Added per-wiki queue stats information [core] - 10https://gerrit.wikimedia.org/r/123493 (owner: 10Aaron Schulz) [21:42:15] (03CR) 10Ori.livneh: [C: 032] Added per-wiki queue stats information [core] - 10https://gerrit.wikimedia.org/r/123493 (owner: 10Aaron Schulz) [21:43:07] (03Abandoned) 10Ori.livneh: Log User-Agent strings on successful authentication requests [extensions/WikimediaEvents] - 10https://gerrit.wikimedia.org/r/93526 (owner: 10Ori.livneh) [21:43:41] (03Abandoned) 10Ori.livneh: [Do not merge] Clean up: remove module store from localStorage [extensions/WikimediaEvents] - 10https://gerrit.wikimedia.org/r/94973 (owner: 10Ori.livneh) [21:43:48] (03PS6) 10CSteipp: Move OAuth logs to another wiki [extensions/OAuth] - 10https://gerrit.wikimedia.org/r/122867 [21:46:27] (03Merged) 10jenkins-bot: Added per-wiki queue stats information [core] - 10https://gerrit.wikimedia.org/r/123493 (owner: 10Aaron Schulz) [21:51:07] (03CR) 10Jforrester: "Potentially we could split each of the /src/ modules into their own directory, which would make the eventual goal (of moving all/most of t" [core] - 10https://gerrit.wikimedia.org/r/123782 (owner: 10Jforrester) [21:56:08] (03PS1) 10JGonera: Prevent popups after scrolling [extensions/Popups] - 10https://gerrit.wikimedia.org/r/123790 [21:57:35] (03PS1) 10Chad: Updating Cirrus to master [core] (wmf/1.23wmf20) - 10https://gerrit.wikimedia.org/r/123791 [21:57:44] (03CR) 10Chad: [C: 032 V: 032] Updating Cirrus to master [core] (wmf/1.23wmf20) - 10https://gerrit.wikimedia.org/r/123791 (owner: 10Chad) [22:17:18] (03CR) 10Matthias Mullie: UUID revamp (032 comments) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/123691 (owner: 10Matthias Mullie) [22:19:55] (03CR) 10Matthias Mullie: "I've seen it serialized in a couple of DB columns. Definitions table comes to mind. And I think we store it for some echo notifications to" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/123689 (owner: 10Matthias Mullie) [22:30:50] legoktm: ping [22:31:42] $1 {{GENDER:$2|caused a title blacklist hit}} when trying to move page $4 to $3 matching $5. [22:31:44] is good? [22:32:56] its hard to call anything with numbered variables good :P but i know thats not an option [22:33:33] ebernhardson: would you use the old title or the title they tried to move to as the target? [22:35:24] PiRSquared: hmm, is the blacklist triggered by the name they tried to move it to? or how [22:35:42] PiRSquared: also, while it might not matter, i think its usually {{GENDER:$2|caused}} a title blacklist hit [22:36:03] (it doesn't really matter though since english isn't gendered) [22:36:06] The blacklist is triggered by the new name [22:36:13] the one they tried to name it to [22:36:31] when moving a page, the old name is tested for noedit, and the new name is tested normally. if either hits, it aborts [22:37:19] I was just looking at the Titleblacklist hooks [22:37:22] hmm, i suppose based on uncertainty i would link the page the article currently exists at [22:37:24] $blacklisted = $titleBlacklist->userCannot( $nt, $user, 'move' ); [22:37:33] if ( !$blacklisted ) { [22:37:35] $blacklisted = $titleBlacklist->userCannot( $old, $user, 'edit' ); [22:37:36] } [22:37:51] so yeah, it could be either ... [22:38:13] I could log them in different ways if that matters [22:40:55] (03CR) 10EBernhardson: "Not sure the best place to mention it, but another patch just added a new file resources/mediawiki/debug.profile.js which is not included " [core] - 10https://gerrit.wikimedia.org/r/123782 (owner: 10Jforrester) [22:41:18] jackmcbarn: would you log for the current one? [22:41:49] ebernhardson: Thanks! [22:42:52] PiRSquared: i'd log for either [22:43:06] (not that i see any point in logging titleblacklist hits at all, but if you are, that's what i'd do) [22:43:07] ebernhardson: Wait, debug.profile.js is mentioned? [22:47:18] James_F: the problem is its not mentioned, it was just added to core yesterday [22:47:28] James_F: so its not a part of the patch, not sure how you wanted to track those [22:47:43] or maybe you will just rebase and double check before +2 :) [22:48:16] James_F: i feel like i might still not be clear, my understanding is debug.profile.js should move to the same directory as debug.js. It currently is not. [22:49:29] (03CR) 10Chad: [C: 031] New API module, list=prefixsearch [core] - 10https://gerrit.wikimedia.org/r/123118 (owner: 10MaxSem) [22:58:44] ebernhardson: Oh, right, yeah, I'll add it to the list. Yes, I moved it to the same directory. [23:00:01] ebernhardson: They're in "mediawiki.debug" section. [23:04:26] (03CR) 10Yuvipanda: [C: 032] "Much +1." [core] - 10https://gerrit.wikimedia.org/r/123118 (owner: 10MaxSem) [23:08:00] (03Merged) 10jenkins-bot: New API module, list=prefixsearch [core] - 10https://gerrit.wikimedia.org/r/123118 (owner: 10MaxSem) [23:09:18] (03PS1) 10Ori.livneh: RL bugfix [core] - 10https://gerrit.wikimedia.org/r/123802 [23:11:23] <^d> YuviPanda: Much review. Great merge. [23:11:40] So core. [23:12:10] ^d: I was going to complete it but wasn't sure :P [23:15:07] (03CR) 10jenkins-bot: [V: 04-1] RL bugfix [core] - 10https://gerrit.wikimedia.org/r/123802 (owner: 10Ori.livneh) [23:15:09] (03CR) 10MaxSem: "I personally know that it's related to those weird hhvm failures, but still a more detailed description would be appreciated:)" [core] - 10https://gerrit.wikimedia.org/r/123802 (owner: 10Ori.livneh) [23:15:43] (03CR) 10Jforrester: "Already done, AFAICT – I23a0ce4137 added mediawiki/mediawiki.debug.profile.js and mediawiki/mediawiki.debug.profile.css which this patch m" [core] - 10https://gerrit.wikimedia.org/r/123782 (owner: 10Jforrester) [23:30:17] (03PS1) 10SG: mw-ui-button: Revamp the LESS to be simpler, and improve cross-browser support [core] - 10https://gerrit.wikimedia.org/r/123804 [23:36:41] (03CR) 10jenkins-bot: [V: 04-1] mw-ui-button: Revamp the LESS to be simpler, and improve cross-browser support [core] - 10https://gerrit.wikimedia.org/r/123804 (owner: 10SG) [23:37:17] (03PS2) 10SG: mw-ui-button: Revamp the LESS to be simpler, and improve cross-browser support [core] - 10https://gerrit.wikimedia.org/r/123804 [23:43:22] (03CR) 10jenkins-bot: [V: 04-1] mw-ui-button: Revamp the LESS to be simpler, and improve cross-browser support [core] - 10https://gerrit.wikimedia.org/r/123804 (owner: 10SG) [23:54:00] mwalker, phpunit seems to try to serialize the input data for tests, which fails for closures [23:55:02] is it just me, or is git.wikimedia.org very slow? [23:55:23] (03PS3) 10SG: mw-ui-button: Revamp the LESS to be simpler, and improve cross-browser support [core] - 10https://gerrit.wikimedia.org/r/123804 [23:56:16] (03PS1) 10Jforrester: Update OOjs UI to v0.1.0-pre (eaa1b7f06d) [core] - 10https://gerrit.wikimedia.org/r/123807 [23:56:36] (03CR) 10Jforrester: [C: 032] "Pull-through." [core] - 10https://gerrit.wikimedia.org/r/123807 (owner: 10Jforrester) [23:58:26] mwalker, https://github.com/gwicke/tassembly-php/commit/99fbc0029ad33dedfb8cb0761967c6cdbc2f1d09 [23:59:09] eh, https://github.com/gwicke/tassembly-php/commit/8ff0b10ac7bf67e35f5ea7e8285609217c26ddf3 [23:59:25] the github web interface is lagging ;)