[00:01:13] <grrrit-wm>	 (03PS1) 10EBernhardson: Standards compliant reset of min/max-width [extensions/Flow] - 10https://gerrit.wikimedia.org/r/123138 
[00:02:26] <grrrit-wm>	 (03CR) 10Anomie: "It would get the next random number from old seed (and would affect the random numbers returned by the next call to foo, too). Lua doesn't" [extensions/Scribunto] - 10https://gerrit.wikimedia.org/r/122862 (owner: 10Anomie)
[00:03:16] <jorm>	 interesting.  talk pages don't have language links.
[00:03:32] <marktraceur>	 Hm, what would the point be?
[00:03:56] <bawolff>	 I've actually been seriously confused by that in the past
[00:04:05] <Krinkle>	 ori: https://bugzilla.wikimedia.org/show_bug.cgi?id=63399
[00:04:10] <jorm>	 yeah.  you'd think you'd go to the discussion in the other language.
[00:04:33] <ori>	 Krinkle: :)
[00:05:26] <grrrit-wm>	 (03CR) 10Springle: "Schema change done." [extensions/Flow] - 10https://gerrit.wikimedia.org/r/115576 (owner: 10EBernhardson)
[00:06:17] <grrrit-wm>	 (03CR) 10Anomie: "Haven't looked at the code yet (I'll do that tomorrow), but my first reaction is to wonder how this is different from list=allpages&appref" [core] - 10https://gerrit.wikimedia.org/r/123118 (owner: 10MaxSem)
[00:06:22] <grrrit-wm>	 (03CR) 10EBernhardson: [C: 031] "Schema change applied, this can be merged and should go on thursdays deploy train" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/122865 (owner: 10EBernhardson)
[00:10:06] <grrrit-wm>	 (03CR) 10MaxSem: "@Anomie, the default implementation is indeed not different, however when a real search engine is plugged into it, the prefix search takes" [core] - 10https://gerrit.wikimedia.org/r/123118 (owner: 10MaxSem)
[00:13:16] <spagewmf>	 jorm: some Beta Features discussions use Special:MyLanguage/Talk:SomePage to send you to a /fr subpage, e.g. Visionneuse de Médias
[00:23:02] <grrrit-wm>	 (03PS1) 10Ori.livneh: Change default prefix of StatsD writer [extensions/EventLogging] - 10https://gerrit.wikimedia.org/r/123142 
[00:23:23] <grrrit-wm>	 (03CR) 10Ori.livneh: [C: 032] Change default prefix of StatsD writer [extensions/EventLogging] - 10https://gerrit.wikimedia.org/r/123142 (owner: 10Ori.livneh)
[00:23:50] <grrrit-wm>	 (03Merged) 10jenkins-bot: Change default prefix of StatsD writer [extensions/EventLogging] - 10https://gerrit.wikimedia.org/r/123142 (owner: 10Ori.livneh)
[00:28:35] <grrrit-wm>	 (03PS1) 10Bsitu: Always use cache to get last revision + add rev_type to key [extensions/Flow] - 10https://gerrit.wikimedia.org/r/123144 
[00:28:40] <grrrit-wm>	 (03PS1) 10Krinkle: Zuul status page: Add support for highlighting a change by id [integration/docroot] - 10https://gerrit.wikimedia.org/r/123145 
[00:29:06] <grrrit-wm>	 (03CR) 10Krinkle: "http://i.imgur.com/AWnE8I3.png" [integration/docroot] - 10https://gerrit.wikimedia.org/r/123145 (owner: 10Krinkle)
[00:29:14] <Krinkle>	 ori: something like that ^ ?
[00:29:32] <ori>	 Krinkle: hey, that looks really nice
[00:30:22] <grrrit-wm>	 (03PS1) 10CSteipp: Prevent GC during phpunit shutdown [core] - 10https://gerrit.wikimedia.org/r/123146 
[00:32:12] <huh_>	 hi
[00:32:23] <grrrit-wm>	 (03PS1) 10Ori.livneh: eventlogging-reporter: send the stat, don't print it. [extensions/EventLogging] - 10https://gerrit.wikimedia.org/r/123147 
[00:32:28] <grrrit-wm>	 (03CR) 10Parent5446: "You've got to be kidding me. What the hell is going on with this bug? XD" [core] - 10https://gerrit.wikimedia.org/r/123146 (owner: 10CSteipp)
[00:32:30] <huh_>	 jenkins doesn't validate json
[00:32:32] <huh_>	 ...
[00:33:00] <bawolff>	 There's a bug for that
[00:33:04] <grrrit-wm>	 (03CR) 10Ori.livneh: [C: 032] eventlogging-reporter: send the stat, don't print it. [extensions/EventLogging] - 10https://gerrit.wikimedia.org/r/123147 (owner: 10Ori.livneh)
[00:33:25] * bawolff  knows because I just recently submitted something with invalid json, and it was rather embarassing ;)

[00:33:30] <grrrit-wm>	 (03Merged) 10jenkins-bot: eventlogging-reporter: send the stat, don't print it. [extensions/EventLogging] - 10https://gerrit.wikimedia.org/r/123147 (owner: 10Ori.livneh)
[00:34:06] <bawolff>	 I agree with parant's setiment on gerrit 123146 - wtf seriously?
[00:35:55] <huh_>	 bawolff: I just messed it up too
[00:36:01] <huh_>	 why isn't it validated?
[00:36:07] <huh_>	 seems like it would be easy to do
[00:36:18] <grrrit-wm>	 (03CR) 10TTO: [WIP] Add log for TB hits (031 comment) [extensions/TitleBlacklist] - 10https://gerrit.wikimedia.org/r/123128 (owner: 10Gerrit Patch Uploader)
[00:36:37] <bawolff>	 I think its accidentally
[00:36:40] <bawolff>	 *Accidental
[00:38:41] <grrrit-wm>	 (03CR) 10Hiong3-eng5: "Yes, that is a good idea. :)" [extensions/WikiLexicalData] - 10https://gerrit.wikimedia.org/r/122280 (owner: 10Hiong3-eng5)
[00:41:37] <grrrit-wm>	 (03Abandoned) 10CSteipp: Disable gc during tests [integration/jenkins] - 10https://gerrit.wikimedia.org/r/121697 (owner: 10CSteipp)
[00:41:46] <grrrit-wm>	 (03PS2) 10MZMcBride: [WIP] Add log for TitleBlacklist hits [extensions/TitleBlacklist] - 10https://gerrit.wikimedia.org/r/123128 (owner: 10Gerrit Patch Uploader)
[00:43:25] <grrrit-wm>	 (03CR) 10Hoo man: Prevent GC during phpunit shutdown (031 comment) [core] - 10https://gerrit.wikimedia.org/r/123146 (owner: 10CSteipp)
[00:45:19] <grrrit-wm>	 (03PS1) 10Gerrit Patch Uploader: [WIP] Add TitleBlacklist hit log [extensions/TitleBlacklist] - 10https://gerrit.wikimedia.org/r/123150 
[00:45:25] <grrrit-wm>	 (03CR) 10Gerrit Patch Uploader: "This commit was uploaded using the Gerrit Patch Uploader [1]." [extensions/TitleBlacklist] - 10https://gerrit.wikimedia.org/r/123150 (owner: 10Gerrit Patch Uploader)
[00:45:28] <huh_>	 dammit
[00:45:38] <huh_>	 bawolff: is it possible to put two changes together?
[00:45:47] <huh_>	 After I forgot to just make a new patchset
[00:45:59] <Gloria>	 Abandon the newer changeset.
[00:46:01] <Gloria>	 And re-commit.
[00:46:10] <bawolff>	 What Gloria said
[00:46:56] <bawolff>	 although if you're feeling adventorus, and you really want to "combine" both, you can do that with an interactive rebase
[00:46:57] <huh_>	 How to abandon?
[00:47:13] <huh_>	 one supersedes the other
[00:47:18] <Gloria>	 There's an abandon button.
[00:48:40] <grrrit-wm>	 (03CR) 10PiRSquared17: [C: 04-1] "This was an accident. Merge with 123128?" [extensions/TitleBlacklist] - 10https://gerrit.wikimedia.org/r/123150 (owner: 10Gerrit Patch Uploader)
[00:49:44] <huh_>	 Gloria: I don't own it because I used the gerrit patch uploader (apparently git-review doesn't work without XCode, long story...)'
[00:50:00] <bawolff>	 actually, are you allowed to abandon other people's patches if you're not +2?
[00:50:17] <huh_>	 (I spent at least 5 hours trying to install git/git-review on old Mac OS X)
[00:50:24] <grrrit-wm>	 (03Abandoned) 10Brian Wolff: [WIP] Add TitleBlacklist hit log [extensions/TitleBlacklist] - 10https://gerrit.wikimedia.org/r/123150 (owner: 10Gerrit Patch Uploader)
[00:50:25] <Gloria>	 huh_: You can't install XCode?
[00:50:36] <huh_>	 on Leopard?
[00:50:39] <Gloria>	 That seems like a poor use of time.
[00:50:48] <Gloria>	 Which one is Leopard?
[00:51:00] <huh_>	 old
[00:51:08] <bawolff>	 silly name, leopard is supposed to speedy, like a leopard
[00:51:09] <Gloria>	 Do you need a new computer?
[00:51:33] <huh_>	 I'd rather make use of what I have
[00:51:35] <bawolff>	 Linux: It just works(tm) [In one very specific obscure field]
[00:52:09] <huh_>	 [if you know C, C++, and bash very well, and aren't afraid to code everything that doesn't work]
[00:52:33] <bawolff>	 huh_: Did you manage to get git installed, or is it both git and git review that are the problem?
[00:52:44] <huh_>	 both
[00:53:13] <huh_>	 Apparently I need a C compiler, which means I need XCode, which means I need to download it from somewhere, ...
[00:53:22] <bawolff>	 Well that sucks...
[00:54:16] <bawolff>	 There's nothing wrong with just using gerrit patch uploader, but if all else fails you could always ssh into tool labs, and work from there (or at least transfer the patch there, and then call git review from there)
[00:54:37] <huh_>	 really?
[00:55:01] <huh_>	 for now I've been working on an own instance on Labs and then getting the diff with git diff, then uploading
[00:56:15] <bawolff>	 Well in that case you should be able to install git review on your labs account, and it should just work
[00:56:29] <bawolff>	 maybe need to do some playing to make it use your ssh key
[00:56:40] <huh_>	 ssh-add and -A wouldn
[00:56:43] <huh_>	 't be enough?
[00:57:00] <bawolff>	 Actually, that would probably be fine
[00:57:43] <grrrit-wm>	 (03PS3) 10Gerrit Patch Uploader: [WIP] Add log for TitleBlacklist hits [extensions/TitleBlacklist] - 10https://gerrit.wikimedia.org/r/123128 
[00:57:45] <grrrit-wm>	 (03CR) 10Gerrit Patch Uploader: "This commit was uploaded using the Gerrit Patch Uploader [1]." [extensions/TitleBlacklist] - 10https://gerrit.wikimedia.org/r/123128 (owner: 10Gerrit Patch Uploader)
[01:01:58] <grrrit-wm>	 (03CR) 10PiRSquared17: "Problem:" (035 comments) [extensions/TitleBlacklist] - 10https://gerrit.wikimedia.org/r/123128 (owner: 10Gerrit Patch Uploader)
[01:02:14] <grrrit-wm>	 (03CR) 10PiRSquared17: "Will add qqq when ready" [extensions/TitleBlacklist] - 10https://gerrit.wikimedia.org/r/123128 (owner: 10Gerrit Patch Uploader)
[01:03:01] <grrrit-wm>	 (03CR) 10PiRSquared17: "Jenkins needs to check JSON validity." [extensions/TitleBlacklist] - 10https://gerrit.wikimedia.org/r/123128 (owner: 10Gerrit Patch Uploader)
[01:04:04] <grrrit-wm>	 (03CR) 10PiRSquared17: [WIP] Add log for TitleBlacklist hits (031 comment) [extensions/TitleBlacklist] - 10https://gerrit.wikimedia.org/r/123128 (owner: 10Gerrit Patch Uploader)
[01:12:33] <grrrit-wm>	 (03PS1) 10Ori.livneh: Update WikimediaEvents to master [core] (wmf/1.23wmf20) - 10https://gerrit.wikimedia.org/r/123154 
[01:13:41] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] Update WikimediaEvents to master [core] (wmf/1.23wmf20) - 10https://gerrit.wikimedia.org/r/123154 (owner: 10Ori.livneh)
[01:13:45] <grrrit-wm>	 (03PS1) 10Ori.livneh: Update WikimediaEvents for 1.23wmf19 cherry-picks [core] (wmf/1.23wmf19) - 10https://gerrit.wikimedia.org/r/123155 
[01:14:49] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] Update WikimediaEvents for 1.23wmf19 cherry-picks [core] (wmf/1.23wmf19) - 10https://gerrit.wikimedia.org/r/123155 (owner: 10Ori.livneh)
[01:16:58] <grrrit-wm>	 (03Abandoned) 10Ori.livneh: Update WikimediaEvents for 1.23wmf19 cherry-picks [core] (wmf/1.23wmf19) - 10https://gerrit.wikimedia.org/r/123155 (owner: 10Ori.livneh)
[01:17:06] <grrrit-wm>	 (03Abandoned) 10Ori.livneh: Update WikimediaEvents to master [core] (wmf/1.23wmf20) - 10https://gerrit.wikimedia.org/r/123154 (owner: 10Ori.livneh)
[01:20:05] <grrrit-wm>	 (03PS4) 10Mwalker: Better WorldPay form settings [core] (fundraising/REL1_22) - 10https://gerrit.wikimedia.org/r/121504 
[01:20:28] <ori>	 Krinkle: tin:/home/krinkle/deprecated.py
[01:35:42] <grrrit-wm>	 (03PS1) 10Brian Wolff: Make sure batch preview page shows correct link colour [extensions/GWToolset] - 10https://gerrit.wikimedia.org/r/123157 
[01:41:08] <grrrit-wm>	 (03CR) 10Jackmcbarn: [C: 031] Prevent passing information between #invokes using math.random [extensions/Scribunto] - 10https://gerrit.wikimedia.org/r/122862 (owner: 10Anomie)
[01:48:08] <bawolff>	 --^ lol, those crazy wikipedians
[01:50:11] <legoktm>	 we try!
[02:00:32] <bawolff>	 I'm always amazed at the crap they come up with to get around template restrictions
[02:06:19] <grrrit-wm>	 (03PS1) 10Brian Wolff: Mark GWToolset namespace as being json for code editor. [extensions/GWToolset] - 10https://gerrit.wikimedia.org/r/123159 
[02:33:47] <grrrit-wm>	 (03PS1) 10Jforrester: Update OOjs UI to v0.1.0-pre (8986c46d35) [core] - 10https://gerrit.wikimedia.org/r/123167 
[02:34:17] <grrrit-wm>	 (03CR) 10Swalling: [C: 031] "Patchset 4 looks good from a UX perspective, in Chrome and FF." [extensions/GettingStarted] - 10https://gerrit.wikimedia.org/r/119972 (owner: 10Phuedx)
[02:47:56] <grrrit-wm>	 (03CR) 10BryanDavis: [C: 032] Mark GWToolset namespace as being json for code editor. [extensions/GWToolset] - 10https://gerrit.wikimedia.org/r/123159 (owner: 10Brian Wolff)
[02:48:01] <grrrit-wm>	 (03Merged) 10jenkins-bot: Mark GWToolset namespace as being json for code editor. [extensions/GWToolset] - 10https://gerrit.wikimedia.org/r/123159 (owner: 10Brian Wolff)
[02:48:13] <bawolff>	 bd808|BUFFER: Weee! that was fast. Thanks :)
[03:00:06] <grrrit-wm>	 (03PS10) 10Brian Wolff: Allow hiding patrol entries from Special:Log for all users [core] - 10https://gerrit.wikimedia.org/r/42279 
[03:01:09] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] Allow hiding patrol entries from Special:Log for all users [core] - 10https://gerrit.wikimedia.org/r/42279 (owner: 10Brian Wolff)
[03:01:20] <bawolff>	 yeah yeah, I'm rebasing it
[03:03:26] <grrrit-wm>	 (03PS11) 10Brian Wolff: Allow hiding patrol entries from Special:Log for all users [core] - 10https://gerrit.wikimedia.org/r/42279 
[03:03:46] <grrrit-wm>	 (03CR) 10Brian Wolff: "PS11: rebase. again..." [core] - 10https://gerrit.wikimedia.org/r/42279 (owner: 10Brian Wolff)
[03:15:21] <grrrit-wm>	 (03PS6) 10Brian Wolff: Use rgba() for gallery caption background instead of opacity [core] - 10https://gerrit.wikimedia.org/r/116227 
[03:16:11] <grrrit-wm>	 (03CR) 10Brian Wolff: "Ok. I also changed background-color, to just background, as old IE wasn't falling back properly, and google told me that would fix that." [core] - 10https://gerrit.wikimedia.org/r/116227 (owner: 10Brian Wolff)
[03:43:56] <grrrit-wm>	 (03CR) 10Legoktm: [C: 04-1] "Haven't tested it yet" (033 comments) [extensions/TitleBlacklist] - 10https://gerrit.wikimedia.org/r/123128 (owner: 10Gerrit Patch Uploader)
[03:51:01] <huh_>	 legoktm: also it only works with redlink=1 ...
[03:51:17] <legoktm>	 o.O
[03:51:20] <legoktm>	 that seems weird.
[03:51:40] <huh_>	 I think the logging should be removed from the userCan hook, but I'm not sure where it should go.
[03:52:03] <huh_>	 I'm not even sure logging GET requests is a good idea, but it seems fine if there's a config flag for it
[03:52:03] <legoktm>	 I don't think logging userCan is a safe thing to do
[03:52:29] <legoktm>	 huh_: I think you should start with just logging account creation attempts
[03:52:44] <huh_>	 ...that part works
[03:52:45] <legoktm>	 thats something we can safely log without the fear of logging any GET request
[03:52:57] <legoktm>	 and that was what ajr wanted in his request
[03:53:15] <legoktm>	 logging GET requests is probably a security issue and won't happen
[03:53:39] <huh_>	 even if only admins can see the log?
[03:54:06] <legoktm>	 yeah
[03:54:39] <legoktm>	 because I could do <iframe src="http://foo/?title=Blacklisted&action=edit"> to spam the log with totally false requests
[03:57:23] <huh_>	 legoktm: so do you recommend restricting https://bugzilla.wikimedia.org/show_bug.cgi?id=21206 to page moves and account creations?
[03:57:49] <legoktm>	 yes
[04:19:04] <^d>	 marktraceur: I really don't know/remember.
[04:26:36] <grrrit-wm>	 (03CR) 10Ori.livneh: [V: 032] "Jenkins missed this one. Timo +2'd the patch, but there was no follow-up. Odd." [extensions/WikimediaEvents] - 10https://gerrit.wikimedia.org/r/119903 (owner: 10Ori.livneh)
[04:26:46] <grrrit-wm>	 (03CR) 10Ori.livneh: [C: 032] "Jenkins missed this one. Timo +2'd the patch, but there was no follow-up. Odd." [extensions/WikimediaEvents] - 10https://gerrit.wikimedia.org/r/119903 (owner: 10Ori.livneh)
[04:34:41] <grrrit-wm>	 (03CR) 10Phuedx: [C: 032] Put LESS test back into extension suite in XML [core] - 10https://gerrit.wikimedia.org/r/123096 (owner: 10Mattflaschen)
[04:37:47] <grrrit-wm>	 (03Merged) 10jenkins-bot: Put LESS test back into extension suite in XML [core] - 10https://gerrit.wikimedia.org/r/123096 (owner: 10Mattflaschen)
[04:49:34] <Amgine>	 btw: just in case no one has mentioned it, going live with the Vector changes (which somehow managed to break templates on en.WT, amongst other things) on 1 April was probably a not-good-thing. Someone should make note to not doing things which cause logophiles to assume a skin change is actually an April Fool's joke.
[04:49:57] <grrrit-wm>	 (03CR) 10Siebrand: "Matt, can you please review again?" [extensions/MwEmbedSupport] - 10https://gerrit.wikimedia.org/r/121950 (owner: 10Siebrand)
[04:50:02] <Amgine>	 not do things
[04:50:03] <Amgine>	 \
[04:51:50] <grrrit-wm>	 (03CR) 10KartikMistry: Use a configurable logger (031 comment) [services/cxserver] - 10https://gerrit.wikimedia.org/r/122339 (owner: 10Santhosh)
[04:52:58] <grrrit-wm>	 (03CR) 10Santhosh: Use a configurable logger (031 comment) [services/cxserver] - 10https://gerrit.wikimedia.org/r/122339 (owner: 10Santhosh)
[04:54:46] <grrrit-wm>	 (03PS5) 10Santhosh: Use a configurable logger [services/cxserver] - 10https://gerrit.wikimedia.org/r/122339 
[05:18:24] <grrrit-wm>	 (03PS1) 10KartikMistry: Add *.log to .gitignore [services/cxserver] - 10https://gerrit.wikimedia.org/r/123169 
[05:28:50] <grrrit-wm>	 (03PS3) 10Hiong3-eng5: Document generator [extensions/WikiLexicalData] - 10https://gerrit.wikimedia.org/r/122280 
[05:38:46] <grrrit-wm>	 (03PS1) 10AndyRussG: DI: global $wgCampaignsDI, improve tests and doc [extensions/Campaigns] (wip/editorcampaigns) - 10https://gerrit.wikimedia.org/r/123170 
[05:42:14] <grrrit-wm>	 (03CR) 10AndyRussG: Add persistence objects and tests (031 comment) [extensions/Campaigns] (wip/editorcampaigns) - 10https://gerrit.wikimedia.org/r/116221 (owner: 10AndyRussG)
[05:51:30] <grrrit-wm>	 (03PS4) 10Hiong3-eng5: Document generator [extensions/WikiLexicalData] - 10https://gerrit.wikimedia.org/r/122280 
[05:54:49] <grrrit-wm>	 (03PS2) 10AndyRussG: DI: global $wgCampaignsDI, improve tests and doc [extensions/Campaigns] (wip/editorcampaigns) - 10https://gerrit.wikimedia.org/r/123170 
[05:57:41] <grrrit-wm>	 (03CR) 10AndyRussG: Add minimal dependency injection, including tests (032 comments) [extensions/Campaigns] (wip/editorcampaigns) - 10https://gerrit.wikimedia.org/r/116153 (owner: 10AndyRussG)
[06:03:59] <grrrit-wm>	 (03PS2) 10AndyRussG: WIP Update Campaigns database schema [extensions/Campaigns] (wip/editorcampaigns) - 10https://gerrit.wikimedia.org/r/122223 
[06:07:09] <grrrit-wm>	 (03PS10) 10Nemo bis: Make captcha.py produce images in arbitrary language [extensions/ConfirmEdit] - 10https://gerrit.wikimedia.org/r/121255 
[06:07:58] <grrrit-wm>	 (03CR) 10Santhosh: [C: 032] Add *.log to .gitignore [services/cxserver] - 10https://gerrit.wikimedia.org/r/123169 (owner: 10KartikMistry)
[06:08:00] <grrrit-wm>	 (03Merged) 10jenkins-bot: Add *.log to .gitignore [services/cxserver] - 10https://gerrit.wikimedia.org/r/123169 (owner: 10KartikMistry)
[06:08:55] <grrrit-wm>	 (03CR) 10AndyRussG: "Just rebasing for hygienic history (so schema change and domain/persistence layer stay together)." [extensions/Campaigns] (wip/editorcampaigns) - 10https://gerrit.wikimedia.org/r/122223 (owner: 10AndyRussG)
[06:23:41] <grrrit-wm>	 (03PS11) 10Mattflaschen: WIP: Refactor and add non-linear tours [extensions/GuidedTour] - 10https://gerrit.wikimedia.org/r/116228 
[06:23:43] <grrrit-wm>	 (03PS1) 10Mattflaschen: Update firsteditve [extensions/GuidedTour] - 10https://gerrit.wikimedia.org/r/123171 
[06:24:08] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] WIP: Refactor and add non-linear tours [extensions/GuidedTour] - 10https://gerrit.wikimedia.org/r/116228 (owner: 10Mattflaschen)
[06:24:29] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] Update firsteditve [extensions/GuidedTour] - 10https://gerrit.wikimedia.org/r/123171 (owner: 10Mattflaschen)
[06:30:20] <grrrit-wm>	 (03CR) 10Mattflaschen: [C: 04-1] "I started this as a way to test the mw.hook support in the GuidedTour non-linear work. It's dependent on that change." [extensions/GuidedTour] - 10https://gerrit.wikimedia.org/r/123171 (owner: 10Mattflaschen)
[06:31:44] <grrrit-wm>	 (03CR) 10Mattflaschen: "I made progress, but I need to think more about when to unregister the hooks. First I was doing onClose. However, that left listeners fo" [extensions/GuidedTour] - 10https://gerrit.wikimedia.org/r/116228 (owner: 10Mattflaschen)
[06:32:59] <grrrit-wm>	 (03PS1) 10Ori.livneh: Use simple random sampling to log deprecated usage at 1:100 [extensions/WikimediaEvents] - 10https://gerrit.wikimedia.org/r/123172 
[06:43:24] <grrrit-wm>	 (03PS2) 10Prtksxna: Remove `redirects to` text and heading [extensions/Popups] - 10https://gerrit.wikimedia.org/r/121373 
[06:43:26] <grrrit-wm>	 (03PS5) 10Prtksxna: Add white fill in triangle for hovercards with images [extensions/Popups] - 10https://gerrit.wikimedia.org/r/120174 
[06:44:07] <grrrit-wm>	 (03CR) 10Prtksxna: Add white fill in triangle for hovercards with images (031 comment) [extensions/Popups] - 10https://gerrit.wikimedia.org/r/120174 (owner: 10Prtksxna)
[06:46:31] <grrrit-wm>	 (03PS4) 10Prtksxna: Use escape key to hide popup [extensions/Popups] - 10https://gerrit.wikimedia.org/r/120343 
[06:46:33] <grrrit-wm>	 (03PS5) 10Prtksxna: Show and hide Popups on focus and blur (along with mouseenter/leave) [extensions/Popups] - 10https://gerrit.wikimedia.org/r/120342 
[06:46:35] <grrrit-wm>	 (03PS4) 10Prtksxna: Use aria-hidden for popups [extensions/Popups] - 10https://gerrit.wikimedia.org/r/120345 
[06:46:37] <grrrit-wm>	 (03PS4) 10Prtksxna: Use tooltip role for Popups [extensions/Popups] - 10https://gerrit.wikimedia.org/r/120344 
[06:46:39] <grrrit-wm>	 (03CR) 10Prtksxna: Show and hide Popups on focus and blur (along with mouseenter/leave) (031 comment) [extensions/Popups] - 10https://gerrit.wikimedia.org/r/120342 (owner: 10Prtksxna)
[06:49:40] <grrrit-wm>	 (03CR) 10Amire80: [C: 032] Show and hide Popups on focus and blur (along with mouseenter/leave) [extensions/Popups] - 10https://gerrit.wikimedia.org/r/120342 (owner: 10Prtksxna)
[06:49:44] <grrrit-wm>	 (03Merged) 10jenkins-bot: Show and hide Popups on focus and blur (along with mouseenter/leave) [extensions/Popups] - 10https://gerrit.wikimedia.org/r/120342 (owner: 10Prtksxna)
[06:50:20] <grrrit-wm>	 (03CR) 10Amire80: [C: 032] Add white fill in triangle for hovercards with images [extensions/Popups] - 10https://gerrit.wikimedia.org/r/120174 (owner: 10Prtksxna)
[06:54:13] <grrrit-wm>	 (03CR) 10Prtksxna: "Could you please submit changes, I don't know why this isn't merging automatically." [extensions/Popups] - 10https://gerrit.wikimedia.org/r/120174 (owner: 10Prtksxna)
[06:54:15] <grrrit-wm>	 (03PS3) 10Amire80: Remove `redirects to` text and heading [extensions/Popups] - 10https://gerrit.wikimedia.org/r/121373 (owner: 10Prtksxna)
[06:54:20] <grrrit-wm>	 (03CR) 10Amire80: [C: 032] Remove `redirects to` text and heading [extensions/Popups] - 10https://gerrit.wikimedia.org/r/121373 (owner: 10Prtksxna)
[06:54:24] <grrrit-wm>	 (03Merged) 10jenkins-bot: Remove `redirects to` text and heading [extensions/Popups] - 10https://gerrit.wikimedia.org/r/121373 (owner: 10Prtksxna)
[06:54:39] <grrrit-wm>	 (03PS6) 10Amire80: Add white fill in triangle for hovercards with images [extensions/Popups] - 10https://gerrit.wikimedia.org/r/120174 (owner: 10Prtksxna)
[06:54:50] <grrrit-wm>	 (03CR) 10Amire80: [C: 032] Add white fill in triangle for hovercards with images [extensions/Popups] - 10https://gerrit.wikimedia.org/r/120174 (owner: 10Prtksxna)
[06:54:54] <grrrit-wm>	 (03Merged) 10jenkins-bot: Add white fill in triangle for hovercards with images [extensions/Popups] - 10https://gerrit.wikimedia.org/r/120174 (owner: 10Prtksxna)
[06:55:14] <grrrit-wm>	 (03PS6) 10Santhosh: Use a configurable logger [services/cxserver] - 10https://gerrit.wikimedia.org/r/122339 
[07:00:16] <grrrit-wm>	 (03PS1) 10Legoktm: mw.flow.api.read returns a jQuery.Promise, not a Deferred [extensions/Flow] - 10https://gerrit.wikimedia.org/r/123173 
[07:14:32] <grrrit-wm>	 (03PS7) 10Santhosh: Use a configurable logger [services/cxserver] - 10https://gerrit.wikimedia.org/r/122339 
[07:27:05] <grrrit-wm>	 (03CR) 10Santhosh: [C: 04-1] Use escape key to hide popup (031 comment) [extensions/Popups] - 10https://gerrit.wikimedia.org/r/120343 (owner: 10Prtksxna)
[07:27:42] <grrrit-wm>	 (03PS1) 10Legoktm: API: Remove 'flowaction' parameter from list=flow [extensions/Flow] - 10https://gerrit.wikimedia.org/r/123174 
[07:44:32] <grrrit-wm>	 (03CR) 10Siebrand: "Mark, do you still have any plans with this? Otherwise I think we should archive/abandon this soon." [extensions/BetaFeatures] - 10https://gerrit.wikimedia.org/r/84625 (owner: 10MarkTraceur)
[08:01:45] <grrrit-wm>	 (03PS1) 10Legoktm: API: Set 'missing': '', instead of 'missing': 'missing' [extensions/Flow] - 10https://gerrit.wikimedia.org/r/123178 
[08:11:04] <grrrit-wm>	 (03CR) 10MaxSem: [C: 032] Add support for JSON files using messageDir [extensions/MwEmbedSupport] - 10https://gerrit.wikimedia.org/r/121950 (owner: 10Siebrand)
[08:11:07] <grrrit-wm>	 (03Merged) 10jenkins-bot: Add support for JSON files using messageDir [extensions/MwEmbedSupport] - 10https://gerrit.wikimedia.org/r/121950 (owner: 10Siebrand)
[08:11:24] <siebrand>	 MaxSem: Cool. You tested, right?
[08:11:26] <siebrand>	 ;)
[08:11:47] <MaxSem>	 I what?:P
[08:12:41] <siebrand>	 MaxSem: You can also merge the two extension patches in https://gerrit.wikimedia.org/r/#/q/status:open+topic:json-i18n-special,n,z now.
[08:14:14] <MaxSem>	 btw siebrand, when do you plan to kill the PHP shims?
[08:14:32] <siebrand>	 MaxSem: I was thinking around MediaWiki 1.25 release.
[08:14:54] <siebrand>	 MaxSem: Then people are expected to be at 1.23LTS or later.
[08:15:44] <siebrand>	 MaxSem: Before that, I'll leave it at the discretion of the extenion maintainers.
[08:30:22] <grrrit-wm>	 (03CR) 10Siebrand: "The dependency has been merged, so this can go in now." [extensions/MwEmbedSupport] - 10https://gerrit.wikimedia.org/r/121976 (owner: 10Siebrand)
[08:30:50] <grrrit-wm>	 (03CR) 10Siebrand: "The dependency has been merged, so this can go in now." [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/121981 (owner: 10Siebrand)
[08:31:13] <grrrit-wm>	 (03CR) 10TheDJ: [C: 04-1] Use document.createElementNS for svg image (031 comment) [extensions/Popups] - 10https://gerrit.wikimedia.org/r/122352 (owner: 10Prtksxna)
[09:05:20] <grrrit-wm>	 (03CR) 10KartikMistry: Use a configurable logger (032 comments) [services/cxserver] - 10https://gerrit.wikimedia.org/r/122339 (owner: 10Santhosh)
[09:08:23] <grrrit-wm>	 (03PS8) 10Santhosh: Use a configurable logger [services/cxserver] - 10https://gerrit.wikimedia.org/r/122339 
[09:20:41] <grrrit-wm>	 (03CR) 10Siebrand: [C: 04-1] "i18n/L10n reviewed." (032 comments) [extensions/TitleBlacklist] - 10https://gerrit.wikimedia.org/r/123128 (owner: 10Gerrit Patch Uploader)
[09:21:17] <grrrit-wm>	 (03CR) 10Phuedx: [C: 032] Fix out of date comment re onClose [extensions/GuidedTour] - 10https://gerrit.wikimedia.org/r/123122 (owner: 10Mattflaschen)
[09:21:41] <grrrit-wm>	 (03Merged) 10jenkins-bot: Fix out of date comment re onClose [extensions/GuidedTour] - 10https://gerrit.wikimedia.org/r/123122 (owner: 10Mattflaschen)
[09:22:49] <grrrit-wm>	 (03CR) 10Siebrand: Added a Redis pool counter class (031 comment) [core] - 10https://gerrit.wikimedia.org/r/118955 (owner: 10Aaron Schulz)
[09:23:15] <grrrit-wm>	 (03Abandoned) 10Phuedx: [WIP] Use grunt-contrib-less to lint LESS files [extensions/GettingStarted] - 10https://gerrit.wikimedia.org/r/118285 (owner: 10Phuedx)
[09:23:29] <grrrit-wm>	 (03Abandoned) 10Phuedx: [WIP] Use grunt-contrib-less to lint LESS files [extensions/GuidedTour] - 10https://gerrit.wikimedia.org/r/118327 (owner: 10Phuedx)
[09:24:10] <grrrit-wm>	 (03PS2) 10Phuedx: Make checkLess.php validate skin styles [core] - 10https://gerrit.wikimedia.org/r/122838 
[09:25:19] <grrrit-wm>	 (03PS1) 10Siebrand: Add punctuation to "pool-servererror" [core] - 10https://gerrit.wikimedia.org/r/123188 
[09:32:36] <grrrit-wm>	 (03CR) 10Siebrand: [C: 031] "i18n/L10n reviewed." [extensions/Workflow] - 10https://gerrit.wikimedia.org/r/107307 (owner: 10Adamw)
[09:33:09] <grrrit-wm>	 (03PS4) 10Hashar: Add cxserver-npm job for mediawiki/services/cxserver [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/122715 (owner: 10Santhosh)
[09:34:05] <grrrit-wm>	 (03PS9) 10Nik: Insert configuration settings check [extensions/PubSubHubbub] - 10https://gerrit.wikimedia.org/r/109078 (owner: 10Alexander.lehmann)
[09:34:28] <grrrit-wm>	 (03CR) 10KartikMistry: [C: 032] "LGTM. Tested." [services/cxserver] - 10https://gerrit.wikimedia.org/r/122339 (owner: 10Santhosh)
[09:34:30] <grrrit-wm>	 (03Merged) 10jenkins-bot: Use a configurable logger [services/cxserver] - 10https://gerrit.wikimedia.org/r/122339 (owner: 10Santhosh)
[09:34:49] <grrrit-wm>	 (03CR) 10Hashar: [C: 032] "deployed :-]" [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/122715 (owner: 10Santhosh)
[09:34:49] <grrrit-wm>	 (03PS3) 10Hashar: Use {name}-npm instead of {name}-npmtest for cxserver [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/122716 (owner: 10Santhosh)
[09:35:03] <grrrit-wm>	 (03CR) 10Hashar: [C: 032] Use {name}-npm instead of {name}-npmtest for cxserver [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/122716 (owner: 10Santhosh)
[09:35:08] <grrrit-wm>	 (03Merged) 10jenkins-bot: Use {name}-npm instead of {name}-npmtest for cxserver [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/122716 (owner: 10Santhosh)
[09:35:11] <grrrit-wm>	 (03Merged) 10jenkins-bot: Add cxserver-npm job for mediawiki/services/cxserver [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/122715 (owner: 10Santhosh)
[09:35:14] <grrrit-wm>	 (03CR) 10Nik: [C: 032] Insert configuration settings check [extensions/PubSubHubbub] - 10https://gerrit.wikimedia.org/r/109078 (owner: 10Alexander.lehmann)
[09:37:00] <grrrit-wm>	 (03PS1) 10Hashar: Jenkins job validation (DO NOT SUBMIT) [services/cxserver] - 10https://gerrit.wikimedia.org/r/123189 
[09:37:59] <grrrit-wm>	 (03Abandoned) 10Hashar: Jenkins job validation (DO NOT SUBMIT) [services/cxserver] - 10https://gerrit.wikimedia.org/r/123189 (owner: 10Hashar)
[09:38:27] <grrrit-wm>	 (03PS1) 10Santhosh: Misc code formatting cleanup [extensions/Popups] - 10https://gerrit.wikimedia.org/r/123190 
[09:40:02] <zeek>	 HI, I am facing problems with the control flow of extention LiquidThreads . I want to know where the control is handled on submittion of replies.
[09:44:09] <Nemo_bis>	 ?
[09:45:14] <zeek>	 HI, I am facing problems with the control flow of extention LiquidThreads . I want to know where the control is handled on submittion of replies.
[09:48:07] <Nemo_bis>	 repeating doesn't help
[09:48:10] <grrrit-wm>	 (03Abandoned) 10Matthias Mullie: Implement paywall to view more than the first reply [extensions/Flow] - 10https://gerrit.wikimedia.org/r/122660 (owner: 10Matthias Mullie)
[09:57:39] <grrrit-wm>	 (03PS1) 10Nik: Added composer.json. [extensions/PubSubHubbub] - 10https://gerrit.wikimedia.org/r/123192 
[09:59:34] <grrrit-wm>	 (03PS1) 10Santhosh: Move the segmentation tests to a new folder [services/cxserver] - 10https://gerrit.wikimedia.org/r/123193 
[10:00:02] <grrrit-wm>	 (03CR) 10Nik: [C: 032 V: 032] Added composer.json. [extensions/PubSubHubbub] - 10https://gerrit.wikimedia.org/r/123192 (owner: 10Nik)
[10:13:39] <grrrit-wm>	 (03CR) 10KartikMistry: [C: 032] "LGTM." [services/cxserver] - 10https://gerrit.wikimedia.org/r/123193 (owner: 10Santhosh)
[10:14:01] <grrrit-wm>	 (03Merged) 10jenkins-bot: Move the segmentation tests to a new folder [services/cxserver] - 10https://gerrit.wikimedia.org/r/123193 (owner: 10Santhosh)
[10:17:56] <grrrit-wm>	 (03PS2) 10Alexander.lehmann: insert test for class PubsubHubbub [extensions/PubSubHubbub] - 10https://gerrit.wikimedia.org/r/122844 
[10:20:07] <grrrit-wm>	 (03Abandoned) 10Hashar: Jenkins validation (DO NOT SUBMIT) [tools/release] - 10https://gerrit.wikimedia.org/r/70200 (owner: 10Hashar)
[10:26:35] <grrrit-wm>	 (03CR) 10Alexander.lehmann: [C: 031 V: 032] Insert configuration settings check [extensions/PubSubHubbub] - 10https://gerrit.wikimedia.org/r/109078 (owner: 10Alexander.lehmann)
[10:39:03] <grrrit-wm>	 (03CR) 10Alexander.lehmann: [C: 032] Create Wikibase URL if it's a Wikibase item. [extensions/PubSubHubbub] - 10https://gerrit.wikimedia.org/r/112656 (owner: 10Nik)
[10:48:51] <grrrit-wm>	 (03PS1) 10Santhosh: Fix the arguments for assertEqual [services/cxserver] - 10https://gerrit.wikimedia.org/r/123197 
[10:48:53] <grrrit-wm>	 (03PS1) 10Santhosh: Use an optional description for segmentation tests [services/cxserver] - 10https://gerrit.wikimedia.org/r/123198 
[10:48:55] <grrrit-wm>	 (03PS1) 10Santhosh: Correct the order of arguments for strictEqual [services/cxserver] - 10https://gerrit.wikimedia.org/r/123199 
[10:48:57] <grrrit-wm>	 (03PS1) 10Santhosh: Add tests for sentences ending with reference [services/cxserver] - 10https://gerrit.wikimedia.org/r/123200 
[11:06:11] <grrrit-wm>	 (03PS1) 10Nik: Fixed Debug output message if no hub is set up. [extensions/PubSubHubbub] - 10https://gerrit.wikimedia.org/r/123201 
[11:07:09] <grrrit-wm>	 (03CR) 10Nik: [C: 032 V: 032] Fixed Debug output message if no hub is set up. [extensions/PubSubHubbub] - 10https://gerrit.wikimedia.org/r/123201 (owner: 10Nik)
[11:13:08] <grrrit-wm>	 (03CR) 10KartikMistry: [C: 032] "LGTM. Tested." [services/cxserver] - 10https://gerrit.wikimedia.org/r/123197 (owner: 10Santhosh)
[11:13:31] <grrrit-wm>	 (03Merged) 10jenkins-bot: Fix the arguments for assertEqual [services/cxserver] - 10https://gerrit.wikimedia.org/r/123197 (owner: 10Santhosh)
[11:14:32] <grrrit-wm>	 (03CR) 10Nikerabbit: [C: 032] Add punctuation to "pool-servererror" [core] - 10https://gerrit.wikimedia.org/r/123188 (owner: 10Siebrand)
[11:17:29] <grrrit-wm>	 (03Merged) 10jenkins-bot: Add punctuation to "pool-servererror" [core] - 10https://gerrit.wikimedia.org/r/123188 (owner: 10Siebrand)
[11:21:15] <grrrit-wm>	 (03CR) 10KartikMistry: [C: 032] "LGTM." [services/cxserver] - 10https://gerrit.wikimedia.org/r/123198 (owner: 10Santhosh)
[11:21:38] <grrrit-wm>	 (03Merged) 10jenkins-bot: Use an optional description for segmentation tests [services/cxserver] - 10https://gerrit.wikimedia.org/r/123198 (owner: 10Santhosh)
[11:22:36] <grrrit-wm>	 (03CR) 10KartikMistry: [C: 032] "LGTM." [services/cxserver] - 10https://gerrit.wikimedia.org/r/123199 (owner: 10Santhosh)
[11:22:58] <grrrit-wm>	 (03Merged) 10jenkins-bot: Correct the order of arguments for strictEqual [services/cxserver] - 10https://gerrit.wikimedia.org/r/123199 (owner: 10Santhosh)
[11:25:00] <grrrit-wm>	 (03PS2) 10Nik: Create Wikibase URL if it's a Wikibase item. [extensions/PubSubHubbub] - 10https://gerrit.wikimedia.org/r/112656 
[11:27:23] <grrrit-wm>	 (03CR) 10KartikMistry: [C: 032] "LGTM. Both tests passes." [services/cxserver] - 10https://gerrit.wikimedia.org/r/123200 (owner: 10Santhosh)
[11:27:44] <grrrit-wm>	 (03Merged) 10jenkins-bot: Add tests for sentences ending with reference [services/cxserver] - 10https://gerrit.wikimedia.org/r/123200 (owner: 10Santhosh)
[11:33:14] <grrrit-wm>	 (03CR) 10Nikerabbit: [C: 04-1] Cleaning up function definitions in Language.php (032 comments) [core] - 10https://gerrit.wikimedia.org/r/122615 (owner: 10Kaldari)
[11:35:48] <grrrit-wm>	 (03CR) 10Nikerabbit: [C: 032 V: 032] Migrate to JSON i18n [extensions/Sarcasm] - 10https://gerrit.wikimedia.org/r/123047 (owner: 10Siebrand)
[11:36:33] <grrrit-wm>	 (03CR) 10Nikerabbit: [C: 032 V: 032] Migrate to JSON i18n [extensions/ScanSet] - 10https://gerrit.wikimedia.org/r/123048 (owner: 10Siebrand)
[11:37:36] <grrrit-wm>	 (03CR) 10Nikerabbit: [C: 032 V: 032] Migrate to JSON i18n [extensions/SectionDisqus] - 10https://gerrit.wikimedia.org/r/123049 (owner: 10Siebrand)
[11:37:51] <grrrit-wm>	 (03CR) 10Nikerabbit: [C: 032 V: 032] Migrate to JSON i18n [extensions/SecureHTML] - 10https://gerrit.wikimedia.org/r/123050 (owner: 10Siebrand)
[11:38:23] <grrrit-wm>	 (03CR) 10Nikerabbit: [C: 032 V: 032] Migrate to JSON i18n [extensions/SecurePasswords] - 10https://gerrit.wikimedia.org/r/123051 (owner: 10Siebrand)
[11:48:45] <grrrit-wm>	 (03PS1) 10Santhosh: Make it possible to run individual tests [services/cxserver] - 10https://gerrit.wikimedia.org/r/123207 
[11:55:56] <grrrit-wm>	 (03PS1) 10Shirayuki: i18n: fix the parser function name [core] - 10https://gerrit.wikimedia.org/r/123208 
[11:58:06] <grrrit-wm>	 (03PS2) 10Shirayuki: i18n: Fix the parser function name [core] - 10https://gerrit.wikimedia.org/r/123208 
[12:01:27] <grrrit-wm>	 (03CR) 10Siebrand: [C: 032] i18n: Fix the parser function name [core] - 10https://gerrit.wikimedia.org/r/123208 (owner: 10Shirayuki)
[12:04:18] <grrrit-wm>	 (03Merged) 10jenkins-bot: i18n: Fix the parser function name [core] - 10https://gerrit.wikimedia.org/r/123208 (owner: 10Shirayuki)
[12:14:13] <grrrit-wm>	 (03CR) 10KartikMistry: [C: 032] "Thanks!" [services/cxserver] - 10https://gerrit.wikimedia.org/r/123207 (owner: 10Santhosh)
[12:14:35] <grrrit-wm>	 (03Merged) 10jenkins-bot: Make it possible to run individual tests [services/cxserver] - 10https://gerrit.wikimedia.org/r/123207 (owner: 10Santhosh)
[12:42:35] <grrrit-wm>	 (03Abandoned) 10Mglaser: Updated Release Notes with security fixes [core] - 10https://gerrit.wikimedia.org/r/115970 (owner: 10Mglaser)
[12:54:38] <grrrit-wm>	 (03CR) 10MarkAHershberger: [C: 032] Fix resetting password [core] (REL1_19) - 10https://gerrit.wikimedia.org/r/122832 (owner: 10Mglaser)
[12:57:08] <grrrit-wm>	 (03Merged) 10jenkins-bot: Fix resetting password [core] (REL1_19) - 10https://gerrit.wikimedia.org/r/122832 (owner: 10Mglaser)
[13:01:15] <grrrit-wm>	 (03PS1) 10Matthias Mullie: Some changes to diff & hist links [extensions/Flow] - 10https://gerrit.wikimedia.org/r/123214 
[13:01:18] <grrrit-wm>	 (03PS1) 10Matthias Mullie: Add "cur" & "prev" difflinks in history, similar to article history [extensions/Flow] - 10https://gerrit.wikimedia.org/r/123215 
[13:01:21] <grrrit-wm>	 (03PS1) 10Matthias Mullie: Remove some of the magic in formatTimestamp [extensions/Flow] - 10https://gerrit.wikimedia.org/r/123216 
[13:01:24] <grrrit-wm>	 (03PS1) 10Matthias Mullie: Make timestamps link to the revision at that particular point in time [extensions/Flow] - 10https://gerrit.wikimedia.org/r/123217 
[13:08:14] <grrrit-wm>	 (03PS1) 10Mglaser: Updated release notes and version number for MediaWiki 1.19.15 [core] (REL1_19) - 10https://gerrit.wikimedia.org/r/123218 
[13:08:57] <grrrit-wm>	 (03CR) 10Nikerabbit: [C: 032 V: 032] Migrate to JSON i18n [extensions/SecureSessions] - 10https://gerrit.wikimedia.org/r/123052 (owner: 10Siebrand)
[13:09:54] <grrrit-wm>	 (03CR) 10Nikerabbit: [C: 032 V: 032] Migrate to JSON i18n [extensions/SelectTag] - 10https://gerrit.wikimedia.org/r/123053 (owner: 10Siebrand)
[13:11:02] <grrrit-wm>	 (03CR) 10Nikerabbit: [C: 032 V: 032] Migrate to JSON i18n [extensions/SelectCategory] - 10https://gerrit.wikimedia.org/r/123054 (owner: 10Siebrand)
[13:14:58] <grrrit-wm>	 (03CR) 10Nikerabbit: [C: 032 V: 032] Migrate to JSON i18n [extensions/SharedCssJs] - 10https://gerrit.wikimedia.org/r/123075 (owner: 10Siebrand)
[13:15:32] <grrrit-wm>	 (03CR) 10Nikerabbit: [C: 032 V: 032] Migrate to JSON i18n [extensions/ShoutBox] - 10https://gerrit.wikimedia.org/r/123076 (owner: 10Siebrand)
[13:16:04] <grrrit-wm>	 (03CR) 10Nikerabbit: [C: 032 V: 032] Migrate to JSON i18n [extensions/SidebarDonateBox] - 10https://gerrit.wikimedia.org/r/123078 (owner: 10Siebrand)
[13:18:14] <grrrit-wm>	 (03CR) 10Nikerabbit: [C: 032 V: 032] Migrate to JSON i18n [extensions/SignWritingMediaWikiPlugin] - 10https://gerrit.wikimedia.org/r/123079 (owner: 10Siebrand)
[13:20:57] <grrrit-wm>	 (03PS1) 10Nikerabbit: whitespace cleanup [extensions/SignWritingMediaWikiPlugin] - 10https://gerrit.wikimedia.org/r/123219 
[13:21:19] <grrrit-wm>	 (03PS5) 10Matthias Mullie: Don't escape the userlinks displayed in "This topic was suppressed by <links>" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/121385 
[13:21:26] <grrrit-wm>	 (03CR) 10Nikerabbit: [C: 032 V: 032] Migrate to JSON i18n [extensions/SimpleFarm] - 10https://gerrit.wikimedia.org/r/123081 (owner: 10Siebrand)
[13:21:46] <grrrit-wm>	 (03CR) 10Nikerabbit: [C: 032 V: 032] whitespace cleanup [extensions/SignWritingMediaWikiPlugin] - 10https://gerrit.wikimedia.org/r/123219 (owner: 10Nikerabbit)
[13:22:10] <grrrit-wm>	 (03CR) 10Nikerabbit: [C: 032 V: 032] Migrate to JSON i18n [extensions/SiteMetrics] - 10https://gerrit.wikimedia.org/r/123084 (owner: 10Siebrand)
[13:23:06] <grrrit-wm>	 (03CR) 10Nikerabbit: [C: 032 V: 032] Migrate to JSON i18n [extensions/SimpleSurvey] - 10https://gerrit.wikimedia.org/r/123083 (owner: 10Siebrand)
[13:23:38] <grrrit-wm>	 (03CR) 10Nikerabbit: [C: 032 V: 032] Migrate to JSON i18n [extensions/SimpleSecurity] - 10https://gerrit.wikimedia.org/r/123082 (owner: 10Siebrand)
[13:24:34] <grrrit-wm>	 (03CR) 10Nikerabbit: [C: 032 V: 032] Migrate to JSON i18n [extensions/SkinPerNamespace] - 10https://gerrit.wikimedia.org/r/123085 (owner: 10Siebrand)
[13:24:52] <grrrit-wm>	 (03CR) 10Nikerabbit: [C: 032 V: 032] Migrate to JSON i18n [extensions/SlimboxThumbs] - 10https://gerrit.wikimedia.org/r/123087 (owner: 10Siebrand)
[13:26:32] <grrrit-wm>	 (03PS1) 10MarkAHershberger: Put patterns to ignore in the yaml file and start using them in tarball creation. [tools/release] - 10https://gerrit.wikimedia.org/r/123220 
[13:29:10] <grrrit-wm>	 (03CR) 10Matthias Mullie: Don't escape the userlinks displayed in "This topic was suppressed by <links>" (031 comment) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/121385 (owner: 10Matthias Mullie)
[13:31:33] <grrrit-wm>	 (03CR) 10Nikerabbit: [C: 032] Migrate to JSON i18n [extensions/SideBarMenu] - 10https://gerrit.wikimedia.org/r/123077 (owner: 10Siebrand)
[13:31:38] <grrrit-wm>	 (03Merged) 10jenkins-bot: Migrate to JSON i18n [extensions/SideBarMenu] - 10https://gerrit.wikimedia.org/r/123077 (owner: 10Siebrand)
[13:31:45] <grrrit-wm>	 (03CR) 10Nikerabbit: [C: 032] Migrate to JSON i18n [extensions/SimpleAntiSpam] - 10https://gerrit.wikimedia.org/r/123080 (owner: 10Siebrand)
[13:31:48] <grrrit-wm>	 (03Merged) 10jenkins-bot: Migrate to JSON i18n [extensions/SimpleAntiSpam] - 10https://gerrit.wikimedia.org/r/123080 (owner: 10Siebrand)
[13:32:01] <grrrit-wm>	 (03CR) 10Nikerabbit: [C: 032] Migrate to JSON i18n [extensions/SkinPerPage] - 10https://gerrit.wikimedia.org/r/123086 (owner: 10Siebrand)
[13:32:02] <grrrit-wm>	 (03Merged) 10jenkins-bot: Migrate to JSON i18n [extensions/SkinPerPage] - 10https://gerrit.wikimedia.org/r/123086 (owner: 10Siebrand)
[13:34:12] <grrrit-wm>	 (03CR) 10Nikerabbit: [C: 032] Migrate to JSON i18n [extensions/MwEmbedSupport] - 10https://gerrit.wikimedia.org/r/121976 (owner: 10Siebrand)
[13:34:17] <grrrit-wm>	 (03Merged) 10jenkins-bot: Migrate to JSON i18n [extensions/MwEmbedSupport] - 10https://gerrit.wikimedia.org/r/121976 (owner: 10Siebrand)
[13:34:25] <grrrit-wm>	 (03CR) 10Nikerabbit: [C: 032] Migrate to JSON i18n [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/121981 (owner: 10Siebrand)
[13:34:36] <grrrit-wm>	 (03Merged) 10jenkins-bot: Migrate to JSON i18n [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/121981 (owner: 10Siebrand)
[13:42:01] <grrrit-wm>	 (03CR) 10Mglaser: [C: 032 V: 032] "Looks good to me!" [tools/release] - 10https://gerrit.wikimedia.org/r/123220 (owner: 10MarkAHershberger)
[13:46:31] <grrrit-wm>	 (03CR) 10MarkAHershberger: [C: 032] Updated release notes and version number for MediaWiki 1.19.15 [core] (REL1_19) - 10https://gerrit.wikimedia.org/r/123218 (owner: 10Mglaser)
[13:48:40] <grrrit-wm>	 (03Merged) 10jenkins-bot: Updated release notes and version number for MediaWiki 1.19.15 [core] (REL1_19) - 10https://gerrit.wikimedia.org/r/123218 (owner: 10Mglaser)
[13:55:20] <grrrit-wm>	 (03PS1) 10Nik: Added namespace to Publisher library. [extensions/PubSubHubbub] - 10https://gerrit.wikimedia.org/r/123224 
[13:59:21] <grrrit-wm>	 (03Abandoned) 10MarkAHershberger: add tarignore [tools/release] - 10https://gerrit.wikimedia.org/r/118072 (owner: 10MarkAHershberger)
[14:03:29] <grrrit-wm>	 (03PS2) 10Nik: Added namespace to Publisher library. [extensions/PubSubHubbub] - 10https://gerrit.wikimedia.org/r/123224 
[14:04:21] <grrrit-wm>	 (03CR) 10Nik: [C: 032 V: 032] Added namespace to Publisher library. [extensions/PubSubHubbub] - 10https://gerrit.wikimedia.org/r/123224 (owner: 10Nik)
[14:07:52] <grrrit-wm>	 (03PS1) 10Nik: Added error handling to publishing changes. [extensions/PubSubHubbub] - 10https://gerrit.wikimedia.org/r/123227 
[14:09:39] <grrrit-wm>	 (03PS1) 10Hashar: Properly apply label to beta-update-databases-eqiad [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/123228 
[14:09:52] <grrrit-wm>	 (03CR) 10Hashar: [C: 032] Properly apply label to beta-update-databases-eqiad [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/123228 (owner: 10Hashar)
[14:10:51] <grrrit-wm>	 (03CR) 10Nik: [C: 032 V: 031] Added error handling to publishing changes. [extensions/PubSubHubbub] - 10https://gerrit.wikimedia.org/r/123227 (owner: 10Nik)
[14:11:02] <grrrit-wm>	 (03Merged) 10jenkins-bot: Properly apply label to beta-update-databases-eqiad [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/123228 (owner: 10Hashar)
[14:11:37] <grrrit-wm>	 (03PS1) 10Hashar: Delete beta jobs running on pmtpa [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/123230 
[14:12:35] <grrrit-wm>	 (03CR) 10Siebrand: [C: 031] "i18n/L10n reviewed." [extensions/Flow] - 10https://gerrit.wikimedia.org/r/123217 (owner: 10Matthias Mullie)
[14:13:55] <grrrit-wm>	 (03PS3) 10Nik: Create Wikibase URL if it's a Wikibase item. [extensions/PubSubHubbub] - 10https://gerrit.wikimedia.org/r/112656 
[14:13:57] <grrrit-wm>	 (03CR) 10Siebrand: "i18n/L10n reviewed. No score yet. See inline question." (031 comment) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/123216 (owner: 10Matthias Mullie)
[14:15:31] <grrrit-wm>	 (03CR) 10Hashar: [C: 032] "jobs deleted manually" [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/123230 (owner: 10Hashar)
[14:16:06] <grrrit-wm>	 (03Merged) 10jenkins-bot: Delete beta jobs running on pmtpa [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/123230 (owner: 10Hashar)
[14:17:46] <grrrit-wm>	 (03PS4) 10Nik: Create Wikibase URL if it's a Wikibase item. [extensions/PubSubHubbub] - 10https://gerrit.wikimedia.org/r/112656 
[14:18:17] <grrrit-wm>	 (03CR) 10Nik: [C: 032 V: 032] Create Wikibase URL if it's a Wikibase item. [extensions/PubSubHubbub] - 10https://gerrit.wikimedia.org/r/112656 (owner: 10Nik)
[14:22:19] <grrrit-wm>	 (03PS1) 10MarkAHershberger: Update tests and fix flake8 issues [tools/release] - 10https://gerrit.wikimedia.org/r/123231 
[14:29:29] <grrrit-wm>	 (03CR) 10Siebrand: [C: 04-1] "L10n reviewed." (031 comment) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/119640 (owner: 10Bsitu)
[14:31:56] <grrrit-wm>	 (03CR) 10Siebrand: [C: 031] "i18n/L10n reviewed." [extensions/Flow] - 10https://gerrit.wikimedia.org/r/118399 (owner: 10Bsitu)
[14:33:36] <grrrit-wm>	 (03CR) 10Siebrand: [C: 04-1] "This should be squahed in the parent. Key additions should have message documentation." [extensions/MediaWikiChat] - 10https://gerrit.wikimedia.org/r/122878 (owner: 10GeorgeBarnick)
[14:34:12] <grrrit-wm>	 (03CR) 10Siebrand: [C: 04-1] "You should squash the message documentation of the dependent patch set into this one." [extensions/MediaWikiChat] - 10https://gerrit.wikimedia.org/r/122876 (owner: 10GeorgeBarnick)
[14:45:45] <grrrit-wm>	 (03PS1) 10Hashar: Integrates puppet-lint for operations/puppet [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/123236 
[14:45:48] <thedj>	 hoo: exposing the json blobs trough cors would be a wikidata bug, they have to use the same strategy as centralauth/login api and the API.
[14:46:06] <grrrit-wm>	 (03CR) 10Hashar: [C: 032] Integrates puppet-lint for operations/puppet [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/123236 (owner: 10Hashar)
[14:46:34] <hoo>	 thedj: huh? Context?
[14:46:52] <hoo>	 ah, I see
[14:47:04] <grrrit-wm>	 (03PS1) 10Hashar: Triggers operations-puppet-puppetlint [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/123238 
[14:47:08] <grrrit-wm>	 (03Merged) 10jenkins-bot: Integrates puppet-lint for operations/puppet [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/123236 (owner: 10Hashar)
[14:47:08] <thedj>	 i mixed up a comment from you and magnus
[14:47:14] <grrrit-wm>	 (03CR) 10Hashar: [C: 032] Triggers operations-puppet-puppetlint [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/123238 (owner: 10Hashar)
[14:47:20] <hoo>	 will reply on the bug
[14:47:23] <grrrit-wm>	 (03Merged) 10jenkins-bot: Triggers operations-puppet-puppetlint [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/123238 (owner: 10Hashar)
[14:48:20] <grrrit-wm>	 (03PS3) 10Nik: insert test for class PubsubHubbub [extensions/PubSubHubbub] - 10https://gerrit.wikimedia.org/r/122844 (owner: 10Alexander.lehmann)
[14:48:25] <grrrit-wm>	 (03PS1) 10Hashar: operations-puppet-puppetlint is not voting [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/123239 
[14:48:29] <grrrit-wm>	 (03CR) 10Anomie: [C: 04-1] "Ah, ok." (038 comments) [core] - 10https://gerrit.wikimedia.org/r/123118 (owner: 10MaxSem)
[14:48:42] <grrrit-wm>	 (03CR) 10Hashar: [C: 032] operations-puppet-puppetlint is not voting [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/123239 (owner: 10Hashar)
[14:48:46] <grrrit-wm>	 (03Merged) 10jenkins-bot: operations-puppet-puppetlint is not voting [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/123239 (owner: 10Hashar)
[14:49:30] <grrrit-wm>	 (03PS4) 10Nik: Added tests for PubSubHubbub class. [extensions/PubSubHubbub] - 10https://gerrit.wikimedia.org/r/122844 (owner: 10Alexander.lehmann)
[14:53:07] <grrrit-wm>	 (03PS5) 10Nik: Added tests for PubSubHubbub class. [extensions/PubSubHubbub] - 10https://gerrit.wikimedia.org/r/122844 (owner: 10Alexander.lehmann)
[14:53:54] <grrrit-wm>	 (03CR) 10Anomie: [C: 04-1] "ipb_timestamp is NOT NULL and I see that list=blocks doesn't check, so I wouldn't think it necessary here either." [core] - 10https://gerrit.wikimedia.org/r/122566 (owner: 10TheDJ)
[14:55:34] <grrrit-wm>	 (03PS6) 10Nik: Added tests for PubSubHubbub class. [extensions/PubSubHubbub] - 10https://gerrit.wikimedia.org/r/122844 (owner: 10Alexander.lehmann)
[14:56:37] <grrrit-wm>	 (03CR) 10Nik: [C: 032] Added tests for PubSubHubbub class. [extensions/PubSubHubbub] - 10https://gerrit.wikimedia.org/r/122844 (owner: 10Alexander.lehmann)
[14:58:38] <grrrit-wm>	 (03PS1) 10Aude: Rename $t to $title in SpecialSearch [core] - 10https://gerrit.wikimedia.org/r/123241 
[15:03:55] <grrrit-wm>	 (03PS7) 10Nik: Added tests for PubSubHubbub class. [extensions/PubSubHubbub] - 10https://gerrit.wikimedia.org/r/122844 (owner: 10Alexander.lehmann)
[15:04:15] <grrrit-wm>	 (03CR) 10Nik: [C: 032 V: 032] Added tests for PubSubHubbub class. [extensions/PubSubHubbub] - 10https://gerrit.wikimedia.org/r/122844 (owner: 10Alexander.lehmann)
[15:07:43] <grrrit-wm>	 (03PS2) 10Reedy: Rename $t to $title in SpecialSearch [core] - 10https://gerrit.wikimedia.org/r/123241 (owner: 10Aude)
[15:07:47] <grrrit-wm>	 (03CR) 10Reedy: [C: 032] Rename $t to $title in SpecialSearch [core] - 10https://gerrit.wikimedia.org/r/123241 (owner: 10Aude)
[15:11:36] <jatin>	 Hi, can someone please review this patch <https://gerrit.wikimedia.org/r/#/c/120502/>?
[15:11:54] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] Rename $t to $title in SpecialSearch [core] - 10https://gerrit.wikimedia.org/r/123241 (owner: 10Aude)
[15:11:56] <grrrit-wm>	 (03Merged) 10jenkins-bot: Rename $t to $title in SpecialSearch [core] - 10https://gerrit.wikimedia.org/r/123241 (owner: 10Aude)
[15:13:59] <aude>	 why qunit time out?
[15:14:28] <grrrit-wm>	 (03CR) 10Chad: "Ooh, I like. Will have to review in depth." [core] - 10https://gerrit.wikimedia.org/r/123118 (owner: 10MaxSem)
[15:14:36] <grrrit-wm>	 (03PS3) 10MaxSem: New API module, list=prefixsearch [core] - 10https://gerrit.wikimedia.org/r/123118 
[15:14:53] <grrrit-wm>	 (03CR) 10MaxSem: New API module, list=prefixsearch (037 comments) [core] - 10https://gerrit.wikimedia.org/r/123118 (owner: 10MaxSem)
[15:24:10] <aude>	 "Elasticsearch failed in an unexpected way.  This is always a bug in CirrusSearch."
[15:24:13] <aude>	 lovely 
[15:24:24] <aude>	 always always
[15:25:01] <grrrit-wm>	 (03PS1) 10Chad: Set mw_cirrus_versions to have no replicas [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/123243 
[15:26:45] <Nikerabbit>	 ploppa
[15:27:27] <grrrit-wm>	 (03PS1) 10Hashar: make-release: fix tests [tools/release] - 10https://gerrit.wikimedia.org/r/123245 
[15:27:56] <aude>	 what a more elaborate elastic mapping we have now
[15:29:42] <^d>	 aude: Full stacktrace? :)
[15:29:49] <aude>	 it's good now
[15:29:57] <^d>	 k
[15:29:58] <aude>	 upgraded to 1.0.1 and deleted / rebuild indexres
[15:30:02] <aude>	 indices*
[15:30:14] <^d>	 bleh, 1.x upgrade
[15:30:35] <aude>	 now there are more things in the index that i had missing before
[15:30:52] <^d>	 Our mapping is cooooool :)
[15:30:56] <^d>	 Specially if you use GeoData too
[15:31:00] <grrrit-wm>	 (03PS1) 10Dan-nl: add 2 Mediawiki templates to GWToolset [extensions/GWToolset] - 10https://gerrit.wikimedia.org/r/123248 
[15:31:05] <grrrit-wm>	 (03CR) 10Manybubbles: [C: 032] Set mw_cirrus_versions to have no replicas [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/123243 (owner: 10Chad)
[15:31:20] <grrrit-wm>	 (03Merged) 10jenkins-bot: Set mw_cirrus_versions to have no replicas [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/123243 (owner: 10Chad)
[15:32:20] <^d>	 manybubbles: So we can keep our # of replicas at 1 here (or raise to 2 if we wanna be paranoid)
[15:32:20] <grrrit-wm>	 (03PS1) 10Aude: Fix variable naming in SpecialSearch, $t => $title [core] - 10https://gerrit.wikimedia.org/r/123249 
[15:32:23] <^d>	 :)
[15:32:24] <aude>	 sorry, missed a spot ^
[15:32:58] <grrrit-wm>	 (03CR) 10Chad: [C: 032] Fix variable naming in SpecialSearch, $t => $title [core] - 10https://gerrit.wikimedia.org/r/123249 (owner: 10Aude)
[15:33:02] <aude>	 thanks
[15:33:06] <^d>	 How the hell did I miss that for so long
[15:33:08] <^d>	 :p
[15:33:19] <aude>	 no, i just renamed all of $t => $title
[15:33:22] <aude>	 missed that one
[15:33:50] <^d>	 Ohhh, I missed the other commit.
[15:33:56] <aude>	 oh
[15:34:31] <aude>	 annoying to have to go search for what $t is, though not surprised it's a Title
[15:35:08] <^d>	 $tle?
[15:35:42] <manybubbles>	 I hate $t
[15:35:53] <grrrit-wm>	 (03Merged) 10jenkins-bot: Fix variable naming in SpecialSearch, $t => $title [core] - 10https://gerrit.wikimedia.org/r/123249 (owner: 10Aude)
[15:35:59] <aude>	 looks like there is more fun stuff like $p
[15:36:51] <^d>	 Hehe
[15:36:55] <^d>	 Tons in Cirrus
[15:36:58] <^d>	 I'm guilty
[15:37:50] <grrrit-wm>	 (03PS1) 10Aude: Rename $p to $parts in Special:Search [core] - 10https://gerrit.wikimedia.org/r/123250 
[15:41:19] <grrrit-wm>	 (03PS1) 10Aude: Remove unused $profile variables in SpecialSearch [core] - 10https://gerrit.wikimedia.org/r/123251 
[15:42:16] <^d>	 aude: Those $profiler don't do what you think
[15:42:25] <aude>	 huh?
[15:42:36] <^d>	 When the object goes out of scope it calls the profile out
[15:42:45] <aude>	 hmmm
[15:42:48] <^d>	 It's a cool way to do wfProfileIn/Out without worrying about matching
[15:42:56] <^d>	 (It confuses the heck out of static analysis tools though)
[15:43:20] <aude>	 let's see
[15:44:14] <aude>	 i would probably just match them then
[15:44:28] <grrrit-wm>	 (03CR) 10Chad: [C: 032] Rename $p to $parts in Special:Search [core] - 10https://gerrit.wikimedia.org/r/123250 (owner: 10Aude)
[15:47:22] <grrrit-wm>	 (03Merged) 10jenkins-bot: Rename $p to $parts in Special:Search [core] - 10https://gerrit.wikimedia.org/r/123250 (owner: 10Aude)
[15:47:57] <grrrit-wm>	 (03Abandoned) 10Aude: Remove unused $profile variables in SpecialSearch [core] - 10https://gerrit.wikimedia.org/r/123251 (owner: 10Aude)
[15:48:05] <aude>	 alright, don't want to bother with that now
[15:50:10] <grrrit-wm>	 (03PS5) 10Jforrester: Add script to send notifications for new features [extensions/BetaFeatures] - 10https://gerrit.wikimedia.org/r/84625 (owner: 10MarkTraceur)
[15:50:23] <grrrit-wm>	 (03CR) 10Jforrester: "PS5 is a rebase." [extensions/BetaFeatures] - 10https://gerrit.wikimedia.org/r/84625 (owner: 10MarkTraceur)
[15:53:38] <aude>	 so, what was i doing when before trying to search somethign :)
[15:53:51] <grrrit-wm>	 (03PS6) 10Jforrester: Add script to send notifications for new features [extensions/BetaFeatures] - 10https://gerrit.wikimedia.org/r/84625 (owner: 10MarkTraceur)
[15:56:35] <grrrit-wm>	 (03PS1) 10Siebrand: Migrate to JSON i18n [extensions/PerPageLicense] - 10https://gerrit.wikimedia.org/r/123252 
[15:56:41] <grrrit-wm>	 (03PS1) 10Siebrand: Migrate to JSON i18n [extensions/Persona] - 10https://gerrit.wikimedia.org/r/123253 
[15:56:45] <grrrit-wm>	 (03PS1) 10Siebrand: Migrate to JSON i18n [extensions/Phalanx] - 10https://gerrit.wikimedia.org/r/123254 
[15:56:47] <grrrit-wm>	 (03PS1) 10Siebrand: Migrate to JSON i18n [extensions/PGFTikZ] - 10https://gerrit.wikimedia.org/r/123255 
[15:56:49] <grrrit-wm>	 (03PS1) 10Siebrand: Migrate to JSON i18n [extensions/PHPExcel] - 10https://gerrit.wikimedia.org/r/123256 
[15:56:51] <grrrit-wm>	 (03PS1) 10Siebrand: Migrate to JSON i18n [extensions/PhpMaps] - 10https://gerrit.wikimedia.org/r/123257 
[15:56:53] <grrrit-wm>	 (03PS1) 10Siebrand: Migrate to JSON i18n [extensions/PhpTagsMaps] - 10https://gerrit.wikimedia.org/r/123258 
[15:56:57] <grrrit-wm>	 (03PS1) 10Siebrand: Migrate to JSON i18n [extensions/PhpTagsFunctions] - 10https://gerrit.wikimedia.org/r/123259 
[15:56:59] <grrrit-wm>	 (03PS1) 10Siebrand: Migrate to JSON i18n [extensions/PictureGame] - 10https://gerrit.wikimedia.org/r/123260 
[15:57:01] <grrrit-wm>	 (03PS1) 10Siebrand: Migrate to JSON i18n [extensions/PollNY] - 10https://gerrit.wikimedia.org/r/123261 
[15:57:03] <grrrit-wm>	 (03PS1) 10Siebrand: Migrate to JSON i18n [extensions/PostEdit] - 10https://gerrit.wikimedia.org/r/123262 
[15:57:05] <grrrit-wm>	 (03PS1) 10Siebrand: Migrate to JSON i18n [extensions/Polyglot] - 10https://gerrit.wikimedia.org/r/123263 
[15:57:07] <grrrit-wm>	 (03PS1) 10Siebrand: Migrate to JSON i18n [extensions/PrefStats] - 10https://gerrit.wikimedia.org/r/123264 
[15:57:10] <grrrit-wm>	 (03PS1) 10Siebrand: Migrate to JSON i18n [extensions/PrefSwitch] - 10https://gerrit.wikimedia.org/r/123265 
[15:57:14] <grrrit-wm>	 (03PS1) 10Siebrand: Migrate to JSON i18n [extensions/PrivateDomains] - 10https://gerrit.wikimedia.org/r/123266 
[15:57:16] <grrrit-wm>	 (03PS1) 10Siebrand: Migrate to JSON i18n [extensions/Premoderation] - 10https://gerrit.wikimedia.org/r/123267 
[15:57:18] <grrrit-wm>	 (03PS1) 10Siebrand: Migrate to JSON i18n [extensions/PronunciationRecording] - 10https://gerrit.wikimedia.org/r/123268 
[15:57:21] <grrrit-wm>	 (03PS1) 10Siebrand: Migrate to JSON i18n [extensions/ProtectSite] - 10https://gerrit.wikimedia.org/r/123269 
[15:57:25] <grrrit-wm>	 (03PS1) 10Siebrand: Migrate to JSON i18n [extensions/Push] - 10https://gerrit.wikimedia.org/r/123270 
[15:57:26] <grrrit-wm>	 (03PS1) 10Siebrand: Migrate to JSON i18n [extensions/PubSubHubbub] - 10https://gerrit.wikimedia.org/r/123271 
[15:57:28] <grrrit-wm>	 (03PS1) 10Siebrand: Migrate to JSON i18n [extensions/PushToWatch] - 10https://gerrit.wikimedia.org/r/123272 
[15:57:30] <grrrit-wm>	 (03PS1) 10Siebrand: Migrate to JSON i18n [extensions/Quantcast] - 10https://gerrit.wikimedia.org/r/123273 
[15:57:33] <grrrit-wm>	 (03PS1) 10Siebrand: Migrate to JSON i18n [extensions/QuizGame] - 10https://gerrit.wikimedia.org/r/123274 
[15:57:35] <grrrit-wm>	 (03PS1) 10Siebrand: Migrate to JSON i18n [extensions/QuickResponse] - 10https://gerrit.wikimedia.org/r/123275 
[15:57:37] <grrrit-wm>	 (03PS1) 10Siebrand: Migrate to JSON i18n [extensions/RandomImage] - 10https://gerrit.wikimedia.org/r/123276 
[15:57:40] <grrrit-wm>	 (03PS1) 10Siebrand: Migrate to JSON i18n [extensions/RandomInCategory] - 10https://gerrit.wikimedia.org/r/123277 
[15:57:42] <grrrit-wm>	 (03PS1) 10Siebrand: Migrate to JSON i18n [extensions/Ratings] - 10https://gerrit.wikimedia.org/r/123278 
[15:57:44] <grrrit-wm>	 (03PS1) 10Siebrand: Migrate to JSON i18n [extensions/RandomUsersWithAvatars] - 10https://gerrit.wikimedia.org/r/123279 
[15:57:49] <grrrit-wm>	 (03PS1) 10Siebrand: Migrate to JSON i18n [extensions/ReassignEdits] - 10https://gerrit.wikimedia.org/r/123281 
[15:57:52] <grrrit-wm>	 (03PS1) 10Siebrand: Migrate to JSON i18n [extensions/RegexFun] - 10https://gerrit.wikimedia.org/r/123282 
[15:57:54] <grrrit-wm>	 (03PS1) 10Siebrand: Migrate to JSON i18n [extensions/RefreshSpecial] - 10https://gerrit.wikimedia.org/r/123283 
[15:57:56] <grrrit-wm>	 (03PS1) 10Siebrand: Migrate to JSON i18n [extensions/RegexFunctions] - 10https://gerrit.wikimedia.org/r/123284 
[15:57:58] <grrrit-wm>	 (03PS1) 10Siebrand: Migrate to JSON i18n [extensions/RelationLinks] - 10https://gerrit.wikimedia.org/r/123285 
[15:58:02] <grrrit-wm>	 (03PS1) 10Siebrand: Migrate to JSON i18n [extensions/RevisionCommentSupplement] - 10https://gerrit.wikimedia.org/r/123286 
[15:58:04] <grrrit-wm>	 (03PS1) 10Siebrand: Migrate to JSON i18n [extensions/ReplaceSet] - 10https://gerrit.wikimedia.org/r/123287 
[15:58:06] <grrrit-wm>	 (03PS1) 10Siebrand: Migrate to JSON i18n [extensions/RightFunctions] - 10https://gerrit.wikimedia.org/r/123288 
[15:58:08] <grrrit-wm>	 (03PS1) 10Siebrand: Migrate to JSON i18n [extensions/RT] - 10https://gerrit.wikimedia.org/r/123289 
[15:58:13] <grrrit-wm>	 (03PS1) 10Siebrand: Migrate to JSON i18n [extensions/SmoothGallery] - 10https://gerrit.wikimedia.org/r/123290 
[15:59:22] <grrrit-wm>	 (03PS1) 10Chad: Remove short variable names [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/123291 
[15:59:39] <^d>	 aude: ^^^ :)
[16:00:13] <DanielK_WMDE_>	 uh, gerrit ios crawling again
[16:00:17] <aude>	 :)
[16:00:24] <DanielK_WMDE_>	 someone give it some coffee, please
[16:00:31] <^d>	 I give up.
[16:00:38] <DanielK_WMDE_>	 (or a friendly kick)
[16:00:45] <^d>	 Kick is pointless.
[16:01:12] <aude>	 did sie-brand kill jenkins?
[16:01:16] <aude>	 errr gerrit
[16:04:32] <grrrit-wm>	 (03CR) 10Jforrester: Add script to send notifications for new features (032 comments) [extensions/BetaFeatures] - 10https://gerrit.wikimedia.org/r/84625 (owner: 10MarkTraceur)
[16:06:31] <DanielK_WMDE_>	 ^d: what i don't understand is... what makes it so horribly slow? what the hell is it doing? is it a problem with the storage backend?
[16:06:36] <DanielK_WMDE_>	 what is it using asa backend?
[16:06:46] <^d>	 Some idiot's crawling it.
[16:06:52] <^d>	 It's using up all the apache connections.
[16:06:57] <aude>	 :(
[16:06:58] <^d>	 Which is why it's fucked from the UI.
[16:07:01] <^d>	 But fine from the command line
[16:07:11] <^d>	 See -operations
[16:07:15] <^d>	 Don't want to repeat myself.
[16:12:17] <grrrit-wm>	 (03CR) 10Isarra: "While 'skinbase' is a good name in that these are used for the bases of skins, it can also be read to imply that it is the base skin. 'Ski" [core] - 10https://gerrit.wikimedia.org/r/114984 (owner: 10Bartosz Dziewoński)
[16:15:28] <grrrit-wm>	 (03CR) 10Parent5446: [C: 032] Extension which allows sign in with Mozilla Persona. [extensions/Persona] - 10https://gerrit.wikimedia.org/r/112309 (owner: 10Donyu)
[16:15:34] <grrrit-wm>	 (03Merged) 10jenkins-bot: Extension which allows sign in with Mozilla Persona. [extensions/Persona] - 10https://gerrit.wikimedia.org/r/112309 (owner: 10Donyu)
[16:16:35] <grrrit-wm>	 (03CR) 10Parent5446: [C: 032] Migrate to JSON i18n [extensions/Persona] - 10https://gerrit.wikimedia.org/r/123253 (owner: 10Siebrand)
[16:16:38] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] Migrate to JSON i18n [extensions/Persona] - 10https://gerrit.wikimedia.org/r/123253 (owner: 10Siebrand)
[16:20:13] <grrrit-wm>	 (03CR) 10Parent5446: [C: 032] Disable Persona button in browsers that do not have Javascript [extensions/Persona] - 10https://gerrit.wikimedia.org/r/120502 (owner: 10Jatin)
[16:20:18] <grrrit-wm>	 (03Merged) 10jenkins-bot: Disable Persona button in browsers that do not have Javascript [extensions/Persona] - 10https://gerrit.wikimedia.org/r/120502 (owner: 10Jatin)
[16:27:00] <grrrit-wm>	 (03PS2) 10Siebrand: Migrate to JSON i18n [extensions/Persona] - 10https://gerrit.wikimedia.org/r/123253 
[16:27:29] <grrrit-wm>	 (03PS3) 10Siebrand: Migrate to JSON i18n [extensions/Persona] - 10https://gerrit.wikimedia.org/r/123253 
[16:33:49] <grrrit-wm>	 (03PS2) 10Siebrand: Migrate to JSON i18n [extensions/SmoothGallery] - 10https://gerrit.wikimedia.org/r/123290 
[16:46:09] <grrrit-wm>	 (03CR) 10Raimond Spekking: [C: 032 V: 032] Migrate to JSON i18n [extensions/Push] - 10https://gerrit.wikimedia.org/r/123270 (owner: 10Siebrand)
[16:46:29] <grrrit-wm>	 (03CR) 10Raimond Spekking: [C: 032 V: 032] Migrate to JSON i18n [extensions/ProtectSite] - 10https://gerrit.wikimedia.org/r/123269 (owner: 10Siebrand)
[16:46:52] <grrrit-wm>	 (03CR) 10Raimond Spekking: [C: 032 V: 032] Migrate to JSON i18n [extensions/PronunciationRecording] - 10https://gerrit.wikimedia.org/r/123268 (owner: 10Siebrand)
[16:47:44] <grrrit-wm>	 (03CR) 10Raimond Spekking: [C: 032 V: 032] Migrate to JSON i18n [extensions/Premoderation] - 10https://gerrit.wikimedia.org/r/123267 (owner: 10Siebrand)
[16:48:11] <grrrit-wm>	 (03CR) 10Raimond Spekking: [C: 032 V: 032] Migrate to JSON i18n [extensions/PrivateDomains] - 10https://gerrit.wikimedia.org/r/123266 (owner: 10Siebrand)
[16:48:32] <grrrit-wm>	 (03CR) 10Raimond Spekking: [C: 032 V: 032] Migrate to JSON i18n [extensions/PrefSwitch] - 10https://gerrit.wikimedia.org/r/123265 (owner: 10Siebrand)
[16:48:50] <grrrit-wm>	 (03CR) 10Raimond Spekking: [C: 032 V: 032] Migrate to JSON i18n [extensions/PrefStats] - 10https://gerrit.wikimedia.org/r/123264 (owner: 10Siebrand)
[16:49:04] <grrrit-wm>	 (03CR) 10Raimond Spekking: [C: 032 V: 032] Migrate to JSON i18n [extensions/Polyglot] - 10https://gerrit.wikimedia.org/r/123263 (owner: 10Siebrand)
[16:49:48] <grrrit-wm>	 (03CR) 10Raimond Spekking: [C: 032 V: 032] Migrate to JSON i18n [extensions/PollNY] - 10https://gerrit.wikimedia.org/r/123261 (owner: 10Siebrand)
[16:50:20] <grrrit-wm>	 (03CR) 10Raimond Spekking: [C: 032 V: 032] Migrate to JSON i18n [extensions/PictureGame] - 10https://gerrit.wikimedia.org/r/123260 (owner: 10Siebrand)
[16:50:37] <grrrit-wm>	 (03CR) 10Raimond Spekking: [C: 032 V: 032] Migrate to JSON i18n [extensions/PhpTagsMaps] - 10https://gerrit.wikimedia.org/r/123258 (owner: 10Siebrand)
[16:51:32] <grrrit-wm>	 (03CR) 10Raimond Spekking: [C: 032 V: 032] Migrate to JSON i18n [extensions/PGFTikZ] - 10https://gerrit.wikimedia.org/r/123255 (owner: 10Siebrand)
[16:53:02] <grrrit-wm>	 (03CR) 10Raimond Spekking: [C: 032 V: 032] Migrate to JSON i18n [extensions/Phalanx] - 10https://gerrit.wikimedia.org/r/123254 (owner: 10Siebrand)
[16:54:12] <grrrit-wm>	 (03CR) 10Raimond Spekking: [C: 032 V: 032] Migrate to JSON i18n [extensions/PerPageLicense] - 10https://gerrit.wikimedia.org/r/123252 (owner: 10Siebrand)
[16:54:34] <grrrit-wm>	 (03CR) 10EBernhardson: [C: 032] "schema hhange has been applied in production" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/116861 (owner: 10Bsitu)
[16:54:43] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] [Schema Change]Add column rev_type_id to table flow_revision [extensions/Flow] - 10https://gerrit.wikimedia.org/r/116861 (owner: 10Bsitu)
[16:55:23] <grrrit-wm>	 (03CR) 10Raimond Spekking: [C: 032 V: 032] Migrate to JSON i18n [extensions/SmoothGallery] - 10https://gerrit.wikimedia.org/r/123290 (owner: 10Siebrand)
[16:56:25] <grrrit-wm>	 (03CR) 10Raimond Spekking: [C: 032 V: 032] Migrate to JSON i18n [extensions/Persona] - 10https://gerrit.wikimedia.org/r/123253 (owner: 10Siebrand)
[16:57:22] <grrrit-wm>	 (03CR) 10Raimond Spekking: [C: 032 V: 032] Migrate to JSON i18n [extensions/RegexFunctions] - 10https://gerrit.wikimedia.org/r/123284 (owner: 10Siebrand)
[16:57:45] <grrrit-wm>	 (03CR) 10Raimond Spekking: [C: 032 V: 032] Migrate to JSON i18n [extensions/RelationLinks] - 10https://gerrit.wikimedia.org/r/123285 (owner: 10Siebrand)
[16:58:04] <grrrit-wm>	 (03CR) 10Raimond Spekking: [C: 032 V: 032] Migrate to JSON i18n [extensions/PHPExcel] - 10https://gerrit.wikimedia.org/r/123256 (owner: 10Siebrand)
[16:58:19] <grrrit-wm>	 (03CR) 10EBernhardson: Update post/header revision storage search key (031 comment) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/117099 (owner: 10Bsitu)
[16:58:22] <grrrit-wm>	 (03CR) 10Raimond Spekking: [C: 032 V: 032] Migrate to JSON i18n [extensions/PostEdit] - 10https://gerrit.wikimedia.org/r/123262 (owner: 10Siebrand)
[16:58:34] <grrrit-wm>	 (03CR) 10EBernhardson: [C: 032] Update column data: flow_revision.rev_type_id [extensions/Flow] - 10https://gerrit.wikimedia.org/r/116874 (owner: 10Bsitu)
[16:58:42] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] [Schema Change]Add column rev_type_id to table flow_revision [extensions/Flow] - 10https://gerrit.wikimedia.org/r/116861 (owner: 10Bsitu)
[16:58:45] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] Update column data: flow_revision.rev_type_id [extensions/Flow] - 10https://gerrit.wikimedia.org/r/116874 (owner: 10Bsitu)
[16:58:48] <grrrit-wm>	 (03CR) 10Raimond Spekking: [C: 032 V: 032] Migrate to JSON i18n [extensions/RevisionCommentSupplement] - 10https://gerrit.wikimedia.org/r/123286 (owner: 10Siebrand)
[16:59:14] <grrrit-wm>	 (03CR) 10Raimond Spekking: [C: 032 V: 032] Migrate to JSON i18n [extensions/RightFunctions] - 10https://gerrit.wikimedia.org/r/123288 (owner: 10Siebrand)
[16:59:36] <grrrit-wm>	 (03CR) 10Raimond Spekking: [C: 032 V: 032] Migrate to JSON i18n [extensions/RT] - 10https://gerrit.wikimedia.org/r/123289 (owner: 10Siebrand)
[16:59:48] <grrrit-wm>	 (03PS1) 10Ottomata: Using 'www-data' as wikimetrics group when running in apache mode [vagrant] - 10https://gerrit.wikimedia.org/r/123303 
[16:59:53] <grrrit-wm>	 (03CR) 10Raimond Spekking: [C: 032 V: 032] Migrate to JSON i18n [extensions/PhpTagsFunctions] - 10https://gerrit.wikimedia.org/r/123259 (owner: 10Siebrand)
[17:00:10] <grrrit-wm>	 (03CR) 10Raimond Spekking: [C: 032 V: 032] Migrate to JSON i18n [extensions/ReplaceSet] - 10https://gerrit.wikimedia.org/r/123287 (owner: 10Siebrand)
[17:00:21] <grrrit-wm>	 (03CR) 10Ottomata: [C: 04-1] "Don't merge until https://gerrit.wikimedia.org/r/#/c/123244 is working and has been updated in modules/wikimetrics submodule." [vagrant] - 10https://gerrit.wikimedia.org/r/123303 (owner: 10Ottomata)
[17:01:23] <grrrit-wm>	 (03PS18) 10EBernhardson: [Schema Change]Add column rev_type_id to table flow_revision [extensions/Flow] - 10https://gerrit.wikimedia.org/r/116861 (owner: 10Bsitu)
[17:02:20] <grrrit-wm>	 (03CR) 10EBernhardson: [C: 032] "PS18: Manual rebase" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/116861 (owner: 10Bsitu)
[17:02:23] <grrrit-wm>	 (03Merged) 10jenkins-bot: [Schema Change]Add column rev_type_id to table flow_revision [extensions/Flow] - 10https://gerrit.wikimedia.org/r/116861 (owner: 10Bsitu)
[17:02:26] <grrrit-wm>	 (03PS16) 10EBernhardson: Update column data: flow_revision.rev_type_id [extensions/Flow] - 10https://gerrit.wikimedia.org/r/116874 (owner: 10Bsitu)
[17:02:29] <grrrit-wm>	 (03CR) 10EBernhardson: [C: 032] Update column data: flow_revision.rev_type_id [extensions/Flow] - 10https://gerrit.wikimedia.org/r/116874 (owner: 10Bsitu)
[17:02:41] <grrrit-wm>	 (03Merged) 10jenkins-bot: Update column data: flow_revision.rev_type_id [extensions/Flow] - 10https://gerrit.wikimedia.org/r/116874 (owner: 10Bsitu)
[17:02:44] <grrrit-wm>	 (03PS1) 10Manybubbles: Add job for search highlighter [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/123304 
[17:03:23] <grrrit-wm>	 (03CR) 10Manybubbles: "I haven't tested this but it _should_ set up a job for the highlighter I wrote for Cirrus." [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/123304 (owner: 10Manybubbles)
[17:04:56] <grrrit-wm>	 (03PS1) 10Manybubbles: New package again [search/highlighter] - 10https://gerrit.wikimedia.org/r/123305 
[17:05:23] <grrrit-wm>	 (03CR) 10EBernhardson: [C: 032] "schema change applied" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/122865 (owner: 10EBernhardson)
[17:05:41] <grrrit-wm>	 (03Merged) 10jenkins-bot: Add workflow_type field [extensions/Flow] - 10https://gerrit.wikimedia.org/r/122865 (owner: 10EBernhardson)
[17:06:03] <grrrit-wm>	 (03CR) 10EBernhardson: [C: 032] mw.flow.api.read returns a jQuery.Promise, not a Deferred [extensions/Flow] - 10https://gerrit.wikimedia.org/r/123173 (owner: 10Legoktm)
[17:06:06] <grrrit-wm>	 (03CR) 10Manybubbles: [C: 032 V: 032] New package again [search/highlighter] - 10https://gerrit.wikimedia.org/r/123305 (owner: 10Manybubbles)
[17:06:19] <grrrit-wm>	 (03Merged) 10jenkins-bot: mw.flow.api.read returns a jQuery.Promise, not a Deferred [extensions/Flow] - 10https://gerrit.wikimedia.org/r/123173 (owner: 10Legoktm)
[17:07:26] <grrrit-wm>	 (03CR) 10EBernhardson: API: Remove 'flowaction' parameter from list=flow (031 comment) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/123174 (owner: 10Legoktm)
[17:10:08] <grrrit-wm>	 (03PS1) 10Siebrand: Migrate to JSON i18n [extensions/SocialLogin] - 10https://gerrit.wikimedia.org/r/123306 
[17:10:12] <grrrit-wm>	 (03PS1) 10Siebrand: Migrate to JSON i18n [extensions/SocialProfile] - 10https://gerrit.wikimedia.org/r/123307 
[17:10:21] <grrrit-wm>	 (03PS1) 10Siebrand: Migrate to JSON i18n [extensions/Spark] - 10https://gerrit.wikimedia.org/r/123308 
[17:10:25] <grrrit-wm>	 (03PS1) 10Siebrand: Migrate to JSON i18n [extensions/Special404] - 10https://gerrit.wikimedia.org/r/123309 
[17:10:32] <grrrit-wm>	 (03PS1) 10Siebrand: Migrate to JSON i18n [extensions/SpellingApi] - 10https://gerrit.wikimedia.org/r/123311 
[17:10:34] <grrrit-wm>	 (03PS1) 10Siebrand: Migrate to JSON i18n [extensions/SoundManager2Button] - 10https://gerrit.wikimedia.org/r/123312 
[17:10:37] <grrrit-wm>	 (03PS1) 10Siebrand: Migrate to JSON i18n [extensions/SphinxSearch] - 10https://gerrit.wikimedia.org/r/123313 
[17:10:39] <grrrit-wm>	 (03PS1) 10Siebrand: Migrate to JSON i18n [extensions/SportsTeams] - 10https://gerrit.wikimedia.org/r/123314 
[17:10:42] <grrrit-wm>	 (03PS1) 10Siebrand: Migrate to JSON i18n [extensions/Spreadsheet] - 10https://gerrit.wikimedia.org/r/123315 
[17:10:44] <grrrit-wm>	 (03PS1) 10Siebrand: Migrate to JSON i18n [extensions/SSLClientAuthentication] - 10https://gerrit.wikimedia.org/r/123316 
[17:10:46] <grrrit-wm>	 (03PS1) 10Siebrand: Migrate to JSON i18n [extensions/StalkerLog] - 10https://gerrit.wikimedia.org/r/123317 
[17:10:48] <grrrit-wm>	 (03PS1) 10Siebrand: Migrate to JSON i18n [extensions/StarterWiki] - 10https://gerrit.wikimedia.org/r/123318 
[17:10:52] <grrrit-wm>	 (03PS1) 10Siebrand: Migrate to JSON i18n [extensions/StickToThatLanguage] - 10https://gerrit.wikimedia.org/r/123319 
[17:10:54] <grrrit-wm>	 (03PS1) 10Siebrand: Migrate to JSON i18n [extensions/StopForumSpam] - 10https://gerrit.wikimedia.org/r/123320 
[17:10:56] <grrrit-wm>	 (03PS1) 10Siebrand: Migrate to JSON i18n [extensions/SubpageFun] - 10https://gerrit.wikimedia.org/r/123321 
[17:10:58] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] Migrate to JSON i18n [extensions/StopForumSpam] - 10https://gerrit.wikimedia.org/r/123320 (owner: 10Siebrand)
[17:11:00] <grrrit-wm>	 (03PS1) 10Siebrand: Migrate to JSON i18n [extensions/SubPageList] - 10https://gerrit.wikimedia.org/r/123322 
[17:11:02] <grrrit-wm>	 (03PS1) 10Siebrand: Migrate to JSON i18n [extensions/Suhosin] - 10https://gerrit.wikimedia.org/r/123323 
[17:11:04] <grrrit-wm>	 (03PS1) 10Siebrand: Migrate to JSON i18n [extensions/Sudo] - 10https://gerrit.wikimedia.org/r/123324 
[17:11:06] <grrrit-wm>	 (03PS1) 10Siebrand: Migrate to JSON i18n [extensions/Survey] - 10https://gerrit.wikimedia.org/r/123325 
[17:11:08] <grrrit-wm>	 (03PS1) 10Siebrand: Migrate to JSON i18n [extensions/SVGEdit] - 10https://gerrit.wikimedia.org/r/123326 
[17:11:12] <grrrit-wm>	 (03PS1) 10Siebrand: Migrate to JSON i18n [extensions/TemplateInfo] - 10https://gerrit.wikimedia.org/r/123327 
[17:11:14] <grrrit-wm>	 (03PS1) 10Siebrand: Migrate to JSON i18n [extensions/Tabber] - 10https://gerrit.wikimedia.org/r/123328 
[17:11:17] <grrrit-wm>	 (03PS1) 10Siebrand: Migrate to JSON i18n [extensions/ThrottleOverride] - 10https://gerrit.wikimedia.org/r/123329 
[17:11:19] <grrrit-wm>	 (03PS1) 10Siebrand: Migrate to JSON i18n [extensions/TimeMachine] - 10https://gerrit.wikimedia.org/r/123330 
[17:11:23] <grrrit-wm>	 (03PS1) 10Siebrand: Migrate to JSON i18n [extensions/TitleIcon] - 10https://gerrit.wikimedia.org/r/123331 
[17:11:25] <grrrit-wm>	 (03PS1) 10Siebrand: Migrate to JSON i18n [extensions/TimezoneSelector] - 10https://gerrit.wikimedia.org/r/123332 
[17:11:29] <grrrit-wm>	 (03PS1) 10Siebrand: Migrate to JSON i18n [extensions/Transliterator] - 10https://gerrit.wikimedia.org/r/123334 
[17:12:15] <grrrit-wm>	 (03CR) 10Siebrand: "The lint failure is not related to the contents of this patch set." [extensions/StopForumSpam] - 10https://gerrit.wikimedia.org/r/123320 (owner: 10Siebrand)
[17:12:21] <grrrit-wm>	 (03CR) 10Manybubbles: [C: 04-1] "Makes sense to me but some of the jobs remove their id parameter entirely which I'm not sure is right?" (031 comment) [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/123291 (owner: 10Chad)
[17:16:24] <grrrit-wm>	 (03CR) 10Chad: "I double checked on that actually. Turns out they're unused. We pass to the parent Job class and it doesn't even have such a parameter (an" [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/123291 (owner: 10Chad)
[17:17:06] <grrrit-wm>	 (03PS1) 10Siebrand: Migrate to JSON i18n [extensions/DataTransfer] - 10https://gerrit.wikimedia.org/r/123336 
[17:18:11] <grrrit-wm>	 (03CR) 10Svemir Brkic: [C: 032 V: 031] Migrate to JSON i18n [extensions/SphinxSearch] - 10https://gerrit.wikimedia.org/r/123313 (owner: 10Siebrand)
[17:18:30] <grrrit-wm>	 (03PS1) 10Siebrand: Migrate to JSON i18n [extensions/LiveTranslate] - 10https://gerrit.wikimedia.org/r/123337 
[17:19:40] <grrrit-wm>	 (03PS3) 10Kaldari: Cleaning up function definitions in Language.php [core] - 10https://gerrit.wikimedia.org/r/122615 
[17:20:23] <grrrit-wm>	 (03CR) 10Chad: "Looks good on the tin. Curious if you looked at the possibility of adding this as one of the "srwhat" params in the current search generat" [core] - 10https://gerrit.wikimedia.org/r/123118 (owner: 10MaxSem)
[17:20:29] <grrrit-wm>	 (03PS1) 10Siebrand: Migrate to JSON i18n [extensions/NSFileRepo] - 10https://gerrit.wikimedia.org/r/123338 
[17:20:45] <grrrit-wm>	 (03CR) 10MarkAHershberger: [C: 032] make-release: fix tests [tools/release] - 10https://gerrit.wikimedia.org/r/123245 (owner: 10Hashar)
[17:20:53] <grrrit-wm>	 (03Merged) 10jenkins-bot: make-release: fix tests [tools/release] - 10https://gerrit.wikimedia.org/r/123245 (owner: 10Hashar)
[17:21:15] <grrrit-wm>	 (03CR) 10Raimond Spekking: [C: 032 V: 032] Migrate to JSON i18n [extensions/SoundManager2Button] - 10https://gerrit.wikimedia.org/r/123312 (owner: 10Siebrand)
[17:21:44] <grrrit-wm>	 (03CR) 10Raimond Spekking: [C: 032 V: 032] Migrate to JSON i18n [extensions/SportsTeams] - 10https://gerrit.wikimedia.org/r/123314 (owner: 10Siebrand)
[17:22:13] <grrrit-wm>	 (03CR) 10Jdlrobson: [C: 031] Adding debugging for bug 62241 [core] - 10https://gerrit.wikimedia.org/r/122554 (owner: 10Kaldari)
[17:22:24] <grrrit-wm>	 (03CR) 10Raimond Spekking: [C: 032 V: 032] Migrate to JSON i18n [extensions/Spreadsheet] - 10https://gerrit.wikimedia.org/r/123315 (owner: 10Siebrand)
[17:22:32] <grrrit-wm>	 (03CR) 10JGonera: [C: 031] Adding debugging for bug 62241 [core] - 10https://gerrit.wikimedia.org/r/122554 (owner: 10Kaldari)
[17:23:00] <grrrit-wm>	 (03CR) 10Raimond Spekking: [C: 032 V: 032] Migrate to JSON i18n [extensions/SSLClientAuthentication] - 10https://gerrit.wikimedia.org/r/123316 (owner: 10Siebrand)
[17:23:11] <grrrit-wm>	 (03CR) 10MaxSem: [C: 032] Adding debugging for bug 62241 [core] - 10https://gerrit.wikimedia.org/r/122554 (owner: 10Kaldari)
[17:23:23] <grrrit-wm>	 (03CR) 10Raimond Spekking: [C: 032 V: 032] Migrate to JSON i18n [extensions/StalkerLog] - 10https://gerrit.wikimedia.org/r/123317 (owner: 10Siebrand)
[17:23:40] <grrrit-wm>	 (03CR) 10Raimond Spekking: [C: 032 V: 032] Migrate to JSON i18n [extensions/StarterWiki] - 10https://gerrit.wikimedia.org/r/123318 (owner: 10Siebrand)
[17:23:59] <grrrit-wm>	 (03CR) 10Raimond Spekking: [C: 032 V: 032] Migrate to JSON i18n [extensions/StickToThatLanguage] - 10https://gerrit.wikimedia.org/r/123319 (owner: 10Siebrand)
[17:24:35] <grrrit-wm>	 (03CR) 10Raimond Spekking: [C: 032 V: 032] Migrate to JSON i18n [extensions/SubpageFun] - 10https://gerrit.wikimedia.org/r/123321 (owner: 10Siebrand)
[17:24:44] <grrrit-wm>	 (03PS1) 10Siebrand: Migrate to JSON i18n [extensions/ReaderFeedback] - 10https://gerrit.wikimedia.org/r/123340 
[17:24:57] <grrrit-wm>	 (03CR) 10Raimond Spekking: [C: 032 V: 032] Migrate to JSON i18n [extensions/SubPageList] - 10https://gerrit.wikimedia.org/r/123322 (owner: 10Siebrand)
[17:25:29] <grrrit-wm>	 (03CR) 10Raimond Spekking: [C: 032 V: 032] Migrate to JSON i18n [extensions/Suhosin] - 10https://gerrit.wikimedia.org/r/123323 (owner: 10Siebrand)
[17:25:44] <grrrit-wm>	 (03CR) 10Raimond Spekking: [C: 032 V: 032] Migrate to JSON i18n [extensions/Sudo] - 10https://gerrit.wikimedia.org/r/123324 (owner: 10Siebrand)
[17:26:03] <grrrit-wm>	 (03CR) 10Raimond Spekking: [C: 032 V: 032] Migrate to JSON i18n [extensions/Survey] - 10https://gerrit.wikimedia.org/r/123325 (owner: 10Siebrand)
[17:26:34] <grrrit-wm>	 (03Merged) 10jenkins-bot: Adding debugging for bug 62241 [core] - 10https://gerrit.wikimedia.org/r/122554 (owner: 10Kaldari)
[17:27:20] <grrrit-wm>	 (03CR) 10Raimond Spekking: [C: 032 V: 032] Migrate to JSON i18n [extensions/ReassignEdits] - 10https://gerrit.wikimedia.org/r/123281 (owner: 10Siebrand)
[17:27:29] <grrrit-wm>	 (03CR) 10EBernhardson: [C: 04-1] "I have been trying to turn this into more of a data pipeline" (031 comment) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/123214 (owner: 10Matthias Mullie)
[17:27:35] <grrrit-wm>	 (03CR) 10Raimond Spekking: [C: 032 V: 032] Migrate to JSON i18n [extensions/RandomUsersWithAvatars] - 10https://gerrit.wikimedia.org/r/123279 (owner: 10Siebrand)
[17:28:00] <grrrit-wm>	 (03CR) 10Raimond Spekking: [C: 032 V: 032] Migrate to JSON i18n [extensions/Ratings] - 10https://gerrit.wikimedia.org/r/123278 (owner: 10Siebrand)
[17:28:06] <grrrit-wm>	 (03PS1) 10Kipcool: .gitreview defaultremote origin [extensions/WikiLexicalData] - 10https://gerrit.wikimedia.org/r/123343 
[17:28:16] <grrrit-wm>	 (03CR) 10Raimond Spekking: [C: 032 V: 032] Migrate to JSON i18n [extensions/RandomInCategory] - 10https://gerrit.wikimedia.org/r/123277 (owner: 10Siebrand)
[17:28:31] <grrrit-wm>	 (03PS1) 10Chad: Don't remove duplicate deletion jobs [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/123344 
[17:28:33] <grrrit-wm>	 (03CR) 10Kipcool: [C: 032 V: 032] .gitreview defaultremote origin [extensions/WikiLexicalData] - 10https://gerrit.wikimedia.org/r/123343 (owner: 10Kipcool)
[17:28:47] <grrrit-wm>	 (03CR) 10Raimond Spekking: [C: 032 V: 032] Migrate to JSON i18n [extensions/RandomImage] - 10https://gerrit.wikimedia.org/r/123276 (owner: 10Siebrand)
[17:29:07] <grrrit-wm>	 (03CR) 10Raimond Spekking: [C: 032 V: 032] Migrate to JSON i18n [extensions/QuickResponse] - 10https://gerrit.wikimedia.org/r/123275 (owner: 10Siebrand)
[17:32:13] <grrrit-wm>	 (03CR) 10Raimond Spekking: [C: 04-1] Migrate to JSON i18n (031 comment) [extensions/QuizGame] - 10https://gerrit.wikimedia.org/r/123274 (owner: 10Siebrand)
[17:32:39] <grrrit-wm>	 (03CR) 10Raimond Spekking: [C: 032 V: 032] Migrate to JSON i18n [extensions/Quantcast] - 10https://gerrit.wikimedia.org/r/123273 (owner: 10Siebrand)
[17:33:04] <grrrit-wm>	 (03CR) 10Raimond Spekking: [C: 032 V: 032] Migrate to JSON i18n [extensions/PushToWatch] - 10https://gerrit.wikimedia.org/r/123272 (owner: 10Siebrand)
[17:33:35] <grrrit-wm>	 (03CR) 10Raimond Spekking: [C: 032 V: 032] Migrate to JSON i18n [extensions/PubSubHubbub] - 10https://gerrit.wikimedia.org/r/123271 (owner: 10Siebrand)
[17:33:52] <grrrit-wm>	 (03CR) 10Raimond Spekking: [C: 032 V: 032] Migrate to JSON i18n [extensions/PhpMaps] - 10https://gerrit.wikimedia.org/r/123257 (owner: 10Siebrand)
[17:34:49] <grrrit-wm>	 (03CR) 10Raimond Spekking: [C: 032 V: 032] Migrate to JSON i18n [extensions/Tabber] - 10https://gerrit.wikimedia.org/r/123328 (owner: 10Siebrand)
[17:34:50] <kaldari>	 ori: Is this page accurate at all? https://wikitech.wikimedia.org/wiki/MediaWiki_UDP_logging . Aren't the UDP logs stored in /a/mw-log on fluorine now? Or are those different logs?
[17:34:51] <grrrit-wm>	 (03PS1) 10Siebrand: Migrate to JSON i18n [extensions/WikimediaIncubator] - 10https://gerrit.wikimedia.org/r/123345 
[17:35:08] <grrrit-wm>	 (03CR) 10Raimond Spekking: [C: 032 V: 032] Migrate to JSON i18n [extensions/TemplateInfo] - 10https://gerrit.wikimedia.org/r/123327 (owner: 10Siebrand)
[17:35:30] <grrrit-wm>	 (03CR) 10Raimond Spekking: [C: 032] Migrate to JSON i18n [extensions/SVGEdit] - 10https://gerrit.wikimedia.org/r/123326 (owner: 10Siebrand)
[17:35:34] <grrrit-wm>	 (03Merged) 10jenkins-bot: Migrate to JSON i18n [extensions/SVGEdit] - 10https://gerrit.wikimedia.org/r/123326 (owner: 10Siebrand)
[17:35:44] <grrrit-wm>	 (03CR) 10Manybubbles: [C: 032] Don't remove duplicate deletion jobs [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/123344 (owner: 10Chad)
[17:35:48] <grrrit-wm>	 (03CR) 10Raimond Spekking: [C: 032 V: 032] Migrate to JSON i18n [extensions/SpellingApi] - 10https://gerrit.wikimedia.org/r/123311 (owner: 10Siebrand)
[17:35:53] <grrrit-wm>	 (03Merged) 10jenkins-bot: Don't remove duplicate deletion jobs [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/123344 (owner: 10Chad)
[17:36:27] <grrrit-wm>	 (03CR) 10Raimond Spekking: [C: 032 V: 032] Migrate to JSON i18n [extensions/Special404] - 10https://gerrit.wikimedia.org/r/123309 (owner: 10Siebrand)
[17:36:42] <grrrit-wm>	 (03PS5) 10Kipcool: Introduce ow_add_definition function to API. [extensions/WikiLexicalData] - 10https://gerrit.wikimedia.org/r/116270 (owner: 10Purodha)
[17:36:48] <grrrit-wm>	 (03CR) 10Raimond Spekking: [C: 032 V: 032] Migrate to JSON i18n [extensions/Spark] - 10https://gerrit.wikimedia.org/r/123308 (owner: 10Siebrand)
[17:37:07] <grrrit-wm>	 (03CR) 10Raimond Spekking: [C: 032 V: 032] Migrate to JSON i18n [extensions/SocialProfile] - 10https://gerrit.wikimedia.org/r/123307 (owner: 10Siebrand)
[17:37:09] <grrrit-wm>	 (03CR) 10Kipcool: [C: 032 V: 032] Introduce ow_add_definition function to API. [extensions/WikiLexicalData] - 10https://gerrit.wikimedia.org/r/116270 (owner: 10Purodha)
[17:37:16] <grrrit-wm>	 (03CR) 10Siebrand: Migrate to JSON i18n (031 comment) [extensions/QuizGame] - 10https://gerrit.wikimedia.org/r/123274 (owner: 10Siebrand)
[17:37:56] <grrrit-wm>	 (03CR) 10Raimond Spekking: [C: 032 V: 032] Migrate to JSON i18n [extensions/SocialLogin] - 10https://gerrit.wikimedia.org/r/123306 (owner: 10Siebrand)
[17:38:14] <grrrit-wm>	 (03CR) 10Raimond Spekking: [C: 032 V: 032] Migrate to JSON i18n [extensions/RefreshSpecial] - 10https://gerrit.wikimedia.org/r/123283 (owner: 10Siebrand)
[17:38:35] <grrrit-wm>	 (03CR) 10Raimond Spekking: [C: 032 V: 032] Migrate to JSON i18n [extensions/RegexFun] - 10https://gerrit.wikimedia.org/r/123282 (owner: 10Siebrand)
[17:39:00] <grrrit-wm>	 (03CR) 10Kipcool: [C: 032 V: 032] "This is good for me thanks :)" [extensions/WikiLexicalData] - 10https://gerrit.wikimedia.org/r/122280 (owner: 10Hiong3-eng5)
[17:39:14] <grrrit-wm>	 (03CR) 10Raimond Spekking: [C: 032 V: 032] Migrate to JSON i18n [extensions/ThrottleOverride] - 10https://gerrit.wikimedia.org/r/123329 (owner: 10Siebrand)
[17:39:32] <grrrit-wm>	 (03CR) 10Raimond Spekking: [C: 032 V: 032] Migrate to JSON i18n [extensions/TimeMachine] - 10https://gerrit.wikimedia.org/r/123330 (owner: 10Siebrand)
[17:39:42] <manybubbles>	 does anyone have godlike powers over wikimedia's travisci account?
[17:39:48] <grrrit-wm>	 (03CR) 10Raimond Spekking: [C: 032 V: 032] Migrate to JSON i18n [extensions/TitleIcon] - 10https://gerrit.wikimedia.org/r/123331 (owner: 10Siebrand)
[17:39:49] <manybubbles>	 I just need a repository turned on for building
[17:40:00] <grrrit-wm>	 (03Abandoned) 10CSteipp: Reduce number of bcrypt tests [core] - 10https://gerrit.wikimedia.org/r/119083 (owner: 10CSteipp)
[17:40:04] <grrrit-wm>	 (03CR) 10Raimond Spekking: [C: 032 V: 032] Migrate to JSON i18n [extensions/TimezoneSelector] - 10https://gerrit.wikimedia.org/r/123332 (owner: 10Siebrand)
[17:40:32] <bd808>	 manybubbles: ori might
[17:40:43] <grrrit-wm>	 (03CR) 10Raimond Spekking: [C: 032] Migrate to JSON i18n [extensions/Transliterator] - 10https://gerrit.wikimedia.org/r/123334 (owner: 10Siebrand)
[17:40:51] <grrrit-wm>	 (03Merged) 10jenkins-bot: Migrate to JSON i18n [extensions/Transliterator] - 10https://gerrit.wikimedia.org/r/123334 (owner: 10Siebrand)
[17:41:35] <grrrit-wm>	 (03PS2) 10Kipcool: API-ow_syntrans: fixed broken part parameter. [extensions/WikiLexicalData] - 10https://gerrit.wikimedia.org/r/118234 (owner: 10Hiong3-eng5)
[17:41:43] <manybubbles>	 bd808: thanks
[17:42:13] <grrrit-wm>	 (03CR) 10Kipcool: [C: 032 V: 032] "ok I have some backlog in my reviewing of patches... sorry..." [extensions/WikiLexicalData] - 10https://gerrit.wikimedia.org/r/118234 (owner: 10Hiong3-eng5)
[17:42:28] <grrrit-wm>	 (03CR) 10Raimond Spekking: [C: 032] Migrate to JSON i18n [extensions/WikimediaIncubator] - 10https://gerrit.wikimedia.org/r/123345 (owner: 10Siebrand)
[17:42:31] <grrrit-wm>	 (03Merged) 10jenkins-bot: Migrate to JSON i18n [extensions/WikimediaIncubator] - 10https://gerrit.wikimedia.org/r/123345 (owner: 10Siebrand)
[17:43:30] <grrrit-wm>	 (03CR) 10Raimond Spekking: [C: 032] Migrate to JSON i18n [extensions/ReaderFeedback] - 10https://gerrit.wikimedia.org/r/123340 (owner: 10Siebrand)
[17:43:33] <grrrit-wm>	 (03Merged) 10jenkins-bot: Migrate to JSON i18n [extensions/ReaderFeedback] - 10https://gerrit.wikimedia.org/r/123340 (owner: 10Siebrand)
[17:43:51] <grrrit-wm>	 (03CR) 10Raimond Spekking: [C: 032 V: 032] Migrate to JSON i18n [extensions/NSFileRepo] - 10https://gerrit.wikimedia.org/r/123338 (owner: 10Siebrand)
[17:44:10] <grrrit-wm>	 (03CR) 10Raimond Spekking: [C: 032 V: 032] Migrate to JSON i18n [extensions/LiveTranslate] - 10https://gerrit.wikimedia.org/r/123337 (owner: 10Siebrand)
[17:44:32] <grrrit-wm>	 (03CR) 10Raimond Spekking: [C: 032 V: 032] Migrate to JSON i18n [extensions/SphinxSearch] - 10https://gerrit.wikimedia.org/r/123313 (owner: 10Siebrand)
[17:44:52] <grrrit-wm>	 (03CR) 10Raimond Spekking: [C: 032 V: 032] Migrate to JSON i18n [extensions/DataTransfer] - 10https://gerrit.wikimedia.org/r/123336 (owner: 10Siebrand)
[17:45:45] <grrrit-wm>	 (03CR) 10Raimond Spekking: [C: 032 V: 032] Migrate to JSON i18n [extensions/StopForumSpam] - 10https://gerrit.wikimedia.org/r/123320 (owner: 10Siebrand)
[17:47:15] <grrrit-wm>	 (03CR) 10Raimond Spekking: [C: 032 V: 032] Migrate to JSON i18n [extensions/QuizGame] - 10https://gerrit.wikimedia.org/r/123274 (owner: 10Siebrand)
[17:47:17] <grrrit-wm>	 (03PS1) 10Jforrester: Switch from CSS to LESS and use MediaWiki's SVG fallback LESS function [extensions/BetaFeatures] - 10https://gerrit.wikimedia.org/r/123348 
[17:47:47] <grrrit-wm>	 (03PS1) 10Chad: Tighten up returns in LinksUpdateJob [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/123349 
[17:49:47] <grrrit-wm>	 (03CR) 10Krinkle: [C: 031] Use simple random sampling to log deprecated usage at 1:100 [extensions/WikimediaEvents] - 10https://gerrit.wikimedia.org/r/123172 (owner: 10Ori.livneh)
[17:50:23] <grrrit-wm>	 (03PS2) 10Bsitu: Add summarize/close/open topic to history/contribution [extensions/Flow] - 10https://gerrit.wikimedia.org/r/123123 
[17:50:37] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] Add summarize/close/open topic to history/contribution [extensions/Flow] - 10https://gerrit.wikimedia.org/r/123123 (owner: 10Bsitu)
[17:53:32] <grrrit-wm>	 (03CR) 10Krinkle: "Relates to bug 54665." [core] - 10https://gerrit.wikimedia.org/r/123096 (owner: 10Mattflaschen)
[17:54:59] <grrrit-wm>	 (03CR) 10Chad: "The change to WikiPage lgtm but I'd rather have someone else OK the api bit." [core] - 10https://gerrit.wikimedia.org/r/113525 (owner: 10Mattflaschen)
[17:55:38] <grrrit-wm>	 (03CR) 10Manybubbles: [C: 032] Tighten up returns in LinksUpdateJob [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/123349 (owner: 10Chad)
[17:56:42] <spagewmf>	 superm401 ++: "LESS test suite done - This covers all LESS in core and registered extensions, except skinStyles" <3 
[17:57:37] <spagewmf>	 superm401: a) by "registered extensions" do you mean any extension running Jenkins CI, or must we edit some .yaml? b) can I tell in CI output this test is happening?
[17:57:51] <grrrit-wm>	 (03PS1) 10Manybubbles: Correctly remove things I moved [search/highlighter] - 10https://gerrit.wikimedia.org/r/123351 
[17:58:02] <grrrit-wm>	 (03CR) 10Manybubbles: [C: 032 V: 032] Correctly remove things I moved [search/highlighter] - 10https://gerrit.wikimedia.org/r/123351 (owner: 10Manybubbles)
[18:00:15] <grrrit-wm>	 (03CR) 10Kipcool: "Hmm, the latest patch 4 actually removed the patch 3. Probably it was not meant to be so, I'll try to merge the changes from the two patch" [extensions/WikiLexicalData] - 10https://gerrit.wikimedia.org/r/119446 (owner: 10Hiong3-eng5)
[18:02:46] <grrrit-wm>	 (03CR) 10Krinkle: "Please don't merge without Roan, Trevor or myself. I don't have enough to fully explain at this time, but I suspect this might have unfore" [core] - 10https://gerrit.wikimedia.org/r/122838 (owner: 10Phuedx)
[18:03:56] <grrrit-wm>	 (03CR) 10Krinkle: Make checkLess.php validate skin styles (031 comment) [core] - 10https://gerrit.wikimedia.org/r/122838 (owner: 10Phuedx)
[18:05:21] <grrrit-wm>	 (03PS1) 10Physikerwelt: Improve UpdateMath script [extensions/MathSearch] - 10https://gerrit.wikimedia.org/r/123355 
[18:05:23] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] Improve UpdateMath script [extensions/MathSearch] - 10https://gerrit.wikimedia.org/r/123355 (owner: 10Physikerwelt)
[18:06:54] <grrrit-wm>	 (03PS5) 10Kipcool: MW WLD prefix compatibility fix [extensions/WikiLexicalData] - 10https://gerrit.wikimedia.org/r/119446 (owner: 10Hiong3-eng5)
[18:07:05] <grrrit-wm>	 (03CR) 10MaxSem: "srwhat=title is not supported by any engines used by WMF." [core] - 10https://gerrit.wikimedia.org/r/123118 (owner: 10MaxSem)
[18:09:27] <grrrit-wm>	 (03PS1) 10Aaron Schulz: Re-organized PoolCounter files [core] - 10https://gerrit.wikimedia.org/r/123357 
[18:10:04] <AaronSchulz>	 ^d: easy one :)
[18:10:06] <grrrit-wm>	 (03CR) 10Chad: "How silly. It should be very easy to support." [core] - 10https://gerrit.wikimedia.org/r/123118 (owner: 10MaxSem)
[18:10:29] <grrrit-wm>	 (03CR) 10Chad: [C: 032] Re-organized PoolCounter files [core] - 10https://gerrit.wikimedia.org/r/123357 (owner: 10Aaron Schulz)
[18:10:35] <grrrit-wm>	 (03PS2) 10Physikerwelt: Improve UpdateMath script [extensions/MathSearch] - 10https://gerrit.wikimedia.org/r/123355 
[18:10:40] <grrrit-wm>	 (03PS1) 10IAlex: Fix language statistics after messages have been moved to JSON [core] - 10https://gerrit.wikimedia.org/r/123358 
[18:11:12] <grrrit-wm>	 (03CR) 10Krinkle: [C: 04-1] Fixes IE11 support in jquery.fullscreen (031 comment) [core] - 10https://gerrit.wikimedia.org/r/122648 (owner: 10Gilles)
[18:12:30] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] Improve UpdateMath script [extensions/MathSearch] - 10https://gerrit.wikimedia.org/r/123355 (owner: 10Physikerwelt)
[18:12:38] <grrrit-wm>	 (03PS2) 10Krinkle: Fixes IE11 support in jquery.fullscreen [core] - 10https://gerrit.wikimedia.org/r/122648 (owner: 10Gilles)
[18:13:18] <grrrit-wm>	 (03PS3) 10Krinkle: Update jquery.fullscreen to newer version (fix IE11 support) [core] - 10https://gerrit.wikimedia.org/r/122648 (owner: 10Gilles)
[18:13:46] <grrrit-wm>	 (03CR) 10Nikerabbit: [C: 04-1] Cleaning up function definitions in Language.php (031 comment) [core] - 10https://gerrit.wikimedia.org/r/122615 (owner: 10Kaldari)
[18:14:18] <grrrit-wm>	 (03PS1) 10Manybubbles: Get ready to release snapshots [search/highlighter] - 10https://gerrit.wikimedia.org/r/123359 
[18:14:26] <grrrit-wm>	 (03CR) 10Manybubbles: [C: 032 V: 032] Get ready to release snapshots [search/highlighter] - 10https://gerrit.wikimedia.org/r/123359 (owner: 10Manybubbles)
[18:14:49] <grrrit-wm>	 (03Merged) 10jenkins-bot: Re-organized PoolCounter files [core] - 10https://gerrit.wikimedia.org/r/123357 (owner: 10Aaron Schulz)
[18:17:32] <grrrit-wm>	 (03PS7) 10Jforrester: New icons [extensions/BetaFeatures] - 10https://gerrit.wikimedia.org/r/91040 (owner: 10Esanders)
[18:17:45] <grrrit-wm>	 (03CR) 10Aaron Schulz: [C: 031] Use simple random sampling to log deprecated usage at 1:100 [extensions/WikimediaEvents] - 10https://gerrit.wikimedia.org/r/123172 (owner: 10Ori.livneh)
[18:17:59] <grrrit-wm>	 (03CR) 10Jforrester: "PS7 is a rebase." [extensions/BetaFeatures] - 10https://gerrit.wikimedia.org/r/91040 (owner: 10Esanders)
[18:19:35] <jackmcbarn>	 anomie: ping https://gerrit.wikimedia.org/r/#/c/120156/
[18:24:52] <grrrit-wm>	 (03PS4) 10Kaldari: Cleaning up function definitions in Language.php [core] - 10https://gerrit.wikimedia.org/r/122615 
[18:25:55] <grrrit-wm>	 (03CR) 10Nikerabbit: [C: 032] "Let's have a go" [core] - 10https://gerrit.wikimedia.org/r/122615 (owner: 10Kaldari)
[18:26:25] <grrrit-wm>	 (03CR) 10Anomie: [C: 032] Remove limits on mw.language:formatDate() [extensions/Scribunto] - 10https://gerrit.wikimedia.org/r/120156 (owner: 10Jackmcbarn)
[18:26:31] <anomie>	 jackmcbarn: ^
[18:27:02] <grrrit-wm>	 (03CR) 10UltrasonicNXT: [C: 032 V: 032] "Merging this, but as Siebrand says, please don't add 2 patchsets when there should only be one." [extensions/MediaWikiChat] - 10https://gerrit.wikimedia.org/r/122878 (owner: 10GeorgeBarnick)
[18:27:16] <grrrit-wm>	 (03CR) 10UltrasonicNXT: [C: 032 V: 032] "Merging this, but as Siebrand says, please don't add 2 patchsets when there should only be one." [extensions/MediaWikiChat] - 10https://gerrit.wikimedia.org/r/122876 (owner: 10GeorgeBarnick)
[18:28:46] <grrrit-wm>	 (03PS1) 10Ragesoss: Add Swedish aliases for EP namespaces and a special page [extensions/EducationProgram] - 10https://gerrit.wikimedia.org/r/123361 
[18:28:51] <grrrit-wm>	 (03Merged) 10jenkins-bot: Remove limits on mw.language:formatDate() [extensions/Scribunto] - 10https://gerrit.wikimedia.org/r/120156 (owner: 10Jackmcbarn)
[18:28:53] <grrrit-wm>	 (03PS1) 10Ragesoss: Add namespace aliases and a special page alias in Swedish [extensions/EducationProgram] - 10https://gerrit.wikimedia.org/r/123362 
[18:29:14] <superm401>	 spagewmf, I believe if you see testextensions in your Jenkins output, it is running.
[18:29:28] <jackmcbarn>	 anomie: thanks
[18:29:29] <jackmcbarn>	 anomie: btw, if you have time, can you look at https://gerrit.wikimedia.org/r/#/c/97559/ and/or https://gerrit.wikimedia.org/r/#/c/116482/ ? they've each been sitting around for a while (one since november)
[18:29:41] <grrrit-wm>	 (03Merged) 10jenkins-bot: Cleaning up function definitions in Language.php [core] - 10https://gerrit.wikimedia.org/r/122615 (owner: 10Kaldari)
[18:29:46] <superm401>	 We need to do our own followup (e.g. one of our extensions isn't running it), so I'll try to let you know any updates.
[18:32:00] <grrrit-wm>	 (03Abandoned) 10Ragesoss: Add Swedish aliases for EP namespaces and a special page [extensions/EducationProgram] - 10https://gerrit.wikimedia.org/r/123361 (owner: 10Ragesoss)
[18:32:36] <grrrit-wm>	 (03Abandoned) 10Ragesoss: Add namespace aliases and a special page alias in Swedish [extensions/EducationProgram] - 10https://gerrit.wikimedia.org/r/123362 (owner: 10Ragesoss)
[18:32:48] <grrrit-wm>	 (03PS1) 10Manybubbles: More spelling fixes [search/highlighter] - 10https://gerrit.wikimedia.org/r/123363 
[18:32:58] <grrrit-wm>	 (03CR) 10Manybubbles: [C: 032 V: 032] More spelling fixes [search/highlighter] - 10https://gerrit.wikimedia.org/r/123363 (owner: 10Manybubbles)
[18:33:30] <grrrit-wm>	 (03CR) 10MaxSem: [C: 04-2] "Wait a sec while I'm investigating something..." [core] - 10https://gerrit.wikimedia.org/r/123118 (owner: 10MaxSem)
[18:36:03] <grrrit-wm>	 (03CR) 10Manybubbles: [C: 032] "Looks like Aaron removed it on December 15th in I1db3b9adeaaeb66821e9ff6a931f7905ce916b7f" [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/123291 (owner: 10Chad)
[18:36:19] <grrrit-wm>	 (03Merged) 10jenkins-bot: Remove short variable names [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/123291 (owner: 10Chad)
[18:36:42] <grrrit-wm>	 (03PS1) 10Ragesoss: Add namespace aliases and a special page alias in Swedish [extensions/EducationProgram] - 10https://gerrit.wikimedia.org/r/123365 
[18:38:03] <grrrit-wm>	 (03CR) 10Odder: "I'm sure you are aware that you're adding a Wikipedia-specific alias to a MediaWiki extension..." [extensions/EducationProgram] - 10https://gerrit.wikimedia.org/r/123365 (owner: 10Ragesoss)
[18:39:41] <grrrit-wm>	 (03CR) 10Kipcool: "Is anyone working on this now?" (035 comments) [extensions/WikiLexicalData] - 10https://gerrit.wikimedia.org/r/119446 (owner: 10Hiong3-eng5)
[18:41:18] <grrrit-wm>	 (03PS1) 10Konarak: Handle defaults for api action=options [core] - 10https://gerrit.wikimedia.org/r/123367 
[18:44:21] <grrrit-wm>	 (03CR) 10Ragesoss: "Odder, I'm not sure what you mean. The EP_NS and EP_NS_TALK namespaces come from this extension, so these aliases should work on any Swedi" [extensions/EducationProgram] - 10https://gerrit.wikimedia.org/r/123365 (owner: 10Ragesoss)
[18:45:39] <grrrit-wm>	 (03CR) 10Nemo bis: "/srv/deployment/integration/slave-scripts/bin/mw-run-phpunit.sh: line 102: 14168 Segmentation fault" [core] - 10https://gerrit.wikimedia.org/r/122615 (owner: 10Kaldari)
[18:46:30] <grrrit-wm>	 (03CR) 10Ragesoss: "Ah, you mean the special page alias, which as "Wikipedia" in the name. That's true, but since at this point the extension is only on Wikip" [extensions/EducationProgram] - 10https://gerrit.wikimedia.org/r/123365 (owner: 10Ragesoss)
[18:46:37] <grrrit-wm>	 (03CR) 10Odder: "On Wikimedia wikis, yes. But your change adds 'Wikipediaambassadörer' as an alias for all wikis that will use/use this extension, even if " [extensions/EducationProgram] - 10https://gerrit.wikimedia.org/r/123365 (owner: 10Ragesoss)
[18:46:58] <grrrit-wm>	 (03CR) 10MaxSem: "Eh, and list=search doesn't support other things our prefix search returns, like search for special pages. I'll poke at making srwhat=titl" [core] - 10https://gerrit.wikimedia.org/r/123118 (owner: 10MaxSem)
[18:47:09] <MaxSem>	 ^d, ^^
[18:47:38] <^d>	 Makes sense.
[18:49:58] <grrrit-wm>	 (03CR) 10Ragesoss: "The current plan is to replace this extension, once the "Editor campaigns" project is far enough along to do so. Because of that, and that" [extensions/EducationProgram] - 10https://gerrit.wikimedia.org/r/123365 (owner: 10Ragesoss)
[18:50:01] <grrrit-wm>	 (03CR) 10Aaron Schulz: [C: 032] Use simple random sampling to log deprecated usage at 1:100 [extensions/WikimediaEvents] - 10https://gerrit.wikimedia.org/r/123172 (owner: 10Ori.livneh)
[18:50:04] <grrrit-wm>	 (03Merged) 10jenkins-bot: Use simple random sampling to log deprecated usage at 1:100 [extensions/WikimediaEvents] - 10https://gerrit.wikimedia.org/r/123172 (owner: 10Ori.livneh)
[18:50:18] <grrrit-wm>	 (03CR) 10JGonera: "Hashar, I'm also wondering about the .jshint file. Why not the one from core?" [extensions/ConfirmEdit] - 10https://gerrit.wikimedia.org/r/122126 (owner: 10AalekhN)
[18:52:05] <grrrit-wm>	 (03PS1) 10Ori.livneh: Update WikimediaEvents to master for I7fdaa5524 [core] (wmf/1.23wmf19) - 10https://gerrit.wikimedia.org/r/123370 
[18:52:26] <grrrit-wm>	 (03PS1) 10Ori.livneh: Update WikimediaEvents to master for I7fdaa5524 [core] (wmf/1.23wmf20) - 10https://gerrit.wikimedia.org/r/123371 
[18:56:03] <grrrit-wm>	 (03CR) 10Ori.livneh: [C: 032] Update WikimediaEvents to master for I7fdaa5524 [core] (wmf/1.23wmf19) - 10https://gerrit.wikimedia.org/r/123370 (owner: 10Ori.livneh)
[18:56:12] <grrrit-wm>	 (03CR) 10Ori.livneh: [C: 032] Update WikimediaEvents to master for I7fdaa5524 [core] (wmf/1.23wmf20) - 10https://gerrit.wikimedia.org/r/123371 (owner: 10Ori.livneh)
[18:57:48] <grrrit-wm>	 (03PS2) 10Konarak: Handle defaults for api action=options [core] - 10https://gerrit.wikimedia.org/r/123367 
[18:59:49] <grrrit-wm>	 (03PS4) 10Ori.livneh: Respect sizing from user-supplied class [core] - 10https://gerrit.wikimedia.org/r/104650 (owner: 10EBernhardson)
[19:00:13] <grrrit-wm>	 (03CR) 10Ori.livneh: [C: 032] Respect sizing from user-supplied class [core] - 10https://gerrit.wikimedia.org/r/104650 (owner: 10EBernhardson)
[19:01:07] <grrrit-wm>	 (03Merged) 10jenkins-bot: Update WikimediaEvents to master for I7fdaa5524 [core] (wmf/1.23wmf19) - 10https://gerrit.wikimedia.org/r/123370 (owner: 10Ori.livneh)
[19:01:09] <grrrit-wm>	 (03Merged) 10jenkins-bot: Update WikimediaEvents to master for I7fdaa5524 [core] (wmf/1.23wmf20) - 10https://gerrit.wikimedia.org/r/123371 (owner: 10Ori.livneh)
[19:04:18] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] Tighten up returns in LinksUpdateJob [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/123349 (owner: 10Chad)
[19:04:26] <grrrit-wm>	 (03Merged) 10jenkins-bot: Respect sizing from user-supplied class [core] - 10https://gerrit.wikimedia.org/r/104650 (owner: 10EBernhardson)
[19:06:49] <grrrit-wm>	 (03PS1) 10Siebrand: Migrate to JSON i18n [extensions/Wikilog] - 10https://gerrit.wikimedia.org/r/123372 
[19:12:01] <grrrit-wm>	 (03CR) 10Aaron Schulz: [C: 032] Fix language statistics after messages have been moved to JSON [core] - 10https://gerrit.wikimedia.org/r/123358 (owner: 10IAlex)
[19:13:06] <grrrit-wm>	 (03CR) 10Bsitu: Update post/header revision storage search key (031 comment) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/117099 (owner: 10Bsitu)
[19:13:07] <^d>	 ebernhardson: I repacked mw/core more aggressively after we talked the other day :)
[19:13:17] <^d>	 Got it down to 189M on gerrit's disk.
[19:15:57] <MatmaRex>	 ^d: <3
[19:16:18] <^d>	 A little more, once I ran jgit gc to regen the bitmaps.
[19:17:09] <^d>	 MatmaRex: http://p.defau.lt/?QK_Zou_78_z1NtS8CuzBTQ
[19:17:43] <MatmaRex>	 pretty
[19:19:02] <grrrit-wm>	 (03PS1) 10Hashar: Job for search highlighter [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/123417 
[19:19:29] <grrrit-wm>	 (03CR) 10Hashar: "Looks legit well done. I have deployed the job." [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/123304 (owner: 10Manybubbles)
[19:20:56] <grrrit-wm>	 (03Merged) 10jenkins-bot: Fix language statistics after messages have been moved to JSON [core] - 10https://gerrit.wikimedia.org/r/123358 (owner: 10IAlex)
[19:24:09] <grrrit-wm>	 (03CR) 10Hashar: [C: 032] "Zuul triggers!" [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/123417 (owner: 10Hashar)
[19:24:19] <grrrit-wm>	 (03Merged) 10jenkins-bot: Job for search highlighter [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/123417 (owner: 10Hashar)
[19:24:55] <grrrit-wm>	 (03PS1) 10Hashar: Jenkins job validation (DO NOT SUBMIT) [search/highlighter] - 10https://gerrit.wikimedia.org/r/123419 
[19:25:17] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] Jenkins job validation (DO NOT SUBMIT) [search/highlighter] - 10https://gerrit.wikimedia.org/r/123419 (owner: 10Hashar)
[19:26:00] <grrrit-wm>	 (03CR) 10Aaron Schulz: [C: 032] Prevent passing information between #invokes using math.random [extensions/Scribunto] - 10https://gerrit.wikimedia.org/r/122862 (owner: 10Anomie)
[19:26:02] <grrrit-wm>	 (03CR) 10Hashar: "Test change https://gerrit.wikimedia.org/r/#/c/123419/" [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/123304 (owner: 10Manybubbles)
[19:28:23] <grrrit-wm>	 (03Merged) 10jenkins-bot: Prevent passing information between #invokes using math.random [extensions/Scribunto] - 10https://gerrit.wikimedia.org/r/122862 (owner: 10Anomie)
[19:29:22] <grrrit-wm>	 (03CR) 10GeorgeBarnick: "I meant to make it the same commit, but for some reason it made them two separate ones." [extensions/MediaWikiChat] - 10https://gerrit.wikimedia.org/r/122876 (owner: 10GeorgeBarnick)
[19:29:50] <grrrit-wm>	 (03PS1) 10CSteipp: Allow setting OAuth to Read Only [extensions/OAuth] - 10https://gerrit.wikimedia.org/r/123421 
[19:31:05] <grrrit-wm>	 (03PS3) 10Bsitu: Add summarize/close/open topic to history/contribution [extensions/Flow] - 10https://gerrit.wikimedia.org/r/123123 
[19:31:14] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] Add summarize/close/open topic to history/contribution [extensions/Flow] - 10https://gerrit.wikimedia.org/r/123123 (owner: 10Bsitu)
[19:31:15] <renoirb>	 Hi all, i’d like to understand what is the difference between wgResourceLoaderMaxage = array(‘versioned’ =>array(), ‘unversioned’ => array());   How can I know which one is applied to my environment?%
[19:31:43] <grrrit-wm>	 (03CR) 10Nemo bis: "Thanks IAlex for keeping maintaining the language statistics for so many years. :)" [core] - 10https://gerrit.wikimedia.org/r/123358 (owner: 10IAlex)
[19:31:58] * marktraceur  looks at RoanKattouw 

[19:32:46] <RoanKattouw>	 mark?
[19:32:49] <RoanKattouw>	 marktraceur: ?
[19:32:55] <RoanKattouw>	 Oh
[19:33:10] <RoanKattouw>	 renoirb: Both are used, it depends on the type of request
[19:33:32] <RoanKattouw>	 Most requests are 'versioned', which means they have a &version=... parameter, and so they have long cache timeouts
[19:33:48] <renoirb>	 Ok, so in the load.php?… what gets loaded, if the resourceloader has a version string?
[19:33:49] <RoanKattouw>	 Some requests are 'unversioned', they don't have a &version=... parameter and so they have short cache timeouts
[19:34:05] <renoirb>	 if the resource… loaded by the resource loader 
[19:34:15] <RoanKattouw>	 ResourceLoader itself ignores the version string, it's only there for cache busting
[19:34:36] <RoanKattouw>	 Our caching strategy for most load.php URLs is this:
[19:34:54] <RoanKattouw>	 1) Load things from load.php?modules=....&version=....
[19:35:05] <RoanKattouw>	 2) Set cache headers to "forever" (30 days)
[19:35:18] <RoanKattouw>	 3) If the module changes, load it with a different (higher) &version parameter
[19:35:31] <RoanKattouw>	 4) This misses the cache we created in #2, so we load the new content
[19:35:33] <RoanKattouw>	 Does that make sense?
[19:36:20] <grrrit-wm>	 (03PS2) 10Hashar: Jenkins job validation (DO NOT SUBMIT) [search/highlighter] - 10https://gerrit.wikimedia.org/r/123419 
[19:36:22] <renoirb>	 so, if my header tag has “…load.php?param=1&param=2”  has NO version= … it doesnt use that caching, right?
[19:36:26] * renoirb  is just validating

[19:36:51] <RoanKattouw>	 renoirb: It does use caching, just very short-term caching (5 minutes instead of 30 days)
[19:37:00] <RoanKattouw>	 This exists mostly for bootstrapping
[19:37:03] <renoirb>	 right.
[19:37:04] <renoirb>	 ok
[19:37:11] <grrrit-wm>	 (03PS2) 10Hashar: Add job for search highlighter [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/123304 (owner: 10Manybubbles)
[19:37:14] <RoanKattouw>	 There's a special module called 'startup' that lists all the last-modified timestamps for all the other modules
[19:37:30] <renoirb>	 So, where should I set this in the configs?
[19:37:34] <RoanKattouw>	 startup can't be loaded with a timestamp because we don't have any timestamps before we've loaded startup
[19:37:44] <RoanKattouw>	 renoirb: The default values should be fine, you shouldn't need to tune these values
[19:38:17] <renoirb>	 My link and script tags that uses the load.php… doesnt have this get parameter, i’d like to set it
[19:38:39] <renoirb>	 I’m currently try8ing to improve my cache Hit rate behind Varnish.   
[19:38:51] <renoirb>	 s/behind/with/
[19:39:21] <RoanKattouw>	 The ones that don't have a version parameter tend to have good reasons for not having one
[19:39:25] <grrrit-wm>	 (03CR) 10Yurik: [C: 04-1] Handle defaults for api action=options (031 comment) [core] - 10https://gerrit.wikimedia.org/r/123367 (owner: 10Konarak)
[19:39:35] <grrrit-wm>	 (03CR) 10Hashar: [C: 032] "Needed JDK7 to make it work: https://integration.wikimedia.org/ci/job/search-highlighter/2/console" (031 comment) [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/123304 (owner: 10Manybubbles)
[19:39:48] <RoanKattouw>	 Usually because that information isn't available at that point in time
[19:40:22] <grrrit-wm>	 (03Merged) 10jenkins-bot: Add job for search highlighter [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/123304 (owner: 10Manybubbles)
[19:40:36] <grrrit-wm>	 (03Abandoned) 10Hashar: Jenkins job validation (DO NOT SUBMIT) [search/highlighter] - 10https://gerrit.wikimedia.org/r/123419 (owner: 10Hashar)
[19:40:38] <renoirb>	 uhm.
[19:40:56] <RoanKattouw>	 Also: if you're just looking at the HTML source, you'll only see versionless ones
[19:41:07] <RoanKattouw>	 The ones with &version=... are added dynamically by JavaScript
[19:41:34] <renoirb>	 I’m in the school of ‘Not using runtime PHP for asset minification AT ALL’ because nothing’s faster than a static asset RoanKattouw. With what I see, i tend to distrust the strategy :/
[19:42:21] <renoirb>	 oh, right!   I forgot to look at the DOM, not just view source :]
[19:42:34] <RoanKattouw>	 Well with Varnish things generated by runtime PHP with high cache timeouts are just as fast as static assets :)
[19:43:02] <renoirb>	 uhm.  I do not have a good enough hit rate so far.
[19:43:16] <marktraceur>	 Nearly as fast, on average, but not exactly as fast
[19:43:24] <renoirb>	 Its either because I broke something that Ryan_Lane did before, or it needs improvements. that’s where I am :)
[19:43:42] <RoanKattouw>	 Did the hit rate use to be higher?
[19:43:45] <marktraceur>	 Definitely way more useful for deployments and development
[19:43:51] <RoanKattouw>	 Is it measuring hit rate just for load.php requests but for content as well?
[19:44:09] <renoirb>	 No, not just load.php, overall service cache hit stats
[19:44:17] <RoanKattouw>	 Right
[19:44:23] <RoanKattouw>	 Which might be affected by much more than just load.php
[19:44:42] <renoirb>	 my MW app servers are always the ones crashing.
[19:44:49] <renoirb>	 (when they crash, that is.)
[19:44:57] <renoirb>	 yes.
[19:47:18] <renoirb>	 I’m curious why MW sends ‘Cache-Control:private, must-revalidate, max-age=0’  on a non authenticated user Response on a page  (e.g. /wiki/Main_Page)
[19:48:08] <RoanKattouw>	 Yeah setting things up so page views are cached correctly is difficuly
[19:48:11] <RoanKattouw>	 *difficult
[19:48:17] <renoirb>	 Indeed.
[19:48:43] <renoirb>	 I’m tempted to set to ignore the headers in some situations. But you know, it can break something else.
[19:49:16] <RoanKattouw>	 So my understanding of content caching is incomplete
[19:49:21] <renoirb>	 I’m not an expert in web server perf tuning, BTW.
[19:50:03] <RoanKattouw>	 Also, hold on, that CC:private header
[19:50:11] <RoanKattouw>	 Are you seeing that coming from MW, or from Varnish?
[19:50:20] <RoanKattouw>	 Because Varnish is *supposed* to send that to the outside world
[19:50:31] <renoirb>	 I ran siege from a neighboor VM with 140 simultaneous … the server was sleeping (of course, no latency).  I pass through Varnish (latency is there) things doesnt go as well.  
[19:51:26] <renoirb>	 Uhm.  My Apache config doesnt set any Cache-Control headers there 
[19:51:31] <renoirb>	 Let me double check
[19:51:58] <RoanKattouw>	 MW might be setting CC headers too
[19:52:12] <renoirb>	 My Varnish config, in case you want to see it: https://github.com/webplatform/varnish-configs/blob/master/docs.vcl
[19:52:13] <RoanKattouw>	 And Varnish might (should, even) be serving different CC headers to you than what it gets from MW
[19:52:24] * RoanKattouw  doesn't speak VCL, unfortunately :(

[19:52:32] <renoirb>	 NP :)
[19:52:36] <renoirb>	 as I said, in case :)
[19:52:51] <renoirb>	 Nothing about writing cache-control there, I confirm.
[19:52:56] * renoirb  checks in apache configs

[19:53:09] <renoirb>	 s/checks/checking/
[19:53:20] <grrrit-wm>	 (03PS1) 10Foxtrott: Add 'fixed' attribute to nav bar; bugfixes [skins/chameleon] - 10https://gerrit.wikimedia.org/r/123423 
[19:53:46] <grrrit-wm>	 (03PS2) 10Foxtrott: Add 'fixed' option to nav bar; bugfixes [skins/chameleon] - 10https://gerrit.wikimedia.org/r/123423 
[19:54:56] <renoirb>	 Nothing there, RoanKattouw 
[19:55:14] <^d>	 siebrand: We should use tabs *and* spaces.
[19:55:19] <^d>	 Then everyone wins!
[19:55:32] <grrrit-wm>	 (03CR) 10Foxtrott: [C: 032 V: 032] Add 'fixed' option to nav bar; bugfixes [skins/chameleon] - 10https://gerrit.wikimedia.org/r/123423 (owner: 10Foxtrott)
[19:55:54] <renoirb>	 What I like to use is Fabien Potencier’s PHP Coding Standards Fixer. Nothing is done manually :)
[19:56:09] <renoirb>	 I do that too with gulp
[19:56:14] <renoirb>	 and my javascript projects
[20:00:56] <jackmcbarn>	 does a CR-2 persist across patch sets?
[20:01:07] <RoanKattouw>	 jackmcbarn: Yes
[20:01:13] <grrrit-wm>	 (03PS1) 10GeorgeBarnick: Changing audio/ directory to assets/ [extensions/MediaWikiChat] - 10https://gerrit.wikimedia.org/r/123425 
[20:01:20] <jackmcbarn>	 what's the reason for that?
[20:01:24] <RoanKattouw>	 I don't know
[20:01:42] <RoanKattouw>	 It's just how Gerrit works
[20:02:08] <RoanKattouw>	 It makes sense to me, though, if you're vetoing something you wouldn't want someone to be able to circumvent that by just changing one character in the commit message
[20:04:58] <grrrit-wm>	 (03CR) 10Raimond Spekking: [C: 032 V: 032] Implemented changes for getting into translatewiki [extensions/BlueSpiceFoundation] - 10https://gerrit.wikimedia.org/r/121683 (owner: 10Smuggli)
[20:06:29] <renoirb>	 Ryan_Lane: yt?
[20:06:41] <grrrit-wm>	 (03PS1) 10Raimond Spekking: Add newline at end of file to unbreak translatewiki.net scripts [extensions/BlueSpiceFoundation] - 10https://gerrit.wikimedia.org/r/123427 
[20:06:51] <grrrit-wm>	 (03CR) 10Raimond Spekking: [C: 032 V: 032] Add newline at end of file to unbreak translatewiki.net scripts [extensions/BlueSpiceFoundation] - 10https://gerrit.wikimedia.org/r/123427 (owner: 10Raimond Spekking)
[20:06:55] <grrrit-wm>	 (03PS2) 10Chad: Tighten up returns in LinksUpdateJob [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/123349 
[20:06:57] <MaxSem>	 renoirb, we improve cache hit rate by messing with cookies: http://git.wikimedia.org/blob/operations%2Fpuppet.git/4376ab705bee4f7ce04274fa9ab1d07381c38173/templates%2Fvarnish%2Ftext-common.inc.vcl.erb
[20:07:14] <renoirb>	 … oh! some VCL :)
[20:07:19] <sumanah>	 in about an hour, cscott will be asking for discussion on Square bounding boxes and Scoped language converter RfCs in #wikimedia-office. 
[20:07:50] <grrrit-wm>	 (03PS1) 10Hashar: Split puppetlint to lenient and strict jobs [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/123430 
[20:08:14] <renoirb>	 Should I consider importing this VCL in my Varnish config MaxSem, is that what you are suggesting?
[20:08:20] <grrrit-wm>	 (03PS2) 10Hashar: Split puppetlint to lenient and strict jobs [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/123430 
[20:08:47] <MaxSem>	 no, it's way too customized for our needs. but you can use bits and pieces from it
[20:09:03] <renoirb>	 I think this is Varnish 3…  I’m behind Fastly, they are Varnish/2.1
[20:09:30] <renoirb>	 But, thanks very much MaxSem!!
[20:09:43] <grrrit-wm>	 (03PS2) 10CSteipp: Move OAuth logs to another wiki [extensions/OAuth] - 10https://gerrit.wikimedia.org/r/122867 
[20:09:57] <grrrit-wm>	 (03PS1) 10Hashar: Split puppetlint to lenient and strict jobs [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/123432 
[20:10:30] <grrrit-wm>	 (03CR) 10Nemo bis: "Not in scope for bug, I suggest abandoning" [core] - 10https://gerrit.wikimedia.org/r/118656 (owner: 10Gerrit Patch Uploader)
[20:11:25] <grrrit-wm>	 (03CR) 10Hashar: [C: 032] "Matanya, that is yet another crazy idea. A job doing only error can be made a blocker whenever we manage to fix all the puppet-lint errors" [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/123430 (owner: 10Hashar)
[20:11:37] <grrrit-wm>	 (03CR) 10Hashar: [C: 032] Split puppetlint to lenient and strict jobs [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/123432 (owner: 10Hashar)
[20:11:43] <grrrit-wm>	 (03Merged) 10jenkins-bot: Split puppetlint to lenient and strict jobs [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/123432 (owner: 10Hashar)
[20:12:19] <grrrit-wm>	 (03Merged) 10jenkins-bot: Split puppetlint to lenient and strict jobs [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/123430 (owner: 10Hashar)
[20:13:05] <cscott>	 thanks, sumanah
[20:13:23] <grrrit-wm>	 (03PS4) 10Bsitu: Add summarize/close/open topic to history/contribution [extensions/Flow] - 10https://gerrit.wikimedia.org/r/123123 
[20:13:34] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] Add summarize/close/open topic to history/contribution [extensions/Flow] - 10https://gerrit.wikimedia.org/r/123123 (owner: 10Bsitu)
[20:17:59] <grrrit-wm>	 (03CR) 10Manybubbles: [C: 032] Tighten up returns in LinksUpdateJob [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/123349 (owner: 10Chad)
[20:21:18] <jackmcbarn>	 anomie: would it be possible/feasible/not cause any problems to be able to access unexpanded parameters from lua?
[20:22:44] <grrrit-wm>	 (03PS1) 10EBernhardson: Better memory reporting when running in HHVM [core] - 10https://gerrit.wikimedia.org/r/123436 
[20:23:48] <grrrit-wm>	 (03CR) 10UltrasonicNXT: "oh hello, looks like we need a rebase." [extensions/MediaWikiChat] - 10https://gerrit.wikimedia.org/r/122878 (owner: 10GeorgeBarnick)
[20:25:05] <anomie>	 jackmcbarn: The hard part is that you'd have to add a way to fetch the unexpanded parameter from the frame.
[20:25:07] <sumanah>	 TrevorParscal: Krinkle mooeypoo - cscott is discussing the Square bounding boxes RfC in #wikimedia-office in ~35 min and says:
[20:25:08] <sumanah>	 "Visual Editor and others would like to provide square bounding boxes for images and thumbnails, which existing wikitext syntax does not support consistently.  I hope to gather consensus around one of the four proposed solutions."
[20:25:18] <sumanah>	 thought you might want to know (cc James_F)
[20:26:21] <jackmcbarn>	 anomie: parameters aren't expanded right now until they're used in lua, right?
[20:26:45] <grrrit-wm>	 (03PS5) 10Bsitu: Add summarize/close/open topic to history/contribution [extensions/Flow] - 10https://gerrit.wikimedia.org/r/123123 
[20:26:56] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] Add summarize/close/open topic to history/contribution [extensions/Flow] - 10https://gerrit.wikimedia.org/r/123123 (owner: 10Bsitu)
[20:27:59] <grrrit-wm>	 (03PS4) 10Raimond Spekking: Implemented changes for getting into translatewiki [extensions/BlueSpiceFoundation] - 10https://gerrit.wikimedia.org/r/121684 (owner: 10Smuggli)
[20:28:13] <grrrit-wm>	 (03CR) 10Raimond Spekking: [C: 032 V: 032] Implemented changes for getting into translatewiki [extensions/BlueSpiceFoundation] - 10https://gerrit.wikimedia.org/r/121684 (owner: 10Smuggli)
[20:28:14] <anomie>	 jackmcbarn: The problem is PPFrame only has functions to get the expanded parameter(s)
[20:28:25] <anomie>	 So you'd need to add to PPFrame
[20:28:57] <jackmcbarn>	 hmm, ok
[20:29:11] <jackmcbarn>	 anomie: also, did you see the gerrit changes i linked you to earlier?
[20:30:30] <anomie>	 jackmcbarn: Haven't had a chance to look at them yet
[20:37:58] <grrrit-wm>	 (03PS2) 10CSteipp: Allow setting OAuth to Read Only [extensions/OAuth] - 10https://gerrit.wikimedia.org/r/123421 
[20:49:10] <grrrit-wm>	 (03CR) 10Mattflaschen: "Is this ready for review?" [extensions/GuidedTour] - 10https://gerrit.wikimedia.org/r/121585 (owner: 10Prtksxna)
[20:53:18] <grrrit-wm>	 (03CR) 10UltrasonicNXT: [C: 031] "Yeah, you've done right with the i18n, TWN will adjust the other languages." [extensions/MediaWikiChat] - 10https://gerrit.wikimedia.org/r/123425 (owner: 10GeorgeBarnick)
[20:53:48] <grrrit-wm>	 (03CR) 10UltrasonicNXT: "I'm going to bump the version number up though, please do do this when you make changes!" [extensions/MediaWikiChat] - 10https://gerrit.wikimedia.org/r/123425 (owner: 10GeorgeBarnick)
[20:54:51] <grrrit-wm>	 (03PS2) 10UltrasonicNXT: Changing audio/ directory to assets/ [extensions/MediaWikiChat] - 10https://gerrit.wikimedia.org/r/123425 (owner: 10GeorgeBarnick)
[20:55:38] <grrrit-wm>	 (03CR) 10UltrasonicNXT: [C: 032 V: 032] Changing audio/ directory to assets/ [extensions/MediaWikiChat] - 10https://gerrit.wikimedia.org/r/123425 (owner: 10GeorgeBarnick)
[20:59:17] <grrrit-wm>	 (03CR) 10GeorgeBarnick: "I meant to up the version number. I was going to do that and had remembered it needed to be done before I started editing the files and I " [extensions/MediaWikiChat] - 10https://gerrit.wikimedia.org/r/123425 (owner: 10GeorgeBarnick)
[21:06:15] <sumanah>	 Nikerabbit: siebrand Nemo_bis - got any opinions on language converter stuff (being discussed in #wikimedia-office right now)?
[21:12:11] <grrrit-wm>	 (03PS1) 10Chad: LinksUpdateSecondary: Avoid pointless extra iteration and return clearly [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/123443 
[21:13:20] <grrrit-wm>	 (03CR) 10Chad: "This has every job returning sane values except MassIndexJob" [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/123443 (owner: 10Chad)
[21:17:46] <grrrit-wm>	 (03CR) 10Manybubbles: [C: 032] LinksUpdateSecondary: Avoid pointless extra iteration and return clearly [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/123443 (owner: 10Chad)
[21:19:54] <^d>	 manybubbles: If you merge the freshness removal that whole chain can go in :p
[21:20:10] <grrrit-wm>	 (03CR) 10Mattflaschen: [C: 032] "The language links are not in the form, so there's no difference there." [core] - 10https://gerrit.wikimedia.org/r/121842 (owner: 10Bartosz Dziewoński)
[21:20:38] <grrrit-wm>	 (03CR) 10Manybubbles: [C: 032] Remove freshness checks, always insert documents [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/123038 (owner: 10Chad)
[21:20:44] <Nemo_bis>	 sumanah: no; that's Liangent's kingdom (and I have no idea what square boxes and the like are)
[21:20:45] <manybubbles>	 I thought i did that....
[21:21:08] <grrrit-wm>	 (03Merged) 10jenkins-bot: Remove freshness checks, always insert documents [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/123038 (owner: 10Chad)
[21:21:16] <grrrit-wm>	 (03Merged) 10jenkins-bot: Tighten up returns in LinksUpdateJob [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/123349 (owner: 10Chad)
[21:21:21] <grrrit-wm>	 (03Merged) 10jenkins-bot: LinksUpdateSecondary: Avoid pointless extra iteration and return clearly [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/123443 (owner: 10Chad)
[21:21:29] <^d>	 wheeee
[21:21:35] <^d>	 go go gadget merges!
[21:23:04] <Nemo_bis>	 ^d: when can we have intewiki search on it.wiki? :)
[21:23:31] <grrrit-wm>	 (03Merged) 10jenkins-bot: mediawiki.ui: Do not depend on divs being present inside .mw-ui-vform [core] - 10https://gerrit.wikimedia.org/r/121842 (owner: 10Bartosz Dziewoński)
[21:23:31] <^d>	 Hmm, good question
[21:23:53] <Nemo_bis>	 Is it controlled by a global or what
[21:24:15] <^d>	 Yeah, $wgCirrusSearchInterwikiSomething
[21:24:18] <Nemo_bis>	 Because I'm quite sure nobody cares on it.wiki if it's ugly
[21:24:35] <^d>	 $wgCirrusSearchInterwikiSources
[21:25:00] <grrrit-wm>	 (03PS3) 10CSteipp: Allow setting OAuth to Read Only [extensions/OAuth] - 10https://gerrit.wikimedia.org/r/123421 
[21:25:05] <Nemo_bis>	 So I should file a bug? The village pump discussion basically gave you guys carte blanche on cirrus tests
[21:26:37] <^d>	 I'd want to make sure my last round of patches are all live.
[21:26:49] <grrrit-wm>	 (03CR) 10Mattflaschen: [C: 04-1] "mediawiki.ui.button (button styling for mediawiki.ui) is now a separate module. Since you're using MW UI buttons (e.g. 'mw-ui-button mw-u" [core] - 10https://gerrit.wikimedia.org/r/121975 (owner: 10Ganeshaditya1)
[21:26:50] <^d>	 :)
[21:27:04] <Nemo_bis>	 The merged ones or even more? :)
[21:27:10] <^d>	 The merged ones.
[21:27:20] <^d>	 I fixed a bunch of IW stuff last week.
[21:27:56] <Nemo_bis>	 Right, only one open and it's not about iw
[21:28:50] <^d>	 :)
[21:31:46] * Nemo_bis  caught up on recent merges

[21:32:13] <sumanah>	 ok, now discussing thumbnails and https://www.mediawiki.org/wiki/Requests_for_comment/Square_bounding_boxes in #wikimedia-office
[21:32:53] <sumanah>	 RoanKattouw_away: TrevorP|Away James_F mooeypoo Krinkle ^ evidently this is VE-related
[21:33:03] <mooeypoo>	 yup
[21:33:09] <mooeypoo>	 sumanah, thanks :)
[21:33:12] <sumanah>	 thanks
[21:35:33] <Nemo_bis>	 ^d: so, all those changes will be deployed tomorrow on Wikipedias; if that's enough for you to test please go ahead, otherwise let me know what's needed and I'll open local discussions/bugs/whatever
[21:35:54] <^d>	 Lemme think about it :)
[21:36:06] <Nemo_bis>	 Sure, no need to answer right now
[21:36:28] <Nemo_bis>	 The performance fix was a good catch, that should save a lot of possible headaches
[21:37:50] <^d>	 Nemo_bis: Heh, which change? I wrote a lot of changes in the last week :p
[21:39:51] <grrrit-wm>	 (03PS1) 10EBernhardson: PHPUnit mock builder doesnt except leading \\ [extensions/Thanks] - 10https://gerrit.wikimedia.org/r/123451 
[21:41:31] <grrrit-wm>	 (03PS1) 10Jforrester: Update OOjs to v1.0.9 [core] - 10https://gerrit.wikimedia.org/r/123452 
[21:41:37] <AaronSchulz>	 csteipp: can you make those MWException instead of Exception?
[21:41:59] <csteipp>	 Yeah, one sec...
[21:42:01] <AaronSchulz>	 https://gerrit.wikimedia.org/r/#/c/123421/2..3/backend/MWOAuthDAO.php
[21:42:12] <AaronSchulz>	 csteipp: also maybe use daoReadOnly as the field
[21:43:26] <Nemo_bis>	 ^d: I mean the hardcoded limit to 10 interwiki search results :)
[21:43:28] <grrrit-wm>	 (03PS2) 10EBernhardson: PHPUnit mock builder doesnt accept leading \\ [extensions/Thanks] - 10https://gerrit.wikimedia.org/r/123451 
[21:43:39] <grrrit-wm>	 (03PS3) 10EBernhardson: PHPUnit mock builder doesnt accept leading \ [extensions/Thanks] - 10https://gerrit.wikimedia.org/r/123451 
[21:43:48] <Nemo_bis>	 Though that's surely not the most important of those patches :)
[21:44:14] <^d>	 Nemo_bis: Actually I lowered it to 5 :p
[21:44:42] <Nemo_bis>	 Whatever :)
[21:45:13] <AaronSchulz>	 ^d: https://gerrit.wikimedia.org/r/#/c/123041/
[21:45:25] <grrrit-wm>	 (03PS5) 10EBernhardson: Standardize URL generation [extensions/Flow] - 10https://gerrit.wikimedia.org/r/121855 
[21:45:35] <AaronSchulz>	 I still need to do the php mc one...but that's a messier :)
[21:45:35] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] Standardize URL generation [extensions/Flow] - 10https://gerrit.wikimedia.org/r/121855 (owner: 10EBernhardson)
[21:45:46] <grrrit-wm>	 (03PS3) 10CSteipp: Move OAuth logs to another wiki [extensions/OAuth] - 10https://gerrit.wikimedia.org/r/122867 
[21:45:56] <grrrit-wm>	 (03PS13) 10Ori.livneh: Visualize profile output in debug toolbar [core] - 10https://gerrit.wikimedia.org/r/104318 (owner: 10EBernhardson)
[21:47:01] <grrrit-wm>	 (03CR) 10Chad: [C: 032] Made BagOStuff fail fast in cas/lock on certain errors [core] - 10https://gerrit.wikimedia.org/r/123041 (owner: 10Aaron Schulz)
[21:47:43] <ebernhardson>	 What can i do about jenkins tests crashing?  Other patches go through just fine but this one always gets "UNSTABLE" from phpunit: https://integration.wikimedia.org/ci/job/mwext-Flow-testextensions-master/3528/console
[21:47:55] <grrrit-wm>	 (03PS4) 10CSteipp: Allow setting OAuth to Read Only [extensions/OAuth] - 10https://gerrit.wikimedia.org/r/123421 
[21:49:26] <grrrit-wm>	 (03PS10) 10Ganeshaditya1: ChangeEmail special page rewritten to use vforms. [core] - 10https://gerrit.wikimedia.org/r/121975 
[21:50:29] <grrrit-wm>	 (03Merged) 10jenkins-bot: Made BagOStuff fail fast in cas/lock on certain errors [core] - 10https://gerrit.wikimedia.org/r/123041 (owner: 10Aaron Schulz)
[21:50:38] <grrrit-wm>	 (03CR) 10Ganeshaditya1: "I am sorry I was not aware of the change." [core] - 10https://gerrit.wikimedia.org/r/121975 (owner: 10Ganeshaditya1)
[21:51:43] <grrrit-wm>	 (03CR) 10Aaron Schulz: [C: 032] Allow setting OAuth to Read Only [extensions/OAuth] - 10https://gerrit.wikimedia.org/r/123421 (owner: 10CSteipp)
[21:51:50] <grrrit-wm>	 (03Merged) 10jenkins-bot: Allow setting OAuth to Read Only [extensions/OAuth] - 10https://gerrit.wikimedia.org/r/123421 (owner: 10CSteipp)
[21:53:10] <grrrit-wm>	 (03PS1) 10MaxSem: Cherry-pick I550eb4b0a8fa18344e8b0de3ec85d61c2122ffb8 [core] (wmf/1.23wmf20) - 10https://gerrit.wikimedia.org/r/123454 
[21:53:47] <grrrit-wm>	 (03CR) 10TheDJ: "Eh where was that comment originally ????" [core] - 10https://gerrit.wikimedia.org/r/122566 (owner: 10TheDJ)
[21:53:53] <grrrit-wm>	 (03PS14) 10Ori.livneh: Visualize profile output in debug toolbar [core] - 10https://gerrit.wikimedia.org/r/104318 (owner: 10EBernhardson)
[21:53:57] <grrrit-wm>	 (03CR) 10Ori.livneh: [C: 032] Visualize profile output in debug toolbar [core] - 10https://gerrit.wikimedia.org/r/104318 (owner: 10EBernhardson)
[21:55:39] <grrrit-wm>	 (03CR) 10Mattflaschen: [C: 04-1] "Doesn't work. !$title->getNamespace() binds first, so it's comparing a boolean to the category (if it did work, it would be a double nega" [extensions/GettingStarted] - 10https://gerrit.wikimedia.org/r/122856 (owner: 10Phuedx)
[21:58:15] <grrrit-wm>	 (03PS1) 10Aaron Schulz: Tiny SQLite fix [extensions/OAuth] - 10https://gerrit.wikimedia.org/r/123456 
[21:58:23] <AaronSchulz>	 csteipp: ;)
[21:58:54] <grrrit-wm>	 (03Merged) 10jenkins-bot: Visualize profile output in debug toolbar [core] - 10https://gerrit.wikimedia.org/r/104318 (owner: 10EBernhardson)
[21:59:15] <hoo>	 AaronSchulz: Really something with mysql in the path is being used for SQLite? Sounds legit and sane
[21:59:50] <AaronSchulz>	 no, just me reusing the file in sql.php
[22:00:08] <AaronSchulz>	 though usually the sqlite stuff in the updater falls back to the mysql files (after some munging)
[22:00:37] <AaronSchulz>	 for core
[22:00:40] <csteipp>	 Aaron just wanted patch 123456 :)
[22:00:55] <grrrit-wm>	 (03CR) 10Hoo man: [C: 032] "123456 \o/" [extensions/OAuth] - 10https://gerrit.wikimedia.org/r/123456 (owner: 10Aaron Schulz)
[22:00:59] <AaronSchulz>	 I wait I got it, haha
[22:01:03] <grrrit-wm>	 (03Merged) 10jenkins-bot: Tiny SQLite fix [extensions/OAuth] - 10https://gerrit.wikimedia.org/r/123456 (owner: 10Aaron Schulz)
[22:01:04] <hoo>	 csteipp: Oh, nice :D
[22:01:11] <AaronSchulz>	 I wasn't even thinking about that
[22:01:15] <grrrit-wm>	 (03PS1) 10Ori.livneh: eventlogging-reporter: use metric type and aggregate [extensions/EventLogging] - 10https://gerrit.wikimedia.org/r/123457 
[22:01:21] <marktraceur>	 \o/
[22:01:23] * AaronSchulz  nevers gets the fun numbers

[22:01:28] <hoo>	 :D
[22:01:29] <AaronSchulz>	 this is quite unusual
[22:01:30] <marktraceur>	 That's because robots ruin everyone's fun
[22:01:34] * hoo  is user 1 on Wikidata :D

[22:01:52] <marktraceur>	 Most powers of 2 and 10 on bugzilla or gerrit are pretty mundane
[22:02:10] <marktraceur>	 And multiples of 10,000 as well
[22:02:18] <grrrit-wm>	 (03CR) 10Ori.livneh: [C: 04-1] Better memory reporting when running in HHVM (031 comment) [core] - 10https://gerrit.wikimedia.org/r/123436 (owner: 10EBernhardson)
[22:02:59] <grrrit-wm>	 (03CR) 10Ori.livneh: [C: 032] eventlogging-reporter: use metric type and aggregate [extensions/EventLogging] - 10https://gerrit.wikimedia.org/r/123457 (owner: 10Ori.livneh)
[22:03:25] <grrrit-wm>	 (03Merged) 10jenkins-bot: eventlogging-reporter: use metric type and aggregate [extensions/EventLogging] - 10https://gerrit.wikimedia.org/r/123457 (owner: 10Ori.livneh)
[22:03:43] <grrrit-wm>	 (03PS2) 10EBernhardson: Better memory reporting when running in HHVM [core] - 10https://gerrit.wikimedia.org/r/123436 
[22:03:50] <grrrit-wm>	 (03CR) 10EBernhardson: Better memory reporting when running in HHVM (031 comment) [core] - 10https://gerrit.wikimedia.org/r/123436 (owner: 10EBernhardson)
[22:04:33] <grrrit-wm>	 (03PS3) 10Ori.livneh: Better memory reporting when running in HHVM [core] - 10https://gerrit.wikimedia.org/r/123436 (owner: 10EBernhardson)
[22:04:39] <grrrit-wm>	 (03CR) 10Ori.livneh: [C: 032] Better memory reporting when running in HHVM [core] - 10https://gerrit.wikimedia.org/r/123436 (owner: 10EBernhardson)
[22:09:03] <grrrit-wm>	 (03Merged) 10jenkins-bot: Better memory reporting when running in HHVM [core] - 10https://gerrit.wikimedia.org/r/123436 (owner: 10EBernhardson)
[22:10:01] <grrrit-wm>	 (03PS6) 10EBernhardson: Standardize URL generation [extensions/Flow] - 10https://gerrit.wikimedia.org/r/121855 
[22:11:29] <grrrit-wm>	 (03CR) 10MaxSem: "Guys, do you have any concerns left?" [core] - 10https://gerrit.wikimedia.org/r/123118 (owner: 10MaxSem)
[22:11:51] <grrrit-wm>	 (03CR) 10Mattflaschen: "Also, apparently we're supposed to use Title->inNamespace for this to be future-proof, though I suspect the future is still going to be pr" [extensions/GettingStarted] - 10https://gerrit.wikimedia.org/r/122856 (owner: 10Phuedx)
[22:16:17] <grrrit-wm>	 (03PS6) 10Bsitu: Add summarize/close/open topic to history/contribution [extensions/Flow] - 10https://gerrit.wikimedia.org/r/123123 
[22:16:30] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] Add summarize/close/open topic to history/contribution [extensions/Flow] - 10https://gerrit.wikimedia.org/r/123123 (owner: 10Bsitu)
[22:17:40] <ebernhardson>	 woo, profiler visualizations :)
[22:17:51] <grrrit-wm>	 (03PS4) 10CSteipp: Move OAuth logs to another wiki [extensions/OAuth] - 10https://gerrit.wikimedia.org/r/122867 
[22:29:50] <Krinkle>	 spagewmf: marktraceur: btw, if you're interested in some doc stuff today. Let me know :)
[22:32:25] <grrrit-wm>	 (03PS19) 10Bsitu: Update post/header revision storage search key [extensions/Flow] - 10https://gerrit.wikimedia.org/r/117099 
[22:33:00] <marktraceur>	 Krinkle: Decided to focus on other stuff
[22:33:07] <Krinkle>	 np
[22:33:38] <grrrit-wm>	 (03CR) 10Bsitu: [C: 04-2] "Don't merge till we run maintenance to update old records" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/117099 (owner: 10Bsitu)
[22:33:52] <grrrit-wm>	 (03CR) 10Aaron Schulz: Move OAuth logs to another wiki (039 comments) [extensions/OAuth] - 10https://gerrit.wikimedia.org/r/122867 (owner: 10CSteipp)
[22:34:15] <AaronSchulz>	 csteipp: https://gerrit.wikimedia.org/r/#/c/122867/3..4/maintenance/importCentralWikiLogs.php
[22:34:27] <AaronSchulz>	 pushed while I was looking at 3
[22:38:09] <grrrit-wm>	 (03CR) 10Aaron Schulz: Move OAuth logs to another wiki (032 comments) [extensions/OAuth] - 10https://gerrit.wikimedia.org/r/122867 (owner: 10CSteipp)
[22:38:29] <grrrit-wm>	 (03PS1) 10Jack Phoenix: Fix message parsing on Special:EditProfile/Special:UpdateProfile + fix all CSS loading calls to use addModuleStyles() instead of addModules() to prevent a flash of unstyled content. [extensions/SocialProfile] - 10https://gerrit.wikimedia.org/r/123468 
[22:55:05] <grrrit-wm>	 (03PS1) 10Bsitu: Remove unused class variable $dbFactory [extensions/Flow] - 10https://gerrit.wikimedia.org/r/123470 
[23:22:39] <grrrit-wm>	 (03PS15) 10Krinkle: mediawiki.api: Refactor getToken and postWithToken methods [core] - 10https://gerrit.wikimedia.org/r/111636 
[23:23:52] <Krinkle>	 marktraceur: https://gerrit.wikimedia.org/r/#/c/111636/
[23:35:40] <grrrit-wm>	 (03PS1) 10Spage: Adapt signup form numbers to new Vector typography [core] - 10https://gerrit.wikimedia.org/r/123478 
[23:37:27] <grrrit-wm>	 (03PS3) 10Adamw: Adds an --extension option to generateJsonI18n [core] - 10https://gerrit.wikimedia.org/r/122659 
[23:38:00] <grrrit-wm>	 (03PS3) 10Adamw: Add --supplementary flag to generateJsonI18n [core] - 10https://gerrit.wikimedia.org/r/122664 
[23:41:20] <grrrit-wm>	 (03CR) 10Mwalker: [C: 032] Cherry-pick I550eb4b0a8fa18344e8b0de3ec85d61c2122ffb8 [core] (wmf/1.23wmf20) - 10https://gerrit.wikimedia.org/r/123454 (owner: 10MaxSem)
[23:45:27] <grrrit-wm>	 (03CR) 10Swalling: [C: 031] "LGTM in Chrome and Firefox, definitely fixes bug." [core] - 10https://gerrit.wikimedia.org/r/123478 (owner: 10Spage)
[23:45:56] <StevenW>	 superm401 or jdlrobson ^ review appreciated
[23:47:20] <superm401>	 StevenW, on it
[23:47:20] <grrrit-wm>	 (03CR) 10Spage: "This is a minimal quick fix change. If the file were converted to LESS it could @import "../../skins/vector/variables" to access @content-" [core] - 10https://gerrit.wikimedia.org/r/123478 (owner: 10Spage)
[23:47:22] <StevenW>	 Thx
[23:51:48] <spagewmf>	 AaronSchulz  wins the internets with gerrit 123456 :)
[23:53:19] <greg-g>	 :)
[23:53:43] <superm401>	 spagewmf, I was wondering why we were overriding it if it's the same.  FIgured it out though.
[23:53:52] <superm401>	 h3 is not covered by the new heading font.
[23:53:53] <grrrit-wm>	 (03PS25) 10Bsitu: Add topic summary revision type [extensions/Flow] - 10https://gerrit.wikimedia.org/r/117357 
[23:54:22] <superm401>	 But h3 and h4 are bolded now.
[23:55:30] <spagewmf>	 superm401: yup, semantics vs. styling :)  Perhaps the two font stacks should be in resources/mediawiki.less for easy access
[23:56:20] <superm401>	 spagewmf, I assume the content h3's are not serif since they're pretty small.  That doesn't apply to the benefits ones, though.
[23:58:29] <grrrit-wm>	 (03PS3) 10BryanDavis: Delete UIDGenerator cache files after unit tests [core] - 10https://gerrit.wikimedia.org/r/121548