[00:04:01] (03PS1) 10Brian Wolff: Follow-up I7d4bb90: Message tweak + add code comment [core] - 10https://gerrit.wikimedia.org/r/122271 [00:12:34] (03CR) 10Alex Monk: [C: 04-1] "Needs message docs" (031 comment) [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/122242 (owner: 10TyA) [00:26:31] (03PS1) 10Brian Wolff: Fix starttime <= endtime comparision [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/122273 [00:36:46] (03PS4) 10TyA: Log CentralAuth account detachments [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/122242 [00:44:06] (03CR) 10Swalling: ChangeEmail special page rewritten to use vforms. (032 comments) [core] - 10https://gerrit.wikimedia.org/r/121975 (owner: 10Ganeshaditya1) [01:10:14] [02:27:04] (03CR) 10Luis Felipe Schenone: [C: 031] "Tested the code to see if it fixes bug 63233, and it does!" [core] - 10https://gerrit.wikimedia.org/r/121842 (owner: 10Bartosz Dziewoński) [02:41:01] (03Abandoned) 10Luis Felipe Schenone: Changed
for
[core] - 10https://gerrit.wikimedia.org/r/121292 (owner: 10Luis Felipe Schenone) [02:54:42] (03CR) 10BryanDavis: [C: 04-1] "I think this looks pretty good, but there are a few small issues that need to be addressed before we can merge it." (031 comment) [wikimedia/wikimania-scholarships] - 10https://gerrit.wikimedia.org/r/122123 (owner: 10Kushal124) [04:34:29] (03CR) 10Mdale: "mwEmbedStandAlone became is the upstream mwEmbed project / Kaltura HTML5 player." [extensions/MwEmbedSupport] - 10https://gerrit.wikimedia.org/r/121950 (owner: 10Siebrand) [04:35:23] (03CR) 10Faidon Liambotis: [C: 031] "+1 on the intention and the 15s timeout (although 30s would also be fine IMHO). No comment on the code itself." [core] - 10https://gerrit.wikimedia.org/r/121912 (owner: 10Brian Wolff) [04:40:25] (03CR) 10Mdale: [C: 032 V: 032] "looks good, thanks Brian." [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/122273 (owner: 10Brian Wolff) [04:46:26] (03PS1) 10Santhosh: Whitespace, code formatting cleanup [services/cxserver] - 10https://gerrit.wikimedia.org/r/122276 [04:51:47] (03PS1) 10Gnosygnu: v1.3.5.1 [xowa] - 10https://gerrit.wikimedia.org/r/122278 [04:54:44] (03CR) 10Gnosygnu: [C: 032 V: 032] "approving own release" [xowa] - 10https://gerrit.wikimedia.org/r/122278 (owner: 10Gnosygnu) [05:01:09] (03PS1) 10Legoktm: Add user_rights variable [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/122279 [05:02:49] for a moment legoktm I thought that was a really old change since there's already user_groups [05:02:55] until I actually read the commit message xD [05:02:58] :P [05:13:33] (03PS1) 10Hiong3-eng5: Document generator [extensions/WikiLexicalData] - 10https://gerrit.wikimedia.org/r/122280 [05:16:38] (03CR) 10Nikerabbit: [C: 032] Migrate to JSON i18n [extensions/ArticleFeedbackv5] - 10https://gerrit.wikimedia.org/r/122243 (owner: 10Siebrand) [05:16:42] (03Merged) 10jenkins-bot: Migrate to JSON i18n [extensions/ArticleFeedbackv5] - 10https://gerrit.wikimedia.org/r/122243 (owner: 10Siebrand) [05:17:22] (03CR) 10Nikerabbit: [C: 032] Migrate to JSON i18n [extensions/BookManagerv2] - 10https://gerrit.wikimedia.org/r/122257 (owner: 10Siebrand) [05:17:25] (03Merged) 10jenkins-bot: Migrate to JSON i18n [extensions/BookManagerv2] - 10https://gerrit.wikimedia.org/r/122257 (owner: 10Siebrand) [05:17:35] (03CR) 10Hiong3-eng5: "I may send patches until Friday, so any suggestions on how to improve this must be given before then." [extensions/WikiLexicalData] - 10https://gerrit.wikimedia.org/r/122280 (owner: 10Hiong3-eng5) [05:18:06] (03CR) 10Nikerabbit: [C: 032] Migrate to JSON i18n [extensions/CategoryTagSorter] - 10https://gerrit.wikimedia.org/r/122262 (owner: 10Siebrand) [05:18:12] (03Merged) 10jenkins-bot: Migrate to JSON i18n [extensions/CategoryTagSorter] - 10https://gerrit.wikimedia.org/r/122262 (owner: 10Siebrand) [05:18:30] (03CR) 10Nikerabbit: [C: 032] Migrate to JSON i18n [extensions/AutomaticBoardWelcome] - 10https://gerrit.wikimedia.org/r/122247 (owner: 10Siebrand) [05:24:29] (03CR) 10Bsitu: [C: 031] Refactor Flow\\Formatter namespace [extensions/Flow] - 10https://gerrit.wikimedia.org/r/117384 (owner: 10EBernhardson) [05:32:59] (03CR) 10Nikerabbit: [V: 032] Migrate to JSON i18n [extensions/AutomaticBoardWelcome] - 10https://gerrit.wikimedia.org/r/122247 (owner: 10Siebrand) [05:37:27] (03CR) 10Nikerabbit: [C: 032 V: 032] Migrate to JSON i18n [extensions/AbsenteeLandlord] - 10https://gerrit.wikimedia.org/r/122225 (owner: 10Siebrand) [05:37:49] (03CR) 10Nikerabbit: [C: 032 V: 032] Migrate to JSON i18n [extensions/AccessControl] - 10https://gerrit.wikimedia.org/r/122226 (owner: 10Siebrand) [05:38:11] (03CR) 10Nikerabbit: [C: 032 V: 032] Migrate to JSON i18n [extensions/AccountInfo] - 10https://gerrit.wikimedia.org/r/122227 (owner: 10Siebrand) [05:38:49] (03CR) 10Nikerabbit: [C: 032 V: 032] Migrate to JSON i18n [extensions/AddThis] - 10https://gerrit.wikimedia.org/r/122228 (owner: 10Siebrand) [05:39:43] (03CR) 10Nikerabbit: [C: 04-1] Migrate to JSON i18n (031 comment) [extensions/AdManager] - 10https://gerrit.wikimedia.org/r/122229 (owner: 10Siebrand) [05:40:38] (03CR) 10Nikerabbit: [C: 032 V: 032] Migrate to JSON i18n [extensions/Ads] - 10https://gerrit.wikimedia.org/r/122230 (owner: 10Siebrand) [05:41:23] (03CR) 10Nikerabbit: [C: 04-1] Migrate to JSON i18n (031 comment) [extensions/AJAXPoll] - 10https://gerrit.wikimedia.org/r/122232 (owner: 10Siebrand) [05:41:43] (03CR) 10Nikerabbit: [C: 032 V: 032] Migrate to JSON i18n [extensions/AkismetKlik] - 10https://gerrit.wikimedia.org/r/122233 (owner: 10Siebrand) [05:42:26] (03CR) 10Nikerabbit: Migrate to JSON i18n (031 comment) [extensions/AllTimeZones] - 10https://gerrit.wikimedia.org/r/122234 (owner: 10Siebrand) [05:42:39] (03CR) 10Grunny: [C: 032] Migrate to JSON i18n [extensions/ApiExplorer] - 10https://gerrit.wikimedia.org/r/122236 (owner: 10Siebrand) [05:43:20] (03CR) 10Grunny: [V: 032] Migrate to JSON i18n [extensions/ApiExplorer] - 10https://gerrit.wikimedia.org/r/122236 (owner: 10Siebrand) [05:44:12] (03CR) 10Nikerabbit: [C: 032 V: 032] Migrate to JSON i18n [extensions/ApiSVGProxy] - 10https://gerrit.wikimedia.org/r/122237 (owner: 10Siebrand) [05:44:52] (03CR) 10Nikerabbit: [C: 032 V: 032] Migrate to JSON i18n [extensions/ArticleCreationWorkflow] - 10https://gerrit.wikimedia.org/r/122240 (owner: 10Siebrand) [05:45:57] (03CR) 10Nikerabbit: Migrate to JSON i18n (031 comment) [extensions/ArticleFeedback] - 10https://gerrit.wikimedia.org/r/122241 (owner: 10Siebrand) [05:46:17] (03CR) 10Nikerabbit: [C: 032 V: 032] Migrate to JSON i18n [extensions/AssertEdit] - 10https://gerrit.wikimedia.org/r/122244 (owner: 10Siebrand) [05:46:40] (03CR) 10Nikerabbit: [C: 032 V: 032] Migrate to JSON i18n [extensions/AuthorProtect] - 10https://gerrit.wikimedia.org/r/122245 (owner: 10Siebrand) [05:47:30] (03CR) 10Nikerabbit: [C: 032 V: 032] Migrate to JSON i18n [extensions/AutoCreateCategoryPages] - 10https://gerrit.wikimedia.org/r/122246 (owner: 10Siebrand) [05:47:59] (03CR) 10Nikerabbit: [C: 032 V: 032] Migrate to JSON i18n [extensions/AutoProxyBlock] - 10https://gerrit.wikimedia.org/r/122248 (owner: 10Siebrand) [05:48:28] (03CR) 10Nikerabbit: [C: 032 V: 032] Migrate to JSON i18n [extensions/AWS] - 10https://gerrit.wikimedia.org/r/122249 (owner: 10Siebrand) [05:48:44] (03CR) 10Nikerabbit: [C: 032 V: 032] Migrate to JSON i18n [extensions/AWSSDK] - 10https://gerrit.wikimedia.org/r/122250 (owner: 10Siebrand) [05:49:12] (03CR) 10Nikerabbit: [C: 032 V: 032] Migrate to JSON i18n [extensions/BayesianFilter] - 10https://gerrit.wikimedia.org/r/122251 (owner: 10Siebrand) [05:50:05] (03CR) 10Nikerabbit: [C: 032 V: 032] Migrate to JSON i18n [extensions/BiblioPlus] - 10https://gerrit.wikimedia.org/r/122252 (owner: 10Siebrand) [05:50:52] (03CR) 10Nikerabbit: [C: 032 V: 032] Migrate to JSON i18n [extensions/BibManager] - 10https://gerrit.wikimedia.org/r/122253 (owner: 10Siebrand) [05:51:19] (03CR) 10Nikerabbit: [C: 032 V: 032] Migrate to JSON i18n [extensions/Blackout] - 10https://gerrit.wikimedia.org/r/122254 (owner: 10Siebrand) [05:51:49] (03CR) 10Nikerabbit: [C: 032 V: 032] Migrate to JSON i18n [extensions/BlockAndNuke] - 10https://gerrit.wikimedia.org/r/122255 (owner: 10Siebrand) [05:52:22] (03CR) 10Nikerabbit: [C: 032 V: 032] Migrate to JSON i18n [extensions/BlogPage] - 10https://gerrit.wikimedia.org/r/122256 (owner: 10Siebrand) [05:53:29] (03PS1) 10Faidon Liambotis: Revert "Categorize pages containing blacklisted links" [extensions/SpamBlacklist] - 10https://gerrit.wikimedia.org/r/122283 [05:53:30] (03CR) 10jenkins-bot: [V: 04-1] Revert "Categorize pages containing blacklisted links" [extensions/SpamBlacklist] - 10https://gerrit.wikimedia.org/r/122283 (owner: 10Faidon Liambotis) [05:53:39] (03CR) 10Nikerabbit: Migrate to JSON i18n (032 comments) [extensions/Bootstrap] - 10https://gerrit.wikimedia.org/r/122258 (owner: 10Siebrand) [05:53:51] (03CR) 10Faidon Liambotis: "recheck" [extensions/SpamBlacklist] - 10https://gerrit.wikimedia.org/r/122283 (owner: 10Faidon Liambotis) [05:53:59] oh jenkins... [05:54:11] ah, no, it's unable to rebase [05:54:11] (03CR) 10Nikerabbit: [C: 032 V: 032] Migrate to JSON i18n [extensions/BreadCrumbs] - 10https://gerrit.wikimedia.org/r/122259 (owner: 10Siebrand) [05:54:50] (03CR) 10Nikerabbit: [C: 032 V: 032] Migrate to JSON i18n [extensions/Carp] - 10https://gerrit.wikimedia.org/r/122260 (owner: 10Siebrand) [05:55:15] (03CR) 10Nikerabbit: [C: 032 V: 032] Migrate to JSON i18n [extensions/CategorySortHeaders] - 10https://gerrit.wikimedia.org/r/122261 (owner: 10Siebrand) [05:55:35] grumble [05:55:37] i18n changes [05:55:42] (03CR) 10Nikerabbit: [C: 032 V: 032] Migrate to JSON i18n [extensions/CategoryTests] - 10https://gerrit.wikimedia.org/r/122263 (owner: 10Siebrand) [05:56:16] (03CR) 10Nikerabbit: [C: 032 V: 032] Migrate to JSON i18n [extensions/CharRangeSpan] - 10https://gerrit.wikimedia.org/r/122264 (owner: 10Siebrand) [05:56:34] (03CR) 10Nikerabbit: [C: 032 V: 032] Migrate to JSON i18n [extensions/Checkpoint] - 10https://gerrit.wikimedia.org/r/122265 (owner: 10Siebrand) [05:57:35] (03CR) 10Nikerabbit: [C: 032] Migrate to JSON i18n [extensions/Agora] - 10https://gerrit.wikimedia.org/r/122231 (owner: 10Siebrand) [05:57:37] (03CR) 10jenkins-bot: [V: 04-1] Migrate to JSON i18n [extensions/Agora] - 10https://gerrit.wikimedia.org/r/122231 (owner: 10Siebrand) [05:57:56] (03CR) 10Nikerabbit: [C: 032] Migrate to JSON i18n [extensions/Annotator] - 10https://gerrit.wikimedia.org/r/122235 (owner: 10Siebrand) [05:57:58] (03CR) 10jenkins-bot: [V: 04-1] Migrate to JSON i18n [extensions/Annotator] - 10https://gerrit.wikimedia.org/r/122235 (owner: 10Siebrand) [05:58:15] so [05:58:25] should I just remove the message across all languages? [05:58:31] (03CR) 10Nikerabbit: [C: 032] Migrate to JSON i18n [extensions/Arrays] - 10https://gerrit.wikimedia.org/r/122239 (owner: 10Siebrand) [05:58:34] now that I'm reverting the feature? [05:58:37] (03CR) 10jenkins-bot: [V: 04-1] Migrate to JSON i18n [extensions/Arrays] - 10https://gerrit.wikimedia.org/r/122239 (owner: 10Siebrand) [05:58:40] sounds... noisy? [05:58:42] i don't know, actually [05:58:50] Nikerabbit: what's the right thing to do in these cases? [05:59:05] ori: removing in English is enouh [05:59:07] $ grep -rl spam-blacklisted-category i18n/ | wc -l [05:59:07] 26 [05:59:23] on next (full) export, the message will be removed from other languages as well [05:59:53] Nikerabbit: but what if the patch is re-reverted (and the feature restored)? Would the translations be lost? [06:00:21] ori: the translation done at translatewiki.net are not purged, so if the same message is reused, the translation will come back as well [06:00:46] translations* [06:00:56] cool, that's useful [06:02:03] (03PS2) 10Faidon Liambotis: Revert "Categorize pages containing blacklisted links" [extensions/SpamBlacklist] - 10https://gerrit.wikimedia.org/r/122283 [06:02:35] Nikerabbit: the automatically generated json lack a trailing newline [06:03:43] hmm I see [06:04:01] oh god, what a backporting hell [06:04:09] that needs to be fixed in Translate as well [06:04:51] Nikerabbit: removing a string from qqq.json while leaving it in e.g. fr.json is okay though, right? [06:05:17] paravoid: qqq is just like any other language in that regard [06:05:23] okay [06:05:42] sorry, I'm not very familiar with our i18n framework and I got caught in the midst of a migration apaprently :) [06:05:47] *apparently [06:06:43] paravoid: yup, sorry about that [06:07:05] (03PS3) 10Faidon Liambotis: Revert "Categorize pages containing blacklisted links" [extensions/SpamBlacklist] - 10https://gerrit.wikimedia.org/r/122283 [06:08:03] (03CR) 10Faidon Liambotis: [C: 032] Revert "Categorize pages containing blacklisted links" [extensions/SpamBlacklist] - 10https://gerrit.wikimedia.org/r/122283 (owner: 10Faidon Liambotis) [06:08:05] (03Merged) 10jenkins-bot: Revert "Categorize pages containing blacklisted links" [extensions/SpamBlacklist] - 10https://gerrit.wikimedia.org/r/122283 (owner: 10Faidon Liambotis) [06:09:00] thanks for that [06:09:13] now, cherry pick to wmf/1.23wmf19 & wmf20 I assume? [06:09:22] and then solve the i18n by hand again :) [06:10:13] pick one, i'll do the other [06:13:33] (03PS1) 10Faidon Liambotis: Revert "Categorize pages containing blacklisted links" [extensions/SpamBlacklist] - 10https://gerrit.wikimedia.org/r/122284 [06:13:35] (03CR) 10jenkins-bot: [V: 04-1] Revert "Categorize pages containing blacklisted links" [extensions/SpamBlacklist] - 10https://gerrit.wikimedia.org/r/122284 (owner: 10Faidon Liambotis) [06:13:44] argh [06:14:01] I pushed to the wrong ref :) [06:16:18] ! [remote rejected] HEAD -> refs/for/wmf/1.23wmf19 (no new changes) [06:16:20] any ideas? [06:16:42] is it confused it's already pushed as a candidate to a master branch? [06:17:57] https://code.google.com/p/gerrit/issues/detail?id=117 [06:17:58] apparently so [06:20:09] (03CR) 10Siebrand: [V: 032] "Override Jenkins." [extensions/Annotator] - 10https://gerrit.wikimedia.org/r/122235 (owner: 10Siebrand) [06:20:24] (03CR) 10Siebrand: [V: 032] "Override Jenkins." [extensions/Arrays] - 10https://gerrit.wikimedia.org/r/122239 (owner: 10Siebrand) [06:20:42] (03CR) 10Siebrand: [V: 032] "Override Jenkins." [extensions/Agora] - 10https://gerrit.wikimedia.org/r/122231 (owner: 10Siebrand) [06:21:29] (03PS1) 10Faidon Liambotis: Revert "Categorize pages containing blacklisted links" [extensions/SpamBlacklist] (wmf/1.23wmf19) - 10https://gerrit.wikimedia.org/r/122285 [06:21:49] (03PS2) 10Siebrand: Migrate to JSON i18n [extensions/AJAXPoll] - 10https://gerrit.wikimedia.org/r/122232 [06:22:21] (03Abandoned) 10Faidon Liambotis: Revert "Categorize pages containing blacklisted links" [extensions/SpamBlacklist] - 10https://gerrit.wikimedia.org/r/122284 (owner: 10Faidon Liambotis) [06:22:26] (03CR) 10Siebrand: "Updated in PS2." (031 comment) [extensions/AJAXPoll] - 10https://gerrit.wikimedia.org/r/122232 (owner: 10Siebrand) [06:22:53] (03PS1) 10Faidon Liambotis: Revert "Categorize pages containing blacklisted links" [extensions/SpamBlacklist] (wmf/1.23wmf20) - 10https://gerrit.wikimedia.org/r/122286 [06:23:12] (03CR) 10Siebrand: "Updated in PS2." (031 comment) [extensions/AdManager] - 10https://gerrit.wikimedia.org/r/122229 (owner: 10Siebrand) [06:23:27] (03PS2) 10Siebrand: Migrate to JSON i18n [extensions/AdManager] - 10https://gerrit.wikimedia.org/r/122229 [06:24:23] (03CR) 10Faidon Liambotis: "Cherry-picked to I1bc03c6ea088b02adde83efae2f1f2b5540f0f27." [extensions/SpamBlacklist] - 10https://gerrit.wikimedia.org/r/122283 (owner: 10Faidon Liambotis) [06:24:51] (03CR) 10Faidon Liambotis: [C: 032] Revert "Categorize pages containing blacklisted links" [extensions/SpamBlacklist] (wmf/1.23wmf19) - 10https://gerrit.wikimedia.org/r/122285 (owner: 10Faidon Liambotis) [06:24:54] (03Merged) 10jenkins-bot: Revert "Categorize pages containing blacklisted links" [extensions/SpamBlacklist] (wmf/1.23wmf19) - 10https://gerrit.wikimedia.org/r/122285 (owner: 10Faidon Liambotis) [06:25:02] (03CR) 10Faidon Liambotis: [C: 032] Revert "Categorize pages containing blacklisted links" [extensions/SpamBlacklist] (wmf/1.23wmf20) - 10https://gerrit.wikimedia.org/r/122286 (owner: 10Faidon Liambotis) [06:25:04] (03Merged) 10jenkins-bot: Revert "Categorize pages containing blacklisted links" [extensions/SpamBlacklist] (wmf/1.23wmf20) - 10https://gerrit.wikimedia.org/r/122286 (owner: 10Faidon Liambotis) [06:26:54] (03CR) 10Siebrand: [C: 04-1] "Per Niklas." [extensions/Bootstrap] - 10https://gerrit.wikimedia.org/r/122258 (owner: 10Siebrand) [06:27:03] (03CR) 10Siebrand: [C: 04-1] "Per Niklas." [extensions/ArticleFeedback] - 10https://gerrit.wikimedia.org/r/122241 (owner: 10Siebrand) [06:27:43] (03PS2) 10Siebrand: Migrate to JSON i18n [extensions/ArticleFeedback] - 10https://gerrit.wikimedia.org/r/122241 [06:27:52] (03CR) 10Siebrand: "Fixed in PS2." (031 comment) [extensions/ArticleFeedback] - 10https://gerrit.wikimedia.org/r/122241 (owner: 10Siebrand) [06:28:59] (03CR) 10Foxtrott: [C: 032 V: 032] Avoid loading styles twice [skins/chameleon] - 10https://gerrit.wikimedia.org/r/122122 (owner: 10Foxtrott) [06:29:56] (03PS2) 10Siebrand: Migrate to JSON i18n [extensions/Bootstrap] - 10https://gerrit.wikimedia.org/r/122258 [06:30:14] (03CR) 10Siebrand: "Replied, and updated in PS2." (032 comments) [extensions/Bootstrap] - 10https://gerrit.wikimedia.org/r/122258 (owner: 10Siebrand) [06:34:02] (03CR) 10Siebrand: [C: 04-1] "Per Niklas." [extensions/AllTimeZones] - 10https://gerrit.wikimedia.org/r/122234 (owner: 10Siebrand) [06:35:19] (03CR) 10Siebrand: "Updated in PS2." (031 comment) [extensions/AllTimeZones] - 10https://gerrit.wikimedia.org/r/122234 (owner: 10Siebrand) [06:35:56] (03PS2) 10Siebrand: Migrate to JSON i18n [extensions/AllTimeZones] - 10https://gerrit.wikimedia.org/r/122234 [06:35:59] (03PS3) 10Prtksxna: Use correct spacing conventions for jshint comment [extensions/Popups] - 10https://gerrit.wikimedia.org/r/121369 [06:36:00] (03PS7) 10Prtksxna: Disable NavigationPopups (Gadget) is Popups (Extension) is enabled [extensions/Popups] - 10https://gerrit.wikimedia.org/r/120188 [06:37:00] (03CR) 10Siebrand: [C: 032] Use correct spacing conventions for jshint comment [extensions/Popups] - 10https://gerrit.wikimedia.org/r/121369 (owner: 10Prtksxna) [06:37:03] (03CR) 10Prtksxna: "Is independent now!" [extensions/Popups] - 10https://gerrit.wikimedia.org/r/121369 (owner: 10Prtksxna) [06:37:05] (03Merged) 10jenkins-bot: Use correct spacing conventions for jshint comment [extensions/Popups] - 10https://gerrit.wikimedia.org/r/121369 (owner: 10Prtksxna) [06:39:29] so many version bumps :) [06:39:37] (03CR) 10Siebrand: [C: 031] "i18n/L10n" [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/122279 (owner: 10Legoktm) [06:42:16] (03CR) 10Siebrand: Whitespace, code formatting cleanup (031 comment) [services/cxserver] - 10https://gerrit.wikimedia.org/r/122276 (owner: 10Santhosh) [06:43:31] (03CR) 10Prtksxna: "Are you planning on submitting a new patch?" [extensions/Popups] - 10https://gerrit.wikimedia.org/r/114710 (owner: 10Brian Wolff) [06:43:33] (03CR) 10Siebrand: [C: 04-1] "i18n/L10n reviewed." (031 comment) [wikimedia/wikimania-scholarships] - 10https://gerrit.wikimedia.org/r/122123 (owner: 10Kushal124) [06:45:32] (03CR) 10Siebrand: [C: 032] Follow-up I7d4bb90: Message tweak + add code comment [core] - 10https://gerrit.wikimedia.org/r/122271 (owner: 10Brian Wolff) [06:46:35] (03CR) 10Siebrand: [C: 032] Follow-up I7d4bb9062. Register tracking categories used. [extensions/Scribunto] - 10https://gerrit.wikimedia.org/r/122270 (owner: 10Brian Wolff) [06:47:56] (03Merged) 10jenkins-bot: Follow-up I7d4bb9062. Register tracking categories used. [extensions/Scribunto] - 10https://gerrit.wikimedia.org/r/122270 (owner: 10Brian Wolff) [06:48:39] (03Merged) 10jenkins-bot: Follow-up I7d4bb90: Message tweak + add code comment [core] - 10https://gerrit.wikimedia.org/r/122271 (owner: 10Brian Wolff) [06:48:49] (03CR) 10Siebrand: "Nice work. Congratulations on getting this merged." [core] - 10https://gerrit.wikimedia.org/r/112323 (owner: 10Kunalgrover05) [06:51:01] (03CR) 10Siebrand: [C: 031] "i18n/L10n reviewed." [extensions/Cite] - 10https://gerrit.wikimedia.org/r/120962 (owner: 10Alex Monk) [06:52:46] (03CR) 10Siebrand: [C: 04-1] "i18n/L10n reviewed." (031 comment) [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/122242 (owner: 10TyA) [06:55:31] (03PS1) 10Faidon Liambotis: Update SpamBlacklist, emergency revert [core] (wmf/1.23wmf19) - 10https://gerrit.wikimedia.org/r/122287 [06:57:08] (03PS1) 10Faidon Liambotis: Update SpamBlacklist, emergency revert [core] (wmf/1.23wmf20) - 10https://gerrit.wikimedia.org/r/122288 [06:57:36] (03CR) 10Faidon Liambotis: [C: 032] Update SpamBlacklist, emergency revert [core] (wmf/1.23wmf19) - 10https://gerrit.wikimedia.org/r/122287 (owner: 10Faidon Liambotis) [06:57:41] (03CR) 10Faidon Liambotis: [C: 032] Update SpamBlacklist, emergency revert [core] (wmf/1.23wmf20) - 10https://gerrit.wikimedia.org/r/122288 (owner: 10Faidon Liambotis) [07:01:31] (03CR) 10Siebrand: [C: 04-1] "Some i18n/L10n reviewed." (0311 comments) [extensions/Workflow] - 10https://gerrit.wikimedia.org/r/107307 (owner: 10Adamw) [07:02:04] (03Merged) 10jenkins-bot: Update SpamBlacklist, emergency revert [core] (wmf/1.23wmf19) - 10https://gerrit.wikimedia.org/r/122287 (owner: 10Faidon Liambotis) [07:03:06] (03Merged) 10jenkins-bot: Update SpamBlacklist, emergency revert [core] (wmf/1.23wmf20) - 10https://gerrit.wikimedia.org/r/122288 (owner: 10Faidon Liambotis) [07:08:37] (03CR) 10Siebrand: "Sweet!" [extensions/NukeDPL] - 10https://gerrit.wikimedia.org/r/121958 (owner: 10Luis Felipe Schenone) [07:10:26] (03CR) 10Siebrand: [C: 04-1] Adds form fields to BadgeManager (032 comments) [extensions/OpenBadges] - 10https://gerrit.wikimedia.org/r/116448 (owner: 10Chococookies) [07:12:41] (03CR) 10Brian Wolff: [C: 04-1] "Sorry forgot about this and it wasn't on my todo list as it didnt have a -1." [extensions/Popups] - 10https://gerrit.wikimedia.org/r/114710 (owner: 10Brian Wolff) [07:13:16] (03CR) 10Nikerabbit: [C: 032 V: 032] Migrate to JSON i18n [extensions/AJAXPoll] - 10https://gerrit.wikimedia.org/r/122232 (owner: 10Siebrand) [07:14:16] (03CR) 10Nikerabbit: [C: 032 V: 032] Migrate to JSON i18n [extensions/AdManager] - 10https://gerrit.wikimedia.org/r/122229 (owner: 10Siebrand) [07:15:07] (03CR) 10Siebrand: [C: 04-1] Merges and inits db schema, add special pages. (036 comments) [extensions/OpenBadges] - 10https://gerrit.wikimedia.org/r/120361 (owner: 10Chococookies) [07:15:41] (03CR) 10Nikerabbit: [C: 032 V: 032] Migrate to JSON i18n [extensions/AllTimeZones] - 10https://gerrit.wikimedia.org/r/122234 (owner: 10Siebrand) [07:29:46] (03CR) 10Fomafix: wpSummaryLabel and wpSummary in one line with full width (032 comments) [core] - 10https://gerrit.wikimedia.org/r/118246 (owner: 10Gerrit Patch Uploader) [07:32:19] (03PS4) 10Gerrit Patch Uploader: wpSummaryLabel and wpSummary in one line with full width [core] - 10https://gerrit.wikimedia.org/r/118246 [07:32:21] (03CR) 10Gerrit Patch Uploader: "This commit was uploaded using the Gerrit Patch Uploader [1]." [core] - 10https://gerrit.wikimedia.org/r/118246 (owner: 10Gerrit Patch Uploader) [07:43:31] (03CR) 10Raimond Spekking: [C: 032] Migrate to JSON i18n [extensions/ArticleFeedback] - 10https://gerrit.wikimedia.org/r/122241 (owner: 10Siebrand) [07:44:21] (03CR) 10Raimond Spekking: [C: 032] Migrate to JSON i18n [extensions/Bootstrap] - 10https://gerrit.wikimedia.org/r/122258 (owner: 10Siebrand) [07:47:19] (03CR) 10Siebrand: [V: 032] "No Jenkins." [extensions/ArticleFeedback] - 10https://gerrit.wikimedia.org/r/122241 (owner: 10Siebrand) [07:47:25] (03CR) 10Siebrand: [V: 032] "No Jenkins." [extensions/Bootstrap] - 10https://gerrit.wikimedia.org/r/122258 (owner: 10Siebrand) [07:48:18] (03PS1) 10Siebrand: Migrate to JSON i18n [extensions/ClickTracking] - 10https://gerrit.wikimedia.org/r/122289 [07:48:45] (03PS1) 10Siebrand: Migrate to JSON i18n [extensions/CloseWikis] - 10https://gerrit.wikimedia.org/r/122290 [07:48:52] (03PS1) 10Siebrand: Migrate to JSON i18n [extensions/Commentbox] - 10https://gerrit.wikimedia.org/r/122291 [07:48:56] (03PS1) 10Siebrand: Migrate to JSON i18n [extensions/CommentPages] - 10https://gerrit.wikimedia.org/r/122292 [07:49:01] (03PS1) 10Siebrand: Migrate to JSON i18n [extensions/CommunityHiring] - 10https://gerrit.wikimedia.org/r/122293 [07:49:09] (03PS1) 10Siebrand: Migrate to JSON i18n [extensions/CommunityTwitter] - 10https://gerrit.wikimedia.org/r/122294 [07:49:13] (03PS1) 10Siebrand: Migrate to JSON i18n [extensions/ConditionalShowSection] - 10https://gerrit.wikimedia.org/r/122295 [07:49:17] (03PS1) 10Siebrand: Migrate to JSON i18n [extensions/Configure] - 10https://gerrit.wikimedia.org/r/122296 [07:49:21] (03PS1) 10Siebrand: Migrate to JSON i18n [extensions/ContactPageFundraiser] - 10https://gerrit.wikimedia.org/r/122297 [07:49:26] (03PS1) 10Siebrand: Migrate to JSON i18n [extensions/Contest] - 10https://gerrit.wikimedia.org/r/122298 [07:49:37] (03PS1) 10Siebrand: Migrate to JSON i18n [extensions/ConventionExtension] - 10https://gerrit.wikimedia.org/r/122300 [07:49:39] (03PS1) 10Siebrand: Migrate to JSON i18n [extensions/Contributors] - 10https://gerrit.wikimedia.org/r/122301 [07:49:41] (03PS1) 10Siebrand: Migrate to JSON i18n [extensions/Convert2Wiki] - 10https://gerrit.wikimedia.org/r/122302 [07:49:43] (03PS1) 10Siebrand: Migrate to JSON i18n [extensions/CopyToClipboard] - 10https://gerrit.wikimedia.org/r/122303 [07:49:47] (03PS1) 10Siebrand: Migrate to JSON i18n [extensions/CoreEvents] - 10https://gerrit.wikimedia.org/r/122304 [07:49:49] (03PS1) 10Siebrand: Migrate to JSON i18n [extensions/CreatePage] - 10https://gerrit.wikimedia.org/r/122305 [07:49:53] (03PS1) 10Siebrand: Migrate to JSON i18n [extensions/CreateRedirect] - 10https://gerrit.wikimedia.org/r/122306 [07:49:55] (03PS1) 10Siebrand: Migrate to JSON i18n [extensions/CreditTab] - 10https://gerrit.wikimedia.org/r/122307 [07:49:57] (03PS1) 10Siebrand: Migrate to JSON i18n [extensions/CryoKey] - 10https://gerrit.wikimedia.org/r/122308 [07:49:59] (03PS1) 10Siebrand: Migrate to JSON i18n [extensions/CSS] - 10https://gerrit.wikimedia.org/r/122309 [07:50:02] (03PS1) 10Siebrand: Migrate to JSON i18n [extensions/CustomUserSignup] - 10https://gerrit.wikimedia.org/r/122310 [07:50:07] (03PS1) 10Siebrand: Migrate to JSON i18n [extensions/DeleteOwn] - 10https://gerrit.wikimedia.org/r/122311 [07:50:09] (03PS1) 10Siebrand: Migrate to JSON i18n [extensions/DeleteBatch] - 10https://gerrit.wikimedia.org/r/122312 [07:50:11] (03PS1) 10Siebrand: Migrate to JSON i18n [extensions/Description2] - 10https://gerrit.wikimedia.org/r/122313 [07:50:13] (03PS1) 10Siebrand: Migrate to JSON i18n [extensions/Diagnosis] - 10https://gerrit.wikimedia.org/r/122314 [07:50:17] (03PS1) 10Siebrand: Migrate to JSON i18n [extensions/DidYouKnow] - 10https://gerrit.wikimedia.org/r/122315 [07:50:20] (03PS1) 10Siebrand: Migrate to JSON i18n [extensions/DidYouMean] - 10https://gerrit.wikimedia.org/r/122316 [07:50:22] (03PS1) 10Siebrand: Migrate to JSON i18n [extensions/DiscussionThreading] - 10https://gerrit.wikimedia.org/r/122317 [07:50:26] (03PS1) 10Siebrand: Migrate to JSON i18n [extensions/DisqusTag] - 10https://gerrit.wikimedia.org/r/122319 [07:50:31] (03PS1) 10Siebrand: Migrate to JSON i18n [extensions/DownloadCounter] - 10https://gerrit.wikimedia.org/r/122320 [07:50:35] (03PS1) 10Siebrand: Migrate to JSON i18n [extensions/Drafts] - 10https://gerrit.wikimedia.org/r/122321 [07:50:37] (03PS1) 10Siebrand: Migrate to JSON i18n [extensions/DPLforum] - 10https://gerrit.wikimedia.org/r/122322 [07:50:39] (03PS1) 10Siebrand: Migrate to JSON i18n [extensions/Duplicator] - 10https://gerrit.wikimedia.org/r/122323 [07:50:42] (03PS1) 10Siebrand: Migrate to JSON i18n [extensions/DynamicPageList] - 10https://gerrit.wikimedia.org/r/122324 [07:50:45] (03PS1) 10Siebrand: Migrate to JSON i18n [extensions/E3Experiments] - 10https://gerrit.wikimedia.org/r/122325 [07:51:10] heh it's getting speedy [07:52:20] (03PS1) 10Siebrand: Migrate to JSON i18n [extensions/Comments] - 10https://gerrit.wikimedia.org/r/122326 [07:58:55] (03PS1) 10Gerrit Patch Uploader: Add pst option to API difftotext Adds the option difftotextpst to ApiQueryRevisions.php, which will perform a pre-save transform on the supplied text, before diffing it against the requested revision. [core] - 10https://gerrit.wikimedia.org/r/122327 [07:58:57] (03CR) 10Gerrit Patch Uploader: "This commit was uploaded using the Gerrit Patch Uploader [1]." [core] - 10https://gerrit.wikimedia.org/r/122327 (owner: 10Gerrit Patch Uploader) [08:04:27] (03CR) 10Siebrand: "Invalid JSON was not caught by the linter. We have to be able to rely on it..." (031 comment) [extensions/Scribunto] - 10https://gerrit.wikimedia.org/r/122270 (owner: 10Brian Wolff) [08:05:22] (03CR) 10Kushal124: Fix validation error messages. (031 comment) [wikimedia/wikimania-scholarships] - 10https://gerrit.wikimedia.org/r/122123 (owner: 10Kushal124) [08:07:58] (03PS1) 10Raimond Spekking: Fix synax error. Make JSON valid [extensions/Scribunto] - 10https://gerrit.wikimedia.org/r/122329 [08:08:15] (03CR) 10Siebrand: [C: 032] Fix synax error. Make JSON valid [extensions/Scribunto] - 10https://gerrit.wikimedia.org/r/122329 (owner: 10Raimond Spekking) [08:10:23] (03CR) 10Fomafix: (Bug 34557) Fixed uses of width: 100%; with borders (031 comment) [core] - 10https://gerrit.wikimedia.org/r/54896 (owner: 10Rahul21) [08:12:25] (03Merged) 10jenkins-bot: Fix synax error. Make JSON valid [extensions/Scribunto] - 10https://gerrit.wikimedia.org/r/122329 (owner: 10Raimond Spekking) [08:12:57] (03CR) 10Siebrand: "I reported bug 63293. Fixing that should hopefully prevent future needs for this." [extensions/Scribunto] - 10https://gerrit.wikimedia.org/r/122329 (owner: 10Raimond Spekking) [08:27:57] (03CR) 10TheDJ: "BTW, If we disable navpopups, it needs a good release statement, and visible mentioning on the HoverCards description page" [extensions/Popups] - 10https://gerrit.wikimedia.org/r/120188 (owner: 10Prtksxna) [08:33:56] (03PS8) 10Nemo bis: Disable NavigationPopups (Gadget) if Popups (Extension) is enabled [extensions/Popups] - 10https://gerrit.wikimedia.org/r/120188 (owner: 10Prtksxna) [08:34:14] (03CR) 10Nemo bis: "+1 on release notes" [extensions/Popups] - 10https://gerrit.wikimedia.org/r/120188 (owner: 10Prtksxna) [08:52:42] (03PS1) 10Hashar: Register NukeDPL [extensions] - 10https://gerrit.wikimedia.org/r/122336 [08:59:48] (03PS2) 10Hashar: Register NukeDPL [extensions] - 10https://gerrit.wikimedia.org/r/122336 [08:59:53] (03CR) 10Hashar: [C: 032 V: 032] Register NukeDPL [extensions] - 10https://gerrit.wikimedia.org/r/122336 (owner: 10Hashar) [09:04:26] (03CR) 10Hashar: "There is still one failure:" [extensions/ConfirmEdit] - 10https://gerrit.wikimedia.org/r/122126 (owner: 10AalekhN) [09:21:08] (03PS23) 10Matthias Mullie: Refactor Flow\\Formatter namespace [extensions/Flow] - 10https://gerrit.wikimedia.org/r/117384 (owner: 10EBernhardson) [09:21:23] (03CR) 10Matthias Mullie: [C: 032] Refactor Flow\\Formatter namespace [extensions/Flow] - 10https://gerrit.wikimedia.org/r/117384 (owner: 10EBernhardson) [09:21:37] (03Merged) 10jenkins-bot: Refactor Flow\\Formatter namespace [extensions/Flow] - 10https://gerrit.wikimedia.org/r/117384 (owner: 10EBernhardson) [09:22:20] (03PS7) 10Ganeshaditya1: ChangeEmail special page rewritten to use vforms. [core] - 10https://gerrit.wikimedia.org/r/121975 [09:23:01] (03PS8) 10Ganeshaditya1: ChangeEmail special page rewritten to use vforms. [core] - 10https://gerrit.wikimedia.org/r/121975 [09:24:51] (03PS19) 10Matthias Mullie: Make BoardHistory a Formatter instance [extensions/Flow] - 10https://gerrit.wikimedia.org/r/115532 (owner: 10EBernhardson) [09:24:59] (03CR) 10Matthias Mullie: [C: 032] Make BoardHistory a Formatter instance [extensions/Flow] - 10https://gerrit.wikimedia.org/r/115532 (owner: 10EBernhardson) [09:25:23] (03Merged) 10jenkins-bot: Make BoardHistory a Formatter instance [extensions/Flow] - 10https://gerrit.wikimedia.org/r/115532 (owner: 10EBernhardson) [09:25:42] (03CR) 10Ganeshaditya1: "Didn't enclose the buttons in a group cause it was rendering each button as a big block like this" [core] - 10https://gerrit.wikimedia.org/r/121975 (owner: 10Ganeshaditya1) [09:28:16] (03PS1) 10Santhosh: Use a configurable logger [services/cxserver] - 10https://gerrit.wikimedia.org/r/122339 [09:31:50] Ehm, this is not standard bahaviour I think? https://www.dropbox.com/s/j70q762yqyihfqg/Screenshot%202014-03-31%2011.30.14.png [09:32:01] A other user is also getting it. :/ [09:32:29] I only get it on my watch list btw. [09:32:36] (03CR) 10Hashar: [C: 031] Send the profiler output to the 'profileoutput' log group [core] - 10https://gerrit.wikimedia.org/r/121336 (owner: 10IAlex) [09:32:51] (03CR) 10Raimond Spekking: [C: 032] Migrate to JSON i18n [extensions/ClickTracking] - 10https://gerrit.wikimedia.org/r/122289 (owner: 10Siebrand) [09:33:00] (03Merged) 10jenkins-bot: Migrate to JSON i18n [extensions/ClickTracking] - 10https://gerrit.wikimedia.org/r/122289 (owner: 10Siebrand) [09:33:08] (03CR) 10Raimond Spekking: [C: 032] Migrate to JSON i18n [extensions/CloseWikis] - 10https://gerrit.wikimedia.org/r/122290 (owner: 10Siebrand) [09:33:15] (03PS2) 10Gerrit Patch Uploader: Exclude user interface elements in content from selection [core] - 10https://gerrit.wikimedia.org/r/110186 [09:33:17] (03CR) 10Gerrit Patch Uploader: "This commit was uploaded using the Gerrit Patch Uploader [1]." [core] - 10https://gerrit.wikimedia.org/r/110186 (owner: 10Gerrit Patch Uploader) [09:33:22] Hello? [09:33:23] (03CR) 10Raimond Spekking: [C: 032] Migrate to JSON i18n [extensions/Commentbox] - 10https://gerrit.wikimedia.org/r/122291 (owner: 10Siebrand) [09:33:47] (03CR) 10Raimond Spekking: [C: 032] Migrate to JSON i18n [extensions/CommentPages] - 10https://gerrit.wikimedia.org/r/122292 (owner: 10Siebrand) [09:34:04] (03PS3) 10Matthias Mullie: Don't escape the userlinks displayed in "This topic was suppressed by " [extensions/Flow] - 10https://gerrit.wikimedia.org/r/121385 [09:34:28] (03CR) 10Raimond Spekking: [C: 032] Migrate to JSON i18n [extensions/CommunityTwitter] - 10https://gerrit.wikimedia.org/r/122294 (owner: 10Siebrand) [09:34:34] (03CR) 10jenkins-bot: [V: 04-1] Don't escape the userlinks displayed in "This topic was suppressed by " [extensions/Flow] - 10https://gerrit.wikimedia.org/r/121385 (owner: 10Matthias Mullie) [09:34:37] (03PS2) 10Hashar: Add extension checks for Nostalgia [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/121625 (owner: 10Siebrand) [09:34:54] (03CR) 10Hashar: [C: 032] Add extension checks for Nostalgia [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/121625 (owner: 10Siebrand) [09:35:18] (03CR) 10Raimond Spekking: [C: 032] Migrate to JSON i18n [extensions/ConditionalShowSection] - 10https://gerrit.wikimedia.org/r/122295 (owner: 10Siebrand) [09:37:38] (03CR) 10Hashar: [C: 032] Add extension checks for Nostalgia [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/121625 (owner: 10Siebrand) [09:38:03] (03Merged) 10jenkins-bot: Add extension checks for Nostalgia [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/121625 (owner: 10Siebrand) [09:38:06] (03CR) 10Raimond Spekking: [C: 032] Migrate to JSON i18n [extensions/CommunityHiring] - 10https://gerrit.wikimedia.org/r/122293 (owner: 10Siebrand) [09:38:18] (03Merged) 10jenkins-bot: Migrate to JSON i18n [extensions/CommunityHiring] - 10https://gerrit.wikimedia.org/r/122293 (owner: 10Siebrand) [09:38:19] Oh, nvm [09:38:38] (03PS1) 10Matthias Mullie: Quote topic names in history [extensions/Flow] - 10https://gerrit.wikimedia.org/r/122340 [09:38:42] (03CR) 10Raimond Spekking: [C: 032] Migrate to JSON i18n [extensions/Configure] - 10https://gerrit.wikimedia.org/r/122296 (owner: 10Siebrand) [09:38:53] (03Merged) 10jenkins-bot: Migrate to JSON i18n [extensions/Configure] - 10https://gerrit.wikimedia.org/r/122296 (owner: 10Siebrand) [09:39:16] (03CR) 10Raimond Spekking: [C: 032] Migrate to JSON i18n [extensions/ContactPageFundraiser] - 10https://gerrit.wikimedia.org/r/122297 (owner: 10Siebrand) [09:39:22] (03Merged) 10jenkins-bot: Migrate to JSON i18n [extensions/ContactPageFundraiser] - 10https://gerrit.wikimedia.org/r/122297 (owner: 10Siebrand) [09:39:33] (03CR) 10Raimond Spekking: [C: 032] Migrate to JSON i18n [extensions/Contest] - 10https://gerrit.wikimedia.org/r/122298 (owner: 10Siebrand) [09:40:00] (03CR) 10Matthias Mullie: Don't escape the userlinks displayed in "This topic was suppressed by " (031 comment) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/121385 (owner: 10Matthias Mullie) [09:40:14] (03CR) 10Raimond Spekking: [C: 032] Migrate to JSON i18n [extensions/Convert2Wiki] - 10https://gerrit.wikimedia.org/r/122302 (owner: 10Siebrand) [09:40:27] (03CR) 10Raimond Spekking: [C: 032] Migrate to JSON i18n [extensions/Contributors] - 10https://gerrit.wikimedia.org/r/122301 (owner: 10Siebrand) [09:41:11] (03CR) 10Raimond Spekking: [C: 04-1] Migrate to JSON i18n (032 comments) [extensions/ConventionExtension] - 10https://gerrit.wikimedia.org/r/122300 (owner: 10Siebrand) [09:42:09] (03PS3) 10Kushal124: Fix validation error messages. [wikimedia/wikimania-scholarships] - 10https://gerrit.wikimedia.org/r/122123 [09:42:54] (03PS2) 10Santhosh: Use a configurable logger [services/cxserver] - 10https://gerrit.wikimedia.org/r/122339 [09:43:27] (03CR) 10Raimond Spekking: [C: 032] Migrate to JSON i18n [extensions/CopyToClipboard] - 10https://gerrit.wikimedia.org/r/122303 (owner: 10Siebrand) [09:43:39] (03CR) 10Raimond Spekking: [C: 032] Migrate to JSON i18n [extensions/CoreEvents] - 10https://gerrit.wikimedia.org/r/122304 (owner: 10Siebrand) [09:43:51] (03CR) 10Raimond Spekking: [C: 032] Migrate to JSON i18n [extensions/CreatePage] - 10https://gerrit.wikimedia.org/r/122305 (owner: 10Siebrand) [09:44:00] (03CR) 10Raimond Spekking: [C: 032] Migrate to JSON i18n [extensions/CreateRedirect] - 10https://gerrit.wikimedia.org/r/122306 (owner: 10Siebrand) [09:44:19] (03CR) 10Raimond Spekking: [C: 032] Migrate to JSON i18n [extensions/CreditTab] - 10https://gerrit.wikimedia.org/r/122307 (owner: 10Siebrand) [09:44:29] (03PS1) 10Hashar: Use label hasBrowserTests for browser tests [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/122341 [09:44:43] (03CR) 10Raimond Spekking: [C: 032] Migrate to JSON i18n [extensions/CryoKey] - 10https://gerrit.wikimedia.org/r/122308 (owner: 10Siebrand) [09:44:56] (03CR) 10Raimond Spekking: [C: 032] Migrate to JSON i18n [extensions/CSS] - 10https://gerrit.wikimedia.org/r/122309 (owner: 10Siebrand) [09:45:32] (03CR) 10Raimond Spekking: [C: 032] Migrate to JSON i18n [extensions/CustomUserSignup] - 10https://gerrit.wikimedia.org/r/122310 (owner: 10Siebrand) [09:45:35] (03Merged) 10jenkins-bot: Migrate to JSON i18n [extensions/CustomUserSignup] - 10https://gerrit.wikimedia.org/r/122310 (owner: 10Siebrand) [09:45:44] (03PS4) 10Kushal124: Fix validation error messages. [wikimedia/wikimania-scholarships] - 10https://gerrit.wikimedia.org/r/122123 [09:45:46] (03CR) 10Raimond Spekking: [C: 032] Migrate to JSON i18n [extensions/DeleteOwn] - 10https://gerrit.wikimedia.org/r/122311 (owner: 10Siebrand) [09:45:56] (03CR) 10Raimond Spekking: [C: 032] Migrate to JSON i18n [extensions/DeleteBatch] - 10https://gerrit.wikimedia.org/r/122312 (owner: 10Siebrand) [09:45:58] (03Merged) 10jenkins-bot: Migrate to JSON i18n [extensions/DeleteBatch] - 10https://gerrit.wikimedia.org/r/122312 (owner: 10Siebrand) [09:46:11] (03CR) 10Raimond Spekking: [C: 032] Migrate to JSON i18n [extensions/Description2] - 10https://gerrit.wikimedia.org/r/122313 (owner: 10Siebrand) [09:46:13] (03PS15) 10Matthias Mullie: [SCHEMA CHANGE] Drop the definition model [extensions/Flow] - 10https://gerrit.wikimedia.org/r/115576 (owner: 10EBernhardson) [09:46:48] (03CR) 10Matthias Mullie: [C: 031] "PS15: rebased." [extensions/Flow] - 10https://gerrit.wikimedia.org/r/115576 (owner: 10EBernhardson) [09:47:04] (03CR) 10Raimond Spekking: [C: 032] Migrate to JSON i18n [extensions/Diagnosis] - 10https://gerrit.wikimedia.org/r/122314 (owner: 10Siebrand) [09:47:14] (03CR) 10Raimond Spekking: [C: 032] Migrate to JSON i18n [extensions/DidYouKnow] - 10https://gerrit.wikimedia.org/r/122315 (owner: 10Siebrand) [09:47:26] (03CR) 10Hashar: [C: 032] Use label hasBrowserTests for browser tests [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/122341 (owner: 10Hashar) [09:48:11] (03Merged) 10jenkins-bot: Use label hasBrowserTests for browser tests [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/122341 (owner: 10Hashar) [09:48:14] (03PS7) 10Phuedx: Add a LESS test suite [core] - 10https://gerrit.wikimedia.org/r/119055 [09:49:01] (03Abandoned) 10Matthias Mullie: Post without comment [extensions/ArticleFeedbackv5] - 10https://gerrit.wikimedia.org/r/37229 (owner: 10Matthias Mullie) [09:49:19] (03Abandoned) 10Matthias Mullie: Bug 43190 - AFTv5 API results should be wrapped in a {'query':results} object (for JSON) [extensions/ArticleFeedbackv5] - 10https://gerrit.wikimedia.org/r/39038 (owner: 10Matthias Mullie) [09:49:27] (03Abandoned) 10Matthias Mullie: Bug 43847 - mysql 5.5 / ansi sql incompatibility [extensions/ArticleFeedback] - 10https://gerrit.wikimedia.org/r/51356 (owner: 10Matthias Mullie) [09:49:37] (03Abandoned) 10Matthias Mullie: Left-pad legacy aft_id values with null-bytes, instead of right-padding [extensions/ArticleFeedbackv5] - 10https://gerrit.wikimedia.org/r/54641 (owner: 10Matthias Mullie) [09:49:44] (03Abandoned) 10Matthias Mullie: (bug 44827) Show amount of remaining characters for moderation-note [extensions/ArticleFeedbackv5] - 10https://gerrit.wikimedia.org/r/59387 (owner: 10Matthias Mullie) [09:51:22] (03Abandoned) 10Matthias Mullie: Move check to detect if AFT is enabled down (otherwise class was not yet loaded) [extensions/ArticleFeedback] - 10https://gerrit.wikimedia.org/r/61359 (owner: 10Matthias Mullie) [09:51:34] (03CR) 10Kushal124: "@Bdavis Fixed as suggested." (031 comment) [wikimedia/wikimania-scholarships] - 10https://gerrit.wikimedia.org/r/122123 (owner: 10Kushal124) [09:51:35] (03Abandoned) 10Matthias Mullie: (bug 38017) Rename "Details" to "Permalink" [extensions/ArticleFeedbackv5] - 10https://gerrit.wikimedia.org/r/61561 (owner: 10Matthias Mullie) [09:51:35] (03Abandoned) 10Matthias Mullie: (bug 37477) Feedback details text on "View feedback page" cut off for very long string without whitespace [extensions/ArticleFeedbackv5] - 10https://gerrit.wikimedia.org/r/61568 (owner: 10Matthias Mullie) [09:51:35] (03Abandoned) 10Matthias Mullie: (bug 47733) Word count is wrong, does not recognize non-ASCII characters [extensions/ArticleFeedbackv5] - 10https://gerrit.wikimedia.org/r/62435 (owner: 10Matthias Mullie) [09:51:35] (03Abandoned) 10Matthias Mullie: (bug 37917) Ugly bolding of entire section when one "other filter" is selected [extensions/ArticleFeedbackv5] - 10https://gerrit.wikimedia.org/r/62437 (owner: 10Matthias Mullie) [09:51:35] (03Abandoned) 10Matthias Mullie: (bug 37427) Filtering by "helpfulness", ranking mistake [extensions/ArticleFeedbackv5] - 10https://gerrit.wikimedia.org/r/62962 (owner: 10Matthias Mullie) [09:51:35] (03Abandoned) 10Matthias Mullie: Substitute $.ajax for mw.Api [extensions/ArticleFeedbackv5] - 10https://gerrit.wikimedia.org/r/63665 (owner: 10Matthias Mullie) [09:51:35] (03Abandoned) 10Matthias Mullie: Bug 32941 - The vertical feedback button doesn't appear on the right of the article page [extensions/ArticleFeedbackv5] - 10https://gerrit.wikimedia.org/r/63671 (owner: 10Matthias Mullie) [09:51:41] (03Abandoned) 10Matthias Mullie: (bug 42837) AFT uses dangerously generic class names like 'buttons' [extensions/ArticleFeedbackv5] - 10https://gerrit.wikimedia.org/r/64084 (owner: 10Matthias Mullie) [09:51:55] (03Abandoned) 10Matthias Mullie: (bug 42837) AFT uses dangerously generic class names like 'buttons' [extensions/ArticleFeedbackv5] - 10https://gerrit.wikimedia.org/r/64086 (owner: 10Matthias Mullie) [09:52:02] (03Abandoned) 10Matthias Mullie: Cleanup JS [extensions/ArticleFeedbackv5] - 10https://gerrit.wikimedia.org/r/65565 (owner: 10Matthias Mullie) [09:52:07] (03Abandoned) 10Matthias Mullie: Add 'all but inappropriate' filter [extensions/ArticleFeedbackv5] - 10https://gerrit.wikimedia.org/r/65799 (owner: 10Matthias Mullie) [09:52:13] (03Abandoned) 10Matthias Mullie: (bug 49327) overlapping text after moderation on permalink-page of feedback [extensions/ArticleFeedbackv5] - 10https://gerrit.wikimedia.org/r/67838 (owner: 10Matthias Mullie) [09:52:21] (03Abandoned) 10Matthias Mullie: Send Echo notifications for AFTv5 [extensions/ArticleFeedbackv5] - 10https://gerrit.wikimedia.org/r/74166 (owner: 10Matthias Mullie) [09:54:28] (03CR) 10Raimond Spekking: [C: 032] Migrate to JSON i18n [extensions/DidYouMean] - 10https://gerrit.wikimedia.org/r/122316 (owner: 10Siebrand) [09:54:42] (03CR) 10Raimond Spekking: [C: 032] Migrate to JSON i18n [extensions/DiscussionThreading] - 10https://gerrit.wikimedia.org/r/122317 (owner: 10Siebrand) [09:54:44] (03Merged) 10jenkins-bot: Migrate to JSON i18n [extensions/DiscussionThreading] - 10https://gerrit.wikimedia.org/r/122317 (owner: 10Siebrand) [09:54:53] (03CR) 10Raimond Spekking: [C: 032] Migrate to JSON i18n [extensions/DisqusTag] - 10https://gerrit.wikimedia.org/r/122319 (owner: 10Siebrand) [09:55:39] (03CR) 10Siebrand: [V: 032] Migrate to JSON i18n [extensions/CreateRedirect] - 10https://gerrit.wikimedia.org/r/122306 (owner: 10Siebrand) [09:56:02] (03CR) 10Raimond Spekking: [C: 04-1] Migrate to JSON i18n (031 comment) [extensions/DownloadCounter] - 10https://gerrit.wikimedia.org/r/122320 (owner: 10Siebrand) [09:56:14] (03CR) 10Raimond Spekking: [C: 032] Migrate to JSON i18n [extensions/Drafts] - 10https://gerrit.wikimedia.org/r/122321 (owner: 10Siebrand) [09:56:19] (03Merged) 10jenkins-bot: Migrate to JSON i18n [extensions/Drafts] - 10https://gerrit.wikimedia.org/r/122321 (owner: 10Siebrand) [09:56:25] (03CR) 10Raimond Spekking: [C: 032] Migrate to JSON i18n [extensions/DPLforum] - 10https://gerrit.wikimedia.org/r/122322 (owner: 10Siebrand) [09:56:36] (03CR) 10Raimond Spekking: [C: 032] Migrate to JSON i18n [extensions/Duplicator] - 10https://gerrit.wikimedia.org/r/122323 (owner: 10Siebrand) [09:56:48] (03CR) 10Siebrand: [V: 032] "No Jenkins for this repo." [extensions/Contributors] - 10https://gerrit.wikimedia.org/r/122301 (owner: 10Siebrand) [09:56:54] (03CR) 10Raimond Spekking: [C: 032] Migrate to JSON i18n [extensions/DynamicPageList] - 10https://gerrit.wikimedia.org/r/122324 (owner: 10Siebrand) [09:56:56] (03CR) 10Siebrand: [V: 032] "No Jenkins for this repo." [extensions/Convert2Wiki] - 10https://gerrit.wikimedia.org/r/122302 (owner: 10Siebrand) [09:57:02] (03CR) 10Siebrand: [V: 032] "No Jenkins for this repo." [extensions/CopyToClipboard] - 10https://gerrit.wikimedia.org/r/122303 (owner: 10Siebrand) [09:57:09] (03CR) 10Siebrand: [V: 032] "No Jenkins for this repo." [extensions/CoreEvents] - 10https://gerrit.wikimedia.org/r/122304 (owner: 10Siebrand) [09:57:15] (03CR) 10Siebrand: [V: 032] "No Jenkins for this repo." [extensions/CreatePage] - 10https://gerrit.wikimedia.org/r/122305 (owner: 10Siebrand) [09:57:22] (03CR) 10Raimond Spekking: [C: 032] Migrate to JSON i18n [extensions/E3Experiments] - 10https://gerrit.wikimedia.org/r/122325 (owner: 10Siebrand) [09:57:24] (03CR) 10Siebrand: [V: 032] "No Jenkins for this repo." [extensions/CreditTab] - 10https://gerrit.wikimedia.org/r/122307 (owner: 10Siebrand) [09:57:28] (03Merged) 10jenkins-bot: Migrate to JSON i18n [extensions/E3Experiments] - 10https://gerrit.wikimedia.org/r/122325 (owner: 10Siebrand) [09:57:30] (03CR) 10Siebrand: [V: 032] "No Jenkins for this repo." [extensions/CryoKey] - 10https://gerrit.wikimedia.org/r/122308 (owner: 10Siebrand) [09:57:37] (03CR) 10Raimond Spekking: [C: 032] Migrate to JSON i18n [extensions/Comments] - 10https://gerrit.wikimedia.org/r/122326 (owner: 10Siebrand) [09:57:40] (03CR) 10Siebrand: [V: 032] "No Jenkins for this repo." [extensions/CSS] - 10https://gerrit.wikimedia.org/r/122309 (owner: 10Siebrand) [09:58:24] (03CR) 10Siebrand: [V: 032] "No Jenkins for this repo." [extensions/CloseWikis] - 10https://gerrit.wikimedia.org/r/122290 (owner: 10Siebrand) [09:58:28] (03CR) 10Siebrand: [V: 032] "No Jenkins for this repo." [extensions/Commentbox] - 10https://gerrit.wikimedia.org/r/122291 (owner: 10Siebrand) [09:58:32] (03CR) 10Siebrand: [V: 032] "No Jenkins for this repo." [extensions/CommentPages] - 10https://gerrit.wikimedia.org/r/122292 (owner: 10Siebrand) [09:58:37] (03CR) 10Siebrand: [V: 032] "No Jenkins for this repo." [extensions/CommunityTwitter] - 10https://gerrit.wikimedia.org/r/122294 (owner: 10Siebrand) [09:58:42] (03CR) 10Siebrand: [V: 032] "No Jenkins for this repo." [extensions/ConditionalShowSection] - 10https://gerrit.wikimedia.org/r/122295 (owner: 10Siebrand) [09:58:45] (03CR) 10Siebrand: [V: 032] "No Jenkins for this repo." [extensions/Contest] - 10https://gerrit.wikimedia.org/r/122298 (owner: 10Siebrand) [09:58:51] (03CR) 10Siebrand: [V: 032] "No Jenkins for this repo." [extensions/DeleteOwn] - 10https://gerrit.wikimedia.org/r/122311 (owner: 10Siebrand) [09:58:56] (03CR) 10Siebrand: [V: 032] "No Jenkins for this repo." [extensions/Description2] - 10https://gerrit.wikimedia.org/r/122313 (owner: 10Siebrand) [09:59:00] (03CR) 10Siebrand: [V: 032] "No Jenkins for this repo." [extensions/Diagnosis] - 10https://gerrit.wikimedia.org/r/122314 (owner: 10Siebrand) [09:59:05] (03CR) 10Siebrand: [V: 032] "No Jenkins for this repo." [extensions/DidYouKnow] - 10https://gerrit.wikimedia.org/r/122315 (owner: 10Siebrand) [09:59:24] (03CR) 10Siebrand: [V: 032] "No Jenkins for this repo." [extensions/DidYouMean] - 10https://gerrit.wikimedia.org/r/122316 (owner: 10Siebrand) [09:59:29] (03CR) 10Siebrand: [V: 032] "No Jenkins for this repo." [extensions/DisqusTag] - 10https://gerrit.wikimedia.org/r/122319 (owner: 10Siebrand) [09:59:35] (03CR) 10Siebrand: [V: 032] "No Jenkins for this repo." [extensions/DPLforum] - 10https://gerrit.wikimedia.org/r/122322 (owner: 10Siebrand) [09:59:48] (03CR) 10Siebrand: [V: 032] "No Jenkins for this repo." [extensions/Duplicator] - 10https://gerrit.wikimedia.org/r/122323 (owner: 10Siebrand) [10:00:12] (03CR) 10Siebrand: [V: 032] "No Jenkins for this repo." [extensions/DynamicPageList] - 10https://gerrit.wikimedia.org/r/122324 (owner: 10Siebrand) [10:00:18] (03CR) 10Siebrand: [V: 032] "No Jenkins for this repo." [extensions/Comments] - 10https://gerrit.wikimedia.org/r/122326 (owner: 10Siebrand) [10:01:59] (03Abandoned) 10Matthias Mullie: (bug 46713) Getting AFTv5 logs via API times out on English Wikipedia [core] - 10https://gerrit.wikimedia.org/r/59418 (owner: 10Matthias Mullie) [10:02:23] (03PS2) 10Siebrand: Migrate to JSON i18n [extensions/ConventionExtension] - 10https://gerrit.wikimedia.org/r/122300 [10:02:59] (03CR) 10Siebrand: Migrate to JSON i18n (032 comments) [extensions/ConventionExtension] - 10https://gerrit.wikimedia.org/r/122300 (owner: 10Siebrand) [10:03:51] (03CR) 10Raimond Spekking: [C: 032] Migrate to JSON i18n [extensions/ConventionExtension] - 10https://gerrit.wikimedia.org/r/122300 (owner: 10Siebrand) [10:03:57] (03CR) 10Raimond Spekking: [V: 032] Migrate to JSON i18n [extensions/ConventionExtension] - 10https://gerrit.wikimedia.org/r/122300 (owner: 10Siebrand) [10:05:19] (03PS1) 10Siebrand: Covert from DOS to Unix line endings [extensions/DownloadCounter] - 10https://gerrit.wikimedia.org/r/122343 [10:05:34] (03CR) 10Siebrand: Migrate to JSON i18n (031 comment) [extensions/DownloadCounter] - 10https://gerrit.wikimedia.org/r/122320 (owner: 10Siebrand) [10:07:08] (03CR) 10Raimond Spekking: [C: 032 V: 032] Migrate to JSON i18n [extensions/DownloadCounter] - 10https://gerrit.wikimedia.org/r/122320 (owner: 10Siebrand) [10:09:42] (03CR) 10Raimond Spekking: [C: 04-1] Covert from DOS to Unix line endings (031 comment) [extensions/DownloadCounter] - 10https://gerrit.wikimedia.org/r/122343 (owner: 10Siebrand) [10:10:19] (03CR) 10Siebrand: Covert from DOS to Unix line endings (031 comment) [extensions/DownloadCounter] - 10https://gerrit.wikimedia.org/r/122343 (owner: 10Siebrand) [10:12:24] (03PS2) 10Siebrand: Covert from DOS to Unix line endings [extensions/DownloadCounter] - 10https://gerrit.wikimedia.org/r/122343 [10:12:43] (03CR) 10Siebrand: "I should have used "dos2unix -U" apparently." [extensions/DownloadCounter] - 10https://gerrit.wikimedia.org/r/122343 (owner: 10Siebrand) [10:19:13] (03CR) 10Phuedx: "PS7 removes LessFileCompilationTest#run and adds #testLessFileCompilation (a normal PHPUnit test case) and also fixes the coding conventio" [core] - 10https://gerrit.wikimedia.org/r/119055 (owner: 10Phuedx) [10:21:20] (03CR) 10Matthias Mullie: [C: 032] Update IRCLineURL hook to include RecentChange object [core] - 10https://gerrit.wikimedia.org/r/120695 (owner: 10EBernhardson) [10:24:31] (03Merged) 10jenkins-bot: Update IRCLineURL hook to include RecentChange object [core] - 10https://gerrit.wikimedia.org/r/120695 (owner: 10EBernhardson) [10:39:08] (03CR) 10Matthias Mullie: [C: 04-1] Reorganise flow-post-interaction link styling (032 comments) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/119812 (owner: 10Bencmq) [10:44:41] (03CR) 10Matthias Mullie: [C: 04-1] "Retracting my -2 because it's in better shape now." [extensions/Flow] - 10https://gerrit.wikimedia.org/r/113066 (owner: 10Matthias Mullie) [10:51:51] (03PS2) 10Hashar: Add phplint for qrpedia repo [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/121934 (owner: 10Addshore) [10:55:26] (03PS1) 10Hashar: Triggers qrpedia-phplint [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/122347 [10:55:43] (03CR) 10Hashar: [C: 032] Triggers qrpedia-phplint [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/122347 (owner: 10Hashar) [10:55:47] (03Merged) 10jenkins-bot: Triggers qrpedia-phplint [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/122347 (owner: 10Hashar) [10:55:51] (03CR) 10Hashar: "Zuul triggers with https://gerrit.wikimedia.org/r/#/c/122347/" [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/121934 (owner: 10Addshore) [10:55:59] (03CR) 10Hashar: [C: 032] Add phplint for qrpedia repo [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/121934 (owner: 10Addshore) [10:56:35] (03Merged) 10jenkins-bot: Add phplint for qrpedia repo [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/121934 (owner: 10Addshore) [10:58:07] (03PS1) 10Hashar: Jenkins job validation (DO NOT SUBMIT) [qrpedia] - 10https://gerrit.wikimedia.org/r/122348 [10:58:19] (03Abandoned) 10Hashar: Jenkins job validation (DO NOT SUBMIT) [qrpedia] - 10https://gerrit.wikimedia.org/r/122348 (owner: 10Hashar) [11:00:28] (03CR) 10Raimond Spekking: [C: 032 V: 032] Covert from DOS to Unix line endings [extensions/DownloadCounter] - 10https://gerrit.wikimedia.org/r/122343 (owner: 10Siebrand) [11:05:45] (03PS1) 10Daniel Kinzler: (bug 58032) introducing pp_sortkey. [core] - 10https://gerrit.wikimedia.org/r/122349 [11:09:12] (03CR) 10jenkins-bot: [V: 04-1] (bug 58032) introducing pp_sortkey. [core] - 10https://gerrit.wikimedia.org/r/122349 (owner: 10Daniel Kinzler) [11:12:27] (03CR) 10Aude: [C: 04-1] (bug 58032) introducing pp_sortkey. (032 comments) [core] - 10https://gerrit.wikimedia.org/r/122349 (owner: 10Daniel Kinzler) [11:13:01] (03CR) 10Aude: (bug 58032) introducing pp_sortkey. (031 comment) [core] - 10https://gerrit.wikimedia.org/r/122349 (owner: 10Daniel Kinzler) [11:14:01] (03CR) 10Aude: (bug 58032) introducing pp_sortkey. (031 comment) [core] - 10https://gerrit.wikimedia.org/r/122349 (owner: 10Daniel Kinzler) [11:14:22] (03PS2) 10Daniel Kinzler: (bug 58032) introducing pp_sortkey. [core] - 10https://gerrit.wikimedia.org/r/122349 [11:15:09] (03PS1) 10Zfilipin: Updated readme file [ruby/api] - 10https://gerrit.wikimedia.org/r/122351 [11:15:32] (03PS2) 10Zfilipin: Updated readme file [ruby/api] - 10https://gerrit.wikimedia.org/r/122351 [11:24:52] (03CR) 10KartikMistry: [C: 031] "Looks fine to me." [ruby/api] - 10https://gerrit.wikimedia.org/r/122351 (owner: 10Zfilipin) [11:27:21] (03PS1) 10Prtksxna: Use document.createElementNS for svg image [extensions/Popups] - 10https://gerrit.wikimedia.org/r/122352 [11:35:04] (03CR) 10Siebrand: [C: 04-1] "Score -1 to indicate there's a todo on this patch set." [extensions/BlueSpiceFoundation] - 10https://gerrit.wikimedia.org/r/121686 (owner: 10Smuggli) [11:43:29] (03CR) 10Siebrand: [C: 04-1] "i18n/L10n reviewed." (037 comments) [wikimedia/wikimania-scholarships] - 10https://gerrit.wikimedia.org/r/122123 (owner: 10Kushal124) [11:46:41] (03CR) 10Siebrand: [C: 032 V: 032] Upgrade html2canvas to remove XSS [extensions/UIFeedback] - 10https://gerrit.wikimedia.org/r/122001 (owner: 10Mattflaschen) [11:47:33] (03CR) 10Siebrand: [C: 032] Add missing line breaks to wfDebug() calls [core] - 10https://gerrit.wikimedia.org/r/121928 (owner: 10IAlex) [11:50:42] (03Merged) 10jenkins-bot: Add missing line breaks to wfDebug() calls [core] - 10https://gerrit.wikimedia.org/r/121928 (owner: 10IAlex) [11:51:40] (03Abandoned) 10Hashar: Revert "Added the $wgPFEnableStringFunctions = true in ParserFunctions tests" [extensions/ParserFunctions] - 10https://gerrit.wikimedia.org/r/114937 (owner: 10MaxSem) [11:51:58] (03PS4) 10Hashar: Add json-lint.php command to -jslint jobs [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/113958 [12:03:41] (03CR) 10Santhosh: Whitespace, code formatting cleanup (031 comment) [services/cxserver] - 10https://gerrit.wikimedia.org/r/122276 (owner: 10Santhosh) [12:07:34] (03CR) 10Hashar: [C: 032] "being deployed" [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/113958 (owner: 10Hashar) [12:08:14] (03Merged) 10jenkins-bot: Add json-lint.php command to -jslint jobs [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/113958 (owner: 10Hashar) [12:15:11] (03PS1) 10KartikMistry: Add module assert for devdependencies [services/cxserver] - 10https://gerrit.wikimedia.org/r/122354 [12:22:31] (03PS3) 10Daniel Kinzler: (bug 58032) introducing pp_sortkey. [core] - 10https://gerrit.wikimedia.org/r/122349 [12:31:37] (03PS4) 10Smuggli: Implemented changes for getting into translatewiki [extensions/BlueSpiceFoundation] - 10https://gerrit.wikimedia.org/r/121683 [12:35:21] (03PS5) 10Smuggli: Implemented changes for getting into translatewiki [extensions/BlueSpiceFoundation] - 10https://gerrit.wikimedia.org/r/121683 [12:37:49] (03PS1) 10Siebrand: Migrate to JSON i18n [extensions/EditPageTracking] - 10https://gerrit.wikimedia.org/r/122356 [12:38:32] (03PS1) 10Siebrand: Migrate to JSON i18n [extensions/Editcount] - 10https://gerrit.wikimedia.org/r/122357 [12:39:18] (03PS1) 10Siebrand: Migrate to JSON i18n [extensions/EditSubpages] - 10https://gerrit.wikimedia.org/r/122358 [12:39:24] (03PS1) 10Siebrand: Migrate to JSON i18n [extensions/EmailCapture] - 10https://gerrit.wikimedia.org/r/122359 [12:39:29] (03PS1) 10Siebrand: Migrate to JSON i18n [extensions/ErrorHandler] - 10https://gerrit.wikimedia.org/r/122360 [12:39:34] (03PS1) 10Siebrand: Migrate to JSON i18n [extensions/EtherEditor] - 10https://gerrit.wikimedia.org/r/122361 [12:39:38] (03PS1) 10Siebrand: Migrate to JSON i18n [extensions/EtherpadLite] - 10https://gerrit.wikimedia.org/r/122362 [12:39:44] (03PS1) 10Siebrand: Migrate to JSON i18n [extensions/ExpandTemplates] - 10https://gerrit.wikimedia.org/r/122363 [12:39:47] (03PS1) 10Siebrand: Migrate to JSON i18n [extensions/ExternalArticles] - 10https://gerrit.wikimedia.org/r/122364 [12:39:49] (03CR) 10jenkins-bot: [V: 04-1] Migrate to JSON i18n [extensions/EtherEditor] - 10https://gerrit.wikimedia.org/r/122361 (owner: 10Siebrand) [12:39:52] (03PS1) 10Siebrand: Migrate to JSON i18n [extensions/ExternalData] - 10https://gerrit.wikimedia.org/r/122365 [12:39:55] (03PS1) 10Siebrand: Migrate to JSON i18n [extensions/FanBoxes] - 10https://gerrit.wikimedia.org/r/122366 [12:40:00] (03PS1) 10Siebrand: Migrate to JSON i18n [extensions/FilterListUsers] - 10https://gerrit.wikimedia.org/r/122367 [12:40:04] (03PS1) 10Siebrand: Migrate to JSON i18n [extensions/FlvHandler] - 10https://gerrit.wikimedia.org/r/122368 [12:40:09] (03PS1) 10Siebrand: Migrate to JSON i18n [extensions/ForcePreview] - 10https://gerrit.wikimedia.org/r/122369 [12:40:12] (03PS1) 10Siebrand: Migrate to JSON i18n [extensions/FormatNum] - 10https://gerrit.wikimedia.org/r/122370 [12:40:18] (03PS1) 10Siebrand: Migrate to JSON i18n [extensions/FormelApplet] - 10https://gerrit.wikimedia.org/r/122371 [12:40:22] (03PS1) 10Siebrand: Migrate to JSON i18n [extensions/Foxway] - 10https://gerrit.wikimedia.org/r/122372 [12:40:26] (03PS1) 10Siebrand: Migrate to JSON i18n [extensions/Genderize] - 10https://gerrit.wikimedia.org/r/122373 [12:40:31] (03PS1) 10Siebrand: Migrate to JSON i18n [extensions/GeoGebra] - 10https://gerrit.wikimedia.org/r/122374 [12:40:35] (03PS1) 10Siebrand: Migrate to JSON i18n [extensions/Git2Pages] - 10https://gerrit.wikimedia.org/r/122375 [12:40:39] (03PS1) 10Siebrand: Migrate to JSON i18n [extensions/Gitweb] - 10https://gerrit.wikimedia.org/r/122376 [12:40:45] (03PS1) 10Siebrand: Migrate to JSON i18n [extensions/GlobalContributions] - 10https://gerrit.wikimedia.org/r/122377 [12:40:50] (03PS1) 10Siebrand: Migrate to JSON i18n [extensions/GlobalCssJs] - 10https://gerrit.wikimedia.org/r/122378 [12:40:54] (03PS1) 10Siebrand: Migrate to JSON i18n [extensions/GlobalPreferences] - 10https://gerrit.wikimedia.org/r/122379 [12:40:58] (03PS1) 10Siebrand: Migrate to JSON i18n [extensions/GlobalUserGroups] - 10https://gerrit.wikimedia.org/r/122380 [12:41:03] (03PS1) 10Siebrand: Migrate to JSON i18n [extensions/GlobalUserrights] - 10https://gerrit.wikimedia.org/r/122381 [12:41:07] (03PS1) 10Siebrand: Migrate to JSON i18n [extensions/GoogleAdSense] - 10https://gerrit.wikimedia.org/r/122382 [12:41:12] (03PS1) 10Siebrand: Migrate to JSON i18n [extensions/googleAnalytics] - 10https://gerrit.wikimedia.org/r/122383 [12:41:16] (03PS1) 10Siebrand: Migrate to JSON i18n [extensions/GoogleCustomWikiSearch] - 10https://gerrit.wikimedia.org/r/122384 [12:41:20] (03PS1) 10Siebrand: Migrate to JSON i18n [extensions/GoogleDocTag] - 10https://gerrit.wikimedia.org/r/122385 [12:41:26] (03PS1) 10Siebrand: Migrate to JSON i18n [extensions/GoogleMaps] - 10https://gerrit.wikimedia.org/r/122386 [12:41:29] (03PS1) 10Siebrand: Migrate to JSON i18n [extensions/GooglePlusOne] - 10https://gerrit.wikimedia.org/r/122387 [12:41:35] (03PS1) 10Siebrand: Migrate to JSON i18n [extensions/GoogleSiteSearch] - 10https://gerrit.wikimedia.org/r/122388 [12:41:39] (03PS1) 10Siebrand: Migrate to JSON i18n [extensions/GraphViz] - 10https://gerrit.wikimedia.org/r/122389 [12:41:42] (03PS1) 10Siebrand: Migrate to JSON i18n [extensions/GroupsSidebar] - 10https://gerrit.wikimedia.org/r/122390 [12:41:45] (03PS3) 10Bencmq: Reorganise flow-post-interaction link styling [extensions/Flow] - 10https://gerrit.wikimedia.org/r/119812 [12:41:50] (03PS1) 10Siebrand: Migrate to JSON i18n [extensions/Hanp] - 10https://gerrit.wikimedia.org/r/122391 [12:41:54] (03PS1) 10Siebrand: Migrate to JSON i18n [extensions/HashTables] - 10https://gerrit.wikimedia.org/r/122392 [12:41:56] (03PS1) 10Siebrand: Migrate to JSON i18n [extensions/HeaderTabs] - 10https://gerrit.wikimedia.org/r/122393 [12:42:41] (03PS4) 10Bencmq: Reorganise flow-post-interaction link styling [extensions/Flow] - 10https://gerrit.wikimedia.org/r/119812 [12:45:00] (03PS1) 10Siebrand: Migrate to JSON i18n [extensions/EducationProgram] - 10https://gerrit.wikimedia.org/r/122394 [12:45:10] (03CR) 10jenkins-bot: [V: 04-1] Migrate to JSON i18n [extensions/EducationProgram] - 10https://gerrit.wikimedia.org/r/122394 (owner: 10Siebrand) [12:46:53] (03PS2) 10Smuggli: Implemented changes for getting into translatewiki [extensions/BlueSpiceFoundation] - 10https://gerrit.wikimedia.org/r/121686 [12:50:46] (03PS3) 10Smuggli: Implemented changes for getting into translatewiki [extensions/BlueSpiceFoundation] - 10https://gerrit.wikimedia.org/r/121680 [12:53:56] (03CR) 10Nikerabbit: [C: 032] Migrate to JSON i18n [extensions/EditPageTracking] - 10https://gerrit.wikimedia.org/r/122356 (owner: 10Siebrand) [12:53:58] (03Merged) 10jenkins-bot: Migrate to JSON i18n [extensions/EditPageTracking] - 10https://gerrit.wikimedia.org/r/122356 (owner: 10Siebrand) [12:54:18] (03PS2) 10Smuggli: Implemented changes for getting into translatewiki [extensions/BlueSpiceFoundation] - 10https://gerrit.wikimedia.org/r/121685 [12:54:27] (03CR) 10Nikerabbit: [C: 032] Migrate to JSON i18n [extensions/Editcount] - 10https://gerrit.wikimedia.org/r/122357 (owner: 10Siebrand) [12:54:29] (03Merged) 10jenkins-bot: Migrate to JSON i18n [extensions/Editcount] - 10https://gerrit.wikimedia.org/r/122357 (owner: 10Siebrand) [12:55:46] (03CR) 10Nikerabbit: [C: 032 V: 032] Migrate to JSON i18n [extensions/EditSubpages] - 10https://gerrit.wikimedia.org/r/122358 (owner: 10Siebrand) [12:56:16] (03CR) 10Nikerabbit: [C: 04-1] Migrate to JSON i18n (031 comment) [extensions/EmailCapture] - 10https://gerrit.wikimedia.org/r/122359 (owner: 10Siebrand) [12:56:34] (03CR) 10Nikerabbit: [C: 032 V: 032] Migrate to JSON i18n [extensions/ErrorHandler] - 10https://gerrit.wikimedia.org/r/122360 (owner: 10Siebrand) [12:57:50] (03PS2) 10Siebrand: Migrate to JSON i18n [extensions/EmailCapture] - 10https://gerrit.wikimedia.org/r/122359 [12:58:53] (03CR) 10Nikerabbit: [C: 04-1] Migrate to JSON i18n (031 comment) [extensions/EtherEditor] - 10https://gerrit.wikimedia.org/r/122361 (owner: 10Siebrand) [12:58:53] (03CR) 10Nikerabbit: [C: 032 V: 032] Migrate to JSON i18n [extensions/EtherpadLite] - 10https://gerrit.wikimedia.org/r/122362 (owner: 10Siebrand) [12:59:16] (03PS2) 10Siebrand: Migrate to JSON i18n [extensions/EtherEditor] - 10https://gerrit.wikimedia.org/r/122361 [12:59:19] (03CR) 10Nikerabbit: [C: 032] Migrate to JSON i18n [extensions/ExpandTemplates] - 10https://gerrit.wikimedia.org/r/122363 (owner: 10Siebrand) [12:59:21] (03CR) 10jenkins-bot: [V: 04-1] Migrate to JSON i18n [extensions/EtherEditor] - 10https://gerrit.wikimedia.org/r/122361 (owner: 10Siebrand) [12:59:23] (03Merged) 10jenkins-bot: Migrate to JSON i18n [extensions/ExpandTemplates] - 10https://gerrit.wikimedia.org/r/122363 (owner: 10Siebrand) [12:59:55] (03CR) 10Nikerabbit: [C: 04-1] Migrate to JSON i18n (031 comment) [extensions/ExternalArticles] - 10https://gerrit.wikimedia.org/r/122364 (owner: 10Siebrand) [13:00:48] (03CR) 10Nikerabbit: [C: 032] "This is not GitHub extension, is it?" [extensions/ExternalData] - 10https://gerrit.wikimedia.org/r/122365 (owner: 10Siebrand) [13:01:00] (03PS2) 10Siebrand: Migrate to JSON i18n [extensions/ExternalArticles] - 10https://gerrit.wikimedia.org/r/122364 [13:01:11] (03CR) 10Nikerabbit: [C: 032 V: 032] Migrate to JSON i18n [extensions/FilterListUsers] - 10https://gerrit.wikimedia.org/r/122367 (owner: 10Siebrand) [13:01:37] (03CR) 10Nikerabbit: [C: 032 V: 032] Migrate to JSON i18n [extensions/ForcePreview] - 10https://gerrit.wikimedia.org/r/122369 (owner: 10Siebrand) [13:01:43] gerrit a bit slow [13:02:03] (03CR) 10Yaron Koren: "Nikerabbit - no, it's not; I haven't moved any of my extensions to GitHub." [extensions/ExternalData] - 10https://gerrit.wikimedia.org/r/122365 (owner: 10Siebrand) [13:02:27] (03CR) 10Nemo bis: "The number of lines in JSON is half than in PHP because of the newlines -> \n conversion, nothing wrong" [extensions/EmailCapture] - 10https://gerrit.wikimedia.org/r/122359 (owner: 10Siebrand) [13:03:05] (03CR) 10Nikerabbit: [C: 032 V: 032] Migrate to JSON i18n [extensions/Genderize] - 10https://gerrit.wikimedia.org/r/122373 (owner: 10Siebrand) [13:03:43] (03CR) 10Nikerabbit: [C: 032 V: 032] Migrate to JSON i18n [extensions/FormelApplet] - 10https://gerrit.wikimedia.org/r/122371 (owner: 10Siebrand) [13:04:17] (03CR) 10Matthias Mullie: [C: 031] "LGTM; awaiting feedback on parent patch; this one can be merged then" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/119812 (owner: 10Bencmq) [13:05:10] (03CR) 10Nikerabbit: [C: 04-1] Migrate to JSON i18n (031 comment) [extensions/FanBoxes] - 10https://gerrit.wikimedia.org/r/122366 (owner: 10Siebrand) [13:05:35] (03CR) 10Nikerabbit: [C: 032 V: 032] Migrate to JSON i18n [extensions/FormatNum] - 10https://gerrit.wikimedia.org/r/122370 (owner: 10Siebrand) [13:06:01] (03CR) 10Nikerabbit: [C: 032 V: 032] Migrate to JSON i18n [extensions/GeoGebra] - 10https://gerrit.wikimedia.org/r/122374 (owner: 10Siebrand) [13:06:05] (03Abandoned) 10Matthias Mullie: Add selectors for Parsoid-output external links [core] - 10https://gerrit.wikimedia.org/r/118447 (owner: 10Matthias Mullie) [13:06:12] (03Abandoned) 10Matthias Mullie: Add selector for Parsoid-output external links [extensions/Collection] - 10https://gerrit.wikimedia.org/r/118448 (owner: 10Matthias Mullie) [13:06:26] (03Abandoned) 10Matthias Mullie: Add selector for Parsoid-output external links [extensions/Nostalgia] - 10https://gerrit.wikimedia.org/r/118450 (owner: 10Matthias Mullie) [13:06:33] (03Abandoned) 10Matthias Mullie: Add selector for Parsoid-output external links [extensions/VectorBeta] - 10https://gerrit.wikimedia.org/r/118451 (owner: 10Matthias Mullie) [13:06:41] (03Abandoned) 10Matthias Mullie: Add selectors for Parsoid-output external links [extensions/skins] - 10https://gerrit.wikimedia.org/r/118452 (owner: 10Matthias Mullie) [13:06:53] (03CR) 10Nikerabbit: [C: 032] "This seems a GitHub extension, so not merging yet." [extensions/Gitweb] - 10https://gerrit.wikimedia.org/r/122376 (owner: 10Siebrand) [13:07:53] (03Abandoned) 10Matthias Mullie: Ignore hooks in User for unittests (it breaks tests/phpunit/phpunit.php) [extensions/Echo] - 10https://gerrit.wikimedia.org/r/66978 (owner: 10Matthias Mullie) [13:07:56] (03CR) 10Nikerabbit: [C: 032 V: 032] Migrate to JSON i18n [extensions/GlobalCssJs] - 10https://gerrit.wikimedia.org/r/122378 (owner: 10Siebrand) [13:08:03] (03CR) 10Siebrand: "Replied." (031 comment) [extensions/FanBoxes] - 10https://gerrit.wikimedia.org/r/122366 (owner: 10Siebrand) [13:08:16] (03CR) 10Nikerabbit: [C: 032 V: 032] Migrate to JSON i18n [extensions/GlobalUserGroups] - 10https://gerrit.wikimedia.org/r/122380 (owner: 10Siebrand) [13:08:49] (03CR) 10Nikerabbit: [C: 032] Migrate to JSON i18n [extensions/GoogleAdSense] - 10https://gerrit.wikimedia.org/r/122382 (owner: 10Siebrand) [13:08:51] (03Merged) 10jenkins-bot: Migrate to JSON i18n [extensions/GoogleAdSense] - 10https://gerrit.wikimedia.org/r/122382 (owner: 10Siebrand) [13:09:12] (03CR) 10Nikerabbit: [C: 032] Migrate to JSON i18n [extensions/GoogleCustomWikiSearch] - 10https://gerrit.wikimedia.org/r/122384 (owner: 10Siebrand) [13:09:14] (03Merged) 10jenkins-bot: Migrate to JSON i18n [extensions/GoogleCustomWikiSearch] - 10https://gerrit.wikimedia.org/r/122384 (owner: 10Siebrand) [13:10:16] (03CR) 10Nikerabbit: [C: 04-1] Migrate to JSON i18n (031 comment) [extensions/GoogleMaps] - 10https://gerrit.wikimedia.org/r/122386 (owner: 10Siebrand) [13:10:40] (03CR) 10Nikerabbit: [C: 032] Migrate to JSON i18n [extensions/GoogleSiteSearch] - 10https://gerrit.wikimedia.org/r/122388 (owner: 10Siebrand) [13:10:42] (03Merged) 10jenkins-bot: Migrate to JSON i18n [extensions/GoogleSiteSearch] - 10https://gerrit.wikimedia.org/r/122388 (owner: 10Siebrand) [13:11:00] (03CR) 10Nikerabbit: [C: 032 V: 032] Migrate to JSON i18n [extensions/GroupsSidebar] - 10https://gerrit.wikimedia.org/r/122390 (owner: 10Siebrand) [13:11:10] (03PS2) 10Siebrand: Migrate to JSON i18n [extensions/GoogleMaps] - 10https://gerrit.wikimedia.org/r/122386 [13:11:22] (03CR) 10AalekhN: "The Possible solution to this jshint failure will be to use asirra_CheckIfHuman(..) instead of Asirra_CheckIfHuman(..) but since this func" [extensions/ConfirmEdit] - 10https://gerrit.wikimedia.org/r/122126 (owner: 10AalekhN) [13:11:55] (03CR) 10Nikerabbit: [C: 032 V: 032] Migrate to JSON i18n [extensions/HashTables] - 10https://gerrit.wikimedia.org/r/122392 (owner: 10Siebrand) [13:12:58] (03CR) 10Siebrand: [C: 031] "i18n/L10n reviewed." [extensions/BlueSpiceFoundation] - 10https://gerrit.wikimedia.org/r/121685 (owner: 10Smuggli) [13:13:10] (03CR) 10Nikerabbit: [C: 04-1] "Besides jslint, this seems to be missing wgMessagesDirs, or am I blind?" [extensions/EducationProgram] - 10https://gerrit.wikimedia.org/r/122394 (owner: 10Siebrand) [13:14:44] (03PS2) 10Siebrand: Migrate to JSON i18n [extensions/EducationProgram] - 10https://gerrit.wikimedia.org/r/122394 [13:14:52] (03CR) 10jenkins-bot: [V: 04-1] Migrate to JSON i18n [extensions/EducationProgram] - 10https://gerrit.wikimedia.org/r/122394 (owner: 10Siebrand) [13:14:58] (03CR) 10Nikerabbit: [C: 032 V: 032] Migrate to JSON i18n [extensions/FlvHandler] - 10https://gerrit.wikimedia.org/r/122368 (owner: 10Siebrand) [13:15:22] (03CR) 10Nikerabbit: [C: 032] Migrate to JSON i18n [extensions/Git2Pages] - 10https://gerrit.wikimedia.org/r/122375 (owner: 10Siebrand) [13:15:39] (03Merged) 10jenkins-bot: Migrate to JSON i18n [extensions/Git2Pages] - 10https://gerrit.wikimedia.org/r/122375 (owner: 10Siebrand) [13:15:51] (03CR) 10Nikerabbit: [C: 032] Migrate to JSON i18n [extensions/GlobalPreferences] - 10https://gerrit.wikimedia.org/r/122379 (owner: 10Siebrand) [13:15:55] (03Merged) 10jenkins-bot: Migrate to JSON i18n [extensions/GlobalPreferences] - 10https://gerrit.wikimedia.org/r/122379 (owner: 10Siebrand) [13:16:20] (03CR) 10Nikerabbit: [C: 032 V: 032] Migrate to JSON i18n [extensions/googleAnalytics] - 10https://gerrit.wikimedia.org/r/122383 (owner: 10Siebrand) [13:16:46] (03CR) 10Nikerabbit: [C: 032 V: 032] Migrate to JSON i18n [extensions/GooglePlusOne] - 10https://gerrit.wikimedia.org/r/122387 (owner: 10Siebrand) [13:18:28] (03CR) 10Nikerabbit: [C: 032 V: 032] Migrate to JSON i18n [extensions/Hanp] - 10https://gerrit.wikimedia.org/r/122391 (owner: 10Siebrand) [13:18:53] (03CR) 10Siebrand: [C: 032] Whitespace, code formatting cleanup (031 comment) [services/cxserver] - 10https://gerrit.wikimedia.org/r/122276 (owner: 10Santhosh) [13:19:01] (03Merged) 10jenkins-bot: Whitespace, code formatting cleanup [services/cxserver] - 10https://gerrit.wikimedia.org/r/122276 (owner: 10Santhosh) [13:19:31] (03CR) 10Nikerabbit: [C: 032] Migrate to JSON i18n [extensions/EmailCapture] - 10https://gerrit.wikimedia.org/r/122359 (owner: 10Siebrand) [13:19:34] (03Merged) 10jenkins-bot: Migrate to JSON i18n [extensions/EmailCapture] - 10https://gerrit.wikimedia.org/r/122359 (owner: 10Siebrand) [13:19:45] (03CR) 10Nikerabbit: [C: 032] Migrate to JSON i18n [extensions/EtherEditor] - 10https://gerrit.wikimedia.org/r/122361 (owner: 10Siebrand) [13:19:49] (03CR) 10jenkins-bot: [V: 04-1] Migrate to JSON i18n [extensions/EtherEditor] - 10https://gerrit.wikimedia.org/r/122361 (owner: 10Siebrand) [13:20:16] (03CR) 10Nikerabbit: [C: 032 V: 032] Migrate to JSON i18n [extensions/GoogleMaps] - 10https://gerrit.wikimedia.org/r/122386 (owner: 10Siebrand) [13:21:18] (03CR) 10Siebrand: [V: 032] "Bypass Jenkins. Error is not related to the contents of this patch set." [extensions/EtherEditor] - 10https://gerrit.wikimedia.org/r/122361 (owner: 10Siebrand) [13:23:20] (03CR) 10Nikerabbit: [C: 032 V: 032] Migrate to JSON i18n [extensions/Foxway] - 10https://gerrit.wikimedia.org/r/122372 (owner: 10Siebrand) [13:23:44] (03CR) 10Nikerabbit: [C: 032 V: 032] Migrate to JSON i18n [extensions/GlobalUserrights] - 10https://gerrit.wikimedia.org/r/122381 (owner: 10Siebrand) [13:25:11] (03CR) 10Nikerabbit: [C: 032 V: 032] Migrate to JSON i18n [extensions/GraphViz] - 10https://gerrit.wikimedia.org/r/122389 (owner: 10Siebrand) [13:25:45] (03CR) 10Nikerabbit: [C: 032 V: 032] Migrate to JSON i18n [extensions/ExternalArticles] - 10https://gerrit.wikimedia.org/r/122364 (owner: 10Siebrand) [13:26:42] (03CR) 10Siebrand: [C: 032] "Excellent!" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/122340 (owner: 10Matthias Mullie) [13:26:56] (03Merged) 10jenkins-bot: Quote topic names in history [extensions/Flow] - 10https://gerrit.wikimedia.org/r/122340 (owner: 10Matthias Mullie) [13:27:03] (03CR) 10Nikerabbit: [C: 04-1] Migrate to JSON i18n (031 comment) [extensions/EducationProgram] - 10https://gerrit.wikimedia.org/r/122394 (owner: 10Siebrand) [13:27:40] (03CR) 10Nikerabbit: [C: 032 V: 032] Migrate to JSON i18n [extensions/GlobalContributions] - 10https://gerrit.wikimedia.org/r/122377 (owner: 10Siebrand) [13:27:56] (03CR) 10Nikerabbit: [C: 032 V: 032] Migrate to JSON i18n [extensions/GoogleDocTag] - 10https://gerrit.wikimedia.org/r/122385 (owner: 10Siebrand) [13:28:20] (03CR) 10Siebrand: Migrate to JSON i18n (031 comment) [extensions/EducationProgram] - 10https://gerrit.wikimedia.org/r/122394 (owner: 10Siebrand) [13:28:26] (03CR) 10Nikerabbit: [C: 032 V: 032] Migrate to JSON i18n [extensions/HeaderTabs] - 10https://gerrit.wikimedia.org/r/122393 (owner: 10Siebrand) [13:28:38] (03PS3) 10Siebrand: Migrate to JSON i18n [extensions/EducationProgram] - 10https://gerrit.wikimedia.org/r/122394 [13:28:46] (03CR) 10jenkins-bot: [V: 04-1] Migrate to JSON i18n [extensions/EducationProgram] - 10https://gerrit.wikimedia.org/r/122394 (owner: 10Siebrand) [13:33:13] (03CR) 10Nikerabbit: [C: 032] Migrate to JSON i18n [extensions/EducationProgram] - 10https://gerrit.wikimedia.org/r/122394 (owner: 10Siebrand) [13:33:20] (03CR) 10jenkins-bot: [V: 04-1] Migrate to JSON i18n [extensions/EducationProgram] - 10https://gerrit.wikimedia.org/r/122394 (owner: 10Siebrand) [13:33:41] (03CR) 10Nikerabbit: [C: 032 V: 032] Migrate to JSON i18n [extensions/FanBoxes] - 10https://gerrit.wikimedia.org/r/122366 (owner: 10Siebrand) [13:33:54] (03CR) 10Nikerabbit: [V: 032] Migrate to JSON i18n [extensions/ExternalData] - 10https://gerrit.wikimedia.org/r/122365 (owner: 10Siebrand) [13:37:31] (03PS3) 10Phuedx: [WIP] Add the mw.cookie module [core] - 10https://gerrit.wikimedia.org/r/120806 [13:40:41] (03CR) 10jenkins-bot: [V: 04-1] [WIP] Add the mw.cookie module [core] - 10https://gerrit.wikimedia.org/r/120806 (owner: 10Phuedx) [13:43:34] (03PS1) 10Mwalker: Merge remote-tracking branch 'gerrit/REL1_22' into fundraising/REL1_22 [core] (fundraising/REL1_22) - 10https://gerrit.wikimedia.org/r/122405 [13:47:21] (03CR) 10Mwalker: [C: 032] Merge remote-tracking branch 'gerrit/REL1_22' into fundraising/REL1_22 [core] (fundraising/REL1_22) - 10https://gerrit.wikimedia.org/r/122405 (owner: 10Mwalker) [13:49:39] (03CR) 10Siebrand: [V: 032] "Bypass Jenkins. Error is not related to the contents of this patch set." [extensions/EducationProgram] - 10https://gerrit.wikimedia.org/r/122394 (owner: 10Siebrand) [13:52:33] (03CR) 10Siebrand: [V: 032] "Merging anyway." [extensions/Gitweb] - 10https://gerrit.wikimedia.org/r/122376 (owner: 10Siebrand) [13:57:13] (03PS1) 10Gilles: Fix error in IE < 9 [core] - 10https://gerrit.wikimedia.org/r/122408 [14:00:34] (03CR) 10Matthias Mullie: [C: 04-1] "isAllowed() & isRevisionAllowed() have a subtle difference:" (031 comment) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/121707 (owner: 10Bsitu) [14:04:32] (03PS4) 10Phuedx: [WIP] Add the mw.cookie module [core] - 10https://gerrit.wikimedia.org/r/120806 [14:15:18] (03PS1) 10Matthias Mullie: (bug 63026) to oversighters, suppressed edits display as unsuppressed in Special:Contributions [extensions/Flow] - 10https://gerrit.wikimedia.org/r/122414 [14:15:58] (03PS2) 10Smuggli: Implemented changes for getting into translatewiki [extensions/BlueSpiceFoundation] - 10https://gerrit.wikimedia.org/r/121687 [14:20:30] (03CR) 10Phuedx: [WIP] Add the mw.cookie module (0317 comments) [core] - 10https://gerrit.wikimedia.org/r/120806 (owner: 10Phuedx) [14:23:58] looksie: http://ibin.co/1HPfvGP8DOXl [14:24:02] I added a status bar :D [14:25:30] (03PS1) 10Matthias Mullie: Fix double entries in Special:Contributions [extensions/Flow] - 10https://gerrit.wikimedia.org/r/122417 [14:26:39] (03CR) 10jenkins-bot: [V: 04-1] Fix double entries in Special:Contributions [extensions/Flow] - 10https://gerrit.wikimedia.org/r/122417 (owner: 10Matthias Mullie) [14:27:38] (03CR) 10Matthias Mullie: Refactor Flow\\Formatter namespace (031 comment) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/117384 (owner: 10EBernhardson) [14:28:23] (03PS1) 10AalekhN: ApiSandbox should pass jshint [extensions/ApiSandbox] - 10https://gerrit.wikimedia.org/r/122418 [14:29:46] (03CR) 10Siebrand: [C: 04-1] "i18n/L10n reviewed." (034 comments) [extensions/BlueSpiceFoundation] - 10https://gerrit.wikimedia.org/r/121687 (owner: 10Smuggli) [14:32:34] (03PS2) 10AalekhN: ApiSandbox should pass jshint [extensions/ApiSandbox] - 10https://gerrit.wikimedia.org/r/122418 [14:36:22] * siebrand kicks sluggish Gerrit. [14:56:34] hey bd808, we have a few commits i'd like to get merged before a workshop we're giving this thursday. would you be able to take a look at them? [14:57:52] * bd808 checks calendar [14:58:14] dan-nl: I can try. Put me on them for review and I'll take a look tomorrow afternoon [14:58:30] that would be great, thanks [14:59:00] (03PS2) 10Dan-nl: relax wiki title restrictions [extensions/GWToolset] - 10https://gerrit.wikimedia.org/r/121094 [14:59:20] (03PS3) 10Dan-nl: Correct the format of the wikitext output [extensions/GWToolset] - 10https://gerrit.wikimedia.org/r/121307 [15:00:14] (03PS2) 10Dan-nl: make sure unicode characters are normalized [extensions/GWToolset] - 10https://gerrit.wikimedia.org/r/121097 [15:05:54] (03PS3) 10AalekhN: ConfirmEdit should pass jshint [extensions/ConfirmEdit] - 10https://gerrit.wikimedia.org/r/122126 [15:29:11] (03PS1) 10Phuedx: Delete the post-edit cookie using the correct domain [core] - 10https://gerrit.wikimedia.org/r/122423 [15:29:11] (03PS5) 10Kushal124: Fix validation error messages. [wikimedia/wikimania-scholarships] - 10https://gerrit.wikimedia.org/r/122123 [15:29:12] (03CR) 10Anomie: "@Nikerabbit: Hmm. It'd be nice to find out where the code flow is getting that exits without shutting down the DB." [core] - 10https://gerrit.wikimedia.org/r/121402 (owner: 10Anomie) [15:36:20] (03CR) 10Smuggli: "Explanation for "No punctuation"." (031 comment) [extensions/BlueSpiceFoundation] - 10https://gerrit.wikimedia.org/r/121687 (owner: 10Smuggli) [15:38:08] (03PS3) 10Smuggli: Implemented changes for getting into translatewiki [extensions/BlueSpiceFoundation] - 10https://gerrit.wikimedia.org/r/121687 [15:43:48] git review -d 122333 ... Branch already exists - reusing .. Switched to branch "review/dzahn/120956" [15:44:04] is it git review or me .. that's a different branch name [15:44:59] hmm, i kept using that topic branch for the wrong patches..grmbl..ok [15:45:09] (03PS1) 10KartikMistry: WIP: Added initial rot13Tests [services/cxserver] - 10https://gerrit.wikimedia.org/r/122424 [15:46:36] (03PS2) 10KartikMistry: WIP: Added initial rot13Tests [services/cxserver] - 10https://gerrit.wikimedia.org/r/122424 [15:53:16] (03CR) 10Anomie: [C: 04-1] ApiFeedRecentChanges: Validate param target (032 comments) [core] - 10https://gerrit.wikimedia.org/r/121959 (owner: 10Nikerabbit) [15:59:48] (03CR) 10Santhosh: WIP: Added initial rot13Tests (031 comment) [services/cxserver] - 10https://gerrit.wikimedia.org/r/122424 (owner: 10KartikMistry) [16:01:38] (03CR) 10Anomie: [C: 031] "Seems sensible. One nitpick." (031 comment) [core] - 10https://gerrit.wikimedia.org/r/121912 (owner: 10Brian Wolff) [16:12:43] anomie: do you have any ideas how to do that? [16:12:55] (03CR) 10Aaron Schulz: [C: 032] Send the profiler output to the 'profileoutput' log group [core] - 10https://gerrit.wikimedia.org/r/121336 (owner: 10IAlex) [16:13:05] anomie: those errors do not appear together with exceptions or fatal errors in the log [16:14:37] Nikerabbit: Can you correlate them with particular requests? [16:15:31] anomie: not with high precision, as I have to match access logs via timestamp [16:16:21] anomie: I guess I could at least get a stack trace with xdebug, but not sure if that would help [16:16:24] (03Merged) 10jenkins-bot: Send the profiler output to the 'profileoutput' log group [core] - 10https://gerrit.wikimedia.org/r/121336 (owner: 10IAlex) [16:17:03] Nikerabbit: Could try, although I fear it'll trace back to "global destruction" or something unhelpful like that. [16:17:06] (03CR) 10Aaron Schulz: [C: 032] Provide RequestContext from fixDoubleRedirects [core] - 10https://gerrit.wikimedia.org/r/120325 (owner: 10MarkAHershberger) [16:19:22] (03PS7) 10Wctaiwan: Add ability to deliver to all pages in a category [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/120334 [16:19:26] (03CR) 10jenkins-bot: [V: 04-1] Add ability to deliver to all pages in a category [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/120334 (owner: 10Wctaiwan) [16:21:17] (03CR) 10Siebrand: [C: 04-1] "i18n/L10n reviewed." (031 comment) [extensions/BlueSpiceFoundation] - 10https://gerrit.wikimedia.org/r/121683 (owner: 10Smuggli) [16:21:23] (03Merged) 10jenkins-bot: Provide RequestContext from fixDoubleRedirects [core] - 10https://gerrit.wikimedia.org/r/120325 (owner: 10MarkAHershberger) [16:22:10] anomie: running with xdebug (on default settings) now [16:22:13] let's see [16:25:00] anomie: got one... but that was without your patch [16:25:16] anomie: http://pastebin.com/STKzVX0A [16:25:20] should I try with your patch? [16:27:01] (03CR) 10Siebrand: [C: 031] "i18n/L10n reviewed." [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/120334 (owner: 10Wctaiwan) [16:27:27] (03CR) 10Aaron Schulz: [C: 032] "I'd prefer that the GUI permission exceptions COMMIT, though overall this is certainly an improvement over the old behavior." [core] - 10https://gerrit.wikimedia.org/r/121402 (owner: 10Anomie) [16:30:16] anomie: well, it was just merged so I guess I just pull it [16:30:35] (03Merged) 10jenkins-bot: Improve handling of uncommitted DB txns with "uncaught" exceptions [core] - 10https://gerrit.wikimedia.org/r/121402 (owner: 10Anomie) [16:31:02] (03PS8) 10Wctaiwan: Add ability to deliver to all pages in a category [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/120334 [16:31:30] (03CR) 10Siebrand: Implemented changes for getting into translatewiki (031 comment) [extensions/BlueSpiceFoundation] - 10https://gerrit.wikimedia.org/r/121687 (owner: 10Smuggli) [16:34:24] (03PS1) 10Gerrit Patch Uploader: Follow-up I7d4bb9062. Register tracking category used. [extensions/Score] - 10https://gerrit.wikimedia.org/r/122429 [16:34:30] (03CR) 10Gerrit Patch Uploader: "This commit was uploaded using the Gerrit Patch Uploader [1]." [extensions/Score] - 10https://gerrit.wikimedia.org/r/122429 (owner: 10Gerrit Patch Uploader) [16:35:16] Nikerabbit: So your stack trace is interesting; the Database is being freed inside ob_end_flush, which makes me suspect that what's holding the DB object is in a handler passed to ob_start somewhere. [16:42:45] anomie: got another one http://pastebin.com/B88JyUbS [16:43:25] Special:UserLogin seems to do that often, but it is not reproducible [16:44:02] might help to log everything that opens a db? [16:44:17] (03CR) 10Isarra: [C: 032 V: 032] "I'm not using windows, which was why I was so confused. Hopefully it was just a one-time thing with the particular file, since otherwise I" [skins/Splash] - 10https://gerrit.wikimedia.org/r/121115 (owner: 10Isarra) [16:45:20] ebernhardson: isn't that a lot [16:47:07] Nikerabbit: perhaps, but this bug has been hitting my inbox for months [16:47:13] Nikerabbit: so maybe its warented ;) [16:47:31] (03CR) 10Siebrand: [C: 04-1] "i18n/L10n reviewed." (038 comments) [extensions/BlueSpiceFoundation] - 10https://gerrit.wikimedia.org/r/121687 (owner: 10Smuggli) [16:48:04] ebernhardson: it's been spamming our irc channel for loong time as well [16:48:48] I don't really know how to debug this, so I'm using a bit of my time trying to help [16:49:17] (03CR) 10Siebrand: [C: 04-1] "i18n/L10n reviewed." (032 comments) [wikimedia/wikimania-scholarships] - 10https://gerrit.wikimedia.org/r/122123 (owner: 10Kushal124) [16:50:54] siebrand: ^^ [16:51:12] Nikerabbit: Thanks, reading up... [16:51:18] (03CR) 10Wctaiwan: [C: 031] "Tested; fixes the bug described." [extensions/Thanks] - 10https://gerrit.wikimedia.org/r/122116 (owner: 10Bencmq) [16:52:50] Nikerabbit: That second stack trace should have been caught by the patch that was just merged. Might be helpful to hack DatabaseBase::begin to record the stack trace instead of just the calling function in mTrxFname. Then at least we might see where it's coming from. [16:53:04] anomie: uh let me see [16:53:15] anomie: do you have line number and file [16:53:24] (03Abandoned) 10Aaron Schulz: [WIP] Added "dbmsOptions" options to Database classes [core] - 10https://gerrit.wikimedia.org/r/104148 (owner: 10Aaron Schulz) [16:53:29] (03CR) 10Siebrand: Follow-up I7d4bb9062. Register tracking category used. (031 comment) [extensions/Score] - 10https://gerrit.wikimedia.org/r/122429 (owner: 10Gerrit Patch Uploader) [16:54:31] Nikerabbit: For hacking? includes/db/Database.php line 3412, append wfGetAllCallers(false) maybe [16:55:02] (03PS1) 10Gerrit Patch Uploader: Follow-up I7d4bb9062. Register tracking category used. [extensions/RSS] - 10https://gerrit.wikimedia.org/r/122430 [16:55:07] (03CR) 10Gerrit Patch Uploader: "This commit was uploaded using the Gerrit Patch Uploader [1]." [extensions/RSS] - 10https://gerrit.wikimedia.org/r/122430 (owner: 10Gerrit Patch Uploader) [16:58:03] (03PS2) 10Gerrit Patch Uploader: Follow-up I7d4bb9062. Register tracking category used. [extensions/Score] - 10https://gerrit.wikimedia.org/r/122429 [16:58:05] (03CR) 10Gerrit Patch Uploader: "This commit was uploaded using the Gerrit Patch Uploader [1]." [extensions/Score] - 10https://gerrit.wikimedia.org/r/122429 (owner: 10Gerrit Patch Uploader) [16:58:47] (03CR) 10PiRSquared17: "Fixed in PS2" [extensions/Score] - 10https://gerrit.wikimedia.org/r/122429 (owner: 10Gerrit Patch Uploader) [16:58:55] (03CR) 10PiRSquared17: "Fixed" (031 comment) [extensions/Score] - 10https://gerrit.wikimedia.org/r/122429 (owner: 10Gerrit Patch Uploader) [16:59:54] (03CR) 10Siebrand: [C: 032] Follow-up I7d4bb9062. Register tracking category used. [extensions/RSS] - 10https://gerrit.wikimedia.org/r/122430 (owner: 10Gerrit Patch Uploader) [16:59:56] (03Merged) 10jenkins-bot: Follow-up I7d4bb9062. Register tracking category used. [extensions/RSS] - 10https://gerrit.wikimedia.org/r/122430 (owner: 10Gerrit Patch Uploader) [17:00:23] (03CR) 10Siebrand: [C: 031] "i18n/L10n reviewed." [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/120334 (owner: 10Wctaiwan) [17:02:39] (03PS11) 10Wctaiwan: Change UI of special page and support Flow Thanks [extensions/Thanks] - 10https://gerrit.wikimedia.org/r/119879 [17:03:28] (03CR) 10Siebrand: [C: 032] Follow-up I7d4bb9062. Register tracking category used. [extensions/Score] - 10https://gerrit.wikimedia.org/r/122429 (owner: 10Gerrit Patch Uploader) [17:03:30] (03Merged) 10jenkins-bot: Follow-up I7d4bb9062. Register tracking category used. [extensions/Score] - 10https://gerrit.wikimedia.org/r/122429 (owner: 10Gerrit Patch Uploader) [17:09:50] (03CR) 10Aaron Schulz: [C: 04-1] Allow copying DAO objects (031 comment) [extensions/OAuth] - 10https://gerrit.wikimedia.org/r/120974 (owner: 10CSteipp) [17:10:08] (03CR) 10Aaron Schulz: [C: 032] Expose thumbnail file to extensions [core] - 10https://gerrit.wikimedia.org/r/121601 (owner: 10Gilles) [17:11:48] (03PS12) 10Wctaiwan: Change UI of special page and support Flow Thanks [extensions/Thanks] - 10https://gerrit.wikimedia.org/r/119879 [17:12:30] (03PS1) 10Siebrand: Migrate to JSON i18n [extensions/BookManager] - 10https://gerrit.wikimedia.org/r/122431 [17:13:20] (03CR) 10jenkins-bot: [V: 04-1] Migrate to JSON i18n [extensions/BookManager] - 10https://gerrit.wikimedia.org/r/122431 (owner: 10Siebrand) [17:13:31] (03Merged) 10jenkins-bot: Expose thumbnail file to extensions [core] - 10https://gerrit.wikimedia.org/r/121601 (owner: 10Gilles) [17:16:45] (03PS1) 10Siebrand: Migrate to JSON i18n [extensions/BookManagerv2] - 10https://gerrit.wikimedia.org/r/122432 [17:18:19] (03PS1) 10Siebrand: Migrate to JSON i18n [extensions/Configure] - 10https://gerrit.wikimedia.org/r/122433 [17:22:42] (03PS1) 10Aaron Schulz: Added PoolCounter use for local copy downloads [extensions/PagedTiffHandler] - 10https://gerrit.wikimedia.org/r/122434 [17:24:02] (03CR) 10MaxSem: [C: 032] Story 1732: Make licensing customizable on mobile interfaces [extensions/WikimediaMessages] - 10https://gerrit.wikimedia.org/r/121106 (owner: 10Kaldari) [17:24:04] (03CR) 10jenkins-bot: [V: 04-1] Story 1732: Make licensing customizable on mobile interfaces [extensions/WikimediaMessages] - 10https://gerrit.wikimedia.org/r/121106 (owner: 10Kaldari) [17:25:05] (03CR) 10Aaron Schulz: [C: 04-1] MWException: Fix sitename appearing twice in (032 comments) [core] - 10https://gerrit.wikimedia.org/r/118665 (owner: 10Krinkle) [17:28:31] <grrrit-wm> (03PS4) 10Kaldari: Story 1732: Make licensing customizable on mobile interfaces [extensions/WikimediaMessages] - 10https://gerrit.wikimedia.org/r/121106 [17:29:45] <grrrit-wm> (03CR) 10MaxSem: [C: 032] Story 1732: Make licensing customizable on mobile interfaces [extensions/WikimediaMessages] - 10https://gerrit.wikimedia.org/r/121106 (owner: 10Kaldari) [17:29:47] <grrrit-wm> (03Merged) 10jenkins-bot: Story 1732: Make licensing customizable on mobile interfaces [extensions/WikimediaMessages] - 10https://gerrit.wikimedia.org/r/121106 (owner: 10Kaldari) [17:31:34] <grrrit-wm> (03PS1) 10Gerrit Patch Uploader: Follow-up I7d4bb9062. Register tracking category used. [extensions/WikiArticleFeeds] - 10https://gerrit.wikimedia.org/r/122435 [17:31:39] <grrrit-wm> (03CR) 10Gerrit Patch Uploader: "This commit was uploaded using the Gerrit Patch Uploader [1]." [extensions/WikiArticleFeeds] - 10https://gerrit.wikimedia.org/r/122435 (owner: 10Gerrit Patch Uploader) [17:33:21] <grrrit-wm> (03PS2) 10Leaves in Motion: Let FauxRequest use data from a Title object [core] - 10https://gerrit.wikimedia.org/r/100952 [17:35:43] <Nikerabbit> anomie: trigger_error('Uncommitted DB writes (transaction from DatabaseBase::query (Title::getCascadeProtectionSources)|MediaWiki::run/MediaWiki::main/MediaWiki::performRequest/SpecialPageFactory::executePath/SpecialPage::run/LoginForm::execute/LoginForm::mainLoginForm/Title::getUserPermissionsErrors/Title::getUserPermissionsErrorsInternal/Title::checkCascadingSourcesRestrictions/Title::getCascadeProtectionSources/DatabaseBase::select/Databa [17:37:22] <anomie> Nikerabbit: Hmm. I'm lost as to why that's not getting rolled back. [17:38:30] <grrrit-wm> (03CR) 10KartikMistry: WIP: Added initial rot13Tests (031 comment) [services/cxserver] - 10https://gerrit.wikimedia.org/r/122424 (owner: 10KartikMistry) [17:38:54] <Nikerabbit> anomie: and why it happens only sometimes [17:40:58] <Nikerabbit> anomie: anything more I can provide, or can I rollback debugging? [17:41:07] <anomie> Nikerabbit: Go ahead and roll back [17:41:09] <grrrit-wm> (03CR) 10Swalling: "Buttons look good, but for some reason I got an error message https://dpaste.de/SKom" [core] - 10https://gerrit.wikimedia.org/r/121975 (owner: 10Ganeshaditya1) [17:41:48] <grrrit-wm> (03CR) 10Leaves in Motion: "I'm not sure this is the right way but this way the canonical url is correct for old revisions etc." [core] - 10https://gerrit.wikimedia.org/r/100952 (owner: 10Leaves in Motion) [17:45:26] <grrrit-wm> (03CR) 10Aaron Schulz: [C: 032] API: Allow for format modules that cannot handle errors [core] - 10https://gerrit.wikimedia.org/r/121381 (owner: 10Anomie) [17:48:20] <grrrit-wm> (03CR) 10Siebrand: [C: 032 V: 032] Follow-up I7d4bb9062. Register tracking category used. [extensions/WikiArticleFeeds] - 10https://gerrit.wikimedia.org/r/122435 (owner: 10Gerrit Patch Uploader) [17:48:48] <grrrit-wm> (03Merged) 10jenkins-bot: API: Allow for format modules that cannot handle errors [core] - 10https://gerrit.wikimedia.org/r/121381 (owner: 10Anomie) [17:55:40] <grrrit-wm> (03CR) 10Aaron Schulz: "I guess for robustness it should still have some sort of rollback mechanism. This needs to be rebased to use Brad's changes. It should jus" [core] - 10https://gerrit.wikimedia.org/r/119932 (owner: 10Brian Wolff) [17:57:56] <grrrit-wm> (03PS1) 10Gerrit Patch Uploader: Follow-up I7d4bb9062. Register tracking category used. [extensions/AJAXPoll] - 10https://gerrit.wikimedia.org/r/122441 [17:58:02] <grrrit-wm> (03CR) 10Gerrit Patch Uploader: "This commit was uploaded using the Gerrit Patch Uploader [1]." [extensions/AJAXPoll] - 10https://gerrit.wikimedia.org/r/122441 (owner: 10Gerrit Patch Uploader) [17:58:32] <grrrit-wm> (03PS2) 10Bsitu: Fix double entries in Special:Contributions [extensions/Flow] - 10https://gerrit.wikimedia.org/r/122417 (owner: 10Matthias Mullie) [18:00:02] <grrrit-wm> (03CR) 10Bencmq: "I wonder who I should ask for review for I3adb60d5b1c75500f8276cda8b8eaa2646bb1565 , which should probably be merged together with this so" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/119812 (owner: 10Bencmq) [18:00:08] <grrrit-wm> (03CR) 10Bsitu: [C: 032] Fix double entries in Special:Contributions [extensions/Flow] - 10https://gerrit.wikimedia.org/r/122417 (owner: 10Matthias Mullie) [18:00:32] <grrrit-wm> (03Merged) 10jenkins-bot: Fix double entries in Special:Contributions [extensions/Flow] - 10https://gerrit.wikimedia.org/r/122417 (owner: 10Matthias Mullie) [18:02:53] <grrrit-wm> (03PS1) 10Aude: Adjust margin between h2 and special page table element [core] - 10https://gerrit.wikimedia.org/r/122442 [18:05:52] <grrrit-wm> (03CR) 10Divec: [C: 032] Add module assert for devdependencies [services/cxserver] - 10https://gerrit.wikimedia.org/r/122354 (owner: 10KartikMistry) [18:05:56] <grrrit-wm> (03Merged) 10jenkins-bot: Add module assert for devdependencies [services/cxserver] - 10https://gerrit.wikimedia.org/r/122354 (owner: 10KartikMistry) [18:05:58] <grrrit-wm> (03CR) 10Aude: "should probably be backported." [core] - 10https://gerrit.wikimedia.org/r/122442 (owner: 10Aude) [18:09:06] <grrrit-wm> (03PS3) 10CSteipp: Allow telling DAO objects they are dirty [extensions/OAuth] - 10https://gerrit.wikimedia.org/r/120974 [18:12:35] <grrrit-wm> (03PS2) 10Aude: Adjust margin between h2 and special page table element [core] - 10https://gerrit.wikimedia.org/r/122442 [18:13:03] <grrrit-wm> (03PS3) 10Aude: Adjust margin between h2 and special page table element [core] - 10https://gerrit.wikimedia.org/r/122442 [18:13:10] <grrrit-wm> (03PS2) 10CSteipp: Add maintenance script to copy db tables [extensions/OAuth] - 10https://gerrit.wikimedia.org/r/121131 [18:14:15] <grrrit-wm> (03CR) 10Aaron Schulz: [C: 032] Allow telling DAO objects they are dirty [extensions/OAuth] - 10https://gerrit.wikimedia.org/r/120974 (owner: 10CSteipp) [18:14:47] <grrrit-wm> (03Merged) 10jenkins-bot: Allow telling DAO objects they are dirty [extensions/OAuth] - 10https://gerrit.wikimedia.org/r/120974 (owner: 10CSteipp) [18:15:21] <grrrit-wm> (03CR) 10Aaron Schulz: Add maintenance script to copy db tables (031 comment) [extensions/OAuth] - 10https://gerrit.wikimedia.org/r/121131 (owner: 10CSteipp) [18:16:32] <grrrit-wm> (03CR) 10Swalling: "WFM in Chrome (screenshot: http://i.imgur.com/bWPRAyz.png) and FF. Should be backported for sure." [core] - 10https://gerrit.wikimedia.org/r/122442 (owner: 10Aude) [18:16:56] <grrrit-wm> (03CR) 10Swalling: [C: 031] "Forgot to properly +1. ;)" [core] - 10https://gerrit.wikimedia.org/r/122442 (owner: 10Aude) [18:17:18] <StevenW> kaldari: ^ [18:17:52] <grrrit-wm> (03PS1) 10Siebrand: Migrate to JSON i18n [extensions/ConfirmAccount] - 10https://gerrit.wikimedia.org/r/122444 [18:19:53] <grrrit-wm> (03CR) 10Kaldari: [C: 032] Adjust margin between h2 and special page table element [core] - 10https://gerrit.wikimedia.org/r/122442 (owner: 10Aude) [18:21:12] <grrrit-wm> (03PS1) 10Siebrand: Migrate to JSON i18n [extensions/CongressLookup] - 10https://gerrit.wikimedia.org/r/122447 [18:21:18] <grrrit-wm> (03CR) 10Bsitu: [Schema Change]Add column rev_type_id to table flow_revision (031 comment) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/116861 (owner: 10Bsitu) [18:22:09] <ori> MatmaRex: https://gerrit.wikimedia.org/r/#/c/120757/ & https://gerrit.wikimedia.org/r/#/c/120957/ pretty please? [18:22:58] <grrrit-wm> (03PS2) 10Siebrand: Migrate to JSON i18n [extensions/CongressLookup] - 10https://gerrit.wikimedia.org/r/122447 [18:23:08] <grrrit-wm> (03Merged) 10jenkins-bot: Adjust margin between h2 and special page table element [core] - 10https://gerrit.wikimedia.org/r/122442 (owner: 10Aude) [18:23:54] <MatmaRex> ori: more minutes an hour pretty please ;_; [18:24:25] <grrrit-wm> (03PS9) 10Ganeshaditya1: ChangeEmail special page rewritten to use vforms. [core] - 10https://gerrit.wikimedia.org/r/121975 [18:25:03] <MatmaRex> ori: i can +2 if you want me to, but at this point it'd just be simpler for you to +2 yourself ;) [18:25:16] <ori> MatmaRex: coud you please? [18:25:29] <ori> could, even [18:26:16] <grrrit-wm> (03PS1) 10PleaseStand: Make MagicWordArray compatible with PCRE 8.34+ [core] (REL1_19) - 10https://gerrit.wikimedia.org/r/122449 [18:26:25] <grrrit-wm> (03PS8) 10Ori.livneh: Allow EventLogging events to be logged via mw#track [extensions/EventLogging] - 10https://gerrit.wikimedia.org/r/120757 [18:26:27] <grrrit-wm> (03PS3) 10Ori.livneh: Allow schema registration via custom hook [extensions/EventLogging] - 10https://gerrit.wikimedia.org/r/120957 [18:27:01] <grrrit-wm> (03PS1) 10PleaseStand: Make MagicWordArray compatible with PCRE 8.34+ [core] (REL1_21) - 10https://gerrit.wikimedia.org/r/122450 [18:28:03] <MatmaRex> ori: alrighty [18:28:09] <ori> <3 [18:28:52] <MatmaRex> as soon as gerrit loads for me… [18:29:09] <MatmaRex> is the pile of junk down again? [18:29:18] <grrrit-wm> (03CR) 10Ganeshaditya1: "My bad .. accidental removed the second argument. Try it now." [core] - 10https://gerrit.wikimedia.org/r/121975 (owner: 10Ganeshaditya1) [18:30:47] <ori> not for me [18:30:55] <grrrit-wm> (03CR) 10Bartosz Dziewoński: [C: 032] "Looks reasonable and I trust that Ori knows what he's doing." [extensions/EventLogging] - 10https://gerrit.wikimedia.org/r/120757 (owner: 10Ori.livneh) [18:30:57] <grrrit-wm> (03CR) 10Bartosz Dziewoński: [C: 032] "Looks reasonable and I trust that Ori knows what he's doing." [extensions/EventLogging] - 10https://gerrit.wikimedia.org/r/120957 (owner: 10Ori.livneh) [18:31:07] <ori> MatmaRex: <3 <3 [18:31:13] <ori> thanks, I really appreciatei t. [18:31:16] <ori> appreciate it. [18:31:35] <MatmaRex> ori: you guys totally need more engineers or something. :P [18:31:58] <grrrit-wm> (03Merged) 10jenkins-bot: Allow EventLogging events to be logged via mw#track [extensions/EventLogging] - 10https://gerrit.wikimedia.org/r/120757 (owner: 10Ori.livneh) [18:32:40] <ori> we need more MatmaRexes [18:32:47] <grrrit-wm> (03CR) 10jenkins-bot: [V: 04-1] Allow schema registration via custom hook [extensions/EventLogging] - 10https://gerrit.wikimedia.org/r/120957 (owner: 10Ori.livneh) [18:32:59] <grrrit-wm> (03PS16) 10Bsitu: [Schema Change]Add column rev_type_id to table flow_revision [extensions/Flow] - 10https://gerrit.wikimedia.org/r/116861 [18:33:11] <MatmaRex> i need more MatmaRexes too, i don't have enough time to do stuff by myself. D: [18:33:26] <MatmaRex> stupid useless university, right? [18:35:00] <grrrit-wm> (03PS1) 10Gerrit Patch Uploader: Follow-up I7d4bb9062. Register tracking category used. [extensions/EtherpadLite] - 10https://gerrit.wikimedia.org/r/122452 [18:35:05] <grrrit-wm> (03CR) 10Gerrit Patch Uploader: "This commit was uploaded using the Gerrit Patch Uploader [1]." [extensions/EtherpadLite] - 10https://gerrit.wikimedia.org/r/122452 (owner: 10Gerrit Patch Uploader) [18:35:31] <grrrit-wm> (03CR) 10Krinkle: [C: 04-1] Fix error in IE < 9 (031 comment) [core] - 10https://gerrit.wikimedia.org/r/122408 (owner: 10Gilles) [18:35:39] <YuviPanda> prtksxna: around? [18:35:39] <grrrit-wm> (03PS4) 10Ori.livneh: Allow schema registration via custom hook [extensions/EventLogging] - 10https://gerrit.wikimedia.org/r/120957 [18:36:47] <grrrit-wm> (03CR) 10Ori.livneh: [C: 032] "Rebased; +2 per Matmarex's +2." [extensions/EventLogging] - 10https://gerrit.wikimedia.org/r/120957 (owner: 10Ori.livneh) [18:38:27] <grrrit-wm> (03CR) 10Jdlrobson: "Mark when will 1.23 be cut? My main worry is this patch will go stable and eventually get abandoned. Are we talking months, years, weeks o" [core] - 10https://gerrit.wikimedia.org/r/118345 (owner: 10Jdlrobson) [18:39:23] <grrrit-wm> (03Merged) 10jenkins-bot: Allow schema registration via custom hook [extensions/EventLogging] - 10https://gerrit.wikimedia.org/r/120957 (owner: 10Ori.livneh) [18:39:59] <grrrit-wm> (03CR) 10Chad: [C: 032] Added PoolCounter use for local copy downloads [extensions/PagedTiffHandler] - 10https://gerrit.wikimedia.org/r/122434 (owner: 10Aaron Schulz) [18:40:25] <grrrit-wm> (03PS1) 10CSteipp: Allow updating DAO Origin [extensions/OAuth] - 10https://gerrit.wikimedia.org/r/122453 [18:41:01] <grrrit-wm> (03Merged) 10jenkins-bot: Added PoolCounter use for local copy downloads [extensions/PagedTiffHandler] - 10https://gerrit.wikimedia.org/r/122434 (owner: 10Aaron Schulz) [18:42:11] <grrrit-wm> (03PS1) 10Siebrand: Migrate to JSON i18n [extensions/examples] - 10https://gerrit.wikimedia.org/r/122455 [18:42:24] <grrrit-wm> (03CR) 10Aaron Schulz: [C: 031] Move Modern and CologneBlue out of core [core] - 10https://gerrit.wikimedia.org/r/118345 (owner: 10Jdlrobson) [18:43:43] <grrrit-wm> (03CR) 10Aaron Schulz: [C: 04-1] Allow updating DAO Origin (031 comment) [extensions/OAuth] - 10https://gerrit.wikimedia.org/r/122453 (owner: 10CSteipp) [18:46:09] <grrrit-wm> (03PS1) 10Siebrand: Migrate to JSON i18n [extensions/ExtTab] - 10https://gerrit.wikimedia.org/r/122456 [18:47:42] <grrrit-wm> (03PS2) 10CSteipp: Allow updating DAO Origin [extensions/OAuth] - 10https://gerrit.wikimedia.org/r/122453 [18:47:58] <grrrit-wm> (03PS6) 10Krinkle: MWException: Fix sitename appearing twice in <title> [core] - 10https://gerrit.wikimedia.org/r/118665 [18:52:20] <grrrit-wm> (03CR) 10Manybubbles: [C: 032] Updated readme file [ruby/api] - 10https://gerrit.wikimedia.org/r/122351 (owner: 10Zfilipin) [18:52:23] <grrrit-wm> (03Merged) 10jenkins-bot: Updated readme file [ruby/api] - 10https://gerrit.wikimedia.org/r/122351 (owner: 10Zfilipin) [18:53:00] <grrrit-wm> (03PS2) 10Siebrand: Migrate to JSON i18n [extensions/BookManager] - 10https://gerrit.wikimedia.org/r/122431 [18:53:09] <grrrit-wm> (03CR) 10jenkins-bot: [V: 04-1] Migrate to JSON i18n [extensions/BookManager] - 10https://gerrit.wikimedia.org/r/122431 (owner: 10Siebrand) [18:53:17] <grrrit-wm> (03CR) 10Krinkle: "Addressed issues." [core] - 10https://gerrit.wikimedia.org/r/118665 (owner: 10Krinkle) [18:53:49] <grrrit-wm> (03CR) 10Siebrand: "The jslint failure is not related to the contents of this patch set." [extensions/BookManager] - 10https://gerrit.wikimedia.org/r/122431 (owner: 10Siebrand) [18:55:01] <grrrit-wm> (03CR) 10Raimond Spekking: [C: 032] Migrate to JSON i18n [extensions/BookManager] - 10https://gerrit.wikimedia.org/r/122431 (owner: 10Siebrand) [18:55:10] <grrrit-wm> (03CR) 10jenkins-bot: [V: 04-1] Migrate to JSON i18n [extensions/BookManager] - 10https://gerrit.wikimedia.org/r/122431 (owner: 10Siebrand) [18:56:28] <grrrit-wm> (03CR) 10Raimond Spekking: [C: 032 V: 032] Migrate to JSON i18n [extensions/ExtTab] - 10https://gerrit.wikimedia.org/r/122456 (owner: 10Siebrand) [18:57:05] <ori> qgil: hey, can you accept my request to connect w/wikimedia on http://www.google-melange.com/ ? my username is 'atdt' [18:58:32] <grrrit-wm> (03CR) 10Raimond Spekking: [C: 04-1] Migrate to JSON i18n (031 comment) [extensions/examples] - 10https://gerrit.wikimedia.org/r/122455 (owner: 10Siebrand) [18:58:38] <qgil> ori, you were faster than Melange's notification system. :) Done. [18:58:50] <ori> qgil: many thanks :) [18:59:00] <qgil> ori, which project do you want to mentor? [18:59:08] <grrrit-wm> (03CR) 10Raimond Spekking: [C: 032 V: 032] Migrate to JSON i18n [extensions/CongressLookup] - 10https://gerrit.wikimedia.org/r/122447 (owner: 10Siebrand) [18:59:27] <grrrit-wm> (03PS1) 10Bsitu: formatter.revision is not defined [extensions/Flow] - 10https://gerrit.wikimedia.org/r/122458 [18:59:30] <grrrit-wm> (03PS2) 10Siebrand: Migrate to JSON i18n [extensions/examples] - 10https://gerrit.wikimedia.org/r/122455 [18:59:54] <grrrit-wm> (03CR) 10Siebrand: [V: 032] "Ignore Jenkins." [extensions/BookManager] - 10https://gerrit.wikimedia.org/r/122431 (owner: 10Siebrand) [19:00:17] <grrrit-wm> (03CR) 10Raimond Spekking: [C: 032 V: 032] Migrate to JSON i18n [extensions/ConfirmAccount] - 10https://gerrit.wikimedia.org/r/122444 (owner: 10Siebrand) [19:01:15] <grrrit-wm> (03CR) 10Raimond Spekking: [C: 032 V: 032] Migrate to JSON i18n [extensions/examples] - 10https://gerrit.wikimedia.org/r/122455 (owner: 10Siebrand) [19:02:39] <grrrit-wm> (03CR) 10EBernhardson: [C: 032] formatter.revision is not defined [extensions/Flow] - 10https://gerrit.wikimedia.org/r/122458 (owner: 10Bsitu) [19:02:45] <grrrit-wm> (03CR) 10Raimond Spekking: [C: 032 V: 032] Migrate to JSON i18n [extensions/Configure] - 10https://gerrit.wikimedia.org/r/122433 (owner: 10Siebrand) [19:02:53] <grrrit-wm> (03CR) 10jenkins-bot: [V: 04-1] formatter.revision is not defined [extensions/Flow] - 10https://gerrit.wikimedia.org/r/122458 (owner: 10Bsitu) [19:04:22] <grrrit-wm> (03CR) 10EBernhardson: [V: 032] "test failure is unrelated" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/122458 (owner: 10Bsitu) [19:04:47] <grrrit-wm> (03CR) 10Raimond Spekking: [C: 032 V: 032] Migrate to JSON i18n [extensions/BookManagerv2] - 10https://gerrit.wikimedia.org/r/122432 (owner: 10Siebrand) [19:04:57] <ori> qgil: MatmaRex's [19:05:13] <ori> qgil: I updated the list on mw.org and indicated the wish to mentor on Google's site [19:05:14] <qgil> ori, good news. :) [19:05:16] <MatmaRex> hi qgil [19:05:32] <MatmaRex> i just replied on the talk page too https://www.mediawiki.org/wiki/User_talk:Matma_Rex/Separating_skins_from_core_MediaWiki#Mentors [19:06:35] <ori> jdlrobson: ^ [19:06:38] <qgil> MatmaRex, thank you. I understand, and I hope you understand my role as gatekeeper. :) [19:06:45] <grrrit-wm> (03CR) 10Raimond Spekking: [C: 032 V: 032] Implemented changes for getting into translatewiki [extensions/BlueSpiceFoundation] - 10https://gerrit.wikimedia.org/r/121685 (owner: 10Smuggli) [19:06:53] <MatmaRex> qgil: of course :) [19:07:01] <grrrit-wm> (03CR) 10Siebrand: [C: 04-1] "i18n/L10n reviewed." (031 comment) [extensions/EtherpadLite] - 10https://gerrit.wikimedia.org/r/122452 (owner: 10Gerrit Patch Uploader) [19:08:07] <grrrit-wm> (03CR) 10Siebrand: "So what's needed to establish that this indeed adds support for JSON based i18n files and get it merged?" [extensions/MwEmbedSupport] - 10https://gerrit.wikimedia.org/r/121950 (owner: 10Siebrand) [19:08:26] <grrrit-wm> (03PS3) 10Siebrand: Implemented changes for getting into translatewiki [extensions/BlueSpiceFoundation] - 10https://gerrit.wikimedia.org/r/121684 (owner: 10Smuggli) [19:08:36] <grrrit-wm> (03CR) 10Siebrand: [C: 032] Implemented changes for getting into translatewiki [extensions/BlueSpiceFoundation] - 10https://gerrit.wikimedia.org/r/121684 (owner: 10Smuggli) [19:12:20] <grrrit-wm> (03CR) 10Divec: Testing infrastructure (036 comments) [services/cxserver] - 10https://gerrit.wikimedia.org/r/121899 (owner: 10Divec) [19:17:43] <grrrit-wm> (03CR) 10PiRSquared17: Follow-up I7d4bb9062. Register tracking category used. (031 comment) [extensions/EtherpadLite] - 10https://gerrit.wikimedia.org/r/122452 (owner: 10Gerrit Patch Uploader) [19:21:28] <grrrit-wm> (03PS1) 10Ori.livneh: Add $wgEventLoggingSchemas [extensions/EventLogging] - 10https://gerrit.wikimedia.org/r/122459 [19:32:08] <grrrit-wm> (03PS1) 10Ori.livneh: Rename efLogServerSideEvent -> efLogEvent; deprecate former [extensions/EventLogging] - 10https://gerrit.wikimedia.org/r/122462 [19:38:38] <grrrit-wm> (03CR) 10Aaron Schulz: [C: 032] Allow updating DAO Origin [extensions/OAuth] - 10https://gerrit.wikimedia.org/r/122453 (owner: 10CSteipp) [19:38:44] <grrrit-wm> (03Merged) 10jenkins-bot: Allow updating DAO Origin [extensions/OAuth] - 10https://gerrit.wikimedia.org/r/122453 (owner: 10CSteipp) [19:39:39] <grrrit-wm> (03CR) 10Siebrand: Follow-up I7d4bb9062. Register tracking category used. (031 comment) [extensions/EtherpadLite] - 10https://gerrit.wikimedia.org/r/122452 (owner: 10Gerrit Patch Uploader) [19:40:46] <grrrit-wm> (03PS2) 10Bsitu: formatter.revision is not defined [extensions/Flow] - 10https://gerrit.wikimedia.org/r/122458 [19:41:02] <grrrit-wm> (03CR) 10jenkins-bot: [V: 04-1] formatter.revision is not defined [extensions/Flow] - 10https://gerrit.wikimedia.org/r/122458 (owner: 10Bsitu) [19:45:53] <grrrit-wm> (03CR) 10Siebrand: Follow-up I7d4bb9062. Register tracking category used. (031 comment) [extensions/EtherpadLite] - 10https://gerrit.wikimedia.org/r/122452 (owner: 10Gerrit Patch Uploader) [19:46:11] <grrrit-wm> (03PS3) 10Bsitu: formatter.revision is not defined [extensions/Flow] - 10https://gerrit.wikimedia.org/r/122458 [19:47:32] <grrrit-wm> (03CR) 10Siebrand: [C: 04-1] "i18n/L10n reviewed." (031 comment) [extensions/AJAXPoll] - 10https://gerrit.wikimedia.org/r/122441 (owner: 10Gerrit Patch Uploader) [19:52:47] <grrrit-wm> (03CR) 10Bsitu: [C: 032] formatter.revision is not defined [extensions/Flow] - 10https://gerrit.wikimedia.org/r/122458 (owner: 10Bsitu) [19:52:59] <grrrit-wm> (03Merged) 10jenkins-bot: formatter.revision is not defined [extensions/Flow] - 10https://gerrit.wikimedia.org/r/122458 (owner: 10Bsitu) [19:55:30] <grrrit-wm> (03CR) 10Aaron Schulz: "Seems the same" [core] - 10https://gerrit.wikimedia.org/r/118665 (owner: 10Krinkle) [19:57:24] <grrrit-wm> (03PS17) 10Bsitu: [Schema Change]Add column rev_type_id to table flow_revision [extensions/Flow] - 10https://gerrit.wikimedia.org/r/116861 [19:59:39] <grrrit-wm> (03PS1) 10Foxtrott: bugfix (dependencies have to be loaded first); some formatting [extensions/Bootstrap] - 10https://gerrit.wikimedia.org/r/122465 [20:03:00] <grrrit-wm> (03PS1) 10Foxtrott: fix html class of main content [skins/chameleon] - 10https://gerrit.wikimedia.org/r/122466 [20:04:49] <grrrit-wm> (03CR) 10Foxtrott: [C: 032 V: 032] bugfix (dependencies have to be loaded first); some formatting [extensions/Bootstrap] - 10https://gerrit.wikimedia.org/r/122465 (owner: 10Foxtrott) [20:05:17] <grrrit-wm> (03CR) 10Foxtrott: [C: 032 V: 032] fix html class of main content [skins/chameleon] - 10https://gerrit.wikimedia.org/r/122466 (owner: 10Foxtrott) [20:15:16] <grrrit-wm> (03PS2) 10Gerrit Patch Uploader: Follow-up I7d4bb9062. Register tracking category used. [extensions/EtherpadLite] - 10https://gerrit.wikimedia.org/r/122452 [20:15:18] <grrrit-wm> (03CR) 10Gerrit Patch Uploader: "This commit was uploaded using the Gerrit Patch Uploader [1]." [extensions/EtherpadLite] - 10https://gerrit.wikimedia.org/r/122452 (owner: 10Gerrit Patch Uploader) [20:23:05] <grrrit-wm> (03CR) 10Mattflaschen: "The only part of this that was reverted is the width change." [extensions/GettingStarted] - 10https://gerrit.wikimedia.org/r/103740 (owner: 10Mattflaschen) [20:28:16] <grrrit-wm> (03PS15) 10Bsitu: Update column data: flow_revision.rev_type_id [extensions/Flow] - 10https://gerrit.wikimedia.org/r/116874 [20:29:55] <grrrit-wm> (03CR) 10Bartosz Dziewoński: [C: 031] Cache RecentChanges Atom feed in varnish for 15 seconds [core] - 10https://gerrit.wikimedia.org/r/121912 (owner: 10Brian Wolff) [20:36:20] <grrrit-wm> (03PS2) 10Divec: Testing infrastructure [services/cxserver] - 10https://gerrit.wikimedia.org/r/121899 [20:36:25] <grrrit-wm> (03CR) 10jenkins-bot: [V: 04-1] Testing infrastructure [services/cxserver] - 10https://gerrit.wikimedia.org/r/121899 (owner: 10Divec) [20:39:40] <grrrit-wm> (03PS1) 10Aaron Schulz: Speed up LocalFile locking behavoir [core] - 10https://gerrit.wikimedia.org/r/122550 [20:39:44] <grrrit-wm> (03PS1) 10Chad: Fix incorrect hook usage, second parameter is a reference [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/122551 [20:44:35] <grrrit-wm> (03PS3) 10Mwalker: Better WorldPay form settings (but only for testing) [core] (fundraising/REL1_22) - 10https://gerrit.wikimedia.org/r/121504 [20:44:41] <grrrit-wm> (03PS3) 10Phuedx: Update copy [extensions/GettingStarted] - 10https://gerrit.wikimedia.org/r/119972 [20:45:31] <grrrit-wm> (03PS3) 10Divec: Testing infrastructure [services/cxserver] - 10https://gerrit.wikimedia.org/r/121899 [20:47:37] <grrrit-wm> (03PS17) 10Bsitu: Update post/header revision storage search key [extensions/Flow] - 10https://gerrit.wikimedia.org/r/117099 [20:48:12] <grrrit-wm> (03PS7) 10Krinkle: MWException: Fix sitename appearing twice in <title> [core] - 10https://gerrit.wikimedia.org/r/118665 [20:48:26] <grrrit-wm> (03CR) 10Krinkle: "Forgot to actually push. This is the one." [core] - 10https://gerrit.wikimedia.org/r/118665 (owner: 10Krinkle) [20:51:16] <grrrit-wm> (03CR) 10BryanDavis: [C: 04-1] "Great work Kushal. Address Siebrand's notes and a few small changes I pointed out and we should be able to get this merged." (035 comments) [wikimedia/wikimania-scholarships] - 10https://gerrit.wikimedia.org/r/122123 (owner: 10Kushal124) [20:51:18] <grrrit-wm> (03PS1) 10Kaldari: Adding debugging for bug 62241 [core] - 10https://gerrit.wikimedia.org/r/122554 [20:51:20] <grrrit-wm> (03CR) 10Aaron Schulz: [C: 032] MWException: Fix sitename appearing twice in <title> [core] - 10https://gerrit.wikimedia.org/r/118665 (owner: 10Krinkle) [20:53:08] <grrrit-wm> (03CR) 10jenkins-bot: [V: 04-1] Adding debugging for bug 62241 [core] - 10https://gerrit.wikimedia.org/r/122554 (owner: 10Kaldari) [20:53:23] <grrrit-wm> (03PS2) 10Aaron Schulz: Speed up LocalFile locking behavior [core] - 10https://gerrit.wikimedia.org/r/122550 [20:54:11] <grrrit-wm> (03PS2) 10Kaldari: Adding debugging for bug 62241 [core] - 10https://gerrit.wikimedia.org/r/122554 [20:55:01] <grrrit-wm> (03PS1) 10Krinkle: Add .jshintrc file [extensions/BookManager] - 10https://gerrit.wikimedia.org/r/122557 [20:55:03] <grrrit-wm> (03PS1) 10Krinkle: Fix jshint violations, minor clean up [extensions/BookManager] - 10https://gerrit.wikimedia.org/r/122558 [20:55:10] <grrrit-wm> (03PS18) 10Bsitu: Update post/header revision storage search key [extensions/Flow] - 10https://gerrit.wikimedia.org/r/117099 [20:55:13] <grrrit-wm> (03CR) 10Siebrand: [C: 04-1] "Per issues pointed out on previous patch set(s)." [extensions/GettingStarted] - 10https://gerrit.wikimedia.org/r/119972 (owner: 10Phuedx) [20:56:35] <grrrit-wm> (03CR) 10jenkins-bot: [V: 04-1] Add .jshintrc file [extensions/BookManager] - 10https://gerrit.wikimedia.org/r/122557 (owner: 10Krinkle) [20:56:40] <grrrit-wm> (03Merged) 10jenkins-bot: MWException: Fix sitename appearing twice in <title> [core] - 10https://gerrit.wikimedia.org/r/118665 (owner: 10Krinkle) [20:57:07] <grrrit-wm> (03CR) 10Krinkle: [C: 032 V: 032] Add .jshintrc file [extensions/BookManager] - 10https://gerrit.wikimedia.org/r/122557 (owner: 10Krinkle) [20:58:03] <grrrit-wm> (03CR) 10Siebrand: [C: 032 V: 032] Follow-up I7d4bb9062. Register tracking category used. [extensions/EtherpadLite] - 10https://gerrit.wikimedia.org/r/122452 (owner: 10Gerrit Patch Uploader) [20:59:08] <grrrit-wm> (03CR) 10jenkins-bot: [V: 04-1] Speed up LocalFile locking behavior [core] - 10https://gerrit.wikimedia.org/r/122550 (owner: 10Aaron Schulz) [20:59:10] <grrrit-wm> (03CR) 10jenkins-bot: [V: 04-1] Adding debugging for bug 62241 [core] - 10https://gerrit.wikimedia.org/r/122554 (owner: 10Kaldari) [20:59:21] <grrrit-wm> (03CR) 10Siebrand: [C: 032] Fix jshint violations, minor clean up [extensions/BookManager] - 10https://gerrit.wikimedia.org/r/122558 (owner: 10Krinkle) [20:59:40] <grrrit-wm> (03Merged) 10jenkins-bot: Fix jshint violations, minor clean up [extensions/BookManager] - 10https://gerrit.wikimedia.org/r/122558 (owner: 10Krinkle) [21:00:32] <grrrit-wm> (03PS2) 10Gilles: Fix error caused by mw.log in IE < 9 [core] - 10https://gerrit.wikimedia.org/r/122408 [21:04:45] <grrrit-wm> (03PS3) 10Kaldari: Adding debugging for bug 62241 [core] - 10https://gerrit.wikimedia.org/r/122554 [21:15:02] <grrrit-wm> (03CR) 10Daniel Kinzler: "@Stepzhou: well, ULS has selenium tests, and they should pass. But that only tells us you are not breaking ULS. The real question is wheth" [core] - 10https://gerrit.wikimedia.org/r/120475 (owner: 10Stepzhou) [21:17:51] <grrrit-wm> (03PS1) 10TheDJ: [WIP] Add timestamp of block to blockinfo [core] - 10https://gerrit.wikimedia.org/r/122566 [21:19:24] <grrrit-wm> (03CR) 10jenkins-bot: [V: 04-1] [WIP] Add timestamp of block to blockinfo [core] - 10https://gerrit.wikimedia.org/r/122566 (owner: 10TheDJ) [21:23:10] <grrrit-wm> (03CR) 10Krinkle: Convert from show()/hide() to using classes (034 comments) [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/120472 (owner: 10TheDJ) [21:27:52] <grrrit-wm> (03CR) 10Manybubbles: "I'm happy to fix it, but why does it work for us now?" [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/122551 (owner: 10Chad) [21:30:19] <grrrit-wm> (03CR) 10TheDJ: Convert from show()/hide() to using classes (031 comment) [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/120472 (owner: 10TheDJ) [21:45:07] <grrrit-wm> (03PS17) 10Bsitu: Drop table: flow_header_revision [extensions/Flow] - 10https://gerrit.wikimedia.org/r/117115 [21:45:25] <grrrit-wm> (03CR) 10jenkins-bot: [V: 04-1] Drop table: flow_header_revision [extensions/Flow] - 10https://gerrit.wikimedia.org/r/117115 (owner: 10Bsitu) [21:45:38] <grrrit-wm> (03CR) 10Bsitu: Drop table: flow_header_revision (031 comment) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/117115 (owner: 10Bsitu) [21:46:19] <grrrit-wm> (03PS18) 10Bsitu: Drop table: flow_header_revision [extensions/Flow] - 10https://gerrit.wikimedia.org/r/117115 [21:46:33] <grrrit-wm> (03CR) 10jenkins-bot: [V: 04-1] Drop table: flow_header_revision [extensions/Flow] - 10https://gerrit.wikimedia.org/r/117115 (owner: 10Bsitu) [21:48:33] <grrrit-wm> (03PS19) 10Bsitu: Drop table: flow_header_revision [extensions/Flow] - 10https://gerrit.wikimedia.org/r/117115 [21:54:27] <superm401> spagewmf, can you take a look at https://gerrit.wikimedia.org/r/#/c/121842/ when you have a chance. I'm inclined to merge, just wanted to see if you think I'm missing something. [22:03:12] <grrrit-wm> (03CR) 10Chad: "The & isn't really necessary since it's an object and we use PHP5. But it's a one-line change to be consistent with the hook definition." [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/122551 (owner: 10Chad) [22:05:00] <spagewmf> superm401, the problem was which of its children should mw-ui-vform whip into shape. By only affecting immediate divs of the vform, other things inside the form would not get big blocky layout (e.g. login form's language links and its CTA). But there are many ways to override and it's not clear what the default behavior should be. [22:06:28] <superm401> spagewmf, thanks, do you want to comment there? If not, I can just quote you. [22:09:52] <grrrit-wm> (03CR) 10Kaldari: [C: 04-1] Make results cacheable (031 comment) [extensions/PageImages] - 10https://gerrit.wikimedia.org/r/121932 (owner: 10MaxSem) [22:10:09] <grrrit-wm> (03PS5) 10TheDJ: Convert from show()/hide() to using classes [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/120472 [22:11:01] <grrrit-wm> (03CR) 10Kaldari: [C: 04-1] Make results cacheable (031 comment) [extensions/TextExtracts] - 10https://gerrit.wikimedia.org/r/121933 (owner: 10MaxSem) [22:11:26] <grrrit-wm> (03CR) 10TheDJ: Convert from show()/hide() to using classes (032 comments) [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/120472 (owner: 10TheDJ) [22:16:17] <grrrit-wm> (03PS2) 10MaxSem: Make results cacheable [extensions/TextExtracts] - 10https://gerrit.wikimedia.org/r/121933 [22:16:28] <grrrit-wm> (03PS2) 10MaxSem: Make results cacheable [extensions/PageImages] - 10https://gerrit.wikimedia.org/r/121932 [22:17:14] <grrrit-wm> (03CR) 10Kaldari: [C: 032] Make results cacheable [extensions/PageImages] - 10https://gerrit.wikimedia.org/r/121932 (owner: 10MaxSem) [22:17:16] <grrrit-wm> (03Merged) 10jenkins-bot: Make results cacheable [extensions/PageImages] - 10https://gerrit.wikimedia.org/r/121932 (owner: 10MaxSem) [22:17:40] <grrrit-wm> (03CR) 10Kaldari: [C: 032] Make results cacheable [extensions/TextExtracts] - 10https://gerrit.wikimedia.org/r/121933 (owner: 10MaxSem) [22:17:56] <grrrit-wm> (03CR) 10Krinkle: "IE9 is affected as well, IE < 9 is inaccurate." [core] - 10https://gerrit.wikimedia.org/r/122408 (owner: 10Gilles) [22:20:23] <grrrit-wm> (03PS3) 10Krinkle: mediawiki.log: Fix unknown method "apply" error in IE9 and below [core] - 10https://gerrit.wikimedia.org/r/122408 (owner: 10Gilles) [22:20:29] <grrrit-wm> (03CR) 10Krinkle: [C: 032] mediawiki.log: Fix unknown method "apply" error in IE9 and below [core] - 10https://gerrit.wikimedia.org/r/122408 (owner: 10Gilles) [22:24:31] <grrrit-wm> (03PS1) 10MaxSem: Make results cacheable [extensions/PageImages] (wmf/1.23wmf19) - 10https://gerrit.wikimedia.org/r/122584 [22:24:47] <grrrit-wm> (03CR) 10MaxSem: [C: 032 V: 032] Make results cacheable [extensions/PageImages] (wmf/1.23wmf19) - 10https://gerrit.wikimedia.org/r/122584 (owner: 10MaxSem) [22:25:00] <grrrit-wm> (03Merged) 10jenkins-bot: mediawiki.log: Fix unknown method "apply" error in IE9 and below [core] - 10https://gerrit.wikimedia.org/r/122408 (owner: 10Gilles) [22:25:28] <grrrit-wm> (03PS1) 10MaxSem: Make results cacheable [extensions/PageImages] (wmf/1.23wmf20) - 10https://gerrit.wikimedia.org/r/122586 [22:25:36] <grrrit-wm> (03CR) 10MaxSem: [C: 032 V: 032] Make results cacheable [extensions/PageImages] (wmf/1.23wmf20) - 10https://gerrit.wikimedia.org/r/122586 (owner: 10MaxSem) [22:25:55] <grrrit-wm> (03CR) 10Krinkle: [C: 04-1] mediawiki.user: Remove #name and #anonymous [core] - 10https://gerrit.wikimedia.org/r/111422 (owner: 10Ori.livneh) [22:26:20] <grrrit-wm> (03CR) 10MaxSem: [V: 032] Make results cacheable [extensions/TextExtracts] - 10https://gerrit.wikimedia.org/r/121933 (owner: 10MaxSem) [22:26:40] <grrrit-wm> (03PS1) 10MaxSem: Make results cacheable [extensions/TextExtracts] (wmf/1.23wmf19) - 10https://gerrit.wikimedia.org/r/122587 [22:26:48] <grrrit-wm> (03CR) 10MaxSem: [C: 032 V: 032] Make results cacheable [extensions/TextExtracts] (wmf/1.23wmf19) - 10https://gerrit.wikimedia.org/r/122587 (owner: 10MaxSem) [22:27:09] <grrrit-wm> (03PS1) 10MaxSem: Make results cacheable [extensions/TextExtracts] (wmf/1.23wmf20) - 10https://gerrit.wikimedia.org/r/122589 [22:27:23] <grrrit-wm> (03CR) 10MaxSem: [C: 032 V: 032] Make results cacheable [extensions/TextExtracts] (wmf/1.23wmf20) - 10https://gerrit.wikimedia.org/r/122589 (owner: 10MaxSem) [22:27:42] <MaxSem> zomg that MaxSem is a spammah [22:30:50] <^d> MaxSem: We should ban him [22:33:51] <grrrit-wm> (03PS1) 10MaxSem: Update MobileFrontend, PageImages and TextExtracts for bug 63248 [core] (wmf/1.23wmf19) - 10https://gerrit.wikimedia.org/r/122594 [22:36:32] <grrrit-wm> (03PS1) 10MaxSem: Update MobileFrontend, PageImages and TextExtracts for bug 63248 [core] (wmf/1.23wmf20) - 10https://gerrit.wikimedia.org/r/122596 [22:36:43] <grrrit-wm> (03PS1) 10Mattflaschen: Note repository is no longer being developed [extensions/E3Experiments] - 10https://gerrit.wikimedia.org/r/122597 [22:37:41] <grrrit-wm> (03CR) 10Mattflaschen: [C: 032] Note repository is no longer being developed [extensions/E3Experiments] - 10https://gerrit.wikimedia.org/r/122597 (owner: 10Mattflaschen) [22:37:55] <grrrit-wm> (03Merged) 10jenkins-bot: Note repository is no longer being developed [extensions/E3Experiments] - 10https://gerrit.wikimedia.org/r/122597 (owner: 10Mattflaschen) [22:49:35] <grrrit-wm> (03PS1) 10Foxtrott: Restructure MainContent to mostly copy Vector's structure [skins/chameleon] - 10https://gerrit.wikimedia.org/r/122600 [22:50:28] <grrrit-wm> (03PS2) 10Foxtrott: Restructure MainContent to mostly copy Vector's structure [skins/chameleon] - 10https://gerrit.wikimedia.org/r/122600 [22:52:54] <grrrit-wm> (03CR) 10Foxtrott: [C: 032 V: 032] Restructure MainContent to mostly copy Vector's structure [skins/chameleon] - 10https://gerrit.wikimedia.org/r/122600 (owner: 10Foxtrott) [22:53:30] <grrrit-wm> (03PS1) 10TheDJ: Add a status bar to the CodeEditor [extensions/CodeEditor] - 10https://gerrit.wikimedia.org/r/122601 [22:54:55] <grrrit-wm> (03CR) 10TheDJ: "A more complex version is in: https://gerrit.wikimedia.org/r/122601" [extensions/CodeEditor] - 10https://gerrit.wikimedia.org/r/118989 (owner: 10TheDJ) [22:57:17] <grrrit-wm> (03PS3) 10Aaron Schulz: Speed up LocalFile locking behavior [core] - 10https://gerrit.wikimedia.org/r/122550 [23:00:28] <grrrit-wm> (03PS2) 10TheDJ: Add a status bar to the CodeEditor [extensions/CodeEditor] - 10https://gerrit.wikimedia.org/r/122601 [23:00:37] <zeek_> Hi, I need some help on LiquidThreads extension. I am confused about the API call made when replying to threads. Does it go to the APITheadAction.php? How to check? [23:00:51] <Krenair> Hi zeek_ [23:01:07] <zeek_> Hi Krenair [23:01:08] <Krenair> What is the value of the action parameter? [23:01:34] <zeek_> threadaction [23:02:31] <Krenair> zeek_, that should be ApiThreadAction.php then, yes [23:03:29] <ori> kaldari: I am ready to go w/https://gerrit.wikimedia.org/r/#/c/122549/ for the swat window. Is it still ok to go? Can you join #wikimedia-operations ? [23:05:18] <zeek_> Krenair: Ok, I know this snippet of code basically is executed everytime. I was testing by commenting this code. http://www.fpaste.org/90447/30707713/ When I comment it out and click reply, the form fails to load. But if I let it load, and then comment it out and submit the form, it works! I cant believe how.. :| [23:06:11] <grrrit-wm> (03CR) 10Kaldari: "recheck" [core] - 10https://gerrit.wikimedia.org/r/120696 (owner: 10Kaldari) [23:07:18] <zeek_> This is why I am confused about the flow control. [23:08:29] <grrrit-wm> (03PS1) 10Esanders: Emit rerender on math node if Tex image is not present [extensions/Math] - 10https://gerrit.wikimedia.org/r/122602 [23:09:50] <zeek_> any suggestions Krenair ? [23:09:52] <grrrit-wm> (03CR) 10Ori.livneh: [C: 032] Update MobileFrontend, PageImages and TextExtracts for bug 63248 [core] (wmf/1.23wmf20) - 10https://gerrit.wikimedia.org/r/122596 (owner: 10MaxSem) [23:10:23] <grrrit-wm> (03CR) 10Ori.livneh: [C: 032] Update MobileFrontend, PageImages and TextExtracts for bug 63248 [core] (wmf/1.23wmf19) - 10https://gerrit.wikimedia.org/r/122594 (owner: 10MaxSem) [23:10:36] <Krenair> looking zeek_ [23:10:50] <zeek_> all right [23:11:21] <Krenair> zeek_, so what you're saying is that the form submission is broken with this code existing [23:11:34] <Krenair> getting rid of it fixes the form submission but breaks the form generation? [23:12:51] <zeek_> Krenair: I am not sure about that, I am working on this bug actually. https://bugzilla.wikimedia.org/show_bug.cgi?id=29786 For this I am passing another token with the form input and then trying to validate it in the execute() function using conditions. But it doesn't work. The form always gets submitted anyhow. [23:13:49] <grrrit-wm> (03Merged) 10jenkins-bot: Update MobileFrontend, PageImages and TextExtracts for bug 63248 [core] (wmf/1.23wmf20) - 10https://gerrit.wikimedia.org/r/122596 (owner: 10MaxSem) [23:13:51] <zeek_> What I expected was getting rid of it should break form submission too. [23:14:06] <grrrit-wm> (03Merged) 10jenkins-bot: Update MobileFrontend, PageImages and TextExtracts for bug 63248 [core] (wmf/1.23wmf19) - 10https://gerrit.wikimedia.org/r/122594 (owner: 10MaxSem) [23:14:14] <zeek_> Thats why now I am doubtful if I got the flow control right. [23:27:23] <zeek_> Krenair: anything you got? [23:27:40] <grrrit-wm> (03CR) 10Aaron Schulz: "Mostly fine. Obviously it will use the new methods and clone in the next patch." (033 comments) [extensions/OAuth] - 10https://gerrit.wikimedia.org/r/121131 (owner: 10CSteipp) [23:28:03] <Krenair> Sorry zeek_, I'm a bit busy right now [23:28:17] <zeek_> Ok no problem. tc. [23:28:21] <grrrit-wm> (03PS3) 10CSteipp: Add maintenance script to copy db tables [extensions/OAuth] - 10https://gerrit.wikimedia.org/r/121131 [23:28:39] <ori> MaxSem: https://gerrit.wikimedia.org/r/#/c/122459/ is trivial; if it were merged I'd be able to sync a bunch of changes I've been waiting on. Got a minute for it? [23:29:05] <MaxSem> looking [23:30:18] <ori> MaxSem: <https://gerrit.wikimedia.org/r/#/c/122462/> is pretty simple too and would clear my EL backlog. but less pressing [23:32:31] <grrrit-wm> (03CR) 10MaxSem: Add $wgEventLoggingSchemas (032 comments) [extensions/EventLogging] - 10https://gerrit.wikimedia.org/r/122459 (owner: 10Ori.livneh) [23:33:36] <ori> MaxSem: good comment. is there a standard pattern for that? copy the array to a static var? [23:34:01] <MaxSem> why does it have to be static? [23:34:37] <ori> oh, I see what you are saying. [23:35:32] <grrrit-wm> (03CR) 10MaxSem: [C: 032] Rename efLogServerSideEvent -> efLogEvent; deprecate former [extensions/EventLogging] - 10https://gerrit.wikimedia.org/r/122462 (owner: 10Ori.livneh) [23:35:59] <grrrit-wm> (03Merged) 10jenkins-bot: Rename efLogServerSideEvent -> efLogEvent; deprecate former [extensions/EventLogging] - 10https://gerrit.wikimedia.org/r/122462 (owner: 10Ori.livneh) [23:41:11] <grrrit-wm> (03PS2) 10Ori.livneh: Add $wgEventLoggingSchemas [extensions/EventLogging] - 10https://gerrit.wikimedia.org/r/122459 [23:41:50] <ori> MaxSem: ^. the isset() check is simply to prevent clobbering extensions that add items to the array before EventLogging.php has been loaded [23:42:15] <Krinkle> ori: Do you intend to submit something for Wikimania? [23:42:16] <MaxSem> ori, I think it's a horrible patttern [23:42:30] <ori> Krinkle: yes, I'm in full-blown panic mode because the deadline is today [23:42:42] <Krinkle> Yeah, I know the feeling. [23:42:44] <Krinkle> OK :) [23:42:50] <ori> Krinkle: why do you ask? [23:42:56] <Krinkle> You've got 12 hours though [23:42:59] <ori> MaxSem: what do you suggest? [23:43:22] <ori> MaxSem: just having the hook, no global? [23:43:22] <MaxSem> include extensions depending on it after? [23:43:54] <grrrit-wm> (03CR) 10Krinkle: Add $wgEventLoggingSchemas (031 comment) [extensions/EventLogging] - 10https://gerrit.wikimedia.org/r/122459 (owner: 10Ori.livneh) [23:44:31] <Krinkle> Yeah, extension should provide the initial value, changing or adding it always done after afaik we shouldn't have to support the wrong order. [23:45:11] <Krinkle> Though I can see the case of it (soft dependency) [23:45:13] <ori> but it's a potential source of bugs that is trivially avoided [23:45:22] <Krinkle> It's not a hard dependency [23:45:57] <Krinkle> ori: I assume the use case is not so much the order as it is extensions not literally depending on EventLogging so in that case they just set it blindly. [23:46:10] <Krinkle> Though that sounds like a good case for a hook. [23:47:51] <grrrit-wm> (03CR) 10MaxSem: Add $wgEventLoggingSchemas (031 comment) [extensions/EventLogging] - 10https://gerrit.wikimedia.org/r/122459 (owner: 10Ori.livneh) [23:48:45] <grrrit-wm> (03PS23) 10Bsitu: Add topic summary revision type [extensions/Flow] - 10https://gerrit.wikimedia.org/r/117357 [23:49:37] <grrrit-wm> (03PS3) 10Ori.livneh: Add $wgEventLoggingSchemas [extensions/EventLogging] - 10https://gerrit.wikimedia.org/r/122459 [23:52:26] <grrrit-wm> (03PS24) 10Bsitu: Add topic summary revision type [extensions/Flow] - 10https://gerrit.wikimedia.org/r/117357 [23:52:47] <grrrit-wm> (03CR) 10jenkins-bot: [V: 04-1] Add topic summary revision type [extensions/Flow] - 10https://gerrit.wikimedia.org/r/117357 (owner: 10Bsitu) [23:53:42] <grrrit-wm> (03PS1) 10EBernhardson: ChangesList initialization hook has been renamed [extensions/Flow] - 10https://gerrit.wikimedia.org/r/122612 [23:53:57] <grrrit-wm> (03CR) 10Ori.livneh: [C: 04-1] "Use simple random sampling rather than time-based sampling, per off-line discussion." [extensions/WikimediaEvents] - 10https://gerrit.wikimedia.org/r/119903 (owner: 10Ori.livneh) [23:58:16] <spagewmf> superm401 or anyone, we have a git repo on a labs instance. `git config core.sharedRepository group` only affects the contents of .git, the regular files are all 644 and so other devs can't update. [23:59:03] <spagewmf> Do we need the setgid bit or umask 002 in every .profile ? The same config seemed to work in pmtpa.