[00:43:36] Hi ori, yt? Got a sec for a couple SQL performance questions? [00:48:53] (03PS1) 10Foxtrott: Improvements to nav bars [skins/chameleon] - 10https://gerrit.wikimedia.org/r/122087 [00:52:50] (03CR) 10Foxtrott: [C: 032 V: 032] Improvements to nav bars [skins/chameleon] - 10https://gerrit.wikimedia.org/r/122087 (owner: 10Foxtrott) [01:02:38] (03CR) 10Jeremyb: "reverted in Ia1b6dc17477f5fe0c38902cb935983d6172f30d8" [extensions/GettingStarted] - 10https://gerrit.wikimedia.org/r/103740 (owner: 10Mattflaschen) [01:40:00] (03CR) 10Swalling: [C: 04-1] "For some reason this produces two submit buttons in Chrome." [core] - 10https://gerrit.wikimedia.org/r/121975 (owner: 10Ganeshaditya1) [02:05:16] (03PS5) 10Ganeshaditya1: ChangeEmail special page rewritten to use vforms. [core] - 10https://gerrit.wikimedia.org/r/121975 [02:15:59] (03CR) 10Ganeshaditya1: "My bad, I forgot to change the text on the buttons." [core] - 10https://gerrit.wikimedia.org/r/121975 (owner: 10Ganeshaditya1) [03:08:46] (03PS1) 10Konarak: MediaWiki:Watchnologintext: Add returnto parameter [core] - 10https://gerrit.wikimedia.org/r/122089 [04:28:22] (03CR) 10Ganeshaditya1: "Also about those red/green stripes should I remove the email validation from this page and let the browser handle it ? Just like in the si" [core] - 10https://gerrit.wikimedia.org/r/121975 (owner: 10Ganeshaditya1) [06:10:43] Hi somone around how to change the mysql data-dir on wikimedia-labs instances [06:13:10] physikerwelt: Seems unlikely; most of the labs people are asleep now :) [06:15:13] ok I was thinking that this might be a common problem (https://wikitech.wikimedia.org/wiki/Nova_Resource:I-000002d6.eqiad.wmflabs) [06:15:24] Oh, maybe it is! [06:15:50] physikerwelt: Have you looked for a reference to the current data-dir in the mysql config? [06:16:14] By default mysql uses a 2 GB partition I tried to move to /home but that seems to be mounted to some external server [06:16:30] physikerwelt: So you need to enable a role in the puppet config...sec [06:16:51] physikerwelt: role::labs::lvm::mnt [06:17:01] It will put all the rest of the space on the instance into /mnt [06:17:08] Then you can put the data-dir there somewhere [06:17:11] great thank you [06:17:16] that solves my problem [06:17:23] Yup! [07:38:41] (03PS1) 10Rahul mishra: UnknownAction hook not mentioned as deprecated in Wiki.php [core] - 10https://gerrit.wikimedia.org/r/122098 [08:12:00] (03PS2) 10Rahul mishra: UnknownAction hook not mentioned as deprecated in Wiki.php [core] - 10https://gerrit.wikimedia.org/r/121301 [08:18:14] (03CR) 10Nemo bis: Adding interwiki search descriptions for WMF sites (031 comment) [extensions/WikimediaMessages] - 10https://gerrit.wikimedia.org/r/121910 (owner: 10Chad) [09:38:28] (03PS1) 10UltrasonicNXT: Add pinging on user join/leave [extensions/MediaWikiChat] - 10https://gerrit.wikimedia.org/r/122103 [09:38:45] (03CR) 10UltrasonicNXT: [C: 032 V: 032] Add pinging on user join/leave [extensions/MediaWikiChat] - 10https://gerrit.wikimedia.org/r/122103 (owner: 10UltrasonicNXT) [09:41:02] (03PS1) 10JustJustin: QuestyCaptcha ignore answer case when stored in an array [extensions/ConfirmEdit] - 10https://gerrit.wikimedia.org/r/122104 [11:15:19] (03CR) 10Nemo bis: "Thanks! Did you test this? I'm not 100 % sure {{FULLPAGENAMEE}} is going to work in all the places this message may be displayed in. It mi" [core] - 10https://gerrit.wikimedia.org/r/122089 (owner: 10Konarak) [12:03:49] (03CR) 10Siebrand: [C: 032] Ask for confirmation when saving document with errors [extensions/CodeEditor] - 10https://gerrit.wikimedia.org/r/121632 (owner: 10TheDJ) [12:03:52] (03Merged) 10jenkins-bot: Ask for confirmation when saving document with errors [extensions/CodeEditor] - 10https://gerrit.wikimedia.org/r/121632 (owner: 10TheDJ) [12:06:42] (03CR) 10Siebrand: [C: 04-1] "i18n/L10n reviewed." (031 comment) [extensions/WikimediaIncubator] - 10https://gerrit.wikimedia.org/r/121980 (owner: 10Ebe123) [12:19:54] (03PS1) 10Siebrand: Migrate to JSON i18n without B/C [extensions/WikimediaShopLink] - 10https://gerrit.wikimedia.org/r/122109 [12:51:45] (03CR) 10Raimond Spekking: [C: 032] Migrate to JSON i18n without B/C [extensions/WikimediaShopLink] - 10https://gerrit.wikimedia.org/r/122109 (owner: 10Siebrand) [12:51:48] (03Merged) 10jenkins-bot: Migrate to JSON i18n without B/C [extensions/WikimediaShopLink] - 10https://gerrit.wikimedia.org/r/122109 (owner: 10Siebrand) [13:02:58] siebrand: does localization update in production work witht he json or does it rely on the legacy wrapper? [13:03:27] Raymond_: ^ [13:03:36] hoo: LU was recently rewritten, and now supports both file formats. [13:03:53] siebrand: So we can go into prod. with the json only, right? [13:04:14] hoo: During this migration period, there will probably be a week or two where things are messed up; that's unavoidable because of WMF's deployment schedule. [13:04:33] hoo: If you don't need BC, that's possible. You can then remove the shims. [13:04:44] siebrand: On that, but you broke the stuff [13:04:57] hoo: I broke stuff? [13:04:59] eg. your change didn't work and only the legacy wrapper made it pass the unit tests [13:05:09] you used the globals without declaring them using global [13:05:21] siebrand: https://gerrit.wikimedia.org/r/122113 [13:06:13] hoo: Technically, submitting a patch set does not break anything. It's only broken once merged. [13:06:26] siebrand: But it has been merged :P [13:06:47] hoo: Did I merge it, hence did I break it, or was it the reviewer that dropped the ball? :) [13:07:05] * siebrand stops trolling. [13:07:10] hoo: Anyway, sorry, I missed that. [13:07:45] siebrand: Want to approve https://gerrit.wikimedia.org/r/122113 ? :) [13:07:55] hoo: yeah, reviewing. [13:08:24] * Raymond_ hides [13:08:55] hoo: I updated the topic to json-i18n. [13:09:01] fine with me [13:27:39] (03PS2) 10Bencmq: Reorganise flow-post-interaction link styling [extensions/Flow] - 10https://gerrit.wikimedia.org/r/119812 [13:29:15] (03CR) 10Bencmq: Reorganise flow-post-interaction link styling (037 comments) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/119812 (owner: 10Bencmq) [13:38:29] (03PS2) 10Ebe123: Standardize "Error" messages [extensions/WikimediaIncubator] - 10https://gerrit.wikimedia.org/r/121980 [13:40:21] (03CR) 10Ebe123: "Done" [extensions/WikimediaIncubator] - 10https://gerrit.wikimedia.org/r/121980 (owner: 10Ebe123) [13:59:50] (03PS1) 10Foxtrott: Introduce IdRegistry; Code restructuring [skins/chameleon] - 10https://gerrit.wikimedia.org/r/122115 [14:02:37] (03PS1) 10Bencmq: Clone thanked label before inserting [extensions/Thanks] - 10https://gerrit.wikimedia.org/r/122116 [14:08:08] (03PS2) 10Foxtrott: Introduce IdRegistry; Code restructuring [skins/chameleon] - 10https://gerrit.wikimedia.org/r/122115 [14:09:05] (03CR) 10Foxtrott: [C: 032 V: 032] Introduce IdRegistry; Code restructuring [skins/chameleon] - 10https://gerrit.wikimedia.org/r/122115 (owner: 10Foxtrott) [14:41:05] (03PS1) 10Foxtrott: Split RL module to work around MW bug [extensions/Bootstrap] - 10https://gerrit.wikimedia.org/r/122117 [14:52:31] (03PS2) 10Foxtrott: Split RL module to work around MW bug [extensions/Bootstrap] - 10https://gerrit.wikimedia.org/r/122117 [14:53:16] (03CR) 10Foxtrott: [C: 032 V: 032] Split RL module to work around MW bug [extensions/Bootstrap] - 10https://gerrit.wikimedia.org/r/122117 (owner: 10Foxtrott) [15:41:35] (03CR) 10Ganeshaditya1: "http://imgur.com/aRiNYZ7 Latest chrome in windows 7." [core] - 10https://gerrit.wikimedia.org/r/121975 (owner: 10Ganeshaditya1) [15:52:36] (03CR) 10Theopolisme: "Shouldn't the "Cancel" button be styled differently from the "Change email" button? (I believe just as a neutral button.)" [core] - 10https://gerrit.wikimedia.org/r/121975 (owner: 10Ganeshaditya1) [16:33:47] (03CR) 10Ganeshaditya1: "Well .. Since the red button was not allowed, I couldn't think of anything else." [core] - 10https://gerrit.wikimedia.org/r/121975 (owner: 10Ganeshaditya1) [16:39:16] (03CR) 10Ganeshaditya1: "http://ux.stackexchange.com/questions/18777/is-a-cancel-button-really-needed-in-a-form-in-a-page?rq=1" [core] - 10https://gerrit.wikimedia.org/r/121975 (owner: 10Ganeshaditya1) [16:55:17] (03PS1) 10Foxtrott: forget RL [extensions/Bootstrap] - 10https://gerrit.wikimedia.org/r/122121 [16:56:10] (03PS2) 10Foxtrott: just forget RL and do own dependency resolving [extensions/Bootstrap] - 10https://gerrit.wikimedia.org/r/122121 [16:59:04] (03CR) 10Foxtrott: [C: 032 V: 032] just forget RL and do own dependency resolving [extensions/Bootstrap] - 10https://gerrit.wikimedia.org/r/122121 (owner: 10Foxtrott) [17:05:40] (03CR) 10Luis Felipe Schenone: [C: 032 V: 032] Fixed {{PLURAL...}} and other minor i18n things [extensions/NukeDPL] - 10https://gerrit.wikimedia.org/r/121958 (owner: 10Luis Felipe Schenone) [17:10:53] (03PS1) 10Foxtrott: Avoid loading styles twice [skins/chameleon] - 10https://gerrit.wikimedia.org/r/122122 [17:11:03] (03PS6) 10Ganeshaditya1: ChangeEmail special page rewritten to use vforms. [core] - 10https://gerrit.wikimedia.org/r/121975 [17:56:26] (03PS1) 10Kushal124: Fix validation error messages. [wikimedia/wikimania-scholarships] - 10https://gerrit.wikimedia.org/r/122123 [18:21:42] (03PS1) 10UltrasonicNXT: Fix sidebar greying of users [extensions/MediaWikiChat] - 10https://gerrit.wikimedia.org/r/122125 [18:21:45] (03PS1) 10AalekhN: ConfirmEdit should pass jshint [extensions/ConfirmEdit] - 10https://gerrit.wikimedia.org/r/122126 [18:21:59] (03CR) 10UltrasonicNXT: [C: 032 V: 032] Fix sidebar greying of users [extensions/MediaWikiChat] - 10https://gerrit.wikimedia.org/r/122125 (owner: 10UltrasonicNXT) [18:27:44] (03CR) 10Hashar: "Can you also add a dummy .jshintrc containing:" [extensions/ConfirmEdit] - 10https://gerrit.wikimedia.org/r/122126 (owner: 10AalekhN) [19:00:31] (03PS1) 10Aude: Move zero group i18n messages to ZeroRatedMobileAccess extension [extensions/WikimediaMessages] - 10https://gerrit.wikimedia.org/r/122128 [19:05:35] (03CR) 10Chococookies: "Don what's the reasoning behind changing the filenames? This means a lot of stuff has to be changed and simply merging the change breaks i" [extensions/OpenBadges] - 10https://gerrit.wikimedia.org/r/120361 (owner: 10Chococookies) [19:12:25] (03CR) 10Raimond Spekking: [C: 032] Move zero group i18n messages to ZeroRatedMobileAccess extension [extensions/WikimediaMessages] - 10https://gerrit.wikimedia.org/r/122128 (owner: 10Aude) [19:12:27] (03Merged) 10jenkins-bot: Move zero group i18n messages to ZeroRatedMobileAccess extension [extensions/WikimediaMessages] - 10https://gerrit.wikimedia.org/r/122128 (owner: 10Aude) [19:31:51] (03PS1) 10Gerrit Patch Uploader: Remove dead code [extensions/CategoryTree] - 10https://gerrit.wikimedia.org/r/122129 [19:31:53] (03CR) 10Gerrit Patch Uploader: "This commit was uploaded using the Gerrit Patch Uploader [1]." [extensions/CategoryTree] - 10https://gerrit.wikimedia.org/r/122129 (owner: 10Gerrit Patch Uploader) [19:39:21] (03CR) 10Aklapper: [C: 04-1] "Thanks for the patch! ""Please enter in your legal guardian's name."" - either this is missing an object after "in" ("in the field"?), or " [wikimedia/wikimania-scholarships] - 10https://gerrit.wikimedia.org/r/122123 (owner: 10Kushal124) [19:48:12] (03PS2) 10Kushal124: Fix validation error messages. [wikimedia/wikimania-scholarships] - 10https://gerrit.wikimedia.org/r/122123 [19:49:04] (03CR) 10Kushal124: "@aklapper Thank you for the review." [wikimedia/wikimania-scholarships] - 10https://gerrit.wikimedia.org/r/122123 (owner: 10Kushal124) [19:50:55] It seems this needs another rebase https://gerrit.wikimedia.org/r/#/c/121684/ [19:56:27] (03PS5) 10Chococookies: Merges and inits db schema, add special pages. [extensions/OpenBadges] - 10https://gerrit.wikimedia.org/r/120361 [19:58:37] (03PS1) 10AndyRussG: Merge changes from master into wip/editorcampaigns [extensions/Campaigns] (wip/editorcampaigns) - 10https://gerrit.wikimedia.org/r/122133 [20:12:14] (03CR) 10Donyu: "The filename changes are consistent with the tutorial on how to make wikimedia extensions and is how every other extension seems to be don" [extensions/OpenBadges] - 10https://gerrit.wikimedia.org/r/120361 (owner: 10Chococookies) [20:18:05] (03PS1) 10Adamw: Rough design diagrams [extensions/Workflow] - 10https://gerrit.wikimedia.org/r/122218 [20:18:44] (03CR) 10jenkins-bot: [V: 04-1] Rough design diagrams [extensions/Workflow] - 10https://gerrit.wikimedia.org/r/122218 (owner: 10Adamw) [20:21:18] (03PS2) 10Adamw: Rough design diagrams [extensions/Workflow] - 10https://gerrit.wikimedia.org/r/122218 [20:21:28] (03CR) 10jenkins-bot: [V: 04-1] Rough design diagrams [extensions/Workflow] - 10https://gerrit.wikimedia.org/r/122218 (owner: 10Adamw) [20:23:07] (03CR) 10Adamw: "Jenkins is complaining cos there is no Workflow.php yet" [extensions/Workflow] - 10https://gerrit.wikimedia.org/r/122218 (owner: 10Adamw) [20:31:34] (03CR) 10Chococookies: "I see where you got that from. However I didn't notice that before from other extensions so I just created a subfolder instead." [extensions/OpenBadges] - 10https://gerrit.wikimedia.org/r/120361 (owner: 10Chococookies) [20:32:48] Yo. [20:32:51] Anyone here? [20:33:13] PHP fatal error in /usr/local/apache/common-local/php-1.23wmf19/extensions/CentralNotice/includes/BannerMessage.php line 55: Call to a member function getContent() on a non-object [20:33:31] hoo: ^ [20:35:52] $msg = Revision::newFromTitle( $this->getTitle( $lang ) )->getContent()->getNativeData(); [20:38:28] (03PS2) 10AalekhN: ConfirmEdit should pass jshint [extensions/ConfirmEdit] - 10https://gerrit.wikimedia.org/r/122126 [20:43:51] can have a look [20:44:05] * hoo hasn't touched central notice for 2 years :P [20:44:31] (03PS10) 10Adamw: Basic state machinery [extensions/Workflow] - 10https://gerrit.wikimedia.org/r/107307 [20:44:38] (03CR) 10jenkins-bot: [V: 04-1] Basic state machinery [extensions/Workflow] - 10https://gerrit.wikimedia.org/r/107307 (owner: 10Adamw) [20:45:41] (03PS2) 10Ricordisamoa: show before [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/120346 [20:46:01] (03PS1) 10Adamw: WIP Standard libraries; integration tests [extensions/Workflow] - 10https://gerrit.wikimedia.org/r/122220 [20:46:07] (03CR) 10jenkins-bot: [V: 04-1] WIP Standard libraries; integration tests [extensions/Workflow] - 10https://gerrit.wikimedia.org/r/122220 (owner: 10Adamw) [20:46:58] (03PS1) 10Adamw: WIP Workflow schema [extensions/Workflow] - 10https://gerrit.wikimedia.org/r/122221 [20:47:01] (03CR) 10jenkins-bot: [V: 04-1] WIP Workflow schema [extensions/Workflow] - 10https://gerrit.wikimedia.org/r/122221 (owner: 10Adamw) [20:47:26] hoo: this was after creating a banner and editing messages [20:51:58] huh: Is there a bug for that? [20:52:03] * hoo searches for one... [20:52:07] Should I create one? [20:52:14] (03PS11) 10Adamw: Basic state machinery [extensions/Workflow] - 10https://gerrit.wikimedia.org/r/107307 [20:52:24] maybe I can try to reproduce the problem [20:52:53] huh: There is one [20:52:57] link? [20:53:07] 59871 [20:53:12] bug 59871 [20:53:19] * huh looks [20:53:53] is it easy? [20:54:11] Sure, already solved it (I hope, can't test) [20:54:22] Thanks. [20:56:25] huh: https://gerrit.wikimedia.org/r/122222 [20:56:31] hah, that's one nice change id :D [20:56:31] saw [20:56:35] :D [20:56:49] (03CR) 10Stepzhou: "That was probably a merge conflict where the OpenBadges.php file wasn't merged correctly. I'll do a merge of the two previous patches. - D" [extensions/OpenBadges] - 10https://gerrit.wikimedia.org/r/120361 (owner: 10Chococookies) [20:57:25] (03PS1) 10AndyRussG: WIP Update Campaigns database schema [extensions/Campaigns] (wip/editorcampaigns) - 10https://gerrit.wikimedia.org/r/122223 [20:57:45] (03PS14) 10UltrasonicNXT: WIP - Rewrite [extensions/WikiForum] - 10https://gerrit.wikimedia.org/r/116258 [20:57:58] hoo: where is $msg defined? [20:58:08] https://gerrit.wikimedia.org/r/#/c/122222/1/includes/BannerMessage.php [20:58:32] ah crap [20:59:16] that's what you get for not testing stuff (And also not being careful enough) [20:59:19] (03CR) 10Stepzhou: "Is there a formal way to verify that it works well with ULS? I've been testing ad hoc and nothing seems to be breaking." [core] - 10https://gerrit.wikimedia.org/r/120475 (owner: 10Stepzhou) [21:00:43] hoo: jenkins-bot didn't complain though (???) [21:01:30] no unit tests... typical for legacy stuff [21:03:25] hoo: why isn't grrrit-wm reporting about that change? [21:04:04] Reviewed the wrong patchset sorry [21:04:41] they probably have an own channel and it's reporting to that one [21:04:55] #wikimedia-fundraising or so... no idea [21:04:57] +1 [21:05:16] yep, http://bots.wmflabs.org/~wm-bot/logs/%23wikimedia-fundraising/20140330.txt [21:05:45] (03PS6) 10TheDJ: CodeEditor: Add basic code completion and snippet support [extensions/CodeEditor] - 10https://gerrit.wikimedia.org/r/106693 [21:06:19] (03PS5) 10TheDJ: CodeEditor: Add a status bar with line and columncount [extensions/CodeEditor] - 10https://gerrit.wikimedia.org/r/118989 [21:06:52] (03PS3) 10TheDJ: [Do not merge] Allow the CodeEditor in read only mode [extensions/CodeEditor] - 10https://gerrit.wikimedia.org/r/120397 [21:07:23] (03CR) 10Hoo man: [C: 032] "Shouldn't harm" [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/120346 (owner: 10Ricordisamoa) [21:07:26] (03Merged) 10jenkins-bot: show before [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/120346 (owner: 10Ricordisamoa) [21:07:28] (03PS4) 10TheDJ: [Do not merge] Support warning for unsaved changes [extensions/CodeEditor] - 10https://gerrit.wikimedia.org/r/121559 [21:07:45] (03CR) 10AndyRussG: "This schema change has been superseded by:" [extensions/Campaigns] (wip/editorcampaigns) - 10https://gerrit.wikimedia.org/r/117905 (owner: 10AndyRussG) [21:09:53] (03PS5) 10TheDJ: Improve the CodeEditor toolbar [extensions/CodeEditor] - 10https://gerrit.wikimedia.org/r/118993 [21:09:55] (03PS10) 10TheDJ: [WIP] Additional CodeEditor buttons [extensions/CodeEditor] - 10https://gerrit.wikimedia.org/r/104512 [21:09:57] (03PS3) 10TheDJ: CodeEditor: Add support for Editor themes [extensions/CodeEditor] - 10https://gerrit.wikimedia.org/r/122085 [21:09:59] (03CR) 10jenkins-bot: [V: 04-1] [WIP] Additional CodeEditor buttons [extensions/CodeEditor] - 10https://gerrit.wikimedia.org/r/104512 (owner: 10TheDJ) [21:10:01] (03CR) 10jenkins-bot: [V: 04-1] CodeEditor: Add support for Editor themes [extensions/CodeEditor] - 10https://gerrit.wikimedia.org/r/122085 (owner: 10TheDJ) [21:11:11] (03PS4) 10TheDJ: CodeEditor: Add support for Editor themes [extensions/CodeEditor] - 10https://gerrit.wikimedia.org/r/122085 [21:16:35] (03PS11) 10TheDJ: [WIP] Additional CodeEditor buttons [extensions/CodeEditor] - 10https://gerrit.wikimedia.org/r/104512 [21:19:55] (03PS1) 10Siebrand: Migrate to JSON i18n [extensions/AbsenteeLandlord] - 10https://gerrit.wikimedia.org/r/122225 [21:20:34] (03PS1) 10Siebrand: Migrate to JSON i18n [extensions/AccessControl] - 10https://gerrit.wikimedia.org/r/122226 [21:20:50] (03PS1) 10Siebrand: Migrate to JSON i18n [extensions/AccountInfo] - 10https://gerrit.wikimedia.org/r/122227 [21:20:58] (03PS1) 10Siebrand: Migrate to JSON i18n [extensions/AddThis] - 10https://gerrit.wikimedia.org/r/122228 [21:21:04] (03PS1) 10Siebrand: Migrate to JSON i18n [extensions/AdManager] - 10https://gerrit.wikimedia.org/r/122229 [21:21:09] (03PS1) 10Siebrand: Migrate to JSON i18n [extensions/Ads] - 10https://gerrit.wikimedia.org/r/122230 [21:21:14] (03PS1) 10Siebrand: Migrate to JSON i18n [extensions/Agora] - 10https://gerrit.wikimedia.org/r/122231 [21:21:17] (03PS1) 10Siebrand: Migrate to JSON i18n [extensions/AJAXPoll] - 10https://gerrit.wikimedia.org/r/122232 [21:21:19] (03CR) 10jenkins-bot: [V: 04-1] Migrate to JSON i18n [extensions/Agora] - 10https://gerrit.wikimedia.org/r/122231 (owner: 10Siebrand) [21:21:26] (03PS1) 10Siebrand: Migrate to JSON i18n [extensions/AkismetKlik] - 10https://gerrit.wikimedia.org/r/122233 [21:21:29] (03PS1) 10Siebrand: Migrate to JSON i18n [extensions/AllTimeZones] - 10https://gerrit.wikimedia.org/r/122234 [21:21:37] (03PS1) 10Siebrand: Migrate to JSON i18n [extensions/Annotator] - 10https://gerrit.wikimedia.org/r/122235 [21:21:40] (03PS1) 10Siebrand: Migrate to JSON i18n [extensions/ApiExplorer] - 10https://gerrit.wikimedia.org/r/122236 [21:21:47] (03PS1) 10Siebrand: Migrate to JSON i18n [extensions/ApiSVGProxy] - 10https://gerrit.wikimedia.org/r/122237 [21:21:49] (03CR) 10jenkins-bot: [V: 04-1] Migrate to JSON i18n [extensions/Annotator] - 10https://gerrit.wikimedia.org/r/122235 (owner: 10Siebrand) [21:21:51] (03PS1) 10Siebrand: Migrate to JSON i18n [extensions/ApprovedRevs] - 10https://gerrit.wikimedia.org/r/122238 [21:21:55] (03PS1) 10Siebrand: Migrate to JSON i18n [extensions/Arrays] - 10https://gerrit.wikimedia.org/r/122239 [21:21:59] (03PS1) 10Siebrand: Migrate to JSON i18n [extensions/ArticleCreationWorkflow] - 10https://gerrit.wikimedia.org/r/122240 [21:22:04] (03CR) 10jenkins-bot: [V: 04-1] Migrate to JSON i18n [extensions/Arrays] - 10https://gerrit.wikimedia.org/r/122239 (owner: 10Siebrand) [21:22:06] (03PS1) 10Siebrand: Migrate to JSON i18n [extensions/ArticleFeedback] - 10https://gerrit.wikimedia.org/r/122241 [21:22:10] o.O [21:22:22] siebrand: are you a bot? [21:22:29] (03PS1) 10TyA: Bug 20461 - Log CentralAuth account detachments [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/122242 [21:22:39] (03PS1) 10Siebrand: Migrate to JSON i18n [extensions/ArticleFeedbackv5] - 10https://gerrit.wikimedia.org/r/122243 [21:22:57] (03PS1) 10Siebrand: Migrate to JSON i18n [extensions/AssertEdit] - 10https://gerrit.wikimedia.org/r/122244 [21:23:01] (03PS1) 10Siebrand: Migrate to JSON i18n [extensions/AuthorProtect] - 10https://gerrit.wikimedia.org/r/122245 [21:23:07] (03PS1) 10Siebrand: Migrate to JSON i18n [extensions/AutoCreateCategoryPages] - 10https://gerrit.wikimedia.org/r/122246 [21:23:11] (03PS1) 10Siebrand: Migrate to JSON i18n [extensions/AutomaticBoardWelcome] - 10https://gerrit.wikimedia.org/r/122247 [21:23:16] (03PS1) 10Siebrand: Migrate to JSON i18n [extensions/AutoProxyBlock] - 10https://gerrit.wikimedia.org/r/122248 [21:23:20] (03PS1) 10Siebrand: Migrate to JSON i18n [extensions/AWS] - 10https://gerrit.wikimedia.org/r/122249 [21:23:26] (03PS1) 10Siebrand: Migrate to JSON i18n [extensions/AWSSDK] - 10https://gerrit.wikimedia.org/r/122250 [21:23:29] (03PS1) 10Siebrand: Migrate to JSON i18n [extensions/BayesianFilter] - 10https://gerrit.wikimedia.org/r/122251 [21:23:35] (03PS1) 10Siebrand: Migrate to JSON i18n [extensions/BiblioPlus] - 10https://gerrit.wikimedia.org/r/122252 [21:23:38] (03PS1) 10Siebrand: Migrate to JSON i18n [extensions/BibManager] - 10https://gerrit.wikimedia.org/r/122253 [21:23:43] (03PS1) 10Siebrand: Migrate to JSON i18n [extensions/Blackout] - 10https://gerrit.wikimedia.org/r/122254 [21:23:47] (03PS1) 10Siebrand: Migrate to JSON i18n [extensions/BlockAndNuke] - 10https://gerrit.wikimedia.org/r/122255 [21:23:52] (03PS1) 10Siebrand: Migrate to JSON i18n [extensions/BlogPage] - 10https://gerrit.wikimedia.org/r/122256 [21:23:57] (03PS1) 10Siebrand: Migrate to JSON i18n [extensions/BookManagerv2] - 10https://gerrit.wikimedia.org/r/122257 [21:24:10] (03PS1) 10Siebrand: Migrate to JSON i18n [extensions/Bootstrap] - 10https://gerrit.wikimedia.org/r/122258 [21:24:14] (03PS1) 10Siebrand: Migrate to JSON i18n [extensions/BreadCrumbs] - 10https://gerrit.wikimedia.org/r/122259 [21:24:19] (03PS1) 10Siebrand: Migrate to JSON i18n [extensions/Carp] - 10https://gerrit.wikimedia.org/r/122260 [21:24:23] (03PS1) 10Siebrand: Migrate to JSON i18n [extensions/CategorySortHeaders] - 10https://gerrit.wikimedia.org/r/122261 [21:24:27] (03PS1) 10Siebrand: Migrate to JSON i18n [extensions/CategoryTagSorter] - 10https://gerrit.wikimedia.org/r/122262 [21:24:31] (03PS1) 10Siebrand: Migrate to JSON i18n [extensions/CategoryTests] - 10https://gerrit.wikimedia.org/r/122263 [21:24:37] (03PS1) 10Siebrand: Migrate to JSON i18n [extensions/CharRangeSpan] - 10https://gerrit.wikimedia.org/r/122264 [21:24:41] (03PS1) 10Siebrand: Migrate to JSON i18n [extensions/Checkpoint] - 10https://gerrit.wikimedia.org/r/122265 [21:25:04] (03CR) 10Swalling: [C: 04-1] "See inline comment per the style guide (visible at http://tools.wmflabs.org/styleguide/desktop/section-2.html)" (031 comment) [core] - 10https://gerrit.wikimedia.org/r/121975 (owner: 10Ganeshaditya1) [21:25:36] No, I'm not a bot. [21:31:04] (03PS1) 10Foxtrott: Several improvements to the navbar [skins/chameleon] - 10https://gerrit.wikimedia.org/r/122266 [21:34:16] (03CR) 10Foxtrott: [C: 032 V: 032] Several improvements to the navbar [skins/chameleon] - 10https://gerrit.wikimedia.org/r/122266 (owner: 10Foxtrott) [21:38:15] (03PS3) 10Alex Monk: Support setting column-width and list-style in tag [extensions/Cite] - 10https://gerrit.wikimedia.org/r/120962 [21:38:17] (03CR) 10jenkins-bot: [V: 04-1] Support setting column-width and list-style in tag [extensions/Cite] - 10https://gerrit.wikimedia.org/r/120962 (owner: 10Alex Monk) [21:42:07] (03CR) 10Siebrand: "The Jenkins failure is not about the contents of this patch set, but about pre-existing code." [extensions/Agora] - 10https://gerrit.wikimedia.org/r/122231 (owner: 10Siebrand) [21:42:24] (03CR) 10Siebrand: "The Jenkins failure is not about the contents of this patch set, but about pre-existing code." [extensions/Annotator] - 10https://gerrit.wikimedia.org/r/122235 (owner: 10Siebrand) [21:43:37] (03CR) 10Siebrand: "The Jenkins unit tests failure appears to not be about the contents of this patch set, but is pre-existing." [extensions/Arrays] - 10https://gerrit.wikimedia.org/r/122239 (owner: 10Siebrand) [21:52:30] (03PS4) 10Alex Monk: Support setting column-width and list-style in tag [extensions/Cite] - 10https://gerrit.wikimedia.org/r/120962 [21:52:38] (03CR) 10jenkins-bot: [V: 04-1] Support setting column-width and list-style in tag [extensions/Cite] - 10https://gerrit.wikimedia.org/r/120962 (owner: 10Alex Monk) [22:00:47] (03PS5) 10Alex Monk: Support setting column-width and list-style in tag [extensions/Cite] - 10https://gerrit.wikimedia.org/r/120962 [22:00:53] (03CR) 10jenkins-bot: [V: 04-1] Support setting column-width and list-style in tag [extensions/Cite] - 10https://gerrit.wikimedia.org/r/120962 (owner: 10Alex Monk) [22:07:45] (03CR) 10Alex Monk: [C: 04-1] Support setting column-width and list-style in tag (031 comment) [extensions/Cite] - 10https://gerrit.wikimedia.org/r/120962 (owner: 10Alex Monk) [22:27:57] (03PS6) 10Alex Monk: Support setting column-width and list-style in tag [extensions/Cite] - 10https://gerrit.wikimedia.org/r/120962 [22:36:28] (03CR) 10Yaron Koren: [C: 032 V: 031] Migrate to JSON i18n [extensions/ApprovedRevs] - 10https://gerrit.wikimedia.org/r/122238 (owner: 10Siebrand) [22:36:30] (03Merged) 10jenkins-bot: Migrate to JSON i18n [extensions/ApprovedRevs] - 10https://gerrit.wikimedia.org/r/122238 (owner: 10Siebrand) [22:40:46] (03CR) 10Brian Wolff: [C: 032] "Thank you for all your hard work on this. Looks good." [core] - 10https://gerrit.wikimedia.org/r/112323 (owner: 10Kunalgrover05) [22:43:25] (03PS2) 10Alex Monk: Log CentralAuth account detachments [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/122242 (owner: 10TyA) [22:44:10] (03Merged) 10jenkins-bot: Implement listing for tracking categories [core] - 10https://gerrit.wikimedia.org/r/112323 (owner: 10Kunalgrover05) [22:45:59] (03CR) 10Alex Monk: [C: 04-1] Log CentralAuth account detachments (031 comment) [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/122242 (owner: 10TyA) [22:48:36] (03CR) 10SPQRobin: [C: 032 V: 031] Standardize "Error" messages [extensions/WikimediaIncubator] - 10https://gerrit.wikimedia.org/r/121980 (owner: 10Ebe123) [22:48:39] (03Merged) 10jenkins-bot: Standardize "Error" messages [extensions/WikimediaIncubator] - 10https://gerrit.wikimedia.org/r/121980 (owner: 10Ebe123) [22:54:48] (03PS3) 10TyA: Log CentralAuth account detachments [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/122242 [23:26:17] (03PS1) 10Brian Wolff: Follow-up I7d4bb9062. Register tracking categories used. [extensions/Scribunto] - 10https://gerrit.wikimedia.org/r/122270 [23:26:35] thanks bawolff :D