[00:00:11] (03PS1) 10Chad: Clean up some unused code [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/121900 [00:05:27] (03CR) 10TheDJ: [C: 032] Use current lang, debug and skin for AJAX call [extensions/CategoryTree] - 10https://gerrit.wikimedia.org/r/114964 (owner: 10Gerrit Patch Uploader) [00:05:31] (03Merged) 10jenkins-bot: Use current lang, debug and skin for AJAX call [extensions/CategoryTree] - 10https://gerrit.wikimedia.org/r/114964 (owner: 10Gerrit Patch Uploader) [00:06:03] (03PS1) 10Gilles: Revert "jquery.color.test: Use fake timers" [core] - 10https://gerrit.wikimedia.org/r/121901 [00:07:57] (03CR) 10Gilles: "MatmaRex and I spent a while trying to figure it out, to no avail. I think it's timing related, because if I comment a bunch of mmv tests," [core] - 10https://gerrit.wikimedia.org/r/117150 (owner: 10Krinkle) [00:15:10] (03PS1) 10Gilles: Revert "jquery.makeCollapsible.test: Use fake timers to advance animations" [core] - 10https://gerrit.wikimedia.org/r/121904 [00:16:32] gi11es: Looking into it now [00:20:02] (03PS4) 10TheDJ: Convert from show()/hide() to using classes [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/120472 [00:20:22] gi11es: No failures for me locallyh on latest master of core and MMV [00:20:40] I've just reverted your changes [00:20:41] (03CR) 10TheDJ: [C: 032] Rework ext.categoryTree.js [extensions/CategoryTree] - 10https://gerrit.wikimedia.org/r/114807 (owner: 10Gerrit Patch Uploader) [00:20:43] (03CR) 10Manybubbles: [C: 032] Clean up some unused code [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/121900 (owner: 10Chad) [00:20:45] (03Merged) 10jenkins-bot: Rework ext.categoryTree.js [extensions/CategoryTree] - 10https://gerrit.wikimedia.org/r/114807 (owner: 10Gerrit Patch Uploader) [00:21:06] gi11es: No, you've submitted a patch proposing we revert it [00:21:11] ah [00:21:26] well, in that case, are you using chrome? that's where I see the failures [00:21:28] (03CR) 10Manybubbles: [C: 032] Fix sloppy coding mistakes from 9e3fd38 [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/121895 (owner: 10Chad) [00:21:30] MatmaRex was seeing them as well [00:21:33] I am using Chrome [00:21:39] (03Merged) 10jenkins-bot: Fix sloppy coding mistakes from 9e3fd38 [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/121895 (owner: 10Chad) [00:21:40] and jenkins, obviously [00:21:42] (03Merged) 10jenkins-bot: Clean up some unused code [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/121900 (owner: 10Chad) [00:21:43] latest master and MMV, no failures. But when running on phantomjs there are failures [00:21:50] Yeah, checking it out now. Hold on [00:22:09] https://integration.wikimedia.org/ci/job/mwext-MultimediaViewer-qunit/1180/consoleFull [00:22:09] The core failure is much earlier on [00:22:16] Krinkle: master core + master MMV causes test failures for me on Opera 20 and tests to hang on Opera 12 [00:22:17] 00:20:05 jquery.color - animate...ERROR [00:22:17] 00:20:05 >> Message: Expected 1 assertions, but 0 were run [00:22:17] 00:20:05 >> at http://localhost:9412/jenkins-mwext-MultimediaViewer-qunit-1180/load.php?debug=false&lang=en&modules=jquery.byteLength%2CcheckboxShiftClick%2Cclient%2Ccolor%2CcolorUtil%2Ccookie%2Cfullscreen%2CgetAttrs%2Chashchange%2Chidpi%2CmakeCollapsible%2Cmw-jump%2CmwExtension%2Cplaceholder%2Cqunit%2CscrollTo%2Cthrottle-debounce%7Cjquery.qunit.completenessTest%7Cmediawiki.Title%2CUri%2Capi%2Ccldr%2Cj [00:22:17] queryMsg%2Clanguage%2Cnotify%2Ctoc%2Cutil%7Cmediawiki.language.data%2Cinit%7Cmediawiki.legacy.ajax%2Cwikibits%7Cmediawiki.libs.pluralruleparser%7Cmediawiki.page.ready%2Cstartup%7Cmediawiki.special.javaScriptTest%7Cmmv%2Cmoment%2Coojs%2Coojs-ui%7Cmmv.HtmlUtils%2CThumbnailWidthCalculator%2Capi%2Cbase%2Cbootstrap%2CembedFileFormatter%2Clightboximage%2Clightboxinterface%2Clogger%2Cmodel%2Cperformance%2Cpro [00:22:17] vider%2Ctests%2Cui%7Cmmv.model.EmbedFileInfo%2CFileUsage%2CImage%2CLicense%2CRepo%2CTaskQueue%2CThumbnail%2CThumbnailWidth%2CUser%7Cmmv.ui.buttons%2Ccanvas%2Ccategories%2Cdescription%2CfileUsage%2CmetadataPanel%2Cpermission%7Cmmv.ui.reuse.dialog%2Cembed%2Cshare%2Ctab%7Cskins.vector.js%7Ctest.mediawiki.qunit.testrunner%7Ctest.sinonjs&skin=vector&version=20140329T001952Z&*:37 [00:22:28] I suspect MMV is modifying something globally causing SinonJS to break [00:22:36] and thus break core tests to no longer have the timer [00:22:47] and then show up again async in the middle of MMV causing the secondary failures [00:22:55] the tests pass on master, with qunit, on jenkins. [00:23:01] Krinkle: we're pretty much certain about that, we just don't know what ;) [00:23:18] Krinkle: the stuff modified by useFakeTimers looks intact to me [00:23:33] Well, I'm genuinely shocked by MMV tests [00:23:39] Can't put it any other way, sorry. [00:24:03] Its small details though, and I'm very nitpicky [00:24:10] A semi colon makes my day :) [00:24:17] wait until you've figured it out before you start assigning blame [00:24:35] That works both ways though :) [00:24:39] I haven't created reverts yet [00:24:44] I've looked into for an hour, it's 1:24am [00:24:58] All other extensions using core tests with qunit aren't failing. Just saying. [00:25:03] Eerythign is possible [00:25:58] I never said the issue was with your commit, I just sent the reverts because it's blocking us from working at all [00:26:17] since it can be reproduced locally, it doesn't have to be blocking the way it currently is [00:26:30] Well, that's a bit exaggerated. You can (and should) have Special:JavaScriptTest/qunit set up locally so you can run tests are you work. [00:26:42] And code is reviewed and built-upon with dependencies in gerrit quite often. [00:26:53] It getting merged and deployed is just a small last step. [00:27:01] I know how it feels, but le'ts not get ahead of ourselves. [00:27:16] I think you misunderstand what I'm saying, we're days before a launch and this commit prevents us from merging anything in our project [00:27:32] unless we disable qunit entirely for our project [00:27:49] since these commits are improvements on your end, and not critical, they can be reverted while the issue is investigated [00:28:07] I've done a fair share of investigating already, I'm not landing this on your doorstep and not doing anything myself [00:28:43] It's only qunit that's failing, the other jenkins jobs run file. And qunit is trivial to run locally. And you can bypass with V+2 if needed to merge. [00:32:40] Iv'e narrowed it down to 3 tests in MMV [00:33:15] which ones? because I've commented a whole bunch already and it just makes the issue intermittent instead of happening every time [00:37:41] I'm assuming it's an override that isn't properly restored, but nothing directly related to the color test was in that situation [00:37:49] (03PS1) 10Jdlrobson: Tweak fixed header behaviour [extensions/VectorBeta] - 10https://gerrit.wikimedia.org/r/121906 [00:38:00] The color test runs asynchronous using time simulation [00:38:22] If the time simulation is broken, the color test (which is the first test to use this technology) will return before the time field is finished [00:38:30] and thus it has fewer assertison than expected [00:38:43] and the missing assertions arrive out of scope in a random ohter test's context. [01:06:52] I think it's something inside mmv.ui.permission.test.js [01:07:16] but those tests are very innocent-looking [01:09:24] gi11es: breakage of visibility-related tests usually means that the staging area of QUnit got hidden [01:09:30] so my guess is [01:09:58] the color.js test changes how jquery.animate behaves [01:10:31] because of that something in the permission tests breaks [01:10:48] then the lightbox is not cleaned up and the staging area remains hidden [01:11:10] so far it seems like it's the "grow()" test in that file [01:11:25] maybe shrink() as well [01:11:37] yeah, that's the one that animates the color [01:12:27] but the tests do not actually rely on the animation being async, so i'm not sure what's going on [01:13:11] the animations still run after the test is over [01:13:31] it's definitely shrink() and grow(), each can make the issue happen individually [01:13:41] (the tests) [01:14:12] ok, mystery solved [01:14:16] the animation takes 500ms [01:14:23] it's still running by the time the color test happens [01:15:19] noop-ing the animation during those tests should do the trick [01:15:57] will do [01:17:09] gi11es: indeed [01:17:17] Im down to bootstrap/test/testhelpers/ui.test/ui/permission.test [01:17:40] editing testhoooks array [01:17:57] it's just a matter of overloading $.fn.animate to avoid that side-effect, we've done it in other tests for exactly the same kind of reason [01:17:59] The register doesnt' break it, it's the execution itself, so nothing in the shared closure, but in the actual test callbacks [01:18:20] Shouldn't stop() take two arguments in this case? [01:18:29] (jquery stop in shrink/grow implemetnation) [01:18:58] They're asynchronous [01:19:06] And provides no callback [01:19:07] Aha [01:19:10] So funnily [01:19:24] this is exactly why in core we don't wait for jquery aniimations and use the test simulation framework. [01:19:36] MMV will benefit greatly from this and be able to rid most of those overrides [01:19:58] What we were doing before this (until last week) was indicate these tests are asynchronous and call QUnit.start() from the animation callback [01:20:27] $node.promise().always(QUnit.start) or something of the like, same for the assertions if needed. [01:20:31] the test is not really async, it checks for show/hide behavior [01:20:49] .animate runs for 500ms per P.grow implementation [01:20:50] that's async [01:20:53] the animation was added to grow() as an afterthought later [01:21:06] Could be done in CSS instead. [01:21:36] And many of these tests I'd recommend doing as UI tests and integration tests with selenium instead of unit tests, these are not unit tests. [01:21:36] yeah, i want to do that at some point [01:21:56] And there's a fair amount (though not in this test) where it is asserting jQuery doing what jquery is told to do [01:22:15] Which is redundant [01:22:38] Okay, so we found it at the same time. [01:22:43] selenium tests are horribly slow, hard to reproduce locally, and usually not very good at giving context on what went wrong [01:23:13] the limit in what you should/shouldn't test with qunit is purely a matter of opinion [01:23:29] test coverage and ability to fix bugs is what matters, not the ideological blurry limit of what is a unit test [01:23:40] That's on the QA team list to improve, I can't help that. It's gotten a lot easier. You run them with shared credentials using cloud services (not install your own selenium), and using their gem to run it from the command line. No harder than running 'npm test'. [01:23:50] But I agree [01:24:47] doing "vagrant enable-role browsertesting" still tends to end with a core dump, to cite just one issue [01:24:53] It matters a lot because writing unit tests in this manner is risky, hard to review, hard to maintain, and has a high ratio of maintenance vs. potential to catch regressions. [01:25:09] I'm not in QA, I feel your pain. [01:25:24] I've yet to run browsertests for VE from my own command line. [01:25:34] Or for a VE team member to add tests for a new feature. [01:26:04] (as opposed to it running somehow somewhere and the QA team maintaining the tests for us) [01:26:48] Anyway, we've found the curlprit. I could put it into a patch but I think id' be more efficient for you to do so as I'm not too familiar with how these tests are structured. [01:27:17] yeah, as i said i will fix it [01:27:29] OK [01:27:32] and replace with a css animation eventually [01:28:13] Bottom line: The tests are doing too many UI assertions. They should be tested to some degree, but this is too much and too detailed / repeating details of the implementation. Though this isn't a rule of thumb, the fact that afaik nobody else writes tests like this in mediawiki/extensions is sign of some value. [01:28:47] I'd recommend looking into centralising restoration of these methods in a way that makes it impossible by design to forget to restore [01:29:10] (simiar to how we preserve mw.config automatically already, see newMwEnvironment) [01:29:26] would like to do that, not sure we'll find the time [01:29:46] Happy to sit down or schedule a meeting about best practices at some point. Anyway, glad we found it [01:29:52] i was thinking about using sinons sandbox [01:29:53] a developer adding an animation somewhere would have broken the neatest unit test in exactly the same way [01:30:06] or using dependency injection all the way [01:30:06] the connection you're making is far fetched [01:30:27] but gi11es is right, this is ultimately a test isolation issue [01:30:28] disabling animations entirely, automatically, is something that'd be worth doing [01:30:39] It isn't. If the tests weren't performing an actual DOM manipulation but pure logic, the animation would not be fired when testing the code units themselves. [01:30:57] And even if you would, using a time simulation would flatten those all together making them not interfere still. [01:31:22] if the tests werent performing DOM manipulation, they would be quite useless for testing an extension that's focused on GUI [01:31:41] I think there's too many cases in these tests where there was felt a need for a certain test, there was no clean way to do it, so it was done in a non-clean way instead of leaving it be for now. Sometimes its not worth it. [01:31:46] exactly, and we've caught several regressions with those tests [01:32:34] so, no coverage is better? right. [01:32:54] No, you find a better way. Or invest a little more in the environment to acommodate it. [01:33:02] Or use a different framework. [01:33:16] I'd like to live in that fantasy world without launch dates [01:33:29] the problem here is that setting up a clock sandbox should isolate your test from the other ones which are not sandboxed [01:33:58] But overwriting .animate in places and relying on user event simulation is a sign of anipatterns. Example: To test login, you don't simulate login.click(), you move the logic of the login click handler into app.login and call that directly. [01:34:08] Because you don't need to assert that clicking a link will fire the click handler [01:34:26] media viewer's UI and its logic is a little more advanced than that [01:34:41] I can give you wishful thinking all night as well, doesn't make it interesting [01:34:45] Sure. We're done here. [01:56:06] (03CR) 10Mattflaschen: [C: 031] "Tested, both output files look good." [extensions/GettingStarted] - 10https://gerrit.wikimedia.org/r/118063 (owner: 10Phuedx) [02:03:36] (03Abandoned) 10Gilles: Revert "jquery.makeCollapsible.test: Use fake timers to advance animations" [core] - 10https://gerrit.wikimedia.org/r/121904 (owner: 10Gilles) [02:03:39] (03Abandoned) 10Gilles: Revert "jquery.color.test: Use fake timers" [core] - 10https://gerrit.wikimedia.org/r/121901 (owner: 10Gilles) [02:21:51] (03CR) 10Mattflaschen: "Jorm, this is adding it to the core HTMLForm library. It may first be used by SecurePoll, but we can be sure extensions (and maybe core a" [core] - 10https://gerrit.wikimedia.org/r/118111 (owner: 10Anomie) [02:35:03] (03CR) 10Mattflaschen: [C: 04-1] "Per Amire80, and might as well change the ellipsis per James." [extensions/GuidedTour] - 10https://gerrit.wikimedia.org/r/119261 (owner: 10Phuedx) [04:03:40] (03CR) 10Aude: HTMLForm: Add date type (034 comments) [core] - 10https://gerrit.wikimedia.org/r/118111 (owner: 10Anomie) [04:09:42] (03CR) 10Mattflaschen: [C: 04-1] "> I'm not sure what advantage this approach would have over the current approach. Now that the test case has been renamed (see above), it'" (031 comment) [core] - 10https://gerrit.wikimedia.org/r/119055 (owner: 10Phuedx) [04:17:35] (03PS1) 10Chad: Adding interwiki search descriptions for WMF sites [extensions/WikimediaMessages] - 10https://gerrit.wikimedia.org/r/121910 [04:18:23] (03PS2) 10Chad: Adding interwiki search descriptions for WMF sites [extensions/WikimediaMessages] - 10https://gerrit.wikimedia.org/r/121910 [04:32:06] (03PS1) 10Brian Wolff: Cache RecentChanges Atom feed in varnish for 15 seconds [core] - 10https://gerrit.wikimedia.org/r/121912 [05:01:11] (03PS4) 10EBernhardson: Standardize URL generation [extensions/Flow] - 10https://gerrit.wikimedia.org/r/121855 [05:01:23] (03CR) 10jenkins-bot: [V: 04-1] Standardize URL generation [extensions/Flow] - 10https://gerrit.wikimedia.org/r/121855 (owner: 10EBernhardson) [05:09:06] (03CR) 10Santhosh: [C: 04-1] Testing infrastructure (037 comments) [services/cxserver] - 10https://gerrit.wikimedia.org/r/121899 (owner: 10Divec) [05:16:17] (03PS1) 10Santhosh: Minor whitespace fixes [services/cxserver] - 10https://gerrit.wikimedia.org/r/121913 [05:25:48] (03CR) 10Mattflaschen: "Inline comments re mw-editsection-like (and why we don't want content to use mw-editsection) and pre.javascript" (032 comments) [core] - 10https://gerrit.wikimedia.org/r/120978 (owner: 10Kaldari) [05:43:06] (03PS1) 10Aude: Add 1px solid #e0e0e0 border to toc [extensions/VectorBeta] - 10https://gerrit.wikimedia.org/r/121915 [05:43:08] (03CR) 10jenkins-bot: [V: 04-1] Add 1px solid #e0e0e0 border to toc [extensions/VectorBeta] - 10https://gerrit.wikimedia.org/r/121915 (owner: 10Aude) [05:45:18] hmm, is that out of beta? [05:48:34] (03PS2) 10Aude: Add 1px solid #e0e0e0 border to toc [extensions/VectorBeta] - 10https://gerrit.wikimedia.org/r/121915 [05:52:31] (03PS3) 10Aude: Add 1px solid #e0e0e0 border to toc [extensions/VectorBeta] - 10https://gerrit.wikimedia.org/r/121915 [06:00:10] (03PS1) 10Mattflaschen: Convert TextImages and PageImages to role [vagrant] - 10https://gerrit.wikimedia.org/r/121917 [06:01:43] (03PS2) 10Mattflaschen: Convert TextImages and PageImages to role [vagrant] - 10https://gerrit.wikimedia.org/r/121917 [06:02:37] (03PS4) 10Aude: Add 1px solid #e0e0e0 border to toc [extensions/VectorBeta] - 10https://gerrit.wikimedia.org/r/121915 [06:14:56] (03PS5) 10Aude: Add 1px solid #e0e0e0 border to toc [extensions/VectorBeta] - 10https://gerrit.wikimedia.org/r/121915 [06:20:57] (03PS1) 10Mattflaschen: Mention BetaFeatures as dependency [extensions/Popups] - 10https://gerrit.wikimedia.org/r/121918 [06:22:09] (03CR) 10Mattflaschen: "I wrote it like this since https://www.mediawiki.org/wiki/Extension:Popups said it was an optional dependency." [extensions/Popups] - 10https://gerrit.wikimedia.org/r/121918 (owner: 10Mattflaschen) [06:23:07] (03PS2) 10Mattflaschen: Mention BetaFeatures as dependency [extensions/Popups] - 10https://gerrit.wikimedia.org/r/121918 [06:24:44] (03PS3) 10Mattflaschen: Convert TextImages and PageImages to role [vagrant] - 10https://gerrit.wikimedia.org/r/121917 [06:24:50] (03CR) 10Legoktm: [C: 04-1] "Er, that's not how the optional dependency is configured. If BF isn't installed, Popups will be loaded for every user automatically." [extensions/Popups] - 10https://gerrit.wikimedia.org/r/121918 (owner: 10Mattflaschen) [06:25:57] (03PS4) 10Mattflaschen: Convert TextImages and PageImages to role [vagrant] - 10https://gerrit.wikimedia.org/r/121917 [06:43:44] (03PS1) 10KartikMistry: Misc fixes [services/cxserver] - 10https://gerrit.wikimedia.org/r/121919 [06:48:25] (03CR) 10Santhosh: [C: 032] Misc fixes [services/cxserver] - 10https://gerrit.wikimedia.org/r/121919 (owner: 10KartikMistry) [06:48:27] (03Merged) 10jenkins-bot: Misc fixes [services/cxserver] - 10https://gerrit.wikimedia.org/r/121919 (owner: 10KartikMistry) [06:51:42] (03CR) 10Yuvipanda: [C: 04-1] "Popups is enabled by default if you do not have betafeatures installed. We should take that out as a dependency." [vagrant] - 10https://gerrit.wikimedia.org/r/121917 (owner: 10Mattflaschen) [07:05:25] (03PS3) 10Mattflaschen: Mention BetaFeatures as dependency, correct comment [extensions/Popups] - 10https://gerrit.wikimedia.org/r/121918 [07:06:07] (03PS4) 10Mattflaschen: Mention BetaFeatures as dependency, correct comment [extensions/Popups] - 10https://gerrit.wikimedia.org/r/121918 [07:06:39] (03CR) 10Mattflaschen: "Sorry, I made the mistake of reading it quickly and believing the comment. :)" [extensions/Popups] - 10https://gerrit.wikimedia.org/r/121918 (owner: 10Mattflaschen) [07:08:19] (03PS5) 10Mattflaschen: Convert TextImages and PageImages to role [vagrant] - 10https://gerrit.wikimedia.org/r/121917 [07:10:22] (03CR) 10Mattflaschen: "Yeah, fixed. I made the mistake of skimming it and believing the comment. See also https://gerrit.wikimedia.org/r/#/c/121918/" [vagrant] - 10https://gerrit.wikimedia.org/r/121917 (owner: 10Mattflaschen) [07:45:28] (03CR) 10Nikerabbit: [C: 032] Migrate to JSON i18n [extensions/SearchExtraNS] - 10https://gerrit.wikimedia.org/r/121858 (owner: 10Siebrand) [07:45:31] (03Merged) 10jenkins-bot: Migrate to JSON i18n [extensions/SearchExtraNS] - 10https://gerrit.wikimedia.org/r/121858 (owner: 10Siebrand) [07:53:55] (03PS1) 10Tpt: Adds an empty .jshintrc [extensions/ProofreadPage] - 10https://gerrit.wikimedia.org/r/121920 [07:55:06] (03CR) 10Tpt: "I've just made change Iec91fcd20eae128e530f3405f6773e8b42a95ab2 that adds an empty .jshintrc" [extensions/ProofreadPage] - 10https://gerrit.wikimedia.org/r/121839 (owner: 10Siebrand) [07:55:48] (03CR) 10Tpt: "sorry, it's change I719ac2dbe4a4ef3b213dbf1b09a050487bbab919" [extensions/ProofreadPage] - 10https://gerrit.wikimedia.org/r/121839 (owner: 10Siebrand) [08:02:45] (03PS8) 10Nemo bis: Make captcha.py produce images in arbitrary language [extensions/ConfirmEdit] - 10https://gerrit.wikimedia.org/r/121255 [08:07:10] (03CR) 10Nemo bis: "I tried the "Diacritic" feature of regex but it didn't produce anything sensible. We'll need something more sophisticated, either from pyI" [extensions/ConfirmEdit] - 10https://gerrit.wikimedia.org/r/121255 (owner: 10Nemo bis) [08:16:48] (03CR) 10Raimond Spekking: [C: 032] Migrate to JSON i18n [extensions/SyntaxHighlight_GeSHi] - 10https://gerrit.wikimedia.org/r/121872 (owner: 10Siebrand) [08:16:50] (03Merged) 10jenkins-bot: Migrate to JSON i18n [extensions/SyntaxHighlight_GeSHi] - 10https://gerrit.wikimedia.org/r/121872 (owner: 10Siebrand) [08:17:04] (03PS1) 10Shirayuki: i18n: Give grep a chance to find the usages [core] - 10https://gerrit.wikimedia.org/r/121921 [08:20:32] (03Abandoned) 10Umherirrender: Add CURRENTDAY1/LOCALDAY1 aliases for CURRENTDAY/LOCALDAY [core] - 10https://gerrit.wikimedia.org/r/110705 (owner: 10Umherirrender) [08:22:16] (03CR) 10Mattflaschen: "Jeroen said, "Barring security issues". Nothing has been done about the security issues." [extensions/UIFeedback] - 10https://gerrit.wikimedia.org/r/50004 (owner: 10Lbenedix) [08:22:50] (03CR) 10Brian Wolff: [C: 04-1] "Please test before submitting patches. There's some issues here (like the fatal) that you should have been able to notice by testing." (034 comments) [core] - 10https://gerrit.wikimedia.org/r/112323 (owner: 10Kunalgrover05) [08:23:41] (03CR) 10Raimond Spekking: [C: 032] Migrate to JSON i18n [extensions/SwiftCloudFiles] - 10https://gerrit.wikimedia.org/r/121871 (owner: 10Siebrand) [08:24:00] (03CR) 10Peachey88: "{{Security alert}}, {{XSS security alert}} and family" [extensions/UIFeedback] - 10https://gerrit.wikimedia.org/r/50004 (owner: 10Lbenedix) [08:24:16] (03CR) 10Nikerabbit: [C: 032] i18n: Give grep a chance to find the usages [core] - 10https://gerrit.wikimedia.org/r/121921 (owner: 10Shirayuki) [08:27:12] (03Merged) 10jenkins-bot: i18n: Give grep a chance to find the usages [core] - 10https://gerrit.wikimedia.org/r/121921 (owner: 10Shirayuki) [08:27:25] (03CR) 10Nikerabbit: [C: 032] Migrate to JSON i18n [extensions/SiteMatrix] - 10https://gerrit.wikimedia.org/r/121861 (owner: 10Siebrand) [08:28:11] (03Merged) 10jenkins-bot: Migrate to JSON i18n [extensions/SiteMatrix] - 10https://gerrit.wikimedia.org/r/121861 (owner: 10Siebrand) [08:28:14] (03CR) 10Raimond Spekking: [C: 032] Migrate to JSON i18n [extensions/SubpageSortkey] - 10https://gerrit.wikimedia.org/r/121870 (owner: 10Siebrand) [08:28:19] (03Merged) 10jenkins-bot: Migrate to JSON i18n [extensions/SubpageSortkey] - 10https://gerrit.wikimedia.org/r/121870 (owner: 10Siebrand) [08:32:43] (03CR) 10Nikerabbit: [C: 032] Migrate to JSON i18n [extensions/Solarium] - 10https://gerrit.wikimedia.org/r/121863 (owner: 10Siebrand) [08:32:45] (03Merged) 10jenkins-bot: Migrate to JSON i18n [extensions/Solarium] - 10https://gerrit.wikimedia.org/r/121863 (owner: 10Siebrand) [08:33:56] (03CR) 10Raimond Spekking: [C: 032] Migrate to JSON i18n [extensions/SubPageList3] - 10https://gerrit.wikimedia.org/r/121869 (owner: 10Siebrand) [08:33:58] (03Merged) 10jenkins-bot: Migrate to JSON i18n [extensions/SubPageList3] - 10https://gerrit.wikimedia.org/r/121869 (owner: 10Siebrand) [08:34:10] (03CR) 10Raimond Spekking: [C: 032] Migrate to JSON i18n [extensions/StrategyWiki] - 10https://gerrit.wikimedia.org/r/121867 (owner: 10Siebrand) [08:34:13] (03Merged) 10jenkins-bot: Migrate to JSON i18n [extensions/StrategyWiki] - 10https://gerrit.wikimedia.org/r/121867 (owner: 10Siebrand) [08:34:29] (03CR) 10Raimond Spekking: [C: 032] Migrate to JSON i18n [extensions/SpamBlacklist] - 10https://gerrit.wikimedia.org/r/121864 (owner: 10Siebrand) [08:34:32] (03Merged) 10jenkins-bot: Migrate to JSON i18n [extensions/SpamBlacklist] - 10https://gerrit.wikimedia.org/r/121864 (owner: 10Siebrand) [08:34:38] (03CR) 10Nikerabbit: [C: 032] Migrate to JSON i18n [extensions/ShortUrl] - 10https://gerrit.wikimedia.org/r/121860 (owner: 10Siebrand) [08:34:41] (03Merged) 10jenkins-bot: Migrate to JSON i18n [extensions/ShortUrl] - 10https://gerrit.wikimedia.org/r/121860 (owner: 10Siebrand) [08:37:00] (03CR) 10Raimond Spekking: [C: 032] Migrate to JSON i18n [extensions/SecurePoll] - 10https://gerrit.wikimedia.org/r/121859 (owner: 10Siebrand) [08:37:02] (03Merged) 10jenkins-bot: Migrate to JSON i18n [extensions/SecurePoll] - 10https://gerrit.wikimedia.org/r/121859 (owner: 10Siebrand) [08:37:29] (03CR) 10Siebrand: [C: 032] Adds an empty .jshintrc [extensions/ProofreadPage] - 10https://gerrit.wikimedia.org/r/121920 (owner: 10Tpt) [08:37:37] (03Merged) 10jenkins-bot: Adds an empty .jshintrc [extensions/ProofreadPage] - 10https://gerrit.wikimedia.org/r/121920 (owner: 10Tpt) [08:38:59] (03CR) 10Raimond Spekking: [V: 032] Migrate to JSON i18n [extensions/SwiftCloudFiles] - 10https://gerrit.wikimedia.org/r/121871 (owner: 10Siebrand) [08:40:25] (03CR) 10Mattflaschen: "Thanks, Peachey88, I've added it" [extensions/UIFeedback] - 10https://gerrit.wikimedia.org/r/50004 (owner: 10Lbenedix) [08:41:12] (03CR) 10Siebrand: [C: 032] Adding interwiki search descriptions for WMF sites [extensions/WikimediaMessages] - 10https://gerrit.wikimedia.org/r/121910 (owner: 10Chad) [08:41:15] (03Merged) 10jenkins-bot: Adding interwiki search descriptions for WMF sites [extensions/WikimediaMessages] - 10https://gerrit.wikimedia.org/r/121910 (owner: 10Chad) [08:46:05] (03CR) 10Siebrand: [C: 04-1] "Per Derkjan." [core] - 10https://gerrit.wikimedia.org/r/108514 (owner: 10Gerrit Patch Uploader) [09:16:05] (03CR) 10Raimond Spekking: Adding interwiki search descriptions for WMF sites (031 comment) [extensions/WikimediaMessages] - 10https://gerrit.wikimedia.org/r/121910 (owner: 10Chad) [09:23:52] (03PS21) 10Kunalgrover05: Implement listing for tracking categories [core] - 10https://gerrit.wikimedia.org/r/112323 [09:40:10] Hi, I need to know how to get an edit token inside wiki text? [09:41:17] Basically I need to edit a page using #autoedit parser function(API), and I need edit token inside wiki text so I can send it to the parser function. [09:45:59] Anyone? [09:47:24] you can't [09:49:42] MaxSem :But for security issues , the concept of edit token was introduced.. so #autoedit parser function of Semantic Forms should not have token parameter? [09:50:20] Or is there an other way round to get the edit token? [09:51:18] MaxSem : The bug I am talking about is https://bugzilla.wikimedia.org/show_bug.cgi?id=51505 . [09:58:57] (03CR) 10Nikerabbit: "This is not valid json. We really need json linter for all extensions." [extensions/WikimediaMessages] - 10https://gerrit.wikimedia.org/r/121910 (owner: 10Chad) [10:00:13] pawan_seerwani: the edit token is to prevent CSRF attacks https://en.wikipedia.org/wiki/CSRF [10:00:25] (03PS1) 10Gerrit Patch Uploader: Support for LivePreview [extensions/CategoryTree] - 10https://gerrit.wikimedia.org/r/121925 [10:00:27] (03CR) 10Gerrit Patch Uploader: "This commit was uploaded using the Gerrit Patch Uploader [1]." [extensions/CategoryTree] - 10https://gerrit.wikimedia.org/r/121925 (owner: 10Gerrit Patch Uploader) [10:00:59] huh, and yes, that looks like a major security issue in SemanticForms to me [10:04:22] (03PS2) 10Gerrit Patch Uploader: Support for LivePreview [extensions/CategoryTree] - 10https://gerrit.wikimedia.org/r/121925 [10:04:23] (03CR) 10Gerrit Patch Uploader: "This commit was uploaded using the Gerrit Patch Uploader [1]." [extensions/CategoryTree] - 10https://gerrit.wikimedia.org/r/121925 (owner: 10Gerrit Patch Uploader) [10:05:46] MatmaRex, I am aware of that :) I have a patch ready which solves the issue ie.. if the token parameter used in #autoedit has the hash string.. But the real question how does the mediawiki user get an edit token from inside wikitext? [10:08:00] pawan_seerwani: i'm not sure if i understand the quesiton. you generally can't do that in wikitext [10:24:03] (03CR) 10Nemo bis: "Bug 58279." [extensions/WikimediaMessages] - 10https://gerrit.wikimedia.org/r/121910 (owner: 10Chad) [10:25:06] token in wikitext sounds like an oxymoron [10:45:34] (03PS1) 10Raimond Spekking: Make JSON valid per Nikerabbit's CR [extensions/WikimediaMessages] - 10https://gerrit.wikimedia.org/r/121927 [10:49:56] (03CR) 10Nikerabbit: [C: 032] Make JSON valid per Nikerabbit's CR [extensions/WikimediaMessages] - 10https://gerrit.wikimedia.org/r/121927 (owner: 10Raimond Spekking) [10:49:58] (03Merged) 10jenkins-bot: Make JSON valid per Nikerabbit's CR [extensions/WikimediaMessages] - 10https://gerrit.wikimedia.org/r/121927 (owner: 10Raimond Spekking) [10:51:16] (03CR) 10Yuvipanda: [C: 032] Mention BetaFeatures as dependency, correct comment [extensions/Popups] - 10https://gerrit.wikimedia.org/r/121918 (owner: 10Mattflaschen) [10:51:20] (03Merged) 10jenkins-bot: Mention BetaFeatures as dependency, correct comment [extensions/Popups] - 10https://gerrit.wikimedia.org/r/121918 (owner: 10Mattflaschen) [10:51:50] (03CR) 10Raimond Spekking: "Invalid JSON fixed with I18ec4285d1a0e524a841e797f5e125b399ddefb9" [extensions/WikimediaMessages] - 10https://gerrit.wikimedia.org/r/121910 (owner: 10Chad) [10:53:18] (03PS1) 10IAlex: Add missing line breaks to wfDebug() calls [core] - 10https://gerrit.wikimedia.org/r/121928 [11:09:24] (03PS1) 10Physikerwelt: Remove SVG generation from updateMath script [extensions/MathSearch] - 10https://gerrit.wikimedia.org/r/121929 [11:48:03] (03PS1) 10MaxSem: Make results cacheable [extensions/PageImages] - 10https://gerrit.wikimedia.org/r/121932 [11:54:07] (03PS1) 10MaxSem: Make results cacheable [extensions/TextExtracts] - 10https://gerrit.wikimedia.org/r/121933 [11:56:29] physikerwelt: how is the math extension going ? [12:00:56] (03PS1) 10Addshore: Add phplint for qrpedia repo [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/121934 [12:29:38] (03PS1) 10Siebrand: Migrate to JSON i18n [extensions/TemplateSandbox] - 10https://gerrit.wikimedia.org/r/121935 [12:30:26] (03PS1) 10Siebrand: Migrate to JSON i18n [extensions/TextExtracts] - 10https://gerrit.wikimedia.org/r/121936 [12:31:05] (03PS1) 10Siebrand: Migrate to JSON i18n [extensions/Thanks] - 10https://gerrit.wikimedia.org/r/121937 [12:46:20] (03PS1) 10Siebrand: Migrate to JSON i18n [extensions/timeline] - 10https://gerrit.wikimedia.org/r/121938 [12:47:13] (03PS1) 10Siebrand: Migrate to JSON i18n [extensions/TitleBlacklist] - 10https://gerrit.wikimedia.org/r/121939 [12:47:28] (03CR) 10Physikerwelt: [C: 032 V: 032] Remove SVG generation from updateMath script [extensions/MathSearch] - 10https://gerrit.wikimedia.org/r/121929 (owner: 10Physikerwelt) [12:48:13] (03PS1) 10Siebrand: Migrate to JSON i18n [extensions/TitleKey] - 10https://gerrit.wikimedia.org/r/121940 [12:48:23] (03PS1) 10Raimond Spekking: Some more consistency tweaks [extensions/NukeDPL] - 10https://gerrit.wikimedia.org/r/121941 [12:48:57] (03PS1) 10Siebrand: Migrate to JSON i18n [extensions/TocTree] - 10https://gerrit.wikimedia.org/r/121942 [12:49:49] (03PS1) 10Siebrand: Migrate to JSON i18n [extensions/TorBlock] - 10https://gerrit.wikimedia.org/r/121943 [12:52:15] (03PS1) 10Siebrand: Migrate to JSON i18n [extensions/TrustedXFF] - 10https://gerrit.wikimedia.org/r/121945 [12:53:55] (03PS1) 10Siebrand: Migrate to JSON i18n [extensions/UnicodeConverter] - 10https://gerrit.wikimedia.org/r/121946 [12:54:10] (03PS1) 10Raimond Spekking: Add special page alias file [extensions/NukeDPL] - 10https://gerrit.wikimedia.org/r/121947 [12:55:31] (03CR) 10Siebrand: "Reported bug for missing Jenkins jobs." [extensions/TextExtracts] - 10https://gerrit.wikimedia.org/r/121936 (owner: 10Siebrand) [13:00:16] (03PS2) 10Siebrand: Migrate to JSON i18n [extensions/timeline] - 10https://gerrit.wikimedia.org/r/121938 [13:19:38] (03PS1) 10Siebrand: A few formatting tweaks [extensions/MwEmbedSupport] - 10https://gerrit.wikimedia.org/r/121949 [13:20:04] (03PS2) 10Siebrand: A few formatting tweaks [extensions/MwEmbedSupport] - 10https://gerrit.wikimedia.org/r/121949 [13:22:42] (03CR) 10Raimond Spekking: [C: 032] Migrate to JSON i18n [extensions/timeline] - 10https://gerrit.wikimedia.org/r/121938 (owner: 10Siebrand) [13:22:44] (03Merged) 10jenkins-bot: Migrate to JSON i18n [extensions/timeline] - 10https://gerrit.wikimedia.org/r/121938 (owner: 10Siebrand) [13:22:58] (03CR) 10Raimond Spekking: [C: 032] Migrate to JSON i18n [extensions/TextExtracts] - 10https://gerrit.wikimedia.org/r/121936 (owner: 10Siebrand) [13:23:15] (03CR) 10Raimond Spekking: [C: 032] Migrate to JSON i18n [extensions/UnicodeConverter] - 10https://gerrit.wikimedia.org/r/121946 (owner: 10Siebrand) [13:23:18] (03Merged) 10jenkins-bot: Migrate to JSON i18n [extensions/UnicodeConverter] - 10https://gerrit.wikimedia.org/r/121946 (owner: 10Siebrand) [13:23:37] (03CR) 10Raimond Spekking: [C: 032] Migrate to JSON i18n [extensions/TrustedXFF] - 10https://gerrit.wikimedia.org/r/121945 (owner: 10Siebrand) [13:23:39] (03Merged) 10jenkins-bot: Migrate to JSON i18n [extensions/TrustedXFF] - 10https://gerrit.wikimedia.org/r/121945 (owner: 10Siebrand) [13:23:56] (03CR) 10Raimond Spekking: [C: 032] Migrate to JSON i18n [extensions/TorBlock] - 10https://gerrit.wikimedia.org/r/121943 (owner: 10Siebrand) [13:23:58] (03Merged) 10jenkins-bot: Migrate to JSON i18n [extensions/TorBlock] - 10https://gerrit.wikimedia.org/r/121943 (owner: 10Siebrand) [13:24:15] (03CR) 10Raimond Spekking: [C: 032] Migrate to JSON i18n [extensions/TocTree] - 10https://gerrit.wikimedia.org/r/121942 (owner: 10Siebrand) [13:24:17] (03Merged) 10jenkins-bot: Migrate to JSON i18n [extensions/TocTree] - 10https://gerrit.wikimedia.org/r/121942 (owner: 10Siebrand) [13:24:31] (03CR) 10Raimond Spekking: [C: 032] Migrate to JSON i18n [extensions/TitleKey] - 10https://gerrit.wikimedia.org/r/121940 (owner: 10Siebrand) [13:24:33] (03Merged) 10jenkins-bot: Migrate to JSON i18n [extensions/TitleKey] - 10https://gerrit.wikimedia.org/r/121940 (owner: 10Siebrand) [13:24:46] (03CR) 10Raimond Spekking: [C: 032] Migrate to JSON i18n [extensions/TitleBlacklist] - 10https://gerrit.wikimedia.org/r/121939 (owner: 10Siebrand) [13:24:50] (03Merged) 10jenkins-bot: Migrate to JSON i18n [extensions/TitleBlacklist] - 10https://gerrit.wikimedia.org/r/121939 (owner: 10Siebrand) [13:25:01] (03CR) 10Raimond Spekking: [C: 032] Migrate to JSON i18n [extensions/Thanks] - 10https://gerrit.wikimedia.org/r/121937 (owner: 10Siebrand) [13:25:15] (03CR) 10Raimond Spekking: [C: 032] Migrate to JSON i18n [extensions/TemplateSandbox] - 10https://gerrit.wikimedia.org/r/121935 (owner: 10Siebrand) [13:25:17] (03Merged) 10jenkins-bot: Migrate to JSON i18n [extensions/TemplateSandbox] - 10https://gerrit.wikimedia.org/r/121935 (owner: 10Siebrand) [13:25:19] (03Merged) 10jenkins-bot: Migrate to JSON i18n [extensions/Thanks] - 10https://gerrit.wikimedia.org/r/121937 (owner: 10Siebrand) [13:25:24] (03CR) 10Luis Felipe Schenone: [C: 032 V: 032] Some more consistency tweaks [extensions/NukeDPL] - 10https://gerrit.wikimedia.org/r/121941 (owner: 10Raimond Spekking) [13:28:22] (03CR) 10Luis Felipe Schenone: Add special page alias file (031 comment) [extensions/NukeDPL] - 10https://gerrit.wikimedia.org/r/121947 (owner: 10Raimond Spekking) [13:29:57] (03PS2) 10Raimond Spekking: Add special page alias file [extensions/NukeDPL] - 10https://gerrit.wikimedia.org/r/121947 [13:33:22] (03CR) 10Siebrand: [V: 032] "No Jenkins :)." [extensions/TextExtracts] - 10https://gerrit.wikimedia.org/r/121936 (owner: 10Siebrand) [13:35:28] (03CR) 10Luis Felipe Schenone: [C: 032 V: 032] Add special page alias file [extensions/NukeDPL] - 10https://gerrit.wikimedia.org/r/121947 (owner: 10Raimond Spekking) [13:44:21] (03PS1) 10Siebrand: Add support for JSON files using messageDir. [extensions/MwEmbedSupport] - 10https://gerrit.wikimedia.org/r/121950 [13:45:36] (03PS2) 10Siebrand: Add support for JSON files using messageDir. [extensions/MwEmbedSupport] - 10https://gerrit.wikimedia.org/r/121950 [13:46:18] (03CR) 10Raimond Spekking: [V: 032] Migrate to JSON i18n [extensions/TextExtracts] - 10https://gerrit.wikimedia.org/r/121936 (owner: 10Siebrand) [13:46:45] "Is gerrit slow for everyone or just for me?" [13:46:49] Where is that website? [13:57:04] http://service.boyum-it.com/education/b1-productivity-package/b1-print-and-delivery/e-learning/ [13:57:07] ffs [13:57:13] didn't mean to paste that [14:20:53] (03CR) 10TheDJ: "@Steven, just to satisfy my own curiosity, which browser did you test ?" [core] - 10https://gerrit.wikimedia.org/r/119998 (owner: 10TheDJ) [14:24:58] (03CR) 10Raimond Spekking: "Luis, do you plan to fix the FIXME (PLURAL)? That is currently the only blocker before I can add the extension to translatewiki.net." [extensions/NukeDPL] - 10https://gerrit.wikimedia.org/r/121941 (owner: 10Raimond Spekking) [14:42:02] (03PS2) 10Bartosz Dziewoński: mediawiki.ui: Do not depend on divs being present inside .mw-ui-vform [core] - 10https://gerrit.wikimedia.org/r/121842 [14:51:28] (03CR) 10Thiemo Mättig (WMDE): Allow to optionally set language in Message constructor (031 comment) [core] - 10https://gerrit.wikimedia.org/r/121113 (owner: 10Aude) [14:56:48] (03CR) 10Lbenedix: "I started to work on a gadget to circumvent the lengthy review process in gerrit but had no time to finish it before I had to deliver my t" [extensions/UIFeedback] - 10https://gerrit.wikimedia.org/r/50004 (owner: 10Lbenedix) [15:06:34] (03PS1) 10Bartosz Dziewoński: vector: Style .mw-editsection-like in addition to .mw-editsection [core] - 10https://gerrit.wikimedia.org/r/121952 [15:09:11] (03PS1) 10Bartosz Dziewoński: commonElements: Move sup, sub styling from Vector's CSS to common styles [core] - 10https://gerrit.wikimedia.org/r/121953 [15:09:16] (03CR) 10Bartosz Dziewoński: "Two more followups." (032 comments) [core] - 10https://gerrit.wikimedia.org/r/120978 (owner: 10Kaldari) [15:09:51] (03PS1) 10Luis Felipe Schenone: Revert "Some more consistency tweaks" [extensions/NukeDPL] - 10https://gerrit.wikimedia.org/r/121954 [15:10:43] (03PS2) 10Bartosz Dziewoński: commonElements: Move sup, sub styling from Vector's CSS to common styles [core] - 10https://gerrit.wikimedia.org/r/121953 [15:10:52] (03Abandoned) 10Luis Felipe Schenone: Revert "Some more consistency tweaks" [extensions/NukeDPL] - 10https://gerrit.wikimedia.org/r/121954 (owner: 10Luis Felipe Schenone) [15:12:27] (03PS1) 10Luis Felipe Schenone: Added {{PLURAL...}} and changed s for s [extensions/NukeDPL] - 10https://gerrit.wikimedia.org/r/121955 [15:13:09] (03CR) 10Luis Felipe Schenone: [C: 032 V: 032] Added {{PLURAL...}} and changed s for s [extensions/NukeDPL] - 10https://gerrit.wikimedia.org/r/121955 (owner: 10Luis Felipe Schenone) [15:13:56] (03CR) 10Luis Felipe Schenone: "For some reason I thought that comment was for the people at TranslateWiki. Just did the changes, check https://gerrit.wikimedia.org/r/#/c" [extensions/NukeDPL] - 10https://gerrit.wikimedia.org/r/121941 (owner: 10Raimond Spekking) [15:15:01] (03CR) 10Siebrand: Added {{PLURAL...}} and changed s for s (031 comment) [extensions/NukeDPL] - 10https://gerrit.wikimedia.org/r/121955 (owner: 10Luis Felipe Schenone) [15:16:06] (03CR) 10Luis Felipe Schenone: Added {{PLURAL...}} and changed s for s (031 comment) [extensions/NukeDPL] - 10https://gerrit.wikimedia.org/r/121955 (owner: 10Luis Felipe Schenone) [15:18:05] (03CR) 10Luis Felipe Schenone: Added {{PLURAL...}} and changed s for s (031 comment) [extensions/NukeDPL] - 10https://gerrit.wikimedia.org/r/121955 (owner: 10Luis Felipe Schenone) [15:24:54] (03CR) 10Luis Felipe Schenone: "And sorry for my rushed merges, I guess I'm overconfident, I'll learn." [extensions/NukeDPL] - 10https://gerrit.wikimedia.org/r/121955 (owner: 10Luis Felipe Schenone) [15:25:11] (03CR) 10Siebrand: "Pointed out some inconsistencies." (0316 comments) [core] - 10https://gerrit.wikimedia.org/r/121928 (owner: 10IAlex) [15:27:04] (03CR) 10Bartosz Dziewoński: [C: 04-1] "The regexp problem is with the "\15" part. It "matches the character with octal index 15 (13 decimal or D hexadecimal) in the character se" [core] - 10https://gerrit.wikimedia.org/r/117808 (owner: 10TheDJ) [15:31:20] (03CR) 10Siebrand: Added {{PLURAL...}} and changed s for s (031 comment) [extensions/NukeDPL] - 10https://gerrit.wikimedia.org/r/121955 (owner: 10Luis Felipe Schenone) [15:33:47] (03CR) 10Siebrand: "Was i18n/wikimedia/en.json actually linted? jslint did run, and should have -1-ed here, I think." [extensions/WikimediaMessages] - 10https://gerrit.wikimedia.org/r/121910 (owner: 10Chad) [15:35:10] (03CR) 10Se4598: "as it seems to be not already scheduled/applied to WMF database by Springle, I created bug 63261" [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/110881 (owner: 10Se4598) [15:43:37] (03PS1) 10Nikerabbit: Avoid fatal errors in api [extensions/LiquidThreads] - 10https://gerrit.wikimedia.org/r/121957 [15:44:47] (03CR) 10Nikerabbit: [C: 032] A few formatting tweaks [extensions/MwEmbedSupport] - 10https://gerrit.wikimedia.org/r/121949 (owner: 10Siebrand) [15:44:49] (03PS1) 10Luis Felipe Schenone: Fixed {{PLURAL...}} and other minor i18n things [extensions/NukeDPL] - 10https://gerrit.wikimedia.org/r/121958 [15:44:51] (03Merged) 10jenkins-bot: A few formatting tweaks [extensions/MwEmbedSupport] - 10https://gerrit.wikimedia.org/r/121949 (owner: 10Siebrand) [15:46:10] (03CR) 10Luis Felipe Schenone: "I promise not to merge until you approve. XD" [extensions/NukeDPL] - 10https://gerrit.wikimedia.org/r/121958 (owner: 10Luis Felipe Schenone) [15:47:58] (03CR) 10Siebrand: [C: 032] Avoid fatal errors in api [extensions/LiquidThreads] - 10https://gerrit.wikimedia.org/r/121957 (owner: 10Nikerabbit) [15:48:00] (03Merged) 10jenkins-bot: Avoid fatal errors in api [extensions/LiquidThreads] - 10https://gerrit.wikimedia.org/r/121957 (owner: 10Nikerabbit) [15:49:39] (03CR) 10Nikerabbit: [C: 04-1] Add support for JSON files using messageDir. (032 comments) [extensions/MwEmbedSupport] - 10https://gerrit.wikimedia.org/r/121950 (owner: 10Siebrand) [15:51:54] (03PS3) 10Siebrand: Add support for JSON files using messageDir. [extensions/MwEmbedSupport] - 10https://gerrit.wikimedia.org/r/121950 [15:57:17] (03CR) 10Siebrand: Add support for JSON files using messageDir. (032 comments) [extensions/MwEmbedSupport] - 10https://gerrit.wikimedia.org/r/121950 (owner: 10Siebrand) [15:58:26] (03PS7) 10TheDJ: [WIP] Additional CodeEditor buttons [extensions/CodeEditor] - 10https://gerrit.wikimedia.org/r/104512 [15:58:28] (03CR) 10jenkins-bot: [V: 04-1] [WIP] Additional CodeEditor buttons [extensions/CodeEditor] - 10https://gerrit.wikimedia.org/r/104512 (owner: 10TheDJ) [15:59:47] (03PS4) 10TheDJ: Improve the CodeEditor toolbar [extensions/CodeEditor] - 10https://gerrit.wikimedia.org/r/118993 [16:00:54] (03PS1) 10Nikerabbit: ApiFeedRecentChanges: Validate param target [core] - 10https://gerrit.wikimedia.org/r/121959 [16:06:32] (03PS8) 10TheDJ: [WIP] Additional CodeEditor buttons [extensions/CodeEditor] - 10https://gerrit.wikimedia.org/r/104512 [16:08:27] (03PS1) 10Siebrand: Migrate to JSON i18n [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/121960 [16:09:52] (03PS1) 10Siebrand: Migrate to JSON i18n [extensions/UserDailyContribs] - 10https://gerrit.wikimedia.org/r/121961 [16:10:42] (03PS1) 10Siebrand: Migrate to JSON i18n [extensions/UserMerge] - 10https://gerrit.wikimedia.org/r/121962 [16:11:43] (03PS1) 10Siebrand: Migrate to JSON i18n [extensions/VectorBeta] - 10https://gerrit.wikimedia.org/r/121963 [16:12:16] (03CR) 10Raimond Spekking: [C: 032 V: 032] Implemented changes for getting into translatewiki [extensions/BlueSpiceFoundation] - 10https://gerrit.wikimedia.org/r/121684 (owner: 10Smuggli) [16:12:32] (03PS1) 10Siebrand: Migrate to JSON i18n [extensions/VipsScaler] - 10https://gerrit.wikimedia.org/r/121964 [16:12:36] (03PS2) 10Raimond Spekking: Implemented changes for getting into translatewiki [extensions/BlueSpiceFoundation] - 10https://gerrit.wikimedia.org/r/121684 (owner: 10Smuggli) [16:13:00] (03CR) 10Raimond Spekking: [C: 032 V: 032] Implemented changes for getting into translatewiki [extensions/BlueSpiceFoundation] - 10https://gerrit.wikimedia.org/r/121684 (owner: 10Smuggli) [16:14:11] (03PS1) 10Siebrand: Migrate to JSON i18n [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/121965 [16:14:47] (03CR) 10Nikerabbit: [C: 032] Migrate to JSON i18n [extensions/UserDailyContribs] - 10https://gerrit.wikimedia.org/r/121961 (owner: 10Siebrand) [16:14:49] (03Merged) 10jenkins-bot: Migrate to JSON i18n [extensions/UserDailyContribs] - 10https://gerrit.wikimedia.org/r/121961 (owner: 10Siebrand) [16:15:06] (03PS1) 10Siebrand: Migrate to JSON i18n [extensions/wikihiero] - 10https://gerrit.wikimedia.org/r/121966 [16:15:35] (03CR) 10Nikerabbit: [C: 032] Migrate to JSON i18n [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/121960 (owner: 10Siebrand) [16:15:43] (03Merged) 10jenkins-bot: Migrate to JSON i18n [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/121960 (owner: 10Siebrand) [16:16:00] (03PS1) 10Siebrand: Migrate to JSON i18n [extensions/WikiLove] - 10https://gerrit.wikimedia.org/r/121967 [16:16:16] (03CR) 10Nikerabbit: [C: 032] Migrate to JSON i18n [extensions/UserMerge] - 10https://gerrit.wikimedia.org/r/121962 (owner: 10Siebrand) [16:16:18] (03Merged) 10jenkins-bot: Migrate to JSON i18n [extensions/UserMerge] - 10https://gerrit.wikimedia.org/r/121962 (owner: 10Siebrand) [16:16:45] (03CR) 10Nikerabbit: [C: 032] Migrate to JSON i18n [extensions/VectorBeta] - 10https://gerrit.wikimedia.org/r/121963 (owner: 10Siebrand) [16:16:50] (03Merged) 10jenkins-bot: Migrate to JSON i18n [extensions/VectorBeta] - 10https://gerrit.wikimedia.org/r/121963 (owner: 10Siebrand) [16:16:52] (03PS1) 10Siebrand: Migrate to JSON i18n [extensions/WikimediaEvents] - 10https://gerrit.wikimedia.org/r/121968 [16:17:04] (03CR) 10Nikerabbit: [C: 032] Migrate to JSON i18n [extensions/VipsScaler] - 10https://gerrit.wikimedia.org/r/121964 (owner: 10Siebrand) [16:17:07] (03Merged) 10jenkins-bot: Migrate to JSON i18n [extensions/VipsScaler] - 10https://gerrit.wikimedia.org/r/121964 (owner: 10Siebrand) [16:17:37] (03CR) 10Nikerabbit: [C: 032] Migrate to JSON i18n [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/121965 (owner: 10Siebrand) [16:17:40] (03PS1) 10Siebrand: Migrate to JSON i18n [extensions/WikimediaIncubator] - 10https://gerrit.wikimedia.org/r/121969 [16:17:42] (03Merged) 10jenkins-bot: Migrate to JSON i18n [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/121965 (owner: 10Siebrand) [16:18:28] (03CR) 10Nikerabbit: [C: 032] Migrate to JSON i18n [extensions/WikimediaIncubator] - 10https://gerrit.wikimedia.org/r/121969 (owner: 10Siebrand) [16:18:30] (03Merged) 10jenkins-bot: Migrate to JSON i18n [extensions/WikimediaIncubator] - 10https://gerrit.wikimedia.org/r/121969 (owner: 10Siebrand) [16:19:04] (03CR) 10Nikerabbit: [C: 032] Migrate to JSON i18n [extensions/WikimediaEvents] - 10https://gerrit.wikimedia.org/r/121968 (owner: 10Siebrand) [16:19:06] (03Merged) 10jenkins-bot: Migrate to JSON i18n [extensions/WikimediaEvents] - 10https://gerrit.wikimedia.org/r/121968 (owner: 10Siebrand) [16:20:06] (03CR) 10Nikerabbit: [C: 032] Migrate to JSON i18n [extensions/wikihiero] - 10https://gerrit.wikimedia.org/r/121966 (owner: 10Siebrand) [16:20:10] (03Merged) 10jenkins-bot: Migrate to JSON i18n [extensions/wikihiero] - 10https://gerrit.wikimedia.org/r/121966 (owner: 10Siebrand) [16:21:56] (03CR) 10Nikerabbit: [C: 04-1] Migrate to JSON i18n (031 comment) [extensions/WikiLove] - 10https://gerrit.wikimedia.org/r/121967 (owner: 10Siebrand) [16:24:01] (03PS2) 10Nikerabbit: Migrate to JSON i18n [extensions/WikiLove] - 10https://gerrit.wikimedia.org/r/121967 (owner: 10Siebrand) [16:24:49] (03CR) 10Nikerabbit: [C: 032] Migrate to JSON i18n [extensions/WikiLove] - 10https://gerrit.wikimedia.org/r/121967 (owner: 10Siebrand) [16:24:51] (03Merged) 10jenkins-bot: Migrate to JSON i18n [extensions/WikiLove] - 10https://gerrit.wikimedia.org/r/121967 (owner: 10Siebrand) [16:25:43] if someone is around, please review https://gerrit.wikimedia.org/r/#/c/121959/ [16:28:18] Like, now? [16:28:30] i.e., emergency? [16:31:34] (03CR) 10Raimond Spekking: [C: 04-1] Fixed {{PLURAL...}} and other minor i18n things (031 comment) [extensions/NukeDPL] - 10https://gerrit.wikimedia.org/r/121958 (owner: 10Luis Felipe Schenone) [16:42:10] (03CR) 10Nikerabbit: [C: 031] "+1, but haven't tested." [extensions/MwEmbedSupport] - 10https://gerrit.wikimedia.org/r/121950 (owner: 10Siebrand) [16:44:11] (03PS1) 10IAlex: Send the localisation store debug message to the "caches" log group [core] - 10https://gerrit.wikimedia.org/r/121971 [16:47:14] (03CR) 10Nikerabbit: [C: 032] Send the localisation store debug message to the "caches" log group [core] - 10https://gerrit.wikimedia.org/r/121971 (owner: 10IAlex) [16:47:52] (03CR) 10Luis Felipe Schenone: Fixed {{PLURAL...}} and other minor i18n things (031 comment) [extensions/NukeDPL] - 10https://gerrit.wikimedia.org/r/121958 (owner: 10Luis Felipe Schenone) [16:50:06] (03Merged) 10jenkins-bot: Send the localisation store debug message to the "caches" log group [core] - 10https://gerrit.wikimedia.org/r/121971 (owner: 10IAlex) [16:51:14] (03CR) 10IAlex: "Messages I receive the most often don't have punctuation. So I don't know in which direction this should go. Anyway my feeling is that tha" [core] - 10https://gerrit.wikimedia.org/r/121928 (owner: 10IAlex) [16:51:57] (03CR) 10Raimond Spekking: Fixed {{PLURAL...}} and other minor i18n things (031 comment) [extensions/NukeDPL] - 10https://gerrit.wikimedia.org/r/121958 (owner: 10Luis Felipe Schenone) [16:58:18] (03PS2) 10Luis Felipe Schenone: Fixed {{PLURAL...}} and other minor i18n things [extensions/NukeDPL] - 10https://gerrit.wikimedia.org/r/121958 [17:00:01] (03PS3) 10Luis Felipe Schenone: Fixed {{PLURAL...}} and other minor i18n things [extensions/NukeDPL] - 10https://gerrit.wikimedia.org/r/121958 [19:59:09] (03CR) 10TheDJ: [C: 032] commonElements: Move sup, sub styling from Vector's CSS to common styles [core] - 10https://gerrit.wikimedia.org/r/121953 (owner: 10Bartosz Dziewoński) [20:17:32] (03PS1) 10Ganeshaditya1: (Bug 56363) ChangeEmail special page rewritten to use vforms. [core] - 10https://gerrit.wikimedia.org/r/121975 [20:23:15] Hey I have re-written the special:changeemail page to use vforms. [20:23:16] https://gerrit.wikimedia.org/r/#/c/121975/ [20:23:28] Could some one review it for me. I am looking for reviewers. [20:25:34] Am I on the wrong channel ? [20:25:48] (03CR) 10Chad: Adding interwiki search descriptions for WMF sites (031 comment) [extensions/WikimediaMessages] - 10https://gerrit.wikimedia.org/r/121910 (owner: 10Chad) [20:37:09] (03PS1) 10Siebrand: Migrate to JSON i18n [extensions/MwEmbedSupport] - 10https://gerrit.wikimedia.org/r/121976 [20:47:23] (03PS2) 10Siebrand: ChangeEmail special page rewritten to use vforms. [core] - 10https://gerrit.wikimedia.org/r/121975 (owner: 10Ganeshaditya1) [20:48:19] (03PS1) 10Ebe123: Standardize "Error" messages [extensions/WikimediaIncubator] - 10https://gerrit.wikimedia.org/r/121980 [20:49:23] (03CR) 10Siebrand: [C: 04-1] "Some code formatting reviewed." (033 comments) [core] - 10https://gerrit.wikimedia.org/r/121975 (owner: 10Ganeshaditya1) [20:52:57] (03PS9) 10TheDJ: [WIP] Additional CodeEditor buttons [extensions/CodeEditor] - 10https://gerrit.wikimedia.org/r/104512 [20:54:11] (03PS2) 10Siebrand: Migrate to JSON i18n [extensions/MwEmbedSupport] - 10https://gerrit.wikimedia.org/r/121976 [20:54:33] (03PS4) 10Siebrand: Add support for JSON files using messageDir [extensions/MwEmbedSupport] - 10https://gerrit.wikimedia.org/r/121950 [20:54:41] (03PS3) 10Siebrand: Migrate to JSON i18n [extensions/MwEmbedSupport] - 10https://gerrit.wikimedia.org/r/121976 [20:56:55] (03PS4) 10Siebrand: Migrate to JSON i18n [extensions/MwEmbedSupport] - 10https://gerrit.wikimedia.org/r/121976 [21:07:40] (03PS1) 10Siebrand: Migrate to JSON i18n [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/121981 [21:08:40] (03PS2) 10Siebrand: Migrate to JSON i18n [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/121981 [21:09:04] (03PS3) 10Siebrand: Migrate to JSON i18n [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/121981 [21:14:04] (03PS1) 10Mattflaschen: Upgrade html2canvas to remove XSS [extensions/UIFeedback] - 10https://gerrit.wikimedia.org/r/122001 [21:16:22] (03CR) 10Mattflaschen: "This removes the XSS (my report upstream was fixed), so when it's merged we can remove the XSS template at https://www.mediawiki.org/wiki/" [extensions/UIFeedback] - 10https://gerrit.wikimedia.org/r/122001 (owner: 10Mattflaschen) [21:18:06] (03CR) 10Mattflaschen: "> The main blocker was the file upload to commons or the wikis file upload api." [extensions/UIFeedback] - 10https://gerrit.wikimedia.org/r/50004 (owner: 10Lbenedix) [21:46:01] (03CR) 10Mattflaschen: [C: 031] "I agree, tag name does not seem like the best way to do this, especially with a generic tag like div (IIRC, Munaf considered some other ta" (031 comment) [core] - 10https://gerrit.wikimedia.org/r/121842 (owner: 10Bartosz Dziewoński) [21:49:02] (03CR) 10Mattflaschen: [C: 032] vector: Style .mw-editsection-like in addition to .mw-editsection [core] - 10https://gerrit.wikimedia.org/r/121952 (owner: 10Bartosz Dziewoński) [21:52:33] (03Merged) 10jenkins-bot: vector: Style .mw-editsection-like in addition to .mw-editsection [core] - 10https://gerrit.wikimedia.org/r/121952 (owner: 10Bartosz Dziewoński) [22:05:33] (03PS13) 10UltrasonicNXT: WIP - Rewrite [extensions/WikiForum] - 10https://gerrit.wikimedia.org/r/116258 [22:17:05] (03PS3) 10Ganeshaditya1: ChangeEmail special page rewritten to use vforms. [core] - 10https://gerrit.wikimedia.org/r/121975 [22:17:31] (03Abandoned) 10Umherirrender: API: Return set values for action=options [core] - 10https://gerrit.wikimedia.org/r/92928 (owner: 10Umherirrender) [22:18:43] (03PS4) 10Ganeshaditya1: ChangeEmail special page rewritten to use vforms. [core] - 10https://gerrit.wikimedia.org/r/121975 [22:20:18] (03CR) 10Ganeshaditya1: "About those red and green stripes. I think we should let the browser validate email just like signup page does." [core] - 10https://gerrit.wikimedia.org/r/121975 (owner: 10Ganeshaditya1) [22:42:11] (03CR) 10Danorton: "Would it be better to use $wgConfigClass::get/set? I don't see it being used anywhere in DefaultSettings.php" [core] - 10https://gerrit.wikimedia.org/r/118981 (owner: 10Danorton) [22:45:03] (03CR) 10Mattflaschen: [C: 032] "There are two separate message groups. I tested one each from each group:" [extensions/MwEmbedSupport] - 10https://gerrit.wikimedia.org/r/121976 (owner: 10Siebrand) [22:55:32] (03CR) 10Siebrand: "Thanks, Matt. Can you please review the parent, too?" [extensions/MwEmbedSupport] - 10https://gerrit.wikimedia.org/r/121976 (owner: 10Siebrand) [22:58:40] marktraceur: around? [22:59:26] legoktm: Hello! When you're on IRC it's usually good practice to jump right in and ask a question, as it saves time for everyone involved :) how can we help you? [22:59:45] lol [23:00:16] I was thinking of whether we should use a $wg global to register betafeatures rather than using a hook [23:00:37] because right now if anything needs to access the list of features, it has to run the hook [23:01:02] let me find the bug I'm thinking about [23:02:54] marktraceur: https://bugzilla.wikimedia.org/show_bug.cgi?id=62897 [23:04:17] legoktm: Saving it to a $wg per-request might be OK [23:04:43] Not sure if it's actually useful [23:05:13] I think it will be [23:05:25] we could also have a static function that everything calls [23:05:56] (03CR) 10Swalling: "Sorry TheDJ, should have said: screenshot is from Chrome." [core] - 10https://gerrit.wikimedia.org/r/119998 (owner: 10TheDJ) [23:06:27] which caches internally [23:06:40] (03PS1) 10TheDJ: CodeEditor: Add support for Editor themes [extensions/CodeEditor] - 10https://gerrit.wikimedia.org/r/122085 [23:06:45] (03CR) 10jenkins-bot: [V: 04-1] CodeEditor: Add support for Editor themes [extensions/CodeEditor] - 10https://gerrit.wikimedia.org/r/122085 (owner: 10TheDJ) [23:08:05] (03PS2) 10TheDJ: CodeEditor: Add support for Editor themes [extensions/CodeEditor] - 10https://gerrit.wikimedia.org/r/122085 [23:11:48] (03CR) 10Ori.livneh: [C: 032] Convert TextImages and PageImages to role [vagrant] - 10https://gerrit.wikimedia.org/r/121917 (owner: 10Mattflaschen) [23:11:53] (03Merged) 10jenkins-bot: Convert TextImages and PageImages to role [vagrant] - 10https://gerrit.wikimedia.org/r/121917 (owner: 10Mattflaschen) [23:11:59] (03CR) 10Mattflaschen: "Does anyone know anything about mwEmbedStandAlone? Is it still supported by this repository?" [extensions/MwEmbedSupport] - 10https://gerrit.wikimedia.org/r/121950 (owner: 10Siebrand) [23:12:49] legoktm: Yeah, I like that a little better [23:14:01] (03CR) 10Mattflaschen: "I ask because MwEmbedResourceManager.php says, "MwEmbedResourceManager adds some convenience functions for loading mwEmbed 'modules'. Its " [extensions/MwEmbedSupport] - 10https://gerrit.wikimedia.org/r/121950 (owner: 10Siebrand) [23:14:10] ok [23:14:16] I'll post a patch in a few minutes [23:14:21] Cool [23:14:37] Until today I thought everybody with an account on bugzilla was allowed to set bugs to RESOLVED/FIXED. I learned today thatat least GSoC students are apparently not allowed. Is it just them or is there a more general rule? And if it is just them, why? [23:17:59] FoxT: I think you need a permission set, but it usually gets set pretty quickly [23:18:18] (03PS2) 10Mattflaschen: Increase the toolbar message container's width [extensions/GettingStarted] - 10https://gerrit.wikimedia.org/r/115891 (owner: 10Phuedx) [23:18:31] marktraceur: Ok, thanks. [23:24:15] (03CR) 10Mattflaschen: [C: 032] "Looks good, tested in a few languages, including Ukranian." [extensions/GettingStarted] - 10https://gerrit.wikimedia.org/r/115891 (owner: 10Phuedx) [23:24:17] (03Merged) 10jenkins-bot: Increase the toolbar message container's width [extensions/GettingStarted] - 10https://gerrit.wikimedia.org/r/115891 (owner: 10Phuedx) [23:44:23] FoxT: certainly has nothing to do with whether or not you are GSoC. more relevant is how old your bugzilla account is and whether someone noticed you needed the bits (or you asked for them) [23:44:37] (03PS1) 10Legoktm: isFeatureEnabled: Check current Skin compatability [extensions/BetaFeatures] - 10https://gerrit.wikimedia.org/r/122086 [23:44:44] (03CR) 10jenkins-bot: [V: 04-1] isFeatureEnabled: Check current Skin compatability [extensions/BetaFeatures] - 10https://gerrit.wikimedia.org/r/122086 (owner: 10Legoktm) [23:44:47] marktraceur: ^ [23:44:53] :/ [23:45:12] jeremyb: Ok, I had two students today reporting independently that they could not set their bugs to RESOLVED. [23:46:03] jeremyb: Would be less hassle for me, might be more motivation for them. [23:46:23] jeremyb: You know, whom to ping? [23:47:45] FoxT: andre__ [23:47:51] there's a bug for this [23:47:58] (03PS3) 10TheDJ: Ask for confirmation when saving document with errors [extensions/CodeEditor] - 10https://gerrit.wikimedia.org/r/121632 [23:48:52] FoxT: https://bugzilla.wikimedia.org/show_bug.cgi?id=40497 [23:49:44] MatmaRex: Thanks. [23:52:15] (03PS2) 10Legoktm: isFeatureEnabled: Check current Skin compatability [extensions/BetaFeatures] - 10https://gerrit.wikimedia.org/r/122086 [23:52:31] yippe.