[00:11:21] (03PS9) 10MaxSem: Elasticsearch support [extensions/GeoData] - 10https://gerrit.wikimedia.org/r/115413 [00:14:31] Hm.. weird. I just used pear to install phpunit and all that is being created is libs/php/doc/PHPUnit [00:14:41] There is no lib/php/PHPUnit/PHPUnit.php etc. [00:14:52] $ find . -name PHPUnit [00:14:52] ./lib/php/doc/PHPUnit [00:15:01] the bin exists [00:15:03] and the doc exists [00:15:13] but no actual php files to be foud in the include path [00:18:42] $ find . -iname phpunit [00:18:42] ./bin/phpunit [00:18:42] ./lib/php/doc/PHPUnit [00:18:44] wtf [00:19:09] /bin/wtf [00:31:52] (03PS8) 10Adi.iiita: LiquidThreads should pass jshint [extensions/LiquidThreads] - 10https://gerrit.wikimedia.org/r/121257 [00:33:09] Krinkle: Fixed the indentation. [00:33:22] marktraceur: Aha, as of PHPUnit 4.0 PEAR, it no longer ships the individual php files [00:33:34] instead it "just works" via the autoloader registered in pear and php.ini [00:33:47] its failing because mediawiki's phpunit.php bootstrap does a require_once for it [00:33:49] (03CR) 10PiRSquared17: "TTO is right, but I62109d645ef15f6e921f868284d2eb908059b873 should be merged as well." [extensions/WikimediaMaintenance] - 10https://gerrit.wikimedia.org/r/112920 (owner: 10Gerrit Patch Uploader) [00:33:52] and in addition for a class that doesn't exist [00:34:23] Hah [00:40:12] hope everything is done now on this .. https://gerrit.wikimedia.org/r/121257 [00:50:29] marktraceur: So, for future reference PHPUnit 4.0 is not compatible. [00:50:31] Have to do sudo pear install --alldeps phpunit/phpunit-3.7.30 [00:50:35] (after uninstall) [00:50:36] great [00:50:45] documentation blames ys [00:50:48] us [00:55:08] Wow. [00:56:01] Krinkle: Please see if this is fine now https://gerrit.wikimedia.org/r/121257 I fixed the indentation. [00:58:10] (03PS1) 10Krinkle: resourceloader: Add unit test to ensure absence of illegal dependencies [core] - 10https://gerrit.wikimedia.org/r/121566 [00:58:39] marktraceur: Took a month, but added the test as I said I would ^ [00:58:56] (I have a chat snippet of you and me talking about that test) [00:59:59] Hahaha [01:00:25] The jquery and mediawiki modules are known by the state of California to contain substances linked to cancer. [01:00:56] RoanKattouw_away: ^^ [01:02:53] (03CR) 10Krinkle: [C: 032] LiquidThreads should pass jshint [extensions/LiquidThreads] - 10https://gerrit.wikimedia.org/r/121257 (owner: 10Adi.iiita) [01:02:59] (03Merged) 10jenkins-bot: LiquidThreads should pass jshint [extensions/LiquidThreads] - 10https://gerrit.wikimedia.org/r/121257 (owner: 10Adi.iiita) [01:03:04] zeek: :) [01:03:29] Thanks :D [01:05:23] TimStarling: Can you reval your -2 on https://gerrit.wikimedia.org/r/#/c/49208/ ? [01:05:31] (03PS10) 10Krinkle: Clean up access points [core] - 10https://gerrit.wikimedia.org/r/49208 (owner: 10Waldir) [01:10:19] (03PS2) 10Krinkle: Deprecate jquery.mwExtension [core] - 10https://gerrit.wikimedia.org/r/117651 (owner: 10Ori.livneh) [01:12:21] (03CR) 10Krinkle: [C: 04-1] "Rebased to resolve notes conflict and to check out usage stats. -1 as this is still used by core, and there should imho not be this many d" [core] - 10https://gerrit.wikimedia.org/r/117651 (owner: 10Ori.livneh) [01:12:38] (03PS6) 10Krinkle: Return a promise from mw.loader.using() [core] - 10https://gerrit.wikimedia.org/r/75511 (owner: 10Helder.wiki) [01:15:06] I was looking into the bug-51505 (https://bugzilla.wikimedia.org/show_bug.cgi?id=51505 - basen of Semantic Forms) , I have found a solution but it involves a minor change in mediawiki-core as well. Will that be acceptable? [01:15:46] pawan_seerwani: I mean, fixing the bug is the primary idea - if it *really* requires the change to core that's fine [01:16:00] pawan_seerwani: Just convince us it's necessary - or maybe ask if it is and we can help you out :) [01:17:16] marktraceur, the change required is adding a new const parameter to includes/EditPage.php [01:17:31] The parameter is as follows : [01:17:31] pawan_seerwani: Can you explain what change you're making? [01:17:35] const AS_INCORRECT_EDIT_TOKEN = 241; [01:18:58] * Surgeon General's Warning: prolonged exposure to this class is known to cause [01:19:01] * headaches, which may be fatal. [01:19:02] <3 comments [01:19:22] marktraceur, to msg generally shown on incorrect csrf token ( edit token) is different than other messages. So inorder to identify this special error, I was thinking of adding the above const parameter [01:19:39] The message* [01:19:43] Aha. [01:21:10] (03PS7) 10Krinkle: resourceloader: Return a promise from mw.loader.using() [core] - 10https://gerrit.wikimedia.org/r/75511 (owner: 10Helder.wiki) [01:21:24] marktraceur, Thoughts? [01:21:52] I'm looking :) [01:22:12] (03PS8) 10Krinkle: resourceloader: Return a promise from mw.loader.using() [core] - 10https://gerrit.wikimedia.org/r/75511 (owner: 10Helder.wiki) [01:23:25] pawan_seerwani: I think in prepareAction in includes/SF_AutoeditAPI.php you should check the $wgUser's edit token against a parameter of the API call [01:23:52] pawan_seerwani: https://doc.wikimedia.org/mediawiki-core/master/php/html/classUser.html#a28fb7ed857a765ed865d0bf3f1daaf35 [01:24:03] So $wgUser->matchEditToken( ... ) [01:24:09] (03PS9) 10Krinkle: resourceloader: Return a promise from mw.loader.using() [core] - 10https://gerrit.wikimedia.org/r/75511 (owner: 10Helder.wiki) [01:24:11] That will return a suitable boolean [01:24:18] (03CR) 10Krinkle: [C: 032] "Added release notes." [core] - 10https://gerrit.wikimedia.org/r/75511 (owner: 10Helder.wiki) [01:24:38] I don't know why you couldn't define the error in the extension. [01:26:13] marktraceur, Oh, I will look into that once and get back. Thanks. [01:28:17] (03Merged) 10jenkins-bot: resourceloader: Return a promise from mw.loader.using() [core] - 10https://gerrit.wikimedia.org/r/75511 (owner: 10Helder.wiki) [01:34:00] marktraceur, I am not actually calling the $wgUser->matchEditToken(...) , instead a parameter EditPage::mTokenOk (which is basically set by matchEditToken()).. and using the mTokenOk in my patch [01:34:17] You probably shouldn't do that, though. [01:34:21] link to my pathc : http://pastebin.com/ww8Q0fE5 [01:34:27] Because it means accessing an EditPage private variable afaict [01:36:13] Oh, alright! But even if I use $wgUser->matchEditToken(...) , I will need the new const parameter AS_INCORRECT_EDIT_TOKEN [01:36:31] pawan_seerwani: I guess I'm not seeing why, can you explain it more? [01:42:39] Oh, I hadn't read your prev msg "on defining error in extension". May be thats what I need. :) [01:47:21] Maybe! [02:58:37] (03PS7) 10Krinkle: resourceloader: Refactor module links output [core] - 10https://gerrit.wikimedia.org/r/95463 [03:09:30] (03PS1) 10Reedy: Move $wgExtensionMessagesFiles['CategoryTreeMagic'] into $wgExtensionFunctions [extensions/CategoryTree] - 10https://gerrit.wikimedia.org/r/121570 [03:12:55] (03PS1) 10BryanDavis: Return exit_status from Application._before_exit [tools/scap] - 10https://gerrit.wikimedia.org/r/121571 [03:17:45] (03PS1) 10Reedy: Add myself back to licensetexts message authors [extensions/WikimediaMessages] - 10https://gerrit.wikimedia.org/r/121572 [03:26:36] https://www.mediawiki.org/wiki/MediaWiki [03:27:10] Does the ´Beta´ tab appear as <betafeatures-... for anyone else too? [03:28:21] Niharika: yes [03:28:48] Niharika: see http://bots.wmflabs.org/~wm-bot/logs/%23wikimedia-operations/20140328.txt [03:28:53] (03PS1) 10AalekhN: Confirm Edit now passes jslint, so make it voting [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/121573 [03:29:03] from 02:53:49 and down [03:29:58] huh: Okay. [03:31:34] Broken on the beta-features page too then. [03:32:05] [03:08:03] Only BetaFeatures and WikimediaMessages [03:32:23] other extensions seem okay [03:36:39] (03PS1) 10AalekhN: Survey should pass Jslint [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/121575 [03:39:31] (03CR) 10Tim Starling: [C: 032] Clean up access points [core] - 10https://gerrit.wikimedia.org/r/49208 (owner: 10Waldir) [03:42:09] (03PS10) 1001tonythomas: Adding a JS Class to inputBox to grey out Submit button. [extensions/InputBox] - 10https://gerrit.wikimedia.org/r/120487 [03:42:58] (03Merged) 10jenkins-bot: Clean up access points [core] - 10https://gerrit.wikimedia.org/r/49208 (owner: 10Waldir) [03:46:35] (03CR) 1001tonythomas: "in InputBox.php," [extensions/InputBox] - 10https://gerrit.wikimedia.org/r/120487 (owner: 1001tonythomas) [04:03:12] (03CR) 10Mattflaschen: [C: 032] "Appears right in Firefox/Iceweasel 24.3.0, Chromium 32.0.1700.123, and IE 7 - 11" [extensions/GettingStarted] - 10https://gerrit.wikimedia.org/r/117874 (owner: 10Phuedx) [04:03:15] (03Merged) 10jenkins-bot: Stop the rightmost toolbar section wrapping [extensions/GettingStarted] - 10https://gerrit.wikimedia.org/r/117874 (owner: 10Phuedx) [04:26:10] It got fixed... [04:32:50] Niharika: yes, some interface messages were not synchronized to all servers correctly [04:33:07] Roan fixed it by forcing a manual re-sync [04:34:08] Ah, okay. [06:38:56] (03PS1) 10Netbrain: Added another missing i18n key [extensions/SideBarMenu] - 10https://gerrit.wikimedia.org/r/121584 [06:39:24] (03PS2) 10IAlex: Send the profiler output to the 'profileoutput' log group [core] - 10https://gerrit.wikimedia.org/r/121336 [06:39:47] (03CR) 10IAlex: "Fixes merge conflict." [core] - 10https://gerrit.wikimedia.org/r/121336 (owner: 10IAlex) [06:39:49] (03CR) 10Netbrain: [C: 032 V: 032] Added another missing i18n key [extensions/SideBarMenu] - 10https://gerrit.wikimedia.org/r/121584 (owner: 10Netbrain) [06:44:36] (03PS1) 10Prtksxna: [wip] Add animation to guiders [extensions/GuidedTour] - 10https://gerrit.wikimedia.org/r/121585 [06:47:16] looking for one of: bd808|BUFFER, ^demon|away or Reedy [06:48:30] looks like after last nigt's scap (this morning's for you I guess) all maintenance jobs now run as wikiuser and the wikiadmin user is mysteriously gone [06:49:34] this means that a bunch of things that are long running and shouldn't be killed got shot (we have a watcher that looks for things *not* running as wikiadmin on the dbs and longer than 5 mins) [06:49:53] anyone with a clue, we need to get this fixed up... thanks [07:07:23] (03CR) 10Nikerabbit: "Maybe http://www.unicode.org/reports/tr36/ has some useful information." [extensions/ConfirmEdit] - 10https://gerrit.wikimedia.org/r/121255 (owner: 10Nemo bis) [07:13:50] (03CR) 10Siebrand: [C: 032] Add myself back to licensetexts message authors [extensions/WikimediaMessages] - 10https://gerrit.wikimedia.org/r/121572 (owner: 10Reedy) [07:13:53] (03Merged) 10jenkins-bot: Add myself back to licensetexts message authors [extensions/WikimediaMessages] - 10https://gerrit.wikimedia.org/r/121572 (owner: 10Reedy) [07:15:09] (03CR) 10Siebrand: [C: 04-1] "Should just load this unconditionally." [extensions/CategoryTree] - 10https://gerrit.wikimedia.org/r/121570 (owner: 10Reedy) [07:15:21] (03CR) 10Prtksxna: [C: 04-1] [wip] Add animation to guiders [extensions/GuidedTour] - 10https://gerrit.wikimedia.org/r/121585 (owner: 10Prtksxna) [07:16:56] (03CR) 10TheDJ: "In theory I agree with Krinkle, but there are a lot of copies of navpopups floating around throughout the sites. So for effectiveness, i w" [extensions/Popups] - 10https://gerrit.wikimedia.org/r/120188 (owner: 10Prtksxna) [07:20:52] (03CR) 10Nikerabbit: "[08:22:18] @Nikerabbit> Reedy: those had no author block (many files were converted, make sure you look at the right ones)" [extensions/WikimediaMessages] - 10https://gerrit.wikimedia.org/r/121572 (owner: 10Reedy) [07:23:01] (03PS1) 10Siebrand: Migrate to JSON i18n [extensions/GWToolset] - 10https://gerrit.wikimedia.org/r/121588 [07:23:54] (03PS1) 10Siebrand: Migrate to JSON i18n [extensions/ImageMap] - 10https://gerrit.wikimedia.org/r/121589 [07:25:00] (03PS1) 10Siebrand: Migrate to JSON i18n [extensions/InputBox] - 10https://gerrit.wikimedia.org/r/121590 [07:26:14] (03PS1) 10Siebrand: Migrate to JSON i18n [extensions/Insider] - 10https://gerrit.wikimedia.org/r/121591 [07:27:42] (03PS1) 10Siebrand: Migrate to JSON i18n [extensions/intersection] - 10https://gerrit.wikimedia.org/r/121592 [07:29:49] (03PS1) 10Siebrand: Migrate to JSON i18n [extensions/LabeledSectionTransclusion] - 10https://gerrit.wikimedia.org/r/121593 [07:32:37] (03PS1) 10Siebrand: Migrate to JSON i18n [extensions/LandingCheck] - 10https://gerrit.wikimedia.org/r/121594 [07:34:19] (03PS1) 10Siebrand: Migrate to JSON i18n [extensions/LdapAuthentication] - 10https://gerrit.wikimedia.org/r/121595 [07:36:38] (03PS1) 10Siebrand: Migrate to JSON i18n [extensions/LiquidThreads] - 10https://gerrit.wikimedia.org/r/121596 [07:37:42] (03PS1) 10Siebrand: Migrate to JSON i18n [extensions/Listings] - 10https://gerrit.wikimedia.org/r/121597 [07:38:52] (03PS1) 10Siebrand: Migrate to JSON i18n [extensions/LocalisationUpdate] - 10https://gerrit.wikimedia.org/r/121598 [07:39:47] (03PS1) 10Siebrand: Migrate to JSON i18n [extensions/MapSources] - 10https://gerrit.wikimedia.org/r/121599 [07:43:43] additional info for one of bd808|BUFFER, ^demon|away or Reedy : privatesettings.php on tin looks to be modified since the last scap so that could be the culprit, would uncommenting the lines about adminsettings there break anything? (spring le noticed that change) [07:47:14] (03CR) 10Rillke: "Without testing this, but was the parameter order simply confused?" (031 comment) [extensions/InputBox] - 10https://gerrit.wikimedia.org/r/120487 (owner: 1001tonythomas) [08:02:02] (03CR) 10Mxn: "Might want to reference bug 5309 and/or bug 62960 in the commit message." [extensions/ConfirmEdit] - 10https://gerrit.wikimedia.org/r/121255 (owner: 10Nemo bis) [08:18:19] (03CR) 10Nemo bis: "> display a word with diacritics and accept only the word _without_ diacritics." [extensions/ConfirmEdit] - 10https://gerrit.wikimedia.org/r/121255 (owner: 10Nemo bis) [08:33:19] (03PS1) 10Gilles: Expose file width and height through data attributes [core] - 10https://gerrit.wikimedia.org/r/121601 [08:35:31] (03CR) 10Gilles: "So, it seems like this new markup would only start appearing if people re-save pages. Is there a mechanism to migrate all existing cached " [core] - 10https://gerrit.wikimedia.org/r/121601 (owner: 10Gilles) [08:36:51] (03PS6) 10Nemo bis: Make captcha.py produce images in arbitrary language [extensions/ConfirmEdit] - 10https://gerrit.wikimedia.org/r/121255 [08:37:23] (03CR) 10Nemo bis: "PS6 just adds some pointers taken from the Unicode document linked by Niklas" [extensions/ConfirmEdit] - 10https://gerrit.wikimedia.org/r/121255 (owner: 10Nemo bis) [08:39:07] (03CR) 10jenkins-bot: [V: 04-1] Expose file width and height through data attributes [core] - 10https://gerrit.wikimedia.org/r/121601 (owner: 10Gilles) [08:39:40] (03CR) 10Mxn: ">> display a word with diacritics and accept only the word _without_ diacritics." [extensions/ConfirmEdit] - 10https://gerrit.wikimedia.org/r/121255 (owner: 10Nemo bis) [09:01:27] (03PS2) 10Siebrand: Migrate to JSON i18n [extensions/LiquidThreads] - 10https://gerrit.wikimedia.org/r/121596 [09:03:11] (03CR) 10Mxn: "For the example CAPTCHA images, be sure to try out the font(s) that Wikimedia uses on its wikis. Fonts like Helvetica seem to work very we" [extensions/ConfirmEdit] - 10https://gerrit.wikimedia.org/r/121255 (owner: 10Nemo bis) [09:05:33] (03CR) 10Nemo bis: "Helvetica is not free. For now I'm using FreeSerif, I may try Noto (Arimo) but there is no coverage table (see bug 59983)." [extensions/ConfirmEdit] - 10https://gerrit.wikimedia.org/r/121255 (owner: 10Nemo bis) [09:16:32] (03CR) 10Siebrand: "Sam probably needs attribution in most files of WMF deployed MediaWiki code..." [extensions/WikimediaMessages] - 10https://gerrit.wikimedia.org/r/121572 (owner: 10Reedy) [09:17:23] (03CR) 10Siebrand: Added another missing i18n key (031 comment) [extensions/SideBarMenu] - 10https://gerrit.wikimedia.org/r/121584 (owner: 10Netbrain) [09:19:07] (03PS1) 10Adrian Lang: Correct CompletenessTest::walkTheObject behaviour wrt breadcrumb [core] - 10https://gerrit.wikimedia.org/r/121604 [09:25:05] (03PS5) 10Netbrain: Added support for execution to be done on client side. This to prevent max execution time error in php. [extensions/MassEditRegex] - 10https://gerrit.wikimedia.org/r/98094 [09:27:51] (03CR) 10Mxn: "Sure, I just meant that sans-serif fonts seem to be more human-readable than slab-serif/monospace fonts." [extensions/ConfirmEdit] - 10https://gerrit.wikimedia.org/r/121255 (owner: 10Nemo bis) [09:27:56] (03CR) 10Siebrand: [C: 031] "i18n/L10n reviewed." [extensions/Persona] - 10https://gerrit.wikimedia.org/r/112309 (owner: 10Donyu) [09:34:45] (03PS6) 10Netbrain: Added support for execution to be done on client side. This to prevent max execution time error in php. [extensions/MassEditRegex] - 10https://gerrit.wikimedia.org/r/98094 [09:39:34] (03CR) 10Raimond Spekking: [C: 032] Migrate to JSON i18n [extensions/ImageMap] - 10https://gerrit.wikimedia.org/r/121589 (owner: 10Siebrand) [09:39:36] (03Merged) 10jenkins-bot: Migrate to JSON i18n [extensions/ImageMap] - 10https://gerrit.wikimedia.org/r/121589 (owner: 10Siebrand) [09:40:11] (03CR) 10Raimond Spekking: [C: 032] Migrate to JSON i18n [extensions/InputBox] - 10https://gerrit.wikimedia.org/r/121590 (owner: 10Siebrand) [09:40:13] (03Merged) 10jenkins-bot: Migrate to JSON i18n [extensions/InputBox] - 10https://gerrit.wikimedia.org/r/121590 (owner: 10Siebrand) [09:40:42] (03CR) 10Raimond Spekking: [C: 032] Migrate to JSON i18n [extensions/Insider] - 10https://gerrit.wikimedia.org/r/121591 (owner: 10Siebrand) [09:40:44] (03Merged) 10jenkins-bot: Migrate to JSON i18n [extensions/Insider] - 10https://gerrit.wikimedia.org/r/121591 (owner: 10Siebrand) [09:41:12] (03CR) 10Raimond Spekking: [C: 032] Migrate to JSON i18n [extensions/intersection] - 10https://gerrit.wikimedia.org/r/121592 (owner: 10Siebrand) [09:41:14] (03Merged) 10jenkins-bot: Migrate to JSON i18n [extensions/intersection] - 10https://gerrit.wikimedia.org/r/121592 (owner: 10Siebrand) [09:42:14] (03CR) 10Raimond Spekking: [C: 032] Migrate to JSON i18n [extensions/LabeledSectionTransclusion] - 10https://gerrit.wikimedia.org/r/121593 (owner: 10Siebrand) [09:42:20] (03Merged) 10jenkins-bot: Migrate to JSON i18n [extensions/LabeledSectionTransclusion] - 10https://gerrit.wikimedia.org/r/121593 (owner: 10Siebrand) [09:42:51] (03CR) 10Raimond Spekking: [C: 032] Migrate to JSON i18n [extensions/LandingCheck] - 10https://gerrit.wikimedia.org/r/121594 (owner: 10Siebrand) [09:42:53] (03Merged) 10jenkins-bot: Migrate to JSON i18n [extensions/LandingCheck] - 10https://gerrit.wikimedia.org/r/121594 (owner: 10Siebrand) [09:43:26] (03CR) 10Raimond Spekking: [C: 032] Migrate to JSON i18n [extensions/LdapAuthentication] - 10https://gerrit.wikimedia.org/r/121595 (owner: 10Siebrand) [09:43:28] (03Merged) 10jenkins-bot: Migrate to JSON i18n [extensions/LdapAuthentication] - 10https://gerrit.wikimedia.org/r/121595 (owner: 10Siebrand) [09:43:47] (03CR) 10Raimond Spekking: [C: 032] Migrate to JSON i18n [extensions/Listings] - 10https://gerrit.wikimedia.org/r/121597 (owner: 10Siebrand) [09:43:49] (03Merged) 10jenkins-bot: Migrate to JSON i18n [extensions/Listings] - 10https://gerrit.wikimedia.org/r/121597 (owner: 10Siebrand) [09:44:27] (03CR) 10Raimond Spekking: [C: 032] Migrate to JSON i18n [extensions/LocalisationUpdate] - 10https://gerrit.wikimedia.org/r/121598 (owner: 10Siebrand) [09:44:29] (03Merged) 10jenkins-bot: Migrate to JSON i18n [extensions/LocalisationUpdate] - 10https://gerrit.wikimedia.org/r/121598 (owner: 10Siebrand) [09:44:48] (03CR) 10Raimond Spekking: [C: 032] Migrate to JSON i18n [extensions/MapSources] - 10https://gerrit.wikimedia.org/r/121599 (owner: 10Siebrand) [09:44:50] (03Merged) 10jenkins-bot: Migrate to JSON i18n [extensions/MapSources] - 10https://gerrit.wikimedia.org/r/121599 (owner: 10Siebrand) [09:54:53] (03PS1) 10Gilles: Gives extensions the ability to output inline head scripts [core] - 10https://gerrit.wikimedia.org/r/121606 [10:00:17] (03PS1) 10Prtksxna: Fix placement issue for smaller images [extensions/Popups] - 10https://gerrit.wikimedia.org/r/121607 [10:00:44] (03CR) 10Raimond Spekking: [C: 032] Migrate to JSON i18n [extensions/LiquidThreads] - 10https://gerrit.wikimedia.org/r/121596 (owner: 10Siebrand) [10:00:47] (03Merged) 10jenkins-bot: Migrate to JSON i18n [extensions/LiquidThreads] - 10https://gerrit.wikimedia.org/r/121596 (owner: 10Siebrand) [10:02:25] (03CR) 10Matthias Mullie: "The more I think about it, the more I'll agree to just ignore mal-fetched data altogether, instead of trying to work around them and displ" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/119304 (owner: 10Matthias Mullie) [10:03:44] (03CR) 10Raimond Spekking: [C: 032] Migrate to JSON i18n [extensions/GWToolset] - 10https://gerrit.wikimedia.org/r/121588 (owner: 10Siebrand) [10:03:49] (03Merged) 10jenkins-bot: Migrate to JSON i18n [extensions/GWToolset] - 10https://gerrit.wikimedia.org/r/121588 (owner: 10Siebrand) [10:04:01] (03PS1) 10Siebrand: Migrate to JSON i18n [extensions/MarkAsHelpful] - 10https://gerrit.wikimedia.org/r/121609 [10:04:04] (03CR) 10jenkins-bot: [V: 04-1] Migrate to JSON i18n [extensions/MarkAsHelpful] - 10https://gerrit.wikimedia.org/r/121609 (owner: 10Siebrand) [10:04:22] (03PS1) 10Siebrand: Migrate to JSON i18n [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/121610 [10:06:16] (03PS1) 10Siebrand: Migrate to JSON i18n [extensions/Math] - 10https://gerrit.wikimedia.org/r/121611 [10:06:24] (03PS1) 10Siebrand: Migrate to JSON i18n [extensions/MoodBar] - 10https://gerrit.wikimedia.org/r/121612 [10:06:47] (03PS1) 10Siebrand: Migrate to JSON i18n [extensions/MwEmbedSupport] - 10https://gerrit.wikimedia.org/r/121615 [10:06:51] (03PS1) 10Siebrand: Migrate to JSON i18n [extensions/MWSearch] - 10https://gerrit.wikimedia.org/r/121616 [10:06:55] (03PS1) 10Siebrand: Migrate to JSON i18n [extensions/NavigationTiming] - 10https://gerrit.wikimedia.org/r/121617 [10:06:59] (03PS1) 10Siebrand: Migrate to JSON i18n [extensions/NewUserMessage] - 10https://gerrit.wikimedia.org/r/121618 [10:07:04] (03PS1) 10Siebrand: Migrate to JSON i18n [extensions/Nostalgia] - 10https://gerrit.wikimedia.org/r/121619 [10:07:48] (03PS7) 10Nemo bis: Make captcha.py produce images in arbitrary language [extensions/ConfirmEdit] - 10https://gerrit.wikimedia.org/r/121255 [10:08:55] (03PS1) 10KartikMistry: Typo fixes in cxserver [services/cxserver] - 10https://gerrit.wikimedia.org/r/121620 [10:09:45] (03PS2) 10Gilles: Expose thumbnail file to extensions [core] - 10https://gerrit.wikimedia.org/r/121601 [10:11:18] (03CR) 10Matthias Mullie: [C: 032] "Tested:" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/107411 (owner: 10Legoktm) [10:11:33] (03CR) 10Matthias Mullie: [C: 04-2] API: Revamp action=flow [extensions/Flow] - 10https://gerrit.wikimedia.org/r/107411 (owner: 10Legoktm) [10:11:46] (03PS20) 10Matthias Mullie: API: Revamp action=flow [extensions/Flow] - 10https://gerrit.wikimedia.org/r/107411 (owner: 10Legoktm) [10:12:33] (03CR) 10Matthias Mullie: [C: 032] "Forgot to submit new patch that removes the old API ;) Merging now!" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/107411 (owner: 10Legoktm) [10:12:48] (03Merged) 10jenkins-bot: API: Revamp action=flow [extensions/Flow] - 10https://gerrit.wikimedia.org/r/107411 (owner: 10Legoktm) [10:15:34] (03CR) 10Siebrand: [C: 04-1] "resources/#ext.popups.core.js# doesn't look like a correct filename." [extensions/Popups] - 10https://gerrit.wikimedia.org/r/121607 (owner: 10Prtksxna) [10:16:51] (03PS2) 10Prtksxna: Fix placement issue for smaller images [extensions/Popups] - 10https://gerrit.wikimedia.org/r/121607 [10:18:45] (03CR) 10Prtksxna: "Siebrand: Oops, that was an emacs backup file that I committed by mistake. Thanks for pointing it out." [extensions/Popups] - 10https://gerrit.wikimedia.org/r/121607 (owner: 10Prtksxna) [10:22:23] (03PS11) 1001tonythomas: Adding a JS Class to inputBox to grey out Submit button. [extensions/InputBox] - 10https://gerrit.wikimedia.org/r/120487 [10:28:47] (03CR) 10Matthias Mullie: [C: 032] wfDebugLog calls must use the Flow log group [extensions/Flow] - 10https://gerrit.wikimedia.org/r/121137 (owner: 10EBernhardson) [10:28:59] (03Merged) 10jenkins-bot: wfDebugLog calls must use the Flow log group [extensions/Flow] - 10https://gerrit.wikimedia.org/r/121137 (owner: 10EBernhardson) [10:31:30] (03PS1) 10Siebrand: Make jslint non-voting for MarkAsHelpful [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/121623 [10:32:05] (03CR) 10Siebrand: "Jenkins not passing is a misconfiguration. I've submitted https://gerrit.wikimedia.org/r/#/c/121623/ for this." [extensions/MarkAsHelpful] - 10https://gerrit.wikimedia.org/r/121609 (owner: 10Siebrand) [10:32:43] (03CR) 10Rillke: [C: 031] "No clue about the PHP-part, though." [extensions/InputBox] - 10https://gerrit.wikimedia.org/r/120487 (owner: 1001tonythomas) [10:35:47] (03CR) 10Raimond Spekking: [C: 032] Migrate to JSON i18n [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/121610 (owner: 10Siebrand) [10:36:01] (03Merged) 10jenkins-bot: Migrate to JSON i18n [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/121610 (owner: 10Siebrand) [10:36:03] (03CR) 10Raimond Spekking: [C: 032] Migrate to JSON i18n [extensions/MoodBar] - 10https://gerrit.wikimedia.org/r/121612 (owner: 10Siebrand) [10:36:06] (03Merged) 10jenkins-bot: Migrate to JSON i18n [extensions/MoodBar] - 10https://gerrit.wikimedia.org/r/121612 (owner: 10Siebrand) [10:37:00] (03CR) 10Raimond Spekking: [C: 032] Migrate to JSON i18n [extensions/Math] - 10https://gerrit.wikimedia.org/r/121611 (owner: 10Siebrand) [10:37:42] (03PS1) 10Siebrand: Add extension checks for Nostalgia [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/121625 [10:38:09] (03Merged) 10jenkins-bot: Migrate to JSON i18n [extensions/Math] - 10https://gerrit.wikimedia.org/r/121611 (owner: 10Siebrand) [10:39:15] (03PS1) 10Siebrand: Add Jenkins jobs for Nostalgia extension repo [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/121626 [10:39:23] (03CR) 10Raimond Spekking: [C: 032] Migrate to JSON i18n [extensions/MwEmbedSupport] - 10https://gerrit.wikimedia.org/r/121615 (owner: 10Siebrand) [10:39:26] (03Merged) 10jenkins-bot: Migrate to JSON i18n [extensions/MwEmbedSupport] - 10https://gerrit.wikimedia.org/r/121615 (owner: 10Siebrand) [10:39:44] (03CR) 10Raimond Spekking: [C: 032] Migrate to JSON i18n [extensions/MWSearch] - 10https://gerrit.wikimedia.org/r/121616 (owner: 10Siebrand) [10:39:46] (03Merged) 10jenkins-bot: Migrate to JSON i18n [extensions/MWSearch] - 10https://gerrit.wikimedia.org/r/121616 (owner: 10Siebrand) [10:39:57] (03CR) 10Raimond Spekking: [C: 032] Migrate to JSON i18n [extensions/NavigationTiming] - 10https://gerrit.wikimedia.org/r/121617 (owner: 10Siebrand) [10:39:59] (03Merged) 10jenkins-bot: Migrate to JSON i18n [extensions/NavigationTiming] - 10https://gerrit.wikimedia.org/r/121617 (owner: 10Siebrand) [10:40:14] (03CR) 10Raimond Spekking: [C: 032] Migrate to JSON i18n [extensions/NewUserMessage] - 10https://gerrit.wikimedia.org/r/121618 (owner: 10Siebrand) [10:40:16] (03Merged) 10jenkins-bot: Migrate to JSON i18n [extensions/NewUserMessage] - 10https://gerrit.wikimedia.org/r/121618 (owner: 10Siebrand) [10:40:21] (03PS2) 10Faidon Liambotis: Set ThrottledError's response code to 429 [core] - 10https://gerrit.wikimedia.org/r/120765 [10:40:23] (03PS1) 10Faidon Liambotis: HttpStatus: add RFC 6585 status codes [core] - 10https://gerrit.wikimedia.org/r/121627 [10:40:25] (03CR) 10Raimond Spekking: [C: 032] Migrate to JSON i18n [extensions/Nostalgia] - 10https://gerrit.wikimedia.org/r/121619 (owner: 10Siebrand) [10:41:34] (03CR) 10Raimond Spekking: [C: 032] Migrate to JSON i18n [extensions/MarkAsHelpful] - 10https://gerrit.wikimedia.org/r/121609 (owner: 10Siebrand) [10:42:10] this grrrit-wm is such a hardworking bot [10:42:11] (03Merged) 10jenkins-bot: Migrate to JSON i18n [extensions/MarkAsHelpful] - 10https://gerrit.wikimedia.org/r/121609 (owner: 10Siebrand) [10:42:41] (03CR) 10Siebrand: [V: 032] "Override Jenkins." [extensions/Nostalgia] - 10https://gerrit.wikimedia.org/r/121619 (owner: 10Siebrand) [10:45:32] (03CR) 10Gilles: "Needed by: https://gerrit.wikimedia.org/r/121629" [core] - 10https://gerrit.wikimedia.org/r/121606 (owner: 10Gilles) [10:53:20] (03PS1) 10TheDJ: Ask for confirmation when saving document with errors [extensions/CodeEditor] - 10https://gerrit.wikimedia.org/r/121632 [10:53:23] (03CR) 10jenkins-bot: [V: 04-1] Ask for confirmation when saving document with errors [extensions/CodeEditor] - 10https://gerrit.wikimedia.org/r/121632 (owner: 10TheDJ) [10:57:55] (03PS1) 10Siebrand: Migrate to JSON i18n [extensions/OAuth] - 10https://gerrit.wikimedia.org/r/121633 [10:58:01] (03CR) 10jenkins-bot: [V: 04-1] Migrate to JSON i18n [extensions/OAuth] - 10https://gerrit.wikimedia.org/r/121633 (owner: 10Siebrand) [10:59:06] (03CR) 10Siebrand: "Jenkins failure is unrelated to the patch set. I'll report a bug and submit Jenkins config updates." [extensions/OAuth] - 10https://gerrit.wikimedia.org/r/121633 (owner: 10Siebrand) [11:00:44] (03PS1) 10Hashar: Tie debian-glue jobs to label hasJenkinsDebianGlue [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/121634 [11:01:10] (03CR) 10Hashar: [C: 032] Tie debian-glue jobs to label hasJenkinsDebianGlue [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/121634 (owner: 10Hashar) [11:02:07] (03Merged) 10jenkins-bot: Tie debian-glue jobs to label hasJenkinsDebianGlue [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/121634 (owner: 10Hashar) [11:03:01] (03PS1) 10Siebrand: Make jslint non-voting for OAuth [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/121636 [11:03:06] (03PS2) 10TheDJ: Ask for confirmation when saving document with errors [extensions/CodeEditor] - 10https://gerrit.wikimedia.org/r/121632 [11:04:15] (03CR) 10Siebrand: "I reported bug 63221 and submitted a patch set to fix. Hashar indicated he won't be able to review today." [extensions/OAuth] - 10https://gerrit.wikimedia.org/r/121633 (owner: 10Siebrand) [11:06:20] (03PS1) 10Siebrand: Migrate to JSON i18n [extensions/OAI] - 10https://gerrit.wikimedia.org/r/121637 [11:07:44] (03PS1) 10Siebrand: Migrate to JSON i18n [extensions/OATHAuth] - 10https://gerrit.wikimedia.org/r/121638 [11:08:57] (03PS1) 10Siebrand: Migrate to JSON i18n [extensions/OpenSearchXml] - 10https://gerrit.wikimedia.org/r/121639 [11:10:57] (03PS1) 10Siebrand: Migrate to JSON i18n [extensions/PagedTiffHandler] - 10https://gerrit.wikimedia.org/r/121640 [11:12:34] (03PS1) 10Siebrand: Migrate to JSON i18n [extensions/PageImages] - 10https://gerrit.wikimedia.org/r/121641 [11:14:38] (03PS1) 10Siebrand: Migrate to JSON i18n [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/121643 [11:16:05] (03PS1) 10Siebrand: Migrate to JSON i18n [extensions/ParserFunctions] - 10https://gerrit.wikimedia.org/r/121644 [11:16:25] (03CR) 10Matthias Mullie: [C: 031] "LGTM. 118719 has already been merged too, so this one looks good to go." (031 comment) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/116861 (owner: 10Bsitu) [11:18:14] (03PS3) 10TheDJ: [Do not merge] Support warning for unsaved changes [extensions/CodeEditor] - 10https://gerrit.wikimedia.org/r/121559 [11:19:45] (03PS1) 10Siebrand: Migrate to JSON i18n [extensions/PdfHandler] - 10https://gerrit.wikimedia.org/r/121647 [11:22:30] (03CR) 10Netbrain: "Patch set 4 was merged incorrectly. needed to revert and reapply patches on patchset 3, and then patch 5 i forgot to rebase again." [extensions/MassEditRegex] - 10https://gerrit.wikimedia.org/r/98094 (owner: 10Netbrain) [11:24:17] (03CR) 10Santhosh: [C: 032] Typo fixes in cxserver [services/cxserver] - 10https://gerrit.wikimedia.org/r/121620 (owner: 10KartikMistry) [11:24:19] (03Merged) 10jenkins-bot: Typo fixes in cxserver [services/cxserver] - 10https://gerrit.wikimedia.org/r/121620 (owner: 10KartikMistry) [11:27:36] (03CR) 10Thiemo Mättig (WMDE): [C: 031] "There was no way to know the language of a message? Huh? Totally makes sense to have this." (032 comments) [core] - 10https://gerrit.wikimedia.org/r/121118 (owner: 10Aude) [11:29:00] (03CR) 10Matthias Mullie: [C: 031] "LGTM, merge when dependencies have been merged" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/116874 (owner: 10Bsitu) [11:31:29] (03PS1) 10Siebrand: Migrate to JSON i18n [extensions/OpenStackManager] - 10https://gerrit.wikimedia.org/r/121648 [11:36:08] (03PS3) 10TheDJ: Edit warning should get value from editors [core] - 10https://gerrit.wikimedia.org/r/121558 [11:39:49] (03PS1) 10Siebrand: Indent PHP file with tabs [extensions/PerPageLicense] - 10https://gerrit.wikimedia.org/r/121651 [11:40:03] (03CR) 10Siebrand: [C: 032 V: 032] Indent PHP file with tabs [extensions/PerPageLicense] - 10https://gerrit.wikimedia.org/r/121651 (owner: 10Siebrand) [11:46:47] (03CR) 10Nemo bis: "On performance tuning not being necessary for dev instances, a conversation yesterday." [vagrant] - 10https://gerrit.wikimedia.org/r/119216 (owner: 10Nemo bis) [11:47:29] (03PS1) 10Siebrand: Some more i18n file tweaks. [extensions/PerPageLicense] - 10https://gerrit.wikimedia.org/r/121652 [11:47:52] (03CR) 10Siebrand: [C: 032 V: 032] Some more i18n file tweaks. [extensions/PerPageLicense] - 10https://gerrit.wikimedia.org/r/121652 (owner: 10Siebrand) [11:48:50] (03CR) 10Thiemo Mättig (WMDE): [C: 031] "I was thinking about other ways to do this. I would love to add a second __constructor( $language, $key, $parameters ). But this is not po" (032 comments) [core] - 10https://gerrit.wikimedia.org/r/121113 (owner: 10Aude) [11:55:05] (03PS1) 10Siebrand: Pretty hard to spot a typo in a filename [extensions/PerPageLicense] - 10https://gerrit.wikimedia.org/r/121653 [11:55:31] (03CR) 10Siebrand: [C: 032 V: 032] "Thanks Nikerabbit!" [extensions/PerPageLicense] - 10https://gerrit.wikimedia.org/r/121653 (owner: 10Siebrand) [12:05:26] (03CR) 10Matthias Mullie: [C: 031] "Some really minor comments; code looks good" (035 comments) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/117099 (owner: 10Bsitu) [12:11:55] (03CR) 10Siebrand: [C: 04-1] "i18n/L10n reviewed." (032 comments) [extensions/CodeEditor] - 10https://gerrit.wikimedia.org/r/121632 (owner: 10TheDJ) [12:39:36] (03CR) 10Nemo bis: [C: 04-1] "Hmm:" [extensions/ConfirmEdit] - 10https://gerrit.wikimedia.org/r/121255 (owner: 10Nemo bis) [12:44:39] (03CR) 10Matthias Mullie: [C: 04-1] Drop table: flow_header_revision (031 comment) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/117115 (owner: 10Bsitu) [13:08:11] (03PS1) 10Addshore: Remove random unneeded tabs and spaces [qrpedia] - 10https://gerrit.wikimedia.org/r/121660 [13:19:11] (03PS1) 10Addshore: General fixes and cleanup [qrpedia] - 10https://gerrit.wikimedia.org/r/121661 [13:24:12] (03CR) 10Aude: [C: 031] General fixes and cleanup [qrpedia] - 10https://gerrit.wikimedia.org/r/121661 (owner: 10Addshore) [13:24:31] omgwould merge if i could [13:24:35] gah [13:24:49] omg, the code :) [13:25:05] looks like the scholarships app when i got it [13:26:30] (03CR) 10Aude: [C: 031] Remove random unneeded tabs and spaces [qrpedia] - 10https://gerrit.wikimedia.org/r/121660 (owner: 10Addshore) [13:31:06] aude: ikr :P [13:46:32] (03CR) 10Anomie: [C: 031] "Code looks ok, haven't tested. A few style nitpicks." (033 comments) [core] - 10https://gerrit.wikimedia.org/r/121548 (owner: 10BryanDavis) [13:52:05] (03CR) 10Anomie: [C: 031] "Seems ok, unless there's an attack that could be done by a local user making MediaWiki generate duplicate IDs. Haven't tested." [core] - 10https://gerrit.wikimedia.org/r/121549 (owner: 10BryanDavis) [13:57:43] (03Abandoned) 10Umherirrender: Use TablePager on Special:ProtectedTitles [core] - 10https://gerrit.wikimedia.org/r/98252 (owner: 10Umherirrender) [14:08:09] (03CR) 10TheDJ: Ask for confirmation when saving document with errors (031 comment) [extensions/CodeEditor] - 10https://gerrit.wikimedia.org/r/121632 (owner: 10TheDJ) [14:13:17] (03CR) 10Nemo bis: "So, I'm testing the following dictionaries: http://p.defau.lt/?CrnKbet1gOe3rz2EIKg9VQ" [extensions/ConfirmEdit] - 10https://gerrit.wikimedia.org/r/121255 (owner: 10Nemo bis) [14:19:28] (03Abandoned) 10Hashar: Make jslint non-voting for MarkAsHelpful [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/121623 (owner: 10Siebrand) [14:32:33] (03CR) 10Siebrand: Ask for confirmation when saving document with errors (031 comment) [extensions/CodeEditor] - 10https://gerrit.wikimedia.org/r/121632 (owner: 10TheDJ) [14:41:31] <^d> Nikerabbit, manybubbles: I see elastic translation memory change got merged :) [14:43:06] (03PS19) 10Daniel Kinzler: Introducing TitleValue [core] - 10https://gerrit.wikimedia.org/r/106517 [14:43:37] (03CR) 10Daniel Kinzler: Introducing TitleValue (0311 comments) [core] - 10https://gerrit.wikimedia.org/r/106517 (owner: 10Daniel Kinzler) [14:44:08] (03CR) 10jenkins-bot: [V: 04-1] Introducing TitleValue [core] - 10https://gerrit.wikimedia.org/r/106517 (owner: 10Daniel Kinzler) [14:52:39] (03Abandoned) 10Hashar: Survey should pass Jslint [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/121575 (owner: 10AalekhN) [14:53:05] (03CR) 10Hashar: "Feel free to reopen this change whenever Survey is passing jshint :]" [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/121575 (owner: 10AalekhN) [14:55:45] (03CR) 10Hashar: "Thanks =)" [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/121529 (owner: 10Krinkle) [14:57:58] (03Abandoned) 10Hashar: Make jslint non-voting for OAuth [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/121636 (owner: 10Siebrand) [15:00:37] (03Abandoned) 10Hashar: Confirm Edit now passes jslint, so make it voting [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/121573 (owner: 10AalekhN) [15:17:25] (03PS20) 10Daniel Kinzler: Introducing TitleValue [core] - 10https://gerrit.wikimedia.org/r/106517 [15:18:25] (03CR) 10Daniel Kinzler: "PS20 is a rebase, with manual fixes for integrating I9dbb566385b." [core] - 10https://gerrit.wikimedia.org/r/106517 (owner: 10Daniel Kinzler) [15:20:43] (03CR) 10jenkins-bot: [V: 04-1] Introducing TitleValue [core] - 10https://gerrit.wikimedia.org/r/106517 (owner: 10Daniel Kinzler) [15:21:12] (03CR) 10Siebrand: "Hmm, no Jenkins jobs." [extensions/Elastica] - 10https://gerrit.wikimedia.org/r/121440 (owner: 10Chad) [15:22:40] (03CR) 10Chad: "Nope. We should probably do linting at the very least." [extensions/Elastica] - 10https://gerrit.wikimedia.org/r/121440 (owner: 10Chad) [15:23:37] (03CR) 10Siebrand: "I just reported https://bugzilla.wikimedia.org/63231" [extensions/Elastica] - 10https://gerrit.wikimedia.org/r/121440 (owner: 10Chad) [15:27:11] (03PS2) 10BryanDavis: Delete UIDGenerator cache files after unit tests [core] - 10https://gerrit.wikimedia.org/r/121548 [15:27:57] (03CR) 10Daniel Kinzler: "These test failures seem to be unrelated: i can reproduce them locally on master." [core] - 10https://gerrit.wikimedia.org/r/106517 (owner: 10Daniel Kinzler) [15:28:48] (03CR) 10BryanDavis: "Fixed style issues pointed out by Brad." (033 comments) [core] - 10https://gerrit.wikimedia.org/r/121548 (owner: 10BryanDavis) [15:38:02] (03CR) 10Daniel Kinzler: "hm, i can reproduce *some* of them on master..." [core] - 10https://gerrit.wikimedia.org/r/106517 (owner: 10Daniel Kinzler) [15:39:28] (03CR) 10Bartosz Dziewoński: "I suppose "the cut", whatever it was, has happened already?" [extensions/BetaFeatures] - 10https://gerrit.wikimedia.org/r/119553 (owner: 10Bartosz Dziewoński) [15:42:40] (03PS6) 10Bartosz Dziewoński: mediawiki.special: Remove HTML backwards-compatibility styles [core] - 10https://gerrit.wikimedia.org/r/116790 [15:43:56] (03PS3) 10Jforrester: Sanitized directory structure [extensions/BetaFeatures] - 10https://gerrit.wikimedia.org/r/119553 (owner: 10Bartosz Dziewoński) [15:44:26] (03CR) 10Legoktm: [C: 032] Only use ->parse on i18n messages if required [extensions/Thanks] - 10https://gerrit.wikimedia.org/r/121541 (owner: 10EBernhardson) [15:44:46] (03Merged) 10jenkins-bot: Only use ->parse on i18n messages if required [extensions/Thanks] - 10https://gerrit.wikimedia.org/r/121541 (owner: 10EBernhardson) [15:45:05] (03CR) 10Jforrester: [C: 032] "The cut happens every Thursday at ~ 17:00 UTC." [extensions/BetaFeatures] - 10https://gerrit.wikimedia.org/r/119553 (owner: 10Bartosz Dziewoński) [15:45:13] (03Merged) 10jenkins-bot: Sanitized directory structure [extensions/BetaFeatures] - 10https://gerrit.wikimedia.org/r/119553 (owner: 10Bartosz Dziewoński) [15:50:29] (03CR) 10Chad: [C: 032] "All looking good to me now that the namespace issue is sorted. Let's get this merged so we can test on beta." [extensions/GeoData] - 10https://gerrit.wikimedia.org/r/115413 (owner: 10MaxSem) [15:50:37] (03Merged) 10jenkins-bot: Elasticsearch support [extensions/GeoData] - 10https://gerrit.wikimedia.org/r/115413 (owner: 10MaxSem) [15:50:40] (03PS1) 10Smuggli: Implemented changes for getting into translatewiki [extensions/BlueSpiceFoundation] - 10https://gerrit.wikimedia.org/r/121680 [15:53:18] (03PS2) 10Smuggli: Implemented changes for getting into translatewiki [extensions/BlueSpiceFoundation] - 10https://gerrit.wikimedia.org/r/121680 [15:54:22] (03CR) 10Bartosz Dziewoński: "Steven, I've really thought about what to reply to you here." [core] - 10https://gerrit.wikimedia.org/r/117438 (owner: 10Bartosz Dziewoński) [16:02:53] (03PS3) 10Bartosz Dziewoński: Check normalization rules of usernames during signup via AJAX [core] - 10https://gerrit.wikimedia.org/r/117438 [16:06:14] (03PS4) 10Bartosz Dziewoński: Check normalization rules of usernames during signup via AJAX [core] - 10https://gerrit.wikimedia.org/r/117438 [16:07:20] (03CR) 10Bartosz Dziewoński: "Rebased. Constructive review would be welcome; I've been told that the i18n needs improvement, but I'm not sure exactly what should be don" [core] - 10https://gerrit.wikimedia.org/r/117438 (owner: 10Bartosz Dziewoński) [16:10:22] (03PS1) 10Smuggli: Implemented changes for getting into translatewiki [extensions/BlueSpiceFoundation] - 10https://gerrit.wikimedia.org/r/121683 [16:14:54] (03PS21) 10Daniel Kinzler: Introducing TitleValue [core] - 10https://gerrit.wikimedia.org/r/106517 [16:18:31] (03CR) 10jenkins-bot: [V: 04-1] Introducing TitleValue [core] - 10https://gerrit.wikimedia.org/r/106517 (owner: 10Daniel Kinzler) [16:18:35] (03PS1) 10Smuggli: Implemented changes for getting into translatewiki [extensions/BlueSpiceFoundation] - 10https://gerrit.wikimedia.org/r/121684 [16:20:16] (03CR) 10Daniel Kinzler: "Uh, so, the tests pass, but jenkins fails anyway, because... what?!" [core] - 10https://gerrit.wikimedia.org/r/106517 (owner: 10Daniel Kinzler) [16:21:48] (03PS1) 10Smuggli: Implemented changes for getting into translatewiki [extensions/BlueSpiceFoundation] - 10https://gerrit.wikimedia.org/r/121685 [16:25:35] (03PS1) 10Smuggli: Implemented changes for getting into translatewiki [extensions/BlueSpiceFoundation] - 10https://gerrit.wikimedia.org/r/121686 [16:30:29] (03PS1) 10Smuggli: Implemented changes for getting into translatewiki [extensions/BlueSpiceFoundation] - 10https://gerrit.wikimedia.org/r/121687 [16:31:32] (03PS1) 10Jforrester: Make jshint voting for LiquidThreads [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/121688 [16:33:13] (03PS2) 10Smuggli: Implemented changes for getting into translatewiki [extensions/BlueSpiceFoundation] - 10https://gerrit.wikimedia.org/r/121683 [16:34:33] Did LQT really get so pretty :O [16:39:41] (03CR) 10Hashar: [C: 032] Make jshint voting for LiquidThreads [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/121688 (owner: 10Jforrester) [16:39:46] (03Merged) 10jenkins-bot: Make jshint voting for LiquidThreads [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/121688 (owner: 10Jforrester) [16:40:04] Nemo_bis: ? [16:41:45] to pass jshint [16:41:57] Nemo_bis: Yeah, a volunteer made it work. Yay. [16:42:47] ahh, different definition of pretty :) [16:43:33] oh, adi.iiita [16:48:08] ^d: yup... I still need to implement translation search [16:50:53] (03CR) 10Catrope: [C: 032] Update OOjs UI to v0.1.0-pre (23fb1b6144) [core] - 10https://gerrit.wikimedia.org/r/121537 (owner: 10Jforrester) [16:54:07] (03Merged) 10jenkins-bot: Update OOjs UI to v0.1.0-pre (23fb1b6144) [core] - 10https://gerrit.wikimedia.org/r/121537 (owner: 10Jforrester) [16:57:33] (03Abandoned) 10Bartosz Dziewoński: Add a dropdown list for the tag selector [core] - 10https://gerrit.wikimedia.org/r/80781 (owner: 10Bartosz Dziewoński) [16:59:59] The IRC discussion about the Project management tools review ( https://www.mediawiki.org/wiki/Project_management_tools/Review ) is about to start in #wikimedia-office . Please join if you'd like to know more and share your thoughts. [17:01:08] (03CR) 10Daniel Kinzler: "looks fine now, but as Nikerabbit said, make sure it works right with ULS." [core] - 10https://gerrit.wikimedia.org/r/120475 (owner: 10Stepzhou) [17:04:28] (03CR) 10Aude: Add getLanguage method to Message (032 comments) [core] - 10https://gerrit.wikimedia.org/r/121118 (owner: 10Aude) [17:04:37] (03CR) 10Aude: Allow to optionally set language in Message constructor (032 comments) [core] - 10https://gerrit.wikimedia.org/r/121113 (owner: 10Aude) [17:06:39] (03CR) 10Daniel Kinzler: [C: 031] Error Msg for missing db username & password when installing [core] - 10https://gerrit.wikimedia.org/r/118798 (owner: 10Pubudu538) [17:10:07] (03PS3) 10Aude: Add getLanguage method to Message [core] - 10https://gerrit.wikimedia.org/r/121118 [17:10:09] (03PS3) 10Aude: Allow to optionally set language in Message constructor [core] - 10https://gerrit.wikimedia.org/r/121113 [17:12:21] (03CR) 10Daniel Kinzler: [C: 031] Allow to optionally set language in Message constructor [core] - 10https://gerrit.wikimedia.org/r/121113 (owner: 10Aude) [17:13:36] (03CR) 10Raimond Spekking: [C: 032] Migrate to JSON i18n [extensions/OpenStackManager] - 10https://gerrit.wikimedia.org/r/121648 (owner: 10Siebrand) [17:13:44] (03Merged) 10jenkins-bot: Migrate to JSON i18n [extensions/OpenStackManager] - 10https://gerrit.wikimedia.org/r/121648 (owner: 10Siebrand) [17:14:11] (03PS1) 10UltrasonicNXT: Fix sidebar away bug [extensions/MediaWikiChat] - 10https://gerrit.wikimedia.org/r/121694 [17:14:29] (03CR) 10UltrasonicNXT: [C: 032 V: 032] Fix sidebar away bug [extensions/MediaWikiChat] - 10https://gerrit.wikimedia.org/r/121694 (owner: 10UltrasonicNXT) [17:15:49] (03CR) 10Raimond Spekking: [C: 032] Migrate to JSON i18n [extensions/PdfHandler] - 10https://gerrit.wikimedia.org/r/121647 (owner: 10Siebrand) [17:15:55] (03Merged) 10jenkins-bot: Migrate to JSON i18n [extensions/PdfHandler] - 10https://gerrit.wikimedia.org/r/121647 (owner: 10Siebrand) [17:16:57] (03CR) 10Raimond Spekking: [C: 032] Migrate to JSON i18n [extensions/ParserFunctions] - 10https://gerrit.wikimedia.org/r/121644 (owner: 10Siebrand) [17:17:05] (03Merged) 10jenkins-bot: Migrate to JSON i18n [extensions/ParserFunctions] - 10https://gerrit.wikimedia.org/r/121644 (owner: 10Siebrand) [17:17:19] (03CR) 10Raimond Spekking: [C: 032] Migrate to JSON i18n [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/121643 (owner: 10Siebrand) [17:17:30] (03Merged) 10jenkins-bot: Migrate to JSON i18n [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/121643 (owner: 10Siebrand) [17:17:42] (03CR) 10Raimond Spekking: [C: 032] Migrate to JSON i18n [extensions/PageImages] - 10https://gerrit.wikimedia.org/r/121641 (owner: 10Siebrand) [17:17:45] (03Merged) 10jenkins-bot: Migrate to JSON i18n [extensions/PageImages] - 10https://gerrit.wikimedia.org/r/121641 (owner: 10Siebrand) [17:17:58] (03CR) 10Raimond Spekking: [C: 032] Migrate to JSON i18n [extensions/PagedTiffHandler] - 10https://gerrit.wikimedia.org/r/121640 (owner: 10Siebrand) [17:18:06] (03Merged) 10jenkins-bot: Migrate to JSON i18n [extensions/PagedTiffHandler] - 10https://gerrit.wikimedia.org/r/121640 (owner: 10Siebrand) [17:18:20] (03CR) 10Raimond Spekking: [C: 032] Migrate to JSON i18n [extensions/OpenSearchXml] - 10https://gerrit.wikimedia.org/r/121639 (owner: 10Siebrand) [17:18:25] (03Merged) 10jenkins-bot: Migrate to JSON i18n [extensions/OpenSearchXml] - 10https://gerrit.wikimedia.org/r/121639 (owner: 10Siebrand) [17:18:38] (03CR) 10Raimond Spekking: [C: 032] Migrate to JSON i18n [extensions/OATHAuth] - 10https://gerrit.wikimedia.org/r/121638 (owner: 10Siebrand) [17:18:43] (03Merged) 10jenkins-bot: Migrate to JSON i18n [extensions/OATHAuth] - 10https://gerrit.wikimedia.org/r/121638 (owner: 10Siebrand) [17:21:19] (03CR) 10Raimond Spekking: [C: 032] Migrate to JSON i18n [extensions/OAuth] - 10https://gerrit.wikimedia.org/r/121633 (owner: 10Siebrand) [17:21:29] (03CR) 10jenkins-bot: [V: 04-1] Migrate to JSON i18n [extensions/OAuth] - 10https://gerrit.wikimedia.org/r/121633 (owner: 10Siebrand) [17:21:47] (03CR) 10Raimond Spekking: [C: 032] Migrate to JSON i18n [extensions/OAI] - 10https://gerrit.wikimedia.org/r/121637 (owner: 10Siebrand) [17:21:50] (03Merged) 10jenkins-bot: Migrate to JSON i18n [extensions/OAI] - 10https://gerrit.wikimedia.org/r/121637 (owner: 10Siebrand) [17:24:33] gi11es: Mind if I CC you to - https://bugzilla.wikimedia.org/63156 - was just about to mention you [17:27:23] (03CR) 10Kaldari: Story 1732: Make licensing customizable on mobile interfaces (031 comment) [extensions/WikimediaMessages] - 10https://gerrit.wikimedia.org/r/121106 (owner: 10Kaldari) [17:27:54] (03CR) 10JGonera: [C: 032] Using more UI agnostic language in licensing notice [extensions/WikimediaMessages] - 10https://gerrit.wikimedia.org/r/120728 (owner: 10Kaldari) [17:27:59] (03Merged) 10jenkins-bot: Using more UI agnostic language in licensing notice [extensions/WikimediaMessages] - 10https://gerrit.wikimedia.org/r/120728 (owner: 10Kaldari) [17:30:48] (03PS1) 10Raimond Spekking: Add a dummy .jshintrc [extensions/OAuth] - 10https://gerrit.wikimedia.org/r/121696 [17:31:24] (03CR) 10Nikerabbit: "I've cherry picked this on translatewiki.net about 12 hours ago, but apart from changed line number, the notices are still the same." [core] - 10https://gerrit.wikimedia.org/r/121402 (owner: 10Anomie) [17:32:04] (03PS2) 10Raimond Spekking: Add a dummy .jshintrc [extensions/OAuth] - 10https://gerrit.wikimedia.org/r/121696 [17:33:34] prtksxna: sure, go ahead [17:34:04] gi11es: Done! Do see - https://bugzilla.wikimedia.org/show_bug.cgi?id=63156#c3 [17:40:00] (03CR) 10CSteipp: "Bug 62623. We're trying to get that fixed soon." [core] - 10https://gerrit.wikimedia.org/r/106517 (owner: 10Daniel Kinzler) [17:41:54] (03CR) 10Kaldari: Story 1732: Make licensing customizable on mobile interfaces (031 comment) [extensions/WikimediaMessages] - 10https://gerrit.wikimedia.org/r/121106 (owner: 10Kaldari) [17:44:45] (03PS1) 10CSteipp: Disable gc during tests [integration/jenkins] - 10https://gerrit.wikimedia.org/r/121697 [17:45:36] csteipp: Mh... isn't that makind the tests somewhat divergent from the "real world" [17:46:51] shouldn't make a huge difference, iirc with gc disabled you still get regular ref counting and object destruction, you just lose cycle collection? [17:47:36] mh, I've never really tried that or looked at that [17:47:38] hoo: Somewhat. Yeah, what ebernhardson said :) (If I understand it entirely, which I'm not entirely sure I do) [17:47:51] Never had the need to do that [17:49:21] csteipp: mh, ok... but this is just a workaround for a PHP 5.3 problem, right? [17:49:56] 5.6 time? :> [17:50:28] addshore: :P ... I have a server still running PHP 5.3 [17:50:36] CentOs... really need to kick that box [17:50:48] * addshore likes some of the changes coming in 5.6 [17:51:20] (03CR) 10Hoo man: [C: 04-1] "You should add some comment telling that this should be removed once we're on PHP 5.4 (or newer), if I get this right" [integration/jenkins] - 10https://gerrit.wikimedia.org/r/121697 (owner: 10CSteipp) [17:52:35] hoo: I look forward to being able to do this MyClass::someMethod(...$args); [17:52:49] csteipp: Oh, btw... do you know anything about the arbcom private wikis? [17:52:56] I mean their SSL config. [17:53:34] Right now their wgServer is set to https://arbcom.*.wikipedia.org/ which doesn't ahve a valid cert. [17:54:03] eg. [17:54:04] https://arbcom.nl.wikipedia.org/wiki/Hoofdpagina [17:54:12] (03CR) 10Gilles: "The same issue happens on line 161" [extensions/Popups] - 10https://gerrit.wikimedia.org/r/121607 (owner: 10Prtksxna) [17:54:23] addshore: i look forward to function( int $foo ) : string ... oh wait we probably arn't getting that :P [17:54:41] :P [17:56:54] * hoo gives ebernhardson some C [17:56:56] * hoo runs [17:57:02] ping prtksxna [17:57:12] ahh, my first programming language. I have many fond memories of C :) [17:57:32] but these days, it would have to be C++ :) [17:58:08] C++ is quite complex and I never really found the time to get some real world experience in it :/ [17:59:41] to quote tstarling, "C++ almost doesn't suck these days" [17:59:47] you should know how much praise that is coming from him :) [17:59:59] MaxSem: pong [18:00:15] prtksxna, I'm confused about that bug [18:00:54] I see a proper image being returned but not displayed at all, both in FF and Chrome [18:01:06] MaxSem: That is 63207 :( [18:01:29] MaxSem: The other bug is that the first relevant image is not showing up, which is the one that I was asking you about [18:01:37] ebernhardson: :P I should laze off a bit more some day and do some real world stuff in C++... like some open source thing... [18:01:54] * hoo needs more time [18:02:11] prtksxna, well, I see the proper image ATM [18:03:32] MaxSem: On the page that Jared pointed out? [18:03:38] yes [18:04:09] the API returns https://upload.wikimedia.org/wikipedia/en/thumb/5/5b/Paramount_Pictures_logo_%282013%29.jpg/300px-Paramount_Pictures_logo_%282013%29.jpg [18:05:06] MaxSem: The last time I tested it was returning https://en.wikipedia.org/wiki/File:Blue_mountain_Paramount_Television_1975.jpg [18:05:11] MaxSem: Is it fuzzy? [18:05:17] no [18:05:25] /o\ [18:05:30] the page was edited recently [18:06:17] https://en.wikipedia.org/w/index.php?title=Paramount_Television&diff=601654507&oldid=601436055 [18:06:24] (03PS1) 10Bartosz Dziewoński: jquery.suggestions: Hide the suggestions list asynchronously [core] - 10https://gerrit.wikimedia.org/r/121701 [18:06:31] ebernhardson: ping in pm [18:07:28] still, Paramount Pictures logo (2002).jpg should've been the PI [18:08:18] MaxSem: Hmm, I'll try to look for more examples and share them with you as I do [18:08:48] MaxSem: Could you please leave a comment on that bug so that Jared too can share if he finds another such instance [18:10:15] hoo: I don't know much about them.. but yeah, I can see the problem with that [18:11:03] csteipp: https://arbcom-nl.wikipedia.org/wiki/Hoofdpagina eg. also works [18:11:10] So why not set that as wgServer? [18:11:28] (03CR) 10Bartosz Dziewoński: "Screenshots, or examples? Bug reports? What browser? I don't see why
would cause the issues you described." [core] - 10https://gerrit.wikimedia.org/r/121292 (owner: 10Luis Felipe Schenone) [18:13:50] csteipp: Could you do a quick review of https://gerrit.wikimedia.org/r/#/c/121633/ please ? [18:13:51] csteipp: That extension has a non-standard way of dealing with globals, and I want to be sure I did it right before merging. [18:15:25] csteipp: Or do you know who to ping/ ask about this? [18:15:40] siebrand_na: I'm right in the middle of a couple other issues, but I'll take a look today. [18:16:03] csteipp: Can you recommend someone else? It's a bit time sensitive. [18:16:16] siebrand_na: anomie might be able to [18:16:25] csteipp: Thanks, will ask Brad. [18:16:30] * anomie looks [18:16:36] * siebrand_na thanks anomie. [18:17:01] anomie: Could you also tell me why this extension has such a non-standard way of dealing with globals? [18:17:25] siebrand_na: You'd probably have to ask Aaron that one [18:17:44] anomie: okay. I thought there was maybe something obvious I was missing :) [18:17:56] siebrand_na: If there is, I'm missing it too [18:18:04] anomie: Aaron was my first choice for reviewer, but he's not online. [18:19:31] mwalker: I made https://gerrit.wikimedia.org/r/#/c/121670/ today, because it wasn't actually being used in the extension. I think it may be a bug. [18:19:38] mwalker: That it's not being used. [18:19:54] mwalker: See commit summary for some detail. [18:20:48] (03CR) 10Nemo bis: "So, will this get "a dummy .jshintrc" as said on the bug or something else?" [extensions/OAuth] - 10https://gerrit.wikimedia.org/r/121633 (owner: 10Siebrand) [18:21:26] hearsay indicates Aaron is on holiday isn't he [18:23:27] (03CR) 10Anomie: [C: 031] "Code seems good, and seems to still work in a minimal test. A few style nitpicks." (032 comments) [extensions/OAuth] - 10https://gerrit.wikimedia.org/r/121633 (owner: 10Siebrand) [18:23:37] (03CR) 10Bartosz Dziewoński: [C: 032] mediawiki.util: Fix jsduck syntax and minor clean up [core] - 10https://gerrit.wikimedia.org/r/121299 (owner: 10Krinkle) [18:23:50] anomie: Thanks, looking/addressing. [18:25:20] (03CR) 10Krinkle: "Nope, no dummy jshintrc." [extensions/OAuth] - 10https://gerrit.wikimedia.org/r/121633 (owner: 10Siebrand) [18:25:36] (03PS2) 10Siebrand: Migrate to JSON i18n [extensions/OAuth] - 10https://gerrit.wikimedia.org/r/121633 [18:25:59] (03PS3) 10Siebrand: Migrate to JSON i18n [extensions/OAuth] - 10https://gerrit.wikimedia.org/r/121633 [18:26:48] (03Merged) 10jenkins-bot: mediawiki.util: Fix jsduck syntax and minor clean up [core] - 10https://gerrit.wikimedia.org/r/121299 (owner: 10Krinkle) [18:27:17] (03CR) 10Siebrand: "Thanks for the review, Brad." (032 comments) [extensions/OAuth] - 10https://gerrit.wikimedia.org/r/121633 (owner: 10Siebrand) [18:28:36] (03CR) 10Siebrand: [C: 032] "Per earlier reviews." [extensions/OAuth] - 10https://gerrit.wikimedia.org/r/121633 (owner: 10Siebrand) [18:28:43] (03CR) 10jenkins-bot: [V: 04-1] Migrate to JSON i18n [extensions/OAuth] - 10https://gerrit.wikimedia.org/r/121633 (owner: 10Siebrand) [18:28:47] (03PS3) 10Prtksxna: Fix placement issue for smaller images [extensions/Popups] - 10https://gerrit.wikimedia.org/r/121607 [18:28:51] (03CR) 10Prtksxna: "Fixed" [extensions/Popups] - 10https://gerrit.wikimedia.org/r/121607 (owner: 10Prtksxna) [18:29:26] (03CR) 10Siebrand: [V: 032] "Override jenkins." [extensions/OAuth] - 10https://gerrit.wikimedia.org/r/121633 (owner: 10Siebrand) [18:34:35] (03CR) 10Gergő Tisza: [C: 031] "We can just leave the current logic as fallback in MediaViewer, then we don't need to worry about cache invalidation. (We probably need it" [core] - 10https://gerrit.wikimedia.org/r/121601 (owner: 10Gilles) [18:41:01] (03CR) 10MaxSem: [C: 032] HttpStatus: add RFC 6585 status codes [core] - 10https://gerrit.wikimedia.org/r/121627 (owner: 10Faidon Liambotis) [18:42:21] (03PS22) 10Ori.livneh: Introducing TitleValue [core] - 10https://gerrit.wikimedia.org/r/106517 (owner: 10Daniel Kinzler) [18:42:52] (03CR) 10Ori.livneh: [C: 032] Return exit_status from Application._before_exit [tools/scap] - 10https://gerrit.wikimedia.org/r/121571 (owner: 10BryanDavis) [18:42:56] siebrand, it's still used... the messages just get constructed dynamically... and this is a great case in point of useless messages we have hanging around (we shouldn't need them per gateway considering they're the same per gateway) [18:43:01] so; thank you for doing it [18:43:34] mwalker: What is it I did? [18:43:41] (03Merged) 10jenkins-bot: Return exit_status from Application._before_exit [tools/scap] - 10https://gerrit.wikimedia.org/r/121571 (owner: 10BryanDavis) [18:44:02] mwalker: Because nothing changed. Why is it you're not sharing resources between gateways? [18:44:19] (03Merged) 10jenkins-bot: HttpStatus: add RFC 6585 status codes [core] - 10https://gerrit.wikimedia.org/r/121627 (owner: 10Faidon Liambotis) [18:44:44] (03PS1) 10Bsitu: Improve post action action performance [extensions/Flow] - 10https://gerrit.wikimedia.org/r/121707 [18:45:22] (03PS2) 10Bsitu: Improve post action menu performance [extensions/Flow] - 10https://gerrit.wikimedia.org/r/121707 [18:45:29] (03PS1) 10Nuria: Adding scheduler mode to wikimetrics. Role change. [vagrant] - 10https://gerrit.wikimedia.org/r/121708 [18:45:33] (03CR) 10jenkins-bot: [V: 04-1] Introducing TitleValue [core] - 10https://gerrit.wikimedia.org/r/106517 (owner: 10Daniel Kinzler) [18:45:38] (03CR) 10Ori.livneh: [C: 031] "Bryan, you magnificent bastard! This looks awesome. Going to test it a bit and hopefully merge soon." [vagrant] - 10https://gerrit.wikimedia.org/r/121425 (owner: 10BryanDavis) [18:45:51] (03CR) 10jenkins-bot: [V: 04-1] Improve post action menu performance [extensions/Flow] - 10https://gerrit.wikimedia.org/r/121707 (owner: 10Bsitu) [18:48:08] (03CR) 10Ori.livneh: [C: 032 V: 032] "The tests pass; the -1 from Jenkins is a Jenkins bug. So off we go." [core] - 10https://gerrit.wikimedia.org/r/106517 (owner: 10Daniel Kinzler) [18:48:32] ori: Wow... great... thanks [18:48:58] siebrand, because of silly design decisions years ago [18:49:19] ori: OMG! [18:49:33] ori: You made fewer lines to Title.php! [18:50:27] the universe is imploding [18:50:57] Lemme get that into production at twn... [18:51:08] On HHVM no less... [18:52:31] siebrand: Nikerabbit did some ninja work there, made it look easy :P [18:52:38] Done... [18:52:59] ori: I have no idea... I just update the nightly builds and report bugs to him. [18:53:30] (03CR) 10Ori.livneh: [C: 032] Adding scheduler mode to wikimetrics. Role change. [vagrant] - 10https://gerrit.wikimedia.org/r/121708 (owner: 10Nuria) [18:53:33] (03Merged) 10jenkins-bot: Adding scheduler mode to wikimetrics. Role change. [vagrant] - 10https://gerrit.wikimedia.org/r/121708 (owner: 10Nuria) [18:53:41] ori: I did see you liked the cookie approach and are going to use that too. [18:54:11] siebrand: yes, it's a great idea [18:54:11] ori: I'm using it on twn, but for example today, I've had to restart HHVM two or 3 times. [18:54:24] ori: Not yet stable at all. [18:54:39] ori: It does feel pretty quick. [18:54:46] Until it breaks. [18:55:06] (03CR) 10Nemo bis: "I'm not so sure about this, I'd need to dig further to see what the expectations are. All those o i s with diacritics don't look so confus" (035 comments) [extensions/AntiSpoof] - 10https://gerrit.wikimedia.org/r/92154 (owner: 10Kaldari) [18:55:07] does it break slowly? :) [18:55:44] ori: Not really. Then it's just an nginx gateway timeout. [18:56:38] i know its generally discouraged, but is ES5 feature detection in javascript ok for developer tools? essentially check for the functions that it needs and bail w/ error message if not ES5? [18:56:56] its an extension of the debug toolbar [18:57:27] i think so, if you don't crash everything [18:57:46] we use ES5 stuff even in core [18:57:54] ok, sounds reasonable then. [18:58:33] ebernhardson: e.g.: https://github.com/wikimedia/mediawiki-core/blob/master/resources/mediawiki/mediawiki.js#L558 [18:59:44] siebrand: can you abandon https://gerrit.wikimedia.org/r/#/c/109473/ please [19:00:13] Nemo_bis: that dev is no longer active [19:00:14] ? [19:00:31] (03CR) 10Ori.livneh: "Krinkle: re: debouncing schema loads, that seems like a good idea. I'll defer that to another patch tho." [extensions/EventLogging] - 10https://gerrit.wikimedia.org/r/120757 (owner: 10Ori.livneh) [19:00:51] (03PS6) 10Ori.livneh: Allow EventLogging events to be logged via mw#track [extensions/EventLogging] - 10https://gerrit.wikimedia.org/r/120757 [19:01:36] Nemo_bis: That dev has more patch sets abandoned than open or merged. https://gerrit.wikimedia.org/r/#/q/owner:aravikn%2540gmail.com,n,z [19:02:29] (03Abandoned) 10Siebrand: Renamed"{{SITENAME}}" to "wikipedia" in ArticleFeedbackv5.i18n.php [extensions/ArticleFeedbackv5] - 10https://gerrit.wikimedia.org/r/109473 (owner: 10Arav93) [19:03:58] yes, he was often confused :) [19:08:16] (03CR) 10Nemo bis: "If I understand correctly the only line you wanted to change is the addition of "RCM_permil"? The message key should follow the same forma" [extensions/FormelApplet] - 10https://gerrit.wikimedia.org/r/69985 (owner: 10Rudolf.grossmann) [19:09:05] (03CR) 10Kaldari: "Thanks for the thorough review!" (035 comments) [extensions/AntiSpoof] - 10https://gerrit.wikimedia.org/r/92154 (owner: 10Kaldari) [19:09:59] (03CR) 10Luis Felipe Schenone: "Link to the new patch: https://gerrit.wikimedia.org/r/#/c/121292/" [core] (REL1_22) - 10https://gerrit.wikimedia.org/r/121291 (owner: 10Luis Felipe Schenone) [19:10:36] (03CR) 10Luis Felipe Schenone: "Here you go: https://bugzilla.wikimedia.org/show_bug.cgi?id=63233" [core] - 10https://gerrit.wikimedia.org/r/121292 (owner: 10Luis Felipe Schenone) [19:11:13] (03PS2) 10Kaldari: Always render copyright notice in user language [core] - 10https://gerrit.wikimedia.org/r/120696 [19:15:08] (03CR) 10jenkins-bot: [V: 04-1] Always render copyright notice in user language [core] - 10https://gerrit.wikimedia.org/r/120696 (owner: 10Kaldari) [19:17:24] (03PS12) 10UltrasonicNXT: WIP - Rewrite [extensions/WikiForum] - 10https://gerrit.wikimedia.org/r/116258 [19:24:25] (03PS1) 10Aude: Add visibility to SpecialCategories methods [core] - 10https://gerrit.wikimedia.org/r/121724 [19:29:22] (03CR) 10Bartosz Dziewoński: "Looks neat, I don't have everything set-up to test though." [extensions/EventLogging] - 10https://gerrit.wikimedia.org/r/120757 (owner: 10Ori.livneh) [19:31:56] (03CR) 10CSteipp: "I honestly haven't looked at all the context, but it does concern me. This appears to be vulnerable to symlink attacks-- if a local user d" [core] - 10https://gerrit.wikimedia.org/r/121549 (owner: 10BryanDavis) [19:33:04] (03CR) 10jenkins-bot: [V: 04-1] Add visibility to SpecialCategories methods [core] - 10https://gerrit.wikimedia.org/r/121724 (owner: 10Aude) [19:44:44] (03PS7) 10Bartosz Dziewoński: resourceloader: Separate gathering of registry data from mw.loader call [core] - 10https://gerrit.wikimedia.org/r/117444 (owner: 10Krinkle) [19:44:50] (03PS8) 10Bartosz Dziewoński: resourceloader: Separate gathering of registry data from mw.loader call [core] - 10https://gerrit.wikimedia.org/r/117444 (owner: 10Krinkle) [19:45:05] (03CR) 10Bartosz Dziewoński: [C: 032] "Looks nice and appears to work." [core] - 10https://gerrit.wikimedia.org/r/117444 (owner: 10Krinkle) [19:46:07] (03CR) 10BryanDavis: "> This appears to be vulnerable to symlink attacks" [core] - 10https://gerrit.wikimedia.org/r/121549 (owner: 10BryanDavis) [19:48:12] (03CR) 10Bartosz Dziewoński: "As I said on the bug: "Given that this is already used in production, I would suggest reverting to the default focus styling while, as Jar" [core] - 10https://gerrit.wikimedia.org/r/119998 (owner: 10TheDJ) [19:50:12] (03CR) 10jenkins-bot: [V: 04-1] resourceloader: Separate gathering of registry data from mw.loader call [core] - 10https://gerrit.wikimedia.org/r/117444 (owner: 10Krinkle) [19:51:14] (03CR) 10Bartosz Dziewoński: "Removing myself from reviewers' list – sorry, I'm not the best guy to review this." [core] - 10https://gerrit.wikimedia.org/r/92928 (owner: 10Umherirrender) [19:52:36] (03CR) 10Bartosz Dziewoński: [V: 032] "Ori just broke master and PHPUnit is segfaulting, let's ignore jenkins." [core] - 10https://gerrit.wikimedia.org/r/117444 (owner: 10Krinkle) [19:53:57] (03CR) 10Bartosz Dziewoński: "https://bugzilla.wikimedia.org/show_bug.cgi?id=62623" [core] - 10https://gerrit.wikimedia.org/r/117444 (owner: 10Krinkle) [19:54:06] (03CR) 10Bartosz Dziewoński: "PHPUnit is segfaulting on master right now, ignore jenkins (bug 62623)." [core] - 10https://gerrit.wikimedia.org/r/121724 (owner: 10Aude) [19:54:29] (03CR) 10Bartosz Dziewoński: "Why only a few and not all methods in this file?" [core] - 10https://gerrit.wikimedia.org/r/121724 (owner: 10Aude) [20:00:09] (03PS3) 10Bartosz Dziewoński: mediawiki.api: Documentation and typo cleanup [core] - 10https://gerrit.wikimedia.org/r/118731 [20:00:11] (03CR) 10Bartosz Dziewoński: mediawiki.api: Documentation and typo cleanup (031 comment) [core] - 10https://gerrit.wikimedia.org/r/118731 (owner: 10Bartosz Dziewoński) [20:00:24] (03PS4) 10Bartosz Dziewoński: mediawiki.api: Documentation and typo cleanup [core] - 10https://gerrit.wikimedia.org/r/118731 [20:00:56] (03PS2) 10Bartosz Dziewoński: mediawiki.api.category: getCategories: Deprecate the 'async' parameter [core] - 10https://gerrit.wikimedia.org/r/118732 [20:01:58] (03CR) 10jenkins-bot: [V: 04-1] mediawiki.api: Documentation and typo cleanup [core] - 10https://gerrit.wikimedia.org/r/118731 (owner: 10Bartosz Dziewoński) [20:02:22] (03CR) 10Bartosz Dziewoński: "PHPUnit is segfaulting on master right now, ignore jenkins (bug 62623)." [core] - 10https://gerrit.wikimedia.org/r/118731 (owner: 10Bartosz Dziewoński) [20:02:32] (03CR) 10Chad: [C: 032] Scan plugins when building index [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/121446 (owner: 10Manybubbles) [20:04:19] (03PS7) 10Ori.livneh: Allow EventLogging events to be logged via mw#track [extensions/EventLogging] - 10https://gerrit.wikimedia.org/r/120757 [20:05:41] (03PS1) 10Nuria: Bumping up modules/wikimetrics [vagrant] - 10https://gerrit.wikimedia.org/r/121831 [20:06:17] (03PS3) 10Bartosz Dziewoński: mediawiki.api.category: getCategories: Deprecate the 'async' parameter [core] - 10https://gerrit.wikimedia.org/r/118732 [20:06:19] (03CR) 10Ori.livneh: "@MatmaRex: I removed the unrelated cleanup bits; will submit as another patch. The forced capitalization is simply so we don't annoy devel" [extensions/EventLogging] - 10https://gerrit.wikimedia.org/r/120757 (owner: 10Ori.livneh) [20:06:22] (03CR) 10Bartosz Dziewoński: mediawiki.api.category: getCategories: Deprecate the 'async' parameter (031 comment) [core] - 10https://gerrit.wikimedia.org/r/118732 (owner: 10Bartosz Dziewoński) [20:06:27] ^ MatmaRex [20:07:15] ori: ah, okay. thanks :) [20:07:18] (03Merged) 10jenkins-bot: Scan plugins when building index [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/121446 (owner: 10Manybubbles) [20:09:01] (03CR) 10Ottomata: [C: 032 V: 032] Bumping up modules/wikimetrics [vagrant] - 10https://gerrit.wikimedia.org/r/121831 (owner: 10Nuria) [20:11:19] (03PS12) 10Krinkle: resourceloader: Optimize module registry sent in the startup module [core] - 10https://gerrit.wikimedia.org/r/72534 (owner: 10Hoo man) [20:12:34] ori: btw, is someone unbreaking phpunit on core master? [20:13:06] (03PS1) 10Ori.livneh: Remove long-deprecated functionality [extensions/EventLogging] - 10https://gerrit.wikimedia.org/r/121832 [20:13:17] MatmaRex: yes, several people are working on it [20:13:48] MatmaRex: https://gerrit.wikimedia.org/r/#/c/121832/1 :) [20:13:56] (03PS2) 10Bartosz Dziewoński: mediawiki.api: Remove deprecated function parameters [core] - 10https://gerrit.wikimedia.org/r/118733 [20:14:29] (03CR) 10Bartosz Dziewoński: [C: 032] Remove long-deprecated functionality [extensions/EventLogging] - 10https://gerrit.wikimedia.org/r/121832 (owner: 10Ori.livneh) [20:15:00] (03CR) 10jenkins-bot: [V: 04-1] mediawiki.api: Documentation and typo cleanup [core] - 10https://gerrit.wikimedia.org/r/118731 (owner: 10Bartosz Dziewoński) [20:15:02] (03CR) 10jenkins-bot: [V: 04-1] mediawiki.api.category: getCategories: Deprecate the 'async' parameter [core] - 10https://gerrit.wikimedia.org/r/118732 (owner: 10Bartosz Dziewoński) [20:15:04] (03CR) 10jenkins-bot: [V: 04-1] resourceloader: Optimize module registry sent in the startup module [core] - 10https://gerrit.wikimedia.org/r/72534 (owner: 10Hoo man) [20:15:11] (03CR) 10Bartosz Dziewoński: "Rebased." [core] - 10https://gerrit.wikimedia.org/r/118733 (owner: 10Bartosz Dziewoński) [20:15:36] (03Merged) 10jenkins-bot: Remove long-deprecated functionality [extensions/EventLogging] - 10https://gerrit.wikimedia.org/r/121832 (owner: 10Ori.livneh) [20:17:17] (03CR) 10jenkins-bot: [V: 04-1] mediawiki.api: Remove deprecated function parameters [core] - 10https://gerrit.wikimedia.org/r/118733 (owner: 10Bartosz Dziewoński) [20:17:52] (03CR) 10Parent5446: [C: 032] Set ThrottledError's response code to 429 [core] - 10https://gerrit.wikimedia.org/r/120765 (owner: 10Faidon Liambotis) [20:18:24] (03PS4) 10Krinkle: mediawiki.api.category: Deprecate getCategories() 'async' parameter [core] - 10https://gerrit.wikimedia.org/r/118732 (owner: 10Bartosz Dziewoński) [20:18:29] yay [20:18:49] (03CR) 10Parent5446: [C: 032] Allow to optionally set language in Message constructor [core] - 10https://gerrit.wikimedia.org/r/121113 (owner: 10Aude) [20:19:22] (03CR) 10Siebrand: [C: 031] "L10n reviewed." (031 comment) [extensions/WikimediaMessages] - 10https://gerrit.wikimedia.org/r/121106 (owner: 10Kaldari) [20:19:33] (03CR) 10Parent5446: [C: 032] Add getLanguage method to Message [core] - 10https://gerrit.wikimedia.org/r/121118 (owner: 10Aude) [20:20:08] (03CR) 10Aude: "prefer to add visibility on the other methods after doing so in the parent classes, to keep consistency." [core] - 10https://gerrit.wikimedia.org/r/121724 (owner: 10Aude) [20:22:29] (03CR) 10jenkins-bot: [V: 04-1] Set ThrottledError's response code to 429 [core] - 10https://gerrit.wikimedia.org/r/120765 (owner: 10Faidon Liambotis) [20:22:41] (03CR) 10jenkins-bot: [V: 04-1] mediawiki.api.category: Deprecate getCategories() 'async' parameter [core] - 10https://gerrit.wikimedia.org/r/118732 (owner: 10Bartosz Dziewoński) [20:23:08] (03PS5) 10Bartosz Dziewoński: mediawiki.api.category: Deprecate getCategories() 'async' parameter [core] - 10https://gerrit.wikimedia.org/r/118732 [20:23:10] (03PS3) 10Bartosz Dziewoński: mediawiki.api: Remove deprecated function parameters [core] - 10https://gerrit.wikimedia.org/r/118733 [20:23:43] (03CR) 10Bartosz Dziewoński: "Added release notes." [core] - 10https://gerrit.wikimedia.org/r/118732 (owner: 10Bartosz Dziewoński) [20:24:10] (03CR) 10jenkins-bot: [V: 04-1] Allow to optionally set language in Message constructor [core] - 10https://gerrit.wikimedia.org/r/121113 (owner: 10Aude) [20:24:12] (03CR) 10jenkins-bot: [V: 04-1] Add getLanguage method to Message [core] - 10https://gerrit.wikimedia.org/r/121118 (owner: 10Aude) [20:24:19] (03CR) 10Bartosz Dziewoński: [C: 032 V: 032] Add visibility to SpecialCategories methods [core] - 10https://gerrit.wikimedia.org/r/121724 (owner: 10Aude) [20:24:56] (03CR) 10Siebrand: [C: 031] "i18n/L10n reviewed." [core] - 10https://gerrit.wikimedia.org/r/117438 (owner: 10Bartosz Dziewoński) [20:25:21] (03CR) 10Bartosz Dziewoński: "PHPUnit is segfaulting on master right now, ignore jenkins (bug 62623)." [core] - 10https://gerrit.wikimedia.org/r/121113 (owner: 10Aude) [20:25:31] (03CR) 10Bartosz Dziewoński: "PHPUnit is segfaulting on master right now, ignore jenkins (bug 62623)." [core] - 10https://gerrit.wikimedia.org/r/121118 (owner: 10Aude) [20:25:36] ori: MatmaRex: hashar: So is there a commit that bypassed Jenkins in master that made it hit that threshold? [20:25:45] Krinkle: yes [20:25:46] yes, titlevalue [20:25:47] MatmaRex: We'll be having a broken Jenkins until Monday? [20:25:53] Or did it just happen to pass and start failing after the merge? [20:26:09] siebrand: i'm not the one to ask [20:26:13] the tests passed; jenkins segfaulted for whatever unrelated reason is causing it to segfault [20:26:18] i've stopped trusting our CI some time ago [20:26:24] so i overrid the vote, not the result [20:26:27] MatmaRex: That's a bit harsh. [20:26:41] life's harsh [20:26:44] MatmaRex: It's a pretty useful process, but we're still hitting edge cases, and that's annoying. [20:26:49] ori: We've had a fair number of commits cause that in certain cases, they're always deterministic [20:27:21] and hence not merged until we find a way around it [20:27:44] (03CR) 10Parent5446: "Why can't you put the code in an external file and have it loaded by ResourceLoader? Generally I'd like to avoid adding more inline script" [core] - 10https://gerrit.wikimedia.org/r/121606 (owner: 10Gilles) [20:27:54] Krinkle: Ah, sorry. I did not know that. Was it documented somewhere? [20:28:07] Only 1 patch so far actually, not a fair number. [20:28:09] (03CR) 10jenkins-bot: [V: 04-1] mediawiki.api.category: Deprecate getCategories() 'async' parameter [core] - 10https://gerrit.wikimedia.org/r/118732 (owner: 10Bartosz Dziewoński) [20:28:25] And it was revised to not trigger it (mostly random variance, almost like trying to avoid a magic output size in gzip) [20:28:26] ori: [20:28:28] (03CR) 10jenkins-bot: [V: 04-1] mediawiki.api: Remove deprecated function parameters [core] - 10https://gerrit.wikimedia.org/r/118733 (owner: 10Bartosz Dziewoński) [20:28:32] RIP Jenkins [20:28:43] ori: Is it that critical a patch? [20:28:45] Can we revert it? [20:28:52] Or hotpatch to wmf if its really that pressing [20:29:15] The people that can fix this don't seem to be available to fix it at the moment [20:29:28] (03CR) 10Bartosz Dziewoński: "PHPUnit is segfaulting on master right now, ignore jenkins (bug 62623)." [core] - 10https://gerrit.wikimedia.org/r/118733 (owner: 10Bartosz Dziewoński) [20:29:32] (03CR) 10Bartosz Dziewoński: "PHPUnit is segfaulting on master right now, ignore jenkins (bug 62623)." [core] - 10https://gerrit.wikimedia.org/r/118732 (owner: 10Bartosz Dziewoński) [20:29:33] Krinkle: we were very slow to move on that patch, despite daniel k. having gone out of his way to discuss, document, present its scope and implementation [20:29:47] it would be very demoralizing and embarrassing to revert it, but not technical critical [20:30:41] This isn't about anyone's feelings or the nature of any patch. Even if it was the one magic patch that made unicorns fall out of the sky and auto-rewrite our repo to run on nodejs, it isn't critical at the moment and is obviously drstroying our workflow and productivity [20:30:49] (midly exxagerated) [20:30:57] mildly exaggerated [20:31:07] can't we just kill the tests themselves? [20:31:15] right, comment them out or something. [20:31:24] (i mean the ones that made phpunit go over the magical limit) [20:31:59] "is obviously destroying" -- well, it's not the patch's fault. but yeah, that sounds like a good idea. i'll submit a patch. [20:32:03] I'm being pulled into twelve different directions today, and still can't prio this unfortunately. [20:32:14] Thx [20:35:15] (03CR) 10Bartosz Dziewoński: [C: 04-1] "JSHint is failing." (032 comments) [core] - 10https://gerrit.wikimedia.org/r/117808 (owner: 10TheDJ) [20:36:31] (03PS3) 10Krinkle: TableSorter: Improve detection and handling of isoDate [core] - 10https://gerrit.wikimedia.org/r/117808 (owner: 10TheDJ) [20:36:43] (03CR) 10Krinkle: "(Rebasing to unleash the new jscs)" [core] - 10https://gerrit.wikimedia.org/r/117808 (owner: 10TheDJ) [20:37:27] (03PS1) 10Siebrand: Migrate to JSON i18n [extensions/Poem] - 10https://gerrit.wikimedia.org/r/121835 [20:37:55] (03CR) 10Krinkle: "Did you push them out to Jenkins?" [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/121626 (owner: 10Siebrand) [20:38:05] (03PS2) 10Krinkle: Add Jenkins jobs for Nostalgia extension repo [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/121626 (owner: 10Siebrand) [20:38:40] (03CR) 10Nemo bis: "No tests actually failed, it's only bug 60037 AFAICS. So, manual V+2 I guess." [core] - 10https://gerrit.wikimedia.org/r/120765 (owner: 10Faidon Liambotis) [20:39:09] (03PS1) 10Siebrand: Migrate to JSON i18n [extensions/PoolCounter] - 10https://gerrit.wikimedia.org/r/121836 [20:39:13] (03PS1) 10Ori.livneh: Temporarily remove tests added in I8eef5a165 [core] - 10https://gerrit.wikimedia.org/r/121837 [20:40:11] Krinkle: https://gerrit.wikimedia.org/r/#/c/121837/ [20:40:14] (03CR) 10jenkins-bot: [V: 04-1] TableSorter: Improve detection and handling of isoDate [core] - 10https://gerrit.wikimedia.org/r/117808 (owner: 10TheDJ) [20:40:23] (03PS1) 10Siebrand: Migrate to JSON i18n [extensions/Popups] - 10https://gerrit.wikimedia.org/r/121838 [20:41:08] (03PS1) 10Siebrand: Migrate to JSON i18n [extensions/ProofreadPage] - 10https://gerrit.wikimedia.org/r/121839 [20:42:07] (03PS1) 10Siebrand: Migrate to JSON i18n [extensions/Quiz] - 10https://gerrit.wikimedia.org/r/121840 [20:42:43] (03CR) 10Bsitu: [C: 032] Moderator usertext & links are allowed to be displayed [extensions/Flow] - 10https://gerrit.wikimedia.org/r/121382 (owner: 10Matthias Mullie) [20:42:44] ori: Krinkle i would perhaps run the Language test group in core separately [20:43:02] (03Merged) 10jenkins-bot: Moderator usertext & links are allowed to be displayed [extensions/Flow] - 10https://gerrit.wikimedia.org/r/121382 (owner: 10Matthias Mullie) [20:43:11] (03PS1) 10Siebrand: Migrate to JSON i18n [extensions/RandomRootPage] - 10https://gerrit.wikimedia.org/r/121841 [20:43:31] (03PS1) 10Bartosz Dziewoński: mediawiki.ui: Do not depend on divs being present inside .mw-ui-vform [core] - 10https://gerrit.wikimedia.org/r/121842 [20:44:04] (03PS1) 10Siebrand: Migrate to JSON i18n [extensions/RelatedArticles] - 10https://gerrit.wikimedia.org/r/121843 [20:44:38] aude: ori: i'm giving you 15 minutes before i +2 ori's patch and call it a day. ;) [20:44:42] (03PS1) 10Siebrand: Migrate to JSON i18n [extensions/RelatedSites] - 10https://gerrit.wikimedia.org/r/121844 [20:44:55] is it really the number of tests running on jenkins? [20:45:37] aude: Krinkle is the most credible person to answer that question, and he says yes, so I trust it [20:45:56] (03PS1) 10Siebrand: Migrate to JSON i18n [extensions/RSS] - 10https://gerrit.wikimedia.org/r/121845 [20:46:09] (03CR) 10Bartosz Dziewoński: "It still seems to think that regexp is invalid. It looks valid enough to me (using http://regex101.com/ )." [core] - 10https://gerrit.wikimedia.org/r/121837 (owner: 10Ori.livneh) [20:46:18] (03CR) 10Bartosz Dziewoński: "Aaaa wrong patch." [core] - 10https://gerrit.wikimedia.org/r/121837 (owner: 10Ori.livneh) [20:46:37] (03CR) 10Bartosz Dziewoński: "It still seems to think that regexp is invalid. It looks valid enough to me (using http://regex101.com/ )." [core] - 10https://gerrit.wikimedia.org/r/117808 (owner: 10TheDJ) [20:46:46] ok [20:46:46] (03PS1) 10Siebrand: Migrate to JSON i18n [extensions/Scribunto] - 10https://gerrit.wikimedia.org/r/121848 [20:47:04] (03CR) 10jenkins-bot: [V: 04-1] mediawiki.ui: Do not depend on divs being present inside .mw-ui-vform [core] - 10https://gerrit.wikimedia.org/r/121842 (owner: 10Bartosz Dziewoński) [20:47:37] (03PS1) 10Aude: Remove SpecialPageAliasTest [core] - 10https://gerrit.wikimedia.org/r/121849 [20:47:38] i'd rather try merging that ^ [20:47:41] (03PS1) 10Siebrand: Migrate to JSON i18n [extensions/Score] - 10https://gerrit.wikimedia.org/r/121850 [20:47:50] i was never really convinced that was the best approach and was hesitant [20:48:05] i would like to rethink and maybe try something different for that [20:50:19] (03CR) 10Bartosz Dziewoński: "PHPUnit is segfaulting on master right now, ignore jenkins (bug 62623)." [core] - 10https://gerrit.wikimedia.org/r/121842 (owner: 10Bartosz Dziewoński) [20:52:22] ori: MatmaRex ^ [20:52:39] think that's the better thing to do [20:53:15] removing a single test makes it work? lol [20:53:24] it does lots of tests [20:53:27] (03PS9) 10EBernhardson: Visualize profile output in debug toolbar [core] - 10https://gerrit.wikimedia.org/r/104318 [20:53:32] kind of abusing phpunit [20:53:32] well yeah, but still [20:53:37] ah hm [20:54:03] eh, it's still one tests afaics, just with lots of assertions? [20:54:05] we can try another approach for validating the aliases [20:54:11] yes [20:54:21] jenkins approves :) [20:54:31] (03CR) 10jenkins-bot: [V: 04-1] Visualize profile output in debug toolbar [core] - 10https://gerrit.wikimedia.org/r/104318 (owner: 10EBernhardson) [20:54:41] (03CR) 10Bsitu: [C: 032] Use existing method to check if moderated instead of doing manually [extensions/Flow] - 10https://gerrit.wikimedia.org/r/121383 (owner: 10Matthias Mullie) [20:54:43] probably in translate extension + maybe a script that we run once in a while [20:54:54] (03Merged) 10jenkins-bot: Use existing method to check if moderated instead of doing manually [extensions/Flow] - 10https://gerrit.wikimedia.org/r/121383 (owner: 10Matthias Mullie) [20:56:06] or it can be run in a different jenkins job [20:56:40] (03CR) 10EBernhardson: Visualize profile output in debug toolbar (0327 comments) [core] - 10https://gerrit.wikimedia.org/r/104318 (owner: 10EBernhardson) [20:56:50] oooh, i got mystery phpunit failure at 98% [20:57:59] (03PS10) 10EBernhardson: Visualize profile output in debug toolbar [core] - 10https://gerrit.wikimedia.org/r/104318 [20:58:05] (03CR) 10EBernhardson: "PS10: rebase" [core] - 10https://gerrit.wikimedia.org/r/104318 (owner: 10EBernhardson) [20:58:22] (03PS4) 10Ori.livneh: Add Cirrus performance logging [extensions/WikimediaEvents] - 10https://gerrit.wikimedia.org/r/120592 [20:59:07] http://hhvm.com/blog/4349/hhvm-3-0-0 btw [20:59:28] (03CR) 10Krinkle: [C: 032] Temporarily remove tests added in I8eef5a165 [core] - 10https://gerrit.wikimedia.org/r/121837 (owner: 10Ori.livneh) [21:01:22] (03CR) 10jenkins-bot: [V: 04-1] Visualize profile output in debug toolbar [core] - 10https://gerrit.wikimedia.org/r/104318 (owner: 10EBernhardson) [21:02:30] (03Merged) 10jenkins-bot: Temporarily remove tests added in I8eef5a165 [core] - 10https://gerrit.wikimedia.org/r/121837 (owner: 10Ori.livneh) [21:04:08] (03PS4) 10Purodha: MW WLD prefix compatibility fix [extensions/WikiLexicalData] - 10https://gerrit.wikimedia.org/r/119446 (owner: 10Hiong3-eng5) [21:04:10] (03PS1) 10Purodha: Some 100+ table prefix errors in WikiLexicaldata [extensions/WikiLexicalData] - 10https://gerrit.wikimedia.org/r/121853 [21:04:12] (03PS1) 10Purodha: Merge commit 'refs/changes/46/119446/3' of ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/WikiLexicalData into HEAD [extensions/WikiLexicalData] - 10https://gerrit.wikimedia.org/r/121854 [21:05:31] (03PS20) 10EBernhardson: Refactor Flow\\Formatter namespace [extensions/Flow] - 10https://gerrit.wikimedia.org/r/117384 [21:05:34] (03PS1) 10EBernhardson: Standardize URL generation [extensions/Flow] - 10https://gerrit.wikimedia.org/r/121855 [21:05:53] (03CR) 10jenkins-bot: [V: 04-1] Standardize URL generation [extensions/Flow] - 10https://gerrit.wikimedia.org/r/121855 (owner: 10EBernhardson) [21:05:56] (03CR) 10EBernhardson: "PS20: rebase" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/117384 (owner: 10EBernhardson) [21:08:42] (03PS5) 10Krinkle: mediawiki.api: Documentation and typo cleanup [core] - 10https://gerrit.wikimedia.org/r/118731 (owner: 10Bartosz Dziewoński) [21:09:13] (03CR) 10Krinkle: [C: 032] mediawiki.api: Documentation and typo cleanup [core] - 10https://gerrit.wikimedia.org/r/118731 (owner: 10Bartosz Dziewoński) [21:09:17] (03PS6) 10Krinkle: mediawiki.api.category: Deprecate getCategories() 'async' parameter [core] - 10https://gerrit.wikimedia.org/r/118732 (owner: 10Bartosz Dziewoński) [21:11:14] (03CR) 10Krinkle: [C: 04-1] mediawiki.api.category: Deprecate getCategories() 'async' parameter (031 comment) [core] - 10https://gerrit.wikimedia.org/r/118732 (owner: 10Bartosz Dziewoński) [21:11:20] (03PS4) 10Krinkle: mediawiki.api: Remove deprecated function parameters [core] - 10https://gerrit.wikimedia.org/r/118733 (owner: 10Bartosz Dziewoński) [21:12:22] (03PS11) 10Krinkle: Visualize profile output in debug toolbar [core] - 10https://gerrit.wikimedia.org/r/104318 (owner: 10EBernhardson) [21:15:00] (03Merged) 10jenkins-bot: mediawiki.api: Documentation and typo cleanup [core] - 10https://gerrit.wikimedia.org/r/118731 (owner: 10Bartosz Dziewoński) [21:16:24] (03CR) 10jenkins-bot: [V: 04-1] mediawiki.api: Remove deprecated function parameters [core] - 10https://gerrit.wikimedia.org/r/118733 (owner: 10Bartosz Dziewoński) [21:16:35] (03CR) 10jenkins-bot: [V: 04-1] Visualize profile output in debug toolbar [core] - 10https://gerrit.wikimedia.org/r/104318 (owner: 10EBernhardson) [21:17:54] (03CR) 10Swalling: [C: 04-1] "So talked more with Jared about this, and I reviewed the patch locally." [core] - 10https://gerrit.wikimedia.org/r/119998 (owner: 10TheDJ) [21:17:57] greg-g, is there a wiki page anywhere that's describing markus' release schedule? [21:18:32] (03CR) 10Raimond Spekking: [C: 032] Migrate to JSON i18n [extensions/PoolCounter] - 10https://gerrit.wikimedia.org/r/121836 (owner: 10Siebrand) [21:18:37] (03Merged) 10jenkins-bot: Migrate to JSON i18n [extensions/PoolCounter] - 10https://gerrit.wikimedia.org/r/121836 (owner: 10Siebrand) [21:18:58] (03CR) 10Raimond Spekking: [C: 032] Migrate to JSON i18n [extensions/Popups] - 10https://gerrit.wikimedia.org/r/121838 (owner: 10Siebrand) [21:19:02] (03Merged) 10jenkins-bot: Migrate to JSON i18n [extensions/Popups] - 10https://gerrit.wikimedia.org/r/121838 (owner: 10Siebrand) [21:19:13] mwalker: which part? [21:19:18] https://www.mediawiki.org/wiki/Project:Release_management/Release_timeline [21:19:22] https://www.mediawiki.org/wiki/Version_lifecycle [21:19:37] (03CR) 10Raimond Spekking: [C: 032] Migrate to JSON i18n [extensions/ProofreadPage] - 10https://gerrit.wikimedia.org/r/121839 (owner: 10Siebrand) [21:19:44] (03CR) 10jenkins-bot: [V: 04-1] Migrate to JSON i18n [extensions/ProofreadPage] - 10https://gerrit.wikimedia.org/r/121839 (owner: 10Siebrand) [21:19:50] https://www.mediawiki.org/wiki/Version_lifecycle#Release_Policy mentions the monthly point releases [21:19:57] (03CR) 10Raimond Spekking: [C: 032] Migrate to JSON i18n [extensions/Quiz] - 10https://gerrit.wikimedia.org/r/121840 (owner: 10Siebrand) [21:19:59] (03Merged) 10jenkins-bot: Migrate to JSON i18n [extensions/Quiz] - 10https://gerrit.wikimedia.org/r/121840 (owner: 10Siebrand) [21:20:14] (03PS12) 10EBernhardson: Visualize profile output in debug toolbar [core] - 10https://gerrit.wikimedia.org/r/104318 [21:20:16] greg-g, the minor version updates; like the one released today [21:20:23] (03CR) 10Raimond Spekking: [C: 032] Migrate to JSON i18n [extensions/RandomRootPage] - 10https://gerrit.wikimedia.org/r/121841 (owner: 10Siebrand) [21:20:24] markus said it was 'regularly scheduled' [21:20:31] mwalker: "monthly" [21:20:40] (03CR) 10Raimond Spekking: [C: 032] Migrate to JSON i18n [extensions/RelatedArticles] - 10https://gerrit.wikimedia.org/r/121843 (owner: 10Siebrand) [21:20:49] "Point releases will be made at least monthly, on the last Thursday of the month. Every point release will include updated i18n files as well as any bug fixes. No new features will be back-ported to point releases and support doesn't include extensions in general, see below (e.g. Extension:UniversalLanguageSelector doesn't support current LTS)." [21:20:55] (03CR) 10Raimond Spekking: [C: 032] Migrate to JSON i18n [extensions/RelatedSites] - 10https://gerrit.wikimedia.org/r/121844 (owner: 10Siebrand) [21:21:05] ah; that's the bit that I was looking for [21:21:07] (03CR) 10Bartosz Dziewoński: mediawiki.api.category: Deprecate getCategories() 'async' parameter (031 comment) [core] - 10https://gerrit.wikimedia.org/r/118732 (owner: 10Bartosz Dziewoński) [21:21:12] yeah, it's kinda buried [21:21:16] (03CR) 10Raimond Spekking: [C: 032] Migrate to JSON i18n [extensions/RSS] - 10https://gerrit.wikimedia.org/r/121845 (owner: 10Siebrand) [21:21:18] (03Merged) 10jenkins-bot: Migrate to JSON i18n [extensions/RandomRootPage] - 10https://gerrit.wikimedia.org/r/121841 (owner: 10Siebrand) [21:21:20] (03Merged) 10jenkins-bot: Migrate to JSON i18n [extensions/RelatedArticles] - 10https://gerrit.wikimedia.org/r/121843 (owner: 10Siebrand) [21:21:22] (03Merged) 10jenkins-bot: Migrate to JSON i18n [extensions/RelatedSites] - 10https://gerrit.wikimedia.org/r/121844 (owner: 10Siebrand) [21:21:24] (03PS7) 10Bartosz Dziewoński: mediawiki.api.category: Deprecate getCategories() 'async' parameter [core] - 10https://gerrit.wikimedia.org/r/118732 [21:21:26] (03PS5) 10Bartosz Dziewoński: mediawiki.api: Remove deprecated function parameters [core] - 10https://gerrit.wikimedia.org/r/118733 [21:21:27] shush siebrand [21:21:31] ;) [21:21:39] (03CR) 10Raimond Spekking: [C: 032] Migrate to JSON i18n [extensions/Scribunto] - 10https://gerrit.wikimedia.org/r/121848 (owner: 10Siebrand) [21:21:50] (03CR) 10Raimond Spekking: [C: 032] Migrate to JSON i18n [extensions/Score] - 10https://gerrit.wikimedia.org/r/121850 (owner: 10Siebrand) [21:21:51] siebrand: nvm, was mostly jenkins ;) [21:21:54] * mwalker grumbles about thursday; meaning I'll have to update the payments cluster on the monday [21:22:06] (03CR) 10Raimond Spekking: [C: 032] Migrate to JSON i18n [extensions/Poem] - 10https://gerrit.wikimedia.org/r/121835 (owner: 10Siebrand) [21:22:09] greg-g: Hmm? [21:22:18] siebrand: grrrit-wm spam with your name :) [21:22:19] greg-g: I can be more quiet, if you do the migration work? [21:22:24] (03Merged) 10jenkins-bot: Migrate to JSON i18n [extensions/RSS] - 10https://gerrit.wikimedia.org/r/121845 (owner: 10Siebrand) [21:22:26] nah, it's cool [21:22:30] siebrand: I lov eit [21:22:31] Thought so... [21:22:36] just wanted a reason to ping you [21:22:42] ;) [21:23:43] (03Merged) 10jenkins-bot: Migrate to JSON i18n [extensions/Score] - 10https://gerrit.wikimedia.org/r/121850 (owner: 10Siebrand) [21:24:15] (03Merged) 10jenkins-bot: Migrate to JSON i18n [extensions/Poem] - 10https://gerrit.wikimedia.org/r/121835 (owner: 10Siebrand) [21:25:06] (03CR) 10Bartosz Dziewoński: [C: 032] jquery.color.test: Use fake timers [core] - 10https://gerrit.wikimedia.org/r/117150 (owner: 10Krinkle) [21:25:54] (03Merged) 10jenkins-bot: Migrate to JSON i18n [extensions/Scribunto] - 10https://gerrit.wikimedia.org/r/121848 (owner: 10Siebrand) [21:26:30] (03CR) 10Siebrand: [V: 032] "Bypassing Jenkins." [extensions/ProofreadPage] - 10https://gerrit.wikimedia.org/r/121839 (owner: 10Siebrand) [21:27:22] (03PS3) 10Jdlrobson: Hygiene: Reorganise the repository by beta feature [extensions/VectorBeta] - 10https://gerrit.wikimedia.org/r/120147 [21:27:24] (03PS7) 10Jdlrobson: Hygiene: Cleanup VectorBeta.php resources [extensions/VectorBeta] - 10https://gerrit.wikimedia.org/r/119904 [21:27:26] (03PS1) 10Jdlrobson: Remove graduated aspects of the typography beta feature [extensions/VectorBeta] - 10https://gerrit.wikimedia.org/r/121857 [21:27:42] (03PS1) 10Siebrand: Migrate to JSON i18n [extensions/SearchExtraNS] - 10https://gerrit.wikimedia.org/r/121858 [21:28:33] (03PS1) 10Siebrand: Migrate to JSON i18n [extensions/SecurePoll] - 10https://gerrit.wikimedia.org/r/121859 [21:28:44] (03Merged) 10jenkins-bot: jquery.color.test: Use fake timers [core] - 10https://gerrit.wikimedia.org/r/117150 (owner: 10Krinkle) [21:29:40] (03CR) 10MarkTraceur: [C: 04-1] Add a whitelisting functionality for registrant hooks (031 comment) [extensions/BetaFeatures] - 10https://gerrit.wikimedia.org/r/117630 (owner: 10Jforrester) [21:29:50] (03PS1) 10Siebrand: Migrate to JSON i18n [extensions/ShortUrl] - 10https://gerrit.wikimedia.org/r/121860 [21:30:39] (03PS1) 10Siebrand: Migrate to JSON i18n [extensions/SiteMatrix] - 10https://gerrit.wikimedia.org/r/121861 [21:31:58] (03PS1) 10Siebrand: Migrate to JSON i18n [extensions/Solarium] - 10https://gerrit.wikimedia.org/r/121863 [21:32:40] (03PS1) 10Siebrand: Migrate to JSON i18n [extensions/SpamBlacklist] - 10https://gerrit.wikimedia.org/r/121864 [21:33:07] (03PS1) 10Jdlrobson: Rename beta feature [extensions/VectorBeta] - 10https://gerrit.wikimedia.org/r/121865 [21:33:28] (03CR) 10Parent5446: [V: 032] Set ThrottledError's response code to 429 [core] - 10https://gerrit.wikimedia.org/r/120765 (owner: 10Faidon Liambotis) [21:34:15] (03CR) 10Bartosz Dziewoński: [C: 032] jquery.makeCollapsible.test: Use fake timers to advance animations [core] - 10https://gerrit.wikimedia.org/r/117153 (owner: 10Krinkle) [21:34:23] (03PS3) 10TheDJ: Improve the CodeEditor toolbar [extensions/CodeEditor] - 10https://gerrit.wikimedia.org/r/118993 [21:34:31] (03PS1) 10Siebrand: Migrate to JSON i18n [extensions/StrategyWiki] - 10https://gerrit.wikimedia.org/r/121867 [21:35:20] (03PS1) 10Siebrand: Migrate to JSON i18n [extensions/SubPageList3] - 10https://gerrit.wikimedia.org/r/121869 [21:35:26] (03CR) 10Bartosz Dziewoński: [C: 032] Hygiene: Cleanup VectorBeta.php resources [extensions/VectorBeta] - 10https://gerrit.wikimedia.org/r/119904 (owner: 10Jdlrobson) [21:35:35] (03PS2) 10Bsitu: No longer need the try-catch fallback; getRootPost will always resolve [extensions/Flow] - 10https://gerrit.wikimedia.org/r/121384 (owner: 10Matthias Mullie) [21:35:45] (03Merged) 10jenkins-bot: Hygiene: Cleanup VectorBeta.php resources [extensions/VectorBeta] - 10https://gerrit.wikimedia.org/r/119904 (owner: 10Jdlrobson) [21:35:51] thanks MatmaRex :D [21:36:15] (03CR) 10Bsitu: [C: 032] No longer need the try-catch fallback; getRootPost will always resolve [extensions/Flow] - 10https://gerrit.wikimedia.org/r/121384 (owner: 10Matthias Mullie) [21:36:29] (03Merged) 10jenkins-bot: No longer need the try-catch fallback; getRootPost will always resolve [extensions/Flow] - 10https://gerrit.wikimedia.org/r/121384 (owner: 10Matthias Mullie) [21:36:40] (03PS1) 10Siebrand: Migrate to JSON i18n [extensions/SubpageSortkey] - 10https://gerrit.wikimedia.org/r/121870 [21:37:46] (03PS1) 10Siebrand: Migrate to JSON i18n [extensions/SwiftCloudFiles] - 10https://gerrit.wikimedia.org/r/121871 [21:37:57] (03Merged) 10jenkins-bot: jquery.makeCollapsible.test: Use fake timers to advance animations [core] - 10https://gerrit.wikimedia.org/r/117153 (owner: 10Krinkle) [21:39:18] (03PS1) 10Siebrand: Migrate to JSON i18n [extensions/SyntaxHighlight_GeSHi] - 10https://gerrit.wikimedia.org/r/121872 [21:39:50] (03CR) 10Bartosz Dziewoński: [C: 032] "I assume that you've verified that all resources still load in normal and debug mode :)" [extensions/VectorBeta] - 10https://gerrit.wikimedia.org/r/120147 (owner: 10Jdlrobson) [21:39:55] (03Merged) 10jenkins-bot: Hygiene: Reorganise the repository by beta feature [extensions/VectorBeta] - 10https://gerrit.wikimedia.org/r/120147 (owner: 10Jdlrobson) [21:40:00] (03CR) 10Parent5446: [V: 032] Allow to optionally set language in Message constructor [core] - 10https://gerrit.wikimedia.org/r/121113 (owner: 10Aude) [21:40:01] jdlrobson: you did, didn't you? :> [21:41:55] (03CR) 10Bartosz Dziewoński: [C: 032] Remove graduated aspects of the typography beta feature [extensions/VectorBeta] - 10https://gerrit.wikimedia.org/r/121857 (owner: 10Jdlrobson) [21:41:59] (03Merged) 10jenkins-bot: Remove graduated aspects of the typography beta feature [extensions/VectorBeta] - 10https://gerrit.wikimedia.org/r/121857 (owner: 10Jdlrobson) [21:43:01] (03CR) 10Parent5446: [V: 032] Add getLanguage method to Message [core] - 10https://gerrit.wikimedia.org/r/121118 (owner: 10Aude) [21:43:35] (03CR) 10Jforrester: Add a whitelisting functionality for registrant hooks (031 comment) [extensions/BetaFeatures] - 10https://gerrit.wikimedia.org/r/117630 (owner: 10Jforrester) [21:44:00] (03PS5) 10Jforrester: Add a whitelisting functionality for registrant hooks [extensions/BetaFeatures] - 10https://gerrit.wikimedia.org/r/117630 [21:46:10] csteipp, re mobile tokens: do you want to just log mobile tokens as taken from session? [21:48:22] (03CR) 10Siebrand: [C: 031] "L10n reviewed." [extensions/VectorBeta] - 10https://gerrit.wikimedia.org/r/121865 (owner: 10Jdlrobson) [21:56:23] (03PS1) 10Jforrester: Remove the "About Beta Features" and "discuss Beta Features" links [extensions/BetaFeatures] - 10https://gerrit.wikimedia.org/r/121876 [21:56:25] (03CR) 10jenkins-bot: [V: 04-1] Remove the "About Beta Features" and "discuss Beta Features" links [extensions/BetaFeatures] - 10https://gerrit.wikimedia.org/r/121876 (owner: 10Jforrester) [21:57:23] (03CR) 10EBernhardson: Refactor Flow\\Formatter namespace (036 comments) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/117384 (owner: 10EBernhardson) [21:58:32] (03CR) 10Hashar: "Siebrand, all those jshint errors are due to bug https://bugzilla.wikimedia.org/show_bug.cgi?id=52456 which I am no more attending to atte" [extensions/ProofreadPage] - 10https://gerrit.wikimedia.org/r/121839 (owner: 10Siebrand) [21:58:35] (03PS21) 10EBernhardson: Refactor Flow\\Formatter namespace [extensions/Flow] - 10https://gerrit.wikimedia.org/r/117384 [21:58:38] (03PS2) 10EBernhardson: Standardize URL generation [extensions/Flow] - 10https://gerrit.wikimedia.org/r/121855 [21:58:41] (03CR) 10jenkins-bot: [V: 04-1] Refactor Flow\\Formatter namespace [extensions/Flow] - 10https://gerrit.wikimedia.org/r/117384 (owner: 10EBernhardson) [21:58:44] (03CR) 10jenkins-bot: [V: 04-1] Standardize URL generation [extensions/Flow] - 10https://gerrit.wikimedia.org/r/121855 (owner: 10EBernhardson) [21:58:47] (03CR) 10Nemo bis: [C: 04-1] "Ok, the general situation is confusing, but this patch is actually very simple and straightforward if one looks at equivset.php: we're not" (032 comments) [extensions/AntiSpoof] - 10https://gerrit.wikimedia.org/r/92057 (owner: 10Kaldari) [21:59:18] (03Abandoned) 10Gilles: Gives extensions the ability to output inline head scripts [core] - 10https://gerrit.wikimedia.org/r/121606 (owner: 10Gilles) [21:59:45] (03CR) 10Siebrand: "Yeah. I guess the extension maintainers will take care of that. I've got 400 more extensions to migrate to JSON i18n." [extensions/ProofreadPage] - 10https://gerrit.wikimedia.org/r/121839 (owner: 10Siebrand) [21:59:55] (03CR) 10Nemo bis: "Ah, I forgot one source backing the statement on L vs. I i l:" [extensions/AntiSpoof] - 10https://gerrit.wikimedia.org/r/92057 (owner: 10Kaldari) [22:00:38] ^d: Are you still the one creating new Gerrit repos? Or is that someone else? [22:01:43] <^d> siebrand: Christian usually handles it but I certainly can. What's up? [22:02:04] (03CR) 10Siebrand: [C: 04-1] "Pretty sure you didn't update your local clone before making i18n changes." [extensions/BetaFeatures] - 10https://gerrit.wikimedia.org/r/121876 (owner: 10Jforrester) [22:02:14] ^d: I thought we're doing that jointly :-) [22:02:33] ^d: There are a few problematic repos that I make exceptions for at twn. I was wondering if there is a solution a little closer to the source for them. [22:02:33] <^d> I've been slacking :p [22:02:40] ^d: curl -s "https://gerrit.wikimedia.org/mediawiki-extensions.txt"|egrep -v "(FundraisingEmailUnsubscribe|DataValuesCommon|ShortUrlApi|^Wikidata$|WikibaseClient|WikibaseLib|WikibaseRepo) [22:03:09] ^d: I think some of them could be deleted, as they'll never be populated. [22:03:15] qchris: might be related, but could i bug you to also `git gc --aggressive` some repos, particularly core? Its up to a 450MiB download but <200M after gc [22:03:29] (for fresh clone) [22:03:43] <^d> ebernhardson: no. [22:03:52] <^d> we run jgit gc weekly. [22:04:09] ^d: hmm, i wonder why its double the necessary size then [22:04:55] <^d> lez see. [22:05:05] <^d> siebrand: What's wrong with them? [22:05:38] ^d: I haven't looked into the details of others than ShortUrlApi in a long time, but I'll go from there though the list. [22:05:40] <^d> ebernhardson: I'm totally fine with trying to improve performance but git gc has hosed me before ;-) [22:05:57] (03PS1) 10Jforrester: Migrate to JSON i18n [extensions/BetaFeatures] - 10https://gerrit.wikimedia.org/r/121877 [22:05:59] (03CR) 10jenkins-bot: [V: 04-1] Migrate to JSON i18n [extensions/BetaFeatures] - 10https://gerrit.wikimedia.org/r/121877 (owner: 10Jforrester) [22:05:59] ^d: understandable :) perhaps i'm too trusting of its man page [22:06:02] ^d: ShortUrlApi is completely empty. It should have gotten at least a .gitreview at creation. Correct? [22:06:42] siebrand: No [22:06:47] siebrand: https://www.mediawiki.org/wiki/Git/New_repositories/Requests [22:06:57] siebrand: search for ShortUrlApi [22:07:10] The comment column explains why it is completely empty [22:07:29] <^d> ebernhardson: It does scary things! [22:07:33] (03CR) 10Aude: "i don't have complete knowledge of extension internals, but see comments for what could be made more clear, etc." (032 comments) [extensions/BetaFeatures] - 10https://gerrit.wikimedia.org/r/117630 (owner: 10Jforrester) [22:07:36] danorton said that he can do the initial commit. [22:07:48] <^d> ebernhardson: It's sort of a wrapper for a highly destructive git-repack [22:07:49] So I let him do that if he wants to. [22:07:53] Hmm. Having this as empty repos in mediawiki-extensions.txt creates a problem in our workflow. [22:07:58] Our scripts bail out. [22:08:08] <^d> `git repack -a -d -f` with various depths and windows. [22:08:22] siebrand: We'll always have empty repos. [22:08:34] siebrand: Some people are requesting us to create them completely empty. [22:08:49] <^d> Maybe we can make the script smarter about skipping empty repos. [22:08:50] Should they remain empty indefinitely? [22:08:56] <^d> No, not forever. [22:09:07] <^d> empty forever == abandoned [22:09:27] DataValuesCommon has been existing for quite a while, for example. [22:09:32] That looks abandoned. [22:09:51] <^d> ebernhardson: [22:09:53] <^d> demon@ytterbium:/var/lib/gerrit2/review_site/git/mediawiki/core.git$ du -sh . [22:09:53] <^d> 1.1G . [22:09:53] <^d> demon@ytterbium:/var/lib/gerrit2/review_site/git/mediawiki/core.git$ du -sh . [22:09:55] <^d> 629M . [22:09:57] <^d> Better? [22:09:57] (03PS22) 10EBernhardson: Refactor Flow\\Formatter namespace [extensions/Flow] - 10https://gerrit.wikimedia.org/r/117384 [22:09:59] <^d> :) [22:10:00] (03PS3) 10EBernhardson: Standardize URL generation [extensions/Flow] - 10https://gerrit.wikimedia.org/r/121855 [22:10:04] (03CR) 10MarkTraceur: "I think this is a flat array." [extensions/BetaFeatures] - 10https://gerrit.wikimedia.org/r/117630 (owner: 10Jforrester) [22:10:06] MatmaRex: interestingly debug=true works for me locally but gets messed up on beta labs.. exploring! [22:10:18] (03CR) 10jenkins-bot: [V: 04-1] Standardize URL generation [extensions/Flow] - 10https://gerrit.wikimedia.org/r/121855 (owner: 10EBernhardson) [22:10:32] ^d: probably :) i'll try a fresh clone from labs. [22:10:35] siebrand: I thnk that has a history of being empty for a reason. Let try to find it... [22:10:41] jdlrobson: oh. huh [22:10:57] MatmaRex: it's only enabled on beta labs so far so this is not the end of the world http://en.wikipedia.beta.wmflabs.org/wiki/Main_Page?debug=true [22:11:00] <^d> ebernhardson: remember, your local clone size will vary based on how well your git repacked it...which isn't always fantastic after a clone of a huge repo. [22:11:11] <^d> repacking/gc'ing after clone for core's not a bad idea. [22:11:17] ^d: i wasn't really worried about local size, but download size. i had to download 450M over the internet to get a clone [22:11:27] <^d> core's too big :( [22:11:48] <^d> I'm tempted to fork it in a way into two repos. [22:11:58] MatmaRex: you know what would be useful - a RL mode which doesn't load gadgets and common.css [22:12:25] can do more than two ;) [22:12:42] (03CR) 10Kaldari: "I think mapping l (lowercase L) to I (uppercase I) would cause problems. If we did that, you could then circumvent any prohibited string c" [extensions/AntiSpoof] - 10https://gerrit.wikimedia.org/r/92057 (owner: 10Kaldari) [22:12:43] ^d: like what, alphabetically? [22:12:51] (03PS2) 10Bsitu: Don't escape the userlinks displayed in "This topic was suppressed by " [extensions/Flow] - 10https://gerrit.wikimedia.org/r/121385 (owner: 10Matthias Mullie) [22:12:53] jdlrobson: heh [22:13:00] siebrand: Darn. I cannot find it. [22:13:01] <^d> MatmaRex: no, that'd be silly :) [22:13:14] <^d> No, we'd cut off all of the pre-git history into a "historical" repo. [22:13:18] don't see what would you want to fork off :P [22:13:19] ah, hm [22:13:25] siebrand: But regardless of the number of repos that we fix ... tomorrow there'll be empty repos again. [22:13:30] a fresh clone from labs was still 450M downloaded (at least its 15MB/s) from https://gerrit.wikimedia.org/r/p/mediawiki/core.git [22:13:31] bleh, i git-blame into that way too often :( [22:13:33] oh well, not a big worry [22:13:55] siebrand: People want them. Can we get your script to ignore empty repos? [22:14:21] qchris: I don't have one, which is the problem. [22:14:37] qchris: I run into a production error, then have to add the repo to an exception list. [22:14:59] qchris: It doesn't happen often, but if I can avoid the blocker, I'd be happy about that. [22:15:11] <^d> MatmaRex: Yeah, but if you used something like git-replace you could stitch the two repos together and preserve history. [22:15:21] <^d> So if you wanted the *full* history for digging, you can. [22:15:24] siebrand: Can we fix the production error that you're talking about to ignore empty repos? [22:15:33] siebrand: How does it look like? [22:15:34] <^d> But for quick day to day stuff it'll be a bajillion times faster. [22:15:56] qchris: The update script exits when updating. [22:16:00] MaxSem: Yeah, basically both sides of that inequality [22:16:07] ^d: i thought that can only be done for branches [22:16:21] hm, i suppose i could copy the other repo into a branch in the main one [22:16:34] but that seems painful [22:16:47] is Gerrit unable to handle 300 MB of repo history? seriously? [22:16:48] siebrand: (Sorry to ask the stupid question) which update script exactly? [22:16:50] qchris: Hmm. I think I may have created a work-around for it on Linux, just not on Windows. [22:16:53] that's not even a lot [22:17:30] I love these too, btw... [22:17:31] efrror: RPC failed; result=7, HTTP code = 0 [22:17:32] atal: The remote end hung up unexpectedly [22:17:36] siebrand: ok. I am not too much use on Windows. [22:17:37] Wonderful... [22:17:52] :-/ [22:18:38] (03CR) 10Bsitu: Don't escape the userlinks displayed in "This topic was suppressed by " (031 comment) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/121385 (owner: 10Matthias Mullie) [22:18:43] (03PS6) 10Jforrester: Add a whitelisting functionality for registrant hooks [extensions/BetaFeatures] - 10https://gerrit.wikimedia.org/r/117630 [22:18:46] (03CR) 10Jforrester: Add a whitelisting functionality for registrant hooks (032 comments) [extensions/BetaFeatures] - 10https://gerrit.wikimedia.org/r/117630 (owner: 10Jforrester) [22:18:52] <^d> MatmaRex: It's not that Gerrit doesn't. [22:19:02] <^d> It's that transferring 300MB is a lot of bullshit for most people. [22:19:08] qchris: This script actually works pretty nicely: http://git.wikimedia.org/blob/translatewiki.git/HEAD/bin%2Fwikiupdate-repo [22:19:12] (03CR) 10EBernhardson: [C: 04-1] "would prefer to base the patch ontop of the formatter refactor" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/121385 (owner: 10Matthias Mullie) [22:19:21] ^d: these people should use shallow clones then, no? [22:19:39] qchris: There 1 retry because of the many known connection errors with Gerrit. If it fails twice, it skips updating that repo. [22:19:52] git clone doc's claim you can't use a shallow clone for submitting branches, but i dont know what it really does [22:21:03] siebrand: I guess I am just missing the wood looking at trees ... but 1 retry? Where. Isn't there just a single call to git in that file? [22:21:12] qchris: sorry, wrong script. It's http://git.wikimedia.org/blob/translatewiki.git/02ac4598f98306c4df681594be0f7a338a19ed49/bin%2Fupdate-reset-repo [22:21:52] <^d> ebernhardson, MatmaRex: basically a shallow clone starts to become difficult to work with pretty quickly if you want to use various branches and history. [22:21:58] ebernhardson: i was under the impression that you can… [22:22:00] siebrand: Thanks. [22:22:01] * MatmaRex tries [22:22:02] <^d> So you end up having to convert it to a full clone & transfer the crap anyway [22:22:10] csteipp, https://gerrit.wikimedia.org/r/121879 ? [22:22:37] qchris: That's used from http://git.wikimedia.org/blob/translatewiki.git/HEAD/bin%2Frepoupdate#L196 [22:22:59] qchris: We're running 7 simultaneously. [22:22:59] (03CR) 10MarkTraceur: [C: 032] "Thanks, James, for navigating the nastiness for us. We would be lost without you." [extensions/BetaFeatures] - 10https://gerrit.wikimedia.org/r/117630 (owner: 10Jforrester) [22:23:04] (03Merged) 10jenkins-bot: Add a whitelisting functionality for registrant hooks [extensions/BetaFeatures] - 10https://gerrit.wikimedia.org/r/117630 (owner: 10Jforrester) [22:23:10] * James_F hugs marktraceur. [22:23:31] ebernhardson: i was able to push from a shallow clone just fine using git 1.9.0 [22:23:37] ^d: ^ [22:23:39] MaxSem: That would be helpful, thanks! [22:23:56] siebrand: Mhmm. Ok. [22:24:01] (that was pushing locally, to a remote using the file:// protocol) [22:24:07] qchris: "Mhmm."? [22:24:23] ^d: you're not very convincing. :) [22:24:35] siebrand: I guess the issue is that origin/master not existing is the problem. [22:24:46] siebrand: You could check beforlehand whether or not that exists [22:24:56] siebrand: If it does not exist, then no need to update. [22:25:23] qchris: Okay. What's a safe way to check if that branch exists? [22:26:24] siebrand: ls-remote should do the trick [22:27:04] siebrand: E.g.: git ls-remote http://gerrit.wikimedia.org/r/mediawiki/extensions/DataValuesCommon refs/heads/master [22:27:12] siebrand: is empty [22:27:22] siebrand: git ls-remote http://gerrit.wikimedia.org/r/mediawiki/extensions/Echo refs/heads/master [22:27:30] siebrand: is not empty [22:27:48] qchris: Hmm. That's more queries at the remote, isn't it? [22:28:27] siebrand: An additional query at the remote. Yes. [22:28:28] <^d> MatmaRex: I shall...find stats! [22:28:48] siebrand: But you can do that before the fetch. [22:29:23] (03CR) 10EBernhardson: [C: 032] Update Makefile for Labs instances migrated to eqiad [extensions/Flow] - 10https://gerrit.wikimedia.org/r/120751 (owner: 10Spage) [22:29:36] (03Merged) 10jenkins-bot: Update Makefile for Labs instances migrated to eqiad [extensions/Flow] - 10https://gerrit.wikimedia.org/r/120751 (owner: 10Spage) [22:29:42] (03PS3) 10EBernhardson: Implement multiPut method. [extensions/Flow] - 10https://gerrit.wikimedia.org/r/120734 (owner: 10Werdna) [22:30:02] siebrand: The man page points me to --exit-code ... that looks even simpler. [22:31:38] <^d> Hmm, it's installer.i18n.php and maintenance/ExtraParserTests.txt that seem to take the most space in my packs. [22:31:48] siebrand: And bear in mind that it is only needed if no local master branch is present. So for most repos, you would not need it anyways. [22:32:33] qchris: So basically I need to check if "git ls-remote . refs/heads/master |grep -c 'refs/heads/master'" is greater or equal to 1 ? [22:34:23] siebrand: the "." repo is the local one. Whether or not that works depends on you do it before or after the fetch. [22:34:46] siebrand: If you want to do it before the fetch, you could do something like [22:34:57] (03CR) 10Krinkle: [C: 032] mediawiki.api.category: Deprecate getCategories() 'async' parameter [core] - 10https://gerrit.wikimedia.org/r/118732 (owner: 10Bartosz Dziewoński) [22:35:06] siebrand: git ls-remote --exit-code origin refs/heads/master [22:35:26] siebrand: That should have return code 2, if the gerrit does not have a master (=empty) [22:35:35] siebrand: And 0 if it has a master. [22:36:02] (03CR) 10Nemo bis: "Is that really a problem? It's not really "circumventing", it just means that to check for l you have to check for l. Aren't admins lowerc" [extensions/AntiSpoof] - 10https://gerrit.wikimedia.org/r/92057 (owner: 10Kaldari) [22:36:46] qchris: Okay, I get it. Thanks. [22:37:46] (03CR) 10Krinkle: [C: 032] "Published to Jenkins: 'mwext-Nostalgia-jslint', 'mwext-Nostalgia-lint', 'mwext-Nostalgia-phpcs-HEAD', 'mwext-Nostalgia-testextensions-mast" [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/121626 (owner: 10Siebrand) [22:38:24] (03Merged) 10jenkins-bot: Add Jenkins jobs for Nostalgia extension repo [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/121626 (owner: 10Siebrand) [22:38:28] (03Merged) 10jenkins-bot: mediawiki.api.category: Deprecate getCategories() 'async' parameter [core] - 10https://gerrit.wikimedia.org/r/118732 (owner: 10Bartosz Dziewoński) [22:40:25] (03CR) 10Siebrand: "James, this was already done in https://gerrit.wikimedia.org/r/#/c/120788/ a few days ago. What I meant in https://gerrit.wikimedia.org/r/" [extensions/BetaFeatures] - 10https://gerrit.wikimedia.org/r/121877 (owner: 10Jforrester) [22:40:31] (03Abandoned) 10Jforrester: Migrate to JSON i18n [extensions/BetaFeatures] - 10https://gerrit.wikimedia.org/r/121877 (owner: 10Jforrester) [22:42:48] (03PS3) 10Brian Wolff: Use rgba() for gallery caption background instead of opacity. [core] - 10https://gerrit.wikimedia.org/r/116227 [22:43:41] (03PS2) 10Jforrester: Remove the "About Beta Features" and "discuss Beta Features" links [extensions/BetaFeatures] - 10https://gerrit.wikimedia.org/r/121876 [22:43:57] (03CR) 10Jforrester: "PS2 is a rebase." [extensions/BetaFeatures] - 10https://gerrit.wikimedia.org/r/121876 (owner: 10Jforrester) [22:44:49] (03CR) 10Siebrand: [C: 031] "L10n changes reviewed." [extensions/BetaFeatures] - 10https://gerrit.wikimedia.org/r/121876 (owner: 10Jforrester) [22:47:25] (03CR) 10Brian Wolff: "I'm not sure it makes sense to rollback implicit automatic transactions (by which I mean the transactions from DBO_TRX) in case of excepti" [core] - 10https://gerrit.wikimedia.org/r/121402 (owner: 10Anomie) [22:50:35] (03CR) 10Swalling: [C: 032] "I assume you checked with Brandon and Jared? ;)" [extensions/VectorBeta] - 10https://gerrit.wikimedia.org/r/121865 (owner: 10Jdlrobson) [22:50:40] (03Merged) 10jenkins-bot: Rename beta feature [extensions/VectorBeta] - 10https://gerrit.wikimedia.org/r/121865 (owner: 10Jdlrobson) [22:52:31] (03PS3) 10Siebrand: Implemented changes for getting into translatewiki [extensions/BlueSpiceFoundation] - 10https://gerrit.wikimedia.org/r/121683 (owner: 10Smuggli) [22:53:27] (03CR) 10Siebrand: [C: 04-1] "L10n reviewed." (031 comment) [extensions/BlueSpiceFoundation] - 10https://gerrit.wikimedia.org/r/121680 (owner: 10Smuggli) [22:57:09] (03CR) 10Siebrand: [C: 04-1] "i18n/L10n reviewed." (034 comments) [extensions/BlueSpiceFoundation] - 10https://gerrit.wikimedia.org/r/121683 (owner: 10Smuggli) [22:57:33] (03CR) 10Siebrand: [C: 031] "i18n/L10n reviewed." [extensions/BlueSpiceFoundation] - 10https://gerrit.wikimedia.org/r/121684 (owner: 10Smuggli) [22:58:41] qchris: Thanks for the patch sets, Christian. I've added Niklas as reviewer. We'll probably get to them over the weekend. Time for bed now. Gutenacht :) [22:59:01] siebrand: Gutenacht :-) [23:00:47] (03CR) 10EBernhardson: [C: 04-1] Implement multiPut method. (0313 comments) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/120734 (owner: 10Werdna) [23:03:35] (03PS1) 10Chad: Protect against missing pages better [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/121888 [23:04:13] (03PS3) 10Siebrand: Add a dummy .jshintrc [extensions/OAuth] - 10https://gerrit.wikimedia.org/r/121696 (owner: 10Raimond Spekking) [23:04:24] (03CR) 10Siebrand: [C: 032] Add a dummy .jshintrc [extensions/OAuth] - 10https://gerrit.wikimedia.org/r/121696 (owner: 10Raimond Spekking) [23:04:29] (03Merged) 10jenkins-bot: Add a dummy .jshintrc [extensions/OAuth] - 10https://gerrit.wikimedia.org/r/121696 (owner: 10Raimond Spekking) [23:06:38] (03CR) 10Gilles: "This seems to have broken tests on our end: https://gerrit.wikimedia.org/r/#/c/121600/" [core] - 10https://gerrit.wikimedia.org/r/117150 (owner: 10Krinkle) [23:06:42] (03PS1) 10MaxSem: Revert "Migrate to JSON i18n" [extensions/MwEmbedSupport] - 10https://gerrit.wikimedia.org/r/121889 [23:06:44] (03CR) 10jenkins-bot: [V: 04-1] Revert "Migrate to JSON i18n" [extensions/MwEmbedSupport] - 10https://gerrit.wikimedia.org/r/121889 (owner: 10MaxSem) [23:07:08] (03PS2) 10MaxSem: Revert "Migrate to JSON i18n" [extensions/MwEmbedSupport] - 10https://gerrit.wikimedia.org/r/121889 [23:07:10] (03CR) 10jenkins-bot: [V: 04-1] Revert "Migrate to JSON i18n" [extensions/MwEmbedSupport] - 10https://gerrit.wikimedia.org/r/121889 (owner: 10MaxSem) [23:08:14] (03PS1) 10MaxSem: Revert "Localisation updates from https://translatewiki.net." [extensions/MwEmbedSupport] - 10https://gerrit.wikimedia.org/r/121890 [23:08:24] (03CR) 10MaxSem: [C: 032 V: 032] Revert "Localisation updates from https://translatewiki.net." [extensions/MwEmbedSupport] - 10https://gerrit.wikimedia.org/r/121890 (owner: 10MaxSem) [23:08:46] (03CR) 10MaxSem: "recheck" [extensions/MwEmbedSupport] - 10https://gerrit.wikimedia.org/r/121889 (owner: 10MaxSem) [23:09:04] (03CR) 10MaxSem: [C: 032] Revert "Migrate to JSON i18n" [extensions/MwEmbedSupport] - 10https://gerrit.wikimedia.org/r/121889 (owner: 10MaxSem) [23:09:07] (03Merged) 10jenkins-bot: Revert "Migrate to JSON i18n" [extensions/MwEmbedSupport] - 10https://gerrit.wikimedia.org/r/121889 (owner: 10MaxSem) [23:09:34] gawdd, this extension is horrrrible [23:10:23] (03CR) 10Gilles: "On desktop the issue can be seen on Chrome (the tests pass on Firefox)." [core] - 10https://gerrit.wikimedia.org/r/117150 (owner: 10Krinkle) [23:10:26] <^d> You know what's also horrible? [23:10:32] <^d> "Go" behavior in search. [23:10:36] Sing-along blogs. [23:10:37] <^d> I hate that. [23:10:46] (03CR) 10Siebrand: [C: 04-1] "L10n/i18n reviewed." (0313 comments) [extensions/BlueSpiceFoundation] - 10https://gerrit.wikimedia.org/r/121687 (owner: 10Smuggli) [23:10:49] MaxSem: Which extension? [23:10:58] MwEmbedSupport [23:11:18] <^d> "I'm feeling lucky" behavior by default. [23:11:54] <^d> Not even lucky. [23:11:56] (03CR) 10Siebrand: "One inline comment. Not sure." (031 comment) [extensions/BlueSpiceFoundation] - 10https://gerrit.wikimedia.org/r/121686 (owner: 10Smuggli) [23:12:07] <^d> Just shooting in the dark for the top-10 that happens to be exact title match [23:13:05] (03CR) 10Siebrand: [C: 04-1] "i18n/L10n reviewed." (031 comment) [extensions/BlueSpiceFoundation] - 10https://gerrit.wikimedia.org/r/121685 (owner: 10Smuggli) [23:13:37] ^d: it's for the usability! [23:14:05] If only we had any measure for the effects of those usability decisions made in 2009/2010 [23:14:29] <^d> No, it goes further back. [23:14:45] <^d> I want to go back and find who wrote "Go" vs. "Search" for monobook or w/e did it first. [23:14:50] <^d> I hate go. [23:15:01] searchlang [23:15:07] But only Usability Initiative made "Go" the default [23:15:19] (03CR) 10Siebrand: [C: 031] "i18n/L10n reviewed." [extensions/NukeDPL] - 10https://gerrit.wikimedia.org/r/121055 (owner: 10Luis Felipe Schenone) [23:15:39] <^d> Nemo_bis: Which was wrong. But go's bad by itself too. [23:15:45] (03CR) 10Siebrand: [C: 04-1] Merges and inits db schema, add special pages. [extensions/OpenBadges] - 10https://gerrit.wikimedia.org/r/120361 (owner: 10Chococookies) [23:15:54] * ^d doesn't like it [23:16:10] Bad but not totally wrong if you know what you're doing when using it [23:16:32] It doesn't make any sense on default MediaWiki without TitleKey, though [23:16:37] <^d> It's a feature for lazy power users that's baked into the search UI we give on every page. [23:18:06] (03PS3) 10Bsitu: Improve topic & post action menu [extensions/Flow] - 10https://gerrit.wikimedia.org/r/121707 [23:19:50] (03Abandoned) 10Siebrand: wfWarn() should NOT cause unit tests to fail [core] - 10https://gerrit.wikimedia.org/r/99648 (owner: 10saper) [23:20:53] (03Abandoned) 10Siebrand: (bug 31986) Add user namespace aliases for all genders and varieties [core] - 10https://gerrit.wikimedia.org/r/29761 (owner: 10Amire80) [23:20:55] (03PS2) 10TheDJ: Convert from show()/hide() to using classes [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/120472 [23:20:57] (03CR) 10jenkins-bot: [V: 04-1] Convert from show()/hide() to using classes [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/120472 (owner: 10TheDJ) [23:21:09] (03CR) 10Luis Felipe Schenone: [C: 032 V: 032] Various changes based on comments to my initial commit [extensions/NukeDPL] - 10https://gerrit.wikimedia.org/r/121055 (owner: 10Luis Felipe Schenone) [23:22:01] (03Abandoned) 10Siebrand: Use edit summaries when posting to user talk pages. [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/69033 (owner: 10Nischayn22) [23:23:02] (03Abandoned) 10Siebrand: (bug 2867) Sort interlanguage links. [core] - 10https://gerrit.wikimedia.org/r/24211 (owner: 10Tim Landscheidt) [23:24:15] (03CR) 10Siebrand: [C: 032 V: 032] "Per Jeroen and my own comments." [extensions/UIFeedback] - 10https://gerrit.wikimedia.org/r/50004 (owner: 10Lbenedix) [23:25:09] (03Abandoned) 10Siebrand: Add a variant without free-form text field [extensions/ArticleFeedbackv5] - 10https://gerrit.wikimedia.org/r/77138 (owner: 10Matthias Mullie) [23:25:34] (03Abandoned) 10Siebrand: Added MessageFormatter to keep up with latest SMW [extensions/ExternalData] - 10https://gerrit.wikimedia.org/r/77275 (owner: 10Rotsee) [23:26:13] (03PS3) 10TheDJ: Convert from show()/hide() to using classes [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/120472 [23:26:38] (03Abandoned) 10Siebrand: (bug 34496) Added line to watchlist tooltip displaying the difference in characters more/less. This makes the user interface more user friendly not everyone knows that a character is one byte. - added temporary variable to reduce line length - removed whi [core] - 10https://gerrit.wikimedia.org/r/65139 (owner: 10Clancer) [23:27:07] (03Abandoned) 10Siebrand: Fix exception on collection save [extensions/Collection] - 10https://gerrit.wikimedia.org/r/84435 (owner: 10saper) [23:27:44] (03Abandoned) 10Siebrand: Add a Special:Agora page with sample form. [extensions/Agora] - 10https://gerrit.wikimedia.org/r/87038 (owner: 10Spage) [23:28:00] (03Abandoned) 10Siebrand: Support using alternative tables in $wgSharedTables [core] - 10https://gerrit.wikimedia.org/r/65477 (owner: 10Liangent) [23:28:04] (03PS2) 10Chad: Protect against missing pages better [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/121888 [23:28:42] (03Abandoned) 10Siebrand: Add Russian grammar forms [extensions/WikimediaMessages] - 10https://gerrit.wikimedia.org/r/76709 (owner: 10Amire80) [23:30:54] (03CR) 10Manybubbles: [C: 032] Protect against missing pages better [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/121888 (owner: 10Chad) [23:30:59] (03Merged) 10jenkins-bot: Protect against missing pages better [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/121888 (owner: 10Chad) [23:31:41] (03CR) 10Siebrand: "Ehr... Is this thing implementing its own i18n loader or something?" [extensions/MwEmbedSupport] - 10https://gerrit.wikimedia.org/r/121889 (owner: 10MaxSem) [23:32:01] (03CR) 10TheDJ: "Yeah I also was not able to find what the problem was there. :(" [core] - 10https://gerrit.wikimedia.org/r/117808 (owner: 10TheDJ) [23:32:14] (03CR) 10MaxSem: "No, it's a home-brewed ResourceLoader:P" [extensions/MwEmbedSupport] - 10https://gerrit.wikimedia.org/r/121889 (owner: 10MaxSem) [23:35:49] (03PS1) 10Jdlrobson: Ensure compatibility with personal compact bar [extensions/VectorBeta] - 10https://gerrit.wikimedia.org/r/121894 [23:36:40] (03CR) 10Siebrand: "Ah, even better. Any ideas on how to teach this thing to use JSON files?" [extensions/MwEmbedSupport] - 10https://gerrit.wikimedia.org/r/121889 (owner: 10MaxSem) [23:37:49] MaxSem: Damn. First hurdle in JSON i18n migrations. I didn't know we had such a thing around. [23:37:53] (03PS1) 10Chad: Fix sloppy coding mistakes from 9e3fd38 [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/121895 [23:50:26] (03PS2) 10Chad: Fix sloppy coding mistakes from 9e3fd38 [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/121895 [23:51:08] (03CR) 10CSteipp: "At minimum there are the dom xss that matt pointed out. Totally fine to have this as a WIP in the repo, but this should go through a secur" [extensions/UIFeedback] - 10https://gerrit.wikimedia.org/r/50004 (owner: 10Lbenedix) [23:54:34] (03CR) 10TheDJ: [C: 04-1] wpSummaryLabel and wpSummary in one line with full width (032 comments) [core] - 10https://gerrit.wikimedia.org/r/118246 (owner: 10Gerrit Patch Uploader) [23:57:31] (03CR) 10TheDJ: [C: 04-1] "Yeah this is not cacheable like this (and even when made so, probably not desirable)." [core] - 10https://gerrit.wikimedia.org/r/108514 (owner: 10Gerrit Patch Uploader) [23:58:10] (03PS1) 10Divec: Testing infrastructure [services/cxserver] - 10https://gerrit.wikimedia.org/r/121899