[00:00:25] All non-voting errors fixed. I guess now this bug is done https://bugzilla.wikimedia.org/show_bug.cgi?id=61610 . Thanks MatmaRex: Krinkle :) [00:00:31] (03PS4) 10Nemo bis: [WIP] Make captcha.py produce images in arbitrary language [extensions/ConfirmEdit] - 10https://gerrit.wikimedia.org/r/121255 [00:01:08] (03CR) 10Nemo bis: [WIP] Make captcha.py produce images in arbitrary language (031 comment) [extensions/ConfirmEdit] - 10https://gerrit.wikimedia.org/r/121255 (owner: 10Nemo bis) [00:06:01] (03CR) 10Krinkle: [C: 04-1] "Thanks man, this is great." [extensions/LiquidThreads] - 10https://gerrit.wikimedia.org/r/121257 (owner: 10Adi.iiita) [00:06:37] zeek: Eh, the line is not commented out in the real code [00:06:47] Your code paste shows the extend() line commented out [00:06:53] Looking at https://gerrit.wikimedia.org/r/#/c/121257/4/jquery/jquery.thread_collapse.js [00:06:58] the line is not commented out there [00:07:04] Oops.. let me c [00:07:18] Why would you remove that argument and feature? Seems a bit odd. [00:08:11] I am little slow with js.. but I did it because the variable $settings was unused [00:08:38] Right, there's two steps [00:08:45] $settings is unused so you removed that [00:08:50] and then $options was unused [00:08:52] I see now [00:08:54] It's great :) [00:08:59] Ohh cool :) [00:12:07] (03CR) 10Mglaser: "Thanks a lot for finding and fixing!" [core] (REL1_22) - 10https://gerrit.wikimedia.org/r/110408 (owner: 10Se4598) [00:14:30] (03PS5) 10Adi.iiita: LiquidThreads should pass jshint [extensions/LiquidThreads] - 10https://gerrit.wikimedia.org/r/121257 [00:16:32] Krinkle: see now [00:18:19] (03CR) 10Krinkle: "See comments on Patch Set 4." (034 comments) [extensions/LiquidThreads] - 10https://gerrit.wikimedia.org/r/121257 (owner: 10Adi.iiita) [00:18:40] (03PS3) 10Kaldari: Typography update to Vector skin [core] - 10https://gerrit.wikimedia.org/r/120978 [00:21:54] * zeek is frustrated cause Gerrit keeps on working -_- [00:25:48] (03CR) 10Stepzhou: Tries to use wikilanguage cookie, HTTP request Accept Header, and then the get preferred variant in that order (034 comments) [core] - 10https://gerrit.wikimedia.org/r/120475 (owner: 10Stepzhou) [00:27:47] Krinkle: In case of mwSetupToolbar, see this http://www.8tiny.com/source/mediawiki/nav.html?_functions/index.html Do a Ctrl+F. I am not sure the source is realiable but I took a shot. [00:29:28] zeek: That's an old version [00:29:33] It was removed a couple versions ago [00:29:36] from wikibits.js [00:29:44] https://github.com/wikimedia/openzim/blob/5a9c2943f73c40a384938e51da55c3d0eef28f12/zimreader/src/wikibits_js.js#L357 [00:30:00] (found it by accident in another mirror, like 8tiny, openzim has an old copy) [00:30:05] Either way, this code is broken. [00:30:12] Then we can be sure that this function is useless here [00:30:21] mwSetupToolbar does not exist, calling it does throw, masking it is not wanted in this case. [00:30:26] Yep :) [00:30:31] Maybe do that in a separate commit before this one [00:30:42] Or leave this line broken for now, and do it in the commit after this one [00:30:48] sure [00:31:06] I'd do it first, so that your commit makes jshint passing [00:31:11] I'll merge it :) [00:32:24] You want me to make one commit first just removing that function? [00:35:39] superm401: hey, I seem to recall that you discovered that omitting the second parameter from setTimeout (to indicate a 0 timeout) breaks on some platforms. is that right? [00:36:04] (03PS1) 10Luis Felipe Schenone: Improved the QuestyCaptcha syntax for setting questions and answers [extensions/ConfirmEdit] - 10https://gerrit.wikimedia.org/r/121286 [00:36:26] Krinkle: ^ [00:36:48] (03PS4) 10Krinkle: Enable mediawiki-core-npm (runs jshint+jscs), disable mediawiki-core-jslint [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/116136 [00:36:55] (03PS1) 10Jdlrobson: Disable VectorBeta typography experiment [extensions/VectorBeta] - 10https://gerrit.wikimedia.org/r/121287 [00:36:59] (03CR) 10Krinkle: [C: 032] "Dependent change in mediawiki-core got merged." [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/116136 (owner: 10Krinkle) [00:37:04] (03CR) 10Jdlrobson: [C: 032] Typography update to Vector skin [core] - 10https://gerrit.wikimedia.org/r/120978 (owner: 10Kaldari) [00:37:54] (03Merged) 10jenkins-bot: Enable mediawiki-core-npm (runs jshint+jscs), disable mediawiki-core-jslint [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/116136 (owner: 10Krinkle) [00:39:04] (03CR) 10Kaldari: [C: 032] Disable VectorBeta typography experiment [extensions/VectorBeta] - 10https://gerrit.wikimedia.org/r/121287 (owner: 10Jdlrobson) [00:39:12] (03Merged) 10jenkins-bot: Disable VectorBeta typography experiment [extensions/VectorBeta] - 10https://gerrit.wikimedia.org/r/121287 (owner: 10Jdlrobson) [00:40:21] Krinkle: Ins't that code intentional regarding "mwSetupToolbar". As far as I see, the conditional statements are there to check if the version is an old one and use the function appropiately [00:41:26] (03Merged) 10jenkins-bot: Typography update to Vector skin [core] - 10https://gerrit.wikimedia.org/r/120978 (owner: 10Kaldari) [00:41:55] (03PS1) 10Jforrester: Update OOjs UI to v0.1.0-pre (e697490c9b) [core] - 10https://gerrit.wikimedia.org/r/121288 [00:47:16] (03CR) 10Brian Wolff: "Personally, I find the use of spaces instead of tabs in message files to be weird." [core] - 10https://gerrit.wikimedia.org/r/119658 (owner: 10Siebrand) [00:57:47] Krinkle: AFK? [00:59:29] (03PS2) 10Luis Felipe Schenone: Improved the QuestyCaptcha syntax for setting questions and answers [extensions/ConfirmEdit] - 10https://gerrit.wikimedia.org/r/121286 [01:02:39] (03PS6) 10Adi.iiita: LiquidThreads should pass jshint [extensions/LiquidThreads] - 10https://gerrit.wikimedia.org/r/121257 [01:02:43] (03PS6) 10Donyu: @donyu @stepzhou fifth iteration for persona sign up special page [extensions/Persona] - 10https://gerrit.wikimedia.org/r/112309 [01:02:45] (03CR) 10jenkins-bot: [V: 04-1] @donyu @stepzhou fifth iteration for persona sign up special page [extensions/Persona] - 10https://gerrit.wikimedia.org/r/112309 (owner: 10Donyu) [01:05:23] zeek: Hey [01:05:34] zeek: No, that code is conditional on whether WikiEditor (an optional plugin) is installed [01:05:39] not mediawiki version [01:05:57] If you use MediaWiki with LQT and without WikiEditor, it should hit that path [01:06:03] I made one more line space mistake... Have to fix it -_- [01:06:05] unless there is an additional conditional that I didn't see [01:06:25] Ohh, so what should be done finally? [01:07:03] I added it to the global whitelist in my last submit [01:09:19] (03PS7) 10Donyu: @donyu @stepzhou fifth iteration for persona sign up special page [extensions/Persona] - 10https://gerrit.wikimedia.org/r/112309 [01:09:21] (03CR) 10jenkins-bot: [V: 04-1] @donyu @stepzhou fifth iteration for persona sign up special page [extensions/Persona] - 10https://gerrit.wikimedia.org/r/112309 (owner: 10Donyu) [01:09:45] Krinkle: Should I remove it entirely? and refix the code including the conditional statements? [01:10:12] (03PS4) 10Stepzhou: Tries to use wikilanguage cookie, HTTP request Accept Header, and then the get preferred variant in that order [core] - 10https://gerrit.wikimedia.org/r/120475 [01:11:14] (03CR) 10jenkins-bot: [V: 04-1] Tries to use wikilanguage cookie, HTTP request Accept Header, and then the get preferred variant in that order [core] - 10https://gerrit.wikimedia.org/r/120475 (owner: 10Stepzhou) [01:13:28] (03PS8) 10Donyu: @donyu @stepzhou fifth iteration for persona sign up special page [extensions/Persona] - 10https://gerrit.wikimedia.org/r/112309 [01:16:48] zeek: Hm.. well, the code is there to populate the edit toolbar [01:16:55] without something doing that, people will get an empty toolbar I suppose [01:17:11] (03PS5) 10Stepzhou: Tries to use wikilanguage cookie, HTTP request Accept Header, and then the get preferred variant in that order [core] - 10https://gerrit.wikimedia.org/r/120475 [01:17:12] There should be a non-wikibits legacy version of that function that it was replaced with [01:17:51] (03CR) 10Spage: [C: 04-1] "It's getting there. Comment more and use LESS variables." (038 comments) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/119812 (owner: 10Bencmq) [01:18:18] Hmm... if we can be sure that function doesn't exist then I was sugestting of removing the condition check, not the entire block [01:19:14] Krinkle: If we cannot figure out for now, should I add comment "FIX IT" and upload it? [01:20:19] (03CR) 10Stepzhou: "Nikerabbit: I've been testing the language cookie portion using ULS with wgULSEnableAnon enabled already. Seems to work disabled as well (" [core] - 10https://gerrit.wikimedia.org/r/120475 (owner: 10Stepzhou) [01:23:06] ori, I remember us talking about the setTimeout thing, but I don't really remember [01:23:18] Sorry, "don't really remember the conclusion" [01:23:34] ori, http://stackoverflow.com/questions/2723610/settimeoutfun-with-a-single-argument-timeout-not-specified says all major browsers can handle omitting the second one (not sure what counts as 'major'). [01:24:39] ori, and it's unambiguously allowed by HTML5: http://www.w3.org/TR/2011/WD-html5-20110525/timers.html#timers [01:25:26] But Mozilla still says it's required (https://developer.mozilla.org/en-US/docs/Web/API/Window.setTimeout). However, it definitely can be omitted there in practice. [01:25:36] ori, so in summary, it's probably safe to drop it. [01:26:45] (03PS7) 10Adi.iiita: LiquidThreads should pass jshint [extensions/LiquidThreads] - 10https://gerrit.wikimedia.org/r/121257 [01:30:44] superm401: thanks for that! [01:30:54] ori, no problem. [01:35:23] marktraceur: fyi; I'm not coming. Maybe some other day :) [01:38:17] (03Abandoned) 10MarkAHershberger: Bug11269p1c [core] - 10https://gerrit.wikimedia.org/r/111259 (owner: 10Adi.iiita) [01:39:23] (03CR) 10MarkAHershberger: [C: 032] "issues are addressed and no one raised any new concerns." [extensions/LiquidThreads] - 10https://gerrit.wikimedia.org/r/118212 (owner: 10Adi.iiita) [01:39:25] (03Merged) 10jenkins-bot: Fixed padlock on thread history for LiquidThreads extension [extensions/LiquidThreads] - 10https://gerrit.wikimedia.org/r/118212 (owner: 10Adi.iiita) [01:39:38] (03PS2) 10Krinkle: Update OOjs UI to v0.1.0-pre (e697490c9b) [core] - 10https://gerrit.wikimedia.org/r/121288 (owner: 10Jforrester) [01:40:11] (03PS1) 10Luis Felipe Schenone: Changed
for
[core] (REL1_22) - 10https://gerrit.wikimedia.org/r/121291 [01:47:26] (03Abandoned) 10Luis Felipe Schenone: Changed
for
[core] (REL1_22) - 10https://gerrit.wikimedia.org/r/121291 (owner: 10Luis Felipe Schenone) [01:48:45] (03PS1) 10Luis Felipe Schenone: Changed
for
[core] - 10https://gerrit.wikimedia.org/r/121292 [01:49:03] Krinkle: I have uploaded PS. What is your suggestion on it? [02:01:40] (03CR) 10Krinkle: [C: 032] Update OOjs UI to v0.1.0-pre (e697490c9b) [core] - 10https://gerrit.wikimedia.org/r/121288 (owner: 10Jforrester) [02:05:33] (03Merged) 10jenkins-bot: Update OOjs UI to v0.1.0-pre (e697490c9b) [core] - 10https://gerrit.wikimedia.org/r/121288 (owner: 10Jforrester) [02:08:51] (03CR) 10Spage: [C: 04-1] "See my comments on the bug. Shahyar Ghobadpour agrees an additive approach is better rather than modifying mw-ui-button to remove everythi" [core] - 10https://gerrit.wikimedia.org/r/121101 (owner: 10Bencmq) [02:09:42] (03CR) 10Chad: "I'm mostly fine with this, other than what we talked about on IRC about the namespace bool filter not seeming to work." [extensions/GeoData] - 10https://gerrit.wikimedia.org/r/115413 (owner: 10MaxSem) [02:15:26] (03CR) 10SG: [C: 04-2] "We can't add classes that imply a design principle (eg. "light"). The new mw-ui classes are supposed to imply context only, and then the C" [core] - 10https://gerrit.wikimedia.org/r/121101 (owner: 10Bencmq) [02:19:10] (03PS2) 10Donyu: Merges and inits db schema, add special pages. [extensions/OpenBadges] - 10https://gerrit.wikimedia.org/r/120361 (owner: 10Chococookies) [02:24:20] (03PS3) 10Donyu: Merges and inits db schema, add special pages. [extensions/OpenBadges] - 10https://gerrit.wikimedia.org/r/120361 (owner: 10Chococookies) [02:46:35] (03PS4) 10Donyu: Merges and inits db schema, add special pages. [extensions/OpenBadges] - 10https://gerrit.wikimedia.org/r/120361 (owner: 10Chococookies) [03:05:05] (03CR) 10Donyu: "I just cleaned up the change request to remove the temporary files, rename the special page class conventions, and squash the previous com" [extensions/OpenBadges] - 10https://gerrit.wikimedia.org/r/120361 (owner: 10Chococookies) [03:13:55] (03CR) 10Mattflaschen: "I agree with Hashar. If there's some magic number of tests we can't exceed, that's a big problem (is that filed yet?)." (031 comment) [core] - 10https://gerrit.wikimedia.org/r/77645 (owner: 10Parent5446) [03:14:25] (03CR) 10Mattflaschen: "See previous comment." (031 comment) [core] - 10https://gerrit.wikimedia.org/r/77645 (owner: 10Parent5446) [03:26:52] (03CR) 10Greg Grossmeier: "https://bugzilla.wikimedia.org/show_bug.cgi?id=62623" [core] - 10https://gerrit.wikimedia.org/r/77645 (owner: 10Parent5446) [03:42:52] anyone happen to know who can add someone to a bugzilla component so that they automatically receive emails regarding bugs for that component? [03:47:43] (03PS1) 10Krinkle: mw.loader: Update addScript() to match latest jQuery [core] - 10https://gerrit.wikimedia.org/r/121298 [03:48:42] dan-nl: file a bug in the bugzilla component (under wikimedia) asking for it. andre__ processes them [03:49:05] "Please add $someone to default CC for $component" [03:49:05] thanks [03:49:25] np [03:53:28] (03PS1) 10Krinkle: mediawiki.util: Fix jsduck syntax and minor clean up [core] - 10https://gerrit.wikimedia.org/r/121299 [04:00:54] (03CR) 10Krinkle: [C: 04-1] Make generating Parser test class names more robust (031 comment) [core] - 10https://gerrit.wikimedia.org/r/67098 (owner: 10Brian Wolff) [04:02:00] Krinkle: Hmm, yeah I suppose you're right. I was thinking of the svn terminology where it was all one giant repo [04:03:05] (03PS6) 10Brian Wolff: Make generating Parser test class names more robust [core] - 10https://gerrit.wikimedia.org/r/67098 [04:03:49] (03CR) 10Krinkle: [C: 04-1] Make generating Parser test class names more robust (031 comment) [core] - 10https://gerrit.wikimedia.org/r/67098 (owner: 10Brian Wolff) [04:07:14] (03CR) 10Krinkle: Allow EventLogging events to be logged via mw#track (031 comment) [extensions/EventLogging] - 10https://gerrit.wikimedia.org/r/120757 (owner: 10Ori.livneh) [04:08:32] (03CR) 10Brian Wolff: Make generating Parser test class names more robust (031 comment) [core] - 10https://gerrit.wikimedia.org/r/67098 (owner: 10Brian Wolff) [04:14:42] (03PS7) 10Brian Wolff: Make generating Parser test class names more robust [core] - 10https://gerrit.wikimedia.org/r/67098 [04:19:20] (03PS1) 10Chad: Also include namespaces in memcached key [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/121300 [04:31:15] (03CR) 10Mattflaschen: [C: 032] "Semantically and visually correct" [extensions/GettingStarted] - 10https://gerrit.wikimedia.org/r/120776 (owner: 10Phuedx) [04:31:20] (03Merged) 10jenkins-bot: Don't use the deprecated mw-ui-primary CSS class [extensions/GettingStarted] - 10https://gerrit.wikimedia.org/r/120776 (owner: 10Phuedx) [04:35:56] (03PS1) 10Rahul mishra: UnknownAction hook not mentioned as deprecated in Wiki.php [core] - 10https://gerrit.wikimedia.org/r/121301 [05:16:56] (03PS3) 10Deepali: Fix label for publication date in json editor [extensions/BookManagerv2] - 10https://gerrit.wikimedia.org/r/120362 [05:18:19] (03CR) 10Deepali: "Fixed Commit message" [extensions/BookManagerv2] - 10https://gerrit.wikimedia.org/r/120362 (owner: 10Deepali) [05:37:57] (03PS1) 10Wctaiwan: Implement a redirector at Special:Flow [extensions/Flow] - 10https://gerrit.wikimedia.org/r/121306 [05:38:25] (03PS2) 10Wctaiwan: Implement a redirector at Special:Flow [extensions/Flow] - 10https://gerrit.wikimedia.org/r/121306 [05:40:08] (03PS1) 10Dan-nl: Correct the format of the wikitext output [extensions/GWToolset] - 10https://gerrit.wikimedia.org/r/121307 [05:45:54] hey bawolff, have you seen the patches i made to https://bugzilla.wikimedia.org/show_bug.cgi?id=62909 and https://bugzilla.wikimedia.org/show_bug.cgi?id=62870 ? [05:46:28] dan-nl: Yes I did (and thanks for doing that) [05:48:55] np [05:49:08] I was actually going to look at them today, but then got distracted by some other things (All the recent talk about 3d stuff made me want to fix up emw's extension). I'll try and look at those patches in the next couple days [05:49:12] are you okay with +2'ing if you're okay with them [05:49:26] cool, thanks [05:50:44] what is emw's extension? [05:52:08] Its to display pdb files (3D renderings of chemical molecules). He submitted it a while back, but didn't really get the help he needed with it, and he kind of lost interest and it ended up being abandoned [05:52:42] Which is sad, as he did do a lot of work to get part of the way there [05:53:19] Its at https://gerrit.wikimedia.org/r/#/c/46897/ if you're really curious [05:54:21] ori, are you there? I'm wondering if anyone is still using kubo. That's yours, right? [05:54:43] I haven't SSH'd into it in several forevers [05:55:03] sounds interesting … for now i'll save the link, thanks [05:55:05] I sort of figured it would go down with Tampa [05:55:23] ori, okay, I'll make a note at https://wikitech.wikimedia.org/wiki/Labs_Eqiad_Migration/Progress that we're not migrating it, if that's alright with you. [05:55:47] that's very nice of you; thanks [05:56:34] bawolff, thanks for all of your input on those 2 bugs. in the end your final comments on both of them helped me the most [05:57:17] Trevor cracked a joke in the office today about how we sound like we're casually planning the destruction of the city of Tampa [05:57:38] so I want to make it clear to all users of this channel: [05:57:42] we are, in fact. [05:57:45] dan-nl: Glad to help. I was worried I was coming off as pushy on the illegal characters one as I semi made the same comment 3 times [05:57:57] More like Tampa is going to be hit with some major disaster, but only we know about it. ;) [05:58:14] superm401: "look, buddy, all I'm saying is I'd sell that houseboat if I were you" [05:58:20] Tampa is going down, but we're ramping up in Real Viginia to prepare to carry the load. [05:58:30] i just ignored the repetition and tried to understand the detail as much as possible [05:59:01] the main goal for me is usually to find a solution that's best [05:59:11] dan-nl: that never works! [05:59:32] * ori stops trolling. [05:59:38] :) [06:00:20] (03PS1) 10MarkTraceur: Add model base class, description model [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/121308 [06:00:20] ori: Its right up there with documenting things, and separating logically distinct code into separate classes [06:00:29] crazy talk [06:03:01] ori (or anyone who knows), how long does it normally take for Puppet to run on a new instance? [06:03:11] Trying to guess if it's working normally or stalled. [06:03:17] Puppet status currently shows as unknown. [06:07:38] I have no idea. A lot of things have changed since I last provisioned an instance from scratch. [06:09:39] ori, no worries, it went to failed (much better!), and I realized I could ssh (was trying to do it from another instance, which didn't work) from my machine. [06:09:48] Will try re-running it, then hit this again tomorrow. [07:07:26] (03CR) 10Hashar: [C: 04-1] "Will split .gitignore after breakfast/bike commute/coffee." (032 comments) [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/121099 (owner: 10Siebrand) [07:11:30] prtksxna: so many bugs [07:11:53] somany! [07:12:03] booking a lot of tickets [07:12:07] we won't have an overlap :( [07:13:17] YuviPanda: ^ [07:13:31] prtksxna: 'tis ok [07:13:41] (03CR) 10Santhosh: [C: 032] Added config.js in .gitignore [services/cxserver] - 10https://gerrit.wikimedia.org/r/121054 (owner: 10KartikMistry) [07:13:43] (03Merged) 10jenkins-bot: Added config.js in .gitignore [services/cxserver] - 10https://gerrit.wikimedia.org/r/121054 (owner: 10KartikMistry) [07:13:45] prtksxna: I'll be back [07:30:21] About the bug fix 56522 [07:30:44] ]is it fine if I change error to error box while making the patch [07:30:52] https://bugzilla.wikimedia.org/show_bug.cgi?id=56522 [07:31:18] Also about the bug 56363 https://bugzilla.wikimedia.org/show_bug.cgi?id=56363 [07:31:38] do I need to change the form completely remove the frameset, tables and stuff [07:31:53] and turn the form into a vform like password reset page ? [07:33:00] https://gerrit.wikimedia.org/r/#/c/117854/ also could some one please merge this patch ? [07:33:19] prtksxna: https://secure.phabricator.com/project/board/773/ phabricator has a trello view [07:34:26] Some one please respond soon .. I have the scheduled power cut in 15 minutes :( [07:34:35] for 6 hours [07:36:40] (03CR) 10Mxn: [C: 04-1] "I ran into a couple issues getting this patch to work with Vietnamese. Otherwise, it looks good, thanks!" (032 comments) [extensions/ConfirmEdit] - 10https://gerrit.wikimedia.org/r/121255 (owner: 10Nemo bis) [07:48:59] (03PS2) 10Dan-nl: Correct the format of the wikitext output [extensions/GWToolset] - 10https://gerrit.wikimedia.org/r/121307 [07:52:54] (03CR) 10Dan-nl: "in ps2" [extensions/GWToolset] - 10https://gerrit.wikimedia.org/r/121307 (owner: 10Dan-nl) [07:53:47] (03CR) 10Ori.livneh: [C: 032] mw.loader: Update addScript() to match latest jQuery [core] - 10https://gerrit.wikimedia.org/r/121298 (owner: 10Krinkle) [07:54:36] (03CR) 10Ori.livneh: [C: 032] Sort version list returned by mwversionsinuse [tools/scap] - 10https://gerrit.wikimedia.org/r/120961 (owner: 10BryanDavis) [07:54:48] (03Merged) 10jenkins-bot: Sort version list returned by mwversionsinuse [tools/scap] - 10https://gerrit.wikimedia.org/r/120961 (owner: 10BryanDavis) [07:55:20] (03PS2) 10Ori.livneh: readme: Fix rendering of Markdown syntax [extensions/NavigationTiming] - 10https://gerrit.wikimedia.org/r/120967 (owner: 10Krinkle) [07:55:25] (03CR) 10Ori.livneh: [C: 032] "Much obliged!" [extensions/NavigationTiming] - 10https://gerrit.wikimedia.org/r/120967 (owner: 10Krinkle) [07:55:27] (03Merged) 10jenkins-bot: readme: Fix rendering of Markdown syntax [extensions/NavigationTiming] - 10https://gerrit.wikimedia.org/r/120967 (owner: 10Krinkle) [07:56:26] (03CR) 10Ori.livneh: [C: 04-1] "Still not quite right. I'll amend." [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/120737 (owner: 10MarkTraceur) [07:57:22] (03PS3) 10Ori.livneh: Fix EventLogging schema registry [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/120737 (owner: 10MarkTraceur) [07:57:49] (03Merged) 10jenkins-bot: mw.loader: Update addScript() to match latest jQuery [core] - 10https://gerrit.wikimedia.org/r/121298 (owner: 10Krinkle) [08:01:40] (03PS4) 10Ori.livneh: Fix EventLogging schema registry [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/120737 (owner: 10MarkTraceur) [08:03:22] (03PS2) 10Ori.livneh: Various minor code quality fixes and clean up [extensions/NavigationTiming] - 10https://gerrit.wikimedia.org/r/120973 (owner: 10Krinkle) [08:03:35] (03CR) 10Ori.livneh: [C: 032] Various minor code quality fixes and clean up [extensions/NavigationTiming] - 10https://gerrit.wikimedia.org/r/120973 (owner: 10Krinkle) [08:03:37] (03Merged) 10jenkins-bot: Various minor code quality fixes and clean up [extensions/NavigationTiming] - 10https://gerrit.wikimedia.org/r/120973 (owner: 10Krinkle) [08:04:57] (03CR) 10Siebrand: Make jslint non-voting for FlaggedRevs (031 comment) [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/121099 (owner: 10Siebrand) [08:05:47] (03PS6) 10Siebrand: Make jslint non-voting for FlaggedRevs [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/121099 [08:11:09] (03CR) 10Ori.livneh: [C: 032] Fix EventLogging schema registry [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/120737 (owner: 10MarkTraceur) [08:11:16] (03Merged) 10jenkins-bot: Fix EventLogging schema registry [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/120737 (owner: 10MarkTraceur) [08:36:25] liangent: around? have a few questions about variant support in the app I'd like to ask you [08:36:32] (and thank you for being so active in reporting bugs!) [08:38:13] YuviPanda: here [08:38:18] liangent: hello! [08:38:35] liangent: so, the API I am using in the app to retreive page content (action=mobileview) supports language variants. [08:39:11] liangent: so, my current plan is to have a separate entries in the 'languages' list for the chinese variants, and just request those if they are picked [08:39:17] liangent: and have that only for zh.wikipedia.org [08:39:24] liangent: is that a viable solution? [08:39:31] or is that too little? [08:40:39] YuviPanda: first it's not zhwiki only [08:41:05] a new section in language list looks consistent with mobilefrontend interface [08:41:50] liangent: if so, can you make me a list of wiki/variant combos I need to support, and what they should be called? [08:41:51] but I should note that if &variant= is not set, it defaults to user's option in Special:Preferences [08:42:04] liangent: oh. I'm not sure if mobileview respects that [08:43:23] YuviPanda: they don't "need" to respected that explicitly in code. userpref is globalized from $wgUser (this should be fixed as a code quality bug however) [08:43:31] s/respected/respect [08:43:36] liangent: ah, hmm. Right. [08:43:47] liangent: so in the app, if you log in, do you get the correct variant as set in your pref? [08:44:12] YuviPanda: let me check it now. actually I have conversion disabled in my userpref... [08:44:23] liangent: ok! :) [08:44:40] (03PS7) 10Krinkle: Make jslint non-voting for FlaggedRevs [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/121099 (owner: 10Siebrand) [08:45:33] YuviPanda: page contents are done correctly, but page titles are not [08:45:48] for the full list.. are you going to hardcode it? [08:45:55] or is it better to fetch that from api [08:46:16] liangent: yeah, was thinking of hardcoding it. [08:46:29] liangent: well, the language list right now is generated by a python script and included in the app [08:46:40] so I'll just include the list in the python script that generates the data. [08:46:51] YuviPanda: so what happens when a new wiki is created? [08:47:01] you have to publish a new app version? [08:47:25] liangent: yeah. our publish step runs the script, so when a new one is created it should automatically get added in the next push. [08:47:43] and our current plan is to have a public release once every two weeks (might change to once a month), so I think that's ok [08:48:46] YuviPanda: even after no new code gets committed? [08:49:01] ie when this new app becomes "the old app" in the future [08:49:19] liangent: heh. In that case we will push out a release when a new wiki gets added I suppose. [08:49:55] liangent: We can make it auto-update in the future too, via an API call. It just needs to be cached really really heavily, and I haven't gotten to writing that part yet [08:50:09] liangent: if you're concerned about that, you should file a bug. I'll note that this is also what the current app does. [08:52:32] liangent: I do agree it might be an issue if the new app gets less resources in the future. However, the current app team is 3 engineers, we've another one joining in a few months, and there's 2 more scheduled for next year, so I don't know if that'll happen again [08:52:34] fine but it's not high priority now - and when it becomes high priority: that means no one cares this app from code level at that time anymore, and it's likely this feature will be never added :p [08:52:50] liangent: in contrast, the old app was just... me. mostly. [08:53:18] YuviPanda: ok [08:53:18] liangent: https://bugzilla.wikimedia.org/show_bug.cgi?id=60743 has discussion about chinese variant handling [08:53:32] liangent: :) I know we've a terrible track record of updating old apps. [08:54:53] so btw there're some other edge cases like https://bugzilla.wikimedia.org/show_bug.cgi?id=62418 [08:55:45] https://www.mediawiki.org/wiki/LanguageConverter#LanguageConverter has a list [08:56:24] and an updated one should be fetchable by getting LanguageConverter::$languagesWithVariants first [08:57:09] liangent: yeah, saw that. I'll update the urls that get caught once we have variant handling in place. [08:57:11] then call https://zh.wikipedia.org/w/api.php?action=query&meta=siteinfo& [08:57:44] some variants that are supported in code may be disabled on site using $wgDisabledVariants [08:57:57] ah, hmm. [08:58:04] and the list returned from api call already has them excluded [08:59:07] liangent: cool. [08:59:23] liangent: and I guess I can pass the value of 'code' from that response to variant= [08:59:50] (03PS1) 10Netbrain: Added missing i18n key [extensions/SideBarMenu] - 10https://gerrit.wikimedia.org/r/121318 [09:00:02] (03CR) 10Netbrain: [C: 032 V: 032] Added missing i18n key [extensions/SideBarMenu] - 10https://gerrit.wikimedia.org/r/121318 (owner: 10Netbrain) [09:00:04] (03PS1) 10Siebrand: Migrate to JSON i18n [extensions/Flow] - 10https://gerrit.wikimedia.org/r/121319 [09:00:07] (03Merged) 10jenkins-bot: Added missing i18n key [extensions/SideBarMenu] - 10https://gerrit.wikimedia.org/r/121318 (owner: 10Netbrain) [09:00:11] YuviPanda: yeah and name="" is also configurable on site ([[MediaWiki:Variantname-zh-cn]]) [09:00:27] liangent: right, so I can use name= in the UI [09:00:34] and api returns current ones too [09:03:24] (03PS1) 10Siebrand: Migrate to JSON i18n [extensions/Gadgets] - 10https://gerrit.wikimedia.org/r/121322 [09:04:40] (03PS1) 10Siebrand: Migrate to JSON i18n [extensions/GeoCrumbs] - 10https://gerrit.wikimedia.org/r/121323 [09:04:41] liangent: mind if I add you as a reviewer when I do those patches? [09:04:42] (03CR) 10jenkins-bot: [V: 04-1] Migrate to JSON i18n [extensions/GeoCrumbs] - 10https://gerrit.wikimedia.org/r/121323 (owner: 10Siebrand) [09:05:56] YuviPanda: I don't feel annoyed to got those mails and notifications, but maybe I don't have time to actually review them in time [09:06:13] (03PS1) 10Siebrand: Migrate to JSON i18n [extensions/GeoData] - 10https://gerrit.wikimedia.org/r/121324 [09:06:35] liangent: hmm, ok :) [09:06:44] liangent: also what did you mean by 'content is converted fine but titles are not'? [09:06:49] you mean when searching? [09:07:45] (03PS1) 10Siebrand: Migrate to JSON i18n [extensions/GettingStarted] - 10https://gerrit.wikimedia.org/r/121325 [09:07:47] (03CR) 10jenkins-bot: [V: 04-1] Migrate to JSON i18n [extensions/GettingStarted] - 10https://gerrit.wikimedia.org/r/121325 (owner: 10Siebrand) [09:08:56] (03PS1) 10Siebrand: Migrate to JSON i18n [extensions/GlobalBlocking] - 10https://gerrit.wikimedia.org/r/121326 [09:10:18] (03PS1) 10Siebrand: Migrate to JSON i18n [extensions/GlobalUsage] - 10https://gerrit.wikimedia.org/r/121327 [09:12:02] (03PS1) 10Siebrand: Migrate to JSON i18n [extensions/GoogleNewsSitemap] - 10https://gerrit.wikimedia.org/r/121328 [09:13:54] YuviPanda: not converted when displayed in the first line of the article [09:14:05] (03PS1) 10Siebrand: Migrate to JSON i18n [extensions/GuidedTour] - 10https://gerrit.wikimedia.org/r/121329 [09:14:13] (03CR) 10jenkins-bot: [V: 04-1] Migrate to JSON i18n [extensions/GuidedTour] - 10https://gerrit.wikimedia.org/r/121329 (owner: 10Siebrand) [09:14:24] liangent: aah, right. I wonder if my redirect handling patch will fix that... [09:14:37] search result - yeah I did not notice that but desktop search suggestion is not handling it correctly either iirc [09:15:00] YuviPanda: why would the patch about redirect resolve conversion? [09:15:34] liangent: I was thinking maybe the API would put a 'redirected' result with the converted title? [09:15:41] it probably doesn't, but might as well check [09:16:05] YuviPanda: there isn't [09:16:10] right. [09:16:19] YuviPanda: but there's another section called "converted" beside "redirected" [09:16:20] liangent: hmm, so I'm not sure how to convert that. [09:16:24] oooh [09:16:35] (03PS8) 10Hashar: Make jslint non-voting for FlaggedRevs [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/121099 (owner: 10Siebrand) [09:16:36] I can use that :) [09:16:41] (03PS9) 10Hashar: Make jslint non-voting for FlaggedRevs [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/121099 (owner: 10Siebrand) [09:16:47] YuviPanda: hm nope that's another thing from ui [09:16:52] (03CR) 10Hashar: [C: 032] Make jslint non-voting for FlaggedRevs [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/121099 (owner: 10Siebrand) [09:16:56] liangent: oh? [09:16:58] (03Merged) 10jenkins-bot: Make jslint non-voting for FlaggedRevs [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/121099 (owner: 10Siebrand) [09:16:58] wait a minute [09:17:35] so a page is stored in database as "zh-cn" [09:18:11] requesting page [[zh-tw]]: converted section says from=zh-tw to=zh-cn [09:18:49] * YuviPanda is so confused atm [09:22:54] YuviPanda: a page title is stored in database in a some variant - sometimes it's zh-cn or sometimes it's zh-tw, let me describe it as the canonical one [09:23:37] when a noncanonical one is requested in &titles= in api, it says "converted from=noncanonical to=canonical" [09:23:54] but this should be hidden from end users [09:23:57] (03CR) 10Nuria: "I take note of this change however I do not have enough knowledge about how does the current resource loader works to CR that this is inde" [extensions/EventLogging] - 10https://gerrit.wikimedia.org/r/120957 (owner: 10Ori.livneh) [09:24:46] users have their own preference about variant. for a given page, it might be sometimes canonical, or sometimes noncanonical [09:24:51] (03PS1) 10Siebrand: Migrate to JSON i18n [extensions/GeoCrumbs] - 10https://gerrit.wikimedia.org/r/121331 [09:25:38] and we need to convert title on ui to the variant preferred by user, regardless of what the canonical one ( = the one stored in database) is [09:25:39] YuviPanda: ^ [09:26:30] (03Abandoned) 10Siebrand: Migrate to JSON i18n [extensions/GeoCrumbs] - 10https://gerrit.wikimedia.org/r/121323 (owner: 10Siebrand) [09:26:37] (03Abandoned) 10Siebrand: Migrate to JSON i18n [extensions/GettingStarted] - 10https://gerrit.wikimedia.org/r/121325 (owner: 10Siebrand) [09:28:45] liangent: right. [09:28:45] liangent: so we figure out what variant page title is in the db, and then figure out what user's pref is and then we convert if necessary [09:30:20] YuviPanda: yeah and the db title is need for action=edit [09:30:21] (03Abandoned) 10Siebrand: Migrate to JSON i18n [extensions/GuidedTour] - 10https://gerrit.wikimedia.org/r/121329 (owner: 10Siebrand) [09:31:03] liangent: aah. [09:31:11] liangent: so, I might have to do the conversion client side... [09:31:26] liangent: can you file this as a separate bug? [09:31:32] YuviPanda: a converted title is available in ParserOutput, and in api, output of action=parse [09:31:41] I'm not sure whether it's there in mobileview [09:31:46] right, but I don't know if it is in action=mobileview. [09:31:55] (03PS1) 10Siebrand: Migrate to JSON i18n [extensions/GeoCrumbs] - 10https://gerrit.wikimedia.org/r/121333 [09:32:06] right. but still should be a separate bug, since I will have to use that for displaying but *not* for sending back to the server [09:32:11] YuviPanda: don't do it clientside. it can't be reliably done [09:32:37] YuviPanda: how do you handle {{DISPLAYTITLE: }} btw? [09:32:52] liangent: I, uh, don't. [09:32:54] converted title should be handled with the same mechanism as displaytitle [09:33:29] I wonder if the API returns it for me [09:33:32] YuviPanda: ok so I should tell you that in parser output they can't be distinguished currently [09:33:36] do you have a test case URL I can check out? [09:33:52] (whether a title got variant-converted, or a displaytitle is set) [09:34:34] (03PS1) 10Siebrand: Migrate to JSON i18n [extensions/GettingStarted] - 10https://gerrit.wikimedia.org/r/121334 [09:35:13] liangent: right. Then I can just handle them as one. [09:35:18] and should be fine. [09:35:30] liangent: do you have an example page I could test this on? [09:36:06] YuviPanda: test what? [09:36:15] liangent: DISPLAYTITLE? [09:36:21] nevermind, let me just make a page. [09:36:26] * YuviPanda was being lazy [09:36:32] (03PS1) 10Siebrand: Migrate to JSON i18n [extensions/GuidedTour] - 10https://gerrit.wikimedia.org/r/121335 [09:37:16] (03Abandoned) 10Siebrand: Migrate to JSON i18n [extensions/GeoCrumbs] - 10https://gerrit.wikimedia.org/r/121331 (owner: 10Siebrand) [09:38:52] YuviPanda: btw a "Go" feature is missing in app [09:39:08] users are forced to search first [09:39:32] liangent: yeah, I'm thinking typing and hitting 'Done' should just take them to the page name if it exists or show search results if it does not [09:39:34] so going to newly created test pages which are not indexed yet is difficult [09:39:37] there's a bug for it, I think [09:40:11] bug id? [09:40:13] liangent: can you comment on https://bugzilla.wikimedia.org/62774 [09:40:20] liangent: I hadn't thought of the index delay use case [09:41:53] YuviPanda: done [09:42:24] liangent: ty! [09:45:46] (03CR) 10Alexander.lehmann: [C: 032] Moved code to namespace PubSubHubbub. [extensions/PubSubHubbub] - 10https://gerrit.wikimedia.org/r/121048 (owner: 10Nik) [09:47:25] (03PS1) 10IAlex: Send the profiler output to the 'profileoutput' log group [core] - 10https://gerrit.wikimedia.org/r/121336 [09:53:00] (03CR) 10Siebrand: "i18n/L10n reviewed." (031 comment) [extensions/SideBarMenu] - 10https://gerrit.wikimedia.org/r/121318 (owner: 10Netbrain) [09:58:25] (03CR) 10Siebrand: "i18n/L10n reviewed." (031 comment) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/121306 (owner: 10Wctaiwan) [10:02:08] liangent: mobileview doesn't support DISPLAYTITLE :( https://en.wikipedia.org/wiki/Special:ApiSandbox#action=mobileview&format=json&page=User%3AYuvipanda%2Ftest%20special [10:03:10] (03PS1) 10Mglaser: Modified regex for Wiki name parameter [packages/WPI] - 10https://gerrit.wikimedia.org/r/121339 [10:05:26] (03CR) 10Siebrand: [C: 031] "i18n/L10n reviewed." [extensions/Persona] - 10https://gerrit.wikimedia.org/r/112309 (owner: 10Donyu) [10:10:08] (03CR) 10Raimond Spekking: [C: 032] Migrate to JSON i18n [extensions/Flow] - 10https://gerrit.wikimedia.org/r/121319 (owner: 10Siebrand) [10:10:23] (03Merged) 10jenkins-bot: Migrate to JSON i18n [extensions/Flow] - 10https://gerrit.wikimedia.org/r/121319 (owner: 10Siebrand) [10:10:44] (03CR) 10Raimond Spekking: [C: 032] Migrate to JSON i18n [extensions/Gadgets] - 10https://gerrit.wikimedia.org/r/121322 (owner: 10Siebrand) [10:10:51] (03Merged) 10jenkins-bot: Migrate to JSON i18n [extensions/Gadgets] - 10https://gerrit.wikimedia.org/r/121322 (owner: 10Siebrand) [10:11:24] (03CR) 10Raimond Spekking: [C: 032] Migrate to JSON i18n [extensions/GeoData] - 10https://gerrit.wikimedia.org/r/121324 (owner: 10Siebrand) [10:11:29] (03Merged) 10jenkins-bot: Migrate to JSON i18n [extensions/GeoData] - 10https://gerrit.wikimedia.org/r/121324 (owner: 10Siebrand) [10:11:42] (03CR) 10Raimond Spekking: [C: 032] Migrate to JSON i18n [extensions/GlobalBlocking] - 10https://gerrit.wikimedia.org/r/121326 (owner: 10Siebrand) [10:11:47] (03Merged) 10jenkins-bot: Migrate to JSON i18n [extensions/GlobalBlocking] - 10https://gerrit.wikimedia.org/r/121326 (owner: 10Siebrand) [10:12:06] (03CR) 10Raimond Spekking: [C: 032] Migrate to JSON i18n [extensions/GlobalUsage] - 10https://gerrit.wikimedia.org/r/121327 (owner: 10Siebrand) [10:12:09] (03Merged) 10jenkins-bot: Migrate to JSON i18n [extensions/GlobalUsage] - 10https://gerrit.wikimedia.org/r/121327 (owner: 10Siebrand) [10:12:27] (03CR) 10Raimond Spekking: [C: 032] Migrate to JSON i18n [extensions/GoogleNewsSitemap] - 10https://gerrit.wikimedia.org/r/121328 (owner: 10Siebrand) [10:12:29] (03Merged) 10jenkins-bot: Migrate to JSON i18n [extensions/GoogleNewsSitemap] - 10https://gerrit.wikimedia.org/r/121328 (owner: 10Siebrand) [10:13:41] (03CR) 10Raimond Spekking: [C: 032] Migrate to JSON i18n [extensions/GeoCrumbs] - 10https://gerrit.wikimedia.org/r/121333 (owner: 10Siebrand) [10:13:43] (03Merged) 10jenkins-bot: Migrate to JSON i18n [extensions/GeoCrumbs] - 10https://gerrit.wikimedia.org/r/121333 (owner: 10Siebrand) [10:14:06] (03CR) 10Raimond Spekking: [C: 032] Migrate to JSON i18n [extensions/GettingStarted] - 10https://gerrit.wikimedia.org/r/121334 (owner: 10Siebrand) [10:14:10] (03Merged) 10jenkins-bot: Migrate to JSON i18n [extensions/GettingStarted] - 10https://gerrit.wikimedia.org/r/121334 (owner: 10Siebrand) [10:14:43] (03CR) 10Raimond Spekking: [C: 032] Migrate to JSON i18n [extensions/GuidedTour] - 10https://gerrit.wikimedia.org/r/121335 (owner: 10Siebrand) [10:15:20] (03Merged) 10jenkins-bot: Migrate to JSON i18n [extensions/GuidedTour] - 10https://gerrit.wikimedia.org/r/121335 (owner: 10Siebrand) [10:15:23] YuviPanda: bug them! [10:15:33] liangent: yeah, gonna do :) [10:16:20] YuviPanda: cc me btw [10:17:07] (03CR) 10Siebrand: [C: 04-1] Implement a redirector at Special:Flow [extensions/Flow] - 10https://gerrit.wikimedia.org/r/121306 (owner: 10Wctaiwan) [10:17:20] liangent: done [10:19:56] YuviPanda: thanks [10:19:58] (03PS2) 10TTO: Add c: as Commons interwiki prefix [extensions/WikimediaMaintenance] - 10https://gerrit.wikimedia.org/r/112920 (owner: 10Gerrit Patch Uploader) [10:20:08] liangent: :) [10:20:09] (03CR) 10TTO: [C: 031] "Now able to be merged." [extensions/WikimediaMaintenance] - 10https://gerrit.wikimedia.org/r/112920 (owner: 10Gerrit Patch Uploader) [10:21:48] (03CR) 10Hashar: "So this is apparently meant to drop md5 and replace it. I have left a bunch of nitpick everywhere." (0321 comments) [core] - 10https://gerrit.wikimedia.org/r/77645 (owner: 10Parent5446) [10:27:41] (03CR) 10Siebrand: "Some review." (0314 comments) [extensions/OpenBadges] - 10https://gerrit.wikimedia.org/r/120361 (owner: 10Chococookies) [10:29:44] (03CR) 10Hashar: "Probably fine, haven't carefully reviewer nor tested but I really like the idea and specially the back compatibility. Thanks." (032 comments) [core] - 10https://gerrit.wikimedia.org/r/121336 (owner: 10IAlex) [10:39:11] (03CR) 10Siebrand: Add topic/post summary diff view (031 comment) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/121128 (owner: 10Bsitu) [10:39:19] (03CR) 10Siebrand: [C: 031] "i18n/L10n reviewed." [extensions/Flow] - 10https://gerrit.wikimedia.org/r/121128 (owner: 10Bsitu) [10:41:38] * YuviPanda attempts to catch MaxSem for https://bugzilla.wikimedia.org/62721 [10:43:58] aaaa [10:44:07] they're surrounding me! [10:44:54] * YuviPanda surrounds MaxSem with https://bugzilla.wikimedia.org/62721 [10:45:01] MaxSem: it should be a trivial check that's missing somewhere.... [10:45:02] I think [10:45:30] MaxSem: I meant https://bugzilla.wikimedia.org/show_bug.cgi?id=61868 [10:45:35] which is the same, really [10:46:48] MaxSem: plz2fix. I don't think Jon knows about the additions to the API (section ranges, onlyRequestedSections) [10:51:01] (03PS1) 10Siebrand: Migrate to JSON i18n [extensions/AdminLinks] - 10https://gerrit.wikimedia.org/r/121341 [10:52:16] (03CR) 10Mglaser: [C: 032 V: 032] "Verified and Reviewed by the Microsoft team" [packages/WPI] - 10https://gerrit.wikimedia.org/r/121339 (owner: 10Mglaser) [10:52:24] (03PS1) 10Siebrand: Migrate to JSON i18n [extensions/APC] - 10https://gerrit.wikimedia.org/r/121342 [10:53:41] (03PS1) 10Siebrand: Migrate to JSON i18n [extensions/ContributionScores] - 10https://gerrit.wikimedia.org/r/121343 [10:55:07] (03PS1) 10Siebrand: Migrate to JSON i18n [extensions/Interwiki] - 10https://gerrit.wikimedia.org/r/121345 [10:56:07] (03PS1) 10Siebrand: Migrate to JSON i18n [extensions/Nuke] - 10https://gerrit.wikimedia.org/r/121346 [10:56:38] (03PS1) 10Hashar: beta: update databases in both datacenters [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/121347 [10:56:41] (03CR) 10Hashar: [C: 032] beta: update databases in both datacenters [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/121347 (owner: 10Hashar) [10:58:01] (03Merged) 10jenkins-bot: beta: update databases in both datacenters [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/121347 (owner: 10Hashar) [10:58:17] (03PS1) 10Siebrand: Migrate to JSON i18n [extensions/Renameuser] - 10https://gerrit.wikimedia.org/r/121348 [10:59:55] (03PS1) 10Siebrand: Migrate to JSON i18n [extensions/ReplaceText] - 10https://gerrit.wikimedia.org/r/121350 [11:02:50] (03PS1) 10Hashar: beta: update MediaWiki config in both datacenters [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/121351 [11:04:31] (03PS1) 10Hashar: beta: update MediaWiki config in both datacenters [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/121355 [11:05:13] (03CR) 10Hashar: [C: 032] beta: update MediaWiki config in both datacenters [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/121355 (owner: 10Hashar) [11:05:18] (03Merged) 10jenkins-bot: beta: update MediaWiki config in both datacenters [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/121355 (owner: 10Hashar) [11:05:25] (03CR) 10Hashar: [C: 032] beta: update MediaWiki config in both datacenters [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/121351 (owner: 10Hashar) [11:06:00] (03Merged) 10jenkins-bot: beta: update MediaWiki config in both datacenters [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/121351 (owner: 10Hashar) [11:10:00] (03PS1) 10Hashar: beta: update MediaWiki code update in both datacenters [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/121357 [11:12:00] (03CR) 10Hashar: [C: 032] beta: update MediaWiki code update in both datacenters [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/121357 (owner: 10Hashar) [11:12:36] (03Merged) 10jenkins-bot: beta: update MediaWiki code update in both datacenters [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/121357 (owner: 10Hashar) [11:17:46] (03PS1) 10Hashar: dashboard: link to pmtpa/eqiad beta cluster jobs [integration/docroot] - 10https://gerrit.wikimedia.org/r/121359 [11:17:59] (03CR) 10Hashar: [C: 032] dashboard: link to pmtpa/eqiad beta cluster jobs [integration/docroot] - 10https://gerrit.wikimedia.org/r/121359 (owner: 10Hashar) [11:18:02] (03Merged) 10jenkins-bot: dashboard: link to pmtpa/eqiad beta cluster jobs [integration/docroot] - 10https://gerrit.wikimedia.org/r/121359 (owner: 10Hashar) [11:25:57] (03Abandoned) 10Matthias Mullie: Revert "Revert "New Hook rc/watchlist hook ChangesListBegin"" [core] - 10https://gerrit.wikimedia.org/r/121075 (owner: 10Matthias Mullie) [11:28:10] (03CR) 10Reedy: [C: 032] Migrate to JSON i18n [extensions/APC] - 10https://gerrit.wikimedia.org/r/121342 (owner: 10Siebrand) [11:28:12] (03Merged) 10jenkins-bot: Migrate to JSON i18n [extensions/APC] - 10https://gerrit.wikimedia.org/r/121342 (owner: 10Siebrand) [11:28:36] (03CR) 10Reedy: [C: 032] Migrate to JSON i18n [extensions/ContributionScores] - 10https://gerrit.wikimedia.org/r/121343 (owner: 10Siebrand) [11:28:38] (03Merged) 10jenkins-bot: Migrate to JSON i18n [extensions/ContributionScores] - 10https://gerrit.wikimedia.org/r/121343 (owner: 10Siebrand) [11:28:53] (03CR) 10Reedy: [C: 032] Migrate to JSON i18n [extensions/Interwiki] - 10https://gerrit.wikimedia.org/r/121345 (owner: 10Siebrand) [11:28:55] (03Merged) 10jenkins-bot: Migrate to JSON i18n [extensions/Interwiki] - 10https://gerrit.wikimedia.org/r/121345 (owner: 10Siebrand) [11:29:05] (03CR) 10Reedy: [C: 032] Migrate to JSON i18n [extensions/Nuke] - 10https://gerrit.wikimedia.org/r/121346 (owner: 10Siebrand) [11:29:07] (03Merged) 10jenkins-bot: Migrate to JSON i18n [extensions/Nuke] - 10https://gerrit.wikimedia.org/r/121346 (owner: 10Siebrand) [11:29:11] (03CR) 10Reedy: [C: 032] Migrate to JSON i18n [extensions/Renameuser] - 10https://gerrit.wikimedia.org/r/121348 (owner: 10Siebrand) [11:29:13] (03Merged) 10jenkins-bot: Migrate to JSON i18n [extensions/Renameuser] - 10https://gerrit.wikimedia.org/r/121348 (owner: 10Siebrand) [11:31:01] (03CR) 10Matthias Mullie: [C: 031] "LGTM and I can't see this causing any BC issues. I'll merge soon, so speak up if you have doubts ;)" [core] - 10https://gerrit.wikimedia.org/r/121121 (owner: 10EBernhardson) [11:31:18] (03CR) 10Reedy: [C: 032] Migrate to JSON i18n [extensions/ReplaceText] - 10https://gerrit.wikimedia.org/r/121350 (owner: 10Siebrand) [11:31:27] (03Merged) 10jenkins-bot: Migrate to JSON i18n [extensions/ReplaceText] - 10https://gerrit.wikimedia.org/r/121350 (owner: 10Siebrand) [11:31:29] (03CR) 10Reedy: [C: 032] Migrate to JSON i18n [extensions/AdminLinks] - 10https://gerrit.wikimedia.org/r/121341 (owner: 10Siebrand) [11:31:32] * siebrand thanks Reedy  [11:31:33] (03Merged) 10jenkins-bot: Migrate to JSON i18n [extensions/AdminLinks] - 10https://gerrit.wikimedia.org/r/121341 (owner: 10Siebrand) [11:31:43] zomg spammers! [11:38:44] (03CR) 10Nikerabbit: [WIP] Make captcha.py produce images in arbitrary language (032 comments) [extensions/ConfirmEdit] - 10https://gerrit.wikimedia.org/r/121255 (owner: 10Nemo bis) [11:49:04] gerrit dead again? [11:50:51] i was about to ask [11:51:00] DanielK_WMDE__: just had a response [11:51:03] try again? [11:54:43] (03CR) 10Nemo bis: [WIP] Make captcha.py produce images in arbitrary language (031 comment) [extensions/ConfirmEdit] - 10https://gerrit.wikimedia.org/r/121255 (owner: 10Nemo bis) [11:56:30] https://bugzilla.wikimedia.org/show_bug.cgi?id=56363 hey about this bug [11:56:32] "[[Special:ChangeEmail]] form should be rewritten to use HTMLForm with vform styling and prettier error messages" [11:56:43] Should the form be re-written as a Vform [11:56:50] just like in the reset password page ? [11:57:00] removing tables, framesets and everything ? [12:22:16] (03CR) 10Ganeshaditya1: "Shouldn't the error be in a

like the rest of the pages ? It will look more harmonious with the rest of the pages you " [core] - 10https://gerrit.wikimedia.org/r/117854 (owner: 10Ganeshaditya1) [12:24:13] (03PS1) 10Mwjames: wfMsgForContent breaks regression tests [extensions/Lingo] - 10https://gerrit.wikimedia.org/r/121364 [12:51:34] (03PS3) 10Wctaiwan: Implement a redirector at Special:Flow [extensions/Flow] - 10https://gerrit.wikimedia.org/r/121306 [12:51:38] (03CR) 10jenkins-bot: [V: 04-1] Implement a redirector at Special:Flow [extensions/Flow] - 10https://gerrit.wikimedia.org/r/121306 (owner: 10Wctaiwan) [12:53:32] (03CR) 10Rillke: "It appears you are preparing something different within this change. Please update the commit message or tie the changes to the commit mes" (033 comments) [extensions/InputBox] - 10https://gerrit.wikimedia.org/r/120487 (owner: 1001tonythomas) [12:53:38] (03PS1) 10Ganeshaditya1: Add message wrongpassword as html and remove its reuse in Special:ChangeEmail [core] - 10https://gerrit.wikimedia.org/r/121367 [12:54:33] Looking for reviewers for this change https://gerrit.wikimedia.org/r/121367 [12:55:18] (03CR) 10jenkins-bot: [V: 04-1] Add message wrongpassword as html and remove its reuse in Special:ChangeEmail [core] - 10https://gerrit.wikimedia.org/r/121367 (owner: 10Ganeshaditya1) [13:04:29] (03PS2) 10Ganeshaditya1: Add message wrongpassword as html and remove its reuse in Special:ChangeEmail [core] - 10https://gerrit.wikimedia.org/r/121367 [13:06:00] (03PS3) 10Prtksxna: Use escape key to hide popup [extensions/Popups] - 10https://gerrit.wikimedia.org/r/120343 [13:06:02] (03PS4) 10Prtksxna: Show and hide Popups on focus and blur (along with mouseenter/leave) [extensions/Popups] - 10https://gerrit.wikimedia.org/r/120342 [13:06:04] (03PS3) 10Prtksxna: Use aria-hidden for popups [extensions/Popups] - 10https://gerrit.wikimedia.org/r/120345 [13:06:06] (03PS3) 10Prtksxna: Use tooltip role for Popups [extensions/Popups] - 10https://gerrit.wikimedia.org/r/120344 [13:06:14] (03CR) 10Rillke: "one small improvement and my paranoid mind will be contented :-)" (031 comment) [extensions/Comments] - 10https://gerrit.wikimedia.org/r/118957 (owner: 1001tonythomas) [13:14:06] (03PS5) 10Prtksxna: Disable NavigationPopups (Gadget) is Popups (Extension) is enabled [extensions/Popups] - 10https://gerrit.wikimedia.org/r/120188 [13:14:08] (03PS1) 10Prtksxna: Use correct spacing conventions for jshint comment [extensions/Popups] - 10https://gerrit.wikimedia.org/r/121369 [13:15:24] (03CR) 10Addshore: [C: 031] Allow to optionally set language in Message constructor [core] - 10https://gerrit.wikimedia.org/r/121113 (owner: 10Aude) [13:15:57] (03PS4) 10Wctaiwan: Implement a redirector at Special:Flow [extensions/Flow] - 10https://gerrit.wikimedia.org/r/121306 [13:18:09] (03PS1) 10Hashar: beta: update Parsoid code update in both datacenters [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/121370 [13:18:37] (03CR) 10Prtksxna: Disable NavigationPopups (Gadget) is Popups (Extension) is enabled (031 comment) [extensions/Popups] - 10https://gerrit.wikimedia.org/r/120188 (owner: 10Prtksxna) [13:19:06] (03CR) 10Addshore: Implement a redirector at Special:Flow (031 comment) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/121306 (owner: 10Wctaiwan) [13:19:50] (03PS1) 10Hashar: beta: update Parsoid code update in both datacenters [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/121371 [13:21:02] (03CR) 10Hashar: [C: 032] beta: update Parsoid code update in both datacenters [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/121371 (owner: 10Hashar) [13:21:05] (03CR) 10Wctaiwan: Implement a redirector at Special:Flow (031 comment) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/121306 (owner: 10Wctaiwan) [13:21:08] (03Merged) 10jenkins-bot: beta: update Parsoid code update in both datacenters [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/121371 (owner: 10Hashar) [13:21:13] (03CR) 10Hashar: [C: 032] beta: update Parsoid code update in both datacenters [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/121370 (owner: 10Hashar) [13:21:34] (03PS3) 10Deepali: Remove edit toolbar from the editing form [core] - 10https://gerrit.wikimedia.org/r/120357 [13:21:48] https://bugzilla.wikimedia.org/show_bug.cgi?id=56363 Hey for the bug [13:21:58] [[Special:ChangeEmail]] form should be rewritten to use HTMLForm with vform styling and prettier error messages [13:22:22] Do I need to redo the form as a Vform and remove tables, framesets and make it more like password reset page ? [13:22:36] (03Merged) 10jenkins-bot: beta: update Parsoid code update in both datacenters [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/121370 (owner: 10Hashar) [13:26:31] (03PS5) 10Wctaiwan: Implement a redirector at Special:Flow [extensions/Flow] - 10https://gerrit.wikimedia.org/r/121306 [13:27:05] (03CR) 10Manybubbles: [C: 032] Also include namespaces in memcached key [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/121300 (owner: 10Chad) [13:27:14] (03Merged) 10jenkins-bot: Also include namespaces in memcached key [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/121300 (owner: 10Chad) [13:27:24] (03CR) 10Wctaiwan: Implement a redirector at Special:Flow (031 comment) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/121306 (owner: 10Wctaiwan) [13:30:49] (03PS1) 10Hashar: dashboard: update beta-parsoid-update links [integration/docroot] - 10https://gerrit.wikimedia.org/r/121372 [13:30:57] (03PS2) 10Deepali: Remove edit toolbar from the editing form [extensions/BookManagerv2] - 10https://gerrit.wikimedia.org/r/120573 [13:30:59] (03CR) 10Hashar: [C: 032] dashboard: update beta-parsoid-update links [integration/docroot] - 10https://gerrit.wikimedia.org/r/121372 (owner: 10Hashar) [13:31:02] (03Merged) 10jenkins-bot: dashboard: update beta-parsoid-update links [integration/docroot] - 10https://gerrit.wikimedia.org/r/121372 (owner: 10Hashar) [13:31:55] @Nikerabbit could you please review these changes https://gerrit.wikimedia.org/r/121367 [13:32:37] (03CR) 10Deepali: "There was a bug with https://gerrit.wikimedia.org/r/#/c/120573/ which I later realised. I have now added a hook in core and added function" [core] - 10https://gerrit.wikimedia.org/r/120357 (owner: 10Deepali) [13:33:07] (03PS9) 10Wctaiwan: Change UI of special page and support Flow Thanks [extensions/Thanks] - 10https://gerrit.wikimedia.org/r/119879 [13:34:11] (03CR) 10Gilles: [C: 04-1] Add model base class, description model (032 comments) [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/121308 (owner: 10MarkTraceur) [13:35:28] (03PS10) 10Wctaiwan: Change UI of special page and support Flow Thanks [extensions/Thanks] - 10https://gerrit.wikimedia.org/r/119879 [13:37:37] (03PS4) 10Prtksxna: Add white fill in triangle for hovercards with images [extensions/Popups] - 10https://gerrit.wikimedia.org/r/120174 [13:37:39] (03PS1) 10Prtksxna: Remove `redirects to` text and heading [extensions/Popups] - 10https://gerrit.wikimedia.org/r/121373 [13:46:13] (03PS1) 10Matthias Mullie: Fix missing new-post entries from Special:Contribitions [extensions/Flow] - 10https://gerrit.wikimedia.org/r/121375 [14:16:08] (03CR) 10Anomie: "Or you could audit existing code for checking if ->getTitle() === null, then make it throw an exception from ->getTitle() if no title is a" [core] - 10https://gerrit.wikimedia.org/r/120552 (owner: 10Hoo man) [14:29:04] (03PS6) 10Phuedx: Add a LESS test suite [core] - 10https://gerrit.wikimedia.org/r/119055 [14:29:21] (03CR) 10PleaseStand: [C: 04-1] UnknownAction hook not mentioned as deprecated in Wiki.php (033 comments) [core] - 10https://gerrit.wikimedia.org/r/121301 (owner: 10Rahul mishra) [14:36:44] (03CR) 10Phuedx: "> TODO" [core] - 10https://gerrit.wikimedia.org/r/119055 (owner: 10Phuedx) [14:44:25] (03CR) 10PleaseStand: [C: 04-1] "Isn't the reporter currently asking for one new wikitext message, not two new HTML messages?" (033 comments) [core] - 10https://gerrit.wikimedia.org/r/121367 (owner: 10Ganeshaditya1) [14:58:26] (03CR) 10Ganeshaditya1: Add message wrongpassword as html and remove its reuse in Special:ChangeEmail (031 comment) [core] - 10https://gerrit.wikimedia.org/r/121367 (owner: 10Ganeshaditya1) [15:00:38] (03CR) 10Ganeshaditya1: "@PleaseStand According to comment 2 here https://bugzilla.wikimedia.org/show_bug.cgi?id=56522" [core] - 10https://gerrit.wikimedia.org/r/121367 (owner: 10Ganeshaditya1) [15:17:39] (03PS1) 10Anomie: API: Allow for format modules that cannot handle errors [core] - 10https://gerrit.wikimedia.org/r/121381 [15:23:17] (03PS1) 10Matthias Mullie: Moderator usertext & links are allowed to be displayed [extensions/Flow] - 10https://gerrit.wikimedia.org/r/121382 [15:23:20] (03PS1) 10Matthias Mullie: Use existing method to check if moderated instead of doing manually [extensions/Flow] - 10https://gerrit.wikimedia.org/r/121383 [15:23:23] (03PS1) 10Matthias Mullie: No longer need the try-catch fallback; getRootPost will always resolve [extensions/Flow] - 10https://gerrit.wikimedia.org/r/121384 [15:23:26] (03PS1) 10Matthias Mullie: Don't escape the userlinks displayed in "This topic was suppressed by " [extensions/Flow] - 10https://gerrit.wikimedia.org/r/121385 [15:24:36] mlitn: hi, do you still need access to stat1 ? [15:25:12] matanya: I don’t - feel free to remove me ;) [15:25:18] thank mlitn [15:25:20] s [15:26:11] ebernhar1son: hi, do you still need access to stat1 ? [15:30:54] For the bug number 56363 which needs the form to be re-written using Vforms. what do I need to do about the red and green stripes with the email validation [15:39:53] (03PS1) 10Chad: Update Elastica to v1.0.1.2 [extensions/Elastica] - 10https://gerrit.wikimedia.org/r/121388 [15:42:35] (03PS3) 10Ganeshaditya1: Add message wrongpassword as html and remove its reuse in Special:ChangeEmail [core] - 10https://gerrit.wikimedia.org/r/121367 [15:46:53] (03PS1) 10Chad: Improve information about Elastica [extensions/Elastica] - 10https://gerrit.wikimedia.org/r/121392 [15:47:49] (03PS4) 10Ganeshaditya1: Add message wrongpassword as html and remove its reuse in Special:ChangeEmail [core] - 10https://gerrit.wikimedia.org/r/121367 [15:49:18] (03Abandoned) 10Legoktm: Add wikidiff2 role [vagrant] - 10https://gerrit.wikimedia.org/r/112812 (owner: 10Legoktm) [16:00:52] (03CR) 10Subramanya Sastry: [C: 032] Update set of files cleaned up after parserTests [core] - 10https://gerrit.wikimedia.org/r/120847 (owner: 10Cscott) [16:11:56] (03CR) 10PleaseStand: [C: 04-1] "> It needs to be HTML here as well. Thats what I could make out of that conversation. Could you please explain what you mean by one wikite" [core] - 10https://gerrit.wikimedia.org/r/121367 (owner: 10Ganeshaditya1) [16:26:37] (03CR) 10Nikerabbit: Added password hashing API (031 comment) [core] - 10https://gerrit.wikimedia.org/r/77645 (owner: 10Parent5446) [16:34:29] (03PS1) 10Manybubbles: WIP: Check script [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/121399 [16:35:05] (03CR) 10Manybubbles: "I was tired of getting Elasticsearch warnings when doing normal stuff like in place reindexing. This only checks the indexes that we expe" [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/121399 (owner: 10Manybubbles) [16:36:53] (03CR) 10PleaseStand: "Rahul, what I'm asking you to do is:" (031 comment) [core] - 10https://gerrit.wikimedia.org/r/121301 (owner: 10Rahul mishra) [16:38:00] csteipp: just FYI, I got the headers off that mysterious token/session problem I have on Linux, and a volunteer had a repro on Windows https://bugzilla.wikimedia.org/show_bug.cgi?id=62614 [16:41:20] (03PS6) 10Krinkle: Disable NavigationPopups (Gadget) if Popups (Extension) is enabled [extensions/Popups] - 10https://gerrit.wikimedia.org/r/120188 (owner: 10Prtksxna) [16:41:25] (03PS2) 10Krinkle: Use correct spacing conventions for jshint comment [extensions/Popups] - 10https://gerrit.wikimedia.org/r/121369 (owner: 10Prtksxna) [16:42:48] chrismcmahon: Cool. What was the url this was hitting to produce that? [16:43:05] (03CR) 10PleaseStand: "* And also note in docs/hooks.txt that the hook is deprecated." [core] - 10https://gerrit.wikimedia.org/r/121301 (owner: 10Rahul mishra) [16:43:55] csteipp: http://en.m.wikipedia.beta.wmflabs.org/w/index.php?title=Special:MobileOptions or in practice http://en.m.wikipedia.beta.wmflabs.org/w/index.php?title=Special:MobileOptions&returnto=Main+Page [16:44:11] the same POST that Jeremy posted? [16:44:41] who is jeremy? :) [16:44:58] (03CR) 10Krinkle: [C: 04-1] "I'd recommend doing it the other way around both because it makes the implementation easier and because it avoids having downstream refere" [extensions/Popups] - 10https://gerrit.wikimedia.org/r/120188 (owner: 10Prtksxna) [16:45:06] jeremyb: You've been replaced :) [16:45:20] chrismcmahon: So your headers were from the post, not the get, right? [16:45:25] csteipp: do i still have an inode connected to an open fd? [16:46:25] (03CR) 10Krinkle: Allow schema registration via custom hook (031 comment) [extensions/EventLogging] - 10https://gerrit.wikimedia.org/r/120957 (owner: 10Ori.livneh) [16:46:34] (03PS1) 10Matthias Mullie: (bug 62613) Notification excerpt lengths are inconsistent [extensions/Flow] - 10https://gerrit.wikimedia.org/r/121401 [16:46:48] csteipp: yes, as I recall. there is no issue loading the page, the issue is submitting the changed state of that ON/OFF toggle [16:49:27] (03CR) 10Krinkle: Allow EventLogging events to be logged via mw#track (031 comment) [extensions/EventLogging] - 10https://gerrit.wikimedia.org/r/120757 (owner: 10Ori.livneh) [16:49:45] (03PS1) 10Anomie: Improve handling of uncommitted DB txns with "uncaught" exceptions [core] - 10https://gerrit.wikimedia.org/r/121402 [16:50:42] (03CR) 10Nikerabbit: [WIP] Make captcha.py produce images in arbitrary language (031 comment) [extensions/ConfirmEdit] - 10https://gerrit.wikimedia.org/r/121255 (owner: 10Nemo bis) [16:52:26] (03PS5) 10Ganeshaditya1: Add message wrongpassword as html and remove its reuse in Special:ChangeEmail [core] - 10https://gerrit.wikimedia.org/r/121367 [16:52:42] (03CR) 10Anomie: Improve handling of uncommitted DB txns with "uncaught" exceptions (031 comment) [core] - 10https://gerrit.wikimedia.org/r/121402 (owner: 10Anomie) [16:54:28] (03CR) 10Nemo bis: [WIP] Make captcha.py produce images in arbitrary language (031 comment) [extensions/ConfirmEdit] - 10https://gerrit.wikimedia.org/r/121255 (owner: 10Nemo bis) [16:55:59] (03PS6) 10Ganeshaditya1: Add message wrongpassword as html and remove its reuse in Special:ChangeEmail [core] - 10https://gerrit.wikimedia.org/r/121367 [16:57:15] chrismcmahon: https://bugzilla.wikimedia.org/show_bug.cgi?id=62614#c40 [16:58:05] (03CR) 10Hashar: Added password hashing API (031 comment) [core] - 10https://gerrit.wikimedia.org/r/77645 (owner: 10Parent5446) [16:59:27] (03CR) 10Krinkle: Allow schema registration via custom hook (031 comment) [extensions/EventLogging] - 10https://gerrit.wikimedia.org/r/120957 (owner: 10Ori.livneh) [17:09:13] (03CR) 10Ganeshaditya1: "Moved the html part to wikimsg which I created newly. How does that look now ?" [core] - 10https://gerrit.wikimedia.org/r/121367 (owner: 10Ganeshaditya1) [17:09:13] gerrit slow [17:09:35] orly [17:10:19] more like 'down' [17:11:56] <^d> bleh, it's the stupid thing like before. [17:12:01] <^d> gerrit process is fine [17:12:06] <^d> UI is fubar'd. [17:12:14] <^d> And back for me. [17:14:08] goes on and off [17:15:36] (03CR) 10Nikerabbit: [WIP] Make captcha.py produce images in arbitrary language (031 comment) [extensions/ConfirmEdit] - 10https://gerrit.wikimedia.org/r/121255 (owner: 10Nemo bis) [17:15:38] (03Merged) 10jenkins-bot: Update set of files cleaned up after parserTests [core] - 10https://gerrit.wikimedia.org/r/120847 (owner: 10Cscott) [17:18:18] (03CR) 10Nikerabbit: Added password hashing API (031 comment) [core] - 10https://gerrit.wikimedia.org/r/77645 (owner: 10Parent5446) [17:19:23] (03CR) 10Nemo bis: [WIP] Make captcha.py produce images in arbitrary language (031 comment) [extensions/ConfirmEdit] - 10https://gerrit.wikimedia.org/r/121255 (owner: 10Nemo bis) [17:20:13] (03CR) 10Chad: [C: 04-1] WIP: Check script (032 comments) [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/121399 (owner: 10Manybubbles) [17:21:51] (03CR) 10Manybubbles: [C: 04-1] WIP: Check script (031 comment) [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/121399 (owner: 10Manybubbles) [17:28:47] (03CR) 10Bartosz Dziewoński: "Needs release notes. Left additional comments inline. I'd have done it before it was merged if I was given the chance, changes like these " (035 comments) [core] - 10https://gerrit.wikimedia.org/r/120978 (owner: 10Kaldari) [17:30:40] (03CR) 10Anomie: [C: 04-1] Add a new image option: "square" (032 comments) [core] - 10https://gerrit.wikimedia.org/r/120856 (owner: 10Cscott) [17:31:18] (03PS2) 10Manybubbles: WIP: Check script [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/121399 [17:32:16] (03CR) 10Manybubbles: [C: 032] Improve information about Elastica [extensions/Elastica] - 10https://gerrit.wikimedia.org/r/121392 (owner: 10Chad) [17:33:48] (03CR) 10Manybubbles: [C: 04-1] "I don't see the autoloader updates we'd need to get the new files loaded." [extensions/Elastica] - 10https://gerrit.wikimedia.org/r/121388 (owner: 10Chad) [17:35:13] (03CR) 10Nikerabbit: [WIP] Make captcha.py produce images in arbitrary language (031 comment) [extensions/ConfirmEdit] - 10https://gerrit.wikimedia.org/r/121255 (owner: 10Nemo bis) [17:37:12] (03CR) 10Cscott: Add a new image option: "square" (032 comments) [core] - 10https://gerrit.wikimedia.org/r/120856 (owner: 10Cscott) [17:38:39] Krinkle: I seem to remember you creating a tool for searching the codebase all the MediaWiki extensions a while back, but I can't find the URL now. [17:38:50] kaldari: That was in the svn days [17:38:59] ah [17:39:04] kaldari: Now there is github [17:39:05] kaldari: https://github.com/search?q=OO.ui.Dialog+%40wikimedia&type=Code [17:39:12] Which is so much awesomer [17:39:19] github's search index can be terribly outdated [17:39:24] thanks, I didn't think about that [17:39:27] more than half a year at times [17:39:37] don't rely on it if it's important [17:39:44] at least it tells you [17:53:01] (03PS7) 10Ganeshaditya1: Add message wrongpassword as html and remove its reuse in Special:ChangeEmail [core] - 10https://gerrit.wikimedia.org/r/121367 [18:00:30] (03PS3) 10Manybubbles: Check script [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/121399 [18:03:28] (03CR) 10Anomie: Add a new image option: "square" (032 comments) [core] - 10https://gerrit.wikimedia.org/r/120856 (owner: 10Cscott) [18:04:47] (03CR) 10Kaldari: Typography update to Vector skin (035 comments) [core] - 10https://gerrit.wikimedia.org/r/120978 (owner: 10Kaldari) [18:05:13] (03PS18) 10Kunalgrover05: Implement listing for tracking categories [core] - 10https://gerrit.wikimedia.org/r/112323 [18:05:21] (03CR) 10Chad: [C: 031] "lgtm, can hold on merging if you want Andrew to glance at the nagios bit." [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/121399 (owner: 10Manybubbles) [18:06:16] (03CR) 10Nemo bis: "By the way there is https://pypi.python.org/pypi/PyCAPTCHA/ but I don't see anything of use in there" [extensions/ConfirmEdit] - 10https://gerrit.wikimedia.org/r/121255 (owner: 10Nemo bis) [18:06:18] (03CR) 10jenkins-bot: [V: 04-1] Implement listing for tracking categories [core] - 10https://gerrit.wikimedia.org/r/112323 (owner: 10Kunalgrover05) [18:10:49] csteipp: I have a poor lame Linux box and WireShark is messing with its ability to internet properly [18:15:07] (03PS1) 10Kaldari: Follow-up to typography changes to Vector [core] - 10https://gerrit.wikimedia.org/r/121419 [18:16:34] (03PS2) 10Kaldari: Follow-up to typography changes to Vector [core] - 10https://gerrit.wikimedia.org/r/121419 [18:17:37] (03Abandoned) 10Kaldari: Turning off Typography Update feature in Beta features [extensions/VectorBeta] - 10https://gerrit.wikimedia.org/r/121244 (owner: 10Kaldari) [18:18:09] (03CR) 10Siebrand: [C: 031] "i18n/L10n reviewed." (031 comment) [core] - 10https://gerrit.wikimedia.org/r/112323 (owner: 10Kunalgrover05) [18:18:31] (03PS19) 10Kunalgrover05: Implement listing for tracking categories [core] - 10https://gerrit.wikimedia.org/r/112323 [18:20:44] (03CR) 10Cscott: "Anomie: you might like "option 3" in https://www.mediawiki.org/wiki/Requests_for_comment/Square_bounding_boxes#Proposals better." [core] - 10https://gerrit.wikimedia.org/r/120856 (owner: 10Cscott) [18:22:01] (03CR) 10Kunalgrover05: "Does the message need to be safe HTML?" [core] - 10https://gerrit.wikimedia.org/r/112323 (owner: 10Kunalgrover05) [18:24:31] (03CR) 10Siebrand: "The message is MADE safe HTML, by either using escaped() or parse() as output mode." [core] - 10https://gerrit.wikimedia.org/r/112323 (owner: 10Kunalgrover05) [18:25:34] (03CR) 10Ottomata: [C: 031] Check script [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/121399 (owner: 10Manybubbles) [18:25:54] (03CR) 10Manybubbles: [C: 032] "1 + 1 = 2" [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/121399 (owner: 10Manybubbles) [18:26:09] (03Merged) 10jenkins-bot: Check script [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/121399 (owner: 10Manybubbles) [18:26:23] (03CR) 10Kunalgrover05: "I meant is there a need to parse it? Since it is a sy" [core] - 10https://gerrit.wikimedia.org/r/112323 (owner: 10Kunalgrover05) [18:26:48] (03CR) 10Kunalgrover05: "I meant is there a need to parse it? Since it is a system message." [core] - 10https://gerrit.wikimedia.org/r/112323 (owner: 10Kunalgrover05) [18:30:06] (03PS20) 10Kunalgrover05: Implement listing for tracking categories [core] - 10https://gerrit.wikimedia.org/r/112323 [18:30:14] (03CR) 10Siebrand: "Are there any changes between PS18 and PS19 but the rebase?" [core] - 10https://gerrit.wikimedia.org/r/112323 (owner: 10Kunalgrover05) [18:31:37] (03CR) 10Kunalgrover05: "No." [core] - 10https://gerrit.wikimedia.org/r/112323 (owner: 10Kunalgrover05) [18:31:47] (03CR) 10Siebrand: [C: 031] "i18n/L10n reviewed." (031 comment) [core] - 10https://gerrit.wikimedia.org/r/112323 (owner: 10Kunalgrover05) [18:34:34] (03PS2) 10Chad: Update Elastica to v1.0.1.2 [extensions/Elastica] - 10https://gerrit.wikimedia.org/r/121388 [18:34:36] (03PS2) 10Chad: Improve information about Elastica [extensions/Elastica] - 10https://gerrit.wikimedia.org/r/121392 [18:34:44] (03CR) 10Nemo bis: [WIP] Make captcha.py produce images in arbitrary language (031 comment) [extensions/ConfirmEdit] - 10https://gerrit.wikimedia.org/r/121255 (owner: 10Nemo bis) [18:35:51] (03Abandoned) 10Ganeshaditya1: Add message wrongpassword as html and remove its reuse in Special:ChangeEmail [core] - 10https://gerrit.wikimedia.org/r/121367 (owner: 10Ganeshaditya1) [18:38:05] (03CR) 10Manybubbles: [C: 032] Update Elastica to v1.0.1.2 [extensions/Elastica] - 10https://gerrit.wikimedia.org/r/121388 (owner: 10Chad) [18:39:59] (03CR) 10Manybubbles: [C: 032] Improve information about Elastica [extensions/Elastica] - 10https://gerrit.wikimedia.org/r/121392 (owner: 10Chad) [18:41:25] (03CR) 10Jdlrobson: Typography update to Vector skin (034 comments) [core] - 10https://gerrit.wikimedia.org/r/120978 (owner: 10Kaldari) [18:42:40] (03PS1) 10BryanDavis: Enable customization of Vagrant and virtual machine [vagrant] - 10https://gerrit.wikimedia.org/r/121425 [18:43:10] (03PS1) 10Jforrester: Update OOjs UI to v0.1.0-pre (e9e435be5e) [core] - 10https://gerrit.wikimedia.org/r/121426 [18:44:19] (03CR) 10Catrope: [C: 032] Update OOjs UI to v0.1.0-pre (e9e435be5e) [core] - 10https://gerrit.wikimedia.org/r/121426 (owner: 10Jforrester) [18:44:31] (03PS1) 10Jforrester: Update OOjs UI to v0.1.0-pre (e9e435be5e) [core] (wmf/1.23wmf20) - 10https://gerrit.wikimedia.org/r/121428 [18:45:56] (03CR) 10Chad: [V: 032] Update Elastica to v1.0.1.2 [extensions/Elastica] - 10https://gerrit.wikimedia.org/r/121388 (owner: 10Chad) [18:46:25] (03CR) 10Chad: [V: 032] Improve information about Elastica [extensions/Elastica] - 10https://gerrit.wikimedia.org/r/121392 (owner: 10Chad) [18:48:50] (03Merged) 10jenkins-bot: Update OOjs UI to v0.1.0-pre (e9e435be5e) [core] - 10https://gerrit.wikimedia.org/r/121426 (owner: 10Jforrester) [18:52:17] (03PS1) 10Catrope: Catch parsing exceptions [extensions/LocalisationUpdate] (wmf/1.23wmf19) - 10https://gerrit.wikimedia.org/r/121429 [18:56:12] (03PS3) 10Kaldari: Follow-up to typography changes to Vector [core] - 10https://gerrit.wikimedia.org/r/121419 [18:57:40] (03CR) 10BryanDavis: "This seems to work pretty well in my local tests. I think it could provide help for roles like fundraising (I01c11eb) and Cirrus (I893b8f4" [vagrant] - 10https://gerrit.wikimedia.org/r/121425 (owner: 10BryanDavis) [19:01:16] (03CR) 10Kaldari: Typography update to Vector skin (031 comment) [core] - 10https://gerrit.wikimedia.org/r/120978 (owner: 10Kaldari) [19:04:45] (03CR) 10Kaldari: "Follow-up commit at https://gerrit.wikimedia.org/r/#/c/121419/" [core] - 10https://gerrit.wikimedia.org/r/120978 (owner: 10Kaldari) [19:05:47] (03CR) 10Mxn: [WIP] Make captcha.py produce images in arbitrary language (032 comments) [extensions/ConfirmEdit] - 10https://gerrit.wikimedia.org/r/121255 (owner: 10Nemo bis) [19:06:02] (03PS1) 10Ottomata: Fixing analytics and hive roles so they work without role::mediawiki [vagrant] - 10https://gerrit.wikimedia.org/r/121431 [19:07:51] (03CR) 10Siebrand: "i18n/L10n reviewed." (031 comment) [extensions/Elastica] - 10https://gerrit.wikimedia.org/r/121392 (owner: 10Chad) [19:09:16] (03PS2) 10Ottomata: Fixing analytics and hive roles so they work without role::mediawiki [vagrant] - 10https://gerrit.wikimedia.org/r/121431 [19:09:42] (03CR) 10Ottomata: [C: 032 V: 032] Fixing analytics and hive roles so they work without role::mediawiki [vagrant] - 10https://gerrit.wikimedia.org/r/121431 (owner: 10Ottomata) [19:10:31] (03Abandoned) 10Umherirrender: Make a single # an invalid title in php and js [core] - 10https://gerrit.wikimedia.org/r/106561 (owner: 10Umherirrender) [19:10:55] (03PS1) 10IAlex: Fix path in findHooks.php script [core] - 10https://gerrit.wikimedia.org/r/121433 [19:12:27] Hi. [19:12:35] Who are the search people? [19:13:23] manybubbles and ^d [19:13:34] <^d> yo [19:13:39] (03PS8) 1001tonythomas: Adding a JS Class to inputBox to grey out Submit button. [extensions/InputBox] - 10https://gerrit.wikimedia.org/r/120487 [19:14:12] ^d: does CirrusSearch use Unicode normalization? [19:14:50] (03PS9) 1001tonythomas: Adding a JS Class to inputBox to grey out Submit button. [extensions/InputBox] - 10https://gerrit.wikimedia.org/r/120487 [19:15:07] <^d> huh: Cirrus doesn't care all that much, it's up to ElasticSearch to handle that. [19:15:18] https://test.wikipedia.org/wiki/Special:Search/C:Real [19:15:24] -> C：Real [19:15:42] hm [19:16:01] <^d> What's wrong with it? [19:16:12] <^d> https://test.wikipedia.org/wiki/Special:Search/~C%EF%BC%9AReal shows the result to me [19:16:33] Nothing wrong with it [19:16:43] (03CR) 10Nemo bis: [WIP] Make captcha.py produce images in arbitrary language (031 comment) [extensions/ConfirmEdit] - 10https://gerrit.wikimedia.org/r/121255 (owner: 10Nemo bis) [19:16:44] <^d> :) [19:17:01] I was trying to find a list of conversions [19:17:22] Maybe I'll check ElasticSearch ... [19:17:29] <^d> I'm not quite sure there. manybubbles? [19:18:44] oh, yeah, that is an open bug about converting some of that stuff [19:18:45] brion: still need you stat1 access ? [19:18:45] so, you are trying to figure out where the word breaks are? [19:18:45] matanya: me? i don’t think so [19:18:57] brion: so i'll remove you. thank you [19:19:00] ok :D [19:20:26] https://github.com/elasticsearch/elasticsearch/blob/ea05f4538ce76f8d200ea94fe68359cd04182e50/docs/reference/analysis/icu-plugin.asciidoc [19:20:31] Is this used? [19:23:17] superm401: hi, still need you stat1 access ? [19:23:49] matanya, I don't think so, let me double-check. [19:24:02] thank you [19:28:17] matanya, actually, I still do, to check EventLogging MySQL data occasionally for troubleshooting. I thought there was another way to do that, apparently not. [19:28:51] cool, thanks superm401 i'll preserve your access [19:39:51] (03CR) 10Siebrand: [C: 031] "i18n/L10n reviewed." [extensions/Flow] - 10https://gerrit.wikimedia.org/r/121306 (owner: 10Wctaiwan) [19:41:26] (03CR) 10Siebrand: [C: 032] Use correct spacing conventions for jshint comment [extensions/Popups] - 10https://gerrit.wikimedia.org/r/121369 (owner: 10Prtksxna) [19:41:34] (03PS1) 10Chad: Remove trailing period [extensions/Elastica] - 10https://gerrit.wikimedia.org/r/121440 [19:42:15] <^d> siebrand: Fixed ^ :) [19:42:44] (03CR) 10Siebrand: [C: 032] "Tx ^d!" [extensions/Elastica] - 10https://gerrit.wikimedia.org/r/121440 (owner: 10Chad) [19:45:22] (03PS1) 10Hoo man: Update Wikidata to fix a problem with SpecialMobileWatchlist [core] (wmf/1.23wmf19) - 10https://gerrit.wikimedia.org/r/121442 [19:46:13] (03CR) 10Yuvipanda: "Needs to be disentangled from the change it is dependent on I think." [extensions/Popups] - 10https://gerrit.wikimedia.org/r/121369 (owner: 10Prtksxna) [19:46:46] (03PS1) 10Hoo man: Update Wikidata to fix a problem with SpecialMobileWatchlist [core] (wmf/1.23wmf20) - 10https://gerrit.wikimedia.org/r/121443 [19:49:04] (03PS1) 10IAlex: Use {{FULLPAGENAME}} in 'missing-revision' message. [core] - 10https://gerrit.wikimedia.org/r/121444 [19:50:51] (03CR) 10Siebrand: [C: 04-1] Added username as parameter to MediaWiki:Comments-reply-to (032 comments) [extensions/Comments] - 10https://gerrit.wikimedia.org/r/118957 (owner: 1001tonythomas) [19:51:28] (03CR) 10Hoo man: [C: 032] Update Wikidata to fix a problem with SpecialMobileWatchlist [core] (wmf/1.23wmf20) - 10https://gerrit.wikimedia.org/r/121443 (owner: 10Hoo man) [19:51:35] (03CR) 10Hoo man: [C: 032] Update Wikidata to fix a problem with SpecialMobileWatchlist [core] (wmf/1.23wmf19) - 10https://gerrit.wikimedia.org/r/121442 (owner: 10Hoo man) [19:53:44] (03CR) 10Siebrand: [C: 032] Use {{FULLPAGENAME}} in 'missing-revision' message. [core] - 10https://gerrit.wikimedia.org/r/121444 (owner: 10IAlex) [19:54:07] heh [19:54:24] yes? [19:54:55] wow, wm-bot works [19:55:20] surprised? [19:55:29] no, not much actually [19:56:42] (03Merged) 10jenkins-bot: Update Wikidata to fix a problem with SpecialMobileWatchlist [core] (wmf/1.23wmf20) - 10https://gerrit.wikimedia.org/r/121443 (owner: 10Hoo man) [19:56:53] (03Merged) 10jenkins-bot: Update Wikidata to fix a problem with SpecialMobileWatchlist [core] (wmf/1.23wmf19) - 10https://gerrit.wikimedia.org/r/121442 (owner: 10Hoo man) [19:57:40] (03Merged) 10jenkins-bot: Use {{FULLPAGENAME}} in 'missing-revision' message. [core] - 10https://gerrit.wikimedia.org/r/121444 (owner: 10IAlex) [19:58:13] (03CR) 10Siebrand: [C: 032] wfMsgForContent breaks regression tests [extensions/Lingo] - 10https://gerrit.wikimedia.org/r/121364 (owner: 10Mwjames) [19:58:33] (03PS1) 10Manybubbles: Scan plugins when building index [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/121446 [19:58:54] (03CR) 10Manybubbles: [V: 032] Remove trailing period [extensions/Elastica] - 10https://gerrit.wikimedia.org/r/121440 (owner: 10Chad) [19:59:42] (03Merged) 10jenkins-bot: wfMsgForContent breaks regression tests [extensions/Lingo] - 10https://gerrit.wikimedia.org/r/121364 (owner: 10Mwjames) [19:59:51] (03CR) 10Swalling: [C: 031] "Tested and works/looks as expected with sup and pre on Firefox and Chrome." [core] - 10https://gerrit.wikimedia.org/r/121419 (owner: 10Kaldari) [20:01:22] (03PS5) 10Krinkle: MWException: Fix sitename appearing twice in [core] - 10https://gerrit.wikimedia.org/r/118665 [20:01:25] <grrrit-wm> (03PS6) 10Krinkle: resourceloader: Separate gathering of registry data from mw.loader call [core] - 10https://gerrit.wikimedia.org/r/117444 [20:01:29] <grrrit-wm> (03PS11) 10Krinkle: resourceloader: Optimize module registry sent in the startup module [core] - 10https://gerrit.wikimedia.org/r/72534 (owner: 10Hoo man) [20:02:48] <grrrit-wm> (03PS6) 10Krinkle: jquery.color.test: Use fake timers [core] - 10https://gerrit.wikimedia.org/r/117150 [20:02:52] <grrrit-wm> (03PS5) 10Krinkle: jquery.makeCollapsible.test: Use fake timers to advance animations [core] - 10https://gerrit.wikimedia.org/r/117153 [20:04:49] <grrrit-wm> (03PS3) 10Krinkle: [WIP] resourceloader: Regression test for bug 62068 [core] - 10https://gerrit.wikimedia.org/r/116143 [20:04:58] <grrrit-wm> (03CR) 10Krinkle: "Rebased to resolve merge conflict with 1a67f2d." [core] - 10https://gerrit.wikimedia.org/r/116143 (owner: 10Krinkle) [20:05:11] <grrrit-wm> (03PS13) 10Krinkle: mediawiki.api: Refactor getToken and postWithToken methods [core] - 10https://gerrit.wikimedia.org/r/111636 [20:05:25] <grrrit-wm> (03PS3) 10Krinkle: [WIP] jshint: Enable 'es3' option [core] - 10https://gerrit.wikimedia.org/r/116527 [20:13:38] <thedj> Krinkle: around ? [20:13:43] <Krinkle> I am [20:13:55] <thedj> Krinkle: got any ideas how to fix editwarning.js ? [20:14:02] <Krinkle> link? context? [20:14:07] <grrrit-wm> (03PS6) 10IAlex: Fixed bug where variables referenced where not reachable (out of scope) [extensions/MassEditRegex] - 10https://gerrit.wikimedia.org/r/97902 (owner: 10Netbrain) [20:14:08] <thedj> for Code editor. [20:14:15] <grrrit-wm> (03CR) 10IAlex: [C: 032 V: 032] Fixed bug where variables referenced where not reachable (out of scope) [extensions/MassEditRegex] - 10https://gerrit.wikimedia.org/r/97902 (owner: 10Netbrain) [20:15:07] <thedj> i basically tried to do the same trick that the old iframe wikieditor was doing, (write the changed contents to the textarea, during the onbeforeunload) but the order of the onbeforeunload handlers is not defined of course, so it's not reliable [20:16:44] <YuviPanda> Deskana: ping [20:16:58] <Deskana> Hey! [20:17:06] <YuviPanda> Deskana: re: CU from mobile, I think they'll be useless anyway. IP is far less unique from mobile carriers, IIRC [20:17:23] <Deskana> YuviPanda: Indeed. So user agent then becomes more important. :) [20:17:30] <grrrit-wm> (03CR) 10jenkins-bot: [V: 04-1] mediawiki.api: Refactor getToken and postWithToken methods [core] - 10https://gerrit.wikimedia.org/r/111636 (owner: 10Krinkle) [20:17:39] <grrrit-wm> (03CR) 10jenkins-bot: [V: 04-1] [WIP] jshint: Enable 'es3' option [core] - 10https://gerrit.wikimedia.org/r/116527 (owner: 10Krinkle) [20:17:50] <YuviPanda> Deskana: true, but if it is fingerprinting on edits that you want for CU, I think we might be able to support that separately [20:17:54] <YuviPanda> s/edits/write actions/ [20:17:59] <Krinkle> thedj: I'm not following. Can you zoom out further? [20:18:13] <Deskana> YuviPanda: Support it separately how? [20:18:28] <thedj> basically, i want to reuse editWarning.js for the codeeditor. [20:18:43] <grrrit-wm> (03PS14) 10Krinkle: mediawiki.api: Refactor getToken and postWithToken methods [core] - 10https://gerrit.wikimedia.org/r/111636 [20:18:51] <thedj> but codeeditor has it's own 'surface' that tneeds to be written back into the textarea before saving [20:19:03] <YuviPanda> Deskana: on every app install, generate a unique token that's sent only for every edit. CU can hook into this and display it? [20:19:07] <thedj> and before closing the window (if you don't save) [20:19:34] <YuviPanda> Deskana: that's a lot more fingerprinty than IP and/or UA, and it'll get captured only by CU and nowhere else [20:19:57] <thedj> but since writing changed content and checking for changed content both needs to happen on document.onbeforeunload, i cannot predict which of those happens first. [20:20:03] <Deskana> YuviPanda: Are there objections to including that information in the user agent? [20:20:29] <YuviPanda> Deskana: I think prime objection (and confusion) is the fact that CU isn't the only thing that consumes UAs [20:20:34] <Deskana> I'm a bit wary of extending checkuser to include a specific method of handling mobile edits. [20:21:00] <YuviPanda> Deskana: I'm sure we can have a hook in CU, and make this happen by hooking into that from Extension:MobileApp. [20:21:04] <thedj> so i'm looking for a way to create a sequence here, without create hard dependencies or anything, and without copying editWarning.js into the codeEditor module, duplicating the logic. [20:21:10] <YuviPanda> Deskana: it can replace UA in CU with UA+Fingerprint [20:21:24] <YuviPanda> Deskana: and that can be deleted / dealt with by regular data retention policies with respect to CU [20:21:38] <YuviPanda> Deskana: and the parts of infrastructure that deal with UAs won't have to deal with it [20:21:41] <Deskana> YuviPanda: As a checkuser, I'd be okay with that. [20:22:14] <thedj> Krinkle: clearer ? [20:22:17] <grrrit-wm> (03CR) 10IAlex: "Sorry for the late reply..." (031 comment) [extensions/Configure] - 10https://gerrit.wikimedia.org/r/77149 (owner: 10Jack Phoenix) [20:22:19] <Deskana> YuviPanda: However, I warn you to be wary. Right now you're not speaking to a product manager at the WMF, you're speaking to a volunteer checkuser. Take what I say with a pinch of salt. :) [20:22:28] <Deskana> YuviPanda: I think it'd be wise to consult with legal. [20:22:31] <Krinkle> thedj: yeah [20:22:45] <YuviPanda> Deskana: we need to split that thread. I think problem is Analytics didn't think of CU as consumer of UA. And Apps is the first time we control the UA from client side [20:22:52] <Krinkle> thedj: I think the ideal situation would be address the way CodeEditor does this syncing in general. [20:22:57] <Krinkle> I recall another bug with this [20:23:01] <YuviPanda> Deskana: oh of course. UA is not part of this sprint or next sprint or anything like that, so I've no idea what I am talking as either :) [20:23:03] <YuviPanda> Deskana: indeed. [20:23:03] <Krinkle> that isn't fixed [20:23:23] <YuviPanda> Deskana: either way, forking that thread sounds appropriate. [20:23:53] <thedj> yeah, but it's often a huge textblock, so it's a bit ineffecient to edit and write continiously (and i can only get the blob from ACE) [20:24:40] <Deskana> YuviPanda: I, personally, think what analytics has failed to consider is that the reaction to "We want this information to track you for analytics purposes" may well be very different from "We want this information to track people abusing our website" [20:24:47] <Deskana> YuviPanda: But that's just my perspective. :) [20:26:04] <thedj> Krinkle: what if i define a data attribute in editwarning, fill it with a function in codeEditor, and then make editwarning run that function if it is set from the beforeunload handler ? [20:26:37] <grrrit-wm> (03CR) 10Bartosz Dziewoński: Typography update to Vector skin (033 comments) [core] - 10https://gerrit.wikimedia.org/r/120978 (owner: 10Kaldari) [20:27:20] <grrrit-wm> (03CR) 10Bartosz Dziewoński: "I left some further comments on the original changeset: https://gerrit.wikimedia.org/r/#/c/120978/3/skins/vector/components/common.less" [core] - 10https://gerrit.wikimedia.org/r/121419 (owner: 10Kaldari) [20:27:30] <YuviPanda> Deskana: :) Indeed, indeed. Plus most people also have no idea what 'CU' is. [20:27:37] <YuviPanda> Deskana: our admin tools are as hidden as they are important [20:27:57] * hoo heard admin tools [20:28:02] * hoo grabs pop corn [20:28:31] <YuviPanda> hoo: CU + UA conversation :) [20:29:02] <YuviPanda> hoo: specifically, http://lists.wikimedia.org/pipermail/mobile-l/2014-March/006759.html and replies [20:29:49] <hoo> ah, I see [20:31:27] <YuviPanda> hoo: so I was suggesting that the apps send a unique fingerprint per device as a separate header only for edit actions, and then there's a hook somewhere that changes UA only for CU from just UA to UA + this fingerprint. [20:32:18] <YuviPanda> hoo: that way the parts of infrastructure that need to deal with UAs don't get tainted, and CU still get its fingerprint [20:32:18] <grrrit-wm> (03CR) 10Bartosz Dziewoński: Typography update to Vector skin (031 comment) [core] - 10https://gerrit.wikimedia.org/r/120978 (owner: 10Kaldari) [20:32:36] <hoo> that sounds workable... although adding more hooks to CheckUser is scary [20:32:54] <YuviPanda> hoo: more important for mobile, since IIRC IP info is practically useless [20:32:59] <grrrit-wm> (03PS1) 10Mwalker: Better WorldPay form settings (but only for testing) [core] (fundraising/REL1_22) - 10https://gerrit.wikimedia.org/r/121504 [20:34:32] <YuviPanda> hoo: so how hard would it be to implement a hook that lets extensions modify what CU considers to be UA? [20:34:55] <YuviPanda> hoo: Deskana let me file a bug for this. [20:34:57] <hoo> if you don't care about code quality not really ahrd [20:35:12] <YuviPanda> hoo: the rest of CU code, how much does it care about code quality atm? ;) [20:35:18] <hoo> there's a single place in CheckUser where you would have to call the hook in [20:35:20] <YuviPanda> (genuine question, I've never looked at it) [20:35:24] <hoo> 0 [20:35:28] <YuviPanda> ah, ok then :) [20:35:42] <Deskana> YuviPanda: Aaron Schulz is a major contributor. You may want to speak to him. :) [20:35:57] <YuviPanda> Deskana: I think I'm too sleepy (+ painkillers :() to be able to write up that forked thread to mobile-l / analytics-l :( [20:36:05] <grrrit-wm> (03CR) 10Kaldari: Typography update to Vector skin (033 comments) [core] - 10https://gerrit.wikimedia.org/r/120978 (owner: 10Kaldari) [20:36:35] <YuviPanda> Deskana: think you can do that at some point in the not-too-distant future? [20:36:37] <grrrit-wm> (03PS2) 10Mwalker: Better WorldPay form settings (but only for testing) [core] (fundraising/REL1_22) - 10https://gerrit.wikimedia.org/r/121504 [20:36:52] <Deskana> YuviPanda: Fork now, though? [20:37:05] <YuviPanda> Deskana: I can start the fork, yeah [20:37:25] <grrrit-wm> (03CR) 10jenkins-bot: [V: 04-1] Better WorldPay form settings (but only for testing) [core] (fundraising/REL1_22) - 10https://gerrit.wikimedia.org/r/121504 (owner: 10Mwalker) [20:45:22] <YuviPanda> Deskana: ok, forked, and wrote the new full proposal as well [20:45:30] <grrrit-wm> (03CR) 10TheDJ: Typography update to Vector skin (032 comments) [core] - 10https://gerrit.wikimedia.org/r/120978 (owner: 10Kaldari) [20:45:33] <MatmaRex> kaldari: ;let me just say that i *really* love how we're discussing all that now that it's been already merged. [20:45:36] <grrrit-wm> (03CR) 10Kaldari: Typography update to Vector skin (031 comment) [core] - 10https://gerrit.wikimedia.org/r/120978 (owner: 10Kaldari) [20:45:41] <MatmaRex> i mean, *really*. [20:45:43] <MatmaRex> awesome job [20:45:53] <MatmaRex> eh [20:46:42] <thedj> wow, i didn't realise that we still didn't have that sub/sup fix in core... [20:47:29] <YuviPanda> Deskana: I'm off to sleep now. Night! [20:48:03] <grrrit-wm> (03PS1) 10Mglaser: SECURITY: Add CSRF token on Special:ChangePassword [core] - 10https://gerrit.wikimedia.org/r/121517 [20:48:35] <Krinkle> marktraceur: https://gerrit.wikimedia.org/r/#/c/121299/1 [20:48:44] <grrrit-wm> (03PS2) 10Krinkle: Add jquery.byteLimit to jsduck [core] - 10https://gerrit.wikimedia.org/r/121276 (owner: 10MarkTraceur) [20:49:31] <marktraceur> Krinkle: Have to put out a fire first [20:50:06] <Deskana> zz_yuvipanda: Good night! :) [20:51:37] <grrrit-wm> (03CR) 10Kaldari: Typography update to Vector skin (031 comment) [core] - 10https://gerrit.wikimedia.org/r/120978 (owner: 10Kaldari) [20:52:54] <grrrit-wm> (03PS3) 10Krinkle: Add jquery.byteLimit to jsduck [core] - 10https://gerrit.wikimedia.org/r/121276 (owner: 10MarkTraceur) [20:52:56] <grrrit-wm> (03CR) 10Krinkle: Add jquery.byteLimit to jsduck (031 comment) [core] - 10https://gerrit.wikimedia.org/r/121276 (owner: 10MarkTraceur) [20:53:00] <grrrit-wm> (03CR) 10Krinkle: [C: 032] Add jquery.byteLimit to jsduck [core] - 10https://gerrit.wikimedia.org/r/121276 (owner: 10MarkTraceur) [20:53:20] <grrrit-wm> (03CR) 10Jdlrobson: [C: 04-1] Follow-up to typography changes to Vector (031 comment) [core] - 10https://gerrit.wikimedia.org/r/121419 (owner: 10Kaldari) [20:54:12] <grrrit-wm> (03CR) 10Kaldari: Follow-up to typography changes to Vector (031 comment) [core] - 10https://gerrit.wikimedia.org/r/121419 (owner: 10Kaldari) [20:54:36] <grrrit-wm> (03CR) 10TheDJ: Typography update to Vector skin (031 comment) [core] - 10https://gerrit.wikimedia.org/r/120978 (owner: 10Kaldari) [20:54:49] <grrrit-wm> (03CR) 10Jdlrobson: Typography update to Vector skin (032 comments) [core] - 10https://gerrit.wikimedia.org/r/120978 (owner: 10Kaldari) [20:56:20] <grrrit-wm> (03PS1) 10Mglaser: SECURITY: Add CSRF token on Special:ChangePassword [core] (REL1_22) - 10https://gerrit.wikimedia.org/r/121518 [20:56:22] <grrrit-wm> (03PS1) 10Mglaser: Updated release notes and version for MediaWiki 1.22.5 [core] (REL1_22) - 10https://gerrit.wikimedia.org/r/121519 [20:57:00] <grrrit-wm> (03PS7) 10JGonera: Use FormData in mw.Api when supported [core] - 10https://gerrit.wikimedia.org/r/116037 [20:57:30] <grrrit-wm> (03CR) 10Jdlrobson: Follow-up to typography changes to Vector (031 comment) [core] - 10https://gerrit.wikimedia.org/r/121419 (owner: 10Kaldari) [20:57:52] <grrrit-wm> (03PS3) 10Krinkle: Add jquery.badge to the jsduck config [core] - 10https://gerrit.wikimedia.org/r/121267 (owner: 10MarkTraceur) [20:58:12] <grrrit-wm> (03PS1) 10Mglaser: SECURITY: Add CSRF token on Special:ChangePassword [core] (REL1_21) - 10https://gerrit.wikimedia.org/r/121520 [20:58:14] <grrrit-wm> (03PS1) 10Mglaser: Updated release notes and version number for MediaWiki 1.21.8 [core] (REL1_21) - 10https://gerrit.wikimedia.org/r/121521 [20:58:26] <grrrit-wm> (03Merged) 10jenkins-bot: Add jquery.byteLimit to jsduck [core] - 10https://gerrit.wikimedia.org/r/121276 (owner: 10MarkTraceur) [20:58:33] <grrrit-wm> (03PS4) 10Krinkle: Add jquery.badge to the jsduck config [core] - 10https://gerrit.wikimedia.org/r/121267 (owner: 10MarkTraceur) [20:58:52] <grrrit-wm> (03CR) 10Krinkle: "Removed link to mw.org page that now points back to doc.wikimedia.org." [core] - 10https://gerrit.wikimedia.org/r/121267 (owner: 10MarkTraceur) [20:59:54] <grrrit-wm> (03PS1) 10Mglaser: SECURITY: Add CSRF token on Special:ChangePassword [core] (REL1_19) - 10https://gerrit.wikimedia.org/r/121523 [20:59:55] <grrrit-wm> (03PS1) 10Mglaser: Updated release notes and version number for MediaWiki 1.19.14 [core] (REL1_19) - 10https://gerrit.wikimedia.org/r/121524 [21:00:34] <grrrit-wm> (03CR) 10jenkins-bot: [V: 04-1] Add jquery.badge to the jsduck config [core] - 10https://gerrit.wikimedia.org/r/121267 (owner: 10MarkTraceur) [21:01:28] <grrrit-wm> (03CR) 10Kaldari: Typography update to Vector skin (031 comment) [core] - 10https://gerrit.wikimedia.org/r/120978 (owner: 10Kaldari) [21:01:46] <grrrit-wm> (03CR) 10Mglaser: [C: 032 V: 032] "Patch is tested and already live on wmf sites" [core] - 10https://gerrit.wikimedia.org/r/121517 (owner: 10Mglaser) [21:03:13] <grrrit-wm> (03PS5) 10Krinkle: Add jquery.badge to the jsduck config [core] - 10https://gerrit.wikimedia.org/r/121267 (owner: 10MarkTraceur) [21:03:22] <grrrit-wm> (03CR) 10Krinkle: [C: 032] Add jquery.badge to the jsduck config [core] - 10https://gerrit.wikimedia.org/r/121267 (owner: 10MarkTraceur) [21:03:58] <grrrit-wm> (03CR) 10jenkins-bot: [V: 04-1] Updated release notes and version for MediaWiki 1.22.5 [core] (REL1_22) - 10https://gerrit.wikimedia.org/r/121519 (owner: 10Mglaser) [21:04:57] <grrrit-wm> (03CR) 10Rillke: "Thanks for your changes, looks better now, however still some little work is required." (031 comment) [extensions/InputBox] - 10https://gerrit.wikimedia.org/r/120487 (owner: 1001tonythomas) [21:05:02] <grrrit-wm> (03CR) 10jenkins-bot: [V: 04-1] Add jquery.badge to the jsduck config [core] - 10https://gerrit.wikimedia.org/r/121267 (owner: 10MarkTraceur) [21:06:13] <grrrit-wm> (03CR) 10jenkins-bot: [V: 04-1] Use FormData in mw.Api when supported [core] - 10https://gerrit.wikimedia.org/r/116037 (owner: 10JGonera) [21:06:32] <grrrit-wm> (03CR) 10Mglaser: [C: 032 V: 032] "CR by Chris Steipp on bugzilla" [core] (REL1_22) - 10https://gerrit.wikimedia.org/r/121518 (owner: 10Mglaser) [21:07:50] <grrrit-wm> (03PS9) 10Stepzhou: Extension which allows sign in with Mozilla Persona. [extensions/Persona] - 10https://gerrit.wikimedia.org/r/112309 (owner: 10Donyu) [21:10:19] <grrrit-wm> (03CR) 10jenkins-bot: [V: 04-1] Add jquery.badge to the jsduck config [core] - 10https://gerrit.wikimedia.org/r/121267 (owner: 10MarkTraceur) [21:10:36] <grrrit-wm> (03CR) 10Stepzhou: "* Added alias localization file to avoid the "Did not find alias for special page" warning." [extensions/Persona] - 10https://gerrit.wikimedia.org/r/112309 (owner: 10Donyu) [21:11:31] <grrrit-wm> (03PS6) 10Krinkle: Add jquery.badge to the jsduck config [core] - 10https://gerrit.wikimedia.org/r/121267 (owner: 10MarkTraceur) [21:11:48] <grrrit-wm> (03CR) 10Krinkle: [C: 032] Add jquery.badge to the jsduck config [core] - 10https://gerrit.wikimedia.org/r/121267 (owner: 10MarkTraceur) [21:13:14] <grrrit-wm> (03CR) 10TheDJ: Follow-up to typography changes to Vector (031 comment) [core] - 10https://gerrit.wikimedia.org/r/121419 (owner: 10Kaldari) [21:13:43] <grrrit-wm> (03CR) 10Mglaser: [C: 032 V: 032] "CR by Chris Steipp on bugzilla" [core] (REL1_21) - 10https://gerrit.wikimedia.org/r/121520 (owner: 10Mglaser) [21:14:11] <grrrit-wm> (03CR) 10Mglaser: [C: 032 V: 032] "CR by Grunny on bugzilla" [core] (REL1_19) - 10https://gerrit.wikimedia.org/r/121523 (owner: 10Mglaser) [21:17:31] <grrrit-wm> (03PS2) 10Mglaser: Updated release notes and version number for MediaWiki 1.22.5 [core] (REL1_22) - 10https://gerrit.wikimedia.org/r/121519 [21:18:16] <grrrit-wm> (03CR) 10Rillke: Use FormData in mw.Api when supported (031 comment) [core] - 10https://gerrit.wikimedia.org/r/116037 (owner: 10JGonera) [21:18:59] <thedj> kaldari: if i remember correctly, the problem is that we currently DONT use unitless lineheight to begin with. [21:19:45] <grrrit-wm> (03CR) 10jenkins-bot: [V: 04-1] Add jquery.badge to the jsduck config [core] - 10https://gerrit.wikimedia.org/r/121267 (owner: 10MarkTraceur) [21:20:11] <grrrit-wm> (03PS2) 10Manybubbles: Enable customization of Vagrant and virtual machine [vagrant] - 10https://gerrit.wikimedia.org/r/121425 (owner: 10BryanDavis) [21:21:01] <grrrit-wm> (03CR) 10JGonera: "Krinkle, can you reply to the comment in the commit message?" (031 comment) [core] - 10https://gerrit.wikimedia.org/r/116037 (owner: 10JGonera) [21:21:04] <grrrit-wm> (03CR) 10Manybubbles: [C: 031] Enable customization of Vagrant and virtual machine [vagrant] - 10https://gerrit.wikimedia.org/r/121425 (owner: 10BryanDavis) [21:23:29] <grrrit-wm> (03CR) 10Mglaser: [C: 032 V: 032] "Release notes and version number: need this to publish the tarball" [core] (REL1_22) - 10https://gerrit.wikimedia.org/r/121519 (owner: 10Mglaser) [21:25:42] <grrrit-wm> (03CR) 10Mglaser: [C: 032 V: 032] "Version and release notes. Need this to publish tarball" [core] (REL1_19) - 10https://gerrit.wikimedia.org/r/121524 (owner: 10Mglaser) [21:25:57] <matanya> Deskana: around ? [21:26:12] <Deskana> matanya: Hey. I sure am. :) [21:27:12] <grrrit-wm> (03CR) 10Mglaser: [C: 032 V: 032] "Release notes and version number. Need this to publish tarball" [core] (REL1_21) - 10https://gerrit.wikimedia.org/r/121521 (owner: 10Mglaser) [21:27:40] <grrrit-wm> (03CR) 10Krinkle: jquery audit of mw.DestinationChecker.js (031 comment) [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/86804 (owner: 10MarkTraceur) [21:30:51] <grrrit-wm> (03PS1) 10Krinkle: mediawiki-core: Change tree to not wait 1.5 minute for phpunit [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/121529 [21:32:44] <matanya> sorry Deskana network issues [21:33:04] <matanya> repeating : Deskana: hello, wanted to let you know hovercard is great! (and report a bug) [21:33:06] <grrrit-wm> (03Merged) 10jenkins-bot: Add jquery.badge to the jsduck config [core] - 10https://gerrit.wikimedia.org/r/121267 (owner: 10MarkTraceur) [21:33:58] <Deskana> matanya: Glad to hear you're enjoying it! :) [21:34:02] <Deskana> matanya: What's your bug? [21:34:16] <matanya> go to any RTL wiki and enable it [21:34:36] <matanya> point at a link, you get the little triangle on the wrong side [21:36:25] <Deskana> matanya: Yeah, we have a few issues with RTL right now. [21:36:36] <matanya> is this reported yet? [21:36:46] <Deskana> matanya: It is, here: https://bugzilla.wikimedia.org/show_bug.cgi?id=62970 [21:36:47] <matanya> or should i open it in bz? [21:36:53] <matanya> thanks [21:39:47] <Deskana> matanya: Thanks! [21:46:13] <grrrit-wm> (03CR) 10Krinkle: [C: 032] mediawiki-core: Change tree to not wait 1.5 minute for phpunit [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/121529 (owner: 10Krinkle) [21:49:02] <grrrit-wm> (03PS2) 10Krinkle: Add jquery.autoEllipsis to jsduck [core] - 10https://gerrit.wikimedia.org/r/121237 (owner: 10MarkTraceur) [21:49:43] <grrrit-wm> (03PS1) 10Jforrester: Update OOjs UI to v0.1.0-pre (23fb1b6144) [core] - 10https://gerrit.wikimedia.org/r/121537 [21:54:28] <grrrit-wm> (03CR) 10Aaron Schulz: [C: 032] Remove unused $wgLicenseTerms [core] - 10https://gerrit.wikimedia.org/r/120860 (owner: 10IAlex) [21:55:19] <grrrit-wm> (03Merged) 10jenkins-bot: mediawiki-core: Change tree to not wait 1.5 minute for phpunit [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/121529 (owner: 10Krinkle) [21:57:43] <grrrit-wm> (03PS4) 10Kaldari: Follow-up to typography changes to Vector [core] - 10https://gerrit.wikimedia.org/r/121419 [22:00:11] <grrrit-wm> (03PS5) 10Ori.livneh: Allow EventLogging events to be logged via mw#track [extensions/EventLogging] - 10https://gerrit.wikimedia.org/r/120757 [22:00:33] <grrrit-wm> (03PS5) 10Nemo bis: Make captcha.py produce images in arbitrary language [extensions/ConfirmEdit] - 10https://gerrit.wikimedia.org/r/121255 [22:03:38] <grrrit-wm> (03PS1) 10EBernhardson: Only use ->parse on i18n messages if required [extensions/Thanks] - 10https://gerrit.wikimedia.org/r/121541 [22:03:47] <grrrit-wm> (03CR) 10Nemo bis: "For now I tested with the following dictionaries provided by Amgine: fj, he, ru, gu. Results look sensible when using a font with adequate" [extensions/ConfirmEdit] - 10https://gerrit.wikimedia.org/r/121255 (owner: 10Nemo bis) [22:06:18] <grrrit-wm> (03PS5) 10Kaldari: Follow-up to typography changes to Vector [core] - 10https://gerrit.wikimedia.org/r/121419 [22:07:46] <grrrit-wm> (03PS3) 10Krinkle: Add jquery.autoEllipsis to jsduck [core] - 10https://gerrit.wikimedia.org/r/121237 (owner: 10MarkTraceur) [22:08:09] <grrrit-wm> (03CR) 10Krinkle: "Rebased against your other marged patches." [core] - 10https://gerrit.wikimedia.org/r/121237 (owner: 10MarkTraceur) [22:08:18] <grrrit-wm> (03CR) 10Krinkle: [C: 032] "Added a few chainables." [core] - 10https://gerrit.wikimedia.org/r/121237 (owner: 10MarkTraceur) [22:09:51] <grrrit-wm> (03Merged) 10jenkins-bot: Remove unused $wgLicenseTerms [core] - 10https://gerrit.wikimedia.org/r/120860 (owner: 10IAlex) [22:11:17] <Krinkle> MatmaRex: Search index can be very fast [22:11:17] <Krinkle> https://github.com/wikimedia/mediawiki-core/search?q=%24wgLicenseTerms&ref=cmdform [22:11:20] <Krinkle> "a minute ago" [22:11:30] <grrrit-wm> (03PS1) 10Hoo man: Update Wikidata to fix the handling of the copyrightpage message [core] (wmf/1.23wmf19) - 10https://gerrit.wikimedia.org/r/121544 [22:11:43] <Krinkle> I guess maybe their equiv. job queue might've been overloaded at some point and they just purged it [22:11:49] <ebernhardson> Krinkle: are there any good ways to debug 'slow loading' from RL? Not as in a problem of RL, but bugs that happen because something from RL hasn't loaded yet. Can i inject a fake pause perhaps? [22:11:51] <Krinkle> any new pushes seem to be immediately indexed though [22:12:21] <grrrit-wm> (03PS1) 10Hoo man: Update Wikidata to fix the handling of the copyrightpage message [core] (wmf/1.23wmf20) - 10https://gerrit.wikimedia.org/r/121545 [22:12:33] <Krinkle> ebernhardson: You mean slowly executing javascript? Or to simulate it having to minify each time? [22:12:35] <grrrit-wm> (03Merged) 10jenkins-bot: Add jquery.autoEllipsis to jsduck [core] - 10https://gerrit.wikimedia.org/r/121237 (owner: 10MarkTraceur) [22:12:48] <Krinkle> so slow load.php responses [22:12:59] <MatmaRex> Krinkle: i think it was hoo who complained about this today, not me :) [22:13:01] <ebernhardson> Krinkle: slow down receiving the javascript, like insert a fake 5s delay before sending it so i can reproduce a bug that only happens before loading [22:13:33] <ebernhardson> hmm, ok i can juist sleep in load.php [22:13:34] <hoo> uh, what? [22:13:41] <Krinkle> ebernhardson: yeah [22:13:50] <Krinkle> ebernhardson: Note though that there's client side caching as well [22:14:03] <Krinkle> aside from 304s, also localStorage [22:14:15] <Krinkle> try sleep(), if not, I got a couple other things you can try. All relatively simple. [22:14:16] <ebernhardson> hmm, thats right [22:14:21] <ebernhardson> ok [22:15:27] <grrrit-wm> (03CR) 10TheDJ: [C: 031] "Looks good to me, was discussed on #wikimedia-tech." [core] - 10https://gerrit.wikimedia.org/r/121419 (owner: 10Kaldari) [22:17:05] <grrrit-wm> (03CR) 10Krinkle: Use rgba() for gallery caption background instead of opacity. (031 comment) [core] - 10https://gerrit.wikimedia.org/r/116227 (owner: 10Brian Wolff) [22:18:31] <grrrit-wm> (03CR) 10Krinkle: [WIP] Add the mw.cookie module (031 comment) [core] - 10https://gerrit.wikimedia.org/r/120806 (owner: 10Phuedx) [22:19:11] <grrrit-wm> (03PS8) 10Krinkle: mediawiki.searchSuggest: Use <ul>/<li> in instead of endless <div>s [core] - 10https://gerrit.wikimedia.org/r/41364 (owner: 10Jarry1250) [22:21:33] <grrrit-wm> (03CR) 10Swalling: [C: 032] "Per TheDJ et al. Seems fine to remove this one minor part, and applying to the sub is low risk as well." [core] - 10https://gerrit.wikimedia.org/r/121419 (owner: 10Kaldari) [22:22:36] <grrrit-wm> (03CR) 10Nemo bis: "Example with Russian: http://imgur.com/a/VVC9H" [extensions/ConfirmEdit] - 10https://gerrit.wikimedia.org/r/121255 (owner: 10Nemo bis) [22:23:39] <grrrit-wm> (03PS2) 10Ori.livneh: Allow schema registration via custom hook [extensions/EventLogging] - 10https://gerrit.wikimedia.org/r/120957 [22:25:19] <hoo> Nemo_bis: Those are on the edge of not being readable :/ [22:29:49] <Nemo_bis> hoo: Niklas read them without difficulty :P [22:30:18] <Nemo_bis> whether they're readable is something we'll need to ask native/fluent speakers [22:30:53] <ebernhardson> jdlrobson: 15:28 < Ryan_Lane1> https://github.com/facebook/huxley <— weren't people looking for something like this recently? [22:31:00] <ebernhardson> (visual diff) [22:31:06] <hoo> I'm not native in ru, but some of these could clearly be different chars [22:31:39] <jdlrobson> ebernhardson: we have a spike to explore this sort of thing [22:31:44] <jdlrobson> not sure if anyone picked it up yet though [22:33:34] <Nemo_bis> hoo: how is https://git.wikimedia.org/blob/mediawiki%2Fextensions%2FAntiSpoof/HEAD/maintenance%2Fequivset.txt generated, other than with smart patches by kaldari ? [22:34:02] <Nemo_bis> (the source of it I mean) [22:34:28] <hoo> Nemo_bis: There's a .in file which has the definitions and a maint. script which can convert that .in file into the .txt one and the other output ones [22:34:37] <Nemo_bis> "The list is based on one by Neil Harris, which was derived by unknown methods" [22:35:08] <Nemo_bis> So it's "magic" [22:35:09] <kaldari> Nemo_bis: Yes, the origins of the file are a bit mysterious :) [22:35:28] <hoo> Nemo_bis: Oh, yes :P We usually just add stuff to it [22:35:30] <kaldari> although at this point it's the .in file plus generateEquivset.php [22:35:38] <grrrit-wm> (03PS1) 10BryanDavis: Delete UIDGenerator cache files after unit tests [core] - 10https://gerrit.wikimedia.org/r/121548 [22:35:43] <grrrit-wm> (03PS1) 10BryanDavis: Make UIDGenerator cache files world writable [core] - 10https://gerrit.wikimedia.org/r/121549 [22:36:46] <Nemo_bis> One day we need Com to interview Neil Harris, the mysterious guy behind the mysterious captcha and antispoof code in use for over ten years at Wikipedia and untouched by anyone else [22:37:36] <kaldari> yeah, who is that guy anyway? [22:37:46] <kaldari> probably works for the NSA :) [22:39:30] <kaldari> Nemo_bis: Just added you to all my ancient unmerged AntiSpoof patches. Mu-ha-ha-ha! [22:39:44] <Nemo_bis> aww [22:40:05] <Nemo_bis> yes, that's why I assumed 1 year time needed to identify the secret location where he lives and ask an interview [22:40:31] <Nemo_bis> kaldari: you can also ad Mxn [22:40:34] <Nemo_bis> * add [22:40:47] <Nemo_bis> he's fantastic for esoteric stuff [22:42:27] <kaldari> Nemo_bis: It seems really odd to me that AntiSpoof doesn't handle ! or $. It seems there must be some reason they were excluded, but for the life of me I haven't been able to find it. [22:42:57] <Nemo_bis> wth Pop_Directional_Format [PDF] Ancient_Greek_Musical_Notation [Ancient_Greek_Music] https://code.google.com/p/mrab-regex-hg/wiki/UnicodeProperties [22:43:40] <Nemo_bis> what character can they be confused with? they look more like something that should be excluded (or not) in core, though last time we added something it was @ and there was some uprise [22:49:10] <grrrit-wm> (03PS1) 10MarkAHershberger: Separate tags from branches [tools/release] - 10https://gerrit.wikimedia.org/r/121552 [22:53:42] <grrrit-wm> (03CR) 10Krinkle: Use FormData in mw.Api when supported (031 comment) [core] - 10https://gerrit.wikimedia.org/r/116037 (owner: 10JGonera) [22:54:05] <grrrit-wm> (03PS20) 10Jdlrobson: Give Vector/Winter Minerva's hamburger menu icon [extensions/VectorBeta] - 10https://gerrit.wikimedia.org/r/117927 [22:54:40] <grrrit-wm> (03PS6) 10Jdlrobson: Hygiene: Cleanup VectorBeta.php resources [extensions/VectorBeta] - 10https://gerrit.wikimedia.org/r/119904 [22:54:44] <grrrit-wm> (03CR) 10Nemo bis: "Mxn, any idea on how to automatically exclude characters that produce confusion in a language-agnostic way? We have to be quite strict, bu" [extensions/ConfirmEdit] - 10https://gerrit.wikimedia.org/r/121255 (owner: 10Nemo bis) [22:55:20] <grrrit-wm> (03CR) 10Patrick87: Follow-up to typography changes to Vector (031 comment) [core] - 10https://gerrit.wikimedia.org/r/121419 (owner: 10Kaldari) [22:58:47] <grrrit-wm> (03CR) 10TheDJ: Follow-up to typography changes to Vector (031 comment) [core] - 10https://gerrit.wikimedia.org/r/121419 (owner: 10Kaldari) [23:00:23] <grrrit-wm> (03CR) 10Kaldari: Follow-up to typography changes to Vector (031 comment) [core] - 10https://gerrit.wikimedia.org/r/121419 (owner: 10Kaldari) [23:09:52] <grrrit-wm> (03PS1) 10Mwalker: Follow-up to typography changes to Vector [core] (wmf/1.23wmf20) - 10https://gerrit.wikimedia.org/r/121554 [23:10:47] <grrrit-wm> (03CR) 10Mwalker: [C: 032] Update OOjs UI to v0.1.0-pre (e9e435be5e) [core] (wmf/1.23wmf20) - 10https://gerrit.wikimedia.org/r/121428 (owner: 10Jforrester) [23:11:00] <grrrit-wm> (03CR) 10Mwalker: [C: 032] Follow-up to typography changes to Vector [core] (wmf/1.23wmf20) - 10https://gerrit.wikimedia.org/r/121554 (owner: 10Mwalker) [23:19:26] <grrrit-wm> (03PS1) 10Mwalker: Updating MultimediaViewer for the 4PM SWAT [core] (wmf/1.23wmf20) - 10https://gerrit.wikimedia.org/r/121555 [23:20:17] <grrrit-wm> (03CR) 10Parent5446: [C: 032 V: 032] Use session_id() instead of $wgSessionStarted to check for session existence [extensions/SecureSessions] - 10https://gerrit.wikimedia.org/r/121246 (owner: 10IAlex) [23:24:18] <grrrit-wm> (03CR) 10Mwalker: [C: 032] Updating MultimediaViewer for the 4PM SWAT [core] (wmf/1.23wmf20) - 10https://gerrit.wikimedia.org/r/121555 (owner: 10Mwalker) [23:27:37] <grrrit-wm> (03CR) 10Mwalker: [C: 032] Catch parsing exceptions [extensions/LocalisationUpdate] (wmf/1.23wmf19) - 10https://gerrit.wikimedia.org/r/121429 (owner: 10Catrope) [23:27:40] <grrrit-wm> (03Merged) 10jenkins-bot: Catch parsing exceptions [extensions/LocalisationUpdate] (wmf/1.23wmf19) - 10https://gerrit.wikimedia.org/r/121429 (owner: 10Catrope) [23:32:34] <grrrit-wm> (03CR) 10Patrick87: Follow-up to typography changes to Vector (031 comment) [core] - 10https://gerrit.wikimedia.org/r/121419 (owner: 10Kaldari) [23:37:40] <grrrit-wm> (03PS1) 10TheDJ: Edit warning should get value from editors [core] - 10https://gerrit.wikimedia.org/r/121558 [23:37:49] <grrrit-wm> (03CR) 10Mwalker: [C: 032] Update Wikidata to fix the handling of the copyrightpage message [core] (wmf/1.23wmf20) - 10https://gerrit.wikimedia.org/r/121545 (owner: 10Hoo man) [23:37:54] <grrrit-wm> (03CR) 10Mwalker: [C: 032] Update Wikidata to fix the handling of the copyrightpage message [core] (wmf/1.23wmf19) - 10https://gerrit.wikimedia.org/r/121544 (owner: 10Hoo man) [23:39:29] <grrrit-wm> (03PS1) 10TheDJ: CodeEditor: Support warning for unsaved changes [extensions/CodeEditor] - 10https://gerrit.wikimedia.org/r/121559 [23:40:38] <grrrit-wm> (03PS2) 10TheDJ: [Do not merge] Support warning for unsaved changes [extensions/CodeEditor] - 10https://gerrit.wikimedia.org/r/121559 [23:42:25] <zeek_> Hi Krinkle: :) Please have a look at the last PS i submitted yesterday on JShint. https://gerrit.wikimedia.org/r/121257 [23:42:55] <grrrit-wm> (03CR) 10Parent5446: [C: 032] Fix path in findHooks.php script [core] - 10https://gerrit.wikimedia.org/r/121433 (owner: 10IAlex) [23:44:21] <grrrit-wm> (03CR) 10jenkins-bot: [V: 04-1] Edit warning should get value from editors [core] - 10https://gerrit.wikimedia.org/r/121558 (owner: 10TheDJ) [23:47:12] <grrrit-wm> (03PS1) 10Mwalker: Updating LocalizationUpdate for SWAT [core] (wmf/1.23wmf19) - 10https://gerrit.wikimedia.org/r/121560 [23:47:25] <grrrit-wm> (03CR) 10Mwalker: [C: 032] Updating LocalizationUpdate for SWAT [core] (wmf/1.23wmf19) - 10https://gerrit.wikimedia.org/r/121560 (owner: 10Mwalker) [23:48:08] <grrrit-wm> (03PS1) 10MarkAHershberger: restructure getGit so that extensions get the release branch [tools/release] - 10https://gerrit.wikimedia.org/r/121561 [23:48:28] <grrrit-wm> (03PS2) 10TheDJ: Edit warning should get value from editors [core] - 10https://gerrit.wikimedia.org/r/121558 [23:51:16] <grrrit-wm> (03CR) 10Krinkle: LiquidThreads should pass jshint (031 comment) [extensions/LiquidThreads] - 10https://gerrit.wikimedia.org/r/121257 (owner: 10Adi.iiita) [23:51:22] <grrrit-wm> (03Merged) 10jenkins-bot: Fix path in findHooks.php script [core] - 10https://gerrit.wikimedia.org/r/121433 (owner: 10IAlex) [23:51:32] <grrrit-wm> (03PS21) 10Kaldari: Give Vector/Winter Minerva's hamburger menu icon [extensions/VectorBeta] - 10https://gerrit.wikimedia.org/r/117927 (owner: 10Jdlrobson) [23:52:26] <grrrit-wm> (03CR) 10Mglaser: [C: 032 V: 032] "Need this for the release, which will be the final test..." [tools/release] - 10https://gerrit.wikimedia.org/r/121552 (owner: 10MarkAHershberger) [23:52:29] <grrrit-wm> (03CR) 10Mglaser: [C: 032 V: 032] "Need this for the release, which will be the final test..." [tools/release] - 10https://gerrit.wikimedia.org/r/121561 (owner: 10MarkAHershberger) [23:52:39] <grrrit-wm> (03CR) 10Kaldari: "Tweaked hamburger CSS to take into account that we aren't using the evil negative margins in Winter." [extensions/VectorBeta] - 10https://gerrit.wikimedia.org/r/117927 (owner: 10Jdlrobson) [23:52:59] <grrrit-wm> (03CR) 10Kaldari: [C: 032] Give Vector/Winter Minerva's hamburger menu icon [extensions/VectorBeta] - 10https://gerrit.wikimedia.org/r/117927 (owner: 10Jdlrobson) [23:53:46] <grrrit-wm> (03Merged) 10jenkins-bot: Updating LocalizationUpdate for SWAT [core] (wmf/1.23wmf19) - 10https://gerrit.wikimedia.org/r/121560 (owner: 10Mwalker) [23:55:26] <Krinkle> Get that HEAD out of attachment and start branching. [23:55:56] <grrrit-wm> (03Merged) 10jenkins-bot: Give Vector/Winter Minerva's hamburger menu icon [extensions/VectorBeta] - 10https://gerrit.wikimedia.org/r/117927 (owner: 10Jdlrobson)