[00:12:03] (03PS1) 10Krinkle: readme: Fix rendering of Markdown syntax [extensions/NavigationTiming] - 10https://gerrit.wikimedia.org/r/120967 [00:14:12] (03PS1) 10Robmoen: Add missing messages to RL module [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/120968 [00:15:48] (03PS2) 10JGonera: Stop make kss from opening browser [core] - 10https://gerrit.wikimedia.org/r/117108 [00:19:05] does anyone offer MediaWiki hosting with VisualEditor (and Flow?) This teacher wants it http://www.kidsopenbook.com/core3 [00:20:11] (03CR) 10Springle: [C: 04-1] "LIMIT won't help with COUNT(*)" [extensions/VectorBeta] - 10https://gerrit.wikimedia.org/r/116920 (owner: 10JGonera) [00:20:52] jgonera: always tricky, counting stuff :) [00:21:08] springle, yeah, I know [00:21:41] often you can just have a counter, but here it's not that simple [00:21:52] yes, your join makes it complex [00:22:12] using the sub-query can alleviate the count somewhat [00:25:39] (03PS1) 10Krinkle: Various minor code quality fixes and clean up [extensions/NavigationTiming] - 10https://gerrit.wikimedia.org/r/120973 [00:25:48] (03CR) 10Krinkle: "Untested." [extensions/NavigationTiming] - 10https://gerrit.wikimedia.org/r/120973 (owner: 10Krinkle) [00:26:50] (03PS1) 10CSteipp: Allow copying DAO objects [extensions/OAuth] - 10https://gerrit.wikimedia.org/r/120974 [00:30:00] springle, I was wondering if I can just check if for each item in table watchlist there is at least one row in table recentchanges satisfying condition X [00:30:30] springle, basically, this number should give a user some indication of how many pages changed recently in their watchlist [00:30:44] (recently = in the last X days) [00:30:58] that's why I need recentchanges table too, not only watchlist [00:32:57] (03PS3) 10Mattflaschen: Stop the rightmost toolbar section wrapping [extensions/GettingStarted] - 10https://gerrit.wikimedia.org/r/117874 (owner: 10Phuedx) [00:34:15] jgonera: queries in a loop isn't a thrilling idea. can you condense it into a single batch lookup? WHERE ... IN (table items) [00:34:39] springle, I don't want to do queries in a loop ;) [00:34:58] great! sorry, i misunderstood :) [00:35:12] maybe I can, I'll think more about this query and let you know if I come up with something [00:35:17] thanks for the suggestions! [00:35:32] does watchlist need an id? [00:35:41] might make this sort of thing easier [00:36:11] hmm no, maybe that's not relevant here [00:48:30] springle, do you mean a surrogate id? [00:49:04] jgonera: yes. but it wouldn't help the join [00:55:15] (03CR) 10Parent5446: Fix/update inline documentation in WikiPage class (031 comment) [core] - 10https://gerrit.wikimedia.org/r/120841 (owner: 10Thiemo Mättig (WMDE)) [00:57:39] (03CR) 10Alex Monk: [C: 04-1] "This is not ready for review yet" [extensions/Cite] - 10https://gerrit.wikimedia.org/r/120962 (owner: 10Alex Monk) [00:59:30] (03CR) 10Parent5446: "I just tested this on vagrant and it delivered the correct status code of 429. What configuration exactly causes it to fall back to 500?" [core] - 10https://gerrit.wikimedia.org/r/120765 (owner: 10Faidon Liambotis) [01:04:32] (03CR) 10MaxSem: "Sean, will the resulting query be appropriate for running it upon every logged-in page view?" [extensions/VectorBeta] - 10https://gerrit.wikimedia.org/r/116920 (owner: 10JGonera) [01:06:33] (03CR) 10Bsitu: Make BoardHistory a Formatter instance (032 comments) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/115532 (owner: 10EBernhardson) [01:09:07] (03PS17) 10Bsitu: Make BoardHistory a Formatter instance [extensions/Flow] - 10https://gerrit.wikimedia.org/r/115532 (owner: 10EBernhardson) [01:09:11] (03CR) 10jenkins-bot: [V: 04-1] Make BoardHistory a Formatter instance [extensions/Flow] - 10https://gerrit.wikimedia.org/r/115532 (owner: 10EBernhardson) [01:13:10] (03PS20) 10Yurik: Initial implementation of the JSON configuration store. [extensions/JsonConfig] - 10https://gerrit.wikimedia.org/r/98767 [01:13:52] (03CR) 10Yurik: Initial implementation of the JSON configuration store. (037 comments) [extensions/JsonConfig] - 10https://gerrit.wikimedia.org/r/98767 (owner: 10Yurik) [01:14:18] (03CR) 10Yurik: Initial implementation of the JSON configuration store. (031 comment) [extensions/JsonConfig] - 10https://gerrit.wikimedia.org/r/98767 (owner: 10Yurik) [01:18:30] (03CR) 10Bsitu: Refactor Flow\\Formatter namespace (031 comment) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/117384 (owner: 10EBernhardson) [01:19:39] (03PS1) 10Kaldari: Typography update to Vector skin [core] - 10https://gerrit.wikimedia.org/r/120978 [01:29:04] (03CR) 10Mattflaschen: [C: 04-1] "It seems to make the x button invisible in IE 7, regardless of the resolution. It was already almost off the edge, but this pushes it all" [extensions/GettingStarted] - 10https://gerrit.wikimedia.org/r/117874 (owner: 10Phuedx) [01:40:37] (03CR) 10Springle: "I was thinking something like this:" [extensions/VectorBeta] - 10https://gerrit.wikimedia.org/r/116920 (owner: 10JGonera) [01:50:57] (03CR) 10Springle: "Another thing: We have the 'watchlist' query load balancing group for wfGetDB. This should use it." [extensions/VectorBeta] - 10https://gerrit.wikimedia.org/r/116920 (owner: 10JGonera) [01:57:11] (03CR) 10MaxSem: "Extra 0.25-0.35s is a lot from a UX perspective, even if cached - the cache can't be very long because otherwise this number will lose its" [extensions/VectorBeta] - 10https://gerrit.wikimedia.org/r/116920 (owner: 10JGonera) [01:57:44] (03PS3) 10thibaultmarin: A few improvements (windows compatibility): [extensions/PGFTikZ] - 10https://gerrit.wikimedia.org/r/120750 [02:07:53] (03CR) 10MZMcBride: "Does this have an associated bug report? I'd be interested in reading further discussion about this. I'm not sure I fully understand why y" [extensions/VectorBeta] - 10https://gerrit.wikimedia.org/r/116920 (owner: 10JGonera) [02:10:24] (03PS4) 10thibaultmarin: A few improvements (windows compatibility): [extensions/PGFTikZ] - 10https://gerrit.wikimedia.org/r/120750 [02:11:13] (03CR) 10Springle: "Fair point." [extensions/VectorBeta] - 10https://gerrit.wikimedia.org/r/116920 (owner: 10JGonera) [02:11:18] (03CR) 10thibaultmarin: A few improvements (windows compatibility): (033 comments) [extensions/PGFTikZ] - 10https://gerrit.wikimedia.org/r/120750 (owner: 10thibaultmarin) [02:24:30] (03PS1) 10Luis Felipe Schenone: Putting back several translations that where somehow lost [extensions/DisqusTag] - 10https://gerrit.wikimedia.org/r/120981 [02:36:20] (03CR) 10MaxSem: "Anyway, the solution with limits is problematic because active users will just always see the count of 100. We could remember time since t" [extensions/VectorBeta] - 10https://gerrit.wikimedia.org/r/116920 (owner: 10JGonera) [02:39:32] (03CR) 10Mattflaschen: [C: 04-1] "I forgot last time that (if we take the approach of changing the config format as I suggested last time) this code does need to be updated" (031 comment) [extensions/GettingStarted] - 10https://gerrit.wikimedia.org/r/118063 (owner: 10Phuedx) [02:45:50] (03CR) 10Springle: "Agree that it's complex and maybe not a useful concept overall. Though <0.1s is about as good as it gets for queries ;-)" [extensions/VectorBeta] - 10https://gerrit.wikimedia.org/r/116920 (owner: 10JGonera) [02:55:49] (03CR) 10MaxSem: [C: 04-2] "Per discussion, while it's technically possible, the limitations would make it useless enough to not justify the additional DB load." [extensions/VectorBeta] - 10https://gerrit.wikimedia.org/r/116920 (owner: 10JGonera) [03:03:39] (03CR) 10Swalling: [C: 031] "Tested and working, meets specification from mediawiki.org. Announcements are all going out/ready. I think we're good to go. :)" [core] - 10https://gerrit.wikimedia.org/r/120978 (owner: 10Kaldari) [03:06:41] (03PS1) 10Luis Felipe Schenone: Updated, organized, cleaned and improved the code previously available only at mediawiki.org [extensions/NukeDPL] - 10https://gerrit.wikimedia.org/r/120983 [03:08:10] (03PS2) 10Luis Felipe Schenone: Initial commit [extensions/NukeDPL] - 10https://gerrit.wikimedia.org/r/120983 [03:09:21] (03CR) 10Luis Felipe Schenone: [C: 032 V: 032] "I've tested the code quite enough. It works fine." [extensions/NukeDPL] - 10https://gerrit.wikimedia.org/r/120983 (owner: 10Luis Felipe Schenone) [03:16:40] (03PS1) 10Mattflaschen: Fix custom local MediaWiki:Helppage values [core] - 10https://gerrit.wikimedia.org/r/120986 [03:17:18] (03PS1) 10Luis Felipe Schenone: Changed right 'nukeDPL' for 'nuke' [extensions/NukeDPL] - 10https://gerrit.wikimedia.org/r/120987 [03:17:23] (03CR) 10Springle: "@Pawanseerwani, The historical decision to use varbinary, while understandable at the time, is now hurting us, IMO. But that's a battle fo" [core] - 10https://gerrit.wikimedia.org/r/110949 (owner: 10Gerrit Patch Uploader) [03:17:39] (03CR) 10Luis Felipe Schenone: [C: 032 V: 032] "Very simple change" [extensions/NukeDPL] - 10https://gerrit.wikimedia.org/r/120987 (owner: 10Luis Felipe Schenone) [03:18:47] (03CR) 10Mattflaschen: "> Edit intro doesn't work with custom local pages. When MediaWiki:helppage has Devwiki:The help page, it displays as "(see the [/wiki/Devw" [core] - 10https://gerrit.wikimedia.org/r/83221 (owner: 10Nemo bis) [03:21:34] (03CR) 10Mattflaschen: "Test with any custom local page. I.E., put something like:" [core] - 10https://gerrit.wikimedia.org/r/120986 (owner: 10Mattflaschen) [03:25:27] (03CR) 10Chad: "Some nits, otherwise ok." (033 comments) [core] - 10https://gerrit.wikimedia.org/r/120335 (owner: 10Siebrand) [03:44:13] (03CR) 10MaxSem: [C: 04-1] "Withdrawing my -2 after discussing this with Sean. Still not very optimistic though:)" [extensions/VectorBeta] - 10https://gerrit.wikimedia.org/r/116920 (owner: 10JGonera) [04:15:08] (03PS8) 1001tonythomas: Error Msg for missing db username & password when installing [core] - 10https://gerrit.wikimedia.org/r/118798 (owner: 10Pubudu538) [04:40:55] (03CR) 10Mattflaschen: "Several of them do, but not all (I encourage designers to signup for Gerrit). I've added Pau Giner and Moiz Syed." [core] - 10https://gerrit.wikimedia.org/r/119998 (owner: 10TheDJ) [04:46:19] (03CR) 10Mattflaschen: "See bugfix to this patch at https://gerrit.wikimedia.org/r/120986 . Hasn't been cherry-picked yet." [core] (REL1_22) - 10https://gerrit.wikimedia.org/r/119947 (owner: 10Nemo bis) [04:55:21] (03PS7) 1001tonythomas: Adding a JS Class to inputBox to grey out Submit button. [extensions/InputBox] - 10https://gerrit.wikimedia.org/r/120487 [04:58:01] (03CR) 10Mattflaschen: [C: 04-1] "The actual idea of the commit seems fine (have not reviewed so far), but see inline regarding why I don't favor the approach of putting th" (031 comment) [extensions/EventLogging] - 10https://gerrit.wikimedia.org/r/120757 (owner: 10Ori.livneh) [05:04:37] (03CR) 10Mattflaschen: "I also recommend you use the closure, both so someone doesn't accidentally create a global (e.g. by setting a constant before the load reg" (031 comment) [extensions/EventLogging] - 10https://gerrit.wikimedia.org/r/120757 (owner: 10Ori.livneh) [06:08:17] (03CR) 10KartikMistry: [C: 032] "LGTM" [services/cxserver] - 10https://gerrit.wikimedia.org/r/119931 (owner: 10Santhosh) [06:08:21] (03Merged) 10jenkins-bot: Segmentation: Add test for figure tags [services/cxserver] - 10https://gerrit.wikimedia.org/r/119931 (owner: 10Santhosh) [06:13:58] Hi. Quick question. Are recent versions of mediawiki more of: optimizations, more features, or bugfixes? [06:14:22] depends [06:14:39] yeah, not the answer I'm looking for. [06:14:41] pretty much all three are present in major releases [06:14:55] we don't generally introduce that many /major/ new features these days [06:15:01] but we do introduce new ones [06:15:51] What about optimizations and bugfixes? [06:20:16] (03CR) 10Wikinaut: [C: 04-2] "Hi, thanks for your patch, but your patch is not needed, You can simply set the MediaWiki:ajaxpoll-tracking-category text string to "-" (m" [extensions/AJAXPoll] - 10https://gerrit.wikimedia.org/r/117254 (owner: 10GeorgeBarnick) [06:20:36] there are always bugfixes [06:20:45] quite a lot actually [06:21:53] (03CR) 10KartikMistry: [C: 032] "LGTM." [services/cxserver] - 10https://gerrit.wikimedia.org/r/119969 (owner: 10Santhosh) [06:21:55] (03Merged) 10jenkins-bot: Segmentation: Handle all section types [services/cxserver] - 10https://gerrit.wikimedia.org/r/119969 (owner: 10Santhosh) [06:23:56] (03Abandoned) 10Wikinaut: Adding config variable to toggle tracking category [extensions/AJAXPoll] - 10https://gerrit.wikimedia.org/r/117254 (owner: 10GeorgeBarnick) [06:37:15] (03CR) 10KartikMistry: [C: 032] "LGTM." [services/cxserver] - 10https://gerrit.wikimedia.org/r/120773 (owner: 10Santhosh) [06:37:18] (03Merged) 10jenkins-bot: Correct the entity escaping and restore parsoid data attribute [services/cxserver] - 10https://gerrit.wikimedia.org/r/120773 (owner: 10Santhosh) [07:06:25] (03PS2) 10Apsdehal: Adds onlyinprint class to shared css [core] - 10https://gerrit.wikimedia.org/r/120865 [07:17:33] (03PS1) 10Nikerabbit: Catch parsing exceptions [extensions/LocalisationUpdate] - 10https://gerrit.wikimedia.org/r/120995 [07:24:46] (03CR) 10KartikMistry: [V: 031] "LGTM." [extensions/LocalisationUpdate] - 10https://gerrit.wikimedia.org/r/120995 (owner: 10Nikerabbit) [07:31:15] (03PS2) 10Robert Vogel: includes/Linker.php: Added hook for "Media:" links [core] - 10https://gerrit.wikimedia.org/r/120767 [08:06:50] (03CR) 10Hashar: [C: 032] "Congratulations and thanks for the code hygiene!" [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/120954 (owner: 10TheDJ) [08:06:58] (03Merged) 10jenkins-bot: CodeEditor now passes jslint, so make it voting [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/120954 (owner: 10TheDJ) [08:41:42] (03PS2) 10Siebrand: Set visibility for some methods and remove unused ones [core] - 10https://gerrit.wikimedia.org/r/120335 [08:43:45] (03PS3) 10Siebrand: Set visibility for some methods and remove unused ones [core] - 10https://gerrit.wikimedia.org/r/120335 [08:44:43] (03CR) 10Siebrand: "Thanks for the review. Addressed comments. May I request that you please score -1 if something is blocking you from merging? Makes it more" (033 comments) [core] - 10https://gerrit.wikimedia.org/r/120335 (owner: 10Siebrand) [08:45:24] (03PS2) 10Siebrand: Fix CodeSniffer errors and warnings in includes/specials (2) [core] - 10https://gerrit.wikimedia.org/r/120330 [08:49:09] (03PS1) 10Siebrand: Migrate to JSON i18n [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/121005 [08:51:27] (03PS1) 10Siebrand: Migrate to JSON i18n [extensions/CharInsert] - 10https://gerrit.wikimedia.org/r/121006 [08:55:44] (03CR) 10Raimond Spekking: "i18n review" (036 comments) [extensions/NukeDPL] - 10https://gerrit.wikimedia.org/r/120983 (owner: 10Luis Felipe Schenone) [09:01:52] (03PS1) 10Siebrand: Migrate to JSON i18n [extensions/CheckUser] - 10https://gerrit.wikimedia.org/r/121007 [09:03:02] (03PS1) 10Siebrand: Migrate to JSON i18n [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/121008 [09:06:49] (03PS1) 10Siebrand: Migrate to JSON i18n [extensions/Cite] - 10https://gerrit.wikimedia.org/r/121010 [09:08:15] (03PS1) 10Siebrand: Migrate to JSON i18n [extensions/cldr] - 10https://gerrit.wikimedia.org/r/121011 [09:08:56] (03CR) 10Hashar: "Thank you!" [tools/scap] - 10https://gerrit.wikimedia.org/r/120936 (owner: 10Hashar) [09:10:17] (03PS1) 10Siebrand: Migrate to JSON i18n [extensions/CleanChanges] - 10https://gerrit.wikimedia.org/r/121013 [09:11:33] (03PS1) 10Siebrand: Migrate to JSON i18n [extensions/ClientSide] - 10https://gerrit.wikimedia.org/r/121014 [09:12:55] (03PS1) 10Siebrand: Migrate to JSON i18n [extensions/CodeEditor] - 10https://gerrit.wikimedia.org/r/121015 [09:14:14] (03PS1) 10Siebrand: Migrate to JSON i18n [extensions/CodeReview] - 10https://gerrit.wikimedia.org/r/121016 [09:15:28] (03CR) 10Hashar: "Might want to move the sorted() in the called function but I am not sure whether python will keep the sort order." (031 comment) [tools/scap] - 10https://gerrit.wikimedia.org/r/120961 (owner: 10BryanDavis) [09:17:59] (03PS1) 10Siebrand: Add jobs for CirrusSearch extension [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/121017 [09:18:04] (03CR) 10jenkins-bot: [V: 04-1] Add jobs for CirrusSearch extension [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/121017 (owner: 10Siebrand) [09:19:23] (03Abandoned) 10Siebrand: Add jobs for CirrusSearch extension [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/121017 (owner: 10Siebrand) [09:24:26] StevenW: Got a minute to talk about GettingStarted? [09:34:11] (03PS3) 10Hashar: beta: Use scap-recompile from the scap git repo [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/120937 [09:37:00] (03CR) 10Hashar: [C: 032] "The scap fix in https://gerrit.wikimedia.org/r/#/c/120936/ got merged in. Texvc recompile properly now https://integration.wikimedia.org/c" [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/120937 (owner: 10Hashar) [09:37:13] (03CR) 10jenkins-bot: [V: 04-1] Migrate to JSON i18n [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/121008 (owner: 10Siebrand) [09:37:36] (03Merged) 10jenkins-bot: beta: Use scap-recompile from the scap git repo [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/120937 (owner: 10Hashar) [09:38:23] (03PS1) 10Hashar: beta: only recompile texvc for change on master [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/121020 [09:38:40] (03CR) 10Siebrand: "Test failure is not related to this change. I'll add a .jshintignore entry." [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/121008 (owner: 10Siebrand) [09:38:56] (03PS2) 10Hashar: beta: only recompile texvc for change on master [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/121020 [09:39:26] (03CR) 10Hashar: [C: 032] beta: only recompile texvc for change on master [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/121020 (owner: 10Hashar) [09:39:31] (03Merged) 10jenkins-bot: beta: only recompile texvc for change on master [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/121020 (owner: 10Hashar) [09:41:30] (03PS2) 10Hashar: beta: compile texvc on both datacenters [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/120940 [09:43:42] (03PS2) 10Siebrand: Migrate to JSON i18n [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/121008 [09:49:03] (03PS1) 10Grunny: Migrate to JSON i18n [extensions/BatchUserRights] - 10https://gerrit.wikimedia.org/r/121021 [09:52:47] (03PS3) 10Hashar: beta: compile texvc on both datacenters [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/120940 [09:52:55] (03CR) 10Hashar: [C: 032] beta: compile texvc on both datacenters [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/120940 (owner: 10Hashar) [09:54:01] (03Merged) 10jenkins-bot: beta: compile texvc on both datacenters [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/120940 (owner: 10Hashar) [09:57:21] (03CR) 10Nikerabbit: [C: 032] Migrate to JSON i18n [extensions/CharInsert] - 10https://gerrit.wikimedia.org/r/121006 (owner: 10Siebrand) [09:57:22] (03Merged) 10jenkins-bot: Migrate to JSON i18n [extensions/CharInsert] - 10https://gerrit.wikimedia.org/r/121006 (owner: 10Siebrand) [10:02:01] gerrit down for me [10:05:06] interestingly, it WFM in one browser and not in another one [10:05:48] works now but slowwwwwwww [10:07:42] (03CR) 10Nikerabbit: [C: 032] Migrate to JSON i18n (031 comment) [extensions/cldr] - 10https://gerrit.wikimedia.org/r/121011 (owner: 10Siebrand) [10:07:46] works again [10:07:48] (03Merged) 10jenkins-bot: Migrate to JSON i18n [extensions/cldr] - 10https://gerrit.wikimedia.org/r/121011 (owner: 10Siebrand) [10:08:37] (03CR) 10Nikerabbit: [C: 032] Migrate to JSON i18n [extensions/CleanChanges] - 10https://gerrit.wikimedia.org/r/121013 (owner: 10Siebrand) [10:08:39] (03Merged) 10jenkins-bot: Migrate to JSON i18n [extensions/CleanChanges] - 10https://gerrit.wikimedia.org/r/121013 (owner: 10Siebrand) [10:08:50] (03CR) 10Faidon Liambotis: "I admit I haven't tested the patch itself -- I have no testing rig and it doesn't look easy to reproduce." [core] - 10https://gerrit.wikimedia.org/r/120765 (owner: 10Faidon Liambotis) [10:13:02] (03CR) 10Raimond Spekking: [C: 032] Migrate to JSON i18n [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/121005 (owner: 10Siebrand) [10:13:07] (03Merged) 10jenkins-bot: Migrate to JSON i18n [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/121005 (owner: 10Siebrand) [10:14:44] (03CR) 10Raimond Spekking: [C: 032] Migrate to JSON i18n [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/121008 (owner: 10Siebrand) [10:15:06] (03Merged) 10jenkins-bot: Migrate to JSON i18n [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/121008 (owner: 10Siebrand) [10:16:26] (03CR) 10Siebrand: [C: 04-1] "Thanks for the help. 1 comment inline." (031 comment) [extensions/BatchUserRights] - 10https://gerrit.wikimedia.org/r/121021 (owner: 10Grunny) [10:16:48] (03CR) 10Raimond Spekking: [C: 031] Migrate to JSON i18n (031 comment) [extensions/CodeReview] - 10https://gerrit.wikimedia.org/r/121016 (owner: 10Siebrand) [10:18:15] (03CR) 10Raimond Spekking: [C: 032] Migrate to JSON i18n [extensions/ClientSide] - 10https://gerrit.wikimedia.org/r/121014 (owner: 10Siebrand) [10:18:22] (03Merged) 10jenkins-bot: Migrate to JSON i18n [extensions/ClientSide] - 10https://gerrit.wikimedia.org/r/121014 (owner: 10Siebrand) [10:21:14] gerrit down again [10:23:18] very intermittent [10:27:29] (03PS2) 10Grunny: Migrate to JSON i18n [extensions/BatchUserRights] - 10https://gerrit.wikimedia.org/r/121021 [10:29:58] (03CR) 10Grunny: Migrate to JSON i18n (031 comment) [extensions/BatchUserRights] - 10https://gerrit.wikimedia.org/r/121021 (owner: 10Grunny) [10:31:24] (03CR) 10Raimond Spekking: [C: 032] Migrate to JSON i18n [extensions/CheckUser] - 10https://gerrit.wikimedia.org/r/121007 (owner: 10Siebrand) [10:31:50] (03Merged) 10jenkins-bot: Migrate to JSON i18n [extensions/CheckUser] - 10https://gerrit.wikimedia.org/r/121007 (owner: 10Siebrand) [10:34:04] (03CR) 10Raimond Spekking: [C: 032] Migrate to JSON i18n [extensions/Cite] - 10https://gerrit.wikimedia.org/r/121010 (owner: 10Siebrand) [10:34:25] (03CR) 10Raimond Spekking: [C: 032] Migrate to JSON i18n [extensions/CodeEditor] - 10https://gerrit.wikimedia.org/r/121015 (owner: 10Siebrand) [10:35:32] (03Merged) 10jenkins-bot: Migrate to JSON i18n [extensions/CodeEditor] - 10https://gerrit.wikimedia.org/r/121015 (owner: 10Siebrand) [10:36:04] (03Merged) 10jenkins-bot: Migrate to JSON i18n [extensions/Cite] - 10https://gerrit.wikimedia.org/r/121010 (owner: 10Siebrand) [10:39:46] (03CR) 10Raimond Spekking: [C: 032] Migrate to JSON i18n [extensions/CodeReview] - 10https://gerrit.wikimedia.org/r/121016 (owner: 10Siebrand) [10:42:38] (03PS2) 10Siebrand: [WIP] Convert core messages to JSON i18n format [core] - 10https://gerrit.wikimedia.org/r/119658 [10:42:44] (03Merged) 10jenkins-bot: Migrate to JSON i18n [extensions/CodeReview] - 10https://gerrit.wikimedia.org/r/121016 (owner: 10Siebrand) [10:43:12] (03CR) 10Siebrand: "Automated the procedure on my side a bit. Rebuilt everything, and made some changes in Language.php. Haven't tested yet." [core] - 10https://gerrit.wikimedia.org/r/119658 (owner: 10Siebrand) [10:48:01] anyone happen to know what is entailed in backporting an extension for deploy? [10:48:11] (03CR) 10Siebrand: Migrate to JSON i18n (031 comment) [extensions/CodeReview] - 10https://gerrit.wikimedia.org/r/121016 (owner: 10Siebrand) [10:48:59] (03CR) 10jenkins-bot: [V: 04-1] [WIP] Convert core messages to JSON i18n format [core] - 10https://gerrit.wikimedia.org/r/119658 (owner: 10Siebrand) [10:54:22] (03CR) 10Gilles: [C: 031] Allow schema registration via custom hook [extensions/EventLogging] - 10https://gerrit.wikimedia.org/r/120957 (owner: 10Ori.livneh) [10:58:31] (03PS1) 10Nikerabbit: Update plurals.xml to CLDR 25 [core] - 10https://gerrit.wikimedia.org/r/121025 [10:59:46] And we're already working on CLDR 26 :) [11:01:17] (03PS2) 10Hashar: beta: compile texvc on both datacenters [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/120939 [11:02:06] (03CR) 10Siebrand: "The changes to Language.php PS2 resolves the issue where translations for languages with only a JSON file were not loaded." [core] - 10https://gerrit.wikimedia.org/r/119658 (owner: 10Siebrand) [11:02:16] (03PS3) 10Hashar: beta: compile texvc on both datacenters [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/120939 [11:03:51] (03PS4) 10Hashar: beta: compile texvc on both datacenters [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/120939 [11:04:13] (03CR) 10jenkins-bot: [V: 04-1] Update plurals.xml to CLDR 25 [core] - 10https://gerrit.wikimedia.org/r/121025 (owner: 10Nikerabbit) [11:04:49] (03CR) 10Hashar: [C: 032] beta: compile texvc on both datacenters [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/120939 (owner: 10Hashar) [11:04:54] (03Merged) 10jenkins-bot: beta: compile texvc on both datacenters [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/120939 (owner: 10Hashar) [11:07:02] (03CR) 10Nikerabbit: "Please check how this interacts with ULS (both with anon language change enabled and disabled)." (031 comment) [core] - 10https://gerrit.wikimedia.org/r/120475 (owner: 10Stepzhou) [11:12:43] (03CR) 10Gilles: [C: 032] Add missing messages to RL module [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/120968 (owner: 10Robmoen) [11:12:53] (03Merged) 10jenkins-bot: Add missing messages to RL module [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/120968 (owner: 10Robmoen) [11:19:41] (03CR) 10Siebrand: Update plurals.xml to CLDR 25 (031 comment) [core] - 10https://gerrit.wikimedia.org/r/121025 (owner: 10Nikerabbit) [11:24:45] (03CR) 10Siebrand: [C: 031] "i18n/L10n reviewed." [core] - 10https://gerrit.wikimedia.org/r/118798 (owner: 10Pubudu538) [11:27:55] (03CR) 10Toniher: [C: 032 V: 032] "Approved change" [extensions/UserFunctions] - 10https://gerrit.wikimedia.org/r/118969 (owner: 10Toniher) [11:28:55] (03CR) 10Siebrand: "More i18n reviewed." (031 comment) [extensions/NukeDPL] - 10https://gerrit.wikimedia.org/r/120983 (owner: 10Luis Felipe Schenone) [11:31:18] (03CR) 10Siebrand: [C: 032 V: 032] Putting back several translations that where somehow lost [extensions/DisqusTag] - 10https://gerrit.wikimedia.org/r/120981 (owner: 10Luis Felipe Schenone) [11:32:54] (03CR) 10Siebrand: [C: 031] "i18n/L10n reviewed." [extensions/PGFTikZ] - 10https://gerrit.wikimedia.org/r/120750 (owner: 10thibaultmarin) [11:35:43] hi. how do I create my own repo for the gsoc project on gerri [11:35:45] gerrit [11:36:32] (03CR) 10Siebrand: [C: 04-1] "Cite has moved to JSON localisation. The localisation file changes have to be redone." [extensions/Cite] - 10https://gerrit.wikimedia.org/r/120962 (owner: 10Alex Monk) [11:39:50] rohit-dua: is it a new extension or what? [11:40:06] rohit-dua: in any case https://www.mediawiki.org/wiki/Gerrit/New_repositories [11:40:44] rohit-dua: did you decide with tpt on what code you'd be building upon? [11:41:07] yeah, check first that you really need a new repo [11:47:10] (03PS1) 10Siebrand: Migrate to JSON i18n [extensions/Collection] - 10https://gerrit.wikimedia.org/r/121027 [11:49:34] (03PS2) 10Siebrand: Migrate to JSON i18n [extensions/Collection] - 10https://gerrit.wikimedia.org/r/121027 [11:51:03] (03PS1) 10Siebrand: Migrate to JSON i18n [extensions/CommunityVoice] - 10https://gerrit.wikimedia.org/r/121029 [11:51:13] (03CR) 10Matthias Mullie: [C: 032] New Hook rc/watchlist hook ChangesListBegin [core] - 10https://gerrit.wikimedia.org/r/116649 (owner: 10EBernhardson) [11:55:15] (03Merged) 10jenkins-bot: New Hook rc/watchlist hook ChangesListBegin [core] - 10https://gerrit.wikimedia.org/r/116649 (owner: 10EBernhardson) [11:56:01] (03PS1) 10Siebrand: Migrate to JSON i18n [extensions/ConfirmEdit] - 10https://gerrit.wikimedia.org/r/121030 [11:57:14] (03PS1) 10Siebrand: Migrate to JSON i18n [extensions/ContactPage] - 10https://gerrit.wikimedia.org/r/121031 [11:58:32] (03PS2) 10Siebrand: Migrate to JSON i18n [extensions/ConfirmEdit] - 10https://gerrit.wikimedia.org/r/121030 [12:02:25] (03PS1) 10Siebrand: Migrate to JSON i18n [extensions/CreditsSource] - 10https://gerrit.wikimedia.org/r/121033 [12:03:29] (03PS1) 10Siebrand: Migrate to JSON i18n [extensions/CustomData] - 10https://gerrit.wikimedia.org/r/121034 [12:04:28] (03PS1) 10Siebrand: Migrate to JSON i18n [extensions/DisableAccount] - 10https://gerrit.wikimedia.org/r/121035 [12:05:32] (03PS1) 10Siebrand: Migrate to JSON i18n [extensions/Disambiguator] - 10https://gerrit.wikimedia.org/r/121036 [12:06:48] Anyone else having issues with the Gerrit web UI on Firefox? [12:07:08] I notice that it's so much more responsive on Chrome compared to on Firefox. [12:08:42] Nemo_bis: well i will be using the ia-upload tool some last step, and the template i'm using is bootstrap [12:08:47] Nemo_bis: https://github.com/rohit-dua/BUB [12:11:19] dan-nl: do you mean backporting a change on an extension? [12:11:30] siebrand: 11.05 < MaxSem> interestingly, it WFM in one browser and not in another one [12:11:33] 11.05 < MaxSem> works now but slowwwwwwww [12:11:49] grr.. [12:12:07] ytterbium doesn't seem overloaded [12:12:20] Nemo_bis: yes, aude gave me https://wikitech.wikimedia.org/wiki/How_to_deploy_code#Updating_the_submodule as a reference. [12:12:23] is git review slow too, or only interface? really wrong day for gerrit to be a jerk [12:12:52] rohit-dua: I don't understand your answer, so you'll work on ia-upload? [12:13:53] Nemo_bis: no the project is independent but i'll be using ia-upload just for upload to commons [12:14:48] (03CR) 10Bartosz Dziewoński: [C: 032] Fix custom local MediaWiki:Helppage values [core] - 10https://gerrit.wikimedia.org/r/120986 (owner: 10Mattflaschen) [12:16:59] ah nice MatmaRex, I can close my tab for testing :) [12:17:18] Nemo_bis: Now it's 503-ing [12:17:19] rohit-dua: ok [12:17:36] siebrand: same here [12:17:49] and back. [12:17:51] and quick. [12:17:51] Nemo_bis: heh, totally double-check that :D [12:17:54] Until it's not. [12:18:44] Which is about now. [12:18:46] Nemo_bis: I haven't heard from (mentors)Yann and Aubrey from days. Are they busy currently. just curious. [12:20:08] rohit-dua: yes, Aubrey just became president of Wikimedia Italia [12:20:19] he'll be more responsive in two weeks from now [12:20:30] (03Merged) 10jenkins-bot: Fix custom local MediaWiki:Helppage values [core] - 10https://gerrit.wikimedia.org/r/120986 (owner: 10Mattflaschen) [12:20:43] that's great news. will he be available as mentor in summer? [12:21:19] he'll let us know.. [12:21:30] ok [12:21:33] * MatmaRex hurts Gerrit [12:21:42] why is it always so slow when i need todo a bunch of actions [12:21:47] * siebrand agrees with MatmaRex  [12:24:15] I think gerrit is lazy and goes out for lunch when it senses work peaks [12:24:16] (03PS1) 10Bartosz Dziewoński: Fix custom local MediaWiki:Helppage values [core] (REL1_22) - 10https://gerrit.wikimedia.org/r/121042 [12:24:27] (03CR) 10Bartosz Dziewoński: [C: 032] Fix custom local MediaWiki:Helppage values [core] (REL1_22) - 10https://gerrit.wikimedia.org/r/121042 (owner: 10Bartosz Dziewoński) [12:24:31] siebrand: Ariel restarted gerrit, should be better [12:24:57] (03CR) 10Bartosz Dziewoński: "Ouch, I was sure that was fixed D: Tested, merged and backported in https://gerrit.wikimedia.org/r/#/c/121042/ , thank you for spotting! /" [core] - 10https://gerrit.wikimedia.org/r/83221 (owner: 10Nemo bis) [12:24:59] (03CR) 10Bartosz Dziewoński: "Ouch, I was sure that was fixed D: Tested, merged and backported in https://gerrit.wikimedia.org/r/#/c/121042/ , thank you for spotting! /" [core] (REL1_22) - 10https://gerrit.wikimedia.org/r/119947 (owner: 10Nemo bis) [12:25:15] okay, i *really* hope nothing else is broken now [12:25:34] (especially as i was one of the people complaining about messed up releases) [12:25:35] * Nemo_bis si cosparge il capo di cenere [12:25:43] * Nemo_bis was another [12:26:07] still feels slower than it normally is, on FF [12:26:30] Nemo_bis: it always feels that way for me [12:26:43] yes, *even* slower [12:28:01] (03CR) 10Daniel Kinzler: [C: 032] Fix/update inline documentation in WikiPage class [core] - 10https://gerrit.wikimedia.org/r/120841 (owner: 10Thiemo Mättig (WMDE)) [12:29:30] (03CR) 10jenkins-bot: [V: 04-1] Fix custom local MediaWiki:Helppage values [core] (REL1_22) - 10https://gerrit.wikimedia.org/r/121042 (owner: 10Bartosz Dziewoński) [12:29:42] sonnuvabitch. [12:29:53] how can that POSSIBLE fail aprser tests [12:29:56] POSSIBLY*. [12:31:45] (03CR) 10Bartosz Dziewoński: "wtf…" [core] (REL1_22) - 10https://gerrit.wikimedia.org/r/121042 (owner: 10Bartosz Dziewoński) [12:31:55] (03CR) 10Bartosz Dziewoński: [C: 032] Fix custom local MediaWiki:Helppage values [core] (REL1_22) - 10https://gerrit.wikimedia.org/r/121042 (owner: 10Bartosz Dziewoński) [12:33:44] (03Merged) 10jenkins-bot: Fix/update inline documentation in WikiPage class [core] - 10https://gerrit.wikimedia.org/r/120841 (owner: 10Thiemo Mättig (WMDE)) [12:33:50] (03CR) 10Daniel Kinzler: [C: 031] Allow access to revision deleted wikitext on action=edit [core] - 10https://gerrit.wikimedia.org/r/120858 (owner: 10Umherirrender) [12:35:27] (03Merged) 10jenkins-bot: Fix custom local MediaWiki:Helppage values [core] (REL1_22) - 10https://gerrit.wikimedia.org/r/121042 (owner: 10Bartosz Dziewoński) [12:35:59] oof. [12:36:46] (03PS2) 10Siebrand: Migrate to JSON i18n [extensions/CreditsSource] - 10https://gerrit.wikimedia.org/r/121033 [12:38:37] (03CR) 10Manybubbles: "I have no objections." [extensions/GeoData] - 10https://gerrit.wikimedia.org/r/115413 (owner: 10MaxSem) [12:42:51] MatmaRex: can I pick your brain ? [12:43:09] thedj: whenever [12:43:42] MatmaRex: i have this beforeunload event that I want to capture in the CodeEditor, to write the contents back to the textarea. [12:44:25] and it seems that it works with mediawiki.action.edit.editWarning.js in debug mode, but not otherwise [12:44:45] so i suspect it's the order in which the handlers get triggered that is the problem. [12:45:31] you have any idea how i can make sure that i write the content back, before the other handler is triggered ? [12:46:05] hmm. i've never tried to really understand how the beforeunload thing worked, the editWarning script looks like a huge hack [12:46:20] thedj: don't you maybe just want form's submit event instead? [12:46:55] (that'll probably be more reliable, if you can use it, including working on older browsers etc.) [12:47:08] that's already handled. this is for when people just close the window or do navigate [12:47:23] i guess i can write the value on every keydown, but that seems a bit expensive as well. [12:51:29] thedj: i think i'm notsure what you're trying to do [12:51:51] ah, unless you want the browsers to magically remember the contents [12:51:56] don't they do it anyway? ugh [12:52:42] (03PS1) 10Amire80: Use the new way of specifying beta screenshots [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/121043 [12:53:44] (03CR) 10Bartosz Dziewoński: "Ugh, this failed and doesn't merge now." [core] (REL1_22) - 10https://gerrit.wikimedia.org/r/110408 (owner: 10Se4598) [12:55:58] MatmaRex: i want to write them, so that editwarning.js can compare them with the original and warn about unsaved changes [12:56:13] (03CR) 10Bartosz Dziewoński: "Is this supposed to have been merged?" [core] (REL1_22) - 10https://gerrit.wikimedia.org/r/120319 (owner: 10MarkAHershberger) [12:56:25] why do we have unmerged patches on REL1_22? D: [12:56:51] Krinkle|detached: thoughts ? perhaps we should add hooks to editwarning.js ? [12:56:55] Nemo_bis: save us ^ [12:57:31] thedj: yeah, i was going to suggest that. not sure if mw.hook is capable of what you'd want though [12:57:53] it might be simpler to just duplicate the logic :( [12:59:43] i don't think it's possible to have sync hooks with return values indeed. [13:05:49] (03Abandoned) 10MarkAHershberger: Handle invalid titles on ProtectedPages and ProtectedTitles [core] (REL1_19) - 10https://gerrit.wikimedia.org/r/62608 (owner: 10MarkAHershberger) [13:06:00] (03PS1) 10TheDJ: Remove CodeEditor delay in drag & drop of text [extensions/CodeEditor] - 10https://gerrit.wikimedia.org/r/121044 [13:06:04] (03CR) 10jenkins-bot: [V: 04-1] Remove CodeEditor delay in drag & drop of text [extensions/CodeEditor] - 10https://gerrit.wikimedia.org/r/121044 (owner: 10TheDJ) [13:06:27] MatmaRex: what sort of help do you need on that? [13:07:09] (03PS2) 10TheDJ: Remove CodeEditor delay in drag & drop of text [extensions/CodeEditor] - 10https://gerrit.wikimedia.org/r/121044 [13:07:14] Nemo_bis: i need someone to prod the release guys, and you seem to do that somewhat often. :D [13:07:36] (i actually just e-mailed them, though) [13:08:23] heh [13:09:11] (03PS1) 10Hashar: beta: drop en/de wikivoyage databases [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/121045 [13:12:11] (03PS1) 10Aude: Update beginRecentChangesList to fix php strict standard notice [extensions/CleanChanges] - 10https://gerrit.wikimedia.org/r/121046 [13:12:48] (03PS2) 10Nik: Adjusted publisher library to coding guidelines. [extensions/PubSubHubbub] - 10https://gerrit.wikimedia.org/r/116989 [13:14:30] (03CR) 10Matthias Mullie: Refactor Flow\\Formatter namespace (033 comments) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/117384 (owner: 10EBernhardson) [13:14:47] (03PS3) 10Nik: Adjusted publisher library to coding guidelines. [extensions/PubSubHubbub] - 10https://gerrit.wikimedia.org/r/116989 [13:14:52] (03PS2) 10Hashar: beta: drop en/de wikivoyage databases [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/121045 [13:15:03] (03CR) 10Hashar: [C: 032] beta: drop en/de wikivoyage databases [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/121045 (owner: 10Hashar) [13:15:26] (03CR) 10Nik: [C: 032 V: 032] Adjusted publisher library to coding guidelines. [extensions/PubSubHubbub] - 10https://gerrit.wikimedia.org/r/116989 (owner: 10Nik) [13:16:05] (03Merged) 10jenkins-bot: beta: drop en/de wikivoyage databases [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/121045 (owner: 10Hashar) [13:16:12] (03PS4) 10Nik: Adjusted publisher library to coding guidelines. [extensions/PubSubHubbub] - 10https://gerrit.wikimedia.org/r/116989 [13:17:12] (03CR) 10Nik: [C: 032 V: 032] Adjusted publisher library to coding guidelines. [extensions/PubSubHubbub] - 10https://gerrit.wikimedia.org/r/116989 (owner: 10Nik) [13:18:02] (03PS18) 10Matthias Mullie: Make BoardHistory a Formatter instance [extensions/Flow] - 10https://gerrit.wikimedia.org/r/115532 (owner: 10EBernhardson) [13:18:10] (03CR) 10Nemo bis: "Caused bug 63108" [core] - 10https://gerrit.wikimedia.org/r/116649 (owner: 10EBernhardson) [13:18:12] (03CR) 10Aude: "only concern is about keeping b/w compatibility if wanted" [extensions/CleanChanges] - 10https://gerrit.wikimedia.org/r/121046 (owner: 10Aude) [13:18:14] (03PS1) 10Nik: Moved code to namespace PubSubHubbub. [extensions/PubSubHubbub] - 10https://gerrit.wikimedia.org/r/121048 [13:18:50] (03PS2) 10Nemo bis: Update beginRecentChangesList to fix php strict standard notice [extensions/CleanChanges] - 10https://gerrit.wikimedia.org/r/121046 (owner: 10Aude) [13:19:14] (03PS2) 10Nik: Moved code to namespace PubSubHubbub. [extensions/PubSubHubbub] - 10https://gerrit.wikimedia.org/r/121048 [13:19:36] (03CR) 10Nik: [C: 032] Moved code to namespace PubSubHubbub. [extensions/PubSubHubbub] - 10https://gerrit.wikimedia.org/r/121048 (owner: 10Nik) [13:25:54] (03CR) 10Siebrand: New Hook rc/watchlist hook ChangesListBegin (032 comments) [core] - 10https://gerrit.wikimedia.org/r/116649 (owner: 10EBernhardson) [13:27:10] (03CR) 10Manybubbles: "So I'm convinced this is a pretty good idea now." [core] - 10https://gerrit.wikimedia.org/r/118592 (owner: 10Chad) [13:27:51] (03CR) 10Siebrand: [C: 04-2] "This is not the right solution. I28d4e414 breaks all overrides from core, and it should be addressed there." [extensions/CleanChanges] - 10https://gerrit.wikimedia.org/r/121046 (owner: 10Aude) [13:29:54] (03CR) 10Brian Wolff: [C: 04-1] "Changing the field type of cl_timestamp, without changing the corresponding code that depends on magic timestamp updating, is going to bre" [core] - 10https://gerrit.wikimedia.org/r/110949 (owner: 10Gerrit Patch Uploader) [13:30:19] (03Abandoned) 10Aude: Update beginRecentChangesList to fix php strict standard notice [extensions/CleanChanges] - 10https://gerrit.wikimedia.org/r/121046 (owner: 10Aude) [13:36:12] (03CR) 10Brian Wolff: [C: 032] Use /usr/bin/ as default folder for DjVu tools in unit tests [core] - 10https://gerrit.wikimedia.org/r/120756 (owner: 10Tpt) [13:40:53] (03Merged) 10jenkins-bot: Use /usr/bin/ as default folder for DjVu tools in unit tests [core] - 10https://gerrit.wikimedia.org/r/120756 (owner: 10Tpt) [13:47:33] (03PS1) 10KartikMistry: Typo fix in console output [services/cxserver] - 10https://gerrit.wikimedia.org/r/121053 [13:51:39] (03PS1) 10KartikMistry: Added config.js in .gitignore [services/cxserver] - 10https://gerrit.wikimedia.org/r/121054 [13:53:55] (03PS1) 10Luis Felipe Schenone: Various changes based on comments to my initial commit [extensions/NukeDPL] - 10https://gerrit.wikimedia.org/r/121055 [13:56:27] (03CR) 10Raimond Spekking: [C: 032] Migrate to JSON i18n [extensions/CommunityVoice] - 10https://gerrit.wikimedia.org/r/121029 (owner: 10Siebrand) [13:56:33] (03Merged) 10jenkins-bot: Migrate to JSON i18n [extensions/CommunityVoice] - 10https://gerrit.wikimedia.org/r/121029 (owner: 10Siebrand) [13:56:44] (03CR) 10Nemo bis: Migrate to JSON i18n (031 comment) [extensions/CategoryTree] - 10https://gerrit.wikimedia.org/r/120791 (owner: 10Siebrand) [13:57:41] (03CR) 10Raimond Spekking: [C: 032] Migrate to JSON i18n [extensions/ConfirmEdit] - 10https://gerrit.wikimedia.org/r/121030 (owner: 10Siebrand) [13:57:45] (03Merged) 10jenkins-bot: Migrate to JSON i18n [extensions/ConfirmEdit] - 10https://gerrit.wikimedia.org/r/121030 (owner: 10Siebrand) [13:58:03] (03CR) 10Raimond Spekking: [C: 032] Migrate to JSON i18n [extensions/ContactPage] - 10https://gerrit.wikimedia.org/r/121031 (owner: 10Siebrand) [13:58:09] (03Merged) 10jenkins-bot: Migrate to JSON i18n [extensions/ContactPage] - 10https://gerrit.wikimedia.org/r/121031 (owner: 10Siebrand) [13:59:03] (03CR) 10Raimond Spekking: [C: 032] Migrate to JSON i18n [extensions/CustomData] - 10https://gerrit.wikimedia.org/r/121034 (owner: 10Siebrand) [13:59:06] (03Merged) 10jenkins-bot: Migrate to JSON i18n [extensions/CustomData] - 10https://gerrit.wikimedia.org/r/121034 (owner: 10Siebrand) [13:59:32] (03CR) 10Raimond Spekking: [C: 032] Migrate to JSON i18n [extensions/DisableAccount] - 10https://gerrit.wikimedia.org/r/121035 (owner: 10Siebrand) [13:59:35] (03Merged) 10jenkins-bot: Migrate to JSON i18n [extensions/DisableAccount] - 10https://gerrit.wikimedia.org/r/121035 (owner: 10Siebrand) [13:59:58] (03CR) 10Raimond Spekking: [C: 032] Migrate to JSON i18n [extensions/Disambiguator] - 10https://gerrit.wikimedia.org/r/121036 (owner: 10Siebrand) [14:00:01] (03Merged) 10jenkins-bot: Migrate to JSON i18n [extensions/Disambiguator] - 10https://gerrit.wikimedia.org/r/121036 (owner: 10Siebrand) [14:00:38] (03CR) 10Raimond Spekking: [C: 032] Migrate to JSON i18n [extensions/Collection] - 10https://gerrit.wikimedia.org/r/121027 (owner: 10Siebrand) [14:00:45] (03Merged) 10jenkins-bot: Migrate to JSON i18n [extensions/Collection] - 10https://gerrit.wikimedia.org/r/121027 (owner: 10Siebrand) [14:01:57] (03CR) 10Raimond Spekking: [C: 032] Migrate to JSON i18n [extensions/CreditsSource] - 10https://gerrit.wikimedia.org/r/121033 (owner: 10Siebrand) [14:02:00] (03Merged) 10jenkins-bot: Migrate to JSON i18n [extensions/CreditsSource] - 10https://gerrit.wikimedia.org/r/121033 (owner: 10Siebrand) [14:04:09] (03CR) 10Siebrand: [C: 04-1] "i18n/L10n reviewed." (035 comments) [extensions/NukeDPL] - 10https://gerrit.wikimedia.org/r/121055 (owner: 10Luis Felipe Schenone) [14:04:11] (03CR) 10Raimond Spekking: [C: 031] Various changes based on comments to my initial commit [extensions/NukeDPL] - 10https://gerrit.wikimedia.org/r/121055 (owner: 10Luis Felipe Schenone) [14:05:11] (03CR) 10Foxtrott: "@Brian Wolff: Does that only concern the cl_timestamp? In that case it would probably make sense to take cl_timestamp (or timestamps gener" [core] - 10https://gerrit.wikimedia.org/r/110949 (owner: 10Gerrit Patch Uploader) [14:06:01] (03CR) 10Brian Wolff: "Yes only cl_timestamp (afaik it is the only one that uses the "timestamp" type in mysql)." [core] - 10https://gerrit.wikimedia.org/r/110949 (owner: 10Gerrit Patch Uploader) [14:06:33] (03CR) 10Catrope: [C: 032] Catch parsing exceptions [extensions/LocalisationUpdate] - 10https://gerrit.wikimedia.org/r/120995 (owner: 10Nikerabbit) [14:06:36] (03Merged) 10jenkins-bot: Catch parsing exceptions [extensions/LocalisationUpdate] - 10https://gerrit.wikimedia.org/r/120995 (owner: 10Nikerabbit) [14:06:39] (03CR) 10Manybubbles: [C: 032] "Verified on a fresh vagrant install." [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/121043 (owner: 10Amire80) [14:06:40] manybubbles: hmm, I guess I should add some logging to know how many documents we push to the index [14:06:47] (03Merged) 10jenkins-bot: Use the new way of specifying beta screenshots [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/121043 (owner: 10Amire80) [14:07:06] Nikerabbit: might want to just count them I guess [14:07:13] it'd be the first line of checking [14:07:18] speed is comparable, index size can be caused by more analysis on the text content, so that looks ok [14:07:25] yeah [14:07:29] that looks sane [14:07:39] the document count being like 60% isn't good though [14:07:41] yay progress [14:07:45] (03PS1) 10Siebrand: Revert "New Hook rc/watchlist hook ChangesListBegin" [core] - 10https://gerrit.wikimedia.org/r/121058 [14:07:45] ya [14:07:47] yay [14:08:01] you really won't get "great" speed out of Elasticsearch in a single thread/process [14:08:06] which sucks [14:08:12] (03PS2) 10Siebrand: Revert "New Hook rc/watchlist hook ChangesListBegin" [core] - 10https://gerrit.wikimedia.org/r/121058 [14:08:25] manybubbles: my bootstrap script is threaded, if that is what you mean [14:08:31] ah [14:08:33] cool [14:08:35] I didn't see that part [14:08:41] (03PS3) 10Siebrand: Revert "New Hook rc/watchlist hook ChangesListBegin" [core] - 10https://gerrit.wikimedia.org/r/121058 [14:08:50] manybubbles: it's in the ttmserver-export.php, which I didn't modify much [14:09:23] it makes a fork for each message group (which also complicates counting the expected number of docs, but I'll figure something) [14:11:32] do you happen to hit Elasticsearch with anything before forking? [14:12:09] ElasticaConnection->destroySingleton might be helpful here [14:14:21] manybubbles: let me see [14:14:51] manybubbles: I do [14:15:03] that might be your http corruption issue [14:15:30] possible [14:18:10] (03PS1) 10Siebrand: Migrate to JSON i18n [extensions/DismissableSiteNotice] - 10https://gerrit.wikimedia.org/r/121061 [14:20:10] (03CR) 10Luis Felipe Schenone: Various changes based on comments to my initial commit (031 comment) [extensions/NukeDPL] - 10https://gerrit.wikimedia.org/r/121055 (owner: 10Luis Felipe Schenone) [14:20:41] (03PS1) 10Siebrand: Migrate to JSON i18n [extensions/DoubleWiki] - 10https://gerrit.wikimedia.org/r/121062 [14:23:11] (03PS1) 10Siebrand: Migrate to JSON i18n [extensions/Echo] - 10https://gerrit.wikimedia.org/r/121065 [14:24:04] 10575 4.47 24.4M Batch failed (Elastica\Exception\ResponseException: Failed to derive xcontent from org.elasticsearch.common.bytes.ChannelBufferBytesReference@92bf1177), trying again in 10 seconds [14:24:10] manybubbles: does that say anything to you? [14:24:38] yeah, that says "garbled request, can't even parse the json" [14:24:46] but in sillytalk [14:25:10] manybubbles: okay, I made it so that it should recreate the connections, but got one of those still [14:25:20] bleh. [14:25:27] well, its still better I suppose [14:26:47] manybubbles: looks so [14:26:49] (03PS1) 10Siebrand: Migrate to JSON i18n [extensions/Elastica] - 10https://gerrit.wikimedia.org/r/121066 [14:27:32] manybubbles: hah Elastica^^ ;) [14:27:45] ha [14:30:56] (03PS1) 10Siebrand: Migrate to JSON i18n [extensions/EventLogging] - 10https://gerrit.wikimedia.org/r/121068 [14:31:39] (03CR) 10Nikerabbit: [C: 032] "Warnings like this: PHP Strict Standards: Declaration of NCL::beginRecentChangesList() should be compatible with EnhancedChangesList::beg" [core] - 10https://gerrit.wikimedia.org/r/121058 (owner: 10Siebrand) [14:32:25] (03PS2) 10Siebrand: Migrate to JSON i18n [extensions/EventLogging] - 10https://gerrit.wikimedia.org/r/121068 [14:33:11] (03PS3) 10IAlex: Fix/update inline documentations in GlobalFunctions [core] - 10https://gerrit.wikimedia.org/r/120850 (owner: 10Thiemo Mättig (WMDE)) [14:33:40] (03PS1) 10Siebrand: Migrate to JSON i18n [extensions/ExtensionDistributor] - 10https://gerrit.wikimedia.org/r/121070 [14:35:54] (03PS1) 10Siebrand: Migrate to JSON i18n [extensions/FeaturedFeeds] - 10https://gerrit.wikimedia.org/r/121071 [14:36:31] (03Merged) 10jenkins-bot: Revert "New Hook rc/watchlist hook ChangesListBegin" [core] - 10https://gerrit.wikimedia.org/r/121058 (owner: 10Siebrand) [14:37:40] (03PS1) 10Siebrand: Migrate to JSON i18n [extensions/DynamicSidebar] - 10https://gerrit.wikimedia.org/r/121072 [14:38:02] (03PS1) 10Siebrand: Migrate to JSON i18n [extensions/EducationProgram] - 10https://gerrit.wikimedia.org/r/121073 [14:38:17] (03CR) 10jenkins-bot: [V: 04-1] Migrate to JSON i18n [extensions/EducationProgram] - 10https://gerrit.wikimedia.org/r/121073 (owner: 10Siebrand) [14:40:26] (03PS4) 10IAlex: Fix/update inline documentations in GlobalFunctions [core] - 10https://gerrit.wikimedia.org/r/120850 (owner: 10Thiemo Mättig (WMDE)) [14:40:31] (03CR) 10IAlex: [C: 032] Fix/update inline documentations in GlobalFunctions [core] - 10https://gerrit.wikimedia.org/r/120850 (owner: 10Thiemo Mättig (WMDE)) [14:45:21] (03Merged) 10jenkins-bot: Fix/update inline documentations in GlobalFunctions [core] - 10https://gerrit.wikimedia.org/r/120850 (owner: 10Thiemo Mättig (WMDE)) [14:47:29] omg too much elasticsearch there:) [14:51:23] (03PS1) 10Matthias Mullie: Revert "Revert "New Hook rc/watchlist hook ChangesListBegin"" [core] - 10https://gerrit.wikimedia.org/r/121075 [14:51:34] (03CR) 10Matthias Mullie: [C: 04-2 V: 04-1] Revert "Revert "New Hook rc/watchlist hook ChangesListBegin"" [core] - 10https://gerrit.wikimedia.org/r/121075 (owner: 10Matthias Mullie) [14:51:35] (03CR) 10BryanDavis: [C: 04-1] "I'll rework to use collections.OrderedDict." (031 comment) [tools/scap] - 10https://gerrit.wikimedia.org/r/120961 (owner: 10BryanDavis) [14:53:10] MaxSem: where? [14:55:51] here, in this channel:) [14:55:58] (03CR) 10Mglaser: [C: 032] "Preparing the release" [core] (REL1_22) - 10https://gerrit.wikimedia.org/r/120319 (owner: 10MarkAHershberger) [14:56:11] Nikerabbit, how is your portage doing? [14:59:42] (03Merged) 10jenkins-bot: Set a title for the context during import on the cli [core] (REL1_22) - 10https://gerrit.wikimedia.org/r/120319 (owner: 10MarkAHershberger) [15:00:12] (03CR) 10AndyRussG: [C: 04-1] "Please don't merge until this has been verified. Thanks!" [extensions/EducationProgram] - 10https://gerrit.wikimedia.org/r/121073 (owner: 10Siebrand) [15:00:32] (03PS4) 10Phuedx: Stop the rightmost toolbar section wrapping [extensions/GettingStarted] - 10https://gerrit.wikimedia.org/r/117874 [15:04:28] MaxSem: hunting some ghostly bugs, but in general I like working with ES [15:05:20] (03CR) 10Phuedx: "> It seems to make the x button invisible in IE 7, regardless of the resolution. It was already almost off the edge, but this pushes it a" [extensions/GettingStarted] - 10https://gerrit.wikimedia.org/r/117874 (owner: 10Phuedx) [15:06:27] MaxSem: much less hassle with configurations [15:06:42] it just works by default reasonably well [15:06:45] yep. no XML whatsoever:) [15:16:50] (03PS1) 10Siebrand: Migrate to JSON i18n [extensions/FlaggedRevs] - 10https://gerrit.wikimedia.org/r/121081 [15:16:59] (03CR) 10jenkins-bot: [V: 04-1] Migrate to JSON i18n [extensions/FlaggedRevs] - 10https://gerrit.wikimedia.org/r/121081 (owner: 10Siebrand) [15:18:37] (03CR) 10Siebrand: "The voting jslint job is a false positive on this patch set. I think it should be disabled for this repo until it actually passes." [extensions/FlaggedRevs] - 10https://gerrit.wikimedia.org/r/121081 (owner: 10Siebrand) [15:25:18] (03PS2) 10BryanDavis: Sort version list returned by mwversionsinuse [tools/scap] - 10https://gerrit.wikimedia.org/r/120961 [15:25:30] (03CR) 10jenkins-bot: [V: 04-1] Sort version list returned by mwversionsinuse [tools/scap] - 10https://gerrit.wikimedia.org/r/120961 (owner: 10BryanDavis) [15:28:21] (03CR) 10Siebrand: "Please explain what it is you need to verify. This is a well known procedure. See https://gerrit.wikimedia.org/r/#/q/status:merged+topic:j" [extensions/EducationProgram] - 10https://gerrit.wikimedia.org/r/121073 (owner: 10Siebrand) [15:30:12] (03PS3) 10BryanDavis: Sort version list returned by mwversionsinuse [tools/scap] - 10https://gerrit.wikimedia.org/r/120961 [15:30:25] (03CR) 10Siebrand: "The voting jslint job is a false positive on this patch set. I think it should be disabled for this repo until it actually passes." [extensions/EducationProgram] - 10https://gerrit.wikimedia.org/r/121073 (owner: 10Siebrand) [15:30:55] (03CR) 10Brian Wolff: "If you mean verified by jenkins, the issues don't seem to be for this commit... https://integration.wikimedia.org/ci/job/mwext-EducationPr" [extensions/EducationProgram] - 10https://gerrit.wikimedia.org/r/121073 (owner: 10Siebrand) [15:30:58] (03CR) 10BryanDavis: Sort version list returned by mwversionsinuse (031 comment) [tools/scap] - 10https://gerrit.wikimedia.org/r/120961 (owner: 10BryanDavis) [15:31:49] manybubbles: ES number of docs is correct, so it's Solr which is wrong [15:32:04] funky! [15:36:29] (03CR) 10AndyRussG: "I don't mean the Jenkins verification. I mean, I want to take the time to understand what's going on here and smoke test a bit, and let ot" [extensions/EducationProgram] - 10https://gerrit.wikimedia.org/r/121073 (owner: 10Siebrand) [15:38:34] Hi, I need to ask about JShint. My code shows only warnings in jshint, so is it acceptable? [15:39:08] zeek: Depends on where iti s [15:39:20] zeek: Are you submitting code for MW core or for an extension? [15:40:05] RoanKattouw: yes Liquid extensions. https://bugzilla.wikimedia.org/show_bug.cgi?id=61610 I am solving this bug. I have fixed errors as the bug says but warnings exist [15:40:20] Nikerabbit: even after a purge and repopulation? maybe some solr update failures skewed counts? [15:40:21] Not able to figure out some of them [15:40:43] zeek: Were there warnings/errors in jshint before you touched the code? [15:40:47] If so, then don't worry about it [15:41:28] Yes, there were errors, but thats what the bug says, to fix them [15:41:44] so will my patch be acceptable if warnings and not errors remain [15:42:09] Ooh [15:42:14] Well you won't be "done" [15:42:25] But any patch that makes things better is welcome [15:43:06] (03CR) 10Chad: [C: 032] Set visibility for some methods and remove unused ones [core] - 10https://gerrit.wikimedia.org/r/120335 (owner: 10Siebrand) [15:43:14] (03PS1) 10Adamw: DonationInterface jslint doesn't pass by a long shot, so make nonvoting [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/121089 [15:43:48] OK. Can you suggest me work around this warning "Avoid arguments.callee." [15:43:48] Nemo_bis: perhaps emptying failed, who knows [15:44:51] manybubbles: hah I found a simple trick to cut the bootstrap time into almost half [15:45:04] simple you say? [15:45:16] manybubbles: 4 lines more code [15:45:19] RoanKattouw: OK. Can you suggest me work around this warning "Avoid arguments.callee." [15:45:41] (03CR) 10Chad: [C: 032] Declare visibility on class properties of LoginForm [core] - 10https://gerrit.wikimedia.org/r/120329 (owner: 10Siebrand) [15:46:01] (03PS2) 10Siebrand: Migrate to JSON i18n [extensions/EducationProgram] - 10https://gerrit.wikimedia.org/r/121073 [15:46:34] Has anyone looked into making jshint run only on changed files? [15:46:39] (03PS3) 10Phuedx: Import config generation script from Gist [extensions/GettingStarted] - 10https://gerrit.wikimedia.org/r/118063 [15:46:42] (03PS2) 10Siebrand: Migrate to JSON i18n [extensions/FlaggedRevs] - 10https://gerrit.wikimedia.org/r/121081 [15:46:52] (03CR) 10jenkins-bot: [V: 04-1] Migrate to JSON i18n [extensions/FlaggedRevs] - 10https://gerrit.wikimedia.org/r/121081 (owner: 10Siebrand) [15:47:25] (03CR) 10Phuedx: Import config generation script from Gist (031 comment) [extensions/GettingStarted] - 10https://gerrit.wikimedia.org/r/118063 (owner: 10Phuedx) [15:47:41] (03CR) 10Chad: [C: 032] "I care :)" [core] - 10https://gerrit.wikimedia.org/r/120328 (owner: 10Siebrand) [15:49:32] (03Merged) 10jenkins-bot: Set visibility for some methods and remove unused ones [core] - 10https://gerrit.wikimedia.org/r/120335 (owner: 10Siebrand) [15:49:51] (03Merged) 10jenkins-bot: Declare visibility on class properties of LoginForm [core] - 10https://gerrit.wikimedia.org/r/120329 (owner: 10Siebrand) [15:50:13] (03CR) 10Hashar: [C: 032] DonationInterface jslint doesn't pass by a long shot, so make nonvoting [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/121089 (owner: 10Adamw) [15:50:17] (03CR) 10Adamw: "@Siebrand: err, it's not quite fair to call something you started doing yesterday a "well-known procedure". Also, AFAICT none of these ch" [extensions/EducationProgram] - 10https://gerrit.wikimedia.org/r/121073 (owner: 10Siebrand) [15:50:30] (03CR) 10Chad: [C: 032] Try to make a dent in CodeSniffer reports on includes/ (1) [core] - 10https://gerrit.wikimedia.org/r/120336 (owner: 10Siebrand) [15:50:37] zeek: That's hard to say without looking at the code [15:51:34] hmmm.... I won't ask you for that trouble... Its 2K lines of javascript.. :| [15:51:38] (03CR) 10Chad: "Needs rebase, conflicts on SpecialPageFactory. Otherwise good." [core] - 10https://gerrit.wikimedia.org/r/120316 (owner: 10Siebrand) [15:51:41] (03CR) 10Siebrand: "@adamw: Translate and other extensions have been using this for weeks, including on Wikimedia Foundation wikis. Thank you very much for be" [extensions/EducationProgram] - 10https://gerrit.wikimedia.org/r/121073 (owner: 10Siebrand) [15:51:44] (03Merged) 10jenkins-bot: Fix CodeSniffer errors and warnings in includes/specials (1) [core] - 10https://gerrit.wikimedia.org/r/120328 (owner: 10Siebrand) [15:52:12] (03CR) 10AndyRussG: [C: 04-1] "-1 again just as a flag to say "please wait a bit"." [extensions/EducationProgram] - 10https://gerrit.wikimedia.org/r/121073 (owner: 10Siebrand) [15:53:03] (03CR) 10Siebrand: "If it's not merged today, and there are localisation changes, this patch set will be worthless. So if it's not merged today, I'll abandon " [extensions/EducationProgram] - 10https://gerrit.wikimedia.org/r/121073 (owner: 10Siebrand) [15:54:10] (03PS1) 10Dan-nl: relax wiki title restrictions [extensions/GWToolset] - 10https://gerrit.wikimedia.org/r/121094 [15:55:03] (03CR) 10Raimond Spekking: [C: 032] Migrate to JSON i18n [extensions/DismissableSiteNotice] - 10https://gerrit.wikimedia.org/r/121061 (owner: 10Siebrand) [15:55:27] (03PS3) 10Chad: Fix CodeSniffer errors and warnings in includes/specials (2) [core] - 10https://gerrit.wikimedia.org/r/120330 (owner: 10Siebrand) [15:55:46] (03CR) 10Chad: [C: 032] Fix CodeSniffer errors and warnings in includes/specials (2) [core] - 10https://gerrit.wikimedia.org/r/120330 (owner: 10Siebrand) [15:55:57] (03CR) 10Raimond Spekking: [C: 032] Migrate to JSON i18n [extensions/DoubleWiki] - 10https://gerrit.wikimedia.org/r/121062 (owner: 10Siebrand) [15:56:08] ^d: If there's something blocking your merge, can you please -1? Otherwise it's hard to see which patch sets need work... I have many open usually. [15:56:18] <^d> Ah sorry [15:56:22] (03CR) 10Raimond Spekking: [C: 032] Migrate to JSON i18n [extensions/Echo] - 10https://gerrit.wikimedia.org/r/121065 (owner: 10Siebrand) [15:56:30] (03CR) 10Chad: [C: 04-1] Update formatting for includes/specialpage [core] - 10https://gerrit.wikimedia.org/r/120316 (owner: 10Siebrand) [15:56:54] (03CR) 10Raimond Spekking: [C: 032] Migrate to JSON i18n [extensions/Elastica] - 10https://gerrit.wikimedia.org/r/121066 (owner: 10Siebrand) [15:57:57] (03CR) 10Raimond Spekking: [C: 032] Migrate to JSON i18n [extensions/EventLogging] - 10https://gerrit.wikimedia.org/r/121068 (owner: 10Siebrand) [15:58:19] (03CR) 10Raimond Spekking: [C: 032] Migrate to JSON i18n [extensions/ExtensionDistributor] - 10https://gerrit.wikimedia.org/r/121070 (owner: 10Siebrand) [16:01:23] <^d> siebrand: Everything depending on 120316 lgtm. I'll merge it all once that parent's rebased. [16:02:59] (03PS3) 10Siebrand: Migrate to JSON i18n [extensions/FlaggedRevs] - 10https://gerrit.wikimedia.org/r/121081 [16:03:39] (03PS1) 10Dan-nl: make sure unicode characters are normalized [extensions/GWToolset] - 10https://gerrit.wikimedia.org/r/121097 [16:05:09] (03PS3) 10Siebrand: Migrate to JSON i18n [extensions/EducationProgram] - 10https://gerrit.wikimedia.org/r/121073 [16:05:34] (03CR) 10Siebrand: "PS3 fixes line endings for .jshintrc." [extensions/EducationProgram] - 10https://gerrit.wikimedia.org/r/121073 (owner: 10Siebrand) [16:06:00] ^d: Many thanks. Will address in a few mins. [16:06:36] <^d> :) [16:06:47] (03Merged) 10jenkins-bot: DonationInterface jslint doesn't pass by a long shot, so make nonvoting [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/121089 (owner: 10Adamw) [16:08:14] (03Merged) 10jenkins-bot: Migrate to JSON i18n [extensions/DismissableSiteNotice] - 10https://gerrit.wikimedia.org/r/121061 (owner: 10Siebrand) [16:09:00] (03Merged) 10jenkins-bot: Migrate to JSON i18n [extensions/DoubleWiki] - 10https://gerrit.wikimedia.org/r/121062 (owner: 10Siebrand) [16:09:20] (03Merged) 10jenkins-bot: Migrate to JSON i18n [extensions/ExtensionDistributor] - 10https://gerrit.wikimedia.org/r/121070 (owner: 10Siebrand) [16:09:27] (03CR) 10jenkins-bot: [V: 04-1] Migrate to JSON i18n [extensions/FlaggedRevs] - 10https://gerrit.wikimedia.org/r/121081 (owner: 10Siebrand) [16:09:34] (03Merged) 10jenkins-bot: Migrate to JSON i18n [extensions/Echo] - 10https://gerrit.wikimedia.org/r/121065 (owner: 10Siebrand) [16:09:37] (03CR) 10AndyRussG: [C: 04-1] "(as per previous comments)" [extensions/EducationProgram] - 10https://gerrit.wikimedia.org/r/121073 (owner: 10Siebrand) [16:11:30] (03CR) 10Adamw: "@siebrand: I did inform myself, using the link you provided: https://gerrit.wikimedia.org/r/#/q/status:merged+topic:json-i18n,n,z -- what " [extensions/EducationProgram] - 10https://gerrit.wikimedia.org/r/121073 (owner: 10Siebrand) [16:12:14] (03CR) 10Brian Wolff: "Whoops." [core] - 10https://gerrit.wikimedia.org/r/85446 (owner: 10Brian Wolff) [16:12:16] (03Merged) 10jenkins-bot: Migrate to JSON i18n [extensions/EventLogging] - 10https://gerrit.wikimedia.org/r/121068 (owner: 10Siebrand) [16:13:20] (03CR) 10Manybubbles: "All integration tests pass for this with Cirrus." [core] - 10https://gerrit.wikimedia.org/r/118592 (owner: 10Chad) [16:14:13] (03Merged) 10jenkins-bot: Try to make a dent in CodeSniffer reports on includes/ (1) [core] - 10https://gerrit.wikimedia.org/r/120336 (owner: 10Siebrand) [16:14:15] (03Merged) 10jenkins-bot: Fix CodeSniffer errors and warnings in includes/specials (2) [core] - 10https://gerrit.wikimedia.org/r/120330 (owner: 10Siebrand) [16:15:54] (03CR) 10Raimond Spekking: [C: 032] Migrate to JSON i18n [extensions/FeaturedFeeds] - 10https://gerrit.wikimedia.org/r/121071 (owner: 10Siebrand) [16:16:26] (03CR) 10Siebrand: "Niklas, Roan, here's where I could use some of your help and review." [core] - 10https://gerrit.wikimedia.org/r/119658 (owner: 10Siebrand) [16:16:33] (03CR) 10Raimond Spekking: [C: 032] Migrate to JSON i18n [extensions/DynamicSidebar] - 10https://gerrit.wikimedia.org/r/121072 (owner: 10Siebrand) [16:17:06] (03CR) 10Hashar: "I did cancel the post merge jobs. Sorry. Next merge will get them running." [core] - 10https://gerrit.wikimedia.org/r/120336 (owner: 10Siebrand) [16:17:08] (03Merged) 10jenkins-bot: Migrate to JSON i18n [extensions/FeaturedFeeds] - 10https://gerrit.wikimedia.org/r/121071 (owner: 10Siebrand) [16:17:10] (03Merged) 10jenkins-bot: Migrate to JSON i18n [extensions/DynamicSidebar] - 10https://gerrit.wikimedia.org/r/121072 (owner: 10Siebrand) [16:17:12] (03CR) 10Hashar: "I did cancel the post merge jobs. Sorry. Next merge will get them running." [core] - 10https://gerrit.wikimedia.org/r/120330 (owner: 10Siebrand) [16:17:14] (03CR) 10Matthias Mullie: "Just took a quick look." [core] - 10https://gerrit.wikimedia.org/r/121075 (owner: 10Matthias Mullie) [16:19:20] (03CR) 10Anomie: Remove "include redirects" option from search (035 comments) [core] - 10https://gerrit.wikimedia.org/r/118592 (owner: 10Chad) [16:19:50] (03PS2) 10Siebrand: Update formatting for includes/specialpage [core] - 10https://gerrit.wikimedia.org/r/120316 [16:20:07] siebrand: you know, if you need to fool Jenkins jslint, there is a better trick than disabling everyone's .jshintrc. [16:20:23] awight: Which? [16:20:26] You can just remove Jenkins from the reviewer list, then merge while it is not looking. [16:20:36] awight: Oh, I know that. But that's cheating. [16:20:39] Usually there is a window of half a minute or so. [16:20:52] Yeah but... people are getting pissed off about you disabling jslint the wrong way. [16:20:54] awight: I'd rather fix the cause. [16:21:04] {} contents are not fixing the cause :[ [16:21:17] awight: That's what test master hashar advised me to do. [16:21:23] awight: Just following orders... [16:21:26] argh, he isn't online. [16:21:47] Seems like the proper thing would be for jslint to be non-voting on those extensions [16:21:49] siebrand: don't make me talk about Befehlstrdger [16:21:58] ^^ what bawolff said. [16:22:12] * bawolff has no idea how to accomplish that, or if that's possible [16:22:22] awight: If you want to hear it another way: I asked what to do, and Antoine said to me that I should add ,jshintrc with contents {}. [16:22:36] awight: And I didn't feel like working on actually making the tests pass. [16:23:02] awight: And I am not in favour of merging patch sets that a CI process blocks. [16:23:07] siebrand: bawolff: here is an example, https://gerrit.wikimedia.org/r/#/c/121089/ [16:23:31] Having the .jshintrc be {} certainly seems better then trying to get one past jenkins by merging quickly :) [16:24:01] well, in most cases it's going to be a "fix" which will have to be immediately reverted [16:24:09] so... choose your poison? [16:24:12] (03PS4) 10Siebrand: Migrate to JSON i18n [extensions/EducationProgram] - 10https://gerrit.wikimedia.org/r/121073 [16:25:28] I don't think there should ever be voting tests being run that don't pass on currently merged code [16:25:53] so .jshintrc being {} shouldn't be reverted until the tests are fixed [16:26:17] bawolff: when .jshintrc is nulled-out, there are no longer tests to fix. [16:26:26] (03PS1) 10Siebrand: No voting jslint for EducationProgram and FlaggedRevs [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/121099 [16:26:36] Well people can still run it locally [16:26:46] with different options [16:27:14] Having jenkins say commits are broken when its not the commit's fault is really confusing and I would consider a bad thing [16:27:17] (03PS4) 10Siebrand: Migrate to JSON i18n [extensions/FlaggedRevs] - 10https://gerrit.wikimedia.org/r/121081 [16:27:29] (03CR) 10jenkins-bot: [V: 04-1] Migrate to JSON i18n [extensions/FlaggedRevs] - 10https://gerrit.wikimedia.org/r/121081 (owner: 10Siebrand) [16:27:43] (03CR) 10Siebrand: "I submitted https://gerrit.wikimedia.org/r/#/c/121099/ to removing the jslint voting." [extensions/EducationProgram] - 10https://gerrit.wikimedia.org/r/121073 (owner: 10Siebrand) [16:27:48] (03CR) 10Siebrand: "I submitted https://gerrit.wikimedia.org/r/#/c/121099/ to removing the jslint voting." [extensions/FlaggedRevs] - 10https://gerrit.wikimedia.org/r/121081 (owner: 10Siebrand) [16:27:53] The thing about the nulling-out solution is that extension maintainers know better than us what the actual state of their .js is... [16:27:57] awight: Thanks. [16:28:11] siebrand: sorry to add work to your plate. Mostly, I'm trying to lubricate the situation a bit. [16:28:37] (03PS3) 10Chad: Remove "include redirects" option from search [core] - 10https://gerrit.wikimedia.org/r/118592 [16:28:38] It's @#$@#$ annoying that have CI process put shit in your face you didn't cause. [16:28:41] siebrand: Can you take a look at this, btw: https://gerrit.wikimedia.org/r/120932 [16:29:09] awight: Please add me as reviewer int he future. [16:29:09] siebrand: totally agreed about the CI. I'm looking at it now, trying to see if I can make jshint only run on changed files. [16:29:13] right. [16:29:14] (03CR) 10Chad: Remove "include redirects" option from search (035 comments) [core] - 10https://gerrit.wikimedia.org/r/118592 (owner: 10Chad) [16:29:21] awight: I watch all commit email, but I scan for i18n and json changes. [16:29:26] awight: I miss most of the rest. [16:29:44] (03CR) 10Chad: [C: 032] Update formatting for includes/specialpage [core] - 10https://gerrit.wikimedia.org/r/120316 (owner: 10Siebrand) [16:30:43] (03CR) 10AndyRussG: [C: 04-1] "(again, as per previous comments)" [extensions/EducationProgram] - 10https://gerrit.wikimedia.org/r/121073 (owner: 10Siebrand) [16:31:07] (03CR) 10Hashar: "I am a js noobie, skipping sorry :-D" [extensions/InputBox] - 10https://gerrit.wikimedia.org/r/120487 (owner: 1001tonythomas) [16:31:53] (03CR) 10Siebrand: [C: 04-1] Comment generated code to explain the i18n JSON migration. (031 comment) [core] - 10https://gerrit.wikimedia.org/r/120932 (owner: 10Adamw) [16:31:58] awight: Reviewed. [16:33:14] siebrand: u want me to change the text? That's fine, but someone better informed could provide superior links IMO [16:33:17] (03Abandoned) 10Siebrand: Migrate to JSON i18n [extensions/EducationProgram] - 10https://gerrit.wikimedia.org/r/121073 (owner: 10Siebrand) [16:33:43] awight: Someone needs to check which 1.22.x got the backport for JSON i18n file support. [16:33:50] (03Merged) 10jenkins-bot: Update formatting for includes/specialpage [core] - 10https://gerrit.wikimedia.org/r/120316 (owner: 10Siebrand) [16:33:59] siebrand: sure, I can do that [16:34:16] But, are there better places to direct people to get the big picture? [16:34:19] awight: You want to look at includes/cache/LocalisationCache.php. [16:34:24] cool [16:34:26] awight: RFC. [16:34:30] ok [16:34:34] https://www.mediawiki.org/wiki/Requests_for_comment/Localisation_format [16:34:41] yep i had that one, good. [16:35:38] (03CR) 10Matthias Mullie: "It looks like all places initialize changeslist via ChangesList::newFromContext." [core] - 10https://gerrit.wikimedia.org/r/121075 (owner: 10Matthias Mullie) [16:36:17] awight: I think the only thing that needs updating hte is version of MediaWiki from where JSON is supported. [16:36:50] (03CR) 10Hashar: [C: 04-1] "FlaggedRevs, I have filled a bug for it bug 63117. Should indeed be non voting." (032 comments) [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/121099 (owner: 10Siebrand) [16:37:43] (03CR) 10Siebrand: "The dummy .jshintrc is getting objections." [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/121099 (owner: 10Siebrand) [16:38:27] siebrand: I don't see anything in 1.22: [16:38:29] siebrand: git blame origin/wmf/1.22wmf9 -- includes/cache/LocalisationCache.php | grep MessagesDirs [16:38:43] siebrand: git blame origin/REL1_22 -- includes/cache/LocalisationCache.php | grep MessagesDirs [16:38:47] both come up empty [16:38:52] awight: Hmm. Let me think... I'm pretty sure we backported this. [16:39:03] awight: But then, I may be wrong. [16:39:09] I am usually wrong. [16:39:10] awight: Should still be done, then. [16:39:39] OK well, perhaps the codegen comment should just link to a page where you announce current compatibility. [16:40:02] (03CR) 10Anomie: [C: 031] Remove "include redirects" option from search [core] - 10https://gerrit.wikimedia.org/r/118592 (owner: 10Chad) [16:40:39] siebrand: ^^ [16:41:25] (03CR) 10Manybubbles: [C: 032] "Ok, if Anomie +1s and I'm happy with it too then +2." [core] - 10https://gerrit.wikimedia.org/r/118592 (owner: 10Chad) [16:42:02] awight: Looks like there is no evidence it ever got backported. I must have had the intention to do that. [16:42:05] ^d: there you go [16:42:20] awight: Will add it to my list. So your patch set is okay. [16:42:32] ok [16:42:39] (03CR) 10AndyRussG: "Wasn't blocking, just wanted a bit of time to look this over carefully." [extensions/EducationProgram] - 10https://gerrit.wikimedia.org/r/121073 (owner: 10Siebrand) [16:43:57] (03PS1) 10Bencmq: Add mw-ui-light button style [core] - 10https://gerrit.wikimedia.org/r/121101 [16:44:27] (03CR) 10Siebrand: "You can download it and see if the L10n still works. Easy as that. If you'd want to merge, you can restore it and merge it. That'll no lon" [extensions/EducationProgram] - 10https://gerrit.wikimedia.org/r/121073 (owner: 10Siebrand) [16:45:31] (03Merged) 10jenkins-bot: Remove "include redirects" option from search [core] - 10https://gerrit.wikimedia.org/r/118592 (owner: 10Chad) [16:46:20] (03PS2) 10Bencmq: Add mw-ui-light button style [core] - 10https://gerrit.wikimedia.org/r/121101 [16:47:31] (03CR) 10Raimond Spekking: [C: 032] Migrate to JSON i18n [extensions/FlaggedRevs] - 10https://gerrit.wikimedia.org/r/121081 (owner: 10Siebrand) [16:47:35] (03PS3) 10Bencmq: Add mw-ui-light button style [core] - 10https://gerrit.wikimedia.org/r/121101 [16:49:10] (03CR) 10jenkins-bot: [V: 04-1] Migrate to JSON i18n [extensions/FlaggedRevs] - 10https://gerrit.wikimedia.org/r/121081 (owner: 10Siebrand) [16:50:05] (03PS1) 10Siebrand: Add .gitignore [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/121105 [16:50:55] siebrand: another question about json-i18n. We have some really horrible code outside of MW, which reads the .i18n.php file directly. We might have to delay deployment of the json changes until that code is fixed. So, you mentioned something about new TWN changes invalidating the patch? Is that true, or will new changes be correctly picked up even if we eventually merge a slightly stale version of the json patch? [16:52:10] awight: Yes, this needs to be coordinated. [16:52:11] (03CR) 10Jdlrobson: "Both Flow and MobileFrontend now have a need for this. Where can we have this conversation and move this along?" [core] - 10https://gerrit.wikimedia.org/r/111250 (owner: 10MaxSem) [16:52:45] siebrand: it won't just pick up changes automatically? I guess I don't understand how deltas are calculated. [16:53:03] Or is the coordination just in the "format=json" TWN configuration? [16:53:32] (03PS2) 10Siebrand: No voting jslint for EducationProgram and FlaggedRevs [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/121099 [16:53:52] (03Abandoned) 10Siebrand: Add .gitignore [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/121105 (owner: 10Siebrand) [16:54:03] (03CR) 10Jdlrobson: "I would advise making a slight amendment to this patch to include a mediawiki.templates module (or mediawiki.blob if we prefer) that would" [core] - 10https://gerrit.wikimedia.org/r/111250 (owner: 10MaxSem) [16:54:05] (03PS3) 10Siebrand: No voting jslint for FlaggedRevs [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/121099 [16:54:30] awight: yes. [16:54:55] awight: And if you have your patch set ready, and there are changes to the i18n files after that, you'll have merge conflicts. [16:55:17] awight: Given that eports and changes are made on a daily basis, there needs to be coordination. [16:55:39] siebrand: okay, thanks for the explanation. [16:55:40] awight: Which is why I'm currently preparing batches of 10 extensions that someone else should merge the same day. [16:56:06] jdlrobson, I don't understand that ^^^ comment [16:56:30] siebrand: Well, I wish you much luck! This is a big improvement, too bad it's costing all the blood... [16:57:02] I am unfortunatly used to it. [16:57:25] We had the same thing when we standardised on the i18n.php files, and came for 3 or 4 different L10n systems. [16:58:07] (03CR) 10Brian Wolff: [C: 04-1] "Looking much better. Some of the message names that were changed this patchset didn't get changed in all places. Other then that 1 or 2 mi" (039 comments) [core] - 10https://gerrit.wikimedia.org/r/112323 (owner: 10Kunalgrover05) [16:59:13] (03PS1) 10Kaldari: Story 1732: Make licensing customizable on mobile interfaces [extensions/WikimediaMessages] - 10https://gerrit.wikimedia.org/r/121106 [16:59:29] (03CR) 10jenkins-bot: [V: 04-1] Story 1732: Make licensing customizable on mobile interfaces [extensions/WikimediaMessages] - 10https://gerrit.wikimedia.org/r/121106 (owner: 10Kaldari) [16:59:31] MaxSem: hope that helps [16:59:31] (03CR) 10Jdlrobson: "To clarify, as Max says I wasn't clear :-):" [core] - 10https://gerrit.wikimedia.org/r/111250 (owner: 10MaxSem) [16:59:51] (03CR) 10Raimond Spekking: [V: 032] Migrate to JSON i18n [extensions/Elastica] - 10https://gerrit.wikimedia.org/r/121066 (owner: 10Siebrand) [16:59:58] (03CR) 10Siebrand: [V: 032] "Merge based on raimond's +2. Jenkins fail is unrelated." [extensions/FlaggedRevs] - 10https://gerrit.wikimedia.org/r/121081 (owner: 10Siebrand) [17:11:25] (03PS3) 10Hoo man: Return a Title in RequestContext::getTitle even if $wgTitle is null [core] - 10https://gerrit.wikimedia.org/r/120552 [17:11:54] (03CR) 10Brian Wolff: [C: 032] "Looks good" [core] - 10https://gerrit.wikimedia.org/r/115640 (owner: 10Umherirrender) [17:12:18] <^d> manybubbles, anomie: many thanks, yay! [17:12:25] (03PS1) 10Ragesoss: Remove student profiles special page and everything that links there [extensions/EducationProgram] - 10https://gerrit.wikimedia.org/r/121107 [17:14:09] (03PS2) 10Chad: Declare visibility on class properties of RedirectSpecialPage [core] - 10https://gerrit.wikimedia.org/r/120317 (owner: 10Siebrand) [17:14:18] (03CR) 10Chad: [C: 032] Declare visibility on class properties of RedirectSpecialPage [core] - 10https://gerrit.wikimedia.org/r/120317 (owner: 10Siebrand) [17:14:30] (03PS2) 10Chad: Make CodeSniffer checks pass on includes/specialpages/ [core] - 10https://gerrit.wikimedia.org/r/120318 (owner: 10Siebrand) [17:14:35] (03CR) 10Chad: [C: 032] Make CodeSniffer checks pass on includes/specialpages/ [core] - 10https://gerrit.wikimedia.org/r/120318 (owner: 10Siebrand) [17:14:53] (03PS2) 10Chad: Declare visibility on class properties of SpecialUndelete [core] - 10https://gerrit.wikimedia.org/r/120331 (owner: 10Siebrand) [17:15:05] (03CR) 10Chad: [C: 032] Declare visibility on class properties of SpecialUndelete [core] - 10https://gerrit.wikimedia.org/r/120331 (owner: 10Siebrand) [17:16:08] (03PS2) 10Chad: Declare visibility on class properties of SpecialRevisionDelete [core] - 10https://gerrit.wikimedia.org/r/120332 (owner: 10Siebrand) [17:16:25] (03CR) 10Chad: [C: 032] Declare visibility on class properties of SpecialRevisionDelete [core] - 10https://gerrit.wikimedia.org/r/120332 (owner: 10Siebrand) [17:16:43] <^d> siebrand: enjoy the spam. jenkins shall merge all eventually. [17:18:05] (03PS2) 10Kaldari: Story 1732: Make licensing customizable on mobile interfaces [extensions/WikimediaMessages] - 10https://gerrit.wikimedia.org/r/121106 [17:18:18] (03CR) 10Nikerabbit: [C: 032] Typo fix in console output [services/cxserver] - 10https://gerrit.wikimedia.org/r/121053 (owner: 10KartikMistry) [17:18:59] (03Merged) 10jenkins-bot: Add a 'revdelete-selected-file' message on Special:RevisionDelete [core] - 10https://gerrit.wikimedia.org/r/115640 (owner: 10Umherirrender) [17:19:01] (03CR) 10jenkins-bot: [V: 04-1] Return a Title in RequestContext::getTitle even if $wgTitle is null [core] - 10https://gerrit.wikimedia.org/r/120552 (owner: 10Hoo man) [17:19:41] (03CR) 10Krinkle: [C: 031] No voting jslint for FlaggedRevs [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/121099 (owner: 10Siebrand) [17:20:24] (03Merged) 10jenkins-bot: Typo fix in console output [services/cxserver] - 10https://gerrit.wikimedia.org/r/121053 (owner: 10KartikMistry) [17:20:26] (03PS4) 10Krinkle: Make jslint non-voting for FlaggedRevs [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/121099 (owner: 10Siebrand) [17:20:31] (03PS5) 10Krinkle: Make jslint non-voting for FlaggedRevs [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/121099 (owner: 10Siebrand) [17:20:48] (03CR) 10Krinkle: [C: 031] Make jslint non-voting for FlaggedRevs [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/121099 (owner: 10Siebrand) [17:21:24] (03PS3) 10Kaldari: Story 1732: Make licensing customizable on mobile interfaces [extensions/WikimediaMessages] - 10https://gerrit.wikimedia.org/r/121106 [17:21:44] (03Merged) 10jenkins-bot: Declare visibility on class properties of RedirectSpecialPage [core] - 10https://gerrit.wikimedia.org/r/120317 (owner: 10Siebrand) [17:22:52] (03Merged) 10jenkins-bot: Make CodeSniffer checks pass on includes/specialpages/ [core] - 10https://gerrit.wikimedia.org/r/120318 (owner: 10Siebrand) [17:24:09] (03Merged) 10jenkins-bot: Declare visibility on class properties of SpecialUndelete [core] - 10https://gerrit.wikimedia.org/r/120331 (owner: 10Siebrand) [17:25:17] (03PS2) 10Ragesoss: Remove student profiles special page and everything that links there [extensions/EducationProgram] - 10https://gerrit.wikimedia.org/r/121107 [17:28:14] (03Merged) 10jenkins-bot: Declare visibility on class properties of SpecialRevisionDelete [core] - 10https://gerrit.wikimedia.org/r/120332 (owner: 10Siebrand) [17:33:49] (03PS3) 10Adamw: Comment generated code to explain the i18n JSON migration. [core] - 10https://gerrit.wikimedia.org/r/120932 [17:36:34] (03CR) 10Siebrand: [C: 032] Comment generated code to explain the i18n JSON migration. [core] - 10https://gerrit.wikimedia.org/r/120932 (owner: 10Adamw) [17:38:00] (03PS4) 10Hoo man: Return a Title in RequestContext::getTitle even if $wgTitle is null [core] - 10https://gerrit.wikimedia.org/r/120552 [17:38:28] (03CR) 10Chad: [C: 032] Have ?download parameter trigger Content-Disposition: attachment [core] - 10https://gerrit.wikimedia.org/r/120703 (owner: 10Gilles) [17:38:39] ^d: Thanks for all the review, Chad. [17:38:53] ^d: I'll prepare a new batch during the weekend :) [17:38:57] <^d> you're welcome [17:39:13] ^d you're going to brawl with hashar on the CodeSniffer check, right? [17:39:23] <^d> at some point. [17:41:02] (03PS1) 10Aude: Allow to optionally set language in Message constructor [core] - 10https://gerrit.wikimedia.org/r/121113 [17:43:40] (03CR) 10Siebrand: Story 1732: Make licensing customizable on mobile interfaces (031 comment) [extensions/WikimediaMessages] - 10https://gerrit.wikimedia.org/r/121106 (owner: 10Kaldari) [17:45:06] (03Merged) 10jenkins-bot: Comment generated code to explain the i18n JSON migration. [core] - 10https://gerrit.wikimedia.org/r/120932 (owner: 10Adamw) [17:45:23] (03Merged) 10jenkins-bot: Have ?download parameter trigger Content-Disposition: attachment [core] - 10https://gerrit.wikimedia.org/r/120703 (owner: 10Gilles) [17:49:29] (03PS5) 10Hoo man: Return a Title in RequestContext::getTitle even if $wgTitle is null [core] - 10https://gerrit.wikimedia.org/r/120552 [17:49:46] (03PS2) 10Jforrester: Update OOjs UI to v0.1.0-pre (1c7875205a) [core] - 10https://gerrit.wikimedia.org/r/120715 (owner: 10JGonera) [17:50:34] (03PS1) 10Isarra: Documentation changes, minor css fixes [skins/Splash] - 10https://gerrit.wikimedia.org/r/121115 [17:51:11] (03PS3) 10Jforrester: Use Agora oojs-ui theme on mobile [core] - 10https://gerrit.wikimedia.org/r/120165 (owner: 10JGonera) [17:53:16] (03CR) 10Jforrester: [C: 031] Use Agora oojs-ui theme on mobile [core] - 10https://gerrit.wikimedia.org/r/120165 (owner: 10JGonera) [18:01:31] (03PS1) 10Aude: Add getLanguageCode method to Message [core] - 10https://gerrit.wikimedia.org/r/121118 [18:05:17] (03CR) 10Catrope: [C: 032] Update OOjs UI to v0.1.0-pre (1c7875205a) [core] - 10https://gerrit.wikimedia.org/r/120715 (owner: 10JGonera) [18:05:24] (03PS3) 10Jdlrobson: Stop make kss from opening browser [core] - 10https://gerrit.wikimedia.org/r/117108 (owner: 10JGonera) [18:05:31] (03CR) 10Catrope: [C: 032] Use Agora oojs-ui theme on mobile [core] - 10https://gerrit.wikimedia.org/r/120165 (owner: 10JGonera) [18:07:56] (03CR) 10Jdlrobson: [C: 032] Stop make kss from opening browser [core] - 10https://gerrit.wikimedia.org/r/117108 (owner: 10JGonera) [18:09:17] siebrand: What about the others that were failing [18:09:31] Krinkle: Don't recall what was done exactly. [18:09:54] Krinkle: Like I said, I abandoned EducationProgram and DonationInterface. [18:10:18] Krinkle: I think I also added some commented .jshintignore entries yesterday for 1 or 2 repos. [18:10:26] (03Merged) 10jenkins-bot: Update OOjs UI to v0.1.0-pre (1c7875205a) [core] - 10https://gerrit.wikimedia.org/r/120715 (owner: 10JGonera) [18:10:45] siebrand: EducationProgram was passing it seems, so that was abandoned for other reasons [18:11:00] siebrand: https://gerrit.wikimedia.org/r/#/c/121073/ [18:11:28] (03Merged) 10jenkins-bot: Use Agora oojs-ui theme on mobile [core] - 10https://gerrit.wikimedia.org/r/120165 (owner: 10JGonera) [18:11:42] DonationInterface was already non-voting, and merged [18:11:44] (03Merged) 10jenkins-bot: Stop make kss from opening browser [core] - 10https://gerrit.wikimedia.org/r/117108 (owner: 10JGonera) [18:11:46] (03CR) 10Jdlrobson: [C: 032] "I tend to agree with Max here. If the API is capable of this but slow we should take a more long term view here and fix the fact that it i" [core] - 10https://gerrit.wikimedia.org/r/118135 (owner: 10MaxSem) [18:13:04] (03CR) 10Siebrand: [C: 04-1] "i18n/L10n reviewed." (031 comment) [skins/Splash] - 10https://gerrit.wikimedia.org/r/121115 (owner: 10Isarra) [18:15:53] (03CR) 10Jdlrobson: [C: 032] "wfm" [extensions/Scribunto] - 10https://gerrit.wikimedia.org/r/118944 (owner: 10Hoo man) [18:18:08] (03Merged) 10jenkins-bot: Don't try to inline load ext.scribunto on mobile [extensions/Scribunto] - 10https://gerrit.wikimedia.org/r/118944 (owner: 10Hoo man) [18:22:45] (03CR) 10Jdlrobson: [C: 032] "Boom." [core] - 10https://gerrit.wikimedia.org/r/114080 (owner: 10Mattflaschen) [18:23:03] (03Merged) 10jenkins-bot: Suppress section edit links with action=render [core] - 10https://gerrit.wikimedia.org/r/118135 (owner: 10MaxSem) [18:23:22] (03PS1) 10EBernhardson: New Hook rc/watchlist hook ChangesListBegin [core] - 10https://gerrit.wikimedia.org/r/121121 [18:23:42] (03CR) 10Siebrand: "Nice, thanks." [core] - 10https://gerrit.wikimedia.org/r/120850 (owner: 10Thiemo Mättig (WMDE)) [18:25:23] (03CR) 10Isarra: "How do you do that? It appears to have a normal ending..." [skins/Splash] - 10https://gerrit.wikimedia.org/r/121115 (owner: 10Isarra) [18:27:04] (03CR) 10Siebrand: Various changes based on comments to my initial commit (031 comment) [extensions/NukeDPL] - 10https://gerrit.wikimedia.org/r/121055 (owner: 10Luis Felipe Schenone) [18:28:07] (03Merged) 10jenkins-bot: Remove button styles from mediawiki.ui [core] - 10https://gerrit.wikimedia.org/r/114080 (owner: 10Mattflaschen) [18:28:16] (03PS2) 10Isarra: Documentation changes, minor css fixes [skins/Splash] - 10https://gerrit.wikimedia.org/r/121115 [18:32:43] (03CR) 10Siebrand: [C: 031] "L10n reviewed." [extensions/Flow] - 10https://gerrit.wikimedia.org/r/119640 (owner: 10Bsitu) [18:33:29] (03CR) 10Siebrand: [C: 031] "i18n/L10n reviewed." [extensions/Flow] - 10https://gerrit.wikimedia.org/r/118399 (owner: 10Bsitu) [18:39:04] (03PS1) 10Adamw: UNTESTED: Only run jshint on modified files [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/121127 [18:39:36] (03CR) 10Siebrand: "I added Niklas to the list of reviewers. Some inline comments on style." (033 comments) [core] - 10https://gerrit.wikimedia.org/r/121121 (owner: 10EBernhardson) [18:40:14] (03CR) 10Adamw: "I don't have a fully functional WMF CI Jenkins locally, so I could not test the absolute paths, etc. I did verify that the syntax will ba" [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/121127 (owner: 10Adamw) [18:48:50] (03PS1) 10Bsitu: Add topic/post summary diff view [extensions/Flow] - 10https://gerrit.wikimedia.org/r/121128 [18:49:00] (03CR) 10jenkins-bot: [V: 04-1] Add topic/post summary diff view [extensions/Flow] - 10https://gerrit.wikimedia.org/r/121128 (owner: 10Bsitu) [18:49:13] (03CR) 10Siebrand: "Hadn't seen your question. I just prepared this reply, and only saw you resolved it by yourself later. Going to review now :)." [skins/Splash] - 10https://gerrit.wikimedia.org/r/121115 (owner: 10Isarra) [18:49:48] (03CR) 10Bsitu: [C: 04-2] Add topic/post summary diff view [extensions/Flow] - 10https://gerrit.wikimedia.org/r/121128 (owner: 10Bsitu) [18:50:33] (03CR) 10Chad: [C: 032] Return a Title in RequestContext::getTitle even if $wgTitle is null [core] - 10https://gerrit.wikimedia.org/r/120552 (owner: 10Hoo man) [18:50:35] (03CR) 10Siebrand: [C: 031] "i18n/L10n reviewed." (031 comment) [skins/Splash] - 10https://gerrit.wikimedia.org/r/121115 (owner: 10Isarra) [18:50:52] <^d> hoo, DanielK_WMDE_: +2'd [18:51:01] \o/ [18:51:03] Thanks [19:02:13] ^demon|lunch, hoo: looking at the code, it seems like it would still return null if $this->title isn't set and wgTitle is null. [19:02:26] oh crap [19:02:30] right [19:02:33] :P [19:02:37] make a test case :) [19:02:39] didn't think about that when changing [19:02:41] (03CR) 10Siebrand: "i18n/L10n reviewed." (033 comments) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/121128 (owner: 10Bsitu) [19:02:46] <^demon|lunch> kill the $wgTitle [19:02:46] * hoo slaps himself [19:02:47] (03CR) 10Siebrand: [C: 04-1] Add topic/post summary diff view [extensions/Flow] - 10https://gerrit.wikimedia.org/r/121128 (owner: 10Bsitu) [19:03:00] ^demon|lunch: Collateral damage ahead... [19:04:29] (03CR) 10Siebrand: [C: 031] "i18n/L10n reviewed." [core] - 10https://gerrit.wikimedia.org/r/117854 (owner: 10Ganeshaditya1) [19:05:41] (03PS1) 10Rillke: Replace wfMessage() with this->msg() [core] - 10https://gerrit.wikimedia.org/r/121129 [19:06:17] huh, i just learned that 'anomie' is a word. https://en.wiktionary.org/wiki/anomie [19:06:45] Hmm, cool [19:06:45] (03PS2) 10CSteipp: Allow copying DAO objects [extensions/OAuth] - 10https://gerrit.wikimedia.org/r/120974 [19:07:00] (03CR) 10Siebrand: [C: 032] Replace wfMessage() with this->msg() [core] - 10https://gerrit.wikimedia.org/r/121129 (owner: 10Rillke) [19:07:09] which should make you double careful always to use correct capitalisation [19:07:20] (03PS2) 10EBernhardson: New Hook rc/watchlist hook ChangesListBegin [core] - 10https://gerrit.wikimedia.org/r/121121 [19:07:25] (03CR) 10Nikerabbit: "I'm not quite convinced that this case is common enough to justify the shortcut." [core] - 10https://gerrit.wikimedia.org/r/121113 (owner: 10Aude) [19:08:35] (03CR) 10Rillke: "Ooops, forgot to mention that it was requsted in Ibe4b9da71ca6451" (031 comment) [core] - 10https://gerrit.wikimedia.org/r/121129 (owner: 10Rillke) [19:08:45] (03CR) 10Nikerabbit: "Why language code instead of language object? It would seem more consistent with the object." [core] - 10https://gerrit.wikimedia.org/r/121118 (owner: 10Aude) [19:10:08] (03PS1) 10CSteipp: Add maintenance script to copy db tables [extensions/OAuth] - 10https://gerrit.wikimedia.org/r/121131 [19:15:35] (03PS3) 10EBernhardson: New Hook rc/watchlist hook ChangesListInitRows [core] - 10https://gerrit.wikimedia.org/r/121121 [19:18:05] (03CR) 10Nemo bis: [C: 04-1] "Hi, thanks for your patch. Please improve the commit message: https://www.mediawiki.org/wiki/Gerrit/Commit_message_guidelines" [extensions/BookManagerv2] - 10https://gerrit.wikimedia.org/r/120362 (owner: 10Deepali) [19:18:48] (03CR) 10Nemo bis: [C: 04-1] "AFAICS this was replaced by https://gerrit.wikimedia.org/r/#/c/120573/ , you need to click the "abandon" button on this one" [core] - 10https://gerrit.wikimedia.org/r/120357 (owner: 10Deepali) [19:22:47] (03CR) 10Siebrand: [C: 032 V: 032] "Thanks, Grunny!" [extensions/BatchUserRights] - 10https://gerrit.wikimedia.org/r/121021 (owner: 10Grunny) [19:29:09] (03CR) 10Jorm: "This is an interface that is going to be seen by ten people in the world at most." [core] - 10https://gerrit.wikimedia.org/r/118111 (owner: 10Anomie) [19:37:48] (03PS1) 10EBernhardson: wfDebugLog calls must use the Flow log group [extensions/Flow] - 10https://gerrit.wikimedia.org/r/121137 [19:38:37] (03CR) 10Siebrand: [C: 031] "i18n/L10n reviewed." [extensions/JsonConfig] - 10https://gerrit.wikimedia.org/r/98767 (owner: 10Yurik) [19:39:13] Is something weird happening with quinit tests? it seems jenkins is stalling on them [19:44:20] rillke: About the commons config. thing... I'll try to deploy that tonight, but I have to stick to the deploy rules as this is non-urgent [19:46:15] hoo: "I have to stick to the deploy rules" -- does this mean you need an RfC ? [19:46:52] rillke: No (hopefully)... just that it needs to be done during a specific time window ;) [19:48:23] hoo: Did you read the notice Greg left there? I am not sure whether he is *demanding* community consensus shown. On the other hand it's just this stupid single message and he possibly didn't look at the diff. [19:49:01] rillke: I'll explain it and try to handle that later on... not a big deal IMO [19:50:08] hoo: Thanks. You are so diligent and helpful :-) Always has been a tremendous pleasure to work with you. [19:50:57] thanks... you're welcome :) [19:56:40] if you want to pass a title string( 'Talk:Foo' ) into something that only accepts Message instances, is `new RawMessage( $titleText )` prefered, or `new RawMessage( '$1', $titleText )` [20:07:23] (03PS1) 10Chad: Don't include Commons search results when doing interwiki searches [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/121139 [20:09:50] Krinkle: Looks like Jenkins has gone AWOL. https://gerrit.wikimedia.org/r/#/c/121129/ has been running for over an hour. puppet-validate and qunit jobs appear to be stuck at https://integration.wikimedia.org/zuul/ [20:12:29] Yeah, already investigating [20:12:42] hmm, stray 'multiple' in apisandbox [20:14:55] (03CR) 10Krinkle: "Killed this job by hand. Don't know what it's doing or why and don't have time to find out but it single handledly killed Jenkins's abilit" [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/121139 (owner: 10Chad) [20:23:43] (03CR) 10Ganeshaditya1: "Umm .. do I need to change anything else or is this fit to be merged ?" [core] - 10https://gerrit.wikimedia.org/r/117854 (owner: 10Ganeshaditya1) [20:24:50] <^d> I dunno how our phantomjs test could've been running over an hour. [20:24:56] <^d> Seeing as I committed the code only ~20m ago [20:26:17] <^d> the fact that qunit never runs in parallel doesn't help things ;-) [20:27:24] (03CR) 10Chad: "I highly doubt it was this test's fault as it was backed up for an hour before I even committed it, but sure let's blame this." [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/121139 (owner: 10Chad) [20:30:45] (03PS6) 10Hoo man: Return a Title in RequestContext::getTitle even if $wgTitle is null [core] - 10https://gerrit.wikimedia.org/r/120552 [20:30:50] ^d: ^ [20:31:05] luckily jenkins seems stalled so the broken version didn't make it [20:31:06] (03PS1) 10MarkTraceur: Add jQuery.arrowSteps to jsduck [core] - 10https://gerrit.wikimedia.org/r/121146 [20:33:47] (03CR) 10Hoo man: "Only return $wgTitle if it's not null (thanks, Daniel)" [core] - 10https://gerrit.wikimedia.org/r/120552 (owner: 10Hoo man) [20:34:03] (03PS2) 10Luis Felipe Schenone: Various changes based on comments to my initial commit [extensions/NukeDPL] - 10https://gerrit.wikimedia.org/r/121055 [20:35:23] (03PS2) 10MarkTraceur: Add jQuery.arrowSteps to jsduck [core] - 10https://gerrit.wikimedia.org/r/121146 [20:37:07] (03CR) 10jenkins-bot: [V: 04-1] Return a Title in RequestContext::getTitle even if $wgTitle is null [core] - 10https://gerrit.wikimedia.org/r/120552 (owner: 10Hoo man) [20:37:40] * hoo kills core with a rusty knife [20:42:48] (03PS1) 10MarkTraceur: Fix resources duplicate [core] - 10https://gerrit.wikimedia.org/r/121215 [20:44:33] (03PS1) 10Krinkle: mediawiki.html: Fix jsduck syntax for list, backtick html, link url. [core] - 10https://gerrit.wikimedia.org/r/121231 [20:44:58] (03PS2) 10Krinkle: mwjsduck-gen: Fix duplicate resources link [core] - 10https://gerrit.wikimedia.org/r/121215 (owner: 10MarkTraceur) [20:45:02] (03CR) 10Krinkle: [C: 032] mwjsduck-gen: Fix duplicate resources link [core] - 10https://gerrit.wikimedia.org/r/121215 (owner: 10MarkTraceur) [20:45:10] (03PS2) 10Krinkle: mediawiki.html: Fix jsduck syntax for list, backtick html, link url [core] - 10https://gerrit.wikimedia.org/r/121231 [20:45:31] marktraceur: https://gerrit.wikimedia.org/r/#/c/121231/ [20:48:23] In #wikimedia-office in ~10 minutes, jdlrobson & others discuss styling in templates https://www.mediawiki.org/wiki/Architecture_meetings/RFC_review_2014-03-26 [20:49:06] (03CR) 10Manybubbles: [C: 032] Don't include Commons search results when doing interwiki searches [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/121139 (owner: 10Chad) [20:49:13] (03CR) 10Hoo man: [C: 04-1] "This is frustrating... we need to find a proper solution for the unit tests failing :/" [core] - 10https://gerrit.wikimedia.org/r/120552 (owner: 10Hoo man) [20:51:58] (03CR) 10Amire80: "Steven asked about gender for Hebrew. It's always needed for imperatives, and if I understand correctly, "Edit the whole page" is an imper" [extensions/GuidedTour] - 10https://gerrit.wikimedia.org/r/119261 (owner: 10Phuedx) [20:53:46] aharoni: thanks! ^ [20:54:04] StevenW: you're welcome :) [20:54:35] (03CR) 10Anomie: "This seems like it's most likely a problem for early hooks. I worry that returning the main page is going to cause more subtle breakage wh" [core] - 10https://gerrit.wikimedia.org/r/120552 (owner: 10Hoo man) [20:55:22] StevenW: gender - always for imperatives ("Edit the page!"), always for past-tense 3rd person ("Sofia edited the page") [20:55:34] and for a lot of other things, too :0 [20:55:35] :) [20:56:20] (03CR) 10Krinkle: "It's just whatever tipped it over. Nothing personal or related to this extension or its tests indeed. Stated it here so you know why Jenki" [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/121139 (owner: 10Chad) [20:57:13] ah, the RFC meeting will also include discussion of Minifier https://www.mediawiki.org/wiki/Requests_for_comment/Minifier [20:57:55] yuvipanda, Deskana: Popups should be available everywhere now [20:58:01] spagewmf: wooot! :) [20:58:27] * Deskana checks. [20:59:07] where/what's Dan Garry on IRC? [20:59:13] spagewmf: Deskana [20:59:17] spagewmf: Well, I enabled the Beta Feature on the English Wikipedia, but I'm not getting the popups, unfortunately. [20:59:18] spagewmf: Deskana is Dan Garry [20:59:30] Deskana: you see Brion around today? [20:59:38] sumanah: he's out sick. [20:59:52] sumanah: No, sorry. [20:59:57] ah. Thanks Yuvi & Dan [21:00:27] spagewmf: I take that back. They seem to be working now. :) [21:00:40] (03PS1) 10MarkTraceur: Add jQuery.autoEllipsis to jsduck [core] - 10https://gerrit.wikimedia.org/r/121237 [21:01:03] Deskana: It's JavaScript, so shift-reload? [21:01:30] spagewmf: Seems to work now. [21:01:37] spagewmf: Thank you so much for your help! :) [21:01:52] (03PS2) 10Brian Wolff: Use rgba() for gallery caption background instead of opacity. [core] - 10https://gerrit.wikimedia.org/r/116227 [21:01:59] YuviPanda: should I have touched some .js file to encourage ResourceLoader? Hmm [21:02:18] spagewmf: give it the 5min window maybe? [21:03:14] (03PS5) 10Phuedx: Add a LESS test suite [core] - 10https://gerrit.wikimedia.org/r/119055 [21:04:09] (03CR) 10Aaron Schulz: [C: 032] Set X-Content-Duration header on ogg transcodes. [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/120185 (owner: 10Brian Wolff) [21:04:37] (03Merged) 10jenkins-bot: Set X-Content-Duration header on ogg transcodes. [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/120185 (owner: 10Brian Wolff) [21:07:10] (03CR) 10MarkTraceur: [C: 032] "Better, but could still use improvez" [core] - 10https://gerrit.wikimedia.org/r/121231 (owner: 10Krinkle) [21:07:44] YuviPanda, anyone: I'm always confused by RL behavior. The extension is newly enabled, it should be adding its ext.popups, but the status is "registered" not "ready". I'm logged in requesting a random page, so shouldn't the new PHP push its module down? [21:08:03] (03CR) 10Mglaser: [C: 032] "Looks good to me" [core] (REL1_19) - 10https://gerrit.wikimedia.org/r/120321 (owner: 10MarkAHershberger) [21:08:25] (03CR) 10Mglaser: [V: 032] "Looks good to me" [core] (REL1_19) - 10https://gerrit.wikimedia.org/r/120321 (owner: 10MarkAHershberger) [21:08:58] (03CR) 10Mglaser: [C: 032 V: 032] "Looks good to me" [core] (REL1_21) - 10https://gerrit.wikimedia.org/r/120320 (owner: 10MarkAHershberger) [21:09:03] (03CR) 10Raimond Spekking: [C: 04-1] Various changes based on comments to my initial commit (033 comments) [extensions/NukeDPL] - 10https://gerrit.wikimedia.org/r/121055 (owner: 10Luis Felipe Schenone) [21:09:20] spagewmf: that will not take effect on cached pages. [21:09:40] spagewmf: the list of modules loaded on a page is included in its HTML, and we cache that for 30 days for anonymous visitors. [21:09:52] spagewmf: VE rollout had some issues with that too. [21:10:01] MatmaRex: right, but I'm logged in. [21:10:28] (03PS3) 10Krinkle: Add jquery.arrowSteps to jsduck [core] - 10https://gerrit.wikimedia.org/r/121146 (owner: 10MarkTraceur) [21:10:32] (03CR) 10Krinkle: Add jquery.arrowSteps to jsduck (031 comment) [core] - 10https://gerrit.wikimedia.org/r/121146 (owner: 10MarkTraceur) [21:10:54] spagewmf: can i see it in action anywhere? [21:10:58] (03CR) 10Krinkle: [C: 032] Add jquery.arrowSteps to jsduck [core] - 10https://gerrit.wikimedia.org/r/121146 (owner: 10MarkTraceur) [21:11:09] MatmaRex: betafeature. [21:11:11] MatmaRex: on all wikis [21:11:50] wfm, then. [21:12:00] as in, i enabled it and i see the cards. [21:12:05] spagewmf: ^ [21:12:14] spagewmf: just overzealous caching at some points, I think. [21:12:58] we also cache just the parser output itself separately, and you might be getting the same as anon users if you haven't changed a lot of user preferences, but i don't think this should affect the loaded modules [21:13:01] yup, working for me en Francais [21:13:04] (03Merged) 10jenkins-bot: mediawiki.html: Fix jsduck syntax for list, backtick html, link url [core] - 10https://gerrit.wikimedia.org/r/121231 (owner: 10Krinkle) [21:13:13] if it was *just* deployed, then maybe LR just needed to "warm up" [21:13:17] RL* [21:14:17] MatmaRex: I wonder/wish there were an overview of caching. anyway, all good now [21:14:39] (03PS3) 10Krinkle: mwjsduck-gen: Fix duplicate resources link [core] - 10https://gerrit.wikimedia.org/r/121215 (owner: 10MarkTraceur) [21:14:49] (03CR) 10Krinkle: [C: 032] mwjsduck-gen: Fix duplicate resources link [core] - 10https://gerrit.wikimedia.org/r/121215 (owner: 10MarkTraceur) [21:18:10] (03PS1) 10Krinkle: mw.loader.store: Turn url into a link in jsduck docs [core] - 10https://gerrit.wikimedia.org/r/121242 [21:18:29] Deskana: can your buddy dgarry add a topic to the Flow discussion welcoming users on all wikis and other languages [21:19:08] spagewmf: I'm sure that can be arranged. :) [21:21:27] (03PS1) 10IAlex: Use session_id() instead of $wgSessionStarted to check for session existence [extensions/FacebookOpenGraph] - 10https://gerrit.wikimedia.org/r/121243 [21:21:41] (03Merged) 10jenkins-bot: Add jquery.arrowSteps to jsduck [core] - 10https://gerrit.wikimedia.org/r/121146 (owner: 10MarkTraceur) [21:21:59] (03Merged) 10jenkins-bot: mwjsduck-gen: Fix duplicate resources link [core] - 10https://gerrit.wikimedia.org/r/121215 (owner: 10MarkTraceur) [21:25:49] (03PS1) 10Kaldari: Turning off Typography Update feature in Beta features [extensions/VectorBeta] - 10https://gerrit.wikimedia.org/r/121244 [21:28:11] (03PS3) 10Luis Felipe Schenone: Various changes based on comments to my initial commit [extensions/NukeDPL] - 10https://gerrit.wikimedia.org/r/121055 [21:28:13] (03CR) 10Parent5446: [C: 04-1] Allow to optionally set language in Message constructor (031 comment) [core] - 10https://gerrit.wikimedia.org/r/121113 (owner: 10Aude) [21:29:35] (03PS1) 10IAlex: Use session_id() instead of $wgSessionStarted to check for session existence [extensions/SecureSessions] - 10https://gerrit.wikimedia.org/r/121246 [21:31:18] (03CR) 10Mattflaschen: [C: 04-1] "Tested, looks good for the most part." (035 comments) [extensions/GettingStarted] - 10https://gerrit.wikimedia.org/r/119972 (owner: 10Phuedx) [21:31:56] Please suggest how to handle "arguments.callee" javascript warning in JShint. [21:32:13] (03CR) 10Phuedx: "> I'm having a little trouble testing this locally in MW-Vagrant. I tried:" (032 comments) [core] - 10https://gerrit.wikimedia.org/r/119055 (owner: 10Phuedx) [21:34:20] (03CR) 10Shirayuki: [C: 04-1] Update copy [extensions/GettingStarted] - 10https://gerrit.wikimedia.org/r/119972 (owner: 10Phuedx) [21:35:15] (03PS1) 10IAlex: Use session_id() instead of $wgSessionStarted to check for session existence [extensions/SocialLogin] - 10https://gerrit.wikimedia.org/r/121250 [21:35:53] (03PS2) 10Krinkle: jsduck: Clean up existing documentation [core] - 10https://gerrit.wikimedia.org/r/121242 [21:37:19] (03PS3) 10Krinkle: jsduck: Clean up existing documentation [core] - 10https://gerrit.wikimedia.org/r/121242 [21:39:10] (03PS4) 10Krinkle: jsduck: Clean up existing documentation [core] - 10https://gerrit.wikimedia.org/r/121242 [21:40:25] (03PS5) 10Krinkle: Minor fixes for existing jsduck documentation in resources/mediawiki/* [core] - 10https://gerrit.wikimedia.org/r/121242 [21:41:08] (03CR) 10Swalling: Update copy (033 comments) [extensions/GettingStarted] - 10https://gerrit.wikimedia.org/r/119972 (owner: 10Phuedx) [21:45:05] marktraceur: https://gerrit.wikimedia.org/r/#/c/121242/ [21:52:34] (03PS1) 10Nemo bis: [WIP] Make captcha.py produce images in arbitrary language [extensions/ConfirmEdit] - 10https://gerrit.wikimedia.org/r/121255 [21:52:36] (03CR) 10jenkins-bot: [V: 04-1] [WIP] Make captcha.py produce images in arbitrary language [extensions/ConfirmEdit] - 10https://gerrit.wikimedia.org/r/121255 (owner: 10Nemo bis) [21:53:03] (03CR) 10Krinkle: [C: 04-1] "jshint is fast enough to not really need optimisation like this (unlike php lint, which is rather slow). Plus I think this has side effect" [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/121127 (owner: 10Adamw) [21:53:16] (03CR) 10Aude: Allow to optionally set language in Message constructor (031 comment) [core] - 10https://gerrit.wikimedia.org/r/121113 (owner: 10Aude) [21:54:19] (03CR) 10MarkTraceur: [C: 032] "LGTM!" [core] - 10https://gerrit.wikimedia.org/r/121242 (owner: 10Krinkle) [21:54:40] (03PS2) 10Aude: Add getLanguage method to Message [core] - 10https://gerrit.wikimedia.org/r/121118 [21:54:42] (03PS2) 10Aude: Allow to optionally set language in Message constructor [core] - 10https://gerrit.wikimedia.org/r/121113 [21:54:48] (03CR) 10Krinkle: "When no relevant files of the kind are changed at all, we filter the job out entirely at the Zuul level (see files: filter in zuul-config)" [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/121127 (owner: 10Adamw) [21:56:45] (03Abandoned) 10Adamw: UNTESTED: Only run jshint on modified files [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/121127 (owner: 10Adamw) [21:57:58] So... I need to automate functional testing for some stuff which only runs on MySQL. Do we do that anywhere? Should I set up a virtual machine for each test, or a mysql ramdisk? [21:59:39] (03PS1) 10Adi.iiita: LiquidThreads should pass jshint [extensions/LiquidThreads] - 10https://gerrit.wikimedia.org/r/121257 [21:59:43] (03Merged) 10jenkins-bot: Minor fixes for existing jsduck documentation in resources/mediawiki/* [core] - 10https://gerrit.wikimedia.org/r/121242 (owner: 10Krinkle) [22:10:14] http://www.patatap.com/ [22:11:26] type a long sentence and stuff gets produced, refresh and do the same and get something different [22:12:22] did you find it from r/InternetIsBeautiful? [22:19:51] (03PS1) 10Bsitu: Move method isComparableTo() to parent class [extensions/Flow] - 10https://gerrit.wikimedia.org/r/121262 [22:20:17] (03CR) 10jenkins-bot: [V: 04-1] Move method isComparableTo() to parent class [extensions/Flow] - 10https://gerrit.wikimedia.org/r/121262 (owner: 10Bsitu) [22:20:45] Hm, photo’s inside the hovercards are not working on nlwiki. :/ [22:26:35] I am facing a weird error in my integration build in javascript... the code has checked a variable to be undefined.. and the build shows the error that variable is undefined.. how to tackle this? http://www.fpaste.org/89001/95872682/ [22:26:47] (03CR) 10Catrope: [C: 032] resourceloader: Sanitize lang code before creating Language object [core] - 10https://gerrit.wikimedia.org/r/119644 (owner: 10Krinkle) [22:28:07] * zeek feels that bd808 may assist here... ^ [22:28:35] zeek: You could try changing the line to [22:28:40] useDialogs = window.wgWikiEditorPreferences.toolbar.dialogs; [22:28:58] Will it not cause cross browser issues? [22:28:59] * bawolff doesn't know js very well, no idea if that's proper or good or even would work [22:29:13] zeek: I mean keep the typeof line in the if coniditional [22:29:16] * bd808 hides from scary javascript [22:29:44] mmmm.... I cant even test if it would work... :P [22:29:48] (03Abandoned) 10Siebrand: Localisation updates from https://translatewiki.net. [extensions/Collection] (OCG) - 10https://gerrit.wikimedia.org/r/107167 (owner: 10Mwalker) [22:30:08] (03PS3) 10Mglaser: update RELEASE-NOTES-1.22 for bug 60543 [core] (REL1_22) - 10https://gerrit.wikimedia.org/r/110408 (owner: 10Se4598) [22:30:12] I think the error is the linter is because the linter can't recognize that you checked for definedness in the condition [22:30:12] sjoerddebruin: file bug? :) [22:30:17] (03CR) 10Catrope: [C: 032] ResourceLoaderStartUpModule: Use hashMtime to detect config changes [core] - 10https://gerrit.wikimedia.org/r/119706 (owner: 10Krinkle) [22:30:27] Hm, maybe. [22:30:29] yup thats true... [22:31:10] (03Merged) 10jenkins-bot: resourceloader: Sanitize lang code before creating Language object [core] - 10https://gerrit.wikimedia.org/r/119644 (owner: 10Krinkle) [22:31:34] Referring to global variables via window should always work, and it will probably confuse the linter's is it defined check [22:32:39] This is not the intended behaviour I think zz_yuvipanda? https://www.dropbox.com/s/egtf5qltnalbc57/Screenshot%202014-03-26%2023.32.25.png [22:33:03] ow! probably not, sjoerddebruin [22:33:03] sjoerddebruin: that definitely doesn't look right [22:33:17] I’ve emptied my cache... [22:33:20] sjoerddebruin: Deskana is PM for popups, he should be able to figure out what to do... [22:33:22] I think [22:33:49] Going to test some other browsers [22:33:53] sjoerddebruin: Whoa, that's really strange. [22:34:05] sjoerddebruin: First thing. Do you have the Navigation Popups gadget enabled? [22:34:08] No. [22:34:29] Hmm. [22:34:35] Chrome is looking good. But i’m a Safari-user. [22:34:48] (03CR) 10Mglaser: [C: 032 V: 032] "Rebased this" [core] (REL1_22) - 10https://gerrit.wikimedia.org/r/110408 (owner: 10Se4598) [22:34:57] sjoerddebruin: Let me load Safari and see if I can replicate this problem. [22:35:03] Would be great. [22:35:30] What do you think of this one? :P https://www.dropbox.com/s/2d61wp9hj817p2i/Screenshot%202014-03-26%2023.35.27.png [22:35:45] sjoerddebruin: Yeah, I get the exact same behaviour as you do in Safari. [22:36:46] sjoerddebruin: I'll file a bug for this. [22:36:47] (03Merged) 10jenkins-bot: ResourceLoaderStartUpModule: Use hashMtime to detect config changes [core] - 10https://gerrit.wikimedia.org/r/119706 (owner: 10Krinkle) [22:36:56] Thanks. You can use my screenshots if you like. [22:37:17] (03PS2) 10Bsitu: Move method isComparableTo() to parent class [extensions/Flow] - 10https://gerrit.wikimedia.org/r/121262 [22:39:21] sjoerddebruin: Here we go: https://bugzilla.wikimedia.org/show_bug.cgi?id=63153 [22:39:31] sjoerddebruin: Feel free to CC yourself on the bug if you want updates. :) [22:39:39] I always do that. :P [22:39:40] sjoerddebruin: Thanks very much for the report. [22:39:46] Yeah, I love the idea btw. [22:40:44] Glad to hear it! [22:45:02] (03PS2) 10Adi.iiita: LiquidThreads should pass jshint [extensions/LiquidThreads] - 10https://gerrit.wikimedia.org/r/121257 [22:45:41] !g 80298d5 [22:45:41] https://gerrit.wikimedia.org/r/#q,80298d5,n,z [22:46:23] (03PS1) 10MarkTraceur: Add jquery.badge to the jsduck config [core] - 10https://gerrit.wikimedia.org/r/121267 [22:47:23] (03CR) 10jenkins-bot: [V: 04-1] Add jquery.badge to the jsduck config [core] - 10https://gerrit.wikimedia.org/r/121267 (owner: 10MarkTraceur) [22:49:03] (03CR) 10Bsitu: Add topic/post summary diff view (031 comment) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/121128 (owner: 10Bsitu) [22:49:20] WIll "mwSetupToolbar();" in javascript be in "window." namespace or "mw." ? [22:49:42] (03PS2) 10MarkTraceur: Add jquery.badge to the jsduck config [core] - 10https://gerrit.wikimedia.org/r/121267 [22:49:54] (03PS2) 10Bsitu: Add topic/post summary diff view [extensions/Flow] - 10https://gerrit.wikimedia.org/r/121128 [22:50:00] (03PS1) 10Krinkle: jquery.spinner: Use @chainable for #injectSpinner [core] - 10https://gerrit.wikimedia.org/r/121269 [22:50:55] (03CR) 10jenkins-bot: [V: 04-1] Add topic/post summary diff view [extensions/Flow] - 10https://gerrit.wikimedia.org/r/121128 (owner: 10Bsitu) [22:51:13] WIll "mwSetupToolbar();" in javascript be in "window." namespace or "mw." ? /* need help to cook JS */ [22:52:14] (03CR) 10Se4598: "hm... due the manual rebase the release note for bug 60543 is now included twice (at the top and also at the bottom of the section)" [core] (REL1_22) - 10https://gerrit.wikimedia.org/r/110408 (owner: 10Se4598) [22:58:41] (03PS2) 10Jdlrobson: Typography update to Vector skin [core] - 10https://gerrit.wikimedia.org/r/120978 (owner: 10Kaldari) [22:58:54] (03CR) 10Jdlrobson: Typography update to Vector skin (039 comments) [core] - 10https://gerrit.wikimedia.org/r/120978 (owner: 10Kaldari) [22:59:09] (03CR) 10Jdlrobson: [C: 04-1] "A few tweaks needed before this is good to merge - see my notes on the patchset before." [core] - 10https://gerrit.wikimedia.org/r/120978 (owner: 10Kaldari) [23:03:43] (03PS2) 10Swalling: Turning off Typography Update feature in Beta features [extensions/VectorBeta] - 10https://gerrit.wikimedia.org/r/121244 (owner: 10Kaldari) [23:05:38] (03PS1) 10Se4598: remove duplicates from release notes [core] (REL1_22) - 10https://gerrit.wikimedia.org/r/121275 [23:06:08] (03PS1) 10MarkTraceur: Add jquery.byteLimit to jsduck [core] - 10https://gerrit.wikimedia.org/r/121276 [23:07:33] (03CR) 10Nemo bis: "Mxn, look: http://markmail.org/message/q5ehdmw3illr6cta" [extensions/ConfirmEdit] - 10https://gerrit.wikimedia.org/r/113122 (owner: 10Norayr) [23:07:41] (03CR) 10Hoo man: [C: 032] remove duplicates from release notes [core] (REL1_22) - 10https://gerrit.wikimedia.org/r/121275 (owner: 10Se4598) [23:11:18] (03Merged) 10jenkins-bot: remove duplicates from release notes [core] (REL1_22) - 10https://gerrit.wikimedia.org/r/121275 (owner: 10Se4598) [23:11:24] (03CR) 10Brian Wolff: [C: 032] "Looks like jenkins got stuck" [core] - 10https://gerrit.wikimedia.org/r/121129 (owner: 10Rillke) [23:15:54] (03PS5) 10Brian Wolff: Make generating Parser test class names more robust [core] - 10https://gerrit.wikimedia.org/r/67098 [23:16:55] (03Merged) 10jenkins-bot: Replace wfMessage() with this->msg() [core] - 10https://gerrit.wikimedia.org/r/121129 (owner: 10Rillke) [23:19:01] (03CR) 10Bartosz Dziewoński: "Fixed in 9a321bd91d42570c7e6eb79eb7dee1ea8a2925f5." [core] (REL1_22) - 10https://gerrit.wikimedia.org/r/110408 (owner: 10Se4598) [23:19:35] (03CR) 10Hoo man: "@Anomie: So you would prefer to change the interface to have "@return Title|null" and then change all users to support both? That's probab" [core] - 10https://gerrit.wikimedia.org/r/120552 (owner: 10Hoo man) [23:30:54] (03PS1) 10MaxSem: Update MobileFrontend to wmf/1.23wmf19 tip [core] (wmf/1.23wmf19) - 10https://gerrit.wikimedia.org/r/121278 [23:30:59] (03CR) 10Bartosz Dziewoński: "I'm not a huge fan of how this changes the generated return type to "jQuery.plugin.spinner"…" [core] - 10https://gerrit.wikimedia.org/r/121269 (owner: 10Krinkle) [23:31:40] (03CR) 10Ori.livneh: [C: 032] Update MobileFrontend to wmf/1.23wmf19 tip [core] (wmf/1.23wmf19) - 10https://gerrit.wikimedia.org/r/121278 (owner: 10MaxSem) [23:35:55] (03Merged) 10jenkins-bot: Update MobileFrontend to wmf/1.23wmf19 tip [core] (wmf/1.23wmf19) - 10https://gerrit.wikimedia.org/r/121278 (owner: 10MaxSem) [23:39:42] (03PS3) 10Adi.iiita: LiquidThreads should pass jshint [extensions/LiquidThreads] - 10https://gerrit.wikimedia.org/r/121257 [23:41:21] (03PS2) 10Nemo bis: [WIP] Make captcha.py produce images in arbitrary language [extensions/ConfirmEdit] - 10https://gerrit.wikimedia.org/r/121255 [23:41:23] (03CR) 10jenkins-bot: [V: 04-1] [WIP] Make captcha.py produce images in arbitrary language [extensions/ConfirmEdit] - 10https://gerrit.wikimedia.org/r/121255 (owner: 10Nemo bis) [23:43:18] (03PS3) 10Nemo bis: [WIP] Make captcha.py produce images in arbitrary language [extensions/ConfirmEdit] - 10https://gerrit.wikimedia.org/r/121255 [23:45:28] (03CR) 10Nemo bis: "PS2 puts the basics in place, PS3 rebase. You can already run it locally to see how it looks, try e.g. making 1000 images with 100 words." [extensions/ConfirmEdit] - 10https://gerrit.wikimedia.org/r/121255 (owner: 10Nemo bis) [23:45:37] I need some javascript help to remove a non-voting error (part of a bug) http://www.fpaste.org/89008/58774441/ Please have a look and suggest. [23:47:22] zeek: well, the $$options variable is defined (as a function argument), but never used inside the body of the function [23:47:27] other than in a comment [23:47:46] MatmaRex: yeah I can see that, but how to fix that, because it is there for a purpose [23:48:13] ignore the error? [23:48:21] or i suppose you could comment the definition too, as in: [23:48:27] $.fn.thread_collapse = function( /* $$options */ ) { [23:49:44] (03CR) 10Nemo bis: [WIP] Make captcha.py produce images in arbitrary language (031 comment) [extensions/ConfirmEdit] - 10https://gerrit.wikimedia.org/r/121255 (owner: 10Nemo bis) [23:49:45] But in case this function is being used somewhere where a argument is being passed? [23:50:25] (03CR) 10Krinkle: [C: 04-1] "Indeed, that's a weird side-effect. Don't think that's intended." [core] - 10https://gerrit.wikimedia.org/r/121269 (owner: 10Krinkle) [23:51:54] (03Abandoned) 10Krinkle: jquery.spinner: Use @chainable for #injectSpinner [core] - 10https://gerrit.wikimedia.org/r/121269 (owner: 10Krinkle) [23:52:22] zeek: javascript doesn't care about the number of arguments [23:52:52] zeek: missing ones are filled with `undefined`s, excess ones are just ignored (but available via the `arguments` object) [23:53:12] ok, wasn't sure about that. It would comment it then. Thanks :) [23:53:24] happy to help [23:54:32] zeek: MatmaRex: It's unused because the code that used it was commented out, if that code is going away, you'd just remove that argument alltogether. [23:55:39] Krinkle: Yes I had commented it out, because the variable $settings was unused. I didn't remove it entirely considering the developer may have something in mind to do later with it. [23:56:28] zeek: We have version control for that. If this is for a Wikimedia project, we generally don't keep commented out code. [23:56:50] It's fine for a work in progress if you find it helpful. [23:57:04] Yes this is for Liquid Extensions. Should I remove it entirely? [23:57:13] Yep [23:57:22] cool doing now. [23:59:19] (03PS4) 10Adi.iiita: LiquidThreads should pass jshint [extensions/LiquidThreads] - 10https://gerrit.wikimedia.org/r/121257