[00:00:18] (03CR) 10jenkins-bot: [V: 04-1] Anonymous editor warning. Now with links to log in and register. [extensions/Flow] - 10https://gerrit.wikimedia.org/r/117846 (owner: 10Werdna) [00:00:55] superm401: are you working on editor-engagement migration? /data/project/git_files is changing while I try to tar it up [00:01:44] (03CR) 10Werdna: "Build failure is unrelated" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/117846 (owner: 10Werdna) [00:02:08] spagewmf, nope, haven't touched it at all today or this weekend. [00:03:40] (03PS1) 10Bsitu: Flow's Echo notificaiton is not being set up correctly [extensions/Flow] - 10https://gerrit.wikimedia.org/r/120716 [00:04:35] superm401 no, it's puppet "group changed 'project-editor-engagement' to 'www-data'" puppetd was running on ee-flow-extra [00:04:39] https://github.com/wikimedia/operations-puppet/blob/production/modules/ircd/manifests/mediawiki-irc-relay.pp [00:04:43] huh: [00:04:51] https://github.com/wikimedia/operations-puppet/blob/production/templates/misc/udpmxircecho.py.erb [00:05:17] https://github.com/wikimedia/operations-puppet/tree/production/templates/udp2log [00:05:21] interesting [00:06:23] https://github.com/wikimedia/operations-mediawiki-config/blob/master/wmf-config/CommonSettings.php#L2632 [00:06:25] (03PS3) 10Bsitu: Replace generic "Internal error - {{SITENAME}}" on error page [extensions/Flow] - 10https://gerrit.wikimedia.org/r/120708 [00:06:30] It's all there [00:06:36] though I can't find anonymous/special.user [00:06:50] where is the ircd code? [00:07:04] upstream package [00:07:15] https://wikitech.wikimedia.org/wiki/Irc [00:07:17] But.. [00:07:19] it is patched [00:07:20] (03Abandoned) 10JGonera: [WIP] Update OOjs UI to v0.1.0-pre (f11efdf6b3) [core] - 10https://gerrit.wikimedia.org/r/120164 (owner: 10JGonera) [00:07:33] to disallow creation of channels and speaking for anyone not op [00:07:38] (which is only rc-pmtpa) [00:07:52] or rather half-op, for some [00:07:53] reason [00:08:15] (03CR) 10jenkins-bot: [V: 04-1] Replace generic "Internal error - {{SITENAME}}" on error page [extensions/Flow] - 10https://gerrit.wikimedia.org/r/120708 (owner: 10Bsitu) [00:13:19] it's been there for a while [00:13:25] googled found an old log [00:13:26] https://raw.githubusercontent.com/yeskarthik/wpeditlog/master/logs.txt [00:13:28] (03PS4) 10Bsitu: Replace generic "Internal error - {{SITENAME}}" on error page [extensions/Flow] - 10https://gerrit.wikimedia.org/r/120708 [00:13:30] 2y ago [00:13:36] anyway, giving up :) [00:15:09] (03PS9) 10Krinkle: resourceloader: Optimize module registry sent in the startup module [core] - 10https://gerrit.wikimedia.org/r/72534 (owner: 10Hoo man) [00:15:45] (03CR) 10JGonera: [C: 04-1] "Menu still overlaps the hamburger. There's a weird vertical line to the right of the page title. Tested in Firefox." [extensions/VectorBeta] - 10https://gerrit.wikimedia.org/r/117927 (owner: 10Jdlrobson) [00:18:12] andre___: Do you maintain the "Gerrit Notification Bot"? [00:19:06] hoo: That's a built-in feature in Gerrit itself, configured in operations/puppet [00:19:43] (03PS4) 10Bsitu: Add 'edit topic summary' no javascript support [extensions/Flow] - 10https://gerrit.wikimedia.org/r/120485 [00:19:46] mh... will have a look [00:19:56] * hoo prays it's not yet another messy perl thing [00:23:02] (03PS18) 10Jdlrobson: Give Vector/Winter Minerva's hamburger menu icon [extensions/VectorBeta] - 10https://gerrit.wikimedia.org/r/117927 [00:23:13] (03CR) 10Jdlrobson: "Added -moz-box-sizing" [extensions/VectorBeta] - 10https://gerrit.wikimedia.org/r/117927 (owner: 10Jdlrobson) [00:26:57] (03PS5) 10Bsitu: Replace generic "Internal error - {{SITENAME}}" on error page [extensions/Flow] - 10https://gerrit.wikimedia.org/r/120708 [00:34:21] (03CR) 10Krinkle: [C: 031] Log usage of deprecated JavaScript functionality [extensions/WikimediaEvents] - 10https://gerrit.wikimedia.org/r/119903 (owner: 10Ori.livneh) [00:34:55] (03PS1) 10Kaldari: Using more UI agnostic language in licensing notice [extensions/WikimediaMessages] - 10https://gerrit.wikimedia.org/r/120725 [00:35:28] (03PS2) 10BryanDavis: Add a PSR-3 based logging interface [core] - 10https://gerrit.wikimedia.org/r/119940 [00:35:49] (03CR) 10BryanDavis: "Response to feedback inline." (034 comments) [core] - 10https://gerrit.wikimedia.org/r/119940 (owner: 10BryanDavis) [00:35:58] (03PS1) 10Jforrester: Update OOjs UI to v0.1.0 [core] - 10https://gerrit.wikimedia.org/r/120726 [00:36:01] (03PS3) 10BryanDavis: Add a PSR-3 based logging interface [core] - 10https://gerrit.wikimedia.org/r/119940 [00:36:14] (03Abandoned) 10Kaldari: Using more UI agnostic language in licensing notice [extensions/WikimediaMessages] - 10https://gerrit.wikimedia.org/r/120725 (owner: 10Kaldari) [00:38:43] (03CR) 10Trevor Parscal: [C: 032] Update OOjs UI to v0.1.0 [core] - 10https://gerrit.wikimedia.org/r/120726 (owner: 10Jforrester) [00:39:09] (03PS1) 10Kaldari: Using more UI agnostic language in licensing notice [extensions/WikimediaMessages] - 10https://gerrit.wikimedia.org/r/120728 [00:40:28] (03PS2) 10BryanDavis: Enable MWLogger logging for legacy logging methods [core] - 10https://gerrit.wikimedia.org/r/119941 [00:41:25] (03CR) 10BryanDavis: Enable MWLogger logging for legacy logging methods (031 comment) [core] - 10https://gerrit.wikimedia.org/r/119941 (owner: 10BryanDavis) [00:41:31] (03PS3) 10BryanDavis: Enable MWLogger logging for legacy logging methods [core] - 10https://gerrit.wikimedia.org/r/119941 [00:41:38] (03CR) 10jenkins-bot: [V: 04-1] Enable MWLogger logging for legacy logging methods [core] - 10https://gerrit.wikimedia.org/r/119941 (owner: 10BryanDavis) [00:42:39] (03CR) 10jenkins-bot: [V: 04-1] Enable MWLogger logging for legacy logging methods [core] - 10https://gerrit.wikimedia.org/r/119941 (owner: 10BryanDavis) [00:44:48] (03CR) 10jenkins-bot: [V: 04-1] Update OOjs UI to v0.1.0 [core] - 10https://gerrit.wikimedia.org/r/120726 (owner: 10Jforrester) [00:45:19] (03Merged) 10jenkins-bot: Update OOjs UI to v0.1.0 [core] - 10https://gerrit.wikimedia.org/r/120726 (owner: 10Jforrester) [00:45:32] (03PS4) 10BryanDavis: Enable MWLogger logging for legacy logging methods [core] - 10https://gerrit.wikimedia.org/r/119941 [00:45:34] (03PS4) 10BryanDavis: Add a PSR-3 based logging interface [core] - 10https://gerrit.wikimedia.org/r/119940 [00:45:36] (03PS4) 10BryanDavis: Add Composer managed libraries [core] - 10https://gerrit.wikimedia.org/r/119939 [00:46:29] (03CR) 10BryanDavis: "Patch set 4 was a manual rebase." [core] - 10https://gerrit.wikimedia.org/r/119939 (owner: 10BryanDavis) [00:46:45] (03CR) 10BryanDavis: "Patch set 4 was a manual rebase." [core] - 10https://gerrit.wikimedia.org/r/119940 (owner: 10BryanDavis) [00:46:59] (03CR) 10BryanDavis: "Patch set 4 was a manual rebase." [core] - 10https://gerrit.wikimedia.org/r/119941 (owner: 10BryanDavis) [00:57:58] (03PS1) 10Bsitu: Remove [] from URL [extensions/Flow] - 10https://gerrit.wikimedia.org/r/120732 [00:58:24] (03CR) 10Krinkle: Add a PSR-3 based logging interface (031 comment) [core] - 10https://gerrit.wikimedia.org/r/119940 (owner: 10BryanDavis) [01:01:55] (03CR) 10Krinkle: "@Erik: These parameters aren't being used right? So should these array items be removed?" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/120732 (owner: 10Bsitu) [01:02:26] (03PS26) 10Werdna: Extract wiki and external links, file and template usages from text. [extensions/Flow] - 10https://gerrit.wikimedia.org/r/110090 [01:02:29] (03PS1) 10Werdna: Implement multiPut method. [extensions/Flow] - 10https://gerrit.wikimedia.org/r/120734 [01:02:44] (03CR) 10jenkins-bot: [V: 04-1] Extract wiki and external links, file and template usages from text. [extensions/Flow] - 10https://gerrit.wikimedia.org/r/110090 (owner: 10Werdna) [01:02:53] (03CR) 10jenkins-bot: [V: 04-1] Implement multiPut method. [extensions/Flow] - 10https://gerrit.wikimedia.org/r/120734 (owner: 10Werdna) [01:03:03] (03CR) 10Werdna: "PS26: Rebase on top of change 120734." [extensions/Flow] - 10https://gerrit.wikimedia.org/r/110090 (owner: 10Werdna) [01:04:50] (03CR) 10Werdna: "Oh noes, I broke everything :(" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/120734 (owner: 10Werdna) [01:13:27] (03CR) 10EBernhardson: "This whole thing is actually changing, the code has moved here:" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/120732 (owner: 10Bsitu) [01:13:30] (03CR) 10BryanDavis: Add a PSR-3 based logging interface (031 comment) [core] - 10https://gerrit.wikimedia.org/r/119940 (owner: 10BryanDavis) [01:14:05] (03CR) 10EBernhardson: [C: 04-1] "passing unnecessary url parameters, still need to double check the rest." (031 comment) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/117384 (owner: 10EBernhardson) [01:20:54] (03PS15) 10EBernhardson: Make BoardHistory a Formatter instance [extensions/Flow] - 10https://gerrit.wikimedia.org/r/115532 [01:20:57] (03PS14) 10EBernhardson: Refactor Flow\\Formatter namespace [extensions/Flow] - 10https://gerrit.wikimedia.org/r/117384 [01:21:20] (03CR) 10jenkins-bot: [V: 04-1] Refactor Flow\\Formatter namespace [extensions/Flow] - 10https://gerrit.wikimedia.org/r/117384 (owner: 10EBernhardson) [01:24:20] (03PS2) 10Werdna: Implement multiPut method. [extensions/Flow] - 10https://gerrit.wikimedia.org/r/120734 [01:24:23] (03PS27) 10Werdna: Extract wiki and external links, file and template usages from text. [extensions/Flow] - 10https://gerrit.wikimedia.org/r/110090 [01:24:34] (03CR) 10jenkins-bot: [V: 04-1] Implement multiPut method. [extensions/Flow] - 10https://gerrit.wikimedia.org/r/120734 (owner: 10Werdna) [01:24:45] (03CR) 10jenkins-bot: [V: 04-1] Extract wiki and external links, file and template usages from text. [extensions/Flow] - 10https://gerrit.wikimedia.org/r/110090 (owner: 10Werdna) [01:26:38] (03PS4) 10Krinkle: MWException: Fix sitename appearing twice in [core] - 10https://gerrit.wikimedia.org/r/118665 [01:26:45] <grrrit-wm> (03CR) 10BryanDavis: [C: 04-1] "Rather than doing this globally, it would be better to make it a feature of role::multimediaviewer. You can look at the apache::conf block" [vagrant] - 10https://gerrit.wikimedia.org/r/120614 (owner: 10Gilles) [01:28:30] <grrrit-wm> (03PS1) 10MarkTraceur: Fix EventLogging schema registry [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/120737 [01:28:37] <marktraceur> ori: https://gerrit.wikimedia.org/r/120737 [01:28:48] <marktraceur> ...hm, I guess it was in here and I just have grrrit-wm muted. [01:29:04] <marktraceur> Long story short, Yuvi and I are idiots and should have seen that. [01:32:05] <grrrit-wm> (03PS16) 10EBernhardson: Make BoardHistory a Formatter instance [extensions/Flow] - 10https://gerrit.wikimedia.org/r/115532 [01:32:08] <grrrit-wm> (03PS15) 10EBernhardson: Refactor Flow\\Formatter namespace [extensions/Flow] - 10https://gerrit.wikimedia.org/r/117384 [01:32:23] <grrrit-wm> (03CR) 10jenkins-bot: [V: 04-1] Make BoardHistory a Formatter instance [extensions/Flow] - 10https://gerrit.wikimedia.org/r/115532 (owner: 10EBernhardson) [01:33:23] <grrrit-wm> (03PS6) 10EBernhardson: New Hook rc/watchlist hook ChangesListBegin [core] - 10https://gerrit.wikimedia.org/r/116649 [01:33:33] <grrrit-wm> (03CR) 10EBernhardson: "PS6: rebase" [core] - 10https://gerrit.wikimedia.org/r/116649 (owner: 10EBernhardson) [01:38:43] <grrrit-wm> (03CR) 10Werdna: [V: 032] "Jenkins failure is a transient one." [extensions/Flow] - 10https://gerrit.wikimedia.org/r/120734 (owner: 10Werdna) [01:41:27] <grrrit-wm> (03CR) 10Addshore: [C: 032] Autoloader incorrect case warnings fixed [core] - 10https://gerrit.wikimedia.org/r/120560 (owner: 10Christopher Johnson (WMDE)) [01:45:59] <grrrit-wm> (03Merged) 10jenkins-bot: Autoloader incorrect case warnings fixed [core] - 10https://gerrit.wikimedia.org/r/120560 (owner: 10Christopher Johnson (WMDE)) [01:57:18] <grrrit-wm> (03PS2) 10Gilles: Have ?download parameter trigger Content-Disposition: attachment [core] - 10https://gerrit.wikimedia.org/r/120703 [02:06:48] <grrrit-wm> (03CR) 10EBernhardson: [C: 032] Flow's Echo notificaiton is not being set up correctly [extensions/Flow] - 10https://gerrit.wikimedia.org/r/120716 (owner: 10Bsitu) [02:07:05] <grrrit-wm> (03Merged) 10jenkins-bot: Flow's Echo notificaiton is not being set up correctly [extensions/Flow] - 10https://gerrit.wikimedia.org/r/120716 (owner: 10Bsitu) [02:11:01] <grrrit-wm> (03CR) 10Ori.livneh: "You are assuming too much about the order in which hooks fire and modules are registered. The decision to register the schema module shoul" [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/120737 (owner: 10MarkTraceur) [02:11:09] <grrrit-wm> (03CR) 10Ori.livneh: [C: 04-1] "Per comment" [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/120737 (owner: 10MarkTraceur) [02:18:10] <grrrit-wm> (03PS1) 10EBernhardson: Flow's Echo notificaiton is not being set up correctly [extensions/Flow] (wmf/1.23wmf19) - 10https://gerrit.wikimedia.org/r/120746 [02:20:28] <grrrit-wm> (03PS3) 10Gilles: Add ?download parameter to images [vagrant] - 10https://gerrit.wikimedia.org/r/120614 [02:21:25] <grrrit-wm> (03CR) 10Gilles: "Bryan, since I'm writing code semi-blind again, how would I test this change locally? What command would "refresh" my roles based on the c" [vagrant] - 10https://gerrit.wikimedia.org/r/120614 (owner: 10Gilles) [02:21:36] <grrrit-wm> (03CR) 10Chad: [C: 032] Update formatting for includes/specials/ [core] - 10https://gerrit.wikimedia.org/r/120326 (owner: 10Siebrand) [02:24:21] <grrrit-wm> (03CR) 10Chad: [C: 04-1] Fix CodeSniffer errors and warnings in includes/specials (1) (036 comments) [core] - 10https://gerrit.wikimedia.org/r/120328 (owner: 10Siebrand) [02:25:16] <grrrit-wm> (03PS4) 10Mattflaschen: Fixed css issue where long copyright text and radio buttons are separated [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/61339 (owner: 10Rasel160) [02:25:40] <grrrit-wm> (03Merged) 10jenkins-bot: Update formatting for includes/specials/ [core] - 10https://gerrit.wikimedia.org/r/120326 (owner: 10Siebrand) [02:27:09] <grrrit-wm> (03PS5) 10Mattflaschen: Fixed css issue where long copyright text and radio buttons are separated [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/61339 (owner: 10Rasel160) [02:27:33] <grrrit-wm> (03CR) 10MarkAHershberger: [C: 031] "looking good. Will +2 shortly if no one raises any issues." [extensions/LiquidThreads] - 10https://gerrit.wikimedia.org/r/118212 (owner: 10Adi.iiita) [02:28:01] <grrrit-wm> (03CR) 10Mattflaschen: "Patch set 4 is a rebase, since otherwise you run into unrelated bugs when testing with recent core." [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/61339 (owner: 10Rasel160) [02:54:35] <grrrit-wm> (03CR) 10BryanDavis: "Gilles, `vagrant provision` will apply the latest puppet configuration changes to your local virtual machine." [vagrant] - 10https://gerrit.wikimedia.org/r/120614 (owner: 10Gilles) [03:49:52] <grrrit-wm> (03CR) 10Mattflaschen: [C: 032] "Tested in recent Firefox and Chromium, and IE 7 through 11" [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/61339 (owner: 10Rasel160) [03:50:05] <grrrit-wm> (03Merged) 10jenkins-bot: Fixed css issue where long copyright text and radio buttons are separated [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/61339 (owner: 10Rasel160) [03:55:08] <grrrit-wm> (03CR) 10Gilles: "Awesome, thanks! I've tested the latest version of the changeset and it works fine on my end." [vagrant] - 10https://gerrit.wikimedia.org/r/120614 (owner: 10Gilles) [04:07:13] <grrrit-wm> (03Abandoned) 10Severin Anatoliy: Fix 'wikiforum-posted' message in russian [extensions/WikiForum] - 10https://gerrit.wikimedia.org/r/120353 (owner: 10Severin Anatoliy) [04:15:20] <grrrit-wm> (03CR) 10Prtksxna: "Thanks Hashar!" [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/120349 (owner: 10Prtksxna) [04:20:30] <grrrit-wm> (03PS1) 10thibaultmarin: A few improvements: - Fixes for use under windows: . Use wfShellExecWithStderr to get stdout/stderr text instead of relying on &> . Cross-platform line split . Use ghostscript instead of epstool (epstool still available but not used by default anymo [extensions/PGFTikZ] - 10https://gerrit.wikimedia.org/r/120750 [04:23:39] <grrrit-wm> (03PS2) 10thibaultmarin: A few improvements (windows compatibility): [extensions/PGFTikZ] - 10https://gerrit.wikimedia.org/r/120750 [04:49:21] <grrrit-wm> (03PS1) 10Spage: Labs instances migrated to eqiad datacenter [extensions/Flow] - 10https://gerrit.wikimedia.org/r/120751 [04:49:37] <grrrit-wm> (03CR) 10jenkins-bot: [V: 04-1] Labs instances migrated to eqiad datacenter [extensions/Flow] - 10https://gerrit.wikimedia.org/r/120751 (owner: 10Spage) [05:24:48] <grrrit-wm> (03PS3) 10Prtksxna: Add white fill in triangle for hovercards with images [extensions/Popups] - 10https://gerrit.wikimedia.org/r/120174 [05:27:01] <grrrit-wm> (03CR) 10Spage: [C: 031] "recheck" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/120751 (owner: 10Spage) [05:35:32] <grrrit-wm> (03PS2) 10Prtksxna: Use escape key to hide popup [extensions/Popups] - 10https://gerrit.wikimedia.org/r/120343 [05:35:34] <grrrit-wm> (03PS2) 10Prtksxna: Show and hide Popups on focus and blur (along with mouseenter/leave) [extensions/Popups] - 10https://gerrit.wikimedia.org/r/120342 [05:35:36] <grrrit-wm> (03PS2) 10Prtksxna: Use aria-hidden for popups [extensions/Popups] - 10https://gerrit.wikimedia.org/r/120345 [05:35:38] <grrrit-wm> (03PS2) 10Prtksxna: Use tooltip role for Popups [extensions/Popups] - 10https://gerrit.wikimedia.org/r/120344 [05:35:40] <grrrit-wm> (03CR) 10jenkins-bot: [V: 04-1] Use escape key to hide popup [extensions/Popups] - 10https://gerrit.wikimedia.org/r/120343 (owner: 10Prtksxna) [05:35:42] <grrrit-wm> (03CR) 10jenkins-bot: [V: 04-1] Show and hide Popups on focus and blur (along with mouseenter/leave) [extensions/Popups] - 10https://gerrit.wikimedia.org/r/120342 (owner: 10Prtksxna) [05:35:44] <grrrit-wm> (03CR) 10jenkins-bot: [V: 04-1] Use aria-hidden for popups [extensions/Popups] - 10https://gerrit.wikimedia.org/r/120345 (owner: 10Prtksxna) [05:35:46] <grrrit-wm> (03CR) 10jenkins-bot: [V: 04-1] Use tooltip role for Popups [extensions/Popups] - 10https://gerrit.wikimedia.org/r/120344 (owner: 10Prtksxna) [05:36:05] <grrrit-wm> (03PS4) 10Prtksxna: Disable NavigationPopups (Gadget) is Popups (Extension) is enabled [extensions/Popups] - 10https://gerrit.wikimedia.org/r/120188 [05:36:10] <grrrit-wm> (03CR) 10jenkins-bot: [V: 04-1] Disable NavigationPopups (Gadget) is Popups (Extension) is enabled [extensions/Popups] - 10https://gerrit.wikimedia.org/r/120188 (owner: 10Prtksxna) [05:36:12] <prtksxna> nooooooooooooooo.com [05:37:11] <marktraceur> Ahahahaha [05:38:24] <grrrit-wm> (03CR) 10Prtksxna: "recheck" [extensions/Popups] - 10https://gerrit.wikimedia.org/r/120188 (owner: 10Prtksxna) [05:38:46] <prtksxna> marktraceur: such drama :P [05:39:13] <prtksxna> I wonder why its all happening though [05:42:42] <marktraceur> prtksxna: What do you mean? [05:43:25] <prtksxna> marktraceur: https://bugzilla.wikimedia.org/show_bug.cgi?id=62997#c3 Those errors are strange [05:43:44] <prtksxna> marktraceur: They are style related and are erroring at places where everything seems fine [05:44:04] <marktraceur> Well. [05:44:07] <marktraceur> That's a shame [05:44:15] <marktraceur> prtksxna: Maybe you should fix the style? [05:44:28] <marktraceur> Oh, yeah, edit .jshintrc [05:44:38] <prtksxna> marktraceur: I am following the style guidelines… [05:44:44] <marktraceur> And/or put directives into the file itself [05:44:50] <prtksxna> marktraceur: Yeah, legoktm pointed out on the -design channel [06:06:41] <grrrit-wm> (03PS7) 10Jatin: Disable Persona button in browsers that do not have Javascript [extensions/Persona] - 10https://gerrit.wikimedia.org/r/120502 [06:14:51] <grrrit-wm> (03PS1) 10Prtksxna: Add .jshintrc file [extensions/Popups] - 10https://gerrit.wikimedia.org/r/120752 [06:14:55] <grrrit-wm> (03CR) 10jenkins-bot: [V: 04-1] Add .jshintrc file [extensions/Popups] - 10https://gerrit.wikimedia.org/r/120752 (owner: 10Prtksxna) [06:16:13] <prtksxna> legoktm: ^ [06:37:32] <grrrit-wm> (03CR) 10Yuvipanda: [C: 032 V: 032] "Fiiineee" [extensions/Popups] - 10https://gerrit.wikimedia.org/r/120752 (owner: 10Prtksxna) [06:37:36] <grrrit-wm> (03CR) 10jenkins-bot: [V: 04-1] Add .jshintrc file [extensions/Popups] - 10https://gerrit.wikimedia.org/r/120752 (owner: 10Prtksxna) [06:37:57] <grrrit-wm> (03CR) 10Yuvipanda: "Ok can't submit. Not sure how to merge this then." [extensions/Popups] - 10https://gerrit.wikimedia.org/r/120752 (owner: 10Prtksxna) [06:38:00] <YuviPanda> prtksxna: ^ [06:38:09] <YuviPanda> prtksxna: fix all jslint failures as part of change adding jshintrc? [06:42:46] <YuviPanda> prtksxna: and looks like nothing can be merged until then [06:46:37] <grrrit-wm> (03CR) 10Siebrand: Fix CodeSniffer errors and warnings in includes/specials (1) (031 comment) [core] - 10https://gerrit.wikimedia.org/r/120328 (owner: 10Siebrand) [06:46:52] <prtksxna> YuviPanda: Right, I am doing that now :) [06:47:03] <YuviPanda> prtksxna: sweet [06:48:41] <grrrit-wm> (03CR) 10Siebrand: [C: 031] "i18n/L10n reviewed." [extensions/Flow] - 10https://gerrit.wikimedia.org/r/117846 (owner: 10Werdna) [06:52:37] <grrrit-wm> (03PS2) 10Spage: Update Makefile for Labs instances migrated to eqiad [extensions/Flow] - 10https://gerrit.wikimedia.org/r/120751 [06:52:49] <grrrit-wm> (03CR) 10jenkins-bot: [V: 04-1] Update Makefile for Labs instances migrated to eqiad [extensions/Flow] - 10https://gerrit.wikimedia.org/r/120751 (owner: 10Spage) [06:56:51] <grrrit-wm> (03CR) 10Siebrand: [C: 032] Set up node-jscs via Grunt (and pass it) [core] - 10https://gerrit.wikimedia.org/r/111963 (owner: 10Krinkle) [07:01:20] <grrrit-wm> (03Merged) 10jenkins-bot: Set up node-jscs via Grunt (and pass it) [core] - 10https://gerrit.wikimedia.org/r/111963 (owner: 10Krinkle) [07:04:28] <grrrit-wm> (03CR) 10Siebrand: [C: 031] "L10n reviewed." [extensions/Flow] - 10https://gerrit.wikimedia.org/r/119640 (owner: 10Bsitu) [07:06:49] <prtksxna> YuviPanda: It has a problem with "logEvent = mw.eventLog ? mw.eventLog.logEvent : function () {}; " >> "'logEvent' is a function." Any ideas how I fix this? [07:07:16] <YuviPanda> prtksxna: shouldn't it be logEvent == mw.eventLog? [07:07:24] <YuviPanda> even === [07:07:59] <prtksxna> YuviPanda: wat no [07:08:07] <prtksxna> YuviPanda: I am assigning it [07:08:22] <YuviPanda> prtksxna: you are using the result of an assignment as conditin for a ternary? [07:08:25] <YuviPanda> BAD prtksxna BAD [07:08:27] <YuviPanda> don't do itttt [07:08:29] <YuviPanda> oh [07:08:30] <YuviPanda> wait [07:08:32] <YuviPanda> aha [07:08:33] <YuviPanda> nevermind [07:08:35] <YuviPanda> I'm an idiot [07:08:56] <YuviPanda> prtksxna: try logEvent = (typeof mw.eventLog === "function") ? <same-thing> [07:09:11] <YuviPanda> prtksxna: err, typeof mw.eventLog !== "undefined" rather [07:09:19] <YuviPanda> prtksxna: you shouldn't depend on the fact that mw.eventLog evaluates to true [07:09:27] <YuviPanda> but expliclty specify what it's checking for [07:09:28] <prtksxna> YuviPanda: But its has a problem with me assigning something to logEvent [07:09:40] <prtksxna> What you are saying it absolutely right but won't solve that error (i think) [07:09:51] <YuviPanda> prtksxna: is logEvent already defined? [07:10:10] <YuviPanda> prtksxna: it might also be getting confused because of this pattern? [07:10:12] <prtksxna> YuviPanda: I have var'd it, then I have a function () and then this [07:10:21] <grrrit-wm> (03CR) 10Nikerabbit: [C: 031] Segmentation: Add test for figure tags [services/cxserver] - 10https://gerrit.wikimedia.org/r/119931 (owner: 10Santhosh) [07:10:22] <prtksxna> YuviPanda: Gimme a minute, let me show you the code [07:10:26] <YuviPanda> prtksxna: ok [07:11:07] <grrrit-wm> (03CR) 10Nikerabbit: Segmentation: Handle all section types (031 comment) [services/cxserver] - 10https://gerrit.wikimedia.org/r/119969 (owner: 10Santhosh) [07:12:23] <prtksxna> YuviPanda: Sorry I am not var-ing it (obviously) http://git.wikimedia.org/blob/mediawiki%2Fextensions%2FPopups.git/720fe09e2c0834737b99feb7143fd0b08787f58a/resources%2Fext.popups.core.js#L337 [07:12:26] <grrrit-wm> (03CR) 10Siebrand: [C: 04-1] "i18n reviewed." (033 comments) [extensions/PGFTikZ] - 10https://gerrit.wikimedia.org/r/120750 (owner: 10thibaultmarin) [07:12:31] <YuviPanda> prtksxna: aah :D [07:12:31] <YuviPanda> ok [07:13:12] <prtksxna> YuviPanda: ideas? [07:13:27] <YuviPanda> prtksxna: you aren't varring it? var it! [07:14:06] <YuviPanda> prtksxna: you already have a function called logEvent [07:14:15] <YuviPanda> line 337 [07:14:20] <YuviPanda> and you are assigning to it again? [07:14:20] <YuviPanda> wat [07:14:21] <YuviPanda> why [07:14:36] <grrrit-wm> (03CR) 10Siebrand: [C: 04-1] "Per PS2 comments." [extensions/BlockAndNuke] - 10https://gerrit.wikimedia.org/r/120476 (owner: 10MarkAHershberger) [07:14:42] <prtksxna> YuviPanda: Cause I am stupid [07:14:48] <prtksxna> YuviPanda: Ignore me please [07:14:50] <YuviPanda> prtksxna: ah. fix that and call them differently [07:15:13] <prtksxna> YuviPanda: This conversation never happened. [07:15:32] <YuviPanda> prtksxna: hehe [07:15:57] <grrrit-wm> (03CR) 10Siebrand: [C: 032] Fix documentation of wfDebugLog() [core] - 10https://gerrit.wikimedia.org/r/120354 (owner: 10IAlex) [07:16:18] <grrrit-wm> (03CR) 10Siebrand: [C: 04-1] Merges and inits db schema, add special pages. [extensions/OpenBadges] - 10https://gerrit.wikimedia.org/r/120361 (owner: 10Chococookies) [07:16:37] <grrrit-wm> (03CR) 10Siebrand: [C: 04-1] Remove edit toolbar from the editing form [core] - 10https://gerrit.wikimedia.org/r/120357 (owner: 10Deepali) [07:19:22] <grrrit-wm> (03PS1) 10Nikerabbit: Add l10n-team [services/cxserver] (refs/meta/config) - 10https://gerrit.wikimedia.org/r/120754 [07:19:56] <grrrit-wm> (03Merged) 10jenkins-bot: Fix documentation of wfDebugLog() [core] - 10https://gerrit.wikimedia.org/r/120354 (owner: 10IAlex) [07:25:16] <grrrit-wm> (03CR) 10Siebrand: [C: 04-1] "i18n/L10n reviewed. Looks okay." (031 comment) [extensions/Persona] - 10https://gerrit.wikimedia.org/r/112309 (owner: 10Donyu) [07:27:39] <grrrit-wm> (03CR) 10Siebrand: [C: 04-1] "i18n/L10n reviewed." (031 comment) [core] - 10https://gerrit.wikimedia.org/r/117854 (owner: 10Ganeshaditya1) [07:27:53] <tonythomas> Hi! I was trying to fix a bug I reported earlier ( https://bugzilla.wikimedia.org/show_bug.cgi?id=59663 ) . I want to know how, the variable $wgDBuser can be accessed from MySqlInstaller.php::submitConnectForm() so that using !strlen will do the trick [07:28:02] <tonythomas> $this->setVarsFromRequest( array ( 'wgDBuser' ) ) returns null [07:30:19] <grrrit-wm> (03PS2) 10Prtksxna: Add .jshintrc file [extensions/Popups] - 10https://gerrit.wikimedia.org/r/120752 [07:30:21] <prtksxna> YuviPanda: ^ [07:31:31] <grrrit-wm> (03CR) 10Siebrand: "> There is no way to apply i18n overrides to a specific family of sites. For instance, if we could have an override that applied to all Wi" [extensions/GettingStarted] - 10https://gerrit.wikimedia.org/r/119972 (owner: 10Phuedx) [07:33:03] <grrrit-wm> (03CR) 10Siebrand: [C: 031] "i18n/L10n reviewed." [core] - 10https://gerrit.wikimedia.org/r/118111 (owner: 10Anomie) [07:34:57] <grrrit-wm> (03CR) 10Prtksxna: "Fixed ALL the errors." [extensions/Popups] - 10https://gerrit.wikimedia.org/r/120752 (owner: 10Prtksxna) [07:47:27] <grrrit-wm> (03CR) 10Yuvipanda: "Change commit summary to reflect?" [extensions/Popups] - 10https://gerrit.wikimedia.org/r/120752 (owner: 10Prtksxna) [07:47:51] <grrrit-wm> (03CR) 10Siebrand: [C: 04-1] Always render copyright notice in user language (031 comment) [core] - 10https://gerrit.wikimedia.org/r/120696 (owner: 10Kaldari) [07:53:58] <grrrit-wm> (03CR) 10Siebrand: Implement listing for tracking categories (032 comments) [core] - 10https://gerrit.wikimedia.org/r/112323 (owner: 10Kunalgrover05) [07:56:37] <YuviPanda> prtksxna: change commit summary, I will merge? :) [08:19:45] <grrrit-wm> (03PS1) 10Tpt: Use /usr/bin/ as default folder for DjVu tools in unit tests [core] - 10https://gerrit.wikimedia.org/r/120756 [08:20:39] <grrrit-wm> (03CR) 10IAlex: Have ?download parameter trigger Content-Disposition: attachment (031 comment) [core] - 10https://gerrit.wikimedia.org/r/120703 (owner: 10Gilles) [08:24:48] <grrrit-wm> (03PS11) 10Tpt: Addition of a parser test for page= parameter of image inclusion [core] - 10https://gerrit.wikimedia.org/r/102475 [08:25:40] <grrrit-wm> (03PS2) 10Gerrit Patch Uploader: Remove unused style for #loginend and #signupend [core] - 10https://gerrit.wikimedia.org/r/120549 [08:25:42] <grrrit-wm> (03CR) 10Gerrit Patch Uploader: "This commit was uploaded using the Gerrit Patch Uploader [1]." [core] - 10https://gerrit.wikimedia.org/r/120549 (owner: 10Gerrit Patch Uploader) [08:27:33] <rotpunkt> Hi, I have a question about Scribunto/Lua: when I read frame:getParent().args["MyParam"] and MyParam contains a <ref> tag, the text between ref tags is not returned... how can I read it? [08:31:22] <grrrit-wm> (03CR) 10jenkins-bot: [V: 04-1] Addition of a parser test for page= parameter of image inclusion [core] - 10https://gerrit.wikimedia.org/r/102475 (owner: 10Tpt) [08:34:28] <rotpunkt> ok, I did not remember of mw.text.unstrip [08:44:30] <grrrit-wm> (03CR) 10Tobias Gritschacher: "As already discussed with hashar, the easiest way to get the recent version of composer is" [integration/jenkins] - 10https://gerrit.wikimedia.org/r/120517 (owner: 10Tobias Gritschacher) [09:03:46] <grrrit-wm> (03PS1) 10Ori.livneh: Allow EventLogging events to be logged via mw#track [extensions/EventLogging] - 10https://gerrit.wikimedia.org/r/120757 [09:04:12] <grrrit-wm> (03PS2) 10Ori.livneh: Allow EventLogging events to be logged via mw#track [extensions/EventLogging] - 10https://gerrit.wikimedia.org/r/120757 [09:12:46] <paravoid> interesting [09:12:54] <paravoid> the elevated 503s are all from a single ISP [09:13:06] <paravoid> Kyivstar GSM, Kiev, Ukraine [09:19:12] <grrrit-wm> (03PS2) 10Santhosh: Segmentation: Handle all section types [services/cxserver] - 10https://gerrit.wikimedia.org/r/119969 [09:19:14] <grrrit-wm> (03CR) 10jenkins-bot: [V: 04-1] Segmentation: Handle all section types [services/cxserver] - 10https://gerrit.wikimedia.org/r/119969 (owner: 10Santhosh) [09:23:06] <paravoid> spambot [09:23:48] <paravoid> hm, wrong channel I suppose :) [09:27:41] <grrrit-wm> (03CR) 10Nemo bis: "Hi, thanks for the patch. So you propose to create an account with a language preference different from the language one is seeing?" (032 comments) [core] - 10https://gerrit.wikimedia.org/r/120475 (owner: 10Stepzhou) [09:28:17] <grrrit-wm> (03PS2) 10Nemo bis: Tries to use wikilanguage cookie, HTTP request Accept Header, and then the get preferred variant in that order [core] - 10https://gerrit.wikimedia.org/r/120475 (owner: 10Stepzhou) [09:28:24] <grrrit-wm> (03PS3) 10Nemo bis: Tries to use wikilanguage cookie, HTTP request Accept Header, and then the get preferred variant in that order [core] - 10https://gerrit.wikimedia.org/r/120475 (owner: 10Stepzhou) [09:29:14] <grrrit-wm> (03PS3) 10Prtksxna: Add .jshintrc file and update core.js to remove errors [extensions/Popups] - 10https://gerrit.wikimedia.org/r/120752 [09:29:59] <grrrit-wm> (03CR) 10Prtksxna: "No!" [extensions/Popups] - 10https://gerrit.wikimedia.org/r/120752 (owner: 10Prtksxna) [10:05:00] <grrrit-wm> (03PS3) 10Gilles: Have ?download parameter trigger Content-Disposition: attachment [core] - 10https://gerrit.wikimedia.org/r/120703 [10:05:30] <grrrit-wm> (03CR) 10Gilles: Have ?download parameter trigger Content-Disposition: attachment (031 comment) [core] - 10https://gerrit.wikimedia.org/r/120703 (owner: 10Gilles) [10:21:41] <grrrit-wm> (03CR) 10Bartosz Dziewoński: [C: 032] Adding function documentation for Skin::footerLink() [core] - 10https://gerrit.wikimedia.org/r/120588 (owner: 10Kaldari) [10:25:31] <grrrit-wm> (03Merged) 10jenkins-bot: Adding function documentation for Skin::footerLink() [core] - 10https://gerrit.wikimedia.org/r/120588 (owner: 10Kaldari) [10:29:53] <grrrit-wm> (03CR) 10Bartosz Dziewoński: "Does not merge." [core] - 10https://gerrit.wikimedia.org/r/117150 (owner: 10Krinkle) [10:32:16] <grrrit-wm> (03PS1) 10Hashar: Release 1.0.0-alpha8 [integration/composer] - 10https://gerrit.wikimedia.org/r/120761 [10:32:19] <grrrit-wm> (03PS1) 10Hashar: Merge upstream tag '1.0.0-alpha8' [integration/composer] - 10https://gerrit.wikimedia.org/r/120762 [10:35:29] <grrrit-wm> (03Abandoned) 10Hashar: Release 1.0.0-alpha8 [integration/composer] - 10https://gerrit.wikimedia.org/r/120761 (owner: 10Hashar) [10:35:41] <grrrit-wm> (03Abandoned) 10Hashar: Merge upstream tag '1.0.0-alpha8' [integration/composer] - 10https://gerrit.wikimedia.org/r/120762 (owner: 10Hashar) [10:40:26] <grrrit-wm> (03PS1) 10Hashar: Merge upstream tag '1.0.0-alpha8' [integration/composer] - 10https://gerrit.wikimedia.org/r/120763 [10:48:21] <grrrit-wm> (03PS1) 10Faidon Liambotis: Set ThrottledError's response code to 403 [core] - 10https://gerrit.wikimedia.org/r/120765 [10:59:53] <grrrit-wm> (03PS1) 10Robert Vogel: includes/Linker.php: Added hook for "Media:" links [core] - 10https://gerrit.wikimedia.org/r/120767 [11:03:48] <grrrit-wm> (03CR) 10KartikMistry: Segmentation: Handle all section types (031 comment) [services/cxserver] - 10https://gerrit.wikimedia.org/r/119969 (owner: 10Santhosh) [11:04:53] <grrrit-wm> (03PS5) 1001tonythomas: Error Msg for missing db username & password when installing [core] - 10https://gerrit.wikimedia.org/r/118798 (owner: 10Pubudu538) [11:13:01] <grrrit-wm> (03PS6) 1001tonythomas: Error Msg for missing db username & password when installing [core] - 10https://gerrit.wikimedia.org/r/118798 (owner: 10Pubudu538) [11:33:02] <grrrit-wm> (03PS3) 10Santhosh: Segmentation: Handle all section types [services/cxserver] - 10https://gerrit.wikimedia.org/r/119969 [11:33:04] <grrrit-wm> (03PS1) 10Santhosh: Correct the entity escaping and restore parsoid data attribute [services/cxserver] - 10https://gerrit.wikimedia.org/r/120773 [11:33:06] <grrrit-wm> (03CR) 10jenkins-bot: [V: 04-1] Correct the entity escaping and restore parsoid data attribute [services/cxserver] - 10https://gerrit.wikimedia.org/r/120773 (owner: 10Santhosh) [11:35:01] <grrrit-wm> (03PS2) 10Santhosh: Correct the entity escaping and restore parsoid data attribute [services/cxserver] - 10https://gerrit.wikimedia.org/r/120773 [11:36:38] <grrrit-wm> (03CR) 10Yuvipanda: [C: 032] "Merging from phone \o/" [extensions/Popups] - 10https://gerrit.wikimedia.org/r/120752 (owner: 10Prtksxna) [11:36:44] <grrrit-wm> (03Merged) 10jenkins-bot: Add .jshintrc file and update core.js to remove errors [extensions/Popups] - 10https://gerrit.wikimedia.org/r/120752 (owner: 10Prtksxna) [11:42:37] <grrrit-wm> (03CR) 10KartikMistry: [C: 031] Segmentation: Handle all section types [services/cxserver] - 10https://gerrit.wikimedia.org/r/119969 (owner: 10Santhosh) [11:54:34] <grrrit-wm> (03PS1) 10Phuedx: Don't use the deprecated mw-ui-primary CSS class [extensions/GettingStarted] - 10https://gerrit.wikimedia.org/r/120776 [12:01:05] <grrrit-wm> (03PS3) 10Yuvipanda: Show and hide Popups on focus and blur (along with mouseenter/leave) [extensions/Popups] - 10https://gerrit.wikimedia.org/r/120342 (owner: 10Prtksxna) [12:22:25] <grrrit-wm> (03CR) 10Bartosz Dziewoński: [C: 032] Remove unused style for #loginend and #signupend [core] - 10https://gerrit.wikimedia.org/r/120549 (owner: 10Gerrit Patch Uploader) [12:26:18] <grrrit-wm> (03Merged) 10jenkins-bot: Remove unused style for #loginend and #signupend [core] - 10https://gerrit.wikimedia.org/r/120549 (owner: 10Gerrit Patch Uploader) [12:33:22] <grrrit-wm> (03PS2) 10Phuedx: Update copy [extensions/GettingStarted] - 10https://gerrit.wikimedia.org/r/119972 [12:35:02] <grrrit-wm> (03CR) 10Phuedx: "I've split out the mw-ui-progressive-related change into Id33ce8ad366c0d0adb4157a93c1532132700f4bb. PS2 is now only the copy update." [extensions/GettingStarted] - 10https://gerrit.wikimedia.org/r/119972 (owner: 10Phuedx) [12:45:15] <grrrit-wm> (03CR) 10Siebrand: [C: 04-1] Update copy [extensions/GettingStarted] - 10https://gerrit.wikimedia.org/r/119972 (owner: 10Phuedx) [13:08:26] <grrrit-wm> (03CR) 10Bartosz Dziewoński: Use rgba() for gallery caption background instead of opacity. (031 comment) [core] - 10https://gerrit.wikimedia.org/r/116227 (owner: 10Brian Wolff) [13:09:31] <grrrit-wm> (03CR) 10Bartosz Dziewoński: [C: 032] Remove $wgHttpOnlyBlacklist [core] - 10https://gerrit.wikimedia.org/r/119919 (owner: 10PleaseStand) [13:11:21] <grrrit-wm> (03PS1) 10Siebrand: Migrate to JSON i18n with B/C [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/120782 [13:13:24] <grrrit-wm> (03PS1) 10Siebrand: Migrate to JSON i18n [extensions/AccountAudit] - 10https://gerrit.wikimedia.org/r/120783 [13:13:36] <grrrit-wm> (03Merged) 10jenkins-bot: Remove $wgHttpOnlyBlacklist [core] - 10https://gerrit.wikimedia.org/r/119919 (owner: 10PleaseStand) [13:14:27] <grrrit-wm> (03PS2) 10Siebrand: Migrate to JSON i18n [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/120782 [13:14:47] <grrrit-wm> (03PS2) 10Siebrand: Migrate to JSON i18n [extensions/AccountAudit] - 10https://gerrit.wikimedia.org/r/120783 [13:14:53] <grrrit-wm> (03PS3) 10Siebrand: Migrate to JSON i18n [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/120782 [13:16:59] <grrrit-wm> (03PS1) 10Siebrand: Migrate to JSON i18n [extensions/AntiBot] - 10https://gerrit.wikimedia.org/r/120784 [13:18:29] <grrrit-wm> (03PS1) 10Siebrand: Migrate to JSON i18n [extensions/AntiSpoof] - 10https://gerrit.wikimedia.org/r/120785 [13:20:21] <grrrit-wm> (03PS1) 10Siebrand: Migrate to JSON i18n [extensions/ApiSandbox] - 10https://gerrit.wikimedia.org/r/120786 [13:24:05] <grrrit-wm> (03PS1) 10Siebrand: Migrate to JSON i18n [extensions/BetaFeatures] - 10https://gerrit.wikimedia.org/r/120788 [13:24:11] <grrrit-wm> (03CR) 10jenkins-bot: [V: 04-1] Migrate to JSON i18n [extensions/BetaFeatures] - 10https://gerrit.wikimedia.org/r/120788 (owner: 10Siebrand) [13:27:52] <grrrit-wm> (03PS1) 10Siebrand: Migrate to JSON i18n [extensions/Calendar] - 10https://gerrit.wikimedia.org/r/120789 [13:29:08] <grrrit-wm> (03PS1) 10Siebrand: Migrate to JSON i18n [extensions/Campaigns] - 10https://gerrit.wikimedia.org/r/120790 [13:30:57] <grrrit-wm> (03PS1) 10Siebrand: Migrate to JSON i18n [extensions/CategoryTree] - 10https://gerrit.wikimedia.org/r/120791 [13:31:00] <grrrit-wm> (03CR) 10jenkins-bot: [V: 04-1] Migrate to JSON i18n [extensions/CategoryTree] - 10https://gerrit.wikimedia.org/r/120791 (owner: 10Siebrand) [13:36:55] <grrrit-wm> (03CR) 10Bartosz Dziewoński: [C: 031] "Looks reasonable, didn't test." (031 comment) [core] - 10https://gerrit.wikimedia.org/r/117444 (owner: 10Krinkle) [13:39:26] <grrrit-wm> (03CR) 10Anomie: SpecialCentralAutoLogin: Move javascript to separate files for linting (031 comment) [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/118430 (owner: 10Krinkle) [13:40:22] <grrrit-wm> (03CR) 10Fomafix: "The width:100% was added in" [core] - 10https://gerrit.wikimedia.org/r/120528 (owner: 10Gerrit Patch Uploader) [13:40:34] <grrrit-wm> (03CR) 10Anomie: [C: 031] "Looks good, haven't tested." [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/118430 (owner: 10Krinkle) [13:51:45] <grrrit-wm> (03PS4) 10Gerrit Patch Uploader: Rework mediawiki.feedback.js [core] - 10https://gerrit.wikimedia.org/r/105457 [13:51:47] <grrrit-wm> (03CR) 10Gerrit Patch Uploader: "This commit was uploaded using the Gerrit Patch Uploader [1]." [core] - 10https://gerrit.wikimedia.org/r/105457 (owner: 10Gerrit Patch Uploader) [13:52:09] <grrrit-wm> (03PS2) 10Siebrand: Migrate to JSON i18n [extensions/BetaFeatures] - 10https://gerrit.wikimedia.org/r/120788 [13:55:56] <grrrit-wm> (03PS2) 10Siebrand: Migrate to JSON i18n [extensions/CategoryTree] - 10https://gerrit.wikimedia.org/r/120791 [13:57:47] <grrrit-wm> (03PS1) 10Bartosz Dziewoński: mediawiki.js: Fix docucumentation breakage [core] (REL1_22) - 10https://gerrit.wikimedia.org/r/120794 [13:58:29] <grrrit-wm> (03CR) 10Bartosz Dziewoński: "I'm cherry-picking this to REL1_22 to hopefully fix the JSDuck job failing on that branch." [core] - 10https://gerrit.wikimedia.org/r/92465 (owner: 10Krinkle) [13:59:03] <grrrit-wm> (03PS2) 10Bartosz Dziewoński: mediawiki.js: Fix documentation breakage [core] (REL1_22) - 10https://gerrit.wikimedia.org/r/120794 [14:00:11] <grrrit-wm> (03CR) 10Bartosz Dziewoński: [C: 032] "Backporting this to fix the JSDuck job currently failing on REL1_22." [core] (REL1_22) - 10https://gerrit.wikimedia.org/r/120794 (owner: 10Bartosz Dziewoński) [14:00:23] <grrrit-wm> (03CR) 10Bartosz Dziewoński: "(This has no code changes, only comments.)" [core] (REL1_22) - 10https://gerrit.wikimedia.org/r/120794 (owner: 10Bartosz Dziewoński) [14:03:42] <grrrit-wm> (03Merged) 10jenkins-bot: mediawiki.js: Fix documentation breakage [core] (REL1_22) - 10https://gerrit.wikimedia.org/r/120794 (owner: 10Bartosz Dziewoński) [14:09:12] <grrrit-wm> (03PS1) 10Siebrand: Add jobs for AccountAudit extension [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/120796 [14:11:43] <grrrit-wm> (03PS1) 10Siebrand: Add jobs for AccountAudit extension [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/120797 [14:13:46] <grrrit-wm> (03PS3) 10Bartosz Dziewoński: Add link to PD help translatable pages from sidebar [core] (REL1_22) - 10https://gerrit.wikimedia.org/r/119947 (owner: 10Nemo bis) [14:13:56] <grrrit-wm> (03CR) 10Bartosz Dziewoński: "JSDuck fixed in https://gerrit.wikimedia.org/r/#/c/120794/" [core] (REL1_22) - 10https://gerrit.wikimedia.org/r/119947 (owner: 10Nemo bis) [14:34:37] <grrrit-wm> (03CR) 10Nemo bis: "Thanks MatmaRex! Mglaser confirmed 1.22.5 is still planned for the 27th, two days left to merge this. :)" [core] (REL1_22) - 10https://gerrit.wikimedia.org/r/119947 (owner: 10Nemo bis) [14:54:46] <grrrit-wm> (03CR) 10Hashar: [C: 032] "thanks" [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/120796 (owner: 10Siebrand) [14:55:23] <grrrit-wm> (03CR) 10Bartosz Dziewoński: [C: 032] "Ah, might as well." [core] (REL1_22) - 10https://gerrit.wikimedia.org/r/119947 (owner: 10Nemo bis) [14:55:57] <grrrit-wm> (03CR) 10Hashar: [C: 032] Add jobs for AccountAudit extension [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/120797 (owner: 10Siebrand) [14:56:17] <grrrit-wm> (03Merged) 10jenkins-bot: Add jobs for AccountAudit extension [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/120796 (owner: 10Siebrand) [14:56:27] <grrrit-wm> (03Merged) 10jenkins-bot: Add jobs for AccountAudit extension [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/120797 (owner: 10Siebrand) [14:56:54] <grrrit-wm> (03CR) 10Hashar: "deployed" [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/120797 (owner: 10Siebrand) [14:59:00] <grrrit-wm> (03Merged) 10jenkins-bot: Add link to PD help translatable pages from sidebar [core] (REL1_22) - 10https://gerrit.wikimedia.org/r/119947 (owner: 10Nemo bis) [15:10:11] <grrrit-wm> (03CR) 10Chad: [V: 032] Add l10n-team [services/cxserver] (refs/meta/config) - 10https://gerrit.wikimedia.org/r/120754 (owner: 10Nikerabbit) [15:10:17] <grrrit-wm> (03CR) 10Chad: [C: 032] Add l10n-team [services/cxserver] (refs/meta/config) - 10https://gerrit.wikimedia.org/r/120754 (owner: 10Nikerabbit) [15:10:47] <grrrit-wm> (03CR) 10Chad: Fix CodeSniffer errors and warnings in includes/specials (1) (031 comment) [core] - 10https://gerrit.wikimedia.org/r/120328 (owner: 10Siebrand) [15:11:22] <grrrit-wm> (03CR) 10Siebrand: Fix CodeSniffer errors and warnings in includes/specials (1) (031 comment) [core] - 10https://gerrit.wikimedia.org/r/120328 (owner: 10Siebrand) [15:11:28] <grrrit-wm> (03PS10) 10Tobias Gritschacher: Implement ApiQuerySites class [core] - 10https://gerrit.wikimedia.org/r/110427 (owner: 10Addshore) [15:11:43] <grrrit-wm> (03CR) 10Tobias Gritschacher: [C: 04-1] "see Thiemo's comments" [core] - 10https://gerrit.wikimedia.org/r/110427 (owner: 10Addshore) [15:12:15] <siebrand> ^demon|away: Can you please fight with hashar/antoine about that check? It's been there for a long time, and such exclusion are in core already. Also, the check found invalid overrides that have since been removed. [15:13:08] * ^demon|away sighs [15:27:54] <grrrit-wm> (03PS2) 10Siebrand: Fix CodeSniffer errors and warnings in includes/specials (1) [core] - 10https://gerrit.wikimedia.org/r/120328 [15:29:38] <grrrit-wm> (03CR) 10MaxSem: [C: 032] Migrate to JSON i18n [extensions/ApiSandbox] - 10https://gerrit.wikimedia.org/r/120786 (owner: 10Siebrand) [15:29:42] <grrrit-wm> (03Merged) 10jenkins-bot: Migrate to JSON i18n [extensions/ApiSandbox] - 10https://gerrit.wikimedia.org/r/120786 (owner: 10Siebrand) [15:29:49] <grrrit-wm> (03CR) 10Jforrester: [C: 032] Migrate to JSON i18n [extensions/AccountAudit] - 10https://gerrit.wikimedia.org/r/120783 (owner: 10Siebrand) [15:29:51] <grrrit-wm> (03Merged) 10jenkins-bot: Migrate to JSON i18n [extensions/AccountAudit] - 10https://gerrit.wikimedia.org/r/120783 (owner: 10Siebrand) [15:31:58] <grrrit-wm> (03PS3) 10Siebrand: Fix CodeSniffer errors and warnings in includes/specials (1) [core] - 10https://gerrit.wikimedia.org/r/120328 [15:32:34] <grrrit-wm> (03CR) 10Siebrand: "I've removed the contentious changes. CodeSniffer warnings and/or errors remain, but who cares." [core] - 10https://gerrit.wikimedia.org/r/120328 (owner: 10Siebrand) [15:32:59] <grrrit-wm> (03CR) 10MaxSem: [C: 031] Add ?download parameter to images [vagrant] - 10https://gerrit.wikimedia.org/r/120614 (owner: 10Gilles) [15:33:50] <grrrit-wm> (03PS13) 10Ganeshaditya1: Display a warning when the user name looked up is not registered. [core] - 10https://gerrit.wikimedia.org/r/117854 [15:35:36] <DanielK_WMDE> siebrand: see me replies on PS1: https://gerrit.wikimedia.org/r/#/c/120775/2 [15:41:41] <grrrit-wm> (03CR) 10Ganeshaditya1: "I am sorry, I forgot to do a git add on the special contributions page" [core] - 10https://gerrit.wikimedia.org/r/117854 (owner: 10Ganeshaditya1) [15:43:53] <grrrit-wm> (03CR) 10Thiemo Mättig (WMDE): [C: 031] "I added some answers to make my intention clear. Basically the definition of being nitpicking. ;-) Sorry." [core] - 10https://gerrit.wikimedia.org/r/110427 (owner: 10Addshore) [15:44:09] <grrrit-wm> (03CR) 10MaxSem: "I think you're describing this role wrongly: it's for testing of some settings useful only for prod use on crappy hosts, not for actual sp" (031 comment) [vagrant] - 10https://gerrit.wikimedia.org/r/119216 (owner: 10Nemo bis) [15:47:24] <grrrit-wm> (03CR) 10Catrope: [C: 032] Fixed typo in update.php [extensions/LocalisationUpdate] (json-rewrite) - 10https://gerrit.wikimedia.org/r/120559 (owner: 10KartikMistry) [15:47:27] <grrrit-wm> (03Merged) 10jenkins-bot: Fixed typo in update.php [extensions/LocalisationUpdate] (json-rewrite) - 10https://gerrit.wikimedia.org/r/120559 (owner: 10KartikMistry) [15:48:12] <grrrit-wm> (03CR) 10Nemo bis: "MaxSem, yes, this is for wikis in the web. If you want to suggest a prefix for such roles or something, feel free to." [vagrant] - 10https://gerrit.wikimedia.org/r/119216 (owner: 10Nemo bis) [15:49:10] <grrrit-wm> (03CR) 10MaxSem: [C: 04-2] "In such case, I'm opposed to having this role in this Vagrant which is intended for development only." [vagrant] - 10https://gerrit.wikimedia.org/r/119216 (owner: 10Nemo bis) [15:49:17] <MaxSem> Nemo_bis, ^^ [15:49:20] <grrrit-wm> (03PS1) 10Phuedx: [WIP] Add the mw.cookie module [core] - 10https://gerrit.wikimedia.org/r/120806 [15:49:51] <grrrit-wm> (03CR) 10MarkAHershberger: [C: 032] Make MySQLi work with non-standard port [core] (REL1_22) - 10https://gerrit.wikimedia.org/r/119735 (owner: 10Mglaser) [15:50:32] <grrrit-wm> (03CR) 10Nemo bis: "MaxSem, do you have documentation for this claim? Vagrant roles are, for instance, used in labs as one wishes." [vagrant] - 10https://gerrit.wikimedia.org/r/119216 (owner: 10Nemo bis) [15:51:10] <grrrit-wm> (03CR) 10jenkins-bot: [V: 04-1] [WIP] Add the mw.cookie module [core] - 10https://gerrit.wikimedia.org/r/120806 (owner: 10Phuedx) [15:53:33] <grrrit-wm> (03PS2) 10Catrope: Merge remote-tracking branch 'origin/json-rewrite' [extensions/LocalisationUpdate] - 10https://gerrit.wikimedia.org/r/119944 (owner: 10Nikerabbit) [15:54:32] <grrrit-wm> (03Merged) 10jenkins-bot: Make MySQLi work with non-standard port [core] (REL1_22) - 10https://gerrit.wikimedia.org/r/119735 (owner: 10Mglaser) [15:57:26] <grrrit-wm> (03CR) 10Jforrester: [C: 032] Migrate to JSON i18n [extensions/BetaFeatures] - 10https://gerrit.wikimedia.org/r/120788 (owner: 10Siebrand) [15:57:39] <grrrit-wm> (03Merged) 10jenkins-bot: Migrate to JSON i18n [extensions/BetaFeatures] - 10https://gerrit.wikimedia.org/r/120788 (owner: 10Siebrand) [15:58:55] <qgil> guillom, can you please start the hangout on air? Google will not allow me now... :( [15:59:04] <guillom> qgil: okay [15:59:13] <qgil> andre___, robla, see above [15:59:29] <qgil> guillom, thank you [16:00:00] <guillom> Don't thank me yet, I have no idea how to do this :) [16:00:10] <qgil> guillom, please invite quimgil@gmail.com [16:00:12] <qgil> ok, wait [16:00:32] <qgil> guillom, https://plus.google.com/hangouts [16:00:43] <qgil> guillom, start Hangout on air [16:00:45] <guillom> ok [16:00:48] <guillom> thanks [16:00:54] <qgil> guillom, start it, then invite us [16:02:40] <grrrit-wm> (03PS1) 10Tinaj1234: Added hook for adding AbuseFilter log link [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/120809 [16:03:11] <guillom> qgil: sorry, it's taking some time to create the youtube channel, verify it, connect to google+ etc. In progress [16:03:39] <qgil> guillom, I see, sorry. [16:04:14] <guillom> getting there [16:04:45] <grrrit-wm> (03CR) 10MaxSem: "Yes I have, from https://www.mediawiki.org/wiki/Vagrant : "MediaWiki-Vagrant is a portable MediaWiki development environment". I know abou" [vagrant] - 10https://gerrit.wikimedia.org/r/119216 (owner: 10Nemo bis) [16:04:59] <guillom> qgil: andre___, robla: invite sent (I think) [16:05:43] <andre___> guillom, hmm, my Inbox does not show one yet [16:06:04] <robla> nor mine... [16:06:17] <qgil_meeting> guillom, I think you invited us as watchers [16:06:22] <guillom> damn [16:06:23] <guillom> sorry [16:06:26] <andre___> yeah, I can watch in G+ [16:06:27] <guillom> I'm new to this [16:06:58] <qgil_meeting> guillom, no worries, from the hangout, you can add new people clicking an icon (I believe next to mute, etc) [16:07:12] <grrrit-wm> (03CR) 10Nemo bis: "File caching has been useful for me in labs, that said your quotation doesn't say that it's *exclusively* that and I don't see why it shou" [vagrant] - 10https://gerrit.wikimedia.org/r/119216 (owner: 10Nemo bis) [16:07:25] <grrrit-wm> (03PS1) 10Tinaj1234: Added a AbuseFilter log link using a hook to Revision history page [core] - 10https://gerrit.wikimedia.org/r/120811 [16:07:36] <guillom> qgil_meeting: ok, done [16:07:38] <qgil_meeting> andre___, robla you might get the invite as a Google+ notification, not email... [16:11:00] <guillom> If people are interested in watching the monthly Engineering Community Team showcase, here's the live stream: http://youtu.be/FxR2RWUtaII [16:11:12] <grrrit-wm> (03PS2) 10Tinaj1234: Added hook for adding AbuseFilter log link [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/120809 [16:19:43] <grrrit-wm> (03CR) 10Adamw: [C: 04-2] "I don't know how far this has spread already, but I'm prepared to do battle :p" (031 comment) [extensions/Campaigns] - 10https://gerrit.wikimedia.org/r/120790 (owner: 10Siebrand) [16:20:51] <grrrit-wm> (03CR) 10Catrope: [C: 032] Merge remote-tracking branch 'origin/json-rewrite' [extensions/LocalisationUpdate] - 10https://gerrit.wikimedia.org/r/119944 (owner: 10Nikerabbit) [16:20:54] <grrrit-wm> (03Merged) 10jenkins-bot: Merge remote-tracking branch 'origin/json-rewrite' [extensions/LocalisationUpdate] - 10https://gerrit.wikimedia.org/r/119944 (owner: 10Nikerabbit) [16:21:32] <grrrit-wm> (03PS1) 10Catrope: Update LocalisationUpdate for rewrite [core] (wmf/1.23wmf19) - 10https://gerrit.wikimedia.org/r/120812 [16:22:39] <grrrit-wm> (03PS1) 10Catrope: Update LocalisationUpdate for rewrite [core] (wmf/1.23wmf18) - 10https://gerrit.wikimedia.org/r/120813 [16:23:50] <grrrit-wm> (03CR) 10Catrope: [C: 032 V: 032] Update LocalisationUpdate for rewrite [core] (wmf/1.23wmf19) - 10https://gerrit.wikimedia.org/r/120812 (owner: 10Catrope) [16:26:05] <grrrit-wm> (03CR) 10BryanDavis: [C: 032] Add ?download parameter to images [vagrant] - 10https://gerrit.wikimedia.org/r/120614 (owner: 10Gilles) [16:26:32] <grrrit-wm> (03Merged) 10jenkins-bot: Add ?download parameter to images [vagrant] - 10https://gerrit.wikimedia.org/r/120614 (owner: 10Gilles) [16:33:40] <grrrit-wm> (03CR) 10Adamw: "/me stifles cries of pain" [extensions/Campaigns] - 10https://gerrit.wikimedia.org/r/120790 (owner: 10Siebrand) [16:34:10] <grrrit-wm> (03CR) 10Adamw: Migrate to JSON i18n (031 comment) [extensions/Campaigns] - 10https://gerrit.wikimedia.org/r/120790 (owner: 10Siebrand) [16:34:13] <grrrit-wm> (03CR) 10KartikMistry: "https://www.mediawiki.org/w/index.php?title=Extension:LocalisationUpdate has been updated and 'Pending for review'." [extensions/LocalisationUpdate] - 10https://gerrit.wikimedia.org/r/119944 (owner: 10Nikerabbit) [16:35:37] <grrrit-wm> (03PS3) 1001tonythomas: Added hook for adding AbuseFilter log link [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/120809 (owner: 10Tinaj1234) [16:35:49] <grrrit-wm> (03CR) 10BryanDavis: "Physikerwelt: What's the status of this patch? Is it still desirable or has your work moved on in such a way that it is no longer worth wo" [vagrant] - 10https://gerrit.wikimedia.org/r/86420 (owner: 10Physikerwelt) [16:36:44] <grrrit-wm> (03CR) 10Daniel Kinzler: [C: 04-1] "should be in core." (031 comment) [core] - 10https://gerrit.wikimedia.org/r/110427 (owner: 10Addshore) [16:42:07] <grrrit-wm> (03PS1) 10MaxSem: Move a couple of classes into their own files [extensions/GeoData] - 10https://gerrit.wikimedia.org/r/120817 [16:42:48] <grrrit-wm> (03CR) 10MaxSem: [C: 032] Move a couple of classes into their own files [extensions/GeoData] - 10https://gerrit.wikimedia.org/r/120817 (owner: 10MaxSem) [16:42:54] <grrrit-wm> (03Merged) 10jenkins-bot: Move a couple of classes into their own files [extensions/GeoData] - 10https://gerrit.wikimedia.org/r/120817 (owner: 10MaxSem) [16:44:46] <grrrit-wm> (03CR) 10Physikerwelt: "Hi Bryan," [vagrant] - 10https://gerrit.wikimedia.org/r/86420 (owner: 10Physikerwelt) [16:47:21] <grrrit-wm> (03PS18) 10Matthias Mullie: API: Revamp action=flow [extensions/Flow] - 10https://gerrit.wikimedia.org/r/107411 (owner: 10Legoktm) [16:47:25] <grrrit-wm> (03CR) 10GWicke: "@Bryan: We generally only pass references to data to the log method, with the message being constructed on demand when necessary. If even " [core] - 10https://gerrit.wikimedia.org/r/112699 (owner: 10BryanDavis) [16:50:06] <grrrit-wm> (03CR) 10Daniel Kinzler: [C: 04-1] Tries to use wikilanguage cookie, HTTP request Accept Header, and then the get preferred variant in that order (033 comments) [core] - 10https://gerrit.wikimedia.org/r/120475 (owner: 10Stepzhou) [16:53:40] <grrrit-wm> (03PS1) 10Cscott: Sync up with Parsoid parserTests. [core] - 10https://gerrit.wikimedia.org/r/120818 [16:55:24] <grrrit-wm> (03PS1) 10KartikMistry: Added .gitignore and .gitreview files [services/cxserver] - 10https://gerrit.wikimedia.org/r/120819 [16:55:52] <grrrit-wm> (03PS19) 10Matthias Mullie: API: Revamp action=flow [extensions/Flow] - 10https://gerrit.wikimedia.org/r/107411 (owner: 10Legoktm) [16:56:22] <grrrit-wm> (03CR) 10Matthias Mullie: API: Revamp action=flow (037 comments) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/107411 (owner: 10Legoktm) [16:57:33] <grrrit-wm> (03CR) 10Matthias Mullie: "PS16: rebase" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/107411 (owner: 10Legoktm) [16:57:51] <grrrit-wm> (03PS1) 10Hashar: beta-parsoid-update-eqiad [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/120820 [17:04:47] <grrrit-wm> (03PS1) 10Hashar: Update Parsoid on EQIAD beta cluster [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/120822 [17:06:17] <grrrit-wm> (03CR) 10Hashar: [C: 032] Update Parsoid on EQIAD beta cluster [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/120822 (owner: 10Hashar) [17:06:21] <grrrit-wm> (03Merged) 10jenkins-bot: Update Parsoid on EQIAD beta cluster [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/120822 (owner: 10Hashar) [17:07:19] <grrrit-wm> (03CR) 10Hcohl: [C: 031] Add local LaTeXML webservice for the Math role [vagrant] - 10https://gerrit.wikimedia.org/r/86420 (owner: 10Physikerwelt) [17:09:13] <grrrit-wm> (03PS2) 10Hashar: beta-parsoid-update-eqiad [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/120820 [17:09:16] <grrrit-wm> (03CR) 10Hashar: [C: 032] beta-parsoid-update-eqiad [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/120820 (owner: 10Hashar) [17:10:27] <grrrit-wm> (03Merged) 10jenkins-bot: beta-parsoid-update-eqiad [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/120820 (owner: 10Hashar) [17:12:37] <grrrit-wm> (03CR) 10Maryana: [C: 031] "New link color works much better. Seems ready to go." [extensions/Flow] - 10https://gerrit.wikimedia.org/r/117846 (owner: 10Werdna) [17:14:35] <grrrit-wm> (03PS3) 10Ori.livneh: Lowered high lock timeout in mergeViaLock() and lock() in BagOStuff [core] - 10https://gerrit.wikimedia.org/r/119314 (owner: 10Aaron Schulz) [17:14:40] <grrrit-wm> (03CR) 10Ori.livneh: [C: 032] Lowered high lock timeout in mergeViaLock() and lock() in BagOStuff [core] - 10https://gerrit.wikimedia.org/r/119314 (owner: 10Aaron Schulz) [17:19:28] <grrrit-wm> (03CR) 10EBernhardson: [C: 032] Anonymous editor warning. Now with links to log in and register. [extensions/Flow] - 10https://gerrit.wikimedia.org/r/117846 (owner: 10Werdna) [17:19:57] <grrrit-wm> (03Merged) 10jenkins-bot: Anonymous editor warning. Now with links to log in and register. [extensions/Flow] - 10https://gerrit.wikimedia.org/r/117846 (owner: 10Werdna) [17:20:00] <grrrit-wm> (03Merged) 10jenkins-bot: Lowered high lock timeout in mergeViaLock() and lock() in BagOStuff [core] - 10https://gerrit.wikimedia.org/r/119314 (owner: 10Aaron Schulz) [17:21:10] <grrrit-wm> (03CR) 10Matthias Mullie: [C: 032] Remove [] from URL [extensions/Flow] - 10https://gerrit.wikimedia.org/r/120732 (owner: 10Bsitu) [17:21:30] <grrrit-wm> (03Merged) 10jenkins-bot: Remove [] from URL [extensions/Flow] - 10https://gerrit.wikimedia.org/r/120732 (owner: 10Bsitu) [17:29:20] <grrrit-wm> (03CR) 10Nikerabbit: [C: 032] Migrate to JSON i18n [extensions/AntiSpoof] - 10https://gerrit.wikimedia.org/r/120785 (owner: 10Siebrand) [17:29:29] <grrrit-wm> (03Merged) 10jenkins-bot: Migrate to JSON i18n [extensions/AntiSpoof] - 10https://gerrit.wikimedia.org/r/120785 (owner: 10Siebrand) [17:29:34] <grrrit-wm> (03CR) 10Catrope: [C: 032 V: 032] Update LocalisationUpdate for rewrite [core] (wmf/1.23wmf18) - 10https://gerrit.wikimedia.org/r/120813 (owner: 10Catrope) [17:29:52] <grrrit-wm> (03PS1) 10Thiemo Mättig (WMDE): Use precise ApiBase type hints and variable names in all API modules [core] - 10https://gerrit.wikimedia.org/r/120827 [17:32:37] <grrrit-wm> (03PS4) 10Ori.livneh: Remove reference to provider.driver.version and virtualbox class [vagrant] - 10https://gerrit.wikimedia.org/r/116676 (owner: 10MarkAHershberger) [17:33:01] <grrrit-wm> (03CR) 10Ori.livneh: [C: 032] "Excellent, thanks to both." [vagrant] - 10https://gerrit.wikimedia.org/r/116676 (owner: 10MarkAHershberger) [17:33:07] <grrrit-wm> (03Merged) 10jenkins-bot: Remove reference to provider.driver.version and virtualbox class [vagrant] - 10https://gerrit.wikimedia.org/r/116676 (owner: 10MarkAHershberger) [17:34:40] <Amgine> <rage> Why does this work for preg_match, but not preg_match_all? http://www.phpliveregex.com/p/4qt [17:35:28] <grrrit-wm> (03CR) 10Ori.livneh: "Rebase and I'll review" [vagrant] - 10https://gerrit.wikimedia.org/r/86420 (owner: 10Physikerwelt) [17:37:54] <grrrit-wm> (03CR) 10Matthias Mullie: [C: 032] Replace generic "Internal error - {{SITENAME}}" on error page [extensions/Flow] - 10https://gerrit.wikimedia.org/r/120708 (owner: 10Bsitu) [17:38:12] <grrrit-wm> (03CR) 10jenkins-bot: [V: 04-1] Replace generic "Internal error - {{SITENAME}}" on error page [extensions/Flow] - 10https://gerrit.wikimedia.org/r/120708 (owner: 10Bsitu) [17:39:21] <Amgine> (and why is xchat hiding my underbars?) [17:39:46] <grrrit-wm> (03CR) 10EBernhardson: "* I'm also unsure about content handler, the high level idea afaiui is:" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/118238 (owner: 10EBernhardson) [17:42:42] <grrrit-wm> (03PS2) 10Ori.livneh: Stop 'stdin: is not a tty' complaints [vagrant] - 10https://gerrit.wikimedia.org/r/120481 (owner: 10BryanDavis) [17:43:07] <grrrit-wm> (03CR) 10Ori.livneh: [C: 032] "What kind of cookie would you like? :)" [vagrant] - 10https://gerrit.wikimedia.org/r/120481 (owner: 10BryanDavis) [17:43:16] <grrrit-wm> (03Merged) 10jenkins-bot: Stop 'stdin: is not a tty' complaints [vagrant] - 10https://gerrit.wikimedia.org/r/120481 (owner: 10BryanDavis) [17:44:12] <grrrit-wm> (03PS3) 10Jdlrobson: Specify screenshots by language in a more robust way [extensions/VectorBeta] - 10https://gerrit.wikimedia.org/r/120238 (owner: 10Amire80) [17:47:24] <grrrit-wm> (03PS2) 10Ori.livneh: Update ACE to Mar 16, 2014 [extensions/CodeEditor] - 10https://gerrit.wikimedia.org/r/118979 (owner: 10TheDJ) [17:47:25] <grrrit-wm> (03CR) 10Ori.livneh: [C: 032] Update ACE to Mar 16, 2014 [extensions/CodeEditor] - 10https://gerrit.wikimedia.org/r/118979 (owner: 10TheDJ) [17:47:27] <grrrit-wm> (03Merged) 10jenkins-bot: Update ACE to Mar 16, 2014 [extensions/CodeEditor] - 10https://gerrit.wikimedia.org/r/118979 (owner: 10TheDJ) [17:48:18] <grrrit-wm> (03CR) 10Jdlrobson: [C: 032] Specify screenshots by language in a more robust way [extensions/VectorBeta] - 10https://gerrit.wikimedia.org/r/120238 (owner: 10Amire80) [17:48:28] <grrrit-wm> (03Merged) 10jenkins-bot: Specify screenshots by language in a more robust way [extensions/VectorBeta] - 10https://gerrit.wikimedia.org/r/120238 (owner: 10Amire80) [17:48:39] <grrrit-wm> (03CR) 10Jdlrobson: [C: 032] Allow having screenshots by language [extensions/BetaFeatures] - 10https://gerrit.wikimedia.org/r/120237 (owner: 10Amire80) [17:49:15] <grrrit-wm> (03Merged) 10jenkins-bot: Allow having screenshots by language [extensions/BetaFeatures] - 10https://gerrit.wikimedia.org/r/120237 (owner: 10Amire80) [17:49:42] <grrrit-wm> (03Abandoned) 10Umherirrender: Accept null in HTMLRadioField::validate [core] - 10https://gerrit.wikimedia.org/r/120313 (owner: 10Umherirrender) [17:54:08] <grrrit-wm> (03PS2) 10Ori.livneh: Work around a problem with web workers in ACE [extensions/CodeEditor] - 10https://gerrit.wikimedia.org/r/118980 (owner: 10TheDJ) [17:56:07] <grrrit-wm> (03PS5) 10Umherirrender: Add CURRENTDAY1/LOCALDAY1 aliases for CURRENTDAY/LOCALDAY [core] - 10https://gerrit.wikimedia.org/r/110705 [17:56:21] <grrrit-wm> (03CR) 10EBernhardson: "Continuing previous early submit:" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/118238 (owner: 10EBernhardson) [17:57:01] <grrrit-wm> (03PS2) 10Inchikutty: Improving zoom of embedded map, on address search [extensions/UploadWizard] (osm) - 10https://gerrit.wikimedia.org/r/118978 [17:59:12] <grrrit-wm> (03PS3) 10Ori.livneh: Work around a problem with web workers in ACE [extensions/CodeEditor] - 10https://gerrit.wikimedia.org/r/118980 (owner: 10TheDJ) [18:04:45] <grrrit-wm> (03CR) 10Nikerabbit: [C: 032] "Surprise attack! ;)" [extensions/Campaigns] - 10https://gerrit.wikimedia.org/r/120790 (owner: 10Siebrand) [18:04:49] <grrrit-wm> (03PS3) 10Matthias Mullie: Update Makefile for Labs instances migrated to eqiad [extensions/Flow] - 10https://gerrit.wikimedia.org/r/120751 (owner: 10Spage) [18:05:02] <grrrit-wm> (03Merged) 10jenkins-bot: Migrate to JSON i18n [extensions/Campaigns] - 10https://gerrit.wikimedia.org/r/120790 (owner: 10Siebrand) [18:05:41] <grrrit-wm> (03CR) 10Nikerabbit: [C: 032] Migrate to JSON i18n [extensions/Calendar] - 10https://gerrit.wikimedia.org/r/120789 (owner: 10Siebrand) [18:06:06] <grrrit-wm> (03Merged) 10jenkins-bot: Migrate to JSON i18n [extensions/Calendar] - 10https://gerrit.wikimedia.org/r/120789 (owner: 10Siebrand) [18:07:01] <grrrit-wm> (03PS6) 10Matthias Mullie: Replace generic "Internal error - {{SITENAME}}" on error page [extensions/Flow] - 10https://gerrit.wikimedia.org/r/120708 (owner: 10Bsitu) [18:07:28] <grrrit-wm> (03CR) 10Nikerabbit: [C: 032] Migrate to JSON i18n [extensions/AntiBot] - 10https://gerrit.wikimedia.org/r/120784 (owner: 10Siebrand) [18:07:36] <grrrit-wm> (03CR) 10Matthias Mullie: [C: 032] Replace generic "Internal error - {{SITENAME}}" on error page [extensions/Flow] - 10https://gerrit.wikimedia.org/r/120708 (owner: 10Bsitu) [18:07:52] <grrrit-wm> (03Merged) 10jenkins-bot: Migrate to JSON i18n [extensions/AntiBot] - 10https://gerrit.wikimedia.org/r/120784 (owner: 10Siebrand) [18:08:10] <grrrit-wm> (03Merged) 10jenkins-bot: Replace generic "Internal error - {{SITENAME}}" on error page [extensions/Flow] - 10https://gerrit.wikimedia.org/r/120708 (owner: 10Bsitu) [18:09:50] <grrrit-wm> (03CR) 10Ori.livneh: [C: 032] Work around a problem with web workers in ACE [extensions/CodeEditor] - 10https://gerrit.wikimedia.org/r/118980 (owner: 10TheDJ) [18:09:52] <grrrit-wm> (03Merged) 10jenkins-bot: Work around a problem with web workers in ACE [extensions/CodeEditor] - 10https://gerrit.wikimedia.org/r/118980 (owner: 10TheDJ) [18:11:38] <grrrit-wm> (03CR) 10Matthias Mullie: [C: 032] Flow's Echo notificaiton is not being set up correctly [extensions/Flow] (wmf/1.23wmf19) - 10https://gerrit.wikimedia.org/r/120746 (owner: 10EBernhardson) [18:11:53] <grrrit-wm> (03Merged) 10jenkins-bot: Flow's Echo notificaiton is not being set up correctly [extensions/Flow] (wmf/1.23wmf19) - 10https://gerrit.wikimedia.org/r/120746 (owner: 10EBernhardson) [18:12:07] <grrrit-wm> (03CR) 10Nikerabbit: Migrate to JSON i18n (031 comment) [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/120782 (owner: 10Siebrand) [18:15:14] <grrrit-wm> (03PS4) 10Siebrand: Migrate to JSON i18n with B/C [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/120782 [18:15:42] <grrrit-wm> (03CR) 10Siebrand: Migrate to JSON i18n with B/C (031 comment) [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/120782 (owner: 10Siebrand) [18:16:49] <grrrit-wm> (03PS4) 10Ori.livneh: CodeEditor: Add a status bar with line and columncount [extensions/CodeEditor] - 10https://gerrit.wikimedia.org/r/118989 (owner: 10TheDJ) [18:17:38] <grrrit-wm> (03CR) 10Nikerabbit: [C: 032] Migrate to JSON i18n with B/C [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/120782 (owner: 10Siebrand) [18:17:40] <grrrit-wm> (03CR) 10Siebrand: [C: 04-1] includes/Linker.php: Added hook for "Media:" links (031 comment) [core] - 10https://gerrit.wikimedia.org/r/120767 (owner: 10Robert Vogel) [18:17:44] <grrrit-wm> (03Merged) 10jenkins-bot: Migrate to JSON i18n with B/C [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/120782 (owner: 10Siebrand) [18:18:50] <grrrit-wm> (03PS12) 10Bsitu: Closing & Summarizing topic frontend changes [extensions/Flow] - 10https://gerrit.wikimedia.org/r/119640 [18:19:01] <grrrit-wm> (03CR) 10jenkins-bot: [V: 04-1] Closing & Summarizing topic frontend changes [extensions/Flow] - 10https://gerrit.wikimedia.org/r/119640 (owner: 10Bsitu) [18:19:10] <grrrit-wm> (03CR) 10Nikerabbit: [C: 032] Migrate to JSON i18n (031 comment) [extensions/CategoryTree] - 10https://gerrit.wikimedia.org/r/120791 (owner: 10Siebrand) [18:19:14] <grrrit-wm> (03Merged) 10jenkins-bot: Migrate to JSON i18n [extensions/CategoryTree] - 10https://gerrit.wikimedia.org/r/120791 (owner: 10Siebrand) [18:22:47] <grrrit-wm> (03PS1) 10Thiemo Mättig (WMDE): Fix/update inline documentation in WikiPage class [core] - 10https://gerrit.wikimedia.org/r/120841 [18:22:54] <grrrit-wm> (03CR) 10MarkTraceur: "James, a link to the new patchset would be crackerjack" [core] - 10https://gerrit.wikimedia.org/r/120555 (owner: 10Gilles) [18:24:18] <grrrit-wm> (03CR) 10Jforrester: "Sorry, new change-id for the new patch rather than re-used – I7db48937d958a." [core] - 10https://gerrit.wikimedia.org/r/120555 (owner: 10Gilles) [18:24:30] <grrrit-wm> (03CR) 10Siebrand: [C: 04-1] Error Msg for missing db username & password when installing (031 comment) [core] - 10https://gerrit.wikimedia.org/r/118798 (owner: 10Pubudu538) [18:26:19] <grrrit-wm> (03CR) 10Matthias Mullie: [C: 04-1] Refactor Flow\\Formatter namespace (031 comment) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/117384 (owner: 10EBernhardson) [18:26:26] <grrrit-wm> (03PS16) 10Matthias Mullie: Refactor Flow\\Formatter namespace [extensions/Flow] - 10https://gerrit.wikimedia.org/r/117384 (owner: 10EBernhardson) [18:26:29] <grrrit-wm> (03CR) 10jenkins-bot: [V: 04-1] Refactor Flow\\Formatter namespace [extensions/Flow] - 10https://gerrit.wikimedia.org/r/117384 (owner: 10EBernhardson) [18:31:45] <grrrit-wm> (03PS1) 10Aude: Update Wikidata, patch for Wikibase js config and revert entity selector patch [core] (wmf/1.23wmf19) - 10https://gerrit.wikimedia.org/r/120845 [18:33:46] <grrrit-wm> (03CR) 10Aude: [C: 032] Update Wikidata, patch for Wikibase js config and revert entity selector patch [core] (wmf/1.23wmf19) - 10https://gerrit.wikimedia.org/r/120845 (owner: 10Aude) [18:35:53] <grrrit-wm> (03PS1) 10Catrope: Make VE math inspector title not be null [extensions/Math] - 10https://gerrit.wikimedia.org/r/120846 [18:37:54] <grrrit-wm> (03Merged) 10jenkins-bot: Update Wikidata, patch for Wikibase js config and revert entity selector patch [core] (wmf/1.23wmf19) - 10https://gerrit.wikimedia.org/r/120845 (owner: 10Aude) [18:40:59] <grrrit-wm> (03PS2) 10MarkTraceur: Fix EventLogging schema registry [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/120737 [18:42:07] <grrrit-wm> (03PS1) 10Cscott: Update set of files cleaned up after parserTests [core] - 10https://gerrit.wikimedia.org/r/120847 [18:44:36] <grrrit-wm> (03CR) 10Matthias Mullie: [C: 04-1] Refactor Flow\\Formatter namespace (031 comment) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/117384 (owner: 10EBernhardson) [18:45:20] <grrrit-wm> (03PS1) 10IAlex: Remove wfDebugLog() call from wfSetupSession() [core] - 10https://gerrit.wikimedia.org/r/120848 [18:48:19] <grrrit-wm> (03PS17) 10Matthias Mullie: Refactor Flow\\Formatter namespace [extensions/Flow] - 10https://gerrit.wikimedia.org/r/117384 (owner: 10EBernhardson) [18:48:24] <grrrit-wm> (03CR) 10Anomie: [C: 04-1] "If this is going to be done, it should be done right. See comments." (033 comments) [core] - 10https://gerrit.wikimedia.org/r/120827 (owner: 10Thiemo Mättig (WMDE)) [18:48:26] <grrrit-wm> (03CR) 10jenkins-bot: [V: 04-1] Refactor Flow\\Formatter namespace [extensions/Flow] - 10https://gerrit.wikimedia.org/r/117384 (owner: 10EBernhardson) [18:54:44] <grrrit-wm> (03PS1) 10Thiemo Mättig (WMDE): Fix/update inline documentations in GlobalFunctions [core] - 10https://gerrit.wikimedia.org/r/120850 [18:56:09] <grrrit-wm> (03PS13) 10Bsitu: Closing & Summarizing topic frontend changes [extensions/Flow] - 10https://gerrit.wikimedia.org/r/119640 [18:56:22] <grrrit-wm> (03CR) 10jenkins-bot: [V: 04-1] Closing & Summarizing topic frontend changes [extensions/Flow] - 10https://gerrit.wikimedia.org/r/119640 (owner: 10Bsitu) [18:57:21] <grrrit-wm> (03PS2) 10Phuedx: [WIP] Add the mw.cookie module [core] - 10https://gerrit.wikimedia.org/r/120806 [18:58:24] <grrrit-wm> (03PS22) 10Bsitu: Add topic summary revision type [extensions/Flow] - 10https://gerrit.wikimedia.org/r/117357 [18:58:52] <grrrit-wm> (03PS18) 10Matthias Mullie: Refactor Flow\\Formatter namespace [extensions/Flow] - 10https://gerrit.wikimedia.org/r/117384 (owner: 10EBernhardson) [18:59:13] <grrrit-wm> (03CR) 10jenkins-bot: [V: 04-1] Refactor Flow\\Formatter namespace [extensions/Flow] - 10https://gerrit.wikimedia.org/r/117384 (owner: 10EBernhardson) [18:59:17] <grrrit-wm> (03CR) 10Matthias Mullie: [C: 032] Handle exceptions when testing row validity [core] - 10https://gerrit.wikimedia.org/r/117378 (owner: 10EBernhardson) [18:59:35] <grrrit-wm> (03CR) 10Subramanya Sastry: [C: 032] Sync up with Parsoid parserTests. [core] - 10https://gerrit.wikimedia.org/r/120818 (owner: 10Cscott) [19:00:23] <grrrit-wm> (03PS15) 10Bsitu: Closing & reopening topic [extensions/Flow] - 10https://gerrit.wikimedia.org/r/118399 [19:00:33] <grrrit-wm> (03CR) 10Matthias Mullie: Refactor Flow\\Formatter namespace (031 comment) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/117384 (owner: 10EBernhardson) [19:01:33] <grrrit-wm> (03CR) 10Matthias Mullie: [C: 031] "LGTM; but needs https://gerrit.wikimedia.org/r/#/c/116649/ merged first; I'll take a look at that soon" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/117384 (owner: 10EBernhardson) [19:03:19] <grrrit-wm> (03Merged) 10jenkins-bot: Handle exceptions when testing row validity [core] - 10https://gerrit.wikimedia.org/r/117378 (owner: 10EBernhardson) [19:04:21] <grrrit-wm> (03Merged) 10jenkins-bot: Sync up with Parsoid parserTests. [core] - 10https://gerrit.wikimedia.org/r/120818 (owner: 10Cscott) [19:05:41] <grrrit-wm> (03PS14) 10Bsitu: Closing & Summarizing topic frontend changes [extensions/Flow] - 10https://gerrit.wikimedia.org/r/119640 [19:05:50] <grrrit-wm> (03CR) 10jenkins-bot: [V: 04-1] Closing & Summarizing topic frontend changes [extensions/Flow] - 10https://gerrit.wikimedia.org/r/119640 (owner: 10Bsitu) [19:09:10] <grrrit-wm> (03PS1) 10UltrasonicNXT: Keep users online if their chat window is focussed [extensions/MediaWikiChat] - 10https://gerrit.wikimedia.org/r/120853 [19:09:36] <grrrit-wm> (03CR) 10IAlex: Fix/update inline documentation in WikiPage class (032 comments) [core] - 10https://gerrit.wikimedia.org/r/120841 (owner: 10Thiemo Mättig (WMDE)) [19:10:10] <grrrit-wm> (03CR) 10Jforrester: [C: 032] Make VE math inspector title not be null [extensions/Math] - 10https://gerrit.wikimedia.org/r/120846 (owner: 10Catrope) [19:10:38] <grrrit-wm> (03PS1) 10Jforrester: Make VE math inspector title not be null [extensions/Math] (wmf/1.23wmf19) - 10https://gerrit.wikimedia.org/r/120854 [19:11:27] <grrrit-wm> (03Merged) 10jenkins-bot: Make VE math inspector title not be null [extensions/Math] - 10https://gerrit.wikimedia.org/r/120846 (owner: 10Catrope) [19:12:43] <grrrit-wm> (03CR) 10UltrasonicNXT: [C: 032 V: 032] Keep users online if their chat window is focussed [extensions/MediaWikiChat] - 10https://gerrit.wikimedia.org/r/120853 (owner: 10UltrasonicNXT) [19:17:16] <grrrit-wm> (03PS7) 1001tonythomas: Error Msg for missing db username & password when installing [core] - 10https://gerrit.wikimedia.org/r/118798 (owner: 10Pubudu538) [19:17:20] <grrrit-wm> (03CR) 10IAlex: Fix/update inline documentations in GlobalFunctions (031 comment) [core] - 10https://gerrit.wikimedia.org/r/120850 (owner: 10Thiemo Mättig (WMDE)) [19:18:03] <grrrit-wm> (03PS1) 10Cscott: Add a new image option: "square" [core] - 10https://gerrit.wikimedia.org/r/120856 [19:21:02] <grrrit-wm> (03PS1) 10Umherirrender: Allow access to revision deleted wikitext on action=edit [core] - 10https://gerrit.wikimedia.org/r/120858 [19:22:56] <grrrit-wm> (03CR) 10Gilles: "It's possible to reuse a Change-Id while switching project? TIL" [core] - 10https://gerrit.wikimedia.org/r/120555 (owner: 10Gilles) [19:25:27] <grrrit-wm> (03CR) 10Thiemo Mättig (WMDE): "> in many places you're renaming variables for zero increase" (032 comments) [core] - 10https://gerrit.wikimedia.org/r/120827 (owner: 10Thiemo Mättig (WMDE)) [19:26:30] <grrrit-wm> (03CR) 10jenkins-bot: [V: 04-1] Add a new image option: "square" [core] - 10https://gerrit.wikimedia.org/r/120856 (owner: 10Cscott) [19:33:02] <grrrit-wm> (03CR) 10GWicke: [C: 04-2] "I'm not a fan of the 'square' option. See my comment at https://bugzilla.wikimedia.org/show_bug.cgi?id=62671#c7." [core] - 10https://gerrit.wikimedia.org/r/120856 (owner: 10Cscott) [19:39:43] <grrrit-wm> (03CR) 10Bartosz Dziewoński: Error Msg for missing db username & password when installing (031 comment) [core] - 10https://gerrit.wikimedia.org/r/118798 (owner: 10Pubudu538) [19:40:17] <grrrit-wm> (03PS1) 10IAlex: Remove unused $wgLicenseTerms [core] - 10https://gerrit.wikimedia.org/r/120860 [19:41:39] <MatmaRex> oh hey, we're on jwz. http://www.jwz.org/blog/2014/03/accidentally-turing-complete/ [19:43:38] <hoo> at least we kept it simple and stupid ... *hides* [19:46:31] <grrrit-wm> (03PS1) 10Hashar: beta: replace /home/wikipedia with /data/project... [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/120861 [19:48:41] <grrrit-wm> (03PS6) 10BryanDavis: Add redisjobqueue role [vagrant] - 10https://gerrit.wikimedia.org/r/88006 (owner: 10Legoktm) [19:48:54] <grrrit-wm> (03PS2) 10Hashar: beta: replace /home/wikipedia with /data/project... [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/120861 [19:50:28] <grrrit-wm> (03CR) 10BryanDavis: "I manually rebased this necrotic commit and fixed the trivial style issues. I have not tested it at all. Kunal should either verify that i" [vagrant] - 10https://gerrit.wikimedia.org/r/88006 (owner: 10Legoktm) [19:58:24] <grrrit-wm> (03CR) 10BryanDavis: "The wikimania_scholarships class is now using a name-based vhost. See Idcedec6 for what I added and how to use it." [vagrant] - 10https://gerrit.wikimedia.org/r/95471 (owner: 10Adamw) [20:00:02] <grrrit-wm> (03CR) 10BryanDavis: [C: 04-2] "Implemented by Max in I2fcb4bb" [vagrant] - 10https://gerrit.wikimedia.org/r/112812 (owner: 10Legoktm) [20:05:49] <grrrit-wm> (03CR) 10Hashar: [C: 032] beta: replace /home/wikipedia with /data/project... [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/120861 (owner: 10Hashar) [20:06:25] <grrrit-wm> (03Merged) 10jenkins-bot: beta: replace /home/wikipedia with /data/project... [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/120861 (owner: 10Hashar) [20:06:58] <grrrit-wm> (03PS3) 10Hashar: Compare JJB config changes by diffing XML output [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/120036 [20:11:27] <grrrit-wm> (03PS4) 10Hashar: Compare JJB config changes by diffing XML output [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/120036 [20:12:34] <grrrit-wm> (03CR) 10Hashar: "Tweak the refspec being fetched. The config-$ZUUL_BRANCH repo would never be updated because it lacked a branch specifier, additionally th" [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/120036 (owner: 10Hashar) [20:14:12] <grrrit-wm> (03CR) 10Hashar: [C: 032] "Confirmed. Job updated." [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/120036 (owner: 10Hashar) [20:14:49] <grrrit-wm> (03Merged) 10jenkins-bot: Compare JJB config changes by diffing XML output [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/120036 (owner: 10Hashar) [20:19:47] <grrrit-wm> (03PS2) 10Cscott: Add a new image option: "square" [core] - 10https://gerrit.wikimedia.org/r/120856 [20:20:50] <grrrit-wm> (03CR) 10Cscott: "See https://www.mediawiki.org/wiki/Requests_for_comment/Square_bounding_boxes" [core] - 10https://gerrit.wikimedia.org/r/120856 (owner: 10Cscott) [20:20:54] <grrrit-wm> (03PS1) 10Hashar: beta: explicitly define node on each job [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/120863 [20:21:35] <grrrit-wm> (03PS2) 10Hashar: beta: explicitly define node on each job [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/120863 [20:22:12] <grrrit-wm> (03CR) 10Swalling: [C: 031] Don't use the deprecated mw-ui-primary CSS class [extensions/GettingStarted] - 10https://gerrit.wikimedia.org/r/120776 (owner: 10Phuedx) [20:31:24] <grrrit-wm> (03PS2) 10Thiemo Mättig (WMDE): Use precise ApiMain/ApiQuery type hints in all API modules [core] - 10https://gerrit.wikimedia.org/r/120827 [20:32:21] <grrrit-wm> (03CR) 10Thiemo Mättig (WMDE): "I found a good way to "predict" the types. Thanks for poking me. :-)" [core] - 10https://gerrit.wikimedia.org/r/120827 (owner: 10Thiemo Mättig (WMDE)) [20:32:43] <grrrit-wm> (03PS1) 10Apsdehal: Adds onlyinprint class to skins [core] - 10https://gerrit.wikimedia.org/r/120865 [20:33:10] <grrrit-wm> (03PS1) 10Mattflaschen: Whitelist Sam Smith (WMF engineer) [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/120866 [20:33:30] <grrrit-wm> (03PS19) 10Bsitu: Refactor Flow\\Formatter namespace [extensions/Flow] - 10https://gerrit.wikimedia.org/r/117384 (owner: 10EBernhardson) [20:34:37] <grrrit-wm> (03PS1) 10Hashar: Make bin/scap-recompile executable [tools/scap] - 10https://gerrit.wikimedia.org/r/120867 [20:34:39] <grrrit-wm> (03PS2) 10Mattflaschen: Whitelist Sam Smith (WMF engineer) [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/120866 [20:35:15] <grrrit-wm> (03CR) 10Mattflaschen: "Fixed alphabetization in 2." [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/120866 (owner: 10Mattflaschen) [20:37:47] <grrrit-wm> (03CR) 10jenkins-bot: [V: 04-1] Use precise ApiMain/ApiQuery type hints in all API modules [core] - 10https://gerrit.wikimedia.org/r/120827 (owner: 10Thiemo Mättig (WMDE)) [20:46:01] <grrrit-wm> (03PS2) 10Thiemo Mättig (WMDE): Fix/update inline documentations in GlobalFunctions [core] - 10https://gerrit.wikimedia.org/r/120850 [20:48:05] <grrrit-wm> (03CR) 10Mattflaschen: [C: 04-1] "Not fully reviewed, but API looks good (I was a little paranoid about get/set being reserved, but they're not listed, and we already use t" (031 comment) [core] - 10https://gerrit.wikimedia.org/r/120806 (owner: 10Phuedx) [20:48:30] <grrrit-wm> (03PS4) 10Wctaiwan: Change UI of special page and support Flow Thanks [extensions/Thanks] - 10https://gerrit.wikimedia.org/r/119879 [20:48:48] <phuedx> superm401: ta [20:48:57] <superm401> phuedx, no problem. [20:49:14] <grrrit-wm> (03CR) 10Thiemo Mättig (WMDE): Fix/update inline documentations in GlobalFunctions (031 comment) [core] - 10https://gerrit.wikimedia.org/r/120850 (owner: 10Thiemo Mättig (WMDE)) [20:52:19] <grrrit-wm> (03CR) 10Thiemo Mättig (WMDE): Fix/update inline documentation in WikiPage class (031 comment) [core] - 10https://gerrit.wikimedia.org/r/120841 (owner: 10Thiemo Mättig (WMDE)) [20:52:28] <grrrit-wm> (03PS5) 10Wctaiwan: Change UI of special page and support Flow Thanks [extensions/Thanks] - 10https://gerrit.wikimedia.org/r/119879 [20:53:03] <grrrit-wm> (03CR) 10Mattflaschen: "Also, it's not necessary to depend on jquery or mediawiki (they're considered implicit dependencies of all modules)." (031 comment) [core] - 10https://gerrit.wikimedia.org/r/120806 (owner: 10Phuedx) [20:54:29] <grrrit-wm> (03PS1) 10Adamw: Comment generated code to explain the i18n JSON migration. [core] - 10https://gerrit.wikimedia.org/r/120932 [20:59:07] <grrrit-wm> (03CR) 10jenkins-bot: [V: 04-1] Fix/update inline documentations in GlobalFunctions [core] - 10https://gerrit.wikimedia.org/r/120850 (owner: 10Thiemo Mättig (WMDE)) [21:01:53] <grrrit-wm> (03PS3) 10Thiemo Mättig (WMDE): Use precise ApiMain/ApiQuery type hints in all API modules [core] - 10https://gerrit.wikimedia.org/r/120827 [21:02:22] <grrrit-wm> (03CR) 10Nikerabbit: Comment generated code to explain the i18n JSON migration. (031 comment) [core] - 10https://gerrit.wikimedia.org/r/120932 (owner: 10Adamw) [21:05:42] <grrrit-wm> (03CR) 10Adamw: Comment generated code to explain the i18n JSON migration. (031 comment) [core] - 10https://gerrit.wikimedia.org/r/120932 (owner: 10Adamw) [21:09:04] <grrrit-wm> (03PS2) 10Adamw: Comment generated code to explain the i18n JSON migration. [core] - 10https://gerrit.wikimedia.org/r/120932 [21:09:56] <grrrit-wm> (03CR) 10Krinkle: Add .jshintrc file and update core.js to remove errors (032 comments) [extensions/Popups] - 10https://gerrit.wikimedia.org/r/120752 (owner: 10Prtksxna) [21:10:33] <grrrit-wm> (03PS1) 10Hashar: scap-recompile: always point to most recent version [tools/scap] - 10https://gerrit.wikimedia.org/r/120936 [21:11:56] <grrrit-wm> (03PS4) 10Jdlrobson: Hygiene: Cleanup VectorBeta.php resources [extensions/VectorBeta] - 10https://gerrit.wikimedia.org/r/119904 [21:12:42] <grrrit-wm> (03CR) 10Krinkle: Show and hide Popups on focus and blur (along with mouseenter/leave) (031 comment) [extensions/Popups] - 10https://gerrit.wikimedia.org/r/120342 (owner: 10Prtksxna) [21:13:14] <grrrit-wm> (03CR) 10Hashar: "I need that change to be able to recompile texvc on beta cluster. The pmtpa bastion still use the version provided by the wikimedia-task-" [tools/scap] - 10https://gerrit.wikimedia.org/r/120936 (owner: 10Hashar) [21:13:47] <YuviPanda> RoanKattouw: Krinkle any idea what mw.loader.state({"mobile.app.config":"missing"}); as output of http://127.0.0.1:8080/w/load.php?debug=true&lang=en&modules=mobile.app.config&only=scripts&skin=vector&* could mean? [21:14:07] <YuviPanda> I was expecting it to give me the module I defined [21:14:19] <YuviPanda> ori: ^ [21:14:32] <grrrit-wm> (03CR) 10Thiemo Mättig (WMDE): Implement ApiQuerySites class (032 comments) [core] - 10https://gerrit.wikimedia.org/r/110427 (owner: 10Addshore) [21:14:50] <Krinkle> MatmaRex: Aww you don't like my docucu ? [21:15:01] <grrrit-wm> (03PS1) 10Hashar: beta: Use scap-recomile from the scap git repo [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/120937 [21:15:21] <MatmaRex> Krinkle: </3 [21:15:22] <Krinkle> YuviPanda: It means that module was not registered in $wgResourceModules, or was registered with invalid values [21:15:45] <Krinkle> YuviPanda: Consult the mediawiki exception/fatal/resourceloader log groups, should be something in there for ya [21:15:54] <YuviPanda> hmm, looking [21:16:01] <Krinkle> Or just look at the load.php request, there should be a comment prepended on top [21:16:02] <grrrit-wm> (03CR) 10Hashar: [C: 04-2] "Pending https://gerrit.wikimedia.org/r/#/c/120936/" [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/120937 (owner: 10Hashar) [21:16:04] <Krinkle> (enable stacktraces) [21:16:14] <grrrit-wm> (03CR) 10Hashar: [C: 032] beta: explicitly define node on each job [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/120863 (owner: 10Hashar) [21:16:56] <grrrit-wm> (03Merged) 10jenkins-bot: beta: explicitly define node on each job [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/120863 (owner: 10Hashar) [21:18:01] <grrrit-wm> (03PS2) 10Hashar: beta: Use scap-recompile from the scap git repo [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/120937 [21:19:33] <ori> what Krinkle said [21:20:10] <grrrit-wm> (03PS1) 10Hashar: beta: compile texvc on both datacenters [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/120939 [21:20:24] <grrrit-wm> (03PS1) 10Hashar: beta: compile texvc on both datacenters [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/120940 [21:20:54] <grrrit-wm> (03CR) 10Hashar: [C: 04-2] "Depends on jjb jobs for boths DC: https://gerrit.wikimedia.org/r/120939" [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/120939 (owner: 10Hashar) [21:21:12] <grrrit-wm> (03CR) 10Hashar: "Depends on jobs for both DCs: https://gerrit.wikimedia.org/r/120940" [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/120939 (owner: 10Hashar) [21:22:23] <grrrit-wm> (03CR) 10Hashar: [C: 04-2] "Zuul change: https://gerrit.wikimedia.org/r/120939" [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/120940 (owner: 10Hashar) [21:23:27] <grrrit-wm> (03PS8) 10Krinkle: SpecialCentralAutoLogin: Move javascript to separate files for linting [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/118430 [21:25:34] <YuviPanda> ori: Krinkle RoanKattouw nevermind, I had forgotten to actually enable the extension [21:25:45] * YuviPanda laughs at self, goes back to work [21:25:49] <grrrit-wm> (03CR) 10Nikerabbit: [C: 032] Added .gitignore and .gitreview files [services/cxserver] - 10https://gerrit.wikimedia.org/r/120819 (owner: 10KartikMistry) [21:25:50] <grrrit-wm> (03Merged) 10jenkins-bot: Added .gitignore and .gitreview files [services/cxserver] - 10https://gerrit.wikimedia.org/r/120819 (owner: 10KartikMistry) [21:26:37] <grrrit-wm> (03CR) 10Daniel Friesen: [C: 04-1] "commonContent is the wrong place for something like this. commonContent, etc... are optional stylesheets for skins to opt-in and simply ma" [core] - 10https://gerrit.wikimedia.org/r/120865 (owner: 10Apsdehal) [21:26:47] <grrrit-wm> (03CR) 10Krinkle: "Hashar: jshint doesn't lint json files. You set that up as a separate job, right? Either way, when we migrate that to npm, shouldn't be an" [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/116136 (owner: 10Krinkle) [21:27:25] <grrrit-wm> (03CR) 10Aaron Schulz: [C: 032] Remove wfDebugLog() call from wfSetupSession() [core] - 10https://gerrit.wikimedia.org/r/120848 (owner: 10IAlex) [21:32:53] * ebernhardson could swear he saw an 'aaron shulz is on vacation' email  [21:32:53] <grrrit-wm> (03Merged) 10jenkins-bot: Remove wfDebugLog() call from wfSetupSession() [core] - 10https://gerrit.wikimedia.org/r/120848 (owner: 10IAlex) [21:33:00] <grrrit-wm> (03CR) 10Hashar: "My idea was to add the json linter to all jslint jobs. Can probably add it as an additional build step to your job :-]" [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/116136 (owner: 10Krinkle) [21:38:38] <grrrit-wm> (03PS1) 10Yuvipanda: [WIP] Add an RL module that contains static(ish) config for the app [extensions/MobileApp] - 10https://gerrit.wikimedia.org/r/120944 [21:39:48] <grrrit-wm> (03PS2) 10Yuvipanda: [WIP] Add an RL module that contains static(ish) config for the app [extensions/MobileApp] - 10https://gerrit.wikimedia.org/r/120944 [21:45:28] <grrrit-wm> (03PS6) 10Wctaiwan: Change UI of special page and support Flow Thanks [extensions/Thanks] - 10https://gerrit.wikimedia.org/r/119879 [21:45:29] <grrrit-wm> (03PS6) 10Krinkle: Various clean up and refactor to make mediawiki-core-npm faster [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/116125 [21:45:29] <grrrit-wm> (03PS7) 10Wctaiwan: Change UI of special page and support Flow Thanks [extensions/Thanks] - 10https://gerrit.wikimedia.org/r/119879 [21:45:52] <grrrit-wm> (03CR) 10Krinkle: "Yep, that's how it'd work." [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/116136 (owner: 10Krinkle) [21:49:24] <grrrit-wm> (03CR) 10Hashar: "Timo / Chad can deploy it today. Else I will do it when I wake up :]" [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/120866 (owner: 10Mattflaschen) [21:50:45] <grrrit-wm> (03PS8) 10Wctaiwan: Change UI of special page and support Flow Thanks [extensions/Thanks] - 10https://gerrit.wikimedia.org/r/119879 [21:54:02] <thedj> ori_: thanks for merging ! [21:54:34] <grrrit-wm> (03PS2) 10Jdlrobson: Hygiene: Reorganise the repository by beta feature [extensions/VectorBeta] - 10https://gerrit.wikimedia.org/r/120147 [21:54:36] <grrrit-wm> (03PS5) 10Jdlrobson: Hygiene: Cleanup VectorBeta.php resources [extensions/VectorBeta] - 10https://gerrit.wikimedia.org/r/119904 [21:54:38] <grrrit-wm> (03PS19) 10Jdlrobson: Give Vector/Winter Minerva's hamburger menu icon [extensions/VectorBeta] - 10https://gerrit.wikimedia.org/r/117927 [21:54:40] <thedj> we now have basic syntax checking for lua and css and jshint support for JS. too nice ! [21:54:49] <thedj> http://en.wikipedia.beta.wmflabs.org/w/index.php?title=Module:HtmlBuilder&action=edit [21:54:54] <YuviPanda> wooo thedj :) [21:56:11] * thedj sets an alert for the template RFC meeting of tomorrow [21:59:50] <grrrit-wm> (03PS1) 10Hoo man: Update Wikidata to fix an exception on Client [core] (wmf/1.23wmf19) - 10https://gerrit.wikimedia.org/r/120950 [22:00:06] <ori_> thedj: did you see the follow-ups on the design list? i think there is interest in contributing icons, but you're being challenged to provide detailed specs :) [22:06:20] <thedj> ori_: hehe, well i was sort of up for that. I'm also somewhat looking for what buttons to have, but it's nice to know ppl are interested [22:07:21] <grrrit-wm> (03CR) 10BryanDavis: [C: 032] Make bin/scap-recompile executable [tools/scap] - 10https://gerrit.wikimedia.org/r/120867 (owner: 10Hashar) [22:07:31] <thedj> ori_: can you perhaps also look at https://gerrit.wikimedia.org/r/#/c/106693/ again ? it allows you to do ctrl-space to get code completion [22:07:39] <grrrit-wm> (03Merged) 10jenkins-bot: Make bin/scap-recompile executable [tools/scap] - 10https://gerrit.wikimedia.org/r/120867 (owner: 10Hashar) [22:08:08] <mwalker> Krinkle, jslint question; my understanding is that our js style for function calls is approximately the php spacey style; e.g. $.function( foo ).bar( baz, chaz ); [22:08:08] <thedj> having all that in one release is gonna be one heck of an improvement. [22:08:22] <mwalker> what is the jslint option to make it not complain about that? [22:09:00] <grrrit-wm> (03CR) 10Krinkle: [C: 032] Whitelist Sam Smith (WMF engineer) [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/120866 (owner: 10Mattflaschen) [22:09:09] <grrrit-wm> (03Merged) 10jenkins-bot: Whitelist Sam Smith (WMF engineer) [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/120866 (owner: 10Mattflaschen) [22:09:54] <grrrit-wm> (03CR) 10PleaseStand: [C: 04-1] [WIP] Add the mw.cookie module (0316 comments) [core] - 10https://gerrit.wikimedia.org/r/120806 (owner: 10Phuedx) [22:16:16] <grrrit-wm> (03CR) 10Hoo man: [C: 032] Update Wikidata to fix an exception on Client [core] (wmf/1.23wmf19) - 10https://gerrit.wikimedia.org/r/120950 (owner: 10Hoo man) [22:17:30] <mwalker> Krinkle, scratch that question; turns out my bigger problem was not having a config file at all; so I copied with modifications the VE one [22:18:24] <Krinkle> mwalker: Yeah, jshint (not jslint!) doesn't have any way to enforce "foo( a, b )". There is no option to enable nor disable it. [22:18:45] <Krinkle> jshint does code quality, jscs does coding style. [22:18:49] <Krinkle> the latter has an option for it. [22:19:02] <Krinkle> I intend to adopt it more widely, though for now most repos only have jshint [22:19:33] <grrrit-wm> (03PS1) 10TheDJ: CodeEditor now passes jslint, so make it voting [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/120954 [22:20:13] <grrrit-wm> (03PS9) 10Krinkle: SpecialCentralAutoLogin: Move javascript to separate files for linting [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/118430 [22:20:29] <grrrit-wm> (03CR) 10Krinkle: "Changed \n back, per PS5." [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/118430 (owner: 10Krinkle) [22:20:48] <grrrit-wm> (03CR) 10Krinkle: SpecialCentralAutoLogin: Move javascript to separate files for linting (031 comment) [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/118430 (owner: 10Krinkle) [22:21:00] <grrrit-wm> (03Merged) 10jenkins-bot: Update Wikidata to fix an exception on Client [core] (wmf/1.23wmf19) - 10https://gerrit.wikimedia.org/r/120950 (owner: 10Hoo man) [22:21:10] <grrrit-wm> (03PS1) 10Spage: Update Flow [core] (wmf/1.23wmf19) - 10https://gerrit.wikimedia.org/r/120955 [22:22:47] <grrrit-wm> (03CR) 10Spage: [C: 032] "06fecfd is what we want." [core] (wmf/1.23wmf19) - 10https://gerrit.wikimedia.org/r/120955 (owner: 10Spage) [22:27:27] <grrrit-wm> (03Merged) 10jenkins-bot: Update Flow [core] (wmf/1.23wmf19) - 10https://gerrit.wikimedia.org/r/120955 (owner: 10Spage) [22:27:38] <ebernhardson> ori_: this might be your realm, includes/Wiki.php:654 (triggerJobs method) has an fsockopen() call that uses the default platform connection timeout of 60s on an unconfigured labs instance(probably different in prod). should we be providing a default connect timeout there, or is it right to just use whatever the php 'default_socket_timeout' ini field uses? [22:28:09] <ebernhardson> ran into it because we had some pages in the new labs instances taking 61s, 60s to timeout that connect and <1s to do everything else [22:28:16] <grrrit-wm> (03PS4) 10Mattflaschen: Add a LESS test suite [core] - 10https://gerrit.wikimedia.org/r/119055 (owner: 10Phuedx) [22:28:30] <ori_> ebernhardson: have you seen https://gerrit.wikimedia.org/r/#/c/119314/ ? [22:29:24] <ebernhardson> ori_: hadn't, but basically seems same thing dont use 60s timeouts? : [22:29:25] <ebernhardson> :) [22:29:57] <grrrit-wm> (03CR) 10Jdlrobson: [C: 031] Using more UI agnostic language in licensing notice (031 comment) [extensions/WikimediaMessages] - 10https://gerrit.wikimedia.org/r/120728 (owner: 10Kaldari) [22:30:07] <grrrit-wm> (03PS2) 10TheDJ: [Do not merge] Allow the CodeEditor in read only mode [extensions/CodeEditor] - 10https://gerrit.wikimedia.org/r/120397 [22:30:25] <grrrit-wm> (03PS5) 10TheDJ: New hook for readonly editpages [core] - 10https://gerrit.wikimedia.org/r/120396 [22:33:57] <grrrit-wm> (03PS1) 10Ori.livneh: Allow schema registration via custom hook [extensions/EventLogging] - 10https://gerrit.wikimedia.org/r/120957 [22:35:14] <grrrit-wm> (03PS1) 10EBernhardson: Reduce connect timeout in MediaWiki::triggerJobs [core] - 10https://gerrit.wikimedia.org/r/120958 [22:36:14] <grrrit-wm> (03CR) 10jenkins-bot: [V: 04-1] Add a LESS test suite [core] - 10https://gerrit.wikimedia.org/r/119055 (owner: 10Phuedx) [22:36:43] <ori_> ebernhardson: yes [22:37:56] <grrrit-wm> (03CR) 10CSteipp: [C: 032] "My testing is all looking fine, so I'm going to merge this. Thanks!" [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/118430 (owner: 10Krinkle) [22:38:00] <grrrit-wm> (03Merged) 10jenkins-bot: SpecialCentralAutoLogin: Move javascript to separate files for linting [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/118430 (owner: 10Krinkle) [22:45:50] <grrrit-wm> (03CR) 10PleaseStand: "Does the newer status code work if you add it to includes/libs/HttpStatus.php? It's my understanding that the Apache bug only applies if a" [core] - 10https://gerrit.wikimedia.org/r/120765 (owner: 10Faidon Liambotis) [22:45:57] <ori> jgonera: 'mobileTargets' is fully deprecated, right? [22:47:14] <gwicke> Krinkle, https://github.com/gwicke/knockoff & https://github.com/gwicke/tassembly [23:01:52] <grrrit-wm> (03CR) 10Swalling: "In the commit, it says "unless you have define your own distinct" [core] - 10https://gerrit.wikimedia.org/r/119998 (owner: 10TheDJ) [23:06:30] <grrrit-wm> (03CR) 10BryanDavis: [C: 032] scap-recompile: always point to most recent version [tools/scap] - 10https://gerrit.wikimedia.org/r/120936 (owner: 10Hashar) [23:06:43] <grrrit-wm> (03Merged) 10jenkins-bot: scap-recompile: always point to most recent version [tools/scap] - 10https://gerrit.wikimedia.org/r/120936 (owner: 10Hashar) [23:08:40] <grrrit-wm> (03PS1) 10BryanDavis: Sort version list returned by mwversionsinuse [tools/scap] - 10https://gerrit.wikimedia.org/r/120961 [23:11:06] <grrrit-wm> (03CR) 10Aaron Schulz: [C: 032] Reduce connect timeout in MediaWiki::triggerJobs [core] - 10https://gerrit.wikimedia.org/r/120958 (owner: 10EBernhardson) [23:13:16] <grrrit-wm> (03PS3) 10Ori.livneh: Allow EventLogging events to be logged via mw#track [extensions/EventLogging] - 10https://gerrit.wikimedia.org/r/120757 [23:14:35] <jgonera> ori, yes. I'm not sure if it even works anymore [23:15:31] <grrrit-wm> (03Merged) 10jenkins-bot: Reduce connect timeout in MediaWiki::triggerJobs [core] - 10https://gerrit.wikimedia.org/r/120958 (owner: 10EBernhardson) [23:15:38] <grrrit-wm> (03CR) 10TheDJ: "Do designers not have review accounts ? /me thinks that's a bit strange....." [core] - 10https://gerrit.wikimedia.org/r/119998 (owner: 10TheDJ) [23:15:58] <grrrit-wm> (03CR) 10Mattflaschen: [C: 04-1] "I'm having a little trouble testing this locally in MW-Vagrant. I tried:" (031 comment) [core] - 10https://gerrit.wikimedia.org/r/119055 (owner: 10Phuedx) [23:16:33] <grrrit-wm> (03PS1) 10Alex Monk: Support setting column-width and list-style in <references /> tag [extensions/Cite] - 10https://gerrit.wikimedia.org/r/120962 [23:16:42] <grrrit-wm> (03CR) 10jenkins-bot: [V: 04-1] Support setting column-width and list-style in <references /> tag [extensions/Cite] - 10https://gerrit.wikimedia.org/r/120962 (owner: 10Alex Monk) [23:16:55] <grrrit-wm> (03CR) 10Mattflaschen: Add a LESS test suite (031 comment) [core] - 10https://gerrit.wikimedia.org/r/119055 (owner: 10Phuedx) [23:17:48] <grrrit-wm> (03CR) 10Alex Monk: [C: 04-1] "Couldn't remember why I hadn't uploaded this earlier. Now I know why." [extensions/Cite] - 10https://gerrit.wikimedia.org/r/120962 (owner: 10Alex Monk) [23:20:28] <grrrit-wm> (03PS4) 10Ori.livneh: Allow EventLogging events to be logged via mw#track [extensions/EventLogging] - 10https://gerrit.wikimedia.org/r/120757 [23:21:33] <grrrit-wm> (03CR) 10Swalling: "They generally do not, because they don't typically review code or submit patches." [core] - 10https://gerrit.wikimedia.org/r/119998 (owner: 10TheDJ) [23:22:18] <grrrit-wm> (03CR) 10Catrope: [C: 032] Make VE math inspector title not be null [extensions/Math] (wmf/1.23wmf19) - 10https://gerrit.wikimedia.org/r/120854 (owner: 10Jforrester) [23:22:35] <grrrit-wm> (03PS8) 10MaxSem: WIP: Elasticsearch support [extensions/GeoData] - 10https://gerrit.wikimedia.org/r/115413 [23:23:18] <grrrit-wm> (03Merged) 10jenkins-bot: Make VE math inspector title not be null [extensions/Math] (wmf/1.23wmf19) - 10https://gerrit.wikimedia.org/r/120854 (owner: 10Jforrester) [23:23:39] <grrrit-wm> (03CR) 10Bsitu: "Looks fine to me, a few minor issues" (034 comments) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/117384 (owner: 10EBernhardson) [23:25:35] <grrrit-wm> (03PS1) 10Catrope: Update Math extension for cherry-pick [core] (wmf/1.23wmf19) - 10https://gerrit.wikimedia.org/r/120964 [23:25:58] <grrrit-wm> (03CR) 10Catrope: [C: 032 V: 032] Update Math extension for cherry-pick [core] (wmf/1.23wmf19) - 10https://gerrit.wikimedia.org/r/120964 (owner: 10Catrope) [23:29:37] <grrrit-wm> (03PS2) 10Alex Monk: Support setting column-width and list-style in <references /> tag [extensions/Cite] - 10https://gerrit.wikimedia.org/r/120962 [23:29:46] <grrrit-wm> (03CR) 10jenkins-bot: [V: 04-1] Support setting column-width and list-style in <references /> tag [extensions/Cite] - 10https://gerrit.wikimedia.org/r/120962 (owner: 10Alex Monk) [23:38:20] <grrrit-wm> (03PS5) 10Krinkle: resourceloader: Separate gathering of registry data from mw.loader call [core] - 10https://gerrit.wikimedia.org/r/117444 [23:38:31] <grrrit-wm> (03CR) 10Krinkle: resourceloader: Separate gathering of registry data from mw.loader call (031 comment) [core] - 10https://gerrit.wikimedia.org/r/117444 (owner: 10Krinkle) [23:39:17] <grrrit-wm> (03PS10) 10Krinkle: resourceloader: Optimize module registry sent in the startup module [core] - 10https://gerrit.wikimedia.org/r/72534 (owner: 10Hoo man) [23:53:53] <grrrit-wm> (03PS7) 10Krinkle: Various clean up and refactor to make mediawiki-core-npm faster [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/116125 [23:54:13] <grrrit-wm> (03CR) 10Krinkle: [C: 032] "Rebased to resolve conflict with addition of parsoidsvc-{repository}-parse-tool-check." [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/116125 (owner: 10Krinkle) [23:55:04] <grrrit-wm> (03Merged) 10jenkins-bot: Various clean up and refactor to make mediawiki-core-npm faster [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/116125 (owner: 10Krinkle) [23:58:06] <grrrit-wm> (03CR) 10JGonera: "How about adding LIMIT to the query of, let's say, 100?" [extensions/VectorBeta] - 10https://gerrit.wikimedia.org/r/116920 (owner: 10JGonera) [23:59:05] <jgonera> hi springle, can I ask you for a review of https://gerrit.wikimedia.org/r/116920 (see my last comment)? [23:59:57] <springle> jgonera: looking