[00:02:06] Hie, I was installing "mwparserfromhell" and I am getting this error. Please help. http://www.fpaste.org/87935/56191971/ [00:17:49] Fixed. :) [01:50:31] (03PS1) 10BryanDavis: Stop 'stdin: is not a tty' complaints [vagrant] - 10https://gerrit.wikimedia.org/r/120481 [02:03:15] (03PS3) 10Brian Wolff: Add default implementation of getLength to base MediaHandler class [core] - 10https://gerrit.wikimedia.org/r/120177 [02:06:56] (03PS2) 10Brian Wolff: Add support for specifying headers in FileRepo::quickImport [core] - 10https://gerrit.wikimedia.org/r/120184 [02:13:31] (03PS7) 10Brian Wolff: Add Special:ListDuplicatedFiles expensive query special page. [core] - 10https://gerrit.wikimedia.org/r/85446 [02:13:52] (03CR) 10Brian Wolff: "PS7: use namespace constants." [core] - 10https://gerrit.wikimedia.org/r/85446 (owner: 10Brian Wolff) [02:24:31] (03CR) 10Legoktm: [C: 04-1] "Since categories can "exist" without the page actually existing, you'll need to modify ext.MassMessage.special.js to not display an error " (033 comments) [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/120334 (owner: 10Wctaiwan) [02:30:33] (03PS1) 10Gnosygnu: v1.3.4.1 [xowa] - 10https://gerrit.wikimedia.org/r/120482 [02:31:28] (03CR) 10Gnosygnu: [C: 032 V: 032] "approving own commit" [xowa] - 10https://gerrit.wikimedia.org/r/120482 (owner: 10Gnosygnu) [02:34:21] (03PS1) 10Physikerwelt: Add documentation [services/mathoid] - 10https://gerrit.wikimedia.org/r/120483 [02:37:48] (03CR) 10Physikerwelt: "^^" [services/mathoid] - 10https://gerrit.wikimedia.org/r/120483 (owner: 10Physikerwelt) [03:03:13] (03PS4) 10Wctaiwan: Add ability to deliver to all pages in a category [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/120334 [03:03:17] (03CR) 10jenkins-bot: [V: 04-1] Add ability to deliver to all pages in a category [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/120334 (owner: 10Wctaiwan) [03:23:49] (03PS5) 10Wctaiwan: Add ability to deliver to all pages in a category [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/120334 [03:28:34] (03PS1) 10Bsitu: edit topic summary no javascript support [extensions/Flow] - 10https://gerrit.wikimedia.org/r/120485 [03:28:58] (03CR) 10jenkins-bot: [V: 04-1] edit topic summary no javascript support [extensions/Flow] - 10https://gerrit.wikimedia.org/r/120485 (owner: 10Bsitu) [03:30:09] (03PS2) 10Bsitu: edit topic summary no javascript support [extensions/Flow] - 10https://gerrit.wikimedia.org/r/120485 [03:51:18] http://en.wiktionary.beta.wmflabs.org/wiki/Special:RecentChanges [03:51:28] Where is coming from? [03:51:36] Why is it HTML escaped? [03:53:47] (03PS6) 10Wctaiwan: Add ability to deliver to all pages in a category [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/120334 [04:01:17] (03CR) 10Klortho: [C: 031] "I am new here! This review is just for this one documentation change? If so, I am fine with it." [services/mathoid] - 10https://gerrit.wikimedia.org/r/120483 (owner: 10Physikerwelt) [04:13:51] (03CR) 10Physikerwelt: [C: 032] "Yes this change updates the documentation only." [services/mathoid] - 10https://gerrit.wikimedia.org/r/120483 (owner: 10Physikerwelt) [05:15:36] (03PS1) 10Physikerwelt: Expiremental option MathML input [extensions/Math] (dev) - 10https://gerrit.wikimedia.org/r/120486 [05:15:48] (03CR) 10jenkins-bot: [V: 04-1] Expiremental option MathML input [extensions/Math] (dev) - 10https://gerrit.wikimedia.org/r/120486 (owner: 10Physikerwelt) [05:20:41] (03PS2) 10Physikerwelt: Expiremental option MathML input [extensions/Math] (dev) - 10https://gerrit.wikimedia.org/r/120486 [05:21:50] (03CR) 10Physikerwelt: [C: 032] Expiremental option MathML input [extensions/Math] (dev) - 10https://gerrit.wikimedia.org/r/120486 (owner: 10Physikerwelt) [05:21:58] (03Merged) 10jenkins-bot: Expiremental option MathML input [extensions/Math] (dev) - 10https://gerrit.wikimedia.org/r/120486 (owner: 10Physikerwelt) [05:23:06] (03PS3) 10Hiong3-eng5: MW WLD prefix compatibility fix [extensions/WikiLexicalData] - 10https://gerrit.wikimedia.org/r/119446 [05:24:48] (03CR) 10Hiong3-eng5: "Purodha, kindly check if the install error was solved. Thanks" [extensions/WikiLexicalData] - 10https://gerrit.wikimedia.org/r/119446 (owner: 10Hiong3-eng5) [05:55:35] Hi legoktm ! You around ? [05:58:20] (03CR) 10Aaron Schulz: [C: 032] Add default implementation of getLength to base MediaHandler class [core] - 10https://gerrit.wikimedia.org/r/120177 (owner: 10Brian Wolff) [06:02:26] (03Merged) 10jenkins-bot: Add default implementation of getLength to base MediaHandler class [core] - 10https://gerrit.wikimedia.org/r/120177 (owner: 10Brian Wolff) [06:04:56] (03CR) 10Aaron Schulz: [C: 032] Add Special:ListDuplicatedFiles expensive query special page. [core] - 10https://gerrit.wikimedia.org/r/85446 (owner: 10Brian Wolff) [06:05:47] (03CR) 10Aaron Schulz: [C: 032] Add support for specifying headers in FileRepo::quickImport [core] - 10https://gerrit.wikimedia.org/r/120184 (owner: 10Brian Wolff) [06:06:16] (03CR) 10Aaron Schulz: [C: 032] Remove double wfDebug() call in Database.php [core] - 10https://gerrit.wikimedia.org/r/120360 (owner: 10IAlex) [06:07:43] (03CR) 10Aaron Schulz: [C: 032] DatabaseMysqlBase: Remove broken check for Percona Server [core] - 10https://gerrit.wikimedia.org/r/120166 (owner: 10PleaseStand) [06:09:14] (03Merged) 10jenkins-bot: Add Special:ListDuplicatedFiles expensive query special page. [core] - 10https://gerrit.wikimedia.org/r/85446 (owner: 10Brian Wolff) [06:09:34] (03Merged) 10jenkins-bot: Add support for specifying headers in FileRepo::quickImport [core] - 10https://gerrit.wikimedia.org/r/120184 (owner: 10Brian Wolff) [06:09:36] (03CR) 10Aaron Schulz: [C: 032] [Regression] Delete autoblocks when removing autoblock flag [core] - 10https://gerrit.wikimedia.org/r/120386 (owner: 10Umherirrender) [06:10:29] (03Merged) 10jenkins-bot: Remove double wfDebug() call in Database.php [core] - 10https://gerrit.wikimedia.org/r/120360 (owner: 10IAlex) [06:11:31] (03Merged) 10jenkins-bot: DatabaseMysqlBase: Remove broken check for Percona Server [core] - 10https://gerrit.wikimedia.org/r/120166 (owner: 10PleaseStand) [06:23:32] (03Merged) 10jenkins-bot: [Regression] Delete autoblocks when removing autoblock flag [core] - 10https://gerrit.wikimedia.org/r/120386 (owner: 10Umherirrender) [06:31:13] (03CR) 10Aaron Schulz: "Passes ceph test on my VM" [core] - 10https://gerrit.wikimedia.org/r/118800 (owner: 10Aaron Schulz) [06:31:24] (03CR) 10Ori.livneh: "I tried something similar before and then removed it because it "did not work out" (thanks for the explanation, past Ori!) This looks diff" [vagrant] - 10https://gerrit.wikimedia.org/r/120481 (owner: 10BryanDavis) [06:31:41] (03CR) 10Ori.livneh: "This is the relevant commit " [vagrant] - 10https://gerrit.wikimedia.org/r/120481 (owner: 10BryanDavis) [06:34:28] (03PS2) 10Aaron Schulz: Lowered high lock timeout in mergeViaLock() and lock() in BagOStuff [core] - 10https://gerrit.wikimedia.org/r/119314 [06:53:39] (03CR) 10Raimond Spekking: [C: 032] Remove period from desc message for consistency [extensions/Popups] - 10https://gerrit.wikimedia.org/r/120474 (owner: 10Siebrand) [06:54:49] (03CR) 10Ori.livneh: [C: 032] Tweaked "latest" handling of filebackend stat entries [core] - 10https://gerrit.wikimedia.org/r/118800 (owner: 10Aaron Schulz) [06:55:03] (03PS4) 10Ori.livneh: Tweaked "latest" handling of filebackend stat entries [core] - 10https://gerrit.wikimedia.org/r/118800 (owner: 10Aaron Schulz) [06:55:09] (03CR) 10Ori.livneh: [C: 032] Tweaked "latest" handling of filebackend stat entries [core] - 10https://gerrit.wikimedia.org/r/118800 (owner: 10Aaron Schulz) [06:55:12] i forgot to rebase [07:00:18] (03Merged) 10jenkins-bot: Tweaked "latest" handling of filebackend stat entries [core] - 10https://gerrit.wikimedia.org/r/118800 (owner: 10Aaron Schulz) [07:13:12] (03CR) 10Siebrand: [V: 032] Remove period from desc message for consistency [extensions/Popups] - 10https://gerrit.wikimedia.org/r/120474 (owner: 10Siebrand) [07:15:39] (03CR) 10Siebrand: "I reported https://bugzilla.wikimedia.org/show_bug.cgi?id=62997 asking for Jenkins for this repo." [extensions/Popups] - 10https://gerrit.wikimedia.org/r/120474 (owner: 10Siebrand) [07:19:51] (03CR) 10Siebrand: "Sorry for the late review. i18n/L10n comment added." (031 comment) [core] - 10https://gerrit.wikimedia.org/r/85446 (owner: 10Brian Wolff) [07:23:37] (03CR) 10Siebrand: [C: 031] "i18n/L10n reviewed." [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/120334 (owner: 10Wctaiwan) [07:23:44] (03PS1) 10Physikerwelt: Don't modify id of math element [extensions/Math] (dev) - 10https://gerrit.wikimedia.org/r/120489 [07:27:52] (03PS3) 1001tonythomas: Adding a JS Class to inputBox to grey out Submit button. [extensions/InputBox] - 10https://gerrit.wikimedia.org/r/120487 [07:28:49] (03CR) 10Siebrand: [C: 04-1] "i18n/L10n reviewed. Looks like f84b9e98ed6f42d17e0ed975b0e51347c7215ee8 has the same issues." (036 comments) [extensions/BlockAndNuke] (REL1_22) - 10https://gerrit.wikimedia.org/r/120479 (owner: 10MarkAHershberger) [07:29:42] (03CR) 10Siebrand: "All files have incorrect line endings." [extensions/BlockAndNuke] - 10https://gerrit.wikimedia.org/r/110551 (owner: 10MarkAHershberger) [07:31:04] (03CR) 10Siebrand: [V: 032] Initial commit [extensions/BlockAndNuke] (REL1_22) - 10https://gerrit.wikimedia.org/r/120478 (owner: 10MarkAHershberger) [07:32:12] (03PS2) 10Siebrand: set up gitreview for REL1_22 [extensions/BlockAndNuke] (REL1_22) - 10https://gerrit.wikimedia.org/r/120477 (owner: 10MarkAHershberger) [07:32:26] (03CR) 10Siebrand: [C: 032 V: 032] set up gitreview for REL1_22 [extensions/BlockAndNuke] (REL1_22) - 10https://gerrit.wikimedia.org/r/120477 (owner: 10MarkAHershberger) [07:38:55] (03CR) 10Siebrand: [C: 04-1] * Change display order to most recent editors/spammers * Remove deprecation * Make $um a more readable $userManager (0310 comments) [extensions/BlockAndNuke] - 10https://gerrit.wikimedia.org/r/120476 (owner: 10MarkAHershberger) [07:56:01] (03CR) 10KartikMistry: [C: 031] "LGTM" [services/cxserver] - 10https://gerrit.wikimedia.org/r/119931 (owner: 10Santhosh) [07:56:30] (03CR) 10KartikMistry: [C: 031] "LGTM." [services/cxserver] - 10https://gerrit.wikimedia.org/r/119969 (owner: 10Santhosh) [08:38:33] (03CR) 10Santhosh: [C: 032] Add .jshintrc and .jshintignore [services/cxserver] - 10https://gerrit.wikimedia.org/r/119934 (owner: 10Santhosh) [08:51:24] (03PS1) 10Physikerwelt: Fix: Wrong classname for class MathMLFilter [extensions/MathSearch] - 10https://gerrit.wikimedia.org/r/120490 [08:51:26] (03PS1) 10Physikerwelt: Alternative Hook for Math Postprocessing [extensions/MathSearch] - 10https://gerrit.wikimedia.org/r/120491 [08:51:33] (03CR) 10jenkins-bot: [V: 04-1] Alternative Hook for Math Postprocessing [extensions/MathSearch] - 10https://gerrit.wikimedia.org/r/120491 (owner: 10Physikerwelt) [08:52:37] (03CR) 10Physikerwelt: [C: 032] Fix: Wrong classname for class MathMLFilter [extensions/MathSearch] - 10https://gerrit.wikimedia.org/r/120490 (owner: 10Physikerwelt) [08:52:41] (03Merged) 10jenkins-bot: Fix: Wrong classname for class MathMLFilter [extensions/MathSearch] - 10https://gerrit.wikimedia.org/r/120490 (owner: 10Physikerwelt) [08:55:53] (03CR) 10Physikerwelt: "Hashar: Minor issue:" [extensions/MathSearch] - 10https://gerrit.wikimedia.org/r/120491 (owner: 10Physikerwelt) [08:56:54] Hi ! i was working on a patch for the inputBox extension to add JS to the interface so that the submit button remains disabled until the user enters the title completely [08:57:14] I could prepare the PS https://gerrit.wikimedia.org/r/#/c/120487/ [08:57:40] but when multiple textboxes are there, the code fails to recognize which submit button to disable [08:58:30] Can some one help me with adding the (this)-> closest effiectevely [09:01:22] (03PS2) 10Physikerwelt: Alternative Hook for Math Postprocessing [extensions/MathSearch] - 10https://gerrit.wikimedia.org/r/120491 [09:04:45] (03CR) 10Physikerwelt: [C: 032] "@Hashar: Never mind ... I removed type hinting." [extensions/MathSearch] - 10https://gerrit.wikimedia.org/r/120491 (owner: 10Physikerwelt) [09:04:49] (03Merged) 10jenkins-bot: Alternative Hook for Math Postprocessing [extensions/MathSearch] - 10https://gerrit.wikimedia.org/r/120491 (owner: 10Physikerwelt) [09:29:39] is there any CSS class for setting "display:none" of any HTML element? [09:30:23] or for disabling any HTML element [09:30:31] (03PS1) 10Hashar: Add jobs for Popups extension [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/120492 [09:30:56] (03CR) 10Hashar: "Thanks. Zuul triggers done with https://gerrit.wikimedia.org/r/120492" [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/120349 (owner: 10Prtksxna) [09:32:18] (03CR) 10Raimond Spekking: "Message key prefix should be changed from "block-" to "blockandnuke-"" [extensions/BlockAndNuke] - 10https://gerrit.wikimedia.org/r/110551 (owner: 10MarkAHershberger) [09:33:22] (03CR) 10Hashar: [C: 032] Add jobs for Popups extension [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/120492 (owner: 10Hashar) [09:33:26] (03Merged) 10jenkins-bot: Add jobs for Popups extension [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/120492 (owner: 10Hashar) [09:34:42] (03PS1) 10Hashar: Jenkins job validation (DO NOT SUBMIT) [extensions/Popups] - 10https://gerrit.wikimedia.org/r/120493 [09:34:44] (03CR) 10jenkins-bot: [V: 04-1] Jenkins job validation (DO NOT SUBMIT) [extensions/Popups] - 10https://gerrit.wikimedia.org/r/120493 (owner: 10Hashar) [09:35:35] (03PS2) 10Hashar: Jenkins job validation (DO NOT SUBMIT) [extensions/Popups] - 10https://gerrit.wikimedia.org/r/120493 [09:35:38] (03CR) 10jenkins-bot: [V: 04-1] Jenkins job validation (DO NOT SUBMIT) [extensions/Popups] - 10https://gerrit.wikimedia.org/r/120493 (owner: 10Hashar) [09:36:21] (03PS1) 10Hashar: Register two more extensions [extensions] - 10https://gerrit.wikimedia.org/r/120494 [09:36:38] (03CR) 10Hashar: [C: 032 V: 032] Register two more extensions [extensions] - 10https://gerrit.wikimedia.org/r/120494 (owner: 10Hashar) [09:37:33] (03CR) 10Hashar: "There is a few jshint errors that needs to be fixed https://integration.wikimedia.org/ci/job/mwext-Popups-jslint/1/console" [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/120349 (owner: 10Prtksxna) [09:38:22] (03Abandoned) 10Hashar: Jenkins job validation (DO NOT SUBMIT) [extensions/Popups] - 10https://gerrit.wikimedia.org/r/120493 (owner: 10Hashar) [09:55:39] (03PS1) 10Physikerwelt: Add missing page alias [extensions/MathSearch] - 10https://gerrit.wikimedia.org/r/120495 [09:58:23] nebulae: You mean to disable a button ? [09:58:31] (03PS4) 1001tonythomas: Adding a JS Class to inputBox to grey out Submit button. [extensions/InputBox] - 10https://gerrit.wikimedia.org/r/120487 [09:58:56] tonythomas: yes [09:59:10] (03CR) 1001tonythomas: "Tested with multiple inputboxes." [extensions/InputBox] - 10https://gerrit.wikimedia.org/r/120487 (owner: 1001tonythomas) [09:59:47] tonythomas: actually, I want to hide one HTML element. [09:59:56] (03CR) 10Physikerwelt: [C: 032] Don't modify id of math element [extensions/Math] (dev) - 10https://gerrit.wikimedia.org/r/120489 (owner: 10Physikerwelt) [10:01:55] nebulae: You can use a jquery function with something like ( '#elementID').hide() wont work ? [10:01:55] (03CR) 10Physikerwelt: [C: 032] Add missing page alias [extensions/MathSearch] - 10https://gerrit.wikimedia.org/r/120495 (owner: 10Physikerwelt) [10:01:57] (03Merged) 10jenkins-bot: Add missing page alias [extensions/MathSearch] - 10https://gerrit.wikimedia.org/r/120495 (owner: 10Physikerwelt) [10:05:11] Actually, I am working on a bug which requires that this element remains hidden if javascript is disabled in the browser and gets shown when javascript is enabled, so I can't use jQuery, I need some CSS class to diable that! [10:05:32] tonythomas: ^ [10:07:55] nebulae: there is something like css("display", "none"); actually used in JQuery though as $("#button").css("display", "none"); [10:08:55] you might be able to use .buttonId { display: none; } [10:11:12] tonythomas: you didn't get my point, I said javascript is disabled in the browser, so how can I use jQuery? [10:12:12] I need some existing css class in mediawiki which would set its display to 'none'. [10:13:20] nebulae: You can just define a new CSS definition for that button ID with .buttonId { display: none; } [10:13:31] nebulae: can you share the bug link ? [10:14:03] tonythomas: https://bugzilla.wikimedia.org/show_bug.cgi?id=57523 [10:15:05] tonythomas: do you know about Persona Login? [10:16:12] nebulae: I hadn't personally tried it. Had seen it somewhere in Mozilla though. Will check it out [10:16:31] yeah [10:17:45] tonythomas: Actually, what this Persona extension does is that it brings two buttons in the wiki, one is on the login page and the other is in the top right corner on all pages. [10:18:35] nebulae: You found a way to check out whether JS is enabled ? [10:19:50] No, I think from PHP we cannot find if Javascript is enabled in the browser or not. [10:21:21] So, what I want to do is to disable the buttons by default and enable them through jQuery because if JS is enabled then only this jQuery function will be called otherwise it will remain disabled. [10:21:55] (03Abandoned) 10Hashar: Adapted unittest to fit new wrapper [extensions/PagedTiffHandler] - 10https://gerrit.wikimedia.org/r/105168 (owner: 10Mglaser) [10:22:49] (03Abandoned) 10Hashar: Ignore wmf.bugconverter@gmail.com [wikimedia/bugzilla/wikibugs] - 10https://gerrit.wikimedia.org/r/104199 (owner: 10Merlijn van Deen) [10:24:05] nebulae: Ok. In that case, you can always add this css to the button with id = wpPersona [10:25:20] (03Abandoned) 10Hashar: Debug change for PHPUnit segfault [core] - 10https://gerrit.wikimedia.org/r/118552 (owner: 10Hashar) [10:26:00] nebulae: like #wpPerson { [10:26:10] display: none; } [10:26:16] but where in the do I add this CSS? [10:26:33] tonythomas: but where in the code do I add this CSS? [10:26:54] you need to add that as a new file, if there is no css existing. Added it as a new folder CSS in the extension dir [10:27:24] and later you can .addClass or .removeClass [10:54:34] (03PS1) 10Jatin: Disable Persona button in browsers that do not have Javascript [extensions/Persona] - 10https://gerrit.wikimedia.org/r/120502 [10:54:36] (03CR) 10jenkins-bot: [V: 04-1] Disable Persona button in browsers that do not have Javascript [extensions/Persona] - 10https://gerrit.wikimedia.org/r/120502 (owner: 10Jatin) [10:59:22] (03CR) 10Hashar: [C: 032] "Jobs deployed" [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/120349 (owner: 10Prtksxna) [11:00:00] (03Merged) 10jenkins-bot: Add jobs for Popups extension [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/120349 (owner: 10Prtksxna) [11:24:55] (03CR) 1001tonythomas: [C: 04-1] "The definitions you made inside window.onload = function() {" (032 comments) [extensions/Persona] - 10https://gerrit.wikimedia.org/r/120502 (owner: 10Jatin) [11:27:58] (03CR) 10Matthias Mullie: [C: 04-1] Simplify setup of RevisionCollectionPermissionsTest (031 comment) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/118729 (owner: 10Addshore) [11:37:59] (03Abandoned) 10Addshore: Simplify setup of RevisionCollectionPermissionsTest [extensions/Flow] - 10https://gerrit.wikimedia.org/r/118729 (owner: 10Addshore) [11:45:50] (03PS1) 10Addshore: Test against php 5.6 on travis [core] - 10https://gerrit.wikimedia.org/r/120508 [11:50:38] (03PS1) 10Siebrand: Use correct Creative Commons license abbreviation [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/120509 [11:52:55] (03PS1) 10Santhosh: Add mediawiki/services/cxserver project [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/120510 [11:57:25] (03CR) 10Fomafix: (Bug 34557) Fixed uses of width: 100%; with borders (032 comments) [core] - 10https://gerrit.wikimedia.org/r/54896 (owner: 10Rahul21) [12:01:57] (03CR) 10Raimond Spekking: [C: 032] Use correct Creative Commons license abbreviation [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/120509 (owner: 10Siebrand) [12:02:05] (03Merged) 10jenkins-bot: Use correct Creative Commons license abbreviation [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/120509 (owner: 10Siebrand) [12:04:17] (03PS2) 10Hashar: Compare JJB config changes by diffing XML output [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/120036 [12:04:46] (03CR) 10Hashar: "Pass --new-file to the diff command to show up the full XML of new jobs. Example: https://integration.wikimedia.org/ci/job/integration-jjb" [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/120036 (owner: 10Hashar) [12:05:47] (03CR) 10Siebrand: "Thanks!" [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/120349 (owner: 10Prtksxna) [12:07:56] (03PS1) 10Santhosh: Add jobs for mediawiki/services/cxserver [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/120511 [12:11:16] (03CR) 10Hashar: [C: 032] "created" [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/120510 (owner: 10Santhosh) [12:11:51] (03Merged) 10jenkins-bot: Add mediawiki/services/cxserver project [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/120510 (owner: 10Santhosh) [12:14:48] (03CR) 10Hashar: "almost :-]" (032 comments) [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/120511 (owner: 10Santhosh) [12:19:44] (03PS2) 10Santhosh: Add jobs for mediawiki/services/cxserver [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/120511 [12:22:20] (03CR) 10Hashar: [C: 032] Add jobs for mediawiki/services/cxserver [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/120511 (owner: 10Santhosh) [12:22:25] (03Merged) 10jenkins-bot: Add jobs for mediawiki/services/cxserver [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/120511 (owner: 10Santhosh) [12:25:18] (03PS2) 10Santhosh: Add .jshintrc and .jshintignore files [services/cxserver] - 10https://gerrit.wikimedia.org/r/119934 [12:25:34] (03CR) 10Santhosh: [C: 032] Add .jshintrc and .jshintignore files [services/cxserver] - 10https://gerrit.wikimedia.org/r/119934 (owner: 10Santhosh) [12:25:36] (03Merged) 10jenkins-bot: Add .jshintrc and .jshintignore files [services/cxserver] - 10https://gerrit.wikimedia.org/r/119934 (owner: 10Santhosh) [12:25:49] (03PS5) 10Hoo man: Optionally place a local block when globally blocking [extensions/GlobalBlocking] - 10https://gerrit.wikimedia.org/r/119915 [12:26:26] (03CR) 10Hoo man: Optionally place a local block when globally blocking (031 comment) [extensions/GlobalBlocking] - 10https://gerrit.wikimedia.org/r/119915 (owner: 10Hoo man) [12:26:48] (03CR) 10Hoo man: "Addressed Siebrand's comment" [extensions/GlobalBlocking] - 10https://gerrit.wikimedia.org/r/119915 (owner: 10Hoo man) [12:28:01] (03CR) 10Siebrand: [C: 031] "i18n/L10n reviewed." [extensions/GlobalBlocking] - 10https://gerrit.wikimedia.org/r/119915 (owner: 10Hoo man) [12:48:35] (03CR) 10Aaron Schulz: [C: 032] Removing Wikitravel from the default interwiki list [core] - 10https://gerrit.wikimedia.org/r/119923 (owner: 10Kaldari) [12:50:04] (03CR) 10Aaron Schulz: [C: 032] Option to increase verbosity of refreshCdbJsonFiles [tools/scap] - 10https://gerrit.wikimedia.org/r/119955 (owner: 10Hashar) [12:50:17] (03Merged) 10jenkins-bot: Option to increase verbosity of refreshCdbJsonFiles [tools/scap] - 10https://gerrit.wikimedia.org/r/119955 (owner: 10Hashar) [12:52:06] (03PS1) 10Siebrand: Use correct Creative Commons license abbreviation [core] - 10https://gerrit.wikimedia.org/r/120513 [12:53:06] (03Merged) 10jenkins-bot: Removing Wikitravel from the default interwiki list [core] - 10https://gerrit.wikimedia.org/r/119923 (owner: 10Kaldari) [12:55:07] (03CR) 10Raimond Spekking: [C: 032] Use correct Creative Commons license abbreviation [core] - 10https://gerrit.wikimedia.org/r/120513 (owner: 10Siebrand) [12:55:55] (03CR) 10MaxSem: "Why are you copying the .c files to .cpp?" (033 comments) [php/FastStringSearch] - 10https://gerrit.wikimedia.org/r/120469 (owner: 10Aaron Schulz) [12:59:21] (03Merged) 10jenkins-bot: Use correct Creative Commons license abbreviation [core] - 10https://gerrit.wikimedia.org/r/120513 (owner: 10Siebrand) [13:06:35] (03PS2) 10Hashar: Test against php 5.6 on travis [core] - 10https://gerrit.wikimedia.org/r/120508 (owner: 10Addshore) [13:06:40] (03CR) 10Hashar: [C: 032] Test against php 5.6 on travis [core] - 10https://gerrit.wikimedia.org/r/120508 (owner: 10Addshore) [13:08:56] (03CR) 10jenkins-bot: [V: 04-1] Test against php 5.6 on travis [core] - 10https://gerrit.wikimedia.org/r/120508 (owner: 10Addshore) [13:11:19] (03Merged) 10jenkins-bot: Test against php 5.6 on travis [core] - 10https://gerrit.wikimedia.org/r/120508 (owner: 10Addshore) [13:13:42] (03PS1) 10Tobias Gritschacher: Adding composer.phar [integration/jenkins] - 10https://gerrit.wikimedia.org/r/120517 [13:17:43] (03CR) 10Hashar: [C: 031] "Timo : that follow a discussion with Tobias, the idea would be run composer in our labs instance much like npm jobs." [integration/jenkins] - 10https://gerrit.wikimedia.org/r/120517 (owner: 10Tobias Gritschacher) [13:17:56] Tobi_WMDE: will poke Timo about it for a second thought [13:18:21] hashar: that's ok [13:25:13] (03CR) 10Physikerwelt: "How can I test that?" [extensions/InputBox] - 10https://gerrit.wikimedia.org/r/120487 (owner: 1001tonythomas) [13:29:53] (03CR) 1001tonythomas: "You need to install inputBox extension," [extensions/InputBox] - 10https://gerrit.wikimedia.org/r/120487 (owner: 1001tonythomas) [13:38:48] I get these errors on adding a JS file https://integration.wikimedia.org/ci/job/mwext-InputBox-jslint/19/console for inputBox extension, but the spacing conventions are as the same as used generally. Can someone too look into it ? [13:38:54] PS : https://gerrit.wikimedia.org/r/#/c/120487/4/resources/ext.inputBox.js [13:44:26] (03PS2) 10Jatin: Disable Persona button in browsers that do not have Javascript [extensions/Persona] - 10https://gerrit.wikimedia.org/r/120502 [13:44:28] (03CR) 10jenkins-bot: [V: 04-1] Disable Persona button in browsers that do not have Javascript [extensions/Persona] - 10https://gerrit.wikimedia.org/r/120502 (owner: 10Jatin) [13:56:31] hoo: You around ? [13:57:33] tonythomas: I'm currently working... so only half [13:57:57] hoo: Thats ok. When you have time, can you go through https://integration.wikimedia.org/ci/job/mwext-InputBox-jslint/19/console [13:58:11] hoo: I get lots of spacing errors for https://gerrit.wikimedia.org/r/#/c/120487/4/resources/ext.inputBox.js [13:58:42] probably there's no .jshintrc file in that extension [13:58:45] let me check quickly [13:58:51] hoo: Thanks [13:59:05] hoo: of course, there is no .jshintrc file [13:59:16] it never even used JS before, I added [13:59:17] it [13:59:19] Ok, so you ahve to add one [13:59:45] Oh. ok. let me check that out [13:59:53] I think there's an example one on mediawiki.org or just take one from another extension [14:01:03] hoo: got something here [14:01:03] * tonythomas https://github.com/wikimedia/mediawiki-extensions-TranslationNotifications/blob/master/.jshintrc [14:01:11] add the same thing will do right ? [14:01:26] I guess so, yes [14:02:08] (03PS5) 10leucosticte: Add getRobotPolicy() [core] - 10https://gerrit.wikimedia.org/r/117832 [14:04:39] (03PS5) 1001tonythomas: Adding a JS Class to inputBox to grey out Submit button. [extensions/InputBox] - 10https://gerrit.wikimedia.org/r/120487 [14:05:12] (03CR) 10Matthias Mullie: [C: 04-1] "Not done reviewing yet" (0310 comments) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/119640 (owner: 10Bsitu) [14:07:59] (03PS6) 1001tonythomas: Adding a JS Class to inputBox to grey out Submit button. [extensions/InputBox] - 10https://gerrit.wikimedia.org/r/120487 [14:08:40] hoo: yay ! got jenkins alright [14:10:20] :) [14:10:33] (03PS6) 10Addshore: Add getRobotPolicy() [core] - 10https://gerrit.wikimedia.org/r/117832 (owner: 10leucosticte) [14:10:38] (03CR) 10Addshore: [C: 032] Add getRobotPolicy() [core] - 10https://gerrit.wikimedia.org/r/117832 (owner: 10leucosticte) [14:15:20] (03Merged) 10jenkins-bot: Add getRobotPolicy() [core] - 10https://gerrit.wikimedia.org/r/117832 (owner: 10leucosticte) [14:17:20] (03PS1) 10Gerrit Patch Uploader: Remove #bodyContent { width: 100%; } [core] - 10https://gerrit.wikimedia.org/r/120528 [14:17:22] (03CR) 10Gerrit Patch Uploader: "This commit was uploaded using the Gerrit Patch Uploader [1]." [core] - 10https://gerrit.wikimedia.org/r/120528 (owner: 10Gerrit Patch Uploader) [14:29:06] (03Abandoned) 10Addshore: Move QueryPage.php to specialpage folder [core] - 10https://gerrit.wikimedia.org/r/109587 (owner: 10Addshore) [14:55:11] (03CR) 10BryanDavis: "This is working for me. Instead of trying to fix up the busted ~root/.profile that ships with ubuntu, this changes the ssh command that Va" [vagrant] - 10https://gerrit.wikimedia.org/r/120481 (owner: 10BryanDavis) [15:02:09] (03CR) 10Bartosz Dziewoński: [C: 031] "I'm not merging yet to let everyone interested look at this change, but I will +2 some time later if no one objects." [core] - 10https://gerrit.wikimedia.org/r/119998 (owner: 10TheDJ) [15:03:07] (03PS3) 10Jatin: Disable Persona button in browsers that do not have Javascript [extensions/Persona] - 10https://gerrit.wikimedia.org/r/120502 [15:03:09] (03CR) 10jenkins-bot: [V: 04-1] Disable Persona button in browsers that do not have Javascript [extensions/Persona] - 10https://gerrit.wikimedia.org/r/120502 (owner: 10Jatin) [15:07:40] (03CR) 1001tonythomas: [C: 04-1] Disable Persona button in browsers that do not have Javascript (032 comments) [extensions/Persona] - 10https://gerrit.wikimedia.org/r/120502 (owner: 10Jatin) [15:11:53] tonythomas: why is this jslint keep giving errors! [15:12:22] tonythomas: You reviewed the code. right? [15:18:30] nebulae: let me check [15:19:11] nebulae: those things you added should go under $( function( $ ) { [15:19:21] try uploading a PS with that [15:35:12] (03CR) 10MarkAHershberger: "tyvm" (039 comments) [extensions/BlockAndNuke] - 10https://gerrit.wikimedia.org/r/120476 (owner: 10MarkAHershberger) [15:35:35] (03PS2) 10MarkAHershberger: Update for code issues and usablity [extensions/BlockAndNuke] - 10https://gerrit.wikimedia.org/r/120476 [15:39:11] tonythomas: ok. [15:42:34] o/ nebulae [15:56:57] (03PS4) 10Jatin: Disable Persona button in browsers that do not have Javascript [extensions/Persona] - 10https://gerrit.wikimedia.org/r/120502 [15:57:01] (03CR) 10jenkins-bot: [V: 04-1] Disable Persona button in browsers that do not have Javascript [extensions/Persona] - 10https://gerrit.wikimedia.org/r/120502 (owner: 10Jatin) [15:58:06] (03PS1) 10Gerrit Patch Uploader: Remove unused style for #loginend [core] - 10https://gerrit.wikimedia.org/r/120549 [15:58:08] (03CR) 10Gerrit Patch Uploader: "This commit was uploaded using the Gerrit Patch Uploader [1]." [core] - 10https://gerrit.wikimedia.org/r/120549 (owner: 10Gerrit Patch Uploader) [16:00:06] nebulae: You forgot the .jshintrc file this time [16:02:24] tonythomas: oops, but is it right to add a new file in extension folder? Moreover that was stiil giving errors . [16:03:22] nebulae: of course, I had to do the same today. Add the file and send the PS [16:08:08] (03PS5) 10Jatin: Disable Persona button in browsers that do not have Javascript [extensions/Persona] - 10https://gerrit.wikimedia.org/r/120502 [16:08:10] (03CR) 10jenkins-bot: [V: 04-1] Disable Persona button in browsers that do not have Javascript [extensions/Persona] - 10https://gerrit.wikimedia.org/r/120502 (owner: 10Jatin) [16:10:45] tonythomas: it still gives some errors! [16:11:38] (03CR) 10Anomie: "I don't think I like this much. For the specific bug mentioned, a better fix would probably to be to explicitly call $field->getDefault() " [core] - 10https://gerrit.wikimedia.org/r/120313 (owner: 10Umherirrender) [16:11:54] (03CR) 10Pastakhov: "I've defined it there https://meta.wikimedia.org/wiki/Grants:IEG/Magic_expression" [extensions/PhpTags] - 10https://gerrit.wikimedia.org/r/120359 (owner: 10Pastakhov) [16:22:12] (03PS1) 10Hoo man: Always return a Title in RequestContext::getTitle [core] - 10https://gerrit.wikimedia.org/r/120552 [16:22:58] (03CR) 10EBernhardson: [C: 032] Display timestamp in local timezone and language per user preference [extensions/Flow] - 10https://gerrit.wikimedia.org/r/119877 (owner: 10Bencmq) [16:23:29] (03Merged) 10jenkins-bot: Display timestamp in local timezone and language per user preference [extensions/Flow] - 10https://gerrit.wikimedia.org/r/119877 (owner: 10Bencmq) [16:27:51] (03CR) 10jenkins-bot: [V: 04-1] Always return a Title in RequestContext::getTitle [core] - 10https://gerrit.wikimedia.org/r/120552 (owner: 10Hoo man) [16:29:40] Nemo_bis: Those errors seems not to be coming from your side [16:29:54] Nemo_bis: sorry ! was meant for nebulae! [16:30:52] :) [16:34:48] (03PS2) 10Hoo man: Always return a Title in RequestContext::getTitle [core] - 10https://gerrit.wikimedia.org/r/120552 [16:36:50] (03PS1) 10Gilles: Add the ability to disable autoEllipsis on labels [core] - 10https://gerrit.wikimedia.org/r/120554 [16:36:52] (03PS1) 10Gilles: Fixes bug where InlineMenuWidget would "steal" DOM labels on selection [core] - 10https://gerrit.wikimedia.org/r/120555 [16:37:50] (03CR) 10jenkins-bot: [V: 04-1] Add the ability to disable autoEllipsis on labels [core] - 10https://gerrit.wikimedia.org/r/120554 (owner: 10Gilles) [16:38:53] (03CR) 10jenkins-bot: [V: 04-1] Fixes bug where InlineMenuWidget would "steal" DOM labels on selection [core] - 10https://gerrit.wikimedia.org/r/120555 (owner: 10Gilles) [16:40:45] (03CR) 10jenkins-bot: [V: 04-1] Always return a Title in RequestContext::getTitle [core] - 10https://gerrit.wikimedia.org/r/120552 (owner: 10Hoo man) [16:42:49] (03CR) 10Matthias Mullie: "JS looks mostly fine to me. Just some remarks to help tidy things up." (037 comments) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/119640 (owner: 10Bsitu) [16:43:35] (03PS2) 10Gilles: Fixes bug where InlineMenuWidget would "steal" DOM labels on selection [core] - 10https://gerrit.wikimedia.org/r/120555 [16:45:02] (03CR) 10Anomie: [C: 031] "Code seems to work. A few nitpicks." (032 comments) [extensions/ParserFunctions] - 10https://gerrit.wikimedia.org/r/113518 (owner: 10Brian Wolff) [16:48:14] (03Abandoned) 10Gilles: Add the ability to disable autoEllipsis on labels [core] - 10https://gerrit.wikimedia.org/r/120554 (owner: 10Gilles) [16:50:58] (03PS1) 10KartikMistry: Fixed typo in update.php [extensions/LocalisationUpdate] (json-rewrite) - 10https://gerrit.wikimedia.org/r/120559 [16:52:03] (03CR) 10Gilles: "Needed by https://gerrit.wikimedia.org/r/#/c/120531/" [core] - 10https://gerrit.wikimedia.org/r/120555 (owner: 10Gilles) [16:54:07] (03CR) 10Anomie: [C: 031] Remove limits on mw.language:formatDate() [extensions/Scribunto] - 10https://gerrit.wikimedia.org/r/120156 (owner: 10Jackmcbarn) [16:55:39] (03CR) 10Matthias Mullie: Refactor Flow\\Formatter namespace (032 comments) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/117384 (owner: 10EBernhardson) [17:06:13] (03PS1) 10Christopher Johnson (WMDE): Autoloader incorrect case warnings fixed [core] - 10https://gerrit.wikimedia.org/r/120560 [17:10:51] (03CR) 10Anomie: [C: 04-1] "Comment on line 60 is the only reason for the -1, the rest are just nitpicks." (034 comments) [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/118430 (owner: 10Krinkle) [17:10:55] (03CR) 10EBernhardson: Refactor Flow\\Formatter namespace (035 comments) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/117384 (owner: 10EBernhardson) [17:17:12] (03CR) 10Kaldari: [C: 031] "Legoktm, Nemo bis: Any objections remaining to merging this?" [core] - 10https://gerrit.wikimedia.org/r/84303 (owner: 10TTO) [17:18:53] (03PS11) 10EBernhardson: Refactor Flow\\Formatter namespace [extensions/Flow] - 10https://gerrit.wikimedia.org/r/117384 [17:18:57] (03CR) 10jenkins-bot: [V: 04-1] Refactor Flow\\Formatter namespace [extensions/Flow] - 10https://gerrit.wikimedia.org/r/117384 (owner: 10EBernhardson) [17:19:09] (03PS1) 10Cmcmahon: QA: the check for the timestamp hasn't worked well, use other means [extensions/Flow] - 10https://gerrit.wikimedia.org/r/120561 [17:20:56] (03CR) 10Cmcmahon: [C: 032] "robustification" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/120561 (owner: 10Cmcmahon) [17:21:10] (03Merged) 10jenkins-bot: QA: the check for the timestamp hasn't worked well, use other means [extensions/Flow] - 10https://gerrit.wikimedia.org/r/120561 (owner: 10Cmcmahon) [17:21:34] (03PS12) 10EBernhardson: Refactor Flow\\Formatter namespace [extensions/Flow] - 10https://gerrit.wikimedia.org/r/117384 [17:26:15] mwalker, updated https://www.mediawiki.org/wiki/Requests_for_comment/HTML_templating_library#Performance with the last numbers after this weekend's tweaks [17:38:59] (03CR) 10Krinkle: [C: 04-1] "Please provide a source for this binary file so that a checksum and/or version or behaviour can be confirmed. Adding binary files with no " [integration/jenkins] - 10https://gerrit.wikimedia.org/r/120517 (owner: 10Tobias Gritschacher) [17:46:28] (03PS6) 10Krinkle: SpecialCentralAutoLogin: Move javascript to separate files for linting [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/118430 [17:46:54] (03CR) 10MaxSem: "No, caching will not help much because a) it's too slow anyway, b) hiding a slow query behind a cache is bad, c) one slow query in several" [extensions/VectorBeta] - 10https://gerrit.wikimedia.org/r/116920 (owner: 10JGonera) [18:07:22] (03PS7) 10Krinkle: SpecialCentralAutoLogin: Move javascript to separate files for linting [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/118430 [18:07:24] (03CR) 10Krinkle: SpecialCentralAutoLogin: Move javascript to separate files for linting (035 comments) [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/118430 (owner: 10Krinkle) [18:09:35] (03PS3) 10Krinkle: Enable mediawiki-core-npm (runs jshint+jscs), disable mediawiki-core-jslint [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/116136 [18:10:37] (03PS3) 10Krinkle: Improve docs for $wgExtensionCredits (and add 'license-name') [core] - 10https://gerrit.wikimedia.org/r/118617 [18:12:19] (03PS4) 10Krinkle: Improve docs for $wgExtensionCredits (and add 'license-name') [core] - 10https://gerrit.wikimedia.org/r/118617 [18:13:51] (03CR) 10Jforrester: [C: 032] Improve docs for $wgExtensionCredits (and add 'license-name') [core] - 10https://gerrit.wikimedia.org/r/118617 (owner: 10Krinkle) [18:18:08] (03Merged) 10jenkins-bot: Improve docs for $wgExtensionCredits (and add 'license-name') [core] - 10https://gerrit.wikimedia.org/r/118617 (owner: 10Krinkle) [18:19:16] (03PS4) 10Chad: Rewrite Interwiki searches to return array of search results [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/119335 [18:20:57] (03CR) 10Manybubbles: [C: 032] Rewrite Interwiki searches to return array of search results [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/119335 (owner: 10Chad) [18:21:06] (03Merged) 10jenkins-bot: Rewrite Interwiki searches to return array of search results [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/119335 (owner: 10Chad) [18:22:40] (03PS12) 10Krinkle: [WIP] Set up node-jscs via Grunt (and pass it) [core] - 10https://gerrit.wikimedia.org/r/111963 [18:22:44] (03CR) 10Krinkle: "Rebased to resolve merge conflicts and newly introduced violations in jquery.color.test.js and jquery.makeCollapsible.test.js." [core] - 10https://gerrit.wikimedia.org/r/111963 (owner: 10Krinkle) [18:25:20] (03CR) 10MarkAHershberger: Fixed padlock on thread history for LiquidThreads extension (032 comments) [extensions/LiquidThreads] - 10https://gerrit.wikimedia.org/r/118212 (owner: 10Adi.iiita) [18:30:12] (03CR) 10Siebrand: "i18n/L10n reviewed." (0310 comments) [extensions/BlockAndNuke] - 10https://gerrit.wikimedia.org/r/120476 (owner: 10MarkAHershberger) [18:31:42] (03CR) 10MarkAHershberger: "oops" (031 comment) [extensions/LiquidThreads] - 10https://gerrit.wikimedia.org/r/118212 (owner: 10Adi.iiita) [18:33:18] (03CR) 10Bsitu: Closing & Summarizing topic frontend changes (032 comments) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/119640 (owner: 10Bsitu) [18:34:13] (03PS2) 10Chad: Allow interwiki searches to return arrays of interwiki results [core] - 10https://gerrit.wikimedia.org/r/119334 [18:40:01] (03CR) 10Chad: [C: 032] Allow interwiki searches to return arrays of interwiki results [core] - 10https://gerrit.wikimedia.org/r/119334 (owner: 10Chad) [18:42:16] (03CR) 10Aaron Schulz: [C: 032] Automatically add a new line at the end of wfLogDBError() [core] - 10https://gerrit.wikimedia.org/r/120355 (owner: 10IAlex) [18:44:11] (03Merged) 10jenkins-bot: Allow interwiki searches to return arrays of interwiki results [core] - 10https://gerrit.wikimedia.org/r/119334 (owner: 10Chad) [18:45:48] (03Merged) 10jenkins-bot: Automatically add a new line at the end of wfLogDBError() [core] - 10https://gerrit.wikimedia.org/r/120355 (owner: 10IAlex) [18:48:35] (03PS5) 10Adi.iiita: Fixed padlock on thread history for LiquidThreads extension [extensions/LiquidThreads] - 10https://gerrit.wikimedia.org/r/118212 [18:52:14] (03PS14) 10EBernhardson: Make BoardHistory a Formatter instance [extensions/Flow] - 10https://gerrit.wikimedia.org/r/115532 [18:52:17] (03PS13) 10EBernhardson: Refactor Flow\\Formatter namespace [extensions/Flow] - 10https://gerrit.wikimedia.org/r/117384 [18:53:12] (03PS3) 10Siebrand: Update for code issues and usablity [extensions/BlockAndNuke] - 10https://gerrit.wikimedia.org/r/120476 (owner: 10MarkAHershberger) [18:55:58] (03CR) 10Siebrand: "PS3 reformats the code." [extensions/BlockAndNuke] - 10https://gerrit.wikimedia.org/r/120476 (owner: 10MarkAHershberger) [19:01:08] (03PS1) 10Deepali: Remove edit toolbar from the editing form [extensions/BookManagerv2] - 10https://gerrit.wikimedia.org/r/120573 [19:03:49] TimStarling, around? [19:04:13] TimStarling, when you have a chance, could you take a look at https://gerrit.wikimedia.org/r/#/c/109853/ [19:05:14] <^d> yurik: Doubt he's up, still super early morning there :) [19:05:37] ^d, thx, not sure what side of aus he is on [19:05:56] <^d> yurik: Eastern, somewhere north of Sydney. [19:06:05] i wonder who else might want to +2 it... [19:06:08] ^d? [19:06:12] :D [19:06:33] it has been siting in gerrit for the past month or two [19:07:49] <^d> Eww....calling ApiMain from a derivative request :( [19:08:02] <^d> Why not just use the SearchEngine subclass directly? [19:12:53] (03CR) 10Bartosz Dziewoński: "#loginend also appears in skins/monobook/main.css, let's be thorough." [core] - 10https://gerrit.wikimedia.org/r/120549 (owner: 10Gerrit Patch Uploader) [19:13:30] (03CR) 10Bartosz Dziewoński: [C: 04-1] "OOjs UI is an external library, this should be fixed upstream first." [core] - 10https://gerrit.wikimedia.org/r/120555 (owner: 10Gilles) [19:17:28] (03CR) 10TheDJ: "For future reference, Daniel was probably referring to Change Iee535a5359c03c52f6b72a95807258caf7ba60ae" [core] - 10https://gerrit.wikimedia.org/r/105207 (owner: 10Gerrit Patch Uploader) [19:25:19] (03PS1) 10Chad: Followup af4085a: reset $prev interwiki to null in between result sets [core] - 10https://gerrit.wikimedia.org/r/120580 [19:43:04] (03Abandoned) 10Jforrester: Syncronize VisualEditor: ec40953..6322ec3 [extensions] - 10https://gerrit.wikimedia.org/r/119689 (owner: 10Jenkins-mwext-sync) [19:51:11] ^d, i think this is because we have several different engines, and having just one place that handles all the complexities is a "good thing" :) [19:51:31] (03CR) 10Anomie: [C: 04-1] "-1 because of the behavior change." (0314 comments) [core] - 10https://gerrit.wikimedia.org/r/106517 (owner: 10Daniel Kinzler) [19:54:17] <^d> yurik: You shouldn't care about the engine. [19:54:23] <^d> That's what SearchEngine::create() is for. [19:54:28] <^d> It'll return the one you want. [19:54:36] ^d yes, but there are multiple ones [19:54:49] <^d> What's your point? [19:55:14] i just don't want to duplicate code in api [19:55:18] i will take a look again [19:55:29] maybe i missed something when designing it [19:56:12] <^d> Well it's not a matter of duplication, just using the appropriate classes. [19:56:30] <^d> When you delegate to ApiMain, you get all the (mostly pointless) overhead from setting up the Api. [19:56:34] <^d> (Which we don't want :)) [19:56:58] (03CR) 10Daniel Friesen: "No, I was referring to a past discussion on this topic where someone pointed out that applying border-box blindly to every textarea causes" [core] - 10https://gerrit.wikimedia.org/r/105207 (owner: 10Gerrit Patch Uploader) [19:59:22] (03PS1) 10Kaldari: Adding function documentation for Skin::footerLink() [core] - 10https://gerrit.wikimedia.org/r/120588 [20:01:25] (03CR) 10Bartosz Dziewoński: Adding function documentation for Skin::footerLink() (031 comment) [core] - 10https://gerrit.wikimedia.org/r/120588 (owner: 10Kaldari) [20:10:45] (03PS2) 10Faidon Liambotis: Dump corefiles on segfaults [integration/jenkins] - 10https://gerrit.wikimedia.org/r/119222 [20:18:47] (03CR) 10Umherirrender: "The check maybe should moved up into the parent and only be done, when a default is set." [core] - 10https://gerrit.wikimedia.org/r/120313 (owner: 10Umherirrender) [20:22:02] (03CR) 10AndyRussG: "Putting some notes here:" [extensions/Campaigns] (wip/editorcampaigns) - 10https://gerrit.wikimedia.org/r/116221 (owner: 10AndyRussG) [20:22:39] StevenW: are you in the office today? I had a general MW feature question... [20:22:48] Not yet [20:22:49] (03CR) 10Hashar: "Is composer available as a source distribution like phpunit/phpcs ? Then we could ship it under integration/composer.git and use puppet g" [integration/jenkins] - 10https://gerrit.wikimedia.org/r/120517 (owner: 10Tobias Gritschacher) [20:22:51] what's up? [20:23:18] StevenW: it can wait. But, I'm curious to know if anyone has written a feature to allow per-word annotation of wiki content, a la google drive... [20:23:34] (03PS1) 10Ori.livneh: [WIP] Add Cirrus performance logging [extensions/WikimediaEvents] - 10https://gerrit.wikimedia.org/r/120592 [20:23:37] (03CR) 10jenkins-bot: [V: 04-1] [WIP] Add Cirrus performance logging [extensions/WikimediaEvents] - 10https://gerrit.wikimedia.org/r/120592 (owner: 10Ori.livneh) [20:24:26] (03PS2) 10Ori.livneh: [WIP] Add Cirrus performance logging [extensions/WikimediaEvents] - 10https://gerrit.wikimedia.org/r/120592 [20:24:28] (03CR) 10jenkins-bot: [V: 04-1] [WIP] Add Cirrus performance logging [extensions/WikimediaEvents] - 10https://gerrit.wikimedia.org/r/120592 (owner: 10Ori.livneh) [20:25:12] (03PS3) 10Ori.livneh: [WIP] Add Cirrus performance logging [extensions/WikimediaEvents] - 10https://gerrit.wikimedia.org/r/120592 [20:26:06] awight: Yes. [20:26:17] (03CR) 10Manybubbles: [C: 032] Followup af4085a: reset $prev interwiki to null in between result sets [core] - 10https://gerrit.wikimedia.org/r/120580 (owner: 10Chad) [20:26:23] See https://www.mediawiki.org/wiki/Extension:Annotator [20:26:26] awight: ^ [20:26:29] StevenW: thx [20:28:13] StevenW: We have a use case for adding something like this to Translation. Also, I wouldn't mind reviving a CR component like Special:Code, but better. [20:29:59] (03Merged) 10jenkins-bot: Followup af4085a: reset $prev interwiki to null in between result sets [core] - 10https://gerrit.wikimedia.org/r/120580 (owner: 10Chad) [20:30:19] StevenW: awesome, the Annotator code base is really compact. [20:30:47] Thank the GSOC student and superm401 for that [20:30:48] :) [20:31:31] awight, yeah, rjain did a great job, but it also leverages a nice library from OKFN. [20:31:35] ^ StevenW [20:31:47] https://github.com/okfn/annotator/ [20:33:48] (03CR) 10Hashar: "Go for it!! :-]" [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/116136 (owner: 10Krinkle) [20:33:54] (03CR) 10Hashar: [C: 031] Enable mediawiki-core-npm (runs jshint+jscs), disable mediawiki-core-jslint [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/116136 (owner: 10Krinkle) [20:35:50] superm401: yes, I like it. The demo is a bit clunky though, I can't tell if it's actually being used anywhere but annotateit.org [20:36:48] (03CR) 10Hashar: [C: 032] "Sorry I lagged out. Lets deploy this, as I understand it the kernel drop the core files in the current working directory which is the job" [integration/jenkins] - 10https://gerrit.wikimedia.org/r/119222 (owner: 10Faidon Liambotis) [20:36:52] (03Merged) 10jenkins-bot: Dump corefiles on segfaults [integration/jenkins] - 10https://gerrit.wikimedia.org/r/119222 (owner: 10Faidon Liambotis) [20:37:27] awight, I think so. See https://github.com/okfn/annotator/wiki . Our demo is at http://annotator.wmflabs.org/wiki/Main_Page BTW. You have to click 'View annotations' to see or add annotations (that part of the UI needs a little work) [20:38:39] superm401: really exciting! [20:38:54] :) [20:40:06] superm401: the specific thing that's bothering me is the unpredictable behavior once you've popped open a comment. Rolling over and out of various things sometimes hides the previous bubble, and sometimes not. [20:40:52] awight, in what case does it not disappear? [20:41:00] superm401: If I get ambitions, should I file bugs? [20:41:09] (03PS2) 10Kaldari: Adding function documentation for Skin::footerLink() [core] - 10https://gerrit.wikimedia.org/r/120588 [20:41:12] Also, when you say 'popped open', do you mean starting a new comment or viewing an old one? [20:41:20] superm401: it won't disappear if you roll over another annotated selection. [20:41:25] viewing an old one. [20:41:51] awight, you're welcome to file, but bear in mind no one is actively working on that I know of. [20:42:06] Also, some bugs may be fixed in upstream (the actual annotator library), but not synced to the extension. [20:42:16] superm401: nah, I tested on the upstream demo [20:42:33] also, resizing the comment box has some bad behaviors. [20:43:00] awight, oh, okay. Yeah, if it's upstream too, file at https://github.com/okfn/annotator/issues/ . [20:43:10] yep, makes sense. [20:44:05] awight, when I said 'no one is actively working', I just meant the extension, to clarify. And actually, even that's not totally true. [20:44:14] no brion today? [20:44:37] Gabriel Birke has submitted a couple patches, and we actually owe a review on one of them: https://gerrit.wikimedia.org/r/#/q/status:open+project:mediawiki/extensions/Annotator,n,z [20:44:41] The other he needs to update. [20:45:18] awight, upstream seems to be moving alone nicely: https://github.com/okfn/annotator/commits/master [20:45:18] s/alone/along [20:46:10] (03PS28) 10Hashar: Added password hashing API [core] - 10https://gerrit.wikimedia.org/r/77645 (owner: 10Parent5446) [20:48:01] awight, I think https://github.com/okfn/annotator/commit/1e48cbe11378cec6403bc555c0a85b90f9e971bf fixes one of the bugs you were talking about. [20:51:23] (03PS11) 10UltrasonicNXT: WIP - Rewrite [extensions/WikiForum] - 10https://gerrit.wikimedia.org/r/116258 [20:53:00] (03CR) 10jenkins-bot: [V: 04-1] Added password hashing API [core] - 10https://gerrit.wikimedia.org/r/77645 (owner: 10Parent5446) [21:00:29] hashar: I've been holding off on the npm job for core for performance reasons. The macro-scm refactor made it tolerable [21:00:37] (git clean everywhere, never wipe workspace) [21:01:07] though that was already the default for mwcore, we couldn't use that macro in labs as it also depended on gerrit replag [21:01:42] Krinkle: hey, i'm poking at the rc feeds stuff, are you familiar with how its implemented? My initial thought is an RCFeedDelegatingFormatter which accepts a map of rc_type => RCFeedFormatter instance. [21:02:13] (03PS1) 10Faidon Liambotis: Bump ulimit max size for corefiles [integration/jenkins] - 10https://gerrit.wikimedia.org/r/120597 [21:02:15] hashar: ^ [21:02:22] csteipp: ^^ btw, we got a corefile already [21:03:35] Krinkle: but ... seeing as how they are instantiated on demand from RecentChange::notifyRCFeeds it seems wastefull to instantiate as needed. Generally the whole part of a feed specifying what formatter it wants seems problematic for extensions formatting custom rc in their own way ... so i'm not sure which direction to go [21:03:37] paravoid: I saw it... At the moment, gdb is saying it's truncated. I'll debug after this meeting [21:04:55] csteipp: yes, I had the limit set to the arbitrary 64M, the changeset above raises it to 2G [21:05:03] gdb says >= 650M, so... [21:05:14] ah, I forgot you had that. Cool. [21:05:20] ebernhardson: what do you mean by rc feeds stuff, in context of what? [21:05:26] what project [21:05:47] Krinkle: https://bugzilla.wikimedia.org/show_bug.cgi?id=61927 [21:05:55] Krinkle: basically your complaint that flow rc feed entrys in irc are cap [21:05:56] s/cap/crap [21:05:57] (03CR) 10Welterkj: "In April 2013, Bawolff added the following tag to the GraphViz extension page:" [extensions/GraphViz] - 10https://gerrit.wikimedia.org/r/111475 (owner: 10Welterkj) [21:06:53] Krinkle: our entrys use the rc_type field to distinguish themselves, so the natural solution seems to be to allow flow to implement a formatter that gets called when rc_type is matching [21:07:41] but the formatters arn't really separated like that, they are separated by purpose(irc,json,etc) rather than by source(core revision, flow, etc) [21:08:52] ebernhardson: Can you zoom out a bit? What is the end feature or bug the formatter would do? The rc feed's default formatter should be good enough. It's only used by machines nowadays. It's our one, only, already legacy, rc push notification feed (irc.wikimedia, right?) [21:08:57] Or is this for RecentChanges API.php? [21:09:21] (03CR) 10Adamw: [C: 04-1] "Only -1'ing for typos." (032 comments) [extensions/Annotator] - 10https://gerrit.wikimedia.org/r/110378 (owner: 10Chiborg) [21:10:29] Krinkle: the end feature is for you to not think the rc feed output of flow is crap :) [21:10:38] Krinkle: since you filed the ticket :) [21:11:09] first step is replacing the output URL, beyond that not entirely sure [21:12:53] Krinkle: the reason that doesn't work with the current formatter is that the current formatter makes the assumption its either a log entry or a core revision, with no wiggle room for alternate things like flow [21:13:14] ebernhardson: Ah, it's that one. [21:13:20] Okay, now I know what you're talking about :) [21:13:20] imo, log entrys, core revisions, and flow should all be independantly formatted, but we arn't reinventing that part now :) [21:14:24] i could just add another hook to override the url, but that feels like a worse hack [21:14:51] Changing the formatter wouldn't be the path I'd recommend you take as right now the only thing keeping the rc feed from breaking bots everywhere is the fact that there is 1 semi sane thing about it: The format is consistent regardless of all the insane factors (like using i18n messages as log formatter, that can still be machine read, ask me why in person and you'll cry once you know). [21:15:15] Instead it should, if at all possible, provide sensible values to those fiels (e.g don't put json data in the field for edit summary) [21:15:29] Krinkle: that was only there because of checkuser :P [21:15:38] I'm not saying it's doing that on purpose, I understand the complexity. [21:15:43] It's all very messy [21:15:48] and that's core's fault [21:16:04] the problem is .. i cant put our data in the fields [21:16:25] like rc_oldid=rrkm6yhfgqh24u1r [21:16:38] that wont be accepted by the database, nor will the numeric representation(its 88bits) [21:16:49] I think it'd be most productive to sit down for a few minutes and just settle on a compromise. I don't have a good solution (I would've given it on the bug), all I know is that irc.wikimedia is crap but very vital and crucial to our countervandalism infrastructure, and we need to find a way to have it not break and work with that existing readers of that format. [21:17:18] ok [21:17:23] the only thing it should get in the expected place is username, timestamp, and url to the diff or created item, and the edit summary if any [21:17:37] the rest could be null or absent even [21:17:59] hmm, we have auto-edit summarys but they can't be put into a database field due to moderation :S i will have to poke at it some more [21:18:08] anything else is just random data points pretty much everything ignores as padding an known fields between irc color codes. [21:18:14] :) [21:18:56] auto summaries can be left out of it, that's fine. I mean it has to be able to read manually entered ones [21:19:08] so that cvn can match them against spam filters and watch words. [21:19:20] ahh, ok. makes sense. [21:19:29] superm401 or anyone: for labs -> eqiad, have you been creating new instances or asking ops to migrate? [21:19:34] and if those don't exist in flow (I imagine it doesn't have many edit summaries, except maybe when editing a post) [21:19:41] ebernhardson: You in the office? [21:19:46] Krinkle: yea, you are? [21:19:52] * ebernhardson assumed you were overseas [21:19:54] I'm visiting for a few weeks, I just arrived last Saturday [21:20:07] I'm sitting in the VE corner. [21:20:16] ok, i'll stop by in a minute [21:30:14] Krinkle: https://bugzilla.wikimedia.org/show_bug.cgi?id=61927 [21:31:50] (03PS1) 10TheDJ: Revert "Remove unneeded show() in WikiEditor toolbar" [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/120599 [21:32:26] (03CR) 10TheDJ: [C: 032] Revert "Remove unneeded show() in WikiEditor toolbar" [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/120599 (owner: 10TheDJ) [21:32:29] (03Merged) 10jenkins-bot: Revert "Remove unneeded show() in WikiEditor toolbar" [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/120599 (owner: 10TheDJ) [21:34:27] (03CR) 10TheDJ: "Reverted in https://gerrit.wikimedia.org/r/120599" [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/118992 (owner: 10TheDJ) [21:38:33] paravoid: thanks [21:39:13] (03CR) 10Hashar: [C: 032] Bump ulimit max size for corefiles [integration/jenkins] - 10https://gerrit.wikimedia.org/r/120597 (owner: 10Faidon Liambotis) [21:39:17] (03Merged) 10jenkins-bot: Bump ulimit max size for corefiles [integration/jenkins] - 10https://gerrit.wikimedia.org/r/120597 (owner: 10Faidon Liambotis) [21:44:38] ebernhardson: http://test2.wikipedia.org/w/api.php?format=jsonfm&action=query&list=recentchanges [21:48:15] (03PS11) 10Bsitu: Closing & Summarizing topic frontend changes [extensions/Flow] - 10https://gerrit.wikimedia.org/r/119640 [21:51:14] (03CR) 10Bsitu: "Addressed most of the comments, the following is not done yet:" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/119640 (owner: 10Bsitu) [21:54:46] (03CR) 10Mattflaschen: "Yep, good catch Steven. I added Bartosz and Siebrand, and pinged Bartosz." [extensions/GuidedTour] - 10https://gerrit.wikimedia.org/r/119261 (owner: 10Phuedx) [21:59:17] (03CR) 10Siebrand: [C: 032] Update the firstedit tour's copy [extensions/GuidedTour] - 10https://gerrit.wikimedia.org/r/119261 (owner: 10Phuedx) [21:59:21] (03CR) 10Mattflaschen: "Bartosz said it's not necessarily for Polish, but might be for Semitic languages. Let's wait a bit for Siebrand, then if he doesn't get t" [extensions/GuidedTour] - 10https://gerrit.wikimedia.org/r/119261 (owner: 10Phuedx) [21:59:48] (03CR) 10Bartosz Dziewoński: [C: 04-2] Update the firstedit tour's copy [extensions/GuidedTour] - 10https://gerrit.wikimedia.org/r/119261 (owner: 10Phuedx) [22:00:26] polarised [22:01:09] (03CR) 10Bartosz Dziewoński: "I blocked the +2 until someone who knows the language can confirm if I'm reading https://en.wikipedia.org/wiki/Imperative_mood#Hebrew_and_" [extensions/GuidedTour] - 10https://gerrit.wikimedia.org/r/119261 (owner: 10Phuedx) [22:02:01] (03Abandoned) 10Raimond Spekking: Localisation updates from https://translatewiki.net. [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/120601 (owner: 10L10n-bot) [22:02:17] (03Abandoned) 10Raimond Spekking: Localisation updates from https://translatewiki.net. [extensions/AccountInfo] - 10https://gerrit.wikimedia.org/r/120602 (owner: 10L10n-bot) [22:02:22] (03Abandoned) 10Raimond Spekking: Localisation updates from https://translatewiki.net. [extensions/AJAXPoll] - 10https://gerrit.wikimedia.org/r/120603 (owner: 10L10n-bot) [22:02:26] (03Abandoned) 10Raimond Spekking: Localisation updates from https://translatewiki.net. [extensions/ApiSandbox] - 10https://gerrit.wikimedia.org/r/120604 (owner: 10L10n-bot) [22:02:31] (03Abandoned) 10Raimond Spekking: Localisation updates from https://translatewiki.net. [extensions/ArticleFeedbackv5] - 10https://gerrit.wikimedia.org/r/120605 (owner: 10L10n-bot) [22:02:36] (03Abandoned) 10Raimond Spekking: Localisation updates from https://translatewiki.net. [extensions/BatchUserRights] - 10https://gerrit.wikimedia.org/r/120606 (owner: 10L10n-bot) [22:02:40] (03Abandoned) 10Raimond Spekking: Localisation updates from https://translatewiki.net. [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/120608 (owner: 10L10n-bot) [22:02:45] (03Abandoned) 10Raimond Spekking: Localisation updates from https://translatewiki.net. [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/120609 (owner: 10L10n-bot) [22:04:57] ori, MatmaRex suggested that https://gerrit.wikimedia.org/r/#/c/119261/1/GuidedTour.i18n.php may require {{GENDER}} in Hebrew. [22:05:01] Could you weigh in, please? [22:05:23] I would CC mooeypoo if she were in here! [22:05:37] yeah, i added her and amir on the changeset [22:05:45] but neither seems to be in here [22:05:56] She's in the office, so all else fails I'll throw things at her [22:06:34] Nor is aharoni [22:08:22] He's not in the office sadlyf [22:08:33] sadly even [22:09:17] (03PS1) 10Gilles: Add ?download parameter to images [vagrant] - 10https://gerrit.wikimedia.org/r/120614 [22:12:07] (03PS2) 10Mattflaschen: Have ?download parameter trigger Content-Disposition: Attachment [vagrant] - 10https://gerrit.wikimedia.org/r/120614 (owner: 10Gilles) [22:12:09] (03CR) 10Jforrester: Update the firstedit tour's copy (031 comment) [extensions/GuidedTour] - 10https://gerrit.wikimedia.org/r/119261 (owner: 10Phuedx) [22:25:22] (03PS3) 10Bsitu: edit topic summary no javascript support [extensions/Flow] - 10https://gerrit.wikimedia.org/r/120485 [22:26:16] hi csteipp do you have a couple minutes for a fishing expedition about some code that handles cookies and sessions? I have a bit of a mystery with some MobileFrontend code, I'm looking for opinions. [22:30:05] (03PS1) 10Parent5446: Fix JavaScript to be jslint compliant [extensions/Persona] - 10https://gerrit.wikimedia.org/r/120684 [22:30:18] (03CR) 10jenkins-bot: [V: 04-1] edit topic summary no javascript support [extensions/Flow] - 10https://gerrit.wikimedia.org/r/120485 (owner: 10Bsitu) [22:30:43] (03CR) 10jenkins-bot: [V: 04-1] Fix JavaScript to be jslint compliant [extensions/Persona] - 10https://gerrit.wikimedia.org/r/120684 (owner: 10Parent5446) [22:30:56] (03CR) 10Swalling: Update the firstedit tour's copy (031 comment) [extensions/GuidedTour] - 10https://gerrit.wikimedia.org/r/119261 (owner: 10Phuedx) [22:34:27] chrismcmahon: Sure [22:34:49] csteipp: this snippet: http://pastebin.com/CMPk6xhv [22:36:03] csteipp: when running automated browser tests, the if() statement on line 5 in the snippet sometimes evaluates to true, which shouldn't ever happen. [22:36:05] (03PS2) 10Parent5446: Fix JavaScript to be jslint compliant [extensions/Persona] - 10https://gerrit.wikimedia.org/r/120684 [22:36:10] (03CR) 10jenkins-bot: [V: 04-1] Fix JavaScript to be jslint compliant [extensions/Persona] - 10https://gerrit.wikimedia.org/r/120684 (owner: 10Parent5446) [22:36:36] chrismcmahon: This is in Ex:MobileFrontend? [22:37:49] csteipp: yes, in Ex:MobileFrontend, so the token in $context and the token in $request are for a brief moment not equal. oddly, the issue is seen in both Firefox and Chrome but so far only on Linux and not on Macs [22:37:50] found it.. looking at it in context [22:38:50] csteipp: I have not reproduced it manually. we have a bug for it at https://bugzilla.wikimedia.org/show_bug.cgi?id=62614 . [22:41:29] chrismcmahon: Where are the test for that defined? Is that in the browsertest repo? [22:41:35] csteipp: I wonder if there is even a chance that something on the client/browser side could be mis-handling cookies/sessions; or if some new beta labs config is causing a fast race condition. [22:41:58] chrismcmahon: It could be. Is this only happening recently? [22:42:03] And only on beta? [22:43:16] csteipp: yes, seen often in /MobileFrontend/tests/browser/features/mainmenu.feature, seen on beta labs, almost exactly coinciding with the move to eqiad. I see it in the Jenkins runs and also see it when running the tests on my laptop against beta labs. [22:44:06] csteipp: but the Mobile guys all run Macs in SF and they can't reproduce the issue, so far only Linux and far away from SF [22:44:48] Hmm. They may have moved to replicated redis for the migration. Is this all hitting one domain, or many? [22:45:51] csteipp: the browser targets are all en.m.wikipedia.beta.wmflabs.org, no other domains showing the issue. [22:45:55] (03PS3) 10Parent5446: Fix JavaScript to be jslint compliant [extensions/Persona] - 10https://gerrit.wikimedia.org/r/120684 [22:45:58] (03CR) 10jenkins-bot: [V: 04-1] Fix JavaScript to be jslint compliant [extensions/Persona] - 10https://gerrit.wikimedia.org/r/120684 (owner: 10Parent5446) [22:46:01] What's in the @ files? I haven't used that syntax... is that the wikiurl? [22:46:27] csteipp: just tags for the Jenkins runs, nothing to do with code [22:47:23] (03PS4) 10Parent5446: Fix JavaScript to be jslint compliant [extensions/Persona] - 10https://gerrit.wikimedia.org/r/120684 [22:47:26] (03CR) 10jenkins-bot: [V: 04-1] Fix JavaScript to be jslint compliant [extensions/Persona] - 10https://gerrit.wikimedia.org/r/120684 (owner: 10Parent5446) [22:48:07] (03PS5) 10Parent5446: Fix JavaScript to be jslint compliant [extensions/Persona] - 10https://gerrit.wikimedia.org/r/120684 [22:48:57] (03PS6) 10Parent5446: Fix JavaScript to be jslint compliant [extensions/Persona] - 10https://gerrit.wikimedia.org/r/120684 [22:49:30] csteipp: the crux of the mystery for me is how "if ( $request->getVal( 'token' ) != $context->getMobileToken() )" could ever be true. once a browser clicks the on/off toggle at http://en.m.wikipedia.beta.wmflabs.org/w/index.php?title=Special:MobileOptions, those tokens should match [22:50:53] Can you grab the headers that are actually being sent/set during the test? [22:51:12] (03CR) 10Parent5446: [C: 032] Fix JavaScript to be jslint compliant [extensions/Persona] - 10https://gerrit.wikimedia.org/r/120684 (owner: 10Parent5446) [22:51:24] (03Merged) 10jenkins-bot: Fix JavaScript to be jslint compliant [extensions/Persona] - 10https://gerrit.wikimedia.org/r/120684 (owner: 10Parent5446) [22:51:58] (03PS1) 10Hashar: refreshCdbJsonFiles: PHP parse error [tools/scap] - 10https://gerrit.wikimedia.org/r/120692 [22:52:16] csteipp: not sure, I haven't tried. I might have set up WireShark or something to do it [22:52:18] (03CR) 10Hashar: "Had a PHP fatal error: https://gerrit.wikimedia.org/r/120692" [tools/scap] - 10https://gerrit.wikimedia.org/r/119955 (owner: 10Hashar) [22:52:26] (03CR) 10Hashar: [C: 032] refreshCdbJsonFiles: PHP parse error [tools/scap] - 10https://gerrit.wikimedia.org/r/120692 (owner: 10Hashar) [22:52:31] Yeah, wireshark would work [22:52:37] (03Merged) 10jenkins-bot: refreshCdbJsonFiles: PHP parse error [tools/scap] - 10https://gerrit.wikimedia.org/r/120692 (owner: 10Hashar) [22:52:53] Or any other proxy that understands http [22:53:03] (03CR) 10BryanDavis: "+1 Antoine beat me to the patch and merge." [tools/scap] - 10https://gerrit.wikimedia.org/r/120692 (owner: 10Hashar) [22:53:49] (03PS6) 10Parent5446: Disable Persona button in browsers that do not have Javascript [extensions/Persona] - 10https://gerrit.wikimedia.org/r/120502 (owner: 10Jatin) [22:53:51] So yeah, either the user doesn't have a session, wsMobileToken in the session is getting overwritten, or the form isn't correctly sending the token [22:53:59] (03CR) 10Parent5446: "PS6: Rebase" [extensions/Persona] - 10https://gerrit.wikimedia.org/r/120502 (owner: 10Jatin) [22:54:58] (03Abandoned) 10Jforrester: Fixes bug where InlineMenuWidget would "steal" DOM labels on selection [core] - 10https://gerrit.wikimedia.org/r/120555 (owner: 10Gilles) [22:56:29] (03CR) 10Parent5446: [C: 04-1] "Minor style issues. Otherwise looks good." (032 comments) [extensions/Persona] - 10https://gerrit.wikimedia.org/r/120502 (owner: 10Jatin) [22:56:32] (03CR) 10EBernhardson: "other repositories run the php linter, could this one too? Since not everything has the .php extension it would probably have to use the " [tools/scap] - 10https://gerrit.wikimedia.org/r/120692 (owner: 10Hashar) [23:00:38] (03PS1) 10EBernhardson: Update IRCLineURL hook to include RecentChange object [core] - 10https://gerrit.wikimedia.org/r/120695 [23:03:07] chrismcmahon: What env variables do you have to set to reproduce this? I'm trying with MEDIAWIKI_URL=en.m.wikipedia.beta.wmflabs.org, and totally fails. [23:03:27] MEDIAWIKI_URL=en.m.wikipedia.beta.wmflabs.org/wiki/ [23:03:29] (03PS2) 10EBernhardson: Update IRCLineURL hook to include RecentChange object [core] - 10https://gerrit.wikimedia.org/r/120695 [23:03:46] csteipp: you need the /wiki/ at the end. you don't need to log in [23:04:12] Ah, better. Thanks [23:04:20] actually csteipp MEDIAWIKI_URL=http://en.m.wikipedia.beta.wmflabs.org/wiki/ (you need the 'http://' also) [23:04:37] (03CR) 10Parent5446: Implement listing for tracking categories (031 comment) [core] - 10https://gerrit.wikimedia.org/r/112323 (owner: 10Kunalgrover05) [23:04:56] csteipp: I hear all the caches on beta are re-starting right now, so might be slow [23:05:06] Yeah, no joke... [23:05:08] (03PS1) 10Kaldari: Always render copyright notice in user language [core] - 10https://gerrit.wikimedia.org/r/120696 [23:05:19] (03PS1) 10Aude: Update Wikidata [core] (wmf/1.23wmf19) - 10https://gerrit.wikimedia.org/r/120697 [23:06:19] chrismcmahon: Yeah, times out for me. So the thing is to narrow down which of those 3 is happening. A header capture of a failure would help determine that. [23:07:45] (03CR) 10Hashar: "I guess find / file / xargs php -l would do the job indeed. If you can come up with the shell commands to have it happen I will be more th" [tools/scap] - 10https://gerrit.wikimedia.org/r/120692 (owner: 10Hashar) [23:09:02] (03CR) 10Hoo man: [C: 031] Update Wikidata [core] (wmf/1.23wmf19) - 10https://gerrit.wikimedia.org/r/120697 (owner: 10Aude) [23:11:03] (03CR) 10Ori.livneh: [C: 032] Update Wikidata [core] (wmf/1.23wmf19) - 10https://gerrit.wikimedia.org/r/120697 (owner: 10Aude) [23:12:11] (03CR) 10Parent5446: [C: 04-1] Add a PSR-3 based logging interface (034 comments) [core] - 10https://gerrit.wikimedia.org/r/119940 (owner: 10BryanDavis) [23:14:49] (03Merged) 10jenkins-bot: Update Wikidata [core] (wmf/1.23wmf19) - 10https://gerrit.wikimedia.org/r/120697 (owner: 10Aude) [23:15:47] (03CR) 10Parent5446: [C: 04-1] Enable MWLogger logging for legacy logging methods (031 comment) [core] - 10https://gerrit.wikimedia.org/r/119941 (owner: 10BryanDavis) [23:18:35] (03CR) 10Parent5446: "Why has the parameter not just been removed entirely? This patch already makes it so that the parameter does nothing." [core] - 10https://gerrit.wikimedia.org/r/120696 (owner: 10Kaldari) [23:24:14] (03CR) 10Kaldari: "Parent5446: If I go ahead and remove the parameter here before it is removed from hook handlers it will cause an error. The reverse is fin" [core] - 10https://gerrit.wikimedia.org/r/120696 (owner: 10Kaldari) [23:34:00] (03PS1) 10Gilles: Have ?download parameter trigger Content-Disposition: Attachment for thumbs [core] - 10https://gerrit.wikimedia.org/r/120703 [23:34:34] (03CR) 10CSteipp: [C: 032] Optionally place a local block when globally blocking [extensions/GlobalBlocking] - 10https://gerrit.wikimedia.org/r/119915 (owner: 10Hoo man) [23:34:57] Yay \o/ [23:35:04] (03Merged) 10jenkins-bot: Optionally place a local block when globally blocking [extensions/GlobalBlocking] - 10https://gerrit.wikimedia.org/r/119915 (owner: 10Hoo man) [23:35:49] (03PS20) 10Jdlrobson: Rewrite the navigation links under the heading [extensions/VectorBeta] - 10https://gerrit.wikimedia.org/r/117903 [23:41:18] (03PS13) 10Krinkle: Set up node-jscs via Grunt (and pass it) [core] - 10https://gerrit.wikimedia.org/r/111963 [23:43:50] (03CR) 10Krinkle: "Passed: https://integration.wikimedia.org/ci/job/mediawiki-core-npm/11" [core] - 10https://gerrit.wikimedia.org/r/111963 (owner: 10Krinkle) [23:44:03] (03PS2) 10Krinkle: [WIP] jshint: Enable 'es3' option [core] - 10https://gerrit.wikimedia.org/r/116527 [23:44:19] (03PS5) 10Krinkle: jquery.color.test: Use fake timers [core] - 10https://gerrit.wikimedia.org/r/117150 [23:44:23] (03PS4) 10Krinkle: jquery.makeCollapsible.test: Use fake timers to advance animations [core] - 10https://gerrit.wikimedia.org/r/117153 [23:45:31] (03PS1) 10Bsitu: Replace generic "Internal error - {{SITENAME}}" on error page [extensions/Flow] - 10https://gerrit.wikimedia.org/r/120708 [23:47:17] (03PS21) 10Jdlrobson: Rewrite the navigation links under the heading [extensions/VectorBeta] - 10https://gerrit.wikimedia.org/r/117903 [23:47:33] (03CR) 10jenkins-bot: [V: 04-1] Replace generic "Internal error - {{SITENAME}}" on error page [extensions/Flow] - 10https://gerrit.wikimedia.org/r/120708 (owner: 10Bsitu) [23:48:55] ori: "irc.wikimedia.org| Closing Link: anonymous.user ()" [23:49:02] I thought for a second it was using a deprecated function [23:49:03] xD [23:49:17] (03CR) 10Kaldari: [C: 032] Rewrite the navigation links under the heading [extensions/VectorBeta] - 10https://gerrit.wikimedia.org/r/117903 (owner: 10Jdlrobson) [23:49:19] heheh [23:49:22] (03Merged) 10jenkins-bot: Rewrite the navigation links under the heading [extensions/VectorBeta] - 10https://gerrit.wikimedia.org/r/117903 (owner: 10Jdlrobson) [23:49:37] (03PS17) 10Jdlrobson: Give Vector/Winter Minerva's hamburger menu icon [extensions/VectorBeta] - 10https://gerrit.wikimedia.org/r/117927 [23:49:45] mw.user.anonymous > mw.user.isAnon [23:49:50] oh well [23:50:38] Krinkle: do WMF ips give the hostmask "special.user" ? [23:50:44] (03PS2) 10Bsitu: Replace the generic "Internal error - {{SITENAME}}" on error page [extensions/Flow] - 10https://gerrit.wikimedia.org/r/120708 [23:50:59] (03CR) 10jenkins-bot: [V: 04-1] Replace the generic "Internal error - {{SITENAME}}" on error page [extensions/Flow] - 10https://gerrit.wikimedia.org/r/120708 (owner: 10Bsitu) [23:52:12] huh: I have no idea, the confusion continued even after I realised it obviously wasn't some kind of reversed javascript identifier [23:52:26] (03PS1) 10Aude: Update Wikidata, fix OutputPageBeforeHtml hook [core] (wmf/1.23wmf19) - 10https://gerrit.wikimedia.org/r/120710 [23:52:28] Are we like hiding IPs from irc.wikimedia.org consumers? [23:52:41] Kinda neat, but thought anyone bothered to do something like that. [23:52:49] didn't [23:52:50] Yes. [23:52:53] (03CR) 10Ori.livneh: [C: 032] Update Wikidata, fix OutputPageBeforeHtml hook [core] (wmf/1.23wmf19) - 10https://gerrit.wikimedia.org/r/120710 (owner: 10Aude) [23:53:13] the hostmasks are all "anonymous.user" or "special.user" [23:53:31] I think WMF (and Labs IPs) give "special.user" [23:53:33] Maybe TS too [23:54:18] Wait, you weren't kidding? [23:54:23] (03CR) 10Catrope: [V: 032] Update Wikidata, fix OutputPageBeforeHtml hook [core] (wmf/1.23wmf19) - 10https://gerrit.wikimedia.org/r/120710 (owner: 10Aude) [23:54:30] *** Processing connection to irc.pmtpa.wikimedia.org [23:54:35] hmpf hmpf eqiad :) [23:54:37] (03CR) 10jenkins-bot: [V: 04-1] [WIP] jshint: Enable 'es3' option [core] - 10https://gerrit.wikimedia.org/r/116527 (owner: 10Krinkle) [23:54:57] Kidding about what? [23:55:21] huh: "special.user" [23:56:03] huh: wm-bot and CVNBot/KrinkleBot (Tool labs and WMF Labs) are both "anonymous.user" in #commons.wikimedia and #n.wikipedia) [23:56:06] nl.wikipedia* [23:56:20] hm [23:56:28] maybe only rc-pmtpa is special.user [23:56:43] (03PS6) 10Werdna: Anonymous editor warning. Now with links to log in and register. [extensions/Flow] - 10https://gerrit.wikimedia.org/r/117846 [23:58:09] (03PS1) 10Catrope: Update VisualEditor for cherry-pick [core] (wmf/1.23wmf19) - 10https://gerrit.wikimedia.org/r/120712 [23:58:26] (03CR) 10Werdna: Anonymous editor warning. Now with links to log in and register. (032 comments) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/117846 (owner: 10Werdna) [23:58:50] Krinkle: is only rc-pmtpa special? [23:59:01] (03CR) 10Werdna: "PS6: Address Matthias' feedback and style links as white w/ underline." [extensions/Flow] - 10https://gerrit.wikimedia.org/r/117846 (owner: 10Werdna) [23:59:08] (03PS1) 10Catrope: Update VisualEditor for cherry-pick [core] (wmf/1.23wmf18) - 10https://gerrit.wikimedia.org/r/120713 [23:59:18] (03CR) 10Catrope: [C: 032 V: 032] Update VisualEditor for cherry-pick [core] (wmf/1.23wmf18) - 10https://gerrit.wikimedia.org/r/120713 (owner: 10Catrope) [23:59:20] huh: I guess [23:59:28] (03CR) 10Catrope: [C: 032 V: 032] Update VisualEditor for cherry-pick [core] (wmf/1.23wmf19) - 10https://gerrit.wikimedia.org/r/120712 (owner: 10Catrope) [23:59:30] huh: Interesting, channel info is public on whois [23:59:36] even for channels I'm not in [23:59:37] (03PS2) 10JGonera: Use Agora oojs-ui theme on mobile [core] - 10https://gerrit.wikimedia.org/r/120165 [23:59:39] (03PS1) 10JGonera: Update OOjs UI to v0.1.0-pre (9df7af96c2) [core] - 10https://gerrit.wikimedia.org/r/120715 [23:59:42] yes [23:59:43] hey Krinkle, wassup