[00:05:31] (03PS2) 10Legoktm: Added tabindex to MassMessage form elements [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/119929 (owner: 10Tinaj1234) [00:06:08] (03CR) 10Legoktm: [C: 032] "Works perfectly, thanks!" [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/119929 (owner: 10Tinaj1234) [00:06:15] (03Merged) 10jenkins-bot: Added tabindex to MassMessage form elements [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/119929 (owner: 10Tinaj1234) [00:27:14] (03PS1) 10Siebrand: Declare visibility on class properties of SpecialUndelete [core] - 10https://gerrit.wikimedia.org/r/120331 [00:27:16] (03PS1) 10Siebrand: Declare visibility on class properties of SpecialRevisionDelete [core] - 10https://gerrit.wikimedia.org/r/120332 [00:38:29] (03PS1) 10Legoktm: Add links to Global CSS/JS on Special:Preferences [extensions/GlobalCssJs] - 10https://gerrit.wikimedia.org/r/120333 [00:45:59] (03CR) 10Purodha: [C: 04-1] "Installaton fails for me. With a fresh Mediawiki installed from git, using a table prefix "ow2_", I get:" [extensions/WikiLexicalData] - 10https://gerrit.wikimedia.org/r/119446 (owner: 10Hiong3-eng5) [01:02:40] (03CR) 10Purodha: "Tables_in_s51397__owintes" [extensions/WikiLexicalData] - 10https://gerrit.wikimedia.org/r/119446 (owner: 10Hiong3-eng5) [01:20:20] (03PS1) 10Wctaiwan: Add ability to deliver to all pages in a category [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/120334 [01:20:56] (03PS1) 10Siebrand: Set visibility for some methods and remove unused ones [core] - 10https://gerrit.wikimedia.org/r/120335 [01:24:06] (03PS2) 10Prtksxna: Disable NavigationPopups (Gadget) is Popups (Extension) is enabled [extensions/Popups] - 10https://gerrit.wikimedia.org/r/120188 [01:24:34] (03CR) 10Prtksxna: Disable NavigationPopups (Gadget) is Popups (Extension) is enabled (031 comment) [extensions/Popups] - 10https://gerrit.wikimedia.org/r/120188 (owner: 10Prtksxna) [01:29:12] (03PS1) 10Siebrand: Try to make a dent in CodeSniffer reports on includes/ (1) [core] - 10https://gerrit.wikimedia.org/r/120336 [01:29:43] (03PS2) 10Siebrand: Try to make a dent in CodeSniffer reports on includes/ (1) [core] - 10https://gerrit.wikimedia.org/r/120336 [01:49:01] (03PS1) 10MarkAHershberger: backport current i18n to get action-replacetext [extensions/ReplaceText] (REL1_19) - 10https://gerrit.wikimedia.org/r/120337 [01:49:03] (03PS1) 10MarkAHershberger: Add gitreview for branch [extensions/ReplaceText] (REL1_19) - 10https://gerrit.wikimedia.org/r/120338 [02:01:46] (03CR) 10MarkAHershberger: [C: 032] "self-merge i18n" [extensions/ReplaceText] (REL1_19) - 10https://gerrit.wikimedia.org/r/120337 (owner: 10MarkAHershberger) [02:01:48] (03Merged) 10jenkins-bot: backport current i18n to get action-replacetext [extensions/ReplaceText] (REL1_19) - 10https://gerrit.wikimedia.org/r/120337 (owner: 10MarkAHershberger) [02:02:11] (03CR) 10MarkAHershberger: [C: 032] Add gitreview for branch [extensions/ReplaceText] (REL1_19) - 10https://gerrit.wikimedia.org/r/120338 (owner: 10MarkAHershberger) [02:02:13] (03Merged) 10jenkins-bot: Add gitreview for branch [extensions/ReplaceText] (REL1_19) - 10https://gerrit.wikimedia.org/r/120338 (owner: 10MarkAHershberger) [02:02:55] (03PS4) 10Yurik: Allow mobile to reduce image quality [core] - 10https://gerrit.wikimedia.org/r/119661 [02:05:58] (03PS5) 10Yurik: Allow mobile to reduce image quality [core] - 10https://gerrit.wikimedia.org/r/119661 [02:13:58] (03PS3) 10Prtksxna: Disable NavigationPopups (Gadget) is Popups (Extension) is enabled [extensions/Popups] - 10https://gerrit.wikimedia.org/r/120188 [02:14:17] (03PS2) 10Prtksxna: Add white fill in triangle for hovercards with images [extensions/Popups] - 10https://gerrit.wikimedia.org/r/120174 [02:19:28] (03Abandoned) 10Fantasticfears: Add display: block; property to labelElement to make the text-overflow: ellipsis work correctly [core] - 10https://gerrit.wikimedia.org/r/120192 (owner: 10Fantasticfears) [02:19:35] (03CR) 10Legoktm: [C: 04-1] "Looking good so far! Want to add a test for sending to categories? :)" (032 comments) [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/120334 (owner: 10Wctaiwan) [02:22:47] (03PS6) 10Yurik: Allow mobile to reduce image quality [core] - 10https://gerrit.wikimedia.org/r/119661 [02:24:29] prtksxna: you should get jenkins jobs set up for popups [02:24:40] legoktm: ah yes [02:26:02] legoktm: Any resource on how I can do that? [02:26:21] yeah let me find them [02:26:36] what I normally do is just copy another extension's jobs and change the name [02:26:51] there is like a proper way to do it though [02:27:13] prtksxna: https://www.mediawiki.org/wiki/Continuous_integration/Tutorials/Adding_a_MediaWiki_extension [02:27:23] that's the long and "proper" way [02:27:39] legoktm: Thanks! I'll set it up today :) [02:28:01] I just do https://gerrit.wikimedia.org/r/#/c/102876/ and https://gerrit.wikimedia.org/r/#/c/102877/ [02:28:02] s/today/tomorrow [02:28:04] legoktm: Trying to make popups more accessible today [02:29:11] legoktm: Seems simple enough :) [03:16:09] (03CR) 10Physikerwelt: [C: 032 V: 032] "Works for me. Tested from the PPA build" [services/mathoid] - 10https://gerrit.wikimedia.org/r/120183 (owner: 10Physikerwelt) [03:22:34] (03CR) 10MaxSem: [C: 04-1] Allow mobile to reduce image quality (031 comment) [core] - 10https://gerrit.wikimedia.org/r/119661 (owner: 10Yurik) [03:43:46] (03CR) 10Yurik: "MaxSem, please recheck your comment." (031 comment) [core] - 10https://gerrit.wikimedia.org/r/119661 (owner: 10Yurik) [03:49:35] (03PS2) 10Wctaiwan: Add ability to deliver to all pages in a category [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/120334 [04:15:32] (03PS7) 10Yurik: Allow mobile to reduce image quality [core] - 10https://gerrit.wikimedia.org/r/119661 [04:24:55] (03PS1) 10Prtksxna: Show and hide Popups on focus and blur (along with mouseenter/leave) [extensions/Popups] - 10https://gerrit.wikimedia.org/r/120342 [04:25:00] (03PS1) 10Prtksxna: Use escape key to hide popup [extensions/Popups] - 10https://gerrit.wikimedia.org/r/120343 [04:25:03] (03PS1) 10Prtksxna: Use tooltip role for Popups [extensions/Popups] - 10https://gerrit.wikimedia.org/r/120344 [04:25:07] (03PS1) 10Prtksxna: Use aria-hidden for popups [extensions/Popups] - 10https://gerrit.wikimedia.org/r/120345 [04:32:25] (03PS1) 10Ricordisamoa: show before [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/120346 [04:42:26] (03PS3) 10Wctaiwan: Add ability to deliver to all pages in a category [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/120334 [05:05:10] (03PS16) 10Kunalgrover05: Implement listing for tracking categories [core] - 10https://gerrit.wikimedia.org/r/112323 [05:19:42] legoktm: installing jjb now [05:19:49] ok [05:19:54] but that's the complicated way :P [05:30:16] legoktm: Should I just clone those two repos somewhere and make the changes? [05:30:24] yeah [05:30:40] legoktm: I don't have any 'extension-unittests' right now, so I don't need to do that? [05:30:57] if you have no unittests, thats fine [05:35:58] (03PS1) 10Prtksxna: Add jobs for Popups extension [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/120349 [05:40:30] (03CR) 10Prtksxna: "I do now and its working. How do I test for RTL?" [extensions/Popups] - 10https://gerrit.wikimedia.org/r/120155 (owner: 10Amire80) [05:40:53] (03CR) 10Prtksxna: Added an RTL beta feature icon [extensions/Popups] - 10https://gerrit.wikimedia.org/r/120155 (owner: 10Amire80) [05:58:18] prtksxna: ?uselang=he [05:58:25] or "ar", or any other rtl language [06:15:53] legoktm: thanks, testing now :) [06:28:45] legoktm: Its not RTL ready, shows to triangles at random places instead of one at the correct place :( [06:28:50] * prtksxna goes to bugzilla [06:46:09] (03CR) 10Hiong3-eng5: "try typing..." [extensions/WikiLexicalData] - 10https://gerrit.wikimedia.org/r/119446 (owner: 10Hiong3-eng5) [06:54:23] (03CR) 10Hiong3-eng5: "I think I was unclear..." [extensions/WikiLexicalData] - 10https://gerrit.wikimedia.org/r/119446 (owner: 10Hiong3-eng5) [08:42:24] (03CR) 10Amire80: "Set your language to an RTL one. For example, add ?uselang=he to the URL." [extensions/Popups] - 10https://gerrit.wikimedia.org/r/120155 (owner: 10Amire80) [08:45:47] (03CR) 10Hiong3-eng5: "If the same problem occurs, I will recheck this out." [extensions/WikiLexicalData] - 10https://gerrit.wikimedia.org/r/119446 (owner: 10Hiong3-eng5) [08:47:03] (03CR) 10Amire80: "Oh, got it. (I shouldn't read Gerrit comments around midnight.)" [extensions/BetaFeatures] - 10https://gerrit.wikimedia.org/r/120237 (owner: 10Amire80) [08:49:21] (03CR) 10Prtksxna: [C: 032 V: 032] "Thank you! The images look correct. Thank you so much for the patch." [extensions/Popups] - 10https://gerrit.wikimedia.org/r/120155 (owner: 10Amire80) [08:52:21] (03PS12) 10Aaron Schulz: Added a Redis pool counter class [core] - 10https://gerrit.wikimedia.org/r/118955 [08:56:47] (03CR) 10Hiong3-eng5: "Did you receive an error regarding an index of the language or language_names tables?" [extensions/WikiLexicalData] - 10https://gerrit.wikimedia.org/r/119446 (owner: 10Hiong3-eng5) [08:58:49] (03PS3) 10IAlex: Misc fixes to UploadSourceField [core] - 10https://gerrit.wikimedia.org/r/104944 [08:59:08] (03PS4) 10IAlex: Misc fixes to UploadSourceField [core] - 10https://gerrit.wikimedia.org/r/104944 [09:09:31] (03PS1) 10Severin Anatoliy: Fix render WikiForumList to display 'Posted by' link [extensions/WikiForum] - 10https://gerrit.wikimedia.org/r/120352 [09:09:33] (03PS1) 10Severin Anatoliy: Fix 'wikiforum-posted' message in russian [extensions/WikiForum] - 10https://gerrit.wikimedia.org/r/120353 [09:15:19] (03PS3) 10IAlex: Link to bugzilla.wikimedia.org in README for consistency [core] - 10https://gerrit.wikimedia.org/r/118761 [09:20:49] (03PS1) 10IAlex: Fix documentation of wfDebugLog() [core] - 10https://gerrit.wikimedia.org/r/120354 [09:41:04] (03PS1) 10IAlex: Automatically add a new line at the end of wfLogDBError() [core] - 10https://gerrit.wikimedia.org/r/120355 [09:43:40] (03CR) 10IAlex: Automatically add a new line at the end of wfLogDBError() (032 comments) [core] - 10https://gerrit.wikimedia.org/r/120355 (owner: 10IAlex) [09:54:09] (03PS1) 10Deepali: Remove edit toolbar from the editing form [core] - 10https://gerrit.wikimedia.org/r/120357 [09:55:34] (03PS2) 10Amire80: Allow having screenshots by language [extensions/BetaFeatures] - 10https://gerrit.wikimedia.org/r/120237 [09:57:33] (03PS2) 10Amire80: Specify screenshots by language in a more robust way [extensions/VectorBeta] - 10https://gerrit.wikimedia.org/r/120238 [10:29:19] (03PS1) 10Pastakhov: fix time useage counter (1.0.10) [extensions/PhpTags] - 10https://gerrit.wikimedia.org/r/120359 [10:29:21] (03CR) 10jenkins-bot: [V: 04-1] fix time useage counter (1.0.10) [extensions/PhpTags] - 10https://gerrit.wikimedia.org/r/120359 (owner: 10Pastakhov) [10:32:27] (03PS1) 10IAlex: Remove double wfDebug() call in Database.php [core] - 10https://gerrit.wikimedia.org/r/120360 [10:34:41] (03PS1) 10Chococookies: Merges and inits db schema, add special pages. [extensions/OpenBadges] - 10https://gerrit.wikimedia.org/r/120361 [10:46:50] (03PS1) 10Deepali: Remove edit toolbar from the editing form [extensions/BookManagerv2] - 10https://gerrit.wikimedia.org/r/120362 [10:48:22] (03CR) 10Siebrand: "Some i18n/L10n review and more." (0318 comments) [extensions/OpenBadges] - 10https://gerrit.wikimedia.org/r/120361 (owner: 10Chococookies) [10:50:55] (03CR) 10Siebrand: [C: 04-1] "Code cannot merge. Needs rebase." (031 comment) [extensions/PhpTags] - 10https://gerrit.wikimedia.org/r/120359 (owner: 10Pastakhov) [10:51:27] (03PS2) 10Deepali: Fix label for publication date in json editor Remove extra -field from bookmanagerv2-publication-date-field-field Bug: 58080 Change-Id: I61f13a7005b0c35c714e1db3a4a478331b5adb6e [extensions/BookManagerv2] - 10https://gerrit.wikimedia.org/r/120362 [10:52:18] (03PS2) 10Siebrand: Remove edit toolbar from the editing form [core] - 10https://gerrit.wikimedia.org/r/120357 (owner: 10Deepali) [10:52:24] (03PS4) 10Addshore: Link to bugzilla.wikimedia.org in README for consistency [core] - 10https://gerrit.wikimedia.org/r/118761 (owner: 10IAlex) [10:52:38] (03CR) 10Addshore: [C: 032] Link to bugzilla.wikimedia.org in README for consistency [core] - 10https://gerrit.wikimedia.org/r/118761 (owner: 10IAlex) [10:53:42] (03CR) 10Deepali: "Wrong commit message in patch-set 1. Fixed in patch-set 2." [extensions/BookManagerv2] - 10https://gerrit.wikimedia.org/r/120362 (owner: 10Deepali) [10:54:05] (03CR) 10Siebrand: "If you want to be able to change behaviour in core based on something an extension implements, you should add a hook in core. Then use tha" (032 comments) [core] - 10https://gerrit.wikimedia.org/r/120357 (owner: 10Deepali) [10:54:11] (03CR) 10jenkins-bot: [V: 04-1] Link to bugzilla.wikimedia.org in README for consistency [core] - 10https://gerrit.wikimedia.org/r/118761 (owner: 10IAlex) [10:58:05] (03Merged) 10jenkins-bot: Link to bugzilla.wikimedia.org in README for consistency [core] - 10https://gerrit.wikimedia.org/r/118761 (owner: 10IAlex) [11:12:55] (03CR) 10Siebrand: [C: 04-1] "i18n/L10n reviewed." (031 comment) [extensions/WikiForum] - 10https://gerrit.wikimedia.org/r/120353 (owner: 10Severin Anatoliy) [11:18:01] (03CR) 10Siebrand: [C: 032] Misc fixes to UploadSourceField [core] - 10https://gerrit.wikimedia.org/r/104944 (owner: 10IAlex) [11:19:13] (03PS2) 10Siebrand: Update formatting for includes/specials/ [core] - 10https://gerrit.wikimedia.org/r/120326 [11:22:06] (03CR) 10Siebrand: [C: 031] "i18n/L10n reviewed." [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/120334 (owner: 10Wctaiwan) [11:22:26] (03Merged) 10jenkins-bot: Misc fixes to UploadSourceField [core] - 10https://gerrit.wikimedia.org/r/104944 (owner: 10IAlex) [11:25:27] (03CR) 10Siebrand: [C: 031] "i18n/L10n reviewed." [extensions/GlobalCssJs] - 10https://gerrit.wikimedia.org/r/120333 (owner: 10Legoktm) [11:34:06] (03CR) 10Siebrand: [C: 04-1] "i18n/L10n reviewed." (037 comments) [core] - 10https://gerrit.wikimedia.org/r/112323 (owner: 10Kunalgrover05) [11:46:27] (03PS2) 10Pastakhov: fix time useage counter (1.0.10) [extensions/PhpTags] - 10https://gerrit.wikimedia.org/r/120359 [12:02:08] (03CR) 10Pastakhov: [C: 032] fix time useage counter (1.0.10) [extensions/PhpTags] - 10https://gerrit.wikimedia.org/r/120359 (owner: 10Pastakhov) [12:02:12] (03Merged) 10jenkins-bot: fix time useage counter (1.0.10) [extensions/PhpTags] - 10https://gerrit.wikimedia.org/r/120359 (owner: 10Pastakhov) [12:12:39] (03CR) 10Siebrand: "So why was Magic capitalised?" [extensions/PhpTags] - 10https://gerrit.wikimedia.org/r/120359 (owner: 10Pastakhov) [13:11:58] can $wgLang->date( $foo, true ) be passed as an argument for mw.msg( 'bar', ) ? [13:42:11] (03PS1) 10UltrasonicNXT: Change away mechanism to be automatic [extensions/MediaWikiChat] - 10https://gerrit.wikimedia.org/r/120369 [13:52:41] (03Abandoned) 10Amire80: add max-width to vector skin [core] - 10https://gerrit.wikimedia.org/r/103744 (owner: 10Hatul) [14:26:58] (03PS2) 10UltrasonicNXT: Change away mechanism to be automatic [extensions/MediaWikiChat] - 10https://gerrit.wikimedia.org/r/120369 [14:27:14] (03CR) 10UltrasonicNXT: [C: 032 V: 032] Change away mechanism to be automatic [extensions/MediaWikiChat] - 10https://gerrit.wikimedia.org/r/120369 (owner: 10UltrasonicNXT) [14:34:31] (03PS1) 10UltrasonicNXT: Bugfix - white usernames [extensions/MediaWikiChat] - 10https://gerrit.wikimedia.org/r/120377 [14:34:42] (03CR) 10UltrasonicNXT: [C: 032 V: 032] Bugfix - white usernames [extensions/MediaWikiChat] - 10https://gerrit.wikimedia.org/r/120377 (owner: 10UltrasonicNXT) [14:42:57] (03PS1) 10UltrasonicNXT: Add case for idle times over 24 hours [extensions/MediaWikiChat] - 10https://gerrit.wikimedia.org/r/120378 [14:43:21] (03CR) 10UltrasonicNXT: [C: 032 V: 032] Add case for idle times over 24 hours [extensions/MediaWikiChat] - 10https://gerrit.wikimedia.org/r/120378 (owner: 10UltrasonicNXT) [14:47:00] (03PS1) 10UltrasonicNXT: Change sidebar grey criteria [extensions/MediaWikiChat] - 10https://gerrit.wikimedia.org/r/120379 [14:48:04] (03CR) 10UltrasonicNXT: [C: 032 V: 032] Change sidebar grey criteria [extensions/MediaWikiChat] - 10https://gerrit.wikimedia.org/r/120379 (owner: 10UltrasonicNXT) [14:52:23] (03PS17) 10Kunalgrover05: Implement listing for tracking categories [core] - 10https://gerrit.wikimedia.org/r/112323 [14:54:32] (03CR) 10Kunalgrover05: "Siebrand: I understand that 2 changes in the commit were unrelated. So how should these errors where line size exceeds 100 be fixed?" (032 comments) [core] - 10https://gerrit.wikimedia.org/r/112323 (owner: 10Kunalgrover05) [14:57:02] (03CR) 10Siebrand: "@kunal: For now it's best to ignore CodeSniffer issues that were not introduced in this commit." [core] - 10https://gerrit.wikimedia.org/r/112323 (owner: 10Kunalgrover05) [15:02:14] (03PS3) 10TheDJ: CodeEditor: Add a status bar with line and columncount [extensions/CodeEditor] - 10https://gerrit.wikimedia.org/r/118989 [15:03:10] (03CR) 10Pastakhov: "I do not know how to write it in English." [extensions/PhpTags] - 10https://gerrit.wikimedia.org/r/120359 (owner: 10Pastakhov) [16:23:30] (03PS1) 10Umherirrender: [Regression] Delete autoblocks when removing autoblock flag [core] - 10https://gerrit.wikimedia.org/r/120386 [16:27:33] (03PS2) 10Umherirrender: [Regression] Delete autoblocks when removing autoblock flag [core] - 10https://gerrit.wikimedia.org/r/120386 [16:29:08] (03CR) 10Umherirrender: "Patch Set 2: Fixed typo" [core] - 10https://gerrit.wikimedia.org/r/120386 (owner: 10Umherirrender) [17:00:44] (03PS5) 10TheDJ: [WIP] Additional CodeEditor buttons [extensions/CodeEditor] - 10https://gerrit.wikimedia.org/r/104512 [17:00:46] (03CR) 10jenkins-bot: [V: 04-1] [WIP] Additional CodeEditor buttons [extensions/CodeEditor] - 10https://gerrit.wikimedia.org/r/104512 (owner: 10TheDJ) [17:10:44] (03PS2) 10TheDJ: Improve the CodeEditor toolbar [extensions/CodeEditor] - 10https://gerrit.wikimedia.org/r/118993 [17:10:46] (03PS6) 10TheDJ: [WIP] Additional CodeEditor buttons [extensions/CodeEditor] - 10https://gerrit.wikimedia.org/r/104512 [17:19:11] (03CR) 10Siebrand: "Is Magic expression defined anywhere?" [extensions/PhpTags] - 10https://gerrit.wikimedia.org/r/120359 (owner: 10Pastakhov) [17:24:25] (03CR) 10Siebrand: [C: 04-1] "i18n/L10n reviewed." (032 comments) [core] - 10https://gerrit.wikimedia.org/r/112323 (owner: 10Kunalgrover05) [18:47:17] (03CR) 10Jforrester: [C: 031] Allow having screenshots by language [extensions/BetaFeatures] - 10https://gerrit.wikimedia.org/r/120237 (owner: 10Amire80) [18:48:40] (03CR) 10Mattflaschen: "I was under the impression from https://trello.com/c/vmJ2t47Q/368-add-optional-ability-to-focus-on-an-attached-element-with-a-magnify-effe" [extensions/GettingStarted] - 10https://gerrit.wikimedia.org/r/118478 (owner: 10Phuedx) [18:51:22] (03CR) 10Mattflaschen: "Also, I requested it be renamed. The new name is https://commons.wikimedia.org/wiki/File:Magnifier_effect_for_Getting_Started_guider.jpg" [extensions/GettingStarted] - 10https://gerrit.wikimedia.org/r/118478 (owner: 10Phuedx) [19:16:56] (03Abandoned) 10Parent5446: test [extensions/OpenBadges] - 10https://gerrit.wikimedia.org/r/112310 (owner: 10Aizhuli90) [19:40:25] (03PS2) 10Parent5446: Created an extension template. [extensions/OpenBadges] - 10https://gerrit.wikimedia.org/r/116289 (owner: 10Chococookies) [20:07:20] (03CR) 10Mattflaschen: [C: 032] "Looks good. As far as I can tell, this doesn't affect anything in production. MobileFrontend has a mw-ui-button-group, which looks simil" [core] - 10https://gerrit.wikimedia.org/r/116075 (owner: 10Pginer) [20:09:40] (03PS1) 10TheDJ: New hook for readonly editpages [core] - 10https://gerrit.wikimedia.org/r/120396 [20:10:42] (03PS2) 10TheDJ: New hook for readonly editpages [core] - 10https://gerrit.wikimedia.org/r/120396 [20:12:23] (03CR) 10IAlex: [C: 04-1] New hook for readonly editpages (032 comments) [core] - 10https://gerrit.wikimedia.org/r/120396 (owner: 10TheDJ) [20:12:50] (03PS11) 10Ganeshaditya1: Display a warning when the user name looked up is not registered. [core] - 10https://gerrit.wikimedia.org/r/117854 [20:12:52] (03Merged) 10jenkins-bot: Button group adjustments [core] - 10https://gerrit.wikimedia.org/r/116075 (owner: 10Pginer) [20:15:12] (03PS1) 10TheDJ: [Do not merge] Allow the CodeEditor in read only mode [extensions/CodeEditor] - 10https://gerrit.wikimedia.org/r/120397 [20:23:39] * marktraceur wonders if anyone is around to glance at https://bugzilla.wikimedia.org/show_bug.cgi?id=61553 [20:23:52] I'm thinking about Just Fixing It especially with lfaraone looking over my shoulder [20:26:27] marktraceur: I very much doubt you can "Just Fix It." [20:26:52] Oh? [20:27:25] I mean, at least doing some investigation, and if it's too much for the next few hours then I can leave it [20:27:27] What are you proposing? [20:27:39] Gloria: Redirecting to non-encoded versions [20:28:18] I doubt more aggressive canonicalization would mean a simpler robots.txt file. [20:28:22] I'm not sure I see the point. [20:29:03] It seems like a solid technical decision; having more than one URL for a resource is certainly allowed but not ideal [20:29:13] Redirects are what we Should Be Doing IMO [20:32:59] I think we used to 404 if there was a %2F in the URL, heh. [20:33:19] marktraceur: That goal is dubious. [20:33:27] We'll always have at least two entry points. [20:33:36] /wiki/Foo and /w/index.php?title=Foo [20:33:51] Right [20:36:37] And that's fine [20:37:42] (03PS3) 10Parent5446: Created an extension template. [extensions/OpenBadges] - 10https://gerrit.wikimedia.org/r/116289 (owner: 10Chococookies) [20:39:29] (03PS4) 10Parent5446: Created an extension template. [extensions/OpenBadges] - 10https://gerrit.wikimedia.org/r/116289 (owner: 10Chococookies) [20:41:13] (03PS2) 10Parent5446: Adds form fields to BadgeManager [extensions/OpenBadges] - 10https://gerrit.wikimedia.org/r/116448 (owner: 10Chococookies) [20:42:02] (03PS5) 10Parent5446: Created an extension template. [extensions/OpenBadges] - 10https://gerrit.wikimedia.org/r/116289 (owner: 10Chococookies) [20:42:58] (03PS1) 10Aaron Schulz: [WIP] Added HHVM support [php/FastStringSearch] - 10https://gerrit.wikimedia.org/r/120469 [20:43:05] (03PS3) 10Parent5446: Adds form fields to BadgeManager [extensions/OpenBadges] - 10https://gerrit.wikimedia.org/r/116448 (owner: 10Chococookies) [20:47:24] (03PS4) 10Parent5446: Adds form fields to BadgeManager [extensions/OpenBadges] - 10https://gerrit.wikimedia.org/r/116448 (owner: 10Chococookies) [20:54:05] (03CR) 10Siebrand: [C: 04-1] "i18n/L10n reviewed." (036 comments) [extensions/OpenBadges] - 10https://gerrit.wikimedia.org/r/116289 (owner: 10Chococookies) [20:56:43] (03PS2) 10Aaron Schulz: [WIP] Added HHVM support [php/FastStringSearch] - 10https://gerrit.wikimedia.org/r/120469 [20:56:45] (03PS5) 10Stepzhou: @donyu @stepzhou fifth iteration for persona sign up special page [extensions/Persona] - 10https://gerrit.wikimedia.org/r/112309 (owner: 10Donyu) [20:56:47] (03CR) 10jenkins-bot: [V: 04-1] @donyu @stepzhou fifth iteration for persona sign up special page [extensions/Persona] - 10https://gerrit.wikimedia.org/r/112309 (owner: 10Donyu) [20:57:40] (03CR) 10Aaron Schulz: "The simple test script currently works." [php/FastStringSearch] - 10https://gerrit.wikimedia.org/r/120469 (owner: 10Aaron Schulz) [21:00:00] (03PS3) 10Aaron Schulz: [WIP] Added HHVM support [php/FastStringSearch] - 10https://gerrit.wikimedia.org/r/120469 [21:01:43] (03PS1) 10Hchuying: Updates AddBadge.php [extensions/OpenBadges] - 10https://gerrit.wikimedia.org/r/120470 [21:01:45] (03PS1) 10Hchuying: Update AddBadge.php [extensions/OpenBadges] - 10https://gerrit.wikimedia.org/r/120471 [21:02:16] (03PS1) 10TheDJ: Convert from show()/hide() to using classes [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/120472 [21:14:46] (03PS1) 10Siebrand: Remove period from desc message for consistency [extensions/Popups] - 10https://gerrit.wikimedia.org/r/120474 [21:16:48] (03PS12) 10Ganeshaditya1: Display a warning when the user name looked up is not registered. [core] - 10https://gerrit.wikimedia.org/r/117854 [21:19:07] (03PS1) 10Stepzhou: Slightly saner email default on user creation with @donyu. [core] - 10https://gerrit.wikimedia.org/r/120475 [21:22:51] (03PS10) 10UltrasonicNXT: WIP - Rewrite [extensions/WikiForum] - 10https://gerrit.wikimedia.org/r/116258 [21:28:55] (03PS3) 10TheDJ: New hook for readonly editpages [core] - 10https://gerrit.wikimedia.org/r/120396 [21:29:16] (03CR) 10TheDJ: New hook for readonly editpages (032 comments) [core] - 10https://gerrit.wikimedia.org/r/120396 (owner: 10TheDJ) [21:34:41] (03CR) 10IAlex: New hook for readonly editpages (031 comment) [core] - 10https://gerrit.wikimedia.org/r/120396 (owner: 10TheDJ) [21:35:04] (03CR) 10IAlex: [C: 04-1] "Still -1 per discussion on PS 2." [core] - 10https://gerrit.wikimedia.org/r/120396 (owner: 10TheDJ) [21:40:23] (03PS4) 10TheDJ: New hook for readonly editpages [core] - 10https://gerrit.wikimedia.org/r/120396 [21:53:29] (03CR) 10TheDJ: [C: 031] Show and hide Popups on focus and blur (along with mouseenter/leave) [extensions/Popups] - 10https://gerrit.wikimedia.org/r/120342 (owner: 10Prtksxna) [21:59:11] (03CR) 10TheDJ: [C: 031] Use escape key to hide popup (031 comment) [extensions/Popups] - 10https://gerrit.wikimedia.org/r/120343 (owner: 10Prtksxna) [21:59:28] (03CR) 10TheDJ: [C: 031] Use tooltip role for Popups [extensions/Popups] - 10https://gerrit.wikimedia.org/r/120344 (owner: 10Prtksxna) [22:01:04] (03CR) 10TheDJ: [C: 031] "I have not tested this with actual screen readers, but on the face of it, all changes look sane and should not have any negative effects." [extensions/Popups] - 10https://gerrit.wikimedia.org/r/120345 (owner: 10Prtksxna) [22:36:45] (03PS1) 10MarkAHershberger: * Change display order to most recent editors/spammers * Remove deprecation * Make $um a more readable $userManager [extensions/BlockAndNuke] - 10https://gerrit.wikimedia.org/r/120476 [22:41:32] (03PS1) 10MarkAHershberger: set up gitreview for REL1_22 [extensions/BlockAndNuke] (REL1_22) - 10https://gerrit.wikimedia.org/r/120477 [22:59:34] (03PS1) 10MarkAHershberger: Initial commit [extensions/BlockAndNuke] (REL1_22) - 10https://gerrit.wikimedia.org/r/120478 [22:59:48] (03CR) 10MarkAHershberger: [C: 032] Initial commit [extensions/BlockAndNuke] (REL1_22) - 10https://gerrit.wikimedia.org/r/120478 (owner: 10MarkAHershberger) [23:00:46] (03PS1) 10MarkAHershberger: files from thepetwiki [extensions/BlockAndNuke] (REL1_22) - 10https://gerrit.wikimedia.org/r/120479 [23:01:05] (03CR) 10MarkAHershberger: [C: 032] files from thepetwiki [extensions/BlockAndNuke] (REL1_22) - 10https://gerrit.wikimedia.org/r/120479 (owner: 10MarkAHershberger)