[00:05:22] (03PS1) 10JGonera: [WIP] Update OOjs UI to v0.1.0-pre (f11efdf6b3) [core] - 10https://gerrit.wikimedia.org/r/120164 [00:07:01] (03PS9) 10Kaldari: Update default contents of interwiki table [core] - 10https://gerrit.wikimedia.org/r/84303 (owner: 10TTO) [00:08:16] (03CR) 10Kaldari: [C: 031] "TTO: removed the 'mark local' comments. I've leaving the wikia entry alone for now per Nemo. Should be easy enough to create a separate pa" [core] - 10https://gerrit.wikimedia.org/r/84303 (owner: 10TTO) [00:10:22] (03PS1) 10JGonera: Use Agora oojs-ui theme on mobile [core] - 10https://gerrit.wikimedia.org/r/120165 [00:10:39] (03CR) 10MarkAHershberger: "I'm not just throwing them around. This is a breaking change. Instead of having something available without any extra work, the user is " [core] - 10https://gerrit.wikimedia.org/r/118345 (owner: 10Jdlrobson) [00:14:27] any WMF config experts around? Every Beta Feature enabled "everywhere" in InitialiseSettings.php copies the array for wmgUseBetaFeatures. How can they say "Enable me everywhere $wgUseBetaFeatures is true"? [00:17:22] (03PS1) 10PleaseStand: DatabaseMysqlBase: Remove broken check for Percona Server [core] - 10https://gerrit.wikimedia.org/r/120166 [00:20:29] (03CR) 10PleaseStand: WebInstaller: Don't call getSoftwareLink() (032 comments) [core] - 10https://gerrit.wikimedia.org/r/106489 (owner: 10PleaseStand) [00:22:09] (03CR) 10PleaseStand: "Format of Percona's version suffix: https://www.percona.com/docs/wiki/percona-server:release_model" [core] - 10https://gerrit.wikimedia.org/r/120166 (owner: 10PleaseStand) [00:22:54] (03CR) 10CSteipp: [C: 04-1] "Isn't working for me in test, unless I use parseExpiryInput on the time period." (031 comment) [extensions/GlobalBlocking] - 10https://gerrit.wikimedia.org/r/119915 (owner: 10Hoo man) [00:23:51] I could create nobetafeatures.lst and have 'default' => true, 'nobetafeatures' => false ; but that still doesn't capture the intent4 [00:24:54] the pattern "'default' => true, 'loginwiki' => false, 'votewiki' => false" reappears over and over [00:28:26] (03PS19) 10Bsitu: Add summary revision type [extensions/Flow] - 10https://gerrit.wikimedia.org/r/117357 [00:34:26] (03PS4) 10Hoo man: Optionally place a local block when globally blocking [extensions/GlobalBlocking] - 10https://gerrit.wikimedia.org/r/119915 [00:34:40] (03CR) 10Hoo man: Optionally place a local block when globally blocking (031 comment) [extensions/GlobalBlocking] - 10https://gerrit.wikimedia.org/r/119915 (owner: 10Hoo man) [00:35:12] (03CR) 10Hoo man: "Fixed block expiry parsing (per Chris)" [extensions/GlobalBlocking] - 10https://gerrit.wikimedia.org/r/119915 (owner: 10Hoo man) [00:50:13] (03PS20) 10Bsitu: Add summary revision type [extensions/Flow] - 10https://gerrit.wikimedia.org/r/117357 [00:50:31] (03CR) 10jenkins-bot: [V: 04-1] Add summary revision type [extensions/Flow] - 10https://gerrit.wikimedia.org/r/117357 (owner: 10Bsitu) [00:51:08] (03CR) 10Hoo man: [C: 04-1] Validate $this->mAddress before storing it (031 comment) [extensions/GlobalBlocking] - 10https://gerrit.wikimedia.org/r/107018 (owner: 10Legoktm) [00:52:20] (03PS21) 10Bsitu: Add topic summary revision type [extensions/Flow] - 10https://gerrit.wikimedia.org/r/117357 [00:52:36] spagewmf: Hey. [00:52:38] spagewmf: Want me to set that up? [00:53:08] James_F: set what up? us up the bomb? :) [00:53:25] any WMF config experts around? Every Beta Feature enabled "everywhere" in InitialiseSettings.php copies the array for wmgUseBetaFeatures. How can they say "Enable me everywhere $wgUseBetaFeatures is true"? [00:54:35] oh, yes, I'm curious how. I know you can set variables in CommonSettings.php... [00:56:51] spagewmf: Make a .dblist. [00:58:33] James_F: OK. It's still 4 lines to say "Like the other 31 cases" [00:58:53] spagewmf: "default" => true, "nonbetafeatures" => false [00:59:07] spagewmf: Yes, but such is life. [01:05:10] I don't think a .dblist would help here at all. [01:05:43] We should probably define all.dblist minus votewiki and loginwiki as a grouping in ... whichever PHP file. [01:05:58] Or change the meaning of default to be (all minus vote/login). [01:10:28] Gloria: the dblist helps a little (eight less lines if nonbetafeatures.dblist, ~30 less lines it's, uhh, specialwikislikevoteandlogin.dblist. Defining a grouping for use in InitialiseSettings might be better still but how? [01:10:40] spagewmf: *fewer. [01:11:04] Gloria: We really should have an OMGNO.dblist for loginwiki and votewiki… [01:11:22] James_F: I was referring to LESS CSS compiler, you insensitive clod! :) [01:13:57] spagewmf: Psh. :-) [01:14:03] (03PS3) 10Hoo man: SpecialCentralAutoLogin: Clean up javascript [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/118429 (owner: 10Krinkle) [01:14:15] spagewmf: https://gerrit.wikimedia.org/r/120171 is how to do it. [01:14:21] And with that, I need to run. [01:14:22] Sorry! [01:15:45] (03PS1) 10Prtksxna: Add white fill in triangle for hovercards with images [extensions/Popups] - 10https://gerrit.wikimedia.org/r/120174 [01:16:47] (03PS4) 10Hoo man: SpecialCentralAutoLogin: Clean up javascript [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/118429 (owner: 10Krinkle) [01:17:18] hoo: have you seen the dependent patch set? [01:18:58] (03CR) 10Hoo man: "Addressed Chris's concern from PS1 by moving a comment out of an inline JS." [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/118429 (owner: 10Krinkle) [01:19:54] (03CR) 10Hoo man: [C: 032] "per Chris on PS1" [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/118429 (owner: 10Krinkle) [01:19:57] (03Merged) 10jenkins-bot: SpecialCentralAutoLogin: Clean up javascript [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/118429 (owner: 10Krinkle) [01:21:14] (03PS1) 10Physikerwelt: Add 0.2.2 resease notes [services/mathoid] - 10https://gerrit.wikimedia.org/r/120175 [01:21:19] (03CR) 10Hoo man: [C: 04-1] "needs a rebase" [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/118430 (owner: 10Krinkle) [01:21:40] hoo: Can you do the rebase? (your change caused the conflict, it was fine a second ago) [01:21:57] Hmm, we have a File::getLength method, which calls MediaHandler::getLength, which is a method that only exists in some subclasses of MediaHandler. *sigh* [01:22:02] I'll do it but please review it first, it's bound to conflict again soon because the file moves. [01:22:13] rather not rebase it again multiple times. [01:22:25] sure, can have a look first [01:23:44] (03PS11) 10Bsitu: Closing & reopening topic [extensions/Flow] - 10https://gerrit.wikimedia.org/r/118399 [01:24:05] (03CR) 10jenkins-bot: [V: 04-1] Closing & reopening topic [extensions/Flow] - 10https://gerrit.wikimedia.org/r/118399 (owner: 10Bsitu) [01:24:46] (03PS12) 10Bsitu: Closing & reopening topic [extensions/Flow] - 10https://gerrit.wikimedia.org/r/118399 [01:24:49] (03PS5) 10Krinkle: SpecialCentralAutoLogin: Move javascript to separate files for linting [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/118430 [01:24:55] (03CR) 10Physikerwelt: [C: 032] Add 0.2.2 resease notes [services/mathoid] - 10https://gerrit.wikimedia.org/r/120175 (owner: 10Physikerwelt) [01:25:00] (03CR) 10jenkins-bot: [V: 04-1] Closing & reopening topic [extensions/Flow] - 10https://gerrit.wikimedia.org/r/118399 (owner: 10Bsitu) [01:25:23] (03PS3) 10Physikerwelt: Fix: Remove MathML out if used as input [services/mathoid] - 10https://gerrit.wikimedia.org/r/119953 [01:26:07] (03CR) 10Krinkle: "Rebased to resolve conflict" [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/118430 (owner: 10Krinkle) [01:26:15] anyone have a clue what this is supposed to be testing? [01:26:16] {{#ifexpr:0*{{{1|}}}0=0|foo|bar}} [01:27:27] jackmcbarn: I suppose, if you call the template with no parameters, it results in foo, if you pass a valid non-zero number, it'll be bar [01:27:30] (03CR) 10Kaldari: [C: 04-1] "The new functions in VectorBeta.hooks.php should have basic function documentation per the coding conventions. Granted, most of them seem " (032 comments) [extensions/VectorBeta] - 10https://gerrit.wikimedia.org/r/117903 (owner: 10Jdlrobson) [01:27:37] (03PS1) 10Brian Wolff: Add default implementation of getLength to base class. [core] - 10https://gerrit.wikimedia.org/r/120177 [01:28:13] (03CR) 10Krinkle: Add default implementation of getLength to base class. (031 comment) [core] - 10https://gerrit.wikimedia.org/r/120177 (owner: 10Brian Wolff) [01:28:41] jackmcbarn: I would guess that {{{1|}}} is being checked that it dissapears properly, and doesn't cause any syntax error in the expression [01:28:49] Krinkle: {{#iferror:{{#expr:{{{1|}}}}} was already ran and determined to not fail [01:29:05] (03CR) 10Physikerwelt: [C: 032] Fix: Remove MathML out if used as input [services/mathoid] - 10https://gerrit.wikimedia.org/r/119953 (owner: 10Physikerwelt) [01:29:26] (03PS2) 10Brian Wolff: Add default implementation of getLength to base MediaHandler class [core] - 10https://gerrit.wikimedia.org/r/120177 [01:30:47] If {{{1|}}} was replaced with a newline, that could conceivably cause {{#iferror:{{#expr:{{{1|}}}}} to be fine, but {{#ifexpr:0*{{{1|}}}0=0|foo|bar}} to fail maybe (I don't know how #expr handles newlines) [01:31:39] ugh. i'll track down who wrote it [01:34:08] (03PS1) 10Physikerwelt: Revert "Fix: Remove MathML out if used as input" [services/mathoid] - 10https://gerrit.wikimedia.org/r/120178 [01:34:35] (03CR) 10Physikerwelt: [C: 032] Revert "Fix: Remove MathML out if used as input" [services/mathoid] - 10https://gerrit.wikimedia.org/r/120178 (owner: 10Physikerwelt) [01:34:57] (03CR) 10Physikerwelt: [V: 032] Revert "Fix: Remove MathML out if used as input" [services/mathoid] - 10https://gerrit.wikimedia.org/r/120178 (owner: 10Physikerwelt) [01:43:50] (03PS1) 10Physikerwelt: Remove windows style line endings [services/mathoid] - 10https://gerrit.wikimedia.org/r/120179 [01:44:37] (03PS2) 10Physikerwelt: Remove windows style line endings [services/mathoid] - 10https://gerrit.wikimedia.org/r/120179 [01:45:50] (03CR) 10Physikerwelt: [C: 032 V: 032] Remove windows style line endings [services/mathoid] - 10https://gerrit.wikimedia.org/r/120179 (owner: 10Physikerwelt) [01:46:45] (03PS13) 10Bsitu: Closing & reopening topic [extensions/Flow] - 10https://gerrit.wikimedia.org/r/118399 [01:47:47] (03CR) 10Hoo man: [C: 031] "I would like Chris or Anomie to have another look, untested" (031 comment) [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/118430 (owner: 10Krinkle) [01:55:09] (03CR) 10Hoo man: [C: 032] Remove unneeded show() in WikiEditor toolbar [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/118992 (owner: 10TheDJ) [01:55:20] (03Merged) 10jenkins-bot: Remove unneeded show() in WikiEditor toolbar [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/118992 (owner: 10TheDJ) [02:04:47] (03PS1) 10Physikerwelt: Fix: Remove MathML out if used as input [services/mathoid] - 10https://gerrit.wikimedia.org/r/120182 [02:05:42] (03PS2) 10Physikerwelt: Fix: Remove MathML out if used as input [services/mathoid] - 10https://gerrit.wikimedia.org/r/120182 [02:06:18] (03CR) 10Physikerwelt: [C: 032] Fix: Remove MathML out if used as input [services/mathoid] - 10https://gerrit.wikimedia.org/r/120182 (owner: 10Physikerwelt) [02:20:12] (03CR) 10AndyRussG: "K, working on it. Next patch will likely be WIP again." (038 comments) [extensions/Campaigns] (wip/editorcampaigns) - 10https://gerrit.wikimedia.org/r/116221 (owner: 10AndyRussG) [02:21:40] (03PS9) 10Hoo man: Support searching for multiple filter IDs [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/105617 (owner: 10Jackmcbarn) [02:21:43] (03PS1) 10Physikerwelt: Release version 0.2.3 [services/mathoid] - 10https://gerrit.wikimedia.org/r/120183 [02:28:48] (03PS1) 10Brian Wolff: Add support for specifying headers in FileRepo::quickImport [core] - 10https://gerrit.wikimedia.org/r/120184 [02:33:03] (03CR) 10Physikerwelt: "see" [services/mathoid] - 10https://gerrit.wikimedia.org/r/120183 (owner: 10Physikerwelt) [02:33:33] (03PS1) 10Brian Wolff: Set X-Content-Duration header on ogg transcodes. [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/120185 [02:34:43] (03CR) 10Brian Wolff: "I should note, I didn't 100% test this, as I don't have a filebackend that supports metadata set up." [core] - 10https://gerrit.wikimedia.org/r/120184 (owner: 10Brian Wolff) [02:40:19] (03CR) 10Hoo man: [C: 032] "Finally :)" [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/105617 (owner: 10Jackmcbarn) [02:40:25] (03Merged) 10jenkins-bot: Support searching for multiple filter IDs [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/105617 (owner: 10Jackmcbarn) [03:00:48] (03CR) 10BryanDavis: [C: 031] Make DjVu metadata be stored as serialized PHP array. (031 comment) [core] - 10https://gerrit.wikimedia.org/r/99544 (owner: 10Brian Wolff) [03:11:04] (03CR) 10Brian Wolff: [C: 04-1] "I was testing this. In certain cases a non-registered account can make edits. This can happen in two cases (That I can think of off the to" [core] - 10https://gerrit.wikimedia.org/r/117854 (owner: 10Ganeshaditya1) [03:12:10] (03CR) 10Brian Wolff: Display a warning when the user name looked up is not registered. (031 comment) [core] - 10https://gerrit.wikimedia.org/r/117854 (owner: 10Ganeshaditya1) [03:20:24] (03CR) 10Jackmcbarn: "IMO, the message is even more useful if an unregistered account has edits." [core] - 10https://gerrit.wikimedia.org/r/117854 (owner: 10Ganeshaditya1) [03:28:37] (03PS7) 10Bsitu: Closing & Summarizing topic frontend changes [extensions/Flow] - 10https://gerrit.wikimedia.org/r/119640 [03:39:10] (03PS5) 10Brian Wolff: Decode html entities before comparing strings in #ifeq: and #switch [extensions/ParserFunctions] - 10https://gerrit.wikimedia.org/r/113518 [03:41:22] (03CR) 10Brian Wolff: "re matmarex" (031 comment) [core] - 10https://gerrit.wikimedia.org/r/116227 (owner: 10Brian Wolff) [03:42:07] (03PS14) 10Bsitu: Closing & reopening topic [extensions/Flow] - 10https://gerrit.wikimedia.org/r/118399 [03:50:12] (03PS8) 10Bsitu: Closing & Summarizing topic frontend changes [extensions/Flow] - 10https://gerrit.wikimedia.org/r/119640 [03:55:43] (03PS9) 10Bsitu: Closing & Summarizing topic frontend changes [extensions/Flow] - 10https://gerrit.wikimedia.org/r/119640 [03:55:47] (03CR) 10jenkins-bot: [V: 04-1] Closing & Summarizing topic frontend changes [extensions/Flow] - 10https://gerrit.wikimedia.org/r/119640 (owner: 10Bsitu) [03:58:14] (03PS10) 10Bsitu: Closing & Summarizing topic frontend changes [extensions/Flow] - 10https://gerrit.wikimedia.org/r/119640 [04:27:59] (03CR) 10Brian Wolff: [C: 04-1] "This is looking much closer to being ready. Good work." (0316 comments) [core] - 10https://gerrit.wikimedia.org/r/112323 (owner: 10Kunalgrover05) [04:34:35] (03CR) 10Brian Wolff: "Ok, lets say my previous comment on that is a "neutral 0" instead of a -1, and have my -1 be just for being pedantic on the commit message" [core] - 10https://gerrit.wikimedia.org/r/117854 (owner: 10Ganeshaditya1) [04:37:22] (03PS10) 10Ganeshaditya1: Display a warning when the user name looked up is not registered. [core] - 10https://gerrit.wikimedia.org/r/117854 [04:38:47] (03PS1) 10Prtksxna: Disable NavigationPopups (Gadget) is Popups (Extension) is enabled [extensions/Popups] - 10https://gerrit.wikimedia.org/r/120188 [04:52:52] (03CR) 10Prtksxna: [C: 04-1] "I can't see any screenshot on Special:Preferences#mw-prefsection-betafeatures now." [extensions/Popups] - 10https://gerrit.wikimedia.org/r/120155 (owner: 10Amire80) [04:56:13] (03PS6) 10Brian Wolff: Add Special:ListDuplicatedFiles expensive query special page. [core] - 10https://gerrit.wikimedia.org/r/85446 [04:56:25] (03CR) 10Brian Wolff: "PS6: rebase" [core] - 10https://gerrit.wikimedia.org/r/85446 (owner: 10Brian Wolff) [04:58:55] (03PS2) 10Brian Wolff: Make play button have higher z-index so its clickable. [extensions/MwEmbedSupport] - 10https://gerrit.wikimedia.org/r/108637 [05:32:03] (03CR) 10Aaron Schulz: [C: 04-1] Add support for specifying headers in FileRepo::quickImport (031 comment) [core] - 10https://gerrit.wikimedia.org/r/120184 (owner: 10Brian Wolff) [05:43:18] (03PS1) 10Spage: Handle "N seconds ago" instead of dying [extensions/Flow] - 10https://gerrit.wikimedia.org/r/120189 [05:43:31] (03CR) 10jenkins-bot: [V: 04-1] Handle "N seconds ago" instead of dying [extensions/Flow] - 10https://gerrit.wikimedia.org/r/120189 (owner: 10Spage) [05:46:06] (03CR) 10Aaron Schulz: [C: 031] "One minor thing" (031 comment) [core] - 10https://gerrit.wikimedia.org/r/85446 (owner: 10Brian Wolff) [05:47:00] (03CR) 10Spage: [C: 032 V: 032] "Jenkins doesn't run browser tests, so this is unrelated, so I'll force it." [extensions/Flow] - 10https://gerrit.wikimedia.org/r/120189 (owner: 10Spage) [05:47:12] (03Merged) 10jenkins-bot: Handle "N seconds ago" instead of dying [extensions/Flow] - 10https://gerrit.wikimedia.org/r/120189 (owner: 10Spage) [05:54:32] (03PS2) 10Hiong3-eng5: MW WLD prefix compatibility fix [extensions/WikiLexicalData] - 10https://gerrit.wikimedia.org/r/119446 [06:33:19] (03CR) 10Rahul mishra: "Hello siebrand, i have tried to fix this bug, please look at it and tell me if this was expected or something else. If what i did is not e" [wikimedia/wikimania-scholarships] - 10https://gerrit.wikimedia.org/r/120146 (owner: 10Rahul mishra) [06:51:13] (03PS10) 10TTO: Update default contents of interwiki table [core] - 10https://gerrit.wikimedia.org/r/84303 [06:54:22] (03PS2) 10Adamw: add Extension:FundraisingChart; notify wikimedia-dev about FR commits [labs/tools/grrrit] - 10https://gerrit.wikimedia.org/r/119643 [06:55:02] (03PS3) 10Adamw: add Extension:FundraisingChart; notify wikimedia-dev about FR commits [labs/tools/grrrit] - 10https://gerrit.wikimedia.org/r/119643 [07:00:29] (03PS2) 10Adamw: Make the "blacklist" variable an array cos that's slightly nicer than a space-separated string [labs/tools/grrrit] - 10https://gerrit.wikimedia.org/r/119924 [08:32:00] (03PS1) 10Fantasticfears: Add display: block; property to labelElement to make the text-overflow: ellipsis work correctly [core] - 10https://gerrit.wikimedia.org/r/120192 [08:40:04] (03CR) 10Nikerabbit: Don't require hook subscribers to know language direction (031 comment) [extensions/BetaFeatures] - 10https://gerrit.wikimedia.org/r/118963 (owner: 10Legoktm) [08:40:50] (03CR) 10Fantasticfears: "You may want to have a look at:" [core] - 10https://gerrit.wikimedia.org/r/120192 (owner: 10Fantasticfears) [08:41:50] (03CR) 10Nikerabbit: "Too bad this solution is not backwards compatible: Extensions using this new support will throw warnings with older BetaFeatures. I guess " [extensions/BetaFeatures] - 10https://gerrit.wikimedia.org/r/118963 (owner: 10Legoktm) [09:02:18] (03PS13) 10Kunalgrover05: Implement listing for tracking categories [core] - 10https://gerrit.wikimedia.org/r/112323 [09:04:33] (03CR) 10jenkins-bot: [V: 04-1] Implement listing for tracking categories [core] - 10https://gerrit.wikimedia.org/r/112323 (owner: 10Kunalgrover05) [09:23:32] (03PS1) 10Amire80: Tabs for indentation [extensions/BetaFeatures] - 10https://gerrit.wikimedia.org/r/120195 [09:34:09] (03PS14) 10Kunalgrover05: Implement listing for tracking categories [core] - 10https://gerrit.wikimedia.org/r/112323 [09:34:37] (03CR) 10Siebrand: [C: 032] Tabs for indentation [extensions/BetaFeatures] - 10https://gerrit.wikimedia.org/r/120195 (owner: 10Amire80) [09:35:12] (03Merged) 10jenkins-bot: Tabs for indentation [extensions/BetaFeatures] - 10https://gerrit.wikimedia.org/r/120195 (owner: 10Amire80) [09:36:16] (03CR) 10jenkins-bot: [V: 04-1] Implement listing for tracking categories [core] - 10https://gerrit.wikimedia.org/r/112323 (owner: 10Kunalgrover05) [09:36:18] (03CR) 10Siebrand: [C: 04-1] "Per Bryan." [wikimedia/wikimania-scholarships] - 10https://gerrit.wikimedia.org/r/120146 (owner: 10Rahul mishra) [09:38:10] (03CR) 10Siebrand: [C: 04-1] "Looking better. Key name can be more specific." (031 comment) [core] - 10https://gerrit.wikimedia.org/r/117854 (owner: 10Ganeshaditya1) [09:38:56] (03CR) 10Siebrand: [C: 031] "L10n reviewed." [extensions/Flow] - 10https://gerrit.wikimedia.org/r/119640 (owner: 10Bsitu) [09:39:33] (03PS15) 10Kunalgrover05: Implement listing for tracking categories [core] - 10https://gerrit.wikimedia.org/r/112323 [09:40:02] (03CR) 10Siebrand: [C: 031] "i18n/L10n reviewed." [extensions/Flow] - 10https://gerrit.wikimedia.org/r/118399 (owner: 10Bsitu) [09:44:08] (03CR) 10Siebrand: [C: 04-1] "i18n/L10n reviewed." (031 comment) [extensions/GlobalBlocking] - 10https://gerrit.wikimedia.org/r/119915 (owner: 10Hoo man) [10:55:16] (03CR) 10Bartosz Dziewoński: "OOjs is a an external library, this patch probably has to submitted somewhere else (but I'm not sure where exactly)." [core] - 10https://gerrit.wikimedia.org/r/120192 (owner: 10Fantasticfears) [12:39:32] (03PS1) 10Nikerabbit: Give name for oojs-ui i18n files [core] - 10https://gerrit.wikimedia.org/r/120202 [14:03:45] (03PS1) 10Nikerabbit: Add a few @since to mediawiki.api [core] - 10https://gerrit.wikimedia.org/r/120209 [14:25:56] (03CR) 10Addshore: [C: 032] Add a few @since to mediawiki.api [core] - 10https://gerrit.wikimedia.org/r/120209 (owner: 10Nikerabbit) [14:28:23] Working on this bug: https://bugzilla.wikimedia.org/show_bug.cgi?id=26934. Contribution page uses ContributionsToolLinks hook. So for action=history a new hook is to be created? any ideas? [14:29:35] (03Merged) 10jenkins-bot: Add a few @since to mediawiki.api [core] - 10https://gerrit.wikimedia.org/r/120209 (owner: 10Nikerabbit) [16:28:07] (03CR) 10Amire80: "Do you have the latest version of the BetaFeatures extension? This commit depends on I1c72aaa3f847b1b7679113f2b88cbb92adf0f936 ." [extensions/Popups] - 10https://gerrit.wikimedia.org/r/120155 (owner: 10Amire80) [16:43:56] (03PS1) 10Yurik: Add phpinfo() as info.php to the root [vagrant] - 10https://gerrit.wikimedia.org/r/120214 [16:52:25] (03CR) 10BryanDavis: [C: 032] Add phpinfo() as info.php to the root [vagrant] - 10https://gerrit.wikimedia.org/r/120214 (owner: 10Yurik) [16:52:28] (03Merged) 10jenkins-bot: Add phpinfo() as info.php to the root [vagrant] - 10https://gerrit.wikimedia.org/r/120214 (owner: 10Yurik) [16:59:19] (03CR) 10BryanDavis: "This puppet fact is used by the virtualbox module as part of the update-guest-additions script. I think we can probably kill this function" [vagrant] - 10https://gerrit.wikimedia.org/r/116676 (owner: 10MarkAHershberger) [17:14:13] (03CR) 10Siebrand: [C: 032] Give name for oojs-ui i18n files [core] - 10https://gerrit.wikimedia.org/r/120202 (owner: 10Nikerabbit) [17:18:41] (03Merged) 10jenkins-bot: Give name for oojs-ui i18n files [core] - 10https://gerrit.wikimedia.org/r/120202 (owner: 10Nikerabbit) [17:34:17] (03PS1) 10Nikerabbit: Fix border css [extensions/APC] - 10https://gerrit.wikimedia.org/r/120227 [17:35:28] (03CR) 10Nemo bis: [C: 031] "Per https://developer.mozilla.org/en-US/docs/Web/CSS/border#Syntax" [extensions/APC] - 10https://gerrit.wikimedia.org/r/120227 (owner: 10Nikerabbit) [17:44:51] (03PS1) 10Nikerabbit: Fix border css [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/120232 [17:48:14] (03PS1) 10Nikerabbit: Fix border css [extensions/LiquidThreads] - 10https://gerrit.wikimedia.org/r/120233 [17:49:36] (03CR) 10Jdlrobson: Rewrite the navigation links under the heading (032 comments) [extensions/VectorBeta] - 10https://gerrit.wikimedia.org/r/117903 (owner: 10Jdlrobson) [17:49:51] (03PS19) 10Jdlrobson: Rewrite the navigation links under the heading [extensions/VectorBeta] - 10https://gerrit.wikimedia.org/r/117903 [17:49:54] (03PS16) 10Jdlrobson: Give Vector/Winter Minerva's hamburger menu icon [extensions/VectorBeta] - 10https://gerrit.wikimedia.org/r/117927 [18:11:32] (03CR) 10Alex Monk: [C: 032] Fix border css [extensions/LiquidThreads] - 10https://gerrit.wikimedia.org/r/120233 (owner: 10Nikerabbit) [18:11:34] (03Merged) 10jenkins-bot: Fix border css [extensions/LiquidThreads] - 10https://gerrit.wikimedia.org/r/120233 (owner: 10Nikerabbit) [18:11:52] (03PS1) 10Amire80: Allow having screenshots by language [extensions/BetaFeatures] - 10https://gerrit.wikimedia.org/r/120237 [18:15:05] (03PS1) 10Amire80: Specify screenshots by language in a more robust way [extensions/VectorBeta] - 10https://gerrit.wikimedia.org/r/120238 [18:15:46] (03CR) 10Amire80: "Needed in I00241c0a5b046513d822318e273afed65617268f ." [extensions/BetaFeatures] - 10https://gerrit.wikimedia.org/r/120237 (owner: 10Amire80) [18:24:21] (03CR) 10Addshore: Simplify setup of RevisionCollectionPermissionsTest (031 comment) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/118729 (owner: 10Addshore) [18:48:05] (03CR) 10BryanDavis: "Cool stuff. I tried to answer a few of your questions." (038 comments) [vagrant] - 10https://gerrit.wikimedia.org/r/119216 (owner: 10Nemo bis) [18:49:08] (03PS1) 10BryanDavis: Remove reference to provider.driver.version and virtualbox class [vagrant] - 10https://gerrit.wikimedia.org/r/120239 [18:51:14] (03Abandoned) 10BryanDavis: Remove reference to provider.driver.version and virtualbox class [vagrant] - 10https://gerrit.wikimedia.org/r/120239 (owner: 10BryanDavis) [18:52:05] (03PS2) 10BryanDavis: Remove reference to provider.driver.version and virtualbox class [vagrant] - 10https://gerrit.wikimedia.org/r/116676 (owner: 10MarkAHershberger) [18:53:02] (03CR) 10BryanDavis: "Amended to remove virtualbox class entirely" [vagrant] - 10https://gerrit.wikimedia.org/r/116676 (owner: 10MarkAHershberger) [18:53:12] (03PS3) 10BryanDavis: Remove reference to provider.driver.version and virtualbox class [vagrant] - 10https://gerrit.wikimedia.org/r/116676 (owner: 10MarkAHershberger) [18:57:06] (03CR) 10Aaron Schulz: [C: 031] Add default implementation of getLength to base MediaHandler class (031 comment) [core] - 10https://gerrit.wikimedia.org/r/120177 (owner: 10Brian Wolff) [19:01:17] (03CR) 10Parent5446: [C: 031] Remove reference to provider.driver.version and virtualbox class [vagrant] - 10https://gerrit.wikimedia.org/r/116676 (owner: 10MarkAHershberger) [19:02:43] (03CR) 10Addshore: Implement ApiQuerySites class (033 comments) [core] - 10https://gerrit.wikimedia.org/r/110427 (owner: 10Addshore) [19:15:53] I have done a password reset on wikitech, and now I can't login neither with my old nor the new password. Typos have been checked for (multiple resets), so is there anything else to consider? [19:17:55] (03PS8) 10Umherirrender: Use TablePager on Special:ProtectedTitles [core] - 10https://gerrit.wikimedia.org/r/98252 [19:18:51] (03CR) 10Umherirrender: "Patch Set 8: Rebased" [core] - 10https://gerrit.wikimedia.org/r/98252 (owner: 10Umherirrender) [19:27:42] (03CR) 10Aaron Schulz: [C: 04-1] "The RunJobs special page change and upload job changes are fine. Note sure about the the others. I does feel like the job should manage th" (031 comment) [core] - 10https://gerrit.wikimedia.org/r/119932 (owner: 10Brian Wolff) [19:28:41] (03CR) 10Aaron Schulz: Rollback transactions if job throws an exception. (031 comment) [core] - 10https://gerrit.wikimedia.org/r/119932 (owner: 10Brian Wolff) [20:19:04] tested with another reset -- after entering a new password on Special:ChangePassword, I'm thrown back to UserLogin with a login error [20:23:32] KillerWalrus: on wikitech? [20:23:53] if yes it happened to me too in the past, your password is too strong [20:24:03] choose a very long one with less strange characters [20:26:19] Nemo_bis: the new or the old? [20:32:03] Nemo_bis: omg thanks [20:33:04] but it appears to be the same for ChangePassword as well [20:35:50] hm? [20:36:06] that wiki is misconfigured, you can't use all sorts of passwords [20:36:37] Nemo_bis: That's odd, my old pw did contain things like $ and accented characters [20:37:30] yeah, just give up and use ascii only ;) [20:38:18] Nemo_bis: an sha1sum failed too =S [20:38:57] but many thanks :) [20:38:58] (03PS9) 10UltrasonicNXT: WIP - Rewrite [extensions/WikiForum] - 10https://gerrit.wikimedia.org/r/116258 [21:10:29] (03CR) 10Jforrester: "Rather than having an array of an array, can't we just have an array of languages with three special values (for default, ltr default, and" [extensions/BetaFeatures] - 10https://gerrit.wikimedia.org/r/120237 (owner: 10Amire80) [21:13:05] (03CR) 10Amire80: "I'm not sure that it would work for what is needed in Typography Refresh ( I00241c0a5b046513d822318e273afed65617268f )." [extensions/BetaFeatures] - 10https://gerrit.wikimedia.org/r/120237 (owner: 10Amire80) [21:13:12] (03CR) 10Parent5446: "Are the messages associated with Percona used anywhere else? If not then they should probably be removed." [core] - 10https://gerrit.wikimedia.org/r/120166 (owner: 10PleaseStand) [21:19:05] (03CR) 10Parent5446: [C: 04-1] "Almost good. Haven't tested." (033 comments) [core] - 10https://gerrit.wikimedia.org/r/112323 (owner: 10Kunalgrover05) [21:19:58] (03CR) 10Parent5446: [C: 032] Remove some unneeded local vars from EditPage.php [core] - 10https://gerrit.wikimedia.org/r/119536 (owner: 10Umherirrender) [21:22:39] (03PS1) 10Umherirrender: Accept null in HTMLRadioField::validate [core] - 10https://gerrit.wikimedia.org/r/120313 [21:26:09] (03Merged) 10jenkins-bot: Remove some unneeded local vars from EditPage.php [core] - 10https://gerrit.wikimedia.org/r/119536 (owner: 10Umherirrender) [21:32:45] (03CR) 10Jforrester: "Sure it would. This change as written now requires setting LTR and RTL default values (or having no over-rides at all), and assigning lang" [extensions/BetaFeatures] - 10https://gerrit.wikimedia.org/r/120237 (owner: 10Amire80) [21:33:42] (03CR) 10Parent5446: [C: 032] AutoLoader: Remove "Class ... not found" debug message [core] - 10https://gerrit.wikimedia.org/r/120024 (owner: 10PleaseStand) [21:37:42] (03Merged) 10jenkins-bot: AutoLoader: Remove "Class ... not found" debug message [core] - 10https://gerrit.wikimedia.org/r/120024 (owner: 10PleaseStand) [21:38:34] (03CR) 10Ori.livneh: "Impressive stuff, Nemo!" (032 comments) [vagrant] - 10https://gerrit.wikimedia.org/r/119216 (owner: 10Nemo bis) [21:43:40] (03CR) 10Nemo bis: "Thanks a lot to both! I will go through this tomorrow or the day after." (031 comment) [vagrant] - 10https://gerrit.wikimedia.org/r/119216 (owner: 10Nemo bis) [21:52:26] (03CR) 10Siebrand: [C: 032] Fix border css [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/120232 (owner: 10Nikerabbit) [21:52:33] (03CR) 10Siebrand: [C: 032] Fix border css [extensions/APC] - 10https://gerrit.wikimedia.org/r/120227 (owner: 10Nikerabbit) [21:52:41] (03Merged) 10jenkins-bot: Fix border css [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/120232 (owner: 10Nikerabbit) [21:52:43] (03Merged) 10jenkins-bot: Fix border css [extensions/APC] - 10https://gerrit.wikimedia.org/r/120227 (owner: 10Nikerabbit) [21:56:49] (03CR) 10BryanDavis: Lot of standard performance tweaks for those who want them (031 comment) [vagrant] - 10https://gerrit.wikimedia.org/r/119216 (owner: 10Nemo bis) [22:07:41] (03PS1) 10Siebrand: Update formatting for includes/specialpage [core] - 10https://gerrit.wikimedia.org/r/120316 [22:11:21] (03PS1) 10Siebrand: Declare visibility on class properties of RedirectSpecialPage [core] - 10https://gerrit.wikimedia.org/r/120317 [22:13:22] (03PS1) 10Siebrand: Make CodeSniffer checks pass on includes/specialpages/ [core] - 10https://gerrit.wikimedia.org/r/120318 [22:20:50] (03PS1) 10MarkAHershberger: Set a title for the context during import on the cli [core] (REL1_22) - 10https://gerrit.wikimedia.org/r/120319 [22:21:16] (03PS1) 10MarkAHershberger: Set a title for the context during import on the cli [core] (REL1_21) - 10https://gerrit.wikimedia.org/r/120320 [22:22:03] (03PS1) 10MarkAHershberger: Set a title for the context during import on the cli [core] (REL1_19) - 10https://gerrit.wikimedia.org/r/120321 [22:48:24] With the introduction of json format for messages, should special page aliases still be used via $wgExtensionMessagesFiles, or should they use json format too? [22:50:06] (03PS1) 10MarkAHershberger: Provide RequestContext from fixDoubleRedirects [core] - 10https://gerrit.wikimedia.org/r/120325 [22:50:26] KillerWalrus: only messages so far [22:50:37] Nikerabbit: thanks :) [22:51:33] (03PS1) 10Siebrand: Update formatting for includes/specials/ [core] - 10https://gerrit.wikimedia.org/r/120326 [22:52:41] (03PS2) 10MarkAHershberger: Provide RequestContext from fixDoubleRedirects [core] - 10https://gerrit.wikimedia.org/r/120325 [22:53:27] (03PS3) 10MarkAHershberger: Provide RequestContext from fixDoubleRedirects [core] - 10https://gerrit.wikimedia.org/r/120325 [23:06:05] (03CR) 10PleaseStand: "Message "version-db-percona-url" is used in installer message "config-dbsupport-mysql". So no, it's not unused." [core] - 10https://gerrit.wikimedia.org/r/120166 (owner: 10PleaseStand) [23:25:19] (03PS1) 10Siebrand: Fix CodeSniffer errors and warnings in includes/specials (1) [core] - 10https://gerrit.wikimedia.org/r/120328 [23:25:21] (03PS1) 10Siebrand: Declare visibility on class properties of LoginForm [core] - 10https://gerrit.wikimedia.org/r/120329 [23:26:15] (03PS2) 10Siebrand: Declare visibility on class properties of LoginForm [core] - 10https://gerrit.wikimedia.org/r/120329 [23:32:11] (03CR) 10Jforrester: [C: 04-2] "OOjs UI is an external library; changes should be submitted to its git repo:" [core] - 10https://gerrit.wikimedia.org/r/120192 (owner: 10Fantasticfears) [23:43:00] (03PS11) 10Aaron Schulz: Added a Redis pool counter class [core] - 10https://gerrit.wikimedia.org/r/118955 [23:45:54] (03CR) 10Legoktm: "Looks fine otherwise." (031 comment) [extensions/Popups] - 10https://gerrit.wikimedia.org/r/120188 (owner: 10Prtksxna) [23:54:11] ori: have you had a chance to poke at that pool counter class some more? [23:59:52] (03PS1) 10Siebrand: Fix CodeSniffer errors and warnings in includes/specials (2) [core] - 10https://gerrit.wikimedia.org/r/120330