[00:00:45] (03PS5) 10Bsitu: Closing & Summarizing topic frontend changes [extensions/Flow] - 10https://gerrit.wikimedia.org/r/119640 [00:00:56] (03CR) 10jenkins-bot: [V: 04-1] Closing & Summarizing topic frontend changes [extensions/Flow] - 10https://gerrit.wikimedia.org/r/119640 (owner: 10Bsitu) [00:02:41] (03CR) 10Bsitu: [C: 04-1] "Found some bugs when working on dependent patch" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/118399 (owner: 10Bsitu) [00:03:18] (03PS1) 10Jdlrobson: Hygiene: Cleanup VectorBeta.php resources [extensions/VectorBeta] - 10https://gerrit.wikimedia.org/r/119904 [00:06:27] (03PS16) 10Jdlrobson: Rewrite the navigation links under the heading [extensions/VectorBeta] - 10https://gerrit.wikimedia.org/r/117903 [00:06:40] (03PS1) 10Kaldari: Adding Wikivoyage to the default interwiki map [core] - 10https://gerrit.wikimedia.org/r/119905 [00:06:49] (03PS2) 10Jdlrobson: Hygiene: Cleanup VectorBeta.php resources [extensions/VectorBeta] - 10https://gerrit.wikimedia.org/r/119904 [00:14:31] (03CR) 10Bencmq: Display timestamp in local timezone and language per user preference (031 comment) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/119877 (owner: 10Bencmq) [00:16:42] (03PS1) 10Kaldari: Updating link protocols for WMF wikis in the interwiki map [core] - 10https://gerrit.wikimedia.org/r/119907 [00:18:42] (03PS2) 10Ori.livneh: Log usage of deprecated JavaScript functionality [extensions/WikimediaEvents] - 10https://gerrit.wikimedia.org/r/119903 [00:18:45] (03CR) 10jenkins-bot: [V: 04-1] Log usage of deprecated JavaScript functionality [extensions/WikimediaEvents] - 10https://gerrit.wikimedia.org/r/119903 (owner: 10Ori.livneh) [00:21:58] (03PS3) 10Ori.livneh: Log usage of deprecated JavaScript functionality [extensions/WikimediaEvents] - 10https://gerrit.wikimedia.org/r/119903 [00:24:16] (03CR) 10Ori.livneh: Log usage of deprecated JavaScript functionality (031 comment) [extensions/WikimediaEvents] - 10https://gerrit.wikimedia.org/r/119903 (owner: 10Ori.livneh) [00:26:47] (03CR) 10Ori.livneh: [C: 04-1] "Could you file a bug suggesting how this could be fixed comprehensively (even if only in outline), and note it in a TODO comment in the co" [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/117916 (owner: 10Aaron Schulz) [00:29:09] (03PS2) 10Wctaiwan: Change the UI of Special:Thanks [extensions/Thanks] - 10https://gerrit.wikimedia.org/r/119879 [00:45:08] (03PS2) 10Ori.livneh: Try to reduce lock contention due to duplicated INSERTS [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/117916 (owner: 10Aaron Schulz) [00:45:35] (03CR) 10Ori.livneh: [C: 032] "Added a comment in PS2" [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/117916 (owner: 10Aaron Schulz) [00:45:41] (03Merged) 10jenkins-bot: Try to reduce lock contention due to duplicated INSERTS [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/117916 (owner: 10Aaron Schulz) [00:48:06] (03CR) 10Krinkle: [C: 04-1] Log usage of deprecated JavaScript functionality (031 comment) [extensions/WikimediaEvents] - 10https://gerrit.wikimedia.org/r/119903 (owner: 10Ori.livneh) [00:53:44] (03PS4) 10Ori.livneh: Log usage of deprecated JavaScript functionality [extensions/WikimediaEvents] - 10https://gerrit.wikimedia.org/r/119903 [00:55:30] (03CR) 10Ori.livneh: Log usage of deprecated JavaScript functionality (031 comment) [extensions/WikimediaEvents] - 10https://gerrit.wikimedia.org/r/119903 (owner: 10Ori.livneh) [00:57:20] (03PS6) 10Bsitu: Closing & Summarizing topic frontend changes [extensions/Flow] - 10https://gerrit.wikimedia.org/r/119640 [00:57:32] (03CR) 10jenkins-bot: [V: 04-1] Closing & Summarizing topic frontend changes [extensions/Flow] - 10https://gerrit.wikimedia.org/r/119640 (owner: 10Bsitu) [01:02:54] Krinkle: getElementsByClassName is deprecated? really? [01:03:19] huh: document.getElementsByClassName is not deprecated, that's in fact a relatively new feature [01:03:32] but the global 'getElementsByClassName' is a legacy function that mediawiki.legacy.wikibits.js provides [01:03:39] and that one has been deprecated for many years now [01:03:40] ah [01:03:50] sorry [01:03:58] Confusion is understandable :) [01:04:01] (03PS1) 10Hoo man: Optionally place a local block when globally blocking [extensions/GlobalBlocking] - 10https://gerrit.wikimedia.org/r/119915 [01:05:52] (03PS2) 10Hoo man: Optionally place a local block when globally blocking [extensions/GlobalBlocking] - 10https://gerrit.wikimedia.org/r/119915 [01:12:34] (03CR) 10Krinkle: Log usage of deprecated JavaScript functionality (032 comments) [extensions/WikimediaEvents] - 10https://gerrit.wikimedia.org/r/119903 (owner: 10Ori.livneh) [01:18:45] (03CR) 10Krinkle: [C: 04-2] "Holding back for now pending potential architecture changes making this obsolete or different. The main issue I personally see might be an" [core] - 10https://gerrit.wikimedia.org/r/74293 (owner: 10MaxSem) [01:21:12] (03CR) 10Ori.livneh: "@Krinkle: Yes, the settings are very conservative, but that's how I usually start with data collection jobs. We can up it as appropriate o" [extensions/WikimediaEvents] - 10https://gerrit.wikimedia.org/r/119903 (owner: 10Ori.livneh) [01:28:30] (03PS1) 10PleaseStand: Remove $wgHttpOnlyBlacklist [core] - 10https://gerrit.wikimedia.org/r/119919 [01:30:39] Krinkle: Hi. [01:31:01] Krinkle: What do you think about MaxSem's Minifier proposal? [01:33:18] I've been pushing it in the back rooms for 2 years. [01:33:39] Roan and I have been thinking about how to do it asynchronously for a while, haven't found a good solution to the cache busting [01:34:28] https://www.mediawiki.org/wiki/Requests_for_comment/Minifier#Stupid_questions_41096 [01:34:51] I'm not sure I fully understand the proposal, though. [01:35:41] I guess I don't see the real pain points of the current system? [01:35:49] It seems like the goal is more aggressive minification. [01:37:55] (03PS1) 10EBernhardson: Revert "Auto-wrapping explicit escaper for templates" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/119920 [01:43:38] Gloria: Note that one big win no matter the strength of UglifyJS is taht it has built-in source maps support [01:43:53] we'd have to significantly alter and rewrite JavaScriptMinifier to support that [01:55:33] Hmmmm. [01:57:10] (03CR) 10EBernhardson: Display timestamp in local timezone and language per user preference (031 comment) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/119877 (owner: 10Bencmq) [02:01:30] (03PS3) 10Hoo man: Don't try to inline load ext.scribunto on mobile [extensions/Scribunto] - 10https://gerrit.wikimedia.org/r/118944 [02:02:59] (03PS1) 10Kaldari: Removing some old cruft from the default interwiki list [core] - 10https://gerrit.wikimedia.org/r/119923 [02:03:51] (03PS2) 10Kaldari: Removing some old cruft from the default interwiki list [core] - 10https://gerrit.wikimedia.org/r/119923 [02:05:15] kaldari: hi [02:05:20] I replied on [[m:IWM]], fyi [02:05:29] hello [02:05:48] (03CR) 10MZMcBride: "Does this commit have an associated bug report or mailing list discussion or something? I see the what, but I can't currently see the why." [extensions/WikimediaEvents] - 10https://gerrit.wikimedia.org/r/119903 (owner: 10Ori.livneh) [02:06:32] (03CR) 10BryanDavis: "> log('trace/lists/anytoken', token);" [core] - 10https://gerrit.wikimedia.org/r/112699 (owner: 10BryanDavis) [02:06:35] huh: thanks! [02:09:56] (03CR) 10Hoo man: [C: 031] "Looks good on first sight, needs manual testing" (031 comment) [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/105617 (owner: 10Jackmcbarn) [02:13:55] (03PS8) 10Hoo man: Add an API module for querying AntiSpoof results. [extensions/AntiSpoof] - 10https://gerrit.wikimedia.org/r/87546 (owner: 10Stwalkerster) [02:22:01] (03CR) 10Hoo man: [C: 032] Add an API module for querying AntiSpoof results. [extensions/AntiSpoof] - 10https://gerrit.wikimedia.org/r/87546 (owner: 10Stwalkerster) [02:22:05] (03Merged) 10jenkins-bot: Add an API module for querying AntiSpoof results. [extensions/AntiSpoof] - 10https://gerrit.wikimedia.org/r/87546 (owner: 10Stwalkerster) [02:31:17] (03CR) 10Jackmcbarn: Support searching for multiple filter IDs (031 comment) [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/105617 (owner: 10Jackmcbarn) [02:32:25] (03CR) 10EBernhardson: [C: 031] Remove Flow's mw-ui-button overrides [extensions/Flow] - 10https://gerrit.wikimedia.org/r/113066 (owner: 10Matthias Mullie) [02:35:46] (03CR) 10Hoo man: Support searching for multiple filter IDs (031 comment) [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/105617 (owner: 10Jackmcbarn) [02:36:14] (03CR) 10Physikerwelt: "Hi Frédéric," [extensions/Math] - 10https://gerrit.wikimedia.org/r/119010 (owner: 10Physikerwelt) [02:41:08] (03PS8) 10Jackmcbarn: Support searching for multiple filter IDs [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/105617 [02:44:41] (03PS14) 10Brian Wolff: Make Special:Whatlinkshere.php transcludable [core] - 10https://gerrit.wikimedia.org/r/106625 (owner: 10AalekhN) [02:44:50] (03CR) 10Brian Wolff: [C: 032] Make Special:Whatlinkshere.php transcludable [core] - 10https://gerrit.wikimedia.org/r/106625 (owner: 10AalekhN) [02:47:00] (03CR) 10Werdna: [C: 031] "Should be fine." [extensions/Flow] - 10https://gerrit.wikimedia.org/r/119920 (owner: 10EBernhardson) [02:49:43] (03Merged) 10jenkins-bot: Make Special:Whatlinkshere.php transcludable [core] - 10https://gerrit.wikimedia.org/r/106625 (owner: 10AalekhN) [02:58:18] (03CR) 10Werdna: "Going to fix these myself if that's cool." (032 comments) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/115530 (owner: 10EBernhardson) [03:06:10] (03PS10) 10Werdna: Split re-usable parts out of ContributionsQuery [extensions/Flow] - 10https://gerrit.wikimedia.org/r/115530 (owner: 10EBernhardson) [03:09:40] (03CR) 10Werdna: "Feel free to +2 PS10 if my rebase is sane." [extensions/Flow] - 10https://gerrit.wikimedia.org/r/115530 (owner: 10EBernhardson) [03:12:26] (03PS12) 10Werdna: Sort the combined header+topic revisions after merging [extensions/Flow] - 10https://gerrit.wikimedia.org/r/115531 (owner: 10EBernhardson) [03:21:39] Hello! just want to know what the performance bottleneck of mediawiki system? [03:21:54] I saw the funding message on wiki so I came here, I wish that I can help. [03:22:22] c9s: Wikimedia foundation funds are used for a lot of things (Including developing new features) [03:22:49] c9s: We're an open source project, you are definitely welcome to help [03:22:58] and have you ever considered about using Go as the backend system? I believe we can reduce a lot of server loading [03:23:52] rewriting all of MediaWiki in a different language would involve a lot of work [03:24:29] Using hip-hop type system is a more likely to happen thing [03:24:48] oh my thinking is that we don't need to write whole system in another language. we could just write a small part for the bottleneck [03:25:16] https://www.mediawiki.org/wiki/HHVM [03:25:29] are you using HHVM or HipHop C++ compiler ? [03:25:49] PHP to C++ compiler [03:25:53] There's plans to use HHVM in (near?) future, but it hasn't happened yet [03:27:52] ok, so currently you're still using zend PHP vm for production systems? [03:28:39] The really expensive parts of mediawiki get heavily cached and a lot of optimization attention, I don't think language changes would make a super huge difference (probably would make some difference) [03:28:41] yes [03:29:16] c9s: Yes, we're using php 5.3.10-1ubuntu3.10+wmf1 (via apache2handler) [03:29:42] c9s: If you're really curious, there is profiling info at https://noc.wikimedia.org/cgi-bin/report.py [03:30:00] server statistics at http://ganglia.wikimedia.org/latest/ [03:30:27] other various pretty graphs at https://gdash.wikimedia.org/ [03:30:45] what about the performance of entry editing/updating? [03:30:55] these can't be cached right? [03:31:14] Generally the most time is spent turning wikitext->html, which is cached heavily [03:31:54] Correct, you can't really cache operations that change things [03:32:07] cool, so the bottleneck is the wikitext parser [03:32:16] interesting graphs! [03:32:18] depends what operation you mean [03:32:28] I mean, an application doesn't have one "bottleneck" [03:32:31] it depends on the operation. [03:32:38] agree :-p [03:32:54] But yeah, wikitext parsing is probably one of our biggest users of CPU… that's why we have the Parsoid project [03:33:18] cool, let me see [03:34:32] c9s: From a save page prespective (I believe) saving the page into db itself isn't that bad, but in order to do that the software has to read the page to figure out all the categories etc, which can take time on a big page, so it comes back to page parsing being expensive [03:34:58] Can I make a suggestion? If you're really interested in getting into performance engineering, you should talk to us about our known challenges and what sort of projects you might want to pursue, rather than try to derive them from first principles. [03:35:28] I'm sure you're a great performance engineer, but we have our own on staff, and they do know sort of what they're doing and a thing or two about MediaWiki [03:35:52] You might consider chatting to ori, he always seems to have ideas about performance. [03:37:53] whenever i have endeavored to provide advice to bawolff i have found out that he knows more than me, usually by a comfortable margin [03:38:10] so i stay quiet :P [03:38:27] not bawolff, but c9s :p [03:39:15] xD [03:39:20] c9s: here's a way of thinking about it: [03:39:31] * bawolff just repeats what other people say most of the time, given you've been actively working on performance stuff for the last little while, you probably know more on the particulars than me [03:40:03] (03PS3) 10Wctaiwan: Change the UI of Special:Thanks [extensions/Thanks] - 10https://gerrit.wikimedia.org/r/119879 [03:40:09] there are really two sites, with different characteristics, and different problems [03:40:48] * c9s listening [03:41:23] the first site is a site for readers. this site receives a lot of traffic -- it's a top web property [03:42:15] this site is powered primarily by varnish, a high-performance http reverse proxy [03:43:15] though for the moment it is better to think of it as an efficient page storage and delivery service, ignoring the proxy bit, since the proxying only happens on cache misses, which users of this site don't often run into [03:44:32] YuviPanda: thank you for earlier skepticism about my yaml patch, I was so wrong... I'll go ahead with another patchset just to illustrate the alternative, but it was fine the way you had it. [03:44:56] varnish is good [03:45:13] the performance of this site is determined by the performance of varnish itself, which is generally very good, by the distance of users from our data centers (which varies, as we only have a few), and by the performance of the CSS, HTML and JavaScript running on the client to render the page [03:46:14] then there is another site [03:46:14] ori: the part that is dangerous to simplify out is the effect of multiple round-trip requests... [03:46:33] by the way, what's the concern of not upgrading php to 5.4 or 5.5? deprecated functions not supported anymore? [03:46:33] awight: i'm obviously painting with a broad stroke :) [03:46:51] c9s: just a moment, you got me rambling, now you have to suffer the full explanation :P [03:47:02] lol, sorry to interrupt ;) [03:47:29] sorry :-p [03:48:14] the second site is a small-to-mid-sized social network that is used by some 100,000 users daily [03:48:35] (that's a very approximate figure; it has been a while since i looked. but the order of magnitude is right.) [03:49:10] this site runs on totally different hardware and software [03:49:48] ori: You just called wikipedia a social network! Well its true, that's a dangerous path to go down ;) [03:49:50] its stack is apache, php, mysql, and memcached (and a few other things, but not many) [03:50:36] bawolff: social networks simply provide the closest point of comparison, in terms of access patterns, etc [03:51:26] Oh its a 100% a social network, people just hate being reminded of that [03:51:30] (03PS4) 10Adamw: Reformat using a slightly more yaml-y style [labs/tools/grrrit] - 10https://gerrit.wikimedia.org/r/112311 [03:51:33] (03CR) 10jenkins-bot: [V: 04-1] Reformat using a slightly more yaml-y style [labs/tools/grrrit] - 10https://gerrit.wikimedia.org/r/112311 (owner: 10Adamw) [03:51:35] heh [03:52:18] or maybe a MMORPG would be a better comparision [03:53:37] (03CR) 10Parent5446: [C: 04-1] "Forgot to -1 the copying monolog directly into the repo." [core] - 10https://gerrit.wikimedia.org/r/112699 (owner: 10BryanDavis) [03:54:24] (03CR) 10Parent5446: "Also, obviously I'd prefer composer over something like repo, but it's been repeated that apparently composer is not a viable solution sin" [core] - 10https://gerrit.wikimedia.org/r/112699 (owner: 10BryanDavis) [03:54:39] the performance of this second site is adequate, with some serious and severe pain points. these mostly stem from database contention, from the computational cost of parsing wikitext, and from scattered points of poor integration that inhere in a software stack with lots of sprawl and very many components [03:56:16] (03CR) 10Parent5446: [C: 031] Remove $wgHttpOnlyBlacklist [core] - 10https://gerrit.wikimedia.org/r/119919 (owner: 10PleaseStand) [03:56:44] that's about it. we're going to switch to HHVM soon. i'm actually about to send a status update to one of our public lists (wikitech-l) [03:57:39] (03CR) 10Brian Wolff: [C: 04-1] "I would prefer that this used an i18n message instead of hardcoding it in (I was debating this, since its more an internal error message, " (034 comments) [core] - 10https://gerrit.wikimedia.org/r/118822 (owner: 10Santosh2201) [03:57:48] (03PS5) 10Adamw: Reformat using a slightly more yaml-y style [labs/tools/grrrit] - 10https://gerrit.wikimedia.org/r/112311 [03:59:08] (03CR) 10Parent5446: HTMLForm: Add hide-if (031 comment) [core] - 10https://gerrit.wikimedia.org/r/118110 (owner: 10Anomie) [03:59:12] (03CR) 10Parent5446: [C: 04-1] HTMLForm: Add hide-if [core] - 10https://gerrit.wikimedia.org/r/118110 (owner: 10Anomie) [03:59:51] i would probably also add that it suffers from being implemented in languages and frameworks that provide poor support for parallelism and concurrency [04:00:58] the big scope projects for improving performance are migrating to hhvm, rewriting the parser (already done, but with a long roadmap of further plans), adding data centers in more places around the world, and enabling http pipelining (using SPDY or HTTP 2 or whatever) [04:01:02] (03CR) 10Brian Wolff: "Note, another person also submitted a patch for this issue - gerrit change 118822. Since 118822 was submitted first, I would prefer that o" [core] - 10https://gerrit.wikimedia.org/r/119350 (owner: 10Rahul mishra) [04:01:36] and pushing computation out of the monolithic app to services that can scale horizontally [04:01:38] YuviPanda: if you get bored, the updated grrrit config patch is ready for testing. I verified that it has the same structure, this time. [04:02:21] the small performance projects involve better instrumentation, and a lot of chasing around developers and wagging fingers at them [04:03:30] when i tell people i work as a performance engineer for wikimedia i generally pretend that the work is mostly about the first list [04:03:53] but there is a lot of chasing developers and wagging fingers :P [04:03:56] (03CR) 10Adamw: "Which style u like is just a matter of preference--no worries if you want to leave the syntax as it was!" [labs/tools/grrrit] - 10https://gerrit.wikimedia.org/r/112311 (owner: 10Adamw) [04:04:09] OK, this was old-man-at-airport-bar rambly, so I'll stop now. [04:05:05] ori, thanks for the detailed picture! [04:05:37] no problem. are you interested in contributing? there are lots of opportunities for getting involved [04:05:42] (03CR) 10Brian Wolff: "Hmm, well actually the history on the bug is more complicated than that, so I don't really know which one should have priority... My comme" [core] - 10https://gerrit.wikimedia.org/r/119350 (owner: 10Rahul mishra) [04:05:58] ori: Great overview, make it a FAQ! [04:06:28] yeah sure, someone mentioned there is a challenge list? I have to leave for a while, will go back later. will stay turned. [04:07:43] c9s: If you want a challenge, figure out how to stop making bad things happen to good files (during upload), and I'll be very happy [only half joking] [04:08:20] i don't know about a challenge list, but https://www.mediawiki.org/wiki/Google_Summer_of_Code_2014 has a huge list of projects, and you don't need to be a GSOC participant to get involved [04:09:30] awight: I can't write prose except on IRC and occasionally in heated e-mail threads.. I get writers block :P [04:09:33] (03PS1) 10Adamw: Make the "blacklist" variable an array [labs/tools/grrrit] - 10https://gerrit.wikimedia.org/r/119924 [04:09:43] How can you use css in a inner wiki link [[link|Link Text]]? [04:10:04] ori: maybe we can modify !wm-bot to record macros [04:10:05] c9s: Often we give https://bugzilla.wikimedia.org/buglist.cgi?keywords=easy&resolution=---&list_id=289519 as a list of good first bugs. Depending on your experience level, you may find some of them a bit trivial (lots of them are one line fixes, some are more complicated), but at the very least they can serve as an introduction on how to submit code [04:10:32] editing a wiki always feels to me like you're addressing posterity with a megaphone [04:10:33] Aurora_Grimes: [[Link|foo]] [04:10:51] Does the span come before or after the link text? [04:10:57] bawolff [04:11:22] Aurora_Grimes: [[Link|Link Text]] [04:11:28] like that to be more explicit [04:11:35] ori: nice metaphor. Unfortunately, it's often like you're shouting in a very small room. [04:11:47] okay, thanks bawolff :) [04:12:20] awight: What do you mean by macros? doesn't it already do that? [04:13:01] (03CR) 10TTO: [C: 031] "Fine, but bear in mind that this whole list is totally crap and out of date." [core] - 10https://gerrit.wikimedia.org/r/119905 (owner: 10Kaldari) [04:13:13] ori: I've been struggling with a similar issue, we realized recently that our Mingle cards are the best documentation we have. I was daydreaming about having the cards somehow synchronized with sections of a wiki page, which would add up to complete documentation for a feature... [04:13:37] (03PS4) 10AndyRussG: WIP Query API modules for campaigns and participants [extensions/Campaigns] (wip/editorcampaigns) - 10https://gerrit.wikimedia.org/r/117380 [04:13:38] bawolff: for multi-line rants? ;) [04:13:47] (03CR) 10TTO: "See I6c1eb3aba6cc55d1313f6d249510a03e4b8e6f13 which I really ought to fix up." [core] - 10https://gerrit.wikimedia.org/r/119905 (owner: 10Kaldari) [04:13:48] awight: that doesn't sound too hard to implement [04:13:56] Oh I guess not multi-line [04:14:02] ori: right? basically just an url fragment [04:14:30] unfortunately mingle is not open-source, right? [04:14:37] It's just a pity that so much TLC is left in a filing cabinet, when FR's documentation is so sparse [04:15:09] ori: that is an issue. we'll probably migrate to trello, but that doesn't help. [04:15:23] trello at least has a nice API [04:15:45] yeah, mingle has one which I do not have words of praise for [04:16:07] at the least, the tool could pull documentation out of cards and into the wiki... [04:16:48] it could be as simple as, a tag you leave in the card contents which links it to the wiki page section. [04:17:25] I added a bugzilla query atom feed to the whitelist for Extension:RSS on MediaWiki.org today [04:17:29] and I saw a Mingle URL [04:17:36] so presumably this is already possible [04:17:51] * awight blinks [04:18:01] but this doesn't make stuff persist on the wiki [04:18:54] bawolff, is there a way to search for pages that use a specific template? [04:18:54] yes, I have a crappy tool which pulls from the mingle api: http://github.com/adamwight/slander [04:18:54] Aurora_Grimes: Yes, Special:Whatlinkshere [04:18:54] Thanks bawolff. I feel like an idiot, should of thought of that. [04:23:35] <^d> bawolff, Aurora_Grimes: Also if you're using the new CirrusSearch, you can use "hastemplate:foo" to narrow results to pages containing {{foo}} [04:45:10] (03PS2) 10Mattflaschen: Make the modal expand to fit its contents [extensions/GettingStarted] - 10https://gerrit.wikimedia.org/r/118088 (owner: 10Phuedx) [04:46:28] (03CR) 10Mattflaschen: [C: 032] "It looks good (code and appearance). Tested in:" [extensions/GettingStarted] - 10https://gerrit.wikimedia.org/r/118088 (owner: 10Phuedx) [04:46:30] (03Merged) 10jenkins-bot: Make the modal expand to fit its contents [extensions/GettingStarted] - 10https://gerrit.wikimedia.org/r/118088 (owner: 10Phuedx) [04:48:47] (03CR) 10Werdna: "First pass." (0319 comments) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/117384 (owner: 10EBernhardson) [04:49:20] Gloria: Working on this: https://bugzilla.wikimedia.org/show_bug.cgi?id=60726. The text between the textarea and the buttons shouldn't be highlighted ? [04:55:55] (03PS9) 10Werdna: Refactor Flow\\Formatter namespace [extensions/Flow] - 10https://gerrit.wikimedia.org/r/117384 (owner: 10EBernhardson) [04:55:59] (03CR) 10jenkins-bot: [V: 04-1] Refactor Flow\\Formatter namespace [extensions/Flow] - 10https://gerrit.wikimedia.org/r/117384 (owner: 10EBernhardson) [04:56:13] (03CR) 10Werdna: "PS9: Rebase" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/117384 (owner: 10EBernhardson) [04:57:29] (03CR) 10Werdna: "PS9 fails because apparently 'use' can't be in the middle anymore?" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/117384 (owner: 10EBernhardson) [05:05:14] (03PS12) 10Werdna: Make BoardHistory a Formatter instance [extensions/Flow] - 10https://gerrit.wikimedia.org/r/115532 (owner: 10EBernhardson) [05:05:17] tinaj1234_: I think that's just about setting tabindex? [05:05:18] (03CR) 10jenkins-bot: [V: 04-1] Make BoardHistory a Formatter instance [extensions/Flow] - 10https://gerrit.wikimedia.org/r/115532 (owner: 10EBernhardson) [05:05:25] Yeah. [05:05:33] I think that'll just make the behavior more sane across browsers. [05:07:00] Gloria: Ok so you go directly to send and preview after subject, right? [05:07:35] I think so, yeah. [05:07:40] Similar to how ?action=edit works. [05:07:59] A logical tab key progression. [05:08:53] ok [05:12:48] (03PS1) 10Ori.livneh: Detect and ignore bogus KeyboardInterrupts raised by PyZMQ [extensions/EventLogging] - 10https://gerrit.wikimedia.org/r/119925 [05:14:00] (03CR) 10Ori.livneh: [C: 032] Detect and ignore bogus KeyboardInterrupts raised by PyZMQ [extensions/EventLogging] - 10https://gerrit.wikimedia.org/r/119925 (owner: 10Ori.livneh) [05:14:30] (03Merged) 10jenkins-bot: Detect and ignore bogus KeyboardInterrupts raised by PyZMQ [extensions/EventLogging] - 10https://gerrit.wikimedia.org/r/119925 (owner: 10Ori.livneh) [05:14:43] (03PS13) 10Werdna: Make BoardHistory a Formatter instance [extensions/Flow] - 10https://gerrit.wikimedia.org/r/115532 (owner: 10EBernhardson) [05:14:46] (03PS10) 10Werdna: Refactor Flow\\Formatter namespace [extensions/Flow] - 10https://gerrit.wikimedia.org/r/117384 (owner: 10EBernhardson) [05:14:59] (03CR) 10jenkins-bot: [V: 04-1] Make BoardHistory a Formatter instance [extensions/Flow] - 10https://gerrit.wikimedia.org/r/115532 (owner: 10EBernhardson) [05:15:08] (03CR) 10jenkins-bot: [V: 04-1] Refactor Flow\\Formatter namespace [extensions/Flow] - 10https://gerrit.wikimedia.org/r/117384 (owner: 10EBernhardson) [05:15:12] Gloria: if $wgLang->timeanddate( $expiration, false ) is given the output would be in UTC right ? is the second argument false making it void of timezone ? [05:16:20] (03CR) 10Mattflaschen: "What's the latest on this?" [core] - 10https://gerrit.wikimedia.org/r/117107 (owner: 10JGonera) [05:16:46] (03CR) 10TTO: [C: 04-1] "Incomplete, by comparison with I6c1eb3aba6cc55d1313f6d249510a03e4b8e6f13. Also please see the comments there." [core] - 10https://gerrit.wikimedia.org/r/119923 (owner: 10Kaldari) [05:17:13] tonythomas: Time is usually output according to user preference. [05:17:15] Or wiki setting. [05:17:22] UTC is generally considered the fallback. [05:17:28] Though it may also be the default. [05:17:39] Because that's what's used internally. [05:17:48] Gloria: if I wanted the output to be in sync with my preference timezone set, [05:18:00] I should pass true as a parameter right ? [05:18:05] I have no idea. [05:18:35] (03PS1) 10Ori.livneh: Add missing import ('inspect') [extensions/EventLogging] - 10https://gerrit.wikimedia.org/r/119927 [05:18:44] (03CR) 10Ori.livneh: [C: 032] Add missing import ('inspect') [extensions/EventLogging] - 10https://gerrit.wikimedia.org/r/119927 (owner: 10Ori.livneh) [05:18:48] Gloria: I had earlier done the same for an extension ( https://gerrit.wikimedia.org/r/#/c/118821/) [05:19:06] and this one was for the same in the UserConfirmationMail function [05:19:30] (03Merged) 10jenkins-bot: Add missing import ('inspect') [extensions/EventLogging] - 10https://gerrit.wikimedia.org/r/119927 (owner: 10Ori.livneh) [05:19:44] the function says $wgLang->timeanddate( $expiration, false ), [05:20:22] I was wondering whether I could get the localtime by passing something like $wgLang->timeanddate( $expiration, true ), [05:21:41] tonythomas: Using "true" there gives the time set in the user preference [05:22:09] bawolff: like $wgLang->timeanddate( $expiration, true ) right ? [05:22:28] tonythomas: MediaWiki uses three different types of time in different places - UTC, server local time (Often but not always UTC), and user local time [05:22:59] tonythomas: yep. See the function definition it languages/Language.php [05:23:30] (03CR) 10Mattflaschen: [C: 04-1] "-1 is because there seems to be an effort at the height fix, which is competing with https://gerrit.wikimedia.org/r/#/c/117107/ and not me" (032 comments) [core] - 10https://gerrit.wikimedia.org/r/117105 (owner: 10Kaldari) [05:23:39] ok. and thats controlled by the second parameter right of wgLang->timeanddate( $time, true ) right ? [05:25:15] bawolff: $adj Bool: whether to adjust the time output according to the user configured offset ($timecorrection) , the second param if put true :) [05:26:29] (03PS1) 10Ori.livneh: Fix check for 'check_rc' in traceback [extensions/EventLogging] - 10https://gerrit.wikimedia.org/r/119928 [05:26:34] (03CR) 10Werdna: "Might want some tests too." (034 comments) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/113528 (owner: 10EBernhardson) [05:26:48] (03CR) 10Ori.livneh: [C: 032] Fix check for 'check_rc' in traceback [extensions/EventLogging] - 10https://gerrit.wikimedia.org/r/119928 (owner: 10Ori.livneh) [05:26:58] (03CR) 10jenkins-bot: [V: 04-1] Fix check for 'check_rc' in traceback [extensions/EventLogging] - 10https://gerrit.wikimedia.org/r/119928 (owner: 10Ori.livneh) [05:27:55] (03PS2) 10Ori.livneh: Fix check for 'check_rc' in traceback [extensions/EventLogging] - 10https://gerrit.wikimedia.org/r/119928 [05:28:03] (03CR) 10Ori.livneh: [C: 032] Fix check for 'check_rc' in traceback [extensions/EventLogging] - 10https://gerrit.wikimedia.org/r/119928 (owner: 10Ori.livneh) [05:28:24] (03CR) 10jenkins-bot: [V: 04-1] Fix check for 'check_rc' in traceback [extensions/EventLogging] - 10https://gerrit.wikimedia.org/r/119928 (owner: 10Ori.livneh) [05:28:35] (03CR) 10Werdna: [C: 032] Remove title attributes from textarea [extensions/Flow] - 10https://gerrit.wikimedia.org/r/119525 (owner: 10EBernhardson) [05:28:50] (03Merged) 10jenkins-bot: Remove title attributes from textarea [extensions/Flow] - 10https://gerrit.wikimedia.org/r/119525 (owner: 10EBernhardson) [05:29:55] (03PS3) 10Ori.livneh: Fix check for 'check_rc' in traceback [extensions/EventLogging] - 10https://gerrit.wikimedia.org/r/119928 [05:30:09] (03CR) 10Ori.livneh: [C: 032] Fix check for 'check_rc' in traceback [extensions/EventLogging] - 10https://gerrit.wikimedia.org/r/119928 (owner: 10Ori.livneh) [05:30:51] (03Merged) 10jenkins-bot: Fix check for 'check_rc' in traceback [extensions/EventLogging] - 10https://gerrit.wikimedia.org/r/119928 (owner: 10Ori.livneh) [05:31:37] (03CR) 10EBernhardson: Refactor Flow\\Formatter namespace (039 comments) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/117384 (owner: 10EBernhardson) [05:32:52] (03CR) 10Werdna: [C: 031] "Also looks fine to me. +2 if everything looks good to you." [extensions/Flow] - 10https://gerrit.wikimedia.org/r/115531 (owner: 10EBernhardson) [05:35:13] (03CR) 10Werdna: Cleanup another round of analysis warnings (032 comments) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/119890 (owner: 10EBernhardson) [05:35:46] (03PS1) 10Tinaj1234: Added tabindex to MassMessage form elements [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/119929 [05:36:13] (03CR) 10Werdna: [C: 031] "Okay those were just display issues. Ignore them. I haven't tested this at all, but it looks fine to me." [extensions/Flow] - 10https://gerrit.wikimedia.org/r/119890 (owner: 10EBernhardson) [05:36:47] (03PS6) 10EBernhardson: fastpath getMulti/gotMulti when using CachingObjectMapper [extensions/Flow] - 10https://gerrit.wikimedia.org/r/113528 [05:36:59] (03CR) 10EBernhardson: fastpath getMulti/gotMulti when using CachingObjectMapper (033 comments) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/113528 (owner: 10EBernhardson) [05:37:03] (03CR) 10jenkins-bot: [V: 04-1] fastpath getMulti/gotMulti when using CachingObjectMapper [extensions/Flow] - 10https://gerrit.wikimedia.org/r/113528 (owner: 10EBernhardson) [05:37:38] (03CR) 10Werdna: "Opened this; saw the number of files, noticed that there was something interesting on TV ;-P" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/115576 (owner: 10EBernhardson) [05:37:41] (03CR) 10Mattflaschen: "This is here for posterity, but we decided to use RL instead, right?" [extensions/GettingStarted] - 10https://gerrit.wikimedia.org/r/118285 (owner: 10Phuedx) [05:40:09] (03PS2) 10EBernhardson: Cleanup another round of analysis warnings [extensions/Flow] - 10https://gerrit.wikimedia.org/r/119890 [05:40:15] (03CR) 10EBernhardson: Cleanup another round of analysis warnings (032 comments) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/119890 (owner: 10EBernhardson) [05:44:42] (03CR) 10Werdna: [C: 031] "LGTM, haven't tested." [extensions/Flow] - 10https://gerrit.wikimedia.org/r/115530 (owner: 10EBernhardson) [05:45:38] (03CR) 10Werdna: [C: 032] Don't check for 'Block', only very privileged users will have this [extensions/Flow] - 10https://gerrit.wikimedia.org/r/114172 (owner: 10Cmcmahon) [05:45:51] (03Merged) 10jenkins-bot: Don't check for 'Block', only very privileged users will have this [extensions/Flow] - 10https://gerrit.wikimedia.org/r/114172 (owner: 10Cmcmahon) [05:48:03] (03CR) 10Werdna: [C: 032] "LGTM" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/118299 (owner: 10Matthias Mullie) [05:48:15] (03CR) 10jenkins-bot: [V: 04-1] (bug 61345) Clicking "Comment (n)" in Collapsed View doesn't expand the topic [extensions/Flow] - 10https://gerrit.wikimedia.org/r/118299 (owner: 10Matthias Mullie) [06:02:11] (03PS1) 10Santhosh: Segmentation: Add test for figure tags [services/cxserver] - 10https://gerrit.wikimedia.org/r/119931 [06:02:48] (03PS1) 10Brian Wolff: Rollback transactions if job throws an exception. [core] - 10https://gerrit.wikimedia.org/r/119932 [06:04:58] (03CR) 10Frédéric Wang: "I believe we can not just rely on tests to say that the change is OK just because "it works" (even more when you modified the references)." [extensions/Math] - 10https://gerrit.wikimedia.org/r/119010 (owner: 10Physikerwelt) [06:09:49] (03PS4) 10Umherirrender: Add CURRENTDAY1/LOCALDAY1 aliases for CURRENTDAY/LOCALDAY [core] - 10https://gerrit.wikimedia.org/r/110705 [06:11:48] (03PS1) 10Santhosh: Add .jshintrc and .jshintignore [services/cxserver] - 10https://gerrit.wikimedia.org/r/119934 [06:14:53] (03PS5) 10Umherirrender: Exclude prop=uploadwarning from allimages and stashimageinfo [core] - 10https://gerrit.wikimedia.org/r/112341 [06:15:52] (03PS1) 1001tonythomas: Adjust datetime in email confirmation email [core] - 10https://gerrit.wikimedia.org/r/119936 [06:36:13] (03PS4) 10EBernhardson: (bug 61345) Clicking "Comment (n)" in Collapsed View doesn't expand the topic [extensions/Flow] - 10https://gerrit.wikimedia.org/r/118299 (owner: 10Matthias Mullie) [06:36:35] (03CR) 10EBernhardson: [C: 032] (bug 61345) Clicking "Comment (n)" in Collapsed View doesn't expand the topic [extensions/Flow] - 10https://gerrit.wikimedia.org/r/118299 (owner: 10Matthias Mullie) [06:36:47] (03Merged) 10jenkins-bot: (bug 61345) Clicking "Comment (n)" in Collapsed View doesn't expand the topic [extensions/Flow] - 10https://gerrit.wikimedia.org/r/118299 (owner: 10Matthias Mullie) [06:54:42] (03CR) 10Raimond Spekking: Add messages for Trademark Licensing form for foundationwiki (031 comment) [extensions/WikimediaMessages] - 10https://gerrit.wikimedia.org/r/110243 (owner: 10Reedy) [06:57:38] (03CR) 10KartikMistry: [C: 031] "LGTM." [services/cxserver] - 10https://gerrit.wikimedia.org/r/119934 (owner: 10Santhosh) [07:01:25] (03PS1) 10BryanDavis: Add Composer managed libraries [core] - 10https://gerrit.wikimedia.org/r/119939 [07:01:27] (03PS1) 10BryanDavis: Add a PSR-3 based logging interface [core] - 10https://gerrit.wikimedia.org/r/119940 [07:01:29] (03PS1) 10BryanDavis: Enable MWLogger logging for legacy logging methods [core] - 10https://gerrit.wikimedia.org/r/119941 [07:01:31] (03PS1) 10BryanDavis: Enable MWLogger logging for wfLogProfilingData [core] - 10https://gerrit.wikimedia.org/r/119942 [07:05:00] (03CR) 10Brian Wolff: [C: 032] "Looks good." [core] - 10https://gerrit.wikimedia.org/r/112341 (owner: 10Umherirrender) [07:08:37] (03CR) 10Parent5446: [C: 031] Adjust datetime in email confirmation email [core] - 10https://gerrit.wikimedia.org/r/119936 (owner: 1001tonythomas) [07:10:17] (03Merged) 10jenkins-bot: Exclude prop=uploadwarning from allimages and stashimageinfo [core] - 10https://gerrit.wikimedia.org/r/112341 (owner: 10Umherirrender) [07:11:31] (03CR) 10Parent5446: "This seems a little weird. Usually it should be the job of whatever function threw the exception to rollback its own transaction." [core] - 10https://gerrit.wikimedia.org/r/119932 (owner: 10Brian Wolff) [07:15:06] (03CR) 10Brian Wolff: "Perhaps, but in practise it seems most of MediaWiki does not do that, but instead relies on (in normal web requests) MediaWiki exiting wit" [core] - 10https://gerrit.wikimedia.org/r/119932 (owner: 10Brian Wolff) [07:15:54] (03CR) 10Adamw: "We covered lots of ground in IRC, but the main thing is to either consolidate or eliminate general persistence stuff, so that the Campaign" (0314 comments) [extensions/Campaigns] (wip/editorcampaigns) - 10https://gerrit.wikimedia.org/r/116221 (owner: 10AndyRussG) [07:22:04] (03CR) 10Adamw: Add persistence objects and tests (031 comment) [extensions/Campaigns] (wip/editorcampaigns) - 10https://gerrit.wikimedia.org/r/116221 (owner: 10AndyRussG) [07:23:58] (03CR) 10Bencmq: "Thank should also be included with that style" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/119812 (owner: 10Bencmq) [07:39:16] (03PS2) 10Bencmq: Display timestamp in local timezone and language per user preference [extensions/Flow] - 10https://gerrit.wikimedia.org/r/119877 [07:47:06] (03PS5) 10Netbrain: Fixed bug where variables referenced where not reachable (out of scope) [extensions/MassEditRegex] - 10https://gerrit.wikimedia.org/r/97902 [07:47:08] (03PS4) 10Netbrain: Added support for execution to be done on client side. This to prevent max execution time error in php. [extensions/MassEditRegex] - 10https://gerrit.wikimedia.org/r/98094 [07:47:47] (03CR) 10Netbrain: "Made api calls use POST" [extensions/MassEditRegex] - 10https://gerrit.wikimedia.org/r/98094 (owner: 10Netbrain) [07:57:41] (03PS1) 10Nikerabbit: Merge remote-tracking branch 'origin/json-rewrite' [extensions/LocalisationUpdate] - 10https://gerrit.wikimedia.org/r/119944 [07:59:27] (03CR) 10Nikerabbit: "Should not probably merge before" [extensions/LocalisationUpdate] - 10https://gerrit.wikimedia.org/r/119944 (owner: 10Nikerabbit) [08:34:55] (03PS1) 10Nemo bis: Add link to PD help translatable pages from sidebar [core] (REL1_22) - 10https://gerrit.wikimedia.org/r/119947 [08:37:14] (03CR) 10jenkins-bot: [V: 04-1] Add link to PD help translatable pages from sidebar [core] (REL1_22) - 10https://gerrit.wikimedia.org/r/119947 (owner: 10Nemo bis) [08:37:26] (03CR) 10Matthias Mullie: "Well, I had been in doubt about that too." [extensions/Flow] - 10https://gerrit.wikimedia.org/r/119304 (owner: 10Matthias Mullie) [08:39:09] (03CR) 10Brian Wolff: [C: 04-1] "Siebrand: Is it ok from an i18n prespective to re-use the 'userpage-userdoesnotexist-view' message, or should there be a new message for t" [core] - 10https://gerrit.wikimedia.org/r/117854 (owner: 10Ganeshaditya1) [08:42:05] (03Abandoned) 10Matthias Mullie: [Experimental] div contenteditable editor [extensions/Flow] - 10https://gerrit.wikimedia.org/r/99004 (owner: 10Matthias Mullie) [08:42:34] (03Abandoned) 10Matthias Mullie: Reads should be done against DB_SLAVE [extensions/Flow] - 10https://gerrit.wikimedia.org/r/116985 (owner: 10Matthias Mullie) [08:54:19] (03CR) 10Matthias Mullie: [C: 032] Split re-usable parts out of ContributionsQuery [extensions/Flow] - 10https://gerrit.wikimedia.org/r/115530 (owner: 10EBernhardson) [08:54:34] (03Merged) 10jenkins-bot: Split re-usable parts out of ContributionsQuery [extensions/Flow] - 10https://gerrit.wikimedia.org/r/115530 (owner: 10EBernhardson) [08:54:45] (03CR) 10Matthias Mullie: [C: 032] Sort the combined header+topic revisions after merging [extensions/Flow] - 10https://gerrit.wikimedia.org/r/115531 (owner: 10EBernhardson) [08:54:59] (03Merged) 10jenkins-bot: Sort the combined header+topic revisions after merging [extensions/Flow] - 10https://gerrit.wikimedia.org/r/115531 (owner: 10EBernhardson) [09:02:34] (03CR) 10Matthias Mullie: [C: 031] "Still looks good. Merge at will, once you're ready to do the schema change" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/115576 (owner: 10EBernhardson) [09:02:38] (03CR) 10Nikerabbit: "I'll rebase&review this after the rewrite has been merged." [extensions/LocalisationUpdate] - 10https://gerrit.wikimedia.org/r/105514 (owner: 10Nemo bis) [09:06:10] (03CR) 10Nemo bis: "No idea about https://integration.wikimedia.org/ci/job/mediawiki-core-jsduck/3887/console but the other is probably caused by the nofollow" [core] (REL1_22) - 10https://gerrit.wikimedia.org/r/119947 (owner: 10Nemo bis) [09:10:36] (03CR) 10Nemo bis: "Or rather, I'll just backport the test fix in a moment. Broken tests are already covered in commit message." [core] (REL1_22) - 10https://gerrit.wikimedia.org/r/119947 (owner: 10Nemo bis) [09:19:00] (03PS2) 10Nemo bis: Add link to PD help translatable pages from sidebar [core] (REL1_22) - 10https://gerrit.wikimedia.org/r/119947 [09:22:44] (03CR) 10jenkins-bot: [V: 04-1] Add link to PD help translatable pages from sidebar [core] (REL1_22) - 10https://gerrit.wikimedia.org/r/119947 (owner: 10Nemo bis) [09:25:02] (03CR) 10Bencmq: "see also https://gerrit.wikimedia.org/r/#/c/119812/" [extensions/Thanks] - 10https://gerrit.wikimedia.org/r/119814 (owner: 10Bencmq) [09:26:50] (03PS3) 10Zfilipin: Merged two job templates that build Ruby gems into one [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/119733 [09:33:18] (03PS1) 10Hashar: mw-update-l10n: show # of threads used [tools/scap] - 10https://gerrit.wikimedia.org/r/119952 [09:43:08] (03PS2) 10Hashar: mw-update-l10n: show # of threads used [tools/scap] - 10https://gerrit.wikimedia.org/r/119952 [09:43:16] (03PS1) 10Physikerwelt: Fix: Remove MathML out if used as input [services/mathoid] - 10https://gerrit.wikimedia.org/r/119953 [09:43:25] (03CR) 10Ori.livneh: [C: 032] mw-update-l10n: show # of threads used [tools/scap] - 10https://gerrit.wikimedia.org/r/119952 (owner: 10Hashar) [09:43:37] (03Merged) 10jenkins-bot: mw-update-l10n: show # of threads used [tools/scap] - 10https://gerrit.wikimedia.org/r/119952 (owner: 10Hashar) [09:43:39] (03CR) 10Hashar: "moved ellipsis '...' at the end of the message" [tools/scap] - 10https://gerrit.wikimedia.org/r/119952 (owner: 10Hashar) [09:43:41] ori: thanks [09:45:40] (03PS2) 10Physikerwelt: Fix: Remove MathML out if used as input [services/mathoid] - 10https://gerrit.wikimedia.org/r/119953 [09:54:58] (03CR) 10Matthias Mullie: fastpath getMulti/gotMulti when using CachingObjectMapper (032 comments) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/113528 (owner: 10EBernhardson) [09:55:54] (03PS7) 10Matthias Mullie: fastpath getMulti/gotMulti when using CachingObjectMapper [extensions/Flow] - 10https://gerrit.wikimedia.org/r/113528 (owner: 10EBernhardson) [09:56:01] (03CR) 10jenkins-bot: [V: 04-1] fastpath getMulti/gotMulti when using CachingObjectMapper [extensions/Flow] - 10https://gerrit.wikimedia.org/r/113528 (owner: 10EBernhardson) [09:56:11] (03CR) 10Matthias Mullie: [C: 032] fastpath getMulti/gotMulti when using CachingObjectMapper [extensions/Flow] - 10https://gerrit.wikimedia.org/r/113528 (owner: 10EBernhardson) [09:56:19] (03CR) 10jenkins-bot: [V: 04-1] fastpath getMulti/gotMulti when using CachingObjectMapper [extensions/Flow] - 10https://gerrit.wikimedia.org/r/113528 (owner: 10EBernhardson) [09:57:12] (03PS1) 10Hashar: Option to increase verbosity of refreshCdbJsonFiles [tools/scap] - 10https://gerrit.wikimedia.org/r/119955 [09:58:27] (03CR) 10Hashar: "Example output of the beta cluster run: https://integration.wikimedia.org/ci/job/beta-code-update/53508/console" [tools/scap] - 10https://gerrit.wikimedia.org/r/119955 (owner: 10Hashar) [10:01:43] (03PS8) 10Matthias Mullie: fastpath getMulti/gotMulti when using CachingObjectMapper [extensions/Flow] - 10https://gerrit.wikimedia.org/r/113528 (owner: 10EBernhardson) [10:02:04] (03CR) 10Matthias Mullie: [C: 032] fastpath getMulti/gotMulti when using CachingObjectMapper [extensions/Flow] - 10https://gerrit.wikimedia.org/r/113528 (owner: 10EBernhardson) [10:02:16] (03Merged) 10jenkins-bot: fastpath getMulti/gotMulti when using CachingObjectMapper [extensions/Flow] - 10https://gerrit.wikimedia.org/r/113528 (owner: 10EBernhardson) [10:19:12] (03CR) 10Bartosz Dziewoński: "I think the bulk of this patch has been now deprecated by other commits you and I submitted. We should look into the Opera stuff separatel" [extensions/BetaFeatures] - 10https://gerrit.wikimedia.org/r/115885 (owner: 10Thiemo Mättig (WMDE)) [10:35:12] (03CR) 10Bartosz Dziewoński: [C: 032] Fix possible error list of action=revisiondelete [core] - 10https://gerrit.wikimedia.org/r/119792 (owner: 10Umherirrender) [10:38:10] (03CR) 10Hashar: [C: 04-1] "* gemspec is a nice hack. Can you update the job-template so we get a job per project please? Just need to replace 'gembuild' with '{n" (033 comments) [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/119733 (owner: 10Zfilipin) [10:39:35] (03Merged) 10jenkins-bot: Fix possible error list of action=revisiondelete [core] - 10https://gerrit.wikimedia.org/r/119792 (owner: 10Umherirrender) [10:42:47] (03CR) 10Bartosz Dziewoński: [C: 032] ResourceLoaderStartUpModule: Remove no-op "delete isCompatible" [core] - 10https://gerrit.wikimedia.org/r/119696 (owner: 10Krinkle) [10:45:34] (03CR) 10Bartosz Dziewoński: [C: 032] ResourceLoaderStartUpModule: Improve comment about modifiedTime hack [core] - 10https://gerrit.wikimedia.org/r/119705 (owner: 10Krinkle) [10:46:47] (03Merged) 10jenkins-bot: ResourceLoaderStartUpModule: Remove no-op "delete isCompatible" [core] - 10https://gerrit.wikimedia.org/r/119696 (owner: 10Krinkle) [10:47:07] (03CR) 10Bartosz Dziewoński: [C: 04-1] "Does not merge." (031 comment) [core] - 10https://gerrit.wikimedia.org/r/117444 (owner: 10Krinkle) [10:49:03] (03Merged) 10jenkins-bot: ResourceLoaderStartUpModule: Improve comment about modifiedTime hack [core] - 10https://gerrit.wikimedia.org/r/119705 (owner: 10Krinkle) [10:50:00] (03CR) 10Phuedx: "Mattflaschen: yarrrp. This is superseded by Iedb8dc31e4817d8b4e40b655cf9b8fb092979e90." [extensions/GettingStarted] - 10https://gerrit.wikimedia.org/r/118285 (owner: 10Phuedx) [10:50:19] (03CR) 10Phuedx: [C: 04-2] [WIP] Use grunt-contrib-less to lint LESS files [extensions/GettingStarted] - 10https://gerrit.wikimedia.org/r/118285 (owner: 10Phuedx) [10:51:32] (03CR) 10Phuedx: [C: 04-2] "This is superseded by Iedb8dc31e4817d8b4e40b655cf9b8fb092979e90 but I'm keeping it around for posterity." [extensions/GuidedTour] - 10https://gerrit.wikimedia.org/r/118327 (owner: 10Phuedx) [10:54:17] (03Abandoned) 10Phuedx: Add a LESS test suite [extensions/GettingStarted] - 10https://gerrit.wikimedia.org/r/119056 (owner: 10Phuedx) [11:08:35] (03PS1) 10Santhosh: Segmentation: Handle all section types [services/cxserver] - 10https://gerrit.wikimedia.org/r/119969 [11:09:33] (03CR) 10Siebrand: [C: 04-1] "i18n/L10n reviewed." (032 comments) [extensions/GlobalBlocking] - 10https://gerrit.wikimedia.org/r/119915 (owner: 10Hoo man) [11:10:25] (03CR) 10Siebrand: [C: 031] "L10n reviewed." [extensions/Flow] - 10https://gerrit.wikimedia.org/r/119640 (owner: 10Bsitu) [11:18:22] (03CR) 10MaxSem: [C: 032] Adding Wikivoyage to the default interwiki map [core] - 10https://gerrit.wikimedia.org/r/119905 (owner: 10Kaldari) [11:18:58] (03CR) 10MaxSem: [C: 032] Updating link protocols for WMF wikis in the interwiki map (031 comment) [core] - 10https://gerrit.wikimedia.org/r/119907 (owner: 10Kaldari) [11:22:13] (03Merged) 10jenkins-bot: Adding Wikivoyage to the default interwiki map [core] - 10https://gerrit.wikimedia.org/r/119905 (owner: 10Kaldari) [11:23:09] (03CR) 10Matthias Mullie: [C: 04-1] Refactor Flow\\Formatter namespace (033 comments) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/117384 (owner: 10EBernhardson) [11:23:15] (03Merged) 10jenkins-bot: Updating link protocols for WMF wikis in the interwiki map [core] - 10https://gerrit.wikimedia.org/r/119907 (owner: 10Kaldari) [11:29:52] (03PS1) 10Phuedx: Update copy and tweak CTA primary button styles [extensions/GettingStarted] - 10https://gerrit.wikimedia.org/r/119972 [11:47:56] (03PS3) 10Thiemo Mättig (WMDE): [WIP] Fix Beta checkboxes not rendering in Opera 12 (Windows) [extensions/BetaFeatures] - 10https://gerrit.wikimedia.org/r/115885 [11:47:58] (03CR) 10jenkins-bot: [V: 04-1] [WIP] Fix Beta checkboxes not rendering in Opera 12 (Windows) [extensions/BetaFeatures] - 10https://gerrit.wikimedia.org/r/115885 (owner: 10Thiemo Mättig (WMDE)) [12:13:23] (03CR) 10Siebrand: [C: 04-1] "L10n reviewed." (031 comment) [extensions/GettingStarted] - 10https://gerrit.wikimedia.org/r/119972 (owner: 10Phuedx) [12:17:38] (03CR) 10Siebrand: [C: 04-1] "i18n/L10n reviewed. Thanks for pinging me, Brian." (031 comment) [core] - 10https://gerrit.wikimedia.org/r/117854 (owner: 10Ganeshaditya1) [12:22:08] (03CR) 10Siebrand: [C: 04-1] "i18n reviewed." (031 comment) [core] - 10https://gerrit.wikimedia.org/r/118345 (owner: 10Jdlrobson) [12:28:52] (03CR) 10Siebrand: [C: 031] "i18n/L10n reviewed." (031 comment) [skins/Modern] - 10https://gerrit.wikimedia.org/r/119885 (owner: 10Jdlrobson) [12:29:04] (03CR) 10Siebrand: [C: 031] "i18n/L10n reviewed." [skins/CologneBlue] - 10https://gerrit.wikimedia.org/r/119884 (owner: 10Jdlrobson) [12:33:14] (03CR) 10Raimond Spekking: [C: 04-1] "per Siebrand. Regression" [extensions/GettingStarted] - 10https://gerrit.wikimedia.org/r/119972 (owner: 10Phuedx) [12:33:58] (03CR) 10Ori.livneh: "@MZMcBride: It will let us measure the decay in usage of functions that we deprecate, and it will let us project the number of users that " [extensions/WikimediaEvents] - 10https://gerrit.wikimedia.org/r/119903 (owner: 10Ori.livneh) [12:38:28] (03PS8) 10Kunalgrover05: Implement listing for tracking categories [core] - 10https://gerrit.wikimedia.org/r/112323 [12:39:28] (03CR) 10jenkins-bot: [V: 04-1] Implement listing for tracking categories [core] - 10https://gerrit.wikimedia.org/r/112323 (owner: 10Kunalgrover05) [12:46:17] (03CR) 10Siebrand: [C: 04-1] "Some i18n/L10n reviewed." (032 comments) [core] - 10https://gerrit.wikimedia.org/r/112323 (owner: 10Kunalgrover05) [12:54:03] (03PS4) 10Manybubbles: Don't respect the "show redirects" option [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/118593 (owner: 10Chad) [12:54:44] (03CR) 10Manybubbles: [C: 031] "Rebased. +1 still stands." [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/118593 (owner: 10Chad) [13:01:38] Hi ! I was just going through this bug on checking Passwords strength before being set, during account creation. Earlier an extension was written for that, but cant the same be acheived by adding some simple strength tests like I mentioned in https://bugzilla.wikimedia.org/show_bug.cgi?id=3348#c14 ? [13:02:52] tonythomas: No [13:03:07] tonythomas: That's a lot of restrictions on passwords - length should really be the only restriction IMO [13:03:49] e.g. correcthorsestaplebattery wouldn't pass any of your checks [13:04:08] (except for not-too-short and has-letters) [13:04:32] rdwrer: that's true. I was just adding the tests thats usually applied these days [13:04:42] its awkward, I agree though [13:05:13] The people who "usually" apply those tests should be found, ridiculed, and forced to create sock accounts on their own websites for eternity [13:05:30] With password generators [13:05:47] After watching and reading loads of stuff about security [13:06:19] rdwrer: ha :) I too find it difficult to create accounts in certain websites due to these checks as a matter of fact. [13:07:42] rdwrer: no wonder PasswordStrength extension was deleted [13:07:54] I wasn't involved, so I can't say [13:08:03] It might have just been community kickback, they do that sometimes [13:08:16] "You want me to be SECURE? Censorship!!!!" [13:09:03] rdwrer: yeah! Are the length tests done now ? [13:09:38] (03PS9) 10Kunalgrover05: Implement listing for tracking categories [core] - 10https://gerrit.wikimedia.org/r/112323 [13:10:38] (03CR) 10jenkins-bot: [V: 04-1] Implement listing for tracking categories [core] - 10https://gerrit.wikimedia.org/r/112323 (owner: 10Kunalgrover05) [13:11:23] rdwrer: nah ! could make an a/c with 2 letters [13:20:17] rdwrer: but there is something like $wgMinimalPasswordLength in SpecialUserlogin.php though, and I can make passwords with length 2 [13:20:51] (03CR) 10Shirayuki: [C: 04-1] "i18n reviewed. Use page instead of article." [extensions/GettingStarted] - 10https://gerrit.wikimedia.org/r/119972 (owner: 10Phuedx) [13:20:55] ah ! DefaultSettings.php puts it $wgMinimalPasswordLength = 1; [13:21:16] dont know why its configured like that though [13:32:58] (03PS10) 10Kunalgrover05: Implement listing for tracking categories [core] - 10https://gerrit.wikimedia.org/r/112323 [13:33:00] (03PS1) 10Kunalgrover05: Merge "Updating link protocols for WMF wikis in the interwiki map" [core] - 10https://gerrit.wikimedia.org/r/119987 [13:35:21] (03CR) 10jenkins-bot: [V: 04-1] Implement listing for tracking categories [core] - 10https://gerrit.wikimedia.org/r/112323 (owner: 10Kunalgrover05) [13:35:23] (03CR) 10Bartosz Dziewoński: [C: 04-2] "I'm pretty sure you didn't mean to submit this." [core] - 10https://gerrit.wikimedia.org/r/119987 (owner: 10Kunalgrover05) [13:35:55] (03CR) 10jenkins-bot: [V: 04-1] Merge "Updating link protocols for WMF wikis in the interwiki map" [core] - 10https://gerrit.wikimedia.org/r/119987 (owner: 10Kunalgrover05) [13:35:57] (03CR) 10Bartosz Dziewoński: [C: 04-1] Merge "Updating link protocols for WMF wikis in the interwiki map" [core] - 10https://gerrit.wikimedia.org/r/119987 (owner: 10Kunalgrover05) [13:44:46] (03CR) 10Kunalgrover05: "Yeah, I am sorry I screwed up my Git..:(" [core] - 10https://gerrit.wikimedia.org/r/119987 (owner: 10Kunalgrover05) [13:51:24] (03PS1) 10Pigpen: Latest state of development [skins/BlueSpiceSkin] - 10https://gerrit.wikimedia.org/r/119993 [13:51:28] (03PS1) 10Pigpen: Latest state of development [extensions/BlueSpiceFoundation] - 10https://gerrit.wikimedia.org/r/119994 [13:58:31] I tried to add a number parameter to the $this->msg( 'userlogin-yourpassword' ) using ->numParams( '$foo').text(); in templates/Usercreate.php .( I added the $1 parameter in the i8n file ). It didn't work. Is there anything like ->numParams() wont work in templates/UserCreate.php ? [13:58:58] (03CR) 10Zfilipin: Merged two job templates that build Ruby gems into one (033 comments) [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/119733 (owner: 10Zfilipin) [13:59:41] (03PS4) 10Zfilipin: Merged two job templates that build Ruby gems into one [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/119733 [14:00:47] (03PS1) 10Pigpen: Latest state of development [extensions/BlueSpiceExtensions] - 10https://gerrit.wikimedia.org/r/119995 [14:01:50] (03CR) 10Pigpen: [C: 032 V: 032] Latest state of development [skins/BlueSpiceSkin] - 10https://gerrit.wikimedia.org/r/119993 (owner: 10Pigpen) [14:02:05] (03CR) 10Pigpen: [C: 032 V: 032] Latest state of development [extensions/BlueSpiceFoundation] - 10https://gerrit.wikimedia.org/r/119994 (owner: 10Pigpen) [14:02:19] (03CR) 10Pigpen: [C: 032 V: 032] Latest state of development [extensions/BlueSpiceExtensions] - 10https://gerrit.wikimedia.org/r/119995 (owner: 10Pigpen) [14:02:29] (03CR) 10Hashar: [C: 032] "Nice! I have refreshed both jobs." [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/119733 (owner: 10Zfilipin) [14:03:06] (03Merged) 10jenkins-bot: Merged two job templates that build Ruby gems into one [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/119733 (owner: 10Zfilipin) [14:04:48] can we please please switch to http://hacklang.org/ ? [14:14:27] yurik: it was discussed yesterday on #mediawiki [14:14:45] Nemo_bis, what was the conclusion? [14:15:57] (03PS1) 10Hashar: Tie debian glue to more slaves [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/119997 [14:16:17] (03CR) 10Hashar: [C: 032] Tie debian glue to more slaves [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/119997 (owner: 10Hashar) [14:17:13] (03PS1) 10TheDJ: Accessibility: Don't remove outlines from focusable elems [core] - 10https://gerrit.wikimedia.org/r/119998 [14:17:15] (03PS1) 10Cmcmahon: WIP: merge after https://gerrit.wikimedia.org/r/#/c/119996/ [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/119999 [14:18:13] (03Merged) 10jenkins-bot: Tie debian glue to more slaves [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/119997 (owner: 10Hashar) [14:24:25] (03CR) 10Umherirrender: Adjust datetime in email confirmation email (031 comment) [core] - 10https://gerrit.wikimedia.org/r/119936 (owner: 1001tonythomas) [14:27:32] (03PS1) 10Siebrand: Fix various inconsistencies in messages [extensions/GWToolset] - 10https://gerrit.wikimedia.org/r/120003 [14:29:08] (03CR) 10Umherirrender: "Would be nice to have a comment about this patch set." [core] - 10https://gerrit.wikimedia.org/r/92928 (owner: 10Umherirrender) [14:29:56] (03PS1) 10Siebrand: Fix localisation [extensions/AccountInfo] - 10https://gerrit.wikimedia.org/r/120004 [14:31:39] (03CR) 10Raimond Spekking: [C: 031] Fix various inconsistencies in messages [extensions/GWToolset] - 10https://gerrit.wikimedia.org/r/120003 (owner: 10Siebrand) [14:32:17] (03CR) 10Raimond Spekking: [C: 032 V: 032] Fix localisation [extensions/AccountInfo] - 10https://gerrit.wikimedia.org/r/120004 (owner: 10Siebrand) [14:35:20] (03CR) 10Anomie: "Code seems sane, haven't tested. +1 from me after Siebrand's issues are fixed." [extensions/GlobalBlocking] - 10https://gerrit.wikimedia.org/r/119915 (owner: 10Hoo man) [14:52:28] (03CR) 10Siebrand: "This looks like you messed up. The latest patch set only leaves changes to MessagesEn.php and has removed all the other code changes. Let " [core] - 10https://gerrit.wikimedia.org/r/112323 (owner: 10Kunalgrover05) [14:54:07] (03CR) 10Kunalgrover05: "Yeah, I screwed my Git somehow. :(" [core] - 10https://gerrit.wikimedia.org/r/112323 (owner: 10Kunalgrover05) [14:54:35] tonythomas: Pretty sure the answer is "we set it that way once and people hate change" [14:57:18] (03PS11) 10Siebrand: Implement listing for tracking categories [core] - 10https://gerrit.wikimedia.org/r/112323 (owner: 10Kunalgrover05) [14:57:46] (03CR) 10Siebrand: "PS11 is PS8 with some tweaks in MessagesQqq.php." [core] - 10https://gerrit.wikimedia.org/r/112323 (owner: 10Kunalgrover05) [14:59:22] (03CR) 10Kunalgrover05: "Shouldn't MessagesQqq.php also have all the entries from MessagesEn.php?" [core] - 10https://gerrit.wikimedia.org/r/112323 (owner: 10Kunalgrover05) [15:00:28] (03CR) 10Siebrand: "Yes, but you've never added those. I commented that on PS8, I believe." [core] - 10https://gerrit.wikimedia.org/r/112323 (owner: 10Kunalgrover05) [15:00:31] rdwrer: so sure ! Can you help me with this ? I tried to add a number parameter to the $this->msg( 'userlogin-yourpassword' ) using ->numParams( '$foo').text(); in templates/Usercreate.php .( I added the $1 parameter in the i8n file ). It didn't work. Is there anything like ->numParams() wont work in templates/UserCreate.php ? [15:01:05] (03Abandoned) 10Siebrand: Merge "Updating link protocols for WMF wikis in the interwiki map" [core] - 10https://gerrit.wikimedia.org/r/119987 (owner: 10Kunalgrover05) [15:01:22] (03CR) 10Kunalgrover05: "Yeah, while adding them, I screwed it all up." [core] - 10https://gerrit.wikimedia.org/r/112323 (owner: 10Kunalgrover05) [15:04:14] tonythomas: Why would numParams work when you passed it '$foo'? It's for _numbers_, dude. [15:05:26] ok. $foo was assigned to a number earlier [15:06:03] https://doc.wikimedia.org/mediawiki-core/master/php/html/classMessage.html#a1d84a8387b66566616ceac86d6fcc4e4 [15:06:18] tonythomas: ^^ [15:06:57] (03PS1) 10Hashar: Revert "Tie debian glue to more slaves" [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/120014 [15:07:07] (03CR) 10Hashar: [C: 032] Revert "Tie debian glue to more slaves" [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/120014 (owner: 10Hashar) [15:07:21] (03CR) 10Nikerabbit: Migrate to JSON i18n (031 comment) [extensions/WikimediaMessages] - 10https://gerrit.wikimedia.org/r/119762 (owner: 10Siebrand) [15:08:11] (03Merged) 10jenkins-bot: Revert "Tie debian glue to more slaves" [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/120014 (owner: 10Hashar) [15:08:17] (03CR) 10Siebrand: Migrate to JSON i18n (031 comment) [extensions/WikimediaMessages] - 10https://gerrit.wikimedia.org/r/119762 (owner: 10Siebrand) [15:08:48] rdwrer: ok. in that case. if $foo = 333 , then ->numParams( $foo )->escaped(); works ? [15:09:45] Probably* [15:11:25] rdwrer: will try rightaway [15:12:47] (03CR) 10Nikerabbit: Migrate to JSON i18n (031 comment) [extensions/WikimediaMessages] - 10https://gerrit.wikimedia.org/r/119762 (owner: 10Siebrand) [15:13:35] (03CR) 10Siebrand: [C: 04-1] Migrate to JSON i18n (031 comment) [extensions/WikimediaMessages] - 10https://gerrit.wikimedia.org/r/119762 (owner: 10Siebrand) [15:14:38] (03PS2) 1001tonythomas: Adjust Date and Time in email confirmation email [core] - 10https://gerrit.wikimedia.org/r/119936 [15:26:27] rdwrer: dont know why, but that didn't work. I even gave $this->msg( 'userlogin-yourpassword' )->numParams(500); and it fails [15:27:32] tonythomas: numParams takes an *arry* [15:27:33] Read the docs [15:27:40] array* [15:28:24] rdwrer: oh! ok. missed that [15:34:49] rdwrer: I created an array and passed. Still it fails. I gave $this->msg( 'key' )->numParams( 567 )->parse(); as given in https://www.mediawiki.org/wiki/Manual:Messages_API#Additional_methods_of_printing_messages -- again the code is broken [15:35:10] tonythomas: And what error do you get? [15:35:18] Alternatively what does it show you? [15:36:38] rdwrer: I get the Special:UserLogin page with no CSS [15:37:14] I mean the create user account page ok [15:40:51] rdwrer: is there any reason like ->parse() or ->numParams() is not accessible from includes/template/ [15:41:19] (03PS2) 10Siebrand: Migrate to JSON i18n [extensions/WikimediaMessages] - 10https://gerrit.wikimedia.org/r/119762 [15:41:41] No, that shouldn't matter [15:41:42] (03CR) 10BryanDavis: [C: 032] Fix various inconsistencies in messages [extensions/GWToolset] - 10https://gerrit.wikimedia.org/r/120003 (owner: 10Siebrand) [15:41:45] (03CR) 10Siebrand: "PS2 corrects the incorrect values for $wgMessagesDirs" [extensions/WikimediaMessages] - 10https://gerrit.wikimedia.org/r/119762 (owner: 10Siebrand) [15:41:54] Wait, no CSS? That's pretty weird. [15:41:54] (03Merged) 10jenkins-bot: Fix various inconsistencies in messages [extensions/GWToolset] - 10https://gerrit.wikimedia.org/r/120003 (owner: 10Siebrand) [15:43:08] rdwrer: yeah! Thats right [15:44:06] rdwrer: all this time, I was getting no css! I edited it in here
[15:44:06] [15:44:38] @seen Dgarry [15:44:38] kushalk124: I have never seen Dgarry [15:47:55] (03CR) 10Nikerabbit: [C: 032] Migrate to JSON i18n [extensions/WikimediaMessages] - 10https://gerrit.wikimedia.org/r/119762 (owner: 10Siebrand) [15:47:59] (03Merged) 10jenkins-bot: Migrate to JSON i18n [extensions/WikimediaMessages] - 10https://gerrit.wikimedia.org/r/119762 (owner: 10Siebrand) [15:48:11] * siebrand thanks Nikerabbit. Wee! [15:50:15] is that the biggest JSON i18n patch to date? [15:56:43] (03CR) 10Hashar: "Well done guys!!!!" [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/119779 (owner: 10Jdlrobson) [16:05:31] (03PS1) 10PleaseStand: AutoLoader: Remove "Class ... not found" debug message [core] - 10https://gerrit.wikimedia.org/r/120024 [16:10:10] (03CR) 10Addshore: Simplify setup of RevisionCollectionPermissionsTest (031 comment) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/118729 (owner: 10Addshore) [16:11:03] rdwrer: fixed it by giving [16:11:03] echo $this->getMsg( 'userlogin-yourpassword' )->numParams( $foo)->escaped(); [16:12:26] (03PS2) 10Cmcmahon: MobileFrontend and UW share upload steps. [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/119999 [16:13:34] (03CR) 10Cmcmahon: [C: 032] "mediawiki-selenium 2.16 is available now" [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/119999 (owner: 10Cmcmahon) [16:13:41] (03Merged) 10jenkins-bot: MobileFrontend and UW share upload steps. [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/119999 (owner: 10Cmcmahon) [16:14:15] (03PS2) 10Chad: Remove "include redirects" option from search [core] - 10https://gerrit.wikimedia.org/r/118592 [16:16:28] legoktm: Hi! You around ? [16:16:41] hey tonythomas [16:17:19] legoktm: Hi ! I was working on https://bugzilla.wikimedia.org/show_bug.cgi?id=3348 as a micro task for our GSoC project [16:17:35] hmm [16:17:43] I'm not sure that's a good bug to try :/ [16:17:57] (03CR) 10Chad: [C: 032] Don't respect the "show redirects" option (031 comment) [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/118593 (owner: 10Chad) [16:18:05] (03Merged) 10jenkins-bot: Don't respect the "show redirects" option [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/118593 (owner: 10Chad) [16:18:17] btw, can you tell me how to acees $wgMinimalPasswordLength in DefaultSettings.php from a file in includes/template/Usercreate.hp [16:18:38] legoktm: I know. was just trying out, on how to get the message there alright [16:19:08] [16:19:12] those files are a mess though [16:19:17] <^d> I hate those files. [16:19:21] <^d> I wish they didn't exist. [16:19:30] <^d> Good morning legoktm! [16:19:31] I set $wgMinimalPasswordLength = 8, and now just to make a message show near password feild as (minimum x characters ) [16:19:56] legoktm: actually I gave global $wgMinimalPasswordLength; [16:20:07] but my echo $this->getMsg( 'userlogin-yourpassword' )->numParams( c )->escaped(); [16:20:15] morning ^d :) [16:20:17] prints out minimum c characters [16:20:29] should that be a $c? [16:20:47] $wgMinimalPasswordLength is shown as c [16:21:01] not $c, I have added the $1 parameter in i18n [16:21:14] oh wait [16:21:31] looks like the call was wrong [16:21:56] legoktm: now it come up alright [16:22:06] dont know where that c came from :) [16:22:09] :P [16:22:49] legoktm: I will send the PS anyway. if its useful let someone use it as per https://bugzilla.wikimedia.org/show_bug.cgi?id=3348#c12 [16:26:37] (03PS2) 10Chad: Rewrite Interwiki searches to return array of search results [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/119335 [16:31:33] (03PS3) 10Chad: Rewrite Interwiki searches to return array of search results [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/119335 [16:33:41] (03PS1) 1001tonythomas: Minimum password length for new account set to 8 [core] - 10https://gerrit.wikimedia.org/r/120025 [16:41:52] (03CR) 10CSteipp: [C: 031] "Thank you! This is a +1 on the feature going out. I haven't tested the patch, although from a quick browse, it looks about right." [core] - 10https://gerrit.wikimedia.org/r/119919 (owner: 10PleaseStand) [16:42:57] (03CR) 10EBernhardson: Simplify setup of RevisionCollectionPermissionsTest (031 comment) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/118729 (owner: 10Addshore) [16:51:41] (03PS1) 10Hashar: Compare JJB config changes by diffing XML output [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/120028 [16:52:11] (03CR) 10jenkins-bot: [V: 04-1] Compare JJB config changes by diffing XML output [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/120028 (owner: 10Hashar) [16:53:15] (03CR) 10Addshore: Simplify setup of RevisionCollectionPermissionsTest (031 comment) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/118729 (owner: 10Addshore) [16:56:19] (03PS2) 10Hashar: Compare JJB config changes by diffing XML output [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/120028 [16:57:07] (03CR) 10EBernhardson: Simplify setup of RevisionCollectionPermissionsTest (031 comment) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/118729 (owner: 10Addshore) [16:59:35] (03PS3) 10Kaldari: Removing Wikitravel from the default interwiki list [core] - 10https://gerrit.wikimedia.org/r/119923 [17:00:13] (03PS4) 10Kaldari: Removing Wikitravel from the default interwiki list [core] - 10https://gerrit.wikimedia.org/r/119923 [17:00:42] (03PS1) 10Hashar: integration-jjb-config-test is voting [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/120029 [17:03:54] (03PS3) 10Hashar: Compare JJB config changes by diffing XML output [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/120028 [17:04:09] (03CR) 10Hashar: "Will make the job voting anyway." [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/120028 (owner: 10Hashar) [17:05:28] (03PS1) 10Hashar: Trigger integration-jjb-config-diff [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/120031 [17:06:13] (03CR) 10Hashar: [C: 032] Trigger integration-jjb-config-diff [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/120031 (owner: 10Hashar) [17:06:35] (03CR) 10Hashar: [C: 032] integration-jjb-config-test is voting [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/120029 (owner: 10Hashar) [17:06:40] (03Merged) 10jenkins-bot: integration-jjb-config-test is voting [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/120029 (owner: 10Hashar) [17:06:43] (03Merged) 10jenkins-bot: Trigger integration-jjb-config-diff [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/120031 (owner: 10Hashar) [17:08:34] (03PS4) 10Hashar: Compare JJB config changes by diffing XML output [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/120028 [17:09:10] (03CR) 10jenkins-bot: [V: 04-1] Compare JJB config changes by diffing XML output [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/120028 (owner: 10Hashar) [17:09:36] (03PS5) 10Hashar: Compare JJB config changes by diffing XML output [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/120028 [17:10:33] (03CR) 10jenkins-bot: [V: 04-1] Compare JJB config changes by diffing XML output [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/120028 (owner: 10Hashar) [17:13:12] (03PS6) 10Hashar: Compare JJB config changes by diffing XML output [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/120028 [17:13:54] (03PS1) 10Chad: Swap wfProfileIn/Out calls for ProfileSection [core] - 10https://gerrit.wikimedia.org/r/120032 [17:14:52] (03CR) 10jenkins-bot: [V: 04-1] Compare JJB config changes by diffing XML output [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/120028 (owner: 10Hashar) [17:16:14] (03PS7) 10Hashar: Compare JJB config changes by diffing XML output [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/120028 [17:16:41] (03PS1) 10Chad: Remove extra profiling calls [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/120033 [17:17:20] (03CR) 10jenkins-bot: [V: 04-1] Compare JJB config changes by diffing XML output [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/120028 (owner: 10Hashar) [17:20:20] (03CR) 10jenkins-bot: [V: 04-1] Swap wfProfileIn/Out calls for ProfileSection [core] - 10https://gerrit.wikimedia.org/r/120032 (owner: 10Chad) [17:20:28] (03PS8) 10Hashar: Compare JJB config changes by diffing XML output [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/120028 [17:22:43] (03PS2) 10Chad: Swap wfProfileIn/Out calls for ProfileSection [core] - 10https://gerrit.wikimedia.org/r/120032 [17:24:54] (03PS9) 10Hashar: Compare JJB config changes by diffing XML output [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/120028 [17:26:00] (03CR) 10Bsitu: [C: 032] Revert "Auto-wrapping explicit escaper for templates" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/119920 (owner: 10EBernhardson) [17:26:30] (03Merged) 10jenkins-bot: Revert "Auto-wrapping explicit escaper for templates" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/119920 (owner: 10EBernhardson) [17:29:43] (03CR) 10Phuedx: WIP: Refactor and add non-linear tours (037 comments) [extensions/GuidedTour] - 10https://gerrit.wikimedia.org/r/116228 (owner: 10Mattflaschen) [17:30:57] (03CR) 10Kaldari: [C: 031] "This looks like a good start :)" [core] - 10https://gerrit.wikimedia.org/r/84303 (owner: 10TTO) [17:34:08] (03PS1) 10Hashar: Compare JJB config changes by diffing XML output [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/120036 [17:34:21] (03Abandoned) 10Hashar: Compare JJB config changes by diffing XML output [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/120028 (owner: 10Hashar) [17:34:28] (03CR) 10Kaldari: "Also, since memoryalpha is a wikia wiki, can't we remove it as well?" [core] - 10https://gerrit.wikimedia.org/r/84303 (owner: 10TTO) [17:36:54] (03CR) 10Hashar: "Diff example at https://integration.wikimedia.org/ci/job/integration-jjb-config-diff/1/console using the patchset https://gerrit.wikimedi" [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/120036 (owner: 10Hashar) [17:37:21] (03PS5) 10Kaldari: Removing Wikitravel from the default interwiki list [core] - 10https://gerrit.wikimedia.org/r/119923 [17:39:30] (03CR) 10Kaldari: "Wow, I can't believe this patch has been sitting here since September. Regardless of whether it is perfect or not, it's a huge improvement" [core] - 10https://gerrit.wikimedia.org/r/84303 (owner: 10TTO) [17:50:15] (03PS12) 10Kunalgrover05: Implement listing for tracking categories [core] - 10https://gerrit.wikimedia.org/r/112323 [17:51:11] (03CR) 10Nemo bis: "> Note that removing entries from this list will not effect existing wikis, only new wikis, as running update does not remove any entries " [core] - 10https://gerrit.wikimedia.org/r/84303 (owner: 10TTO) [17:51:17] (03CR) 10jenkins-bot: [V: 04-1] Implement listing for tracking categories [core] - 10https://gerrit.wikimedia.org/r/112323 (owner: 10Kunalgrover05) [17:55:01] (03CR) 10Adamw: [C: 031] "I wholeheartedly agree, but since I wrote the FIXME, I should wait for other devs' feedback." [core] - 10https://gerrit.wikimedia.org/r/120024 (owner: 10PleaseStand) [17:55:48] YuviPanda: /me bumps the yaml patch [17:57:13] (03PS4) 10Krinkle: resourceloader: Separate gathering of registry data from mw.loader call [core] - 10https://gerrit.wikimedia.org/r/117444 [17:57:48] Krinkle: if you have a few seconds, we'd really like the voting enabled here, https://gerrit.wikimedia.org/r/#/c/118727 [17:57:57] Perhaps we still need hashar to deploy the change, though... [17:58:31] Yes, integration/ repos should not be merged in unless it is or will be deployed (some we merge after, others merge first if run from git) [17:59:03] Ohsorry, I thought I deployed that [17:59:07] (03PS3) 10Krinkle: Make DonationInterface tests voting; Remove "runtests" target [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/118727 (owner: 10Adamw) [17:59:12] Krinkle: thx! [17:59:12] (03CR) 10Krinkle: [C: 032] Make DonationInterface tests voting; Remove "runtests" target [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/118727 (owner: 10Adamw) [17:59:20] (03Merged) 10jenkins-bot: Make DonationInterface tests voting; Remove "runtests" target [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/118727 (owner: 10Adamw) [18:00:34] [#wikimedia-operations] : !log Reloading Zuul to deploy I20b4aa9159df7 [18:00:36] awight: ^ [18:00:47] (03CR) 10BryanDavis: "What exactly is "impolite" about debug logging the failure?" [core] - 10https://gerrit.wikimedia.org/r/120024 (owner: 10PleaseStand) [18:02:44] (03CR) 10Trevor Parscal: "I think this needs to be merged immediately so it makes it into 1.23, not until after 1.23 is cut." [core] - 10https://gerrit.wikimedia.org/r/118345 (owner: 10Jdlrobson) [18:03:42] (03CR) 10Adamw: "BryanDavis: perhaps I should have chosen my words more carefully. The convention in PHP autoloaders is to attempt to find the class in wh" [core] - 10https://gerrit.wikimedia.org/r/120024 (owner: 10PleaseStand) [18:05:30] (03CR) 10Krinkle: "Rebased to resolve conflict with c29d513." [core] - 10https://gerrit.wikimedia.org/r/117444 (owner: 10Krinkle) [18:07:10] (03PS1) 10Jforrester: Update OOjs UI to v0.1.0-pre (3b434d5388) [core] - 10https://gerrit.wikimedia.org/r/120041 [18:08:24] (03PS3) 10Krinkle: Import CologneBlue skin from MediaWiki core [skins/CologneBlue] - 10https://gerrit.wikimedia.org/r/119884 (owner: 10Jdlrobson) [18:08:26] (03PS3) 10Krinkle: Import Modern skin from MediaWiki core [skins/Modern] - 10https://gerrit.wikimedia.org/r/119885 (owner: 10Jdlrobson) [18:10:36] (03PS4) 10Jdlrobson: Move Modern and CologneBlue out of core [core] - 10https://gerrit.wikimedia.org/r/118345 [18:11:35] (03CR) 10jenkins-bot: [V: 04-1] Move Modern and CologneBlue out of core [core] - 10https://gerrit.wikimedia.org/r/118345 (owner: 10Jdlrobson) [18:12:50] (03PS5) 10Jdlrobson: Move Modern and CologneBlue out of core [core] - 10https://gerrit.wikimedia.org/r/118345 [18:14:11] (03PS4) 10Jdlrobson: Move CologneBlue out of core. [skins/CologneBlue] - 10https://gerrit.wikimedia.org/r/119884 [18:25:16] (03CR) 10MarkTraceur: [C: 04-2] "This needs to be discussed on a grander scale than just #wikimedia-dev and Bugzilla. Go to VPTs or mailing lists, but don't just submit a " (031 comment) [core] - 10https://gerrit.wikimedia.org/r/120025 (owner: 1001tonythomas) [18:26:13] (03CR) 10Siebrand: [C: 04-1] Move Modern and CologneBlue out of core (032 comments) [core] - 10https://gerrit.wikimedia.org/r/118345 (owner: 10Jdlrobson) [18:26:57] (03CR) 10Siebrand: [C: 031] "i18n/L10n reviewed." [skins/CologneBlue] - 10https://gerrit.wikimedia.org/r/119884 (owner: 10Jdlrobson) [18:27:55] (03CR) 10Siebrand: [C: 031] "i18n/L10n reviewed." [skins/Modern] - 10https://gerrit.wikimedia.org/r/119885 (owner: 10Jdlrobson) [18:32:46] (03CR) 10Bsitu: [C: 032] Cleanup another round of analysis warnings [extensions/Flow] - 10https://gerrit.wikimedia.org/r/119890 (owner: 10EBernhardson) [18:33:04] (03CR) 10jenkins-bot: [V: 04-1] Cleanup another round of analysis warnings [extensions/Flow] - 10https://gerrit.wikimedia.org/r/119890 (owner: 10EBernhardson) [18:35:58] (03CR) 10Siebrand: [C: 04-1] "i18n/L10n reviewed." (036 comments) [core] - 10https://gerrit.wikimedia.org/r/112323 (owner: 10Kunalgrover05) [18:36:00] (03PS6) 10Jdlrobson: Move Modern and CologneBlue out of core [core] - 10https://gerrit.wikimedia.org/r/118345 [18:37:24] (03CR) 10Siebrand: [C: 04-1] "Almost there, Jon. i18n/L10n-wise that is..." (031 comment) [core] - 10https://gerrit.wikimedia.org/r/118345 (owner: 10Jdlrobson) [18:43:20] (03CR) 10Siebrand: [C: 04-1] "i18n/L10n reviewed." (032 comments) [core] - 10https://gerrit.wikimedia.org/r/120025 (owner: 1001tonythomas) [18:45:28] (03PS3) 10Bsitu: Cleanup another round of analysis warnings [extensions/Flow] - 10https://gerrit.wikimedia.org/r/119890 (owner: 10EBernhardson) [18:45:36] (03CR) 10MaxSem: "We have recently had a well-discussed RFC about raising it to 6 chars, and it will be implemented soon. Suggest abandoning." [core] - 10https://gerrit.wikimedia.org/r/120025 (owner: 1001tonythomas) [18:46:09] (03CR) 10Bsitu: [C: 032] Cleanup another round of analysis warnings [extensions/Flow] - 10https://gerrit.wikimedia.org/r/119890 (owner: 10EBernhardson) [18:46:23] (03CR) 10jenkins-bot: [V: 04-1] Cleanup another round of analysis warnings [extensions/Flow] - 10https://gerrit.wikimedia.org/r/119890 (owner: 10EBernhardson) [18:48:21] (03CR) 1001tonythomas: [C: 04-1] "The feature requires more discussion and consensus." [core] - 10https://gerrit.wikimedia.org/r/120025 (owner: 1001tonythomas) [18:48:41] (03Abandoned) 1001tonythomas: Minimum password length for new account set to 8 [core] - 10https://gerrit.wikimedia.org/r/120025 (owner: 1001tonythomas) [18:50:12] (03PS1) 10PleaseStand: Use ProfileSection class from core [extensions/Score] - 10https://gerrit.wikimedia.org/r/120054 [18:52:44] (03CR) 10Bartosz Dziewoński: [C: 04-1] "And I think this should not be merged before 1.23. We've removed enough skins from core for now, and the process for both creating new ski" [core] - 10https://gerrit.wikimedia.org/r/118345 (owner: 10Jdlrobson) [18:54:10] (03PS1) 10Ottomata: Updating wikimetrics submodule [vagrant] - 10https://gerrit.wikimedia.org/r/120055 [18:55:24] (03PS4) 10Bsitu: Cleanup another round of analysis warnings [extensions/Flow] - 10https://gerrit.wikimedia.org/r/119890 (owner: 10EBernhardson) [18:56:08] (03PS2) 10Ottomata: Updating wikimetrics submodule [vagrant] - 10https://gerrit.wikimedia.org/r/120055 [18:56:13] (03CR) 10Ottomata: [C: 032 V: 032] Updating wikimetrics submodule [vagrant] - 10https://gerrit.wikimedia.org/r/120055 (owner: 10Ottomata) [19:01:35] (03CR) 10Bsitu: [C: 032] Cleanup another round of analysis warnings [extensions/Flow] - 10https://gerrit.wikimedia.org/r/119890 (owner: 10EBernhardson) [19:01:53] (03Merged) 10jenkins-bot: Cleanup another round of analysis warnings [extensions/Flow] - 10https://gerrit.wikimedia.org/r/119890 (owner: 10EBernhardson) [19:04:30] (03CR) 10Kaldari: "susning.nu looks like it's just Lars Aronsson's resume. I can't imagine a lot of new wikis wanting to interwiki-link to Lars' resume, but " [core] - 10https://gerrit.wikimedia.org/r/84303 (owner: 10TTO) [19:08:09] (03CR) 10Krinkle: [C: 04-1] "Main file should be Modern.php, not modern.php, after the extension name (other skin extensions do this as well)." (033 comments) [skins/Modern] - 10https://gerrit.wikimedia.org/r/119885 (owner: 10Jdlrobson) [19:09:40] (03CR) 10Trevor Parscal: [C: 032] Update OOjs UI to v0.1.0-pre (3b434d5388) [core] - 10https://gerrit.wikimedia.org/r/120041 (owner: 10Jforrester) [19:11:57] (03CR) 10Krinkle: Import Modern skin from MediaWiki core (031 comment) [skins/Modern] - 10https://gerrit.wikimedia.org/r/119885 (owner: 10Jdlrobson) [19:13:12] (03PS4) 10Krinkle: Import Modern skin from MediaWiki core [skins/Modern] - 10https://gerrit.wikimedia.org/r/119885 (owner: 10Jdlrobson) [19:14:10] (03Merged) 10jenkins-bot: Update OOjs UI to v0.1.0-pre (3b434d5388) [core] - 10https://gerrit.wikimedia.org/r/120041 (owner: 10Jforrester) [19:15:53] (03CR) 10Krinkle: "Hm.. maybe create the repo under mediawiki/extensions instead, so that there is no confusion over how to install this. Other skins we've m" [skins/Modern] - 10https://gerrit.wikimedia.org/r/119885 (owner: 10Jdlrobson) [19:20:14] (03CR) 10Jdlrobson: "Okay now I'm super confused. I originally had it as Modern.php but was asked to rename it. "Don't use a Modern/Modern.php + Modern/modern/" [skins/Modern] - 10https://gerrit.wikimedia.org/r/119885 (owner: 10Jdlrobson) [19:21:49] (03PS7) 10Jdlrobson: Move Modern and CologneBlue out of core [core] - 10https://gerrit.wikimedia.org/r/118345 [19:23:12] (03CR) 10Jdlrobson: [C: 032] "We can resolve the mixins issue later - we will need to restructure the directory structure anyhow, since everything else is currently usi" [extensions/VectorBeta] - 10https://gerrit.wikimedia.org/r/117119 (owner: 10JGonera) [19:23:21] (03Merged) 10jenkins-bot: Add icons to compact personal bar [extensions/VectorBeta] - 10https://gerrit.wikimedia.org/r/117119 (owner: 10JGonera) [19:26:03] (03CR) 10Aaron Schulz: [C: 032] Use ProfileSection class from core [extensions/Score] - 10https://gerrit.wikimedia.org/r/120054 (owner: 10PleaseStand) [19:26:05] (03Merged) 10jenkins-bot: Use ProfileSection class from core [extensions/Score] - 10https://gerrit.wikimedia.org/r/120054 (owner: 10PleaseStand) [19:33:19] (03CR) 10Jforrester: "Leaving these mostly-unsupported and unsupportable skins in core means continuing to lie to downstream users. Doing so in an LTS means doi" [core] - 10https://gerrit.wikimedia.org/r/118345 (owner: 10Jdlrobson) [19:37:41] (03CR) 10Chad: [C: 031] "Less prefs. Less code. Less skins. What's not to love?" [core] - 10https://gerrit.wikimedia.org/r/118345 (owner: 10Jdlrobson) [19:38:40] (03CR) 10Bartosz Dziewoński: "(Clarifying and updating this documentation is part of my GSoC proposal, and now you see why it's clearly needed :D)" [skins/Modern] - 10https://gerrit.wikimedia.org/r/119885 (owner: 10Jdlrobson) [19:38:45] jdlrobson: James_F: ^d could someone respond to hexmode's question on the list about this? http://lists.wikimedia.org/pipermail/wikitech-l/2014-March/075182.html (where this is the skin break out) [19:39:00] ya know, the tarball release manager ;) [19:39:36] greg-g: What's in core doesn't really affect what's in the tarballs; adding a single line to the build scripts isn't huge… [19:39:48] James_F: D: [19:39:51] <^d> Isn't the same discussion happening on the gerrit change? [19:39:59] James_F: to him, not me :) [19:40:08] greg-g: But yes, if Deskana doesn't object to me interfering in his field, I can reply. [19:40:08] ^d: only not seen by everyone :/ [19:40:12] holding this until after 1.23 sounds like a good idea, and i haven't even seen this e-mail before apparently [19:40:13] kk [19:40:14] greg-g: Don't want to step on any toes… [19:40:16] yeah [19:40:18] * greg-g nods [19:40:35] <^d> Waiting for 1.23 is silly. [19:40:36] <^d> w/e. [19:40:37] (this is probably the first time mark and i agree on something entirely, heh) [19:40:48] ^d: Waiting for 1.24wmf1, you mean. And yes. [19:41:01] <^d> Waiting at all. [19:41:01] Let's not have this discussion in /three/ places. [19:41:06] :P [19:41:14] Or twelve or whatever. [19:41:26] <^d> We could merge now so we don't have to have the discussion in any places ;-) [19:41:51] (03CR) 10Bartosz Dziewoński: [C: 04-1] "As before." [core] - 10https://gerrit.wikimedia.org/r/118345 (owner: 10Jdlrobson) [19:42:56] ^d: :P [19:43:00] grhhhh, i've just written like ten kilobytes of text about how not to fuck up when doing exactly this and now everyone want to merge things right now [19:43:01] Who wants my opinion? [19:43:02] And on what? [19:43:11] everything [19:43:13] everyone [19:44:15] (03PS8) 10Ganeshaditya1: Display a warning when the user name looked up is not registered. [core] - 10https://gerrit.wikimedia.org/r/117854 [19:45:12] <^d> Nothing has to fuck up. Just delete the skins and forget they exist. [19:45:15] <^d> What breaks? :p [19:45:28] ^d: only if vector goes down first. :D [19:46:06] * ^d wants one skin, effectively hardcoded UI [19:46:13] <^d> Then we don't need a skin system at all!!!! [19:46:28] (03PS9) 10Ganeshaditya1: Display a warning when the user name looked up is not registered. [core] - 10https://gerrit.wikimedia.org/r/117854 [19:46:54] (03CR) 10Bartosz Dziewoński: "My point is, I am *certain* that we will do something incompatible before the next LTS, and everyone doing skins I've ever asked has compl" [core] - 10https://gerrit.wikimedia.org/r/118345 (owner: 10Jdlrobson) [19:47:25] (03Abandoned) 10Hashar: Exceptions can now optionally have a dedup id [core] - 10https://gerrit.wikimedia.org/r/108890 (owner: 10Hashar) [19:47:43] Deskana: Removing the non-Vector/Monobook skins from MW-core. [19:48:07] ^d: you know, you'll get both of these things free with my gsoc :P (i want to move them out of core, and then we'll need a fallback skin) [19:48:24] * MatmaRex points to https://www.mediawiki.org/wiki/User:Matma_Rex/Separating_skins_from_core_MediaWiki ~ [19:49:16] (03CR) 10Chad: "How is deleting these old skins breaking the existing skin API? I'm not saying do anything else other than just merging this." [core] - 10https://gerrit.wikimedia.org/r/118345 (owner: 10Jdlrobson) [19:49:36] How does this affect our users? [19:49:55] If I understand this correctly, it doesn't. The skins they can use on WMF wikis are unaffected by this change. [19:50:39] <^d> Why wouldn't this master change go into the next wmf branch? [19:50:47] Deskana: um, no. the skins will be removed. [19:51:12] Deskana: if we want to keep them, jon's trying to move them into "extensions", but we currently don't really have a process for deploying extnesion-like skins [19:51:19] (we have Nostalgia, but it sucks) [19:51:30] Deskana: This is about users of MW (third party installers) rather than Wikimedia site users. [19:51:40] <^d> Nostalgia was a hack so I could delete it from core but not break nostalgiawiki [19:52:12] ^d: yes, my point exactly [19:52:19] let's not do that anymore [19:52:25] again* [19:52:31] <^d> meh, it works. [19:52:48] it's a bad practice [19:53:16] <^d> again, meh. [19:54:40] * Deskana reads the page MatmaRex linked. [19:55:10] The idea of this patch was to simply move them out of core for the time being with the idea they would still be enabled on wikimedia sites that want them and to revisit the discussion of where and if they should be enabled [19:55:35] on a side note, imo mediawiki.org should be packaged with more than the default skins to showcase what skins are available [19:55:48] So actually, what was said in this channel isn't entirely accurate. This is mostly just a technical, back-end thing: we're not stopping people from using skins on their third-party websites, it's just that they'd have to install, say, Extension:Modern, rather than it being in there by default. [19:56:08] <^d> jdlrobson: I'd prefer doing that on labs. [19:56:09] Is that accurate? [19:57:19] Deskana: that sounds accurate to me [19:57:36] * Deskana wonders why it doesn't already work that way in the first place. [19:57:41] Modularity is good, yo. [19:58:07] Deskana: (if you're talking about my proposal and not just the patches, then mostly yes too, but more like Skin:Modern - not exactly an extension) [19:58:34] <^d> I don't think anyone disagrees that skins should be easier to make & install [19:58:38] <^d> And modularity++ [19:59:05] <^d> What's being debated is *when* we'll paint the bikeshed we've already agreed to paint. [20:07:11] MatmaRex: Okay, so. [20:07:25] (03CR) 10Isarra: "skins/Modern/Modern.php etc is correct." [skins/Modern] - 10https://gerrit.wikimedia.org/r/119885 (owner: 10Jdlrobson) [20:07:56] MatmaRex: As the product manager, I have no opinion. I think it's an entirely technical decision; the end-users of mediawiki wouldn't notice the change at all, since it's a back-end thing. [20:08:45] MatmaRex: As a reasonably technical person (who is not as technical as developers like you), I think it's a good idea. Modularity is good! [20:09:10] * Deskana does not understand why skins are hard-coded into core. [20:09:25] MatmaRex: I'd recommend speaking to whoever is responsible for making the bundles we distribute to third parties. I don't know who that is. [20:09:33] Deskana: hysterical raisins ;) [20:09:47] Deskana: that's mark and markus [20:09:52] Okay. [20:09:59] MatmaRex: Does that sufficiently answer your question then? :) [20:11:05] Deskana: i agree this is a technical matter and that most end-users probably won't notice if we execute it well – but some will notice, and this needs documentation etc., and personally i am not comfortable rushing this, especially for a LTS release [20:12:39] Deskana: i am not exactly in a position to decide :) [20:12:59] mark has already suggested postponing to 1.24, and i agree with that; that is all :) [20:13:10] Okay, cool. This all sounds sane enough to me. [20:13:22] (heh, this sounded like a bit of a cop-out…) [20:17:49] (03CR) 10Chad: [C: 032] Remove extra profiling calls [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/120033 (owner: 10Chad) [20:17:59] (03Merged) 10jenkins-bot: Remove extra profiling calls [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/120033 (owner: 10Chad) [20:18:02] * ^d is self-merging like a rebel [20:25:06] (03CR) 10GWicke: "@Bryan: The need to log to a specific logger makes it harder to filter dynamically, and looks pretty verbose and high overhead to me. I do" [core] - 10https://gerrit.wikimedia.org/r/112699 (owner: 10BryanDavis) [20:27:29] spagewmf, I know Fabrice is planning to archive the AFTv5 feedback somewhere. It's possible that's what aftv5 on Labs is for. [20:28:55] superm401: maybe. I asked E2 and nobody responded about that labs instance. [20:29:01] Well, presumably they have dumps somewhere other than Labs storage. [20:29:19] Anyway I think project storage gets migrated automatically. [20:34:39] (03CR) 10Hashar: "Parent5446" [core] - 10https://gerrit.wikimedia.org/r/112699 (owner: 10BryanDavis) [20:36:21] (03CR) 10BryanDavis: [C: 04-2] "Mergeable implementation:" [core] - 10https://gerrit.wikimedia.org/r/112699 (owner: 10BryanDavis) [20:46:27] (03CR) 10Mwjames: "If you really have to deploy code from an external source that is managed by Composer, you should use the /vendor/monolog directory and ke" [core] - 10https://gerrit.wikimedia.org/r/119939 (owner: 10BryanDavis) [20:50:24] (03PS3) 10Kaldari: Update default contents of interwiki table [core] - 10https://gerrit.wikimedia.org/r/84303 (owner: 10TTO) [20:51:25] (03PS8) 10UltrasonicNXT: WIP - Rewrite [extensions/WikiForum] - 10https://gerrit.wikimedia.org/r/116258 [20:56:31] (03PS4) 10Kaldari: Update default contents of interwiki table [core] - 10https://gerrit.wikimedia.org/r/84303 (owner: 10TTO) [21:01:50] Nemo_bis: Rebased TTO's interwiki table clean-up and also fixed some errors in it. Let me know what you think. [21:05:00] If you insist :) [21:05:13] (03PS5) 10Kaldari: Update default contents of interwiki table [core] - 10https://gerrit.wikimedia.org/r/84303 (owner: 10TTO) [21:05:26] Missed one :) [21:05:47] Did you check all those URLs? [21:05:47] Nemo_bis: Do you understand the change to the wikia URL? That's the only one I'm not sure about. [21:07:18] Hm, the new form is what we use normally [21:08:00] Nemo_bis: With the 'c:'? [21:09:06] TTO's version actually had Wikia listed twice. I wasn't quite sure which one was correct as I've never seen the 'c:' syntax before [21:09:39] (03CR) 10BryanDavis: "We can't use vendor/... because that would break Jeroen's hard work on https://www.mediawiki.org/wiki/Composer." [core] - 10https://gerrit.wikimedia.org/r/119939 (owner: 10BryanDavis) [21:10:00] c: is what produces the redirect [21:10:56] (03PS6) 10Kaldari: Update default contents of interwiki table [core] - 10https://gerrit.wikimedia.org/r/84303 (owner: 10TTO) [21:11:12] Nemo_bis: Found one more bad URL. Fixed. [21:15:46] (03PS1) 10Rahul mishra: Break up large blocks of text in Wikimania Scholarships i18n files [wikimedia/wikimania-scholarships] - 10https://gerrit.wikimedia.org/r/120146 [21:18:35] (03CR) 10Nemo bis: "The wikia: prefix is used to link any Wikia wiki, with the subdomain name as final prefix before the actual title. IIRC, we've always used" [core] - 10https://gerrit.wikimedia.org/r/84303 (owner: 10TTO) [21:19:32] (03CR) 10Nemo bis: "Also, why are the Wikimedia projects marked local? They shouldn't have a preferential treatment." [core] - 10https://gerrit.wikimedia.org/r/84303 (owner: 10TTO) [21:19:54] (03CR) 10BryanDavis: "I think that Siebrand's intent was to make separate messages from the large blocks rather than to simply introduce whitespace. Hopefully h" [wikimedia/wikimania-scholarships] - 10https://gerrit.wikimedia.org/r/120146 (owner: 10Rahul mishra) [21:21:50] (03CR) 10BryanDavis: Break up large blocks of text in Wikimania Scholarships i18n files (031 comment) [wikimedia/wikimania-scholarships] - 10https://gerrit.wikimedia.org/r/120146 (owner: 10Rahul mishra) [21:21:52] (03CR) 10Jeroen De Dauw: "This approach looks conceptually good to me. Have to agree it seems the most pragmatic thing to do. Several other PHP projects are doing e" (031 comment) [core] - 10https://gerrit.wikimedia.org/r/119939 (owner: 10BryanDavis) [21:23:10] (03CR) 10Jeroen De Dauw: "Also shows how we can perfectly have the extension management and MW dependencies work side by side without drastically changing the MW in" [core] - 10https://gerrit.wikimedia.org/r/119939 (owner: 10BryanDavis) [21:23:31] (03CR) 10BryanDavis: Add Composer managed libraries (031 comment) [core] - 10https://gerrit.wikimedia.org/r/119939 (owner: 10BryanDavis) [21:25:25] JeroenDeDauw: Thanks for the comments. +1's are welcomed as well ;) [21:26:59] hexmode: Are you there? [21:27:07] (03PS16) 10JGonera: Add Fixed header experiment to Vector Beta [extensions/VectorBeta] - 10https://gerrit.wikimedia.org/r/107523 (owner: 10Jdlrobson) [21:27:39] (03CR) 10JGonera: [C: 032] "There were still two definitions of $wgVBResourceBoilerplate. I removed one." [extensions/VectorBeta] - 10https://gerrit.wikimedia.org/r/107523 (owner: 10Jdlrobson) [21:27:44] (03Merged) 10jenkins-bot: Add Fixed header experiment to Vector Beta [extensions/VectorBeta] - 10https://gerrit.wikimedia.org/r/107523 (owner: 10Jdlrobson) [21:29:24] (03CR) 10JGonera: [C: 032] Ensure that we do not run VectorBeta outside Vector skin [extensions/VectorBeta] - 10https://gerrit.wikimedia.org/r/119664 (owner: 10Jdlrobson) [21:29:27] (03CR) 10jenkins-bot: [V: 04-1] Ensure that we do not run VectorBeta outside Vector skin [extensions/VectorBeta] - 10https://gerrit.wikimedia.org/r/119664 (owner: 10Jdlrobson) [21:30:25] (03PS15) 10Bsitu: [Schema Change]Add column rev_type_id to table flow_revision [extensions/Flow] - 10https://gerrit.wikimedia.org/r/116861 [21:30:42] bd808: ugh, cryptic name much? [21:30:59] bd808: I will +1 after the .json file has a sane style [21:31:46] bd808: I've seen MANY such files, and this is really odd [21:32:01] Also, either tab or 4 spaces are used, looks like you have 2 spaces [21:32:31] JeroenDeDauw: I will amend. Easy fixes. [21:33:15] I could opine on the beauty of the leading comma style in files that don't allow extra trailing commas but meh. [21:36:02] (03PS2) 10BryanDavis: Add Composer managed libraries [core] - 10https://gerrit.wikimedia.org/r/119939 [21:39:29] (03CR) 10BryanDavis: "Fixed json formatting" (031 comment) [core] - 10https://gerrit.wikimedia.org/r/119939 (owner: 10BryanDavis) [21:41:25] (03PS14) 10Bsitu: Update column data: flow_revision.rev_type_id [extensions/Flow] - 10https://gerrit.wikimedia.org/r/116874 [21:44:19] (03CR) 10Swalling: [C: 031] "I consider the original patchset that changed to 'page' to have been a regression, and this is language is a very specific and considered " [extensions/GettingStarted] - 10https://gerrit.wikimedia.org/r/119972 (owner: 10Phuedx) [21:51:39] (03PS17) 10Jdlrobson: Rewrite the navigation links under the heading [extensions/VectorBeta] - 10https://gerrit.wikimedia.org/r/117903 [21:55:11] (03PS3) 10Jdlrobson: Hygiene: Cleanup VectorBeta.php resources [extensions/VectorBeta] - 10https://gerrit.wikimedia.org/r/119904 [21:55:13] (03PS13) 10Jdlrobson: Give Vector/Winter Minerva's hamburger menu icon [extensions/VectorBeta] - 10https://gerrit.wikimedia.org/r/117927 [21:55:15] (03PS1) 10Jdlrobson: Hygiene: Reorganise the repository by beta feature [extensions/VectorBeta] - 10https://gerrit.wikimedia.org/r/120147 [21:55:24] (03CR) 10Jeroen De Dauw: Add Composer managed libraries (033 comments) [core] - 10https://gerrit.wikimedia.org/r/119939 (owner: 10BryanDavis) [21:55:58] (03PS5) 10Jdlrobson: Ensure that we do not run VectorBeta outside Vector skin [extensions/VectorBeta] - 10https://gerrit.wikimedia.org/r/119664 [21:56:19] (03CR) 10JGonera: "A bunch of inline comments in patchset 16." (038 comments) [extensions/VectorBeta] - 10https://gerrit.wikimedia.org/r/117903 (owner: 10Jdlrobson) [21:56:29] (03CR) 10JGonera: [C: 04-1] "See previous comment." [extensions/VectorBeta] - 10https://gerrit.wikimedia.org/r/117903 (owner: 10Jdlrobson) [21:58:52] (03CR) 10Mattflaschen: "I know we've discussed this before, but these are my current thoughts:" [extensions/GettingStarted] - 10https://gerrit.wikimedia.org/r/119972 (owner: 10Phuedx) [22:06:53] (03CR) 10JGonera: [C: 04-1] "Weird things happen in Firefox (hamburger too big and overlaps the menu when menu open) + inline comment." (031 comment) [extensions/VectorBeta] - 10https://gerrit.wikimedia.org/r/117927 (owner: 10Jdlrobson) [22:07:00] (03PS3) 10BryanDavis: Add Composer managed libraries [core] - 10https://gerrit.wikimedia.org/r/119939 [22:07:10] (03CR) 10BryanDavis: Add Composer managed libraries (033 comments) [core] - 10https://gerrit.wikimedia.org/r/119939 (owner: 10BryanDavis) [22:07:35] (03CR) 10JGonera: [C: 032] Ensure that we do not run VectorBeta outside Vector skin [extensions/VectorBeta] - 10https://gerrit.wikimedia.org/r/119664 (owner: 10Jdlrobson) [22:08:06] (03Merged) 10jenkins-bot: Ensure that we do not run VectorBeta outside Vector skin [extensions/VectorBeta] - 10https://gerrit.wikimedia.org/r/119664 (owner: 10Jdlrobson) [22:12:49] (03PS5) 10Krinkle: MWException: Expand {{SITENAME}} in pagetitle with Message::text() [core] - 10https://gerrit.wikimedia.org/r/116080 (owner: 10Brian Wolff) [22:13:06] (03CR) 10Krinkle: [C: 032] MWException: Expand {{SITENAME}} in pagetitle with Message::text() [core] - 10https://gerrit.wikimedia.org/r/116080 (owner: 10Brian Wolff) [22:13:13] (03PS3) 10Krinkle: MWException: Fix sitename appearing twice in [core] - 10https://gerrit.wikimedia.org/r/118665 [22:18:32] <grrrit-wm> (03Merged) 10jenkins-bot: MWException: Expand {{SITENAME}} in pagetitle with Message::text() [core] - 10https://gerrit.wikimedia.org/r/116080 (owner: 10Brian Wolff) [22:18:41] <grrrit-wm> (03CR) 10Jeroen De Dauw: [C: 031] Add Composer managed libraries [core] - 10https://gerrit.wikimedia.org/r/119939 (owner: 10BryanDavis) [22:26:48] <^d> AaronSchulz: https://gerrit.wikimedia.org/r/#/c/119505/ :) [22:27:18] <grrrit-wm> (03PS7) 10Kaldari: Update default contents of interwiki table [core] - 10https://gerrit.wikimedia.org/r/84303 (owner: 10TTO) [22:27:25] <AaronSchulz> maybe if https://gerrit.wikimedia.org/r/#/c/115522/ was merged [22:27:57] <grrrit-wm> (03PS8) 10Kaldari: Update default contents of interwiki table [core] - 10https://gerrit.wikimedia.org/r/84303 (owner: 10TTO) [22:28:37] <kaldari> Nemo_bis: Implemented your suggestions on the interwiki changes [22:30:56] <grrrit-wm> (03PS12) 10Krinkle: mediawiki.api: Refactor getToken and postWithToken methods [core] - 10https://gerrit.wikimedia.org/r/111636 [22:32:34] <grrrit-wm> (03PS16) 10Bsitu: Update post/header revision storage search key [extensions/Flow] - 10https://gerrit.wikimedia.org/r/117099 [22:36:05] <grrrit-wm> (03PS18) 10Jdlrobson: Rewrite the navigation links under the heading [extensions/VectorBeta] - 10https://gerrit.wikimedia.org/r/117903 [22:36:17] <jdlrobson> ^ jgonera boom. Should hopefully make you happy [22:40:23] <grrrit-wm> (03CR) 10Amire80: [C: 031] "Tested." [extensions/BetaFeatures] - 10https://gerrit.wikimedia.org/r/118963 (owner: 10Legoktm) [22:41:06] <zeek_> Hi, I need a little i18n advice. I was working on the bug............. https://bugzilla.wikimedia.org/show_bug.cgi?id=33394 ........... and i made changes like this.... http://www.fpaste.org/87573/95440984/ ... It works but Please tell me if this is the acceptable way.. [22:41:09] <grrrit-wm> (03CR) 10BryanDavis: "@GWicke I'm not sure I follow your concerns. Are you worried about controlling which messages are actually emitted to your log event strea" [core] - 10https://gerrit.wikimedia.org/r/112699 (owner: 10BryanDavis) [22:41:29] <grrrit-wm> (03PS14) 10Jdlrobson: Give Vector/Winter Minerva's hamburger menu icon [extensions/VectorBeta] - 10https://gerrit.wikimedia.org/r/117927 [22:41:51] <grrrit-wm> (03PS15) 10Jdlrobson: Give Vector/Winter Minerva's hamburger menu icon [extensions/VectorBeta] - 10https://gerrit.wikimedia.org/r/117927 [22:42:43] <grrrit-wm> (03CR) 10Jforrester: [C: 032] "Good enough for me. :-)" [extensions/BetaFeatures] - 10https://gerrit.wikimedia.org/r/118963 (owner: 10Legoktm) [22:42:51] <grrrit-wm> (03Merged) 10jenkins-bot: Don't require hook subscribers to know language direction [extensions/BetaFeatures] - 10https://gerrit.wikimedia.org/r/118963 (owner: 10Legoktm) [22:52:29] <grrrit-wm> (03PS1) 10Amire80: Added an RTL beta feature icon [extensions/Popups] - 10https://gerrit.wikimedia.org/r/120155 [22:54:24] <grrrit-wm> (03PS4) 10Adi.iiita: Fixed padlock on thread history for LiquidThreads extension [extensions/LiquidThreads] - 10https://gerrit.wikimedia.org/r/118212 [22:56:05] <grrrit-wm> (03PS5) 10Krinkle: Import CologneBlue skin from MediaWiki core [skins/CologneBlue] - 10https://gerrit.wikimedia.org/r/119884 (owner: 10Jdlrobson) [22:57:36] <jackmcbarn> anomie|away: do you know why "Too many calls to mw.language:formatDate()" is a thing? isn't execution time a good enough limit? (i'm running into this limit) [22:58:10] <anomie|away> jackmcbarn: Probably. It's a limit to match the limit in ParserFunction's date formatting function. [22:58:11] <grrrit-wm> (03CR) 10Jdlrobson: "Bartosz, I am prepared for turbulence but I see this as a good thing that will give us a much needed kick up the arse to make our skins ni" [core] - 10https://gerrit.wikimedia.org/r/118345 (owner: 10Jdlrobson) [22:59:14] <jdlrobson> kaldari: where you at? [23:00:08] <Krinkle> jdlrobson: The main problem is the different ways to go about it. Either as a proper extension (register in Name.php, include in LocalSettings, put in extensions/), or this weird fucked up pattern of putting it in skins/ and have classes magically self-register some of the time, and basically kil yourself in debugging and hate the world. [23:00:14] <Krinkle> I'm obviously neutral here. [23:00:18] <Krinkle> Very. [23:00:56] <jackmcbarn> anomie|away: could i do away with it? [23:01:04] <anomie|away> jackmcbarn: Go for it. [23:01:08] <jackmcbarn> kk [23:01:09] <Krinkle> I think the latter pattern is not very explored, documented nor developed. Extensions work, we use them all the time, treating skins special seems silly to me. We don't have different patterns for extensions providing special pages, apis or parser hooks either. [23:01:45] <Krinkle> wordpress gives themes their own infrastructure, but they separate it entirely, not half-ass like we do. Our skins detection system is not made to be extended, it's for core skins as far as I'm concerned. [23:01:59] <Krinkle> especially with regards to i18n and module registration. [23:02:05] <Krinkle> MatmaRex: [23:02:23] <James_F> Krinkle: This is going to be the prompt for us to fix it, isn't it/ [23:03:06] <Krinkle> James_F: Well, this is the perfect time, because unlike every other time, this time its skins we care about. [23:03:40] <Krinkle> Which means we have to not just tell people to do whatever work (which lead to people figuring out you can put new directories in skins/ and they work! nice isn't it, until ti doesn't work..) [23:03:59] <grrrit-wm> (03PS1) 10Jackmcbarn: Remove limits on mw.language:formatDate() [extensions/Scribunto] - 10https://gerrit.wikimedia.org/r/120156 [23:04:17] <MatmaRex> Krinkle: what i was suggesting was not autodiscovery [23:04:38] <Krinkle> I know, but why put anything in skins/ at all if they work exactly like extensions? If that's literally the only difference. [23:04:49] <MatmaRex> Krinkle: i'm not sure if we want skins to be extensions, eh [23:04:50] <Krinkle> For one, resources don't work because extPath is from extensions assets path [23:05:00] <MatmaRex> why do we even have the skins/ folder instead of includes/skins/, then? :/ [23:05:17] <James_F> MatmaRex: Indeed. [23:05:17] <grrrit-wm> (03PS2) 10Amire80: Added an RTL beta feature icon [extensions/Popups] - 10https://gerrit.wikimedia.org/r/120155 [23:05:18] <Krinkle> I say screw the subset of things we currently do differnet and just straighten it out [23:05:20] <Krinkle> exactly. [23:05:33] <grrrit-wm> (03PS14) 10Bsitu: Drop table: flow_header_revision [extensions/Flow] - 10https://gerrit.wikimedia.org/r/117115 [23:05:43] <Krinkle> MatmaRex: I know Nostalgia was done "right", people install it, nobody has a problem with it, its installed on wmf even, it "just works" [23:05:49] <grrrit-wm> (03CR) 10jenkins-bot: [V: 04-1] Drop table: flow_header_revision [extensions/Flow] - 10https://gerrit.wikimedia.org/r/117115 (owner: 10Bsitu) [23:05:50] <Krinkle> I'd recommend we do all skin extensions that way [23:06:57] <grrrit-wm> (03PS15) 10Bsitu: Drop table: flow_header_revision [extensions/Flow] - 10https://gerrit.wikimedia.org/r/117115 [23:07:09] <grrrit-wm> (03CR) 10jenkins-bot: [V: 04-1] Drop table: flow_header_revision [extensions/Flow] - 10https://gerrit.wikimedia.org/r/117115 (owner: 10Bsitu) [23:07:12] <grrrit-wm> (03CR) 10TTO: "Thanks for taking this up, Kaldari." [core] - 10https://gerrit.wikimedia.org/r/84303 (owner: 10TTO) [23:07:25] <Isarra> Krinkle: Skins are user-installed and often user-made. They need to be in a top-level directory so the user can get to them. [23:07:35] <Isarra> MatmaRex: ^ [23:07:40] <grrrit-wm> (03CR) 10TTO: "Also you need to remove the "mark local" entries from the commit message. They are no longer relevant." [core] - 10https://gerrit.wikimedia.org/r/84303 (owner: 10TTO) [23:07:52] <MatmaRex> Krinkle: we might actually want to make skins behave differently than extensions in the future, though [23:08:04] <Krinkle> Isarra: To clafiry, moving to includes/ would move core skins, extensions go in extensions/ [23:08:14] <Krinkle> skins are extensions in that model [23:08:30] <Krinkle> them being user made is irrelevant there, so is any other extension [23:08:32] <Isarra> Aye, they are extensions. But why do you want to keep core skins around at all? [23:08:33] <Krinkle> extensions/ is top level [23:08:34] <MatmaRex> jon was talking about support for choosing skins in the installer, that would probably require making them previewable without database, and idon't think that works now, for example [23:08:36] <Isarra> How does that help ANYTHING? [23:08:43] <MatmaRex> oh, ugh [23:08:47] <MatmaRex> no, let's kill core skins, please [23:08:48] <Krinkle> Isarra: Well, we need to have 1 core skin at least, that could go in includes/ [23:08:58] <grrrit-wm> (03CR) 10CSteipp: "Tested, and this works fine. I'll hold off merging in case anyone has a reason we should still support these browsers. Otherwise I'll merg" [core] - 10https://gerrit.wikimedia.org/r/119919 (owner: 10PleaseStand) [23:08:58] <MatmaRex> especially if we want to put non-core skins in extensions/ [23:09:10] <MatmaRex> Krinkle: we'd just need a simple fallback [23:09:24] <MatmaRex> like, the default SkinTemplate nagivation, body text, and a big fat warning [23:09:33] <MatmaRex> navigation* [23:09:34] <Isarra> But putting all skins in extensions just makes a bigger mess. Skins are a very distinct subset of extensions, and it makes sense to keep them separate from extensions because unlike extensions, you only use one skin at a time. You need to know what all is there. [23:09:38] <Isarra> It's a different model. [23:09:40] <grrrit-wm> (03CR) 10Aaron Schulz: [C: 032] Remove completely useless implementation of getInfo() [core] - 10https://gerrit.wikimedia.org/r/119505 (owner: 10Chad) [23:10:01] <Isarra> Do what MatmaRex said. [23:10:22] <grrrit-wm> (03PS16) 10Bsitu: Drop table: flow_header_revision [extensions/Flow] - 10https://gerrit.wikimedia.org/r/117115 [23:10:23] <Krinkle> Isarra: Not true, you don't use one skin at a time. [23:10:30] <Isarra> The fallback should not be the default, however. That just promotes getting stuck with the default being the only option for everyone. [23:10:45] <Isarra> What, so the top half of the page is one skin and the bottom is another? [23:10:54] <Krinkle> And they're not significantly different either. They register and integrate in mediawiki framework like any other type of extension. You're over special-casing skins. [23:11:05] <Krinkle> Isarra: No, you call one on one page, obviously [23:11:08] <Isarra> You can have different skins installed, and use different skins for different pages, even, but only one skin is ever called at once. [23:11:11] <Krinkle> But you don't use two special pages at the same time ither [23:11:13] <Krinkle> either* [23:11:24] <Krinkle> (not accounting for includable pages that is) [23:11:43] <Krinkle> Skins don't globally take over the run time, registering more than one is fine [23:11:48] <Krinkle> and in fact we do that [23:12:10] <grrrit-wm> (03CR) 10Chad: [C: 032] Avoid showing crazy staleness times at ActiveUsers [core] - 10https://gerrit.wikimedia.org/r/115522 (owner: 10Aaron Schulz) [23:12:11] <Isarra> Okay. [23:12:18] <Isarra> Doesn't mean skins should be with extensions. [23:12:49] <Isarra> Think in terms of numbers - we have what, dozens, perhaps hundreds of extensions that all do things to extend functionality of the software. [23:13:27] <Isarra> Add another few dozen skins to the pile - skins which don't extend the functionality of the software at all, but instead provide an interface. [23:13:44] <grrrit-wm> (03Merged) 10jenkins-bot: Remove completely useless implementation of getInfo() [core] - 10https://gerrit.wikimedia.org/r/119505 (owner: 10Chad) [23:13:54] <Isarra> They're technically implemented the same way, but they don't do the same thing. Putting them together is messy and doesn't make sense. [23:14:20] <Isarra> When searching for a skin, you're searching for a style. That should all be together. [23:14:56] <Isarra> That shouldn't be mixed in with dozens of other things that do dozens of other things. [23:15:30] <grrrit-wm> (03Merged) 10jenkins-bot: Avoid showing crazy staleness times at ActiveUsers [core] - 10https://gerrit.wikimedia.org/r/115522 (owner: 10Aaron Schulz) [23:16:36] <bawolff> Logically, I like the idea of all third party code being in the same place (ie extensions directory) [23:17:59] <Isarra> It's a pain in the arse, though, having to go through weird subsubsubdirectories to configure a thing. [23:18:55] <grrrit-wm> (03PS3) 10Chad: Swap wfProfileIn/Out calls for ProfileSection [core] - 10https://gerrit.wikimedia.org/r/120032 [23:18:57] <grrrit-wm> (03CR) 10jenkins-bot: [V: 04-1] Swap wfProfileIn/Out calls for ProfileSection [core] - 10https://gerrit.wikimedia.org/r/120032 (owner: 10Chad) [23:19:15] <Isarra> Users don't really think of themes as 'code', either. [23:19:29] <Isarra> That's what skins are - what everyone else calls themes. [23:19:51] <grrrit-wm> (03CR) 10Chad: "recheck" [core] - 10https://gerrit.wikimedia.org/r/120032 (owner: 10Chad) [23:20:25] <James_F> Isarra: No, skins are frameworks for themes. [23:20:42] <James_F> Isarra: We could have a sane theming system inside a skin. [23:20:43] <grrrit-wm> (03CR) 10MarkAHershberger: [C: 04-2] "Do not merge till 1.23 is cut. We need to announce at 1.23 that the skin will be removed for 1.24. No announcement was made when we rele" [core] - 10https://gerrit.wikimedia.org/r/118345 (owner: 10Jdlrobson) [23:20:53] <bawolff> Well we could, but we don't ;) [23:21:06] <James_F> Isarra: But MW expects skins to do half the work that it should do itself, so… [23:22:06] <grrrit-wm> (03CR) 10Jforrester: "Please don't just throw -2s around. This is not (necessarily) a breaking change, and you have yet to explain why you think the rules for b" [core] - 10https://gerrit.wikimedia.org/r/118345 (owner: 10Jdlrobson) [23:22:56] <bawolff> Oh sad, we're actually getting rid of those skins? I liked CologneBlue [23:23:12] <Isarra> James_F: Aye, someone would need to establish the framework for the theming system. ashley'll work on that. [23:23:18] <James_F> bawolff: No, we're just moving them to their own repo where they can be looked after properly. [23:23:32] <Isarra> Doesn't change that 'theme' is still what everyone else calls what we call skins. [23:23:32] <James_F> bawolff: Right now we're not even talking about removing them from the tarball. [23:24:09] <James_F> Isarra: I think ashley's suggestion is great, and at that point we can abandon all other skins, select just one, and let people theme that one skin instead. [23:24:16] <Isarra> And how is mw not doing the work? The skin calls the core libraries and tells it what order to do things in... [23:24:29] <bawolff> James_F: Well provided that's not used as an excuse for "not in core, hence we can utterly break it without caring", it seems to be a rather superficial change [23:24:30] <grrrit-wm> (03PS18) 10Bsitu: Add summary revision type [extensions/Flow] - 10https://gerrit.wikimedia.org/r/117357 [23:24:33] <Isarra> Or it would if someone would actually add the functionality in. [23:24:35] <^d> AaronSchulz: Super easy one... https://gerrit.wikimedia.org/r/#/c/120032/ [23:24:42] <Isarra> Except currently whenever anyone tries they just get blocked. [23:24:53] <Isarra> James_F: Eh? [23:24:55] <James_F> bawolff: It is, hence my irritation at use of the -2 hammer. :-( [23:25:22] <Isarra> How in the nine hells did you get from theming support to dropping all skins? [23:26:21] <grrrit-wm> (03CR) 10Aaron Schulz: [C: 032] Swap wfProfileIn/Out calls for ProfileSection [core] - 10https://gerrit.wikimedia.org/r/120032 (owner: 10Chad) [23:26:24] <ori> Isarra: http://math.arizona.edu/~lega/583/Fall98/lectnotes/cv4_1.gif [23:26:57] * AaronSchulz hands ori https://gerrit.wikimedia.org/r/#/c/118800/ [23:27:02] <Isarra> Wikia's Oasis supports theming. It's still one skin. [23:27:14] <Isarra> Nimbus has theming too. [23:27:27] <Isarra> ori: Explain. [23:27:39] <ori> Aaron Ternary Schulz [23:27:54] <ori> Aaron ? Ternary : Schulz. [23:28:08] <ori> AaronSchulz: looks fine; have you tested it? Should I test it? [23:29:59] * AaronSchulz can't remember [23:30:01] * AaronSchulz starts tests [23:30:09] <grrrit-wm> (03Merged) 10jenkins-bot: Swap wfProfileIn/Out calls for ProfileSection [core] - 10https://gerrit.wikimedia.org/r/120032 (owner: 10Chad) [23:31:31] * AaronSchulz runs 2 VMs at once [23:33:13] <grrrit-wm> (03PS1) 10Foxtrott: add branch alias for dev-master to composer.json [extensions/Lingo] - 10https://gerrit.wikimedia.org/r/120158 [23:33:45] <AaronSchulz> ori: heh, I probably should have had merge() use NULL as "do nothing" instead of false, but meh, too late [23:34:00] <grrrit-wm> (03PS2) 10Foxtrott: add branch alias for dev-master to composer.json [extensions/Lingo] - 10https://gerrit.wikimedia.org/r/120158 [23:34:15] <AaronSchulz> storing "false" would broken anyway, so I guess it makes sense [23:34:34] <AaronSchulz> where as NULL might actually work on GET...so I guess that made sense [23:34:57] * AaronSchulz finds the HHVM counterpart to smart_str [23:35:19] <grrrit-wm> (03CR) 10Foxtrott: [C: 032 V: 032] add branch alias for dev-master to composer.json [extensions/Lingo] - 10https://gerrit.wikimedia.org/r/120158 (owner: 10Foxtrott) [23:36:02] <grrrit-wm> (03PS3) 10Hoo man: Optionally place a local block when globally blocking [extensions/GlobalBlocking] - 10https://gerrit.wikimedia.org/r/119915 [23:36:09] <grrrit-wm> (03CR) 10Hoo man: Optionally place a local block when globally blocking (032 comments) [extensions/GlobalBlocking] - 10https://gerrit.wikimedia.org/r/119915 (owner: 10Hoo man) [23:36:43] <grrrit-wm> (03CR) 10Hoo man: "Addressed Siebrand's comments" [extensions/GlobalBlocking] - 10https://gerrit.wikimedia.org/r/119915 (owner: 10Hoo man) [23:39:24] <grrrit-wm> (03CR) 10Hoo man: "Another week went by, yet nothing happened... this still needs a rebase" [core] - 10https://gerrit.wikimedia.org/r/106517 (owner: 10Daniel Kinzler) [23:43:29] <AaronSchulz> ori: I get 'HTTP GET of URL has right contents (SwiftFileBackend).' though I also get that on master :/ [23:43:51] <AaronSchulz> not related, though I wonder what's up with that [23:45:01] <grrrit-wm> (03PS3) 10Ori.livneh: Tweaked "latest" handling of filebackend stat entries [core] - 10https://gerrit.wikimedia.org/r/118800 (owner: 10Aaron Schulz) [23:48:40] <grrrit-wm> (03PS1) 10MaxSem: hhvm: log stack traces [vagrant] - 10https://gerrit.wikimedia.org/r/120162 [23:48:58] <AaronSchulz> ori: http://hhvm.com/blog/431/on-garbage-collection [23:49:09] <AaronSchulz> I wonder if the cycle collector was ever turned on in hhvm [23:49:44] <AaronSchulz> we have some offending code ourselves...I guess the use of maxjobs will probably save runners from OOMing...unless there are lots of huge objects [23:50:02] <AaronSchulz> could probably use some investigation [23:54:13] <grrrit-wm> (03CR) 10Ori.livneh: [C: 032] hhvm: log stack traces [vagrant] - 10https://gerrit.wikimedia.org/r/120162 (owner: 10MaxSem) [23:54:17] <grrrit-wm> (03Merged) 10jenkins-bot: hhvm: log stack traces [vagrant] - 10https://gerrit.wikimedia.org/r/120162 (owner: 10MaxSem) [23:58:48] <grrrit-wm> (03CR) 10Prtksxna: "Thanks for the patch! I'll review and merge it today." [extensions/Popups] - 10https://gerrit.wikimedia.org/r/120155 (owner: 10Amire80)