[00:00:35] (03CR) 10jenkins-bot: [V: 04-1] WIP: Refactor and add non-linear tours [extensions/GuidedTour] - 10https://gerrit.wikimedia.org/r/116228 (owner: 10Mattflaschen) [00:34:29] Is anyone on that can help me with editing some java? [00:35:47] Aurora_Grimes: Hello! When you're on IRC it's usually good practice to jump right in and ask a question, as it saves time for everyone involved :) how can we help you? [00:36:12] rdwrer [20:32:59] Okay in JS, if I wanted to check for a user group in the following code, instead of what page it is on, what would I need to change? [00:36:13] [20:33:01] if ( wgCanonicalNamespace == 'Project' && wgTitle == 'Sandbox' ) { [00:36:20] JS is not Java. [00:36:26] oh? [00:36:30] Not even close [00:36:33] !wp Java [00:36:33] https://en.wikipedia.org/?title=Java [00:36:37] !wp JavaScript [00:36:37] https://en.wikipedia.org/?title=JavaScript [00:36:51] Yeah. The names are confusing. Not your fault Aurora_Grimes [00:37:19] Aurora_Grimes: What do you mean by "user group" - what user authoured the page? [00:38:28] It's not so much for an authoring doohicky. I have some Javascript I pulled to add to the p-actions tab different things, I want to define when they show by doing a check and it only shows each option if a member is part of a custom usergroup (defined in localsettings) [00:38:43] Aha. [00:38:52] Aurora_Grimes: If the member, meaning the current user, is a member? [00:39:12] rdwrer, if the user viewing the page is a member of the usergroup. [00:39:34] Basically [00:39:39] * rdwrer looks [00:40:00] Aurora_Grimes: https://doc.wikimedia.org/mediawiki-core/master/js/#!/api/mw.user-method-getGroups [00:40:09] So something like [00:40:17] (and this will be asynchronous) [00:40:40] asynchronous? [00:40:58] mw.user.getGroups().done( function ( groups ) { if ( groups.indexOf( 'myUserGroup' ) !== -1 ) { /* do things here */ } } ); [00:41:18] Aurora_Grimes: It makes an API request, so don't expect it to give you an answer right away [00:41:51] I'm so confused lol I know no javascript, mind if I PM you so we dont clutter up the public channel? [00:42:46] rdwrer? [00:42:51] (03CR) 10Ori.livneh: [C: 032] Fix JSHint for CodeEditor [extensions/CodeEditor] - 10https://gerrit.wikimedia.org/r/118998 (owner: 10TheDJ) [00:42:55] No, talk here [00:42:55] (03Merged) 10jenkins-bot: Fix JSHint for CodeEditor [extensions/CodeEditor] - 10https://gerrit.wikimedia.org/r/118998 (owner: 10TheDJ) [00:42:59] okay [00:43:17] Aurora_Grimes: So the /* do things here */ part is where you know the user is in the group. [00:43:25] Give me a second, I am setting up a JSFIDDLE to explain better what my current code is and what I am doing. [00:43:30] Aurora_Grimes: You'll need to replace 'myUserGroup' with your own thing [00:43:32] Ugh [00:47:57] rdwrer, here is the applicable JSFiddle with more information also http://jsfiddle.net/ZC7z9/#&togetherjs=16mGyEidr4 [00:49:03] I coded all the JS into Mediawiki:Common.JS on my wiki [00:50:34] Aurora_Grimes: There. [00:51:20] Aurora_Grimes: You can split up the checks into different if statements [00:51:23] I'm done with this [00:52:55] rdwrer: One last question, if I wanted the third one to check for one or the other (But not make it mandatory to both, what do I change the && you put in for? [00:53:47] ||. [00:53:59] So ( condition1 || condition2 ) [00:54:35] ah so like this? mw.user.getGroups().done( function ( groups ) { if ( groups.indexOf( 'Asrallka' ) !== -1 || groups.indexOf( 'Cabinet' ) !== -1 ) { [00:55:55] ? [00:56:03] Yup [00:56:16] You should put all the if statements in the same callback though [00:56:31] Ideally there will be no performance difference but I'm not sure I trust Krinkle|detached to do that right :) [00:56:58] lol [00:57:00] :) [00:57:18] What do you mean by all the if statements in the same callback? [00:57:22] So [00:57:30] Aurora_Grimes: In JavaScript, there are anonymous functions [00:57:38] We're creating one with function ( groups ) { ... } [00:57:53] It gets passed as a callback to the promise that's returned from getGroups() [00:58:06] A *promise* is an object that fires events based on other events [00:58:13] (03PS7) 10Prtksxna: Make EventLogging a soft dependency [extensions/Popups] - 10https://gerrit.wikimedia.org/r/115878 [00:58:21] So our promise is one that ties together the "we have the groups now" with the callback. [00:58:41] A *callback* just means "a function that is called when something else happens" [00:59:06] So you should only make a .done( function ( groups ) { ... } ); call once [00:59:14] You shouldn't be defining it multiple times [00:59:30] (03Abandoned) 10Spage: Fix error page titles [extensions/Flow] - 10https://gerrit.wikimedia.org/r/116631 (owner: 10Spage) [00:59:33] That way, no matter what, all of your menu items will get added at the same time [01:00:02] How would I do that with my code then? (LIke I said, I'm new and much more a see it and learn type of person, explanations only help so far :/) [01:00:46] Aurora_Grimes: You know how if statements work, right? [01:01:15] Not really? I only really know the basics of CSS and HTML, this is my first foray into JS [01:01:54] Aurora_Grimes: http://etherpad.wikimedia.org/p/F2gsk6WTo1 [01:05:11] rdwrer: so what I just edited into that link you just gave me be better is what your saying? [01:05:48] Yup! [01:06:02] okay, thanks for all the help, it truly is appreciated :) [01:06:02] Aurora_Grimes: You may want/need to abstract some of that code, as it looks very similar [01:06:05] But I won't be too picky [01:06:08] Yup, cheers [01:06:11] I'm off now :) [01:06:16] Okay :) [01:08:41] (03Abandoned) 10Prtksxna: WIP: Rename popups to hovercards [extensions/Popups] - 10https://gerrit.wikimedia.org/r/119239 (owner: 10Prtksxna) [01:09:43] (03PS1) 10Prtksxna: Renaming Popups to Hovercards in the i18n file [extensions/Popups] - 10https://gerrit.wikimedia.org/r/119429 [01:15:36] For some reason it's not working hmmmn.... testing :p [01:24:34] (03CR) 10Legoktm: [C: 04-1] "In general, you should only touch the 'en' and 'qqq' messages, and leave the rest for TWN." (031 comment) [extensions/Popups] - 10https://gerrit.wikimedia.org/r/119429 (owner: 10Prtksxna) [01:26:08] (03CR) 10Deskana: [C: 04-1] "See in-line comments. Extension name proper should still be "Popups"." (031 comment) [extensions/Popups] - 10https://gerrit.wikimedia.org/r/119429 (owner: 10Prtksxna) [01:26:42] (03PS2) 10Prtksxna: Renaming Popups to Hovercards in the i18n file [extensions/Popups] - 10https://gerrit.wikimedia.org/r/119429 [01:32:11] (03PS3) 10Prtksxna: Renaming Popups to Hovercards in the i18n file [extensions/Popups] - 10https://gerrit.wikimedia.org/r/119429 [01:34:11] (03CR) 10Deskana: [C: 031] "This looks right to me. The extension name proper will continue to be Popups due to the difficulty of renaming the git repository, but the" [extensions/Popups] - 10https://gerrit.wikimedia.org/r/119429 (owner: 10Prtksxna) [01:35:07] (03CR) 10Prtksxna: Renaming Popups to Hovercards in the i18n file (031 comment) [extensions/Popups] - 10https://gerrit.wikimedia.org/r/119429 (owner: 10Prtksxna) [01:46:43] (03PS4) 10Prtksxna: Renaming Popups to Hovercards in the i18n file [extensions/Popups] - 10https://gerrit.wikimedia.org/r/119429 [01:47:34] (03CR) 10Legoktm: [C: 031] Renaming Popups to Hovercards in the i18n file [extensions/Popups] - 10https://gerrit.wikimedia.org/r/119429 (owner: 10Prtksxna) [02:03:30] (03CR) 10Deskana: [C: 031] "Per previous rationale." [extensions/Popups] - 10https://gerrit.wikimedia.org/r/119429 (owner: 10Prtksxna) [02:07:09] (03CR) 10Aaron Schulz: [C: 032] Allow login with passwords not meeting complexity requirements [core] - 10https://gerrit.wikimedia.org/r/117635 (owner: 10CSteipp) [02:11:41] (03Merged) 10jenkins-bot: Allow login with passwords not meeting complexity requirements [core] - 10https://gerrit.wikimedia.org/r/117635 (owner: 10CSteipp) [02:14:07] ori: I guess I'm done futzing with 118955 now [02:15:06] Aurora_Grimes: Hi [02:19:20] Hi Krinkle :) [02:20:30] legoktm: Ping if you're around. [02:20:40] James_F: -ish [02:20:44] what's up? [02:21:11] legoktm: Beta Features has a feature (ho ho) to go "Hey, OMG, look at this 'beta' link in your personal toolbar!one11wow!", right? [02:21:19] yes [02:21:22] legoktm: A one-off JS pop-out notice [02:21:28] legoktm: Did we ever deploy it? [02:21:42] technically it's deployed but there's some bug that's preventing it from going off [02:21:50] Right. [02:22:31] Maybe we should fix that bug at some point to get more eyes on the Beta Features. [02:22:34] Thanks. :-) [02:23:49] Yeah [02:23:52] It was working for me locally [02:23:56] ...some of the time. [02:23:59] Hmm. [02:24:44] I'll look at it tomorrow [02:24:51] Thanks! [02:25:32] James_F: http://fyre.it/ZcTaxI.4 is making me chuckle [02:27:32] AaronSchulz: Ha. The attitude in the comments makes me sad. [02:28:48] AaronSchulz: Unsurprised, but sad. [02:30:51] never saw that level of vitriol before [02:49:35] er James_F, https://bugzilla.wikimedia.org/show_bug.cgi?id=60748 hasn't been merged yet... [02:50:42] legoktm: But… it's now working for me. [02:50:48] legoktm: Now I'm confused. [02:51:04] :| [02:51:47] legoktm: Have you got the auto-enroll switched on on Beta Labs? Have you now got Hovercards working for you there? 'Cos I have and did without opting in… [02:52:10] legoktm: I thought I'd merged that week ago, but apparently my +2 didn't go through. [02:52:54] I usually don't use beta labs. Last time I tested it was...whenever I wrote that patch, but I don't think anyone else has touched the extension in the meantime. [02:53:20] Beta Labs has a new BF which you won't have opted-into, then? [02:54:17] i've got an old extension in a new git repository, and i want to overhaul the extension for the newer versions [02:54:37] how do i create a branch in the repo so that the old version can still be maintained? [02:54:44] something like REL1_21 [02:55:50] Prodi: git checkout -b REL1_21 hashoflastcommitstillinREL1_21 ; git push origin REL1_21 [02:56:13] cool, thanks! [03:03:07] (03PS10) 10Aaron Schulz: Added a Redis pool counter class [core] - 10https://gerrit.wikimedia.org/r/118955 [03:03:40] ori: heh, I lied, one more small change [03:33:09] So I have code I want to put in CSS, like #p-uniqueid, #p-otheruniqueid { display: none; } to hide two tabs to all users, so I put it in Mediawiki:Common.css [03:33:54] What CSS would I use to override that for only select Mediawiki:Group-sysops.css? [03:34:23] or on other group css pages. [03:37:20] Aurora_Grimes: The opposite of display none is display block (in case of block level elements, like

,

or
  • ) or display inline (in case of inline elements, like , or ) [03:37:59] okay, thanks Krinkle :) [04:46:36] AaronSchulz: that may take me a bit to review [05:31:54] (03PS1) 10Hiong3-eng5: MW WLD prefix compatibility fix [extensions/WikiLexicalData] - 10https://gerrit.wikimedia.org/r/119446 [05:36:33] (03CR) 10Krinkle: "@Ori: Can we get stats on usage of these deprecated properties? They are tracked now with mw.track. This would be a good first case to see" [core] - 10https://gerrit.wikimedia.org/r/118733 (owner: 10Bartosz Dziewoński) [05:37:49] (03CR) 10Krinkle: mediawiki.api: Documentation and typo cleanup (031 comment) [core] - 10https://gerrit.wikimedia.org/r/118731 (owner: 10Bartosz Dziewoński) [05:39:11] (03CR) 10Krinkle: mediawiki.api.category: getCategories: Deprecate the 'async' parameter (031 comment) [core] - 10https://gerrit.wikimedia.org/r/118732 (owner: 10Bartosz Dziewoński) [05:46:57] (03CR) 10Krinkle: jquery.byteLimit: Restore caret position after limiting (031 comment) [core] - 10https://gerrit.wikimedia.org/r/114959 (owner: 10Bartosz Dziewoński) [05:48:07] (03PS3) 10AndyRussG: WIP Query API modules for campaigns and participants [extensions/Campaigns] (wip/editorcampaigns) - 10https://gerrit.wikimedia.org/r/117380 [05:48:41] (03CR) 10AndyRussG: "Rebased" [extensions/Campaigns] (wip/editorcampaigns) - 10https://gerrit.wikimedia.org/r/117380 (owner: 10AndyRussG) [05:54:27] (03CR) 10Krinkle: [C: 04-1] jquery.byteLimit: Restore caret position after limiting (031 comment) [core] - 10https://gerrit.wikimedia.org/r/114959 (owner: 10Bartosz Dziewoński) [06:00:27] (03PS2) 10Krinkle: Make DonationInterface tests voting; Remove "runtests" target [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/118727 (owner: 10Adamw) [06:02:49] (03CR) 10Krinkle: [C: 04-1] "These don't look like less files. Why do they have a less suffix? The upstream repo (both release distro and git working copy) are plain c" [core] - 10https://gerrit.wikimedia.org/r/110908 (owner: 10Isarra) [06:12:13] (03CR) 10Krinkle: "So shall we pick one of those then? Or are they inferior? Only the first and fourth escape hyphens it seems? Though I'm for deprecating jq" [core] - 10https://gerrit.wikimedia.org/r/97856 (owner: 10Ori.livneh) [06:15:13] (03CR) 10Krinkle: Cache VCS commit id/date text on Special:Version (031 comment) [core] - 10https://gerrit.wikimedia.org/r/95878 (owner: 10Alex Monk) [06:16:18] (03Abandoned) 10Krinkle: set -e for MMV doc tests [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/111136 (owner: 10MarkTraceur) [06:21:03] (03Abandoned) 10Krinkle: Fire hook "LivePreviewPrepare" [core] - 10https://gerrit.wikimedia.org/r/110347 (owner: 10Helder.wiki) [06:22:10] (03CR) 10Ori.livneh: "In my dreams we replace our motley crew of JavaScript odds and ends with a solid, comprehensive library like YUI or Closure, but since we " [core] - 10https://gerrit.wikimedia.org/r/97856 (owner: 10Ori.livneh) [06:23:23] (03CR) 10Ori.livneh: "@Krinkle: Yep. I'll write something up." [core] - 10https://gerrit.wikimedia.org/r/118733 (owner: 10Bartosz Dziewoński) [06:24:25] (03CR) 10Krinkle: [C: 04-1] Add new jquery.scroll.js plugin (031 comment) [core] - 10https://gerrit.wikimedia.org/r/96949 (owner: 10Werdna) [06:25:39] (03PS3) 10Krinkle: Use checkboxShiftClick for "Copy Metadata" checkboxes [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/84003 (owner: 10Rillke) [06:25:56] (03CR) 10Krinkle: "Rebased, ping UploadWizard maintainers." [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/84003 (owner: 10Rillke) [06:27:21] (03CR) 10Krinkle: "Is this redundant now that we have mw.track for these." [core] - 10https://gerrit.wikimedia.org/r/92667 (owner: 10Ori.livneh) [06:27:29] (03CR) 10Raimond Spekking: [C: 031] Renaming Popups to Hovercards in the i18n file [extensions/Popups] - 10https://gerrit.wikimedia.org/r/119429 (owner: 10Prtksxna) [06:27:51] (03Abandoned) 10Ori.livneh: mw.log.deprecate: fire mediaWiki.deprecated hook on deprecated property access [core] - 10https://gerrit.wikimedia.org/r/92667 (owner: 10Ori.livneh) [06:28:17] (03Abandoned) 10Krinkle: JavaScript sprintfDate() implementation [core] - 10https://gerrit.wikimedia.org/r/67166 (owner: 10Wizardist) [06:31:34] (03PS7) 10Mattflaschen: WIP: Refactor and add non-linear tours [extensions/GuidedTour] - 10https://gerrit.wikimedia.org/r/116228 [06:32:04] (03CR) 10jenkins-bot: [V: 04-1] WIP: Refactor and add non-linear tours [extensions/GuidedTour] - 10https://gerrit.wikimedia.org/r/116228 (owner: 10Mattflaschen) [06:34:49] (03PS8) 10Mattflaschen: WIP: Refactor and add non-linear tours [extensions/GuidedTour] - 10https://gerrit.wikimedia.org/r/116228 [06:35:18] (03CR) 10jenkins-bot: [V: 04-1] WIP: Refactor and add non-linear tours [extensions/GuidedTour] - 10https://gerrit.wikimedia.org/r/116228 (owner: 10Mattflaschen) [06:41:23] (03CR) 10Ori.livneh: [C: 031] "Code looks good; haven't tested yet. One comment in-line." (031 comment) [core] - 10https://gerrit.wikimedia.org/r/95463 (owner: 10Krinkle) [06:43:36] (03CR) 10Krinkle: resourceloader: Refactor module links output (031 comment) [core] - 10https://gerrit.wikimedia.org/r/95463 (owner: 10Krinkle) [06:46:44] Krinkle: I don't follow [06:47:19] calls itself [06:47:58] oh, I hadn't noticed [06:49:02] yes, just leave it in then, i was wrong to suggest that [06:49:13] (03CR) 10Mattflaschen: "Patch set 8 gets the first step working (at least for the 'test' tour), fixes the doc test 100%, and fixes jshint (except two places I hav" [extensions/GuidedTour] - 10https://gerrit.wikimedia.org/r/116228 (owner: 10Mattflaschen) [06:49:28] it's a long and terrifying method [06:55:13] Yep [07:10:42] (03CR) 10Yuvipanda: [C: 032 V: 032] "Much +1s" [extensions/Popups] - 10https://gerrit.wikimedia.org/r/119429 (owner: 10Prtksxna) [07:14:53] prtksxna: ^ merged [07:15:02] zz_yuvipanda: Thanks :) [07:19:23] (03PS2) 10TheDJ: CodeEditor: Add a status bar with line and columncount [extensions/CodeEditor] - 10https://gerrit.wikimedia.org/r/118989 [07:20:40] (03PS5) 10TheDJ: CodeEditor: Add basic code completion and snippet support [extensions/CodeEditor] - 10https://gerrit.wikimedia.org/r/106693 [07:50:58] (03PS1) 10Spage: Add Popups (Hovercards) extension [tools/release] - 10https://gerrit.wikimedia.org/r/119447 [08:35:53] (03CR) 10Hiong3-eng5: "This has been tested with a mySQL database:" [extensions/WikiLexicalData] - 10https://gerrit.wikimedia.org/r/119446 (owner: 10Hiong3-eng5) [09:08:16] (03PS1) 10Spage: Add Popups extension [core] (wmf/1.23wmf18) - 10https://gerrit.wikimedia.org/r/119450 [09:17:34] (03PS1) 10Spage: Add Popups extension [core] (wmf/1.23wmf17) - 10https://gerrit.wikimedia.org/r/119451 [09:43:18] (03CR) 10Siebrand: "Oh, I didn't know that Flow would be getting summaries. I expected the Lqt summaries to be added to the top post content somehow. Still, n" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/119243 (owner: 10Werdna) [09:49:42] (03Abandoned) 10Marco: No error anymore when uploading files with same base name [core] - 10https://gerrit.wikimedia.org/r/87020 (owner: 10Marco) [10:07:15] (03CR) 10Hashar: "That is a good start. You want to:" (032 comments) [core] - 10https://gerrit.wikimedia.org/r/119055 (owner: 10Phuedx) [10:08:38] thanks hashar [10:09:14] phuedx: the test suites are a bit of a mess :/ [10:09:51] hashar: how do you mean? [10:28:20] (03PS1) 10Thiemo Mättig (WMDE): Unify coding style of jQuery( '' ) calls [core] - 10https://gerrit.wikimedia.org/r/119460 [10:37:21] (03CR) 10Bartosz Dziewoński: [C: 032] Unify coding style of jQuery( '' ) calls [core] - 10https://gerrit.wikimedia.org/r/119460 (owner: 10Thiemo Mättig (WMDE)) [10:38:57] (03CR) 10Nikerabbit: "Heh, I noticed only one $( elem ) change compared to many other changes. The commit message hinted the opposite." [core] - 10https://gerrit.wikimedia.org/r/119460 (owner: 10Thiemo Mättig (WMDE)) [10:40:56] (03Merged) 10jenkins-bot: Unify coding style of jQuery( '' ) calls [core] - 10https://gerrit.wikimedia.org/r/119460 (owner: 10Thiemo Mättig (WMDE)) [10:44:31] (03CR) 10Bartosz Dziewoński: [C: 032] Link to existing login help page by default from helplogin-url [core] - 10https://gerrit.wikimedia.org/r/83220 (owner: 10Nemo bis) [10:48:21] (03Merged) 10jenkins-bot: Link to existing login help page by default from helplogin-url [core] - 10https://gerrit.wikimedia.org/r/83220 (owner: 10Nemo bis) [10:57:35] (03CR) 10Bartosz Dziewoński: Get rid of Internet Explorer for Mac fixes in Monobook's main.css. (031 comment) [core] - 10https://gerrit.wikimedia.org/r/119422 (owner: 10Jack Phoenix) [11:34:36] (03PS1) 10Bartosz Dziewoński: shared.css: Canonicalize and simplify background image rules [core] - 10https://gerrit.wikimedia.org/r/119463 [11:35:30] (03CR) 10Bartosz Dziewoński: [C: 04-1] "A brief comment would be helpful. See also where I just cleaned up the place in core you lifted this from. :) https://gerrit.wikimedia.org" [extensions/BetaFeatures] - 10https://gerrit.wikimedia.org/r/119034 (owner: 10Thiemo Mättig (WMDE)) [11:39:29] (03PS3) 10Bartosz Dziewoński: Remove link to edits with Oversight from Special:Contributions [extensions/Oversight] - 10https://gerrit.wikimedia.org/r/117243 (owner: 10Alex Monk) [11:39:42] (03CR) 10Bartosz Dziewoński: [C: 032 V: 032] Remove link to edits with Oversight from Special:Contributions [extensions/Oversight] - 10https://gerrit.wikimedia.org/r/117243 (owner: 10Alex Monk) [11:39:55] (03CR) 10Nikerabbit: "Why not embed PNG version?" [core] - 10https://gerrit.wikimedia.org/r/119463 (owner: 10Bartosz Dziewoński) [11:46:50] (03CR) 10Bartosz Dziewoński: "Not sure why the LESS mixing version does that, probably to save some data transfer in the most common case. I don't care much for either," [core] - 10https://gerrit.wikimedia.org/r/119463 (owner: 10Bartosz Dziewoński) [12:02:49] (03CR) 10Thiemo Mättig (WMDE): [C: 04-1] "I love the idea" (031 comment) [core] - 10https://gerrit.wikimedia.org/r/119463 (owner: 10Bartosz Dziewoński) [12:14:23] (03CR) 1001tonythomas: "Andre, Welcome." [wikimedia/bugzilla/modifications] - 10https://gerrit.wikimedia.org/r/118958 (owner: 1001tonythomas) [12:25:25] (03Abandoned) 10Hashar: Make checkPHPExtension() load the extension when it's available. [core] - 10https://gerrit.wikimedia.org/r/97329 (owner: 10Platonides) [12:26:28] (03Abandoned) 10Hashar: Install without XML support [core] - 10https://gerrit.wikimedia.org/r/76663 (owner: 10MarkAHershberger) [12:26:36] (03PS2) 10Bartosz Dziewoński: shared.css: Canonicalize and simplify background image rules [core] - 10https://gerrit.wikimedia.org/r/119463 [12:26:39] (03CR) 10Bartosz Dziewoński: shared.css: Canonicalize and simplify background image rules (031 comment) [core] - 10https://gerrit.wikimedia.org/r/119463 (owner: 10Bartosz Dziewoński) [12:27:36] (03Abandoned) 10Hashar: Removed SiteConfiguration::getAll() [core] - 10https://gerrit.wikimedia.org/r/107034 (owner: 10Tinaj1234) [12:29:16] (03CR) 10Hashar: "Removing myself as a reviewer, I am too busy with beta/contint." [core] - 10https://gerrit.wikimedia.org/r/118997 (owner: 10Aude) [12:29:56] (03PS1) 10Dan-nl: don’t concatenate item specific categories [extensions/GWToolset] - 10https://gerrit.wikimedia.org/r/119467 [12:30:43] (03Abandoned) 10Hashar: grrrit: switch default channel [labs/tools/grrrit] - 10https://gerrit.wikimedia.org/r/117839 (owner: 10AzaToth) [13:14:51] (03CR) 10Siebrand: Update i18n strings for the deadend tag The deadend tag is no longer used for 'too few links', only 'no links'. Updating the description to (031 comment) [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/119409 (owner: 10OliverKeyes) [13:27:50] I was working on replacing $.proxy with ve.bind for Visual Editor ( https://bugzilla.wikimedia.org/show_bug.cgi?id=62762 ). According to BZ comments, the trick is to change ve.bind() to a wrapper that uses native .bind() as an assignment ve.bind = $.proxy; happens in one of the extensions js file. The documentation says the assignment is a Wrapper for [13:27:50] Function#bind. But actually its a wrapper for $.proxy right ? [13:28:24] (03PS2) 10Thiemo Mättig (WMDE): Provide PNG fallbacks for non-SVG web browsers [extensions/BetaFeatures] - 10https://gerrit.wikimedia.org/r/119034 [13:29:11] (03CR) 10Thiemo Mättig (WMDE): [C: 031] shared.css: Canonicalize and simplify background image rules [core] - 10https://gerrit.wikimedia.org/r/119463 (owner: 10Bartosz Dziewoński) [13:41:58] hoo: you around ? [13:42:07] Yeah [13:42:36] As I posted earlier, I was working on this Visual Editor bug, https://bugzilla.wikimedia.org/show_bug.cgi?id=62762 [13:42:52] The point is to change ve.bind() to a wrapper that uses native .bind() [13:45:02] (03PS2) 10Dan-nl: don’t concatenate item specific categories [extensions/GWToolset] - 10https://gerrit.wikimedia.org/r/119467 [13:45:35] (03CR) 10Dan-nl: "* spelling correction" [extensions/GWToolset] - 10https://gerrit.wikimedia.org/r/119467 (owner: 10Dan-nl) [13:46:48] tonythomas: Ok [13:47:06] (03PS1) 10Jeroen De Dauw: Fix path after file got moved [core] - 10https://gerrit.wikimedia.org/r/119475 [13:47:46] (03CR) 10Hoo man: [C: 032] "I guess you know what you're doing" [core] - 10https://gerrit.wikimedia.org/r/119475 (owner: 10Jeroen De Dauw) [13:48:19] hoo: and as per https://git.wikimedia.org/blob/VisualEditor%2FVisualEditor.git/HEAD/modules%2Fve%2Fve.js#L129, we have ve.bind = $.proxy; [13:48:19] [13:48:23] (03Abandoned) 10Jeroen De Dauw: Add ComposerPackageModifierTest integration test [core] - 10https://gerrit.wikimedia.org/r/105114 (owner: 10Jeroen De Dauw) [13:48:45] hoo: and the documentation says that's a wrapper class for #bind. [13:50:27] (03PS1) 10Jeroen De Dauw: Add ComposerPackageModifierTest integration test [core] - 10https://gerrit.wikimedia.org/r/119476 [13:51:31] tonythomas: Yeah... so? [13:52:07] (03Merged) 10jenkins-bot: Fix path after file got moved [core] - 10https://gerrit.wikimedia.org/r/119475 (owner: 10Jeroen De Dauw) [13:52:44] hoo: but, actually its a wrapper class for $.proxy right ? [13:52:59] when you give ve.bind = $.proxy() ? [13:53:20] (03PS2) 10Jeroen De Dauw: Add ComposerPackageModifierTest integration test [core] - 10https://gerrit.wikimedia.org/r/119476 [13:57:16] (03CR) 10Matthias Mullie: Cache created objects within the mapper (032 comments) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/113527 (owner: 10EBernhardson) [13:57:35] (03PS4) 10Matthias Mullie: Cache created objects within the mapper [extensions/Flow] - 10https://gerrit.wikimedia.org/r/113527 (owner: 10EBernhardson) [13:57:45] (03CR) 10Matthias Mullie: [C: 032] Cache created objects within the mapper [extensions/Flow] - 10https://gerrit.wikimedia.org/r/113527 (owner: 10EBernhardson) [13:58:30] (03CR) 10jenkins-bot: [V: 04-1] Cache created objects within the mapper [extensions/Flow] - 10https://gerrit.wikimedia.org/r/113527 (owner: 10EBernhardson) [13:58:56] (03PS4) 10Matthias Mullie: fastpath getMulti/gotMulti when using CachingObjectMapper [extensions/Flow] - 10https://gerrit.wikimedia.org/r/113528 (owner: 10EBernhardson) [13:59:01] (03CR) 10Matthias Mullie: [C: 032] fastpath getMulti/gotMulti when using CachingObjectMapper [extensions/Flow] - 10https://gerrit.wikimedia.org/r/113528 (owner: 10EBernhardson) [13:59:17] (03Merged) 10jenkins-bot: Cache created objects within the mapper [extensions/Flow] - 10https://gerrit.wikimedia.org/r/113527 (owner: 10EBernhardson) [13:59:29] hoo: or is my concept of Wrapper wrong ? When the funcion $.proxy is assigned to ve.bind, we are actually wrapping $.proxy right ? [13:59:34] (03CR) 10jenkins-bot: [V: 04-1] Add ComposerPackageModifierTest integration test [core] - 10https://gerrit.wikimedia.org/r/119476 (owner: 10Jeroen De Dauw) [13:59:42] correct [14:02:28] hoo: in that case, the wrapper is ve.bind right ? [14:03:21] ve.bind is $.proxy [14:03:52] (03CR) 10Matthias Mullie: [C: 032] Only load the container on flow pages [extensions/Flow] - 10https://gerrit.wikimedia.org/r/115861 (owner: 10EBernhardson) [14:04:06] (03Merged) 10jenkins-bot: Only load the container on flow pages [extensions/Flow] - 10https://gerrit.wikimedia.org/r/115861 (owner: 10EBernhardson) [14:04:27] ok. I am still doubtful why the documentation says that in https://git.wikimedia.org/blob/VisualEditor%2FVisualEditor.git/HEAD/modules%2Fve%2Fve.js#L111 [14:07:52] (03PS5) 10Matthias Mullie: Add more info to flakey permissions test [extensions/Flow] - 10https://gerrit.wikimedia.org/r/118722 (owner: 10EBernhardson) [14:07:57] (03CR) 10Matthias Mullie: [C: 032] Add more info to flakey permissions test [extensions/Flow] - 10https://gerrit.wikimedia.org/r/118722 (owner: 10EBernhardson) [14:08:15] (03Merged) 10jenkins-bot: Add more info to flakey permissions test [extensions/Flow] - 10https://gerrit.wikimedia.org/r/118722 (owner: 10EBernhardson) [14:08:53] tonythomas: well: https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Function/bind and https://api.jquery.com/jQuery.proxy/ [14:09:02] (03CR) 10Jack Phoenix: Get rid of Internet Explorer for Mac fixes in Monobook's main.css. (031 comment) [core] - 10https://gerrit.wikimedia.org/r/119422 (owner: 10Jack Phoenix) [14:09:07] these two do very similar things, which is why they are (almost?) equivalent [14:10:18] hoo: of course. But, there is a notion to replace the whole with bind() as per the bug. [14:10:38] (03CR) 10Gilles: [C: 032] Use checkboxShiftClick for "Copy Metadata" checkboxes [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/84003 (owner: 10Rillke) [14:10:51] (03Merged) 10jenkins-bot: Use checkboxShiftClick for "Copy Metadata" checkboxes [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/84003 (owner: 10Rillke) [14:11:16] tonythomas: Which makes sense, no? [14:11:38] (03CR) 10Matthias Mullie: [C: 032] use ResultWrapper directly [extensions/Flow] - 10https://gerrit.wikimedia.org/r/119080 (owner: 10EBernhardson) [14:11:39] hoo: of corse. we cant have one pointing to another and using it in the formers name [14:11:50] (03Merged) 10jenkins-bot: use ResultWrapper directly [extensions/Flow] - 10https://gerrit.wikimedia.org/r/119080 (owner: 10EBernhardson) [14:12:05] hoo: now, the task is to change ve.bind() to a wrapper that uses native .bind() [14:12:06] Why can't we? [14:12:51] hoo: The VE team told me that they have their own reasons for switching to bind() [14:13:00] probably performance [14:13:35] (03CR) 10Jeroen De Dauw: "Hashar: why the fuck does the Jenkins thing give a -2?" [core] - 10https://gerrit.wikimedia.org/r/119476 (owner: 10Jeroen De Dauw) [14:13:38] hoo: of course. and supports latest browsers only. Its not a problem as VE is not meant for the aged browsers [14:15:14] Sure... so where's the problem? [14:15:44] (03CR) 10Matthias Mullie: [C: 032] Join ObjectStorage and WritableObjectStorage interfaces (031 comment) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/119079 (owner: 10EBernhardson) [14:15:59] (03Merged) 10jenkins-bot: Join ObjectStorage and WritableObjectStorage interfaces [extensions/Flow] - 10https://gerrit.wikimedia.org/r/119079 (owner: 10EBernhardson) [14:16:05] (03PS1) 10Matthias Mullie: Fix typo [extensions/Flow] - 10https://gerrit.wikimedia.org/r/119479 [14:16:36] (03CR) 10Matthias Mullie: [C: 032] "Meant to fix this before merging https://gerrit.wikimedia.org/r/#/c/119079/, but forgot" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/119479 (owner: 10Matthias Mullie) [14:16:52] (03Merged) 10jenkins-bot: Fix typo [extensions/Flow] - 10https://gerrit.wikimedia.org/r/119479 (owner: 10Matthias Mullie) [14:17:50] (03CR) 10Matthias Mullie: [C: 032] Remove unused PersistenceException class [extensions/Flow] - 10https://gerrit.wikimedia.org/r/119213 (owner: 10EBernhardson) [14:18:51] (03CR) 10jenkins-bot: [V: 04-1] Remove unused PersistenceException class [extensions/Flow] - 10https://gerrit.wikimedia.org/r/119213 (owner: 10EBernhardson) [14:19:04] (03PS2) 10Matthias Mullie: Remove unused PersistenceException class [extensions/Flow] - 10https://gerrit.wikimedia.org/r/119213 (owner: 10EBernhardson) [14:19:09] (03CR) 10Matthias Mullie: [C: 032] Remove unused PersistenceException class [extensions/Flow] - 10https://gerrit.wikimedia.org/r/119213 (owner: 10EBernhardson) [14:19:27] (03Merged) 10jenkins-bot: Remove unused PersistenceException class [extensions/Flow] - 10https://gerrit.wikimedia.org/r/119213 (owner: 10EBernhardson) [14:20:49] (03CR) 10Matthias Mullie: [C: 032] More fix to diff link from contribution & recentchange page [extensions/Flow] - 10https://gerrit.wikimedia.org/r/119230 (owner: 10Bsitu) [14:21:02] (03Merged) 10jenkins-bot: More fix to diff link from contribution & recentchange page [extensions/Flow] - 10https://gerrit.wikimedia.org/r/119230 (owner: 10Bsitu) [14:21:09] hoo: As per the comments. I need to change ve.bin() to a wrapper right ? Already we have ve.bind = $.proxy; I need to find a way to make ve.bind working like itself, where I seem a little stuck [14:22:50] tonythomas: Yep, that's what you need to do :) [14:23:13] (03CR) 10Hashar: "JeroenDeDauw the junit XML file is invalid :-/" [core] - 10https://gerrit.wikimedia.org/r/119476 (owner: 10Jeroen De Dauw) [14:25:16] hoo: Yeah! Atleast got some clarity. So, there needs to be a function that takes ve.bind() and returns its original properties ? [14:26:27] ve.bind = function( f, c ) { f.bind.apply( c, arguments ) } [14:26:33] something like that [14:26:51] hoo: I will try that. Thanks. time for me to go. brb [14:34:33] (03PS2) 10Phuedx: Add a LESS test suite [core] - 10https://gerrit.wikimedia.org/r/119055 [14:34:35] (03CR) 10jenkins-bot: [V: 04-1] Add a LESS test suite [core] - 10https://gerrit.wikimedia.org/r/119055 (owner: 10Phuedx) [14:35:09] (03CR) 10Dzahn: [C: 032] Remove useless [% PROCESS global/variables.none.tmpl %] [wikimedia/bugzilla/modifications] - 10https://gerrit.wikimedia.org/r/118958 (owner: 1001tonythomas) [14:35:21] (03CR) 10Dzahn: [V: 032] Remove useless [% PROCESS global/variables.none.tmpl %] [wikimedia/bugzilla/modifications] - 10https://gerrit.wikimedia.org/r/118958 (owner: 1001tonythomas) [14:36:37] (03PS3) 10Phuedx: Add a LESS test suite [core] - 10https://gerrit.wikimedia.org/r/119055 [14:40:14] (03CR) 10Matthias Mullie: [C: 032] Remove title must exist requirement [extensions/Flow] - 10https://gerrit.wikimedia.org/r/119118 (owner: 10EBernhardson) [14:40:26] (03CR) 10jenkins-bot: [V: 04-1] Remove title must exist requirement [extensions/Flow] - 10https://gerrit.wikimedia.org/r/119118 (owner: 10EBernhardson) [14:40:45] (03PS4) 10Matthias Mullie: Remove title must exist requirement [extensions/Flow] - 10https://gerrit.wikimedia.org/r/119118 (owner: 10EBernhardson) [14:41:29] (03CR) 10Matthias Mullie: [C: 032] Remove title must exist requirement [extensions/Flow] - 10https://gerrit.wikimedia.org/r/119118 (owner: 10EBernhardson) [14:41:41] (03Merged) 10jenkins-bot: Remove title must exist requirement [extensions/Flow] - 10https://gerrit.wikimedia.org/r/119118 (owner: 10EBernhardson) [14:44:01] https://scrutinizer-ci.com/g/wmde/WikibaseInternalSerialization/statistics/ [14:44:03] Tobi_WMDE: ^ [14:46:30] (03CR) 10Thiemo Mättig (WMDE): "> only one $( elem ) change compared to many other changes." [core] - 10https://gerrit.wikimedia.org/r/119460 (owner: 10Thiemo Mättig (WMDE)) [14:48:27] (03CR) 10Matthias Mullie: [C: 032] Show who moderated the most recent revision [extensions/Flow] - 10https://gerrit.wikimedia.org/r/117382 (owner: 10EBernhardson) [14:48:42] (03Merged) 10jenkins-bot: Show who moderated the most recent revision [extensions/Flow] - 10https://gerrit.wikimedia.org/r/117382 (owner: 10EBernhardson) [14:52:52] (03CR) 10Matthias Mullie: [C: 04-1] "Other than the remark about dieing, this looks good" (032 comments) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/115530 (owner: 10EBernhardson) [15:00:03] (03CR) 10Matthias Mullie: [C: 031] "Looks good, but could use a built-in sort instead" (031 comment) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/115531 (owner: 10EBernhardson) [15:03:11] (03PS6) 10Matthias Mullie: Add method to inject a workflow into the urlgenerators workflow cache [extensions/Flow] - 10https://gerrit.wikimedia.org/r/116673 (owner: 10EBernhardson) [15:03:21] (03CR) 10Matthias Mullie: [C: 032] Add method to inject a workflow into the urlgenerators workflow cache [extensions/Flow] - 10https://gerrit.wikimedia.org/r/116673 (owner: 10EBernhardson) [15:03:34] (03Merged) 10jenkins-bot: Add method to inject a workflow into the urlgenerators workflow cache [extensions/Flow] - 10https://gerrit.wikimedia.org/r/116673 (owner: 10EBernhardson) [15:03:55] (03PS6) 10Matthias Mullie: Make FlowActions accessible from permissions [extensions/Flow] - 10https://gerrit.wikimedia.org/r/116674 (owner: 10EBernhardson) [15:04:03] (03CR) 10Matthias Mullie: [C: 032] Make FlowActions accessible from permissions [extensions/Flow] - 10https://gerrit.wikimedia.org/r/116674 (owner: 10EBernhardson) [15:04:18] (03Merged) 10jenkins-bot: Make FlowActions accessible from permissions [extensions/Flow] - 10https://gerrit.wikimedia.org/r/116674 (owner: 10EBernhardson) [15:20:52] hi. I have submitted a LINK (of my GSoC proposal) to melange.. Do I have to write the full proposal on melange too or the link is just fine? pls help [15:22:23] rohit-dua: Just copy paste the entire wiki page to the Project summary box, and give the url. Thats how I did it. [15:22:40] tonythomas: thank you [15:22:54] rohit-dua: welcome :) [15:28:07] (03PS3) 10Dan-nl: don’t concatenate item specific categories [extensions/GWToolset] - 10https://gerrit.wikimedia.org/r/119467 [15:28:21] (03CR) 10Chad: [C: 032] Remove current implementation of getInfo() [extensions/MWSearch] - 10https://gerrit.wikimedia.org/r/119236 (owner: 10Chad) [15:28:25] (03Merged) 10jenkins-bot: Remove current implementation of getInfo() [extensions/MWSearch] - 10https://gerrit.wikimedia.org/r/119236 (owner: 10Chad) [15:28:46] (03CR) 10Siebrand: Initial pile of skin (031 comment) [skins/Splash] - 10https://gerrit.wikimedia.org/r/112859 (owner: 10Isarra) [15:28:51] (03CR) 10Dan-nl: "* incremented the version nr." [extensions/GWToolset] - 10https://gerrit.wikimedia.org/r/119467 (owner: 10Dan-nl) [15:29:18] (03PS1) 10Nemo bis: Link to existing login help page by default from helplogin-url [core] (REL1_22) - 10https://gerrit.wikimedia.org/r/119489 [15:30:00] (03CR) 10Siebrand: Bug fix and minor improvements (031 comment) [extensions/DisqusTag] - 10https://gerrit.wikimedia.org/r/112839 (owner: 10Luis Felipe Schenone) [15:31:09] (03CR) 10Yuvipanda: "Also note that this is using MapQuest tiles, which I guess is against WMF's Privacy Policy." [extensions/UploadWizard] (osm) - 10https://gerrit.wikimedia.org/r/116129 (owner: 10Inchikutty) [15:35:40] (03CR) 10Phuedx: Add a LESS test suite (032 comments) [core] - 10https://gerrit.wikimedia.org/r/119055 (owner: 10Phuedx) [15:54:40] (03PS3) 10Gerrit Patch Uploader: wpSummaryLabel and wpSummary in one line with full width [core] - 10https://gerrit.wikimedia.org/r/118246 [15:54:42] (03CR) 10Gerrit Patch Uploader: "This commit was uploaded using the Gerrit Patch Uploader [1]." [core] - 10https://gerrit.wikimedia.org/r/118246 (owner: 10Gerrit Patch Uploader) [16:00:32] (03CR) 10Anomie: [C: 032] Remove leftover code for titles in messages [extensions/Scribunto] - 10https://gerrit.wikimedia.org/r/119325 (owner: 10Jackmcbarn) [16:01:27] (03PS2) 10Matthias Mullie: Split all Flow\\Data classes into one file per class [extensions/Flow] - 10https://gerrit.wikimedia.org/r/119214 (owner: 10EBernhardson) [16:01:28] (03CR) 10jenkins-bot: [V: 04-1] Split all Flow\\Data classes into one file per class [extensions/Flow] - 10https://gerrit.wikimedia.org/r/119214 (owner: 10EBernhardson) [16:02:05] (03Merged) 10jenkins-bot: Remove leftover code for titles in messages [extensions/Scribunto] - 10https://gerrit.wikimedia.org/r/119325 (owner: 10Jackmcbarn) [16:03:43] (03PS2) 10Siebrand: Link to existing login help page by default from helplogin-url [core] (REL1_22) - 10https://gerrit.wikimedia.org/r/119489 (owner: 10Nemo bis) [16:03:50] (03CR) 10Siebrand: [C: 032] Link to existing login help page by default from helplogin-url [core] (REL1_22) - 10https://gerrit.wikimedia.org/r/119489 (owner: 10Nemo bis) [16:04:46] (03PS1) 10Matthias Mullie: Fix Notice: Undefined variable: wgFlowAbuseFilterGroup [extensions/Flow] - 10https://gerrit.wikimedia.org/r/119494 [16:05:16] (03CR) 10Matthias Mullie: [C: 032] Fix Notice: Undefined variable: wgFlowAbuseFilterGroup [extensions/Flow] - 10https://gerrit.wikimedia.org/r/119494 (owner: 10Matthias Mullie) [16:06:04] (03Merged) 10jenkins-bot: Fix Notice: Undefined variable: wgFlowAbuseFilterGroup [extensions/Flow] - 10https://gerrit.wikimedia.org/r/119494 (owner: 10Matthias Mullie) [16:08:36] (03Merged) 10jenkins-bot: Link to existing login help page by default from helplogin-url [core] (REL1_22) - 10https://gerrit.wikimedia.org/r/119489 (owner: 10Nemo bis) [16:12:22] (03PS3) 10Matthias Mullie: Split all Flow\\Data classes into one file per class [extensions/Flow] - 10https://gerrit.wikimedia.org/r/119214 (owner: 10EBernhardson) [16:13:08] (03CR) 10Matthias Mullie: [C: 032] "This rebase was no fun" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/119214 (owner: 10EBernhardson) [16:13:21] (03Merged) 10jenkins-bot: Split all Flow\\Data classes into one file per class [extensions/Flow] - 10https://gerrit.wikimedia.org/r/119214 (owner: 10EBernhardson) [16:14:38] (03CR) 10Siebrand: [C: 04-1] "Per Addshore." [extensions/OpenBadges] - 10https://gerrit.wikimedia.org/r/112350 (owner: 10Hchuying) [16:17:48] (03CR) 10Cmcmahon: [C: 032] "do ResourceLoader error check for one page" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/119070 (owner: 10Cmcmahon) [16:17:56] (03CR) 10Siebrand: [C: 04-1] "i18n/L10n reviewed." (034 comments) [extensions/Persona] - 10https://gerrit.wikimedia.org/r/112309 (owner: 10Donyu) [16:29:18] (03CR) 10Cmcmahon: [C: 032] "refactoring" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/115659 (owner: 10Cmcmahon) [16:36:50] (03CR) 10MarkTraceur: [C: 031] Add Popups (Hovercards) extension [tools/release] - 10https://gerrit.wikimedia.org/r/119447 (owner: 10Spage) [16:37:58] (03CR) 10MarkTraceur: [C: 031] Add Popups extension [core] (wmf/1.23wmf18) - 10https://gerrit.wikimedia.org/r/119450 (owner: 10Spage) [16:38:33] (03CR) 10MarkTraceur: [C: 031] "Blindly following documentation is fun!" [core] (wmf/1.23wmf17) - 10https://gerrit.wikimedia.org/r/119451 (owner: 10Spage) [16:41:03] (03PS1) 10MaxSem: Update README [extensions/Minifier] - 10https://gerrit.wikimedia.org/r/119499 [16:41:47] (03CR) 10MaxSem: [C: 032] Update README [extensions/Minifier] - 10https://gerrit.wikimedia.org/r/119499 (owner: 10MaxSem) [16:41:50] (03PS1) 10Chad: Turn on "now using" text when we're a Beta Feature [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/119500 [16:42:09] (03CR) 10MaxSem: [V: 032] Update README [extensions/Minifier] - 10https://gerrit.wikimedia.org/r/119499 (owner: 10MaxSem) [16:43:06] (03CR) 10OliverKeyes: "Appreciated for future commits." [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/119409 (owner: 10OliverKeyes) [16:45:10] (03PS4) 10Matthias Mullie: Combine various history actions [extensions/Flow] - 10https://gerrit.wikimedia.org/r/117383 (owner: 10EBernhardson) [16:45:13] (03PS1) 10Matthias Mullie: Add BC for obsolete action names [extensions/Flow] - 10https://gerrit.wikimedia.org/r/119501 [16:45:24] (03CR) 10jenkins-bot: [V: 04-1] Combine various history actions [extensions/Flow] - 10https://gerrit.wikimedia.org/r/117383 (owner: 10EBernhardson) [16:45:33] (03CR) 10jenkins-bot: [V: 04-1] Add BC for obsolete action names [extensions/Flow] - 10https://gerrit.wikimedia.org/r/119501 (owner: 10Matthias Mullie) [16:46:20] (03CR) 10Matthias Mullie: "I just submitted a patch to cover this feedback" (035 comments) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/117383 (owner: 10EBernhardson) [16:48:05] (03CR) 10Matthias Mullie: [C: 031] "I've dealt with my own feedback and looks good to me now\" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/117383 (owner: 10EBernhardson) [16:51:07] (03PS12) 10Jdlrobson: Rewrite the navigation links under the heading [extensions/VectorBeta] - 10https://gerrit.wikimedia.org/r/117903 [16:51:09] (03PS11) 10Jdlrobson: Give Vector/Winter Minerva's hamburger menu icon [extensions/VectorBeta] - 10https://gerrit.wikimedia.org/r/117927 [16:52:08] (03CR) 10Jdlrobson: [C: 04-1] "Waiting on a response to https://bugzilla.wikimedia.org/show_bug.cgi?id=56756#c11" [extensions/VectorBeta] - 10https://gerrit.wikimedia.org/r/118451 (owner: 10Matthias Mullie) [16:52:46] (03PS5) 10Matthias Mullie: Combine various history actions [extensions/Flow] - 10https://gerrit.wikimedia.org/r/117383 (owner: 10EBernhardson) [16:52:55] (03CR) 10Matthias Mullie: [C: 032] Combine various history actions [extensions/Flow] - 10https://gerrit.wikimedia.org/r/117383 (owner: 10EBernhardson) [16:53:08] (03CR) 10jenkins-bot: [V: 04-1] Combine various history actions [extensions/Flow] - 10https://gerrit.wikimedia.org/r/117383 (owner: 10EBernhardson) [16:54:32] (03CR) 10EBernhardson: [C: 032] Add BC for obsolete action names [extensions/Flow] - 10https://gerrit.wikimedia.org/r/119501 (owner: 10Matthias Mullie) [16:54:36] (03PS2) 10EBernhardson: Add BC for obsolete action names [extensions/Flow] - 10https://gerrit.wikimedia.org/r/119501 (owner: 10Matthias Mullie) [16:54:44] (03CR) 10EBernhardson: [C: 032] Add BC for obsolete action names [extensions/Flow] - 10https://gerrit.wikimedia.org/r/119501 (owner: 10Matthias Mullie) [16:55:10] (03Merged) 10jenkins-bot: Combine various history actions [extensions/Flow] - 10https://gerrit.wikimedia.org/r/117383 (owner: 10EBernhardson) [16:55:13] (03Merged) 10jenkins-bot: Add BC for obsolete action names [extensions/Flow] - 10https://gerrit.wikimedia.org/r/119501 (owner: 10Matthias Mullie) [16:56:54] (03CR) 10Jdlrobson: [C: 04-1] "In reply to Siebrand - I'm happy to merge this without the image since this is currently under a feature flag so the image can easily be a" (032 comments) [extensions/VectorBeta] - 10https://gerrit.wikimedia.org/r/99586 (owner: 10JGonera) [16:58:22] (03CR) 10Jdlrobson: Add watchlist count to compact personal bar (031 comment) [extensions/VectorBeta] - 10https://gerrit.wikimedia.org/r/116920 (owner: 10JGonera) [17:03:31] (03PS1) 10Chad: Expose search metrics to Javascript for performance tooling [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/119503 [17:05:08] (03PS1) 10Chad: Break up SearchEngine.php into a couple of other files [core] - 10https://gerrit.wikimedia.org/r/119504 [17:05:10] (03PS1) 10Chad: Remove completely useless implementation of getInfo() [core] - 10https://gerrit.wikimedia.org/r/119505 [17:07:25] (03CR) 10Chad: "I hate this function so I'm getting rid of it instead. See I51270aa3." [core] - 10https://gerrit.wikimedia.org/r/119235 (owner: 10Chad) [17:07:35] (03Abandoned) 10Chad: Rewrite SearchResultSet::getInfo() to actually be useful [core] - 10https://gerrit.wikimedia.org/r/119235 (owner: 10Chad) [17:08:13] (03PS2) 10Chad: Don't respect the "show redirects" option on Special:Search or the API [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/118593 [17:13:46] (03PS2) 10Chad: Expose search metrics to Javascript for performance tooling [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/119503 [17:19:19] (03PS1) 10Matthias Mullie: Get rid of unused uses in container.php [extensions/Flow] - 10https://gerrit.wikimedia.org/r/119508 [17:19:31] (03CR) 10Chad: Remove pointless $wgTitle and commented global mess (031 comment) [extensions/WYSIWYG] - 10https://gerrit.wikimedia.org/r/118422 (owner: 10Chad) [17:20:34] (03CR) 10Isarra: Initial pile of skin (031 comment) [skins/Splash] - 10https://gerrit.wikimedia.org/r/112859 (owner: 10Isarra) [17:24:36] (03CR) 10Isarra: "Is there any harm in them having a less suffix?" [core] - 10https://gerrit.wikimedia.org/r/110908 (owner: 10Isarra) [17:27:50] (03PS2) 10BryanDavis: Make use of strong consistency with Ceph RGW [core] - 10https://gerrit.wikimedia.org/r/119241 (owner: 10Aaron Schulz) [17:28:05] (03CR) 10BryanDavis: [C: 032] Make use of strong consistency with Ceph RGW [core] - 10https://gerrit.wikimedia.org/r/119241 (owner: 10Aaron Schulz) [17:33:27] (03Merged) 10jenkins-bot: Make use of strong consistency with Ceph RGW [core] - 10https://gerrit.wikimedia.org/r/119241 (owner: 10Aaron Schulz) [17:41:14] Krinkle, what was that link to the mw.url guide? [17:44:06] Aurora_Grimes: https://doc.wikimedia.org/mediawiki-core/master/js/ [17:44:19] mw.util I think [17:49:03] (03PS8) 10EBernhardson: Split re-usable parts out of ContributionsQuery [extensions/Flow] - 10https://gerrit.wikimedia.org/r/115530 [17:49:26] (03CR) 10EBernhardson: "die's were debugging statements that snuck in, removed now" (031 comment) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/115530 (owner: 10EBernhardson) [17:49:37] (03PS8) 10EBernhardson: Sort the combined header+topic revisions after merging [extensions/Flow] - 10https://gerrit.wikimedia.org/r/115531 [17:49:50] (03CR) 10jenkins-bot: [V: 04-1] Sort the combined header+topic revisions after merging [extensions/Flow] - 10https://gerrit.wikimedia.org/r/115531 (owner: 10EBernhardson) [17:50:16] okay thanks :) [17:51:50] (03PS9) 10EBernhardson: Sort the combined header+topic revisions after merging [extensions/Flow] - 10https://gerrit.wikimedia.org/r/115531 [17:52:59] (03Abandoned) 10EBernhardson: Simplify header and edit-header templates [extensions/Flow] - 10https://gerrit.wikimedia.org/r/103064 (owner: 10EBernhardson) [17:53:09] (03Abandoned) 10EBernhardson: Simplify edit-post template [extensions/Flow] - 10https://gerrit.wikimedia.org/r/103071 (owner: 10EBernhardson) [17:53:22] (03Abandoned) 10EBernhardson: Simplify edit-title template [extensions/Flow] - 10https://gerrit.wikimedia.org/r/103069 (owner: 10EBernhardson) [17:53:43] (03Abandoned) 10EBernhardson: Start HHVM on boot [vagrant] - 10https://gerrit.wikimedia.org/r/112064 (owner: 10EBernhardson) [17:58:02] (03CR) 10EBernhardson: [SCHEMA CHANGE] Drop the definition model (032 comments) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/115576 (owner: 10EBernhardson) [17:58:31] (03CR) 10Chad: [C: 032] Remove pointless extra assignment [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/119331 (owner: 10Chad) [17:58:41] (03Merged) 10jenkins-bot: Remove pointless extra assignment [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/119331 (owner: 10Chad) [18:01:44] (03PS1) 10Cmcmahon: Improve text of message attached to uploaded image [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/119519 [18:04:28] (03CR) 10Gergő Tisza: "UploadWizard is already calling Flickr APIs, not sure how that is conceptually different from calling MapQuest APIs. There is no personall" [extensions/UploadWizard] (osm) - 10https://gerrit.wikimedia.org/r/116129 (owner: 10Inchikutty) [18:05:59] (03PS1) 10Siebrand: Use IP address instead of IP [extensions/ThrottleOverride] - 10https://gerrit.wikimedia.org/r/119520 [18:08:54] (03CR) 10Siebrand: [C: 04-1] "Thanks for spotting that, LegoKTM." [extensions/ThrottleOverride] - 10https://gerrit.wikimedia.org/r/109443 (owner: 10Parent5446) [18:09:41] (03PS3) 10Yuvipanda: shared.css: Canonicalize and simplify background image rules [core] - 10https://gerrit.wikimedia.org/r/119463 (owner: 10Bartosz Dziewoński) [18:09:47] (03CR) 10Yuvipanda: [C: 032] shared.css: Canonicalize and simplify background image rules [core] - 10https://gerrit.wikimedia.org/r/119463 (owner: 10Bartosz Dziewoński) [18:11:53] (03CR) 10Gergő Tisza: [C: 032] Improve text of message attached to uploaded image [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/119519 (owner: 10Cmcmahon) [18:12:02] (03Merged) 10jenkins-bot: Improve text of message attached to uploaded image [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/119519 (owner: 10Cmcmahon) [18:15:20] (03Merged) 10jenkins-bot: shared.css: Canonicalize and simplify background image rules [core] - 10https://gerrit.wikimedia.org/r/119463 (owner: 10Bartosz Dziewoński) [18:15:47] (03CR) 10Siebrand: "Did reviews and only noticed this was abandoned after. Might as well submit :)." (035 comments) [extensions/WikimediaIncubator] - 10https://gerrit.wikimedia.org/r/112022 (owner: 10Ebe123) [18:17:42] (03PS2) 10Jack Phoenix: Get rid of Internet Explorer for Mac fixes in Monobook's main.css. [core] - 10https://gerrit.wikimedia.org/r/119422 [18:22:07] (03CR) 10Wctaiwan: [C: 031] "Haven't tested, but seems sane given https://en.wikipedia.org/wiki/CSS_filter#Star_HTML_hack and https://en.wikipedia.org/wiki/CSS_filter#" [core] - 10https://gerrit.wikimedia.org/r/119422 (owner: 10Jack Phoenix) [18:22:47] (03CR) 10Daniel Friesen: "How about it wastefully invoking lessc to parse an entire CSS file, iterate over it trying to do less specific stuff, and end up doing abs" [core] - 10https://gerrit.wikimedia.org/r/110908 (owner: 10Isarra) [18:24:19] (03CR) 10Jdlrobson: Suppress section edit links with action=render (031 comment) [core] - 10https://gerrit.wikimedia.org/r/118135 (owner: 10MaxSem) [18:30:44] (03PS1) 10EBernhardson: Remove title attributes from textarea [extensions/Flow] - 10https://gerrit.wikimedia.org/r/119525 [18:34:19] (03PS1) 10Helder.wiki: Remove inexistent hook "LivePreviewPrepare" [extensions/CodeEditor] - 10https://gerrit.wikimedia.org/r/119527 [18:34:36] (03CR) 10Raimond Spekking: [C: 032 V: 032] Use IP address instead of IP [extensions/ThrottleOverride] - 10https://gerrit.wikimedia.org/r/119520 (owner: 10Siebrand) [18:34:56] (03PS2) 10Helder.wiki: Remove inexistent hook "LivePreviewPrepare" [extensions/CodeEditor] - 10https://gerrit.wikimedia.org/r/119527 [18:34:58] (03PS1) 10Siebrand: Update the installer to use JSON i18n [core] - 10https://gerrit.wikimedia.org/r/119528 [18:35:32] (03CR) 10Helder.wiki: "Patch to remove the hook from CodeEditor:" [core] - 10https://gerrit.wikimedia.org/r/110347 (owner: 10Helder.wiki) [18:38:55] (03CR) 10Jdlrobson: [C: 04-1] "Max could you make this configurable by a parameter?" [core] - 10https://gerrit.wikimedia.org/r/118135 (owner: 10MaxSem) [18:40:03] (03CR) 10MaxSem: "Per bug report, the core behaviour should be like that. And that gadget should really use the API." [core] - 10https://gerrit.wikimedia.org/r/118135 (owner: 10MaxSem) [18:40:31] jdlrobson, ^ [18:42:00] (03PS1) 10Umherirrender: Use square brackets instead of curly braces for char of a string [core] - 10https://gerrit.wikimedia.org/r/119529 [18:42:02] (03PS8) 10Alex Monk: Cache VCS commit id/date text on Special:Version [core] - 10https://gerrit.wikimedia.org/r/95878 [18:42:21] (03CR) 10Isarra: "So it has a meaningful performance impact?" [core] - 10https://gerrit.wikimedia.org/r/110908 (owner: 10Isarra) [18:43:06] (03CR) 10Siebrand: [C: 04-1] Use square brackets instead of curly braces for char of a string (031 comment) [core] - 10https://gerrit.wikimedia.org/r/119529 (owner: 10Umherirrender) [18:45:33] (03CR) 10Bartosz Dziewoński: [C: 032] Provide PNG fallbacks for non-SVG web browsers [extensions/BetaFeatures] - 10https://gerrit.wikimedia.org/r/119034 (owner: 10Thiemo Mättig (WMDE)) [18:45:39] (03Merged) 10jenkins-bot: Provide PNG fallbacks for non-SVG web browsers [extensions/BetaFeatures] - 10https://gerrit.wikimedia.org/r/119034 (owner: 10Thiemo Mättig (WMDE)) [18:46:22] (03PS3) 10Bartosz Dziewoński: White background for the green Beta checkboxes [extensions/BetaFeatures] - 10https://gerrit.wikimedia.org/r/119036 (owner: 10Thiemo Mättig (WMDE)) [18:46:30] (03CR) 10Bartosz Dziewoński: [C: 032] "This looks a lot better." [extensions/BetaFeatures] - 10https://gerrit.wikimedia.org/r/119036 (owner: 10Thiemo Mättig (WMDE)) [18:46:34] (03Merged) 10jenkins-bot: White background for the green Beta checkboxes [extensions/BetaFeatures] - 10https://gerrit.wikimedia.org/r/119036 (owner: 10Thiemo Mättig (WMDE)) [18:48:32] James_F: Are you keeping tabs on the design changes in BetaFeatures? [18:51:44] (03PS1) 10Bartosz Dziewoński: betafeatures.css: Remove Sass compilation artifacts [extensions/BetaFeatures] - 10https://gerrit.wikimedia.org/r/119535 [18:51:48] ^ trivial [18:52:04] (03PS1) 10Umherirrender: Remove some unneeded local vars from EditPage.php [core] - 10https://gerrit.wikimedia.org/r/119536 [18:52:40] (03CR) 10Helder.wiki: "It was using the API before, but I had to change[1] it to action=render because it was too slow to be usable." [core] - 10https://gerrit.wikimedia.org/r/118135 (owner: 10MaxSem) [18:53:14] (03CR) 10MarkTraceur: [C: 032] "Ta, MatmaRex" [extensions/BetaFeatures] - 10https://gerrit.wikimedia.org/r/119535 (owner: 10Bartosz Dziewoński) [18:53:36] (03Merged) 10jenkins-bot: betafeatures.css: Remove Sass compilation artifacts [extensions/BetaFeatures] - 10https://gerrit.wikimedia.org/r/119535 (owner: 10Bartosz Dziewoński) [18:54:14] (03CR) 10MaxSem: "If there is a perfprmance problem with API, it should be filed as a bug, however we already have a rich API and I'm not going to reproduce" [core] - 10https://gerrit.wikimedia.org/r/118135 (owner: 10MaxSem) [18:54:28] rdwrer: i'm also about to draw you a SVG. [18:54:48] since one is missing. [18:55:01] Woohoo [18:55:12] MatmaRex: Hopefully it's a pretty SVG [18:55:25] * rdwrer judges SVGs not by the beauty of their rendering but by the beauty of their markup [18:55:39] rdwrer: the SVGs I use have windows line endings [18:55:58] * rdwrer casts YuviPanda into a pit for forty years [18:56:08] rdwrer: the markup will probably be pretty nasty when i'm done optimizing it. :P [18:56:26] MatmaRex: As long as it's not, like, one path with thousands of points [18:56:42] Which I shit you not is how Illustrator will do things most of the time [18:57:12] (03PS1) 10Andrew Bogott: Use a recurring job to delete instance host entries. [extensions/OpenStackManager] - 10https://gerrit.wikimedia.org/r/119537 [18:57:34] with simple icons that's usually all you need, heh [18:57:40] well, maybe with fewer points [18:57:51] (03PS2) 10Andrew Bogott: Use a recurring job to delete instance host entries. [extensions/OpenStackManager] - 10https://gerrit.wikimedia.org/r/119537 [18:58:35] spagewmf: ping? Popups/Hovercards/Peekcards bing deployed today? :) [18:59:42] (03CR) 10Helder.wiki: "More background about that change (in Portuguese): https://pt.wikipedia.org/w/index.php?oldid=32652368#Atualiza.C3.A7.C3.A3o" [core] - 10https://gerrit.wikimedia.org/r/118135 (owner: 10MaxSem) [19:11:18] hexmode: Hie. are you there? [19:11:29] zeek: yep [19:12:06] (03CR) 10MaxSem: "If Google translated it right, it claims that API always reparses the page, which is wrong." [core] - 10https://gerrit.wikimedia.org/r/118135 (owner: 10MaxSem) [19:14:30] (03PS2) 10Umherirrender: Use square brackets instead of curly braces for char of a string [core] - 10https://gerrit.wikimedia.org/r/119529 [19:16:07] (03CR) 10Umherirrender: "Patch Set 2: Changed more places" (031 comment) [core] - 10https://gerrit.wikimedia.org/r/119529 (owner: 10Umherirrender) [19:21:07] (03PS1) 10Siebrand: Remove bogus entry [core] - 10https://gerrit.wikimedia.org/r/119539 [19:23:04] (03CR) 10Siebrand: [C: 032] Remove bogus entry [core] - 10https://gerrit.wikimedia.org/r/119539 (owner: 10Siebrand) [19:26:23] rdwrer: Argh, was going to ask you about that change. [19:26:57] (03Merged) 10jenkins-bot: Remove bogus entry [core] - 10https://gerrit.wikimedia.org/r/119539 (owner: 10Siebrand) [19:27:14] rdwrer: IMO it looks nicer. [19:27:57] * ^d looks around for a CR victim [19:30:49] * hexmode looks for quim [19:33:04] (03PS1) 10Cscott: Update the documentation at the top of parserTests.txt [core] - 10https://gerrit.wikimedia.org/r/119544 [19:33:06] (03PS1) 10Cscott: Allow setting default thumb size in parser tests [core] - 10https://gerrit.wikimedia.org/r/119545 [19:40:09] (03CR) 10Siebrand: [C: 032] Use square brackets instead of curly braces for char of a string [core] - 10https://gerrit.wikimedia.org/r/119529 (owner: 10Umherirrender) [19:41:58] pizzzacat: ping? [19:43:53] (03Merged) 10jenkins-bot: Use square brackets instead of curly braces for char of a string [core] - 10https://gerrit.wikimedia.org/r/119529 (owner: 10Umherirrender) [19:44:18] rdwrer: i ended up drawing two. :P let me just recompress and i'll push 'em [19:45:30] (03PS2) 10Cscott: Allow setting default thumb size in parser tests [core] - 10https://gerrit.wikimedia.org/r/119545 [19:52:45] (03PS3) 10Chad: Expose search metrics to Javascript for performance tooling [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/119503 [19:58:00] (03PS1) 10Bartosz Dziewoński: checked.svg: Optimize [extensions/BetaFeatures] - 10https://gerrit.wikimedia.org/r/119547 [19:58:02] (03PS1) 10Bartosz Dziewoński: feature-information.svg: New SVG version in addition to PNG one [extensions/BetaFeatures] - 10https://gerrit.wikimedia.org/r/119548 [19:58:04] (03PS1) 10Bartosz Dziewoński: feature-discussion.svg: Snap to one-pixel grid [extensions/BetaFeatures] - 10https://gerrit.wikimedia.org/r/119549 [19:58:12] rdwrer: enjoy ^ [19:58:23] (i haven't actually tested that it works, but it should) [19:58:30] ^ famous last words [19:58:35] well, not necessarily last [20:01:50] :((( it's just one path [20:02:09] THE ONE TRUE WAY [20:02:11] THE ONE TRUE PATH [20:02:29] HAS A FINITE NUMBER OF POINTS, BUT CAN HAVE INFINITE DOTS PER INCH [20:03:36] * rdwrer smacks YuviPanda [20:03:52] rdwrer: it's all technically true! [20:04:13] *nod* [20:04:22] (03CR) 10MarkTraceur: [C: 032] checked.svg: Optimize [extensions/BetaFeatures] - 10https://gerrit.wikimedia.org/r/119547 (owner: 10Bartosz Dziewoński) [20:04:26] (03Merged) 10jenkins-bot: checked.svg: Optimize [extensions/BetaFeatures] - 10https://gerrit.wikimedia.org/r/119547 (owner: 10Bartosz Dziewoński) [20:04:26] TECHNICALLY TRUE! THE BEST KIND OF TRUE! [20:04:36] MatmaRex: Weird dependencies [20:08:12] (03PS1) 10Bartosz Dziewoński: Sanitized directory structure [extensions/BetaFeatures] - 10https://gerrit.wikimedia.org/r/119553 [20:08:16] (03CR) 10jenkins-bot: [V: 04-1] Sanitized directory structure [extensions/BetaFeatures] - 10https://gerrit.wikimedia.org/r/119553 (owner: 10Bartosz Dziewoński) [20:08:41] <^d> WHO WANTS TO REVIEW AN EASY CHANGE? [20:08:42] rdwrer: well, how do you want me to make that more paths? [20:09:07] MatmaRex: The checkbox is just one path, that's fine, but the scroll thing could more easily be a bunch of shapes [20:09:13] Or more understandably at least [20:09:14] if the "holes" are supposed to be transparent and not white [20:09:44] * ^d pouts [20:09:57] rdwrer: composing rectangles and ellipses together gets old really fast [20:10:05] also, smaller filesize this way! [20:10:32] Meh, not as interesting IMO [20:10:38] Maintainable code is good [20:10:50] Anyway, this is fine [20:11:02] (03CR) 10MarkTraceur: [C: 032] "bd" [extensions/BetaFeatures] - 10https://gerrit.wikimedia.org/r/119548 (owner: 10Bartosz Dziewoński) [20:11:03] * YuviPanda opens all of rdwrer's SVGs in illustrator [20:11:07] (03Merged) 10jenkins-bot: feature-information.svg: New SVG version in addition to PNG one [extensions/BetaFeatures] - 10https://gerrit.wikimedia.org/r/119548 (owner: 10Bartosz Dziewoński) [20:11:14] rdwrer: what is 'bd' [20:11:31] ugh, wtf is up with https://gerrit.wikimedia.org/r/#/c/119553/ [20:11:43] jshint crapped all over my file moves. [20:11:46] ^d: halp [20:12:05] hashar: halp [20:12:29] * ^d knows nothing about js or jshint [20:12:59] * YuviPanda makes ^d rewrite mw in nodejs [20:13:05] ^d: did that 'easy change' of yours get merged? [20:13:22] <^d> Nope :( [20:13:22] YuviPanda: Thumbs up [20:13:28] ^d: link? [20:13:30] rdwrer: ooh. [20:13:30] <^d> https://gerrit.wikimedia.org/r/#/c/119504/ [20:14:19] (03PS2) 10Yuvipanda: Break up SearchEngine.php into a couple of other files [core] - 10https://gerrit.wikimedia.org/r/119504 (owner: 10Chad) [20:14:26] (03CR) 10Yuvipanda: [C: 032] Break up SearchEngine.php into a couple of other files [core] - 10https://gerrit.wikimedia.org/r/119504 (owner: 10Chad) [20:14:34] ^d: easy enough :) [20:14:36] (03CR) 10MarkTraceur: [C: 032] "Thanks much, MatmaRex." [extensions/BetaFeatures] - 10https://gerrit.wikimedia.org/r/119549 (owner: 10Bartosz Dziewoński) [20:15:18] <^d> YuviPanda: <3 [20:15:25] ^d: <3 [20:16:07] (03Merged) 10jenkins-bot: feature-discussion.svg: Snap to one-pixel grid [extensions/BetaFeatures] - 10https://gerrit.wikimedia.org/r/119549 (owner: 10Bartosz Dziewoński) [20:16:24] yay rdwrer [20:19:01] (03Merged) 10jenkins-bot: Break up SearchEngine.php into a couple of other files [core] - 10https://gerrit.wikimedia.org/r/119504 (owner: 10Chad) [20:20:32] (03PS2) 10Chad: Remove completely useless implementation of getInfo() [core] - 10https://gerrit.wikimedia.org/r/119505 [20:21:05] (03PS3) 10Bartosz Dziewoński: Remove inexistent hook "LivePreviewPrepare" [extensions/CodeEditor] - 10https://gerrit.wikimedia.org/r/119527 (owner: 10Helder.wiki) [20:21:09] (03CR) 10Bartosz Dziewoński: [C: 032] Remove inexistent hook "LivePreviewPrepare" [extensions/CodeEditor] - 10https://gerrit.wikimedia.org/r/119527 (owner: 10Helder.wiki) [20:21:40] (03Merged) 10jenkins-bot: Remove inexistent hook "LivePreviewPrepare" [extensions/CodeEditor] - 10https://gerrit.wikimedia.org/r/119527 (owner: 10Helder.wiki) [20:21:57] (03Abandoned) 10Chad: Turn on "now using" text when we're a Beta Feature [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/119500 (owner: 10Chad) [20:22:26] (03PS4) 10Chad: Expose search metrics to Javascript for performance tooling [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/119503 [20:25:19] MaxSem: force merge. It is a bug [20:25:32] MaxSem: jshint is run on both the old file (which no more exist) and the new file [20:25:48] MaxSem: that is an issue with git-changed-in-head script from integration/jenkins.git [20:25:53] probably [20:26:30] ? [20:29:34] hashar: you were looking for MatmaRex [20:29:36] MatmaRex: ^ [20:29:54] ah [20:30:05] MatmaRex: force merge https://gerrit.wikimedia.org/r/#/c/119553/ [20:30:07] hashar: eek. thanks [20:30:13] MatmaRex: I am pretty sure it is a bug in the jenkins job [20:30:33] hmm [20:30:33] no [20:30:36] MatmaRex: ahah [20:30:38] (03CR) 10Bartosz Dziewoński: "hashar says that jenkins lies and this has to be force-merged when it is merged." [extensions/BetaFeatures] - 10https://gerrit.wikimedia.org/r/119553 (owner: 10Bartosz Dziewoński) [20:30:43] MatmaRex: that is worth than that [20:30:55] hm? [20:31:12] MatmaRex: so we have the crazy feature that whenever a job run on gallium host, jshint uses the .jshintrc that comes from integration/docroot.git which for some reason has non default option [20:31:24] (03CR) 10Bartosz Dziewoński: "(Note that I haven't checked that this works correctly in normal and debug mode!)" [extensions/BetaFeatures] - 10https://gerrit.wikimedia.org/r/119553 (owner: 10Bartosz Dziewoński) [20:31:30] MatmaRex: the fix is to add an empty .jshintrc in that repo that simply contains: {} [20:31:40] huh. [20:31:43] why did it not fail before? [20:31:52] bug is https://bugzilla.wikimedia.org/show_bug.cgi?id=52456 [20:31:59] it probably ran on another host [20:32:16] simply add the empty .jshintrc and you will be fine :] [20:32:34] maybe someday someone will find a proper fix for bug 52456 :-] [20:32:54] i've learned to ignore jenkins already. :P [20:42:45] (03CR) 10Adamw: [C: 04-1] "Looks great, but there are a few blockers." (0324 comments) [extensions/FundraisingChart] - 10https://gerrit.wikimedia.org/r/118616 (owner: 10Ssmith) [20:45:01] Amgine, http://parsoid-lb.eqiad.wikimedia.org/enwiktionary/water?oldid=25832643 [20:46:02] (03CR) 10Manybubbles: [C: 04-1] "Some complaints about minor stuff BUT I think we should also have a look at doing all the searches at once with an multi search." (032 comments) [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/119335 (owner: 10Chad) [20:47:47] (03PS20) 10Nemo bis: Add link to PD help translatable pages from sidebar [core] - 10https://gerrit.wikimedia.org/r/83221 [20:48:08] (03PS21) 10Nemo bis: Add link to PD help translatable pages from sidebar [core] - 10https://gerrit.wikimedia.org/r/83221 [20:48:40] in #wikimedia-office in about 15 minutes, discussing structured logging and MVC [20:48:40] https://www.mediawiki.org/wiki/Architecture_meetings/RFC_review_2014-03-19 [20:49:17] (03CR) 10Bsitu: [C: 04-1] "Missing edit conflict handling" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/117357 (owner: 10Bsitu) [20:52:13] sherah? [20:52:50] (03PS1) 10EBernhardson: ubdeleted -> undeleted [extensions/Flow] - 10https://gerrit.wikimedia.org/r/119633 [20:53:14] (03CR) 10EBernhardson: [C: 032] ubdeleted -> undeleted [extensions/Flow] - 10https://gerrit.wikimedia.org/r/119633 (owner: 10EBernhardson) [20:53:32] (03CR) 10jenkins-bot: [V: 04-1] ubdeleted -> undeleted [extensions/Flow] - 10https://gerrit.wikimedia.org/r/119633 (owner: 10EBernhardson) [20:53:42] (03Merged) 10jenkins-bot: ubdeleted -> undeleted [extensions/Flow] - 10https://gerrit.wikimedia.org/r/119633 (owner: 10EBernhardson) [20:54:06] (03PS1) 10Cmcmahon: Revert "Replace fragile checks with checks for spinner on save" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/119635 [20:54:23] (03PS22) 10Nemo bis: Add link to PD help translatable pages from sidebar [core] - 10https://gerrit.wikimedia.org/r/83221 [20:56:25] (03CR) 10Manybubbles: "Awe! I kind of wanted to do this." [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/119500 (owner: 10Chad) [20:58:28] (03CR) 10Chad: "I don't think the approach is right, it'll blindly override the global setting." [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/119500 (owner: 10Chad) [20:59:14] (03CR) 10Chad: "That's also possible, the main thing was I wanted to split into multiple result sets." [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/119335 (owner: 10Chad) [20:59:48] (03CR) 10Chad: Rewrite Interwiki searches to return array of search results (032 comments) [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/119335 (owner: 10Chad) [21:01:24] pizzzacat: jorm appears to be trying to ping you, dunno if he succeeded yet [21:01:39] has not, at least in this channel. [21:02:02] grrr. [21:02:22] that may be why. [21:02:28] ebernhardson: Mind throwing something at pizzzacat for jorm? [21:02:36] rdwrer: who is that? [21:02:41] ebernhardson: Sherah. [21:02:45] * rdwrer facepalms [21:02:48] shes not here [21:02:51] Oh! [21:02:53] Maybe couching. [21:02:54] (03CR) 10Adamw: [C: 032 V: 032] Move hooks to separate file/class [extensions/Campaigns] (wip/editorcampaigns) - 10https://gerrit.wikimedia.org/r/116056 (owner: 10AndyRussG) [21:03:01] Or meeting or something [21:05:06] prtksxna you around? I note Hovercards on en-beta shows in UI [21:05:10] in #wikimedia-office now, discussing structured logging and MVC https://www.mediawiki.org/wiki/Architecture_meetings/RFC_review_2014-03-19 [21:05:35] spagewmf: hey! He's asleep a few feet away. I can look into it instead. moment [21:07:29] spagewmf: most probably a betalabs issue. I see that the i18n file has popups-last-edited message properly set [21:07:45] spagewmf: and it's set in RL properly [21:09:06] YuviPanda: I concur, thanks. 2am!? [21:09:16] spagewmf: 2:40 AM. [21:09:34] spagewmf: :) [21:09:41] spagewmf: I tested locally, works fine [21:09:56] spagewmf: I merged most of the code there, so I'll be around till end of deployment in case you've questions :) [21:10:17] Yuvampire [21:14:39] YuviPanda: what happened, someone reminded you of your extension? :) https://gerrit.wikimedia.org/r/119636 [21:15:41] Nemo_bis: wait, that's not mine, is it [21:15:45] mine was something else Sifter [21:15:49] I think [21:15:51] Ah :) [21:15:53] * YuviPanda cringes at his GSoC [21:20:22] (03CR) 10Adamw: [C: 032 V: 032] "Brilliant work! Thanks for taking the time to reinvent the wheel, it actually looks much more round, functional and helpful than the Symf" (032 comments) [extensions/Campaigns] (wip/editorcampaigns) - 10https://gerrit.wikimedia.org/r/116153 (owner: 10AndyRussG) [21:20:44] Could I get some 2nd opinions on https://gerrit.wikimedia.org/r/#/c/119541/ (tabs vs spaces in json i18n files)? [21:20:49] (03CR) 10Adamw: "Also: this should be ported to MediaWiki-core." [extensions/Campaigns] (wip/editorcampaigns) - 10https://gerrit.wikimedia.org/r/116153 (owner: 10AndyRussG) [21:21:20] (03PS2) 10Spage: Add Popups extension [core] (wmf/1.23wmf18) - 10https://gerrit.wikimedia.org/r/119450 [21:22:10] kaldari: Well, now expect a fifteenth opinion [21:22:16] (03PS3) 10Andrew Bogott: Use a recurring job to delete instance host entries. [extensions/OpenStackManager] - 10https://gerrit.wikimedia.org/r/119537 [21:22:17] Bikeshedders, start your paintbrushes [21:22:17] :) [21:22:37] rdwrer: maybe I should start a thread on wikitech-l ;) [21:23:11] Yes, that will solve all problems [21:23:49] (03PS1) 10Adamw: notify EdProgram about Extension:Campaigns patches [labs/tools/grrrit] - 10https://gerrit.wikimedia.org/r/119638 [21:24:46] (03CR) 10Spage: [C: 032] "PS2 is latest Popups (message changes only)." [core] (wmf/1.23wmf18) - 10https://gerrit.wikimedia.org/r/119450 (owner: 10Spage) [21:24:52] YuviPanda: No big deal, but should I redo https://gerrit.wikimedia.org/r/#/c/112311/ ? [21:25:01] awight: lookin [21:25:15] (03PS1) 10Robmoen: Delint and general mw.UploadWizardUpload cleanup [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/119639 [21:25:20] awight: oh yeah, I'm sober enough to merge those now if you rebase :) [21:25:25] lol ok sure [21:25:28] awight: :) [21:25:30] cos I'm not :p [21:25:53] awight: hahaha :D [21:26:17] * awight pins the code down with a toothpick so I can beat it up [21:26:36] (03PS14) 10EBernhardson: [SCHEMA CHANGE] Drop the definition model [extensions/Flow] - 10https://gerrit.wikimedia.org/r/115576 [21:26:52] (03PS4) 10Andrew Bogott: Use a recurring job to delete instance host entries. [extensions/OpenStackManager] - 10https://gerrit.wikimedia.org/r/119537 [21:26:55] (03PS1) 10Bsitu: Closing & Summarizing topic frontend changes [extensions/Flow] - 10https://gerrit.wikimedia.org/r/119640 [21:27:06] (03CR) 10jenkins-bot: [V: 04-1] Closing & Summarizing topic frontend changes [extensions/Flow] - 10https://gerrit.wikimedia.org/r/119640 (owner: 10Bsitu) [21:28:37] (03Merged) 10jenkins-bot: Add Popups extension [core] (wmf/1.23wmf18) - 10https://gerrit.wikimedia.org/r/119450 (owner: 10Spage) [21:28:39] (03CR) 10Siebrand: [C: 031] "L10n reviewed." [extensions/Flow] - 10https://gerrit.wikimedia.org/r/119640 (owner: 10Bsitu) [21:31:19] (03PS1) 10Hashar: Empty jshint.rc to reset to defaults [extensions/BetaFeatures] - 10https://gerrit.wikimedia.org/r/119641 [21:31:46] (03PS2) 10Robmoen: Delint and general mw.UploadWizardUpload cleanup [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/119639 [21:32:01] (03PS2) 10Bsitu: Closing & Summarizing topic frontend changes [extensions/Flow] - 10https://gerrit.wikimedia.org/r/119640 [21:32:09] (03CR) 10jenkins-bot: [V: 04-1] Closing & Summarizing topic frontend changes [extensions/Flow] - 10https://gerrit.wikimedia.org/r/119640 (owner: 10Bsitu) [21:33:30] (03CR) 10AndyRussG: [C: 032] notify EdProgram about Extension:Campaigns patches [labs/tools/grrrit] - 10https://gerrit.wikimedia.org/r/119638 (owner: 10Adamw) [21:33:33] (03Merged) 10jenkins-bot: notify EdProgram about Extension:Campaigns patches [labs/tools/grrrit] - 10https://gerrit.wikimedia.org/r/119638 (owner: 10Adamw) [21:33:54] (03PS2) 10Adamw: Reformat using a more yaml-y style [labs/tools/grrrit] - 10https://gerrit.wikimedia.org/r/112311 [21:33:57] (03CR) 10jenkins-bot: [V: 04-1] Reformat using a more yaml-y style [labs/tools/grrrit] - 10https://gerrit.wikimedia.org/r/112311 (owner: 10Adamw) [21:34:33] argh. [21:35:52] (03PS3) 10Adamw: Reformat using a more yaml-y style [labs/tools/grrrit] - 10https://gerrit.wikimedia.org/r/112311 [21:38:40] awight: tell me when you're ok with me testing it, I'll test + merge? [21:39:53] (03CR) 10Bartosz Dziewoński: [C: 032] "Ugly :(" [extensions/BetaFeatures] - 10https://gerrit.wikimedia.org/r/119641 (owner: 10Hashar) [21:39:55] (03CR) 10Spage: [C: 032] "Deploy time." [core] (wmf/1.23wmf17) - 10https://gerrit.wikimedia.org/r/119451 (owner: 10Spage) [21:39:57] (03PS1) 10Adamw: add Extension:FundraisingChart; notify wikimedia-dev about FR commits [labs/tools/grrrit] - 10https://gerrit.wikimedia.org/r/119643 [21:40:34] YuviPanda: I think it's ready to go. Actually, I'm not sure how the previous syntax was working, cos curly brace is supposed to create maps, not lists... [21:40:40] (03Merged) 10jenkins-bot: Empty jshint.rc to reset to defaults [extensions/BetaFeatures] - 10https://gerrit.wikimedia.org/r/119641 (owner: 10Hashar) [21:41:01] (03PS3) 10Robmoen: Delint and general mw.UploadWizardUpload cleanup [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/119639 [21:41:13] awight: I think it might've been ok with curly braces, because some of it had keys? [21:41:23] (03PS1) 10Krinkle: resourceloader: Sanitize lang code before creating Language object [core] - 10https://gerrit.wikimedia.org/r/119644 [21:42:53] YuviPanda: perhaps it was sticking together thanks to evil magick? [21:43:09] awight: or maybe since it was iterating over things, it was iterating over the keys and it was ok? [21:43:10] evil magick like *gravity* [21:43:40] * awight gets nervous that coworkers are reading the newpaper [21:44:14] awight: are you a wight? [21:44:23] yessir a human [21:44:28] (03Merged) 10jenkins-bot: Add Popups extension [core] (wmf/1.23wmf17) - 10https://gerrit.wikimedia.org/r/119451 (owner: 10Spage) [21:45:10] (03PS5) 10Andrew Bogott: Use a recurring job to delete instance host entries. [extensions/OpenStackManager] - 10https://gerrit.wikimedia.org/r/119537 [21:45:20] (03CR) 10Tim Starling: [C: 031] "Looks good to me. Maybe some day we can port the whole of MW core to composer and have dependencies, but I think this way is fine for now." [core] - 10https://gerrit.wikimedia.org/r/112699 (owner: 10BryanDavis) [21:45:20] spagewmf: woo! :) [21:45:55] (03CR) 10Tim Starling: "I should say, the way composer is used looks good. I haven't reviewed the code." [core] - 10https://gerrit.wikimedia.org/r/112699 (owner: 10BryanDavis) [21:47:05] (03PS2) 10Bartosz Dziewoński: Sanitized directory structure [extensions/BetaFeatures] - 10https://gerrit.wikimedia.org/r/119553 [21:47:33] awight, sue Matthew McConaughey for saying "Well, awight awight awight!" all the time [21:48:03] anomie: btw looks like https://gerrit.wikimedia.org/r/#/c/106517/ is awaiting your next comment [21:48:10] (03PS3) 10Adi.iiita: Fixed padlock on thread history for LiquidThreads extension [extensions/LiquidThreads] - 10https://gerrit.wikimedia.org/r/118212 [21:48:51] spagewmf: he probably has the same speech impelement as my patrilineage [21:52:04] (03CR) 10CSteipp: [C: 031] "Security should be ok" [core] - 10https://gerrit.wikimedia.org/r/118111 (owner: 10Anomie) [21:53:23] (03PS10) 10JGonera: Add Compact personal bar beta feature [extensions/VectorBeta] - 10https://gerrit.wikimedia.org/r/99586 [21:53:31] jdlrobson, ^ [21:54:36] (03CR) 10Siebrand: [C: 031] "L10n reviewed." [extensions/Flow] - 10https://gerrit.wikimedia.org/r/119640 (owner: 10Bsitu) [22:01:24] (03PS23) 10Nemo bis: Add link to PD help translatable pages from sidebar [core] - 10https://gerrit.wikimedia.org/r/83221 [22:02:25] Why are extensions able to use "auto_increment" under sqlite? Maybe there is magic in the DatabaseUpdater class? [22:03:28] oh dear. includes/db/DatabaseSqlite.php: $s = preg_replace( '/\bauto_increment\b/i', 'AUTOINCREMENT', $s ); [22:04:51] hahaha [22:05:37] Sadly, I almost like this sort of approach. I've always been impressed by WordPress calculating schema migrations by doing some basic regexing on your create table statements... [22:08:40] sql has rather simple syntax :) [22:08:53] (03PS10) 10EBernhardson: Sort the combined header+topic revisions after merging [extensions/Flow] - 10https://gerrit.wikimedia.org/r/115531 [22:08:56] (03PS9) 10EBernhardson: Split re-usable parts out of ContributionsQuery [extensions/Flow] - 10https://gerrit.wikimedia.org/r/115530 [22:08:59] (03PS5) 10EBernhardson: Refactor Flow\\Formatter namespace [extensions/Flow] - 10https://gerrit.wikimedia.org/r/117384 [22:12:27] (03PS11) 10EBernhardson: Sort the combined header+topic revisions after merging [extensions/Flow] - 10https://gerrit.wikimedia.org/r/115531 [22:12:30] (03PS6) 10EBernhardson: Refactor Flow\\Formatter namespace [extensions/Flow] - 10https://gerrit.wikimedia.org/r/117384 [22:12:51] (03CR) 10jenkins-bot: [V: 04-1] Refactor Flow\\Formatter namespace [extensions/Flow] - 10https://gerrit.wikimedia.org/r/117384 (owner: 10EBernhardson) [22:15:01] (03CR) 10Matthias Mullie: [C: 031] "Merge after code freeze" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/115531 (owner: 10EBernhardson) [22:15:09] (03CR) 10Matthias Mullie: [C: 031] "Merge after code freeze" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/115530 (owner: 10EBernhardson) [22:18:11] (03CR) 10Matthias Mullie: [C: 032] Prevent double email notifications on talk page edit [extensions/Echo] - 10https://gerrit.wikimedia.org/r/114683 (owner: 10Bsitu) [22:18:22] (03Merged) 10jenkins-bot: Prevent double email notifications on talk page edit [extensions/Echo] - 10https://gerrit.wikimedia.org/r/114683 (owner: 10Bsitu) [22:18:32] (03CR) 10CSteipp: [C: 031] HTMLForm: Add hide-if [core] - 10https://gerrit.wikimedia.org/r/118110 (owner: 10Anomie) [22:20:45] (03PS7) 10EBernhardson: Refactor Flow\\Formatter namespace [extensions/Flow] - 10https://gerrit.wikimedia.org/r/117384 [22:21:31] \o/ thanks mlitn [22:21:42] just today I had 3 duplicate enotifs [22:24:47] (03CR) 10Adamw: [C: 032 V: 032] Schema change: create tables (032 comments) [extensions/Campaigns] (wip/editorcampaigns) - 10https://gerrit.wikimedia.org/r/117905 (owner: 10AndyRussG) [22:28:10] (03CR) 10Jforrester: [C: 031] "Let's merge this after the cut." [extensions/BetaFeatures] - 10https://gerrit.wikimedia.org/r/119553 (owner: 10Bartosz Dziewoński) [22:29:01] (03PS9) 10Mattflaschen: WIP: Refactor and add non-linear tours [extensions/GuidedTour] - 10https://gerrit.wikimedia.org/r/116228 [22:29:38] (03CR) 10jenkins-bot: [V: 04-1] WIP: Refactor and add non-linear tours [extensions/GuidedTour] - 10https://gerrit.wikimedia.org/r/116228 (owner: 10Mattflaschen) [22:31:46] (03CR) 10Mattflaschen: "I went ahead and removed guider.prev(), and fixed next and skip." [extensions/GuidedTour] - 10https://gerrit.wikimedia.org/r/116228 (owner: 10Mattflaschen) [22:32:08] (03CR) 10Adamw: [C: 04-1] Add persistence objects and tests (031 comment) [extensions/Campaigns] (wip/editorcampaigns) - 10https://gerrit.wikimedia.org/r/116221 (owner: 10AndyRussG) [22:32:47] (03PS4) 10MaxSem: HHVM support [php/wikidiff2] - 10https://gerrit.wikimedia.org/r/117362 [22:33:23] (03CR) 10CSteipp: [C: 031] HTMLForm: Add daterange type [core] - 10https://gerrit.wikimedia.org/r/118112 (owner: 10Anomie) [22:33:26] (03CR) 10Adamw: Add persistence objects and tests (031 comment) [extensions/Campaigns] (wip/editorcampaigns) - 10https://gerrit.wikimedia.org/r/116221 (owner: 10AndyRussG) [22:33:50] (03PS9) 10EBernhardson: Make BoardHistory a Formatter instance [extensions/Flow] - 10https://gerrit.wikimedia.org/r/115532 [22:34:05] (03CR) 10jenkins-bot: [V: 04-1] Make BoardHistory a Formatter instance [extensions/Flow] - 10https://gerrit.wikimedia.org/r/115532 (owner: 10EBernhardson) [22:38:18] (03PS10) 10EBernhardson: Make BoardHistory a Formatter instance [extensions/Flow] - 10https://gerrit.wikimedia.org/r/115532 [22:46:04] (03CR) 10Mattflaschen: "Can you explain the vertical alignment part? I don't see any change to the center." [extensions/GettingStarted] - 10https://gerrit.wikimedia.org/r/117874 (owner: 10Phuedx) [22:49:17] (03CR) 10Hoo man: [C: 032] Preferences.php: avoid "Undefined index" if key 'realname' don't exist in $formdata [core] - 10https://gerrit.wikimedia.org/r/116282 (owner: 10GBT248) [22:52:23] (03PS1) 10Jforrester: Update OOjs UI to v0.1.0-pre (53f2410336) [core] - 10https://gerrit.wikimedia.org/r/119656 [22:53:33] (03Merged) 10jenkins-bot: Preferences.php: avoid "Undefined index" if key 'realname' don't exist in $formdata [core] - 10https://gerrit.wikimedia.org/r/116282 (owner: 10GBT248) [22:54:48] (03CR) 10Catrope: [C: 032] Update OOjs UI to v0.1.0-pre (53f2410336) [core] - 10https://gerrit.wikimedia.org/r/119656 (owner: 10Jforrester) [22:57:18] bd808: On logstash, there's two errors that are missing a stacktrace [22:57:28] Originating from https://github.com/wikimedia/mediawiki-core/blob/wmf/1.23wmf17/includes/Message.php#L922-L926 and https://github.com/wikimedia/mediawiki-core/blob/wmf/1.23wmf17/includes/context/RequestContext.php#L318-L320 [22:57:42] That code in php ($e = new Exception;) looks wrong, right? [22:58:12] (03PS27) 10CSteipp: Added password hashing API [core] - 10https://gerrit.wikimedia.org/r/77645 (owner: 10Parent5446) [22:58:46] That's a trick to get a stack trace. It should work. The newline might confuse logstash [22:59:15] * bd808 looks to see how "Bug58676" messages are parsed [22:59:23] (03CR) 10CSteipp: "PS27 fixed rebase" [core] - 10https://gerrit.wikimedia.org/r/77645 (owner: 10Parent5446) [22:59:30] They are both trending relatively new errors popping up a lot in production. Should be fixed, but no idea where to start. [22:59:32] (03Merged) 10jenkins-bot: Update OOjs UI to v0.1.0-pre (53f2410336) [core] - 10https://gerrit.wikimedia.org/r/119656 (owner: 10Jforrester) [23:01:40] Krinkle: logstash should have those stack traces, but I can definitely see them in /a/mw-log/Bug58676.log on fluorine [23:02:10] https://logstash.wikimedia.org/#/dashboard/elasticsearch/fatalmonitor [23:02:27] CHecked the 'raw' json even [23:02:30] just the one line [23:03:26] Krinkle: Oh. The fatal doesn't get the stacktrace. You need to look at "type:Bug58676" events [23:03:40] is the /fatalmonitor more than just the query it shows? [23:03:42] The fatal log only gets the warning emit [23:03:55] Are they from different events? [23:03:59] or different views to the same data [23:04:35] Krinkle: `trigger_error( $warning, E_USER_WARNING );` goes to that fatal view [23:04:44] Right [23:04:56] (03PS2) 10Siebrand: Update the installer to use JSON i18n [core] - 10https://gerrit.wikimedia.org/r/119528 [23:04:59] (03PS1) 10Siebrand: [WIP] Convert core messages to JSON i18n format [core] - 10https://gerrit.wikimedia.org/r/119658 [23:05:03] On, https://logstash.wikimedia.org/#/dashboard/elasticsearch/default, it is almost impossible to click the smaller types [23:05:07] `wfDebugLog( 'Bug58676', …)` is in logstash as "type:Bug58676" [23:05:18] I'd expect the labels to be clickable, but only the chart bars it seems [23:05:23] which are like < 2px tall :) [23:05:53] Yeah. I usually get to the lesser ones by exclude filtering the big ones [23:05:59] (03CR) 10jenkins-bot: [V: 04-1] Added password hashing API [core] - 10https://gerrit.wikimedia.org/r/77645 (owner: 10Parent5446) [23:06:25] (03CR) 10Parent5446: "Tested and works. One inline question." (031 comment) [core] - 10https://gerrit.wikimedia.org/r/118110 (owner: 10Anomie) [23:06:27] (03CR) 10AndyRussG: Add persistence objects and tests (032 comments) [extensions/Campaigns] (wip/editorcampaigns) - 10https://gerrit.wikimedia.org/r/116221 (owner: 10AndyRussG) [23:06:29] bd808: Can I do that from the UI without typing? [23:06:36] I can click a big one, can I negate it? [23:07:35] Not on the bars, but you can open the detail of an event and and click the (/) on it's _type or other fields [23:08:08] Krinkle: https://logstash.wikimedia.org/#dashboard/temp/7ZylSkZNQxaTeJzdOJAyGQ [23:08:15] bd808: Doing such a UI action (adding and removing filters), is that supposed to update the query search in input field on top? [23:08:27] I got there already :) [23:08:34] The are added to the "FILTERING" section [23:08:44] which is probably collapsed by default [23:08:50] right [23:12:08] (03CR) 10jenkins-bot: [V: 04-1] [WIP] Convert core messages to JSON i18n format [core] - 10https://gerrit.wikimedia.org/r/119658 (owner: 10Siebrand) [23:16:44] (03CR) 10Jdlrobson: "How critical are these gadgets? How much time would you need to rewrite them? If I merge this change tomorrow you would have an entire two" [core] - 10https://gerrit.wikimedia.org/r/118135 (owner: 10MaxSem) [23:18:03] (03CR) 10Parent5446: [C: 032] HTMLForm: Add date type [core] - 10https://gerrit.wikimedia.org/r/118111 (owner: 10Anomie) [23:25:03] (03CR) 10Siebrand: "Here's the process I followed:" [core] - 10https://gerrit.wikimedia.org/r/119658 (owner: 10Siebrand) [23:25:54] (03PS11) 10EBernhardson: Make BoardHistory a Formatter instance [extensions/Flow] - 10https://gerrit.wikimedia.org/r/115532 [23:25:57] (03PS8) 10EBernhardson: Refactor Flow\\Formatter namespace [extensions/Flow] - 10https://gerrit.wikimedia.org/r/117384 [23:26:14] (03PS1) 10Yurik: *INCOMPLETE* Image Quality reduction param [core] - 10https://gerrit.wikimedia.org/r/119661 [23:26:49] (03CR) 10Siebrand: "I've tested." [core] - 10https://gerrit.wikimedia.org/r/119658 (owner: 10Siebrand) [23:27:41] (03CR) 10Jdlrobson: [C: 032] Add Compact personal bar beta feature [extensions/VectorBeta] - 10https://gerrit.wikimedia.org/r/99586 (owner: 10JGonera) [23:27:51] (03CR) 10jenkins-bot: [V: 04-1] *INCOMPLETE* Image Quality reduction param [core] - 10https://gerrit.wikimedia.org/r/119661 (owner: 10Yurik) [23:27:53] (03Merged) 10jenkins-bot: Add Compact personal bar beta feature [extensions/VectorBeta] - 10https://gerrit.wikimedia.org/r/99586 (owner: 10JGonera) [23:30:32] (03CR) 10Siebrand: "The issue is easily tested by adding "?uselang=hil" [core] - 10https://gerrit.wikimedia.org/r/119658 (owner: 10Siebrand) [23:32:41] (03PS9) 10Jdlrobson: Add click tracking to compact personal bar [extensions/VectorBeta] - 10https://gerrit.wikimedia.org/r/117138 (owner: 10JGonera) [23:32:45] (03CR) 10Jdlrobson: [C: 032] Add click tracking to compact personal bar [extensions/VectorBeta] - 10https://gerrit.wikimedia.org/r/117138 (owner: 10JGonera) [23:32:51] (03Merged) 10jenkins-bot: Add click tracking to compact personal bar [extensions/VectorBeta] - 10https://gerrit.wikimedia.org/r/117138 (owner: 10JGonera) [23:34:12] (03CR) 10Jdlrobson: [C: 04-1] "Needs a rebase apart from that doesn't look like any issues.. although that said I have an icon mixin - would be call to reuse the same th" [extensions/VectorBeta] - 10https://gerrit.wikimedia.org/r/117119 (owner: 10JGonera) [23:34:21] Uh, memories. Last time we did ClickTracking nothing good came out of it and after 4-5 years we're still waiting for the raw data which was interpreted with such catastrophic consequences :) [23:35:13] Nemo_bis: we have click tracking on MobileFrontend - it's very enlightening - e.g. http://mobile-reportcard.wmflabs.org/graphs/menu-daily , http://mobile-reportcard.wmflabs.org/graphs/watchlist-activity , http://mobile-reportcard.wmflabs.org/graphs/diff-activity [23:37:00] (03CR) 10Parent5446: "Has anybody considering repo? It's a tool developed by Google (and used for Android) to handle multiple Git repositories in a sane manner," [core] - 10https://gerrit.wikimedia.org/r/112699 (owner: 10BryanDavis) [23:38:12] (03PS3) 10CSteipp: Reduce number of bcrypt tests [core] - 10https://gerrit.wikimedia.org/r/119083 [23:38:26] (03PS11) 10Jdlrobson: Add Fixed header experiment to Vector Beta [extensions/VectorBeta] - 10https://gerrit.wikimedia.org/r/107523 [23:39:27] (03CR) 10jenkins-bot: [V: 04-1] Add Fixed header experiment to Vector Beta [extensions/VectorBeta] - 10https://gerrit.wikimedia.org/r/107523 (owner: 10Jdlrobson) [23:39:56] (03PS12) 10Jdlrobson: Add Fixed header experiment to Vector Beta [extensions/VectorBeta] - 10https://gerrit.wikimedia.org/r/107523 [23:39:58] (03PS4) 10CSteipp: Reduce number of bcrypt tests [core] - 10https://gerrit.wikimedia.org/r/119083 [23:40:00] (03CR) 10jenkins-bot: [V: 04-1] Add Fixed header experiment to Vector Beta [extensions/VectorBeta] - 10https://gerrit.wikimedia.org/r/107523 (owner: 10Jdlrobson) [23:40:02] (03CR) 10BryanDavis: [C: 032] Add Popups (Hovercards) extension [tools/release] - 10https://gerrit.wikimedia.org/r/119447 (owner: 10Spage) [23:40:23] (03CR) 10MaxSem: [C: 04-1] "This query takes forever to execute on enwiki and in general queries that are appropriate on special pages are not always so for every pag" [extensions/VectorBeta] - 10https://gerrit.wikimedia.org/r/116920 (owner: 10JGonera) [23:41:04] (03Merged) 10jenkins-bot: Add Popups (Hovercards) extension [tools/release] - 10https://gerrit.wikimedia.org/r/119447 (owner: 10Spage) [23:41:31] (03CR) 10Parent5446: [C: 032] HTMLForm: Add date type [core] - 10https://gerrit.wikimedia.org/r/118111 (owner: 10Anomie) [23:43:20] (03PS1) 10Reedy: Tidy up and simplify database query/query building [extensions/TwitterCards] - 10https://gerrit.wikimedia.org/r/119663 [23:46:45] (03CR) 10jenkins-bot: [V: 04-1] Reduce number of bcrypt tests [core] - 10https://gerrit.wikimedia.org/r/119083 (owner: 10CSteipp) [23:47:01] (03PS2) 10Reedy: Tidy up and simplify database query/query building [extensions/TwitterCards] - 10https://gerrit.wikimedia.org/r/119663 [23:49:26] (03PS5) 10CSteipp: Reduce number of bcrypt tests [core] - 10https://gerrit.wikimedia.org/r/119083 [23:51:06] (03PS13) 10Jdlrobson: Add Fixed header experiment to Vector Beta [extensions/VectorBeta] - 10https://gerrit.wikimedia.org/r/107523 [23:51:08] (03PS13) 10Jdlrobson: Rewrite the navigation links under the heading [extensions/VectorBeta] - 10https://gerrit.wikimedia.org/r/117903 [23:51:10] (03PS12) 10Jdlrobson: Give Vector/Winter Minerva's hamburger menu icon [extensions/VectorBeta] - 10https://gerrit.wikimedia.org/r/117927 [23:56:03] (03CR) 10BryanDavis: "> Has anybody considering repo?" [core] - 10https://gerrit.wikimedia.org/r/112699 (owner: 10BryanDavis) [23:56:24] gwicke: still cannot connect to server. [23:56:31] (03CR) 10jenkins-bot: [V: 04-1] Reduce number of bcrypt tests [core] - 10https://gerrit.wikimedia.org/r/119083 (owner: 10CSteipp) [23:58:30] (03PS1) 10Jdlrobson: Ensure that we do not run VectorBeta outside Vector skin [extensions/VectorBeta] - 10https://gerrit.wikimedia.org/r/119664 [23:58:30] Amgine, https everywhere? [23:58:40] Yes. [23:58:51] in that case, you can try https://parsoid-prod.wmflabs.org/ [23:59:10] that's yuvi's nginx instance proxy [23:59:40] Also loaded an instance without everwhere. [23:59:54] as a stop-gap until we have a real content api with https, spdy etc