[01:12:07] (03PS1) 10leucosticte: Add LocallyBlockedProxy hook [core] - 10https://gerrit.wikimedia.org/r/118942 [01:14:20] (03CR) 10Aklapper: "The commit message now says "Fix previous patches" but that only makes sense if you followed the patchsets in Gerrit. In the log of Git it" [core] - 10https://gerrit.wikimedia.org/r/116230 (owner: 10Deepali) [01:18:38] (03CR) 10Aklapper: thumb.php should output docs if no file specified (033 comments) [core] - 10https://gerrit.wikimedia.org/r/118822 (owner: 10Santosh2201) [02:37:38] (03CR) 10Hoo man: [C: 04-1] "After investigating a little it seems like the 'ext.scribunto' module is loaded only on pages with errors anyway, so this change has no va" [extensions/Scribunto] - 10https://gerrit.wikimedia.org/r/109262 (owner: 10TheDJ) [02:50:23] (03PS1) 10Hoo man: Don't try to (inline load) ext.scribunto if it isn't registered [extensions/Scribunto] - 10https://gerrit.wikimedia.org/r/118944 [02:50:51] (03PS2) 10Hoo man: Don't try to inline load ext.scribunto if it isn't registered [extensions/Scribunto] - 10https://gerrit.wikimedia.org/r/118944 [02:54:47] (03PS1) 10MarkAHershberger: Initial attempt to fix capitalization typo [extensions/BlockAndNuke] - 10https://gerrit.wikimedia.org/r/118945 [04:19:23] (03PS5) 10Santosh2201: thumb.php should output docs if no file specified [core] - 10https://gerrit.wikimedia.org/r/118822 [04:20:43] (03PS1) 10Reedy: Add COPYING [extensions/MSSQLBackCompat] - 10https://gerrit.wikimedia.org/r/118948 [04:21:18] (03CR) 10Reedy: [C: 032 V: 032] "MSSQL database file came from core" [extensions/MSSQLBackCompat] - 10https://gerrit.wikimedia.org/r/118948 (owner: 10Reedy) [04:32:33] (03CR) 1001tonythomas: [C: 04-1] thumb.php should output docs if no file specified (033 comments) [core] - 10https://gerrit.wikimedia.org/r/118822 (owner: 10Santosh2201) [04:43:12] (03PS6) 10Santosh2201: thumb.php should output docs if no file specified [core] - 10https://gerrit.wikimedia.org/r/118822 [04:54:17] (03PS16) 10AndyRussG: WIP Add persistence objects and tests [extensions/Campaigns] (wip/editorcampaigns) - 10https://gerrit.wikimedia.org/r/116221 [05:53:27] ori: https://gerrit.wikimedia.org/r/#/c/118955/ is how I spend my Saturdays ;) [05:54:57] * AaronSchulz reads https://github.com/Snugug/north#development-process [06:01:06] (03PS2) 10Aaron Schulz: [WIP] Added a Redis pool counter class [core] - 10https://gerrit.wikimedia.org/r/118955 [06:19:19] (03Abandoned) 10Pubudu538: Error Msg for missing db username when installing [core] - 10https://gerrit.wikimedia.org/r/118742 (owner: 10Pubudu538) [06:52:30] (03CR) 10IAlex: [C: 04-1] "The hook should also be documented in docs/hooks.txt." (031 comment) [core] - 10https://gerrit.wikimedia.org/r/118942 (owner: 10leucosticte) [06:56:51] (03PS3) 10Aaron Schulz: [WIP] Added a Redis pool counter class [core] - 10https://gerrit.wikimedia.org/r/118955 [07:04:13] (03PS4) 10Aaron Schulz: [WIP] Added a Redis pool counter class [core] - 10https://gerrit.wikimedia.org/r/118955 [07:43:21] Hey!! Is https://bugzilla.wikimedia.org/show_bug.cgi?id=40942 still open?? There has already been a patch submitted for it, which I think works alright! [07:58:07] (03PS5) 10Aaron Schulz: [WIP] Added a Redis pool counter class [core] - 10https://gerrit.wikimedia.org/r/118955 [08:09:23] (03PS1) 1001tonythomas: Added username as parameter to MediaWiki:Comments-reply-to [extensions/Comments] - 10https://gerrit.wikimedia.org/r/118957 [08:09:43] (03PS6) 10Aaron Schulz: [WIP] Added a Redis pool counter class [core] - 10https://gerrit.wikimedia.org/r/118955 [08:23:18] (03PS4) 10Umherirrender: Add a 'revdelete-selected-file' message on Special:RevisionDelete [core] - 10https://gerrit.wikimedia.org/r/115640 [09:10:23] (03PS1) 1001tonythomas: Remove useless [% PROCESS global/variables.none.tmpl %] [wikimedia/bugzilla/modifications] - 10https://gerrit.wikimedia.org/r/118958 [09:38:55] AaronSchulz: AWAKE_ONE and AWAKE_ALL sound like incantations for the summoning of a skeleton army or something :) [09:39:13] const ARISE_MINIONS; [09:54:52] (03CR) 10Nemo bis: "Thanks Pawan Seerwani for your patch. To indicate that there is no need to review it, please click the "abandon" button." [core] - 10https://gerrit.wikimedia.org/r/118806 (owner: 10Pawanseerwani) [10:02:00] (03PS1) 10Ori.livneh: HashRing constructor: accept a list of locations and a 'weight' arg [core] - 10https://gerrit.wikimedia.org/r/118962 [10:05:11] (03PS2) 10Aaron Schulz: HashRing constructor: accept a list of locations and a 'weight' arg [core] - 10https://gerrit.wikimedia.org/r/118962 (owner: 10Ori.livneh) [10:05:15] (03CR) 10Legoktm: [C: 031] "Seems sane to me. What's the planned usecase for this though? Can we just get away with unregistering the hook?" [extensions/BetaFeatures] - 10https://gerrit.wikimedia.org/r/117630 (owner: 10Jforrester) [10:05:20] (03CR) 10Ori.livneh: [C: 031] "The first half or so reads well. Need to get to the second half now." (032 comments) [core] - 10https://gerrit.wikimedia.org/r/118955 (owner: 10Aaron Schulz) [10:05:30] (03PS3) 10Aaron Schulz: HashRing constructor: accept a list of locations and a 'weight' arg [core] - 10https://gerrit.wikimedia.org/r/118962 (owner: 10Ori.livneh) [10:14:06] ori: heh I still have a set of fixes [10:18:54] (03PS1) 10Legoktm: Don't require hook subscribers to know language direction [extensions/BetaFeatures] - 10https://gerrit.wikimedia.org/r/118963 [10:38:04] (03PS1) 10Pastakhov: fix icon from directory (version 0.6.1) [extensions/MultiMaps] - 10https://gerrit.wikimedia.org/r/118964 [10:38:10] (03CR) 10jenkins-bot: [V: 04-1] fix icon from directory (version 0.6.1) [extensions/MultiMaps] - 10https://gerrit.wikimedia.org/r/118964 (owner: 10Pastakhov) [10:41:35] (03PS1) 10Amire80: Remove mention of DefaultSettings.php from the messages [extensions/GWToolset] - 10https://gerrit.wikimedia.org/r/118965 [10:57:38] (03PS1) 10Amire80: Consistent punctuation in the comment messages [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/118967 [11:00:58] (03PS2) 10Pastakhov: fix icon from directory (version 0.6.1) [extensions/MultiMaps] - 10https://gerrit.wikimedia.org/r/118964 [11:01:02] (03CR) 10jenkins-bot: [V: 04-1] fix icon from directory (version 0.6.1) [extensions/MultiMaps] - 10https://gerrit.wikimedia.org/r/118964 (owner: 10Pastakhov) [11:02:27] (03CR) 10Rillke: [C: 031] Added username as parameter to MediaWiki:Comments-reply-to [extensions/Comments] - 10https://gerrit.wikimedia.org/r/118957 (owner: 1001tonythomas) [11:15:10] (03PS1) 10Toniher: Added fix Uckelman - NS detection [extensions/UserFunctions] - 10https://gerrit.wikimedia.org/r/118969 [11:16:09] (03PS3) 10Pastakhov: fix icon from directory (version 0.6.1) [extensions/MultiMaps] - 10https://gerrit.wikimedia.org/r/118964 [11:16:13] (03CR) 10jenkins-bot: [V: 04-1] fix icon from directory (version 0.6.1) [extensions/MultiMaps] - 10https://gerrit.wikimedia.org/r/118964 (owner: 10Pastakhov) [11:32:57] (03Abandoned) 10leucosticte: Add LocallyBlockedProxy hook [core] - 10https://gerrit.wikimedia.org/r/118942 (owner: 10leucosticte) [11:33:54] (03CR) 10Siebrand: [C: 04-1] "Per PS6 comments." [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/87322 (owner: 10Netbrain) [11:34:02] (03PS4) 10Pastakhov: fix icon from directory (version 0.6.1) [extensions/MultiMaps] - 10https://gerrit.wikimedia.org/r/118964 [11:35:12] (03CR) 10Siebrand: [C: 031] "L10n reviewed." [extensions/Flow] - 10https://gerrit.wikimedia.org/r/116501 (owner: 10Matthias Mullie) [11:37:43] (03CR) 10Siebrand: [C: 032] Renamed /job to /jobqueue [core] - 10https://gerrit.wikimedia.org/r/118755 (owner: 10Aaron Schulz) [11:38:16] (03CR) 10Pastakhov: [C: 032] fix icon from directory (version 0.6.1) [extensions/MultiMaps] - 10https://gerrit.wikimedia.org/r/118964 (owner: 10Pastakhov) [11:38:33] (03Merged) 10jenkins-bot: fix icon from directory (version 0.6.1) [extensions/MultiMaps] - 10https://gerrit.wikimedia.org/r/118964 (owner: 10Pastakhov) [11:38:57] (03CR) 10Siebrand: [C: 031] "i18n/L10n reviewed." [core] - 10https://gerrit.wikimedia.org/r/114966 (owner: 10Mjnovice) [11:41:30] (03Merged) 10jenkins-bot: Renamed /job to /jobqueue [core] - 10https://gerrit.wikimedia.org/r/118755 (owner: 10Aaron Schulz) [11:46:03] (03CR) 10Siebrand: [C: 04-1] "i18n/L10n reviewed." (031 comment) [extensions/Comments] - 10https://gerrit.wikimedia.org/r/118957 (owner: 1001tonythomas) [11:46:38] (03CR) 10Siebrand: [C: 032] Consistent punctuation in the comment messages [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/118967 (owner: 10Amire80) [11:46:45] (03Merged) 10jenkins-bot: Consistent punctuation in the comment messages [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/118967 (owner: 10Amire80) [11:47:19] (03CR) 10Siebrand: [C: 032] Remove mention of DefaultSettings.php from the messages [extensions/GWToolset] - 10https://gerrit.wikimedia.org/r/118965 (owner: 10Amire80) [11:47:23] (03Merged) 10jenkins-bot: Remove mention of DefaultSettings.php from the messages [extensions/GWToolset] - 10https://gerrit.wikimedia.org/r/118965 (owner: 10Amire80) [12:15:48] (03Abandoned) 10Pawanseerwani: Appropriate log message for property creation [core] - 10https://gerrit.wikimedia.org/r/118806 (owner: 10Pawanseerwani) [12:46:16] (03CR) 1001tonythomas: "Its a Reply to user, right ? I am not sure where the Gender specific. ?" [extensions/Comments] - 10https://gerrit.wikimedia.org/r/118957 (owner: 1001tonythomas) [12:57:21] (03CR) 10Rillke: [C: 04-1] "But unfortunately, in some languages, the verb's inflection depends on the gender -- a rule of thumb is always including the gender variab" [extensions/Comments] - 10https://gerrit.wikimedia.org/r/118957 (owner: 1001tonythomas) [13:12:18] (03PS2) 1001tonythomas: Added username as parameter to MediaWiki:Comments-reply-to [extensions/Comments] - 10https://gerrit.wikimedia.org/r/118957 [13:27:03] (03CR) 10Rillke: [C: 04-1] Added username as parameter to MediaWiki:Comments-reply-to (031 comment) [extensions/Comments] - 10https://gerrit.wikimedia.org/r/118957 (owner: 1001tonythomas) [13:37:25] (03CR) 10Rillke: "Please have a look at https://gerrit.wikimedia.org/r/#/c/77898/" [extensions/Comments] - 10https://gerrit.wikimedia.org/r/118957 (owner: 1001tonythomas) [13:40:21] (03CR) 10Rillke: "I would have committed a patch if your extension would have worked with SQLite ..." [extensions/Comments] - 10https://gerrit.wikimedia.org/r/118957 (owner: 1001tonythomas) [13:45:17] (03PS3) 1001tonythomas: Added username as parameter to MediaWiki:Comments-reply-to [extensions/Comments] - 10https://gerrit.wikimedia.org/r/118957 [15:21:48] (03Abandoned) 10TheDJ: [Do not merge] CodeEditor should not load WikiEditor if disabled [extensions/CodeEditor] - 10https://gerrit.wikimedia.org/r/106685 (owner: 10TheDJ) [15:38:57] grrr [16:26:29] (03CR) 10TheDJ: "@Ori" [extensions/CodeEditor] - 10https://gerrit.wikimedia.org/r/108050 (owner: 10TheDJ) [16:40:07] (03CR) 10Rillke: [C: 04-1] "If I would have to fix this, I would add a data-user-gender=\"[YOUR CODE HERE]\" to" (032 comments) [extensions/Comments] - 10https://gerrit.wikimedia.org/r/118957 (owner: 1001tonythomas) [16:48:13] (03PS1) 10Inchikutty: Improving zoom of embedded map, on address search[WIP] [extensions/UploadWizard] (osm) - 10https://gerrit.wikimedia.org/r/118978 [16:50:46] (03CR) 10Ori.livneh: "@TheDJ: Sure, ping me on IRC to coordinate." [extensions/CodeEditor] - 10https://gerrit.wikimedia.org/r/108050 (owner: 10TheDJ) [17:13:08] does anyone know if we have JS methods to make a url absolute ? [17:14:00] thedj: sure: Math.abs() [17:14:02] :D [17:14:22] hehe [17:14:34] I think there is one, trying to find it [17:15:20] i don't think we have one in core at least. [17:15:37] * YuviPanda wonders what happens if you do url < 0 ? -url : url  [17:15:49] what is the fragment that you are trying to construct an absolute URL from? [17:15:56] is it a path component, query string, ? [17:15:59] //bits.wikimedia.org [17:16:11] but we can't rely on that for 3rd parties of course. [17:16:49] * thedj wants to curse at the webworkers working group... [17:18:01] Object.keys( window ).filter( function ( k ) { return /bits/i.test( window[k] ); } ); [17:18:31] mw.config.get('wgExtensionAssetsPath'), mw.config.get('wgLoadScript') [17:19:19] yup, there is my problem :D [17:19:26] thedj: https://github.com/atdt/wob.js?utm_source=javascriptweekly&utm_medium=email [17:25:04] i can't believe the best way to 'fully qualify' a url is to create an image object out of it... [17:26:16] https://bugzilla.wikimedia.org/show_bug.cgi?id=62713 [17:30:24] it's annoying, we never really need this, because we deal with 'known' configurations, but because they put this into the spec, now suddenly, you are screwed [17:49:42] (03CR) 10Parent5446: [C: 032] Move variable definitions near to where they are used [core] - 10https://gerrit.wikimedia.org/r/118813 (owner: 10IAlex) [17:53:26] (03CR) 10Aklapper: thumb.php should output docs if no file specified (031 comment) [core] - 10https://gerrit.wikimedia.org/r/118822 (owner: 10Santosh2201) [17:54:40] (03Merged) 10jenkins-bot: Move variable definitions near to where they are used [core] - 10https://gerrit.wikimedia.org/r/118813 (owner: 10IAlex) [17:55:35] ori: got it. realized this is only a problem for protocol relativ links to begin with, so why worry about anything more than that. [17:56:14] since other relative links are on the same server (and thus don't have to use CORS trickery to begin with) [18:04:37] thedj: when is one type of URL generated, and when the other? [18:04:53] that is, protocol relative vs. path-relative [18:05:51] if you are on the same server by default, wgExtensionAssetsPath defaults to wgServer / extensions to begin with. [18:06:04] but in theory you could set it to something path or server relative of course [18:06:35] if you use static server, you are usually either fully qualified or protocol relative. [18:09:39] there's https://git.wikimedia.org/blob/mediawiki%2Fcore.git/HEAD/resources%2Fmediawiki%2Fmediawiki.Uri.js too btw [18:09:56] but what do you need to do differently if it's a separate domain? [18:10:32] I can't have importScripts( '//bits.wikimedia.org..' ) in the webworker [18:10:55] webworker only allow for importScripts( 'https//bits.wikimedia.org..' ); [18:11:29] you could devise a simple message-passing rpc for the webworker to request that the main page fetch a document and send it as a message [18:12:39] and then exec that ? [18:12:42] myWorker.addEventListener( 'importScript', function ( scriptContent ) { /* execute the script */ } ); [18:13:23] myWorker.postMessage( 'importScript', scriptSrc ); [18:13:24] etc. [18:13:32] there are some useful examples on [18:13:39] but i beat them all to it with [18:13:44] :P [18:14:41] you may also want to look at which is an abandoned (but working) patch to have resourceloader load modules in a webworker [18:15:10] specifically the bits here: https://gerrit.wikimedia.org/r/#/c/89375/1/resources/mediawiki/mediawiki.js [18:16:05] the blobifyScript and workerFunction are things you could reuse here potentially [18:16:45] yeah i use that already, but simply to do an importScripts. [18:17:18] i guess i need to add a downloader instead and parse those results.. [18:18:12] or just hack the url.. [18:42:22] Unsurprisingly, I updated kernel and vagrant was broken again [18:42:42] Nemo_bis: bug report plz [18:43:01] and if you're unsure about whether a log portion is relevant, err on the side of including it [18:44:28] (03CR) 10Yuvipanda: [C: 04-2] "git fetch takes a URL argument. So you can just do 'git fetch '. Then you can use the variable FETCH_HEAD to checkout the " [vagrant] - 10https://gerrit.wikimedia.org/r/118653 (owner: 10Wctaiwan) [18:47:51] hi wctaiwan [18:47:51] running git fetch $url updates the local branch from $url, but I don't think it touches the remote branch the local branch was originally tracking [18:48:19] wctaiwan: hmm, right. that's true. but why does that matter? [18:48:34] wctaiwan: also this patch has the 'can leave repo in inconsistent state' issue, where your remote URL suddenly is http and not ssh [18:48:35] because then git status complains about the local branch being ahead [18:48:41] (03PS7) 10Santosh2201: thumb.php should output docs if no file specified [core] - 10https://gerrit.wikimedia.org/r/118822 [18:49:26] wctaiwan: ah, hmm. [18:49:30] what do you mean suddenly? [18:49:37] I see at least two issues with the approach [18:49:48] 1. if the command dies halfway, the old remote url is lost and [18:49:57] wctaiwan: like, I am pushing code, all fine. Then I run the vagrant git-update command, something somewhere fails and I can't push anymore because the remote URL has changed [18:50:14] 2. I'm not sure if it's safe to do git remote set-url (if it's guaranteed to change the one I want to change) [18:50:38] if allowed to run to completion, the script _should_ restore the original remote URL, whatever it was [18:50:53] it just changes it for the duration of the pull [18:51:04] wctaiwan: indeed, but we won't know if it will run to completion :) Also it just has to fail once for the url to be lost [18:51:06] but it's true that if the command is terminated when it's pulling, the remote dies. [18:51:12] yeah [18:51:16] wctaiwan: hmm, I might have a solution. moment [18:51:20] okay [18:52:09] ori: there is nothing we can do, virtualbox is just b0rked on fedora [18:52:56] well, I could stop updating the kernel from the official repo and fetch it from RPMfusion, perhaps, but I'm not going to [18:53:24] wctaiwan: hmm, I can't figure a way out to do this properly :( ask ori perhaps? [18:53:40] * wctaiwan pokes ori  [18:53:52] (03PS1) 10TheDJ: Update ACE to Mar 16, 2014 [extensions/CodeEditor] - 10https://gerrit.wikimedia.org/r/118979 [18:54:12] (03PS1) 10TheDJ: Work around a problem with web workers in ACE [extensions/CodeEditor] - 10https://gerrit.wikimedia.org/r/118980 [18:54:45] YuviPanda: yeah, before I just did git remote update after running the script, but that doesn't necessarily work inside vagrant, namely it doesn't if your SSH keys are on the host and not in vagrant [18:55:01] wctaiwan: right. Perhaps vagrant git-update should just run on the host. [18:55:02] ? [18:55:08] which is why we need the pull $url workaround in the first place really [18:55:21] wctaiwan: then it'll need to be platform dependent, but that shouldn't be too hard... [18:55:24] if we can have it do that it'd be great, but can we? [18:55:38] wctaiwan: why not? [18:55:55] I don't know. Like you said, platform dependence. [18:56:15] it's a shell script so if you're going to run it on windows you'd need to rewrite it in... python? People need python for gerrit so they should have that. [18:57:04] wctaiwan: well, the rest of the vagrant plugins are in ruby :D [18:57:18] wctaiwan: vagrant itself is in ruby, so if they have vagrant running, it means they have ruby running [18:57:32] hmm okay [18:57:45] but yeah, we probably need a different workaround [18:58:12] wctaiwan: rewriting git remote URLs doesn't sound like a good step, in general terms [18:58:16] my patch works well enough for me since I'm willing to gamble my computer won't die in the middle of running the command and I don't have multiple urls for one remote, but it's not ideal :P [18:58:21] I agree [18:58:44] but it's the only approach I see if you want to work around SSH [18:59:52] wctaiwan: indeed. plus it might be weirder for me, since I am not really on branches much :D (reflogs / checkouts woo!) [18:59:59] YuviPanda: alternatively we could just make it so that it runs "git pull" if the url isn't ssh:// [19:00:14] and if it _is_ ssh use the old approach [19:00:25] that way at least remotes you don't commit to would not have the issue [19:00:31] wctaiwan: we could also disable the 'local branch is ahead of remote by xxxx commits' :P [19:00:45] uh, no, bad idea >.> [19:01:07] wctaiwan: heh, why? [19:01:11] (03PS7) 10UltrasonicNXT: WIP - Rewrite [extensions/WikiForum] - 10https://gerrit.wikimedia.org/r/116258 [19:02:03] just because you're ignoring it doesn't mean git doesn't see the two as out of sync [19:02:07] you'd just have issues down the road.. [19:02:36] wctaiwan: like what? [19:02:47] wctaiwan: I'm just curious, esp. with our gerrit workflow [19:03:56] I'm not sure, but it just seems dangerous to me. [19:04:28] I mean, I think git status should be accurate--otherwise this patch wasn't needed at all. Just mentally ignore the message since you know why it's happening [19:04:57] [15:00:14] YuviPanda: alternatively we could just make it so that it runs "git pull" if the url isn't ssh:// [15:00:29] and if it _is_ ssh use the old approach [19:05:06] what do you think of that, as a patch implementing a partial fix? [19:05:27] that way it's still broken for ssh repos, but it'd work for HTTPS repos. [19:05:32] wctaiwan: should, yes. that definitely doesn't sound like a -2 :) [19:06:04] okay, I'll upload that as a patchset then. (Later, working on something else right now) [19:06:09] unless ori has better ideas :P [19:06:17] (03PS1) 10Danorton: Bug 62713 - fractional second wfDebugLog timestamp [core] - 10https://gerrit.wikimedia.org/r/118981 [19:06:31] wctaiwan: heh, you mean 'when ori has better ideas' :P [19:06:45] oh fair point :P [19:06:52] wctaiwan: :) [19:07:04] ALL HAIL ORI [19:22:19] (03PS2) 10Danorton: Bug 62713 - fractional second wfDebugLog timestamp [core] - 10https://gerrit.wikimedia.org/r/118981 [19:25:39] (03PS7) 10Aaron Schulz: [WIP] Added a Redis pool counter class [core] - 10https://gerrit.wikimedia.org/r/118955 [19:28:54] (03PS1) 10Aaron Schulz: Moved ProcessCacheLRU to /libs [core] - 10https://gerrit.wikimedia.org/r/118982 [19:30:44] (03CR) 10jenkins-bot: [V: 04-1] Moved ProcessCacheLRU to /libs [core] - 10https://gerrit.wikimedia.org/r/118982 (owner: 10Aaron Schulz) [19:34:09] (03PS2) 10Aaron Schulz: Moved ProcessCacheLRU to /libs [core] - 10https://gerrit.wikimedia.org/r/118982 [19:39:27] (03CR) 10jenkins-bot: [V: 04-1] Moved ProcessCacheLRU to /libs [core] - 10https://gerrit.wikimedia.org/r/118982 (owner: 10Aaron Schulz) [19:45:45] (03PS2) 10Wctaiwan: Use 'git pull' for non-SSH URLs in run-git-update [vagrant] - 10https://gerrit.wikimedia.org/r/118653 [19:48:21] (03PS3) 10Aaron Schulz: Moved ProcessCacheLRU to /libs [core] - 10https://gerrit.wikimedia.org/r/118982 [19:54:12] (03PS3) 10Wctaiwan: Use 'git pull' for non-SSH URLs in run-git-update [vagrant] - 10https://gerrit.wikimedia.org/r/118653 [20:00:52] (03CR) 10Yuvipanda: "Seems better to me :) Removing -2." [vagrant] - 10https://gerrit.wikimedia.org/r/118653 (owner: 10Wctaiwan) [20:26:31] (03PS4) 10Rillke: Added username as parameter to MediaWiki:Comments-reply-to [extensions/Comments] - 10https://gerrit.wikimedia.org/r/118957 (owner: 1001tonythomas) [20:34:11] (03PS1) 10Rillke: SQLite compatibility by adding UNIX_TMESTAMP shim [extensions/Comments] - 10https://gerrit.wikimedia.org/r/118988 [20:43:50] what was the solution to mw-vagrant hanging on first boot? I remember it was because Vagrant's filesystem access speed is limited or something [20:45:44] KillerWalrus: have you tried turning it off and on? :) [20:45:59] (03CR) 10AndyRussG: [C: 04-1] "Good start! The resulting notifications, in both Web and e-mail versions, look quite nice. Good work on the change in ArticleStore, too." (036 comments) [extensions/EducationProgram] - 10https://gerrit.wikimedia.org/r/118101 (owner: 10Jlloyd) [20:48:09] YuviPanda: did a Ctrl+C and vagrant halt, lemme check again =D [20:48:19] KillerWalrus: :) [20:50:12] (03CR) 10Rillke: SQLite compatibility by adding UNIX_TMESTAMP shim (031 comment) [extensions/Comments] - 10https://gerrit.wikimedia.org/r/118988 (owner: 10Rillke) [20:55:10] (03CR) 10Rillke: [C: 04-1] "oops, this slipped through some other commit, sorry!" [extensions/Comments] - 10https://gerrit.wikimedia.org/r/118957 (owner: 1001tonythomas) [20:59:35] (03CR) 10Aaron Schulz: [C: 032] New 'profileerror' log group for profiling errors [core] - 10https://gerrit.wikimedia.org/r/118937 (owner: 10IAlex) [21:03:21] (03Merged) 10jenkins-bot: New 'profileerror' log group for profiling errors [core] - 10https://gerrit.wikimedia.org/r/118937 (owner: 10IAlex) [21:07:05] (03PS2) 10Krinkle: SpecialCentralAutoLogin: Clean up javascript [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/118429 [21:07:14] (03PS3) 10Krinkle: SpecialCentralAutoLogin: Move javascript to separate files for linting [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/118430 [21:12:55] (03CR) 10Jack Phoenix: [C: 04-1] "The code and the approach here are OK; the reason why I'm giving this a -1 is a tad bit more complicated." [extensions/Comments] - 10https://gerrit.wikimedia.org/r/118988 (owner: 10Rillke) [21:15:49] (03PS1) 10TheDJ: CodeEditor: Add a status bar with line and columncount [extensions/CodeEditor] - 10https://gerrit.wikimedia.org/r/118989 [21:17:07] (03PS4) 10Krinkle: SpecialCentralAutoLogin: Move javascript to separate files for linting [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/118430 [21:17:14] (03CR) 10Krinkle: SpecialCentralAutoLogin: Move javascript to separate files for linting (032 comments) [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/118430 (owner: 10Krinkle) [21:22:23] if I clone mediawiki/core from the host machine, would that make Puppet still provision it? [21:23:11] (03CR) 10Rillke: "Jack, I won't have the time caring about all that. Either trash this commit, please or take care of it." [extensions/Comments] - 10https://gerrit.wikimedia.org/r/118988 (owner: 10Rillke) [21:23:18] (03PS6) 10Krinkle: mediawiki.api: Use Promise.then instead of manual Deferred wrap [core] - 10https://gerrit.wikimedia.org/r/116957 [21:23:26] KillerWalrus: should, yeah. [21:24:15] (03PS7) 10Krinkle: mediawiki.api: Use Promise.then instead of manual Deferred wrap [core] - 10https://gerrit.wikimedia.org/r/116957 [21:24:29] (03CR) 10Krinkle: mediawiki.api: Use Promise.then instead of manual Deferred wrap (033 comments) [core] - 10https://gerrit.wikimedia.org/r/116957 (owner: 10Krinkle) [21:39:26] (03PS5) 10Rillke: Added username as parameter to MediaWiki:Comments-reply-to [extensions/Comments] - 10https://gerrit.wikimedia.org/r/118957 (owner: 1001tonythomas) [21:42:08] (03CR) 10Rillke: "Tested locally replacing the English message with" [extensions/Comments] - 10https://gerrit.wikimedia.org/r/118957 (owner: 1001tonythomas) [21:46:18] (03CR) 10Bartosz Dziewoński: [C: 032] mediawiki.api: Use Promise.then instead of manual Deferred wrap [core] - 10https://gerrit.wikimedia.org/r/116957 (owner: 10Krinkle) [21:46:27] (03PS2) 10Bartosz Dziewoński: mediawiki.api: Documentation and typo cleanup [core] - 10https://gerrit.wikimedia.org/r/118731 [21:48:37] (03Abandoned) 10Rillke: SQLite compatibility by adding UNIX_TMESTAMP shim [extensions/Comments] - 10https://gerrit.wikimedia.org/r/118988 (owner: 10Rillke) [21:51:03] (03Merged) 10jenkins-bot: mediawiki.api: Use Promise.then instead of manual Deferred wrap [core] - 10https://gerrit.wikimedia.org/r/116957 (owner: 10Krinkle) [22:36:45] (03CR) 10Aklapper: thumb.php should output docs if no file specified (031 comment) [core] - 10https://gerrit.wikimedia.org/r/118822 (owner: 10Santosh2201) [22:48:28] (03PS1) 10TheDJ: Remove unneeded show() in WikiEditor toolbar [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/118992 [22:49:34] (03PS1) 10TheDJ: Improve the CodeEditor toolbar [extensions/CodeEditor] - 10https://gerrit.wikimedia.org/r/118993 [22:55:56] (03PS4) 10TheDJ: [WIP] Toggle invisible characters in CodeEditor [extensions/CodeEditor] - 10https://gerrit.wikimedia.org/r/104512 [23:06:05] (03CR) 10PleaseStand: [C: 04-1] Moved ProcessCacheLRU to /libs (031 comment) [core] - 10https://gerrit.wikimedia.org/r/118982 (owner: 10Aaron Schulz) [23:21:32] (03PS1) 10Aude: Allow use of phpunit.phar with MediaWiki's phpunit.php test entry point [core] - 10https://gerrit.wikimedia.org/r/118997 [23:22:30] (03PS2) 10Aude: Allow use of phpunit.phar with MediaWiki's phpunit.php test entry point [core] - 10https://gerrit.wikimedia.org/r/118997 [23:27:03] (03PS3) 10Aude: Allow use of phpunit.phar with MediaWiki's phpunit.php test entry point [core] - 10https://gerrit.wikimedia.org/r/118997 [23:28:28] aude: Wouldn't it be smart to add it to gitignore so that users can just drop it into tests/phpunit/ (and make phpunit.php use that) [23:29:09] (03PS1) 10TheDJ: Fix JSHint for CodeEditor [extensions/CodeEditor] - 10https://gerrit.wikimedia.org/r/118998 [23:30:20] hoo: might work, but i rather had phpunit installed one place globally [23:30:36] We should support both [23:30:37] have* [23:30:58] ok... [23:32:52] (03PS4) 10Aaron Schulz: Moved ProcessCacheLRU to /libs [core] - 10https://gerrit.wikimedia.org/r/118982 [23:33:26] (03PS4) 10Aude: Allow use of phpunit.phar with MediaWiki's phpunit.php test entry point [core] - 10https://gerrit.wikimedia.org/r/118997 [23:33:43] there ^ [23:33:58] gah [23:35:09] (03PS5) 10Aude: Allow use of phpunit.phar with MediaWiki's phpunit.php test entry point [core] - 10https://gerrit.wikimedia.org/r/118997 [23:35:53] looking [23:36:41] (03PS6) 10Aude: Allow use of phpunit.phar with MediaWiki's phpunit.php test entry point [core] - 10https://gerrit.wikimedia.org/r/118997 [23:37:30] where is git inore? [23:37:33] ignore* [23:37:50] aude: main foolder [23:38:09] (03CR) 10Hoo man: Allow use of phpunit.phar with MediaWiki's phpunit.php test entry point (031 comment) [core] - 10https://gerrit.wikimedia.org/r/118997 (owner: 10Aude) [23:38:22] old PS, sorry... but still current [23:38:30] it's like gerrit undid my patch [23:38:51] commit message updates can be nasty [23:39:02] they don't have anything like edit-conflict detection [23:39:21] (03PS7) 10Aude: Allow use of phpunit.phar with MediaWiki's phpunit.php test entry point [core] - 10https://gerrit.wikimedia.org/r/118997 [23:41:30] (03PS8) 10Aude: Allow use of phpunit.phar with MediaWiki's phpunit.php test entry point [core] - 10https://gerrit.wikimedia.org/r/118997 [23:41:42] that should be it, unless someone has a different idea for this [23:42:13] (03CR) 10Hoo man: [C: 031] Allow use of phpunit.phar with MediaWiki's phpunit.php test entry point [core] - 10https://gerrit.wikimedia.org/r/118997 (owner: 10Aude) [23:42:16] * aude commented in the bug report [23:42:16] yep :) [23:42:28] there's a bug? [23:42:33] there is [23:42:35] Not noted in the commit message... :P [23:42:46] gah, eaten [23:43:37] gerrit is hungry [23:43:49] (03PS9) 10Aude: Allow use of phpunit.phar with MediaWiki's phpunit.php test entry point [core] - 10https://gerrit.wikimedia.org/r/118997 [23:43:54] cookie gap there as well, I guess :D [23:44:55] (03CR) 10Hoo man: [C: 031] "Would prefer a second pair of eyes in order to have a look at the new configuration variable." [core] - 10https://gerrit.wikimedia.org/r/118997 (owner: 10Aude) [23:45:17] even sebastian commented in the bug, so maybe he will review [23:45:41] oh, wow... never seen him on BZ before [23:46:10] as mentioned, this is a workaround and perhaps the bootstrap can be reworked to be included with phpunit --bootstrap [23:48:31] anyway... good night [23:48:41] goodnight [23:49:43] (03CR) 10Jforrester: [C: 031] Don't require hook subscribers to know language direction [extensions/BetaFeatures] - 10https://gerrit.wikimedia.org/r/118963 (owner: 10Legoktm) [23:51:07] (03CR) 10Jforrester: "> Seems sane to me. What's the planned use case for this though?" [extensions/BetaFeatures] - 10https://gerrit.wikimedia.org/r/117630 (owner: 10Jforrester)