[00:01:22] <^d> \o/ [00:03:33] (03CR) 10Werdna: "Yeah, right. Like this. :-P." [extensions/Flow] - 10https://gerrit.wikimedia.org/r/118566 (owner: 10Matthias Mullie) [00:03:49] (03CR) 10Ori.livneh: "@Krinkle: makes sense. I'll try to make the release notes update comprehensive." [core] - 10https://gerrit.wikimedia.org/r/117672 (owner: 10Ori.livneh) [00:03:52] hey ^d, how's life? [00:04:05] <^d> life's good. busy! [00:04:07] <^d> you? [00:04:29] (03CR) 10Werdna: "I see you've done that in change 118566." [extensions/Flow] - 10https://gerrit.wikimedia.org/r/118565 (owner: 10Matthias Mullie) [00:08:41] (03PS8) 10Jdlrobson: WIP: Rewrite the navigation links under the heading [extensions/VectorBeta] - 10https://gerrit.wikimedia.org/r/117903 [00:09:11] (03PS9) 10Jdlrobson: WIP: Rewrite the navigation links under the heading [extensions/VectorBeta] - 10https://gerrit.wikimedia.org/r/117903 [00:11:35] (03PS2) 10Jforrester: Update OOjs UI to v0.1.0-pre (ac0cc69508) [core] - 10https://gerrit.wikimedia.org/r/118640 [00:14:37] (03CR) 10Krinkle: [C: 032] Update OOjs UI to v0.1.0-pre (ac0cc69508) [core] - 10https://gerrit.wikimedia.org/r/118640 (owner: 10Jforrester) [00:17:50] (03PS1) 10Mwalker: Adding WorldPay forms [core] (fundraising/REL1_22) - 10https://gerrit.wikimedia.org/r/118646 [00:18:52] (03Merged) 10jenkins-bot: Update OOjs UI to v0.1.0-pre (ac0cc69508) [core] - 10https://gerrit.wikimedia.org/r/118640 (owner: 10Jforrester) [00:25:41] ori, any idea what can cause a "Schema fetch failure: HTTP Error 400: Bad Request"? it happens for me only for one particular schema (PersonalBar) [00:25:44] ori, nevermind, missing dependency in RL [00:28:51] hmph [00:28:51] string(60) "Failed to connect to localhost port 8000: Connection refused" [00:29:27] andrew-macbook:tests andrew$ nc -zv localhost 8000 [00:29:27] nc: connectx to localhost port 8000 (tcp) failed: Connection refused [00:29:27] Connection to localhost port 8000 [tcp/irdmi] succeeded! [00:29:28] weiird [00:31:39] (03CR) 10Bsitu: Cache created objects within the mapper (032 comments) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/113527 (owner: 10EBernhardson) [00:37:53] seriously, fucking macports [00:38:58] fuck it, I'm switching to vagrant [00:40:02] (03CR) 10Jdlrobson: "Good catch. Not sure how I missed that!" [core] - 10https://gerrit.wikimedia.org/r/118589 (owner: 10Jdlrobson) [00:44:19] seriously, I should not have to do this every time I upgrade Major OS version: http://webcache.googleusercontent.com/search?q=cache%3Ahttps%3A%2F%2Ftrac.macports.org%2Fwiki%2FMigration&oq=cache%3Ahttps%3A%2F%2Ftrac.macports.org%2Fwiki%2FMigration&aqs=chrome..69i57j69i58.896j0j4&sourceid=chrome&espv=210&es_sm=91&ie=UTF-8 [00:44:25] aaaand the wiki is down too [00:48:04] <^d> werdna: macports? wtf? [00:48:04] <^d> homebrew dude. [00:48:32] (03PS6) 10JGonera: [WIP] Add click tracking to compact personal bar [extensions/VectorBeta] - 10https://gerrit.wikimedia.org/r/117138 [00:48:35] (03CR) 10jenkins-bot: [V: 04-1] [WIP] Add click tracking to compact personal bar [extensions/VectorBeta] - 10https://gerrit.wikimedia.org/r/117138 (owner: 10JGonera) [00:48:36] I installed macports years ago [00:48:45] should probably migrate hey [00:50:04] ^d: any idea how one migrates to homebrew? [00:53:48] hahaha [00:53:48] Homebrew — MacPorts driving you to drink? Try Homebrew! [00:53:50] (03PS1) 10Manybubbles: Start building suggest field combined didyoumean [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/118650 [00:53:52] (03PS1) 10Manybubbles: Use combined didyoumean [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/118651 [00:54:42] (03CR) 10Manybubbles: [C: 04-1] "No merging until after I860e7c7ba682111f94eecbe907a937f9618c8465 is released." [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/118651 (owner: 10Manybubbles) [00:56:17] (03PS5) 10Manybubbles: Get Cirrus's browser tests working [vagrant] - 10https://gerrit.wikimedia.org/r/115679 [00:57:16] (03CR) 10Manybubbles: "I've been using this for weeks for all of my Cirrus development. I'd love to get it merged. If it needs fixing I'm happy to change thing" [vagrant] - 10https://gerrit.wikimedia.org/r/115679 (owner: 10Manybubbles) [00:57:35] (03CR) 10Bsitu: Fix error page titles (031 comment) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/116631 (owner: 10Spage) [00:58:05] (03PS2) 10Spage: Add integration test for flowthank API [extensions/Thanks] - 10https://gerrit.wikimedia.org/r/118461 (owner: 10Bencmq) [00:58:22] (03CR) 10jenkins-bot: [V: 04-1] Add integration test for flowthank API [extensions/Thanks] - 10https://gerrit.wikimedia.org/r/118461 (owner: 10Bencmq) [01:01:16] (03CR) 10Springle: "Schema change done." [extensions/Flow] - 10https://gerrit.wikimedia.org/r/116115 (owner: 10Matthias Mullie) [01:01:53] (03CR) 10Springle: "Schema change done." [extensions/Flow] - 10https://gerrit.wikimedia.org/r/116226 (owner: 10Bsitu) [01:05:30] (03CR) 10GWicke: [C: 032] Fix minor typo in parser tests error message. [core] - 10https://gerrit.wikimedia.org/r/118609 (owner: 10Cscott) [01:10:11] (03Merged) 10jenkins-bot: Fix minor typo in parser tests error message. [core] - 10https://gerrit.wikimedia.org/r/118609 (owner: 10Cscott) [01:13:24] (03PS1) 10Wctaiwan: Temporarily change remote URL during git-update [vagrant] - 10https://gerrit.wikimedia.org/r/118653 [01:16:11] (03CR) 10Bsitu: Show who moderated the most recent revision (031 comment) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/117382 (owner: 10EBernhardson) [01:16:32] (03CR) 10Wctaiwan: "I tested the code once and it seems to work, but I haven't tested extensively. In addition, I am not sure it is safe--that is, it wouldn't" [vagrant] - 10https://gerrit.wikimedia.org/r/118653 (owner: 10Wctaiwan) [01:25:01] (03PS3) 10Bencmq: Add integration test for flowthank API [extensions/Thanks] - 10https://gerrit.wikimedia.org/r/118461 [01:53:49] (03CR) 10Skizzerz: [C: 031] "From a cursory glance this looks fine; nothing should break changing from binary(14) to varbinary(14). The one actual timestamp field may " [core] - 10https://gerrit.wikimedia.org/r/110949 (owner: 10Gerrit Patch Uploader) [02:07:19] (03PS1) 10Ori.livneh: Emit $wgSearchType as JavaScript config variable [core] - 10https://gerrit.wikimedia.org/r/118655 [02:08:22] (03CR) 10Manybubbles: [C: 031] Emit $wgSearchType as JavaScript config variable [core] - 10https://gerrit.wikimedia.org/r/118655 (owner: 10Ori.livneh) [02:10:36] (03CR) 10Daniel Friesen: [C: 04-1] "We already have standard classes and IDs like #mw-content-text (implicitly output around body content) and .mw-body (any skin that opts in" [core] - 10https://gerrit.wikimedia.org/r/118589 (owner: 10Jdlrobson) [02:10:47] (03CR) 10Chad: [C: 032] Emit $wgSearchType as JavaScript config variable [core] - 10https://gerrit.wikimedia.org/r/118655 (owner: 10Ori.livneh) [02:14:20] (03Merged) 10jenkins-bot: Emit $wgSearchType as JavaScript config variable [core] - 10https://gerrit.wikimedia.org/r/118655 (owner: 10Ori.livneh) [02:15:08] (03PS4) 10Bencmq: Browser test for Thank feature in Flow [extensions/Flow] - 10https://gerrit.wikimedia.org/r/117882 [02:19:33] (03PS1) 10Gerrit Patch Uploader: Add namespace aliases for Serbo-Croatian (sh) [core] - 10https://gerrit.wikimedia.org/r/118656 [02:19:38] (03CR) 10Gerrit Patch Uploader: "This commit was uploaded using the Gerrit Patch Uploader [1]." [core] - 10https://gerrit.wikimedia.org/r/118656 (owner: 10Gerrit Patch Uploader) [02:23:07] (03PS1) 10Ori.livneh: Emit $wgSearchType as JavaScript config variable [core] (wmf/1.23wmf17) - 10https://gerrit.wikimedia.org/r/118657 [02:23:34] (03PS1) 10Ori.livneh: Emit $wgSearchType as JavaScript config variable [core] (wmf/1.23wmf18) - 10https://gerrit.wikimedia.org/r/118658 [02:23:39] ^d: ^ [02:24:17] (03CR) 10Chad: [C: 032] Emit $wgSearchType as JavaScript config variable [core] (wmf/1.23wmf18) - 10https://gerrit.wikimedia.org/r/118658 (owner: 10Ori.livneh) [02:24:37] (03CR) 10Chad: [C: 032] Emit $wgSearchType as JavaScript config variable [core] (wmf/1.23wmf17) - 10https://gerrit.wikimedia.org/r/118657 (owner: 10Ori.livneh) [02:29:33] (03Merged) 10jenkins-bot: Emit $wgSearchType as JavaScript config variable [core] (wmf/1.23wmf18) - 10https://gerrit.wikimedia.org/r/118658 (owner: 10Ori.livneh) [02:29:47] (03Merged) 10jenkins-bot: Emit $wgSearchType as JavaScript config variable [core] (wmf/1.23wmf17) - 10https://gerrit.wikimedia.org/r/118657 (owner: 10Ori.livneh) [02:33:02] (03CR) 10Kolega2357: [C: 031] Add namespace aliases for Serbo-Croatian (sh) [core] - 10https://gerrit.wikimedia.org/r/118656 (owner: 10Gerrit Patch Uploader) [02:34:14] (03CR) 10PiRSquared17: [C: 031] Make Special:Whatlinkshere.php transcludable [core] - 10https://gerrit.wikimedia.org/r/106625 (owner: 10AalekhN) [03:06:06] is anyone else's vagrant unusually slow on osx? [03:06:38] simple PHP stuff takes 10x as long on vagrant as it does on my host machine directly [03:07:05] I even gave it 2GB of RAM and 2 CPU cores to use at 100% [03:11:46] man, vagrant takes *forever* to provision [03:11:50] like, an hour or so [03:15:08] (03CR) 10Springle: "@PleaseStand: Whether VARBINARY actually wastes DB space overall compared to BINARY would need analysis, taking both the frequency of <14 " [core] - 10https://gerrit.wikimedia.org/r/110949 (owner: 10Gerrit Patch Uploader) [03:23:48] werdna: superm401 is working on automating the provisioning process so that it requires pulling fewer dependencies [03:25:51] ori: it's been provisioning for 1h13 so far… [03:26:07] werdna: hit ctrl+c to abort it twice [03:26:16] looks like it's stuck on this [03:26:16] vagrant 19488 0.0 1.3 56684 10024 ? Ss 03:12 0:00 git clone --recursive --branch master https://gerrit.wikimedia.org/r/p/mediawiki/extensions/VisualEditor.git /vagrant/mediawiki/extensions/VisualEditor [03:26:36] yeah [03:26:54] git clones inside the vm are super slow for some reason [03:26:59] hmm [03:27:09] it's a combination of the file operations that git performs and the behavior of virtualbox shared folders [03:27:14] do: [03:27:20] (after breaking the puppet run) [03:27:26] I kind of want to run a git proxy on my own laptop / raspi at home [03:27:27] in the vagrant folder [03:27:32] oh I see, it's just too many layers of abstraction [03:27:33] git clone https://gerrit.wikimedia.org/r/mediawiki/core mediawiki [03:28:02] fatal: destination path 'mediawiki' already exists and is not an empty directory. [03:28:02] :-P [03:28:07] ok, that's fine [03:28:12] cd mediawiki/extensions [03:28:23] git clone --recursive --branch master https://gerrit.wikimedia.org/r/p/mediawiki/extensions/VisualEditor.git VisualEditor [03:28:43] I assume after rm -rf VisualEditor [03:28:47] yeah [03:29:02] and I guess I'll do the same for Flow and whatever else [03:29:15] is this your initial provisioning run? [03:29:23] yep [03:29:35] macports went belly up so I decided it was time to start using vagrant [03:30:31] if it's your first provisioning run, your machine is running with an older version of VritualBox Guest Additions [03:30:39] which includes the driver that facilitates file sharing between the guest and host [03:31:05] so run 'vagrant vbguest' [03:31:11] to check if it's running hte latest [03:31:13] I thought it'd already updated [03:31:18] it may have [03:31:28] GuestAdditions 4.3.8 running --- OK. [03:31:30] looks fine [03:31:37] oh, ok. that bit is fine then [03:31:44] i wonder why git cloning is slow effing slow then. urgh. [03:32:02] well, anyway, that trick will work (cloning in your host environment and having puppet just discover that) [03:32:10] but it's a shame that it takes resorting to that, i take that to be a failure of the setup [03:32:46] yeah, maybe the provision script can somehow do that cloning externally itself [03:33:13] my laptop also hasn't been the fastest today [03:33:52] oh also ffi failed to build [03:33:59] I thought 768M would be enough… [03:39:22] holy hell, VE is a HUGE git repo [03:57:54] ori: one more thing… unit tests aren't running properly :/ [03:58:32] PHP Warning: require_once(PHPUnit/Runner/Version.php): failed to open stream: No such file or directory in /vagrant/mediawiki/tests/phpunit/phpunit.php on line 107 [04:23:52] fuck it, I'll rerun the provisioner [04:23:56] maybe interrupting has fucked it up somehow [04:24:16] (03PS1) 10Pastakhov: fix ternary operator ( add '?:' ) [extensions/PhpTags] - 10https://gerrit.wikimedia.org/r/118662 [04:26:29] (03PS2) 10Pastakhov: fix ternary operator ( add '?:' ) [extensions/PhpTags] - 10https://gerrit.wikimedia.org/r/118662 [04:26:56] (03CR) 10Pastakhov: [C: 032] fix ternary operator ( add '?:' ) [extensions/PhpTags] - 10https://gerrit.wikimedia.org/r/118662 (owner: 10Pastakhov) [04:27:00] (03Merged) 10jenkins-bot: fix ternary operator ( add '?:' ) [extensions/PhpTags] - 10https://gerrit.wikimedia.org/r/118662 (owner: 10Pastakhov) [04:28:47] (03CR) 10Springle: [C: 031] Redo WhatLinksHere query and add a *_from_namespace field to link tables [core] - 10https://gerrit.wikimedia.org/r/117373 (owner: 10Aaron Schulz) [04:58:52] (03PS3) 10Krinkle: Exceptions were directly outputting {{SITENAME}}. [core] - 10https://gerrit.wikimedia.org/r/116080 (owner: 10Brian Wolff) [04:59:13] (03PS4) 10Krinkle: MWException: Expand {{SITENAME}} in pagetitle with Message::text() [core] - 10https://gerrit.wikimedia.org/r/116080 (owner: 10Brian Wolff) [05:02:35] (03PS1) 10Krinkle: MWException: Fix sitename appearing twice in [core] - 10https://gerrit.wikimedia.org/r/118665 [05:06:51] <grrrit-wm> (03PS2) 10Krinkle: MWException: Fix sitename appearing twice in <title> [core] - 10https://gerrit.wikimedia.org/r/118665 [05:06:51] <grrrit-wm> (03CR) 10Krinkle: [C: 031] "@PleaseStand: The sitename appearing twice is a separate pre-existing bug, fixed in I85d65d89e72b4497a0." [core] - 10https://gerrit.wikimedia.org/r/116080 (owner: 10Brian Wolff) [05:29:13] <zeek_> Hi hexmode: are you there? [05:37:01] <grrrit-wm> (03PS1) 10Werdna: Pin PHPUnit to version 3.7. [core] - 10https://gerrit.wikimedia.org/r/118666 [06:20:17] <grrrit-wm> (03PS21) 10Werdna: Extract wiki and external links, file and template usages from text. [extensions/Flow] - 10https://gerrit.wikimedia.org/r/110090 [06:20:20] <grrrit-wm> (03CR) 10jenkins-bot: [V: 04-1] Extract wiki and external links, file and template usages from text. [extensions/Flow] - 10https://gerrit.wikimedia.org/r/110090 (owner: 10Werdna) [06:26:04] <grrrit-wm> (03PS3) 10KartikMistry: Updater class [extensions/LocalisationUpdate] (json-rewrite) - 10https://gerrit.wikimedia.org/r/118445 (owner: 10Nikerabbit) [06:31:12] <pawan_seerwani> Hi, I am trying to solve this bug: https://bugzilla.wikimedia.org/show_bug.cgi?id=43989 [06:31:42] <pawan_seerwani> I have understood that the bug is because & is not being converted to '&' [06:32:07] <pawan_seerwani> but I don't know where in the codebase should I change.. [06:32:18] <Nikerabbit> pawan_seerwani: hmm? the bug is marked as fixed [06:32:19] <pawan_seerwani> Any help/hint would be appreciated [06:32:48] <pawan_seerwani> That was accidently marked as fixed... but it exists [06:39:02] <pawan_seerwani> Can anyone tell where in the codebase symbols like '&' in wikitext is converted to '&' [06:42:38] <Nikerabbit> pawan_seerwani: in thousands of places [07:03:56] <pawan_seerwani> Nikerabbit, any suggestion as to how find where to change for this bug? [07:04:15] <pawan_seerwani> *how to [07:05:11] <grrrit-wm> (03PS1) 10SG: Fix a misnamed variable from 28cbae3 [extensions/Flow] - 10https://gerrit.wikimedia.org/r/118669 [07:06:36] <grrrit-wm> (03CR) 10SG: [C: 032 V: 032] "Self-approving because this is how we got here in the first place!" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/118669 (owner: 10SG) [07:06:46] <grrrit-wm> (03Merged) 10jenkins-bot: Fix a misnamed variable from 28cbae3 [extensions/Flow] - 10https://gerrit.wikimedia.org/r/118669 (owner: 10SG) [07:18:45] <grrrit-wm> (03CR) 10Nikerabbit: HTMLForm: Add daterange type (031 comment) [core] - 10https://gerrit.wikimedia.org/r/118112 (owner: 10Anomie) [07:22:13] <Nemo_bis> pawan_seerwani: first, you have to comment on bug to say it's not fixed and get it reopened, or file it again [07:22:36] <Nemo_bis> without a good problem statement there is no chance maintainers will understand your patch [07:30:15] <pawan_seerwani> Nemo_bis, I have mailed the maintainer about reopening the bug [07:31:16] <Nemo_bis> pawan_seerwani: very wrong; you need to comment on bug [07:31:49] <pawan_seerwani> Nemo_bis, Sorry. I will comment right away. [07:31:54] <Nemo_bis> https://www.mediawiki.org/wiki/Bug_management/Bugzilla_etiquette [07:31:56] <Nemo_bis> ok [07:32:13] <Nemo_bis> be sure to include steps to reproduce if the bug doesn't have them yet [08:46:06] <grrrit-wm> (03PS2) 10Maduranga: Change date and decimal separators for Uzbek language [core] - 10https://gerrit.wikimedia.org/r/118579 [10:08:12] <grrrit-wm> (03CR) 10Amire80: [C: 032] Prevent "Log in" being used in two different contexts [core] - 10https://gerrit.wikimedia.org/r/118320 (owner: 10Siebrand) [10:11:50] <grrrit-wm> (03Merged) 10jenkins-bot: Prevent "Log in" being used in two different contexts [core] - 10https://gerrit.wikimedia.org/r/118320 (owner: 10Siebrand) [10:14:36] <grrrit-wm> (03PS3) 10Hashar: git-logs: cleanup after processing by removing ChangeLog file [tools/release] - 10https://gerrit.wikimedia.org/r/110282 (owner: 10Awjrichards) [10:14:40] <grrrit-wm> (03PS4) 10Hashar: git-logs: cleanup after processing by removing ChangeLog file [tools/release] - 10https://gerrit.wikimedia.org/r/110282 (owner: 10Awjrichards) [10:15:24] <grrrit-wm> (03CR) 10Hashar: [C: 032] git-logs: cleanup after processing by removing ChangeLog file [tools/release] - 10https://gerrit.wikimedia.org/r/110282 (owner: 10Awjrichards) [10:15:26] <grrrit-wm> (03Merged) 10jenkins-bot: git-logs: cleanup after processing by removing ChangeLog file [tools/release] - 10https://gerrit.wikimedia.org/r/110282 (owner: 10Awjrichards) [10:17:48] <grrrit-wm> (03PS4) 10Hashar: git-logs: support commit ranges [tools/release] - 10https://gerrit.wikimedia.org/r/110283 (owner: 10Awjrichards) [10:18:32] <grrrit-wm> (03CR) 10Hashar: [C: 032] git-logs: support commit ranges [tools/release] - 10https://gerrit.wikimedia.org/r/110283 (owner: 10Awjrichards) [10:18:34] <grrrit-wm> (03Merged) 10jenkins-bot: git-logs: support commit ranges [tools/release] - 10https://gerrit.wikimedia.org/r/110283 (owner: 10Awjrichards) [10:19:56] <grrrit-wm> (03PS4) 10Hashar: git-logs: option to make 'INFO' output optional [tools/release] - 10https://gerrit.wikimedia.org/r/110284 (owner: 10Awjrichards) [10:20:16] <grrrit-wm> (03CR) 10Hashar: [C: 032] "rebased. Good enough for now." [tools/release] - 10https://gerrit.wikimedia.org/r/110284 (owner: 10Awjrichards) [10:20:18] <grrrit-wm> (03CR) 10jenkins-bot: [V: 04-1] git-logs: option to make 'INFO' output optional [tools/release] - 10https://gerrit.wikimedia.org/r/110284 (owner: 10Awjrichards) [10:20:51] <grrrit-wm> (03CR) 10Hashar: [C: 032] "retry" [tools/release] - 10https://gerrit.wikimedia.org/r/110284 (owner: 10Awjrichards) [10:20:53] <grrrit-wm> (03Merged) 10jenkins-bot: git-logs: option to make 'INFO' output optional [tools/release] - 10https://gerrit.wikimedia.org/r/110284 (owner: 10Awjrichards) [10:35:34] <grrrit-wm> (03CR) 10Hashar: [C: 04-1] "Suggestion to use --exclude and make-release.yaml." (031 comment) [tools/release] - 10https://gerrit.wikimedia.org/r/118072 (owner: 10MarkAHershberger) [10:57:42] <grrrit-wm> (03CR) 10Siebrand: [C: 04-1] Add namespace aliases for Serbo-Croatian (sh) (031 comment) [core] - 10https://gerrit.wikimedia.org/r/118656 (owner: 10Gerrit Patch Uploader) [10:58:18] <grrrit-wm> (03Abandoned) 10Hashar: Jenkins job validation (DO NOT SUBMIT) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/86118 (owner: 10Hashar) [11:03:12] <grrrit-wm> (03PS24) 10Addshore: Add "Thanks" for comments on Flow boards [extensions/Thanks] - 10https://gerrit.wikimedia.org/r/115557 (owner: 10Wctaiwan) [11:03:17] <grrrit-wm> (03PS4) 10Addshore: Add integration test for flowthank API [extensions/Thanks] - 10https://gerrit.wikimedia.org/r/118461 (owner: 10Bencmq) [11:03:48] <grrrit-wm> (03PS1) 10MaxSem: Update MobileFrontend to wmf/1.23wmf17 tip [core] (wmf/1.23wmf17) - 10https://gerrit.wikimedia.org/r/118685 [11:04:22] <grrrit-wm> (03PS1) 10MaxSem: Update MobileFrontend to wmf/1.23wmf18 tip [core] (wmf/1.23wmf18) - 10https://gerrit.wikimedia.org/r/118686 [11:06:24] <grrrit-wm> (03CR) 10MaxSem: [C: 032 V: 032] Update MobileFrontend to wmf/1.23wmf17 tip [core] (wmf/1.23wmf17) - 10https://gerrit.wikimedia.org/r/118685 (owner: 10MaxSem) [11:06:37] <grrrit-wm> (03CR) 10MaxSem: [C: 032 V: 032] Update MobileFrontend to wmf/1.23wmf18 tip [core] (wmf/1.23wmf18) - 10https://gerrit.wikimedia.org/r/118686 (owner: 10MaxSem) [11:07:46] <grrrit-wm> (03CR) 10Siebrand: [C: 031] "L10n reviewed." [extensions/Thanks] - 10https://gerrit.wikimedia.org/r/115557 (owner: 10Wctaiwan) [11:08:09] <grrrit-wm> (03CR) 10Siebrand: [C: 031] "L10n reviewed." [extensions/SpamBlacklist] - 10https://gerrit.wikimedia.org/r/118636 (owner: 10Jackmcbarn) [11:11:01] <grrrit-wm> (03CR) 10Addshore: [C: 04-1] Add integration test for flowthank API (031 comment) [extensions/Thanks] - 10https://gerrit.wikimedia.org/r/118461 (owner: 10Bencmq) [11:12:01] <grrrit-wm> (03CR) 10Addshore: "If this is going in it should probably wait for https://gerrit.wikimedia.org/r/#/c/118461/ !" [extensions/Thanks] - 10https://gerrit.wikimedia.org/r/115557 (owner: 10Wctaiwan) [11:19:58] <grrrit-wm> (03PS5) 10Bencmq: Add integration test for flowthank API [extensions/Thanks] - 10https://gerrit.wikimedia.org/r/118461 [11:22:05] <grrrit-wm> (03CR) 10Bencmq: Add integration test for flowthank API (031 comment) [extensions/Thanks] - 10https://gerrit.wikimedia.org/r/118461 (owner: 10Bencmq) [11:32:39] <Nikerabbit> Gerrit seems completely down [11:33:11] <ori> Nikerabbit: just verrrrrrrrry slow I think [11:33:33] <Nikerabbit> ori: nope, my browser gave up on multiple pages already [11:33:55] <hoo> works for me (slow, but works)= [11:34:26] <YuviPanda> sounds like a normal day in GerritLand [11:36:14] <Nemo_bis> Nikerabbit: chrome is not particularly patient or persistent, usually [11:39:47] <grrrit-wm> (03PS5) 10Ori.livneh: ResourceLoader::makeLoaderImplementScript: Bind args as '$' and 'jQuery' [core] - 10https://gerrit.wikimedia.org/r/117672 [11:40:46] <grrrit-wm> (03CR) 10jenkins-bot: [V: 04-1] ResourceLoader::makeLoaderImplementScript: Bind args as '$' and 'jQuery' [core] - 10https://gerrit.wikimedia.org/r/117672 (owner: 10Ori.livneh) [11:41:07] <grrrit-wm> (03PS6) 10Ori.livneh: ResourceLoader::makeLoaderImplementScript: Bind args as '$' and 'jQuery' [core] - 10https://gerrit.wikimedia.org/r/117672 [11:41:30] <grrrit-wm> (03CR) 10Ori.livneh: "PS5: Added suitably scary release note. PS6: rebase." [core] - 10https://gerrit.wikimedia.org/r/117672 (owner: 10Ori.livneh) [11:50:56] <grrrit-wm> (03PS3) 10Phuedx: [WIP] "Magnify" the Edit tab [extensions/GettingStarted] - 10https://gerrit.wikimedia.org/r/118478 [11:51:55] <grrrit-wm> (03CR) 10Siebrand: HTMLForm: Add date type (032 comments) [core] - 10https://gerrit.wikimedia.org/r/118111 (owner: 10Anomie) [11:57:13] <grrrit-wm> (03CR) 10Helder.wiki: "Needs a note on" [core] - 10https://gerrit.wikimedia.org/r/118655 (owner: 10Ori.livneh) [12:09:15] <grrrit-wm> (03CR) 10Ori.livneh: "> Needs a note on https://www.mediawiki.org/wiki/Manual:Interface/JavaScript#Page-specific" [core] - 10https://gerrit.wikimedia.org/r/118655 (owner: 10Ori.livneh) [13:25:56] <grrrit-wm> (03PS1) 10Matthias Mullie: (bug 62634) Fatal exception "DatabaseBase::makeList: empty input for field rev_id" on Special:Contributions [extensions/Flow] - 10https://gerrit.wikimedia.org/r/118694 [13:28:30] <grrrit-wm> (03CR) 10Matthias Mullie: Use single query for multiple revision lookups by pk (031 comment) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/115416 (owner: 10EBernhardson) [13:35:09] <grrrit-wm> (03CR) 10Matthias Mullie: [C: 031] "LGTM" [extensions/Thanks] - 10https://gerrit.wikimedia.org/r/115557 (owner: 10Wctaiwan) [13:37:14] <grrrit-wm> (03CR) 10Matthias Mullie: "You don't want to make this one a dependency on 118566, because 118566 is actually dependant on this patch. That would get messy if you we" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/118565 (owner: 10Matthias Mullie) [13:38:05] <grrrit-wm> (03PS2) 10Matthias Mullie: Create ContentFixer - to combine all content fixups in one place [extensions/Flow] - 10https://gerrit.wikimedia.org/r/118566 [13:38:08] <grrrit-wm> (03CR) 10jenkins-bot: [V: 04-1] Create ContentFixer - to combine all content fixups in one place [extensions/Flow] - 10https://gerrit.wikimedia.org/r/118566 (owner: 10Matthias Mullie) [13:39:19] <grrrit-wm> (03PS3) 10Matthias Mullie: (bug 61772) MediaWiki:Bad image list not integrated [extensions/Flow] - 10https://gerrit.wikimedia.org/r/118565 [13:39:22] <grrrit-wm> (03PS2) 10Matthias Mullie: Move Parsoid-related code into own folder/namespace [extensions/Flow] - 10https://gerrit.wikimedia.org/r/118564 [13:39:25] <grrrit-wm> (03PS3) 10Matthias Mullie: Create ContentFixer - to combine all content fixups in one place [extensions/Flow] - 10https://gerrit.wikimedia.org/r/118566 [13:39:45] <grrrit-wm> (03CR) 10jenkins-bot: [V: 04-1] Move Parsoid-related code into own folder/namespace [extensions/Flow] - 10https://gerrit.wikimedia.org/r/118564 (owner: 10Matthias Mullie) [13:42:13] <grrrit-wm> (03PS3) 10Matthias Mullie: Move Parsoid-related code into own folder/namespace [extensions/Flow] - 10https://gerrit.wikimedia.org/r/118564 [13:44:01] <grrrit-wm> (03PS1) 10Addshore: Remove phpunit compatability function calls [core] - 10https://gerrit.wikimedia.org/r/118697 [13:55:17] <grrrit-wm> (03CR) 10Addshore: Add integration test for flowthank API (031 comment) [extensions/Thanks] - 10https://gerrit.wikimedia.org/r/118461 (owner: 10Bencmq) [13:55:21] <grrrit-wm> (03CR) 10Addshore: [C: 032] Add integration test for flowthank API [extensions/Thanks] - 10https://gerrit.wikimedia.org/r/118461 (owner: 10Bencmq) [13:55:29] <grrrit-wm> (03CR) 10Addshore: [C: 032] Add "Thanks" for comments on Flow boards [extensions/Thanks] - 10https://gerrit.wikimedia.org/r/115557 (owner: 10Wctaiwan) [13:55:45] <grrrit-wm> (03Merged) 10jenkins-bot: Add "Thanks" for comments on Flow boards [extensions/Thanks] - 10https://gerrit.wikimedia.org/r/115557 (owner: 10Wctaiwan) [13:55:57] <grrrit-wm> (03Merged) 10jenkins-bot: Add integration test for flowthank API [extensions/Thanks] - 10https://gerrit.wikimedia.org/r/118461 (owner: 10Bencmq) [14:05:42] <grrrit-wm> (03PS11) 10Umherirrender: API: Return set values for action=options [core] - 10https://gerrit.wikimedia.org/r/92928 [14:05:45] <grrrit-wm> (03CR) 10Addshore: [C: 031] Prevent double email notifications on talk page edit [extensions/Echo] - 10https://gerrit.wikimedia.org/r/114683 (owner: 10Bsitu) [14:05:50] <grrrit-wm> (03PS4) 10Addshore: Prevent double email notifications on talk page edit [extensions/Echo] - 10https://gerrit.wikimedia.org/r/114683 (owner: 10Bsitu) [14:05:55] <grrrit-wm> (03CR) 10Addshore: [C: 031] Prevent double email notifications on talk page edit [extensions/Echo] - 10https://gerrit.wikimedia.org/r/114683 (owner: 10Bsitu) [14:08:00] <grrrit-wm> (03CR) 10Hoo man: [C: 032] Remove phpunit compatability function calls [core] - 10https://gerrit.wikimedia.org/r/118697 (owner: 10Addshore) [14:10:43] <grrrit-wm> (03PS5) 10Matthias Mullie: Action menu updates [extensions/Flow] - 10https://gerrit.wikimedia.org/r/116501 [14:10:46] <grrrit-wm> (03CR) 10jenkins-bot: [V: 04-1] Action menu updates [extensions/Flow] - 10https://gerrit.wikimedia.org/r/116501 (owner: 10Matthias Mullie) [14:11:27] <grrrit-wm> (03Merged) 10jenkins-bot: Remove phpunit compatability function calls [core] - 10https://gerrit.wikimedia.org/r/118697 (owner: 10Addshore) [14:11:48] <grrrit-wm> (03CR) 10Hoo man: [C: 04-1] "Needs a rebase. But despite of that, I will approve this in maybe a week if no further concerns are expressed (@Anomie)." [core] - 10https://gerrit.wikimedia.org/r/106517 (owner: 10Daniel Kinzler) [14:13:06] <grrrit-wm> (03PS2) 10Matthias Mullie: Minify SVG files [extensions/Flow] - 10https://gerrit.wikimedia.org/r/116747 [14:13:10] <grrrit-wm> (03CR) 10jenkins-bot: [V: 04-1] Minify SVG files [extensions/Flow] - 10https://gerrit.wikimedia.org/r/116747 (owner: 10Matthias Mullie) [14:15:41] <grrrit-wm> (03PS6) 10Matthias Mullie: Action menu updates [extensions/Flow] - 10https://gerrit.wikimedia.org/r/116501 [14:16:23] <grrrit-wm> (03PS3) 10Matthias Mullie: Minify SVG files [extensions/Flow] - 10https://gerrit.wikimedia.org/r/116747 [14:19:50] <grrrit-wm> (03CR) 10Anomie: [C: 031] "Depends on how you look at it. You don't support the *option* to list redirects because it's required. ;)" [core] - 10https://gerrit.wikimedia.org/r/118592 (owner: 10Chad) [14:25:39] <grrrit-wm> (03CR) 10Matthias Mullie: "Ebernhardson:" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/116501 (owner: 10Matthias Mullie) [14:31:32] <grrrit-wm> (03PS7) 10Umherirrender: Use TablePager on Special:ProtectedTitles [core] - 10https://gerrit.wikimedia.org/r/98252 [14:32:15] <grrrit-wm> (03CR) 10Umherirrender: "Patch Set 7: Rebased" [core] - 10https://gerrit.wikimedia.org/r/98252 (owner: 10Umherirrender) [14:32:17] <grrrit-wm> (03CR) 10Manybubbles: "So I can totally get behind cCirrus refusing to implement the feature. I think I'll need more convincing that it isn't *somewhat* useful " [core] - 10https://gerrit.wikimedia.org/r/118592 (owner: 10Chad) [14:33:32] <grrrit-wm> (03PS7) 10Netbrain: Added "search and replace within selection" functionality [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/87322 [14:38:44] <grrrit-wm> (03CR) 10Netbrain: "comments" [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/87322 (owner: 10Netbrain) [15:33:14] <grrrit-wm> (03CR) 10Anomie: [C: 031] Avoid header notice log spam from RunJobs API (032 comments) [core] - 10https://gerrit.wikimedia.org/r/118336 (owner: 10Aaron Schulz) [16:29:54] <grrrit-wm> (03CR) 10Chad: Start building suggest field combined didyoumean (031 comment) [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/118650 (owner: 10Manybubbles) [16:31:29] <grrrit-wm> (03CR) 10Manybubbles: [C: 04-1] Start building suggest field combined didyoumean (031 comment) [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/118650 (owner: 10Manybubbles) [16:32:11] <grrrit-wm> (03CR) 10Aaron Schulz: Avoid header notice log spam from RunJobs API (031 comment) [core] - 10https://gerrit.wikimedia.org/r/118336 (owner: 10Aaron Schulz) [16:32:11] <grrrit-wm> (03CR) 10Anomie: HTMLForm: Add date type (031 comment) [core] - 10https://gerrit.wikimedia.org/r/118111 (owner: 10Anomie) [16:33:51] <grrrit-wm> (03PS3) 10Aaron Schulz: Avoid header notice log spam from RunJobs API [core] - 10https://gerrit.wikimedia.org/r/118336 [16:46:50] <grrrit-wm> (03CR) 10Anomie: Avoid header notice log spam from RunJobs API (031 comment) [core] - 10https://gerrit.wikimedia.org/r/118336 (owner: 10Aaron Schulz) [16:49:25] <grrrit-wm> (03PS9) 10CSteipp: ignore this (more segfault testing) [core] - 10https://gerrit.wikimedia.org/r/118573 [16:57:54] <grrrit-wm> (03CR) 10Aaron Schulz: Avoid header notice log spam from RunJobs API (031 comment) [core] - 10https://gerrit.wikimedia.org/r/118336 (owner: 10Aaron Schulz) [17:00:04] <grrrit-wm> (03PS4) 10Aaron Schulz: Avoid header notice log spam from RunJobs API [core] - 10https://gerrit.wikimedia.org/r/118336 [17:05:03] <grrrit-wm> (03PS1) 10Bsitu: Add code to prevent exception for new db columns [extensions/Flow] - 10https://gerrit.wikimedia.org/r/118719 [17:11:06] <rdwrer> !g I8fa0d286997a27b46d2d0506513254694c1927ec [17:11:06] <wm-bot> https://gerrit.wikimedia.org/r/#q,I8fa0d286997a27b46d2d0506513254694c1927ec,n,z [17:12:12] <rdwrer> !g I9ba37038e41d81bbb8dfa96b8a7766b35d24fa5a [17:12:12] <wm-bot> https://gerrit.wikimedia.org/r/#q,I9ba37038e41d81bbb8dfa96b8a7766b35d24fa5a,n,z [17:15:10] <grrrit-wm> (03CR) 10Bsitu: [C: 032] (bug 62634) Fatal exception "DatabaseBase::makeList: empty input for field rev_id" on Special:Contributions [extensions/Flow] - 10https://gerrit.wikimedia.org/r/118694 (owner: 10Matthias Mullie) [17:15:23] <grrrit-wm> (03Merged) 10jenkins-bot: (bug 62634) Fatal exception "DatabaseBase::makeList: empty input for field rev_id" on Special:Contributions [extensions/Flow] - 10https://gerrit.wikimedia.org/r/118694 (owner: 10Matthias Mullie) [17:16:20] <ori> rdwrer: is there a way to check client-side which beta features a user has opted into? [17:16:35] <grrrit-wm> (03PS2) 10Bsitu: Add code to prevent exception for new db columns [extensions/Flow] - 10https://gerrit.wikimedia.org/r/118719 [17:16:40] <ori> mw.config.get( 'wgBetaFeaturesFeatures' ); only seems to get populated on the beta features pref page [17:17:19] <rdwrer> ori: Hm; no, but there could be something useful added in getconfigvars [17:17:31] <rdwrer> I would merge that patch [17:17:32] <gwicke> shahyar: thanks for the work on TemplatePerf, just merged it! [17:17:46] <rdwrer> Innn a heartbeat [17:20:49] <grrrit-wm> (03CR) 10EBernhardson: [C: 032] Move Parsoid-related code into own folder/namespace [extensions/Flow] - 10https://gerrit.wikimedia.org/r/118564 (owner: 10Matthias Mullie) [17:21:02] <grrrit-wm> (03Merged) 10jenkins-bot: Move Parsoid-related code into own folder/namespace [extensions/Flow] - 10https://gerrit.wikimedia.org/r/118564 (owner: 10Matthias Mullie) [17:21:05] <grrrit-wm> (03PS4) 10EBernhardson: (bug 61772) MediaWiki:Bad image list not integrated [extensions/Flow] - 10https://gerrit.wikimedia.org/r/118565 (owner: 10Matthias Mullie) [17:21:16] <grrrit-wm> (03CR) 10jenkins-bot: [V: 04-1] (bug 61772) MediaWiki:Bad image list not integrated [extensions/Flow] - 10https://gerrit.wikimedia.org/r/118565 (owner: 10Matthias Mullie) [17:24:29] <grrrit-wm> (03PS13) 10Bsitu: [Schema Change]Add column rev_type_id to table flow_revision [extensions/Flow] - 10https://gerrit.wikimedia.org/r/116861 [17:29:05] <grrrit-wm> (03PS14) 10Bsitu: [Schema Change]Add column rev_type_id to table flow_revision [extensions/Flow] - 10https://gerrit.wikimedia.org/r/116861 [17:32:30] <grrrit-wm> (03CR) 10Isarra: "Alternative method - leave the files where they are and duplicate them for the resources. This would maintain backwards compatibility (we " [core] - 10https://gerrit.wikimedia.org/r/114984 (owner: 10Bartosz Dziewoński) [17:32:37] <grrrit-wm> (03CR) 10Ssmith: [C: 032 V: 032] Adding WorldPay forms [core] (fundraising/REL1_22) - 10https://gerrit.wikimedia.org/r/118646 (owner: 10Mwalker) [17:33:12] <grrrit-wm> (03CR) 10Bartosz Dziewoński: [C: 04-1] "Per Daniel, Parsoid should generate the appropriate classes instead." [core] - 10https://gerrit.wikimedia.org/r/118447 (owner: 10Matthias Mullie) [17:35:46] <grrrit-wm> (03CR) 10Bartosz Dziewoński: "Merging https://gerrit.wikimedia.org/r/#/c/114984/ in the form Daniel would like and which I don't like will not help get this merged anyw" [core] - 10https://gerrit.wikimedia.org/r/110908 (owner: 10Isarra) [17:37:30] <grrrit-wm> (03PS1) 10EBernhardson: Add more info to flakey permissions test [extensions/Flow] - 10https://gerrit.wikimedia.org/r/118722 [17:37:52] <grrrit-wm> (03CR) 10EBernhardson: [C: 032] Add more info to flakey permissions test [extensions/Flow] - 10https://gerrit.wikimedia.org/r/118722 (owner: 10EBernhardson) [17:38:03] <grrrit-wm> (03CR) 10jenkins-bot: [V: 04-1] Add more info to flakey permissions test [extensions/Flow] - 10https://gerrit.wikimedia.org/r/118722 (owner: 10EBernhardson) [17:40:07] <grrrit-wm> (03CR) 10Isarra: "Aye, we definitely do want to be moving the other files so they're all consistent. We could hold off moving the others for a time, and onl" [core] - 10https://gerrit.wikimedia.org/r/110908 (owner: 10Isarra) [17:40:43] <grrrit-wm> (03PS1) 10Nikerabbit: Avoid infinite fallback loops [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/118724 [17:41:40] <grrrit-wm> (03CR) 10jenkins-bot: [V: 04-1] Avoid infinite fallback loops [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/118724 (owner: 10Nikerabbit) [17:42:26] <grrrit-wm> (03CR) 10Nikerabbit: Use language fallbacks where they're available (031 comment) [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/117465 (owner: 10Chad) [17:43:48] <grrrit-wm> (03PS1) 10Cscott: Sync up with Parsoid parserTests. [core] - 10https://gerrit.wikimedia.org/r/118726 [17:44:31] <grrrit-wm> (03PS2) 10EBernhardson: Add more info to flakey permissions test [extensions/Flow] - 10https://gerrit.wikimedia.org/r/118722 [17:45:25] <grrrit-wm> (03CR) 10EBernhardson: [C: 032] Add more info to flakey permissions test [extensions/Flow] - 10https://gerrit.wikimedia.org/r/118722 (owner: 10EBernhardson) [17:45:38] <grrrit-wm> (03CR) 10jenkins-bot: [V: 04-1] Add more info to flakey permissions test [extensions/Flow] - 10https://gerrit.wikimedia.org/r/118722 (owner: 10EBernhardson) [17:46:14] <grrrit-wm> (03CR) 10Pawanseerwani: "@Skizzerz : Thanks, I will test it soon and let you know :)" [core] - 10https://gerrit.wikimedia.org/r/110949 (owner: 10Gerrit Patch Uploader) [17:47:07] <grrrit-wm> (03PS2) 10Nikerabbit: Avoid infinite fallback loops [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/118724 [17:47:21] <shahyar> gwicke: thanks! [17:47:33] <grrrit-wm> (03CR) 10Chad: Use language fallbacks where they're available (031 comment) [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/117465 (owner: 10Chad) [17:47:37] <grrrit-wm> (03PS1) 10Adamw: DonationInterface tests are voting; deprecate "runtests" target [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/118727 [17:48:20] <grrrit-wm> (03CR) 10Nikerabbit: "Untested." [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/118724 (owner: 10Nikerabbit) [17:48:31] <grrrit-wm> (03CR) 10Chad: "Typo, otherwise looks good." (031 comment) [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/118724 (owner: 10Nikerabbit) [17:48:33] <grrrit-wm> (03PS3) 10EBernhardson: Add more info to flakey permissions test [extensions/Flow] - 10https://gerrit.wikimedia.org/r/118722 [17:48:46] <grrrit-wm> (03CR) 10jenkins-bot: [V: 04-1] Add more info to flakey permissions test [extensions/Flow] - 10https://gerrit.wikimedia.org/r/118722 (owner: 10EBernhardson) [17:49:58] <grrrit-wm> (03CR) 10Nischayn22: "https://bugzilla.wikimedia.org/show_bug.cgi?id=32606#c13" [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/50760 (owner: 10Nischayn22) [17:50:56] <grrrit-wm> (03CR) 10Bartosz Dziewoński: [C: 04-1] "I think you broke the logic in one place during the cleanup. Looks good to go otherwise." (033 comments) [core] - 10https://gerrit.wikimedia.org/r/116957 (owner: 10Krinkle) [17:53:34] <grrrit-wm> (03CR) 10Nischayn22: "Unfortunately I don't have enough time to code this again. Only a small issue of putting var statements together remains. Can this be merg" [core] - 10https://gerrit.wikimedia.org/r/64556 (owner: 10Nischayn22) [17:54:27] <grrrit-wm> (03PS4) 10EBernhardson: Add more info to flakey permissions test [extensions/Flow] - 10https://gerrit.wikimedia.org/r/118722 [17:55:02] <grrrit-wm> (03CR) 10EBernhardson: [C: 032] Add more info to flakey permissions test [extensions/Flow] - 10https://gerrit.wikimedia.org/r/118722 (owner: 10EBernhardson) [17:55:17] <grrrit-wm> (03CR) 10jenkins-bot: [V: 04-1] Add more info to flakey permissions test [extensions/Flow] - 10https://gerrit.wikimedia.org/r/118722 (owner: 10EBernhardson) [17:55:59] <grrrit-wm> (03CR) 10Subramanya Sastry: [C: 032] Sync up with Parsoid parserTests. [core] - 10https://gerrit.wikimedia.org/r/118726 (owner: 10Cscott) [17:57:57] <gwicke> shahyar, let us know if you have input on the kotasm / tassembly work btw [17:59:00] <grrrit-wm> (03PS12) 10Bsitu: Update column data: flow_revision.rev_type_id [extensions/Flow] - 10https://gerrit.wikimedia.org/r/116874 [17:59:53] <grrrit-wm> (03Merged) 10jenkins-bot: Sync up with Parsoid parserTests. [core] - 10https://gerrit.wikimedia.org/r/118726 (owner: 10Cscott) [18:02:11] <grrrit-wm> (03PS13) 10Bsitu: Update column data: flow_revision.rev_type_id [extensions/Flow] - 10https://gerrit.wikimedia.org/r/116874 [18:04:13] <awight> spagewmf: ebernhardson: I usually crib out of the jenkins build log and get a command along the lines of: php maintenance/install.php --dbtype=sqlite --dbname=yrname --dbpath=./data --pass testpass sqlitetest WikiAdmin [18:05:14] <awight> oh and u have to move any existing LocalSettings.php out of the way before doing such a thing. [18:08:33] <shahyar> gwicke: I will likely, at some point. :) [18:09:43] <gwicke> great [18:11:42] <grrrit-wm> (03PS7) 10Tpt: Addition of a parser test for page= parameter of image inclusion [core] - 10https://gerrit.wikimedia.org/r/102475 [18:12:21] <grrrit-wm> (03CR) 10Tpt: "PS7: rebase + be sure that 'djvu' is in $wgFileExtensions." [core] - 10https://gerrit.wikimedia.org/r/102475 (owner: 10Tpt) [18:13:32] <grrrit-wm> (03PS1) 10Addshore: Remove assignment in conditon in phpunit.php [core] - 10https://gerrit.wikimedia.org/r/118730 [18:13:55] <grrrit-wm> (03Draft1) 10Addshore: Simplify setup of RevisionCollectionPermissionsTest [extensions/Flow] - 10https://gerrit.wikimedia.org/r/118729 [18:14:12] <grrrit-wm> (03PS2) 10Manybubbles: Start building suggest field combined didyoumean [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/118650 [18:16:24] <grrrit-wm> (03PS1) 10Bartosz Dziewoński: mediawiki.api: Documentation and typo cleanup [core] - 10https://gerrit.wikimedia.org/r/118731 [18:16:26] <grrrit-wm> (03PS1) 10Bartosz Dziewoński: mediawiki.api.category: getCategories: Deprecate the 'async' parameter [core] - 10https://gerrit.wikimedia.org/r/118732 [18:16:28] <grrrit-wm> (03PS1) 10Bartosz Dziewoński: mediawiki.api: Remove deprecated function parameters [core] - 10https://gerrit.wikimedia.org/r/118733 [18:17:00] <grrrit-wm> (03CR) 10Bartosz Dziewoński: [C: 04-2] "Let's do this for 1.24." [core] - 10https://gerrit.wikimedia.org/r/118733 (owner: 10Bartosz Dziewoński) [18:19:23] <grrrit-wm> (03CR) 10jenkins-bot: [V: 04-1] Addition of a parser test for page= parameter of image inclusion [core] - 10https://gerrit.wikimedia.org/r/102475 (owner: 10Tpt) [18:19:47] <grrrit-wm> (03CR) 10Chad: [C: 032] Start building suggest field combined didyoumean [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/118650 (owner: 10Manybubbles) [18:19:55] <grrrit-wm> (03Merged) 10jenkins-bot: Start building suggest field combined didyoumean [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/118650 (owner: 10Manybubbles) [18:22:32] <grrrit-wm> (03CR) 10Bartosz Dziewoński: "Eeek, ugly hacks D:" [core] - 10https://gerrit.wikimedia.org/r/118041 (owner: 10Kaldari) [18:23:48] <grrrit-wm> (03PS8) 10Tpt: Addition of a parser test for page= parameter of image inclusion [core] - 10https://gerrit.wikimedia.org/r/102475 [18:24:05] <grrrit-wm> (03CR) 10Addshore: [C: 031] Avoid infinite fallback loops [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/118724 (owner: 10Nikerabbit) [18:24:49] <grrrit-wm> (03PS14) 10Bsitu: Update post/header revision storage search key [extensions/Flow] - 10https://gerrit.wikimedia.org/r/117099 [18:25:20] <grrrit-wm> (03PS2) 10Chad: Use combined didyoumean [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/118651 (owner: 10Manybubbles) [18:25:37] <grrrit-wm> (03CR) 10Manybubbles: [C: 04-1] Use combined didyoumean [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/118651 (owner: 10Manybubbles) [18:25:40] <grrrit-wm> (03CR) 10Chad: [C: 04-2] "Code is fine, will merge once parent change is live." [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/118651 (owner: 10Manybubbles) [18:25:49] <grrrit-wm> (03CR) 10Manybubbles: "Just hold until we're ready...." [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/118651 (owner: 10Manybubbles) [18:27:10] <grrrit-wm> (03CR) 10CSteipp: "Worried about the efficiency of the comment in the script we send to all users. Otherwise I would merge this as is. Thanks!" (031 comment) [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/118429 (owner: 10Krinkle) [18:29:26] <grrrit-wm> (03CR) 10Bartosz Dziewoński: SpecialCentralAutoLogin: Clean up javascript (031 comment) [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/118429 (owner: 10Krinkle) [18:31:24] <grrrit-wm> (03CR) 10jenkins-bot: [V: 04-1] Addition of a parser test for page= parameter of image inclusion [core] - 10https://gerrit.wikimedia.org/r/102475 (owner: 10Tpt) [18:36:28] <grrrit-wm> (03PS15) 10Bsitu: Update post/header revision storage search key [extensions/Flow] - 10https://gerrit.wikimedia.org/r/117099 [18:44:44] <grrrit-wm> (03CR) 10CSteipp: SpecialCentralAutoLogin: Move javascript to separate files for linting (032 comments) [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/118430 (owner: 10Krinkle) [18:46:07] <grrrit-wm> (03CR) 10CSteipp: [C: 031] "Actually, I hadn't looked at the followup commit, which minifies the script. So the comment will be stripped. As long as both this and the" [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/118429 (owner: 10Krinkle) [18:46:57] <grrrit-wm> (03CR) 10Kaldari: "Bartosz Dziewoński: ?" [core] - 10https://gerrit.wikimedia.org/r/118041 (owner: 10Kaldari) [18:47:57] <MatmaRex> kaldari: you added a hack for a non-core skin in glue code for a non-core library, in core. :( [18:48:27] <grrrit-wm> (03CR) 10Bartosz Dziewoński: "You added a hack for a non-core skin in glue code for a non-core library, in core. :(" [core] - 10https://gerrit.wikimedia.org/r/118041 (owner: 10Kaldari) [18:49:19] <kaldari> MatmaRex: ah yeah, although Minerva will probably be moved to core soon [18:49:54] <MatmaRex> kaldari: heh, last time i heard we're moving all skins out of core [18:50:28] <kaldari> MatmaRex: yeah, we should move them all out of core and replace them with Minerva :) [18:50:36] <MatmaRex> heh [18:51:31] <grrrit-wm> (03PS13) 10Bsitu: Drop table: flow_header_revision [extensions/Flow] - 10https://gerrit.wikimedia.org/r/117115 [18:51:57] <kaldari> I'll admit it's a violation of core purity, but only a small violation ;) [18:57:50] <grrrit-wm> (03PS1) 10Rillke: Add link to local copy of Libre Art License [extensions/WikimediaMessages] - 10https://gerrit.wikimedia.org/r/118740 [18:58:13] <grrrit-wm> (03PS3) 10Nikerabbit: Avoid infinite fallback loops [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/118724 [18:58:54] <grrrit-wm> (03CR) 10Rillke: [C: 04-1] "Don't merge yet. Community may want to add input here." [extensions/WikimediaMessages] - 10https://gerrit.wikimedia.org/r/118740 (owner: 10Rillke) [19:00:01] <grrrit-wm> (03PS1) 10Spage: (bug 62634) Fatal exception "DatabaseBase::makeList: empty input for field rev_id" on Special:Contributions [extensions/Flow] (wmf/1.23wmf18) - 10https://gerrit.wikimedia.org/r/118741 [19:00:17] <grrrit-wm> (03CR) 10jenkins-bot: [V: 04-1] (bug 62634) Fatal exception "DatabaseBase::makeList: empty input for field rev_id" on Special:Contributions [extensions/Flow] (wmf/1.23wmf18) - 10https://gerrit.wikimedia.org/r/118741 (owner: 10Spage) [19:00:20] <grrrit-wm> (03PS2) 10Rillke: Add link to local copy of Libre Art License [extensions/WikimediaMessages] - 10https://gerrit.wikimedia.org/r/118740 [19:03:02] <YuviPanda> how do I see number of files/lines changed for a commit? [19:03:27] <Reedy> Whre? [19:04:22] <grrrit-wm> (03PS1) 10Pubudu538: Error Msg for missing db username when installing [core] - 10https://gerrit.wikimedia.org/r/118742 [19:07:26] <YuviPanda> rdwrer: in git [19:07:28] <YuviPanda> err [19:07:29] <YuviPanda> Reedy: git [19:07:41] <YuviPanda> git show <sha> doesn't give me the number of files [19:11:04] <grrrit-wm> (03CR) 10CSteipp: [C: 04-1] "Please do follow whitespace conventions." [core] - 10https://gerrit.wikimedia.org/r/114966 (owner: 10Mjnovice) [19:13:57] <grrrit-wm> (03CR) 10Phuedx: "I really like the direction this is going!" (0312 comments) [extensions/GuidedTour] - 10https://gerrit.wikimedia.org/r/116228 (owner: 10Mattflaschen) [19:18:43] <grrrit-wm> (03PS11) 10Bsitu: Add summary revision type [extensions/Flow] - 10https://gerrit.wikimedia.org/r/117357 [19:23:01] * ^d found the font we should totally use in MediaWiki. [19:23:04] <^d> http://www.fontspace.com/tension-type/helveticrap [19:25:07] <DanielK_WMDE_> grr, what's wrong with gerrit again? [19:25:14] <DanielK_WMDE_> i'm getting timeouts on the web [19:25:22] <DanielK_WMDE_> (git review is fast, for a change) [19:27:25] <DanielK_WMDE_> ^d: can you pokit it? or who is taking care of that htese days? [19:27:35] <DanielK_WMDE_> err, poke it. [19:27:40] <^d> This was happening yesterday :\ [19:28:21] <^d> It's a tad slow via the UI for me, but there. [19:28:32] <DanielK_WMDE_> for me it was the opposit yesterday: web was fine, but git review was timing out [19:29:09] <DanielK_WMDE_> ^d: yes, it's up - it starts sending data. but the page never quite finishes loading. [19:30:24] <hashar> poooor gerrit :D [19:30:28] <DanielK_WMDE_> ^d: uh... something is wrong. have a look at https://gerrit.wikimedia.org/r/#/c/117858/ - the overview has a red X by WikidataJenkins, but the Comments say Verified+2. [19:30:32] <DanielK_WMDE_> something isn't quite in sync [19:30:48] <hashar> could it be related to the monday upgrade? [19:31:08] <hashar> though in my experience it started screwing up from time to time two days ago [19:32:24] <DanielK_WMDE_> more nulljob errors from jenkins. i guess it's failing to clone stuff from gerrit. which makes me poke it to try again. [19:32:29] <DanielK_WMDE_> which puts more load on gerrit. [19:32:30] <DanielK_WMDE_> yay [19:32:51] <^d> I'd say a race condition between the two comments. [19:32:51] <DanielK_WMDE_> screw it, giving up for today. [19:33:03] <^d> (Review + comment aren't really atomic) [19:33:28] <DanielK_WMDE_> ^d: so what do i do, force it to check again? [19:33:36] <^d> I guess. [19:33:44] <DanielK_WMDE_> hmhm. right. on monday :) [19:34:14] <^d> I'm going to spend my afternoon playing with phabricator. I'm fed up with gerrit and it makes my head hurt. [19:34:39] <grrrit-wm> (03CR) 10Hashar: [C: 032] Remove assignment in conditon in phpunit.php [core] - 10https://gerrit.wikimedia.org/r/118730 (owner: 10Addshore) [19:34:44] <DanielK_WMDE_> ^d: have a look at http://brightbyte.de/page/Git_CR - that's what I'd want code review to be like [19:34:55] <DanielK_WMDE_> phabricator also looks nice. though it's kind of the opposite. [19:35:22] <DanielK_WMDE_> phabricator is all shiny, while my vision of git cr is rather bare bone. [19:36:23] <DanielK_WMDE_> anyway, ttfn [19:39:00] <grrrit-wm> (03Merged) 10jenkins-bot: Remove assignment in conditon in phpunit.php [core] - 10https://gerrit.wikimedia.org/r/118730 (owner: 10Addshore) [19:49:13] <grrrit-wm> (03CR) 10Spage: "recheck" [extensions/Flow] (wmf/1.23wmf18) - 10https://gerrit.wikimedia.org/r/118741 (owner: 10Spage) [20:16:32] <awjr> robla: well played with [Ops] We're replacing Bugzilla with RT [20:18:13] <robla> thanks....I can't go for *too* long without a little trolling. being in management makes me a little rusty :-) [20:19:36] <grrrit-wm> (03CR) 10Chad: [C: 032] Avoid infinite fallback loops [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/118724 (owner: 10Nikerabbit) [20:19:44] <grrrit-wm> (03Merged) 10jenkins-bot: Avoid infinite fallback loops [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/118724 (owner: 10Nikerabbit) [20:19:50] <^d> Nikerabbit: Thanks for spotting that + the patch [20:20:56] <grrrit-wm> (03PS1) 10Aaron Schulz: Use preloadFileStat() to speed up syncFileBackend [core] - 10https://gerrit.wikimedia.org/r/118752 [20:23:50] <grrrit-wm> (03PS2) 10Bsitu: Closing & reopening topic [extensions/Flow] - 10https://gerrit.wikimedia.org/r/118399 [20:24:11] <grrrit-wm> (03CR) 10jenkins-bot: [V: 04-1] Closing & reopening topic [extensions/Flow] - 10https://gerrit.wikimedia.org/r/118399 (owner: 10Bsitu) [20:27:28] <grrrit-wm> (03PS3) 10Bsitu: Closing & reopening topic [extensions/Flow] - 10https://gerrit.wikimedia.org/r/118399 [20:27:45] <grrrit-wm> (03CR) 10jenkins-bot: [V: 04-1] Closing & reopening topic [extensions/Flow] - 10https://gerrit.wikimedia.org/r/118399 (owner: 10Bsitu) [20:29:03] <grrrit-wm> (03PS4) 10Bsitu: Closing & reopening topic [extensions/Flow] - 10https://gerrit.wikimedia.org/r/118399 [20:29:17] <grrrit-wm> (03CR) 10jenkins-bot: [V: 04-1] Closing & reopening topic [extensions/Flow] - 10https://gerrit.wikimedia.org/r/118399 (owner: 10Bsitu) [20:42:40] <grrrit-wm> (03PS1) 10Aaron Schulz: Renamed /job to /jobqueue [core] - 10https://gerrit.wikimedia.org/r/118755 [20:50:50] <grrrit-wm> (03PS1) 10IAlex: Link to bugs.mediawiki.org in UPGRADE for consistency [core] - 10https://gerrit.wikimedia.org/r/118761 [20:54:00] <grrrit-wm> (03PS2) 10Nemo bis: Link to bugs.mediawiki.org in UPGRADE for consistency [core] - 10https://gerrit.wikimedia.org/r/118761 (owner: 10IAlex) [21:00:03] <grrrit-wm> (03PS5) 10Bsitu: Closing & reopening topic [extensions/Flow] - 10https://gerrit.wikimedia.org/r/118399 [21:10:38] <grrrit-wm> (03PS1) 10Manybubbles: Lots of small fixes [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/118763 [21:12:04] <grrrit-wm> (03PS1) 10IAlex: Put the "else" (or "elseif") on the same line as the previous closing brace [core] - 10https://gerrit.wikimedia.org/r/118764 [21:15:17] <grrrit-wm> (03CR) 10Manybubbles: "We should also remove the "supports" flag for it in cirrus. This'll remove the check box I think." [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/118593 (owner: 10Chad) [21:31:01] <welterkj> PRIVMSG JeroenDeDauw Hi Jeroen, could you help me interpret the review status of https://gerrit.wikimedia.org/r/#/c/111475/ [21:31:44] <rdwrer> Hi there welterkj. [21:31:53] <welterkj> Hi [21:33:55] <grrrit-wm> (03PS1) 10BryanDavis: Simple script to update scap across the cluster [tools/scap] - 10https://gerrit.wikimedia.org/r/118769 [21:34:18] <bd808> ori: ^ [21:35:17] <chasemp> just a note, according to the docs here: https://meta.wikimedia.org/wiki/Help:Unified_login it seems new logins should be unified by default. I made an account on en.wikipedia and had to manually unify it to login to mediawiki.org. unsure if this is worth a bug report. [21:35:39] <grrrit-wm> (03CR) 10Hashar: [C: 031] "Cant we use git-deploy from tin.eqiad.wmnet to achieve that?" [tools/scap] - 10https://gerrit.wikimedia.org/r/118769 (owner: 10BryanDavis) [21:35:57] <grrrit-wm> (03CR) 10Ori.livneh: [C: 032] "You're not going to call it "scap-scap" or something funny? I am disappointed in you." [tools/scap] - 10https://gerrit.wikimedia.org/r/118769 (owner: 10BryanDavis) [21:36:24] <grrrit-wm> (03Merged) 10jenkins-bot: Simple script to update scap across the cluster [tools/scap] - 10https://gerrit.wikimedia.org/r/118769 (owner: 10BryanDavis) [21:36:30] <ori> hashar: we could, but i threw a childish tantrum at the sprint onset and have been fastidiously pretending it wasn't a mistake ever since [21:36:38] <bd808> :) [21:36:48] <bd808> Also obvious troll is obvious [21:36:49] <ori> also, IT WASN'T A MISTAKE [21:37:11] <bd808> Soon enough it will be moot [21:37:23] <bd808> I have plans that will work damn it [21:37:32] <bd808> As soon as I can test them [21:42:14] <grrrit-wm> (03CR) 10CSteipp: "The performance of this concerns me. SpamBlacklist's filter() already takes up a fair amount of processing time (http://noc.wikimedia.org/" [extensions/SpamBlacklist] - 10https://gerrit.wikimedia.org/r/118636 (owner: 10Jackmcbarn) [21:42:45] <welterkj> Hi all, I'm a new volunteer and I have a review in progress for my first contribution. There are several patch sets in my change and green "Reviewed" check marks are sprinkled about. It looks like all files have been inspected but I don't have any up or down votes. How should I interpret this review status? [21:45:41] <hashar> bd808: ori: yeah I was just wondering. Sounds weird to use dsh when we are trying to get rid of it :-]]] [21:46:07] <hashar> ^d: someone added support to Jenkins Job Builder to let it add multiple remotes on a git repository and thus merge branches :D [21:46:13] <ori> hashar: bd808 can just add a self_update() function to scap [21:46:16] <ori> it no longer uses dsh [21:46:18] <^d> Hehe :) [21:46:45] <hashar> ^d: https://review.openstack.org/#/c/80084/3/tests/scm/fixtures/git-multiple-remotes.yaml,unified :D [21:46:50] <bd808> `scap --ensure=latest` [21:47:50] <grrrit-wm> (03PS1) 10Manybubbles: Add integration test for word count [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/118771 [21:50:15] <grrrit-wm> (03CR) 10Cscott: "It would be much better to do this automatically, depending on whether the djvu tools were present." [core] - 10https://gerrit.wikimedia.org/r/102475 (owner: 10Tpt) [21:57:21] <grrrit-wm> (03PS3) 10Jackmcbarn: Unlink/remove blacklisted links during parse [extensions/SpamBlacklist] - 10https://gerrit.wikimedia.org/r/118636 [22:00:04] <werdna> hey, who are the PHPUnit people? [22:02:26] <rdwrer> werdna: chrismcmahon and zeljkof, I guess [22:02:29] <rdwrer> To an extent [22:02:48] <werdna> hmm, they don't seem to be baout [22:02:49] <werdna> about* [22:02:54] <werdna> at least not zelkof [22:06:08] <grrrit-wm> (03CR) 10Chad: [C: 032] Add integration test for word count [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/118771 (owner: 10Manybubbles) [22:06:14] <grrrit-wm> (03Merged) 10jenkins-bot: Add integration test for word count [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/118771 (owner: 10Manybubbles) [22:08:17] <greg-g> werdna: much past zejko's bed time [22:08:22] <greg-g> +l [22:08:27] <werdna> mmm [22:08:46] <hashar> bd808: ori: or use pip :-] package { 'scap': provider => pip, ensure => latest } [22:14:38] <grrrit-wm> (03CR) 10Aaron Schulz: [C: 032] Add two new debug log groups [core] - 10https://gerrit.wikimedia.org/r/111946 (owner: 10IAlex) [22:18:30] <grrrit-wm> (03Merged) 10jenkins-bot: Add two new debug log groups [core] - 10https://gerrit.wikimedia.org/r/111946 (owner: 10IAlex) [22:21:01] <grrrit-wm> (03CR) 10Parent5446: [C: 032] Use preloadFileStat() to speed up syncFileBackend [core] - 10https://gerrit.wikimedia.org/r/118752 (owner: 10Aaron Schulz) [22:25:14] <grrrit-wm> (03Merged) 10jenkins-bot: Use preloadFileStat() to speed up syncFileBackend [core] - 10https://gerrit.wikimedia.org/r/118752 (owner: 10Aaron Schulz) [22:26:22] <grrrit-wm> (03CR) 10Parent5446: [C: 031] SpecialCentralAutoLogin: Clean up javascript [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/118429 (owner: 10Krinkle) [22:30:20] <grrrit-wm> (03CR) 10Aaron Schulz: [C: 032] Correct the destionation of checkLastModified debug messages [core] - 10https://gerrit.wikimedia.org/r/111833 (owner: 10IAlex) [22:31:47] <grrrit-wm> (03CR) 10Parent5446: Link to existing login help page by default from helplogin-url (031 comment) [core] - 10https://gerrit.wikimedia.org/r/83220 (owner: 10Nemo bis) [22:33:23] <grrrit-wm> (03PS3) 10Ori.livneh: Correct the destination of checkLastModified debug messages [core] - 10https://gerrit.wikimedia.org/r/111833 (owner: 10IAlex) [22:33:33] <grrrit-wm> (03CR) 10Ori.livneh: [C: 032] Correct the destination of checkLastModified debug messages [core] - 10https://gerrit.wikimedia.org/r/111833 (owner: 10IAlex) [22:36:06] <grrrit-wm> (03CR) 10Parent5446: HTMLForm: Add daterange type (031 comment) [core] - 10https://gerrit.wikimedia.org/r/118112 (owner: 10Anomie) [22:36:46] <grrrit-wm> (03CR) 10Parent5446: [C: 031] Refactor password validity checking [core] - 10https://gerrit.wikimedia.org/r/118233 (owner: 10CSteipp) [22:36:55] <hashar> meanwhile on beta ori and bd808 break puppet: [22:36:56] <hashar> err: /Stage[main]/Mediawiki::Sync/Git::Clone[mediawiki/tools/scap]/Exec[git_pull_mediawiki/tools/scap]: Could not evaluate: /bin/sh: 1: fetch: not found [22:37:05] <hashar> on deployment-apache01.eqiad.wmflabs [22:37:11] <ori> i'm on it [22:38:23] <grrrit-wm> (03Merged) 10jenkins-bot: Correct the destination of checkLastModified debug messages [core] - 10https://gerrit.wikimedia.org/r/111833 (owner: 10IAlex) [22:39:27] <grrrit-wm> (03CR) 10Aaron Schulz: [C: 032] Make MySQLi work with non-standard port [core] - 10https://gerrit.wikimedia.org/r/109634 (owner: 10Mglaser) [22:41:35] <hashar> and I am heading to bed [22:41:39] <hashar> *wave ori* [22:41:48] <ori> hashar: could you verify the fix if you have a chance? [22:42:04] <hashar> err: /Stage[main]/Mediawiki::Sync/Git::Clone[mediawiki/tools/scap]/Exec[git_pull_mediawiki/tools/scap]/returns: change from notrun to 0 failed: umask 002; /usr/bin/git -c core.sharedRepository=066 pull --quiet returned 128 instead of one of [0] at /etc/puppet/modules/git/manifests/clone.pp:190 [22:42:15] <ori> blargh, i'll debug [22:42:16] <ori> good night [22:42:22] <hashar> you can try out running puppet on the beta machines :D [22:42:33] <grrrit-wm> (03PS10) 10Jdlrobson: Rewrite the navigation links under the heading [extensions/VectorBeta] - 10https://gerrit.wikimedia.org/r/117903 [22:42:35] <grrrit-wm> (03PS10) 10Jdlrobson: Give Vector/Winter Minerva's hamburger menu icon [extensions/VectorBeta] - 10https://gerrit.wikimedia.org/r/117927 [22:43:27] <grrrit-wm> (03Merged) 10jenkins-bot: Make MySQLi work with non-standard port [core] - 10https://gerrit.wikimedia.org/r/109634 (owner: 10Mglaser) [22:43:36] <hashar> ori: deployment-bastion.pmtpa.wmflabs has the issue if it can help you [22:43:40] <grrrit-wm> (03CR) 10Aaron Schulz: [C: 032] "The original hook was just for replicating purges for any "clone" file backends (for FileBackendMultiWrite). Such uses would do duplicate " [core] - 10https://gerrit.wikimedia.org/r/118424 (owner: 10Prod) [22:44:03] * hashar sleeps [22:46:42] <grrrit-wm> (03CR) 10CSteipp: Unlink/remove blacklisted links during parse (031 comment) [extensions/SpamBlacklist] - 10https://gerrit.wikimedia.org/r/118636 (owner: 10Jackmcbarn) [22:47:23] <grrrit-wm> (03CR) 10BryanDavis: [C: 031] "One completely trivial comment on the commit message. Tested locally and it works great." (031 comment) [tools/release] - 10https://gerrit.wikimedia.org/r/118558 (owner: 10Hashar) [22:48:24] <grrrit-wm> (03Merged) 10jenkins-bot: Execute LocalFilePurgeThumbnails hook before purging thumbnails [core] - 10https://gerrit.wikimedia.org/r/118424 (owner: 10Prod) [22:48:45] <grrrit-wm> (03CR) 10Aaron Schulz: [C: 04-1] Pass correct parameter to stat() in checkImages.php (031 comment) [core] - 10https://gerrit.wikimedia.org/r/117027 (owner: 10AalekhN) [22:58:30] <grrrit-wm> (03CR) 10Aaron Schulz: [C: 032] Split revdelete-text on Special:RevisionDelete for each type [core] - 10https://gerrit.wikimedia.org/r/115426 (owner: 10Umherirrender) [22:59:24] <grrrit-wm> (03CR) 10PleaseStand: [C: 04-1] "The commit message claims that this change adds an "Error Msg for missing db username when installing", though it actually changes parserT" [core] - 10https://gerrit.wikimedia.org/r/118742 (owner: 10Pubudu538) [23:02:35] <grrrit-wm> (03Merged) 10jenkins-bot: Split revdelete-text on Special:RevisionDelete for each type [core] - 10https://gerrit.wikimedia.org/r/115426 (owner: 10Umherirrender) [23:05:39] <grrrit-wm> (03CR) 10Chad: [C: 032] Lots of small fixes [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/118763 (owner: 10Manybubbles) [23:05:50] <grrrit-wm> (03Merged) 10jenkins-bot: Lots of small fixes [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/118763 (owner: 10Manybubbles) [23:13:21] <grrrit-wm> (03CR) 10Ori.livneh: [C: 032] Add script to cleanup l10n cache for an inactive MediaWiki version [tools/scap] - 10https://gerrit.wikimedia.org/r/118337 (owner: 10BryanDavis) [23:13:57] <grrrit-wm> (03Merged) 10jenkins-bot: Add script to cleanup l10n cache for an inactive MediaWiki version [tools/scap] - 10https://gerrit.wikimedia.org/r/118337 (owner: 10BryanDavis) [23:19:07] <grrrit-wm> (03CR) 10Deskana: "This is essentially a "Make search results worse" button if it's presented to users. As the person that thinks about user-facing stuff, we" [core] - 10https://gerrit.wikimedia.org/r/118592 (owner: 10Chad) [23:26:25] <grrrit-wm> (03PS7) 10JGonera: Add Compact personal bar beta feature [extensions/VectorBeta] - 10https://gerrit.wikimedia.org/r/99586 [23:26:27] <grrrit-wm> (03PS2) 10JGonera: Add icons to compact personal bar [extensions/VectorBeta] - 10https://gerrit.wikimedia.org/r/117119 [23:26:29] <grrrit-wm> (03CR) 10jenkins-bot: [V: 04-1] Add Compact personal bar beta feature [extensions/VectorBeta] - 10https://gerrit.wikimedia.org/r/99586 (owner: 10JGonera) [23:26:31] <grrrit-wm> (03CR) 10jenkins-bot: [V: 04-1] Add icons to compact personal bar [extensions/VectorBeta] - 10https://gerrit.wikimedia.org/r/117119 (owner: 10JGonera) [23:28:58] <grrrit-wm> (03CR) 10Ori.livneh: [C: 04-1] "Must be merged no sooner than 30 days after I0c9edac35 is deployed." [core] - 10https://gerrit.wikimedia.org/r/117672 (owner: 10Ori.livneh) [23:30:24] <grrrit-wm> (03PS2) 10JGonera: Add watchlist count to compact personal bar [extensions/VectorBeta] - 10https://gerrit.wikimedia.org/r/116920 [23:30:26] <grrrit-wm> (03CR) 10jenkins-bot: [V: 04-1] Add watchlist count to compact personal bar [extensions/VectorBeta] - 10https://gerrit.wikimedia.org/r/116920 (owner: 10JGonera) [23:32:05] <grrrit-wm> (03PS8) 10JGonera: Add Compact personal bar beta feature [extensions/VectorBeta] - 10https://gerrit.wikimedia.org/r/99586 [23:32:21] <grrrit-wm> (03PS3) 10JGonera: Add icons to compact personal bar [extensions/VectorBeta] - 10https://gerrit.wikimedia.org/r/117119 [23:32:35] <grrrit-wm> (03PS7) 10JGonera: Add click tracking to compact personal bar [extensions/VectorBeta] - 10https://gerrit.wikimedia.org/r/117138 [23:32:55] <grrrit-wm> (03PS3) 10JGonera: Add watchlist count to compact personal bar [extensions/VectorBeta] - 10https://gerrit.wikimedia.org/r/116920 [23:33:11] <grrrit-wm> (03CR) 10JGonera: Add Compact personal bar beta feature [extensions/VectorBeta] - 10https://gerrit.wikimedia.org/r/99586 (owner: 10JGonera) [23:33:37] <grrrit-wm> (03CR) 10JGonera: Add watchlist count to compact personal bar [extensions/VectorBeta] - 10https://gerrit.wikimedia.org/r/116920 (owner: 10JGonera) [23:40:34] <chrismcmahon> werdna: actually, you probably want hashar for PHPUnit, what's the question? [23:41:11] <werdna> chrismcmahon: Noticed that install-phpunit.sh is now broken, because PHPUnit 4.0 was released as a PHAR, which is incompatible with our wrapper script [23:41:17] <werdna> https://gerrit.wikimedia.org/r/#/c/118666/ [23:42:52] <chrismcmahon> werdna: you definitely want hashar, I put him on the review list [23:43:00] <werdna> cheers