[00:00:41] (03CR) 10Krinkle: Replace hidesig module with a more robust implementation (031 comment) [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/102076 (owner: 10TTO) [00:04:13] (03CR) 10Krinkle: "ping" [core] - 10https://gerrit.wikimedia.org/r/64569 (owner: 10Hashar) [00:22:47] (03PS2) 10CSteipp: Refactor password validity checking [core] - 10https://gerrit.wikimedia.org/r/118233 [00:44:32] (03PS1) 10Jforrester: Update OOjs UI to v0.1.0-pre (46ccd5b3a7) [core] - 10https://gerrit.wikimedia.org/r/118411 [01:06:27] (03CR) 10Anomie: [C: 04-2] "No. This is already a bit of a hack, we don't need to make it a *gigantic* hack." [core] - 10https://gerrit.wikimedia.org/r/118336 (owner: 10Aaron Schulz) [01:06:38] (03PS1) 10Chad: Clean up HHVM build [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/118418 [01:07:34] (03CR) 10Chad: [C: 032] "Already tested & live." [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/118418 (owner: 10Chad) [01:07:51] (03Merged) 10jenkins-bot: Clean up HHVM build [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/118418 (owner: 10Chad) [01:08:19] mwalker, just added partial support to kotasm / tassembly [01:14:29] (03CR) 10Aaron Schulz: "This won't show up to users." [core] - 10https://gerrit.wikimedia.org/r/118336 (owner: 10Aaron Schulz) [01:14:34] (03CR) 10MaxSem: [C: 032 V: 032] Allow minor Express updates, pin Jade [extensions/Minifier] - 10https://gerrit.wikimedia.org/r/118387 (owner: 10MaxSem) [01:15:10] (03CR) 10Anomie: "There are comments being added to bug 19415 that could use consideration before merging." [core] - 10https://gerrit.wikimedia.org/r/118135 (owner: 10MaxSem) [01:16:16] (03PS1) 10MaxSem: Use cURL to keep the connection alive [extensions/Minifier] - 10https://gerrit.wikimedia.org/r/118419 [01:16:22] (03CR) 10Anomie: "I still don't like this in the api.php entry point. Especially now that it's not really part of the API at all, apparently." [core] - 10https://gerrit.wikimedia.org/r/118336 (owner: 10Aaron Schulz) [01:17:48] (03CR) 10MarkAHershberger: [C: 04-1] "Just putting a marker here requesting you avod merging till we branch 1.23." [core] - 10https://gerrit.wikimedia.org/r/118345 (owner: 10Jdlrobson) [01:18:21] ori: is a special page fine for 118336? [01:18:48] it would need to do shutdown and exit() itself...but I guess that can work [01:19:20] (03CR) 10MarkAHershberger: [C: 04-1] "Just putting a note here to request avoiding merging till REL1_23 is branched." [skins] - 10https://gerrit.wikimedia.org/r/118347 (owner: 10Jdlrobson) [01:19:54] (03CR) 10Krinkle: "ping" [integration/jenkins] - 10https://gerrit.wikimedia.org/r/90428 (owner: 10Hashar) [01:22:27] (03CR) 10Krinkle: [C: 04-1] "This repo doesn't contain any skins, only submodules. Doesn't seem natural to do that now." [skins] - 10https://gerrit.wikimedia.org/r/118347 (owner: 10Jdlrobson) [01:23:32] (03CR) 10Krinkle: WIP: Provide a new home for CologneBlue and Modern (032 comments) [skins] - 10https://gerrit.wikimedia.org/r/118347 (owner: 10Jdlrobson) [01:31:23] Hi Jasper_Deng [01:31:29] hi Krenair [01:31:31] Can I help you with something? [01:31:41] * Jasper_Deng knows Krenair saw his /version [01:31:45] :P [01:31:47] b/c I normally expect you to be on znc [01:32:11] yeah, I am on ZNC [01:32:55] * Jasper_Deng could possibly see Krenair at Wikimania this summer [01:33:22] Jasper_Deng, you might be coming? [01:33:27] yes [01:33:32] great [01:33:46] Ever been to the UK before? [01:33:56] technically yes, on Grand Turk island in the Caribbean :P [01:34:03] Heh :P [01:34:15] (but never to the UK's mainland) [01:34:23] Okay, what I should have said was, ever been to GB before? [01:34:34] yeah I haven't [01:35:07] gonna be a long plane ride [01:36:03] Yep, 11 hours IIRC [01:36:33] what jet lag [01:42:28] (03PS1) 10Chad: Remove $wgTitle from all maintenance scripts [core] - 10https://gerrit.wikimedia.org/r/118420 [01:46:35] i'm new to gerrit and trying to use git review -s [01:46:42] it's saying it couldn't connect to gerrit over ssh [01:47:42] i've tried logging in via putty and I get in, but it gives me the message that interactive shells aren't allowed [01:49:14] am I doing something wrong, or should I try to push over https? [01:54:12] (03PS1) 10Chad: Remove pointless $wgTitle and commented global mess [extensions/WYSIWYG] - 10https://gerrit.wikimedia.org/r/118422 [02:07:34] (03PS1) 10Parent5446: Test commit (DO NOT MERGE) [core] - 10https://gerrit.wikimedia.org/r/118423 [02:09:54] (03Abandoned) 10Parent5446: Test commit (DO NOT MERGE) [core] - 10https://gerrit.wikimedia.org/r/118423 (owner: 10Parent5446) [02:11:15] (03CR) 10Chad: "But I wanted to merge :(" [core] - 10https://gerrit.wikimedia.org/r/118423 (owner: 10Parent5446) [02:11:55] (03PS1) 10Prod: Execute LocalFilePurgeThumbnails hook before purging thumbnails [core] - 10https://gerrit.wikimedia.org/r/118424 [02:25:45] anyone know how to use github? [02:27:52] depends on what you want to do... [02:28:42] I have a PR pending [02:29:17] I want to submit a new PR which depends on the old one (is "stacked" on top of the old one, I am told is the relevant jargon) [02:30:06] so I created a new branch which has the old PR branch as its base [02:30:15] then pushed my changes into it [02:30:28] that was what I was going to suggest [02:30:48] but it still gives you the pull request already exists error? [02:31:04] now when I click the PR button on that branch, the UI does not give me any confidence that it is not just going to request review of the whole two branches [02:31:32] I can try it, I guess, if this sounds sane so far [02:31:53] that's the process as I've experienced it [02:33:27] https://github.com/facebook/hhvm/pull/2044 [02:33:56] seems broken to me [02:34:23] aye... not sure what to tell you [02:34:44] might try jumping into #github and seeing what the yhave to say [02:35:56] good luck! /me has to dash off to the sports store before they close [02:43:44] i've got an extension on SVN [02:43:48] how do i get it migrated to git? [02:44:28] https://www.mediawiki.org/wiki/Gerrit somewhere. [02:45:05] ah ok [02:45:06] thanks [02:45:48] I think there's a subpage somewhere where you can request the creation of a new repo. [02:45:57] Once you have a repo, you can use svn2git or something. [02:46:02] Or perhaps someone else will do it for you. [02:46:05] yea i found it :D [03:00:12] (03PS6) 10Welterkj: use imagemap class for HTML rendering [extensions/GraphViz] - 10https://gerrit.wikimedia.org/r/111475 [03:10:47] (03CR) 10Krinkle: "Various minor issues and code quality issues found. Most (if not all) of these will be fixed in the I2d7f27520f37991d3975920d6a70233475630" (035 comments) [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/107336 (owner: 10CSteipp) [03:25:58] Krinkle, do you know if jsduck has any backwards-compatible breaks in later versions? [03:26:05] Yes [03:26:11] Use 4.x [03:27:07] that's why we haven't upgrade to 5.x and that oojs-core is not using jsduck on jenkins right now, and also why VE has both a config for 4.x and 5.x [03:27:34] It would be nice for GuidedTour to upgrade to get @inheritdoc [03:27:43] Once core, and other repos are compatible, we'll upgrade to 5.x, but gonna take some effort and not something I can prioritise right now [03:27:44] How do we set Jenkins up to build jsduck? [03:27:48] If you can't use inheritdoc, you're doing it wrong :P [03:28:00] That's been around more than long enough [03:28:10] @localdoc is a supplement to @inheritdoc. [03:28:27] In the cases I'm eyeing it for, it's a wrapper, rather than inheritance. [03:29:34] Well, yeah, that's 5.x, so, can't use that. [03:29:40] Unless you implement it in a plugin [03:30:20] Just repeat for now, or do a minimal @param and one-line description and make a link to the other one instead of embedding actually @inheritdoc'ing [03:30:54] Yeah, the latter is what I'm doing? [03:30:59] k [03:31:12] Krinkle, so the Jenkins job uses 4.x, right? Is that setup in layout.yaml? [03:31:16] Yes [03:31:19] There is a macro for it [03:31:33] Cool, let me try to do that. [03:31:38] See mwcore, multimediaviewer and visualeditor for examples [03:31:46] You should have both a -test and a -publish one [03:32:08] gem install jsduck --version '< 5.0' will install latest 4.x [03:32:34] or just specify '4.10.4' to be safe [03:33:01] (number is output on the bottom right) https://doc.wikimedia.org/VisualEditor/master/ [03:44:01] (03PS1) 10Mattflaschen: Test and publish jsduck for GuidedTour [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/118426 [03:44:12] (03CR) 10jenkins-bot: [V: 04-1] Test and publish jsduck for GuidedTour [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/118426 (owner: 10Mattflaschen) [03:51:11] (03PS2) 10Mattflaschen: Test and publish jsduck for GuidedTour [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/118426 [03:52:12] Krinkle, is that layoutdiff failure on patch set 2 an actual problem? [03:52:47] No, that just means you made a change [03:53:04] useful to detect that commits that only refactor indeed make no change [03:53:12] because it's all template expansion [03:53:28] the first few diff lines at https://integration.wikimedia.org/ci/job/integration-zuul-layoutdiff/954/console are just race condition [03:53:33] the bottom + added lines are true [03:53:41] + Job mwext-GuidedTour-doc-publish [03:54:15] How come mwext-GuidedTour-doc-test isn't there? [03:54:26] It is [03:54:29] https://integration.wikimedia.org/ci/job/integration-zuul-layoutdiff/954/consoleFull [03:55:23] Thanks, I never noticed that link before. [03:56:02] superm401: You have to create that job first though, it doesn't exist [03:56:05] (jenkins-job-builder-config) [03:56:22] https://github.com/wikimedia/integration-jenkins-job-builder-config/blob/master/mediawiki-extensions.yaml [03:56:47] Right now both extensiosn that use it have a non-standard config because they use custom stuff [03:56:49] Oh, okay, I was wondering why only VisualEditor had an explicit -jsduck, and how it knew it was jsduck docs. [03:57:41] superm401: Also, remove it from the 'check' pipeline [03:57:50] GuidedTour has a custom config with MetaTag.rb [03:57:53] that means code execution [03:58:47] Ah, good call [03:59:09] superm401: For the GuidedTour-doc-test, don't follow MMV or VE example, GuidedTour doesn't need the generate.sh script, it has a plain --config [03:59:19] so instead of shell builder, use the jsduck macro and pass it the config [03:59:55] Like here for example [03:59:56] https://github.com/wikimedia/integration-jenkins-job-builder-config/blob/b1ef441138aadb2c37e9f25a3cb49484918a0ff8/misc.yaml#L7 [03:59:56] (03PS3) 10Mattflaschen: Test and publish jsduck for GuidedTour [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/118426 [04:02:01] (03CR) 10Parent5446: "Is phpcs voting now?" [core] - 10https://gerrit.wikimedia.org/r/118256 (owner: 10leucosticte) [04:02:55] shoot, I accidentally commited to 'master' instead of checking out a new branch first. How do I reset that? anyone knows? [04:03:13] (this is post 'git commit' and pre 'git review') [04:03:17] mooeypoo: git branch master -m newtopic [04:03:31] that renames your local master branch [04:03:41] next time you try to checkout 'master' it'll re-create it from origin/master [04:03:42] Krinkle, and then I just go 'git review' ? [04:04:31] assuming you didn't get an error, and git status tells you you are indeed on that newly created branch, and that "git log" shows you the branch you're on looks like what you expect (with your commit on top) [04:04:32] hm [04:04:33] yes [04:04:58] ok, git log shows my branch on top [04:05:02] and 'git show HEAD' looks good [04:05:11] and i'm on a new branch according to git status... so... that should work [04:05:13] ... I hope [04:05:14] (03CR) 10Krinkle: "No, itsn't and never has been. That's the postmerge job." [core] - 10https://gerrit.wikimedia.org/r/118256 (owner: 10leucosticte) [04:05:19] if I did it right :P [04:05:51] mooeypoo: btw, save-the-world trick: omit 'HEAD' from "git show" and get the same thing. [04:06:24] ooh thanks! [04:06:47] also, as being a magic alias, it isn't case sensitive (all those camel cases, what an effort, right? git show head, of course in documentation one should probably write out 'HEAD' for prettyness, but locally you gotta save every effort you can :) [04:07:40] same for 'git log', though I assume you omitted it from that already (for some reason it makes more sense in git-log than git-show, though both do the same, they take an argument for top commit, and default to HEAD) [04:08:01] Krinkle, hmm, is VisualEditor-jsduck the equivalent of -test or -publish? [04:08:11] superm401: equiv of -test [04:08:21] wait, "head" is not case sensitive? [04:08:41] mooeypoo, sometimes. :) [04:09:09] Although, now that I'm testing, it seems to be (I recall from a while back it wasn't in one case, though) [04:09:17] Well, After University Writing (Especially Scientific Publications) *My* Head is CamelCase. [04:09:23] If youre interacting with the file system, it's different of course. Though not always, which is why git can't allow you to have a branch named head (thanks Windows!), and figured it might as well allow it as shortcut as being an illegal branch name. [04:09:38] ha [04:09:52] git show head isn't working for me [04:10:07] works in my head, broke in production :) [04:10:16] works on MY HEAD [04:10:19] in* [04:10:25] :) [04:10:33] I think it did use to work though. [04:10:34] superm401: git version? [04:10:45] 1.7.10.4 [04:10:54] Works for me, tested it again locally, git v1.9.0 [04:11:21] fatal: ambiguous argument 'head': unknown revision or path not in the working tree. [04:11:23] Guess that is kind of old. [04:11:31] That's what I get for being on Debian stable. [04:11:40] On Mac, homebrew has latest git. On Ubuntu, I'd use ppa:git-core/ppa [04:11:43] git version 1.8.3.2 [04:11:46] http://askubuntu.com/a/279175 [04:11:50] I started on testing, but it became stable. :) [04:11:56] I'll probably reupgrade to testing pretty soon. [04:12:02] k [04:13:28] I upgraded from 12.04 LTS to 13.10, and ended up spending half hte night convincing Ubuntu that my video card works. [04:13:35] I am a little update traumatized. [04:14:10] I did feel like a total pro working my way with terminal, though. That was nice.... for.. a little while. [04:17:18] (03PS1) 10Mattflaschen: Add jobs for GuidedTour jsduck build [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/118428 [04:19:49] (03PS4) 10Mattflaschen: Test and publish jsduck for GuidedTour [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/118426 [04:27:11] (03PS2) 10Mattflaschen: Add jobs for GuidedTour jsduck build [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/118428 [04:33:57] (03PS1) 10Krinkle: SpecialCentralAutoLogin: Clean up javascript [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/118429 [04:33:59] (03PS1) 10Krinkle: SpecialCentralAutoLogin: Move javascript to separate files and minify [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/118430 [04:34:26] (03PS2) 10Krinkle: SpecialCentralAutoLogin: Move javascript to separate files for linting [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/118430 [04:35:57] (03CR) 10Krinkle: Add jobs for GuidedTour jsduck build (031 comment) [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/118428 (owner: 10Mattflaschen) [04:36:48] (03CR) 10Krinkle: For caching, avoid passing returnto to Special:CentralAutoLogin (031 comment) [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/86265 (owner: 10Anomie) [04:38:53] (03CR) 10Krinkle: "mediawiki.org isn't the only place that counts as documentation. First and foremost is the documentation the repository." [core] - 10https://gerrit.wikimedia.org/r/90453 (owner: 10EBernhardson) [04:53:32] (03CR) 10Krinkle: "ping" [core] - 10https://gerrit.wikimedia.org/r/83942 (owner: 10Aaron Schulz) [05:59:21] (03PS3) 10Mattflaschen: WIP: Refactor and add non-linear tours [extensions/GuidedTour] - 10https://gerrit.wikimedia.org/r/116228 [05:59:52] (03CR) 10jenkins-bot: [V: 04-1] WIP: Refactor and add non-linear tours [extensions/GuidedTour] - 10https://gerrit.wikimedia.org/r/116228 (owner: 10Mattflaschen) [06:02:38] (03CR) 10Mattflaschen: "There's general progress and changes throughout. It's still not ready for a full review, but I would appreciate a look-through (I also t" [extensions/GuidedTour] - 10https://gerrit.wikimedia.org/r/116228 (owner: 10Mattflaschen) [06:49:14] (03PS22) 10Bencmq: Add "Thanks" for comments on Flow boards [extensions/Thanks] - 10https://gerrit.wikimedia.org/r/115557 (owner: 10Wctaiwan) [06:53:38] (03CR) 10Bencmq: "PS22: addressed issues in PS21 comments." [extensions/Thanks] - 10https://gerrit.wikimedia.org/r/115557 (owner: 10Wctaiwan) [06:54:08] (03CR) 10Bencmq: Add "Thanks" for comments on Flow boards (036 comments) [extensions/Thanks] - 10https://gerrit.wikimedia.org/r/115557 (owner: 10Wctaiwan) [07:51:13] (03CR) 10Aaron Schulz: [C: 032] Remove $wgTitle from all maintenance scripts [core] - 10https://gerrit.wikimedia.org/r/118420 (owner: 10Chad) [07:55:01] (03Merged) 10jenkins-bot: Remove $wgTitle from all maintenance scripts [core] - 10https://gerrit.wikimedia.org/r/118420 (owner: 10Chad) [09:02:12] (03PS1) 10Hashar: Disable mediawiki-core-regression-phpcs-HEAD [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/118434 [09:04:32] (03CR) 10Hashar: [C: 032] Disable mediawiki-core-regression-phpcs-HEAD [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/118434 (owner: 10Hashar) [09:04:36] (03Merged) 10jenkins-bot: Disable mediawiki-core-regression-phpcs-HEAD [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/118434 (owner: 10Hashar) [09:21:16] (03CR) 10Matthias Mullie: [C: 04-1] "Should only be done once https://bugzilla.wikimedia.org/show_bug.cgi?id=62528 is addressed" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/116985 (owner: 10Matthias Mullie) [09:37:47] (03PS1) 10IAlex: Remove request_with_session/request_without_session from showCacheStats.php [core] - 10https://gerrit.wikimedia.org/r/118437 [10:29:30] (03PS1) 10Maduranga: fix Bug 46453 - Uzbek: Change date and decimal separators [core] - 10https://gerrit.wikimedia.org/r/118440 [11:00:03] (03PS1) 10Zfilipin: Run Ruby lint and build the gem for mediawiki/ruby/api repository [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/118441 [11:14:09] (03PS3) 10Nikerabbit: I18n file finder [extensions/LocalisationUpdate] (json-rewrite) - 10https://gerrit.wikimedia.org/r/117181 [11:14:11] (03PS4) 10Nikerabbit: File readers [extensions/LocalisationUpdate] (json-rewrite) - 10https://gerrit.wikimedia.org/r/117177 [11:14:13] (03PS1) 10Nikerabbit: Fetchers [extensions/LocalisationUpdate] (json-rewrite) - 10https://gerrit.wikimedia.org/r/118444 [11:14:15] (03PS1) 10Nikerabbit: Updater class [extensions/LocalisationUpdate] (json-rewrite) - 10https://gerrit.wikimedia.org/r/118445 [11:14:17] (03PS1) 10Nikerabbit: Rewritten update script and configuration [extensions/LocalisationUpdate] (json-rewrite) - 10https://gerrit.wikimedia.org/r/118446 [11:15:18] (03CR) 10Nikerabbit: File readers [extensions/LocalisationUpdate] (json-rewrite) - 10https://gerrit.wikimedia.org/r/117177 (owner: 10Nikerabbit) [11:15:48] (03Abandoned) 10Nikerabbit: [WIP] LU rewrite [extensions/LocalisationUpdate] (json-rewrite) - 10https://gerrit.wikimedia.org/r/117385 (owner: 10Nikerabbit) [11:17:30] (03PS2) 10Zfilipin: Forgot to add Amir to authors [ruby/api] - 10https://gerrit.wikimedia.org/r/116499 [11:18:33] (03PS2) 10Nikerabbit: Rewritten update script and configuration [extensions/LocalisationUpdate] (json-rewrite) - 10https://gerrit.wikimedia.org/r/118446 [11:18:35] (03PS2) 10Nikerabbit: Updater class [extensions/LocalisationUpdate] (json-rewrite) - 10https://gerrit.wikimedia.org/r/118445 [11:19:27] RoanKattouw_away: https://gerrit.wikimedia.org/r/#/q/status:open+project:mediawiki/extensions/LocalisationUpdate+branch:json-rewrite,n,z [11:22:53] (03PS1) 10Matthias Mullie: Add selectors for Parsoid-output external links [core] - 10https://gerrit.wikimedia.org/r/118447 [11:24:09] (03PS1) 10Matthias Mullie: Add selector for Parsoid-output external links [extensions/Collection] - 10https://gerrit.wikimedia.org/r/118448 [11:26:17] (03PS1) 10Matthias Mullie: Add selector for Parsoid-output external links [extensions/Nostalgia] - 10https://gerrit.wikimedia.org/r/118450 [11:27:14] (03PS1) 10Matthias Mullie: Add selector for Parsoid-output external links [extensions/VectorBeta] - 10https://gerrit.wikimedia.org/r/118451 [11:29:13] (03PS1) 10Matthias Mullie: Add selectors for Parsoid-output external links [extensions/skins] - 10https://gerrit.wikimedia.org/r/118452 [11:44:21] (03PS1) 10Zfilipin: Zuul configuration for mediawiki/ruby/api repository [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/118454 [11:49:55] (03CR) 10Gabrielchihonglee: [C: 031] Add Fixed header experiment to Vector Beta [extensions/VectorBeta] - 10https://gerrit.wikimedia.org/r/107523 (owner: 10Jdlrobson) [11:54:25] (03CR) 10Hashar: [C: 032] "\O/" [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/118454 (owner: 10Zfilipin) [11:54:30] (03Merged) 10jenkins-bot: Zuul configuration for mediawiki/ruby/api repository [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/118454 (owner: 10Zfilipin) [11:55:16] (03PS1) 10Hashar: Jenkins job validation (DO NOT SUBMIT) [ruby/api] - 10https://gerrit.wikimedia.org/r/118455 [11:55:18] (03CR) 10jenkins-bot: [V: 04-1] Jenkins job validation (DO NOT SUBMIT) [ruby/api] - 10https://gerrit.wikimedia.org/r/118455 (owner: 10Hashar) [11:56:06] (03CR) 10Hashar: "recheck" [ruby/api] - 10https://gerrit.wikimedia.org/r/118455 (owner: 10Hashar) [11:56:57] (03Abandoned) 10Hashar: Jenkins job validation (DO NOT SUBMIT) [ruby/api] - 10https://gerrit.wikimedia.org/r/118455 (owner: 10Hashar) [11:57:55] (03PS3) 10Zfilipin: Forgot to add Amir to authors [ruby/api] - 10https://gerrit.wikimedia.org/r/116499 [11:58:56] (03CR) 10Zfilipin: [C: 032] Forgot to add Amir to authors [ruby/api] - 10https://gerrit.wikimedia.org/r/116499 (owner: 10Zfilipin) [11:58:58] (03Merged) 10jenkins-bot: Forgot to add Amir to authors [ruby/api] - 10https://gerrit.wikimedia.org/r/116499 (owner: 10Zfilipin) [11:59:33] (03CR) 10Nikerabbit: fix Bug 46453 - Uzbek: Change date and decimal separators (032 comments) [core] - 10https://gerrit.wikimedia.org/r/118440 (owner: 10Maduranga) [12:02:57] (03PS2) 10Zfilipin: Refactor the library [ruby/api] - 10https://gerrit.wikimedia.org/r/116632 (owner: 10JGonera) [12:05:00] Nikerabbit: how convenient that you used a consistent topic, the link I added to the RfC is always up to date :) [12:05:08] (03CR) 10Zfilipin: [C: 032] Refactor the library [ruby/api] - 10https://gerrit.wikimedia.org/r/116632 (owner: 10JGonera) [12:05:10] (03Merged) 10jenkins-bot: Refactor the library [ruby/api] - 10https://gerrit.wikimedia.org/r/116632 (owner: 10JGonera) [12:05:38] (03PS2) 10Zfilipin: Adding a basic delete_page function and adding more error handling [ruby/api] - 10https://gerrit.wikimedia.org/r/116633 (owner: 10JGonera) [12:07:05] (03CR) 10Zfilipin: [C: 032] Adding a basic delete_page function and adding more error handling [ruby/api] - 10https://gerrit.wikimedia.org/r/116633 (owner: 10JGonera) [12:07:07] (03Merged) 10jenkins-bot: Adding a basic delete_page function and adding more error handling [ruby/api] - 10https://gerrit.wikimedia.org/r/116633 (owner: 10JGonera) [12:07:21] (03PS2) 10Zfilipin: Update readme with #delete_page [ruby/api] - 10https://gerrit.wikimedia.org/r/116634 (owner: 10JGonera) [12:07:38] (03CR) 10Zfilipin: [C: 032] Update readme with #delete_page [ruby/api] - 10https://gerrit.wikimedia.org/r/116634 (owner: 10JGonera) [12:07:40] (03Merged) 10jenkins-bot: Update readme with #delete_page [ruby/api] - 10https://gerrit.wikimedia.org/r/116634 (owner: 10JGonera) [12:07:50] (03PS2) 10Zfilipin: Add Client#create_account [ruby/api] - 10https://gerrit.wikimedia.org/r/116635 (owner: 10JGonera) [12:09:24] (03CR) 10Zfilipin: [C: 032] Add Client#create_account [ruby/api] - 10https://gerrit.wikimedia.org/r/116635 (owner: 10JGonera) [12:09:26] (03Merged) 10jenkins-bot: Add Client#create_account [ruby/api] - 10https://gerrit.wikimedia.org/r/116635 (owner: 10JGonera) [12:10:22] (03CR) 10Hashar: [C: 032] "Deployed by Zeljkof" [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/118441 (owner: 10Zfilipin) [12:10:39] (03Merged) 10jenkins-bot: Run Ruby lint and build the gem for mediawiki/ruby/api repository [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/118441 (owner: 10Zfilipin) [12:14:36] (03CR) 10Daniel Friesen: "I'm a bit mixed on this. We don't really excessively support IE6. But this goes and adds attribute selectors to a bunch of selectors that " [core] - 10https://gerrit.wikimedia.org/r/118447 (owner: 10Matthias Mullie) [12:27:09] (03PS1) 10Zfilipin: Release version 0.1.0 of the gem [ruby/api] - 10https://gerrit.wikimedia.org/r/118456 [12:27:39] (03CR) 10Manybubbles: [C: 032] Simplify error output a tad in updateOneSearchIndexConfig [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/118386 (owner: 10Chad) [12:28:18] (03PS4) 1001tonythomas: Implementing HTML Email [core] - 10https://gerrit.wikimedia.org/r/115399 [12:29:06] (03CR) 10Tobias Gritschacher: [C: 031] Release version 0.1.0 of the gem [ruby/api] - 10https://gerrit.wikimedia.org/r/118456 (owner: 10Zfilipin) [12:30:08] (03CR) 10Manybubbles: Simplify getIndexSuffixForNamespace() logic a tiny bit (031 comment) [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/118382 (owner: 10Chad) [12:33:57] (03PS2) 10Zfilipin: Release version 0.1.0 of the gem [ruby/api] - 10https://gerrit.wikimedia.org/r/118456 [12:34:43] (03CR) 10Zfilipin: [C: 032] Release version 0.1.0 of the gem [ruby/api] - 10https://gerrit.wikimedia.org/r/118456 (owner: 10Zfilipin) [12:34:45] (03Merged) 10jenkins-bot: Release version 0.1.0 of the gem [ruby/api] - 10https://gerrit.wikimedia.org/r/118456 (owner: 10Zfilipin) [12:37:11] !bug 62149 [12:37:11] https://bugzilla.wikimedia.org/buglist.cgi?quicksearch=62149 [12:37:16] aude: ^ see ;) [12:37:27] ah [12:53:53] (03PS1) 10Zfilipin: Fixed "gem build" warnings [ruby/api] - 10https://gerrit.wikimedia.org/r/118459 [12:56:10] (03PS2) 10Zfilipin: Fixed "gem build" warnings [ruby/api] - 10https://gerrit.wikimedia.org/r/118459 [12:59:07] (03PS1) 10Zfilipin: Fixed gem home page [ruby/api] - 10https://gerrit.wikimedia.org/r/118460 [12:59:55] (03CR) 10Manybubbles: [C: 032] Fixed "gem build" warnings [ruby/api] - 10https://gerrit.wikimedia.org/r/118459 (owner: 10Zfilipin) [12:59:57] (03Merged) 10jenkins-bot: Fixed "gem build" warnings [ruby/api] - 10https://gerrit.wikimedia.org/r/118459 (owner: 10Zfilipin) [13:00:56] (03CR) 10Manybubbles: [C: 032] Fixed gem home page [ruby/api] - 10https://gerrit.wikimedia.org/r/118460 (owner: 10Zfilipin) [13:00:58] (03Merged) 10jenkins-bot: Fixed gem home page [ruby/api] - 10https://gerrit.wikimedia.org/r/118460 (owner: 10Zfilipin) [13:08:00] (03CR) 10Siebrand: [C: 04-1] "i18n reviewed." (032 comments) [core] - 10https://gerrit.wikimedia.org/r/118440 (owner: 10Maduranga) [13:23:13] (03PS1) 10Bencmq: Add integration test for flowthank API [extensions/Thanks] - 10https://gerrit.wikimedia.org/r/118461 [13:26:54] Anybody know what's the different purposes of the repos in git.wikimedia.org vs. gerrit.wikimedia.org? [13:35:37] (03PS3) 10Hashar: Add jobs for GuidedTour jsduck build [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/118428 (owner: 10Mattflaschen) [13:38:48] (03PS13) 10AndyRussG: WIP Add persistence objects and tests [extensions/Campaigns] (wip/editorcampaigns) - 10https://gerrit.wikimedia.org/r/116221 [14:21:07] (03CR) 10Siebrand: [C: 04-1] "i18n/L10n reviewed." (036 comments) [extensions/GraphViz] - 10https://gerrit.wikimedia.org/r/111475 (owner: 10Welterkj) [14:24:09] (03PS3) 10Nikerabbit: Rewritten update script and configuration [extensions/LocalisationUpdate] (json-rewrite) - 10https://gerrit.wikimedia.org/r/118446 [14:29:53] (03CR) 10Hashar: Add jobs for GuidedTour jsduck build (031 comment) [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/118428 (owner: 10Mattflaschen) [14:30:03] (03CR) 10Hashar: [C: 032] "Deployed" [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/118428 (owner: 10Mattflaschen) [14:30:21] (03Merged) 10jenkins-bot: Add jobs for GuidedTour jsduck build [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/118428 (owner: 10Mattflaschen) [14:31:09] (03PS5) 10Hashar: Test and publish jsduck for GuidedTour [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/118426 (owner: 10Mattflaschen) [14:31:21] Was MultiMediaviewers code changed drastically lately ? I dont see many of the components that existed in the latest update. like the initializeInterface function completely. [14:32:19] was checking with my patch https://gerrit.wikimedia.org/r/#/c/108317/8/resources/mmv/mmv.lightboxinterface.js [14:32:24] (03CR) 10Hashar: [C: 032] "Excellent, thank you :-]" [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/118426 (owner: 10Mattflaschen) [14:32:27] (03Merged) 10jenkins-bot: Test and publish jsduck for GuidedTour [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/118426 (owner: 10Mattflaschen) [14:32:32] (03CR) 10Nikerabbit: HTMLForm: Add daterange type (031 comment) [core] - 10https://gerrit.wikimedia.org/r/118112 (owner: 10Anomie) [14:33:55] (03CR) 10Aude: [C: 04-1] "I would keep the is_object() check for title, although it probably is not needed." (031 comment) [extensions/WYSIWYG] - 10https://gerrit.wikimedia.org/r/118422 (owner: 10Chad) [14:33:57] hoo: you around ? [14:34:06] tonythomas: Yes, but a bit busy [14:34:23] (03CR) 10Nikerabbit: HTMLForm: Add daterange type (032 comments) [core] - 10https://gerrit.wikimedia.org/r/118112 (owner: 10Anomie) [14:34:25] (03PS1) 10Hashar: Link to GuidedTour documentation [integration/docroot] - 10https://gerrit.wikimedia.org/r/118465 [14:34:39] hoo: ok. can you go through my query earlier on the change of Multimediaviewers codebase ? [14:34:45] (03CR) 10Hashar: [C: 032] Link to GuidedTour documentation [integration/docroot] - 10https://gerrit.wikimedia.org/r/118465 (owner: 10Hashar) [14:34:48] (03Merged) 10jenkins-bot: Link to GuidedTour documentation [integration/docroot] - 10https://gerrit.wikimedia.org/r/118465 (owner: 10Hashar) [14:34:55] I can have a quick glance [14:35:00] hoo: I don't see many of the components that existed in the latest update. like the initializeInterface function [14:35:33] hoo: I was trying to edit something in my merged patch https://gerrit.wikimedia.org/r/#/c/108317/ and now the function iteself is nowhere there [14:36:37] (03PS1) 10Hashar: Mention doc.wikimedia.org on docroot postmerge job [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/118466 [14:36:46] (03CR) 10Hashar: [C: 032] Mention doc.wikimedia.org on docroot postmerge job [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/118466 (owner: 10Hashar) [14:37:03] tonythomas: https://gerrit.wikimedia.org/r/116921 [14:37:16] that commit changed a lot [14:37:22] and might have removed what you'Re looking for [14:38:48] (03PS1) 10Hashar: Adjust builder for GuidedTour doc [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/118467 [14:39:36] (03CR) 10Hashar: "Sorry follow up is in https://gerrit.wikimedia.org/r/#/c/118467/" [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/118428 (owner: 10Mattflaschen) [14:39:46] (03CR) 10Hashar: [C: 032] Adjust builder for GuidedTour doc [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/118467 (owner: 10Hashar) [14:40:05] (03Merged) 10jenkins-bot: Adjust builder for GuidedTour doc [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/118467 (owner: 10Hashar) [14:40:58] (03CR) 10Aaron Schulz: [C: 032] Remove request_with_session/request_without_session from showCacheStats.php [core] - 10https://gerrit.wikimedia.org/r/118437 (owner: 10IAlex) [14:44:29] (03Merged) 10jenkins-bot: Remove request_with_session/request_without_session from showCacheStats.php [core] - 10https://gerrit.wikimedia.org/r/118437 (owner: 10IAlex) [14:49:51] (03PS3) 10BryanDavis: Force l10n rebuild after bootstrapping [tools/scap] - 10https://gerrit.wikimedia.org/r/117821 [15:11:23] (03CR) 10Siebrand: "Follow-ups." (032 comments) [core] - 10https://gerrit.wikimedia.org/r/118112 (owner: 10Anomie) [15:12:52] (03CR) 10Siebrand: [C: 04-1] "i18n/L10n reviewed." [core] - 10https://gerrit.wikimedia.org/r/118112 (owner: 10Anomie) [15:13:24] (03PS2) 10Hashar: Mention doc.wikimedia.org on docroot postmerge job [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/118466 [15:14:09] (03CR) 10Hashar: [C: 032] Mention doc.wikimedia.org on docroot postmerge job [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/118466 (owner: 10Hashar) [15:14:13] (03Merged) 10jenkins-bot: Mention doc.wikimedia.org on docroot postmerge job [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/118466 (owner: 10Hashar) [15:16:36] (03PS1) 10Hashar: Tweak success message for operations-puppet-doc [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/118471 [15:16:47] (03CR) 10Hashar: [C: 032] Tweak success message for operations-puppet-doc [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/118471 (owner: 10Hashar) [15:16:52] (03Merged) 10jenkins-bot: Tweak success message for operations-puppet-doc [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/118471 (owner: 10Hashar) [15:32:41] (03PS1) 10Phuedx: [WIP] Show the Edit tab under a magnifying glass [extensions/GettingStarted] - 10https://gerrit.wikimedia.org/r/118478 [15:32:48] (03CR) 10jenkins-bot: [V: 04-1] [WIP] Show the Edit tab under a magnifying glass [extensions/GettingStarted] - 10https://gerrit.wikimedia.org/r/118478 (owner: 10Phuedx) [15:34:53] tonythomas: We've been refactoring it a lot, yeah [15:37:36] rdwrer: ok. Anyway, I will send a fresh PS fixing the exit lightbox interface on backdrop click and the maximise issue pointed here https://bugzilla.wikimedia.org/show_bug.cgi?id=62578 [15:43:35] anomie: around? [15:44:05] jackmcbarn: Sort of, trying to cut down my overgrown inbox. ;) [15:44:48] can i have your opinion on the best way to turn templates like https://en.wikipedia.org/wiki/Template:Location_map_USA and https://en.wikipedia.org/wiki/Template:Location_map_Belgium into lua? i have 3 main questions: [15:44:59] 1) should i have one big data module, or a separate data module for each? [15:45:33] 2) should i use require or mw.loadData? (i'm optimizing for the pathological case where there's 6000 points on a single map, because we do have that, and the other cases don't need optimized) [15:45:54] 3) assuming the answer to 1 was separate, should i test for existence first and then load, or pcall the load and test for failure? [15:46:38] (03PS2) 10Phuedx: [WIP] Show the Edit tab under a magnifying glass [extensions/GettingStarted] - 10https://gerrit.wikimedia.org/r/118478 [15:51:28] (03CR) 10Anomie: [C: 04-1] Adjust magic bolding in api help to only match lines inside * (031 comment) [core] - 10https://gerrit.wikimedia.org/r/118130 (owner: 10Umherirrender) [15:53:50] (03Abandoned) 10Hashar: Experiment multiple git repos for Chad [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/118086 (owner: 10Hashar) [15:55:38] jackmcbarn: 1) The advantage to one data module is that it's fewer modules to maintain, and fewer to load if multiple maps are used on a page. The disadvantage is that having to edit one country's data invalidates pages using the map for any country. 2) Probably mw.loadData, unless you really need code returned by the data module. Although it doesn't matter if there's only one #invoke on a page (even if that #invoke has 6000 points in it). For 600 [15:55:38] 0 #invokes it'd be a huge win though. 3) I'd pcall it to save an expensive parser function call. [15:56:53] ok, thanks [15:57:13] (03PS1) 10Hashar: Debug change for PHPUnit segfault [core] - 10https://gerrit.wikimedia.org/r/118552 [15:58:08] jackmcbarn: BTW, please do ping me on any (important) message, because I tend to switch away from IRC as soon as I reply and might forget to look back. [15:58:14] kk [16:03:01] (03CR) 10jenkins-bot: [V: 04-1] Debug change for PHPUnit segfault [core] - 10https://gerrit.wikimedia.org/r/118552 (owner: 10Hashar) [16:05:57] (03Abandoned) 10Hashar: Script to help to maintain CREDITS file [tools/release] - 10https://gerrit.wikimedia.org/r/40080 (owner: 10Dereckson) [16:08:11] (03PS2) 10MarkAHershberger: make-release: remove SimpleAntiSpam from recent versions [tools/release] - 10https://gerrit.wikimedia.org/r/118073 [16:08:28] (03CR) 10Hashar: [C: 032] make-release: remove SimpleAntiSpam from recent versions [tools/release] - 10https://gerrit.wikimedia.org/r/118073 (owner: 10MarkAHershberger) [16:08:30] (03Merged) 10jenkins-bot: make-release: remove SimpleAntiSpam from recent versions [tools/release] - 10https://gerrit.wikimedia.org/r/118073 (owner: 10MarkAHershberger) [16:17:47] (03PS3) 10MarkAHershberger: make-release: fix script to use branches instead of tags [tools/release] - 10https://gerrit.wikimedia.org/r/118074 [16:19:14] hey hashar, when you have a moment would you be able to look at https://gerrit.wikimedia.org/r/#/c/118342/ [16:21:24] (03CR) 10Hashar: [C: 04-1] "Can you please split this commit in smaller parts ? It is a bit hard to review all those modifications in the same change." [tools/release] - 10https://gerrit.wikimedia.org/r/118074 (owner: 10MarkAHershberger) [16:36:20] (03CR) 10Anomie: HTMLForm: Add date type (032 comments) [core] - 10https://gerrit.wikimedia.org/r/118111 (owner: 10Anomie) [16:45:42] (03PS1) 10Hashar: Tox environnement to run python based tests [tools/release] - 10https://gerrit.wikimedia.org/r/118558 [16:46:20] dan-nl: can't access gerrit right now :( [16:46:48] hashar: np, i understand … hopefully it'll come back soon :) [16:48:26] ^d: apparently Gerrit is wild again :/ [16:49:34] <^d> what the fuck. [16:50:18] anomie: were you going to +2 the spamblacklist thing? [16:50:25] dan-nl: there is a new mediawiki version being deployed. But I guess a bunch of us can deploy the simple GWToolset change :] [16:50:41] dan-nl: I dont want to interfere with the ongoing deployment though [16:50:54] (03PS14) 10AndyRussG: WIP Add persistence objects and tests [extensions/Campaigns] (wip/editorcampaigns) - 10https://gerrit.wikimedia.org/r/116221 [16:50:54] i see, np, tomorrow would be fine too [16:52:01] jackmcbarn: Probably. Link? [16:52:16] anomie: https://gerrit.wikimedia.org/r/117231 [16:52:50] (03CR) 10Hashar: "Added Bryan and Dan since they know about tox :-]" [tools/release] - 10https://gerrit.wikimedia.org/r/118558 (owner: 10Hashar) [16:53:08] dan-nl: if it is not deployed tonight, feel free to ping me tomorrow [16:53:16] I am off! *wave* [16:53:19] cool, thanks hashar [16:54:25] (03PS1) 10Chad: Title and redirect snippets don't have a parameter anymore [core] - 10https://gerrit.wikimedia.org/r/118561 [16:55:07] (03CR) 10Anomie: [C: 032] Categorize pages containing blacklisted links [extensions/SpamBlacklist] - 10https://gerrit.wikimedia.org/r/117231 (owner: 10Jackmcbarn) [16:55:22] thanks [16:56:03] Are there issues with Gerrit at the moment? [16:56:15] yeah [16:56:16] know [16:56:18] (03Merged) 10jenkins-bot: Categorize pages containing blacklisted links [extensions/SpamBlacklist] - 10https://gerrit.wikimedia.org/r/117231 (owner: 10Jackmcbarn) [16:56:22] n [16:58:34] (03PS1) 10Chad: Don't prefix interwiki search results with their interwiki prefix [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/118562 [17:03:17] (03PS1) 10Matthias Mullie: Move Parsoid-related code into own folder/namespace [extensions/Flow] - 10https://gerrit.wikimedia.org/r/118564 [17:03:20] (03PS1) 10Matthias Mullie: (bug 61772) MediaWiki:Bad image list not integrated [extensions/Flow] - 10https://gerrit.wikimedia.org/r/118565 [17:03:24] (03PS1) 10Matthias Mullie: [WIP] Create ContentFixer - to combine all content fixups in one place [extensions/Flow] - 10https://gerrit.wikimedia.org/r/118566 [17:03:27] (03PS1) 10Matthias Mullie: Get rid of the now obsolete $wgFlowParsoidTitle [extensions/Flow] - 10https://gerrit.wikimedia.org/r/118567 [17:03:43] (03CR) 10jenkins-bot: [V: 04-1] (bug 61772) MediaWiki:Bad image list not integrated [extensions/Flow] - 10https://gerrit.wikimedia.org/r/118565 (owner: 10Matthias Mullie) [17:04:08] (03CR) 10Matthias Mullie: [C: 04-1] "This has been implemented in https://gerrit.wikimedia.org/r/118566 & https://gerrit.wikimedia.org/r/118567" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/116085 (owner: 10Matthias Mullie) [17:05:45] (03PS2) 10Matthias Mullie: (bug 61772) MediaWiki:Bad image list not integrated [extensions/Flow] - 10https://gerrit.wikimedia.org/r/118565 [17:07:51] (03CR) 10Krinkle: "This preserved the wrong part, add undid the right part by adding the old code in its place as well." [core] - 10https://gerrit.wikimedia.org/r/116957 (owner: 10Krinkle) [17:08:04] (03CR) 10Krinkle: "(also incidentally failed lint, but oh well)" [core] - 10https://gerrit.wikimedia.org/r/116957 (owner: 10Krinkle) [17:09:03] (03PS5) 10Krinkle: mediawiki.api: Use Promise.then instead of manual Deferred wrapping [core] - 10https://gerrit.wikimedia.org/r/116957 [17:10:34] (03CR) 10Krinkle: "re-resolved merge conflict, specifically accounting for I81ec4282aed" [core] - 10https://gerrit.wikimedia.org/r/116957 (owner: 10Krinkle) [17:11:02] I'd appreciate people looking at https://test.wikipedia.org for signs of l10n cache problems. I *think* I may have finally fixed https://bugzilla.wikimedia.org/show_bug.cgi?id=51174 but I've been proven wrong when I thought that before. [17:12:43] (03PS11) 10Krinkle: mediawiki.api: Refactor getToken and postWithToken methods [core] - 10https://gerrit.wikimedia.org/r/111636 [17:15:48] (03PS1) 10Chad: Hardcode interwiki searches offset and limit [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/118571 [17:21:07] (03CR) 10Anomie: HTMLForm: Add "cloner" type (031 comment) [core] - 10https://gerrit.wikimedia.org/r/118113 (owner: 10Anomie) [17:21:22] (03CR) 10Anomie: HTMLForm: Add daterange type (032 comments) [core] - 10https://gerrit.wikimedia.org/r/118112 (owner: 10Anomie) [17:22:29] (03CR) 10Manybubbles: [C: 032] Don't prefix interwiki search results with their interwiki prefix [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/118562 (owner: 10Chad) [17:22:36] (03Merged) 10jenkins-bot: Don't prefix interwiki search results with their interwiki prefix [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/118562 (owner: 10Chad) [17:23:23] (03PS3) 10Anomie: HTMLForm: Add "cloner" type [core] - 10https://gerrit.wikimedia.org/r/118113 [17:23:25] (03PS3) 10Anomie: HTMLForm: Add daterange type [core] - 10https://gerrit.wikimedia.org/r/118112 [17:23:27] (03PS3) 10Anomie: Release notes for recent HTMLForm changes [core] - 10https://gerrit.wikimedia.org/r/118114 [17:23:29] (03PS3) 10Anomie: HTMLForm: Add date type [core] - 10https://gerrit.wikimedia.org/r/118111 [17:25:13] (03CR) 10Manybubbles: [C: 031] Title and redirect snippets don't have a parameter anymore [core] - 10https://gerrit.wikimedia.org/r/118561 (owner: 10Chad) [17:25:26] (03PS2) 10Chad: Simplify getIndexSuffixForNamespace() logic a tiny bit [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/118382 [17:26:14] (03CR) 10jenkins-bot: [V: 04-1] Release notes for recent HTMLForm changes [core] - 10https://gerrit.wikimedia.org/r/118114 (owner: 10Anomie) [17:26:33] (03CR) 10Manybubbles: [C: 032] Simplify getIndexSuffixForNamespace() logic a tiny bit [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/118382 (owner: 10Chad) [17:27:07] (03CR) 10jenkins-bot: [V: 04-1] Simplify getIndexSuffixForNamespace() logic a tiny bit [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/118382 (owner: 10Chad) [17:28:01] (03CR) 10Manybubbles: [C: 032] Simplify a little bit of logic in a few places [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/118383 (owner: 10Chad) [17:29:01] (03CR) 10Manybubbles: [C: 04-1] "Looks like syntax is wrong...." [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/118382 (owner: 10Chad) [17:32:24] (03PS4) 10EBernhardson: New Hook rc/watchlist hook ChangesListBegin [core] - 10https://gerrit.wikimedia.org/r/116649 [17:32:58] (03PS3) 10Chad: Simplify getIndexSuffixForNamespace() logic a tiny bit [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/118382 [17:33:23] (03CR) 10jenkins-bot: [V: 04-1] New Hook rc/watchlist hook ChangesListBegin [core] - 10https://gerrit.wikimedia.org/r/116649 (owner: 10EBernhardson) [17:36:10] (03PS4) 10EBernhardson: Method to identify if a ChangesList is watchlist or normal [core] - 10https://gerrit.wikimedia.org/r/117466 [17:36:32] (03CR) 10EBernhardson: [C: 032] (bug 59636) should not override global h1 and h2 style [extensions/Flow] - 10https://gerrit.wikimedia.org/r/116474 (owner: 10Matthias Mullie) [17:37:27] (03Merged) 10jenkins-bot: (bug 59636) should not override global h1 and h2 style [extensions/Flow] - 10https://gerrit.wikimedia.org/r/116474 (owner: 10Matthias Mullie) [17:38:54] (03PS1) 10CSteipp: ignore this (more segfault testing) [core] - 10https://gerrit.wikimedia.org/r/118573 [17:42:52] (03PS5) 10EBernhardson: New Hook rc/watchlist hook ChangesListBegin [core] - 10https://gerrit.wikimedia.org/r/116649 [17:44:41] (03PS15) 10AndyRussG: WIP Add persistence objects and tests [extensions/Campaigns] (wip/editorcampaigns) - 10https://gerrit.wikimedia.org/r/116221 [17:51:08] (03CR) 10CSteipp: [C: 031] "dear jenkins, please review." [core] - 10https://gerrit.wikimedia.org/r/118573 (owner: 10CSteipp) [17:51:09] (03CR) 10jenkins-bot: [V: 04-1] ignore this (more segfault testing) [core] - 10https://gerrit.wikimedia.org/r/118573 (owner: 10CSteipp) [17:51:27] csteipp: does that work? "dear jenkins, please review."? [17:51:32] Yep :) [17:51:42] I mean, it probably has more to do with the +1 than my incantation, but it gets the job done. [17:51:47] csteipp: :D [17:51:59] (03CR) 10Chad: [C: 032] Remove nasty redirect juggling added for 1.0 [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/118078 (owner: 10Manybubbles) [17:52:02] (03Merged) 10jenkins-bot: Remove nasty redirect juggling added for 1.0 [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/118078 (owner: 10Manybubbles) [17:52:55] huh, i found a gerrit install where they have a bot leaving inline comments. https://gerrit.sio2project.mimuw.edu.pl/#/c/1922/4/oioioi/contests/views.py [17:52:59] (03CR) 10EBernhardson: "Also, i browsed through quickly to look at the images and it seems many of them are very very similar. It seems a variety of images that " [extensions/Flow] - 10https://gerrit.wikimedia.org/r/116501 (owner: 10Matthias Mullie) [17:53:00] can we has that? [17:54:21] (03PS2) 10CSteipp: ignore this (more segfault testing) [core] - 10https://gerrit.wikimedia.org/r/118573 [17:54:28] (03CR) 10Manybubbles: [C: 032] Simplify getIndexSuffixForNamespace() logic a tiny bit [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/118382 (owner: 10Chad) [17:57:30] (03CR) 10Manybubbles: [C: 032] Simplify error output a tad in updateOneSearchIndexConfig [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/118386 (owner: 10Chad) [17:58:14] (03CR) 10Umherirrender: "Patch Set 2: Addressed inline comments" [core] - 10https://gerrit.wikimedia.org/r/118130 (owner: 10Umherirrender) [17:58:18] (03Merged) 10jenkins-bot: Simplify a little bit of logic in a few places [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/118383 (owner: 10Chad) [17:58:21] (03Merged) 10jenkins-bot: Simplify error output a tad in updateOneSearchIndexConfig [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/118386 (owner: 10Chad) [18:00:20] (03Merged) 10jenkins-bot: Title and redirect snippets don't have a parameter anymore [core] - 10https://gerrit.wikimedia.org/r/118561 (owner: 10Chad) [18:00:53] (03CR) 10CSteipp: "review" [core] - 10https://gerrit.wikimedia.org/r/118573 (owner: 10CSteipp) [18:03:50] (03PS3) 10CSteipp: ignore this (more segfault testing) [core] - 10https://gerrit.wikimedia.org/r/118573 [18:05:38] (03CR) 10CSteipp: [C: 031] "mr. jenkins, please review." [core] - 10https://gerrit.wikimedia.org/r/118573 (owner: 10CSteipp) [18:06:29] :D [18:06:50] (03PS1) 10Chad: Should've bumped analysis version when I adjusted language fallbacks [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/118577 [18:07:27] (03CR) 10Chad: [C: 032] Should've bumped analysis version when I adjusted language fallbacks [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/118577 (owner: 10Chad) [18:08:31] (03Merged) 10jenkins-bot: Should've bumped analysis version when I adjusted language fallbacks [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/118577 (owner: 10Chad) [18:08:38] (03CR) 10Jdlrobson: "Krinkle see comment above that it's a WIP and a -2. It's being done this way whilst the 2 new repositories are being setup. Then it will c" [skins] - 10https://gerrit.wikimedia.org/r/118347 (owner: 10Jdlrobson) [18:10:08] (03PS4) 10CSteipp: ignore this (more segfault testing) [core] - 10https://gerrit.wikimedia.org/r/118573 [18:14:16] (03PS1) 10Chad: Adjust default interwiki result text [core] - 10https://gerrit.wikimedia.org/r/118578 [18:17:22] (03PS5) 10CSteipp: ignore this (more segfault testing) [core] - 10https://gerrit.wikimedia.org/r/118573 [18:17:52] (03PS1) 10Maduranga: Change date and decimal separators for Uzbek language [core] - 10https://gerrit.wikimedia.org/r/118579 [18:21:43] (03CR) 10Swalling: WIP Add persistence objects and tests (031 comment) [extensions/Campaigns] (wip/editorcampaigns) - 10https://gerrit.wikimedia.org/r/116221 (owner: 10AndyRussG) [18:34:35] (03PS2) 10EBernhardson: Anonymous editor warning. Now with links to log in and register. [extensions/Flow] - 10https://gerrit.wikimedia.org/r/117846 (owner: 10Werdna) [18:34:38] (03CR) 10jenkins-bot: [V: 04-1] Anonymous editor warning. Now with links to log in and register. [extensions/Flow] - 10https://gerrit.wikimedia.org/r/117846 (owner: 10Werdna) [18:36:34] (03PS3) 10EBernhardson: Anonymous editor warning. Now with links to log in and register. [extensions/Flow] - 10https://gerrit.wikimedia.org/r/117846 (owner: 10Werdna) [18:37:33] (03Abandoned) 10Umherirrender: return array on prop=imageinfo for empty metadata [core] - 10https://gerrit.wikimedia.org/r/116291 (owner: 10Umherirrender) [18:56:44] (03CR) 10Anomie: [C: 032] Adjust magic bolding in api help to only match lines inside * [core] - 10https://gerrit.wikimedia.org/r/118130 (owner: 10Umherirrender) [19:00:57] (03Merged) 10jenkins-bot: Adjust magic bolding in api help to only match lines inside * [core] - 10https://gerrit.wikimedia.org/r/118130 (owner: 10Umherirrender) [19:03:07] (03CR) 10AndyRussG: WIP Add persistence objects and tests (031 comment) [extensions/Campaigns] (wip/editorcampaigns) - 10https://gerrit.wikimedia.org/r/116221 (owner: 10AndyRussG) [19:05:04] (03PS6) 10CSteipp: ignore this (more segfault testing) [core] - 10https://gerrit.wikimedia.org/r/118573 [19:18:28] (03PS4) 10Umherirrender: Exclude prop=uploadwarning from allimages and stashimageinfo [core] - 10https://gerrit.wikimedia.org/r/112341 [19:25:30] (03PS1) 10Bsitu: "An unexpected error occurred" on first preview of Flow board [extensions/Flow] - 10https://gerrit.wikimedia.org/r/118586 [19:35:51] (03CR) 10Siebrand: [C: 031] "L10n reviewed." (031 comment) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/117846 (owner: 10Werdna) [19:35:57] (03CR) 10Siebrand: [C: 04-1] Anonymous editor warning. Now with links to log in and register. [extensions/Flow] - 10https://gerrit.wikimedia.org/r/117846 (owner: 10Werdna) [19:37:00] (03Abandoned) 10Jdlrobson: Skins: Only load watch star ajax on Vector [core] - 10https://gerrit.wikimedia.org/r/118217 (owner: 10Jdlrobson) [19:40:03] (03PS2) 10Jdlrobson: Add prebodytext template variable [core] - 10https://gerrit.wikimedia.org/r/117904 [19:41:09] (03CR) 10Brion VIBBER: "Seems wrong to me. I think I'd still want the captcha information so I could show the new captcha on the second form, wouldn't I?" [extensions/ConfirmEdit] - 10https://gerrit.wikimedia.org/r/118381 (owner: 10MaxSem) [19:43:21] (03CR) 10MaxSem: "The point of it is to display captcha only when nothing else is preventing account creation." [extensions/ConfirmEdit] - 10https://gerrit.wikimedia.org/r/118381 (owner: 10MaxSem) [19:43:28] brion, ^ [19:44:41] (03PS2) 10Aaron Schulz: Avoid header notice log spam from RunJobs API [core] - 10https://gerrit.wikimedia.org/r/118336 [19:44:52] (03CR) 10Brion VIBBER: "But then you'd have to submit the data again twice: once with updated user info, then oops! captcha was wrong. Now you have to prompt the " [extensions/ConfirmEdit] - 10https://gerrit.wikimedia.org/r/118381 (owner: 10MaxSem) [19:45:56] (03PS4) 10EBernhardson: Anonymous editor warning. Now with links to log in and register. [extensions/Flow] - 10https://gerrit.wikimedia.org/r/117846 (owner: 10Werdna) [19:46:09] (03CR) 10Kaldari: [C: 04-1] Add prebodytext template variable (031 comment) [core] - 10https://gerrit.wikimedia.org/r/117904 (owner: 10Jdlrobson) [19:46:16] (03CR) 10Anomie: "Removing -2 for PS2 rewrite. Will review later." [core] - 10https://gerrit.wikimedia.org/r/118336 (owner: 10Aaron Schulz) [19:46:17] brion, have you tried this change? you get captcha only once [19:46:47] MaxSem: but i don't want captcha only once, do i? [19:46:56] i want it every time i submit a new request [19:47:23] thats something i've wondered about before actually, if i pass the captcha but fail some other validation i would prefer to not re-captcha [19:47:32] brion, but the captcha will be new each time... [19:47:34] but not sure how that would be implemented :P [19:48:01] ebernhardson: shouldn't validating first and then sending captcha fix that problem, other than for race conditions of sorts where something was valid 5s ago but not now? [19:48:02] MaxSem: it's already new because the captcha was wrong, right? [19:48:47] YuviPanda: hmm, so the captcha is almost an interstitial? [19:50:08] ebernhardson: pretty much, yeah. You validate all, and if everything validates then captcha [19:50:11] YuviPanda: sounds reasonable [19:50:16] so the pipeline in my proposal is: you fill in data, get it right, submit token and only then you need to solve the captcha [19:50:19] ebernhardson: yeah, that seems to be what MaxSem is doing here. [19:50:19] part of the purpose of the captcha is to prevent dictionary-attack-type behavior [19:50:20] (IIRC) [19:50:31] yes? [19:50:33] (03PS3) 10Jdlrobson: Add prebodytext template variable [core] - 10https://gerrit.wikimedia.org/r/117904 [19:50:33] (03PS1) 10Jdlrobson: Skin: Make #bodyContent standard across all our skins. [core] - 10https://gerrit.wikimedia.org/r/118589 [19:50:34] (03CR) 10EBernhardson: [C: 04-1] "Blue link text on the blue hover background is not working, check with may to see what would be better. Kaity suggested making link-text b" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/117846 (owner: 10Werdna) [19:51:57] YuviPanda, MaxSem: so the way it works is that if you fail the captcha, you don't get to guess the same captcha again. you get a new captcha [19:52:04] that's why it gives you the captcha information back with your result [19:52:08] exactly [19:52:09] so you don't have to ask for it again... [19:52:11] brion: yeah, that's how it already works. [19:52:17] brion: in captchas everywhere, no? [19:52:18] so i don't understand the purpose of the patch? [19:52:26] which seems to be to remove it? [19:52:42] brion: because currently, you submit a request, get back a captcha, solve it, and *then* get told that the username is unavailable. [19:52:49] brion: that's what this is intended to fix. Unsure if it does :) [19:53:03] YuviPanda: that's intended behavior. captcha is part of your initial form submission [19:53:11] brion, the purpose of the patch is that people don't have to solve it the second time if they entered something non-captchy wrong the first time [19:53:39] what MaxSem said. [19:53:59] brion: you shouldn't need to solve a captcha for validating if the user name is available. you should only solve it for actually creating an account [19:54:39] hmm [19:54:50] feels wrong somehow [19:55:19] dunno :) [19:55:20] that's because username validation currently is "try to create an account ans see if something explodes in your face" [19:55:57] why can't it have a little "available/not available" indicator next to the username field that auto changes based on what you type? [19:56:13] brion, I myself was melting my brains over it for several days:) [19:56:15] MaxSem: does it actually preserve the previous captcha though? [19:56:28] i'm pretty sure it rewrites the captcha as soon as you fail it [19:56:28] what previous captcha? [19:56:39] (03CR) 10Kaldari: [C: 04-1] Add prebodytext template variable (031 comment) [core] - 10https://gerrit.wikimedia.org/r/117904 (owner: 10Jdlrobson) [19:56:40] the one you had to pass first [19:56:42] the point of this change is to prevent unneeded captchas [19:56:53] aaaaaaaaah [19:56:59] * brion kicks self in head [19:57:20] ok if something failed out before the captcha validation, that might actually be possible [19:57:24] lemme look up the code [19:58:20] yes, yes there are several things that can fail out before the captcha is validated [19:58:23] ok this makes sense :D [19:58:30] (03Abandoned) 10EBernhardson: Don't globally style h1 and h2 [extensions/Flow] - 10https://gerrit.wikimedia.org/r/105426 (owner: 10Spage) [19:58:45] hmmmm [19:59:10] but if you don't send the captcha information, the client won't know to send it on its second round through .... unless that's assumed in the protocol [19:59:34] i cant seem to locate it, where was the template for bugzilla db change requests? [20:01:21] (03CR) 10Kaldari: [C: 032] Vector: Make animation LESS component [core] - 10https://gerrit.wikimedia.org/r/117617 (owner: 10Jdlrobson) [20:02:25] MaxSem: so 'username already exists' seems to trigger a fatal error, not a warning [20:02:34] so that case doesn't hit what the patch would change [20:02:49] can you give an example of a failure that returns a warning other than NeedsToken? [20:05:02] (03Merged) 10jenkins-bot: Vector: Make animation LESS component [core] - 10https://gerrit.wikimedia.org/r/117617 (owner: 10Jdlrobson) [20:07:36] brion, have you seen my reply? [20:07:46] OuKB: to what? [20:07:52] { [20:07:52] "error": { [20:07:52] "code": "passwordtooshort", [20:07:52] "info": "Passwords must be at least {{PLURAL:1|1 character|1 characters}}." [20:07:52] } [20:07:53] } [20:08:42] OuKB: context? [20:08:59] can you give an example of a failure that returns a warning other than NeedsToken? [20:09:09] OuKB: that's an error not a warning [20:09:22] you can see it doesn't include the captcha data there either [20:09:34] since that's currently included only with warnings [20:09:35] yes, that was the intention [20:10:04] show captcha only when it's the only thing between us and registration [20:10:07] so all the pre-captcha-validation errors i can reproduce currently return fatal API error results, with no token or captcha information, under the current code [20:10:14] (03CR) 10Bartosz Dziewoński: [C: 04-1] "Why?" (031 comment) [core] - 10https://gerrit.wikimedia.org/r/118589 (owner: 10Jdlrobson) [20:10:34] so i don't think that patch would change anything so far [20:10:41] so i'm kinda confused :D [20:12:09] * brion hmms some more [20:13:38] okay, so after this patch: try entering just username - password too short. add password - NeedToken. add token - solveme the captcha [20:13:51] (03PS7) 10CSteipp: ignore this (more segfault testing) [core] - 10https://gerrit.wikimedia.org/r/118573 [20:14:30] MaxSem: and before the patch, what happens? [20:16:23] (03PS1) 10Manybubbles: Fix word_count [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/118591 [20:19:08] (03CR) 10jenkins-bot: [V: 04-1] ignore this (more segfault testing) [core] - 10https://gerrit.wikimedia.org/r/118573 (owner: 10CSteipp) [20:20:28] (03CR) 10Brion VIBBER: "What's an example error that triggers this code path? On further investigation, all the pre-captcha-validation errors I can see return a S" [extensions/ConfirmEdit] - 10https://gerrit.wikimedia.org/r/118381 (owner: 10MaxSem) [20:22:14] (03CR) 10Chad: [C: 032 V: 032] "Need to get this live, can't wait on browser tests. Other tests passed fine (lint & unit)" [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/118591 (owner: 10Manybubbles) [20:26:13] (03CR) 10EBernhardson: [C: 032] "submitted https://bugzilla.wikimedia.org/show_bug.cgi?id=62617 to have this change applied in production" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/116226 (owner: 10Bsitu) [20:26:27] (03Merged) 10jenkins-bot: Remove unique from index (tree_rev_descendant_id, tree_rev_id) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/116226 (owner: 10Bsitu) [20:29:15] brion, riiight. so your commit actually fixed this problem:P [20:29:19] (03PS4) 10EBernhardson: [SCHEMA CHANGE] Add index on revision user data [extensions/Flow] - 10https://gerrit.wikimedia.org/r/116115 (owner: 10Matthias Mullie) [20:29:34] heh [20:29:45] or so it seems [20:30:15] WHY DIDN'T YOU LINK IT TO BUGZILLA?!:P [20:30:26] ;_; [20:31:58] YuviPanda, does https://gerrit.wikimedia.org/r/#/c/116170/ look like that? [20:32:01] (03CR) 10Helder.wiki: "Done: https://www.mediawiki.org/w/index.php?diff=927854" [extensions/Gadgets] - 10https://gerrit.wikimedia.org/r/75506 (owner: 10Catrope) [20:32:17] (03CR) 10Helder.wiki: "Docs: https://www.mediawiki.org/w/index.php?diff=927854" [extensions/Gadgets] - 10https://gerrit.wikimedia.org/r/60954 (owner: 10MaxSem) [20:32:52] MaxSem: brion does it? I think they are two separate issues. [20:35:50] YuviPanda: from what i can tell, unless other extensions using AbortNewAccount are issuing warnings in their responses there's no way to hit the warning code path other than the captcha validation failing, which only happens *after* all those other checks for things like duplicate usernames [20:36:30] brion: yeah, so we want captcha validation tohappen after all extensions and core. I do not know if MaxSem's patch does it :) [20:36:38] brion: to see current workflow, try having invalid inputs in the android app [20:37:37] YuviPanda, that brion's patch is very new and it changes API output format [20:38:00] it is live only on phase0 wikis [20:38:13] MaxSem: hmm, in that case account creation on the apps will actually fail [20:38:33] MaxSem: but it only changes the format in one specific case, doesn't it? [20:38:45] YuviPanda, {{sofixit}}:) [20:38:51] the cases we worry about haven't changed, iirc [20:39:03] yes [20:39:26] still ,you introduced a new status code [20:39:51] gosh, these things are confusing as hell [20:40:17] hehe [20:41:14] (03PS1) 10Chad: Remove "include redirects" option from search [core] - 10https://gerrit.wikimedia.org/r/118592 [20:41:55] (03PS1) 10Chad: Don't respect the "show redirections" option on Special:Search or the API [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/118593 [20:43:19] YuviPanda, MaxSem: ok i think you guys want to have the initial NeedsToken response not include a captcha ...... ? [20:43:31] in which case with our current code we wouldn't prompt you until after a second round through [20:43:36] ok i think this starts to make sense [20:43:50] man this api stuff rots my brain ;) [20:44:27] <^d> Who wants to review those changes ^ :p [20:44:34] brion: I'm going to leave it to you and MaxSem :) [20:44:35] <^d> Less clutter on advanced search ;-) [20:44:38] yessss ok this is making sense now [20:44:39] let me test [20:47:22] (03Abandoned) 10Reedy: Make message keys unique, were the same as extension/ContactPage [extensions/ContactPageFundraiser] - 10https://gerrit.wikimedia.org/r/110142 (owner: 10Reedy) [20:53:46] (03CR) 10Brion VIBBER: [C: 031] "Ok hashed this out on IRC and we think it makes sense now. :D" [extensions/ConfirmEdit] - 10https://gerrit.wikimedia.org/r/118381 (owner: 10MaxSem) [20:54:09] MaxSem, YuviPanda: can you look at that last comment and confirm that the flow sounds right? [20:54:48] if it sounds right i'll +2 :D [20:57:13] (03PS1) 10Manybubbles: Fix word_count [extensions/CirrusSearch] (wmf/1.23wmf17) - 10https://gerrit.wikimedia.org/r/118597 [20:57:41] (03CR) 10Manybubbles: "the wmf17 version of this patch is totally different the master/18" [extensions/CirrusSearch] (wmf/1.23wmf17) - 10https://gerrit.wikimedia.org/r/118597 (owner: 10Manybubbles) [20:59:42] (03PS1) 10Manybubbles: Fix word_count [extensions/CirrusSearch] (wmf/1.23wmf18) - 10https://gerrit.wikimedia.org/r/118598 [21:00:06] (03CR) 10EBernhardson: [C: 04-2] "LGTM. Filed bug to have index created on wikimedia production: https://bugzilla.wikimedia.org/show_bug.cgi?id=62620" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/116115 (owner: 10Matthias Mullie) [21:00:20] (03CR) 10Manybubbles: "this one is just a clean cherry pick from master." [extensions/CirrusSearch] (wmf/1.23wmf18) - 10https://gerrit.wikimedia.org/r/118598 (owner: 10Manybubbles) [21:00:22] (03CR) 10GWicke: [C: 032] Allow more-descriptive section names for parserTests [core] - 10https://gerrit.wikimedia.org/r/89141 (owner: 10Arlolra) [21:01:34] (03CR) 10EBernhardson: "My initial thought here is basically same as the patch overall, removing dead/useless code. With our current state of only discussions/to" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/115576 (owner: 10EBernhardson) [21:02:16] brion, lgtm but waiting for YuviPanda to confirm [21:04:12] (03Merged) 10jenkins-bot: Allow more-descriptive section names for parserTests [core] - 10https://gerrit.wikimedia.org/r/89141 (owner: 10Arlolra) [21:04:47] MaxSem: I have a fever and just took some pills, so don't wait on me :) [21:05:45] oh stit! [21:05:49] get well soon [21:08:13] (03PS8) 10CSteipp: ignore this (more segfault testing) [core] - 10https://gerrit.wikimedia.org/r/118573 [21:09:47] ! [21:09:47] Hello, I'm wm-bot. The database for this channel is published at http://bots.wmflabs.org/~wm-bot/db/%23mediawiki.htm More about WM-Bot: https://meta.wikimedia.org/wiki/wm-bot [21:09:56] YuviPanda: ok i'm gonna assume it works and merge it then :D [21:10:12] MaxSem: brion yeah, the pills are making me a bit dizzy atm [21:10:38] (03CR) 10Brion VIBBER: [C: 032 V: 032] "Ok general consensusing among me and Max is this is ok, let's merge." [extensions/ConfirmEdit] - 10https://gerrit.wikimedia.org/r/118381 (owner: 10MaxSem) [21:10:54] YuviPanda: go sleep or something, it's late :) [21:11:10] brion: i'm writing email to mobile-l, will sl;eep after [21:11:15] thanks brion! [21:13:02] hi all, who should i talk to you about a change in flow or perhaps parsoid (not sure which) that messed up an API? [21:13:43] theopolisme, what's up? [21:13:44] (03CR) 10Manybubbles: "I wonder if we should let the database backed searches keep it and just say we don't support it in cirrus? It looks like the check box dr" [core] - 10https://gerrit.wikimedia.org/r/118592 (owner: 10Chad) [21:15:17] (03CR) 10jenkins-bot: [V: 04-1] ignore this (more segfault testing) [core] - 10https://gerrit.wikimedia.org/r/118573 (owner: 10CSteipp) [21:15:22] gwicke: https://bugzilla.wikimedia.org/show_bug.cgi?id=62597, tags at the top of the body content aren't being returned by action=flow-parsoid-utils for some reason, although i'm pretty positive they used to be... [21:17:27] (03CR) 10Chad: "But then we're lying. We do support it, just always on ;-)" [core] - 10https://gerrit.wikimedia.org/r/118592 (owner: 10Chad) [21:18:22] (03CR) 10Chad: [C: 032] Fix word_count [extensions/CirrusSearch] (wmf/1.23wmf17) - 10https://gerrit.wikimedia.org/r/118597 (owner: 10Manybubbles) [21:18:29] (03Merged) 10jenkins-bot: Fix word_count [extensions/CirrusSearch] (wmf/1.23wmf17) - 10https://gerrit.wikimedia.org/r/118597 (owner: 10Manybubbles) [21:18:32] (03CR) 10Chad: [C: 032] Fix word_count [extensions/CirrusSearch] (wmf/1.23wmf18) - 10https://gerrit.wikimedia.org/r/118598 (owner: 10Manybubbles) [21:18:37] (03Merged) 10jenkins-bot: Fix word_count [extensions/CirrusSearch] (wmf/1.23wmf18) - 10https://gerrit.wikimedia.org/r/118598 (owner: 10Manybubbles) [21:18:38] MaxSem: you're right about HNI being cleaner to use that Zend [21:20:55] and about a million times so! [21:21:33] (03PS1) 10Chad: Update Cirrus submodule to pull word_count fix [core] (wmf/1.23wmf17) - 10https://gerrit.wikimedia.org/r/118604 [21:21:39] theopolisme, could be an issue with the way the flow extension parses the Parsoid HTML [21:21:51] Yeah, that's what I thought [21:22:06] theopolisme, also if you want HTTPS and a fast cluster: https://parsoid-prod.wmflabs.org/ [21:22:20] it's a proxy in front of http://parsoid-lb.eqiad.wikimedia.org/ [21:23:20] (03PS1) 10Chad: Update Cirrus submodule to pull word_count fix [core] (wmf/1.23wmf18) - 10https://gerrit.wikimedia.org/r/118605 [21:24:11] AaronSchulz, are you making a full port of igbinary? [21:28:11] toying around with it atm [21:28:28] there is a lot of crap to reason through, like a custom memory allocator and hash table implementation [21:29:04] maybe just the usual C code wheel reinventing [21:29:30] I'm not even sure how much space this encoding saves really [21:30:07] gwicke: hey, that's great [21:30:10] thanks for showing me that [21:30:12] :D [21:32:33] theopolisme, you are welcome ;) [21:33:51] (03PS7) 10Welterkj: use imagemap class for HTML rendering [extensions/GraphViz] - 10https://gerrit.wikimedia.org/r/111475 [21:36:44] (03PS1) 10Cscott: Fix minor typo in parser tests error message. [core] - 10https://gerrit.wikimedia.org/r/118609 [21:42:32] (03CR) 10Welterkj: "The whitespace removal tool I used (gedit plugin) got overzealous and consumed non-blank final lines which I manually added back, inadvert" [extensions/GraphViz] - 10https://gerrit.wikimedia.org/r/111475 (owner: 10Welterkj) [21:43:08] (03CR) 10Bsitu: [C: 032] Update annotations in RevisionView [extensions/Flow] - 10https://gerrit.wikimedia.org/r/117032 (owner: 10EBernhardson) [21:43:28] (03Merged) 10jenkins-bot: Update annotations in RevisionView [extensions/Flow] - 10https://gerrit.wikimedia.org/r/117032 (owner: 10EBernhardson) [21:47:56] (03PS3) 10CSteipp: Refactor password validity checking [core] - 10https://gerrit.wikimedia.org/r/118233 [21:47:58] (03CR) 10EBernhardson: [C: 04-1] "new hooks also need a release notes entry" [core] - 10https://gerrit.wikimedia.org/r/115860 (owner: 10Werdna) [21:48:40] (03CR) 10CSteipp: "PS3 adds some unit testing" [core] - 10https://gerrit.wikimedia.org/r/118233 (owner: 10CSteipp) [21:50:04] (03CR) 10Welterkj: "Learned how to publish my comments." (036 comments) [extensions/GraphViz] - 10https://gerrit.wikimedia.org/r/111475 (owner: 10Welterkj) [22:02:59] (03PS3) 10Bsitu: Cleanup undefined method warnings [extensions/Flow] - 10https://gerrit.wikimedia.org/r/117111 (owner: 10EBernhardson) [22:11:45] (03PS1) 10Ssmith: Refactored post-IRL-code-review. [extensions/FundraisingChart] - 10https://gerrit.wikimedia.org/r/118616 [22:11:47] (03CR) 10jenkins-bot: [V: 04-1] Refactored post-IRL-code-review. [extensions/FundraisingChart] - 10https://gerrit.wikimedia.org/r/118616 (owner: 10Ssmith) [22:17:08] (03CR) 10Siebrand: use imagemap class for HTML rendering (031 comment) [extensions/GraphViz] - 10https://gerrit.wikimedia.org/r/111475 (owner: 10Welterkj) [22:17:50] (03CR) 10Siebrand: [C: 04-1] "i18n/L10n reviewed." [extensions/GraphViz] - 10https://gerrit.wikimedia.org/r/111475 (owner: 10Welterkj) [22:18:42] (03PS1) 10Krinkle: Improve docs for $wgExtensionCredits (and add 'license-name') [core] - 10https://gerrit.wikimedia.org/r/118617 [22:19:55] (03CR) 10Krinkle: "Added documentation for it in DefaultSettings.php in I2b2c17965230558." [core] - 10https://gerrit.wikimedia.org/r/65299 (owner: 10Mwalker) [22:19:57] (03CR) 10Siebrand: [C: 031] "L10n reviewed." [extensions/Flow] - 10https://gerrit.wikimedia.org/r/117846 (owner: 10Werdna) [22:21:13] (03CR) 10Siebrand: [C: 032] Adjust default interwiki result text [core] - 10https://gerrit.wikimedia.org/r/118578 (owner: 10Chad) [22:22:55] (03CR) 10Bsitu: [C: 032] Cleanup undefined method warnings [extensions/Flow] - 10https://gerrit.wikimedia.org/r/117111 (owner: 10EBernhardson) [22:22:59] (03CR) 10EBernhardson: [C: 04-1] "I think this needs to be split into two patches? We need a first patch we can deploy which allows the new column to exist. Then we creat" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/116861 (owner: 10Bsitu) [22:23:09] (03CR) 10jenkins-bot: [V: 04-1] Cleanup undefined method warnings [extensions/Flow] - 10https://gerrit.wikimedia.org/r/117111 (owner: 10EBernhardson) [22:23:42] (03CR) 10Siebrand: Improve docs for $wgExtensionCredits (and add 'license-name') (031 comment) [core] - 10https://gerrit.wikimedia.org/r/118617 (owner: 10Krinkle) [22:23:44] (03CR) 10Spage: [C: 04-1] "The tipsy is mispositioned when adding a new topic. If I'm in a hurry it vanishes before I can read it." (037 comments) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/117846 (owner: 10Werdna) [22:24:34] (03CR) 10Siebrand: [C: 031] "L10n reviewed." [extensions/Thanks] - 10https://gerrit.wikimedia.org/r/115557 (owner: 10Wctaiwan) [22:25:04] (03Merged) 10jenkins-bot: Adjust default interwiki result text [core] - 10https://gerrit.wikimedia.org/r/118578 (owner: 10Chad) [22:25:52] (03CR) 10Chad: "Thanks for the review + merge!" [core] - 10https://gerrit.wikimedia.org/r/118578 (owner: 10Chad) [22:28:30] (03PS1) 10Ladsgroup: Changing URLs of mediawiki.org in scripts to the SSL-based website [core] - 10https://gerrit.wikimedia.org/r/118619 [22:29:43] (03PS2) 10Krinkle: Improve docs for $wgExtensionCredits (and add 'license-name') [core] - 10https://gerrit.wikimedia.org/r/118617 [22:30:24] (03PS4) 10EBernhardson: Cleanup undefined method warnings [extensions/Flow] - 10https://gerrit.wikimedia.org/r/117111 [22:30:38] (03CR) 10EBernhardson: [C: 032] "re-submit per bsitu +2" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/117111 (owner: 10EBernhardson) [22:30:42] (03CR) 10Krinkle: Improve docs for $wgExtensionCredits (and add 'license-name') (031 comment) [core] - 10https://gerrit.wikimedia.org/r/118617 (owner: 10Krinkle) [22:30:52] (03CR) 10Krinkle: "Fixed a few spelling mistakes and simplified grammar." [core] - 10https://gerrit.wikimedia.org/r/118617 (owner: 10Krinkle) [22:31:16] (03Merged) 10jenkins-bot: Cleanup undefined method warnings [extensions/Flow] - 10https://gerrit.wikimedia.org/r/117111 (owner: 10EBernhardson) [22:34:22] (03CR) 10EBernhardson: [C: 031] "LGTM, couple possible tweaks." (032 comments) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/116874 (owner: 10Bsitu) [22:35:14] (03CR) 10Siebrand: Improve docs for $wgExtensionCredits (and add 'license-name') (031 comment) [core] - 10https://gerrit.wikimedia.org/r/118617 (owner: 10Krinkle) [22:37:52] (03CR) 10Siebrand: [C: 032] Changing URLs of mediawiki.org in scripts to the SSL-based website [core] - 10https://gerrit.wikimedia.org/r/118619 (owner: 10Ladsgroup) [22:40:23] (03PS8) 10Welterkj: use imagemap class for HTML rendering [extensions/GraphViz] - 10https://gerrit.wikimedia.org/r/111475 [22:41:12] (03CR) 10EBernhardson: "Looks good, but there are some new references to flow_header_revision in the ContributionsQuery that will also need to be changed over(als" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/117115 (owner: 10Bsitu) [22:41:34] (03Merged) 10jenkins-bot: Changing URLs of mediawiki.org in scripts to the SSL-based website [core] - 10https://gerrit.wikimedia.org/r/118619 (owner: 10Ladsgroup) [22:41:50] (03CR) 10Welterkj: "Image->File. Thanks for the explanation." (031 comment) [extensions/GraphViz] - 10https://gerrit.wikimedia.org/r/111475 (owner: 10Welterkj) [22:46:25] <^d> brion: Would you mind lending an opinion on a gerrit change? I'm looking to simplify search a bit (code and UI). Most of this old search stuff has your fingerprints on it ;-) [22:48:51] (03PS3) 10EBernhardson: Only load the container on flow pages [extensions/Flow] - 10https://gerrit.wikimedia.org/r/115861 [22:49:01] (03CR) 10jenkins-bot: [V: 04-1] Only load the container on flow pages [extensions/Flow] - 10https://gerrit.wikimedia.org/r/115861 (owner: 10EBernhardson) [22:49:03] (03PS1) 10Hoo man: Update Wikidata to fix ContentRetriever fatal [core] (wmf/1.23wmf18) - 10https://gerrit.wikimedia.org/r/118625 [22:51:24] (03PS4) 10Jdlrobson: Add prebodyhtml template variable [core] - 10https://gerrit.wikimedia.org/r/117904 [22:51:26] (03PS1) 10Hoo man: Update Wikidata to fix ContentRetriever fatal [core] (wmf/1.23wmf17) - 10https://gerrit.wikimedia.org/r/118627 [22:51:53] (03PS2) 10Jdlrobson: Skin: Make #bodyContent standard across all our skins. [core] - 10https://gerrit.wikimedia.org/r/118589 [22:52:47] (03CR) 10Bsitu: "There is still one slight problem. If you click on Full view then Collpsed view again, clicking on 'Comment (n)' only opens the threads, " [extensions/Flow] - 10https://gerrit.wikimedia.org/r/118299 (owner: 10Matthias Mullie) [22:52:52] (03CR) 10Kaldari: [C: 032] Add prebodyhtml template variable [core] - 10https://gerrit.wikimedia.org/r/117904 (owner: 10Jdlrobson) [22:53:12] (03PS3) 10Jdlrobson: Skin: Make #bodyContent standard across all our skins. [core] - 10https://gerrit.wikimedia.org/r/118589 [22:53:53] (03CR) 10Hoo man: [C: 032] Update Wikidata to fix ContentRetriever fatal [core] (wmf/1.23wmf18) - 10https://gerrit.wikimedia.org/r/118625 (owner: 10Hoo man) [22:56:33] gwicke: speaking of parsoid ;) ...is there a way to get the raw template wikicode? [22:56:43] for a specific mw:Transclusion [22:57:20] afaik best you can do is get title from the json properties, and ask the wiki directly? [22:58:22] (03CR) 10Bsitu: [C: 032] Send all wfDebugLog calls to the 'Flow' logGroup [extensions/Flow] - 10https://gerrit.wikimedia.org/r/118015 (owner: 10EBernhardson) [22:58:40] (03Merged) 10jenkins-bot: Send all wfDebugLog calls to the 'Flow' logGroup [extensions/Flow] - 10https://gerrit.wikimedia.org/r/118015 (owner: 10EBernhardson) [22:58:50] ebernhardson: what do you mean by "ask the wiki"? [22:59:04] theopolisme: there must be an api call that returns the wikicode for a given title? [22:59:10] assuming wikicode === wikitext? [22:59:39] * ebernhardson pokes in the includes/api/ folder a bit [22:59:56] (03Merged) 10jenkins-bot: Add prebodyhtml template variable [core] - 10https://gerrit.wikimedia.org/r/117904 (owner: 10Jdlrobson) [23:00:00] (03CR) 10Siebrand: [C: 04-1] "Per Brian." [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/101494 (owner: 10Apsdehal) [23:00:03] (03CR) 10Chad: [C: 032] Update Cirrus submodule to pull word_count fix [core] (wmf/1.23wmf18) - 10https://gerrit.wikimedia.org/r/118605 (owner: 10Chad) [23:00:05] (03CR) 10Chad: [C: 032] Update Cirrus submodule to pull word_count fix [core] (wmf/1.23wmf17) - 10https://gerrit.wikimedia.org/r/118604 (owner: 10Chad) [23:00:10] ebernhardson: ah, i mean the code resulting in a specific transclusion, so say if someone typed {{foo|bar|t=hi}} [23:00:34] this generates some html, parsoid makes an mw:Transclusion object that has the data about the parameters [23:01:02] (03Merged) 10jenkins-bot: Update Wikidata to fix ContentRetriever fatal [core] (wmf/1.23wmf18) - 10https://gerrit.wikimedia.org/r/118625 (owner: 10Hoo man) [23:01:35] theopolisme: ahha, well i know all the info is there in the html because parsoid can reverse the html into wikitext with no other content, but not entirely sure what the process is(also thats likely not future proof, it may change without notice) [23:02:26] yeah, exactly. i see there is some sort of 'pi' data stored (parameter information?) that includes whether or not the parameters are named/etc...the info is all definitely there [23:03:14] i'm just writing a tool that uses parsoid to parse templates, but then i need to update the templates :P [23:03:26] which involves matching and replacing them [23:06:25] (03Merged) 10jenkins-bot: Update Cirrus submodule to pull word_count fix [core] (wmf/1.23wmf18) - 10https://gerrit.wikimedia.org/r/118605 (owner: 10Chad) [23:06:41] (03Merged) 10jenkins-bot: Update Cirrus submodule to pull word_count fix [core] (wmf/1.23wmf17) - 10https://gerrit.wikimedia.org/r/118604 (owner: 10Chad) [23:07:20] (03PS4) 10EBernhardson: Only load the container on flow pages [extensions/Flow] - 10https://gerrit.wikimedia.org/r/115861 [23:09:14] (03CR) 10EBernhardson: [C: 032] diff link for a post is action=compare-post-revisions [extensions/Flow] - 10https://gerrit.wikimedia.org/r/118040 (owner: 10Bsitu) [23:09:28] (03CR) 10jenkins-bot: [V: 04-1] diff link for a post is action=compare-post-revisions [extensions/Flow] - 10https://gerrit.wikimedia.org/r/118040 (owner: 10Bsitu) [23:09:29] (03PS4) 10EBernhardson: diff link for a post is action=compare-post-revisions [extensions/Flow] - 10https://gerrit.wikimedia.org/r/118040 (owner: 10Bsitu) [23:09:30] (03CR) 10EBernhardson: [C: 032] diff link for a post is action=compare-post-revisions [extensions/Flow] - 10https://gerrit.wikimedia.org/r/118040 (owner: 10Bsitu) [23:09:43] (03Merged) 10jenkins-bot: diff link for a post is action=compare-post-revisions [extensions/Flow] - 10https://gerrit.wikimedia.org/r/118040 (owner: 10Bsitu) [23:13:05] (03PS1) 10Krinkle: Update VisualEditor submodule to 5280060 (latest wmf/1.23wmf18) [core] (wmf/1.23wmf18) - 10https://gerrit.wikimedia.org/r/118631 [23:13:16] (03CR) 10Krinkle: [C: 032] Update VisualEditor submodule to 5280060 (latest wmf/1.23wmf18) [core] (wmf/1.23wmf18) - 10https://gerrit.wikimedia.org/r/118631 (owner: 10Krinkle) [23:17:19] (03CR) 10Trevor Parscal: [C: 032] Update OOjs UI to v0.1.0-pre (46ccd5b3a7) [core] - 10https://gerrit.wikimedia.org/r/118411 (owner: 10Jforrester) [23:18:19] (03Merged) 10jenkins-bot: Update VisualEditor submodule to 5280060 (latest wmf/1.23wmf18) [core] (wmf/1.23wmf18) - 10https://gerrit.wikimedia.org/r/118631 (owner: 10Krinkle) [23:20:37] (03Merged) 10jenkins-bot: Update OOjs UI to v0.1.0-pre (46ccd5b3a7) [core] - 10https://gerrit.wikimedia.org/r/118411 (owner: 10Jforrester) [23:22:02] (03CR) 10Hoo man: [C: 032] Update Wikidata to fix ContentRetriever fatal [core] (wmf/1.23wmf17) - 10https://gerrit.wikimedia.org/r/118627 (owner: 10Hoo man) [23:22:21] (03CR) 10EBernhardson: [C: 032] "Submitted bugzilla ticket to have this change applied after March 25 when this patch will hit phase2:" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/115619 (owner: 10Matthias Mullie) [23:22:47] (03CR) 10jenkins-bot: [V: 04-1] Drop tree_orig_create_time [extensions/Flow] - 10https://gerrit.wikimedia.org/r/115619 (owner: 10Matthias Mullie) [23:24:56] (03PS3) 10EBernhardson: Drop tree_orig_create_time [extensions/Flow] - 10https://gerrit.wikimedia.org/r/115619 (owner: 10Matthias Mullie) [23:25:25] (03CR) 10EBernhardson: [C: 032] Drop tree_orig_create_time [extensions/Flow] - 10https://gerrit.wikimedia.org/r/115619 (owner: 10Matthias Mullie) [23:25:36] (03Merged) 10jenkins-bot: Drop tree_orig_create_time [extensions/Flow] - 10https://gerrit.wikimedia.org/r/115619 (owner: 10Matthias Mullie) [23:26:42] (03Merged) 10jenkins-bot: Update Wikidata to fix ContentRetriever fatal [core] (wmf/1.23wmf17) - 10https://gerrit.wikimedia.org/r/118627 (owner: 10Hoo man) [23:27:07] (03CR) 10Jack Phoenix: [C: 04-1] "#bodyContent already exists on MonoBook (line 85) and IDs should be unique." [core] - 10https://gerrit.wikimedia.org/r/118589 (owner: 10Jdlrobson) [23:30:47] (03PS4) 10Jforrester: Add a whitelisting functionality for registrant hooks [extensions/BetaFeatures] - 10https://gerrit.wikimedia.org/r/117630 [23:30:57] (03CR) 10Jforrester: [C: 032] Add a whitelisting functionality for registrant hooks [extensions/BetaFeatures] - 10https://gerrit.wikimedia.org/r/117630 (owner: 10Jforrester) [23:31:24] (03CR) 10Jforrester: "That would have been me failing to try to publish two comments. Ahem. :-)" (032 comments) [extensions/BetaFeatures] - 10https://gerrit.wikimedia.org/r/117630 (owner: 10Jforrester) [23:34:58] (03PS1) 10Jackmcbarn: Unlink/remove blacklisted links during parse [extensions/SpamBlacklist] - 10https://gerrit.wikimedia.org/r/118636 [23:47:20] (03CR) 10Parent5446: Refactor password validity checking (031 comment) [core] - 10https://gerrit.wikimedia.org/r/118233 (owner: 10CSteipp) [23:47:46] (03CR) 10Parent5446: "Ah OK" [core] - 10https://gerrit.wikimedia.org/r/118256 (owner: 10leucosticte) [23:50:18] (03CR) 10jenkins-bot: [V: 04-1] Update OOjs UI to v0.1.0-pre (5345806a96) [core] - 10https://gerrit.wikimedia.org/r/118640 (owner: 10Jforrester) [23:58:18] (03CR) 10CSteipp: Refactor password validity checking (031 comment) [core] - 10https://gerrit.wikimedia.org/r/118233 (owner: 10CSteipp) [23:58:55] (03CR) 10Chad: [C: 032] Remove JavaScript link insertion code [extensions/WikimediaShopLink] - 10https://gerrit.wikimedia.org/r/117814 (owner: 10Ori.livneh) [23:58:59] (03Merged) 10jenkins-bot: Remove JavaScript link insertion code [extensions/WikimediaShopLink] - 10https://gerrit.wikimedia.org/r/117814 (owner: 10Ori.livneh) [23:59:22] ^d: weee. that's another JS module that bites the dust. [23:59:53] (03CR) 10Werdna: [C: 031] "Looks fine, but let's instead have a list of handlers including these two, makes things more modular and nice :)." [extensions/Flow] - 10https://gerrit.wikimedia.org/r/118565 (owner: 10Matthias Mullie)