[00:01:14] (03CR) 10Daniel Friesen: "Right Windows was the other issue, aren't there also Windows Server versions that can't even support symbolic links at all still running? " [core] - 10https://gerrit.wikimedia.org/r/114984 (owner: 10Bartosz Dziewoński) [00:03:00] btw, I discovered the best thing ever if you like SSH – "mosh" [00:04:15] werdna: 2011 called... [00:04:24] YuviPanda: okay I'm slow :p [00:04:32] but seriously how has nobody told me about this before [00:04:58] werdna: :D [00:05:48] (03PS2) 10AzaToth: grrrit: Fix check in repo_config for "repos" [labs/tools/grrrit] - 10https://gerrit.wikimedia.org/r/118028 [00:06:30] Oh come now, 2012 at earliest [00:06:42] https://en.wikipedia.org/wiki/Mosh ty wikipedia [00:07:01] Initial Release March 12, 2012; 23 months ago [00:07:30] I demand to be bubbled by our search engine [00:08:00] werdna: true, true. [00:14:57] (03PS2) 10Mattflaschen: WIP: Refactor and add non-linear tours [extensions/GuidedTour] - 10https://gerrit.wikimedia.org/r/116228 [00:15:32] (03CR) 10jenkins-bot: [V: 04-1] WIP: Refactor and add non-linear tours [extensions/GuidedTour] - 10https://gerrit.wikimedia.org/r/116228 (owner: 10Mattflaschen) [00:16:15] (03CR) 10Mattflaschen: "This is just a rebase, plus the small TODO items from PS1. I also removed the tour parameter from the step. I'm not sure if I'll end up " [extensions/GuidedTour] - 10https://gerrit.wikimedia.org/r/116228 (owner: 10Mattflaschen) [00:16:28] (03CR) 10Mattflaschen: WIP: Refactor and add non-linear tours (035 comments) [extensions/GuidedTour] - 10https://gerrit.wikimedia.org/r/116228 (owner: 10Mattflaschen) [00:18:34] (03CR) 10Isarra: "I don't know, when did they quit using FAT?" [core] - 10https://gerrit.wikimedia.org/r/114984 (owner: 10Bartosz Dziewoński) [00:28:58] (03PS4) 10Bsitu: Add summary revision type [extensions/Flow] - 10https://gerrit.wikimedia.org/r/117357 [00:36:28] (03PS5) 10Bsitu: Add summary revision type [extensions/Flow] - 10https://gerrit.wikimedia.org/r/117357 [00:42:23] (03PS1) 10Bsitu: diff link for a post is action=compare-post-revisions [extensions/Flow] - 10https://gerrit.wikimedia.org/r/118040 [00:43:45] (03PS1) 10Kaldari: Don't load the apex theme for oojs-ui if we're using Minerva skin [core] - 10https://gerrit.wikimedia.org/r/118041 [00:44:08] (03PS2) 10Bsitu: diff link for a post is action=compare-post-revisions [extensions/Flow] - 10https://gerrit.wikimedia.org/r/118040 [00:58:35] (03PS2) 10Jdlrobson: WIP: Prep work for responsive design [extensions/VectorBeta] - 10https://gerrit.wikimedia.org/r/117927 [00:58:39] (03PS2) 10Kaldari: Don't load the apex theme for oojs-ui if we're using Minerva skin [core] - 10https://gerrit.wikimedia.org/r/118041 [00:59:04] (03CR) 10Jforrester: [C: 032] Don't load the apex theme for oojs-ui if we're using Minerva skin [core] - 10https://gerrit.wikimedia.org/r/118041 (owner: 10Kaldari) [00:59:36] (03CR) 10jenkins-bot: [V: 04-1] WIP: Prep work for responsive design [extensions/VectorBeta] - 10https://gerrit.wikimedia.org/r/117927 (owner: 10Jdlrobson) [01:03:34] (03Merged) 10jenkins-bot: Don't load the apex theme for oojs-ui if we're using Minerva skin [core] - 10https://gerrit.wikimedia.org/r/118041 (owner: 10Kaldari) [01:06:02] Hi hexmode: are you there? [01:12:05] zeek_: y [01:13:37] hexmode: I was going thru this bug. https://bugzilla.wikimedia.org/show_bug.cgi?id=61568 .... and the comment wasn't clear enough to help me reproduce it, but going by it I did the modification... please do a sanity check cause I am not sure.... http://www.fpaste.org/84154/39450029/ [01:14:46] zeek_: checking [01:16:32] zeek_: could you you provide a diff? [01:17:14] https://git.wikimedia.org/blob/mediawiki%2Fextensions%2FLiquidThreads/9312df05a8df29db64b90b154c9b3a02db903275/classes%2FView.php#L1930 [01:17:32] just changed line 1930 to :- $this->output->addHTML( $div . $link. '' ); [01:20:25] hexmode: ^ [01:20:59] zeek_: yeah, just trying to grok + make sure it works with end of function [01:21:34] ok [01:22:43] (03PS1) 10Yaron Koren: SMW code now only called if SMW is installed [extensions/ApprovedRevs] - 10https://gerrit.wikimedia.org/r/118048 [01:23:11] zeek_: so, yeah, that's what the bug says. I'm not sure it is right, but only one way: test! [01:23:23] zeek_: can you submit to gerrit? [01:23:24] (03CR) 10Yaron Koren: [C: 032 V: 031] SMW code now only called if SMW is installed [extensions/ApprovedRevs] - 10https://gerrit.wikimedia.org/r/118048 (owner: 10Yaron Koren) [01:23:27] (03Merged) 10jenkins-bot: SMW code now only called if SMW is installed [extensions/ApprovedRevs] - 10https://gerrit.wikimedia.org/r/118048 (owner: 10Yaron Koren) [01:24:34] hexmode: Little issue there... I use https to submit changes.. so I have the syntax for submiting it to core given by demon... but, not sure about this. [01:25:09] zeek_: do you have an account on gerrit? [01:25:28] and, do you have git-review installed? [01:25:43] yeah i have it.. the problem is ssh is blocked on my network.. so i used https :| [01:25:50] ah [01:25:54] :{ [01:25:56] i do this... git push https://gerrit.wikimedia.org/r/p/mediawiki/core HEAD:refs/for/master [01:26:14] demon had told me this command [01:26:21] gotcha [01:26:32] well, that isn't the right place [01:26:44] you should use ... (sec) [01:27:04] O:) [01:28:38] zeek_: I *think* this is the URL you want: https://gerrit.wikimedia.org/r/p/mediawiki/extensions/LiquidThreads [01:29:02] but I've never submitted that way, so let me know what happens [01:29:27] sure. [01:29:44] but... [01:29:52] what will be the reference for my branch... [01:29:59] HEAD:refs/for/master [01:30:02] this only? [01:30:03] O.o [01:30:26] I think that will work [01:30:32] ok let me try [01:38:01] hexmode: On it. Just realised that the git inside the LiquidThread directory needs global settings [01:38:17] :) [01:41:56] (03PS1) 10Adi.iiita: Added div to fix show more replies link generates malformed HTML [extensions/LiquidThreads] - 10https://gerrit.wikimedia.org/r/118049 [01:42:16] zeek_: worked! [01:42:42] kudos :) [01:43:33] MyM™? [01:43:59] Amgine: yeah. heh [01:44:23] [01:45:02] zeek_: ok, cool, I think the next step is doing what Quim said in his email about a formal app? [01:45:20] * hexmode goes to re-read Quim's email [01:45:39] * zeek_ goes to re-read Quim's email [01:45:48] oops :P [01:46:05] [01:46:15] zeek_: type "/me goes ..." [01:46:47] * zeek_ goes experimenting  [01:46:54] cool :) [01:47:17] * Amgine trouts hexmode [01:48:45] (03CR) 10MarkAHershberger: [C: 032] "does as the bug requests." [extensions/LiquidThreads] - 10https://gerrit.wikimedia.org/r/118049 (owner: 10Adi.iiita) [01:48:47] (03Merged) 10jenkins-bot: Added div to fix show more replies link generates malformed HTML [extensions/LiquidThreads] - 10https://gerrit.wikimedia.org/r/118049 (owner: 10Adi.iiita) [01:49:08] hexmode: Thanks for the merge. :) ................ For the other bugs, i will have to install lucene.. and i think thats not good for a nocturnal night which just turned into sunrise.. so i shall continue with it after grabbing some sleep. [01:49:29] zeek_: http://permalink.gmane.org/gmane.science.linguistics.wikipedia.technical/75923 [01:50:07] * hexmode looks up "trouts" so he can understand Amgine  [01:50:39] Old IRC command was /slap [nick] [01:50:51] ah [01:50:53] sort of the proto /me command. [01:51:10] I avoided IRC in college for the most part [01:51:28] so I'm a newbie, I guess, compared with you [01:51:29] Ah... you missed a lot of terrible puns. [01:52:09] it would say things like "Amgine slaps hexmode with a large trout." or something similar. [01:52:10] hexmode: read the link.... i shall work on it too today itself and would join the IRC meet today.... [01:55:58] hexmode: Ok then I think I should leave now... feeling sleep deprived.. I shall see you after some hours if you available.. Thanks for the merge and link again. :) [01:56:12] zeek_: np [01:56:15] night! [01:56:26] * zeek_ goes to grab some sleep!  [01:56:29] or morning, as the case may be [01:56:31] :) [02:09:31] (03CR) 10MarkAHershberger: "Commit message should have ended with "Bug: 61568" (note the colon) so it would be picked up automatically by the bot that syncs commits w" [extensions/LiquidThreads] - 10https://gerrit.wikimedia.org/r/118049 (owner: 10Adi.iiita) [02:18:43] Hi, I have a small problem using bugzilla. Anyone? [02:19:34] On this page : https://gerrit.wikimedia.org/r/#/c/110949/4/maintenance/archives/patch-clean_timestamps.sql , when I reply to a comment, it gets saved as draft, and is not viewable. How do I comment on it? [02:22:01] On the page : https://gerrit.wikimedia.org/r/#/c/110949/4/maintenance/archives/patch-clean_timestamps.sql , when I reply to a comment, it gets saved as draft, and is not viewable. How do I comment publicly and not as a draft? [02:22:04] That's a problem using gerrit, and I can't help with that but I suspect someone here knows how to help you. [02:24:32] found the solution : http://stackoverflow.com/questions/6307545/not-able-to-add-comments-on-gerrit-it-rather-gets-added-as-draft-what-am-i-doi [02:24:37] :) [02:27:06] cool! [02:32:50] (03CR) 10Pawanseerwani: "@Foxtrott : I had replied to one of them earlier, and others were accidently saved as draft(din't know it requires a CR comment for publis" [core] - 10https://gerrit.wikimedia.org/r/110949 (owner: 10Gerrit Patch Uploader) [02:34:06] It still din't get published, the problem still persists [02:34:17] :( [02:34:22] Anyone? [02:35:27] ^d is usually knowledgeable about Gerrit issues, but may be asleep at this time. [02:35:53] pawan_seerwani: you need to actually publish your comments [02:35:55] go back to the main change page [02:36:02] and then down the bottom click on "Review" or "Publish" [02:38:03] If that doesn't work, ping Gloria. Not because xe will be able to help you, but just because random pings of Gloria are always appropriate. [02:39:08] * Gloria agrees with werdna. [02:39:16] * Gloria tickles Amgine endlessly [02:39:17] . [02:39:20] * werdna pings Gloria and Amgine  [02:39:30] [02:40:14] (03CR) 10Pawanseerwani: "All my inline comments are getting saved as draft and are not being published. Is it a bug, or am I doing something wrong?" [core] - 10https://gerrit.wikimedia.org/r/110949 (owner: 10Gerrit Patch Uploader) [02:40:32] well, that worked. [02:43:01] There's little doubt that I could eat this entire pint of ice cream. [02:43:04] The question is should I. [02:43:21] couldn't * [02:43:24] Words are hard. [02:44:18] Gloria: only half. So tomorrow you have something to feel guilty about too. [02:44:21] @werdna : I cannot find the "Review" or "Pubilsh" button [02:45:41] I put it back in the freezer. [02:45:41] You mean the main page like this : https://gerrit.wikimedia.org/r/#/c/110949/ ?? [02:45:45] Even half was a lot. [02:45:48] Such guilt. [02:51:44] pawan_seerwani: yep [02:52:18] I still don't see the button to publish my inline comment [02:52:36] could you post a screen shot of the button ? [02:52:47] pawan_seerwani: Do you see "1 draft"? [02:53:10] pawan_seerwani: https://www.dropbox.com/s/kzckq23r65grvkk/Screenshot%202014-03-11%2013.52.38.png [02:53:14] you need to click on "Add Comment" [02:53:16] and, this is important [02:53:23] you need to do it on the patchset that the comments are on [02:55:49] Thanks werdna! I had accidently reviewed for patch5 but the comments were in patch 4. My bad. [02:57:29] (03CR) 10Pawanseerwani: "I had accidently reviewed for patch 5 but the comments were in patch 4. My bad. Sorry." (034 comments) [core] - 10https://gerrit.wikimedia.org/r/110949 (owner: 10Gerrit Patch Uploader) [03:02:09] (03CR) 10Parent5446: Add script for renaming a user option (033 comments) [core] - 10https://gerrit.wikimedia.org/r/117872 (owner: 10Aude) [03:14:57] (03PS1) 10Andrew Bogott: Start a fresh region section for each region. Fixes bug 62478 [extensions/OpenStackManager] - 10https://gerrit.wikimedia.org/r/118050 [03:15:45] (03CR) 10Andrew Bogott: [C: 032] Start a fresh region section for each region. Fixes bug 62478 [extensions/OpenStackManager] - 10https://gerrit.wikimedia.org/r/118050 (owner: 10Andrew Bogott) [03:15:47] (03Merged) 10jenkins-bot: Start a fresh region section for each region. Fixes bug 62478 [extensions/OpenStackManager] - 10https://gerrit.wikimedia.org/r/118050 (owner: 10Andrew Bogott) [03:55:47] (03PS1) 10BryanDavis: Remove scap.tasks.scap [tools/scap] - 10https://gerrit.wikimedia.org/r/118051 [03:58:42] (03CR) 10BryanDavis: Remove scap.tasks.scap (031 comment) [tools/scap] - 10https://gerrit.wikimedia.org/r/118051 (owner: 10BryanDavis) [04:31:29] (03PS1) 10Physikerwelt: Add description to identifiers [extensions/MathSearch] - 10https://gerrit.wikimedia.org/r/118052 [04:34:45] (03CR) 10Physikerwelt: [C: 032 V: 032] Add description to identifiers [extensions/MathSearch] - 10https://gerrit.wikimedia.org/r/118052 (owner: 10Physikerwelt) [06:21:09] (03PS2) 10AndyRussG: WIP Schema change: create tables [extensions/Campaigns] (wip/editorcampaigns) - 10https://gerrit.wikimedia.org/r/117905 [06:27:30] (03PS9) 10AndyRussG: WIP Stubs and tests for persistence objects [extensions/Campaigns] (wip/editorcampaigns) - 10https://gerrit.wikimedia.org/r/116221 [06:34:26] (03CR) 10AndyRussG: "Rebased once more" [extensions/Campaigns] (wip/editorcampaigns) - 10https://gerrit.wikimedia.org/r/116221 (owner: 10AndyRussG) [06:37:18] (03PS10) 10AndyRussG: WIP Add persistence objects and tests [extensions/Campaigns] (wip/editorcampaigns) - 10https://gerrit.wikimedia.org/r/116221 [08:33:27] (03CR) 10Gilles: jquery audit of mw.GroupProgressBar.js (031 comment) [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/86810 (owner: 10MarkTraceur) [08:55:02] (03CR) 10Daniel Kinzler: [C: 032] Introduce stashMwGlobals method to MediaWikiTestCase [core] - 10https://gerrit.wikimedia.org/r/117036 (owner: 10Addshore) [08:56:35] (03CR) 10Daniel Kinzler: [C: 032] Throw exception when trying to stash unset globals [core] - 10https://gerrit.wikimedia.org/r/117039 (owner: 10Addshore) [08:57:15] (03CR) 10Daniel Kinzler: [C: 032] Cleanup MediawikiTestCase [core] - 10https://gerrit.wikimedia.org/r/116974 (owner: 10Addshore) [09:00:03] (03CR) 10Daniel Kinzler: [C: 031] Cleanup a bunch of tests and add todos [core] - 10https://gerrit.wikimedia.org/r/117464 (owner: 10Addshore) [09:00:05] (03Merged) 10jenkins-bot: Introduce stashMwGlobals method to MediaWikiTestCase [core] - 10https://gerrit.wikimedia.org/r/117036 (owner: 10Addshore) [09:00:19] (03Merged) 10jenkins-bot: Throw exception when trying to stash unset globals [core] - 10https://gerrit.wikimedia.org/r/117039 (owner: 10Addshore) [09:01:10] (03Merged) 10jenkins-bot: Cleanup MediawikiTestCase [core] - 10https://gerrit.wikimedia.org/r/116974 (owner: 10Addshore) [09:43:41] (03CR) 10Nemo bis: "Sigh, initMessagesHref in SideBarTest is completely idiotic, it doesn't test anything meaningful AFAICS." [core] - 10https://gerrit.wikimedia.org/r/83221 (owner: 10Nemo bis) [09:53:12] (03CR) 10Siebrand: [C: 031] "i18n/L10n reviewed." [core] - 10https://gerrit.wikimedia.org/r/117635 (owner: 10CSteipp) [09:54:12] (03CR) 10Siebrand: [C: 031] "i18n/L10n reviewed." [extensions/SpamBlacklist] - 10https://gerrit.wikimedia.org/r/117231 (owner: 10Jackmcbarn) [09:54:35] (03CR) 10Matthias Mullie: "I'd merge this, but I'm afraid the schema change will get lost & not happen in production." [extensions/Flow] - 10https://gerrit.wikimedia.org/r/116226 (owner: 10Bsitu) [09:54:49] (03CR) 10Siebrand: [C: 032] Add final period to API module descriptions [extensions/CodeReview] - 10https://gerrit.wikimedia.org/r/117925 (owner: 10Umherirrender) [09:54:56] (03Merged) 10jenkins-bot: Add final period to API module descriptions [extensions/CodeReview] - 10https://gerrit.wikimedia.org/r/117925 (owner: 10Umherirrender) [09:55:41] (03CR) 10Siebrand: [C: 032] Add missing DROP SEQUENCE to postgres' tables.sql [core] - 10https://gerrit.wikimedia.org/r/116166 (owner: 10Umherirrender) [09:56:22] (03CR) 10Matthias Mullie: [C: 032] Fix a typo in class instance variable [extensions/Flow] - 10https://gerrit.wikimedia.org/r/117023 (owner: 10Bsitu) [09:56:45] (03Merged) 10jenkins-bot: Fix a typo in class instance variable [extensions/Flow] - 10https://gerrit.wikimedia.org/r/117023 (owner: 10Bsitu) [09:58:00] (03CR) 10Siebrand: [C: 032] "@liangent: Just add it to the release where you think it suits best." [core] - 10https://gerrit.wikimedia.org/r/111968 (owner: 10Liangent) [09:59:04] (03CR) 10Matthias Mullie: [C: 031] "Apart from not yet being clear if it's ok that workflows can no longer be loaded by a specific workflow_type (which is not currently being" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/115576 (owner: 10EBernhardson) [09:59:07] (03CR) 10Siebrand: [C: 04-1] "The modern era is JSON based i18n. See https://www.mediawiki.org/wiki/Manual:GenerateJSONi18n.php for a quick start guide." [extensions/PageNotice] - 10https://gerrit.wikimedia.org/r/105141 (owner: 10TTO) [09:59:50] (03Merged) 10jenkins-bot: Add missing DROP SEQUENCE to postgres' tables.sql [core] - 10https://gerrit.wikimedia.org/r/116166 (owner: 10Umherirrender) [10:01:19] (03Merged) 10jenkins-bot: Remove user preference "noconvertlink" [core] - 10https://gerrit.wikimedia.org/r/111968 (owner: 10Liangent) [10:05:56] (03CR) 10Siebrand: [C: 032] Address i18n issue [extensions/CreditsSource] - 10https://gerrit.wikimedia.org/r/112958 (owner: 10Matthias Mullie) [10:05:58] (03Merged) 10jenkins-bot: Address i18n issue [extensions/CreditsSource] - 10https://gerrit.wikimedia.org/r/112958 (owner: 10Matthias Mullie) [10:07:23] (03CR) 10Siebrand: [C: 031] "i18n reviewed." [core] - 10https://gerrit.wikimedia.org/r/109853 (owner: 10Yurik) [10:09:47] (03PS15) 10Nemo bis: Add link to PD help translatable pages from sidebar [core] - 10https://gerrit.wikimedia.org/r/83221 [10:10:24] (03PS16) 10Nemo bis: Add link to PD help translatable pages from sidebar [core] - 10https://gerrit.wikimedia.org/r/83221 [10:10:32] (03CR) 10Nemo bis: Add link to PD help translatable pages from sidebar (033 comments) [core] - 10https://gerrit.wikimedia.org/r/83221 (owner: 10Nemo bis) [10:12:18] (03CR) 10jenkins-bot: [V: 04-1] Add link to PD help translatable pages from sidebar [core] - 10https://gerrit.wikimedia.org/r/83221 (owner: 10Nemo bis) [10:13:56] (03PS17) 10Nemo bis: Add link to PD help translatable pages from sidebar [core] - 10https://gerrit.wikimedia.org/r/83221 [10:17:56] (03CR) 10Nemo bis: "PS15 addressing last inline comments and fixing wrong tests; PS16-17 rebase." (031 comment) [core] - 10https://gerrit.wikimedia.org/r/83221 (owner: 10Nemo bis) [10:19:07] (03CR) 10jenkins-bot: [V: 04-1] Add link to PD help translatable pages from sidebar [core] - 10https://gerrit.wikimedia.org/r/83221 (owner: 10Nemo bis) [10:22:13] (03PS18) 10Nemo bis: Add link to PD help translatable pages from sidebar [core] - 10https://gerrit.wikimedia.org/r/83221 [10:26:24] (03CR) 10Nikerabbit: [C: 04-2] "Please do not merge yet, I will amend these with more fixes as I go on to have clean patches." [extensions/LocalisationUpdate] (json-rewrite) - 10https://gerrit.wikimedia.org/r/117177 (owner: 10Nikerabbit) [10:43:13] (03PS1) 10Phuedx: Import config generation script from Gist [extensions/GettingStarted] - 10https://gerrit.wikimedia.org/r/118063 [10:57:06] (03CR) 10Phuedx: "Mattflaschen: testing this is a little awkward because Title#secureAndSplit checks Interwiki::isValidInterwiki as it's stripping the prefi" [extensions/GettingStarted] - 10https://gerrit.wikimedia.org/r/118063 (owner: 10Phuedx) [11:11:06] (03CR) 10Addshore: [C: 04-1] "see comments" [core] - 10https://gerrit.wikimedia.org/r/97742 (owner: 10Aude) [11:11:37] :( [11:12:08] line or no line? [11:13:22] (03PS7) 10Nemo bis: Link to existing login help page by default from helplogin-url [core] - 10https://gerrit.wikimedia.org/r/83220 [11:13:25] (03CR) 10Nemo bis: "Rebased" [core] - 10https://gerrit.wikimedia.org/r/83220 (owner: 10Nemo bis) [11:24:48] (03PS7) 10MaxSem: Make ResourceLoader minifiers extendable [core] - 10https://gerrit.wikimedia.org/r/74293 [11:50:13] (03PS2) 10Phuedx: Stop the rightmost toolbar section wrapping [extensions/GettingStarted] - 10https://gerrit.wikimedia.org/r/117874 [11:50:15] (03PS4) 10Phuedx: Make the toolbar respond to a content overflow [extensions/GettingStarted] - 10https://gerrit.wikimedia.org/r/115176 [11:50:56] (03CR) 10Hcohl: [C: 031] Coverage tests for the Math extension [extensions/Math] - 10https://gerrit.wikimedia.org/r/112353 (owner: 10Physikerwelt) [11:54:47] (03CR) 10Phuedx: "Good spot Mattflaschen. Done by repurposing the old -vshift CSS classes." [extensions/GettingStarted] - 10https://gerrit.wikimedia.org/r/115176 (owner: 10Phuedx) [12:54:56] (03CR) 10Addshore: [C: 04-1] Coverage tests for the Math extension (039 comments) [extensions/Math] - 10https://gerrit.wikimedia.org/r/112353 (owner: 10Physikerwelt) [12:57:20] (03PS1) 10Liangent: Add release note for removal of preference "noconvertlink" [core] - 10https://gerrit.wikimedia.org/r/118066 [13:03:49] (03CR) 10Siebrand: [C: 032] Add release note for removal of preference "noconvertlink" [core] - 10https://gerrit.wikimedia.org/r/118066 (owner: 10Liangent) [13:04:09] Could an error in the database have caused an offset of some kind causing https://en.wikipedia.org/wiki/Wikipedia:Help_desk#How_do_I_stop_watching_the_protection_log.3F [13:05:28] Oh good... anomie, Could an error in the database have caused an offset of some kind causing https://en.wikipedia.org/wiki/Wikipedia:Help_desk#How_do_I_stop_watching_the_protection_log.3F [13:06:30] The reason I'm befuddled by this somewhat is because we don't have "Thread:" or "Extension:" on enwp... [13:07:09] Technical_13: Doesn't seem likely, but I'll have a look around. As for that, he probably copied his watchlist from mediawiki.org into enwiki. [13:07:24] (03Merged) 10jenkins-bot: Add release note for removal of preference "noconvertlink" [core] - 10https://gerrit.wikimedia.org/r/118066 (owner: 10Liangent) [13:07:27] (03CR) 10Gilles: [C: 032] Comply with WCAG 2.0 H44 - label form control association [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/117414 (owner: 10Rillke) [13:07:33] (03PS1) 10Liangent: Partly revert 28b4dd5f for zh and zh-cn/hk/mo/sg/tw messages [core] - 10https://gerrit.wikimedia.org/r/118067 [13:07:33] So, I'm wondering if it is pulling the listing for their user number on mw wiki [13:08:06] possible. Anyways, I'm off to catch a bus to receive my scholarship for a free class... :) [13:08:09] I highly doubt it [13:08:43] I do too, and if it did, that would be a MAJOR security issue, which is why I thought since it is possible, I better note it here and let you all deal with it. [13:09:00] The database shows [13:09:00] 368 rows in set (0.00 sec) [13:09:29] (03Merged) 10jenkins-bot: Comply with WCAG 2.0 H44 - label form control association [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/117414 (owner: 10Rillke) [13:09:52] None of those 3 pages are in that list [13:10:12] Technical_13: The watchlist for the person with that user's enwiki user_id on mediawiki.org does not at all match what he claims there either. [13:10:22] Well, either way, I didn't note it in the discussion on wiki because I think that would just confuse the user. [13:10:38] Figured I would just point you all to it and let you figure it out. [13:10:53] Times like this a sudo extension could be quite useful ;) [13:11:28] (03CR) 10Siebrand: "If someone touched any page like MediaWiki/Somekey/code, the group for that code will be exported, unless explicitly skipped in export.php" [core] - 10https://gerrit.wikimedia.org/r/118067 (owner: 10Liangent) [13:15:28] (03CR) 10Liangent: "Siebrand: Even if --lang exists with that language code not listed?" [core] - 10https://gerrit.wikimedia.org/r/118067 (owner: 10Liangent) [13:15:49] (03PS2) 10Liangent: Partly revert 28b4dd5f for zh and zh-cn/hk/mo/sg/tw messages [core] - 10https://gerrit.wikimedia.org/r/118067 [13:16:16] (03CR) 10Pawanseerwani: Clean Timestamp Fields in mysql (034 comments) [core] - 10https://gerrit.wikimedia.org/r/110949 (owner: 10Gerrit Patch Uploader) [13:18:10] (03CR) 10Matthias Mullie: Use single query for multiple revision lookups by pk (031 comment) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/115416 (owner: 10EBernhardson) [13:18:55] (03CR) 10Gilles: [C: 032] Replacing deprecated $j.browser with $.client [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/74425 (owner: 10Rillke) [13:19:03] (03Merged) 10jenkins-bot: Replacing deprecated $j.browser with $.client [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/74425 (owner: 10Rillke) [13:20:00] (03CR) 10Jarry1250: "Some code-style comments. Do you use an IDE? PHPStorm provides free licenses if you only use it in relation to MediaWiki. It's a massive h" (032 comments) [extensions/Math] - 10https://gerrit.wikimedia.org/r/112353 (owner: 10Physikerwelt) [13:20:09] (03PS4) 10Matthias Mullie: Use single query for multiple revision lookups by pk [extensions/Flow] - 10https://gerrit.wikimedia.org/r/115416 (owner: 10EBernhardson) [13:20:30] (03CR) 10Matthias Mullie: Use single query for multiple revision lookups by pk (031 comment) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/115416 (owner: 10EBernhardson) [13:22:01] (03PS5) 10Matthias Mullie: Use single query for multiple revision lookups by pk [extensions/Flow] - 10https://gerrit.wikimedia.org/r/115416 (owner: 10EBernhardson) [13:22:13] (03CR) 10Matthias Mullie: [C: 032] Use single query for multiple revision lookups by pk [extensions/Flow] - 10https://gerrit.wikimedia.org/r/115416 (owner: 10EBernhardson) [13:22:26] (03Merged) 10jenkins-bot: Use single query for multiple revision lookups by pk [extensions/Flow] - 10https://gerrit.wikimedia.org/r/115416 (owner: 10EBernhardson) [13:22:44] (03CR) 10Matthias Mullie: [C: 032] Test and fix RevisionStorage partial result [extensions/Flow] - 10https://gerrit.wikimedia.org/r/117233 (owner: 10EBernhardson) [13:22:47] (03CR) 10jenkins-bot: [V: 04-1] Test and fix RevisionStorage partial result [extensions/Flow] - 10https://gerrit.wikimedia.org/r/117233 (owner: 10EBernhardson) [13:23:30] (03PS2) 10Matthias Mullie: Test and fix RevisionStorage partial result [extensions/Flow] - 10https://gerrit.wikimedia.org/r/117233 (owner: 10EBernhardson) [13:23:39] (03CR) 10Matthias Mullie: [C: 032] Test and fix RevisionStorage partial result [extensions/Flow] - 10https://gerrit.wikimedia.org/r/117233 (owner: 10EBernhardson) [13:23:54] (03Merged) 10jenkins-bot: Test and fix RevisionStorage partial result [extensions/Flow] - 10https://gerrit.wikimedia.org/r/117233 (owner: 10EBernhardson) [13:25:00] (03CR) 10Siebrand: [C: 04-1] "I think it would be useful to explain IGO in the qqq." [extensions/WikimediaMessages] - 10https://gerrit.wikimedia.org/r/115597 (owner: 10Rillke) [13:33:11] (03PS3) 10Gilles: Remind user to select a license [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/117428 (owner: 10Rillke) [13:33:46] (03CR) 10Gilles: [C: 032] Remind user to select a license [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/117428 (owner: 10Rillke) [13:33:54] (03Merged) 10jenkins-bot: Remind user to select a license [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/117428 (owner: 10Rillke) [13:35:40] (03CR) 10Siebrand: Add diff view of changes to board header (031 comment) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/109431 (owner: 10Bsitu) [13:38:13] (03CR) 10Anomie: Categorize pages containing blacklisted links (031 comment) [extensions/SpamBlacklist] - 10https://gerrit.wikimedia.org/r/117231 (owner: 10Jackmcbarn) [13:39:41] (03CR) 10Siebrand: [C: 031] "L10n reviewed." [extensions/Thanks] - 10https://gerrit.wikimedia.org/r/115557 (owner: 10Wctaiwan) [13:40:45] (03CR) 10Matthias Mullie: "I'll make 2 small changes (see individual comments), then merge this one" (032 comments) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/115552 (owner: 10Wctaiwan) [13:40:51] (03PS5) 10Matthias Mullie: Allow extension of post interaction links [extensions/Flow] - 10https://gerrit.wikimedia.org/r/115552 (owner: 10Wctaiwan) [13:41:41] (03CR) 10Matthias Mullie: [C: 032] Allow extension of post interaction links [extensions/Flow] - 10https://gerrit.wikimedia.org/r/115552 (owner: 10Wctaiwan) [13:41:53] (03Merged) 10jenkins-bot: Allow extension of post interaction links [extensions/Flow] - 10https://gerrit.wikimedia.org/r/115552 (owner: 10Wctaiwan) [13:46:02] (03CR) 10Matthias Mullie: Add "Thanks" for comments on Flow boards (032 comments) [extensions/Thanks] - 10https://gerrit.wikimedia.org/r/115557 (owner: 10Wctaiwan) [13:46:06] (03PS12) 10Matthias Mullie: Add "Thanks" for comments on Flow boards [extensions/Thanks] - 10https://gerrit.wikimedia.org/r/115557 (owner: 10Wctaiwan) [13:46:09] (03CR) 10jenkins-bot: [V: 04-1] Add "Thanks" for comments on Flow boards [extensions/Thanks] - 10https://gerrit.wikimedia.org/r/115557 (owner: 10Wctaiwan) [13:46:31] (03PS13) 10Matthias Mullie: Add "Thanks" for comments on Flow boards [extensions/Thanks] - 10https://gerrit.wikimedia.org/r/115557 (owner: 10Wctaiwan) [13:54:15] (03CR) 10Siebrand: [C: 031] "L10n reviewed." [extensions/Thanks] - 10https://gerrit.wikimedia.org/r/115557 (owner: 10Wctaiwan) [14:03:51] (03CR) 10Siebrand: "@liangent --lang:a,b,c should never export (if not yet present) or update (if present) d." [core] - 10https://gerrit.wikimedia.org/r/118067 (owner: 10Liangent) [14:04:52] (03CR) 10Chad: [C: 032] More Jenkins fixes [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/117423 (owner: 10Manybubbles) [14:05:03] (03Merged) 10jenkins-bot: More Jenkins fixes [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/117423 (owner: 10Manybubbles) [14:10:09] (03CR) 10Addshore: [C: 04-1] Add "Thanks" for comments on Flow boards (036 comments) [extensions/Thanks] - 10https://gerrit.wikimedia.org/r/115557 (owner: 10Wctaiwan) [14:11:39] (03CR) 10Addshore: [C: 032] Fix mismatched parentheses [extensions/Thanks] - 10https://gerrit.wikimedia.org/r/115817 (owner: 10Jackmcbarn) [14:11:47] (03Merged) 10jenkins-bot: Fix mismatched parentheses [extensions/Thanks] - 10https://gerrit.wikimedia.org/r/115817 (owner: 10Jackmcbarn) [14:13:36] (03CR) 10Addshore: [C: 032] Add COPYING [extensions/Thanks] - 10https://gerrit.wikimedia.org/r/116254 (owner: 10Reedy) [14:13:42] (03Merged) 10jenkins-bot: Add COPYING [extensions/Thanks] - 10https://gerrit.wikimedia.org/r/116254 (owner: 10Reedy) [14:18:05] (03PS1) 10MarkAHershberger: add tarignore [tools/release] - 10https://gerrit.wikimedia.org/r/118072 [14:18:07] (03PS1) 10MarkAHershberger: Remove SimpleAntiSpam from recent versions [tools/release] - 10https://gerrit.wikimedia.org/r/118073 [14:18:09] (03PS1) 10MarkAHershberger: Fix make-release script to use branches instead of tags [tools/release] - 10https://gerrit.wikimedia.org/r/118074 [14:18:11] (03CR) 10jenkins-bot: [V: 04-1] Fix make-release script to use branches instead of tags [tools/release] - 10https://gerrit.wikimedia.org/r/118074 (owner: 10MarkAHershberger) [14:24:34] (03PS1) 10Manybubbles: Remove nasty redirect juggling added for 1.0 [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/118078 [14:25:00] (03CR) 10Manybubbles: [C: 04-1] "I'd like to see what Jenkins' browser tests make of it first because I haven't had time to run them myself this time." [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/118078 (owner: 10Manybubbles) [14:32:45] (03CR) 10Addshore: [C: 032] Adjust description of ApiWikiLoveImageLog [extensions/WikiLove] - 10https://gerrit.wikimedia.org/r/117914 (owner: 10Umherirrender) [14:32:47] (03Merged) 10jenkins-bot: Adjust description of ApiWikiLoveImageLog [extensions/WikiLove] - 10https://gerrit.wikimedia.org/r/117914 (owner: 10Umherirrender) [14:37:06] (03CR) 10Addshore: [C: 04-1] Add getRobotPolicy() (031 comment) [core] - 10https://gerrit.wikimedia.org/r/117832 (owner: 10leucosticte) [14:41:18] (03CR) 10Physikerwelt: "@Jarry1250:" [extensions/Math] - 10https://gerrit.wikimedia.org/r/112353 (owner: 10Physikerwelt) [14:43:01] (03PS2) 10MarkAHershberger: Fix make-release script to use branches instead of tags [tools/release] - 10https://gerrit.wikimedia.org/r/118074 [14:43:10] (03CR) 10Addshore: [C: 032] Couple of minor code updates [extensions/VipsScaler] - 10https://gerrit.wikimedia.org/r/117811 (owner: 10Reedy) [14:43:12] (03Merged) 10jenkins-bot: Couple of minor code updates [extensions/VipsScaler] - 10https://gerrit.wikimedia.org/r/117811 (owner: 10Reedy) [14:44:10] (03PS1) 10MarkAHershberger: 1.19.13 release notes and version update [core] (REL1_19) - 10https://gerrit.wikimedia.org/r/118080 [14:44:32] (03PS1) 10Chad: Fix fatal, $settingsObject got lost in refactoring [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/118081 [14:48:41] (03PS1) 10MarkAHershberger: 1.21.7 release notes and version update [core] (REL1_21) - 10https://gerrit.wikimedia.org/r/118082 [14:49:38] (03CR) 10MarkAHershberger: [C: 032] 1.19.13 release notes and version update [core] (REL1_19) - 10https://gerrit.wikimedia.org/r/118080 (owner: 10MarkAHershberger) [14:52:51] (03Merged) 10jenkins-bot: 1.19.13 release notes and version update [core] (REL1_19) - 10https://gerrit.wikimedia.org/r/118080 (owner: 10MarkAHershberger) [14:54:16] (03PS1) 10MarkAHershberger: 1.22.4 release notes and version update [core] (REL1_22) - 10https://gerrit.wikimedia.org/r/118084 [14:55:43] (03PS2) 10Addshore: Pass correct parameter to stat() in checkImages.php [core] - 10https://gerrit.wikimedia.org/r/117027 (owner: 10AalekhN) [14:55:47] (03PS3) 10Addshore: Pass correct parameter to stat() in checkImages.php [core] - 10https://gerrit.wikimedia.org/r/117027 (owner: 10AalekhN) [14:57:29] (03CR) 10Addshore: Update annotations in RevisionView (031 comment) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/117032 (owner: 10EBernhardson) [15:03:50] anyone around that can delete gerrit repos? :> or where should I request it? :P [15:04:50] addshore: I bet ^d can do it or tell you the right way to ask [15:05:08] (03CR) 10Matthias Mullie: [C: 04-1] "Mostly nitpicking comments - feel free to disagree ;)" (0315 comments) [extensions/Thanks] - 10https://gerrit.wikimedia.org/r/115557 (owner: 10Wctaiwan) [15:06:03] <^d> addshore: What repo? [15:06:16] mediawiki/extensions/DataValuesCommon [15:06:50] (03CR) 10Addshore: [C: 04-1] Add COPYING (031 comment) [extensions/GeoData] - 10https://gerrit.wikimedia.org/r/116252 (owner: 10Reedy) [15:07:05] (03CR) 10Addshore: [C: 04-1] "ugly spaces again :/" [extensions/FeaturedFeeds] - 10https://gerrit.wikimedia.org/r/116250 (owner: 10Reedy) [15:08:05] (03CR) 10Addshore: [C: 032] Add COPYING [extensions/PoolCounter] - 10https://gerrit.wikimedia.org/r/116253 (owner: 10Reedy) [15:08:09] (03Merged) 10jenkins-bot: Add COPYING [extensions/PoolCounter] - 10https://gerrit.wikimedia.org/r/116253 (owner: 10Reedy) [15:08:48] (03CR) 10Addshore: [C: 032] Add COPYING [extensions/UserDailyContribs] - 10https://gerrit.wikimedia.org/r/116256 (owner: 10Reedy) [15:08:51] (03Merged) 10jenkins-bot: Add COPYING [extensions/UserDailyContribs] - 10https://gerrit.wikimedia.org/r/116256 (owner: 10Reedy) [15:09:26] (03CR) 10Addshore: [C: 032] Add COPYING [extensions/Collection] - 10https://gerrit.wikimedia.org/r/116238 (owner: 10Reedy) [15:09:35] (03Merged) 10jenkins-bot: Add COPYING [extensions/Collection] - 10https://gerrit.wikimedia.org/r/116238 (owner: 10Reedy) [15:09:41] (03CR) 10Addshore: [C: 032] Add COPYING [extensions/GlobalUsage] - 10https://gerrit.wikimedia.org/r/116239 (owner: 10Reedy) [15:09:43] (03Merged) 10jenkins-bot: Add COPYING [extensions/GlobalUsage] - 10https://gerrit.wikimedia.org/r/116239 (owner: 10Reedy) [15:10:02] (03CR) 10Addshore: [C: 032] Add COPYING [extensions/CharInsert] - 10https://gerrit.wikimedia.org/r/116242 (owner: 10Reedy) [15:10:05] (03Merged) 10jenkins-bot: Add COPYING [extensions/CharInsert] - 10https://gerrit.wikimedia.org/r/116242 (owner: 10Reedy) [15:10:17] (03CR) 10Manybubbles: "Jenkins looks ok." [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/118078 (owner: 10Manybubbles) [15:10:22] (03CR) 10Addshore: [C: 032] Add COPYING [extensions/TorBlock] - 10https://gerrit.wikimedia.org/r/116245 (owner: 10Reedy) [15:10:24] (03Merged) 10jenkins-bot: Add COPYING [extensions/TorBlock] - 10https://gerrit.wikimedia.org/r/116245 (owner: 10Reedy) [15:10:30] (03CR) 10MarkAHershberger: [C: 032] 1.22.4 release notes and version update [core] (REL1_22) - 10https://gerrit.wikimedia.org/r/118084 (owner: 10MarkAHershberger) [15:10:40] (03CR) 10Addshore: [C: 032] Add COPYING [extensions/CodeEditor] - 10https://gerrit.wikimedia.org/r/116248 (owner: 10Reedy) [15:10:57] (03CR) 10Addshore: [C: 032] Add COPYING [extensions/Disambiguator] - 10https://gerrit.wikimedia.org/r/116249 (owner: 10Reedy) [15:11:19] (03Merged) 10jenkins-bot: Add COPYING [extensions/CodeEditor] - 10https://gerrit.wikimedia.org/r/116248 (owner: 10Reedy) [15:11:21] (03Merged) 10jenkins-bot: Add COPYING [extensions/Disambiguator] - 10https://gerrit.wikimedia.org/r/116249 (owner: 10Reedy) [15:12:05] (03CR) 10MarkAHershberger: [C: 032] 1.21.7 release notes and version update [core] (REL1_21) - 10https://gerrit.wikimedia.org/r/118082 (owner: 10MarkAHershberger) [15:12:33] (03CR) 10Addshore: "O_o" [extensions/NoUnwrap] - 10https://gerrit.wikimedia.org/r/116027 (owner: 10Reedy) [15:14:00] (03PS1) 10Hashar: Experiment multiple git repos for Chad [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/118086 [15:14:46] (03Merged) 10jenkins-bot: 1.22.4 release notes and version update [core] (REL1_22) - 10https://gerrit.wikimedia.org/r/118084 (owner: 10MarkAHershberger) [15:16:45] (03Merged) 10jenkins-bot: 1.21.7 release notes and version update [core] (REL1_21) - 10https://gerrit.wikimedia.org/r/118082 (owner: 10MarkAHershberger) [15:20:00] (03CR) 10Addshore: [C: 04-1] Implementing HTML Email (035 comments) [core] - 10https://gerrit.wikimedia.org/r/115399 (owner: 1001tonythomas) [15:20:31] (03PS2) 10Hashar: Experiment multiple git repos for Chad [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/118086 [15:20:42] (03PS3) 10Jackmcbarn: Categorize pages containing blacklisted links [extensions/SpamBlacklist] - 10https://gerrit.wikimedia.org/r/117231 [15:22:27] (03PS19) 10Physikerwelt: Coverage tests for the Math extension [extensions/Math] - 10https://gerrit.wikimedia.org/r/112353 [15:22:46] (03PS3) 10Hashar: Experiment multiple git repos for Chad [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/118086 [15:23:05] (03CR) 10Physikerwelt: Coverage tests for the Math extension (0311 comments) [extensions/Math] - 10https://gerrit.wikimedia.org/r/112353 (owner: 10Physikerwelt) [15:23:10] jackmcbarn: Heh, I typoed on 117231 PS2. "!$links" obviously won't work, should be "$links". [15:23:30] (03PS20) 10Physikerwelt: Coverage tests for the Math extension [extensions/Math] - 10https://gerrit.wikimedia.org/r/112353 [15:23:49] (03PS4) 10Jackmcbarn: Categorize pages containing blacklisted links [extensions/SpamBlacklist] - 10https://gerrit.wikimedia.org/r/117231 [15:24:06] anomie: lol. that's what i get for not testing before git-review [15:24:12] (03CR) 10Hcohl: [C: 031] Coverage tests for the Math extension [extensions/Math] - 10https://gerrit.wikimedia.org/r/112353 (owner: 10Physikerwelt) [15:24:37] (03CR) 10Addshore: [C: 032] Fix undefined variable [extensions/BookManagerv2] - 10https://gerrit.wikimedia.org/r/112152 (owner: 10Legoktm) [15:24:42] (03Merged) 10jenkins-bot: Fix undefined variable [extensions/BookManagerv2] - 10https://gerrit.wikimedia.org/r/112152 (owner: 10Legoktm) [15:25:44] (03PS4) 10Addshore: Fixed bug where variables referenced where not reachable (out of scope) [extensions/MassEditRegex] - 10https://gerrit.wikimedia.org/r/97902 (owner: 10Netbrain) [15:28:11] (03CR) 10Addshore: [C: 032] Modify Drafts::display to return HTML instead of a count [extensions/Drafts] - 10https://gerrit.wikimedia.org/r/88894 (owner: 10Legoktm) [15:28:17] (03PS5) 10Addshore: Make [[Special:Drafts/title]] show drafts for that title [extensions/Drafts] - 10https://gerrit.wikimedia.org/r/88895 (owner: 10Legoktm) [15:28:19] (03Merged) 10jenkins-bot: Modify Drafts::display to return HTML instead of a count [extensions/Drafts] - 10https://gerrit.wikimedia.org/r/88894 (owner: 10Legoktm) [15:29:16] (03CR) 10Addshore: Make [[Special:Drafts/title]] show drafts for that title (031 comment) [extensions/Drafts] - 10https://gerrit.wikimedia.org/r/88895 (owner: 10Legoktm) [15:31:53] (03CR) 10Addshore: [C: 031] "not tested" [extensions/Drafts] - 10https://gerrit.wikimedia.org/r/88895 (owner: 10Legoktm) [15:33:23] (03CR) 10Addshore: [C: 04-1] OpenBadges Special page (038 comments) [extensions/OpenBadges] - 10https://gerrit.wikimedia.org/r/112350 (owner: 10Hchuying) [15:33:45] (03CR) 10Anomie: [C: 031] "It looks like the Flow people agree that this doesn't need to wait on them, so absent any other objections I'll probably +2 this sometime " [extensions/SpamBlacklist] - 10https://gerrit.wikimedia.org/r/117231 (owner: 10Jackmcbarn) [15:34:41] (03PS21) 10Physikerwelt: Coverage tests for the Math extension [extensions/Math] - 10https://gerrit.wikimedia.org/r/112353 [15:35:09] (03PS22) 10Physikerwelt: Coverage tests for the Math extension [extensions/Math] - 10https://gerrit.wikimedia.org/r/112353 [15:35:47] (03PS4) 10Hashar: Experiment multiple git repos for Chad [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/118086 [15:36:08] (03CR) 10Addshore: [C: 032] Add COPYING [extensions/ConfirmEdit] - 10https://gerrit.wikimedia.org/r/112173 (owner: 10Reedy) [15:36:12] (03Merged) 10jenkins-bot: Add COPYING [extensions/ConfirmEdit] - 10https://gerrit.wikimedia.org/r/112173 (owner: 10Reedy) [15:36:40] (03CR) 10Addshore: [C: 032] Change spaces to tabs [extensions/OAuth] - 10https://gerrit.wikimedia.org/r/112055 (owner: 10CSteipp) [15:36:47] (03Merged) 10jenkins-bot: Change spaces to tabs [extensions/OAuth] - 10https://gerrit.wikimedia.org/r/112055 (owner: 10CSteipp) [15:41:39] (03CR) 10Hcohl: [C: 031] Coverage tests for the Math extension [extensions/Math] - 10https://gerrit.wikimedia.org/r/112353 (owner: 10Physikerwelt) [15:43:27] <^d> addshore: I'll get to it some point today :) [15:43:37] awesome ^d :) [15:46:21] (03CR) 10Addshore: [C: 032] Coverage tests for the Math extension [extensions/Math] - 10https://gerrit.wikimedia.org/r/112353 (owner: 10Physikerwelt) [15:46:32] (03PS3) 10Addshore: remove armourMath and wgContLang (bug 60799) [extensions/Math] (math2_0_0) - 10https://gerrit.wikimedia.org/r/112324 (owner: 10Physikerwelt) [15:47:17] (03Merged) 10jenkins-bot: Coverage tests for the Math extension [extensions/Math] - 10https://gerrit.wikimedia.org/r/112353 (owner: 10Physikerwelt) [15:47:57] (03PS1) 10Phuedx: Make the modal expand to fit its contents [extensions/GettingStarted] - 10https://gerrit.wikimedia.org/r/118088 [15:52:21] (03PS5) 10Hashar: Experiment multiple git repos for Chad [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/118086 [15:53:16] (03PS1) 10Addshore: Split up some long lines in tests [extensions/Math] - 10https://gerrit.wikimedia.org/r/118089 [15:54:22] (03PS4) 10Matthias Mullie: Non-hacky way to feed title to Parsoid [extensions/Flow] - 10https://gerrit.wikimedia.org/r/115112 [15:55:00] (03CR) 10jenkins-bot: [V: 04-1] Non-hacky way to feed title to Parsoid [extensions/Flow] - 10https://gerrit.wikimedia.org/r/115112 (owner: 10Matthias Mullie) [15:55:21] (03PS4) 10Matthias Mullie: (bug 61107) Contributions from Flow appear in every namespace [extensions/Flow] - 10https://gerrit.wikimedia.org/r/115908 [15:55:48] (03CR) 10jenkins-bot: [V: 04-1] (bug 61107) Contributions from Flow appear in every namespace [extensions/Flow] - 10https://gerrit.wikimedia.org/r/115908 (owner: 10Matthias Mullie) [15:56:11] (03CR) 10EBernhardson: "While we could, its best to send everything through sean. Typically file a new tracking bug in bugzilla and email him." [extensions/Flow] - 10https://gerrit.wikimedia.org/r/116226 (owner: 10Bsitu) [15:57:53] (03CR) 10Hcohl: [C: 031] Split up some long lines in tests [extensions/Math] - 10https://gerrit.wikimedia.org/r/118089 (owner: 10Addshore) [16:01:55] qgil, I sent my project idea to wikitech emailing list a week ago and receive some feedback [16:02:48] zaynetro, ah, ok, which is your project? [16:02:48] (03PS5) 10Matthias Mullie: Non-hacky way to feed title to Parsoid [extensions/Flow] - 10https://gerrit.wikimedia.org/r/115112 [16:02:53] (03CR) 10jenkins-bot: [V: 04-1] Non-hacky way to feed title to Parsoid [extensions/Flow] - 10https://gerrit.wikimedia.org/r/115112 (owner: 10Matthias Mullie) [16:03:01] (sorry, I have bad memory with names, nicks, email addresses...) :) [16:03:32] qgil, https://www.mediawiki.org/wiki/User:Zaynetro/GSoC_2014_proposal [16:03:34] (03PS6) 10Matthias Mullie: Non-hacky way to feed title to Parsoid [extensions/Flow] - 10https://gerrit.wikimedia.org/r/115112 [16:03:49] (03CR) 10jenkins-bot: [V: 04-1] Non-hacky way to feed title to Parsoid [extensions/Flow] - 10https://gerrit.wikimedia.org/r/115112 (owner: 10Matthias Mullie) [16:04:15] zaynetro, ah, yes, I remember. [16:04:46] zaynetro, let me check the replies. [16:07:48] zaynetro, so... in practice, if you don't get mentoring help from someone like bawolff, then this will mean that the feasibility of your project within this GSoC round is questioned [16:08:13] (03CR) 10Swalling: [C: 031] "Tested and working in Firefox and Chrome with long language strings including Russian, German, Spanish, Ukrainian, and French." [extensions/GettingStarted] - 10https://gerrit.wikimedia.org/r/118088 (owner: 10Phuedx) [16:08:20] zaynetro, the reply from Nikerabbit is important, because he is one of the i18n experts, and he knows very well what is he talking about. [16:08:53] If Nikerabbit says that your project is more complex than you think, he might have a point. :) [16:09:13] qgil, let me check the names [16:09:34] zaynetro, also, the success of your project depends ultimately on the deployment in Wikimedia servers, interacting between no less than English Wikipedia and English Wiktionary... [16:10:04] zaynetro, this makes things more comploicated, as explained at https://www.mediawiki.org/wiki/Google_Summer_of_Code_2014#Your_project [16:10:53] TL;DR: wasted time [16:11:01] zaynetro, if you are interested in i18n related projects, and if you don' t find a mentor in 48h, I recommend you to look at https://www.mediawiki.org/wiki/Google_Summer_of_Code_2014#Internationalization_and_localization , where there is more than enough to choose from [16:11:42] Nemo_bis, is a good reference here as well. :) [16:12:56] zaynetro, Nemo_bis I don' t know, maybe the idea could be explored as a hackish gadget not requiring any server deployment, but that would be more like a personal project, not a GSoC project [16:13:42] qgil, thank you for all this data. I am going to contact Nikerabbit right now. [16:14:30] and after will explore Internationalization and localization content [16:15:24] contact for what? you have a proposal page, its purpose is holding discussion (on the talk) [16:15:42] I assume, contact to make Nikerabbit aware of the proposal. [16:16:18] someone pinging me [16:16:24] he already got feedback, he is aware [16:17:07] if I remember correctly, this is the proposal I replied on wikitech? [16:17:18] https://www.mediawiki.org/wiki/User_talk:Zaynetro/GSoC_2014_proposal [16:17:19] Nikerabbit, I wanted to make sure if my GSoC project is in the scope of this program [16:17:44] in scope != likely to be successful [16:18:38] (03PS1) 10Chad: Job for building hhvm daily [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/118091 [16:18:43] (03CR) 10jenkins-bot: [V: 04-1] Job for building hhvm daily [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/118091 (owner: 10Chad) [16:18:47] (03CR) 10Aaron Schulz: Pass correct parameter to stat() in checkImages.php (031 comment) [core] - 10https://gerrit.wikimedia.org/r/117027 (owner: 10AalekhN) [16:18:48] sorry, I am still learning to use English properly [16:19:06] zaynetro: your English is far better than some English we see! [16:19:34] sumanah, I am trying my best [16:19:42] It shows. :) [16:19:45] (in a good way) [16:20:06] I don't know about scope, some of the criteria are in https://www.mediawiki.org/wiki/Google_Summer_of_Code_2014#Your_project [16:20:48] (03PS2) 10Chad: Job for building hhvm daily [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/118091 [16:21:15] OK, now the better way will be to contact the possible mentors? [16:21:22] there is a risk with deployment to wmf, although it could be useful just for other mediawikis as well [16:21:48] I'm not aware of anyone willing to mentor such a project but I'm eager to be proven wrong :) [16:21:52] there are some concerns about the implementation, which can be worked out [16:22:10] I made three proposals for which I think it would be possible to find mentors [16:22:26] and for mentoring, I can only mentor one project and I have couple in my sight already [16:23:05] If you plan an extension, you'll need to work against the hostily and hopelessness of Wiktionary's community, which has had very very very bad experiences with extension deployment in the past decade [16:23:19] * Nemo_bis doesn't see any possible ally in this endeavour [16:24:34] zaynetro, let me tell you: take very seriously whatever Nikerabbit and Nemo_bis have to tell you. :) [16:24:55] zaynetro, their answers might not sound good for you now, but they can save you a lot of time and work [16:25:04] I'd suggest talking to Rahul, who worked with https://www.mediawiki.org/wiki/Extension:PronunciationRecording [16:25:28] Also superm401 may have some valuable experience interfacing with enwikt, especially given he mentored the above [16:25:35] (03CR) 10Hashar: Job for building hhvm daily (032 comments) [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/118091 (owner: 10Chad) [16:25:39] Not that he'll mentor another wikt project, but still. :P [16:25:41] qgil, yep, I appreciate your help, since every experience is helpful [16:26:01] rdwrer: frankly, their experience is not nearly 1/10 of what I have with Wiktionary [16:26:13] Nemo_bis: Yeah, I don't know [16:26:15] I tried to interest some Wiktionary folks I know very well but I failed [16:26:26] interest in this proposal I mean [16:26:31] As you were stricken....to the ground? [16:27:22] ( http://www.azlyrics.com/lyrics/tenaciousd/themetal.html ) [16:28:26] (03PS3) 10Chad: Job for building hhvm daily [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/118091 [16:30:27] (03CR) 10Liangent: "@Siebrand: So what's the reason that zh messages got exported in I1cdc5f6df47189ab35d141ed89a4c84cfac7fe18 ?" [core] - 10https://gerrit.wikimedia.org/r/118067 (owner: 10Liangent) [16:31:11] (03PS1) 10IAlex: Don't use isset() to check whether an existing variable is null [core] - 10https://gerrit.wikimedia.org/r/118092 [16:32:23] (03PS4) 10Chad: Job for building hhvm daily [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/118091 [16:41:44] (03PS1) 10EBernhardson: Dependencies for Thanks [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/118093 [16:48:27] (03CR) 10Nemo bis: "Thanks nevertheless for your second patch and a belated welcome to gerrit. :)" [extensions/Scribunto] - 10https://gerrit.wikimedia.org/r/117663 (owner: 10Ocean behind ears) [16:50:07] (03CR) 10Hashar: [C: 031] "You might have needed the Flow dependencies as well, but since you told me their are optional this is good :-]" [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/118093 (owner: 10EBernhardson) [16:56:26] (03CR) 10Ragesoss: [C: 031] ":)" [extensions/EducationProgram] - 10https://gerrit.wikimedia.org/r/113145 (owner: 10J-squared) [16:56:50] anomie: is there a way to see the output of mw.log and such when it's called from a #invoke and not the lua console? [16:57:20] jackmcbarn: https://gerrit.wikimedia.org/r/#/c/55602/ [16:57:43] (03CR) 10Siebrand: "@liangent I wasn't around, but I assume a mass page move or something similar." [core] - 10https://gerrit.wikimedia.org/r/118067 (owner: 10Liangent) [16:58:08] anomie: sigh. any idea why nobody's reviewing that? [16:58:38] probably for the same reason nobody's reviewing about 1200 other gerrit changes :) [16:58:59] jackmcbarn: Tim is busy, and no one else is added as a reviewer. I should probably ping some more people at some point. After rebasing it. [17:02:13] (03CR) 10Manybubbles: [C: 032] Fix fatal, $settingsObject got lost in refactoring [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/118081 (owner: 10Chad) [17:02:26] (03Merged) 10jenkins-bot: Fix fatal, $settingsObject got lost in refactoring [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/118081 (owner: 10Chad) [17:02:53] (03PS1) 10Jackmcbarn: Improve invalid title error message [extensions/Scribunto] - 10https://gerrit.wikimedia.org/r/118094 [17:06:24] (03PS2) 10Jackmcbarn: Improve invalid title error message [extensions/Scribunto] - 10https://gerrit.wikimedia.org/r/118094 [17:08:43] (03PS5) 10Chad: Job for building hhvm daily [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/118091 [17:16:37] (03CR) 10EBernhardson: [C: 032] "Pushed to jenkins and tested with JJB, looks good." [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/118093 (owner: 10EBernhardson) [17:16:42] (03PS6) 10Chad: Job for building hhvm daily [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/118091 [17:16:55] (03Merged) 10jenkins-bot: Dependencies for Thanks [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/118093 (owner: 10EBernhardson) [17:16:58] (03CR) 10jenkins-bot: [V: 04-1] Job for building hhvm daily [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/118091 (owner: 10Chad) [17:19:06] if someone passes a string like "1 + 2 * 3" into lua, is there any way to evaluate it other than frame:callParserFunction('#expr', blah)? [17:24:44] (03PS1) 10Jlloyd: Add notifications for when a student is assigned an article and that article's talk page has been edited [extensions/EducationProgram] - 10https://gerrit.wikimedia.org/r/118101 [17:27:19] (03CR) 10Siebrand: "Thanks." [extensions/OAuth] - 10https://gerrit.wikimedia.org/r/112055 (owner: 10CSteipp) [17:28:08] (03CR) 10Siebrand: [C: 031] "i18n/L10n reviewed." [extensions/SpamBlacklist] - 10https://gerrit.wikimedia.org/r/117231 (owner: 10Jackmcbarn) [17:28:32] (03CR) 10Siebrand: [C: 031] "i18n/L10n reviewed." [extensions/Drafts] - 10https://gerrit.wikimedia.org/r/88895 (owner: 10Legoktm) [17:29:34] (03CR) 10Siebrand: [C: 032] Add COPYING [extensions/OpenStackManager] - 10https://gerrit.wikimedia.org/r/112183 (owner: 10Reedy) [17:29:37] (03Merged) 10jenkins-bot: Add COPYING [extensions/OpenStackManager] - 10https://gerrit.wikimedia.org/r/112183 (owner: 10Reedy) [17:29:43] (03CR) 10Siebrand: [C: 032] Add COPYING [extensions/LdapAuthentication] - 10https://gerrit.wikimedia.org/r/112182 (owner: 10Reedy) [17:29:45] (03Merged) 10jenkins-bot: Add COPYING [extensions/LdapAuthentication] - 10https://gerrit.wikimedia.org/r/112182 (owner: 10Reedy) [17:29:50] (03CR) 10Siebrand: [C: 032] Add COPYING [extensions/Oversight] - 10https://gerrit.wikimedia.org/r/112180 (owner: 10Reedy) [17:30:04] (03PS2) 10Siebrand: Add COPYING [extensions/SecurePoll] - 10https://gerrit.wikimedia.org/r/112178 (owner: 10Reedy) [17:30:10] (03CR) 10Siebrand: [C: 032] Add COPYING [extensions/SecurePoll] - 10https://gerrit.wikimedia.org/r/112178 (owner: 10Reedy) [17:30:12] (03Merged) 10jenkins-bot: Add COPYING [extensions/SecurePoll] - 10https://gerrit.wikimedia.org/r/112178 (owner: 10Reedy) [17:30:23] (03CR) 10Siebrand: [C: 032] Add COPYING [extensions/OpenSearchXml] - 10https://gerrit.wikimedia.org/r/112177 (owner: 10Reedy) [17:30:26] (03Merged) 10jenkins-bot: Add COPYING [extensions/OpenSearchXml] - 10https://gerrit.wikimedia.org/r/112177 (owner: 10Reedy) [17:30:31] (03CR) 10Siebrand: [C: 032 V: 032] Add COPYING [extensions/AccountAudit] - 10https://gerrit.wikimedia.org/r/112176 (owner: 10Reedy) [17:30:44] (03CR) 10Siebrand: [C: 032] Add COPYING [extensions/SiteMatrix] - 10https://gerrit.wikimedia.org/r/112175 (owner: 10Reedy) [17:30:46] (03Merged) 10jenkins-bot: Add COPYING [extensions/SiteMatrix] - 10https://gerrit.wikimedia.org/r/112175 (owner: 10Reedy) [17:30:52] (03CR) 10Siebrand: [C: 032] Add COPYING [extensions/ExtensionDistributor] - 10https://gerrit.wikimedia.org/r/112174 (owner: 10Reedy) [17:30:54] (03Merged) 10jenkins-bot: Add COPYING [extensions/ExtensionDistributor] - 10https://gerrit.wikimedia.org/r/112174 (owner: 10Reedy) [17:31:00] (03CR) 10Siebrand: [C: 032 V: 032] Add COPYING [extensions/ConfirmAccount] - 10https://gerrit.wikimedia.org/r/112172 (owner: 10Reedy) [17:31:39] (03CR) 10Siebrand: [C: 032] Add COPYING [extensions/OAI] - 10https://gerrit.wikimedia.org/r/116240 (owner: 10Reedy) [17:31:42] (03Merged) 10jenkins-bot: Add COPYING [extensions/OAI] - 10https://gerrit.wikimedia.org/r/116240 (owner: 10Reedy) [17:31:46] (03CR) 10Siebrand: [C: 032] Add COPYING [extensions/TrustedXFF] - 10https://gerrit.wikimedia.org/r/116255 (owner: 10Reedy) [17:31:48] (03Merged) 10jenkins-bot: Add COPYING [extensions/TrustedXFF] - 10https://gerrit.wikimedia.org/r/116255 (owner: 10Reedy) [17:32:22] (03CR) 10Siebrand: [C: 04-1] "To indicate open question by Brad." [extensions/Scribunto] - 10https://gerrit.wikimedia.org/r/107786 (owner: 10Reedy) [17:37:33] (03CR) 10Siebrand: [V: 032] Add COPYING [extensions/Oversight] - 10https://gerrit.wikimedia.org/r/112180 (owner: 10Reedy) [17:37:56] (03CR) 10Siebrand: [V: 032] Add .gitreview and .gitignore [extensions/NoUnwrap] - 10https://gerrit.wikimedia.org/r/116027 (owner: 10Reedy) [17:39:54] (03PS2) 10Siebrand: Add notification when a student's assigned article's talk page has been edited [extensions/EducationProgram] - 10https://gerrit.wikimedia.org/r/118101 (owner: 10Jlloyd) [17:41:33] (03CR) 10Siebrand: [C: 04-1] "i18n/L10n reviewed." (032 comments) [extensions/EducationProgram] - 10https://gerrit.wikimedia.org/r/118101 (owner: 10Jlloyd) [17:55:51] (03PS1) 10Kaldari: Adding some FOSS fonts to the top of the stack per discussion [extensions/VectorBeta] - 10https://gerrit.wikimedia.org/r/118106 [17:56:33] (03CR) 10AndyRussG: [C: 04-1] "So close!!! I was so just about to click "+2" and merge. The only blocker is the message before the link in the e-mail notification. See c" (035 comments) [extensions/EducationProgram] - 10https://gerrit.wikimedia.org/r/113145 (owner: 10J-squared) [17:56:48] (03CR) 10Siebrand: [C: 031] "i18n/L10n reviewed." [core] - 10https://gerrit.wikimedia.org/r/115426 (owner: 10Umherirrender) [17:59:19] jackmcbarn: (you should have pinged me) Not currently. If you decide to try to implement such a thing, the trick is to avoid allowing arbitrary Lua code as template parameters while still being useful. I'd say just stick with frame:callParserFunction. [18:00:15] (i still fail to see how that's bad) [18:00:29] have you seen Module:LuaCall? [18:01:21] (03CR) 10Anomie: [C: 032] "May as well." [extensions/Scribunto] - 10https://gerrit.wikimedia.org/r/118094 (owner: 10Jackmcbarn) [18:01:32] (03CR) 10Adi.iiita: "Thanks for mentioning it. Would be careful about it next time." [extensions/LiquidThreads] - 10https://gerrit.wikimedia.org/r/118049 (owner: 10Adi.iiita) [18:02:51] (03Merged) 10jenkins-bot: Improve invalid title error message [extensions/Scribunto] - 10https://gerrit.wikimedia.org/r/118094 (owner: 10Jackmcbarn) [18:04:15] !seen krinkle [18:04:15] Did you mean @seen krinkle? [18:04:18] @seen krinkle [18:04:18] ebernhardson: krinkle is in here, right now [18:04:39] (03PS11) 10Bsitu: [Schema Change]Add new column rev_type_id to flow_revision [extensions/Flow] - 10https://gerrit.wikimedia.org/r/116861 [18:04:57] (03CR) 10jenkins-bot: [V: 04-1] [Schema Change]Add new column rev_type_id to flow_revision [extensions/Flow] - 10https://gerrit.wikimedia.org/r/116861 (owner: 10Bsitu) [18:05:07] WTF... [18:05:32] jackmcbarn: Because we don't want people embedding Lua in articles or templates, we want them to write Modules. My reaction to that module is "Ugh, why?". [18:05:41] (03PS3) 10Rillke: Add cc-IGO (international governed organization) [extensions/WikimediaMessages] - 10https://gerrit.wikimedia.org/r/115597 [18:06:18] i've noticed that whenever we try not to give template authors some ability, they always seem to come up with an inefficient way of getting it themselves anyway [18:06:20] why do we bother? [18:06:37] Krinkle: any good ways to share variables between javascript files without just loading up mw.flow.* ? [18:07:09] (03PS12) 10Bsitu: [Schema Change]Add column rev_type_id to table flow_revision [extensions/Flow] - 10https://gerrit.wikimedia.org/r/116861 [18:07:09] by loading i mean just setting variables in there [18:07:31] ebernhardson: What kind of variables? [18:07:36] jackmcbarn: The difference is that in this case there's a *better* way to do it: just write a module. [18:07:50] (03PS14) 10Wctaiwan: Add "Thanks" for comments on Flow boards [extensions/Thanks] - 10https://gerrit.wikimedia.org/r/115557 [18:08:10] ebernhardson: That sounds like a flawed program design to me... [18:08:28] Krinkle: sec, its actually shahyar's question [18:08:37] -.- [18:08:37] he should be here any moment ... [18:08:49] Krinkle: I was looking to split up multiple JS files, but combine them at compile time [18:09:12] anomie: also, i noticed the AfC pages do pseudo-variables by transcluding and grepping themselves [18:09:16] "compile time"? [18:09:32] is that something we need to worry about? [18:09:54] basically, HugeClass has sub classes, eg. HugeClass.SmallerClass. these also access local, private variables to be shared between them. [18:10:38] shahyar: Sounds like you're running into the fallacy of private variables in JS [18:10:41] however, right now, they are all inside the same anonymous function in the same file. I was looking to split up those separate classes/objects into their own files, but include them within another JS when they get processed for output to the client. [18:10:50] jackmcbarn: There's nothing we can do to prevent it without removing the ability to fetch a page's content at all, so no. It's still "ugh" though. [18:11:36] rdwrer: just because ecmascript is a weird language doesn't mean we can't use it in an even weirder way to accomplish what we want. [18:11:40] True [18:11:50] shahyar: Inherited private variables aren't possible AFAIK [18:11:57] (03PS10) 10Bsitu: Update column flow_revision.rev_type_id [extensions/Flow] - 10https://gerrit.wikimedia.org/r/116874 [18:12:06] shahyar: You can inherit a public variable and lie by marking it as public, though [18:12:09] (03CR) 10jenkins-bot: [V: 04-1] Update column flow_revision.rev_type_id [extensions/Flow] - 10https://gerrit.wikimedia.org/r/116874 (owner: 10Bsitu) [18:12:12] Assuming you're documenting your code [18:12:22] We do this in MMV to grand effect [18:12:28] (03CR) 10Addshore: [C: 04-1] Add "Thanks" for comments on Flow boards (033 comments) [extensions/Thanks] - 10https://gerrit.wikimedia.org/r/115557 (owner: 10Wctaiwan) [18:13:05] (03PS11) 10Bsitu: Update column data: flow_revision.rev_type_id [extensions/Flow] - 10https://gerrit.wikimedia.org/r/116874 [18:13:14] I'm trying to avoid making more public variables. MW has enough stuff in the global scope already. what I did at a previous place was write a preprocessor which includes other files (à la LESS) where written. [18:14:00] it was nice, in the sense that code becomes far more readable. so, instead of files that are hundreds or thousands of lines long, you end up with multiple files with a concise purpose. [18:14:05] shahyar: Not the global scope, the class scope [18:14:15] shahyar: BigClass.prototype.whateverVariable = 'blah'; [18:14:19] shahyar: You can let resourceloader concat files, that's fine. It'll fail in debug mode, but don't worry about that, because debug mode is not how you want to debug anyway. [18:14:50] rdwrer: inheriting private variables is perfectly possible but you need to not use the classical inheritance model and instead embrace closures and object prototypal inheritance. [18:15:04] Krinkle: how can I make resource loader concat JS files, all of them within a closure? [18:15:18] Krinkle: Do you have an example handy? (and why do I feel we've had this conversation before?) [18:15:24] shahyar: 'modules' => scripts => array( 'foo.js', 'bar'.js' ) [18:15:27] (03PS1) 10Anomie: HTMLForm: Support 'url' type [core] - 10https://gerrit.wikimedia.org/r/118109 [18:15:29] (03PS1) 10Anomie: HTMLForm: Add hide-if [core] - 10https://gerrit.wikimedia.org/r/118110 [18:15:31] (03PS1) 10Anomie: HTMLForm: Add date type [core] - 10https://gerrit.wikimedia.org/r/118111 [18:15:32] foo/bar are concatenated without any changes [18:15:33] (03PS1) 10Anomie: HTMLForm: Add daterange type [core] - 10https://gerrit.wikimedia.org/r/118112 [18:15:35] (03PS1) 10Anomie: HTMLForm: Add "cloner" type [core] - 10https://gerrit.wikimedia.org/r/118113 [18:15:37] (03PS1) 10Anomie: Release notes for recent HTMLForm changes [core] - 10https://gerrit.wikimedia.org/r/118114 [18:15:39] the result is the module's script source that will be loaded [18:16:10] However they should not depend on sharing scope. as taht results in invalid files [18:16:14] Krinkle: so, I'd need a file with an opening anonymous function, my JS files, and then another file which closes that anonymous function and calls it? [18:16:18] e.g. each file will fail the lint because of undefined variables [18:16:19] no [18:16:51] If you go that route you'll need to compile separately and become a library like jquery.js or oojs.js and then you load the distribution (final file) in ResourceLoader/MediaWiki only. [18:17:15] right, but I'm assuming as-is, there is nothing that can do that for me in MW? [18:17:41] No, and I think being able to do that is sufficiently minor that it shouldn't be leading how you structure the module. [18:18:00] It's a nice model to have, but not an option right now. [18:18:20] Also note that such private variables would be static only [18:18:25] not instance bound [18:18:41] so you should probably use the "javascript way" instead which will allow you to do that. [18:18:54] Thanks! Everything is fine right now, just thinking long-term about how separating this code could be done once it gets too big. [18:19:11] Pasing around by principle of least authority (instead of principle of "I'm in this concatenated scope, I can access anything and everything") [18:19:26] e.g. local object literal, pass around privately from one constructor to the next. [18:19:46] privileged method would be define inside the constructor not on the prototype. [18:19:55] methods* defined* [18:20:18] given our architecture, looks like I'll probably just use getters and setters on public classes. [18:20:32] not sure yet, but not important at this juncture. [18:21:14] (03PS25) 10CSteipp: Added password hashing API [core] - 10https://gerrit.wikimedia.org/r/77645 (owner: 10Parent5446) [18:21:18] hi hexmode: You there? [18:21:24] function Foo(options, priv = {}) { this.hasAccess = function () { return priv.value * 2; }; } Foo.prototype.noAccess = function () {} [18:21:51] foo Bar() { options, priv = {}} ) Foo.call(this, { x: priv.x }); // pass only part on to Foo } [18:21:53] etc. [18:21:53] zeek_: yep [18:22:09] This would be class Foo and class Bar extending Foo [18:23:00] hexmode: I was going through this bug https://bugzilla.wikimedia.org/show_bug.cgi?id=28746 .... and I am not sure of what its trying to say.... it says that the subject is missing... but I think it appears fine when i checked in my wiki.... https://mediacru.sh/argqlN6dfDqr [18:23:41] (03PS15) 10Wctaiwan: Add "Thanks" for comments on Flow boards [extensions/Thanks] - 10https://gerrit.wikimedia.org/r/115557 [18:24:30] (03CR) 10Addshore: [C: 04-1] "still need to address the comments in PS14" [extensions/Thanks] - 10https://gerrit.wikimedia.org/r/115557 (owner: 10Wctaiwan) [18:24:33] Krinkle: yeah, I think what I'll end up doing is somewhat similar. not to extend classes, but rather to assign new methods to private classes/objects from separate files. [18:25:07] shahyar: there's https://www.mediawiki.org/wiki/ResourceLoader/Default_modules#mediaWiki.Map , could have mw.flow.stuff.get( 'someVar' ) [18:25:54] spagewmf: would be weird to use that for complete objects [18:26:03] (03PS2) 10Addshore: optimized generate variable $storagename and small fixes [extensions/GraphViz] - 10https://gerrit.wikimedia.org/r/32195 (owner: 10Pastakhov) [18:26:28] zeek_: update the bug with your screenshot and suggest it works for you. [18:26:51] roger that [18:27:15] (03CR) 10Addshore: [C: 04-1] optimized generate variable $storagename and small fixes (033 comments) [extensions/GraphViz] - 10https://gerrit.wikimedia.org/r/32195 (owner: 10Pastakhov) [18:29:44] (03CR) 10Addshore: [C: 04-1] "Needs a rebase" [extensions/LabeledSectionTransclusion] - 10https://gerrit.wikimedia.org/r/37312 (owner: 10Merlijn van Deen) [18:30:57] (03CR) 10Addshore: [C: 04-1] "needs a rebase" [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/22273 (owner: 10MarkTraceur) [18:32:03] (03CR) 10jenkins-bot: [V: 04-1] Added password hashing API [core] - 10https://gerrit.wikimedia.org/r/77645 (owner: 10Parent5446) [18:32:08] (03PS2) 10Addshore: Add test case for parsoid's extension handling [core] - 10https://gerrit.wikimedia.org/r/54805 (owner: 10MarkTraceur) [18:33:03] hexmode: Done. [18:33:03] (03CR) 10Wctaiwan: Add "Thanks" for comments on Flow boards (0319 comments) [extensions/Thanks] - 10https://gerrit.wikimedia.org/r/115557 (owner: 10Wctaiwan) [18:33:58] (03PS8) 10J-squared: Notification for when a user adds you to a course [extensions/EducationProgram] - 10https://gerrit.wikimedia.org/r/113145 [18:36:13] (03CR) 10MaxSem: [C: 032] Add COPYING [extensions/FeaturedFeeds] - 10https://gerrit.wikimedia.org/r/116250 (owner: 10Reedy) [18:36:16] (03Merged) 10jenkins-bot: Add COPYING [extensions/FeaturedFeeds] - 10https://gerrit.wikimedia.org/r/116250 (owner: 10Reedy) [18:36:46] (03PS16) 10Wctaiwan: Add "Thanks" for comments on Flow boards [extensions/Thanks] - 10https://gerrit.wikimedia.org/r/115557 [18:36:49] (03CR) 10MaxSem: [C: 032] Add COPYING [extensions/GeoData] - 10https://gerrit.wikimedia.org/r/116252 (owner: 10Reedy) [18:36:56] (03Merged) 10jenkins-bot: Add COPYING [extensions/GeoData] - 10https://gerrit.wikimedia.org/r/116252 (owner: 10Reedy) [18:37:46] (03PS2) 10MaxSem: Add JS hash to URL to allow consistent hashing via Varnish, support multiple hosts [extensions/Minifier] - 10https://gerrit.wikimedia.org/r/114933 [18:37:56] (03CR) 10Wctaiwan: Add "Thanks" for comments on Flow boards (033 comments) [extensions/Thanks] - 10https://gerrit.wikimedia.org/r/115557 (owner: 10Wctaiwan) [18:38:30] (03PS11) 10Bsitu: Update post/header revisions storage search key [extensions/Flow] - 10https://gerrit.wikimedia.org/r/117099 [18:38:45] (03CR) 10jenkins-bot: [V: 04-1] Update post/header revisions storage search key [extensions/Flow] - 10https://gerrit.wikimedia.org/r/117099 (owner: 10Bsitu) [18:39:35] SETNAME Pawan Kumar D [18:41:22] SETNAME [18:43:57] (03CR) 10Jdlrobson: Updating mediawiki.ui color variables per design team (032 comments) [core] - 10https://gerrit.wikimedia.org/r/117105 (owner: 10Kaldari) [18:44:21] Hi, I am unable to upload a patch in https://tools.wmflabs.org/gerrit-patch-uploader/ [18:44:45] Error says : [18:45:02] git apply < patch [18:45:11] error: patch failed: includes/installer/MysqlUpdater.php:249 [18:45:13] error: includes/installer/MysqlUpdater.php: patch does not apply [18:46:28] Anyone? [18:49:44] pawan_seerwani: are you sure the patch applies on top of the most recent MediaWiki? [18:49:51] (the so-called "git master") [18:52:06] MatmaRex: I am not sure. But mostly yes, on top of most recent Mediawiki. How do I confirm that? [18:52:47] pawan_seerwani: depends, have you downloaded MediaWiki via git? [18:54:22] MatmaRex: Yes, via gerrit. But due to ports blocking at my institute network, I don't use gerrit via command line, instead I use gerrit patch uploader [18:55:08] hexmode: I think for the bug https://bugzilla.wikimedia.org/show_bug.cgi?id=33394 .... It works fine too https://mediacru.sh/R6WKvLdU2-6w [18:55:21] pawan_seerwani: okay. i understand you're not submitting commits via gerrit, but anyway, have you made a commit with your changes, or are the uncommited? [18:55:34] (`git status` should tell you if you have any uncommited changes) [18:56:01] I have committed all of it in my local git repo. And I used git diff command to generate the patch file [18:56:12] and then I submit the same via gerrit patch uploader [18:56:46] regardless, you have to run `git fetch origin` to download the latest commits to MediaWiki, and then `git rebase origin/master` if you have committed the changes, or `git stash && git checkout origin/master && git stash pop` if you haven't [18:57:07] if these commands complain about merge conflicts, that means the patch can't be automatically applied [18:57:41] you can fix the conflict and submit the patch again, or just cancel everything and redo your patch manually [18:58:13] if the commands don't complain, then either gerrit-patch-uploader is weirdly picky or something went wrong while you were generating the diff [18:58:23] so just try again :) [18:59:14] so I should do 1. git fetch origin 2. git rebase origin/master 3. git stash && git checkout origin/master && git stash pop [18:59:34] pawan_seerwani: you can push to gerrit using https too. [18:59:36] and then check if any conflicts exits? [18:59:58] zeek_: and how do I do that? [19:00:39] pawan_seerwani: First lets confirm you have no issues with https... so can you push to github via https from your place? [19:01:16] zeek_: ok. How to confirm that? [19:01:30] Pardon my ignorance :| [19:01:52] Well, sign up for github and push one repository using git. Google up a little if you havn't used github earlier. [19:02:28] That is possible. I have done it before. [19:02:39] Next? [19:03:06] (03CR) 10SG: [C: 032 V: 032] New CSS class for interaction link separators [extensions/Flow] - 10https://gerrit.wikimedia.org/r/117638 (owner: 10Wctaiwan) [19:03:19] (03Merged) 10jenkins-bot: New CSS class for interaction link separators [extensions/Flow] - 10https://gerrit.wikimedia.org/r/117638 (owner: 10Wctaiwan) [19:03:49] zeek_: are you suggesting me to change my remote origin to forked mediawiki core repository? [19:04:55] pawan_seerwani: Great, then if you arw working on MW core and you have a gerrit account, then in your account settings, you have the option for HTTP password. Generate a password from there. Then use this command to push "git push https://gerrit.wikimedia.org/r/p/mediawiki/core HEAD:refs/for/master" , and follow the convention about one commit per patch as explained by MatmaRex earlier. [19:06:39] (03PS1) 10Krinkle: Update oojs to v1.0.8 [core] - 10https://gerrit.wikimedia.org/r/118126 [19:07:20] I just dint get the part of one commit per patch? [19:08:08] In simple words, all the changes you make to solve one bug should be under one commit [19:08:54] Ok, now I get it. I will try it and get back Thanks :) [19:09:31] zeek_: if the way your committing via gerrit isn't on MediaWiki.org, you should update the wiki so that you can just point people to that or so they can just find it themselves :) [19:09:50] Sure, I shall do it. :) [19:16:50] zeek_: https://bugzilla.wikimedia.org/show_bug.cgi?id=28746 -- see my last comment [19:18:34] hexmode: Can't see any comment of yours except "Priority: Unprioritized → Low" : [19:18:39] : | [19:19:45] zeek_: sorry, wrong bug https://bugzilla.wikimedia.org/33394 [19:19:54] yeah got it [19:24:22] (03CR) 10Jforrester: [C: 032] Update oojs to v1.0.8 [core] - 10https://gerrit.wikimedia.org/r/118126 (owner: 10Krinkle) [19:24:28] zeek_: I have put all changes under one commit, but what is "HEAD:refs/for/master"? [19:24:43] Don't care for it, just use the command as it is [19:24:54] Ok [19:25:53] (03PS1) 10Hashar: pywikibot-core-tox-flake8 [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/118128 [19:26:20] (03CR) 10Hashar: [C: 032] pywikibot-core-tox-flake8 [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/118128 (owner: 10Hashar) [19:26:43] (03Merged) 10jenkins-bot: pywikibot-core-tox-flake8 [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/118128 (owner: 10Hashar) [19:27:29] zeek_: fatal: Authentication failed :| [19:28:02] (03Merged) 10jenkins-bot: Update oojs to v1.0.8 [core] - 10https://gerrit.wikimedia.org/r/118126 (owner: 10Krinkle) [19:28:18] All I can say is see your password and username carefully [19:28:20] (03PS7) 10Chad: Job for building hhvm daily [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/118091 [19:28:32] (03CR) 10Chad: [C: 032] Job for building hhvm daily [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/118091 (owner: 10Chad) [19:29:03] (03PS1) 10Hashar: Trigger flake8 for pywikibot/core (non voting) [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/118129 [19:30:12] (03CR) 10Hashar: [C: 032] Trigger flake8 for pywikibot/core (non voting) [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/118129 (owner: 10Hashar) [19:30:20] (03Merged) 10jenkins-bot: Trigger flake8 for pywikibot/core (non voting) [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/118129 (owner: 10Hashar) [19:30:23] (03PS8) 10Chad: Job for building hhvm daily [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/118091 [19:30:28] (03CR) 10Chad: [C: 032] Job for building hhvm daily [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/118091 (owner: 10Chad) [19:30:59] (03Merged) 10jenkins-bot: Job for building hhvm daily [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/118091 (owner: 10Chad) [19:31:32] zeek_: It worked. but with errors [19:31:39] Unable to rewind rpc post data - try increasing http.postBuffer error: RPC failed; result=65, HTTP code = 302 fatal: The remote end hung up unexpectedly fatal: The remote end hung up unexpectedly Everything up-to-date [19:33:42] (03PS3) 10Jdlrobson: WIP: Make Vector/Winter responsive [extensions/VectorBeta] - 10https://gerrit.wikimedia.org/r/117927 [19:33:50] (03CR) 10jenkins-bot: [V: 04-1] WIP: Make Vector/Winter responsive [extensions/VectorBeta] - 10https://gerrit.wikimedia.org/r/117927 (owner: 10Jdlrobson) [19:34:09] (03CR) 10AndyRussG: "Just a typo..." (031 comment) [extensions/EducationProgram] - 10https://gerrit.wikimedia.org/r/113145 (owner: 10J-squared) [19:34:31] pawan_seerwani: I think you need help of ^d here. He is the keeper of gerrit. :) [19:34:34] (03PS1) 10Umherirrender: Adjust magic bolding in api help to only match lines inside * [core] - 10https://gerrit.wikimedia.org/r/118130 [19:36:58] pawan_seerwani: You may try out this command "git config http.postBuffer 524288000" [19:40:24] marcoil, gwicke are there URLs at hand to see the features developed by Be and Maria? [19:40:29] I'm looking at https://www.mediawiki.org/wiki/User:5xbe/OPW_Monthly_Progress_Reports#February [19:40:53] and https://www.mediawiki.org/wiki/User:Mariapacana/OPW_Progress_Report [19:41:20] I find gerrit and bugzilla URLs but can't find the links to the deployed tools [19:44:24] (03PS6) 10Pawanseerwani: Clean Timestamp Fields in mysql [core] - 10https://gerrit.wikimedia.org/r/110949 (owner: 10Gerrit Patch Uploader) [19:45:22] (03CR) 10jenkins-bot: [V: 04-1] Clean Timestamp Fields in mysql [core] - 10https://gerrit.wikimedia.org/r/110949 (owner: 10Gerrit Patch Uploader) [19:46:22] zeek_: It worked! Thanks a million. [19:46:55] no problem. :) [19:55:23] (03PS1) 10EBernhardson: Database update script should run as web user [vagrant] - 10https://gerrit.wikimedia.org/r/118133 [20:00:03] (03PS1) 10MaxSem: Suppress section edit links with action=render [core] - 10https://gerrit.wikimedia.org/r/118135 [20:01:01] (03CR) 10MaxSem: [C: 04-2] "Need to fix the cause of original revert first." [core] - 10https://gerrit.wikimedia.org/r/118135 (owner: 10MaxSem) [20:03:26] (03PS2) 10Cscott: Rename sections in parserTests.txt. [core] - 10https://gerrit.wikimedia.org/r/117613 [20:03:28] (03PS6) 10Cscott: Allow more-descriptive section names for parserTests [core] - 10https://gerrit.wikimedia.org/r/89141 (owner: 10Arlolra) [20:03:30] (03CR) 10Swalling: [C: 032] "Tested and working in Chrome and Firefox. (End result on OSX is still Georgia, Helvetica Neue.)" [extensions/VectorBeta] - 10https://gerrit.wikimedia.org/r/118106 (owner: 10Kaldari) [20:03:32] (03PS9) 10J-squared: Notification for when a user adds you to a course [extensions/EducationProgram] - 10https://gerrit.wikimedia.org/r/113145 [20:05:15] (03Merged) 10jenkins-bot: Adding some FOSS fonts to the top of the stack per discussion [extensions/VectorBeta] - 10https://gerrit.wikimedia.org/r/118106 (owner: 10Kaldari) [20:07:40] (03CR) 10Cscott: "Good to go now!" [core] - 10https://gerrit.wikimedia.org/r/89141 (owner: 10Arlolra) [20:11:27] (03PS2) 10EBernhardson: Database update script should run as web user [vagrant] - 10https://gerrit.wikimedia.org/r/118133 [20:11:29] (03PS1) 10EBernhardson: Create flow role [vagrant] - 10https://gerrit.wikimedia.org/r/118136 [20:12:32] (03PS2) 10MaxSem: Suppress section edit links with action=render [core] - 10https://gerrit.wikimedia.org/r/118135 [20:13:28] qgil, both are not really tools [20:13:31] (03CR) 10MaxSem: "PS2 fixes the problem." [core] - 10https://gerrit.wikimedia.org/r/118135 (owner: 10MaxSem) [20:14:00] (03CR) 10Umherirrender: "Looks like jenkins did not see this patch set. Needs recode-review-2 or manual merge." [core] - 10https://gerrit.wikimedia.org/r/117466 (owner: 10EBernhardson) [20:14:03] qgil, Maria reworked our logging infrastructure and Be overhauled the rt testing front-end with templating etc [20:16:20] (03CR) 10MaxSem: "Second attempt in https://gerrit.wikimedia.org/r/118135" [core] - 10https://gerrit.wikimedia.org/r/94150 (owner: 10Bartosz Dziewoński) [20:24:27] (03CR) 10Umherirrender: "So many reviewers ..." [core] - 10https://gerrit.wikimedia.org/r/106561 (owner: 10Umherirrender) [20:25:58] (03CR) 10Umherirrender: "Or not, because there is a unmerged dependency." [core] - 10https://gerrit.wikimedia.org/r/117466 (owner: 10EBernhardson) [20:27:58] (03PS3) 10Cscott: Rename sections in parserTests.txt. [core] - 10https://gerrit.wikimedia.org/r/117613 [20:28:00] (03PS7) 10Cscott: Allow more-descriptive section names for parserTests [core] - 10https://gerrit.wikimedia.org/r/89141 (owner: 10Arlolra) [20:35:10] (03CR) 10Bartosz Dziewoński: "Thanks." (031 comment) [core] - 10https://gerrit.wikimedia.org/r/118135 (owner: 10MaxSem) [20:35:32] (03CR) 10AndyRussG: [C: 032] "Great, all set!" [extensions/EducationProgram] - 10https://gerrit.wikimedia.org/r/113145 (owner: 10J-squared) [20:35:46] (03Merged) 10jenkins-bot: Notification for when a user adds you to a course [extensions/EducationProgram] - 10https://gerrit.wikimedia.org/r/113145 (owner: 10J-squared) [20:36:19] (03CR) 10Swalling: [C: 031] "Tested again after rebase on top of the other patch. Working in FF and Chrome on OSX." [extensions/GettingStarted] - 10https://gerrit.wikimedia.org/r/117874 (owner: 10Phuedx) [20:49:43] (03PS1) 10Ragesoss: Let course coordinators add online volunteers to courses [extensions/EducationProgram] - 10https://gerrit.wikimedia.org/r/118196 [20:50:36] +1 Coren :) http://lists.wikimedia.org/pipermail/wikitech-l/2014-March/075123.html [20:55:27] Is there a specific IRC for internationalization... if yes please tell me the channel [20:56:19] zeek_: #mediawiki-i18n [20:56:34] thanks. [20:56:40] (03CR) 10Ori.livneh: [C: 032] Create flow role [vagrant] - 10https://gerrit.wikimedia.org/r/118136 (owner: 10EBernhardson) [20:56:50] (03CR) 10Ori.livneh: [C: 032] Database update script should run as web user [vagrant] - 10https://gerrit.wikimedia.org/r/118133 (owner: 10EBernhardson) [20:57:13] (03Merged) 10jenkins-bot: Database update script should run as web user [vagrant] - 10https://gerrit.wikimedia.org/r/118133 (owner: 10EBernhardson) [20:57:15] (03Merged) 10jenkins-bot: Create flow role [vagrant] - 10https://gerrit.wikimedia.org/r/118136 (owner: 10EBernhardson) [21:00:56] (03PS12) 10Bsitu: Update post/header revisions storage search key [extensions/Flow] - 10https://gerrit.wikimedia.org/r/117099 [21:01:15] (03CR) 10jenkins-bot: [V: 04-1] Update post/header revisions storage search key [extensions/Flow] - 10https://gerrit.wikimedia.org/r/117099 (owner: 10Bsitu) [21:06:59] (03CR) 10CSteipp: [C: 032] "Fixes the issue, and looks ok to me." [extensions/AntiSpoof] - 10https://gerrit.wikimedia.org/r/117640 (owner: 10Hoo man) [21:07:05] (03Merged) 10jenkins-bot: Map U+200B (zero width space) to an empty string [extensions/AntiSpoof] - 10https://gerrit.wikimedia.org/r/117640 (owner: 10Hoo man) [21:12:58] (03CR) 10CSteipp: [C: 031] "Logging looks ok" [extensions/SpamBlacklist] - 10https://gerrit.wikimedia.org/r/117231 (owner: 10Jackmcbarn) [21:14:08] (03PS1) 10EBernhardson: Don't install php5-fpm [vagrant] - 10https://gerrit.wikimedia.org/r/118201 [21:15:02] (03PS2) 10EBernhardson: Don't install php5-fpm [vagrant] - 10https://gerrit.wikimedia.org/r/118201 [21:15:58] (03PS1) 10EBernhardson: HHVM on ubuntu precise requires boost ppa [vagrant] - 10https://gerrit.wikimedia.org/r/118202 [21:17:50] (03CR) 10CSteipp: "Haven't tested, but looks fine for security. Should work as long as the name and title are normalized the same. Can't remember off the top" [extensions/GlobalCssJs] - 10https://gerrit.wikimedia.org/r/94842 (owner: 10Legoktm) [21:17:59] (03CR) 10CSteipp: [C: 031] Display a notice on top of the edit window when editing global.css/js [extensions/GlobalCssJs] - 10https://gerrit.wikimedia.org/r/94842 (owner: 10Legoktm) [21:19:45] (03PS2) 10EBernhardson: HHVM on ubuntu precise requires boost ppa [vagrant] - 10https://gerrit.wikimedia.org/r/118202 [21:25:26] (03PS13) 10Bsitu: Update post/header revision storage search key [extensions/Flow] - 10https://gerrit.wikimedia.org/r/117099 [21:34:43] (03CR) 10Arlolra: [C: 04-1] "Cscott:" [core] - 10https://gerrit.wikimedia.org/r/89141 (owner: 10Arlolra) [21:36:04] (03PS11) 10Bsitu: Drop table flow_header_revision [extensions/Flow] - 10https://gerrit.wikimedia.org/r/117115 [21:36:21] (03CR) 10jenkins-bot: [V: 04-1] Drop table flow_header_revision [extensions/Flow] - 10https://gerrit.wikimedia.org/r/117115 (owner: 10Bsitu) [21:36:58] (03PS12) 10Bsitu: Drop table: flow_header_revision [extensions/Flow] - 10https://gerrit.wikimedia.org/r/117115 [21:38:43] (03CR) 10CSteipp: [C: 032] When checking whitelist of extensions, only count last extension. [core] - 10https://gerrit.wikimedia.org/r/117668 (owner: 10Brian Wolff) [21:40:19] (03CR) 10CSteipp: [C: 031] Remove link to edits with Oversight from Special:Contributions [extensions/Oversight] - 10https://gerrit.wikimedia.org/r/117243 (owner: 10Alex Monk) [21:42:49] (03CR) 10Helder.wiki: "I believe this will remove functionality from https://pt.wikipedia.org/wiki/MediaWiki:Gadget-PagesForDeletion.js/Core.js" [core] - 10https://gerrit.wikimedia.org/r/118135 (owner: 10MaxSem) [21:43:37] (03Merged) 10jenkins-bot: When checking whitelist of extensions, only count last extension. [core] - 10https://gerrit.wikimedia.org/r/117668 (owner: 10Brian Wolff) [21:45:52] (03PS6) 10Bsitu: Add summary revision type [extensions/Flow] - 10https://gerrit.wikimedia.org/r/117357 [21:47:06] (03CR) 10CSteipp: [C: 031] "Looks good, and fixes the immediate bug. Adding Ori just in case he thinks 3 extra if's on every api call isn't worth the usability gains." [core] - 10https://gerrit.wikimedia.org/r/117189 (owner: 10Anomie) [21:51:17] (03CR) 10CSteipp: [C: 031] Add an API module for querying AntiSpoof results. [extensions/AntiSpoof] - 10https://gerrit.wikimedia.org/r/87546 (owner: 10Stwalkerster) [21:57:09] (03PS7) 10Bsitu: Add summary revision type [extensions/Flow] - 10https://gerrit.wikimedia.org/r/117357 [22:00:54] (03PS5) 10EBernhardson: (bug 61107) Contributions from Flow appear in every namespace [extensions/Flow] - 10https://gerrit.wikimedia.org/r/115908 (owner: 10Matthias Mullie) [22:03:13] (03CR) 10EBernhardson: [C: 032] "I'm a bit worried about the performance of this query, but for the moment its ok. We probably need to revisit some data modeling to make " [extensions/Flow] - 10https://gerrit.wikimedia.org/r/115908 (owner: 10Matthias Mullie) [22:03:28] (03Merged) 10jenkins-bot: (bug 61107) Contributions from Flow appear in every namespace [extensions/Flow] - 10https://gerrit.wikimedia.org/r/115908 (owner: 10Matthias Mullie) [22:10:12] (03CR) 10Aaron Schulz: [C: 031] API: Handle exceptions from ApiBeforeMain hook in a user-friendly manner [core] - 10https://gerrit.wikimedia.org/r/117189 (owner: 10Anomie) [22:17:10] hexmode: Can you help me with the function getPrefixedText(), I cannot find what it does. [22:21:57] zeek_: JS or PHP? [22:22:16] PHP [22:22:44] zeek_: https://doc.wikimedia.org/mediawiki-core/master/php/html/classTitle.html#af5b1a7940de056155682dc7fd82a2ef1 [22:24:01] rdwrer: Please help me with one thing more, I have a link like this "http://127.0.0.1:8080/w/index.php?title=Thread:Talk:Main_Page/Test_1&lqt_method=diff&diff=11&oldid=5" and I wish to generate is as an internal link in wiki text, so what is the correct way... using [$1 text] or [[$1|text]] isn't giving correct output. [22:24:32] zeek_: What are you putting into $1? [22:25:07] title->getPrefixText [22:25:12] kind of [22:25:41] I feel this is the problem of my variable.... but doesn't internationalization automatically fix it? [22:26:57] (03PS7) 10EBernhardson: Non-hacky way to feed title to Parsoid [extensions/Flow] - 10https://gerrit.wikimedia.org/r/115112 (owner: 10Matthias Mullie) [22:28:56] zeek_: if you have a url and wikitext you have to use [$1 text], but that will always render the external links thing. Generally the hacky solution is wrap the message output in [22:29:11] (assuming what your worried about is the little external link icon) [22:29:31] yeah i know about that, but I am trying to not use the hack.... so how can i really fix it if possible [22:29:58] (03CR) 10EBernhardson: "PS7: updated RedlinkerTest, all tests passing now" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/115112 (owner: 10Matthias Mullie) [22:30:22] zeek_: you cant really [22:30:27] ebernhardson: why does [[$1|text]] doen't work in this case? [22:30:46] zeek_: because $1 is a url which includes query parameters, and you cant pass query parameters in [[...]] [22:31:13] (assuming your url posted above) [22:31:42] Yes thats the URL, so then using class plainlinks is the acceptable way? [22:32:07] its the hacky way we've ended up using, the i18n team prefers you not put that in the message itself though and just wrap the $message->parse() result [22:33:53] ebernhardson: Didn't follow on your last point.. please explain [22:35:01] zeek_: you could have in your i18n file 'some-i18n-key' => 'foo bar [$1 $2] baz [22:35:20] (03PS4) 10Krinkle: qunit: Disable sinonjs-ie as it breaks the clock sandbox [core] - 10https://gerrit.wikimedia.org/r/117149 [22:35:27] zeek_: but i18n team doesn't like that, they would prefer echo '' . wfMessage( 'some-i18n-key' )->parse() . ''; [22:36:00] (doesn't like as in it makes translations more difficult for the people helping us to translate) [22:36:30] (03CR) 10Krinkle: "Bump, this is blocking extensions from using sinon mock timers in their qunit tests (ran by Jenkins on phantomjs, which, as most engines, " [core] - 10https://gerrit.wikimedia.org/r/117149 (owner: 10Krinkle) [22:36:47] (03PS4) 10Krinkle: jquery.color.test: Use fake timers [core] - 10https://gerrit.wikimedia.org/r/117150 [22:37:19] got it.. thanks. :) [22:44:35] (03PS8) 10EBernhardson: Non-hacky way to feed title to Parsoid [extensions/Flow] - 10https://gerrit.wikimedia.org/r/115112 (owner: 10Matthias Mullie) [22:44:52] (03CR) 10jenkins-bot: [V: 04-1] Non-hacky way to feed title to Parsoid [extensions/Flow] - 10https://gerrit.wikimedia.org/r/115112 (owner: 10Matthias Mullie) [22:48:17] (03PS1) 10Adi.iiita: Fixed padlock on thread history for LiquidThreads Bug 33394 [extensions/LiquidThreads] - 10https://gerrit.wikimedia.org/r/118212 [22:49:52] (03CR) 10Krinkle: [C: 031] Remove JavaScript link insertion code [extensions/WikimediaShopLink] - 10https://gerrit.wikimedia.org/r/117814 (owner: 10Ori.livneh) [22:49:53] hexmode: https://gerrit.wikimedia.org/r/118212 [22:50:59] (03PS9) 10EBernhardson: Non-hacky way to feed title to Parsoid [extensions/Flow] - 10https://gerrit.wikimedia.org/r/115112 (owner: 10Matthias Mullie) [22:51:14] (03CR) 10jenkins-bot: [V: 04-1] Non-hacky way to feed title to Parsoid [extensions/Flow] - 10https://gerrit.wikimedia.org/r/115112 (owner: 10Matthias Mullie) [22:51:44] (03CR) 10Krinkle: Add $wgLocalInterwikis to handle multiple local prefixes (031 comment) [core] - 10https://gerrit.wikimedia.org/r/110162 (owner: 10TTO) [23:00:06] jdlrobson, kaldari: I'm trying to access mediawiki.ui's @colorGrayDark from an extension, but that's not in $wgResourceLoaderLESSImportPaths , is there a hack way to @import it in LESS? [23:00:38] (03PS4) 10Cscott: Rename sections in parserTests.txt. [core] - 10https://gerrit.wikimedia.org/r/117613 [23:00:40] (03PS8) 10Cscott: Allow more-descriptive section names for parserTests [core] - 10https://gerrit.wikimedia.org/r/89141 (owner: 10Arlolra) [23:01:37] spagewmf: $wgResourceLoaderLESSImportPaths ? [23:02:14] (03PS10) 10EBernhardson: Non-hacky way to feed title to Parsoid [extensions/Flow] - 10https://gerrit.wikimedia.org/r/115112 (owner: 10Matthias Mullie) [23:02:34] (03CR) 10EBernhardson: Non-hacky way to feed title to Parsoid (032 comments) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/115112 (owner: 10Matthias Mullie) [23:02:59] kaldari: thx. MobileFrontend fiddles that, but I don't think extensions should change globals. [23:03:27] (03PS5) 10Krinkle: resourcesoader: Pass jQuery twice to 'implements' module wrapper [core] - 10https://gerrit.wikimedia.org/r/85637 (owner: 10Ori.livneh) [23:03:33] (03CR) 10Spage: "Right approach." (032 comments) [core] - 10https://gerrit.wikimedia.org/r/117105 (owner: 10Kaldari) [23:03:57] spagewmf: oops, I see you already mentioned that. Not sure what a better way would be [23:04:05] (03CR) 10EBernhardson: [C: 032] "PS8-10: wfDeprecated(), then undid wfDeprecated() since it fails tests where code paths need adjusting and cant just switch for performanc" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/115112 (owner: 10Matthias Mullie) [23:04:08] (03PS2) 10Krinkle: ResourceLoader::makeLoaderImplementScript: Bind args as '$' and 'jQuery' [core] - 10https://gerrit.wikimedia.org/r/117672 (owner: 10Ori.livneh) [23:04:14] (03PS3) 10Krinkle: ResourceLoader::makeLoaderImplementScript: Bind args as '$' and 'jQuery' [core] - 10https://gerrit.wikimedia.org/r/117672 (owner: 10Ori.livneh) [23:05:05] kaldari: I commented on your 15shadesofgrey patch. Jon added $IP/skins/Vector to $wgResourceLoaderLESSImportPaths; we should nail down what's in the path. [23:05:57] (03PS6) 10Krinkle: resourceloader: Pass jQuery twice to 'implements' module wrapper [core] - 10https://gerrit.wikimedia.org/r/85637 (owner: 10Ori.livneh) [23:05:59] (03Merged) 10jenkins-bot: Non-hacky way to feed title to Parsoid [extensions/Flow] - 10https://gerrit.wikimedia.org/r/115112 (owner: 10Matthias Mullie) [23:06:22] (03CR) 10Krinkle: [C: 032] resourceloader: Pass jQuery twice to 'implements' module wrapper [core] - 10https://gerrit.wikimedia.org/r/85637 (owner: 10Ori.livneh) [23:06:27] (03PS4) 10Krinkle: ResourceLoader::makeLoaderImplementScript: Bind args as '$' and 'jQuery' [core] - 10https://gerrit.wikimedia.org/r/117672 (owner: 10Ori.livneh) [23:10:13] (03CR) 10Krinkle: [C: 04-1] "Hold back for cache reasons (I0c9edac35). Also, let's add release notes to this one about ResourceLoader now binding $ and jQuery in the i" [core] - 10https://gerrit.wikimedia.org/r/117672 (owner: 10Ori.livneh) [23:12:51] (03CR) 10Krinkle: "This change can potentially break bad setups that overload jQuery or $ and try to use it. E.g. if a wiki out there is happily loading some" [core] - 10https://gerrit.wikimedia.org/r/117672 (owner: 10Ori.livneh) [23:13:24] (03Merged) 10jenkins-bot: resourceloader: Pass jQuery twice to 'implements' module wrapper [core] - 10https://gerrit.wikimedia.org/r/85637 (owner: 10Ori.livneh) [23:14:09] (03CR) 10Krinkle: [C: 031] "Pending +1 from Mark." [core] - 10https://gerrit.wikimedia.org/r/111620 (owner: 10MarkTraceur) [23:14:12] rdwrer: https://gerrit.wikimedia.org/r/#/c/111620/ [23:14:19] Uh oh [23:14:24] Oh, that's not so bad [23:15:12] (03CR) 10Krinkle: [C: 031] Mention possibility of $revision being null in PageContentSaveComplete [core] - 10https://gerrit.wikimedia.org/r/117625 (owner: 10Alex Monk) [23:20:43] (03CR) 10Spage: "@Mattflaschen, the benefit of having the unused colors is to encourage consistency in code outside mediawiki.ui. Otherwise extensions have" [core] - 10https://gerrit.wikimedia.org/r/117105 (owner: 10Kaldari) [23:21:02] (03PS1) 10Jdlrobson: Skins: Only load watch star ajax on Vector [core] - 10https://gerrit.wikimedia.org/r/118217 [23:21:52] Krinkle: Want me to merge or only +1? [23:22:14] Fine either way, but suppose it's cleaner if you +1 [23:27:27] (03CR) 10Krinkle: "Untrue. This also works in Monobook and other skins that implement the same html structure (which all skins generally should unless they h" [core] - 10https://gerrit.wikimedia.org/r/118217 (owner: 10Jdlrobson) [23:27:31] (03CR) 10Krinkle: [C: 04-1] Skins: Only load watch star ajax on Vector [core] - 10https://gerrit.wikimedia.org/r/118217 (owner: 10Jdlrobson) [23:28:43] Krinkle: this isn't the case though… do any of the other skins in core implement the same HTML structure? [23:28:59] it doesn't seem to work for me on any of the skins on live wikipedia [23:30:27] (03CR) 10Krinkle: Skins: Only load watch star ajax on Vector (031 comment) [core] - 10https://gerrit.wikimedia.org/r/118217 (owner: 10Jdlrobson) [23:30:58] jdlrobson: As I said, Monobook, and practically all modern skins developed for mediawiki that are even remotely like what a skin should be like in mediawiki that doesn't re-implement everything itself (like MF) [23:31:09] The portlet html is generated by Linker and Skin, not by a subclass [23:31:18] it is the default structure provided by the placeholders [23:31:21] for tab and sidebar etc. [23:31:33] not in anyway specific for Vector, I don't know where you get that from. [23:31:47] errr Krinkle but i don't see this code run anywhere other than Vector [23:31:51] If Vector were the only skin that doesn't override it, then it would be a bit tre, but still semantically different. [23:32:18] ooh wait, this code has nothing to do with the star itself [23:32:25] okay this makes a little more sense now [23:32:29] Then someone broke it. It used to work fine in monobook, and most custom skins I've seen. [23:32:35] (03PS2) 10Physikerwelt: Split up some long lines in tests [extensions/Math] - 10https://gerrit.wikimedia.org/r/118089 (owner: 10Addshore) [23:32:40] it just looked different so i was some how missing that [23:32:55] (03CR) 10Physikerwelt: [C: 032] Split up some long lines in tests [extensions/Math] - 10https://gerrit.wikimedia.org/r/118089 (owner: 10Addshore) [23:33:49] (03CR) 10Jdlrobson: [C: 04-2] "Sorry I see this now. It just wasn't obvious when first writing this patch that that code was doing anything in the other skins as I was l" [core] - 10https://gerrit.wikimedia.org/r/118217 (owner: 10Jdlrobson) [23:35:19] (03Merged) 10jenkins-bot: Split up some long lines in tests [extensions/Math] - 10https://gerrit.wikimedia.org/r/118089 (owner: 10Addshore) [23:36:07] (03CR) 10Jdlrobson: Skins: Only load watch star ajax on Vector (031 comment) [core] - 10https://gerrit.wikimedia.org/r/118217 (owner: 10Jdlrobson) [23:37:58] (03CR) 10Maryana: [C: 04-1] "This patch makes reply and edit all smooshed together." [extensions/Flow] - 10https://gerrit.wikimedia.org/r/113066 (owner: 10Matthias Mullie) [23:40:02] (03PS8) 10Bsitu: Add summary revision type [extensions/Flow] - 10https://gerrit.wikimedia.org/r/117357 [23:40:08] (03CR) 10jenkins-bot: [V: 04-1] Add summary revision type [extensions/Flow] - 10https://gerrit.wikimedia.org/r/117357 (owner: 10Bsitu) [23:43:08] (03CR) 10MarkTraceur: [C: 031] Include all of /resources/mediawiki/* in jsduck index [core] - 10https://gerrit.wikimedia.org/r/111620 (owner: 10MarkTraceur) [23:43:25] Krinkle: Done [23:52:21] (03CR) 10Krinkle: [C: 032] Include all of /resources/mediawiki/* in jsduck index [core] - 10https://gerrit.wikimedia.org/r/111620 (owner: 10MarkTraceur) [23:54:54] (03CR) 10Krinkle: mediawiki.inspect: add method for grepping loaded modules (031 comment) [core] - 10https://gerrit.wikimedia.org/r/97856 (owner: 10Ori.livneh) [23:55:05] (03CR) 10Krinkle: [C: 04-1] mediawiki.inspect: add method for grepping loaded modules [core] - 10https://gerrit.wikimedia.org/r/97856 (owner: 10Ori.livneh) [23:56:56] (03Merged) 10jenkins-bot: Include all of /resources/mediawiki/* in jsduck index [core] - 10https://gerrit.wikimedia.org/r/111620 (owner: 10MarkTraceur) [23:57:10] (03CR) 10Krinkle: "Found at least two popular one (aside from the one deprecated in mwExtension)." [core] - 10https://gerrit.wikimedia.org/r/97856 (owner: 10Ori.livneh) [23:58:50] (03PS1) 10EBernhardson: Pass Title to setContent to prevent lazy-loading [extensions/Flow] - 10https://gerrit.wikimedia.org/r/118219