[00:00:59] (03PS14) 10Inchikutty: UploadWizard: OSM embedding: Geocoding, reverse geocoding [extensions/UploadWizard] (osm) - 10https://gerrit.wikimedia.org/r/116130 [00:01:34] Reedy: Is that a real thing? [00:02:02] https://wikimediafoundation.org/wiki/Staff_and_contractors#Multimedia [00:02:56] Gloria: Only for nine months. :-) [00:03:04] (03CR) 10BryanDavis: "> I don't know what "NOQA" means. I checked and James_F: Where's the baby? [00:03:26] Reedy: MURIKA! [00:03:32] Wait, no, that's not the answer. [00:03:36] (That's always the answer.) [00:03:55] Reedy: I think it's the Media Viewer Beta Feature, which is indeed about to come to term. [00:04:57] There's a difference between it existing on a page on the Internet and it being a real thing. [00:05:10] Gloria: Yes; normally the former lags the latter by a few months. [00:05:18] Anyway, if the Multimedia Team is interested in maintaining PagedTiffHandler, I won't say no. [00:05:34] I think it's currently considered a platform extension, though. Who knows! [00:05:40] James_F: Indeed. :-) [00:07:13] Gloria: Luckily Multimedia is a sub-team of Platform, so… [00:07:51] I think I might get Platform and Core mixed up. [00:07:53] Unless they're the same. [00:08:00] Core, not to be confused with Core Features. [00:08:03] Core is a sub-team of Platform. [00:08:10] Yeah. Who came up with these names? Oy. [00:08:11] It's turtles all the way down. [00:08:33] (03PS1) 10Reedy: Couple of minor code updates [extensions/VipsScaler] - 10https://gerrit.wikimedia.org/r/117811 [00:08:35] So Core and Multimedia are siblings, then. [00:08:44] That seems, um, [00:08:45] Sure. [00:09:00] In the same way that VE and Core are cousins. [00:09:16] Because VE lives under Features, not Platform. [00:09:38] Exactly. [00:10:00] Personally, I'd have an "Editing" team which does VE, WT and other tools for editors. [00:16:10] heyhey James_F / Gloria [00:16:17] Heya werdna. [00:16:36] * Gloria waves. [00:17:02] what's going on? [00:19:02] werdna: Someone mentioned VipsScaler and I went to investigate. [00:19:13] I think the extension is enabled, but only activates for large PNGs or something. [00:19:26] People want support for other file types, via other extensions, perhaps? I'm not really sure. [00:19:37] There's some code pending, but it's now a matter of code review. :-) [00:19:56] I have no idea what VipsScaler does [00:20:00] The default code suggests it should be fine for jpgs [00:20:01] but I'm guessing it's an image scaler [00:20:08] and I vaguely remember that VIPS is a type of image [00:20:14] so that seems to make sense [00:21:13] Warning: require(/usr/lib/php/pear/PHPUnit/Autoload.php): failed to open stream: No such file or directory in /usr/bin/phpunit on line 43 [00:21:13] grrrr [00:36:17] (03PS1) 10Reedy: Don't branch skins or SkinPerPage extensions [tools/release] - 10https://gerrit.wikimedia.org/r/117812 [00:36:48] (03CR) 10Reedy: "https://gerrit.wikimedia.org/r/117810 needs to be merged/deployed first..." [tools/release] - 10https://gerrit.wikimedia.org/r/117812 (owner: 10Reedy) [00:36:52] (03PS8) 10Bsitu: Update post/header revisions storage lookup key [extensions/Flow] - 10https://gerrit.wikimedia.org/r/117099 [00:37:21] (03PS1) 10Hoo man: Remove the skins and SkinPerPage extension from make-wmf-branch [tools/release] - 10https://gerrit.wikimedia.org/r/117813 [00:38:58] (03Abandoned) 10Hoo man: Remove the skins and SkinPerPage extension from make-wmf-branch [tools/release] - 10https://gerrit.wikimedia.org/r/117813 (owner: 10Hoo man) [00:54:39] Reedy: how much do you know about phpunit tests? [00:57:09] (03CR) 10Anomie: [C: 04-2] "This has nothing to do with bug 55898, is in the wrong place, and either has the wrong content or is redundant to engines/LuaStandalone/bi" [extensions/Scribunto] - 10https://gerrit.wikimedia.org/r/117663 (owner: 10Ocean behind ears) [00:59:31] (03CR) 10Hiong3-eng5: [C: 031] "Re-check the code for wrong parameters or missing parameters or existing definitions." [extensions/WikiLexicalData] - 10https://gerrit.wikimedia.org/r/116270 (owner: 10Purodha) [01:00:16] (03PS1) 10Ori.livneh: Remove JavaScript link insertion code [extensions/WikimediaShopLink] - 10https://gerrit.wikimedia.org/r/117814 [01:05:01] (03PS2) 10Reedy: Don't branch skins or SkinPerPage extensions [tools/release] - 10https://gerrit.wikimedia.org/r/117812 [01:05:32] (03PS3) 10Reedy: Don't branch skins, SkinPerPage or FormPreloadPostCache extensions [tools/release] - 10https://gerrit.wikimedia.org/r/117812 [01:05:34] (03PS5) 10Bsitu: Drop table flow_header_revision [extensions/Flow] - 10https://gerrit.wikimedia.org/r/117115 [01:05:40] (03CR) 10jenkins-bot: [V: 04-1] Drop table flow_header_revision [extensions/Flow] - 10https://gerrit.wikimedia.org/r/117115 (owner: 10Bsitu) [01:08:15] (03PS6) 10Bsitu: Drop table flow_header_revision [extensions/Flow] - 10https://gerrit.wikimedia.org/r/117115 [01:08:20] (03CR) 10jenkins-bot: [V: 04-1] Drop table flow_header_revision [extensions/Flow] - 10https://gerrit.wikimedia.org/r/117115 (owner: 10Bsitu) [01:17:22] (03PS7) 10Bsitu: Drop table flow_header_revision [extensions/Flow] - 10https://gerrit.wikimedia.org/r/117115 [01:28:13] (03CR) 10Brian Wolff: "I think there is still stuff to do here before review. I havent looked at this in a while, should really give it more attention (along wit" [extensions/PagedTiffHandler] - 10https://gerrit.wikimedia.org/r/86413 (owner: 10Brian Wolff) [01:41:36] (03CR) 10Hoo man: [C: 04-1] "also qqq message change still missing" (032 comments) [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/105617 (owner: 10Jackmcbarn) [01:42:47] (03Abandoned) 10Hoo man: Increased $mChangeLimit from 100 to 500 [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/109461 (owner: 10Arav93) [01:45:22] (03CR) 10Hoo man: "I suggest to abandon this (per the wontfixed bug)" [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/82229 (owner: 10Helder.wiki) [01:49:55] (03CR) 10Hoo man: [C: 032] Exclude backlinks from selection [extensions/Cite] - 10https://gerrit.wikimedia.org/r/110324 (owner: 10Gerrit Patch Uploader) [01:50:13] (03Merged) 10jenkins-bot: Exclude backlinks from selection [extensions/Cite] - 10https://gerrit.wikimedia.org/r/110324 (owner: 10Gerrit Patch Uploader) [01:54:34] (03CR) 10Jackmcbarn: "Will fix other issues shortly." (031 comment) [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/105617 (owner: 10Jackmcbarn) [01:58:01] (03PS12) 10Werdna: Extract wiki and external links, file and template usages from text. [extensions/Flow] - 10https://gerrit.wikimedia.org/r/110090 [01:58:05] (03CR) 10jenkins-bot: [V: 04-1] Extract wiki and external links, file and template usages from text. [extensions/Flow] - 10https://gerrit.wikimedia.org/r/110090 (owner: 10Werdna) [01:59:15] (03PS6) 10Jackmcbarn: Support searching for multiple filter IDs [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/105617 [02:00:45] (03CR) 10Jackmcbarn: Support searching for multiple filter IDs (031 comment) [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/105617 (owner: 10Jackmcbarn) [02:01:30] (03PS13) 10Werdna: Extract wiki and external links, file and template usages from text. [extensions/Flow] - 10https://gerrit.wikimedia.org/r/110090 [02:01:52] (03CR) 10Werdna: "PS12 makes all tests pass. PS13 is a rebase." [extensions/Flow] - 10https://gerrit.wikimedia.org/r/110090 (owner: 10Werdna) [02:02:00] (03CR) 10jenkins-bot: [V: 04-1] Extract wiki and external links, file and template usages from text. [extensions/Flow] - 10https://gerrit.wikimedia.org/r/110090 (owner: 10Werdna) [02:02:40] (03CR) 10Hoo man: Support searching for multiple filter IDs (032 comments) [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/105617 (owner: 10Jackmcbarn) [02:03:18] 02:01:58 Flow\Exception\InvalidDataException: Title "UTPage" does not exist. [02:03:19] fail [02:05:19] (03PS1) 10Werdna: Workaround for issue where UTPage title is never created, and so there is no existing page to test against. [core] - 10https://gerrit.wikimedia.org/r/117815 [02:06:33] (03CR) 10Werdna: "Tests are failing because UTPage doesn't exist :/" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/110090 (owner: 10Werdna) [02:17:43] (03PS1) 10MarkAHershberger: Set a title for the context during import on the cli [core] - 10https://gerrit.wikimedia.org/r/117816 [02:33:49] (03PS6) 10AndyRussG: Add minimal dependency injection, including tests [extensions/Campaigns] (wip/editorcampaigns) - 10https://gerrit.wikimedia.org/r/116153 [02:54:44] (03CR) 10Ori.livneh: [C: 031] "Fine by me, but I'll wait for Hashar to make the call on this one." [tools/scap] - 10https://gerrit.wikimedia.org/r/116399 (owner: 10BryanDavis) [02:55:42] (03CR) 10AndyRussG: "Thanks! The reflection you're seeing isn't for checking that the implementation class is a subclass of the registered type. It's for disco" [extensions/Campaigns] (wip/editorcampaigns) - 10https://gerrit.wikimedia.org/r/116153 (owner: 10AndyRussG) [02:56:33] (03PS7) 10AndyRussG: Add minimal dependency injection, including tests [extensions/Campaigns] (wip/editorcampaigns) - 10https://gerrit.wikimedia.org/r/116153 [02:57:09] (03CR) 10AndyRussG: "Minor improvement in wording in comment" [extensions/Campaigns] (wip/editorcampaigns) - 10https://gerrit.wikimedia.org/r/116153 (owner: 10AndyRussG) [03:05:57] (03PS1) 10Werdna: Fix editing header on untouched page. [extensions/Flow] - 10https://gerrit.wikimedia.org/r/117819 [03:14:27] (03PS1) 10Werdna: Fix Header::create, which now needs to set ->userWiki because of I439b102e9125c4e6aed988032a21d51b1079f93b [extensions/Flow] - 10https://gerrit.wikimedia.org/r/117820 [03:27:40] (03CR) 10Ori.livneh: [C: 032] Implement multiversion/refreshWikiversionsCDB in python [tools/scap] - 10https://gerrit.wikimedia.org/r/116906 (owner: 10BryanDavis) [03:27:49] (03PS14) 10Werdna: Extract wiki and external links, file and template usages from text. [extensions/Flow] - 10https://gerrit.wikimedia.org/r/110090 [03:28:05] (03Merged) 10jenkins-bot: Implement multiversion/refreshWikiversionsCDB in python [tools/scap] - 10https://gerrit.wikimedia.org/r/116906 (owner: 10BryanDavis) [03:28:07] (03CR) 10jenkins-bot: [V: 04-1] Extract wiki and external links, file and template usages from text. [extensions/Flow] - 10https://gerrit.wikimedia.org/r/110090 (owner: 10Werdna) [03:29:55] (03PS15) 10Werdna: Extract wiki and external links, file and template usages from text. [extensions/Flow] - 10https://gerrit.wikimedia.org/r/110090 [03:30:12] (03CR) 10jenkins-bot: [V: 04-1] Extract wiki and external links, file and template usages from text. [extensions/Flow] - 10https://gerrit.wikimedia.org/r/110090 (owner: 10Werdna) [03:30:27] (03CR) 10Werdna: "PS14 uses LinksUpdate instead of our roll-your-own thing, and triggers secondary data updates when something on a Flow board is updated." [extensions/Flow] - 10https://gerrit.wikimedia.org/r/110090 (owner: 10Werdna) [03:35:19] (03PS1) 10BryanDavis: Force l10n rebuild after bootstrapping [tools/scap] - 10https://gerrit.wikimedia.org/r/117821 [03:39:31] (03PS2) 10BryanDavis: Force l10n rebuild after bootstrapping [tools/scap] - 10https://gerrit.wikimedia.org/r/117821 [03:59:13] (03PS4) 10BryanDavis: Use realm specific filename with mwversionsinuse [tools/scap] - 10https://gerrit.wikimedia.org/r/117014 [04:50:39] (03PS1) 10Gnosygnu: v1.3.2.1 [xowa] - 10https://gerrit.wikimedia.org/r/117822 [04:51:04] (03CR) 10Gnosygnu: [C: 032 V: 032] "approving own commit" [xowa] - 10https://gerrit.wikimedia.org/r/117822 (owner: 10Gnosygnu) [04:54:08] (03CR) 10Hiong3-eng5: "yes, from my perspective, no need to rebase this. the corrections in 116270 is enough." [extensions/WikiLexicalData] - 10https://gerrit.wikimedia.org/r/116277 (owner: 10Purodha) [06:42:54] (03PS1) 10AndyRussG: WIP Schema change: create tables [extensions/Campaigns] - 10https://gerrit.wikimedia.org/r/117825 [06:47:58] (03PS1) 10Ori.livneh: lint [vagrant] - 10https://gerrit.wikimedia.org/r/117826 [06:48:18] (03CR) 10Ori.livneh: [C: 032] lint [vagrant] - 10https://gerrit.wikimedia.org/r/117826 (owner: 10Ori.livneh) [07:14:20] (03CR) 10KartikMistry: [WIP] LU rewrite (031 comment) [extensions/LocalisationUpdate] (json-rewrite) - 10https://gerrit.wikimedia.org/r/117385 (owner: 10Nikerabbit) [07:23:10] (03CR) 10Nikerabbit: [WIP] LU rewrite (031 comment) [extensions/LocalisationUpdate] (json-rewrite) - 10https://gerrit.wikimedia.org/r/117385 (owner: 10Nikerabbit) [07:39:06] (03CR) 10KartikMistry: [WIP] LU rewrite (031 comment) [extensions/LocalisationUpdate] (json-rewrite) - 10https://gerrit.wikimedia.org/r/117385 (owner: 10Nikerabbit) [08:18:48] (03CR) 10Gergő Tisza: [C: 032] Embedding leaflet maps based on OSM data to UploadWizard [extensions/UploadWizard] (osm) - 10https://gerrit.wikimedia.org/r/116129 (owner: 10Inchikutty) [08:37:27] (03CR) 10Gergő Tisza: "I don't see more problems with the code. If you don't plan more changes, please remove the remaining console.log commands, and I will merg" (031 comment) [extensions/UploadWizard] (osm) - 10https://gerrit.wikimedia.org/r/116130 (owner: 10Inchikutty) [09:03:04] (03PS1) 10leucosticte: Add getRobotPolicy() [core] - 10https://gerrit.wikimedia.org/r/117832 [09:04:10] (03PS2) 10Siebrand: Add final period to API module descriptions [core] - 10https://gerrit.wikimedia.org/r/117704 (owner: 10Addshore) [09:05:08] (03CR) 10Siebrand: [C: 032] "Thanks. Getting ready to scan extension API modules, too?" [core] - 10https://gerrit.wikimedia.org/r/117704 (owner: 10Addshore) [09:08:43] (03Merged) 10jenkins-bot: lint [vagrant] - 10https://gerrit.wikimedia.org/r/117826 (owner: 10Ori.livneh) [09:09:03] (03CR) 10Siebrand: [C: 04-1] "i18n/L10n reviewed." (034 comments) [extensions/OpenBadges] - 10https://gerrit.wikimedia.org/r/116289 (owner: 10Chococookies) [09:09:39] (03Merged) 10jenkins-bot: Embedding leaflet maps based on OSM data to UploadWizard [extensions/UploadWizard] (osm) - 10https://gerrit.wikimedia.org/r/116129 (owner: 10Inchikutty) [09:10:39] (03CR) 10Siebrand: Add PM log (031 comment) [extensions/MediaWikiChat] - 10https://gerrit.wikimedia.org/r/116287 (owner: 10UltrasonicNXT) [09:12:40] (03Merged) 10jenkins-bot: Add final period to API module descriptions [core] - 10https://gerrit.wikimedia.org/r/117704 (owner: 10Addshore) [09:13:31] (03PS2) 10leucosticte: Add getRobotPolicy() [core] - 10https://gerrit.wikimedia.org/r/117832 [09:16:11] (03CR) 10Siebrand: [C: 04-1] "i18n/L10n reviewed." [extensions/EducationProgram] - 10https://gerrit.wikimedia.org/r/114449 (owner: 10Amire80) [09:17:18] (03CR) 10Amire80: "Heh, didn't notice Sage's comment. Fixing." [extensions/EducationProgram] - 10https://gerrit.wikimedia.org/r/114449 (owner: 10Amire80) [09:18:06] (03PS3) 10Siebrand: Add getRobotPolicy() [core] - 10https://gerrit.wikimedia.org/r/117832 (owner: 10leucosticte) [09:20:40] (03CR) 10Siebrand: "Nice one." [extensions/MediaWikiChat] - 10https://gerrit.wikimedia.org/r/117694 (owner: 10UltrasonicNXT) [09:22:30] (03CR) 10Siebrand: Add users being away (031 comment) [extensions/MediaWikiChat] - 10https://gerrit.wikimedia.org/r/117690 (owner: 10UltrasonicNXT) [10:07:02] (03CR) 10Hashar: [C: 031] grrrit: Allow filtering based on branches [labs/tools/grrrit] - 10https://gerrit.wikimedia.org/r/116996 (owner: 10AzaToth) [10:07:58] (03CR) 10Hashar: [C: 031] grrrit: Pass betacluster messages to QA [labs/tools/grrrit] - 10https://gerrit.wikimedia.org/r/116997 (owner: 10AzaToth) [10:07:58] (03CR) 10Hashar: [C: 04-1] "I dont think all repos should spam #wikimedia-dev" [labs/tools/grrrit] - 10https://gerrit.wikimedia.org/r/117662 (owner: 10AzaToth) [10:10:57] (03PS6) 10Hashar: Parsoid: uses ZUUL_COMMIT as a git refspec to build [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/117045 [10:14:10] (03CR) 10Hashar: [C: 032] Parsoid: uses ZUUL_COMMIT as a git refspec to build [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/117045 (owner: 10Hashar) [10:14:27] (03Merged) 10jenkins-bot: Parsoid: uses ZUUL_COMMIT as a git refspec to build [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/117045 (owner: 10Hashar) [10:17:30] (03PS18) 10Physikerwelt: Coverage tests for the Math extension [extensions/Math] - 10https://gerrit.wikimedia.org/r/112353 [10:18:20] (03Abandoned) 10Inchikutty: Embedding leaflet maps based on OSM data to UploadWizard [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/109263 (owner: 10Inchikutty) [10:19:31] (03Abandoned) 10Inchikutty: [WIP]UploadWizard:OSM embedding- Geocoding, reverse geocoding [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/112342 (owner: 10Inchikutty) [10:21:07] (03CR) 10Hashar: [C: 031] "Change is fine to me, I am not sure what else is waiting." [extensions/Math] - 10https://gerrit.wikimedia.org/r/112353 (owner: 10Physikerwelt) [10:23:13] (03Abandoned) 10AzaToth: grrrit: Send all bug commits to #wikimedia-dev [labs/tools/grrrit] - 10https://gerrit.wikimedia.org/r/117662 (owner: 10AzaToth) [10:23:52] (03CR) 10Hashar: "That was the last entry for Bug 47063 - Jenkins: Investigate using concurrent builds of the same job" [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/117603 (owner: 10Krinkle) [10:25:50] (03CR) 10Physikerwelt: "I think self-merging changes violates the code review policy..." [extensions/Math] - 10https://gerrit.wikimedia.org/r/112353 (owner: 10Physikerwelt) [10:33:34] (03PS1) 10AzaToth: grrrit: switch default channel [labs/tools/grrrit] - 10https://gerrit.wikimedia.org/r/117839 [10:41:35] (03CR) 10AzaToth: [C: 031] grrrit: switch default channel [labs/tools/grrrit] - 10https://gerrit.wikimedia.org/r/117839 (owner: 10AzaToth) [10:45:02] (03PS16) 10Werdna: Extract wiki and external links, file and template usages from text. [extensions/Flow] - 10https://gerrit.wikimedia.org/r/110090 [10:45:21] (03CR) 10jenkins-bot: [V: 04-1] Extract wiki and external links, file and template usages from text. [extensions/Flow] - 10https://gerrit.wikimedia.org/r/110090 (owner: 10Werdna) [10:46:20] (03CR) 10Werdna: "PS16 updates the tests to pass with the new LinksUpdate method." [extensions/Flow] - 10https://gerrit.wikimedia.org/r/110090 (owner: 10Werdna) [10:48:29] (03PS2) 10Physikerwelt: Add hook documentation [extensions/Math] (dev) - 10https://gerrit.wikimedia.org/r/117836 [10:48:31] (03PS1) 10Physikerwelt: Add hook MathMLChanged [extensions/Math] (dev) - 10https://gerrit.wikimedia.org/r/117840 [10:51:29] (03PS15) 10Inchikutty: UploadWizard: OSM embedding: Geocoding, reverse geocoding [extensions/UploadWizard] (osm) - 10https://gerrit.wikimedia.org/r/116130 [10:51:47] (03CR) 10Physikerwelt: [C: 032] Add hook documentation [extensions/Math] (dev) - 10https://gerrit.wikimedia.org/r/117836 (owner: 10Physikerwelt) [10:52:02] (03CR) 10Physikerwelt: [C: 032] Add hook MathMLChanged [extensions/Math] (dev) - 10https://gerrit.wikimedia.org/r/117840 (owner: 10Physikerwelt) [10:52:10] (03Merged) 10jenkins-bot: Add hook MathMLChanged [extensions/Math] (dev) - 10https://gerrit.wikimedia.org/r/117840 (owner: 10Physikerwelt) [10:54:32] (03PS16) 10Inchikutty: UploadWizard: OSM embedding: Geocoding, reverse geocoding [extensions/UploadWizard] (osm) - 10https://gerrit.wikimedia.org/r/116130 [10:56:56] hey what's the "standard" way to put a link in the middle of an interface message in JS? [10:57:10] Krinkle|detached: ^^ (what's the "standard" way to put a link in the middle of an interface message in JS?) [11:02:55] (03PS1) 10Bartosz Dziewoński: mediawiki.api.watch: Fix promise return value format [core] - 10https://gerrit.wikimedia.org/r/117842 [11:03:12] (03CR) 10Pawanseerwani: "@Foxtrott : At the time of writing the patch, I did not know which table contained exptime column. Now I know it. I will add it in the nex" (031 comment) [core] - 10https://gerrit.wikimedia.org/r/110949 (owner: 10Gerrit Patch Uploader) [11:08:07] (03CR) 10Matthias Mullie: Fix the maintenance script for updating *_user_wiki (031 comment) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/116223 (owner: 10Bsitu) [11:55:07] (03PS3) 10Amire80: Rephrase ep-undelete-course-no-rights [extensions/EducationProgram] - 10https://gerrit.wikimedia.org/r/114449 [11:57:27] (03CR) 10Amire80: "I removed the "a" article. I am trusting a native English speaker." [extensions/EducationProgram] - 10https://gerrit.wikimedia.org/r/114449 (owner: 10Amire80) [12:12:31] (03CR) 10Siebrand: [C: 032] Rephrase ep-undelete-course-no-rights [extensions/EducationProgram] - 10https://gerrit.wikimedia.org/r/114449 (owner: 10Amire80) [12:12:36] (03Merged) 10jenkins-bot: Rephrase ep-undelete-course-no-rights [extensions/EducationProgram] - 10https://gerrit.wikimedia.org/r/114449 (owner: 10Amire80) [12:13:51] uh-oh.... Trouble is here... [12:14:15] (03PS1) 10Werdna: Anonymous editor warning. Now with links to log in and register. [extensions/Flow] - 10https://gerrit.wikimedia.org/r/117846 [12:15:54] surprised anyone? :P [12:31:16] (03PS3) 10Lekshmi: Resetting img alt value as '0' [core] - 10https://gerrit.wikimedia.org/r/116483 [12:31:27] (03Abandoned) 10Helder.wiki: Increase $mChangeLimit from 100 to 500 [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/82229 (owner: 10Helder.wiki) [12:32:11] Apparently the only trouble is with their connection... [12:46:15] (03CR) 10Nikerabbit: Add getRobotPolicy() (031 comment) [core] - 10https://gerrit.wikimedia.org/r/117832 (owner: 10leucosticte) [12:51:13] (03PS4) 10leucosticte: Add getRobotPolicy() [core] - 10https://gerrit.wikimedia.org/r/117832 [12:58:54] (03CR) 10Nikerabbit: "Even if this is in a branch, you should still follow coding conventions. There are many whitespace issues which will need to be fixed befo" [extensions/UploadWizard] (osm) - 10https://gerrit.wikimedia.org/r/116129 (owner: 10Inchikutty) [13:01:41] (03CR) 10Netbrain: "bump! let's try to get this through code review. shal we?" [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/87322 (owner: 10Netbrain) [13:02:02] (03CR) 10Nikerabbit: [C: 031] Add getRobotPolicy() [core] - 10https://gerrit.wikimedia.org/r/117832 (owner: 10leucosticte) [13:02:30] (03CR) 10Nikerabbit: [WIP] LU rewrite (031 comment) [extensions/LocalisationUpdate] (json-rewrite) - 10https://gerrit.wikimedia.org/r/117385 (owner: 10Nikerabbit) [13:26:04] (03PS1) 10Ganeshaditya1: Display a warning when the user name looked up is not registered. [core] - 10https://gerrit.wikimedia.org/r/117854 [13:29:27] Hi, is bug 40942 still open? I saw a patch, but should I edit something in it? [13:31:46] (03CR) 10Ganeshaditya1: "Took a little liberty and prevent the nocontrib message which says "No records found matching these crtieria" from being displayed when th" [core] - 10https://gerrit.wikimedia.org/r/117854 (owner: 10Ganeshaditya1) [13:50:04] @jackmcbarn I made the patch man. Do check it out when you have time. [14:09:20] (03PS5) 10Gerrit Patch Uploader: Clean Timestamp Fields in mysql [core] - 10https://gerrit.wikimedia.org/r/110949 [14:09:22] (03CR) 10Gerrit Patch Uploader: "This commit was uploaded using the Gerrit Patch Uploader [1]." [core] - 10https://gerrit.wikimedia.org/r/110949 (owner: 10Gerrit Patch Uploader) [14:11:21] (03PS1) 10Zfilipin: Moved "I am at a random page" step to the mediawiki_selenium Ruby gem [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/117856 [14:16:44] (03CR) 10Manybubbles: [C: 032] Moved "I am at a random page" step to the mediawiki_selenium Ruby gem [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/117856 (owner: 10Zfilipin) [14:16:50] (03Merged) 10jenkins-bot: Moved "I am at a random page" step to the mediawiki_selenium Ruby gem [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/117856 (owner: 10Zfilipin) [14:42:27] (03CR) 10Reedy: [C: 032] Don't branch skins, SkinPerPage or FormPreloadPostCache extensions [tools/release] - 10https://gerrit.wikimedia.org/r/117812 (owner: 10Reedy) [14:42:30] (03Merged) 10jenkins-bot: Don't branch skins, SkinPerPage or FormPreloadPostCache extensions [tools/release] - 10https://gerrit.wikimedia.org/r/117812 (owner: 10Reedy) [14:42:56] (03PS2) 10Reedy: Remove ContactPageFundraiser [tools/release] - 10https://gerrit.wikimedia.org/r/110293 [14:43:01] (03CR) 10Reedy: [C: 032] Remove ContactPageFundraiser [tools/release] - 10https://gerrit.wikimedia.org/r/110293 (owner: 10Reedy) [14:43:03] (03Merged) 10jenkins-bot: Remove ContactPageFundraiser [tools/release] - 10https://gerrit.wikimedia.org/r/110293 (owner: 10Reedy) [14:51:57] Hey who are the maintainers for the special:contribute page ? [14:55:03] (03PS3) 10Umherirrender: Add CURRENTDAY1/LOCALDAY1 aliases for CURRENTDAY/LOCALDAY [core] - 10https://gerrit.wikimedia.org/r/110705 [14:58:17] (03CR) 10Anomie: "Just tested it, seems to work. I'd +2 once it's rebased." [core] - 10https://gerrit.wikimedia.org/r/110162 (owner: 10TTO) [15:01:09] aditya_: what's that? [15:02:05] (03PS8) 10TTO: Allow additional interwiki prefixes on local interwiki links [core] - 10https://gerrit.wikimedia.org/r/113329 [15:02:59] (03CR) 10jenkins-bot: [V: 04-1] Allow additional interwiki prefixes on local interwiki links [core] - 10https://gerrit.wikimedia.org/r/113329 (owner: 10TTO) [15:05:58] (03PS14) 10Bartosz Dziewoński: Add $wgLocalInterwikis to handle multiple local prefixes [core] - 10https://gerrit.wikimedia.org/r/110162 (owner: 10TTO) [15:06:00] (03PS9) 10Bartosz Dziewoński: Allow additional interwiki prefixes on local interwiki links [core] - 10https://gerrit.wikimedia.org/r/113329 (owner: 10TTO) [15:06:08] (03CR) 10Bartosz Dziewoński: "Rebased with https://github.com/MatmaRex/mediawikireleasenotes-driver: `git pull && git review -d 110162 && git rebase master && git revie" [core] - 10https://gerrit.wikimedia.org/r/110162 (owner: 10TTO) [15:06:50] (03CR) 10Anomie: [C: 032] Let wildcard actions work in list=logevents&leaction= (031 comment) [core] - 10https://gerrit.wikimedia.org/r/117041 (owner: 10Umherirrender) [15:12:13] (03Merged) 10jenkins-bot: Let wildcard actions work in list=logevents&leaction= [core] - 10https://gerrit.wikimedia.org/r/117041 (owner: 10Umherirrender) [15:15:38] (03CR) 10Anomie: [C: 04-1] "These "sites" may be in core, but it seems like they aren't actually used or populated by anything in core. So it seems to me that it bein" [core] - 10https://gerrit.wikimedia.org/r/110427 (owner: 10Addshore) [15:16:44] yikes [15:18:52] (03CR) 10Hoo man: "This will surely get better by -1ing our attempts at upstreaming this!" [core] - 10https://gerrit.wikimedia.org/r/110427 (owner: 10Addshore) [15:20:59] (03PS1) 10Aude: Add script for renaming a user option [core] - 10https://gerrit.wikimedia.org/r/117872 [15:21:40] populate sites needs to be in core [15:21:49] and the other stuffs [15:21:52] yep [15:22:09] but we might need an RfC about that if Anomie dislikes [15:22:16] (03PS1) 10Phuedx: Stop the rightmost toolbar section wrapping [extensions/GettingStarted] - 10https://gerrit.wikimedia.org/r/117874 [15:22:27] we already have rfc [15:22:37] Daniel Friesens? [15:22:43] * 's [15:22:49] https://www.mediawiki.org/wiki/Requests_for_comment/New_sites_system [15:23:08] that one is rather messy IMHO [15:23:35] that's what I meant [15:23:51] (I mean, no surprise if someone isn't aware/doesn't remember it or any interim conclusion about it) [15:31:08] (03PS8) 10Addshore: Implement ApiQuerySites class [core] - 10https://gerrit.wikimedia.org/r/110427 [15:31:32] (03CR) 10Anomie: [C: 031] "Seems to work locally. I left a few nitpicks, but not anything worth not +1ing over." (034 comments) [core] - 10https://gerrit.wikimedia.org/r/117373 (owner: 10Aaron Schulz) [15:31:35] rebasing and fixing the help url [15:33:50] addshore: my commit? thanks [15:34:17] Lloffiwr also drafted an update of two help pages so we should be able to make some links even more useful [15:34:33] Nemo_bis: you commit? :O [15:34:38] *your... [15:34:58] https://gerrit.wikimedia.org/r/83220 [15:35:08] or https://gerrit.wikimedia.org/r/83221 [15:35:24] (03PS9) 10Addshore: Implement ApiQuerySites class [core] - 10https://gerrit.wikimedia.org/r/110427 [15:36:12] * addshore is lost :P [15:36:25] ok, I must be too egocentric :P [15:38:30] :D [15:42:36] (03CR) 10Anomie: "A few nitpicks. Also, the commit summary should probably mention that it's also cleaning up after Ib63f16a8 didn't regenerate equivset.php" (032 comments) [extensions/AntiSpoof] - 10https://gerrit.wikimedia.org/r/117640 (owner: 10Hoo man) [15:45:45] (03CR) 10Anomie: [C: 032] "Thanks. I'm stuck at a library that blocks port 22 (WTF?), so I can't submit anything to Gerrit today." [core] - 10https://gerrit.wikimedia.org/r/110162 (owner: 10TTO) [15:46:18] (03CR) 10Jackmcbarn: [C: 04-1] "You need to add the message to messages.inc. See https://www.mediawiki.org/wiki/Localisation#Adding_new_messages for more details." (034 comments) [core] - 10https://gerrit.wikimedia.org/r/117854 (owner: 10Ganeshaditya1) [15:52:03] (03PS2) 10Hoo man: Map U+200B (zero width space) to an empty string [extensions/AntiSpoof] - 10https://gerrit.wikimedia.org/r/117640 [15:52:11] (03CR) 10Hoo man: Map U+200B (zero width space) to an empty string (032 comments) [extensions/AntiSpoof] - 10https://gerrit.wikimedia.org/r/117640 (owner: 10Hoo man) [15:52:32] @jackmcbarn The mockup for that bug showed that the talk page user page and everything are still displayed inspite of the fact that user doesn't exists [15:52:56] (03CR) 10Hoo man: "Addressed Anomie's comments" [extensions/AntiSpoof] - 10https://gerrit.wikimedia.org/r/117640 (owner: 10Hoo man) [15:53:11] Do you want me to change this bug so that none of that is shown but this message that the user doesn't exists ? [15:54:27] @jackmcbarn. I could like return from the contributionssub function from the place where you marked in the patch. [15:54:58] aditya_sastry: you don't want to return early [15:55:05] you still want to show the whole interface and everything else [15:57:47] (03CR) 10Anomie: [C: 031] "Seems to work. I'd like to see Brion's comment on this though." [core] - 10https://gerrit.wikimedia.org/r/113329 (owner: 10TTO) [15:57:52] @jackmcbarn "For namespacea(talk | block log | uploads | logs)" This interface right ? in that case I guess the place where I have written the code is the best place to put it IMO. [15:58:20] aditya_sastry: see how when a user is blocked, it adds the block notice underneath that, even though it's the same function? just do the same thing [15:58:49] (03CR) 10Anomie: [C: 031] "Looks good to me. Haven't tested." [extensions/AntiSpoof] - 10https://gerrit.wikimedia.org/r/117640 (owner: 10Hoo man) [16:02:51] (03CR) 10KartikMistry: [C: 031] "LGTM." [core] - 10https://gerrit.wikimedia.org/r/114713 (owner: 10Amire80) [16:03:36] (03CR) 10Anomie: "Personally, I'd like to see any core callers cleaned up to expect titles, and a warning logged for the deprecated syntax so userscripts ca" [core] - 10https://gerrit.wikimedia.org/r/117842 (owner: 10Bartosz Dziewoński) [16:05:38] (03PS1) 10Bencmq: [WIP] Browser test for Thank feature in Flow [extensions/Flow] - 10https://gerrit.wikimedia.org/r/117882 [16:11:07] (03CR) 10Bencmq: "This is still not complete, so I would really appreciate some feedback." (032 comments) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/117882 (owner: 10Bencmq) [16:13:35] (03CR) 10Eranroz: "I think the only "core caller" is mediawiki.page.watch.ajax.js" (031 comment) [core] - 10https://gerrit.wikimedia.org/r/117842 (owner: 10Bartosz Dziewoński) [16:15:10] (03PS1) 10Hashar: Adding more extensions [extensions] - 10https://gerrit.wikimedia.org/r/117883 [16:15:15] (03CR) 10Halfak: "Re. "suppressed"" [extensions/WikimediaEvents] - 10https://gerrit.wikimedia.org/r/117643 (owner: 10Mattflaschen) [16:15:25] (03CR) 10Hashar: [C: 032 V: 032] Adding more extensions [extensions] - 10https://gerrit.wikimedia.org/r/117883 (owner: 10Hashar) [16:16:51] (03CR) 10Anomie: [C: 031] "Works locally. I'd like Chris to double-check the change to $preventLog behavior in SpamBlacklist_body.php though." (031 comment) [extensions/SpamBlacklist] - 10https://gerrit.wikimedia.org/r/117231 (owner: 10Jackmcbarn) [16:20:31] (03PS3) 10Bartosz Dziewoński: Check validity and availability of usernames during signup via AJAX [core] - 10https://gerrit.wikimedia.org/r/117437 [16:21:13] (03PS2) 10Bencmq: [WIP] Browser test for Thank feature in Flow [extensions/Flow] - 10https://gerrit.wikimedia.org/r/117882 [16:21:21] (03CR) 10Bartosz Dziewoński: "Ori, I implemented your idea, but without caching (per what I grumbled aboutm it's debounced already and that should be enough) and with ." [core] - 10https://gerrit.wikimedia.org/r/117437 (owner: 10Bartosz Dziewoński) [16:23:12] (03CR) 10Bartosz Dziewoński: "Core callers should be fixed, but we shouldn't break compatibility of this module anyway, IMO. I went with the minimal patch for now :)" [core] - 10https://gerrit.wikimedia.org/r/117842 (owner: 10Bartosz Dziewoński) [16:23:19] (03CR) 10Bencmq: "Two questions posted as inline comments in pset 1" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/117882 (owner: 10Bencmq) [16:23:43] (03CR) 10Bartosz Dziewoński: mediawiki.api.watch: Fix promise return value format (031 comment) [core] - 10https://gerrit.wikimedia.org/r/117842 (owner: 10Bartosz Dziewoński) [16:24:20] (03CR) 10Bartosz Dziewoński: "(Whoops, it seems my master contained some unexpected things and I accidentally added dependencies. Sorry!)" [core] - 10https://gerrit.wikimedia.org/r/110162 (owner: 10TTO) [16:29:45] (03CR) 10Anomie: [C: 031] "Seems to work, but not merging until Hoo's suggestion is discussed." (031 comment) [extensions/Scribunto] - 10https://gerrit.wikimedia.org/r/109262 (owner: 10TheDJ) [16:31:24] (03CR) 10Anomie: mediawiki.api.watch: Fix promise return value format (031 comment) [core] - 10https://gerrit.wikimedia.org/r/117842 (owner: 10Bartosz Dziewoński) [16:31:30] (03CR) 10Greg Grossmeier: [C: 031] "+1 for getting this fixed in the minimal way before tomorrow (with a backport to wmf17)." [core] - 10https://gerrit.wikimedia.org/r/117842 (owner: 10Bartosz Dziewoński) [16:45:54] (03CR) 10Anomie: Extract wiki and external links, file and template usages from text. (031 comment) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/110090 (owner: 10Werdna) [16:46:57] (03CR) 10Anomie: "This seems like a good approach." (032 comments) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/110090 (owner: 10Werdna) [16:51:08] (03PS1) 10UltrasonicNXT: Fix errors caused by offline users having no away entry [extensions/MediaWikiChat] - 10https://gerrit.wikimedia.org/r/117890 [16:52:24] (03CR) 10Helder.wiki: "See also bug 2522." [core] - 10https://gerrit.wikimedia.org/r/110705 (owner: 10Umherirrender) [16:52:36] (03CR) 10UltrasonicNXT: [C: 032 V: 032] Fix errors caused by offline users having no away entry [extensions/MediaWikiChat] - 10https://gerrit.wikimedia.org/r/117890 (owner: 10UltrasonicNXT) [16:52:42] (03CR) 10Hashar: "foo" [extensions] - 10https://gerrit.wikimedia.org/r/117883 (owner: 10Hashar) [16:53:27] (03CR) 10Hashar: "foo" [extensions] - 10https://gerrit.wikimedia.org/r/117883 (owner: 10Hashar) [16:54:07] (03CR) 10Halfak: [C: 031] "Tested regular creation, move and move without redirect. Checked logged JSON against schema: https://meta.wikimedia.org/w/index.php?title" [extensions/WikimediaEvents] - 10https://gerrit.wikimedia.org/r/117643 (owner: 10Mattflaschen) [17:00:19] I notice there are a lot of grrrit-wm spam here; what you think about setting default channel to #wikimedia-feed instead? [17:00:58] which will make all extension commits which have no own channel set to go there instead of here [17:00:58] AzaToth: There'll be noise about it [17:01:12] (03PS1) 10Hashar: Allow postmerge pipeline to report in Gerrit [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/117893 [17:01:24] (03CR) 10Hashar: [C: 032] Allow postmerge pipeline to report in Gerrit [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/117893 (owner: 10Hashar) [17:01:29] And anyway there's nobody in there. :P [17:01:29] (03Merged) 10jenkins-bot: Allow postmerge pipeline to report in Gerrit [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/117893 (owner: 10Hashar) [17:01:44] rdwrer: heh, yea, that channel doesn't exists yet [17:02:00] AzaToth: I'd suggest sending messages both places for a while, especially mediawiki/core commits [17:02:05] But ideally all [17:02:10] rdwrer: at the moment, default channel is this one [17:02:14] I know [17:02:42] zz_yuvipanda, legoktm, aude - as people who help maintain grrrit-wm, you should maybe be aware that we're talking about moving the default channel to -feed [17:02:43] mediawiki/core stuff will go here [17:03:05] https://bugzilla.wikimedia.org/show_bug.cgi?id=62474 [17:03:15] made a buggie for it and a patchie [17:03:26] rdwrer: :/ [17:03:33] TIL AzaToth's name. [17:03:39] :-P [17:03:54] rdwrer: I assume you are Mark H :-P [17:03:54] * aude likes seeing the commits here, even if it's a bit noisy sometimes [17:04:03] I am [17:04:06] So says WHOIS [17:04:14] aude: even for non-descript extension commits? [17:04:19] Real names are silly anyway [17:04:58] AzaToth: at least deployed extensions, i like to see what is changing [17:05:17] Do we have a good list of those? (greg-g?) [17:05:18] (03PS1) 10Hashar: Add #wikimedia-qa in footers [integration/docroot] - 10https://gerrit.wikimedia.org/r/117894 [17:05:21] aude: https://gerrit.wikimedia.org/r/#/c/117839/1/config.yaml [17:05:31] line 47 [17:05:32] rdwrer: of deployed extensions (on wmf servers)? [17:05:34] (03CR) 10Hashar: [C: 032] Add #wikimedia-qa in footers [integration/docroot] - 10https://gerrit.wikimedia.org/r/117894 (owner: 10Hashar) [17:05:37] (03Merged) 10jenkins-bot: Add #wikimedia-qa in footers [integration/docroot] - 10https://gerrit.wikimedia.org/r/117894 (owner: 10Hashar) [17:05:39] extension-list ? [17:05:41] Yeah [17:05:54] yeah, extension-list is the non-friendly but completely accurate source [17:06:19] extension-list? [17:06:30] although there is some stuff like mobile frontend or wikibase extensions that don't have changes reported here [17:06:32] there's also https://www.mediawiki.org/wiki/Category:Extensions_used_on_Wikimedia which is non-canonical [17:06:34] We could probably throw it through a few transformations and be done [17:06:52] might be difficult to maintain such list for grrrrt [17:06:56] aude: config.yaml can always be updated :-P [17:06:59] AzaToth: ok [17:08:34] aude: https://gerrit.wikimedia.org/r/#/c/116996/3 adds posibility to filter per branch, so if you want, it can be made so only commits to certain branches ends up here [17:11:45] i don't have huge preference and if people prefer some of the noise elsewhere [17:16:00] (03CR) 10Krinkle: [C: 04-1] "Why does this depend on I2ac9e0da0f1c8?" [core] - 10https://gerrit.wikimedia.org/r/110162 (owner: 10TTO) [17:16:35] (03PS2) 10Bartosz Dziewoński: mediawiki.api.watch: Fix promise return value format [core] - 10https://gerrit.wikimedia.org/r/117842 [17:22:50] aude: if you think the grrrit commits are sound, would you merge them? [17:23:00] can't +2 myself [17:27:38] rdwrer: hmm? 'default channel'? [17:27:45] rdwrer: -feed already has all [17:28:03] YuviPanda: I disagree, -feed didn't exist until we created it just now [17:28:10] rdwrer: #mediawiki-feed [17:28:11] ? [17:28:15] Oh, no, wikimedia [17:28:30] AzaToth: ^^ [17:28:32] rdwrer: #mediawiki-feed has all changes, Nemo_bis made me do it : [17:28:45] (03CR) 10Krinkle: "@MatmaRex: I don't like the return value as an array. Makes it hard to use (requires looping to find the right one etc.). Any ideas? Conve" [core] - 10https://gerrit.wikimedia.org/r/117842 (owner: 10Bartosz Dziewoński) [17:28:49] But then non-mediawiki things will go there [17:29:00] rdwrer: yeah, it's 'all the things' [17:29:45] YuviPanda: Even things with other places to go, right? [17:30:01] Because if so I can totally ignore grrrit-wm in other channels which would actually be sorta nice [17:30:29] <^d> lol bot bikesheds. [17:31:09] (03CR) 10Isarra: [C: 031] "Yes." [core] - 10https://gerrit.wikimedia.org/r/117806 (owner: 10Jack Phoenix) [17:31:22] lolbot. [17:31:33] rdwrer: yeap, it is literally all the feeds [17:31:34] rdwrer: yea, atm everything goes to #mediawiki-feed and anything not spedified goes here [17:31:46] Cool [17:31:53] * rdwrer sets about ignoring bots [17:31:59] <^d> I got 99 problems but irc bots ain't one. [17:32:04] but a lot of fringe extension goes here [17:32:29] ^d: I assume you never complained about bot spam [17:32:54] or ignoring a channel because it's too noisy [17:33:12] <^d> Maybe and no, in that order. [17:33:27] <^d> (Maybe, but definitely not anymore. If a bot annoys me I /ignore it and don't bother anyone else) [17:34:24] ^d: as I heard hashar planned to leave this channel because it have become too spammy, I though it might be a good idea to reduce the spam [17:36:17] (03PS7) 10Jackmcbarn: Allow moving category pages [core] - 10https://gerrit.wikimedia.org/r/111096 [17:43:55] rdwrer: AzaToth fwiw, I've no opinion on where grrrit-wm is as long as it is somewhere : [17:44:14] somewhere :? [17:44:24] as in, as long as we don't kill it completely [17:44:29] ah [17:44:39] AzaToth: I'll look at your patches in a few mins now. [17:44:43] started to wonder where colon is ツ [17:47:36] AzaToth: heh. for some reason typing the 'zero' character in my laptop increases the brightness. need to restart laptop to check [17:47:37] brb [17:48:42] Wow [17:49:38] (03PS3) 10Krinkle: mediawiki.api.watch: Fix promise return value format [core] - 10https://gerrit.wikimedia.org/r/117842 (owner: 10Bartosz Dziewoński) [17:50:23] hehe [17:50:56] (03CR) 10Krinkle: [C: 032] "@MatmaRex: I'm forging ahead on this one without the other patch. I'd prefer we come up with a better way since imho replacing this with a" [core] - 10https://gerrit.wikimedia.org/r/117842 (owner: 10Bartosz Dziewoński) [17:54:28] (03PS1) 10Chad: Missing exception import: PartialShardFailureException [extensions/Elastica] - 10https://gerrit.wikimedia.org/r/117899 [17:54:34] (03Merged) 10jenkins-bot: mediawiki.api.watch: Fix promise return value format [core] - 10https://gerrit.wikimedia.org/r/117842 (owner: 10Bartosz Dziewoński) [17:54:45] (03CR) 10Ori.livneh: [C: 032] Log automatic creation of a redirect as a PageCreation [extensions/WikimediaEvents] - 10https://gerrit.wikimedia.org/r/117643 (owner: 10Mattflaschen) [17:55:07] (03PS1) 10Krinkle: mediawiki.api.watch: Fix promise return value format [core] (wmf/1.23wmf17) - 10https://gerrit.wikimedia.org/r/117900 [17:55:12] (03CR) 10Manybubbles: [C: 032 V: 032] Missing exception import: PartialShardFailureException [extensions/Elastica] - 10https://gerrit.wikimedia.org/r/117899 (owner: 10Chad) [17:55:40] (03CR) 10Krinkle: [C: 031] "To be deployed in a few minutes." [core] (wmf/1.23wmf17) - 10https://gerrit.wikimedia.org/r/117900 (owner: 10Krinkle) [17:55:54] AzaToth: heh, turns out when I was sleeping hugging the keyboard in the train journey, it somehow decided to program itself for '0' to be 'increase brightness' [17:56:01] AzaToth: I reset it now, but have to redo my customizations [17:56:32] (03Merged) 10jenkins-bot: Log automatic creation of a redirect as a PageCreation [extensions/WikimediaEvents] - 10https://gerrit.wikimedia.org/r/117643 (owner: 10Mattflaschen) [17:57:18] (03PS8) 10AndyRussG: Add minimal dependency injection, including tests [extensions/Campaigns] (wip/editorcampaigns) - 10https://gerrit.wikimedia.org/r/116153 [17:57:32] (03PS2) 10Bsitu: Add summary revision type [extensions/Flow] - 10https://gerrit.wikimedia.org/r/117357 [17:57:36] (03PS3) 10Mwalker: Image files so we stop getting useless errors [core] (fundraising/REL1_22) - 10https://gerrit.wikimedia.org/r/117622 [17:58:44] (03CR) 10Awjrichards: [C: 031] Improve error handling in PHP part [extensions/Minifier] - 10https://gerrit.wikimedia.org/r/114936 (owner: 10MaxSem) [17:58:47] (03PS1) 10Chad: Updating Elastica to master (missing class import) [core] (wmf/1.23wmf17) - 10https://gerrit.wikimedia.org/r/117902 [17:59:47] (03CR) 10jenkins-bot: [V: 04-1] Add summary revision type [extensions/Flow] - 10https://gerrit.wikimedia.org/r/117357 (owner: 10Bsitu) [17:59:53] (03CR) 10AndyRussG: "Made Setup non-static. With staticness tests were being contaminated by calls in Campaigns.php and in other tests." [extensions/Campaigns] (wip/editorcampaigns) - 10https://gerrit.wikimedia.org/r/116153 (owner: 10AndyRussG) [17:59:55] (03PS2) 10Ganeshaditya1: Display a warning when the user name looked up is not registered. [core] - 10https://gerrit.wikimedia.org/r/117854 [18:01:02] (03CR) 10Chad: [C: 032 V: 032] Updating Elastica to master (missing class import) [core] (wmf/1.23wmf17) - 10https://gerrit.wikimedia.org/r/117902 (owner: 10Chad) [18:01:09] (03CR) 10Krinkle: [C: 032] mediawiki.api.watch: Fix promise return value format [core] (wmf/1.23wmf17) - 10https://gerrit.wikimedia.org/r/117900 (owner: 10Krinkle) [18:01:48] (03CR) 10jenkins-bot: [V: 04-1] Display a warning when the user name looked up is not registered. [core] - 10https://gerrit.wikimedia.org/r/117854 (owner: 10Ganeshaditya1) [18:02:16] YuviPanda: haha [18:02:49] (03PS1) 10Jdlrobson: WIP: Rewrite the navigation links under the heading [extensions/VectorBeta] - 10https://gerrit.wikimedia.org/r/117903 [18:03:37] (03PS1) 10Jdlrobson: Add prebodytext template variable [core] - 10https://gerrit.wikimedia.org/r/117904 [18:04:32] (03PS3) 10Ganeshaditya1: Display a warning when the user name looked up is not registered. [core] - 10https://gerrit.wikimedia.org/r/117854 [18:06:18] (03CR) 10jenkins-bot: [V: 04-1] Display a warning when the user name looked up is not registered. [core] - 10https://gerrit.wikimedia.org/r/117854 (owner: 10Ganeshaditya1) [18:07:32] (03PS7) 10Jackmcbarn: Support searching for multiple filter IDs [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/105617 [18:09:21] (03Merged) 10jenkins-bot: mediawiki.api.watch: Fix promise return value format [core] (wmf/1.23wmf17) - 10https://gerrit.wikimedia.org/r/117900 (owner: 10Krinkle) [18:10:09] (03CR) 10AndyRussG: "Keeping this as "WIP" until persistence classes are done, since the changes have to coordinate but stay separate." [extensions/Campaigns] - 10https://gerrit.wikimedia.org/r/117825 (owner: 10AndyRussG) [18:10:52] (03CR) 10EBernhardson: [C: 032] Fix editing header on untouched page. [extensions/Flow] - 10https://gerrit.wikimedia.org/r/117819 (owner: 10Werdna) [18:11:05] (03Merged) 10jenkins-bot: Fix editing header on untouched page. [extensions/Flow] - 10https://gerrit.wikimedia.org/r/117819 (owner: 10Werdna) [18:11:08] (03PS4) 10Ganeshaditya1: Display a warning when the user name looked up is not registered. [core] - 10https://gerrit.wikimedia.org/r/117854 [18:11:25] (03CR) 10EBernhardson: [C: 032] "We should probably just create some UserTuple class or whatever that holds the three identifying properties" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/117820 (owner: 10Werdna) [18:12:02] (03PS2) 10Bsitu: Fix the maintenance script for updating *_user_wiki [extensions/Flow] - 10https://gerrit.wikimedia.org/r/116223 [18:12:25] (03CR) 10jenkins-bot: [V: 04-1] Fix Header::create, which now needs to set ->userWiki because of I439b102e9125c4e6aed988032a21d51b1079f93b [extensions/Flow] - 10https://gerrit.wikimedia.org/r/117820 (owner: 10Werdna) [18:14:00] (03PS1) 10AndyRussG: WIP Schema change: create tables [extensions/Campaigns] (wip/editorcampaigns) - 10https://gerrit.wikimedia.org/r/117905 [18:14:08] (03PS2) 10Werdna: Fix Header::create, which now needs to set ->userWiki because of I439b102e9125c4e6aed988032a21d51b1079f93b [extensions/Flow] - 10https://gerrit.wikimedia.org/r/117820 [18:14:14] (03CR) 10EBernhardson: [C: 032] Fix Header::create, which now needs to set ->userWiki because of I439b102e9125c4e6aed988032a21d51b1079f93b [extensions/Flow] - 10https://gerrit.wikimedia.org/r/117820 (owner: 10Werdna) [18:14:22] (03CR) 10jenkins-bot: [V: 04-1] Fix Header::create, which now needs to set ->userWiki because of I439b102e9125c4e6aed988032a21d51b1079f93b [extensions/Flow] - 10https://gerrit.wikimedia.org/r/117820 (owner: 10Werdna) [18:15:31] (03CR) 10Jdlrobson: [C: 032] Improve error handling in PHP part [extensions/Minifier] - 10https://gerrit.wikimedia.org/r/114936 (owner: 10MaxSem) [18:16:25] (03Abandoned) 10AndyRussG: WIP Schema change: create tables [extensions/Campaigns] - 10https://gerrit.wikimedia.org/r/117825 (owner: 10AndyRussG) [18:17:34] (03CR) 10Jackmcbarn: [C: 04-1] Display a warning when the user name looked up is not registered. (032 comments) [core] - 10https://gerrit.wikimedia.org/r/117854 (owner: 10Ganeshaditya1) [18:17:47] (03PS17) 10Inchikutty: UploadWizard: OSM embedding: Geocoding, reverse geocoding [extensions/UploadWizard] (osm) - 10https://gerrit.wikimedia.org/r/116130 [18:18:53] @jackmcbarn I am not done yet. I mixed up two commits sorry. [18:19:05] that's fine, just re-upload when you are done [18:20:02] (03CR) 10Jdlrobson: [C: 031] "Looks fine. Would +2 but I can't setup locally. Ping me on irc..!" [extensions/Minifier] - 10https://gerrit.wikimedia.org/r/114936 (owner: 10MaxSem) [18:20:56] (03CR) 10Greg Grossmeier: "Multimedia team: Adding you here for your input/attention as appropriate." [extensions/PagedTiffHandler] - 10https://gerrit.wikimedia.org/r/86413 (owner: 10Brian Wolff) [18:25:21] (03PS3) 10EBernhardson: Fix Header::create, which now needs to set ->userWiki because of I439b102e9125c4e6aed988032a21d51b1079f93b [extensions/Flow] - 10https://gerrit.wikimedia.org/r/117820 (owner: 10Werdna) [18:25:30] (03CR) 10EBernhardson: [C: 032] Fix Header::create, which now needs to set ->userWiki because of I439b102e9125c4e6aed988032a21d51b1079f93b [extensions/Flow] - 10https://gerrit.wikimedia.org/r/117820 (owner: 10Werdna) [18:25:44] (03Merged) 10jenkins-bot: Fix Header::create, which now needs to set ->userWiki because of I439b102e9125c4e6aed988032a21d51b1079f93b [extensions/Flow] - 10https://gerrit.wikimedia.org/r/117820 (owner: 10Werdna) [18:37:14] (03CR) 10Ssmith: [C: 032 V: 032] Image files so we stop getting useless errors [core] (fundraising/REL1_22) - 10https://gerrit.wikimedia.org/r/117622 (owner: 10Mwalker) [18:40:38] (03PS5) 10Ganeshaditya1: Display a warning when the user name looked up is not registered. [core] - 10https://gerrit.wikimedia.org/r/117854 [18:40:57] @jackmcbarn done ! is it good ? [18:41:06] (03CR) 10Jdlrobson: [C: 032 V: 032] Improve error handling in PHP part [extensions/Minifier] - 10https://gerrit.wikimedia.org/r/114936 (owner: 10MaxSem) [18:42:44] (03CR) 10Jdlrobson: [C: 032 V: 032] Handle exceptions gracefully [extensions/Minifier] - 10https://gerrit.wikimedia.org/r/114891 (owner: 10MaxSem) [18:42:58] (03PS15) 10TTO: Add $wgLocalInterwikis to handle multiple local prefixes [core] - 10https://gerrit.wikimedia.org/r/110162 [18:43:03] (03CR) 10Jdlrobson: [C: 04-1] JSON statistics (031 comment) [extensions/Minifier] - 10https://gerrit.wikimedia.org/r/114903 (owner: 10MaxSem) [18:43:17] @jackmcbarn sorry forgot to remove the variable from the return statement arghhhhhhhhh this is so frustrating [18:43:49] (03CR) 10Bartosz Dziewoński: "Because my master was not gerrit/master. Sorry." [core] - 10https://gerrit.wikimedia.org/r/110162 (owner: 10TTO) [18:44:43] (03CR) 10Siebrand: [C: 031] "i18n/L10n reviewed." [core] - 10https://gerrit.wikimedia.org/r/111096 (owner: 10Jackmcbarn) [18:45:06] (03CR) 10Jdlrobson: [C: 04-1] "Feel free to disagree and remove my -1 but I think an array would be better here :)" (031 comment) [extensions/Minifier] - 10https://gerrit.wikimedia.org/r/114933 (owner: 10MaxSem) [18:45:50] (03PS6) 10Ganeshaditya1: Display a warning when the user name looked up is not registered. [core] - 10https://gerrit.wikimedia.org/r/117854 [18:46:17] (03CR) 10Siebrand: [C: 032] Add a link to Special:WhatLinksHere in deleting-backlinks-warning [core] - 10https://gerrit.wikimedia.org/r/114713 (owner: 10Amire80) [18:47:52] @jackmcbarn check it out done now !! [18:47:57] looking... [18:50:28] (03Merged) 10jenkins-bot: Add a link to Special:WhatLinksHere in deleting-backlinks-warning [core] - 10https://gerrit.wikimedia.org/r/114713 (owner: 10Amire80) [18:54:03] (03CR) 10Jackmcbarn: Display a warning when the user name looked up is not registered. (032 comments) [core] - 10https://gerrit.wikimedia.org/r/117854 (owner: 10Ganeshaditya1) [18:58:51] (03PS7) 10Ganeshaditya1: Display a warning when the user name looked up is not registered. [core] - 10https://gerrit.wikimedia.org/r/117854 [19:01:22] @jackmcbarn Sorry about the braces .. Do check it out now ... [19:02:49] (03CR) 10Mattflaschen: "I also agree with and support the decision on changing the MW core password length to 6. I see no reason to remove it from the patch." [core] - 10https://gerrit.wikimedia.org/r/117635 (owner: 10CSteipp) [19:03:02] aditya_sastry: looks fine to me [19:03:27] (03PS6) 10BryanDavis: Convert sync-wikiversions to python [tools/scap] - 10https://gerrit.wikimedia.org/r/116918 [19:03:33] (03CR) 10Siebrand: [C: 04-1] "L10n reviewed." (031 comment) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/117846 (owner: 10Werdna) [19:04:11] @jackmcbarn phew.. sorry man it took so many iterations. Is there like a page documenting the important classes and methods. I feel like a idiot randomly trying out these methods .. [19:09:14] (03CR) 10EBernhardson: "Its likely not worth complicating this with those concerns until flow supports categorization." [extensions/SpamBlacklist] - 10https://gerrit.wikimedia.org/r/117231 (owner: 10Jackmcbarn) [19:11:32] (03CR) 10Isarra: "Should be able to unless the tarballs are explicitly created to exclude them or something." [core] - 10https://gerrit.wikimedia.org/r/114984 (owner: 10Bartosz Dziewoński) [19:12:50] @jackmcbarn aren't you going to merge it ? [19:13:02] aditya_sastry: i can't. you have to wait for someone who can [19:13:24] @jackmcbarn do I need to add more reviewers ? [19:13:34] aditya_sastry: no, you have enough. one of them should see it soon [19:13:48] @jackmcbarn thanks man. [19:13:54] np [19:15:55] (03PS1) 10Krinkle: mediawiki.api.watch: Don't use deprecated 'title' parameter [core] - 10https://gerrit.wikimedia.org/r/117912 [19:17:50] (03PS2) 10Jackmcbarn: Categorize pages containing blacklisted links [extensions/SpamBlacklist] - 10https://gerrit.wikimedia.org/r/117231 [19:18:16] (03CR) 10Krinkle: mediawiki.api: Use Promise.then instead of manual Deferred wrapping (031 comment) [core] - 10https://gerrit.wikimedia.org/r/116957 (owner: 10Krinkle) [19:18:26] (03CR) 10Bartosz Dziewoński: "Krinkle:" [core] - 10https://gerrit.wikimedia.org/r/117842 (owner: 10Bartosz Dziewoński) [19:19:18] Krinkle: ha, nice timing [19:19:22] thanks :D [19:20:23] (03CR) 10Krinkle: "Yeah, I've come back from thinking arrays are a pain to deal with. It requires a loop or iteration of some kind no matter how you present " [core] - 10https://gerrit.wikimedia.org/r/117842 (owner: 10Bartosz Dziewoński) [19:20:59] (03CR) 10jenkins-bot: [V: 04-1] mediawiki.api.watch: Don't use deprecated 'title' parameter [core] - 10https://gerrit.wikimedia.org/r/117912 (owner: 10Krinkle) [19:21:01] (03CR) 10Bartosz Dziewoński: Check validity and availability of usernames during signup via AJAX (031 comment) [core] - 10https://gerrit.wikimedia.org/r/117437 (owner: 10Bartosz Dziewoński) [19:21:56] (03PS2) 10Krinkle: mediawiki.api.watch: Don't use deprecated 'title' parameter [core] - 10https://gerrit.wikimedia.org/r/117912 [19:22:51] (03CR) 10Bartosz Dziewoński: mediawiki.api.watch: Don't use deprecated 'title' parameter (031 comment) [core] - 10https://gerrit.wikimedia.org/r/117912 (owner: 10Krinkle) [19:23:35] (03PS1) 10Umherirrender: Adjust description of ApiWikiLoveImageLog [extensions/WikiLove] - 10https://gerrit.wikimedia.org/r/117914 [19:24:56] (03PS1) 10Krinkle: mediawiki.api.watch: Don't use deprecated 'title' parameter [core] - 10https://gerrit.wikimedia.org/r/117915 [19:25:18] (03Abandoned) 10Krinkle: mediawiki.api.watch: Don't use deprecated 'title' parameter [core] - 10https://gerrit.wikimedia.org/r/117915 (owner: 10Krinkle) [19:25:32] (03PS3) 10Krinkle: mediawiki.api.watch: Don't use deprecated 'title' parameter [core] - 10https://gerrit.wikimedia.org/r/117912 [19:25:37] (03CR) 10Krinkle: mediawiki.api.watch: Don't use deprecated 'title' parameter (031 comment) [core] - 10https://gerrit.wikimedia.org/r/117912 (owner: 10Krinkle) [19:30:07] (03CR) 10Hoo man: [C: 04-1] "didn't yet look at the tests" (032 comments) [core] - 10https://gerrit.wikimedia.org/r/117872 (owner: 10Aude) [19:34:15] (03CR) 10Krinkle: [C: 04-1] "Should there be requirements as to when the script is ran (e.g. before or after the software change, could do validation of there being a " [core] - 10https://gerrit.wikimedia.org/r/117872 (owner: 10Aude) [19:36:52] (03CR) 10Kaldari: [C: 04-1] Adjust description of ApiWikiLoveImageLog (031 comment) [extensions/WikiLove] - 10https://gerrit.wikimedia.org/r/117914 (owner: 10Umherirrender) [19:36:55] (03CR) 10Krinkle: "Works for me, but want some confirmation on the implementation for 'escaped' that looks rather suspicious." (031 comment) [core] - 10https://gerrit.wikimedia.org/r/113307 (owner: 10Bartosz Dziewoński) [19:42:38] (03PS2) 10Umherirrender: Adjust description of ApiWikiLoveImageLog [extensions/WikiLove] - 10https://gerrit.wikimedia.org/r/117914 [19:43:34] (03CR) 10Umherirrender: "Patch Set 2: Added verb" (031 comment) [extensions/WikiLove] - 10https://gerrit.wikimedia.org/r/117914 (owner: 10Umherirrender) [19:44:18] (03CR) 10JGonera: "I don't think this will be a problem since width depends on button's caption. I'll ask Jared to be sure." [core] - 10https://gerrit.wikimedia.org/r/117107 (owner: 10JGonera) [19:46:20] (03CR) 10Krinkle: "I get a call inside the method yes, but wasn't getting anything inside the loop. Found a few ones though. Put an error_log$match['file'][0" [core] - 10https://gerrit.wikimedia.org/r/115895 (owner: 10Bartosz Dziewoński) [19:47:52] (03CR) 10Krinkle: [C: 032] CSSMin: Don't do file_exists on random data in getLocalFileReferences() [core] - 10https://gerrit.wikimedia.org/r/115895 (owner: 10Bartosz Dziewoński) [19:48:26] (03PS4) 10Bartosz Dziewoński: CSSMin: Don't do file_exists on random data in getLocalFileReferences() [core] - 10https://gerrit.wikimedia.org/r/115895 [19:48:42] MatmaRex: Could you add release notes for that bug fix? ^ [19:49:30] Krinkle: sure, in a minute [19:54:40] csteipp: if I send an email to announce now, can you approve? [19:55:14] (03PS5) 10Bartosz Dziewoński: CSSMin: Don't do file_exists on random data in getLocalFileReferences() [core] - 10https://gerrit.wikimedia.org/r/115895 [19:55:26] Krinkle: good enough i hope ^ [19:55:27] Reedy: could you approve an announce email? [19:57:34] (03CR) 10Gergő Tisza: [C: 032] UploadWizard: OSM embedding: Geocoding, reverse geocoding [extensions/UploadWizard] (osm) - 10https://gerrit.wikimedia.org/r/116130 (owner: 10Inchikutty) [19:57:45] (03Merged) 10jenkins-bot: UploadWizard: OSM embedding: Geocoding, reverse geocoding [extensions/UploadWizard] (osm) - 10https://gerrit.wikimedia.org/r/116130 (owner: 10Inchikutty) [19:58:27] (03CR) 10EBernhardson: [C: 032] Turn on logging for unexpected exceptions [extensions/Flow] - 10https://gerrit.wikimedia.org/r/117451 (owner: 10Bsitu) [19:59:09] (03Merged) 10jenkins-bot: Turn on logging for unexpected exceptions [extensions/Flow] - 10https://gerrit.wikimedia.org/r/117451 (owner: 10Bsitu) [20:00:00] (03PS1) 10Aaron Schulz: Further optimize User::saveOptions() by doing deletes by PRIMARY KEY [core] - 10https://gerrit.wikimedia.org/r/117921 [20:00:52] (03CR) 10Krinkle: [C: 032] CSSMin: Don't do file_exists on random data in getLocalFileReferences() [core] - 10https://gerrit.wikimedia.org/r/115895 (owner: 10Bartosz Dziewoński) [20:04:47] (03Merged) 10jenkins-bot: CSSMin: Don't do file_exists on random data in getLocalFileReferences() [core] - 10https://gerrit.wikimedia.org/r/115895 (owner: 10Bartosz Dziewoński) [20:09:58] (03CR) 10EBernhardson: [WIP]flow_revision - add new column rev_type_id (033 comments) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/116861 (owner: 10Bsitu) [20:14:46] (03CR) 10Mattflaschen: [C: 04-1] "Phuedx is doing the arrow thing in a followup (already chained)." [extensions/GettingStarted] - 10https://gerrit.wikimedia.org/r/115176 (owner: 10Phuedx) [20:16:09] (03CR) 10EBernhardson: [C: 031] "havn't tried it, looks like it should work." [extensions/Flow] - 10https://gerrit.wikimedia.org/r/116874 (owner: 10Bsitu) [20:22:04] (03PS6) 10UltrasonicNXT: WIP - Rewrite [extensions/WikiForum] - 10https://gerrit.wikimedia.org/r/116258 [20:22:45] (03CR) 10Mattflaschen: "It looks like the same is true for print." [extensions/GettingStarted] - 10https://gerrit.wikimedia.org/r/115176 (owner: 10Phuedx) [20:25:49] (03CR) 10Hoo man: Further optimize User::saveOptions() by doing deletes by PRIMARY KEY (031 comment) [core] - 10https://gerrit.wikimedia.org/r/117921 (owner: 10Aaron Schulz) [20:27:14] (03PS1) 10Umherirrender: Add final period to API module descriptions [extensions/CodeReview] - 10https://gerrit.wikimedia.org/r/117925 [20:28:03] (03CR) 10Hashar: [C: 04-1] "Wikibugs is abandon ware. It is hooked directly on one of our mail server and ops want to get rid of that design/architecture, for example" [wikimedia/bugzilla/wikibugs] - 10https://gerrit.wikimedia.org/r/104199 (owner: 10Merlijn van Deen) [20:30:26] (03CR) 10Hashar: "#mediawiki suffered from much spam and the bot got moved to #wikimedia-dev which is not being unusable during peak hours. So yeah moving " [labs/tools/grrrit] - 10https://gerrit.wikimedia.org/r/117839 (owner: 10AzaToth) [20:41:09] (03CR) 10EBernhardson: Update post/header revisions storage lookup key (033 comments) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/117099 (owner: 10Bsitu) [20:42:33] (03PS3) 10Bsitu: Add summary revision type [extensions/Flow] - 10https://gerrit.wikimedia.org/r/117357 [20:50:11] (03CR) 10Aaron Schulz: Further optimize User::saveOptions() by doing deletes by PRIMARY KEY (031 comment) [core] - 10https://gerrit.wikimedia.org/r/117921 (owner: 10Aaron Schulz) [20:51:38] (03PS2) 10Jdlrobson: WIP: Rewrite the navigation links under the heading [extensions/VectorBeta] - 10https://gerrit.wikimedia.org/r/117903 [20:51:40] (03PS1) 10Jdlrobson: WIP: Prep work for responsive design [extensions/VectorBeta] - 10https://gerrit.wikimedia.org/r/117927 [20:55:00] (03CR) 10Hoo man: [C: 032] Further optimize User::saveOptions() by doing deletes by PRIMARY KEY (031 comment) [core] - 10https://gerrit.wikimedia.org/r/117921 (owner: 10Aaron Schulz) [20:56:39] (03CR) 10BryanDavis: "I have working code for a different take on this that I think moves further in the direction that Ori was thinking about with his comments" [tools/scap] - 10https://gerrit.wikimedia.org/r/116399 (owner: 10BryanDavis) [20:57:16] bd808: ooh, that looks nice [20:58:16] ori: Cool. I'll work on a patch using it later [20:59:01] (03CR) 10EBernhardson: [C: 04-1] "Looks good in general, has a rendering oddity in chrome 33 though. Basically in firefox the hover transition for menu elements is just t" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/116501 (owner: 10Matthias Mullie) [20:59:09] (03Merged) 10jenkins-bot: Further optimize User::saveOptions() by doing deletes by PRIMARY KEY [core] - 10https://gerrit.wikimedia.org/r/117921 (owner: 10Aaron Schulz) [21:00:16] (03CR) 10Bsitu: Add summary revision type (031 comment) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/117357 (owner: 10Bsitu) [21:02:19] (03CR) 10TheDJ: Conditionally load jquery.ui.dialog for Scribunto errors (032 comments) [extensions/Scribunto] - 10https://gerrit.wikimedia.org/r/109262 (owner: 10TheDJ) [21:04:53] (03CR) 10Hoo man: "We should avoid making the program flow more complicated than necessary" (031 comment) [extensions/Scribunto] - 10https://gerrit.wikimedia.org/r/109262 (owner: 10TheDJ) [21:15:33] TOOL_LABS:when we create new tools: do they have different instances every time someone visits it.? If so will I have to create a database to link them up somehow..... [21:16:21] rohit-dua, huh? How do you mean "different instances everytime someone visits it"? [21:16:31] (also, #wikimedia-labs might be a good place) [21:16:44] rohit-dua: please go to #wikimedia-labs for support on Wikimedia Labs [21:18:32] (03CR) 10Krinkle: Further optimize User::saveOptions() by doing deletes by PRIMARY KEY (031 comment) [core] - 10https://gerrit.wikimedia.org/r/117921 (owner: 10Aaron Schulz) [21:19:16] (03PS9) 10Bsitu: Add new column rev_type_id to flow_revision [extensions/Flow] - 10https://gerrit.wikimedia.org/r/116861 [21:27:10] (03PS10) 10Bsitu: Add new column rev_type_id to flow_revision [extensions/Flow] - 10https://gerrit.wikimedia.org/r/116861 [21:27:30] (03CR) 10EBernhardson: [C: 032] [SCHEMA CHANGE] Add index on revision user data [extensions/Flow] - 10https://gerrit.wikimedia.org/r/116115 (owner: 10Matthias Mullie) [21:32:00] (03CR) 10EBernhardson: [C: 031] "lgtm" (031 comment) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/117638 (owner: 10Wctaiwan) [21:33:37] (03PS9) 10Bsitu: Update column flow_revision.rev_type_id [extensions/Flow] - 10https://gerrit.wikimedia.org/r/116874 [21:36:20] (03CR) 10Aaron Schulz: Further optimize User::saveOptions() by doing deletes by PRIMARY KEY (032 comments) [core] - 10https://gerrit.wikimedia.org/r/117921 (owner: 10Aaron Schulz) [21:43:39] (03PS1) 10EBernhardson: Send all wfDebugLog calls to the 'Flow' logGroup [extensions/Flow] - 10https://gerrit.wikimedia.org/r/118015 [21:43:55] (03CR) 10jenkins-bot: [V: 04-1] Send all wfDebugLog calls to the 'Flow' logGroup [extensions/Flow] - 10https://gerrit.wikimedia.org/r/118015 (owner: 10EBernhardson) [21:44:46] (03CR) 10EBernhardson: "resubmit" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/118015 (owner: 10EBernhardson) [21:45:06] (03PS2) 10EBernhardson: Send all wfDebugLog calls to the 'Flow' logGroup [extensions/Flow] - 10https://gerrit.wikimedia.org/r/118015 [21:46:24] (03CR) 10Hoo man: Further optimize User::saveOptions() by doing deletes by PRIMARY KEY (031 comment) [core] - 10https://gerrit.wikimedia.org/r/117921 (owner: 10Aaron Schulz) [21:57:39] (03CR) 10Hashar: "Looking at the console log on https://integration.wikimedia.org/ci/job/mediawiki-core-phpunit-databaseless/21929/console the tests are pas" [core] - 10https://gerrit.wikimedia.org/r/77645 (owner: 10Parent5446) [21:59:08] RoanKattouw: I haven't been able to find a hook that loads soon enough to make the skin work for skinStyles. Do you have any suggestions or should I create a new hook? Tried onRequestContextCreateSkin, onSkinTemplateOutputPageBeforeExec, and onBeforePageDisplay. [21:59:17] hi. what amount of work should be done before the mid-term evaluations of the GSOC program [21:59:32] kaldari: There's onBeforeSetup or whatever it's called [22:00:03] Or AfterSetup or whatever [22:01:47] RoanKattouw: SetupAfterCache? [22:05:22] kaldari: Maybe that's the one [22:05:39] kaldari: Yeah probably [22:09:53] YuviPanda: finished customisations? [22:10:38] AzaToth: whelp, yes. looking now [22:10:46] heh [22:11:41] YuviPanda: dont worry, I've not sat here counting seconds [22:11:47] AzaToth: :) [22:11:57] AzaToth: ok, looks ok to me. I can +2, can you deploy? [22:12:17] (03CR) 10Yuvipanda: [C: 032] grrrit: Allow filtering based on branches [labs/tools/grrrit] - 10https://gerrit.wikimedia.org/r/116996 (owner: 10AzaToth) [22:12:24] I can deploy [22:12:25] (03CR) 10Yuvipanda: [C: 032] grrrit: Pass betacluster messages to QA [labs/tools/grrrit] - 10https://gerrit.wikimedia.org/r/116997 (owner: 10AzaToth) [22:12:31] AzaToth: and thanks for the patches! :) [22:12:45] (03CR) 10jenkins-bot: [V: 04-1] grrrit: Pass betacluster messages to QA [labs/tools/grrrit] - 10https://gerrit.wikimedia.org/r/116997 (owner: 10AzaToth) [22:12:52] wut [22:12:58] wat [22:13:17] "This change depends on a change that failed to merge." [22:13:35] AzaToth: but it is merging... [22:13:53] * AzaToth scratches heads [22:14:09] AzaToth: jenkins seems confused [22:14:44] AzaToth: it did a -verified, then did a v+2? [22:14:55] (03CR) 10Swalling: [C: 031] "Tested and working for me locally." [extensions/GettingStarted] - 10https://gerrit.wikimedia.org/r/117874 (owner: 10Phuedx) [22:18:02] (03CR) 10Hashar: [C: 032] grrrit: Allow filtering based on branches [labs/tools/grrrit] - 10https://gerrit.wikimedia.org/r/116996 (owner: 10AzaToth) [22:18:05] (03CR) 10jenkins-bot: [V: 04-1] grrrit: Pass betacluster messages to QA [labs/tools/grrrit] - 10https://gerrit.wikimedia.org/r/116997 (owner: 10AzaToth) [22:18:09] (03CR) 10Yuvipanda: grrrit: Allow filtering based on branches [labs/tools/grrrit] - 10https://gerrit.wikimedia.org/r/116996 (owner: 10AzaToth) [22:18:29] (03CR) 10Yuvipanda: [C: 032] grrrit: Allow filtering based on branches [labs/tools/grrrit] - 10https://gerrit.wikimedia.org/r/116996 (owner: 10AzaToth) [22:18:32] (03CR) 10jenkins-bot: [V: 04-1] grrrit: Pass betacluster messages to QA [labs/tools/grrrit] - 10https://gerrit.wikimedia.org/r/116997 (owner: 10AzaToth) [22:29:55] (03CR) 10Hashar: "Again :]" [labs/tools/grrrit] - 10https://gerrit.wikimedia.org/r/116996 (owner: 10AzaToth) [22:30:39] (03CR) 10EBernhardson: [C: 031] "LGTM" (032 comments) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/117115 (owner: 10Bsitu) [22:31:06] (03CR) 10Hashar: [C: 032] "Allowed JenkinsBot to submit patches." [labs/tools/grrrit] - 10https://gerrit.wikimedia.org/r/116996 (owner: 10AzaToth) [22:31:09] (03Merged) 10jenkins-bot: grrrit: Allow filtering based on branches [labs/tools/grrrit] - 10https://gerrit.wikimedia.org/r/116996 (owner: 10AzaToth) [22:31:12] (03Merged) 10jenkins-bot: grrrit: Pass betacluster messages to QA [labs/tools/grrrit] - 10https://gerrit.wikimedia.org/r/116997 (owner: 10AzaToth) [22:41:59] (03CR) 10EBernhardson: [C: 032] Fix the maintenance script for updating *_user_wiki [extensions/Flow] - 10https://gerrit.wikimedia.org/r/116223 (owner: 10Bsitu) [22:42:12] (03Merged) 10jenkins-bot: Fix the maintenance script for updating *_user_wiki [extensions/Flow] - 10https://gerrit.wikimedia.org/r/116223 (owner: 10Bsitu) [22:44:34] (03Abandoned) 10MaxSem: action=createaccount should do checks in the first request, not second [core] - 10https://gerrit.wikimedia.org/r/116872 (owner: 10MaxSem) [22:45:54] (03CR) 10Mattflaschen: [C: 04-1] "I realized this isn't right. mediawiki.js does the escaping if it's format: 'parsed', so the test is not valid." (031 comment) [core] - 10https://gerrit.wikimedia.org/r/113307 (owner: 10Bartosz Dziewoński) [22:46:11] (03PS9) 10Bsitu: Update post/header revisions storage lookup key [extensions/Flow] - 10https://gerrit.wikimedia.org/r/117099 [22:49:02] (03PS10) 10Bsitu: Update post/header revisions storage lookup key [extensions/Flow] - 10https://gerrit.wikimedia.org/r/117099 [22:49:27] (03CR) 10Bsitu: Update post/header revisions storage lookup key [extensions/Flow] - 10https://gerrit.wikimedia.org/r/117099 (owner: 10Bsitu) [22:51:53] (03CR) 10Mattflaschen: "You're right. Even if the text length is similar, no one would expect the width to be the same, since it's not intended to be used with a" [core] - 10https://gerrit.wikimedia.org/r/117107 (owner: 10JGonera) [22:53:50] (03CR) 10Foxtrott: "Any comments on the inline comments on patch 5?" [core] - 10https://gerrit.wikimedia.org/r/110949 (owner: 10Gerrit Patch Uploader) [22:54:17] (03CR) 10Foxtrott: "I meant patch 4. Sorry." [core] - 10https://gerrit.wikimedia.org/r/110949 (owner: 10Gerrit Patch Uploader) [23:01:39] (03PS8) 10Bsitu: Drop table flow_header_revision [extensions/Flow] - 10https://gerrit.wikimedia.org/r/117115 [23:01:42] (03CR) 10jenkins-bot: [V: 04-1] Drop table flow_header_revision [extensions/Flow] - 10https://gerrit.wikimedia.org/r/117115 (owner: 10Bsitu) [23:05:50] (03PS1) 10Mattflaschen: Add return true to only hook without it [extensions/EventLogging] - 10https://gerrit.wikimedia.org/r/118026 [23:06:40] (03PS9) 10Bsitu: Drop table flow_header_revision [extensions/Flow] - 10https://gerrit.wikimedia.org/r/117115 [23:06:48] (03CR) 10jenkins-bot: [V: 04-1] Drop table flow_header_revision [extensions/Flow] - 10https://gerrit.wikimedia.org/r/117115 (owner: 10Bsitu) [23:07:39] (03CR) 10Mattflaschen: "I don't know if this adds any compatibility, but it at least adds consistency (all of the others have it), and makes it easier for anyone " [extensions/EventLogging] - 10https://gerrit.wikimedia.org/r/118026 (owner: 10Mattflaschen) [23:08:18] (03PS10) 10Bsitu: Drop table flow_header_revision [extensions/Flow] - 10https://gerrit.wikimedia.org/r/117115 [23:18:41] (03CR) 10CSteipp: "MZ is right that I did say this would be WMF only, so I'm keeping it at 1 in PS2. We can decide that separately." (031 comment) [core] - 10https://gerrit.wikimedia.org/r/117635 (owner: 10CSteipp) [23:21:13] (03PS2) 10CSteipp: Raise minimum password length [core] - 10https://gerrit.wikimedia.org/r/117635 [23:21:31] (03PS2) 10MaxSem: JSON statistics [extensions/Minifier] - 10https://gerrit.wikimedia.org/r/114903 [23:23:25] (03CR) 10EBernhardson: (bug 61107) Contributions from Flow appear in every namespace (032 comments) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/115908 (owner: 10Matthias Mullie) [23:26:22] i just made a fresh clone of mediawiki-vagrant and ran vagrant up, but its failing to run /vagrant/mediawiki/maintenance/install.php because /vagrant/mediawiki never got the checkout. anyone run into this? [23:27:11] i could try and figure out when it happened, but `vagrant destroy && vagrant up` inside a git bisect is going to take awhile :) [23:41:22] (03CR) 10Mattflaschen: "Please update the commit message to reflect the current patch." [core] - 10https://gerrit.wikimedia.org/r/117635 (owner: 10CSteipp) [23:43:50] ebernhardson: I have seen that happen locally. In my case I could see output from the initial puppet run that showed a timeout talking to gerrit that made git croak. [23:44:48] (03PS4) 10CSteipp: Allow login without a valid password [core] - 10https://gerrit.wikimedia.org/r/117635 [23:46:40] (03PS4) 10BryanDavis: Replace cluster_monitor with a ssh.Job class [tools/scap] - 10https://gerrit.wikimedia.org/r/116399 [23:46:42] (03PS5) 10BryanDavis: Use realm specific filename with mwversionsinuse [tools/scap] - 10https://gerrit.wikimedia.org/r/117014 [23:47:09] bd808: hmm, oddly enough paging through my output theres not a single line with Git::Clone, i'm expecting there should be some sort of 'notice: /Stage[main/Git::Clone/....' ? [23:48:20] heh, the word 'core' (which is from the line in mediawiki/manifests/init.pp: git::clone { 'mediawiki/core': ... } ) doesn't show up in the output except for in relation to ppa for git-core :S [23:48:47] hmm [23:52:36] (03PS1) 10AzaToth: grrrit: Fix order of arguments for "repos" [labs/tools/grrrit] - 10https://gerrit.wikimedia.org/r/118028 [23:53:33] its almost gotta be the timeout though, running `ps ax | grep 'git clone'` ad naseum while its provisioning does turn up that its trying to clone core [23:54:29] (03CR) 10BryanDavis: "Going for a record of how many completely different implementations for a single feature I can pack into a change set. :)" [tools/scap] - 10https://gerrit.wikimedia.org/r/116399 (owner: 10BryanDavis) [23:56:07] (03CR) 10Mattflaschen: "> I think that you should be able to build a tour without" [extensions/GuidedTour] - 10https://gerrit.wikimedia.org/r/116228 (owner: 10Mattflaschen) [23:58:09] ebernhardson: I highly recommend keeping one master clone of core and using git-new-workdir to setup copies for vms [23:58:54] bd808: yea generally this isn't a problem, the only reason i was setting up a new one is because i was going to make a 'Flow' role and i wanted to do it on a fresh instance instead of my hacked up one [23:59:09] * bd808 nods