[00:01:16] (03PS2) 10Foxtrott: followup Ic8756e685: fix botched fix [extensions/Lingo] - 10https://gerrit.wikimedia.org/r/117664 [00:01:47] (03CR) 10Foxtrott: [C: 032 V: 032] followup Ic8756e685: fix botched fix [extensions/Lingo] - 10https://gerrit.wikimedia.org/r/117664 (owner: 10Foxtrott) [00:25:26] (03CR) 10Gergő Tisza: [C: 04-1] "Last small issue..." (031 comment) [extensions/UploadWizard] (osm) - 10https://gerrit.wikimedia.org/r/116129 (owner: 10Inchikutty) [00:29:16] (03PS1) 10Foxtrott: Release version 1.1.0 [extensions/Lingo] - 10https://gerrit.wikimedia.org/r/117665 [00:29:50] (03CR) 10Foxtrott: [C: 032 V: 032] Release version 1.1.0 [extensions/Lingo] - 10https://gerrit.wikimedia.org/r/117665 (owner: 10Foxtrott) [00:50:01] (03CR) 10Gergő Tisza: [C: 04-1] "Some small issues, mostly documentation; plus there are some more in patchset 4." (034 comments) [extensions/UploadWizard] (osm) - 10https://gerrit.wikimedia.org/r/116130 (owner: 10Inchikutty) [01:09:34] (03CR) 10Daniel Kinzler: Introducing TitleValue (031 comment) [core] - 10https://gerrit.wikimedia.org/r/106517 (owner: 10Daniel Kinzler) [02:20:41] (03PS1) 10Reedy: Swap global function for closure [extensions/CodeReview] - 10https://gerrit.wikimedia.org/r/117666 [02:22:33] (03CR) 10Hoo man: [C: 032] Swap global function for closure [extensions/CodeReview] - 10https://gerrit.wikimedia.org/r/117666 (owner: 10Reedy) [02:22:38] (03Merged) 10jenkins-bot: Swap global function for closure [extensions/CodeReview] - 10https://gerrit.wikimedia.org/r/117666 (owner: 10Reedy) [02:30:32] (03CR) 10Parent5446: [C: 031] Introducing TitleValue [core] - 10https://gerrit.wikimedia.org/r/106517 (owner: 10Daniel Kinzler) [02:53:06] (03PS2) 10Aaron Schulz: Deprecated useless BagOStuff::replace method [core] - 10https://gerrit.wikimedia.org/r/115518 [02:53:12] (03CR) 10Ori.livneh: [C: 032] Deprecated useless BagOStuff::replace method [core] - 10https://gerrit.wikimedia.org/r/115518 (owner: 10Aaron Schulz) [02:56:08] (03PS2) 10Anomie: mw.language: Fix exceptions and add tests [extensions/Scribunto] - 10https://gerrit.wikimedia.org/r/116984 [02:56:24] (03CR) 10Ori.livneh: [C: 032] mw.language: Fix exceptions and add tests [extensions/Scribunto] - 10https://gerrit.wikimedia.org/r/116984 (owner: 10Anomie) [02:58:05] (03Merged) 10jenkins-bot: Deprecated useless BagOStuff::replace method [core] - 10https://gerrit.wikimedia.org/r/115518 (owner: 10Aaron Schulz) [02:59:03] (03CR) 10Ori.livneh: [C: 032] "Cool." [extensions/WikimediaEvents] - 10https://gerrit.wikimedia.org/r/117619 (owner: 10Mattflaschen) [02:59:06] (03Merged) 10jenkins-bot: Move hooks into hooks class [extensions/WikimediaEvents] - 10https://gerrit.wikimedia.org/r/117619 (owner: 10Mattflaschen) [02:59:10] (03Merged) 10jenkins-bot: mw.language: Fix exceptions and add tests [extensions/Scribunto] - 10https://gerrit.wikimedia.org/r/116984 (owner: 10Anomie) [03:01:45] (03CR) 10Ori.livneh: Log automatic creation of a redirect as a PageCreation (031 comment) [extensions/WikimediaEvents] - 10https://gerrit.wikimedia.org/r/117643 (owner: 10Mattflaschen) [03:13:23] (03CR) 10Worden.lee: "Thanks! Here's a preview: https://www.youtube.com/watch?v=4d90Tt5EGAc" [core] - 10https://gerrit.wikimedia.org/r/67173 (owner: 10Worden.lee) [03:17:56] (03CR) 10MZMcBride: "Agree with Nikerabbit. The RFC "outcome" is pretty dubious. Apparently anyone who objects to this idea has to know to show up to a specifi" [core] - 10https://gerrit.wikimedia.org/r/117635 (owner: 10CSteipp) [03:20:00] Gloria: wow. [03:20:11] Gloria: thanks for that comment. I'm surprised and lost likewise. [03:32:05] ? [03:33:04] jorm: I was referring to the last comment grrrit-wm announced. [03:33:37] i have that bot blocked [03:48:05] jorm, https://gerrit.wikimedia.org/r/117635 [03:50:48] I'm not sure why it's surprising that the MediaWiki architects made a decision about an RFC. I mean, it *is* their job. [03:51:42] http://www.bbc.com/news/world-europe-26488072 [03:51:56] * AaronSchulz never heard "joshing" used in a news story like that [03:54:02] AaronSchulz: http://m.bbc.com/sport/athletics/16246797 ! :P [03:55:28] I always imagine there being some crazy guy called Josh... [03:59:09] at the Elysee palace? [04:26:54] (03PS4) 10AndyRussG: Add minial dependency injection, including tests [extensions/Campaigns] (wip/editorcampaigns) - 10https://gerrit.wikimedia.org/r/116153 [04:40:47] (03PS7) 10AndyRussG: WIP Stubs and tests for persistence objects [extensions/Campaigns] (wip/editorcampaigns) - 10https://gerrit.wikimedia.org/r/116221 [04:41:52] (03CR) 10AndyRussG: "Rebased and added "WIP" to commit message" [extensions/Campaigns] (wip/editorcampaigns) - 10https://gerrit.wikimedia.org/r/116221 (owner: 10AndyRussG) [04:51:33] (03PS2) 10AndyRussG: WIP Query API modules for campaigns and participants [extensions/Campaigns] (wip/editorcampaigns) - 10https://gerrit.wikimedia.org/r/117380 [04:52:01] (03CR) 10AndyRussG: "Rebased and added "WIP" to commit message" [extensions/Campaigns] (wip/editorcampaigns) - 10https://gerrit.wikimedia.org/r/117380 (owner: 10AndyRussG) [05:08:58] (03PS8) 10TTO: Hide edit toolbar Signature button in content namespaces by default [core] - 10https://gerrit.wikimedia.org/r/87649 [05:09:46] (03CR) 10jenkins-bot: [V: 04-1] Hide edit toolbar Signature button in content namespaces by default [core] - 10https://gerrit.wikimedia.org/r/87649 (owner: 10TTO) [05:14:52] (03PS5) 10MZMcBride: Add minimal dependency injection, including tests [extensions/Campaigns] (wip/editorcampaigns) - 10https://gerrit.wikimedia.org/r/116153 (owner: 10AndyRussG) [05:32:15] (03CR) 10Parent5446: "IMO, the actual changing of the minimal password length should be removed from this patch. Not because I disagree with it, but because no " [core] - 10https://gerrit.wikimedia.org/r/117635 (owner: 10CSteipp) [08:09:42] (03PS1) 10Brian Wolff: When checking whitelist of extensions, only count last extension. [core] - 10https://gerrit.wikimedia.org/r/117668 [09:35:48] jorm: they had ignored user feedback ... [09:46:38] (03CR) 10TTO: "recheck" [core] - 10https://gerrit.wikimedia.org/r/87649 (owner: 10TTO) [10:22:59] (03PS1) 10Ori.livneh: ResourceLoader::makeLoaderImplementScript: bind args as '$' & 'jQuery' [core] - 10https://gerrit.wikimedia.org/r/117672 [10:23:51] (03CR) 10Ori.livneh: "@Krinkle: I0f0c3a04c." [core] - 10https://gerrit.wikimedia.org/r/85637 (owner: 10Ori.livneh) [10:45:31] (03CR) 10Kipcool: [C: 032 V: 032] API ow_express 1.1 initial changes [extensions/WikiLexicalData] - 10https://gerrit.wikimedia.org/r/116459 (owner: 10Hiong3-eng5) [10:46:47] (03CR) 10Kipcool: [C: 032 V: 032] API cache output for owDefine [extensions/WikiLexicalData] - 10https://gerrit.wikimedia.org/r/117393 (owner: 10Hiong3-eng5) [10:47:20] (03PS3) 10Hiong3-eng5: API 1.1 ow_syntrans initial changes [extensions/WikiLexicalData] - 10https://gerrit.wikimedia.org/r/117162 [10:51:48] (03CR) 10Kipcool: [C: 032 V: 032] "@Hiong: actually, I just used the rebase button from gerrit, it worked fine :)" [extensions/WikiLexicalData] - 10https://gerrit.wikimedia.org/r/117162 (owner: 10Hiong3-eng5) [10:54:48] (03PS2) 10Purodha: Fix mistyped file name.:wq [extensions/WikiLexicalData] - 10https://gerrit.wikimedia.org/r/116271 [10:56:47] (03Abandoned) 10Kipcool: Fix mistyped file name.:wq [extensions/WikiLexicalData] - 10https://gerrit.wikimedia.org/r/116271 (owner: 10Purodha) [11:01:43] (03Abandoned) 10Kipcool: Fix even more typos and morge branch 'master' of ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/WikiLexicalData [extensions/WikiLexicalData] - 10https://gerrit.wikimedia.org/r/116472 (owner: 10Purodha) [11:03:33] (03CR) 10Kipcool: [C: 04-1] "Are all changes of this patch introduced in the other patch 116270 ? If not, it should be :) Or at least it should be rebased." [extensions/WikiLexicalData] - 10https://gerrit.wikimedia.org/r/116277 (owner: 10Purodha) [11:14:13] (03CR) 10Kipcool: "Hmm... Purodha, could you please test the code before you commit it? Or at least mention that you have not tested it?" [extensions/WikiLexicalData] - 10https://gerrit.wikimedia.org/r/116270 (owner: 10Purodha) [12:25:18] (03CR) 10Siebrand: [C: 031] "Quick i18n/L10n review." (032 comments) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/116786 (owner: 10Spage) [12:25:24] (03CR) 10Siebrand: [C: 04-1] subclass core's ErrorPageError & PermissionsError [extensions/Flow] - 10https://gerrit.wikimedia.org/r/116786 (owner: 10Spage) [12:51:35] (03CR) 10Siebrand: [C: 04-1] "i18n/L10n reviewed." [core] - 10https://gerrit.wikimedia.org/r/117635 (owner: 10CSteipp) [12:57:21] (03PS8) 10AndyRussG: WIP Stubs and tests for persistence objects [extensions/Campaigns] (wip/editorcampaigns) - 10https://gerrit.wikimedia.org/r/116221 [12:59:12] Hi, who's around? [12:59:45] (03CR) 10AndyRussG: "Rebased again" [extensions/Campaigns] (wip/editorcampaigns) - 10https://gerrit.wikimedia.org/r/116221 (owner: 10AndyRussG) [13:04:39] (03CR) 10Siebrand: [C: 032] Remove 2 false values returned in execute() [core] - 10https://gerrit.wikimedia.org/r/113894 (owner: 10Reedy) [13:07:06] (03CR) 10Siebrand: [C: 032] Method to identify if a ChangesList is watchlist or normal [core] - 10https://gerrit.wikimedia.org/r/117466 (owner: 10EBernhardson) [13:08:25] (03Merged) 10jenkins-bot: Remove 2 false values returned in execute() [core] - 10https://gerrit.wikimedia.org/r/113894 (owner: 10Reedy) [13:27:50] (03PS7) 10Inchikutty: Embedding leaflet maps based on OSM data to UploadWizard [extensions/UploadWizard] (osm) - 10https://gerrit.wikimedia.org/r/116129 [13:32:52] (03PS2) 10Addshore: Introduce stashMwGlobals method to MediaWikiTestCase [core] - 10https://gerrit.wikimedia.org/r/117036 [13:33:00] (03PS5) 10Addshore: Throw exception when trying to stash unset globals [core] - 10https://gerrit.wikimedia.org/r/117039 [13:33:05] (03PS8) 10Addshore: Cleanup MediawikiTestCase [core] - 10https://gerrit.wikimedia.org/r/116974 [13:33:33] (03PS5) 10Addshore: Add basic tests for MediaWikiTestCase [core] - 10https://gerrit.wikimedia.org/r/117042 [13:33:38] (03PS3) 10Addshore: Cleanup a bunch of tests and add todos [core] - 10https://gerrit.wikimedia.org/r/117464 [13:36:17] (03PS11) 10Inchikutty: [WIP]UploadWizard: OSM embedding: Geocoding, reverse geocoding [extensions/UploadWizard] (osm) - 10https://gerrit.wikimedia.org/r/116130 [14:12:56] (03PS3) 10Addshore: Introduce stashMwGlobals method to MediaWikiTestCase [core] - 10https://gerrit.wikimedia.org/r/117036 [14:12:58] (03PS6) 10Addshore: Throw exception when trying to stash unset globals [core] - 10https://gerrit.wikimedia.org/r/117039 [14:13:00] (03PS9) 10Addshore: Cleanup MediawikiTestCase [core] - 10https://gerrit.wikimedia.org/r/116974 [14:13:02] (03PS4) 10Addshore: Cleanup a bunch of tests and add todos [core] - 10https://gerrit.wikimedia.org/r/117464 [14:13:32] (03Abandoned) 10Addshore: Add basic tests for MediaWikiTestCase [core] - 10https://gerrit.wikimedia.org/r/117042 (owner: 10Addshore) [14:48:11] (03PS1) 10Raimond Spekking: Consistency tweaks [extensions/PGFTikZ] - 10https://gerrit.wikimedia.org/r/117677 [15:01:54] (03PS1) 10Reedy: Remove API developer email addresses [core] - 10https://gerrit.wikimedia.org/r/117678 [15:02:40] (03CR) 10Hoo man: [C: 032] "makes sense" [core] - 10https://gerrit.wikimedia.org/r/117678 (owner: 10Reedy) [15:06:25] (03Merged) 10jenkins-bot: Remove API developer email addresses [core] - 10https://gerrit.wikimedia.org/r/117678 (owner: 10Reedy) [15:10:51] (03PS1) 10Reedy: Wrap long text [core] - 10https://gerrit.wikimedia.org/r/117680 [15:13:38] (03PS1) 10Reedy: Wrap long line [extensions/GlobalBlocking] - 10https://gerrit.wikimedia.org/r/117681 [15:27:36] (03CR) 10Hoo man: [C: 032] "The API *could* do that automatically, I guess..." [core] - 10https://gerrit.wikimedia.org/r/117680 (owner: 10Reedy) [15:29:44] hoo: it does for some parts... [15:29:48] look for the wordwrap calls [15:30:49] "Some parts", that's the MediaWiki way [15:31:21] where consistency is another word for boring [15:31:26] (03Merged) 10jenkins-bot: Wrap long text [core] - 10https://gerrit.wikimedia.org/r/117680 (owner: 10Reedy) [15:31:49] Description and examples it seems [15:32:01] wordwrap( implode( ', ', MWNamespace::getValidNamespaces() ) [15:32:03] yeah [15:33:15] I remember when there wasn't any wordwrap at all ;) [15:34:06] Yeah, that's probably because you introduced thenm [15:34:12] according to a quick git blame [15:35:00] they've been there quite a while [15:35:42] e22c5cb3 :P [15:36:42] and that means absolutely nothing ;) [15:36:44] Reedy: do you think https://gerrit.wikimedia.org/r/#/c/117662/ is a good idea, or a really bad one? [15:38:29] i'm sure you can find a lot of people who disapprove [15:40:42] (03CR) 10Bartosz Dziewoński: "And I filed the above as bug 62454. All of these bugs aren't really relevant to this patchset, though." [core] - 10https://gerrit.wikimedia.org/r/114959 (owner: 10Bartosz Dziewoński) [15:40:51] my idea was so that review request on fringe stuff can get noticed [15:41:13] just because it's a bug doesn't mean it belongs in here though [16:15:47] (03CR) 10BryanDavis: "> [...snip...] use the command basename as a name for the ProgressReporter" [tools/scap] - 10https://gerrit.wikimedia.org/r/116399 (owner: 10BryanDavis) [16:41:05] hello all. [16:41:21] I would like to inquire about the bug number 60524 [16:41:39] I would like to work on it and I saw a bit of disagreement in the comments [16:41:50] I would like to know if the bug is still open ? [16:44:09] Yes it is [16:44:18] It still has a Status of New [16:44:27] (03PS5) 10Jackmcbarn: Support searching for multiple filter IDs [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/105617 [16:44:55] https://bugzilla.wikimedia.org/show_bug.cgi?id=60524 [16:45:23] great ! I have a question about this bug . See I figure I can check to see if the username exists in the database [16:45:34] by using the user class constructor [16:45:38] to see if the id is 0 [16:45:48] also I can ignore this process if it is a ip adress [16:46:13] but there is this mention of some pre-phase 3 era usernames [16:46:19] how do I check for those ? [16:46:55] aditya_sastry: use the same logic it uses to determine whether or not to link to the user page [17:01:51] (03CR) 10Siebrand: [C: 032] Wrap long line [extensions/GlobalBlocking] - 10https://gerrit.wikimedia.org/r/117681 (owner: 10Reedy) [17:01:54] (03Merged) 10jenkins-bot: Wrap long line [extensions/GlobalBlocking] - 10https://gerrit.wikimedia.org/r/117681 (owner: 10Reedy) [17:05:29] (03CR) 10Siebrand: [C: 04-1] Consistency tweaks (031 comment) [extensions/PGFTikZ] - 10https://gerrit.wikimedia.org/r/117677 (owner: 10Raimond Spekking) [17:07:21] Can someone tell me which doxygen I should be using? I want to install it on my vagrant development VM [17:07:37] (03CR) 10Siebrand: [C: 031] "i18n/L10n reviewed." [core] - 10https://gerrit.wikimedia.org/r/117438 (owner: 10Bartosz Dziewoński) [17:08:26] (03PS2) 10Raimond Spekking: Consistency tweaks [extensions/PGFTikZ] - 10https://gerrit.wikimedia.org/r/117677 [17:08:33] (03CR) 10Siebrand: [C: 031] "L10n reviewed." [extensions/GlobalCssJs] - 10https://gerrit.wikimedia.org/r/94842 (owner: 10Legoktm) [17:10:22] danorton: It shouldn't matter too much as long as it's a recentish version [17:10:46] Thx, Reedy. Is there a template Doxyfile? [17:10:51] Yup [17:11:00] in core it's maintenance/Doxyfile [17:11:20] I don't see how to install doxygen on the VM. When I use apt-get, it tries to update everything (~ 700MB) [17:11:30] when i hit the section edit link for Staff on https://meta.wikimedia.org/wiki/User_groups , i end up editing the Steward section instead [17:11:36] can someone confirm this isn't just me? [17:12:33] Templates? [17:12:33] Reedy, I don't see how to install doxygen on the VM. When I use apt-get, it tries to update everything (~ 700MB). [17:14:01] I'm not sure it's "update everything" [17:14:09] Looking locally, it's got quite a large dependancy tree [17:14:15] 0 upgraded, 30 newly installed, 0 to remove and 3 not upgraded. [17:15:17] Need to get 382 MB/434 MB of archives. [17:15:17] After this operation, 701 MB of additional disk space will be used. [17:15:27] (03CR) 10Siebrand: [C: 032 V: 032] Consistency tweaks [extensions/PGFTikZ] - 10https://gerrit.wikimedia.org/r/117677 (owner: 10Raimond Spekking) [17:15:29] Need to get 639 MB of archives. [17:15:29] After this operation, 977 MB of additional disk space will be used. [17:15:57] Yikes! [17:16:21] Not really a "development" VM w/o doxygen, is it? [17:16:34] I just created https://bugzilla.wikimedia.org/62457 requesting vagrant include doxygen [17:16:36] Maybe, maybe not [17:17:04] A version for master is maintained at https://doc.wikimedia.org/mediawiki-core/master/php/html/ [17:17:31] Not sure everyone necesserily needs it locally [17:17:37] Okay, thx, Reedy. [17:18:22] (03PS1) 10UltrasonicNXT: Add users being away [extensions/MediaWikiChat] - 10https://gerrit.wikimedia.org/r/117690 [17:23:22] (03PS2) 10UltrasonicNXT: Add users being away [extensions/MediaWikiChat] - 10https://gerrit.wikimedia.org/r/117690 [17:23:41] (03CR) 10UltrasonicNXT: [C: 032 V: 032] Add users being away [extensions/MediaWikiChat] - 10https://gerrit.wikimedia.org/r/117690 (owner: 10UltrasonicNXT) [17:29:58] @jackmcbarn [17:30:24] @jackmcbarn are you refering to the logic in article.php and editpage.php ? [17:30:30] no [17:30:39] on the contributions page, sometimes the username is gray and not a link [17:30:43] sometimes it's red or blue and is a link [17:30:48] if it's gray and not an IP, display the warning [17:31:31] Ohh k .. Sorry this is the first time I am writting a patch on user contrib file so I am not so sure of the code there [17:34:29] (03CR) 10Siebrand: "Have the corresponding pages on translatewiki.net been removed? Otherwise these entries will resurface when a full export is done from the" [extensions/ContactPage] - 10https://gerrit.wikimedia.org/r/116630 (owner: 10Reedy) [17:37:41] Reedy, those doxygen dependencies were crazy. I just downloaded single binary (26M) and it works fine. [17:38:12] (03CR) 10Reedy: "Yup, this was the final cleanup after the rest of the incorrect en-gb messages were moved to lt, where an lt message didn't already exist" [extensions/ContactPage] - 10https://gerrit.wikimedia.org/r/116630 (owner: 10Reedy) [17:39:16] I guess those give you the possibility to use every single feature [17:40:38] :D Unless you can make it a mail client, it's not complete! [17:41:53] (03PS1) 10UltrasonicNXT: Make avatars in sidebar module greyscale where away too [extensions/MediaWikiChat] - 10https://gerrit.wikimedia.org/r/117693 [17:42:48] (03CR) 10UltrasonicNXT: [C: 032 V: 032] Make avatars in sidebar module greyscale where away too [extensions/MediaWikiChat] - 10https://gerrit.wikimedia.org/r/117693 (owner: 10UltrasonicNXT) [17:54:26] (03PS1) 10UltrasonicNXT: Remove dependencies on globals, ContextSource gets instead [extensions/MediaWikiChat] - 10https://gerrit.wikimedia.org/r/117694 [17:54:45] (03CR) 10UltrasonicNXT: [C: 032 V: 032] Remove dependencies on globals, ContextSource gets instead [extensions/MediaWikiChat] - 10https://gerrit.wikimedia.org/r/117694 (owner: 10UltrasonicNXT) [18:02:42] (03PS1) 10Addshore: make composer use dev-master [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/117695 [18:04:11] (03CR) 10Hoo man: [C: 032] "whatever" [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/117695 (owner: 10Addshore) [18:04:16] (03Merged) 10jenkins-bot: make composer use dev-master [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/117695 (owner: 10Addshore) [18:04:24] hi, the replica databases on *.labsdb don't contain the "text" table. Is it correct? [18:09:00] rotpunkt: yes, it's correct [18:09:01] rotpunkt: That's because WMF handles that in a different manner, yes [18:09:08] ^ [18:12:32] thanks, so, if have a bot on wmflabs that needs to read the wikitext of a page it has to use api.php. right? [18:13:47] or is there another way? [18:14:57] I mean not http-based [18:18:15] rotpunkt: No, you have to use http [18:20:30] ok thanks! I hoped there was another way, just for saving bandwith :) thanks again [18:38:39] (03PS1) 10SPQRobin: Shorter lines in LanguageUz.php comments [core] - 10https://gerrit.wikimedia.org/r/117697 [18:38:46] (03CR) 10Adamw: "Why do all the reflection when you could just use interfaces?" [extensions/Campaigns] (wip/editorcampaigns) - 10https://gerrit.wikimedia.org/r/116153 (owner: 10AndyRussG) [18:39:57] (03CR) 10SPQRobin: [C: 032 V: 032] Shorter lines in LanguageUz.php comments [core] - 10https://gerrit.wikimedia.org/r/117697 (owner: 10SPQRobin) [18:48:30] (03CR) 10SPQRobin: Fix Uzbek converter (031 comment) [core] - 10https://gerrit.wikimedia.org/r/116914 (owner: 10SPQRobin) [18:52:01] (03CR) 10Bartosz Dziewoński: Shorter lines in LanguageUz.php comments (031 comment) [core] - 10https://gerrit.wikimedia.org/r/117697 (owner: 10SPQRobin) [18:52:42] (03Abandoned) 10Ori.livneh: Update VisualEditor events to those added in gerrit 94284 [extensions/WikimediaEvents] - 10https://gerrit.wikimedia.org/r/96202 (owner: 10Jforrester) [19:04:43] @jackmcbarn this is almost done could you tell me your username in gerrit so that I could add you as a reviewer ? [19:04:48] jackmcbarn [19:05:24] Hey how come this throws an exception ? [19:05:35] Linker::link( $userObj->getUserPage(), htmlspecialchars( $userObj->getName() ) ); [19:05:41] sorry [19:06:02] (Title::isKnown(Linker::normaliseSpecialPage($userObj->getUserPage()))) [19:06:31] Like am trying to check if a user page exists or not [19:06:45] and it is throwing a exception @jackmcbarn [19:07:00] their user page isn't a special page [19:07:49] Took out the normaliseSpecialPage from that chaining [19:07:56] still throws a error [19:08:15] (Title::isKnown($userObj->getUserPage())) [19:09:54] @jacmcbarn I took out the normaliseSpecialpage and it still throws that exception [19:10:04] (Title::isKnown($userObj->getUserPage())) [19:10:20] @jackmcbarn I took out the normaliseSpecialpage and it still throws that exception [19:10:35] what exception [19:10:58] [79844abe] 2014-03-09 19:10:43: Fatal exception of type MWException @jackmcbarn [19:11:06] i need more details than that [19:12:23] In the special contrib page... in the contributionSub I added this line (Title::isKnown($userObj->getUserPage())) which is causing it to throw that error. The userOBJ is the text recieved from the textbox. @jackmcbarn [19:13:07] aditya_sastry: isKnown is the wrong function [19:13:16] if their user page is a redlink, the user could still exist [19:14:16] jackmcbarn: Check out https://en.wikipedia.org/wiki/Special:Badtitle and try linking to it directly from your sandbox... It's a redlink that claims it doesn't exist but is a valid target... [19:14:42] aditya_sastry: if $userObj->isAnon() is true but the username isn't a valid IP address, show the warning [19:14:48] aditya_sastry: don't fuss with page title checks [19:14:53] Technical_13: soon [19:15:21] Where would such a bug ticket go? wikimedia general? special pages? parser? [19:16:00] @jackmcbarn Ok thanks. I need to add the warning to the i18n page right ? Both in english and qqq section [19:33:51] (03CR) 10SPQRobin: Shorter lines in LanguageUz.php comments (031 comment) [core] - 10https://gerrit.wikimedia.org/r/117697 (owner: 10SPQRobin) [19:46:12] (03CR) 10Siebrand: "Great." [extensions/ContactPage] - 10https://gerrit.wikimedia.org/r/116630 (owner: 10Reedy) [19:56:16] (03CR) 10Siebrand: [C: 031] "L10n reviewed." [extensions/Flow] - 10https://gerrit.wikimedia.org/r/116501 (owner: 10Matthias Mullie) [19:58:27] (03CR) 10Foxtrott: "The bug report contains exptime. Is there a specific reason why it is missing in this patch?" (035 comments) [core] - 10https://gerrit.wikimedia.org/r/110949 (owner: 10Gerrit Patch Uploader) [20:05:31] (03CR) 10Siebrand: [C: 032] "@addshore: I agree, but this appears to make core consistent for now. Open a bug?" [core] - 10https://gerrit.wikimedia.org/r/116290 (owner: 10Umherirrender) [20:09:27] (03Merged) 10jenkins-bot: Remove final period from api module descriptions [core] - 10https://gerrit.wikimedia.org/r/116290 (owner: 10Umherirrender) [20:14:12] (03CR) 10Addshore: "What is even worse is that this hasn't even removed final periods from all description messages >.>" [core] - 10https://gerrit.wikimedia.org/r/116290 (owner: 10Umherirrender) [20:23:14] (03PS1) 10Addshore: Add final preiod to api module descriptions [core] - 10https://gerrit.wikimedia.org/r/117704 [20:24:40] (03CR) 10Addshore: "https://gerrit.wikimedia.org/r/#/c/117704/" [core] - 10https://gerrit.wikimedia.org/r/116290 (owner: 10Umherirrender) [20:29:26] (03CR) 10TheDJ: "Yes this should work. It's not depending on anything that is unique to wmf." [extensions/CodeEditor] - 10https://gerrit.wikimedia.org/r/106693 (owner: 10TheDJ) [20:57:42] (03PS1) 10Jack Phoenix: Reapplying r45820 to support the NewSignupPage extension. [core] - 10https://gerrit.wikimedia.org/r/117806 [21:00:28] (03PS3) 10TheDJ: Conditionally load jquery.ui.dialog for Scribunto errors [extensions/Scribunto] - 10https://gerrit.wikimedia.org/r/109262 [21:07:56] (03CR) 10Hoo man: "Just some thoughts... it's a little hard to get the code in its current state" (032 comments) [extensions/Scribunto] - 10https://gerrit.wikimedia.org/r/109262 (owner: 10TheDJ) [21:33:19] (03CR) 10TheDJ: "So wait, we are stuck on a naming issue, which has as suggested solution: Well let's rename the OTHER modules ? If that is truly the reaso" [core] - 10https://gerrit.wikimedia.org/r/110908 (owner: 10Isarra) [21:50:10] (03CR) 10Bartosz Dziewoński: "TheDJ, I tried to submit a change to do just that https://gerrit.wikimedia.org/r/#/c/114984/ and it was -1'd too. If you can push this for" [core] - 10https://gerrit.wikimedia.org/r/110908 (owner: 10Isarra) [21:50:35] (03CR) 10Isarra: "The rename of the rest is change 114984 (this one can be updated to match once that's sorted out/merged), which has also been -1ed because" [core] - 10https://gerrit.wikimedia.org/r/110908 (owner: 10Isarra) [21:50:51] Isarra: mid-air collision! [21:50:55] Ohai. [21:52:12] Yeah, if these can finally get merged, that would be great. o_O [21:52:39] (03CR) 10Daniel Friesen: "Oh, I missed another issue that needs fixing while talking about that." [core] - 10https://gerrit.wikimedia.org/r/114984 (owner: 10Bartosz Dziewoński) [21:54:01] (03CR) 10Bartosz Dziewoński: "I was going to add symlinks to resolve that." [core] - 10https://gerrit.wikimedia.org/r/114984 (owner: 10Bartosz Dziewoński) [21:55:08] (03CR) 10Daniel Friesen: "I like c114984, it just has a few minor issues that need fixing before +1ing it (wrapping commonPrint up and a backward compatibility brea" [core] - 10https://gerrit.wikimedia.org/r/110908 (owner: 10Isarra) [21:57:06] (03CR) 10Daniel Friesen: "Is that something we can do? I know that git supports symlinks. But I don't recall that being a practice we've used. And I'm not sure our " [core] - 10https://gerrit.wikimedia.org/r/114984 (owner: 10Bartosz Dziewoński) [22:26:48] hey what category does changes to the special:contribution page fall under ? [22:27:49] Category? In what context? [22:27:52] Bugzilla components? [22:28:20] I am looking for reviewers [22:28:31] Yeah also bugzilla components too [22:28:57] What? [22:29:08] Are we discussing bugzilla components or not? [22:29:15] Reviewers for this patch I am about to submit [22:29:38] also do provide me infor on bugzilla component category of special:contrib [22:29:41] Oh, so you're looking at the maintainers list to find people to review? And you need to find the right set of maintainers? [22:29:48] Yeah [22:29:51] maintainers [22:29:56] sorry not reviewers [22:30:25] I would say Special Pages [22:31:10] Umm .. that column has no one's name in it !! [22:31:41] if you link me to the patch, I might be able to find some people to ask about it [22:32:00] Sure .. I am waiting for the the repository to clone [22:32:16] I will instead get the bugzilla listing instead. [22:32:41] https://bugzilla.wikimedia.org/show_bug.cgi?id=60524 [22:33:36] ok, so you plan to make a patch for this bug? [22:34:40] Umm .. I made the patch .. but not on the latest git rep [22:34:51] so waiting for it to download .. [23:10:15] (03PS12) 10Inchikutty: UploadWizard: OSM embedding: Geocoding, reverse geocoding [extensions/UploadWizard] (osm) - 10https://gerrit.wikimedia.org/r/116130 [23:13:14] (03PS13) 10Inchikutty: UploadWizard: OSM embedding: Geocoding, reverse geocoding [extensions/UploadWizard] (osm) - 10https://gerrit.wikimedia.org/r/116130 [23:28:54] (03CR) 10Bartosz Dziewoński: "Caused bug 62422 :(" [core] - 10https://gerrit.wikimedia.org/r/116067 (owner: 10Eranroz) [23:38:45] (03PS1) 10TheDJ: TableSorter: Improve detection and handling of isoDate [core] - 10https://gerrit.wikimedia.org/r/117808 [23:39:15] (03PS2) 10TheDJ: TableSorter: Improve detection and handling of isoDate [core] - 10https://gerrit.wikimedia.org/r/117808 [23:42:36] (03CR) 10MZMcBride: "I don't know what "NOQA" means. I checked and ." [tools/scap] - 10https://gerrit.wikimedia.org/r/114123 (owner: 10Ori.livneh) [23:44:49] (03CR) 10jenkins-bot: [V: 04-1] TableSorter: Improve detection and handling of isoDate [core] - 10https://gerrit.wikimedia.org/r/117808 (owner: 10TheDJ) [23:58:27] (03CR) 10MZMcBride: "Greg: I'm not sure who's available to review this change (Bryan T.M. seems pretty busy). Can you please add this to the agenda of an upcom" [extensions/PagedTiffHandler] - 10https://gerrit.wikimedia.org/r/86413 (owner: 10Brian Wolff) [23:58:55] "Multimedia Team"