[00:02:51] <grrrit-wm>	 (03CR) 10Bartosz Dziewoński: [C: 04-1] "Commented on the bug: https://bugzilla.wikimedia.org/show_bug.cgi?id=54965#c5 . This fix really belongs in OOjs, so I would suggest not me" [core] - 10https://gerrit.wikimedia.org/r/117241 (owner: 10Alex Monk)
[00:04:19] <grrrit-wm>	 (03PS1) 10Kaldari: Revert "Warn on account creation when username is adjusted" [core] (wmf/1.23wmf17) - 10https://gerrit.wikimedia.org/r/117348 
[00:04:42] <grrrit-wm>	 (03CR) 10Kaldari: [C: 032] Revert "Warn on account creation when username is adjusted" [core] (wmf/1.23wmf17) - 10https://gerrit.wikimedia.org/r/117348 (owner: 10Kaldari)
[00:09:08] <grrrit-wm>	 (03PS1) 10MarkTraceur: Some updates to ULS and VE [core] (wmf/1.23wmf17) - 10https://gerrit.wikimedia.org/r/117349 
[00:09:10] <grrrit-wm>	 (03Merged) 10jenkins-bot: Revert "Warn on account creation when username is adjusted" [core] (wmf/1.23wmf17) - 10https://gerrit.wikimedia.org/r/117348 (owner: 10Kaldari)
[00:10:50] <grrrit-wm>	 (03Abandoned) 10Alex Monk: Set body height to 100% in monobook [core] - 10https://gerrit.wikimedia.org/r/117241 (owner: 10Alex Monk)
[00:11:25] <grrrit-wm>	 (03PS1) 10MarkTraceur: Fix logic error in VE [core] (wmf/1.23wmf16) - 10https://gerrit.wikimedia.org/r/117350 
[00:12:32] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] Fix logic error in VE [core] (wmf/1.23wmf16) - 10https://gerrit.wikimedia.org/r/117350 (owner: 10MarkTraceur)
[00:12:47] <rdwrer>	 ...what
[00:13:04] <rdwrer>	 Aauuuugghhhhh
[00:13:18] <hoo>	 rdwrer: Happens occasionally
[00:13:32] <grrrit-wm>	 (03PS2) 10MarkTraceur: Fix logic error in VE [core] (wmf/1.23wmf16) - 10https://gerrit.wikimedia.org/r/117350 
[00:13:34] <hoo>	 just rebase or change the commit message or beat jenkins with a baseball bat
[00:13:37] <rdwrer>	 I didn't update it or something
[00:17:33] <grrrit-wm>	 (03PS1) 10Chad: Remove references to SearchUpdate class, we don't use that [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/117351 
[00:22:59] <grrrit-wm>	 (03PS3) 10Krinkle: Update VisualEditor submodule to fix logic error (412396ce86) [core] (wmf/1.23wmf16) - 10https://gerrit.wikimedia.org/r/117350 (owner: 10MarkTraceur)
[00:24:38] <grrrit-wm>	 (03CR) 10Krinkle: "I'd recommend removing the unused code from CodeEditor." [core] - 10https://gerrit.wikimedia.org/r/110347 (owner: 10Helder.wiki)
[00:27:39] <grrrit-wm>	 (03PS2) 10Krinkle: Update lessphp to b7cd5c79e8 [core] - 10https://gerrit.wikimedia.org/r/117160 (owner: 10Ori.livneh)
[00:29:28] <grrrit-wm>	 (03CR) 10Krinkle: [C: 031] "Good to go. @Ori: Not merging just yet before I make sure you're okay with this actually going in at this time." [core] - 10https://gerrit.wikimedia.org/r/117160 (owner: 10Ori.livneh)
[00:29:32] <Krinkle>	 ori: ^
[00:35:29] <grrrit-wm>	 (03CR) 10Krinkle: [C: 04-1] "Avoid empty(). Especially this much. Please be much more explicit in your intention to avoid bugs and undetectable hazards in the future." [core] - 10https://gerrit.wikimedia.org/r/117309 (owner: 10Thiemo Mättig (WMDE))
[00:35:43] <grrrit-wm>	 (03PS1) 10JGonera: Update MobileFrontend [core] (wmf/1.23wmf16) - 10https://gerrit.wikimedia.org/r/117355 
[00:36:30] <James_F>	 rdwrer: BTW, don't forget https://gerrit.wikimedia.org/r/#/c/117344/ – 'twould be sad.
[00:36:56] <grrrit-wm>	 (03CR) 10Kaldari: [C: 032] Update MobileFrontend [core] (wmf/1.23wmf16) - 10https://gerrit.wikimedia.org/r/117355 (owner: 10JGonera)
[00:37:21] <rdwrer>	 James_F: I have three patches open ready to merge
[00:37:37] <James_F>	 rdwrer: Awesome. :-)
[00:38:55] <grrrit-wm>	 (03PS5) 10Bsitu: Have post/header revisions reference rev_type/rev_type_id [extensions/Flow] - 10https://gerrit.wikimedia.org/r/117099 
[00:38:58] <grrrit-wm>	 (03PS5) 10Bsitu: [WIP]flow_revision - add new column rev_type_id [extensions/Flow] - 10https://gerrit.wikimedia.org/r/116861 
[00:39:01] <grrrit-wm>	 (03PS5) 10Bsitu: Update flow_revision.rev_type_id [extensions/Flow] - 10https://gerrit.wikimedia.org/r/116874 
[00:39:04] <grrrit-wm>	 (03PS1) 10Bsitu: Add summary revision type [extensions/Flow] - 10https://gerrit.wikimedia.org/r/117357 
[00:39:44] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] Add summary revision type [extensions/Flow] - 10https://gerrit.wikimedia.org/r/117357 (owner: 10Bsitu)
[00:40:15] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] [WIP]flow_revision - add new column rev_type_id [extensions/Flow] - 10https://gerrit.wikimedia.org/r/116861 (owner: 10Bsitu)
[00:41:21] <grrrit-wm>	 (03Merged) 10jenkins-bot: Update MobileFrontend [core] (wmf/1.23wmf16) - 10https://gerrit.wikimedia.org/r/117355 (owner: 10JGonera)
[00:42:05] <grrrit-wm>	 (03PS1) 10JGonera: Update MobileFrontend [core] (wmf/1.23wmf17) - 10https://gerrit.wikimedia.org/r/117359 
[00:42:28] <grrrit-wm>	 (03CR) 10Kaldari: [C: 032] Update MobileFrontend [core] (wmf/1.23wmf17) - 10https://gerrit.wikimedia.org/r/117359 (owner: 10JGonera)
[00:43:15] <grrrit-wm>	 (03CR) 10Krinkle: "Since there is no bug report, could you describe briefly why it was broken and how this fixes it? It seems like one logic is replaced with" (032 comments) [core] - 10https://gerrit.wikimedia.org/r/117309 (owner: 10Thiemo Mättig (WMDE))
[00:45:08] <grrrit-wm>	 (03CR) 10Krinkle: [C: 04-1] Insert link dialog: Insert simplest form of wikilinks possible (031 comment) [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/69896 (owner: 10Alex Monk)
[00:45:33] <grrrit-wm>	 (03CR) 10Krinkle: Insert link dialog: Insert simplest form of wikilinks possible (031 comment) [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/69896 (owner: 10Alex Monk)
[00:45:49] <Krenair>	 Krinkle, I pretty much decided at this point that this commit isn't worth the fuss
[00:46:58] <grrrit-wm>	 (03Merged) 10jenkins-bot: Update MobileFrontend [core] (wmf/1.23wmf17) - 10https://gerrit.wikimedia.org/r/117359 (owner: 10JGonera)
[00:50:14] <grrrit-wm>	 (03CR) 10MarkTraceur: [C: 032 V: 032] Some updates to ULS and VE [core] (wmf/1.23wmf17) - 10https://gerrit.wikimedia.org/r/117349 (owner: 10MarkTraceur)
[00:50:17] <grrrit-wm>	 (03CR) 10MarkTraceur: [C: 032 V: 032] Update VisualEditor submodule to fix logic error (412396ce86) [core] (wmf/1.23wmf16) - 10https://gerrit.wikimedia.org/r/117350 (owner: 10MarkTraceur)
[00:54:14] <grrrit-wm>	 (03CR) 10MarkTraceur: [C: 032] Update VisualEditor submodule to fix logic error (412396ce86) [core] (wmf/1.23wmf16) - 10https://gerrit.wikimedia.org/r/117350 (owner: 10MarkTraceur)
[00:54:17] <grrrit-wm>	 (03CR) 10MarkAHershberger: "is_readable() "Tells whether a file exists and is readable" http://us3.php.net/manual/en/function.is-readable.php so only one is needed." [core] - 10https://gerrit.wikimedia.org/r/117022 (owner: 10Umherirrender)
[00:54:20] <rdwrer>	 Ugh, fucking...patchsets
[00:55:46] <grrrit-wm>	 (03CR) 10MarkAHershberger: [C: 04-1] LocalSettings.php must be readable by the server [core] - 10https://gerrit.wikimedia.org/r/117022 (owner: 10Umherirrender)
[00:57:28] <grrrit-wm>	 (03Merged) 10jenkins-bot: Some updates to ULS and VE [core] (wmf/1.23wmf17) - 10https://gerrit.wikimedia.org/r/117349 (owner: 10MarkTraceur)
[01:00:41] <grrrit-wm>	 (03CR) 10Chad: "Yeah, I'd just swap the file_exists() call above for is_readable() and handle it all at once." [core] - 10https://gerrit.wikimedia.org/r/117022 (owner: 10Umherirrender)
[01:01:47] <grrrit-wm>	 (03PS4) 10Hiong3-eng5: API ow_express 1.1 initial changes [extensions/WikiLexicalData] - 10https://gerrit.wikimedia.org/r/116459 
[01:05:40] <grrrit-wm>	 (03Merged) 10jenkins-bot: Update VisualEditor submodule to fix logic error (412396ce86) [core] (wmf/1.23wmf16) - 10https://gerrit.wikimedia.org/r/117350 (owner: 10MarkTraceur)
[01:10:23] <grrrit-wm>	 (03PS1) 10MaxSem: WIP: HHVM support [php/wikidiff2] - 10https://gerrit.wikimedia.org/r/117362 
[01:16:42] <grrrit-wm>	 (03CR) 10Mattflaschen: "It's not unrelated, but it was fixed in patch set 3." [extensions/GettingStarted] - 10https://gerrit.wikimedia.org/r/115176 (owner: 10Phuedx)
[01:19:56] <grrrit-wm>	 (03CR) 10Hashar: "If you guys have any idea how to test hhvm support for wikidiff2, I will be more than happy to craft a job for it. We have hhvm installed" [php/wikidiff2] - 10https://gerrit.wikimedia.org/r/117362 (owner: 10MaxSem)
[01:31:44] <grrrit-wm>	 (03PS1) 10MarkTraceur: Update ULS to fix James_F's mistake [core] (wmf/1.23wmf17) - 10https://gerrit.wikimedia.org/r/117368 
[01:32:36] <James_F>	 rdwrer: :-P
[01:33:26] <grrrit-wm>	 (03PS6) 10Bsitu: [WIP]flow_revision - add new column rev_type_id [extensions/Flow] - 10https://gerrit.wikimedia.org/r/116861 
[01:34:31] <grrrit-wm>	 (03CR) 10MarkTraceur: [C: 032] Update ULS to fix James_F's mistake [core] (wmf/1.23wmf17) - 10https://gerrit.wikimedia.org/r/117368 (owner: 10MarkTraceur)
[01:36:38] <grrrit-wm>	 (03CR) 10Bsitu: Update flow_revision.rev_type_id (031 comment) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/116874 (owner: 10Bsitu)
[01:38:08] <grrrit-wm>	 (03PS4) 10Bencmq: Allow extension of post interaction links [extensions/Flow] - 10https://gerrit.wikimedia.org/r/115552 (owner: 10Wctaiwan)
[01:38:18] <grrrit-wm>	 (03Merged) 10jenkins-bot: Update ULS to fix James_F's mistake [core] (wmf/1.23wmf17) - 10https://gerrit.wikimedia.org/r/117368 (owner: 10MarkTraceur)
[01:49:52] <rdwrer>	 http://devopsreactions.tumblr.com/post/75576729444/explaining-how-git-gerrit-and-jenkins-work-together <3
[01:52:31] <grrrit-wm>	 (03PS1) 10Aaron Schulz: Redid WhatLinksHere query and added a _from_namespace field [core] - 10https://gerrit.wikimedia.org/r/117373 
[01:54:35] <grrrit-wm>	 (03PS11) 10Bencmq: Add "Thanks" for comments on Flow boards [extensions/Thanks] - 10https://gerrit.wikimedia.org/r/115557 (owner: 10Wctaiwan)
[01:55:50] <grrrit-wm>	 (03CR) 10Bencmq: "The relevant CSS classes for the thanks link were no longer passed down from Flow, based on suggestions from https://gerrit.wikimedia.org/" [extensions/Thanks] - 10https://gerrit.wikimedia.org/r/115557 (owner: 10Wctaiwan)
[01:56:45] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] Redid WhatLinksHere query and added a _from_namespace field [core] - 10https://gerrit.wikimedia.org/r/117373 (owner: 10Aaron Schulz)
[02:00:13] <donatello>	 does anyone know what ULS refers to?
[02:00:25] <donatello>	 trying to go through this bug https://bugzilla.wikimedia.org/show_bug.cgi?id=40379
[02:00:37] <donatello>	 and someone referenced that users can set their language using ULS as well
[02:01:30] <donatello>	 possibly universal language selector?
[02:01:52] <donatello>	 nvm found it on the wikimedia wiki
[02:05:18] <grrrit-wm>	 (03PS2) 10Aaron Schulz: Redid WhatLinksHere query and added a _from_namespace field [core] - 10https://gerrit.wikimedia.org/r/117373 
[02:09:19] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] Redid WhatLinksHere query and added a _from_namespace field [core] - 10https://gerrit.wikimedia.org/r/117373 (owner: 10Aaron Schulz)
[02:11:16] <grrrit-wm>	 (03CR) 10Wctaiwan: "I was subsequently able to reporoduce the bug with Thanked state (same as comment 7 at https://gerrit.wikimedia.org/r/#/c/60914/). Since t" [extensions/Thanks] - 10https://gerrit.wikimedia.org/r/115557 (owner: 10Wctaiwan)
[02:21:43] <kaldari>	 Risker: You around?
[02:23:40] <kaldari>	 Risker: can you hear me now?
[02:24:20] <kaldari>	 hmm, this IRC thing doesn't seem to be working :P
[02:25:27] <grrrit-wm>	 (03PS3) 10Aaron Schulz: Redid WhatLinksHere query and added a _from_namespace field [core] - 10https://gerrit.wikimedia.org/r/117373 
[02:29:21] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] Redid WhatLinksHere query and added a _from_namespace field [core] - 10https://gerrit.wikimedia.org/r/117373 (owner: 10Aaron Schulz)
[02:29:56] <grrrit-wm>	 (03CR) 10Bsitu: "Tested and it worked fine. I don't see a better approach to filter based on namespace in current data schema" (032 comments) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/115908 (owner: 10Matthias Mullie)
[02:51:38] <grrrit-wm>	 (03PS4) 10Aaron Schulz: Redid WhatLinksHere query and added a _from_namespace field [core] - 10https://gerrit.wikimedia.org/r/117373 
[02:54:04] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] Redid WhatLinksHere query and added a _from_namespace field [core] - 10https://gerrit.wikimedia.org/r/117373 (owner: 10Aaron Schulz)
[03:02:32] <grrrit-wm>	 (03CR) 10Parent5446: "@Isarra, the bug in the commit message is the original bug being fixed. I don't think there's a bug report for the "issue" that was caused" [core] - 10https://gerrit.wikimedia.org/r/117247 (owner: 10Bartosz Dziewoński)
[03:03:55] <grrrit-wm>	 (03PS5) 10Aaron Schulz: Redid WhatLinksHere query and added a _from_namespace field [core] - 10https://gerrit.wikimedia.org/r/117373 
[03:07:00] <grrrit-wm>	 (03CR) 10Manybubbles: "Chad," [vagrant] - 10https://gerrit.wikimedia.org/r/115679 (owner: 10Manybubbles)
[03:34:21] <grrrit-wm>	 (03PS1) 10EBernhardson: Handle exceptions when testing row validity [core] - 10https://gerrit.wikimedia.org/r/117378 
[03:41:33] <grrrit-wm>	 (03CR) 10Bsitu: [C: 04-2] Have post/header revisions reference rev_type/rev_type_id [extensions/Flow] - 10https://gerrit.wikimedia.org/r/117099 (owner: 10Bsitu)
[04:14:06] <grrrit-wm>	 (03CR) 10Mattflaschen: [C: 04-1] "When you deprecate something, please remove uses of it at least in the same repository, unless that's really infeasible for some reason (w" (032 comments) [core] - 10https://gerrit.wikimedia.org/r/117105 (owner: 10Kaldari)
[04:19:44] <grrrit-wm>	 (03PS2) 10Mattflaschen: Make .mw-ui-button height the same for all buttons [core] - 10https://gerrit.wikimedia.org/r/117107 (owner: 10JGonera)
[04:27:55] <grrrit-wm>	 (03CR) 10Isarra: "Ah, didn't see that for some reason." [core] - 10https://gerrit.wikimedia.org/r/117247 (owner: 10Bartosz Dziewoński)
[04:29:00] <grrrit-wm>	 (03CR) 10Isarra: "And yeah, the issues without js have been greatly overstated, especially on the mailing list. The basic functionality is definitely there," [core] - 10https://gerrit.wikimedia.org/r/117247 (owner: 10Bartosz Dziewoński)
[04:38:45] <grrrit-wm>	 (03CR) 10Ori.livneh: "Yep, fine by me." [core] - 10https://gerrit.wikimedia.org/r/117160 (owner: 10Ori.livneh)
[04:42:34] <grrrit-wm>	 (03CR) 10Chad: "Yeah I was trying to follow the README but I know nothing about Ruby and got stuck in dependency hell :(" [vagrant] - 10https://gerrit.wikimedia.org/r/115679 (owner: 10Manybubbles)
[04:46:01] <grrrit-wm>	 (03PS1) 10Chad: Bump CirrusSearch to 0.2 [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/117379 
[05:10:52] <grrrit-wm>	 (03CR) 10Mattflaschen: [C: 031] "The height is right, but the bevels no longer cover the bottom part of the very left and right of the button in Firefox 23.0 (since that's" [core] - 10https://gerrit.wikimedia.org/r/117107 (owner: 10JGonera)
[05:13:12] <grrrit-wm>	 (03CR) 10Andrew Bogott: [C: 032] Make special/SpecialNovaProxy.php region-aware. [extensions/OpenStackManager] - 10https://gerrit.wikimedia.org/r/116998 (owner: 10Andrew Bogott)
[05:13:16] <grrrit-wm>	 (03Merged) 10jenkins-bot: Make special/SpecialNovaProxy.php region-aware. [extensions/OpenStackManager] - 10https://gerrit.wikimedia.org/r/116998 (owner: 10Andrew Bogott)
[05:18:50] <grrrit-wm>	 (03CR) 10Mattflaschen: [C: 04-1] "There's some more stuff to move." (031 comment) [core] - 10https://gerrit.wikimedia.org/r/117108 (owner: 10JGonera)
[06:00:15] <grrrit-wm>	 (03PS1) 10Andrew Bogott: Remove 'create proxy' link from the project header. [extensions/OpenStackManager] - 10https://gerrit.wikimedia.org/r/117381 
[06:02:33] <grrrit-wm>	 (03CR) 10Andrew Bogott: [V: 032] Remove 'create proxy' link from the project header. [extensions/OpenStackManager] - 10https://gerrit.wikimedia.org/r/117381 (owner: 10Andrew Bogott)
[06:04:00] <grrrit-wm>	 (03CR) 10Andrew Bogott: [C: 032] Remove 'create proxy' link from the project header. [extensions/OpenStackManager] - 10https://gerrit.wikimedia.org/r/117381 (owner: 10Andrew Bogott)
[06:17:12] <grrrit-wm>	 (03CR) 10Ryan Lane: "Minor nitpick. It looks good otherwise." (031 comment) [extensions/OpenStackManager] - 10https://gerrit.wikimedia.org/r/116998 (owner: 10Andrew Bogott)
[06:51:49] <grrrit-wm>	 (03PS1) 10EBernhardson: Show who moderated the most recent revision [extensions/Flow] - 10https://gerrit.wikimedia.org/r/117382 
[06:52:44] <grrrit-wm>	 (03CR) 10Gergő Tisza: Embedding leaflet maps based on OSM data to UploadWizard (031 comment) [extensions/UploadWizard] (osm) - 10https://gerrit.wikimedia.org/r/116129 (owner: 10Inchikutty)
[07:02:55] <grrrit-wm>	 (03PS5) 10EBernhardson: Make BoardHistory a Formatter instance [extensions/Flow] - 10https://gerrit.wikimedia.org/r/115532 
[07:02:58] <grrrit-wm>	 (03PS5) 10EBernhardson: Sort the combined header+topic revisions after merging [extensions/Flow] - 10https://gerrit.wikimedia.org/r/115531 
[07:03:01] <grrrit-wm>	 (03PS5) 10EBernhardson: Split reusable parts out of ContributionsQuery [extensions/Flow] - 10https://gerrit.wikimedia.org/r/115530 
[07:03:04] <grrrit-wm>	 (03PS3) 10EBernhardson: Make FlowActions accessible from permissions [extensions/Flow] - 10https://gerrit.wikimedia.org/r/116674 
[07:03:07] <grrrit-wm>	 (03PS3) 10EBernhardson: Add method to inject a workflow into the urlgenerators workflow cache [extensions/Flow] - 10https://gerrit.wikimedia.org/r/116673 
[07:03:10] <grrrit-wm>	 (03PS1) 10EBernhardson: Combine various history actions [extensions/Flow] - 10https://gerrit.wikimedia.org/r/117383 
[07:03:13] <grrrit-wm>	 (03PS1) 10EBernhardson: Refactor Flow\\Formatter namespace [extensions/Flow] - 10https://gerrit.wikimedia.org/r/117384 
[07:03:16] <grrrit-wm>	 (03CR) 10Gergő Tisza: [C: 04-1] "Some minor issues with documentation and control flow." (034 comments) [extensions/UploadWizard] (osm) - 10https://gerrit.wikimedia.org/r/116129 (owner: 10Inchikutty)
[07:03:24] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] Split reusable parts out of ContributionsQuery [extensions/Flow] - 10https://gerrit.wikimedia.org/r/115530 (owner: 10EBernhardson)
[07:05:09] <grrrit-wm>	 (03PS6) 10EBernhardson: Split re-usable parts out of ContributionsQuery [extensions/Flow] - 10https://gerrit.wikimedia.org/r/115530 
[07:05:37] <grrrit-wm>	 (03PS6) 10EBernhardson: Sort the combined header+topic revisions after merging [extensions/Flow] - 10https://gerrit.wikimedia.org/r/115531 
[07:05:42] <grrrit-wm>	 (03PS4) 10EBernhardson: Add method to inject a workflow into the urlgenerators workflow cache [extensions/Flow] - 10https://gerrit.wikimedia.org/r/116673 
[07:05:46] <grrrit-wm>	 (03PS4) 10EBernhardson: Make FlowActions accessible from permissions [extensions/Flow] - 10https://gerrit.wikimedia.org/r/116674 
[07:05:49] <grrrit-wm>	 (03PS2) 10EBernhardson: Combine various history actions [extensions/Flow] - 10https://gerrit.wikimedia.org/r/117383 
[07:05:53] <grrrit-wm>	 (03PS2) 10EBernhardson: Refactor Flow\\Formatter namespace [extensions/Flow] - 10https://gerrit.wikimedia.org/r/117384 
[07:05:57] <grrrit-wm>	 (03PS6) 10EBernhardson: Make BoardHistory a Formatter instance [extensions/Flow] - 10https://gerrit.wikimedia.org/r/115532 
[07:06:05] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] Make FlowActions accessible from permissions [extensions/Flow] - 10https://gerrit.wikimedia.org/r/116674 (owner: 10EBernhardson)
[07:10:00] <grrrit-wm>	 (03CR) 10Mattflaschen: [C: 032] "Patch set 3 looks good." [extensions/GettingStarted] - 10https://gerrit.wikimedia.org/r/117174 (owner: 10Phuedx)
[07:10:04] <grrrit-wm>	 (03Merged) 10jenkins-bot: Focus the primary button when the CTA is shown [extensions/GettingStarted] - 10https://gerrit.wikimedia.org/r/117174 (owner: 10Phuedx)
[07:23:30] <grrrit-wm>	 (03PS1) 10Nikerabbit: [WIP] LU rewrite [extensions/LocalisationUpdate] (json-rewrite) - 10https://gerrit.wikimedia.org/r/117385 
[07:23:33] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] [WIP] LU rewrite [extensions/LocalisationUpdate] (json-rewrite) - 10https://gerrit.wikimedia.org/r/117385 (owner: 10Nikerabbit)
[07:54:28] <grrrit-wm>	 (03CR) 10Mattflaschen: [C: 04-1] "Okay, except that cancel link still has destructive. As noted, this contradicts the style guide." [core] - 10https://gerrit.wikimedia.org/r/116725 (owner: 10Deepali)
[08:01:23] <grrrit-wm>	 (03CR) 10Gergő Tisza: Embedding leaflet maps based on OSM data to UploadWizard (031 comment) [extensions/UploadWizard] (osm) - 10https://gerrit.wikimedia.org/r/116129 (owner: 10Inchikutty)
[08:02:35] <grrrit-wm>	 (03CR) 10Mattflaschen: "Just for clarity, quiet neutral means:" [core] - 10https://gerrit.wikimedia.org/r/116725 (owner: 10Deepali)
[08:03:41] <grrrit-wm>	 (03CR) 10JGonera: "We could possibly use only border-top and border-bottom." [core] - 10https://gerrit.wikimedia.org/r/117107 (owner: 10JGonera)
[08:12:42] <grrrit-wm>	 (03PS1) 10Andrew Bogott: Prevent proxy creation in read-only regions. [extensions/OpenStackManager] - 10https://gerrit.wikimedia.org/r/117386 
[08:17:59] <grrrit-wm>	 (03PS2) 10Andrew Bogott: Prevent proxy creation in read-only regions. [extensions/OpenStackManager] - 10https://gerrit.wikimedia.org/r/117386 
[08:18:32] <grrrit-wm>	 (03CR) 10Andrew Bogott: [C: 032 V: 032] Prevent proxy creation in read-only regions. [extensions/OpenStackManager] - 10https://gerrit.wikimedia.org/r/117386 (owner: 10Andrew Bogott)
[08:18:46] <grrrit-wm>	 (03CR) 10Gergő Tisza: "This looks great!" (032 comments) [extensions/UploadWizard] (osm) - 10https://gerrit.wikimedia.org/r/116130 (owner: 10Inchikutty)
[08:21:31] <grrrit-wm>	 (03PS5) 10Nemo bis: UploadWizard: OSM embedding: Geocoding, reverse geocoding [extensions/UploadWizard] (osm) - 10https://gerrit.wikimedia.org/r/116130 (owner: 10Inchikutty)
[08:23:18] <grrrit-wm>	 (03CR) 10Gergő Tisza: "Overall, this is pretty close to where it could be merged back into master. (I still think a larger map would be an improvement, but the c" [extensions/UploadWizard] (osm) - 10https://gerrit.wikimedia.org/r/116130 (owner: 10Inchikutty)
[08:25:00] <grrrit-wm>	 (03PS1) 10Andrew Bogott: A couple of minor fixes to proxy special page. [extensions/OpenStackManager] - 10https://gerrit.wikimedia.org/r/117387 
[08:25:44] <grrrit-wm>	 (03CR) 10Andrew Bogott: [C: 032 V: 032] A couple of minor fixes to proxy special page. [extensions/OpenStackManager] - 10https://gerrit.wikimedia.org/r/117387 (owner: 10Andrew Bogott)
[08:38:02] <grrrit-wm>	 (03PS1) 10Andrew Bogott: Use array_key_exists instead of in_array [extensions/OpenStackManager] - 10https://gerrit.wikimedia.org/r/117388 
[08:38:47] <grrrit-wm>	 (03CR) 10Andrew Bogott: [C: 032 V: 032] Use array_key_exists instead of in_array [extensions/OpenStackManager] - 10https://gerrit.wikimedia.org/r/117388 (owner: 10Andrew Bogott)
[08:45:22] <grrrit-wm>	 (03CR) 10Nikerabbit: "Why are you skipping Jenkins and self-merging in an extension used by WMF?" [extensions/OpenStackManager] - 10https://gerrit.wikimedia.org/r/117388 (owner: 10Andrew Bogott)
[08:47:50] <grrrit-wm>	 (03CR) 10Andrew Bogott: "Jenkins has never, ever given a +2 to a patch in this project, so I'm in the habit." [extensions/OpenStackManager] - 10https://gerrit.wikimedia.org/r/117388 (owner: 10Andrew Bogott)
[08:49:54] <grrrit-wm>	 (03CR) 10Nikerabbit: "Given https://gerrit.wikimedia.org/r/#/c/116998/ it indeed looks like you are not on the whitelist which allows Jenkins to run tests befor" [extensions/OpenStackManager] - 10https://gerrit.wikimedia.org/r/117388 (owner: 10Andrew Bogott)
[08:52:33] <grrrit-wm>	 (03CR) 10Andrew Bogott: "Ah, ok. When I +2/submit a patch, gerrit scolds me and then merges afterwards anyway... I guess that's because Jenkins is running after t" [extensions/OpenStackManager] - 10https://gerrit.wikimedia.org/r/117388 (owner: 10Andrew Bogott)
[09:00:19] <grrrit-wm>	 (03CR) 10Mattflaschen: [C: 04-1] "It would be nice to make all the icons the same size, if possible (maybe through changing the amount of whitespace in the SVG itself)." [extensions/GettingStarted] - 10https://gerrit.wikimedia.org/r/116969 (owner: 10Phuedx)
[09:02:35] <grrrit-wm>	 (03CR) 10Nemo bis: "In theory you already are on the whitelist AFAICS, having a @wikimedia.org address: https://git.wikimedia.org/blob/integration%2Fzuul-conf" [extensions/OpenStackManager] - 10https://gerrit.wikimedia.org/r/117388 (owner: 10Andrew Bogott)
[09:06:54] <grrrit-wm>	 (03PS1) 10Nemo bis: Typofix [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/117389 
[09:08:04] <grrrit-wm>	 (03CR) 10Mattflaschen: "Jon, in the future please add the original developer as a reviewer in reverts." [core] - 10https://gerrit.wikimedia.org/r/117234 (owner: 10Jdlrobson)
[09:09:43] <grrrit-wm>	 (03PS1) 1001tonythomas: Changed CSS of input#wpSummary from width:80% to width:100% [core] - 10https://gerrit.wikimedia.org/r/117390 
[09:12:01] <grrrit-wm>	 (03PS2) 1001tonythomas: Changed CSS of input#wpSummary from width:80% to width:100% [core] - 10https://gerrit.wikimedia.org/r/117390 
[09:12:41] <grrrit-wm>	 (03CR) 10Mattflaschen: "Ready for review" [core] - 10https://gerrit.wikimedia.org/r/114080 (owner: 10Mattflaschen)
[09:15:19] <grrrit-wm>	 (03CR) 10Bartosz Dziewoński: "This also makes the input move to its own line after its description." [core] - 10https://gerrit.wikimedia.org/r/117390 (owner: 1001tonythomas)
[09:16:46] <tonythomas>	 MatmaRex: Thats an advantage right ?
[09:17:34] <MatmaRex>	 tonythomas: it's a change :) no idea if it's for the better
[09:17:45] <MatmaRex>	 tonythomas: i assume there was a reason why this was done in this way
[09:18:28] <tonythomas>	 MatmaRex: That was unintentional though, I think 
[09:19:00] <MatmaRex>	 i have no idea
[09:19:56] <tonythomas>	 ok :) lets wait for the reporter 
[09:27:01] <grrrit-wm>	 (03PS5) 10Hiong3-eng5: API ow_express 1.1 initial changes [extensions/WikiLexicalData] - 10https://gerrit.wikimedia.org/r/116459 
[09:32:21] <grrrit-wm>	 (03PS1) 10Hiong3-eng5: API cache output for owDefine [extensions/WikiLexicalData] - 10https://gerrit.wikimedia.org/r/117393 
[09:33:48] <grrrit-wm>	 (03CR) 10Mattflaschen: "Right, however if we go that route, it won't be the same width, right?" [core] - 10https://gerrit.wikimedia.org/r/117107 (owner: 10JGonera)
[10:08:42] <grrrit-wm>	 (03PS2) 10leucosticte: Make the following fields int unsigned: *change_tag.ct_rc_id *change_tag.ct_log_id *change_tag.ct_rev_id *filearchive.fa_id *filearchive.fa_deleted_user *ipblocks.ipb_id *page_props.pp_page *page_restrictions.pr_page *recentchanges.rc_id *tag_summary.ts_r [core] - 10https://gerrit.wikimedia.org/r/112825 
[10:09:35] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] Make the following fields int unsigned: *change_tag.ct_rc_id *change_tag.ct_log_id *change_tag.ct_rev_id *filearchive.fa_id *filearchive.fa_deleted_user *ipblocks.ipb_id *page_props.pp_page *page_restrictions.pr_page *recentchanges.rc_id *tag_summary.ts_r [core] - 10https://gerrit.wikimedia.org/r/112825 (owner: 10leucosticte)
[10:22:52] <grrrit-wm>	 (03PS1) 10Aude: Merge "Add visibility in PoolCounter classes" [core] - 10https://gerrit.wikimedia.org/r/117396 
[10:23:03] <aude>	 gah
[10:26:41] <grrrit-wm>	 (03PS3) 10leucosticte: Make the following fields int unsigned: *change_tag.ct_rc_id *change_tag.ct_log_id *change_tag.ct_rev_id *filearchive.fa_id *filearchive.fa_deleted_user *ipblocks.ipb_id *page_props.pp_page *page_restrictions.pr_page *recentchanges.rc_id *tag_summary.ts_r [core] - 10https://gerrit.wikimedia.org/r/112825 
[10:26:50] <grrrit-wm>	 (03Abandoned) 10Aude: Merge "Add visibility in PoolCounter classes" [core] - 10https://gerrit.wikimedia.org/r/117396 (owner: 10Aude)
[10:28:09] <grrrit-wm>	 (03PS11) 10Aude: Add BaseTemplateAfterPortlet hook to add html after portlets [core] - 10https://gerrit.wikimedia.org/r/101895 
[10:29:02] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] Add BaseTemplateAfterPortlet hook to add html after portlets [core] - 10https://gerrit.wikimedia.org/r/101895 (owner: 10Aude)
[10:29:12] <Luxo>	 Hi. I've a question abot git, I've pushed my tool global user contributions to https://git.wikimedia.org/summary/labs%2Ftools%2Fguc.git  I'm using git the first time, maybe I'm doing something wrong.. is it normal that I can just push new branches, that I'm not allowed to push into master or my previous pushs?
[10:29:37] <aude>	 Luxo: that's normal
[10:29:49] <aude>	 you can use git review or think permissions cna be changed
[10:30:11] <aude>	 https://www.mediawiki.org/wiki/Gerrit/git-review
[10:31:08] <Luxo>	 aude: ok thx.
[10:34:26] <grrrit-wm>	 (03PS12) 10Aude: Add BaseTemplateAfterPortlet hook to add html after portlets [core] - 10https://gerrit.wikimedia.org/r/101895 
[10:35:11] <grrrit-wm>	 (03PS2) 10Thiemo Mättig (WMDE): Fix Status::getMessage accidentially returning string instead of Message [core] - 10https://gerrit.wikimedia.org/r/117309 
[10:35:14] <Alina-malina>	 anyone doing video editing stuff here?
[10:46:56] <p858snake|l>	 aude: git push permissions are heardly given, because it means that gerrit misses the commits all together
[10:53:51] <grrrit-wm>	 (03PS2) 10Siebrand: Remove link to edits with Oversight from Special:Contributions [extensions/Oversight] - 10https://gerrit.wikimedia.org/r/117243 (owner: 10Alex Monk)
[10:55:24] <grrrit-wm>	 (03CR) 10Siebrand: [C: 031] "i18n/L10n reviewed." [extensions/Oversight] - 10https://gerrit.wikimedia.org/r/117243 (owner: 10Alex Monk)
[10:55:47] <grrrit-wm>	 (03Abandoned) 10Siebrand: Use 'brackets' message instead of hard coded brackets [core] - 10https://gerrit.wikimedia.org/r/100184 (owner: 10Siebrand)
[10:56:02] <grrrit-wm>	 (03Abandoned) 10Siebrand: New collation: zh-zhuyin (bopomofo). [core] (chinese-collation) - 10https://gerrit.wikimedia.org/r/48798 (owner: 10Siebrand)
[10:58:37] <grrrit-wm>	 (03CR) 10Siebrand: "Removing myself from reviewers. This is not the code I generally review. Please only add me as reviewer to i18n/L10n related patch sets." [core] - 10https://gerrit.wikimedia.org/r/59522 (owner: 10Alexia)
[10:59:35] <grrrit-wm>	 (03Abandoned) 10Siebrand: Altered the time separator for Slovene from colon to period [core] - 10https://gerrit.wikimedia.org/r/109658 (owner: 10Arav93)
[11:00:23] <grrrit-wm>	 (03PS2) 10Hashar: Enable JIT for unit tests in HHVM [integration/jenkins] - 10https://gerrit.wikimedia.org/r/117226 (owner: 10EBernhardson)
[11:22:33] <grrrit-wm>	 (03CR) 10Helder.wiki: [C: 031] "It is already on its own line, at least on enwiki, frwiki, ptwiki and plwiki:" [core] - 10https://gerrit.wikimedia.org/r/117390 (owner: 1001tonythomas)
[11:28:19] <grrrit-wm>	 (03CR) 10Hashar: [C: 032] "Lets try! :-]" [integration/jenkins] - 10https://gerrit.wikimedia.org/r/117226 (owner: 10EBernhardson)
[11:28:22] <grrrit-wm>	 (03Merged) 10jenkins-bot: Enable JIT for unit tests in HHVM [integration/jenkins] - 10https://gerrit.wikimedia.org/r/117226 (owner: 10EBernhardson)
[11:28:28] <grrrit-wm>	 (03CR) 10Siebrand: [C: 031] "i18n/L10n reviewed." [extensions/SpamBlacklist] - 10https://gerrit.wikimedia.org/r/117231 (owner: 10Jackmcbarn)
[11:28:44] <grrrit-wm>	 (03CR) 10Hashar: "Note that change made to integration/jenkins.git repository can be deployed by anyone from tin /srv/deployment/integration/slave-scripts" [integration/jenkins] - 10https://gerrit.wikimedia.org/r/117226 (owner: 10EBernhardson)
[11:44:04] <grrrit-wm>	 (03PS1) 10Hashar: HHVM opcache in workspace [integration/jenkins] - 10https://gerrit.wikimedia.org/r/117405 
[11:44:31] <grrrit-wm>	 (03CR) 10Hashar: [C: 032] HHVM opcache in workspace [integration/jenkins] - 10https://gerrit.wikimedia.org/r/117405 (owner: 10Hashar)
[11:44:34] <grrrit-wm>	 (03Merged) 10jenkins-bot: HHVM opcache in workspace [integration/jenkins] - 10https://gerrit.wikimedia.org/r/117405 (owner: 10Hashar)
[11:45:20] <grrrit-wm>	 (03CR) 10Hashar: "A nice side effect is that the tests are passing, more precisely they no more segfault." [integration/jenkins] - 10https://gerrit.wikimedia.org/r/117226 (owner: 10EBernhardson)
[11:54:59] <grrrit-wm>	 (03CR) 10Hashar: [C: 032] "Thanks!" [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/117389 (owner: 10Nemo bis)
[11:55:05] <grrrit-wm>	 (03Merged) 10jenkins-bot: Typofix [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/117389 (owner: 10Nemo bis)
[11:58:06] <grrrit-wm>	 (03CR) 10Phuedx: "> So we should try to get the builder stuff done as part of this project. We can separate it out if appropriate, but I would suggest we d" (031 comment) [extensions/GuidedTour] - 10https://gerrit.wikimedia.org/r/116228 (owner: 10Mattflaschen)
[11:59:30] <sumanah>	 diwanship
[12:00:01] <sumanah>	 !seen diwanship
[12:00:02] <wm-bot>	 Did you mean @seen diwanship?
[12:00:07] <sumanah>	 @seen diwanship
[12:00:07] <wm-bot>	 sumanah: Last time I saw diwanship they were quitting the network with reason: Ping timeout: 245 seconds N/A at 3/7/2014 9:51:28 AM (2h8m38s ago)
[12:01:42] <grrrit-wm>	 (03PS4) 10leucosticte: Make the following fields int unsigned: [core] - 10https://gerrit.wikimedia.org/r/112825 
[12:03:03] <grrrit-wm>	 (03CR) 10Jeroen De Dauw: "+1 on doing security review of included code. I find the notion of WMF being sceptical of the Symfony architecture somewhat amusing. At le" [extensions/Campaigns] (wip/editorcampaigns) - 10https://gerrit.wikimedia.org/r/115853 (owner: 10AndyRussG)
[12:21:15] <grrrit-wm>	 (03CR) 10Liangent: Create plural rules for variants of zh (Chinese) (031 comment) [core] - 10https://gerrit.wikimedia.org/r/116278 (owner: 10Liangent)
[12:35:53] <grrrit-wm>	 (03PS4) 10Phuedx: Icon tweaks [extensions/GettingStarted] - 10https://gerrit.wikimedia.org/r/116969 
[12:40:50] <sumanah>	 Niharika: hi there
[12:40:59] <Niharika>	 Hi sumanah!
[12:41:05] <sumanah>	 Niharika: can you hear me in the videochat?
[12:41:17] <Niharika>	 Nope. Can see you either?
[12:41:19] <Niharika>	 .*
[12:41:25] <sumanah>	 I cannot see you
[12:41:30] <sumanah>	 shall we IRC privmsg instead?
[12:41:36] <Niharika>	 Yep. Okay. 
[12:42:28] <grrrit-wm>	 (03CR) 10Phuedx: "I've resized the lightbulb icon to 43px square as per https://trello.com/c/Pc2CHbVS/284-gettingstarted-icon-tweaks." [extensions/GettingStarted] - 10https://gerrit.wikimedia.org/r/116969 (owner: 10Phuedx)
[13:07:05] <liangent>	 !seen bawolff
[13:07:05] <wm-bot>	 Did you mean @seen bawolff?
[13:07:11] <liangent>	 @seen bawolff
[13:07:11] <wm-bot>	 liangent: Last time I saw bawolff they were quitting the network with reason: Quit: ChatZilla 0.9.90.1 [Iceweasel 3.5.16/20121207230533] N/A at 3/7/2014 12:18:56 AM (12h48m14s ago)
[13:08:01] <grrrit-wm>	 (03CR) 10Siebrand: [C: 031] "May work somewhat." [extensions/Popups] - 10https://gerrit.wikimedia.org/r/115858 (owner: 10Prtksxna)
[13:10:18] <grrrit-wm>	 (03CR) 10Siebrand: [C: 032] Add highlighting after clicking "Drag to new location" button [extensions/LiquidThreads] - 10https://gerrit.wikimedia.org/r/93740 (owner: 1001tonythomas)
[13:10:20] <grrrit-wm>	 (03Merged) 10jenkins-bot: Add highlighting after clicking "Drag to new location" button [extensions/LiquidThreads] - 10https://gerrit.wikimedia.org/r/93740 (owner: 1001tonythomas)
[13:10:26] <grrrit-wm>	 (03CR) 10Siebrand: [C: 032] Use javascript:void() as href for CharInsert [extensions/CharInsert] - 10https://gerrit.wikimedia.org/r/116950 (owner: 1001tonythomas)
[13:10:28] <grrrit-wm>	 (03Merged) 10jenkins-bot: Use javascript:void() as href for CharInsert [extensions/CharInsert] - 10https://gerrit.wikimedia.org/r/116950 (owner: 1001tonythomas)
[13:12:40] <grrrit-wm>	 (03CR) 10Siebrand: [C: 031] "i18n/L10n reviewed." [extensions/VectorBeta] - 10https://gerrit.wikimedia.org/r/99586 (owner: 10JGonera)
[13:15:30] <grrrit-wm>	 (03CR) 10Siebrand: [C: 032] i18n: use double-quotation for consistency [extensions/OpenStackManager] - 10https://gerrit.wikimedia.org/r/116462 (owner: 10Shirayuki)
[13:15:33] <grrrit-wm>	 (03Merged) 10jenkins-bot: i18n: use double-quotation for consistency [extensions/OpenStackManager] - 10https://gerrit.wikimedia.org/r/116462 (owner: 10Shirayuki)
[13:16:00] <grrrit-wm>	 (03CR) 10Siebrand: [C: 032] i18n: use "int:" for consistency [core] - 10https://gerrit.wikimedia.org/r/115128 (owner: 10Shirayuki)
[13:19:44] <grrrit-wm>	 (03CR) 10Siebrand: [C: 04-1] "* .DS_STORE should not be here." (034 comments) [extensions/VideoJsPlayer] - 10https://gerrit.wikimedia.org/r/117019 (owner: 10AalekhN)
[13:19:51] <grrrit-wm>	 (03Merged) 10jenkins-bot: i18n: use "int:" for consistency [core] - 10https://gerrit.wikimedia.org/r/115128 (owner: 10Shirayuki)
[13:23:26] <grrrit-wm>	 (03CR) 10Manybubbles: [C: 032] Bump CirrusSearch to 0.2 [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/117379 (owner: 10Chad)
[13:31:55] <grrrit-wm>	 (03CR) 10Manybubbles: "Sorry! The docs in tests/browser reference the docs in the mediawiki-selenium gem and those in turn reference using RVM. RVM provides an" [vagrant] - 10https://gerrit.wikimedia.org/r/115679 (owner: 10Manybubbles)
[13:33:48] <grrrit-wm>	 (03CR) 10Manybubbles: [C: 032] Remove references to SearchUpdate class, we don't use that [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/117351 (owner: 10Chad)
[13:34:05] <grrrit-wm>	 (03CR) 10Manybubbles: [C: 032] Handle old todo, Title objects have long since been removed [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/117336 (owner: 10Chad)
[13:45:32] <grrrit-wm>	 (03PS2) 10Yarda: Fix HTTPS protocol detection [core] - 10https://gerrit.wikimedia.org/r/116943 
[13:55:28] <grrrit-wm>	 (03CR) 10Yarda: "I used strcmp as pointed out in previous review, I used the long form with explicit '==', '!=' operators for better readability and change" [core] - 10https://gerrit.wikimedia.org/r/116943 (owner: 10Yarda)
[13:56:08] <grrrit-wm>	 (03PS3) 10Manybubbles: Drop 0.90 compatibility [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/117317 
[13:56:42] <grrrit-wm>	 (03PS4) 10Manybubbles: Drop 0.90 compatibility [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/117317 
[14:12:35] <hexmode>	 greg-g: didn't we have a mtg scheduled?
[14:12:41] <hexmode>	 I looked for you :(
[14:13:05] <grrrit-wm>	 (03PS1) 10Rillke: Comply with WCAG 2.0 H44 - label form control association [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/117414 
[14:20:14] <grrrit-wm>	 (03PS2) 10Rillke: Comply with WCAG 2.0 H44 - label form control association [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/117414 
[14:26:00] <hexmode>	 Krinkle|detached: where are you?
[14:27:54] <grrrit-wm>	 (03PS1) 10QChris: Make wikimetrics' database setup depend on alembic [vagrant] - 10https://gerrit.wikimedia.org/r/117415 
[14:31:34] <grrrit-wm>	 (03CR) 10Ottomata: Make wikimetrics' database setup depend on alembic (031 comment) [vagrant] - 10https://gerrit.wikimedia.org/r/117415 (owner: 10QChris)
[14:37:18] <grrrit-wm>	 (03CR) 10Thiemo Mättig (WMDE): "I understand that things get confusing very fast when I try to fix as much problems as I can in a single patch. I will try to avoid this i" [core] - 10https://gerrit.wikimedia.org/r/117309 (owner: 10Thiemo Mättig (WMDE))
[14:43:25] <grrrit-wm>	 (03PS2) 10QChris: Make wikimetrics' database setup depend on alembic [vagrant] - 10https://gerrit.wikimedia.org/r/117415 
[14:44:31] <grrrit-wm>	 (03CR) 10QChris: Make wikimetrics' database setup depend on alembic (031 comment) [vagrant] - 10https://gerrit.wikimedia.org/r/117415 (owner: 10QChris)
[14:51:31] <grrrit-wm>	 (03CR) 10Ottomata: [C: 032 V: 032] Make wikimetrics' database setup depend on alembic [vagrant] - 10https://gerrit.wikimedia.org/r/117415 (owner: 10QChris)
[14:53:10] <grrrit-wm>	 (03CR) 10Rillke: [C: 04-1] "The error indicators (if invalid user input is provided) are not properly detected." [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/117414 (owner: 10Rillke)
[14:59:50] <grrrit-wm>	 (03CR) 10Fomafix: [C: 04-1] Changed CSS of input#wpSummary from width:80% to width:100% (031 comment) [core] - 10https://gerrit.wikimedia.org/r/117390 (owner: 1001tonythomas)
[15:00:33] <grrrit-wm>	 (03CR) 10Hashar: Revert "Revert "Warn on account creation when username is adjusted"" (031 comment) [core] - 10https://gerrit.wikimedia.org/r/117247 (owner: 10Bartosz Dziewoński)
[15:03:32] <grrrit-wm>	 (03PS3) 1001tonythomas: Changed CSS of input#wpSummary from width:80% to width:100% [core] - 10https://gerrit.wikimedia.org/r/117390 
[15:04:27] <grrrit-wm>	 (03CR) 1001tonythomas: "@Fomafix : done :)" [core] - 10https://gerrit.wikimedia.org/r/117390 (owner: 1001tonythomas)
[15:07:14] <grrrit-wm>	 (03CR) 10Hoo man: [C: 031] "Restoring +1, as mentioned earlier I would like for someone else to have a look." [core] - 10https://gerrit.wikimedia.org/r/36330 (owner: 10Alex Monk)
[15:11:18] <grrrit-wm>	 (03CR) 10Siebrand: [C: 032] Fix Uzbek converter [core] - 10https://gerrit.wikimedia.org/r/116914 (owner: 10SPQRobin)
[15:12:00] <grrrit-wm>	 (03PS3) 10Rillke: Comply with WCAG 2.0 H44 - label form control association [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/117414 
[15:12:12] <grrrit-wm>	 (03CR) 10Siebrand: Fix Uzbek converter (031 comment) [core] - 10https://gerrit.wikimedia.org/r/116914 (owner: 10SPQRobin)
[15:15:09] <grrrit-wm>	 (03Merged) 10jenkins-bot: Fix Uzbek converter [core] - 10https://gerrit.wikimedia.org/r/116914 (owner: 10SPQRobin)
[15:21:30] <grrrit-wm>	 (03CR) 10Daniel Kinzler: [C: 031 V: 032] "Works and looks good, see PS8. Holding off on the +2 on Katie's request." [core] - 10https://gerrit.wikimedia.org/r/101895 (owner: 10Aude)
[15:34:55] <grrrit-wm>	 (03CR) 10Daniel Kinzler: "will you? i think the whole chain is good to go in..." [core] - 10https://gerrit.wikimedia.org/r/117036 (owner: 10Addshore)
[15:40:20] <grrrit-wm>	 (03CR) 10Anomie: "Oh, you may not be aware of I7a3d7b6e. getAllowedParams() is passed a flags parameter, and you can branch on $flags & ApiBase::GET_VALUES_" [core] - 10https://gerrit.wikimedia.org/r/117041 (owner: 10Umherirrender)
[15:41:03] <grrrit-wm>	 (03PS1) 10Manybubbles: Have ApiRunJobs run periodic tasks [core] - 10https://gerrit.wikimedia.org/r/117419 
[15:41:47] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] Have ApiRunJobs run periodic tasks [core] - 10https://gerrit.wikimedia.org/r/117419 (owner: 10Manybubbles)
[15:41:52] <grrrit-wm>	 (03CR) 10Manybubbles: "This fixes Cirrus's browser tests on master." [core] - 10https://gerrit.wikimedia.org/r/117419 (owner: 10Manybubbles)
[15:42:55] <grrrit-wm>	 (03CR) 10Manybubbles: "recheck" [core] - 10https://gerrit.wikimedia.org/r/117419 (owner: 10Manybubbles)
[15:55:19] <greg-g>	 hexmode: 'twas 5:30am for me, I obviously did something weird when I was in the east coast :)
[15:55:30] <grrrit-wm>	 (03CR) 10Addshore: "If the whole chain is ready ( which is what it looks like ) I wont bother poking the tests into the relevant commits." [core] - 10https://gerrit.wikimedia.org/r/117036 (owner: 10Addshore)
[15:58:56] <grrrit-wm>	 (03PS2) 10Chad: Handle old todo, Title objects have long since been removed [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/117336 
[15:59:02] <grrrit-wm>	 (03CR) 10Manybubbles: [C: 032] Handle old todo, Title objects have long since been removed [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/117336 (owner: 10Chad)
[15:59:10] <grrrit-wm>	 (03Merged) 10jenkins-bot: Handle old todo, Title objects have long since been removed [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/117336 (owner: 10Chad)
[15:59:27] <grrrit-wm>	 (03PS2) 10Chad: Remove references to SearchUpdate class, we don't use that [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/117351 
[15:59:38] <grrrit-wm>	 (03CR) 10Manybubbles: [C: 032] Remove references to SearchUpdate class, we don't use that [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/117351 (owner: 10Chad)
[15:59:45] <grrrit-wm>	 (03Merged) 10jenkins-bot: Remove references to SearchUpdate class, we don't use that [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/117351 (owner: 10Chad)
[16:02:34] <grrrit-wm>	 (03PS2) 10Manybubbles: Hacky python script to reply production logs [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/115991 
[16:03:48] <grrrit-wm>	 (03CR) 10Addshore: [C: 04-1] Fix Status::getMessage accidentially returning string instead of Message (032 comments) [core] - 10https://gerrit.wikimedia.org/r/117309 (owner: 10Thiemo Mättig (WMDE))
[16:06:50] <hexmode>	 greg-g: oh the joys of google calendar
[16:06:51] <hexmode>	 greg-g: So, 11:30 then?  8:30 for you?  1/2 hr from now?
[16:07:31] <mglaser>	 greg-g, hexmode, we can start in 3 minutes :)
[16:07:36] <manybubbles>	 slow slow slow
[16:19:31] <grrrit-wm>	 (03CR) 10Anomie: [C: 04-1] "The behavior change for "hide links" in Special:WhatLinksHere is no good." (034 comments) [core] - 10https://gerrit.wikimedia.org/r/117373 (owner: 10Aaron Schulz)
[16:22:42] <grrrit-wm>	 (03CR) 10Aaron Schulz: [C: 032] Have ApiRunJobs run periodic tasks [core] - 10https://gerrit.wikimedia.org/r/117419 (owner: 10Manybubbles)
[16:24:54] <grrrit-wm>	 (03PS1) 10Manybubbles: More Jenkins fixes [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/117423 
[16:25:43] <grrrit-wm>	 (03CR) 10Manybubbles: "This should get us closer to 100%...." [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/117423 (owner: 10Manybubbles)
[16:26:02] <grrrit-wm>	 (03CR) 10Aaron Schulz: "Did the script run? Editing a page won't work due to the INSERT IGNORE." (033 comments) [core] - 10https://gerrit.wikimedia.org/r/117373 (owner: 10Aaron Schulz)
[16:26:21] <grrrit-wm>	 (03Merged) 10jenkins-bot: Have ApiRunJobs run periodic tasks [core] - 10https://gerrit.wikimedia.org/r/117419 (owner: 10Manybubbles)
[16:27:07] <grrrit-wm>	 (03PS2) 10Manybubbles: More Jenkins fixes [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/117423 
[16:27:37] <grrrit-wm>	 (03PS4) 10Manybubbles: Get Cirrus's browser tests working [vagrant] - 10https://gerrit.wikimedia.org/r/115679 
[16:41:03] <grrrit-wm>	 (03CR) 10Thiemo Mättig (WMDE): Fix Status::getMessage accidentially returning string instead of Message (032 comments) [core] - 10https://gerrit.wikimedia.org/r/117309 (owner: 10Thiemo Mättig (WMDE))
[16:51:05] <grrrit-wm>	 (03PS1) 10Krinkle: doc: Clean up documentation in ResourceLoader.php [core] - 10https://gerrit.wikimedia.org/r/117427 
[17:00:24] <grrrit-wm>	 (03PS1) 10Rillke: Remember user to select a license [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/117428 
[17:05:21] <grrrit-wm>	 (03CR) 10Rillke: "grep -r "mwe-error-main"" [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/117428 (owner: 10Rillke)
[17:12:57] <grrrit-wm>	 (03Abandoned) 10Bartosz Dziewoński: Revert "Revert "Warn on account creation when username is adjusted"" [core] - 10https://gerrit.wikimedia.org/r/117247 (owner: 10Bartosz Dziewoński)
[17:14:21] <grrrit-wm>	 (03CR) 10Umherirrender: "Showing the NoLocalSettings text sounds not like a helpful error message in this case. I want showing different text, so I need both calls" [core] - 10https://gerrit.wikimedia.org/r/117022 (owner: 10Umherirrender)
[17:15:09] <grrrit-wm>	 (03PS2) 10MarkTraceur: Remind user to select a license [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/117428 (owner: 10Rillke)
[17:22:01] <grrrit-wm>	 (03CR) 10Chad: "It's a wasted function call on every page invocation though :\" [core] - 10https://gerrit.wikimedia.org/r/117022 (owner: 10Umherirrender)
[17:25:56] <grrrit-wm>	 (03CR) 10Hashar: "The update.php script fails with some index not set in updateOneSearchIndex.php" [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/117423 (owner: 10Manybubbles)
[17:27:21] <grrrit-wm>	 (03CR) 10Chad: "Gah! I hit this before and wrote I4fbeb509, but couldn't replicate. What the heck? :)" [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/117423 (owner: 10Manybubbles)
[17:29:16] <zeek>	 Hie, I am going through this bug regarding Semantic Forms and I am not able to reproduce it. I saw the documentation on api.php but its not helping. Please see https://bugzilla.wikimedia.org/show_bug.cgi?id=51505
[17:30:36] <grrrit-wm>	 (03CR) 10AndyRussG: "Thanks Jeroen!" [extensions/Campaigns] (wip/editorcampaigns) - 10https://gerrit.wikimedia.org/r/115853 (owner: 10AndyRussG)
[17:31:33] <grrrit-wm>	 (03CR) 10Chad: [C: 032] Drop 0.90 compatibility [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/117317 (owner: 10Manybubbles)
[17:31:41] <grrrit-wm>	 (03Merged) 10jenkins-bot: Drop 0.90 compatibility [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/117317 (owner: 10Manybubbles)
[17:32:53] <grrrit-wm>	 (03CR) 10Chad: [C: 032] "This is hacky and for testing. If it works for Nik then I'm merging. Improvements can always come later :)" [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/115991 (owner: 10Manybubbles)
[17:33:00] <grrrit-wm>	 (03Merged) 10jenkins-bot: Hacky python script to reply production logs [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/115991 (owner: 10Manybubbles)
[17:33:51] <grrrit-wm>	 (03CR) 10Anomie: "Did what script run?" [core] - 10https://gerrit.wikimedia.org/r/117373 (owner: 10Aaron Schulz)
[17:34:38] <zeek>	 Ohh got it fixed. :)
[17:35:20] <grrrit-wm>	 (03PS2) 10Chad: Bump CirrusSearch to 0.2 [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/117379 
[17:36:15] <grrrit-wm>	 (03CR) 10Chad: [C: 032 V: 032] Bump CirrusSearch to 0.2 [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/117379 (owner: 10Chad)
[17:53:13] <grrrit-wm>	 (03PS2) 10MaxSem: WIP: HHVM support [php/wikidiff2] - 10https://gerrit.wikimedia.org/r/117362 
[17:53:45] <gwicke>	 rdwrer: ping
[17:57:16] <grrrit-wm>	 (03PS14) 10Lekshmi: Changed deprecated $wgCopyrightIcon [core] - 10https://gerrit.wikimedia.org/r/109903 
[17:57:30] <rdwrer>	 gwicke: Pong
[17:57:35] <rdwrer>	 What's up?
[17:57:40] <gwicke>	 hey
[17:58:00] <gwicke>	 we are looking into video / audio support in parsoid
[17:58:02] <gwicke>	 https://bugzilla.wikimedia.org/show_bug.cgi?id=62270
[17:58:28] <rdwrer>	 'kay
[17:58:45] <rdwrer>	 gwicke: Anything I can do to help, or just notifying? :)
[17:58:50] <gwicke>	 is there anybody on the multimedia team who can give us feedback on the dom spec and integration with the timed media handler player?
[17:59:08] <gwicke>	 was wondering who to cc on the bug
[17:59:13] <rdwrer>	 Hm, usually I'd shunt you towards gi11es but he's being a dad
[17:59:40] <rdwrer>	 I can help you out to an extent too
[17:59:46] <gwicke>	 k; I cc'ed brion so far
[17:59:54] <rdwrer>	 So I guess both of us, but don't expect much out of Gilles for a while
[18:00:21] <gwicke>	 Dubuc?
[18:00:34] <rdwrer>	 Yup
[18:00:54] <gwicke>	 k, cc'ed both of you
[18:01:51] <gwicke>	 we'll probably just do a simple video / audio tag instead of img, the main question is which extra info is needed to hook up a player client-side
[18:02:33] <brion>	 gwicke: so something to consider is also handling additional media types that don't have native <video>/<audio> wrappers -- like a map would be something we likely drop in at runtime to a special <div> or even a custom element
[18:03:13] <brion>	 for a/v specifically, in theory you could use <video>/<audio> with some <source>s inside, and let the runtime player "enhance" it to a full video player with UI
[18:03:24] <brion>	 or you could use a placeholder with a thumb image, ... or.... 
[18:03:40] <gwicke>	 which kind of map were you thinking of?
[18:03:45] <gwicke>	 svg?
[18:04:01] <rdwrer>	 > custom element
[18:04:01] <rdwrer>	 No
[18:04:02] <brion>	 could be svg, could be OSM-style raster tiles, could be anything
[18:04:05] <rdwrer>	 Agh
[18:04:20] <brion>	 point is its rendering would be dynamic
[18:04:51] <gwicke>	 ah, are there plans to do this as an image rather than a tag hook?
[18:05:03] <brion>	 don't know yet :)
[18:05:20] <brion>	 but it's a possibility
[18:05:50] <gwicke>	 yeah
[18:06:35] <gwicke>	 re <source>, is there an api currently that would let a client discover other qualities provided only the file resource?
[18:07:35] <gwicke>	 the set of qualities seems to be likely to change, so maybe it makes sense to only provide a <source> pointing to the original by default
[18:07:45] <gwicke>	 and let the client fill in scaled versions
[18:09:54] <grrrit-wm>	 (03PS1) 10Aaron Schulz: Fixed stats queries for sqlite [extensions/FlaggedRevs] - 10https://gerrit.wikimedia.org/r/117435 
[18:11:13] <brion>	 might make sense
[18:11:36] <brion>	 you can grab the set of transcodes through the api yes
[18:11:38] <grrrit-wm>	 (03PS2) 10Umherirrender: LocalSettings.php must be readable by the server [core] - 10https://gerrit.wikimedia.org/r/117022 
[18:12:19] <brion>	 it's a bit flaky though and probably should be respecced :)
[18:12:32] <gwicke>	 panta rei ;)
[18:12:36] <brion>	 but i use it in ogv.js demo to get the available .ogv or .oga transcode info https://brionv.com/misc/ogv.js/demo/
[18:12:48] <grrrit-wm>	 (03CR) 10Umherirrender: "Patch Set 2: Addressed comments" [core] - 10https://gerrit.wikimedia.org/r/117022 (owner: 10Umherirrender)
[18:13:02] <brion>	 and yes they can change -- a newly uploaded file for instance may be used before all the transcodes get finished
[18:13:23] <brion>	 but if a page using it is saved before then, it'd be nice if visiting it again didn't limit us to the old transcodes
[18:13:54] <gwicke>	 brion: saw that, very cool
[18:14:03] <gwicke>	 yeah
[18:14:04] <grrrit-wm>	 (03CR) 10Hoo man: [C: 032] Fixed stats queries for sqlite (031 comment) [extensions/FlaggedRevs] - 10https://gerrit.wikimedia.org/r/117435 (owner: 10Aaron Schulz)
[18:14:10] <grrrit-wm>	 (03Merged) 10jenkins-bot: Fixed stats queries for sqlite [extensions/FlaggedRevs] - 10https://gerrit.wikimedia.org/r/117435 (owner: 10Aaron Schulz)
[18:14:19] <gwicke>	 it also sounds likely that we'd want chunking and adaptive streaming at some point
[18:14:43] <gwicke>	 but that can also be handled with an api returning a manifest
[18:15:49] <brion>	 some day probably yeah, that's a lot of infrastructure though :D
[18:16:09] <brion>	 ideally yes, don't stick all that in your high-level markup :D
[18:17:39] <grrrit-wm>	 (03PS1) 10Bartosz Dziewoński: Check validity and availability of usernames during signup via AJAX [core] - 10https://gerrit.wikimedia.org/r/117437 
[18:17:50] <grrrit-wm>	 (03PS1) 10Bartosz Dziewoński: Check normalization rules of usernames during signup via AJAX [core] - 10https://gerrit.wikimedia.org/r/117438 
[18:18:01] <gwicke>	 brion, which API end point are you using for the transcodes? prop=videoinfo?
[18:18:31] <grrrit-wm>	 (03CR) 10Bartosz Dziewoński: "I have resubmitted this, sans the controversial part, split into two parts, as https://gerrit.wikimedia.org/r/117437 and https://gerrit.wi" [core] - 10https://gerrit.wikimedia.org/r/114400 (owner: 10Bartosz Dziewoński)
[18:18:46] <grrrit-wm>	 (03CR) 10Bartosz Dziewoński: "I have resubmitted the reverted patch, sans the controversial part, split into two parts, as https://gerrit.wikimedia.org/r/117437 and htt" [core] - 10https://gerrit.wikimedia.org/r/117234 (owner: 10Jdlrobson)
[18:18:56] <grrrit-wm>	 (03CR) 10Bartosz Dziewoński: "I have resubmitted this, sans the controversial part, split into two parts, as https://gerrit.wikimedia.org/r/117437 and https://gerrit.wi" [core] - 10https://gerrit.wikimedia.org/r/117247 (owner: 10Bartosz Dziewoński)
[18:19:37] <brion>	 gwicke: transcodestatus. videoinfo gives similar info though
[18:20:37] <gwicke>	 k, thanks
[18:22:23] <grrrit-wm>	 (03CR) 10Bartosz Dziewoński: [C: 04-1] "The wording here needs help. Help, anyone?" [core] - 10https://gerrit.wikimedia.org/r/117438 (owner: 10Bartosz Dziewoński)
[18:22:37] <MatmaRex>	 ugh, i think i broke gerrit, it suddenly got slow.
[18:24:35] <ONeill123456>	 Hello all
[18:24:41] <rdwrer>	 Hi, ONeill123456
[18:24:45] <rdwrer>	 What's up?
[18:24:49] <ONeill123456>	 i have a question, hope you can help :)
[18:24:55] <rdwrer>	 ONeill123456: Hello! When you're on IRC it's usually good practice to jump right in and ask a question, as it saves time for everyone involved :) how can we help you?
[18:24:55] <grrrit-wm>	 (03CR) 10Bartosz Dziewoński: [C: 031] "This part of the reverted patch was non-controversial (no one even commented on it) and I believe it's good to go in again as-is. I only d" [core] - 10https://gerrit.wikimedia.org/r/117437 (owner: 10Bartosz Dziewoński)
[18:25:29] <ONeill123456>	 I hope, i can change the user option skin on an external PHP page
[18:26:04] <ONeill123456>	 but, if i want to save settings using saveSettings() function in user class i become a notice and the skin option isn't written to db
[18:26:16] <ONeill123456>	 Uncommitted DB writes (transaction from DatabaseBase::query (LCStoreDB::get)).
[18:26:25] <grrrit-wm>	 (03PS1) 10Purodha: Move long URL out of message Gwtoolset-step-1-instructions-3, see also https://translatewiki.net/wiki/Thread:Support/About_MediaWiki:Gwtoolset-step-1-instructions-3/sv [extensions/GWToolset] - 10https://gerrit.wikimedia.org/r/117440 
[18:26:39] <rdwrer>	 ONeill123456: External PHP page, like, outside of MediaWiki?
[18:26:51] <ONeill123456>	 @rdwrer: yes
[18:27:08] <ONeill123456>	 read isn't a problem, that function, but not save settings
[18:27:31] <rdwrer>	 ONeill123456: I'm surprised it's working as well as it is, honestly, but OK
[18:27:52] <rdwrer>	 ONeill123456: Can you "just" send a manual commit command to the database?
[18:28:57] <grrrit-wm>	 (03PS1) 10Krinkle: tests: Add ResourceLoaderTestCase and abstract context creation [core] - 10https://gerrit.wikimedia.org/r/117441 
[18:28:59] <grrrit-wm>	 (03PS1) 10Krinkle: resourceloader: Consistently pass inDebugMode to encodeJsCall() in load.php [core] - 10https://gerrit.wikimedia.org/r/117442 
[18:29:11] <ONeill123456>	 @rdwrer: the "external" PHP site is on same server, i have initialized WebStarter and User from includes (i was not sure, that it work, too, but :)). Yes, i have full access to server and db :)
[18:29:38] <rdwrer>	 Then just send the commit, I guess
[18:31:14] <grrrit-wm>	 (03PS1) 10Krinkle: tests: Add unit tests for ResourceLoaderStartupModule [core] - 10https://gerrit.wikimedia.org/r/117443 
[18:31:16] <grrrit-wm>	 (03PS1) 10Krinkle: resourceloader: Separate gathering of registry data from mw.loader call [core] - 10https://gerrit.wikimedia.org/r/117444 
[18:31:33] <grrrit-wm>	 (03PS2) 10AndyRussG: Move hooks to separate file/class [extensions/Campaigns] (wip/editorcampaigns) - 10https://gerrit.wikimedia.org/r/116056 
[18:32:21] <ONeill123456>	 @rdwrer: you mean write direct to the database?
[18:32:44] <rdwrer>	 ONeill123456: That's one option, but I mean send a commit command
[18:33:14] <rdwrer>	 ONeill123456: https://dev.mysql.com/doc/refman/5.0/en/commit.html
[18:36:05] <ONeill123456>	 i hope i don't missunderstood you, but with only an commit to the database, the option isn't saved in db too :/
[18:36:37] <grrrit-wm>	 (03PS3) 10Manybubbles: More Jenkins fixes [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/117423 
[18:37:08] <grrrit-wm>	 (03CR) 10Manybubbles: "Try it with a rebase. I think the Elastica upgrade caused that error but I thought I handled it in the "drop 0.90 support" commit." [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/117423 (owner: 10Manybubbles)
[18:38:46] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] tests: Add ResourceLoaderTestCase and abstract context creation [core] - 10https://gerrit.wikimedia.org/r/117441 (owner: 10Krinkle)
[18:38:55] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] resourceloader: Consistently pass inDebugMode to encodeJsCall() in load.php [core] - 10https://gerrit.wikimedia.org/r/117442 (owner: 10Krinkle)
[18:40:02] <grrrit-wm>	 (03PS3) 10Tpt: Adds a beginning of parser tests [extensions/ProofreadPage] - 10https://gerrit.wikimedia.org/r/115356 
[18:40:21] <grrrit-wm>	 (03PS2) 10Nemo bis: Move long URL out of message Gwtoolset-step-1-instructions-3 [extensions/GWToolset] - 10https://gerrit.wikimedia.org/r/117440 (owner: 10Purodha)
[18:43:12] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] tests: Add unit tests for ResourceLoaderStartupModule [core] - 10https://gerrit.wikimedia.org/r/117443 (owner: 10Krinkle)
[18:43:22] <grrrit-wm>	 (03CR) 10Nemo bis: "Thanks for the patch!" (032 comments) [extensions/GWToolset] - 10https://gerrit.wikimedia.org/r/117440 (owner: 10Purodha)
[18:43:36] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] resourceloader: Separate gathering of registry data from mw.loader call [core] - 10https://gerrit.wikimedia.org/r/117444 (owner: 10Krinkle)
[18:44:12] <grrrit-wm>	 (03CR) 10Phe: [C: 031] Adds a beginning of parser tests [extensions/ProofreadPage] - 10https://gerrit.wikimedia.org/r/115356 (owner: 10Tpt)
[18:44:26] <ONeill123456>	 i can give the code, too, if necessary
[18:47:34] <grrrit-wm>	 (03CR) 10Addshore: [C: 04-1] doc: Clean up documentation in ResourceLoader.php (035 comments) [core] - 10https://gerrit.wikimedia.org/r/117427 (owner: 10Krinkle)
[18:49:38] <paravoid>	 has anyone signed Facebook's CLA for HHVM?
[18:49:52] <paravoid>	 ori: maybe?
[18:50:07] * ^d  has

[18:50:10] <^d>	 Tim has too
[18:50:47] <paravoid>	 did you sign it personally or did you sign it on behalf of the WMF?
[18:50:52] <rdwrer>	 ONeill123456: That's weird, and I feel like I've seen the same error before, but I don't know where
[18:51:07] <rdwrer>	 paravoid: Surely ebernhardson has.
[18:51:14] <^d>	 paravoid: We all did it individually. I talked to Luis about it first if memory serves.
[18:53:29] <brion>	 ^d: moment
[18:54:03] <grrrit-wm>	 (03PS4) 10Tpt: Adds a beginning of parser tests [extensions/ProofreadPage] - 10https://gerrit.wikimedia.org/r/115356 
[18:55:13] <grrrit-wm>	 (03CR) 10Tpt: [C: 032] "Reviewed by Phe" [extensions/ProofreadPage] - 10https://gerrit.wikimedia.org/r/115356 (owner: 10Tpt)
[18:55:20] <grrrit-wm>	 (03Merged) 10jenkins-bot: Adds a beginning of parser tests [extensions/ProofreadPage] - 10https://gerrit.wikimedia.org/r/115356 (owner: 10Tpt)
[18:57:15] <grrrit-wm>	 (03PS3) 10AndyRussG: Add DI setup that's performed only when needed [extensions/Campaigns] (wip/editorcampaigns) - 10https://gerrit.wikimedia.org/r/116153 
[18:58:17] <ONeill123456>	 rdwrer: hmm, not good :/ :)
[18:58:40] <rdwrer>	 ONeill123456: No, but maybe someone else will show up who can help
[18:58:50] <rdwrer>	 ONeill123456: You might also ask in #mediawiki
[18:59:15] <grrrit-wm>	 (03CR) 10AndyRussG: "Just rebasing... A new patch set that doesn't use Symfony coming up..." [extensions/Campaigns] (wip/editorcampaigns) - 10https://gerrit.wikimedia.org/r/116153 (owner: 10AndyRussG)
[18:59:19] <ONeill123456>	 ok, thx :)
[19:00:10] <grrrit-wm>	 (03CR) 10Addshore: [C: 04-1] "-1 is mainly for the comment at the top of the file as I am aware the other 2 issues are not introduced in this commit." (033 comments) [core] - 10https://gerrit.wikimedia.org/r/117441 (owner: 10Krinkle)
[19:02:25] <grrrit-wm>	 (03CR) 10Krinkle: tests: Add ResourceLoaderTestCase and abstract context creation (032 comments) [core] - 10https://gerrit.wikimedia.org/r/117441 (owner: 10Krinkle)
[19:04:19] <vidhan>	 vagrant problem
[19:04:22] <grrrit-wm>	 (03CR) 10Krinkle: doc: Clean up documentation in ResourceLoader.php (032 comments) [core] - 10https://gerrit.wikimedia.org/r/117427 (owner: 10Krinkle)
[19:04:40] <grrrit-wm>	 (03PS2) 10Krinkle: doc: Clean up documentation in ResourceLoader.php [core] - 10https://gerrit.wikimedia.org/r/117427 
[19:05:18] <grrrit-wm>	 (03PS2) 10Krinkle: tests: Add ResourceLoaderTestCase and abstract context creation [core] - 10https://gerrit.wikimedia.org/r/117441 
[19:05:27] <Krenair>	 YuviPanda, hi
[19:05:33] <YuviPanda>	 hi Krenair
[19:05:36] <Krenair>	 The github bot is down once again
[19:05:40] <grrrit-wm>	 (03CR) 10Addshore: tests: Add ResourceLoaderTestCase and abstract context creation (031 comment) [core] - 10https://gerrit.wikimedia.org/r/117441 (owner: 10Krinkle)
[19:05:45] <YuviPanda>	 Krenair: it's been down for a bit, I haven't had the time to fix it :(
[19:05:56] <YuviPanda>	 I don't know when I'll have the time, tbh.
[19:06:24] <rajesh__>	 hello
[19:06:34] <addshore>	 morning / evening YuviPanda ! :)
[19:06:48] <YuviPanda>	 addshore: just past midnight, so I have no idea which one is appropriate
[19:06:49] <YuviPanda>	 :D
[19:06:51] <rajesh__>	 please can anybody help
[19:06:59] <rajesh__>	 ?
[19:07:12] <grrrit-wm>	 (03CR) 10Addshore: [C: 032] doc: Clean up documentation in ResourceLoader.php [core] - 10https://gerrit.wikimedia.org/r/117427 (owner: 10Krinkle)
[19:07:27] <addshore>	 YuviPanda, now thats just confusing :P
[19:07:28] <rajesh__>	 hello grrit
[19:07:50] <rajesh__>	 please anybody help
[19:07:58] <rajesh__>	 I m new to irc
[19:08:08] <YuviPanda>	 addshore: :D indeed.
[19:08:11] <grrrit-wm>	 (03PS3) 10Krinkle: tests: Add ResourceLoaderTestCase and abstract context creation [core] - 10https://gerrit.wikimedia.org/r/117441 
[19:08:24] <addshore>	 rajesh__: what do you need help with? :O
[19:08:37] <grrrit-wm>	 (03PS3) 10Tpt: Addition of a parser test for page= parameter of image inclusion [core] - 10https://gerrit.wikimedia.org/r/102475 
[19:09:09] <rajesh__>	 http://en.wikipedia.org/wiki/Wikipedia:GLAM/MonmouthpediA/Participate
[19:09:15] <rajesh__>	 please check this
[19:09:43] <rajesh__>	 i want to make similar one
[19:09:50] <grrrit-wm>	 (03PS4) 10JGonera: [WIP] Add click tracking to compact personal bar [extensions/VectorBeta] - 10https://gerrit.wikimedia.org/r/117138 
[19:10:07] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] [WIP] Add click tracking to compact personal bar [extensions/VectorBeta] - 10https://gerrit.wikimedia.org/r/117138 (owner: 10JGonera)
[19:10:10] <grrrit-wm>	 (03PS4) 10Krinkle: tests: Add ResourceLoaderTestCase and abstract context creation [core] - 10https://gerrit.wikimedia.org/r/117441 
[19:10:30] <rajesh__>	 which template is used for making this may I know
[19:10:45] <rajesh__>	 @addshore
[19:10:45] <wm-bot>	 Permission denied
[19:11:07] <rajesh__>	 @addshore you there?
[19:11:07] <wm-bot>	 Permission denied
[19:11:21] <grrrit-wm>	 (03PS2) 10Krinkle: resourceloader: Consistently pass inDebugMode to encodeJsCall() in load.php [core] - 10https://gerrit.wikimedia.org/r/117442 
[19:11:26] <grrrit-wm>	 (03PS2) 10Krinkle: tests: Add unit tests for ResourceLoaderStartupModule [core] - 10https://gerrit.wikimedia.org/r/117443 
[19:11:31] <grrrit-wm>	 (03PS2) 10Krinkle: resourceloader: Separate gathering of registry data from mw.loader call [core] - 10https://gerrit.wikimedia.org/r/117444 
[19:12:05] <rajesh__>	 hi
[19:12:09] <addshore>	 rajesh__: best to ask in #wikipedia-en :)
[19:12:16] <grrrit-wm>	 (03Merged) 10jenkins-bot: doc: Clean up documentation in ResourceLoader.php [core] - 10https://gerrit.wikimedia.org/r/117427 (owner: 10Krinkle)
[19:13:03] <rajesh__>	 can you give me the link where I can find all the syntax of wikimedia @addshore
[19:13:11] <grrrit-wm>	 (03PS5) 10JGonera: [WIP] Add click tracking to compact personal bar [extensions/VectorBeta] - 10https://gerrit.wikimedia.org/r/117138 
[19:13:33] <addshore>	 rajesh__: take a look at https://www.mediawiki.org/wiki/Help:Formatting
[19:13:47] <rajesh__>	 thnx @addshore
[19:13:59] <grrrit-wm>	 (03CR) 10Chad: [C: 031] "Minor nit, otherwise good and let's merge." (031 comment) [core] - 10https://gerrit.wikimedia.org/r/110987 (owner: 10Yuvipanda)
[19:15:03] <grrrit-wm>	 (03Draft1) 10Addshore: Fix phpdoc of class vars in ResourceLoader [core] - 10https://gerrit.wikimedia.org/r/117448 
[19:15:12] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] Addition of a parser test for page= parameter of image inclusion [core] - 10https://gerrit.wikimedia.org/r/102475 (owner: 10Tpt)
[19:16:15] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] [WIP] Add click tracking to compact personal bar [extensions/VectorBeta] - 10https://gerrit.wikimedia.org/r/117138 (owner: 10JGonera)
[19:17:16] <grrrit-wm>	 (03CR) 10Chad: [C: 032] LocalSettings.php must be readable by the server [core] - 10https://gerrit.wikimedia.org/r/117022 (owner: 10Umherirrender)
[19:18:42] <grrrit-wm>	 (03PS3) 10Krinkle: resourceloader: Separate gathering of registry data from mw.loader call [core] - 10https://gerrit.wikimedia.org/r/117444 
[19:18:44] <grrrit-wm>	 (03PS3) 10Krinkle: tests: Add unit tests for ResourceLoaderStartupModule [core] - 10https://gerrit.wikimedia.org/r/117443 
[19:18:47] <grrrit-wm>	 (03PS2) 10MarkAHershberger: SECURITY: API: Don't find links in the middle of api.php links [core] (REL1_19) - 10https://gerrit.wikimedia.org/r/115961 (owner: 10Mglaser)
[19:18:56] <grrrit-wm>	 (03PS5) 10Krinkle: resourceloader: Optimize module registry sent in the startup module [core] - 10https://gerrit.wikimedia.org/r/72534 (owner: 10Hoo man)
[19:19:15] <hoo>	 oh, you undreafted it
[19:20:00] <grrrit-wm>	 (03PS3) 10Dan-nl: Move long URL out of message Gwtoolset-step-1-instructions-3 [extensions/GWToolset] - 10https://gerrit.wikimedia.org/r/117440 (owner: 10Purodha)
[19:20:20] <grrrit-wm>	 (03PS6) 10Krinkle: resourceloader: Optimize module registry sent in the startup module [core] - 10https://gerrit.wikimedia.org/r/72534 (owner: 10Hoo man)
[19:21:30] <grrrit-wm>	 (03CR) 10Bsitu: [C: 032] Move Collection classes into collection namespace [extensions/Flow] - 10https://gerrit.wikimedia.org/r/117031 (owner: 10EBernhardson)
[19:22:07] <grrrit-wm>	 (03PS7) 10Krinkle: resourceloader: Optimize module registry sent in the startup module [core] - 10https://gerrit.wikimedia.org/r/72534 (owner: 10Hoo man)
[19:22:23] <grrrit-wm>	 (03CR) 10Krinkle: resourceloader: Optimize module registry sent in the startup module (031 comment) [core] - 10https://gerrit.wikimedia.org/r/72534 (owner: 10Hoo man)
[19:22:24] <hexmode>	 csteipp: could you look at https://gerrit.wikimedia.org/r/115961
[19:22:30] <grrrit-wm>	 (03CR) 10Dan-nl: [C: 032 V: 032] "* thanks for the patch!" [extensions/GWToolset] - 10https://gerrit.wikimedia.org/r/117440 (owner: 10Purodha)
[19:22:38] <grrrit-wm>	 (03CR) 10Krinkle: "Rebased on I01808ce5d6a0ac6f7 and fixed minor typo." [core] - 10https://gerrit.wikimedia.org/r/72534 (owner: 10Hoo man)
[19:22:45] * csteipp  looking

[19:22:50] <grrrit-wm>	 (03CR) 10Krinkle: "Add case of unknown dependency." [core] - 10https://gerrit.wikimedia.org/r/72534 (owner: 10Hoo man)
[19:22:56] <hexmode>	 I'm going to get 1.19 to build correctly
[19:22:58] <grrrit-wm>	 (03CR) 10Krinkle: "Fix test failure." [core] - 10https://gerrit.wikimedia.org/r/72534 (owner: 10Hoo man)
[19:23:19] <grrrit-wm>	 (03Merged) 10jenkins-bot: LocalSettings.php must be readable by the server [core] - 10https://gerrit.wikimedia.org/r/117022 (owner: 10Umherirrender)
[19:24:18] <grrrit-wm>	 (03PS8) 10Krinkle: resourceloader: Optimize module registry sent in the startup module [core] - 10https://gerrit.wikimedia.org/r/72534 (owner: 10Hoo man)
[19:24:28] <grrrit-wm>	 (03CR) 10Krinkle: "update doc comment" [core] - 10https://gerrit.wikimedia.org/r/72534 (owner: 10Hoo man)
[19:24:45] <grrrit-wm>	 (03Merged) 10jenkins-bot: Move Collection classes into collection namespace [extensions/Flow] - 10https://gerrit.wikimedia.org/r/117031 (owner: 10EBernhardson)
[19:25:34] <grrrit-wm>	 (03PS1) 10Bsitu: Turn on logging for unexpected exceptions [extensions/Flow] - 10https://gerrit.wikimedia.org/r/117451 
[19:26:42] <hoo>	 Krinkle: Well done, great :)
[19:27:15] <grrrit-wm>	 (03CR) 10CSteipp: [C: 032] SECURITY: API: Don't find links in the middle of api.php links [core] (REL1_19) - 10https://gerrit.wikimedia.org/r/115961 (owner: 10Mglaser)
[19:27:19] <Krinkle>	 hoo: Thanks
[19:28:46] <addshore>	 silly ResourceLoaderTest::testLessFileCompilation fails for me :>
[19:29:37] <hoo>	 addshore: On master?
[19:29:51] <addshore>	 mhhm, well was poking Krinkles patch :P
[19:30:06] <grrrit-wm>	 (03Merged) 10jenkins-bot: SECURITY: API: Don't find links in the middle of api.php links [core] (REL1_19) - 10https://gerrit.wikimedia.org/r/115961 (owner: 10Mglaser)
[19:31:02] <Krinkle>	 addshore: Should've been fixed by one of the revisions I made to it
[19:31:05] <hexmode>	 Krinkle: did you get a chance to poke at https://bugzilla.mozilla.org/show_bug.cgi?id=858844
[19:31:35] <hexmode>	 (pm'd your detached nick)
[19:32:08] <Krinkle>	 hexmode: Didn't we fix that and backport it?
[19:32:17] <grrrit-wm>	 (03PS6) 10Aaron Schulz: Redid WhatLinksHere query and added a _from_namespace field [core] - 10https://gerrit.wikimedia.org/r/117373 
[19:32:27] <grrrit-wm>	 (03CR) 10Addshore: [C: 032] tests: Add ResourceLoaderTestCase and abstract context creation [core] - 10https://gerrit.wikimedia.org/r/117441 (owner: 10Krinkle)
[19:32:51] <hexmode>	 Krinkle: guess I'll have to look, clues to starting point?
[19:32:52] <addshore>	 was failing for me on master also, will take a poke at it in a second
[19:34:54] <rajesh__>	 hi
[19:35:04] <rajesh__>	 can anybody help me
[19:35:45] <hexmode>	 rajesh__: ask
[19:35:48] <Krinkle>	 hexmode: Your own messages on that bug should tell you. Let me know if you need anything.
[19:36:16] <rajesh__>	 how can I create table header in mediawiki
[19:36:19] <rajesh__>	 ?
[19:36:22] <hexmode>	 Krinkle: ty for helping me out when I'm too lazy and stupid :)
[19:37:18] <rajesh__>	 hello @hexmode
[19:37:18] <Krinkle>	 It's been a few months, so I'm not entirely familiar with itmyself either. But I think the last action point was yours telling them to upgrade after you make the minor release.
[19:37:21] <hexmode>	 Krinkle: yeah, that was pretty stupid of me.  "Scroll down a little, you ninny!"
[19:37:22] <grrrit-wm>	 (03PS6) 10Inchikutty: UploadWizard: OSM embedding: Geocoding, reverse geocoding [extensions/UploadWizard] (osm) - 10https://gerrit.wikimedia.org/r/116130 
[19:38:10] <hexmode>	 rajesh__: https://www.mediawiki.org/wiki/Help:Tables
[19:38:37] <grrrit-wm>	 (03PS7) 10MaxSem: WIP: Elasticsearch support [extensions/GeoData] - 10https://gerrit.wikimedia.org/r/115413 
[19:38:56] <grrrit-wm>	 (03CR) 10Bsitu: Inject CheckUser data more directly (032 comments) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/117253 (owner: 10EBernhardson)
[19:39:27] <paravoid>	 MaxSem: oh!
[19:39:34] <paravoid>	 I hadn't realized you were working on that
[19:39:36] <paravoid>	 nice!
[19:39:40] <MaxSem>	 yep;)
[19:40:20] <rajesh__>	 thnx @hexmode
[19:42:38] <rajesh__>	 you there@hexmode
[19:43:37] <hexmode>	 rajesh__: yep, but you should try #mediawiki
[19:43:41] <grrrit-wm>	 (03CR) 10EBernhardson: Inject CheckUser data more directly (032 comments) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/117253 (owner: 10EBernhardson)
[19:45:18] <grrrit-wm>	 (03PS5) 10Rillke: Replacing deprecated $j.browser with $.client [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/74425 
[19:45:43] <hexmode>	 .awat
[19:45:49] <hexmode>	 wat?
[19:46:15] <grrrit-wm>	 (03PS4) 10Manybubbles: More Jenkins fixes [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/117423 
[19:46:38] <grrrit-wm>	 (03CR) 10Bsitu: Update annotations in RevisionView (032 comments) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/117032 (owner: 10EBernhardson)
[19:46:50] <grrrit-wm>	 (03CR) 10Addshore: [C: 032] resourceloader: Consistently pass inDebugMode to encodeJsCall() in load.php [core] - 10https://gerrit.wikimedia.org/r/117442 (owner: 10Krinkle)
[19:48:12] <grrrit-wm>	 (03CR) 10preilly: [C: 031] WIP: HHVM support [php/wikidiff2] - 10https://gerrit.wikimedia.org/r/117362 (owner: 10MaxSem)
[19:48:42] <grrrit-wm>	 (03CR) 10Bsitu: Inject CheckUser data more directly (031 comment) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/117253 (owner: 10EBernhardson)
[19:48:45] <grrrit-wm>	 (03CR) 10Rillke: "Thanks for the pointer; in the end it was faster downloading and installing the old firefox version instead of using the connect tool by s" [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/74425 (owner: 10Rillke)
[19:50:42] <grrrit-wm>	 (03Merged) 10jenkins-bot: resourceloader: Consistently pass inDebugMode to encodeJsCall() in load.php [core] - 10https://gerrit.wikimedia.org/r/117442 (owner: 10Krinkle)
[19:51:02] <jackmcbarn>	 anomie: did you see the thing i posted on your talk a few days ago?
[19:51:12] <Krenair>	 Hm... I wonder if ottomata meant to fork that repository as wikimedia.
[19:51:44] <anomie>	 jackmcbarn: Changing it might break existing users. 
[19:53:18] <jackmcbarn>	 hmm
[19:54:13] <hexmode>	 Krinkle: This comment is what I wanted you to look at https://bugzilla.mozilla.org/show_bug.cgi?id=858844#c16 (Trying to figure out if I'm really awake right now, I'm so slow)
[19:56:08] <jackmcbarn>	 blugh, why can't lua be more like c?
[19:57:06] <hexmode>	 "Ugh"
[19:57:48] <Krinkle>	 hexmode: Can you reach one of them on irc?
[19:57:57] <Krinkle>	 hexmode: The problem is they're loading a second jQuery
[19:58:06] <Krinkle>	 <script src="/extensions/Bugzilla/web/jquery/1.6.2/jquery.min.js?303"></script> 
[19:58:07] <hexmode>	 Krinkle: ah
[19:58:28] <Krinkle>	 which redefines jQuery including jQuery.fn plugin registry
[19:58:42] <hexmode>	 Krinkle: I could probably even fix that.  I think I have access to the wikimo repo
[19:59:00] <grrrit-wm>	 (03PS1) 10Addshore: Cleanup SampleTest.php [core] - 10https://gerrit.wikimedia.org/r/117458 
[19:59:32] <hexmode>	 Krinkle: thanks for looking
[20:00:46] <Krenair>	 https://github.com/wikimedia/mediawiki-core/blob/master/README.mediawiki - ugh, what?
[20:00:58] <Krenair>	 Github used to follow the symlink and render this
[20:02:38] <MaxSem>	 Krenair, they still do at https://github.com/wikimedia/mediawiki-core
[20:03:08] <Krenair>	 Hm, maybe that was what I was thinking of then...
[20:05:32] <Krinkle>	 hexmode: https://bugzilla.mozilla.org/show_bug.cgi?id=858844#c22
[20:06:14] <hexmode>	 \o/ :) :)
[20:06:37] * hexmode  exhausted his emoticons

[20:07:29] <grrrit-wm>	 (03PS2) 10EBernhardson: New Hook rc/watchlist hook ChangesListBegin [core] - 10https://gerrit.wikimedia.org/r/116649 
[20:08:21] <hexmode>	 Krinkle: for future reference, their irc nicks (for irc.mozilla.org) are in parens
[20:13:04] <grrrit-wm>	 (03PS1) 10Catrope: Update VisualEditor to wmf16 branch for cherry-pick [core] (wmf/1.23wmf16) - 10https://gerrit.wikimedia.org/r/117462 
[20:13:29] <grrrit-wm>	 (03CR) 10Catrope: [C: 032 V: 032] Update VisualEditor to wmf16 branch for cherry-pick [core] (wmf/1.23wmf16) - 10https://gerrit.wikimedia.org/r/117462 (owner: 10Catrope)
[20:18:09] <grrrit-wm>	 (03PS4) 10Tpt: Addition of a parser test for page= parameter of image inclusion [core] - 10https://gerrit.wikimedia.org/r/102475 
[20:18:45] <grrrit-wm>	 (03PS2) 10Krinkle: Enable mediawiki-core-npm (runs jshint+jscs), disable mediawiki-core-jslint [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/116136 
[20:18:51] <grrrit-wm>	 (03PS5) 10Krinkle: Various clean up and refactor to make mediawiki-core-npm faster [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/116125 
[20:21:09] <grrrit-wm>	 (03PS2) 10Umherirrender: Let wildcard actions work in list=logevents&leaction= [core] - 10https://gerrit.wikimedia.org/r/117041 
[20:22:18] <grrrit-wm>	 (03CR) 10Umherirrender: "Patch Set 2: Instead of removing the wildcards, let they work now as wildcards work." [core] - 10https://gerrit.wikimedia.org/r/117041 (owner: 10Umherirrender)
[20:23:03] <grrrit-wm>	 (03PS1) 10Addshore: Cleanup a bunch of tests and add todos [core] - 10https://gerrit.wikimedia.org/r/117464 
[20:23:40] <grrrit-wm>	 (03CR) 10Krinkle: "How is leaction=foo/* different from letype=foo?" (031 comment) [core] - 10https://gerrit.wikimedia.org/r/117041 (owner: 10Umherirrender)
[20:24:48] <grrrit-wm>	 (03PS2) 10Addshore: Cleanup a bunch of tests and add todos [core] - 10https://gerrit.wikimedia.org/r/117464 
[20:24:57] <YuviPanda>	 madhuvishy: hi
[20:25:00] <YuviPanda>	 madhuvishy: vagrant ssh
[20:25:06] <YuviPanda>	 madhuvishy: then ls /vagrant
[20:25:36] <madhuvishy>	 YuviPanda, did vagrant ssh. fancy ascii showed up.
[20:25:42] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] Addition of a parser test for page= parameter of image inclusion [core] - 10https://gerrit.wikimedia.org/r/102475 (owner: 10Tpt)
[20:25:53] <madhuvishy>	 YuviPanda, okay..
[20:26:15] <YuviPanda>	 madhuvishy: do you see a /vagrant?
[20:26:21] <YuviPanda>	 madhuvishy: and a /vagrant/mediawiki?
[20:26:27] <grrrit-wm>	 (03PS1) 10Chad: Use language fallbacks where they're available [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/117465 
[20:27:39] <madhuvishy>	 YuviPanda, Yes to /vagrant. No to /vagrant/mediawiki
[20:28:10] <YuviPanda>	 madhuvishy: ah!
[20:28:17] <YuviPanda>	 madhuvishy: ok, so exit the ssh session
[20:28:23] <YuviPanda>	 madhuvishy: wait
[20:28:28] <YuviPanda>	 madhuvishy: is there anytihng at all inside /vagrant?
[20:28:28] <madhuvishy>	 YuviPanda, okay
[20:29:01] <madhuvishy>	 YuviPanda, yes. LocalSettings.php puppet logs etc
[20:29:23] <grrrit-wm>	 (03CR) 10Umherirrender: "A extension usually register an own type and can than have some sub types. You can filter all types with letype=, but searching for a type" [core] - 10https://gerrit.wikimedia.org/r/117041 (owner: 10Umherirrender)
[20:29:31] <YuviPanda>	 madhuvishy: okay, then exit it, rm -rf the 'mediawiki' folder in your Mediawiki-Vagrant checkout, run vagrant provision again
[20:29:59] <grrrit-wm>	 (03CR) 10Jeroen De Dauw: [C: 031] "haha, this test is funny" [core] - 10https://gerrit.wikimedia.org/r/117042 (owner: 10Addshore)
[20:30:05] <grrrit-wm>	 (03PS3) 10Umherirrender: Let wildcard actions work in list=logevents&leaction= [core] - 10https://gerrit.wikimedia.org/r/117041 
[20:31:25] <YuviPanda>	 madhuvishy: the git clone just must've failed the first time :)
[20:32:20] <grrrit-wm>	 (03CR) 10Nemo bis: Correct parameter passed checkImages.php (031 comment) [core] - 10https://gerrit.wikimedia.org/r/117027 (owner: 10AalekhN)
[20:33:13] <madhuvishy>	 YuviPanda, I did git clone https://gerrit.wikimedia.org/r/mediawiki/vagrant
[20:33:32] <YuviPanda>	 madhuvishy: yeah, but inside that there should be a 'mediawiki' folder?
[20:33:33] <YuviPanda>	 madhuvishy: no?
[20:33:48] <grrrit-wm>	 (03CR) 10Umherirrender: "Patch Set 3: Fixed typo and removed trailing spaces" (031 comment) [core] - 10https://gerrit.wikimedia.org/r/117041 (owner: 10Umherirrender)
[20:33:50] <grrrit-wm>	 (03PS1) 10EBernhardson: Method to identify if a ChangesList is watchlist or normal [core] - 10https://gerrit.wikimedia.org/r/117466 
[20:33:51] <madhuvishy>	 YuviPanda, but if i hit the URL on the browser, it says not found. if I clone, there is no mediawiki folder
[20:34:08] <YuviPanda>	 madhuvishy: yeah, there's no mediawiki folder first, you need to provision for the folder to turn up
[20:34:14] <YuviPanda>	 madhuvishy: it's all puppet magic :)
[20:34:18] <madhuvishy>	 YuviPanda, aah
[20:34:18] <YuviPanda>	 madhuvishy: did you run provision --force?
[20:35:52] <madhuvishy>	 YuviPanda, I clone, cd vagrant. vagrant provision. it says VM not created, moving on.
[20:36:02] <YuviPanda>	 madhuvishy: vagrant up?
[20:36:16] <YuviPanda>	 madhuvishy: do 'vagrant up', 'vagrant provision --force' try again?
[20:37:18] <grrrit-wm>	 (03CR) 10Nemo bis: "Hi, thanks for your patch!" (031 comment) [extensions/OpenBadges] - 10https://gerrit.wikimedia.org/r/116452 (owner: 10Aizhuli90)
[20:39:42] <YuviPanda>	 madhuvishy: I'm off to sleep now :( can you file a bug at https://bugzilla.wikimedia.org/ if it still doesn't work?
[20:40:01] <madhuvishy>	 YuviPanda, okay, sure. thanks. 
[20:40:05] <YuviPanda>	 madhuvishy: yw :)
[20:40:13] <grrrit-wm>	 (03PS2) 10Chad: Use language fallbacks where they're available [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/117465 
[20:40:45] <YuviPanda>	 madhuvishy: actually, https://bugzilla.wikimedia.org/show_bug.cgi?id=61235
[20:40:53] <grrrit-wm>	 (03CR) 10Manybubbles: [C: 032] "Lets try it." [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/117465 (owner: 10Chad)
[20:40:59] <grrrit-wm>	 (03Merged) 10jenkins-bot: Use language fallbacks where they're available [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/117465 (owner: 10Chad)
[20:41:11] <YuviPanda>	 madhuvishy: has a workaround if it happens again. ideally it shouldn't, but still
[20:41:21] <YuviPanda>	 madhuvishy: you should also comment there if the workaround works for you
[20:41:40] <madhuvishy>	 YuviPanda, okay will do.
[20:41:48] <YuviPanda>	 madhuvishy: :)
[20:41:49] <YuviPanda>	 bye!
[20:41:54] <madhuvishy>	 bye
[20:42:59] <grrrit-wm>	 (03PS7) 10EBernhardson: Make BoardHistory a Formatter instance [extensions/Flow] - 10https://gerrit.wikimedia.org/r/115532 
[20:43:02] <grrrit-wm>	 (03PS3) 10EBernhardson: Refactor Flow\\Formatter namespace [extensions/Flow] - 10https://gerrit.wikimedia.org/r/117384 
[20:45:33] <grrrit-wm>	 (03PS7) 10Inchikutty: UploadWizard: OSM embedding: Geocoding, reverse geocoding [extensions/UploadWizard] (osm) - 10https://gerrit.wikimedia.org/r/116130 
[20:55:59] <grrrit-wm>	 (03PS3) 10Nemo bis: Adding config variable to toggle tracking category [extensions/AJAXPoll] - 10https://gerrit.wikimedia.org/r/117254 (owner: 10GeorgeBarnick)
[20:56:18] <grrrit-wm>	 (03CR) 10Nemo bis: "Thanks for the patch! Wrapped some lines in the commit message." [extensions/AJAXPoll] - 10https://gerrit.wikimedia.org/r/117254 (owner: 10GeorgeBarnick)
[20:57:56] <grrrit-wm>	 (03CR) 10Nemo bis: Changed deprecated $wgCopyrightIcon (031 comment) [core] - 10https://gerrit.wikimedia.org/r/109903 (owner: 10Lekshmi)
[21:00:02] <grrrit-wm>	 (03CR) 10Nemo bis: "Thanks! So you're making a fork "just" for code style? Or is our version already different from upstream's? If not, did you try submitting" [extensions/PubSubHubbub] - 10https://gerrit.wikimedia.org/r/116989 (owner: 10Nik)
[21:00:29] <grrrit-wm>	 (03PS2) 10Nemo bis: Introduce ow_add_definition function to API. [extensions/WikiLexicalData] - 10https://gerrit.wikimedia.org/r/116270 (owner: 10Purodha)
[21:01:14] <grrrit-wm>	 (03CR) 10Nemo bis: "Fantastic to see you active in gerrit, purodha!" [extensions/WikiLexicalData] - 10https://gerrit.wikimedia.org/r/116270 (owner: 10Purodha)
[21:06:11] <grrrit-wm>	 (03CR) 10Umherirrender: "A "@since 1.23" would be nice. Optional you can change the one usage of the property in OldChangesList to the new method." [core] - 10https://gerrit.wikimedia.org/r/117466 (owner: 10EBernhardson)
[21:06:20] <grrrit-wm>	 (03PS6) 10Inchikutty: Embedding leaflet maps based on OSM data to UploadWizard [extensions/UploadWizard] (osm) - 10https://gerrit.wikimedia.org/r/116129 
[21:10:11] <grrrit-wm>	 (03CR) 10Nik: "It's actually the same code as upstream, though the PubSubHubbub project has different coding styles and adding their entire repo as a dep" [extensions/PubSubHubbub] - 10https://gerrit.wikimedia.org/r/116989 (owner: 10Nik)
[21:14:06] <spagewmf>	 hashar: êtes-vous éveillé ? the Flow extension's phpunit tests integration with AbuseFilter and SpamBlacklist, but they aren't enabled in Jenkins, is there a way to configure them in Jenkins?
[21:16:15] <hashar>	 spagewmf: do you mean Flow depends on AbuseFilter and SpamBlacklist extensions?
[21:16:33] <grrrit-wm>	 (03PS7) 10Addshore: Remove unused stuff from tests [core] - 10https://gerrit.wikimedia.org/r/109470 
[21:16:41] <grrrit-wm>	 (03PS7) 10Addshore: Move QueryPage.php to specialpage folder [core] - 10https://gerrit.wikimedia.org/r/109587 
[21:16:42] <spagewmf>	 hashar: it integrates with them and has tests for the integration, but doesn't require them.
[21:16:52] <grrrit-wm>	 (03PS7) 10Addshore: Implement ApiQuerySites class [core] - 10https://gerrit.wikimedia.org/r/110427 
[21:17:09] <grrrit-wm>	 (03PS2) 10Addshore: Clean up ExportDemoTest [core] - 10https://gerrit.wikimedia.org/r/116955 
[21:17:25] <hashar>	 spagewmf: we can have the Jenkins job fetch them.  It is a dirty hack but works :]
[21:18:08] <grrrit-wm>	 (03PS2) 10Addshore: Fix phpdoc of class vars in ResourceLoader [core] - 10https://gerrit.wikimedia.org/r/117448 
[21:18:19] <grrrit-wm>	 (03CR) 10Umherirrender: Redid WhatLinksHere query and added a _from_namespace field (032 comments) [core] - 10https://gerrit.wikimedia.org/r/117373 (owner: 10Aaron Schulz)
[21:18:58] <spagewmf>	 hashar: thx, I'll file a bug. (Do other teams run their own jenkins CI? we rely on "the experts" for this stuff :o) )
[21:19:05] <hashar>	 spagewmf: dont bother with a bug
[21:19:09] <hashar>	 spagewmf: doing it right now :]
[21:21:14] <grrrit-wm>	 (03PS1) 10Hashar: Dependencies for Flow [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/117474 
[21:21:36] <hashar>	 spagewmf:  https://gerrit.wikimedia.org/r/117474
[21:21:39] <grrrit-wm>	 (03PS5) 10Tpt: Addition of a parser test for page= parameter of image inclusion [core] - 10https://gerrit.wikimedia.org/r/102475 
[21:21:59] <hashar>	 spagewmf: sorry should have paired with you to let you do it but it is late here :D
[21:22:44] <grrrit-wm>	 (03PS23) 10CSteipp: Added password hashing API [core] - 10https://gerrit.wikimedia.org/r/77645 (owner: 10Parent5446)
[21:24:20] <grrrit-wm>	 (03CR) 10CSteipp: [C: 032] "PS23: Rebase to get rid of release notes conflict." [core] - 10https://gerrit.wikimedia.org/r/77645 (owner: 10Parent5446)
[21:26:19] <spagewmf>	 hashar ++!  Teach a man to fish... but then he'll still eat your food :)
[21:26:37] <grrrit-wm>	 (03CR) 10Umherirrender: [C: 031] Add a deprecation notice of $wgRateLimitLog in RELEASE-NOTES [core] - 10https://gerrit.wikimedia.org/r/116755 (owner: 10IAlex)
[21:26:44] <hashar>	 spagewmf: yeah I need to train folks I guess
[21:26:50] <addshore>	 D
[21:26:51] <addshore>	 :D
[21:27:10] <hashar>	 and push some folks to get composer for all extensions :]
[21:27:51] * addshore  would be more than willing to throw patches at all the extensions to allow them to be included with composer ;p

[21:28:18] <Nemo_bis>	 addshore: do so then :) I'm sure there are people willing to review
[21:28:23] <addshore>	 xD
[21:28:24] <grrrit-wm>	 (03CR) 10Umherirrender: [C: 031] Preferences.php: avoid "Undefined index" if key 'realname' don't exist in $formdata [core] - 10https://gerrit.wikimedia.org/r/116282 (owner: 10GBT248)
[21:28:25] <Nemo_bis>	 and most extensions are unmaintained anyway
[21:28:26] <grrrit-wm>	 (03CR) 10Aaron Schulz: Redid WhatLinksHere query and added a _from_namespace field (031 comment) [core] - 10https://gerrit.wikimedia.org/r/117373 (owner: 10Aaron Schulz)
[21:28:38] <Nemo_bis>	 so any core dev can merge without annoying anyone
[21:28:39] <addshore>	 Nemo_bis: indeed :/
[21:31:05] <grrrit-wm>	 (03PS7) 10Aaron Schulz: Redid WhatLinksHere query and added a _from_namespace field [core] - 10https://gerrit.wikimedia.org/r/117373 
[21:33:11] <grrrit-wm>	 (03CR) 10Bartosz Dziewoński: [C: 032] "Next branch cut is on 13 March, so we can merge this already." [core] - 10https://gerrit.wikimedia.org/r/82102 (owner: 10Bartosz Dziewoński)
[21:35:08] <grrrit-wm>	 (03CR) 10Hashar: "And are you sure https://gerrit.wikimedia.org/r/#/c/82100/ got deployed 31 days before March 13th ? :-D" [core] - 10https://gerrit.wikimedia.org/r/82102 (owner: 10Bartosz Dziewoński)
[21:35:35] <^d>	 hashar: Yay, you're here!
[21:35:58] <hashar>	 ^d: na heading bed in a few minutes
[21:36:03] <^d>	 Nooo :(
[21:36:04] <hashar>	 ^d: solving some jenkins madness first.  
[21:36:28] <grrrit-wm>	 (03CR) 10Bartosz Dziewoński: [C: 04-2] "I'm pretty sure, I commented a month ago that 13 March is the right date and I hope I calculated this then. Was it not?" [core] - 10https://gerrit.wikimedia.org/r/82102 (owner: 10Bartosz Dziewoński)
[21:36:29] <greg-g>	 the story of antoine's life
[21:36:31] <hashar>	 ^d: I got ebernhardson|lch patch applied for the hhvm job. Which is to enable JIT and that solved segfaults / missing class. The tests are passing \O/
[21:36:37] <hashar>	 ^d: was it to get gerrit upgradeD?
[21:36:38] <MatmaRex>	 hashar: stop scaring me
[21:36:52] <grrrit-wm>	 (03CR) 10Umherirrender: [C: 031] Send the full title to the 'nogomatch' debug log group [core] - 10https://gerrit.wikimedia.org/r/111663 (owner: 10IAlex)
[21:36:54] <^d>	 hashar: No, I've got a window monday evening for it.
[21:37:02] <hashar>	 ^d: excellent!
[21:37:14] <^d>	 hashar: I was wanting to set up a jenkins slave in eqiad labs but the puppet class wasn't working.
[21:37:25] <hashar>	 ohhh
[21:37:41] <hashar>	 ^d: go ahead, what is wrong with it ? :-]
[21:38:00] <^d>	 Puppet fails on stuff like.
[21:38:02] <^d>	 Mar  7 21:37:09 hhvm-build ntpd[7594]: bind(22) AF_INET6 fe80::f816:3eff:fed3:af53%2#123 flags 0x11 failed: Cannot assign requested address
[21:38:02] <^d>	 Mar  7 21:37:09 hhvm-build ntpd[7594]: unable to create socket on eth0 (213) for fe80::f816:3eff:fed3:af53#123
[21:38:02] <^d>	 Mar  7 21:37:09 hhvm-build ntpd[7594]: failed to init interface for address fe80::f816:3eff:fed3:af53
[21:38:11] <grrrit-wm>	 (03CR) 10Bartosz Dziewoński: "Yes, it was deployed with 1.23wmf13, which was undeployed entirely no later than on 13 February." [core] - 10https://gerrit.wikimedia.org/r/82102 (owner: 10Bartosz Dziewoński)
[21:38:49] <MatmaRex>	 hashar: *grumble grumble*
[21:38:58] <hashar>	 ^d: that is in the console isn't it ?  You might want to poke folks in #wikimedia-labs
[21:39:08] <^d>	 Yeah, I should.
[21:39:12] <^d>	 Ok, have a good sleep!
[21:39:13] <^d>	 :)
[21:39:24] <hashar>	 ^d: also you need to wait a bit before the instance is usable.
[21:39:31] <MatmaRex>	 hashar: is that 30 days or 31 days, btw? i thought it was 30
[21:39:40] <hashar>	 ^d: I usually wait 10 - 20 minutes, connect there then  sudo su -  and run puppetd -tv
[21:40:07] <hashar>	 MatmaRex: yeah my concern is merely to find out when the previous patch got deployed.
[21:40:14] <^d>	 hashar: Been going on for like 2hrs :\
[21:40:28] <grrrit-wm>	 (03CR) 10Bartosz Dziewoński: [C: 032] "KAMIKAZE" [core] - 10https://gerrit.wikimedia.org/r/82102 (owner: 10Bartosz Dziewoński)
[21:40:33] <hashar>	 ^d: hhvm-build.eqiad.wmflabs ? 
[21:40:36] <^d>	 Yeah
[21:40:43] <MatmaRex>	 gerrit totally should let us do delayed merges or something
[21:40:56] <grrrit-wm>	 (03CR) 10Umherirrender: Redid WhatLinksHere query and added a _from_namespace field (034 comments) [core] - 10https://gerrit.wikimedia.org/r/117373 (owner: 10Aaron Schulz)
[21:41:12] <MatmaRex>	 i have two more pending changes that are just waiting for the right time, eh
[21:41:46] <grrrit-wm>	 (03CR) 10Aaron Schulz: Redid WhatLinksHere query and added a _from_namespace field (031 comment) [core] - 10https://gerrit.wikimedia.org/r/117373 (owner: 10Aaron Schulz)
[21:42:49] <grrrit-wm>	 (03PS8) 10Aaron Schulz: Redid WhatLinksHere query and added a _from_namespace field [core] - 10https://gerrit.wikimedia.org/r/117373 
[21:42:58] <grrrit-wm>	 (03PS8) 10Inchikutty: UploadWizard: OSM embedding: Geocoding, reverse geocoding [extensions/UploadWizard] (osm) - 10https://gerrit.wikimedia.org/r/116130 
[21:43:57] <hashar>	 ^d: so yeah poke ops about it :-]
[21:44:47] <hashar>	 ^d: you will have to add the node manually in jenkins interface. There is some scary configuration with a user jenkins-deploy or jenkins-slave.
[21:44:57] <hashar>	 ^d: not even sure why I ended up with two different usernames hehe
[21:45:05] <grrrit-wm>	 (03CR) 10Aaron Schulz: [C: 032] Add a deprecation notice of $wgRateLimitLog in RELEASE-NOTES [core] - 10https://gerrit.wikimedia.org/r/116755 (owner: 10IAlex)
[21:45:27] <grrrit-wm>	 (03PS9) 10Inchikutty: UploadWizard: OSM embedding: Geocoding, reverse geocoding [extensions/UploadWizard] (osm) - 10https://gerrit.wikimedia.org/r/116130 
[21:45:50] <^d>	 hashar: Yeah, I knew I had more work to do :)
[21:45:53] <^d>	 Thanks for your help.
[21:46:14] <hashar>	 ^d: we can poke at it on monday if you want. I usually connect at noon PST
[21:48:19] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] Added password hashing API [core] - 10https://gerrit.wikimedia.org/r/77645 (owner: 10Parent5446)
[21:49:53] <grrrit-wm>	 (03PS24) 10Parent5446: Added password hashing API [core] - 10https://gerrit.wikimedia.org/r/77645 
[21:51:04] <greg-g>	 hashar: don't forget about daylight savings!
[21:52:15] <hashar>	 greg-g: oh my god
[21:52:27] <hashar>	 greg-g: DST kills me sleep schedule for up to six weeks :-/
[21:52:35] <greg-g>	 :/
[21:52:46] <hashar>	 I should get a couple years of vacations probably
[21:52:48] <grrrit-wm>	 (03PS1) 10Toniher: Adding a new magic word: SCOREPAGE [extensions/VoteNY] - 10https://gerrit.wikimedia.org/r/117599 
[21:57:13] <grrrit-wm>	 (03CR) 10Aaron Schulz: [C: 032] Remove unused stuff from tests [core] - 10https://gerrit.wikimedia.org/r/109470 (owner: 10Addshore)
[21:57:58] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] Addition of a parser test for page= parameter of image inclusion [core] - 10https://gerrit.wikimedia.org/r/102475 (owner: 10Tpt)
[21:58:00] <grrrit-wm>	 (03CR) 10Krinkle: "It's consistently failing on mw-run-phpunit.sh: line 102: 12749 Segmentation fault. Only with this change applied. Other commits between t" [core] - 10https://gerrit.wikimedia.org/r/77645 (owner: 10Parent5446)
[21:58:51] <grrrit-wm>	 (03Merged) 10jenkins-bot: Remove HTML back-compat styles from I5fe0543e [core] - 10https://gerrit.wikimedia.org/r/82102 (owner: 10Bartosz Dziewoński)
[21:59:24] <grrrit-wm>	 (03Merged) 10jenkins-bot: Add a deprecation notice of $wgRateLimitLog in RELEASE-NOTES [core] - 10https://gerrit.wikimedia.org/r/116755 (owner: 10IAlex)
[21:59:54] <hashar>	 spagewmf: Flow tests are now failing  https://integration.wikimedia.org/ci/job/mwext-Flow-testextensions-master/3047/console
[22:00:35] <spagewmf>	 oops, I'll take a loo
[22:00:38] <kaldari>	 for some reason Jenkins-bot won't run on this change any more: https://gerrit.wikimedia.org/r/#/c/111253/
[22:00:42] <spagewmf>	 k
[22:00:57] <hashar>	 kaldari: retrigger it , I restarted Jenkins earlier and it might not have catcher it
[22:01:08] <hashar>	 kaldari: Jenkins went wild for the last hour or so. Sorry :-(
[22:01:21] <hashar>	 spagewmf: it might be related to the addition of AbuseFilter and SpamBlacklist extensions
[22:01:39] <grrrit-wm>	 (03Merged) 10jenkins-bot: Remove unused stuff from tests [core] - 10https://gerrit.wikimedia.org/r/109470 (owner: 10Addshore)
[22:02:35] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] Added password hashing API [core] - 10https://gerrit.wikimedia.org/r/77645 (owner: 10Parent5446)
[22:02:42] <hashar>	 spagewmf: https://integration.wikimedia.org/ci/job/mwext-Flow-testextensions-master/3047/testReport/junit/(root)/Flow_Tests_RevisionCollectionPermissionsTest__testPermissions/testPermissions_with_data_set__5/
[22:03:03] <grrrit-wm>	 (03PS9) 10Krinkle: Redo WhatLinksHere query and add a *_from_namespace field to link tables [core] - 10https://gerrit.wikimedia.org/r/117373 (owner: 10Aaron Schulz)
[22:03:08] <grrrit-wm>	 (03PS17) 10Bsitu: No need to load workflow in formatters [extensions/Flow] - 10https://gerrit.wikimedia.org/r/112846 (owner: 10EBernhardson)
[22:03:13] <hashar>	 kaldari: maybe Jenkins was just a bit slow :-]
[22:03:32] <grrrit-wm>	 (03CR) 10Addshore: "https://github.com/wikimedia/integration-jenkins/blob/master/bin/mw-run-phpunit.sh#L102" [core] - 10https://gerrit.wikimedia.org/r/77645 (owner: 10Parent5446)
[22:03:42] <grrrit-wm>	 (03CR) 10Krinkle: "Mentioned "link tables" in commit message. From a glance it didn't look like t his commit would add additional database fields to core dat" [core] - 10https://gerrit.wikimedia.org/r/117373 (owner: 10Aaron Schulz)
[22:03:57] <hashar>	 spagewmf: off to bed.  The easiest is probably to skip / ignore that test for now and fix it later on.
[22:04:09] <hashar>	 spagewmf: you can add the  '@group broken'  on the test to get it ignored
[22:04:23] <spagewmf>	 hashar: ebernhardson says it's an intermittent failure we can't fgigure out, not directly related. Thanks, dormez bien :)
[22:05:14] <hashar>	 spagewmf: :-(
[22:05:24] <grrrit-wm>	 (03CR) 10Krinkle: "That's merely the top call, this is likely not related to our script or phpunit, but php itself actually segfaulting on this. E.g. the the" [core] - 10https://gerrit.wikimedia.org/r/77645 (owner: 10Parent5446)
[22:05:24] <hashar>	 spagewmf: merci !
[22:06:04] <hashar>	 Krinkle: interestingly the hhvm job run just fine and does not segfault :-D
[22:06:23] <Krinkle>	 hashar: you sound surprised?
[22:06:48] <hashar>	 Krinkle: yup because the first few runs kept segfaulting until ebernhardson enabled HHVM JIT :-]
[22:06:53] <Krinkle>	 If PHP segfaults, it's pretty much guranteed to be an implementation error. Two implementations making the same mistake to that low level is unlikely I'd say.
[22:06:56] <thedj_>	 StevenW: btw. on typography, were the comments about broken floats and the blockquote problems picked up yet ?
[22:07:05] <Krinkle>	 At least in javascript engines these are usually specific to one engine
[22:07:10] <thedj_>	 StevenW: before someone deploys it in 2 weeks to production....
[22:07:11] <grrrit-wm>	 (03CR) 10Bsitu: [C: 032] No need to load workflow in formatters [extensions/Flow] - 10https://gerrit.wikimedia.org/r/112846 (owner: 10EBernhardson)
[22:07:17] <Krinkle>	 hashar: aha
[22:07:30] <Krinkle>	 So HHVM without JIT also failed?
[22:07:42] <hashar>	 Krinkle: on a different patch
[22:07:48] <grrrit-wm>	 (03Merged) 10jenkins-bot: No need to load workflow in formatters [extensions/Flow] - 10https://gerrit.wikimedia.org/r/112846 (owner: 10EBernhardson)
[22:07:57] <hashar>	 Krinkle: without JIT it fails most of the time with segfault or  class not being found
[22:08:11] <grrrit-wm>	 (03PS10) 10Aaron Schulz: Redo WhatLinksHere query and add a *_from_namespace field to link tables [core] - 10https://gerrit.wikimedia.org/r/117373 
[22:08:37] <Krinkle>	 hashar: 15 minutes and 22 minutes?
[22:08:42] <Krinkle>	 That looks like a *serious* problem
[22:08:48] <Krinkle>	 for the non database phpunit tests
[22:09:06] <hashar>	 Krinkle: Jenkins went wild again 
[22:09:29] <grrrit-wm>	 (03CR) 10Hashar: [C: 032] Dependencies for Flow [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/117474 (owner: 10Hashar)
[22:09:32] <KillerWalrus>	 am I correct to assume that setter functions will succeed Block.php's 14 optional parameters?
[22:09:34] <^d>	 How about we just turn hhvm back off for now?
[22:09:48] <^d>	 Rather than leaving it weird over the weekend?
[22:09:50] <grrrit-wm>	 (03Merged) 10jenkins-bot: Dependencies for Flow [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/117474 (owner: 10Hashar)
[22:09:59] <Krinkle>	 hashar: So I don't know if these things are connected, but as said before I very often see lots of jobs queued, and only 1 or 2 things execeuting in all of jenkins. Put differently, almost nothing ever runs in parallel. 
[22:10:13] <Krinkle>	 But afaik lots of things do allow concurrency, so something is blocking stuff.
[22:10:26] <grrrit-wm>	 (03CR) 10Parent5446: "God help me. I swear it's not my fault! :P" [core] - 10https://gerrit.wikimedia.org/r/77645 (owner: 10Parent5446)
[22:10:27] <thedj>	 StevenW: i don't know who wrote the blockquote change, but that person should read up about display:block...
[22:10:28] <hashar>	 ^d: are you talking about the mw core hhvm job ?  It is set to timeout after 8 minutes.
[22:10:55] <hashar>	 Krinkle: yeah Jenkins was CPU overloaded due to some nasty issue
[22:11:20] <grrrit-wm>	 (03CR) 10Cscott: "Yeah, I probably need to run dumpGrepper." [core] - 10https://gerrit.wikimedia.org/r/116995 (owner: 10Cscott)
[22:11:21] <hashar>	 Krinkle: aka web crawlers hitting all the URLs :(
[22:11:40] <hashar>	 Krinkle: the qunit jobs are not concurrent iirc.
[22:12:31] <grrrit-wm>	 (03PS6) 10Tpt: Addition of a parser test for page= parameter of image inclusion [core] - 10https://gerrit.wikimedia.org/r/102475 
[22:13:09] <grrrit-wm>	 (03PS2) 10EBernhardson: Method to identify if a ChangesList is watchlist or normal [core] - 10https://gerrit.wikimedia.org/r/117466 
[22:13:17] <Krinkle>	 hashar: They are, if not, I'll make them right now. NO reason for them not to be
[22:14:16] <grrrit-wm>	 (03CR) 10Parent5446: [C: 04-1] "Needs pgsql, mssql, and oracle patches." [core] - 10https://gerrit.wikimedia.org/r/112825 (owner: 10leucosticte)
[22:14:27] <Krinkle>	 hashar: Hm.. indeed, they're not. Do you know a reason for them not to be?
[22:14:44] <hashar>	 Krinkle: I think the qunit job had some hardcoded paths at some point, i.e. not varying by workspace
[22:14:51] <hashar>	 Krinkle: might be fixed now
[22:15:01] <grrrit-wm>	 (03PS2) 10EBernhardson: Inject CheckUser data more directly [extensions/Flow] - 10https://gerrit.wikimedia.org/r/117253 
[22:15:02] <hashar>	 Krinkle: iirc they would use the same sqlite database :-]
[22:15:25] <hashar>	 Krinkle: but that might be fixed now
[22:15:28] <grrrit-wm>	 (03CR) 10Cscott: [C: 04-1] "On IRC, gwicke and I agreed on "!!html, !!html/php !!html/parsoid and maybe in a decade or so !!html/php,parsoid or !!html/* when there ar" [core] - 10https://gerrit.wikimedia.org/r/89141 (owner: 10Arlolra)
[22:15:34] <Krinkle>	 yeah, it uses paths that contain /TEST_ID/ and they symlink to WORKSPACE
[22:15:37] <Krinkle>	 so should be fine
[22:15:44] <hashar>	 should be
[22:15:47] <Krinkle>	 Hm.. not sure about db
[22:15:55] <hashar>	 too late for me to figure it out
[22:15:59] <grrrit-wm>	 (03CR) 10Parent5446: [C: 031] Categorize pages containing blacklisted links [extensions/SpamBlacklist] - 10https://gerrit.wikimedia.org/r/117231 (owner: 10Jackmcbarn)
[22:16:12] <Krinkle>	 hashar: It uses the general 'mw-setup-extension' macro, not a special one
[22:16:20] <hashar>	 so that might work :]
[22:16:25] <Krinkle>	 I'm assuming that one is fine with concurrency? If not, none of our phpunit would be able to run concufrent.
[22:17:06] <hashar>	 indeed
[22:17:38] <hashar>	 falling a sleep *wave*
[22:18:06] <greg-g>	 g'night
[22:19:04] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] Addition of a parser test for page= parameter of image inclusion [core] - 10https://gerrit.wikimedia.org/r/102475 (owner: 10Tpt)
[22:19:31] <grrrit-wm>	 (03PS1) 10Krinkle: Allow qunit jobs to run concurrent [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/117603 
[22:19:34] <grrrit-wm>	 (03PS1) 10Krinkle: Explicitly set concurrency to false for doxygen-publish [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/117604 
[22:25:22] <grrrit-wm>	 (03CR) 10Jdlrobson: [C: 032] Add COPYING [extensions/VectorBeta] - 10https://gerrit.wikimedia.org/r/116246 (owner: 10Reedy)
[22:25:27] <grrrit-wm>	 (03Merged) 10jenkins-bot: Add COPYING [extensions/VectorBeta] - 10https://gerrit.wikimedia.org/r/116246 (owner: 10Reedy)
[22:40:51] <grrrit-wm>	 (03PS5) 10Cscott: Rename sections in parserTests.txt [core] - 10https://gerrit.wikimedia.org/r/89141 (owner: 10Arlolra)
[22:40:53] <grrrit-wm>	 (03PS1) 10Cscott: Rename sections in parserTests.txt. [core] - 10https://gerrit.wikimedia.org/r/117613 
[22:41:44] <grrrit-wm>	 (03CR) 10Cscott: [C: 04-2] "-2'ing because I'm not done with it yet, I want to add the html/php and html/parsoid aliases." [core] - 10https://gerrit.wikimedia.org/r/89141 (owner: 10Arlolra)
[22:45:15] <grrrit-wm>	 (03CR) 10Aaron Schulz: [C: 04-2] "Schema change" [core] - 10https://gerrit.wikimedia.org/r/117373 (owner: 10Aaron Schulz)
[22:45:40] <grrrit-wm>	 (03PS5) 10Manybubbles: More Jenkins fixes [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/117423 
[22:50:33] <grrrit-wm>	 (03CR) 10Aaron Schulz: [C: 032] Revert "Rollback: Make update of recentchanges table later" [core] - 10https://gerrit.wikimedia.org/r/117307 (owner: 10Umherirrender)
[22:52:56] <grrrit-wm>	 (03CR) 10Chad: [C: 032] Report calls to deprecated methods as errors in PHP log [vagrant] - 10https://gerrit.wikimedia.org/r/75544 (owner: 10Ori.livneh)
[22:53:04] <grrrit-wm>	 (03Merged) 10jenkins-bot: Report calls to deprecated methods as errors in PHP log [vagrant] - 10https://gerrit.wikimedia.org/r/75544 (owner: 10Ori.livneh)
[22:54:25] <grrrit-wm>	 (03Merged) 10jenkins-bot: Revert "Rollback: Make update of recentchanges table later" [core] - 10https://gerrit.wikimedia.org/r/117307 (owner: 10Umherirrender)
[22:55:36] <grrrit-wm>	 (03Abandoned) 10Chad: Make 'remote_debug' PHP settings the default; retire role [vagrant] - 10https://gerrit.wikimedia.org/r/113521 (owner: 10Ori.livneh)
[22:58:21] <StevenW>	 thedj: we won't be including the blockquote changes
[23:03:09] <grrrit-wm>	 (03CR) 10Spage: "FYI Flow creates a SpamBlacklist object and invokes filter() on links in a post. But it's using Parsoid, so this hook won't run; besides," [extensions/SpamBlacklist] - 10https://gerrit.wikimedia.org/r/117231 (owner: 10Jackmcbarn)
[23:03:35] <spagewmf>	 gwicke, James_F : ^ is Parsoid integration with AbuseFilter/SpamBlacklist/wfIsBadImage on your radar? Flow is doing it ad hoc
[23:04:08] <gwicke>	 spagewmf, it is on the radar, but not very high right now
[23:04:38] <gwicke>	 afaik that area is a mess in PHP
[23:04:49] <gwicke>	 so nobody wants to touch it
[23:04:56] <hoo>	 gwicke: Yes, yes, yes, yes ...
[23:05:06] <gwicke>	 ;)
[23:05:40] <spagewmf>	 gwicke: thanks.  I guess VE ends up submitting to parser to store your edit and that's when these things run?  Flow of course just stores the Parsoid HTML
[23:05:52] <hoo>	 I should have never taken over AbuseFilter... it's like *shivers*
[23:05:52] <gwicke>	 yes
[23:06:34] <gwicke>	 spagewmf, to work on HTML we'll probably have to extract just the blacklisted URLs etc, and apply them to hrefs instead of some wikitext regexp
[23:06:44] <gwicke>	 I have not looked into it too deeply though
[23:07:42] <spagewmf>	 gwicke: might some day sanitize & check extensions hook into Parsoid?  Fire up a PHP interpreter compiled to JS and wfRunHook...  8-/ !?
[23:07:54] <gwicke>	 spagewmf, since you re-parse already, it might also be possible to just run it on the wikitext
[23:08:45] <gwicke>	 spagewmf, I'd rather convert the blacklist/abusefilter stuff into a service
[23:23:07] <grrrit-wm>	 (03PS1) 10Jdlrobson: Vector: Make animation LESS component [core] - 10https://gerrit.wikimedia.org/r/117617 
[23:27:03] <grrrit-wm>	 (03CR) 10Bsitu: [C: 032] Remove unnecessary branching in validation [extensions/Flow] - 10https://gerrit.wikimedia.org/r/115564 (owner: 10EBernhardson)
[23:27:20] <grrrit-wm>	 (03Merged) 10jenkins-bot: Remove unnecessary branching in validation [extensions/Flow] - 10https://gerrit.wikimedia.org/r/115564 (owner: 10EBernhardson)
[23:27:55] <helderwiki>	 MatmaRex: do you think it is possible to warn users who try to access the JS wgVariables directly instead of using the recommended interface, which is mw.config.get('wgTitle')?
[23:28:04] <helderwiki>	 Maybe with mw.log.deprecate ?
[23:28:39] <MatmaRex>	 helderwiki: i think there's a bug open for that, it's rather troublesome actually
[23:28:46] <helderwiki>	 o.O
[23:29:04] <MatmaRex>	 https://bugzilla.wikimedia.org/show_bug.cgi?id=56550
[23:29:46] <MatmaRex>	 basically, the issue is that mw.config.get('wgWhatever') does window['wgWhatever'] internally. :/
[23:30:22] <MatmaRex>	 and we can't avoid that unless we "separete" the two interfaces, which will cause them to get desynchronized if some code is clever enough to try to set them
[23:30:27] <MatmaRex>	 separate*
[23:30:33] <MatmaRex>	 helderwiki: ^
[23:31:07] <helderwiki>	 hmmm..
[23:31:15] <helderwiki>	 thanks for the link BTW
[23:34:25] <grrrit-wm>	 (03CR) 10Chad: "Still seems to be used in puppet/modules/virtualbox/manifests/init.pp." [vagrant] - 10https://gerrit.wikimedia.org/r/116676 (owner: 10MarkAHershberger)
[23:35:26] <grrrit-wm>	 (03CR) 10Chad: [C: 032] Add a role for wikidiff2 [vagrant] - 10https://gerrit.wikimedia.org/r/113884 (owner: 10MaxSem)
[23:35:29] <grrrit-wm>	 (03Merged) 10jenkins-bot: Add a role for wikidiff2 [vagrant] - 10https://gerrit.wikimedia.org/r/113884 (owner: 10MaxSem)
[23:35:36] <grrrit-wm>	 (03PS1) 10Mattflaschen: Move hooks into hooks class [extensions/WikimediaEvents] - 10https://gerrit.wikimedia.org/r/117619 
[23:36:47] <grrrit-wm>	 (03PS2) 10Bsitu: wfProfileIn/Out -> ProfileSection [extensions/Flow] - 10https://gerrit.wikimedia.org/r/116910 (owner: 10EBernhardson)
[23:37:12] <grrrit-wm>	 (03CR) 10Krinkle: [C: 032] "Pushed 'mediawiki-core-qunit', 'mwext-TemplateData-qunit', 'mwext-VisualEditor-qunit', 'mwext-Wikibase-qunit', 'mwext-MobileFrontend-qunit" [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/117603 (owner: 10Krinkle)
[23:37:32] <grrrit-wm>	 (03Merged) 10jenkins-bot: Allow qunit jobs to run concurrent [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/117603 (owner: 10Krinkle)
[23:38:04] <grrrit-wm>	 (03CR) 10Bsitu: [C: 032] wfProfileIn/Out -> ProfileSection [extensions/Flow] - 10https://gerrit.wikimedia.org/r/116910 (owner: 10EBernhardson)
[23:38:17] <grrrit-wm>	 (03Merged) 10jenkins-bot: wfProfileIn/Out -> ProfileSection [extensions/Flow] - 10https://gerrit.wikimedia.org/r/116910 (owner: 10EBernhardson)
[23:41:31] <grrrit-wm>	 (03PS1) 10Gerrit Patch Uploader: Add proofreading status (quality level) to action=info [extensions/ProofreadPage] - 10https://gerrit.wikimedia.org/r/117620 
[23:41:38] <grrrit-wm>	 (03CR) 10Gerrit Patch Uploader: "This commit was uploaded using the Gerrit Patch Uploader [1]." [extensions/ProofreadPage] - 10https://gerrit.wikimedia.org/r/117620 (owner: 10Gerrit Patch Uploader)
[23:42:45] <grrrit-wm>	 (03CR) 10PiRSquared17: "Comments?" [extensions/ProofreadPage] - 10https://gerrit.wikimedia.org/r/117620 (owner: 10Gerrit Patch Uploader)
[23:44:38] <grrrit-wm>	 (03PS1) 10Mwalker: Image files so we stop getting useless errors [core] (fundraising/REL1_22) - 10https://gerrit.wikimedia.org/r/117622 
[23:45:52] <grrrit-wm>	 (03CR) 10Krinkle: [C: 032] "Pushed 'mediawiki-core-doxygen-publish' (no difference, false is the default)" [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/117604 (owner: 10Krinkle)
[23:45:55] <grrrit-wm>	 (03CR) 10Chad: [C: 032] Remove leftover MW_VERSIONS_SYNC usage [tools/scap] - 10https://gerrit.wikimedia.org/r/116447 (owner: 10BryanDavis)
[23:46:11] <grrrit-wm>	 (03Merged) 10jenkins-bot: Explicitly set concurrency to false for doxygen-publish [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/117604 (owner: 10Krinkle)
[23:46:31] <grrrit-wm>	 (03Merged) 10jenkins-bot: Remove leftover MW_VERSIONS_SYNC usage [tools/scap] - 10https://gerrit.wikimedia.org/r/116447 (owner: 10BryanDavis)
[23:46:40] <grrrit-wm>	 (03PS1) 10EBernhardson: Fix undefined variable [extensions/Flow] - 10https://gerrit.wikimedia.org/r/117623 
[23:48:57] <grrrit-wm>	 (03PS2) 10Mwalker: Image files so we stop getting useless errors [core] (fundraising/REL1_22) - 10https://gerrit.wikimedia.org/r/117622 
[23:49:10] <huh>	 Gloria: bug 41369
[23:50:08] <grrrit-wm>	 (03PS4) 10Krinkle: PathRouter: Fix documentation typo [core] - 10https://gerrit.wikimedia.org/r/115403 
[23:50:27] <grrrit-wm>	 (03PS2) 10Jdlrobson: Add Fixed header experiment to Vector Beta [extensions/VectorBeta] - 10https://gerrit.wikimedia.org/r/107523 
[23:51:05] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] Add Fixed header experiment to Vector Beta [extensions/VectorBeta] - 10https://gerrit.wikimedia.org/r/107523 (owner: 10Jdlrobson)
[23:51:18] <grrrit-wm>	 (03CR) 10Adamw: "well... an empty file would be good enuf." [core] (fundraising/REL1_22) - 10https://gerrit.wikimedia.org/r/117622 (owner: 10Mwalker)
[23:55:46] <grrrit-wm>	 (03PS3) 10Jdlrobson: Add Fixed header experiment to Vector Beta [extensions/VectorBeta] - 10https://gerrit.wikimedia.org/r/107523 
[23:56:13] <grrrit-wm>	 (03PS1) 10Alex Monk: Mention possibility of $revision being null in PageContentSaveComplete [core] - 10https://gerrit.wikimedia.org/r/117625 
[23:57:53] <Krenair>	 ^ one line doc fix
[23:58:31] <grrrit-wm>	 (03CR) 10Chad: [C: 032] Follow-up 08091667f4c7, avoid flash of unstyled content [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/108473 (owner: 10Brian Wolff)
[23:58:42] <grrrit-wm>	 (03Merged) 10jenkins-bot: Follow-up 08091667f4c7, avoid flash of unstyled content [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/108473 (owner: 10Brian Wolff)
[23:58:51] <grrrit-wm>	 (03CR) 10CSteipp: "Tests passed for PS22. PS23 and 24 were just rebases. If it's a problem with the code for this patchset, wouldn't PS22 have failed too?" [core] - 10https://gerrit.wikimedia.org/r/77645 (owner: 10Parent5446)
[23:59:00] <grrrit-wm>	 (03PS4) 10Jdlrobson: Add Fixed header experiment to Vector Beta [extensions/VectorBeta] - 10https://gerrit.wikimedia.org/r/107523