[00:00:20] (03PS20) 10Parent5446: Added password hashing API [core] - 10https://gerrit.wikimedia.org/r/77645 [00:00:26] (03PS1) 10JGonera: Add icons to compact personal bar [extensions/VectorBeta] - 10https://gerrit.wikimedia.org/r/117119 [00:01:18] (03CR) 10jenkins-bot: [V: 04-1] Added password hashing API [core] - 10https://gerrit.wikimedia.org/r/77645 (owner: 10Parent5446) [00:01:53] (03Merged) 10jenkins-bot: HTMLForm: Clean up 0 handling [core] (wmf/1.23wmf16) - 10https://gerrit.wikimedia.org/r/117114 (owner: 10Anomie) [00:01:57] (03Merged) 10jenkins-bot: HTMLForm: Clean up 0 handling [core] (wmf/1.23wmf15) - 10https://gerrit.wikimedia.org/r/117113 (owner: 10Anomie) [00:02:11] (03PS2) 10Bsitu: Drop table flow_header_revision [extensions/Flow] - 10https://gerrit.wikimedia.org/r/117115 [00:02:16] (03PS21) 10Parent5446: Added password hashing API [core] - 10https://gerrit.wikimedia.org/r/77645 [00:03:37] (03CR) 10TheDJ: "I haven't tested this, but I wanted to point out that there is a difference between undefined alt and alt=""." [core] - 10https://gerrit.wikimedia.org/r/116483 (owner: 10Lekshmi) [00:04:32] (03CR) 10jenkins-bot: [V: 04-1] Added password hashing API [core] - 10https://gerrit.wikimedia.org/r/77645 (owner: 10Parent5446) [00:04:39] (03CR) 10jenkins-bot: [V: 04-1] Drop table flow_header_revision [extensions/Flow] - 10https://gerrit.wikimedia.org/r/117115 (owner: 10Bsitu) [00:04:47] (03PS8) 10EBernhardson: [SCHEMA CHANGE] Drop the definition model [extensions/Flow] - 10https://gerrit.wikimedia.org/r/115576 [00:04:56] (03CR) 10jenkins-bot: [V: 04-1] [SCHEMA CHANGE] Drop the definition model [extensions/Flow] - 10https://gerrit.wikimedia.org/r/115576 (owner: 10EBernhardson) [00:05:01] (03CR) 10EBernhardson: "PS8: rebase only" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/115576 (owner: 10EBernhardson) [00:06:24] (03PS9) 10EBernhardson: [SCHEMA CHANGE] Drop the definition model [extensions/Flow] - 10https://gerrit.wikimedia.org/r/115576 [00:06:32] (03CR) 10jenkins-bot: [V: 04-1] [SCHEMA CHANGE] Drop the definition model [extensions/Flow] - 10https://gerrit.wikimedia.org/r/115576 (owner: 10EBernhardson) [00:06:35] :S [00:07:25] (03PS22) 10Parent5446: Added password hashing API [core] - 10https://gerrit.wikimedia.org/r/77645 [00:07:51] (03PS1) 10Catrope: Update VisualEditor to wmf16 branch for cherry-pick [core] (wmf/1.23wmf16) - 10https://gerrit.wikimedia.org/r/117120 [00:08:26] (03PS10) 10EBernhardson: [SCHEMA CHANGE] Drop the definition model [extensions/Flow] - 10https://gerrit.wikimedia.org/r/115576 [00:09:04] (03PS1) 10Jforrester: Update OOjs UI to v0.1.0-pre (e4f6ce0156) [core] - 10https://gerrit.wikimedia.org/r/117121 [00:10:06] (03CR) 10Jarry1250: "Cool. Might it not be more transparent (not sure about the performance pros/cons) to run a GET against mediawikiwiki's API, rather than tr" [extensions/Math] - 10https://gerrit.wikimedia.org/r/112353 (owner: 10Physikerwelt) [00:10:08] (03CR) 10jenkins-bot: [V: 04-1] [SCHEMA CHANGE] Drop the definition model [extensions/Flow] - 10https://gerrit.wikimedia.org/r/115576 (owner: 10EBernhardson) [00:10:14] (03CR) 10Catrope: [C: 032 V: 032] Update VisualEditor to wmf16 branch for cherry-pick [core] (wmf/1.23wmf16) - 10https://gerrit.wikimedia.org/r/117120 (owner: 10Catrope) [00:17:48] (03PS11) 10EBernhardson: [SCHEMA CHANGE] Drop the definition model [extensions/Flow] - 10https://gerrit.wikimedia.org/r/115576 [00:18:01] (03CR) 10jenkins-bot: [V: 04-1] [SCHEMA CHANGE] Drop the definition model [extensions/Flow] - 10https://gerrit.wikimedia.org/r/115576 (owner: 10EBernhardson) [00:18:13] anyone have a script/wikipage/docs/etc. that simplifys duplicating what jenkins does(init new sqlite, run all the stuff) locally without sending it to jenkins? [00:18:24] (03PS1) 10Catrope: Update VisualEditor extension, for the right cherry-pick this time [core] (wmf/1.23wmf16) - 10https://gerrit.wikimedia.org/r/117124 [00:18:46] running phpunit is fine, its the db initialization in sqlite that always trips me up [00:18:49] init/patch/etc. [00:18:49] (03CR) 10Catrope: [C: 032 V: 032] Update VisualEditor extension, for the right cherry-pick this time [core] (wmf/1.23wmf16) - 10https://gerrit.wikimedia.org/r/117124 (owner: 10Catrope) [00:20:08] (03PS12) 10EBernhardson: [SCHEMA CHANGE] Drop the definition model [extensions/Flow] - 10https://gerrit.wikimedia.org/r/115576 [00:21:58] (03CR) 10Spage: [C: 04-1] "The button code is now in core, but Flow still needs its form override for the left blue bar on input fields until that is implemented in " [extensions/Flow] - 10https://gerrit.wikimedia.org/r/113066 (owner: 10Matthias Mullie) [00:22:30] (03CR) 10Catrope: [C: 032] Update OOjs UI to v0.1.0-pre (e4f6ce0156) [core] - 10https://gerrit.wikimedia.org/r/117121 (owner: 10Jforrester) [00:25:34] (03CR) 10EBernhardson: "PS8-12: rebase and fix sqlite initialization" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/115576 (owner: 10EBernhardson) [00:26:37] (03Merged) 10jenkins-bot: Update OOjs UI to v0.1.0-pre (e4f6ce0156) [core] - 10https://gerrit.wikimedia.org/r/117121 (owner: 10Jforrester) [00:29:19] spagewmf, not sure if you guys are still in the mw.ui meeting room. [00:29:36] I'm going to keep working on it a few more minutes, but probably won't rejoin the hangout. [00:30:19] no, we were kicked out. I filed a bug for Jared's neutral being bigger and commented on Deepak's patch. Until next time... [00:35:14] spagewmf, for me the neutral is an okay size, the issue is that it's not buttony/interesting enough. [00:36:23] superm401: I think you're right. It's OK if it's grouped with a colorful button, but a neutral button on its own doesn't look like much. [00:38:10] superm401: the size change is almost an optical illusion, the button with a background looks bigger than it is. It was very noticeable in Flow's version of Agora where disable->enable would shuffle button positions. [00:40:20] That's the slight relative size discrepancy between button types, right? [00:40:26] I've got to go, but I'll be back on later. [00:43:07] ^d: https://bugzilla.wikimedia.org/show_bug.cgi?id=62295 being fixed would make me happy… ;-) [00:44:38] (03PS3) 10Bsitu: Drop table flow_header_revision [extensions/Flow] - 10https://gerrit.wikimedia.org/r/117115 [00:46:50] (03PS3) 10Bsitu: Update flow_revision.rev_type_id [extensions/Flow] - 10https://gerrit.wikimedia.org/r/116874 [00:48:47] (03CR) 10Aaron Schulz: Added password hashing API (031 comment) [core] - 10https://gerrit.wikimedia.org/r/77645 (owner: 10Parent5446) [00:51:03] (03PS13) 10EBernhardson: [SCHEMA CHANGE] Drop the definition model [extensions/Flow] - 10https://gerrit.wikimedia.org/r/115576 [00:51:30] (03CR) 10Aaron Schulz: [C: 031] Added password hashing API [core] - 10https://gerrit.wikimedia.org/r/77645 (owner: 10Parent5446) [00:51:41] (03CR) 10EBernhardson: "addressed reviews in PS13" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/115576 (owner: 10EBernhardson) [00:56:22] <^d> James_F: And what can I do about this? :p [00:58:07] ^d: `git pull` :-) [00:58:08] (03CR) 10EBernhardson: [C: 031] "good for merge post-branch cut tomorrow" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/117023 (owner: 10Bsitu) [00:58:21] <^d> And how do you propose I do that? [00:58:22] <^d> :p [01:04:16] ^d: I dunno. It's the CI wiki… [01:04:31] ^d: Certainly, you're more likely to have shell on it than I am. :-) [01:04:36] <^d> wikitechwiki? It's labs stuff. [01:04:42] <^d> I don't have access to update that. [01:04:51] Really? That should be fixed. [01:05:11] (03PS2) 10Spage: Remove Flow's mw-ui-button overrides [extensions/Flow] - 10https://gerrit.wikimedia.org/r/113066 (owner: 10Matthias Mullie) [01:06:03] <^d> James_F: It's not a cluster wiki. This is an old discussion. [01:07:09] ^d: Who /does/ have access, then? [01:07:12] (03PS3) 10Matthias Mullie: Remove Flow's mw-ui-button overrides [extensions/Flow] - 10https://gerrit.wikimedia.org/r/113066 [01:07:19] <^d> James_F: opsen. [01:07:32] ^d: Just them? Helpful. [01:07:32] <^d> Mainly, prod a labs person like Coren or Andrew [01:07:37] <^d> Yeah :( [01:07:39] Kk, will do. [01:07:48] (Also, boo.) [01:08:16] <^d> James_F: This is why I said "PLZ PLZ NOT LIKE WIKITECHWIKI" when this came up on the ops list re: zero. [01:10:03] omg, sinon is the worst piece of crap I've ever seen ever I can't believe omg, wtf! [01:10:58] The code is horribly broken, how can that lib be so popular with so many fundamental flaws, completely dead code, and so many features in it that don't even work and clearly haven't been tested or used by anyone [01:11:13] using fake timers gives you a broken Date instance with no methods other than an undefined property toUTCString [01:11:20] no getTime() or anything [01:11:24] <^d> s/sinon/mediawiki/ [01:11:29] <^d> "The code is horribly broken, how can that lib be so popular with so many fundamental flaws, completely dead code, and so many features in it that don't even work and clearly haven't been tested or used by anyone" [01:11:30] <^d> ;-) [01:11:48] (03PS1) 10Kaldari: Removing negative margin for headers since it breaks Chrome :( [extensions/VectorBeta] - 10https://gerrit.wikimedia.org/r/117134 [01:13:48] ^d: Ah, KO. [01:14:04] ^d: Be nice. :-) [01:14:41] <^d> Why should I be nice? You wouldn't let me upgrade Gerrit. [01:14:47] <^d> So now I'm bored and lashing out ;-) [01:18:56] (03PS1) 10Jforrester: Update OOjs UI to v0.1.0-pre (e1b23620c0) [core] - 10https://gerrit.wikimedia.org/r/117137 [01:19:05] ^d: :-P [01:19:41] (03PS1) 10JGonera: [WIP] Add click tracking to compact personal bar [extensions/VectorBeta] - 10https://gerrit.wikimedia.org/r/117138 [01:19:54] (03CR) 10jenkins-bot: [V: 04-1] [WIP] Add click tracking to compact personal bar [extensions/VectorBeta] - 10https://gerrit.wikimedia.org/r/117138 (owner: 10JGonera) [01:21:35] (03PS2) 10JGonera: [WIP] Add click tracking to compact personal bar [extensions/VectorBeta] - 10https://gerrit.wikimedia.org/r/117138 [01:21:39] (03CR) 10jenkins-bot: [V: 04-1] [WIP] Add click tracking to compact personal bar [extensions/VectorBeta] - 10https://gerrit.wikimedia.org/r/117138 (owner: 10JGonera) [01:26:12] (03CR) 10BryanDavis: Convert scap to cil.Application class (031 comment) [tools/scap] - 10https://gerrit.wikimedia.org/r/116694 (owner: 10BryanDavis) [01:26:35] (03CR) 10Catrope: [C: 032] Update OOjs UI to v0.1.0-pre (e1b23620c0) [core] - 10https://gerrit.wikimedia.org/r/117137 (owner: 10Jforrester) [01:30:17] (03Merged) 10jenkins-bot: Update OOjs UI to v0.1.0-pre (e1b23620c0) [core] - 10https://gerrit.wikimedia.org/r/117137 (owner: 10Jforrester) [01:38:09] (03CR) 10Bsitu: [SCHEMA CHANGE] Add index on revision user data (031 comment) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/116115 (owner: 10Matthias Mullie) [01:41:22] (03CR) 10Physikerwelt: "mediawiki: is included in the interwiki table by default. I don't see a reason why (many) peoply should delete it." [extensions/Math] - 10https://gerrit.wikimedia.org/r/112353 (owner: 10Physikerwelt) [01:43:01] (03CR) 10Jdlrobson: [C: 032 V: 032] Removing negative margin for headers since it breaks Chrome :( [extensions/VectorBeta] - 10https://gerrit.wikimedia.org/r/117134 (owner: 10Kaldari) [01:46:03] (03PS4) 10Bsitu: [WIP]flow_revision - add new column rev_type_id [extensions/Flow] - 10https://gerrit.wikimedia.org/r/116861 [01:51:23] (03PS4) 10Bsitu: Update flow_revision.rev_type_id [extensions/Flow] - 10https://gerrit.wikimedia.org/r/116874 [02:10:14] (03PS4) 10Bsitu: Have post/header revisions reference rev_type/rev_type_id [extensions/Flow] - 10https://gerrit.wikimedia.org/r/117099 [02:10:32] (03CR) 10Krinkle: "@Jdlrobson: Please don't bypass the gate without trying." [extensions/VectorBeta] - 10https://gerrit.wikimedia.org/r/117134 (owner: 10Kaldari) [02:15:47] (03PS1) 10Krinkle: Restrict Verified/Submit to JenkinsBot and l10n-bot [extensions/VectorBeta] (refs/meta/config) - 10https://gerrit.wikimedia.org/r/117146 [02:15:49] (03CR) 10jenkins-bot: [V: 04-1] Restrict Verified/Submit to JenkinsBot and l10n-bot [extensions/VectorBeta] (refs/meta/config) - 10https://gerrit.wikimedia.org/r/117146 (owner: 10Krinkle) [02:15:58] (03CR) 10Krinkle: [C: 032 V: 032] Restrict Verified/Submit to JenkinsBot and l10n-bot [extensions/VectorBeta] (refs/meta/config) - 10https://gerrit.wikimedia.org/r/117146 (owner: 10Krinkle) [02:16:35] (03PS4) 10Bsitu: Drop table flow_header_revision [extensions/Flow] - 10https://gerrit.wikimedia.org/r/117115 [02:35:24] (03PS1) 10Krinkle: qunit: Disable sinonjs-ie as it breaks the clock sandbox [core] - 10https://gerrit.wikimedia.org/r/117149 [02:35:26] (03PS1) 10Krinkle: jquery.color.test: Use fake timers [core] - 10https://gerrit.wikimedia.org/r/117150 [02:35:59] (03CR) 10Krinkle: Fix jQuery compatibility issues in jquery.color.js (031 comment) [core] - 10https://gerrit.wikimedia.org/r/115835 (owner: 10Gergő Tisza) [02:38:47] (03CR) 10Jforrester: [C: 032 V: 032] Syncronize VisualEditor: 07422e3..37f4996 [extensions] - 10https://gerrit.wikimedia.org/r/117147 (owner: 10Jenkins-mwext-sync) [02:39:16] (03Abandoned) 10Jforrester: Syncronize VisualEditor: 07422e3..37f4996 [extensions] - 10https://gerrit.wikimedia.org/r/117147 (owner: 10Jenkins-mwext-sync) [02:39:36] (03Abandoned) 10Jforrester: Syncronize VisualEditor: 99fb026..809a167 [extensions] - 10https://gerrit.wikimedia.org/r/117103 (owner: 10Jenkins-mwext-sync) [02:39:40] (03Abandoned) 10Jforrester: Syncronize VisualEditor: 7efd0b6..19f7afb [extensions] - 10https://gerrit.wikimedia.org/r/117112 (owner: 10Jenkins-mwext-sync) [02:39:44] (03Abandoned) 10Jforrester: Syncronize VisualEditor: 6d87cd6..e0f37e0 [extensions] - 10https://gerrit.wikimedia.org/r/117125 (owner: 10Jenkins-mwext-sync) [02:39:48] (03Abandoned) 10Jforrester: Syncronize VisualEditor: 27cda86..2a08584 [extensions] - 10https://gerrit.wikimedia.org/r/117133 (owner: 10Jenkins-mwext-sync) [02:39:52] (03Abandoned) 10Jforrester: Syncronize VisualEditor: 7201311..4ad33a6 [extensions] - 10https://gerrit.wikimedia.org/r/117142 (owner: 10Jenkins-mwext-sync) [02:39:56] (03Abandoned) 10Jforrester: Syncronize VisualEditor: 44352e6..c0380f1 [extensions] - 10https://gerrit.wikimedia.org/r/117145 (owner: 10Jenkins-mwext-sync) [02:40:05] (03CR) 10jenkins-bot: [V: 04-1] qunit: Disable sinonjs-ie as it breaks the clock sandbox [core] - 10https://gerrit.wikimedia.org/r/117149 (owner: 10Krinkle) [02:40:07] (03CR) 10jenkins-bot: [V: 04-1] jquery.color.test: Use fake timers [core] - 10https://gerrit.wikimedia.org/r/117150 (owner: 10Krinkle) [03:02:25] (03PS1) 10Krinkle: jquery.makeCollapsible.test: Minor clean up [core] - 10https://gerrit.wikimedia.org/r/117152 [03:02:27] (03PS1) 10Krinkle: jquery.makeCollapsible.test: Use fake timers to advance animations [core] - 10https://gerrit.wikimedia.org/r/117153 [03:03:19] (03PS1) 10BryanDavis: Delete stub l10n file after generating ExtensionMessages [tools/scap] - 10https://gerrit.wikimedia.org/r/117154 [03:07:06] (03CR) 10jenkins-bot: [V: 04-1] jquery.makeCollapsible.test: Minor clean up [core] - 10https://gerrit.wikimedia.org/r/117152 (owner: 10Krinkle) [03:07:08] (03CR) 10jenkins-bot: [V: 04-1] jquery.makeCollapsible.test: Use fake timers to advance animations [core] - 10https://gerrit.wikimedia.org/r/117153 (owner: 10Krinkle) [03:09:00] (03CR) 10BryanDavis: "It would be really really nice if this could be merged before the 1.23wmf17 branch is deployed tomorrow. Last week and the week before we " [tools/scap] - 10https://gerrit.wikimedia.org/r/117154 (owner: 10BryanDavis) [03:10:06] (03CR) 10Krinkle: "Looks like phantomjs is lacking ProgressEvent support and for some reason it was working because it was covered by "IE" fixes." [core] - 10https://gerrit.wikimedia.org/r/117149 (owner: 10Krinkle) [03:15:27] (03PS1) 10Krinkle: Update SinonJS to v1.9.0 [core] - 10https://gerrit.wikimedia.org/r/117156 [03:15:33] (03PS16) 10Mattflaschen: [WIP] Add mw-ui-button classes to various buttons [core] - 10https://gerrit.wikimedia.org/r/52169 [03:16:12] (03PS2) 10Krinkle: jquery.makeCollapsible.test: Minor clean up [core] - 10https://gerrit.wikimedia.org/r/117152 [03:16:14] (03PS2) 10Krinkle: jquery.makeCollapsible.test: Use fake timers to advance animations [core] - 10https://gerrit.wikimedia.org/r/117153 [03:16:16] (03PS2) 10Krinkle: jquery.color.test: Use fake timers [core] - 10https://gerrit.wikimedia.org/r/117150 [03:16:18] (03PS2) 10Krinkle: qunit: Disable sinonjs-ie as it breaks the clock sandbox [core] - 10https://gerrit.wikimedia.org/r/117149 [03:33:30] (03CR) 10Krinkle: [C: 04-1] "Inconsistent coding style." (031 comment) [core] - 10https://gerrit.wikimedia.org/r/117039 (owner: 10Addshore) [03:33:32] (03CR) 10Subramanya Sastry: "I have not looked at the changes for this patch, but some information about how this would impact existing pages would be helpful. Probabl" [core] - 10https://gerrit.wikimedia.org/r/116995 (owner: 10Cscott) [04:01:51] (03PS1) 10Anomie: API: Fix logic for list=recentchanges prop=userid [core] - 10https://gerrit.wikimedia.org/r/117158 [04:47:42] (03CR) 10Krinkle: Add basic tests for MediaWikiTestCase (032 comments) [core] - 10https://gerrit.wikimedia.org/r/117042 (owner: 10Addshore) [04:49:28] (03CR) 10Krinkle: [C: 031] "Good looks fine, untested though." [core] - 10https://gerrit.wikimedia.org/r/105457 (owner: 10Gerrit Patch Uploader) [04:57:00] (03PS1) 10Ori.livneh: Update lessphp to b7cd5c79e8 [core] - 10https://gerrit.wikimedia.org/r/117160 [04:59:38] (03CR) 10Ori.livneh: [C: 032] Update SinonJS to v1.9.0 [core] - 10https://gerrit.wikimedia.org/r/117156 (owner: 10Krinkle) [05:00:33] (03CR) 10Mattflaschen: "I don't think we want to remove destructive with JavaScript. I think it should start with no destructive, and then it could be added if t" (031 comment) [core] - 10https://gerrit.wikimedia.org/r/116725 (owner: 10Deepali) [05:03:10] (03Merged) 10jenkins-bot: Update SinonJS to v1.9.0 [core] - 10https://gerrit.wikimedia.org/r/117156 (owner: 10Krinkle) [05:12:00] (03PS1) 10Hiong3-eng5: API 1.1 ow_syntrans initial changes [extensions/WikiLexicalData] - 10https://gerrit.wikimedia.org/r/117162 [05:16:55] ori: Should I assign https://bugzilla.wikimedia.org/61742 to you? [05:17:18] (03PS2) 10Hiong3-eng5: API 1.1 ow_syntrans initial changes [extensions/WikiLexicalData] - 10https://gerrit.wikimedia.org/r/117162 [05:18:39] prtksxna: OK. Can you make it easier for me by commenting on the bug and letting me know what to watch for? What performance implications might this extension have, and why they're acceptable? [05:19:30] ori: I think StevenW already forwarded my mail to you about load times, should I include that here [05:19:49] ori: I'll try and think of other performance implications as well and document them on the bug [05:20:17] ori: When will you have time to discuss the event logging stuff [05:21:41] Yes, could you include the note on the bug? [05:21:43] (03CR) 10Mattflaschen: [C: 04-2] "This is up for testing at http://mwui.wmflabs.org/wiki/Main_Page . I removed the HTML form stuff. I think S is planning to tackle that s" [core] - 10https://gerrit.wikimedia.org/r/52169 (owner: 10Mattflaschen) [05:22:05] ori: EventLogging or Popups? [05:22:11] popups [05:22:21] the eventlogging stuff is the clickthru implementation, right? [05:22:23] ori: Right, I'll do that [05:22:30] what is most urgent for you? [05:22:45] ori: Yes, that and finding if the click was middle/right/etc [05:22:49] (03CR) 10thibaultmarin: [C: 032] PGFTikZ extension: initial import [extensions/PGFTikZ] - 10https://gerrit.wikimedia.org/r/38487 (owner: 10thibaultmarin) [05:22:51] ori: Popups is urgent to me [05:23:03] ori: I am guessing the EL stuff isn't urgent but important to both of us [05:23:54] OK; I'll wait for your follow-up on the bug and then review [05:24:55] ori: I am not completely sure what other performance implications there might be [05:25:00] ori: Any pointer that I should look at [05:25:08] s/pointer/pointers [05:25:59] when using this feature, what additional requests are made, and under what condition? [05:26:55] ori: Got it [05:27:13] ori: I'll assign it to you only after adding the comments that you've asked for [05:28:35] prtksxna: thanks; I really appreciate it. [05:28:51] ori: :) [05:45:52] ori: All yours! [05:46:49] ori: Let me know if you want more information for anything :) [05:56:17] (03PS4) 10Prtksxna: Make EventLogging a soft dependency [extensions/Popups] - 10https://gerrit.wikimedia.org/r/115878 [05:56:19] (03PS5) 10Prtksxna: Use moment.js instead of timeAgo method [extensions/Popups] - 10https://gerrit.wikimedia.org/r/115858 [05:56:31] (03PS10) 10Prtksxna: Flip the starting point of the popup if its on the right side of the screen [extensions/Popups] - 10https://gerrit.wikimedia.org/r/115187 [05:56:33] (03PS10) 10Prtksxna: Limit image size for portrait popups [extensions/Popups] - 10https://gerrit.wikimedia.org/r/115186 [05:56:35] (03PS11) 10Prtksxna: Flip the arrow position if the popup is flipped [extensions/Popups] - 10https://gerrit.wikimedia.org/r/115188 [05:56:37] (03PS5) 10Prtksxna: Use mixin for creating pokeys with the border method [extensions/Popups] - 10https://gerrit.wikimedia.org/r/116052 [05:56:39] (03PS8) 10Prtksxna: Add border around pokey of the popup [extensions/Popups] - 10https://gerrit.wikimedia.org/r/116053 [05:56:41] (03PS2) 10Prtksxna: Stop overflowing text from hitting the border [extensions/Popups] - 10https://gerrit.wikimedia.org/r/116736 [05:56:59] There needs to be a flag to not post on IRC [06:06:48] (03PS1) 10BryanDavis: Specify git log format [tools/release] - 10https://gerrit.wikimedia.org/r/117163 [06:06:50] (03PS1) 10BryanDavis: Guard against wiki markup in commit messages [tools/release] - 10https://gerrit.wikimedia.org/r/117164 [06:06:52] (03PS1) 10BryanDavis: Use relative paths for exec and require [tools/release] - 10https://gerrit.wikimedia.org/r/117165 [06:15:02] (03CR) 10Parent5446: Added password hashing API (031 comment) [core] - 10https://gerrit.wikimedia.org/r/77645 (owner: 10Parent5446) [06:17:57] (03PS3) 10EBernhardson: Use single query for multiple revision lookups by pk [extensions/Flow] - 10https://gerrit.wikimedia.org/r/115416 [06:19:40] (03CR) 10EBernhardson: "PS3 addresses review. also added test case and simplified conditionals that trigger the special cases" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/115416 (owner: 10EBernhardson) [07:16:35] (03CR) 10Aaron Schulz: [C: 032] API: Fix logic for list=recentchanges prop=userid [core] - 10https://gerrit.wikimedia.org/r/117158 (owner: 10Anomie) [07:20:18] (03Merged) 10jenkins-bot: API: Fix logic for list=recentchanges prop=userid [core] - 10https://gerrit.wikimedia.org/r/117158 (owner: 10Anomie) [07:21:56] (03CR) 10Nemo bis: "thibaultmarin, ahem, sorry, you also need to do the Verified+2 ("publish and submit" button I think?) because there is no jenkins-bot here" [extensions/PGFTikZ] - 10https://gerrit.wikimedia.org/r/38487 (owner: 10thibaultmarin) [07:23:55] (03CR) 10Mattflaschen: [C: 032] "Looks good" [extensions/GuidedTour] - 10https://gerrit.wikimedia.org/r/116970 (owner: 10Phuedx) [07:24:26] (03Merged) 10jenkins-bot: Icon tweaks [extensions/GuidedTour] - 10https://gerrit.wikimedia.org/r/116970 (owner: 10Phuedx) [07:27:59] (03PS2) 10Andrew Bogott: Make special/SpecialNovaProxy.php region-aware. [extensions/OpenStackManager] - 10https://gerrit.wikimedia.org/r/116998 [07:43:41] (03CR) 10Mattflaschen: [C: 04-1] "Looks good, except for some small things." (035 comments) [extensions/GettingStarted] - 10https://gerrit.wikimedia.org/r/116969 (owner: 10Phuedx) [08:15:42] (03PS1) 10Physikerwelt: Fix: remove database-name from sql script [extensions/MathSearch] - 10https://gerrit.wikimedia.org/r/117167 [08:20:08] (03CR) 10Physikerwelt: [C: 032] Fix: remove database-name from sql script [extensions/MathSearch] - 10https://gerrit.wikimedia.org/r/117167 (owner: 10Physikerwelt) [08:20:13] (03Merged) 10jenkins-bot: Fix: remove database-name from sql script [extensions/MathSearch] - 10https://gerrit.wikimedia.org/r/117167 (owner: 10Physikerwelt) [08:23:24] (03CR) 10Nikerabbit: qunit: Use sinon sandbox for mediawiki.api.parse.test (031 comment) [core] - 10https://gerrit.wikimedia.org/r/117005 (owner: 10Krinkle) [08:39:28] (03PS2) 10Aaron Schulz: Replace replace() call with set() [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/115519 [08:39:35] (03CR) 10Ori.livneh: [C: 032] Replace replace() call with set() [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/115519 (owner: 10Aaron Schulz) [08:53:56] (03CR) 10Nemo bis: "I think something went very wrong in some rebase (though I didn't touch anything in mine). :) Will fix." [core] - 10https://gerrit.wikimedia.org/r/83221 (owner: 10Nemo bis) [09:11:27] (03PS3) 10Andrew Bogott: Make special/SpecialNovaProxy.php region-aware. [extensions/OpenStackManager] - 10https://gerrit.wikimedia.org/r/116998 [09:13:37] (03CR) 10Gabrielchihonglee: [C: 031] "Great suggestion! but should the button changes it color more clear?" [core] - 10https://gerrit.wikimedia.org/r/52169 (owner: 10Mattflaschen) [09:28:16] (03Abandoned) 10Johannes Weberhofer: Updated FSF address [extensions/SyntaxHighlight_GeSHi] - 10https://gerrit.wikimedia.org/r/57065 (owner: 10Johannes Weberhofer) [09:49:50] (03PS5) 10Andrew Bogott: Make special/SpecialNovaProxy.php region-aware. [extensions/OpenStackManager] - 10https://gerrit.wikimedia.org/r/116998 [10:02:58] (03PS1) 10Prtksxna: [wip] Reorganizing code [extensions/Popups] - 10https://gerrit.wikimedia.org/r/117169 [10:03:34] (03CR) 10Prtksxna: [V: 04-1] [wip] Reorganizing code [extensions/Popups] - 10https://gerrit.wikimedia.org/r/117169 (owner: 10Prtksxna) [10:21:21] (03PS3) 10Thiemo Mättig (WMDE): Added and updated Doxygen comments in content handler and diff namespaces [core] - 10https://gerrit.wikimedia.org/r/116503 [10:21:30] (03CR) 10Thiemo Mättig (WMDE): Added and updated Doxygen comments in content handler and diff namespaces (0335 comments) [core] - 10https://gerrit.wikimedia.org/r/116503 (owner: 10Thiemo Mättig (WMDE)) [10:23:55] (03CR) 10Matthias Mullie: [C: 031] "Depending on parent WIP change, but this looks good already" (031 comment) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/116874 (owner: 10Bsitu) [10:38:50] (03CR) 10Hashar: "IIRC Carl told me he was not too confortable with nodejs and regex mixed together. Yuvi you might want to take over." [labs/tools/grrrit] - 10https://gerrit.wikimedia.org/r/116996 (owner: 10AzaToth) [10:44:34] (03PS2) 10Addshore: Also stash unset globals in MediaWikiTestCase [core] - 10https://gerrit.wikimedia.org/r/117039 [10:45:06] (03CR) 10Addshore: Also stash unset globals in MediaWikiTestCase (031 comment) [core] - 10https://gerrit.wikimedia.org/r/117039 (owner: 10Addshore) [10:45:25] (03PS6) 10Addshore: Cleanup MediawikiTestCase [core] - 10https://gerrit.wikimedia.org/r/116974 [10:45:32] (03PS2) 10Addshore: Add basic tests for MediaWikiTestCase [core] - 10https://gerrit.wikimedia.org/r/117042 [10:48:16] (03CR) 10Matthias Mullie: [C: 031] "LGTM, merge after code freeze" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/115416 (owner: 10EBernhardson) [10:58:06] (03PS1) 10Mglaser: Updated to MW1.22.0 [packages/WPI] - 10https://gerrit.wikimedia.org/r/117172 [10:59:39] (03CR) 10Mglaser: [C: 032 V: 032] "Merge as this is a package already reviewed by the Microsoft team" [packages/WPI] - 10https://gerrit.wikimedia.org/r/117172 (owner: 10Mglaser) [11:15:18] (03CR) 10Hashar: [C: 032] Specify git log format [tools/release] - 10https://gerrit.wikimedia.org/r/117163 (owner: 10BryanDavis) [11:15:21] (03Merged) 10jenkins-bot: Specify git log format [tools/release] - 10https://gerrit.wikimedia.org/r/117163 (owner: 10BryanDavis) [11:16:03] (03CR) 10Hashar: [C: 032] Guard against wiki markup in commit messages [tools/release] - 10https://gerrit.wikimedia.org/r/117164 (owner: 10BryanDavis) [11:16:05] (03Merged) 10jenkins-bot: Guard against wiki markup in commit messages [tools/release] - 10https://gerrit.wikimedia.org/r/117164 (owner: 10BryanDavis) [11:17:05] (03PS2) 10Hashar: Use relative paths for exec and require [tools/release] - 10https://gerrit.wikimedia.org/r/117165 (owner: 10BryanDavis) [11:18:14] (03CR) 10Hashar: [C: 031] Use relative paths for exec and require [tools/release] - 10https://gerrit.wikimedia.org/r/117165 (owner: 10BryanDavis) [11:34:20] (03PS3) 10Phuedx: Icon tweaks [extensions/GettingStarted] - 10https://gerrit.wikimedia.org/r/116969 [11:43:27] (03CR) 10Phuedx: Icon tweaks (035 comments) [extensions/GettingStarted] - 10https://gerrit.wikimedia.org/r/116969 (owner: 10Phuedx) [11:46:37] (03CR) 10Helder.wiki: "So, should this be merged or a new patch submitted to remove the code from CodeEditor?" [core] - 10https://gerrit.wikimedia.org/r/110347 (owner: 10Helder.wiki) [11:59:24] (03PS2) 10Bartosz Dziewoński: Remove tests for jquery.delayedBind (deprecated) [core] - 10https://gerrit.wikimedia.org/r/117117 (owner: 10Krinkle) [11:59:30] (03CR) 10Bartosz Dziewoński: [C: 032] Remove tests for jquery.delayedBind (deprecated) [core] - 10https://gerrit.wikimedia.org/r/117117 (owner: 10Krinkle) [12:02:10] (03CR) 10Bartosz Dziewoński: jquery.makeCollapsible.test: Minor clean up (031 comment) [core] - 10https://gerrit.wikimedia.org/r/117152 (owner: 10Krinkle) [12:02:13] (03PS3) 10Bartosz Dziewoński: jquery.makeCollapsible.test: Minor clean up [core] - 10https://gerrit.wikimedia.org/r/117152 (owner: 10Krinkle) [12:02:44] (03PS4) 10Krinkle: jquery.makeCollapsible.test: Minor clean up [core] - 10https://gerrit.wikimedia.org/r/117152 [12:02:57] (03CR) 10Bartosz Dziewoński: "Rebased on master." [core] - 10https://gerrit.wikimedia.org/r/117152 (owner: 10Krinkle) [12:03:09] (03CR) 10Bartosz Dziewoński: [C: 032] jquery.makeCollapsible.test: Minor clean up [core] - 10https://gerrit.wikimedia.org/r/117152 (owner: 10Krinkle) [12:05:07] (03Merged) 10jenkins-bot: Remove tests for jquery.delayedBind (deprecated) [core] - 10https://gerrit.wikimedia.org/r/117117 (owner: 10Krinkle) [12:06:32] (03CR) 10Bartosz Dziewoński: qunit: Use sinon sandbox for mediawiki.api.parse.test (031 comment) [core] - 10https://gerrit.wikimedia.org/r/117005 (owner: 10Krinkle) [12:08:05] (03Merged) 10jenkins-bot: jquery.makeCollapsible.test: Minor clean up [core] - 10https://gerrit.wikimedia.org/r/117152 (owner: 10Krinkle) [12:08:08] (03CR) 10Bartosz Dziewoński: [C: 031] "Still needs rebasing though :)" [core] - 10https://gerrit.wikimedia.org/r/110162 (owner: 10TTO) [12:11:58] (03CR) 10Bartosz Dziewoński: Rename RedirectSpecialPage subclasses (032 comments) [core] - 10https://gerrit.wikimedia.org/r/106888 (owner: 10Bartosz Dziewoński) [12:13:16] (03PS7) 10Bartosz Dziewoński: Rename RedirectSpecialPage subclasses [core] - 10https://gerrit.wikimedia.org/r/106888 [12:13:56] (03PS8) 10Bartosz Dziewoński: Rename RedirectSpecialPage subclasses [core] - 10https://gerrit.wikimedia.org/r/106888 [12:14:27] (03CR) 10Bartosz Dziewoński: "Rebased, addressed comments." [core] - 10https://gerrit.wikimedia.org/r/106888 (owner: 10Bartosz Dziewoński) [12:16:02] (03CR) 10Bartosz Dziewoński: [C: 031] mediawiki.api: Use Promise.then instead of manual Deferred wrapping (031 comment) [core] - 10https://gerrit.wikimedia.org/r/116957 (owner: 10Krinkle) [12:39:07] (03PS1) 10Phuedx: Focus the primary button when the CTA is shown [extensions/GettingStarted] - 10https://gerrit.wikimedia.org/r/117174 [12:39:24] (03PS1) 10Hoo man: Use Wikidata 1.23wmf17 branch [tools/release] - 10https://gerrit.wikimedia.org/r/117175 [12:39:27] Reedy: ^ [12:40:00] (03CR) 10Matthias Mullie: Allow extension of post interaction links (032 comments) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/115552 (owner: 10Wctaiwan) [12:48:11] (03PS1) 10Nikerabbit: File readers [extensions/LocalisationUpdate] (json-rewrite) - 10https://gerrit.wikimedia.org/r/117177 [12:55:13] \quit [12:58:22] (03CR) 10Helder.wiki: "FYI: while testing this again, I found bug 62318 and bug 62319. Both happens with and without applying this patch. In the second one, when" [core] - 10https://gerrit.wikimedia.org/r/114959 (owner: 10Bartosz Dziewoński) [13:05:57] (03PS1) 10Aude: update wikidata branch [tools/release] - 10https://gerrit.wikimedia.org/r/117178 [13:06:17] aude: :P [13:06:46] https://gerrit.wikimedia.org/r/117175 [13:08:02] (03PS2) 10Nikerabbit: File readers [extensions/LocalisationUpdate] (json-rewrite) - 10https://gerrit.wikimedia.org/r/117177 [13:08:44] (03CR) 10Phuedx: Icon tweaks (031 comment) [extensions/GettingStarted] - 10https://gerrit.wikimedia.org/r/116969 (owner: 10Phuedx) [13:09:57] hoo: ? [13:10:07] aude: Already did that 25 minutes agi [13:10:09] * ago [13:10:11] aw [13:10:27] (03Abandoned) 10Aude: update wikidata branch [tools/release] - 10https://gerrit.wikimedia.org/r/117178 (owner: 10Aude) [13:10:34] tried to ping you about it, but you probably went to eat or so [13:15:21] (03CR) 10Daniel Kinzler: [C: 032] "thanks for fixing my messy comments!" [core] - 10https://gerrit.wikimedia.org/r/116503 (owner: 10Thiemo Mättig (WMDE)) [13:17:35] (03PS3) 10Addshore: Add basic tests for MediaWikiTestCase [core] - 10https://gerrit.wikimedia.org/r/117042 [13:19:20] (03Merged) 10jenkins-bot: Added and updated Doxygen comments in content handler and diff namespaces [core] - 10https://gerrit.wikimedia.org/r/116503 (owner: 10Thiemo Mättig (WMDE)) [13:20:19] (03CR) 10Daniel Kinzler: [C: 032] Cleanup MediawikiTestCase [core] - 10https://gerrit.wikimedia.org/r/116974 (owner: 10Addshore) [13:25:18] (03CR) 10thibaultmarin: [V: 032] PGFTikZ extension: initial import [extensions/PGFTikZ] - 10https://gerrit.wikimedia.org/r/38487 (owner: 10thibaultmarin) [13:27:09] (03CR) 10Daniel Kinzler: [C: 04-2] "MediaWiki should not use any uninitializes globals anywhere, ever. They are a major security risk. I suggest to throw an exception here in" (031 comment) [core] - 10https://gerrit.wikimedia.org/r/117039 (owner: 10Addshore) [13:31:24] (03CR) 10Swalling: [C: 04-1] "The tab index setting works, but if you try to hit enter/return it does not select the button and start the tour. (Probably because it's d" [extensions/GettingStarted] - 10https://gerrit.wikimedia.org/r/117174 (owner: 10Phuedx) [13:32:50] (03PS3) 10Addshore: Throw exception when trying to stash unset globals [core] - 10https://gerrit.wikimedia.org/r/117039 [13:33:30] (03PS4) 10Addshore: Throw exception when trying to stash unset globals [core] - 10https://gerrit.wikimedia.org/r/117039 [13:35:37] (03CR) 10Daniel Kinzler: Add basic tests for MediaWikiTestCase (033 comments) [core] - 10https://gerrit.wikimedia.org/r/117042 (owner: 10Addshore) [13:36:19] (03CR) 10Daniel Kinzler: "I like it, but see comments on PS2." [core] - 10https://gerrit.wikimedia.org/r/117042 (owner: 10Addshore) [13:37:17] (03CR) 10Addshore: Add basic tests for MediaWikiTestCase (033 comments) [core] - 10https://gerrit.wikimedia.org/r/117042 (owner: 10Addshore) [13:44:21] anomie: good morning Brad. How was the hhvm kick of yesterday? I have missed the calendar invite for some reason :-( [13:45:48] hashar: It was ok, mainly planning on what the current goal would be and who would do what. Unfortunately I don't remember the details. [13:46:51] (03CR) 10Hashar: [C: 032] "Not sure why I havent approved that one previously. Good to go!" [tools/release] - 10https://gerrit.wikimedia.org/r/117165 (owner: 10BryanDavis) [13:46:53] (03Merged) 10jenkins-bot: Use relative paths for exec and require [tools/release] - 10https://gerrit.wikimedia.org/r/117165 (owner: 10BryanDavis) [13:47:15] anomie: I have read the ether pad, seems there is nothing to worry about as far as I am concerned :] [13:49:47] (03CR) 10Hashar: [C: 031] "Is this pending Ori review? I like the cli wrapper." [tools/scap] - 10https://gerrit.wikimedia.org/r/116456 (owner: 10BryanDavis) [13:53:44] (03CR) 10Hashar: [C: 032] "I also wanted the API doc to be generated but could not find a way to have it happen automatically. Since one has to automodule each modu" [tools/scap] - 10https://gerrit.wikimedia.org/r/116457 (owner: 10BryanDavis) [14:09:03] (03CR) 10Daniel Kinzler: [C: 032] Add visibility to DifferenceEngine methods [core] - 10https://gerrit.wikimedia.org/r/115347 (owner: 10Aude) [14:09:32] (03PS7) 10Addshore: Cleanup MediawikiTestCase [core] - 10https://gerrit.wikimedia.org/r/116974 [14:09:43] (03CR) 10jenkins-bot: [V: 04-1] Add visibility to DifferenceEngine methods [core] - 10https://gerrit.wikimedia.org/r/115347 (owner: 10Aude) [14:10:06] rebase? [14:10:30] (03PS4) 10Addshore: Add basic tests for MediaWikiTestCase [core] - 10https://gerrit.wikimedia.org/r/117042 [14:11:39] (03CR) 10Bartosz Dziewoński: "Loading from URL still doesn't work. /me debugs" [extensions/ApiSandbox] - 10https://gerrit.wikimedia.org/r/112307 (owner: 10Alex Monk) [14:12:45] (03PS2) 10Aude: Add visibility to DifferenceEngine methods [core] - 10https://gerrit.wikimedia.org/r/115347 [14:13:40] (03CR) 10jenkins-bot: [V: 04-1] Add visibility to DifferenceEngine methods [core] - 10https://gerrit.wikimedia.org/r/115347 (owner: 10Aude) [14:14:13] (03CR) 10Daniel Kinzler: [C: 032] Add test to validate special page aliases (031 comment) [core] - 10https://gerrit.wikimedia.org/r/97118 (owner: 10Aude) [14:18:17] (03Merged) 10jenkins-bot: Add test to validate special page aliases [core] - 10https://gerrit.wikimedia.org/r/97118 (owner: 10Aude) [14:22:12] merge all the stuff [14:22:43] the special page thing... i'd like jenkins to run in a different job ideally [14:24:24] (03CR) 10Aude: Add test to validate special page aliases (031 comment) [core] - 10https://gerrit.wikimedia.org/r/97118 (owner: 10Aude) [14:25:50] (03CR) 10Bartosz Dziewoński: [C: 04-1] "Debugged. :)" (031 comment) [extensions/ApiSandbox] - 10https://gerrit.wikimedia.org/r/112307 (owner: 10Alex Monk) [14:27:39] (03PS3) 10Nikerabbit: File readers [extensions/LocalisationUpdate] (json-rewrite) - 10https://gerrit.wikimedia.org/r/117177 [14:27:41] (03PS1) 10Nikerabbit: I18n file finder [extensions/LocalisationUpdate] (json-rewrite) - 10https://gerrit.wikimedia.org/r/117181 [14:28:57] (03PS3) 10Krinkle: qunit: Disable sinonjs-ie as it breaks the clock sandbox [core] - 10https://gerrit.wikimedia.org/r/117149 [14:29:04] (03PS3) 10Krinkle: jquery.color.test: Use fake timers [core] - 10https://gerrit.wikimedia.org/r/117150 [14:29:43] (03PS3) 10Krinkle: jquery.makeCollapsible.test: Use fake timers to advance animations [core] - 10https://gerrit.wikimedia.org/r/117153 [14:30:05] (03CR) 10Krinkle: "Rebased to resolve merge conflict when the stack order got changed in MatmaRex's rebase." [core] - 10https://gerrit.wikimedia.org/r/117153 (owner: 10Krinkle) [14:35:21] (03PS3) 10Aude: Add visibility to DifferenceEngine methods [core] - 10https://gerrit.wikimedia.org/r/115347 [14:40:22] (03PS1) 10Hashar: mw-run-phpunit-hhvm: mw tests with HHVM! [integration/jenkins] - 10https://gerrit.wikimedia.org/r/117185 [14:40:39] (03CR) 10Hashar: [C: 032] mw-run-phpunit-hhvm: mw tests with HHVM! [integration/jenkins] - 10https://gerrit.wikimedia.org/r/117185 (owner: 10Hashar) [14:40:43] (03Merged) 10jenkins-bot: mw-run-phpunit-hhvm: mw tests with HHVM! [integration/jenkins] - 10https://gerrit.wikimedia.org/r/117185 (owner: 10Hashar) [14:42:32] (03PS10) 10Krinkle: mediawiki.api: Refactor getToken and postWithToken methods [core] - 10https://gerrit.wikimedia.org/r/111636 [14:42:51] (03CR) 10Krinkle: "Rebased to resolve conflict with ef51e96190b03a92c." [core] - 10https://gerrit.wikimedia.org/r/111636 (owner: 10Krinkle) [14:44:49] hashar: Is hhvm for the labs slaves puppetised? [14:45:51] addshore: Hm.. 5.3 is failing on travis now? [14:46:09] it was always failing, its a slightly random one ;p [14:46:19] ""expected more than 1 checkpoint to have been created. Checkpoint interval is 0.5 seconds, maybe your computer is too fast?"" [14:48:19] (03PS1) 10Hashar: MediaWiki phpunit under HHVM! [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/117187 [14:48:27] (03PS2) 10Nikerabbit: I18n file finder [extensions/LocalisationUpdate] (json-rewrite) - 10https://gerrit.wikimedia.org/r/117181 [14:50:18] (03PS1) 10Anomie: API: Handle exceptions from ApiBeforeMain hook in a user-friendly manner [core] - 10https://gerrit.wikimedia.org/r/117189 [14:53:34] (03CR) 10Krinkle: "I'd rather the unit tests for these methods are introduced in same commit." [core] - 10https://gerrit.wikimedia.org/r/117036 (owner: 10Addshore) [14:54:11] (03PS4) 10Deepali: Add appropriate mw-ui button styles to Save, Preview, Show changes and cancel buttons. [core] - 10https://gerrit.wikimedia.org/r/116725 [14:54:18] (03CR) 10Addshore: "I will take a poke and amend the previous commits." [core] - 10https://gerrit.wikimedia.org/r/117036 (owner: 10Addshore) [15:08:51] (03PS1) 10Krinkle: jsduck: Clean up odd use of @returns instead of @return [core] - 10https://gerrit.wikimedia.org/r/117198 [15:10:30] (03CR) 10Addshore: [C: 032] Add visibility to DifferenceEngine methods [core] - 10https://gerrit.wikimedia.org/r/115347 (owner: 10Aude) [15:14:14] (03Merged) 10jenkins-bot: Add visibility to DifferenceEngine methods [core] - 10https://gerrit.wikimedia.org/r/115347 (owner: 10Aude) [15:15:21] (03PS2) 10Hoo man: Use Wikidata 1.23wmf17 branch [tools/release] - 10https://gerrit.wikimedia.org/r/117175 [15:15:23] (03PS2) 10Hashar: MediaWiki phpunit under HHVM! [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/117187 [15:15:34] (03CR) 10BryanDavis: [C: 032] Use Wikidata 1.23wmf17 branch [tools/release] - 10https://gerrit.wikimedia.org/r/117175 (owner: 10Hoo man) [15:15:36] (03Merged) 10jenkins-bot: Use Wikidata 1.23wmf17 branch [tools/release] - 10https://gerrit.wikimedia.org/r/117175 (owner: 10Hoo man) [15:22:17] (03PS3) 10Hashar: MediaWiki phpunit under HHVM! [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/117187 [15:23:44] (03PS4) 10Hashar: MediaWiki phpunit under HHVM! [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/117187 [15:26:45] anomie: I think I got some hhvm tests at https://integration.wikimedia.org/ci/job/mediawiki-core-phpunit-hhvm/2/console :D [15:27:05] gotta use hhvm to install / update mediawiki though [15:27:33] hashar: Looks like it's running hhvm there to me too. Nice! [15:27:44] ooh, crash. [15:27:52] <^d> hashar: I saw your e-mail re: building packages for hhvm. I volunteered for that yesterday. [15:27:58] <^d> Want to pair up tomorrow? [15:28:42] <^d> s/packages/binaries/ [15:28:43] <^d> :) [15:29:31] Segmentation fault hhvm --php phpunit.php [15:29:33] :-((((((((( [15:30:14] ^d: if we have a repo with a /debian/ directory and it matches git-buildpackage convention, we can just add a debian-glue job in Jenkins [15:30:19] that is like 3 lines to add and a job to be created [15:30:25] then adding the relevant trigger in Zuul [15:30:56] ^d: so yeah we can pair up :] [15:31:30] <^d> hashar: Well I think we're going for the path of least resistance for now--not using debs since upstream has those and is trying to improve them. [15:31:45] <^d> For now, building binaries and moving them around to the $testingPlaces was deemed ok. [15:33:47] soounds good [15:33:56] so one would send a patchset, a job compile / run some tests [15:34:05] <^d> Something like that. [15:34:16] then we can +2 and once merged we would compile and copy/git-deploy/whatever to the boxes ? [15:34:31] though on the Jenkins slaves I am using the hhvm packages [15:34:36] the hhvm debian package [15:34:43] ori got them uploaded a couple days ago [15:34:47] <^d> That's probably fine for that. [15:35:11] <^d> Anyway, I'll think on it a bit today and we'll pair up tomorrow morning my time. [15:36:16] ^d: feel free to spam me with emails during your day [15:36:25] ^d: also might want to get Gerrit upgraded :-] [15:47:00] (03PS5) 10Hashar: MediaWiki phpunit under HHVM! [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/117187 [15:49:03] (03CR) 10BryanDavis: [C: 032] "Self-merge to ensure that puppet has time to pull the change to tin before I need it for the 1.23wmf17 deploy today." [tools/scap] - 10https://gerrit.wikimedia.org/r/117154 (owner: 10BryanDavis) [15:49:08] <^d> hashar: I wanted to yesterday. I responded to your e-mail. [15:49:45] (03Merged) 10jenkins-bot: Delete stub l10n file after generating ExtensionMessages [tools/scap] - 10https://gerrit.wikimedia.org/r/117154 (owner: 10BryanDavis) [15:50:24] (03CR) 10Hashar: [C: 032] "This change to jenkins creates the mediawiki-core-phpunit-hhvm job which runs the phpunit test suite using hhvm as provided by the debian " [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/117187 (owner: 10Hashar) [15:50:47] (03Merged) 10jenkins-bot: MediaWiki phpunit under HHVM! [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/117187 (owner: 10Hashar) [15:52:04] (03PS13) 10Phuedx: Updates to jsduck setup and comments [extensions/GuidedTour] - 10https://gerrit.wikimedia.org/r/86057 (owner: 10Mattflaschen) [15:53:28] (03PS1) 10Hashar: Trigger mediawiki-core-phpunit-hhvm [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/117205 [15:53:43] (03CR) 10Hashar: "Zuul triggers in https://gerrit.wikimedia.org/r/117205" [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/117187 (owner: 10Hashar) [15:54:44] (03CR) 10Phuedx: "I updated the docblock for mediaWiki.libs.guiders.skipThenUpdateDisplay so that jsduck parsed it correctly." [extensions/GuidedTour] - 10https://gerrit.wikimedia.org/r/86057 (owner: 10Mattflaschen) [15:55:57] ^d: (re Gerrit up) yeah scheduling the deployment sounds reasonable :-] Anytime next week since I guess you probably dont want to upgrade Gerrit on friday. [15:56:09] <^d> Meh I might. [15:56:10] <^d> :) [15:56:55] (03CR) 10Hashar: [C: 032] Trigger mediawiki-core-phpunit-hhvm [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/117205 (owner: 10Hashar) [15:56:59] (03Merged) 10jenkins-bot: Trigger mediawiki-core-phpunit-hhvm [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/117205 (owner: 10Hashar) [15:57:57] anomie: ^d and the hhvm job is now being triggered on patch submission. Posting announce to wikitech [15:58:29] (03Restored) 10Hashar: Jenkins job validation (DO NOT SUBMIT) [core] - 10https://gerrit.wikimedia.org/r/92621 (owner: 10Hashar) [15:58:33] (03PS4) 10Hashar: Jenkins job validation (DO NOT SUBMIT) [core] - 10https://gerrit.wikimedia.org/r/92621 [16:09:43] (03Abandoned) 10Hashar: Jenkins job validation (DO NOT SUBMIT) [core] - 10https://gerrit.wikimedia.org/r/92621 (owner: 10Hashar) [16:14:43] (03PS1) 10Hashar: Restrict mediawiki-core-phpunit-hhvm to master branch [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/117208 [16:16:08] (03CR) 10Hashar: [C: 032] Restrict mediawiki-core-phpunit-hhvm to master branch [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/117208 (owner: 10Hashar) [16:16:14] (03Merged) 10jenkins-bot: Restrict mediawiki-core-phpunit-hhvm to master branch [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/117208 (owner: 10Hashar) [16:20:37] <^d> hashar: Not bad. Only failing is a djvu :) [16:20:43] <^d> Other than the bunch of expected skips. [16:21:58] <^d> hashar: I wonder if we can mark some as a cdbSkip group that automatically gets excluded. [16:22:09] <^d> s/cdbSkip/hhvmSkip/ [16:22:17] <^d> Some of them like cdb are always going to skip, but that's ok. [16:23:31] ^d: well they are skip so we are safe :] [16:23:46] ^d: potentially we could @group nohhvm [16:23:53] and filter out test in that nohhvm group [16:23:59] something like phpunit --exclude nohhvm [16:24:06] <^d> Yeah that's what I was thinking [16:25:48] (03PS2) 10Phuedx: Focus the primary button when the CTA is shown [extensions/GettingStarted] - 10https://gerrit.wikimedia.org/r/117174 [16:31:59] <^d> hashar: So can any of the slaves actually build hhvm? Do we have the 2 dozen or so dependencies? Are we on 12.04 or hopefully something newer? [16:32:10] (03CR) 10Manybubbles: [C: 031] "Thanks!" [core] - 10https://gerrit.wikimedia.org/r/117189 (owner: 10Anomie) [16:32:24] ^d: there is two slaves instances in the labs project 'integration' [16:32:37] ^d: they are Precise 12.04 with the hhvm packages from apt.wikimedia.org [16:32:44] is gerrit (through git, not the web interface) being terribly slow for anyone else? [16:32:49] ^d: the hhvm is not installed automatically (puppet has ensure => present ) [16:33:04] <^d> Right. I'm talking about building the binary though. [16:33:10] ^d: whenever we have some ops to build us a 14.04 image for labs, we can have such a slave added [16:33:15] ah for the binary [16:33:19] so yeah nothing yet [16:33:25] 12.04 for now [16:33:43] <^d> Hmm, I'm not in the integration project. [16:33:47] andrew and coren are busy migrating to eqiad so I dont think we will get a 14.04 Ubuntu instance anytime soon [16:33:49] <^d> I might've removed myself :p [16:33:58] that is convenient :] [16:34:14] they are maintained via puppet anyway [16:35:08] (03CR) 10Phuedx: [C: 04-2] "PS2 is an intermediate commit. Ignore it." [extensions/GettingStarted] - 10https://gerrit.wikimedia.org/r/117174 (owner: 10Phuedx) [16:35:20] ^d: added you [16:35:26] <^d> Got it, thanks. [16:36:20] ^d: with root access [16:36:36] and as usual nothing is documented (bug: 1) [16:36:49] <^d> Don't worry, I won't be documenting my work either! [16:36:50] <^d> :) [16:36:51] though the instances are in puppet [16:36:52] (03CR) 10Swalling: [C: 031] "Patchset 2 LGTM. Tested locally. :)" [extensions/GettingStarted] - 10https://gerrit.wikimedia.org/r/117174 (owner: 10Phuedx) [16:37:14] if you can trick someone from ops to add a 14.04 instance in labs that would be very helpful [16:37:34] would need some puppet work though probably but I think Faidon already played with that a couple weeks ago [16:38:00] * hashar reporting time [16:40:04] (03CR) 10Chad: [C: 031] API: Handle exceptions from ApiBeforeMain hook in a user-friendly manner [core] - 10https://gerrit.wikimedia.org/r/117189 (owner: 10Anomie) [16:41:30] * bd808|deploy is cutting 1.23wmf17 branch [16:45:00] StevenW: that was my first accidental `git review` – achievement unlocked? [16:55:09] (03CR) 10Manybubbles: "Looks good to me. I can +2 if you've tested it." [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/116896 (owner: 10Chad) [16:56:33] (03PS2) 10Zfilipin: Cloudbees Jenkins jobs are now created using Jenkins Job Builder [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/114934 [16:57:01] (03CR) 10Cmcmahon: [C: 032] Cloudbees Jenkins jobs are now created using Jenkins Job Builder [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/114934 (owner: 10Zfilipin) [16:57:42] (03CR) 10Daniel Kinzler: [C: 04-1] "documentation is wrong, please fix" (031 comment) [core] - 10https://gerrit.wikimedia.org/r/101895 (owner: 10Aude) [16:59:36] (03CR) 10jenkins-bot: [V: 04-1] Cloudbees Jenkins jobs are now created using Jenkins Job Builder [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/114934 (owner: 10Zfilipin) [17:05:11] (03CR) 10Alex Monk: [C: 032] Give links to a user's suppressed edits on Special:Contribs [core] - 10https://gerrit.wikimedia.org/r/104711 (owner: 10Legoktm) [17:07:38] * ebernhardson sometimes wishes he could just fix typos directly in gerrit [17:11:17] ^ [17:11:21] It'd be nice [17:16:36] Something up with Jenkins? [17:16:38] well, as I said that it suddenly started a load of queued stuff [17:18:04] (03Merged) 10jenkins-bot: Give links to a user's suppressed edits on Special:Contribs [core] - 10https://gerrit.wikimedia.org/r/104711 (owner: 10Legoktm) [17:19:19] (03CR) 10Chad: [C: 031] "I have. Exported some pages, imported them on a second wiki with this patch, jobs ran, index updated." [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/116896 (owner: 10Chad) [17:20:06] (03PS1) 10EBernhardson: Enable JIT for unit tests in HHVM [integration/jenkins] - 10https://gerrit.wikimedia.org/r/117226 [17:22:38] (03CR) 10Manybubbles: [C: 032] Index pages when they're imported [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/116896 (owner: 10Chad) [17:23:26] (03Merged) 10jenkins-bot: Index pages when they're imported [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/116896 (owner: 10Chad) [17:29:14] (03CR) 10Daniel Kinzler: [V: 032] "Manually verified for Vector, MonoBook and CologneBlue." [core] - 10https://gerrit.wikimedia.org/r/101895 (owner: 10Aude) [17:29:22] (03PS3) 10Phuedx: Focus the primary button when the CTA is shown [extensions/GettingStarted] - 10https://gerrit.wikimedia.org/r/117174 [17:29:28] alright :) [17:34:34] (03PS10) 10Wctaiwan: [WIP] Add "Thanks" for comments on Flow boards [extensions/Thanks] - 10https://gerrit.wikimedia.org/r/115557 [17:38:29] (03PS1) 10Jackmcbarn: Categorize pages containing blacklisted links [extensions/SpamBlacklist] - 10https://gerrit.wikimedia.org/r/117231 [17:38:37] MatmaRex: Am I right when I check the logs that you are responsible for the terribly bad "username will be adjusted" message that is also suppressing all error messages on mobile…? :-) https://wmf.ci.cloudbees.com/job/MobileFrontend-en.m.wikipedia.beta.wmflabs.org-linux-firefox/393/testReport/junit/(root)/Create%20failure%20messages/Create_account_mistype_captcha_message/ [17:39:35] jdlrobson: depends on what you mean by 'responsible', but according to some definitions yes [17:39:50] jdlrobson: fix your browsertests not to use lowercase usernames? :) [17:40:04] (03PS12) 10Alex Monk: Allow multiple prop/list/meta params for action=query [extensions/ApiSandbox] - 10https://gerrit.wikimedia.org/r/112307 [17:40:11] MatmaRex: the browser tests do not need fixing - you broke error messages [17:40:14] they report correclty [17:40:42] jdlrobson: i'm pretty sure that core checks for everything else first before checking for this [17:41:00] jdlrobson: that part of code was technically written by umherirrender, i wrote the client-side JS part [17:41:05] MatmaRex: i don't know what to say i'm now looking into what's happened but i've confirmed this change breaks it [17:41:20] regardless of if i broke it all, the browser tests still could be amended [17:41:49] lowercase usernames are converted to uppercase-first usernames, and now we have a warning for that, so your tests also see that warning :) [17:42:37] MatmaRex: the browser tests are fine - they check an error message shows. I can't help if a user starts their username with a lower case letter which is common on browser tests [17:42:42] it's a /good/ thing it's written this way [17:42:55] i'm not sure what the issue is right now [17:43:05] MatmaRex: personally i think the warning is terrible - it means nothing to the end user - i thought there was a technical issue on beta labs [17:43:09] what you're describing looks like the expected behavior to me, i am clearly missing something [17:43:32] jdlrobson: this was discussed on the bug, on the patch, on the design list and i think on wikitech too [17:43:44] MatmaRex: This is a terrible experience on mobile, because of this slight adjustment to the first character which is not obvious the user now has to refill out a password and a captcha [17:43:47] AGAIN [17:43:54] it is meaningful for at least some users, and it's entirely client-side and seamless if you have JS enabled [17:44:06] MatmaRex: it wasn't discussed enough and looking from code review StevenW still had some concerns. [17:44:16] steven was wrong. :P [17:44:24] MatmaRex: it's probably meaningful for the people on that wikitech conversation and no one else [17:44:33] MatmaRex: what makes you think you are right? I happen to side with StevenW on this [17:44:43] I'm not the only who objects. Jared brought up the same UX concerns and Erik suggested an alternative which was ignored. [17:44:56] so why was this code merged? [17:45:22] steven enjoys blocking changes to login/signup for dubious reasons :/ [17:45:30] it was merged because it had support, clearly [17:45:37] MatmaRex: from you and Parent from the look of it [17:45:41] jdlrobson: i suggest tou read that conversation before saying that [17:45:46] anyway i need to fix this issue in preparation for a lightning deploy now but i'm really not happy with this change [17:45:47] and that too [17:45:55] and the fact it got merged on a Wednesday [17:46:00] (03CR) 10Phuedx: "Mattflaschen: I've removed the .mw-gettingstarted-cta-button-contents div, which, after testing in Chrome, Opera, IE7, and IE8 didn't seem" [extensions/GettingStarted] - 10https://gerrit.wikimedia.org/r/117174 (owner: 10Phuedx) [17:46:08] (03PS3) 10Inchikutty: UploadWizard:OSM embedding- Geocoding, reverse geocoding [extensions/UploadWizard] (osm) - 10https://gerrit.wikimedia.org/r/116130 [17:46:16] what's the problem with merging code on wednesday? [17:46:23] i'm not going to schedule my life around your deployments [17:46:31] i merge and write too many patches for that [17:47:06] jdlrobson: if you look at the patch, it received six +1s from five people [17:49:11] brb, dinner. [17:49:30] MatmaRex: jdlrobson I think no one foresaw the consequences for mobile [17:52:16] (03PS1) 10EBernhardson: Test and fix RevisionStorage partial result [extensions/Flow] - 10https://gerrit.wikimedia.org/r/117233 [17:54:59] James_F: bd808|deploy auto added to the deploy notes script for you ;) [17:55:15] Reedy: Yay. That will nicely fix __NOINDEX__ etc. calls. :-) [17:55:35] Reedy: Thanks! [17:56:12] (03CR) 10Matthias Mullie: [C: 031] "LGTM, merge after code freeze" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/117233 (owner: 10EBernhardson) [17:57:32] (03PS1) 10Jdlrobson: Revert "Warn on account creation when username is adjusted" [core] - 10https://gerrit.wikimedia.org/r/117234 [17:58:30] (03PS2) 10Nemo bis: Revert "Warn on account creation when username is adjusted" [core] - 10https://gerrit.wikimedia.org/r/117234 (owner: 10Jdlrobson) [17:59:37] (03CR) 10Swalling: [C: 032] "The patch being reverted breaks mobile account creations unacceptably." [core] - 10https://gerrit.wikimedia.org/r/117234 (owner: 10Jdlrobson) [18:01:04] (03PS1) 10BryanDavis: Remove l10n file as user l10nupdate [tools/scap] - 10https://gerrit.wikimedia.org/r/117236 [18:01:05] bd808|deploy, superm401: i propose we postpone the vagrant meeting (if we haven't already) [18:01:38] ori: Works for me [18:02:00] ori: https://gerrit.wikimedia.org/r/#/c/117236/ plz [18:02:57] (03CR) 10Cmcmahon: "also note that a mobile user does not see the warning in the page inline like a desktop user does, but instead only after completing all o" [core] - 10https://gerrit.wikimedia.org/r/117234 (owner: 10Jdlrobson) [18:03:46] (03CR) 10Ori.livneh: [C: 032] Remove l10n file as user l10nupdate [tools/scap] - 10https://gerrit.wikimedia.org/r/117236 (owner: 10BryanDavis) [18:04:11] (03Merged) 10jenkins-bot: Remove l10n file as user l10nupdate [tools/scap] - 10https://gerrit.wikimedia.org/r/117236 (owner: 10BryanDavis) [18:04:14] (03CR) 10Swalling: [C: 032] "Re-reviewing for PS2 (commit message update)" [core] - 10https://gerrit.wikimedia.org/r/117234 (owner: 10Jdlrobson) [18:04:53] (03CR) 10Daniel Kinzler: [C: 032] Throw exception when trying to stash unset globals [core] - 10https://gerrit.wikimedia.org/r/117039 (owner: 10Addshore) [18:06:14] (03CR) 10Daniel Kinzler: [C: 032] Cleanup MediawikiTestCase [core] - 10https://gerrit.wikimedia.org/r/116974 (owner: 10Addshore) [18:07:23] (03PS1) 10Matthias Mullie: [WIP] Make DatabaseUpdater work with external DBs (like used for Flow) [core] - 10https://gerrit.wikimedia.org/r/117237 [18:07:36] (03CR) 10Matthias Mullie: [C: 04-2] [WIP] Make DatabaseUpdater work with external DBs (like used for Flow) [core] - 10https://gerrit.wikimedia.org/r/117237 (owner: 10Matthias Mullie) [18:09:00] (03CR) 10Daniel Kinzler: [C: 031] Add basic tests for MediaWikiTestCase [core] - 10https://gerrit.wikimedia.org/r/117042 (owner: 10Addshore) [18:09:02] (03CR) 10Nemo bis: "Sorry for mid-air collision" [core] - 10https://gerrit.wikimedia.org/r/117234 (owner: 10Jdlrobson) [18:09:17] (03CR) 10CSteipp: [C: 031] "Haven't tested yet, but the status handling looks good, and shouldn't open up any issues. This should work." [extensions/ConfirmEdit] - 10https://gerrit.wikimedia.org/r/116170 (owner: 10Brion VIBBER) [18:09:26] whee [18:09:31] thanks csteipp [18:09:53] no problem! [18:17:42] csteipp, https://gerrit.wikimedia.org/r/#/c/111514/ needs review :/ [18:19:28] Yeah... I need to get a dev environment setup so I can test that. I think Deskana managed to do it. [18:22:04] (03CR) 10Mattflaschen: [C: 04-1] Updates to jsduck setup and comments (031 comment) [extensions/GuidedTour] - 10https://gerrit.wikimedia.org/r/86057 (owner: 10Mattflaschen) [18:24:37] back. [18:24:44] jdlrobson: ping me if you need anything [18:32:27] (03PS1) 10Alex Monk: Set body height to 100% in monobook [core] - 10https://gerrit.wikimedia.org/r/117241 [18:37:23] (03PS9) 10Aude: Add BaseTemplateAfterPortlet hook to add html after portlets [core] - 10https://gerrit.wikimedia.org/r/101895 [18:37:58] (03PS1) 10Alex Monk: Remove link to OS'd edits from Special:Contributions [extensions/Oversight] - 10https://gerrit.wikimedia.org/r/117243 [18:38:22] (03CR) 10jenkins-bot: [V: 04-1] Add BaseTemplateAfterPortlet hook to add html after portlets [core] - 10https://gerrit.wikimedia.org/r/101895 (owner: 10Aude) [18:38:34] csteipp: are you going to have a chance to test https://gerrit.wikimedia.org/r/#/c/116170/ and give it a +2 or should i poke somebody else for the final push? [18:39:16] (03PS2) 10Jforrester: Set body height to 100% in monobook [core] - 10https://gerrit.wikimedia.org/r/117241 (owner: 10Alex Monk) [18:39:34] (03CR) 10Cmcmahon: [C: 032] Revert "Warn on account creation when username is adjusted" [core] - 10https://gerrit.wikimedia.org/r/117234 (owner: 10Jdlrobson) [18:40:21] (03PS10) 10Aude: Add BaseTemplateAfterPortlet hook to add html after portlets [core] - 10https://gerrit.wikimedia.org/r/101895 [18:42:12] (03CR) 10jenkins-bot: [V: 04-1] Add BaseTemplateAfterPortlet hook to add html after portlets [core] - 10https://gerrit.wikimedia.org/r/101895 (owner: 10Aude) [18:42:34] jdlrobson: ugh [18:43:06] merge conflicts [18:45:38] jdlrobson: i really, really don't like how you think that mobile use cases trump everything, including widespread consensus among developers and designers who have discussed this before [18:45:57] (03Abandoned) 10Chad: Settings are no longer wrapped in an 'index' key [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/116870 (owner: 10Chad) [18:46:10] jdlrobson: making mobile automatically uppercase the first letter on form submit requires literally three lines of javascript code [18:46:17] (03CR) 10Swalling: [C: 031] "LGTM, tested locally. (Moiz also gives his thumbs up on a screenshot.)" [extensions/GettingStarted] - 10https://gerrit.wikimedia.org/r/116969 (owner: 10Phuedx) [18:46:45] jdlrobson: revert this on deployment branches for now, if it causes troubles for you, and fix your issue; i'm going to revert the core revert later [18:46:45] (03CR) 10Alex Monk: [C: 04-1] "something's wrong with this" [core] - 10https://gerrit.wikimedia.org/r/117241 (owner: 10Alex Monk) [18:46:51] MatmaRex, look at it from a different angle: there's a breakage. we need to fix it. nobody says that this feature should not be there in general [18:47:00] good [18:47:05] i understand [18:47:09] but don't revert this from master [18:47:11] (03CR) 10Matthias Mullie: [SCHEMA CHANGE] Add index on revision user data (031 comment) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/116115 (owner: 10Matthias Mullie) [18:47:40] i mean, what good does reverting from master accomplish? there's still breakage [18:47:44] nope. we don't revert stuff from deployment branches only [18:47:46] nothing's fixed, it just makes people angry [18:48:10] that's silly [18:48:12] that's begging for a mistake next time a deployment branch is created [18:48:20] it should be fixed by that time already [18:48:30] as i said, the fix requires literally thtee lines of code [18:48:38] sorry, this is not how things are done [18:48:39] (03PS3) 10Alex Monk: Set body height to 100% in monobook [core] - 10https://gerrit.wikimedia.org/r/117241 [18:48:45] this isn';t how things are done either [18:48:52] MatmaRex: we rely on master for an integrated test environment. that's how we find out that a change in one place causes breakage in another place. thus we revert from master a lot. MaxSem [18:49:26] we have enough hacks for various extensions in master, i'd like to remove some of them instead of adding more [18:49:41] wmf's dev teams need to set their priorities straight [18:50:47] (03Abandoned) 10Chad: Remove content index segregation [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/115210 (owner: 10Chad) [18:50:58] i particularly like how no one even commented on the reverted patch [18:51:15] and in fact went to additional lengths to avoid the automatic comment gerrit adds if you revert through its interface [18:51:19] this is really not fucking cool [18:51:33] i wouldn't even know about the revert if i didn't watch irc logs scroll by [18:51:52] or if Nemo_bis hadn't added a bug footer ;) [18:53:07] MatmaRex: IMHO, the merge came out of the blue [18:53:13] (03CR) 10Bartosz Dziewoński: "This has been silently reverted by Jon in https://gerrit.wikimedia.org/r/#/c/117234/ . I would appreciate leaving a comment here, or rever" [core] - 10https://gerrit.wikimedia.org/r/114400 (owner: 10Bartosz Dziewoński) [18:53:30] MatmaRex: I actually sent a message to the mailing list to explain why it was reverted. [18:53:35] So no it's not silent. [18:54:06] MatmaRex: I dislike how people /still/ don't test on mobile and /still/ don't care about mobile when traffic for it is growing. As MaxSem says - rewrite the patch but think about mobile this time [18:54:06] just because i read all relevant mailing lists doesn't mean everyone does. [18:54:09] the consensus on the mailing list seemed to tend towards something different, so I was a bit surprised too (then I tested it and I saw that it was more similar to what seemed to be the consensus) [18:54:17] jdlrobson: well maybe the "mobile" should be in core. [18:54:22] they we would test on it. [18:54:28] brion: I can probably do that today.. although if someone beats me to it, I won't complain :) [18:54:43] csteipp: ok thanks :D i'll keep an eye out [18:54:52] MatmaRex: yeh i'd love it in core and that's what we're working towards. Sadly I have no magic wand though. [18:54:57] any help with that most appreciated. [18:54:57] jdlrobson: i already told you, you need to fix this in mobilefrontend [18:55:02] it's a three-line patch [18:55:37] or just don't suppress core's scripting for the form [18:55:39] MatmaRex: 3 lines or not - i need to switch my focus from things like VisualEditor to do that and rush a patch. It's easier in this case to revert since the patch was an enhancement request. [18:55:57] oh, naturally it's easier to revert [18:56:01] doesn't mean you should do that [18:56:16] funny how no one agrees to revert wmf's broken stuff [18:56:24] revert VE? hell naw [18:57:03] ok this conversation appears to no longer be constructive… [18:57:35] the revert was not constructive [18:58:23] (03CR) 10Swalling: "Moiz did have one comment, which is that the lightbulb being a bit big. Let's do 42x42 instead of 48." [extensions/GettingStarted] - 10https://gerrit.wikimedia.org/r/116969 (owner: 10Phuedx) [18:58:46] jdlrobson: $(form).on('submit', function(){var $field=$(field); var val = $field.val(); val[0] = val[0].toUpperCase(); $field.val( val ); }) [18:58:48] you're welcome [18:59:10] replace 'form' and 'field' with appropriate ids, they're probably different on mobile than in core because you like doing things differently [19:00:31] (03PS4) 10Chad: Update Elastica to master (1c7c432) [extensions/Elastica] - 10https://gerrit.wikimedia.org/r/115948 (owner: 10Manybubbles) [19:00:51] (03PS3) 10Matthias Mullie: (bug 61107) Contributions from Flow appear in every namespace [extensions/Flow] - 10https://gerrit.wikimedia.org/r/115908 [19:01:23] (03CR) 10Chad: [C: 032] Update Elastica to master (1c7c432) [extensions/Elastica] - 10https://gerrit.wikimedia.org/r/115948 (owner: 10Manybubbles) [19:01:50] (03PS3) 10Matthias Mullie: [SCHEMA CHANGE] Add index on revision user data [extensions/Flow] - 10https://gerrit.wikimedia.org/r/116115 [19:01:53] (03CR) 10Chad: [V: 032] Update Elastica to master (1c7c432) [extensions/Elastica] - 10https://gerrit.wikimedia.org/r/115948 (owner: 10Manybubbles) [19:03:14] (03PS1) 10EBernhardson: New hook CheckUserInsertForRecentChange [extensions/CheckUser] - 10https://gerrit.wikimedia.org/r/117246 [19:03:49] (03CR) 10EBernhardson: "Documentation added: https://www.mediawiki.org/wiki/Manual:Hooks/CheckUserInsertForRecentChange" [extensions/CheckUser] - 10https://gerrit.wikimedia.org/r/117246 (owner: 10EBernhardson) [19:04:15] (03PS2) 10EBernhardson: New hook CheckUserInsertForRecentChange [extensions/CheckUser] - 10https://gerrit.wikimedia.org/r/117246 [19:09:30] (03PS1) 10Bartosz Dziewoński: Revert "Revert "Warn on account creation when username is adjusted"" [core] - 10https://gerrit.wikimedia.org/r/117247 [19:09:39] (03CR) 10Matthias Mullie: [C: 032] New hook CheckUserInsertForRecentChange [extensions/CheckUser] - 10https://gerrit.wikimedia.org/r/117246 (owner: 10EBernhardson) [19:09:49] (03CR) 10Bartosz Dziewoński: [C: 04-2] "Pending MF guys and gals fixing up their stuff." [core] - 10https://gerrit.wikimedia.org/r/117247 (owner: 10Bartosz Dziewoński) [19:10:17] just submitting this so that it is clear that i won't let this just be reverted and forgotten. [19:14:38] jdlrobson: what list did you send the explanation to? i don't see ny new mail related to that [19:15:29] (03CR) 10Mattflaschen: "Gabriel, I didn't understand your question. Is there a specific place where you think it might be using the wrong button class? Or are y" [core] - 10https://gerrit.wikimedia.org/r/52169 (owner: 10Mattflaschen) [19:15:58] (03CR) 10Jdlrobson: "This is not a problem with the MobileFrontend and there is nothing to fix there." [core] - 10https://gerrit.wikimedia.org/r/117247 (owner: 10Bartosz Dziewoński) [19:16:10] (03CR) 10Jdlrobson: [C: 04-1] "See above comments that need to be resolved." [core] - 10https://gerrit.wikimedia.org/r/117247 (owner: 10Bartosz Dziewoński) [19:16:33] (03PS2) 10Bartosz Dziewoński: Revert "Revert "Warn on account creation when username is adjusted"" [core] - 10https://gerrit.wikimedia.org/r/117247 [19:17:30] (03CR) 10Jdlrobson: "Just to clarify this wasn't silently reverted. See http://lists.wikimedia.org/pipermail/mobile-l/2014-March/006557.html" [core] - 10https://gerrit.wikimedia.org/r/114400 (owner: 10Bartosz Dziewoński) [19:17:33] (03CR) 10Bartosz Dziewoński: "Jon, that is the expected behavior on desktop." [core] - 10https://gerrit.wikimedia.org/r/117247 (owner: 10Bartosz Dziewoński) [19:18:43] (03CR) 10Jdlrobson: [C: 04-1] "Expected by whom? This doesn't seem like the appropriate behaviour as it has destructive frustrating consequences on poor users who try to" [core] - 10https://gerrit.wikimedia.org/r/117247 (owner: 10Bartosz Dziewoński) [19:19:56] (03CR) 10Bartosz Dziewoński: "I don't see how the mobile-l list is related to a revert of a patch to core that was discussed on the design list. This *was* silently rev" [core] - 10https://gerrit.wikimedia.org/r/114400 (owner: 10Bartosz Dziewoński) [19:22:13] (03CR) 10MaxSem: [C: 04-1] "+1 to not forcing users to resubmit if they entered something wrong. Let's not cause butthurt:)" [core] - 10https://gerrit.wikimedia.org/r/117247 (owner: 10Bartosz Dziewoński) [19:24:17] MaxSem: have you even tested the patch? no one has to resubmit anything if they have javascript enabled [19:24:19] (03PS1) 10Addshore: Add test for Message::params [core] - 10https://gerrit.wikimedia.org/r/117248 [19:24:37] MaxSem: hell, have you even read the commit message? [19:24:41] MatmaRex, I did and was talking about no JS behaviour [19:25:07] "fuck you if you don't have JS" is not nice [19:25:17] that behaviour is expected, we must not silently change the data the user has typed into the form [19:26:08] this is a very minor problem if compared to someone deciding not to register [19:26:32] in your opinion [19:28:27] (03Merged) 10jenkins-bot: New hook CheckUserInsertForRecentChange [extensions/CheckUser] - 10https://gerrit.wikimedia.org/r/117246 (owner: 10EBernhardson) [19:37:19] (03PS1) 10Addshore: Split MessageTest::testMessageParamTypes [core] - 10https://gerrit.wikimedia.org/r/117249 [19:38:32] (03CR) 10Umherirrender: [C: 031] "Still looks good to me. They should not be hassle about a silently adjust of the input on this form. On each other form the normalisation " [core] - 10https://gerrit.wikimedia.org/r/117247 (owner: 10Bartosz Dziewoński) [19:42:42] (03PS1) 10EBernhardson: Inject CheckUser data more directly [extensions/Flow] - 10https://gerrit.wikimedia.org/r/117253 [19:46:43] (03PS1) 10GeorgeBarnick: Adding config variable to toggle tracking category [extensions/AJAXPoll] - 10https://gerrit.wikimedia.org/r/117254 [20:01:07] (03CR) 10Manybubbles: [C: 031] "Since Mediawiki is GPLv2 there isn't much reason to license the plugin any other way..... I think its ok to declare the extension as GPL" [extensions/Elastica] - 10https://gerrit.wikimedia.org/r/116251 (owner: 10Reedy) [20:04:48] (03CR) 10Hoo man: [C: 032] ":)" [core] - 10https://gerrit.wikimedia.org/r/117249 (owner: 10Addshore) [20:07:37] (03CR) 10Jack Phoenix: Adding config variable to toggle tracking category (031 comment) [extensions/AJAXPoll] - 10https://gerrit.wikimedia.org/r/117254 (owner: 10GeorgeBarnick) [20:08:02] (03CR) 10Hoo man: [C: 032] Add test for Message::params [core] - 10https://gerrit.wikimedia.org/r/117248 (owner: 10Addshore) [20:10:02] (03Merged) 10jenkins-bot: Split MessageTest::testMessageParamTypes [core] - 10https://gerrit.wikimedia.org/r/117249 (owner: 10Addshore) [20:10:53] (03PS1) 10Aude: Update Wikidata build, fix uncaught exception in claim html formatting [core] (wmf/1.23wmf17) - 10https://gerrit.wikimedia.org/r/117306 [20:12:20] (03Merged) 10jenkins-bot: Add test for Message::params [core] - 10https://gerrit.wikimedia.org/r/117248 (owner: 10Addshore) [20:14:19] (03PS1) 10Umherirrender: Revert "Rollback: Make update of recentchanges table later" [core] - 10https://gerrit.wikimedia.org/r/117307 [20:14:55] (03PS2) 10GeorgeBarnick: Adding config variable to toggle tracking category [extensions/AJAXPoll] - 10https://gerrit.wikimedia.org/r/117254 [20:16:45] (03CR) 10Hoo man: [C: 032] Update Wikidata build, fix uncaught exception in claim html formatting [core] (wmf/1.23wmf17) - 10https://gerrit.wikimedia.org/r/117306 (owner: 10Aude) [20:18:33] (03CR) 10jenkins-bot: [V: 04-1] Revert "Rollback: Make update of recentchanges table later" [core] - 10https://gerrit.wikimedia.org/r/117307 (owner: 10Umherirrender) [20:21:04] (03PS1) 10Addshore: Revert "Add getMessage tests with Short and Long Contexts" [core] - 10https://gerrit.wikimedia.org/r/117308 [20:23:48] (03Merged) 10jenkins-bot: Update Wikidata build, fix uncaught exception in claim html formatting [core] (wmf/1.23wmf17) - 10https://gerrit.wikimedia.org/r/117306 (owner: 10Aude) [20:27:05] (03PS2) 10Umherirrender: Revert "Rollback: Make update of recentchanges table later" [core] - 10https://gerrit.wikimedia.org/r/117307 [20:28:41] (03CR) 10Umherirrender: "Patch Set 2: Rebased and added comment to code" [core] - 10https://gerrit.wikimedia.org/r/117307 (owner: 10Umherirrender) [20:30:32] (03CR) 10Parent5446: "I mentioned this in the mailing list, but in the future please be more respectful and allow original reviewers the time to review patches " [core] - 10https://gerrit.wikimedia.org/r/117234 (owner: 10Jdlrobson) [20:31:02] (03CR) 10Parent5446: "I'm going to go ahead and shift discussion about the necessity of this change over to Bugzilla." [core] - 10https://gerrit.wikimedia.org/r/117247 (owner: 10Bartosz Dziewoński) [20:33:27] (03PS1) 10Thiemo Mättig (WMDE): Status::getMessage accidentially returned string instead of Message [core] - 10https://gerrit.wikimedia.org/r/117309 [20:40:56] (03CR) 10Parent5446: [C: 031] "Will wait on Bartosz to remove -2 before merging." [core] - 10https://gerrit.wikimedia.org/r/117247 (owner: 10Bartosz Dziewoński) [20:41:37] (03CR) 10Umherirrender: "That is a good idea. But at the moment it is hard to do, because the list for validation and autodoc is the same, but I need a function fo" [core] - 10https://gerrit.wikimedia.org/r/117041 (owner: 10Umherirrender) [20:46:10] (03CR) 10Jack Phoenix: [C: 031] "This is good to go as far as I'm concerned (but I'm not able to +2 this patchset, unfortunately)." [extensions/AJAXPoll] - 10https://gerrit.wikimedia.org/r/117254 (owner: 10GeorgeBarnick) [20:48:49] (03PS1) 10Manybubbles: If namespace doesn't have a weight default to .2 [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/117311 [20:49:07] (03CR) 10Isarra: "MaxSem: As I understand it, that's a limitation in the login form in general. It doesn't fall back very gracefully without js for a lot of" [core] - 10https://gerrit.wikimedia.org/r/117247 (owner: 10Bartosz Dziewoński) [20:51:18] (03PS1) 10Manybubbles: Make method signatures match core [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/117312 [21:00:38] (03CR) 10Swalling: "@Parent5446 Normally we would wait to get input on reverting a new feature. However, we are not going to wait around for others to review " [core] - 10https://gerrit.wikimedia.org/r/117234 (owner: 10Jdlrobson) [21:03:53] (03CR) 10Mwalker: [C: 032] Revert "Add getMessage tests with Short and Long Contexts" [core] - 10https://gerrit.wikimedia.org/r/117308 (owner: 10Addshore) [21:04:18] cheers mwalker|alt, I was quite shocked when I spotted string in the phpdoc today >.> [21:04:39] yep yep; I should've checked too [21:05:00] heh, easy mistake to make as the default is a bool :P [21:05:05] (03PS14) 10Phuedx: Updates to jsduck setup and comments [extensions/GuidedTour] - 10https://gerrit.wikimedia.org/r/86057 (owner: 10Mattflaschen) [21:06:05] (03CR) 10Phuedx: Updates to jsduck setup and comments (031 comment) [extensions/GuidedTour] - 10https://gerrit.wikimedia.org/r/86057 (owner: 10Mattflaschen) [21:06:10] (03PS14) 10Nemo bis: Add link to PD help translatable pages from sidebar [core] - 10https://gerrit.wikimedia.org/r/83221 [21:08:02] (03CR) 10Addshore: [C: 04-1] "Needs a manual rebase :<" [core] - 10https://gerrit.wikimedia.org/r/101895 (owner: 10Aude) [21:11:25] (03CR) 10Phuedx: [C: 032] Updates to jsduck setup and comments [extensions/GuidedTour] - 10https://gerrit.wikimedia.org/r/86057 (owner: 10Mattflaschen) [21:11:29] (03CR) 10CSteipp: [C: 032] Cleaner response for captcha-related createaccount API failure [extensions/ConfirmEdit] - 10https://gerrit.wikimedia.org/r/116170 (owner: 10Brion VIBBER) [21:11:37] \o/ wooooo [21:11:43] thanks :D [21:13:54] (03Merged) 10jenkins-bot: Cleaner response for captcha-related createaccount API failure [extensions/ConfirmEdit] - 10https://gerrit.wikimedia.org/r/116170 (owner: 10Brion VIBBER) [21:13:57] (03CR) 10Addshore: Add RCCacheEntryBuilder, split from EnhancedChangesList and cleaned up (034 comments) [core] - 10https://gerrit.wikimedia.org/r/97742 (owner: 10Aude) [21:14:51] (03CR) 10jenkins-bot: [V: 04-1] Add link to PD help translatable pages from sidebar [core] - 10https://gerrit.wikimedia.org/r/83221 (owner: 10Nemo bis) [21:23:16] (03CR) 10Nikerabbit: Add RCCacheEntryBuilder, split from EnhancedChangesList and cleaned up (031 comment) [core] - 10https://gerrit.wikimedia.org/r/97742 (owner: 10Aude) [21:25:34] (03PS1) 10MaxSem: Ignore build files [php/wikidiff2] - 10https://gerrit.wikimedia.org/r/117316 [21:26:13] (03CR) 10MaxSem: [C: 032 V: 032] "Trivial." [php/wikidiff2] - 10https://gerrit.wikimedia.org/r/117316 (owner: 10MaxSem) [21:28:07] (03CR) 10Chad: [C: 032] Make method signatures match core [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/117312 (owner: 10Manybubbles) [21:29:00] (03PS1) 10Manybubbles: [WIP] Drop 0.90 compatibility [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/117317 [21:29:02] (03CR) 10jenkins-bot: [V: 04-1] [WIP] Drop 0.90 compatibility [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/117317 (owner: 10Manybubbles) [21:29:17] (03PS1) 10Chad: Minor code style tweak to simplify Result constructor [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/117318 [21:30:36] (03CR) 10Nikerabbit: [C: 032] jsduck: Clean up odd use of @returns instead of @return [core] - 10https://gerrit.wikimedia.org/r/117198 (owner: 10Krinkle) [21:32:27] (03CR) 10Manybubbles: [C: 032] "uhg I'm working on this file! I'll +2 and then merge on my side." [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/117318 (owner: 10Chad) [21:37:43] (03PS4) 10EBernhardson: [WIP] Rework formatters to use a common base [extensions/Flow] - 10https://gerrit.wikimedia.org/r/115532 [21:37:46] (03PS4) 10EBernhardson: Sort the combined header+topic revisions after merging [extensions/Flow] - 10https://gerrit.wikimedia.org/r/115531 [21:37:49] (03PS4) 10EBernhardson: Split reusable parts out of ContributionsQuery [extensions/Flow] - 10https://gerrit.wikimedia.org/r/115530 [21:37:52] (03PS2) 10EBernhardson: Make FlowActions accessible from permissions [extensions/Flow] - 10https://gerrit.wikimedia.org/r/116674 [21:37:55] (03PS2) 10EBernhardson: Add method to inject a workflow into the urlgenerators workflow cache [extensions/Flow] - 10https://gerrit.wikimedia.org/r/116673 [21:40:29] is jenkins hosed? [21:40:48] I'm not getting my customary +2s [21:40:58] manybubbles: Very slow today [21:41:23] (03CR) 10Bsitu: Use single query for multiple revision lookups by pk (031 comment) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/115416 (owner: 10EBernhardson) [21:41:24] https://integration.wikimedia.org/ci/job/mwext-browsertests-CirrusSearch-phantomjs/76/ isn't responding.... [21:41:47] https://integration.wikimedia.org/zuul/ long queue [21:42:13] (03PS1) 10Chad: Remove some pointless else statements [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/117325 [21:43:28] Nikerabbit: I think the queue comes from it getting hosed [21:43:33] maybe the other way around too [21:45:04] manybubbles: likely [21:45:30] (03CR) 10Chad: [C: 032] If namespace doesn't have a weight default to .2 [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/117311 (owner: 10Manybubbles) [21:45:45] (03Merged) 10jenkins-bot: Updates to jsduck setup and comments [extensions/GuidedTour] - 10https://gerrit.wikimedia.org/r/86057 (owner: 10Mattflaschen) [21:46:17] (03Merged) 10jenkins-bot: Ignore build files [php/wikidiff2] - 10https://gerrit.wikimedia.org/r/117316 (owner: 10MaxSem) [21:47:14] best way to get a mocked IContextSource that returns the proper (mocked) classes in phpunit? [21:47:35] (03CR) 10Manybubbles: [C: 032] Remove some pointless else statements [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/117325 (owner: 10Chad) [21:53:53] ebernhardson, there's already a mock: create DerivativeContext, then set everything you need [21:57:38] * addshore thinks jenkins needs a rest [22:00:48] go go gadget gallium! http://ganglia.wikimedia.org/latest/?r=day&cs=&ce=&c=Miscellaneous+eqiad&h=gallium.wikimedia.org&tab=m&vn=&hide-hf=false&mc=2&z=medium&metric_group=ALLGROUPS [22:07:42] (03CR) 10CSteipp: [C: 032] "This is working in my (fairly limited) test environment. Seems like it should work for WMF." [extensions/Oversight] - 10https://gerrit.wikimedia.org/r/111514 (owner: 10Alex Monk) [22:08:15] :) [22:08:45] (03PS4) 10Inchikutty: UploadWizard:OSM embedding- Geocoding, reverse geocoding [extensions/UploadWizard] (osm) - 10https://gerrit.wikimedia.org/r/116130 [22:08:50] csteipp, think you need to Verified+2 and publish too [22:08:57] James_F: fyi: I'm drafting an awareness e-mail to wikitech-l at the moment about my intent to upgrade jQuery core (finally!) in MediaWiki. We've reached a point where we really need to cut this rope and move on. I'd like your review on it before I send it, and quickly afterwards for it (or a derivative of it) to appear on wikitech-ambassadors (which I need approval of afaik, since it's not an open list [22:08:58] , right?) [22:09:03] Can you be that person? [22:09:04] ah, one of those repos... [22:09:08] Krenair: Jenkins is slow, but not down [22:09:20] csteipp: Don't think so [22:09:32] couple of days ago I had a checkuser patch which jenkins merged [22:09:48] Cool. I'll see if it goes through in the next few hours [22:09:48] nothing showing on https://integration.wikimedia.org/zuul/ [22:09:50] James_F: Basically a "this is what will break if you're still using these deprecated features, here's how to fix them, here's the marvelous jQuery.com upgrade guide, go out , reproduce and fix your gadgets" [22:09:52] it will just take an awefull long time for jenkins to get around to it right now [22:09:54] Krinkle: http://ganglia.wikimedia.org/latest/?r=day&cs=&ce=&c=Miscellaneous+eqiad&h=gallium.wikimedia.org&tab=m&vn=&hide-hf=false&mc=2&z=medium&metric_group=ALLGROUPS [22:10:03] opps Krenair ^^ [22:10:16] Krenair: https://gerrit.wikimedia.org/r/116259 [22:10:19] https://gerrit.wikimedia.org/r/#/q/project:mediawiki/extensions/Oversight,n,z shows previous changes have had Verified+2 from the approver [22:10:34] Dang, what happened to gallium? [22:10:37] hoo, that's checkuser not oversight [22:10:47] oh, damn [22:11:02] :) [22:11:08] heh, ok :P [22:11:30] Krinkle: Oooh, yay. [22:12:07] Krinkle: Send and I'll review. [22:13:20] (03CR) 10Parent5446: "I'm not going to have this discussion in two different places. Please respond on the mailing list." [core] - 10https://gerrit.wikimedia.org/r/117234 (owner: 10Jdlrobson) [22:13:28] (03PS1) 10Jforrester: Update OOjs UI to v0.1.0-pre (8b13d2b7f7) [core] - 10https://gerrit.wikimedia.org/r/117328 [22:18:21] csteipp, so yes, it's one of those repos [22:18:47] (03CR) 10CSteipp: [V: 032] Check current name of user instead of blindly using user_text (could've been renamed since) [extensions/Oversight] - 10https://gerrit.wikimedia.org/r/111514 (owner: 10Alex Monk) [22:18:50] If it had queued tests for jenkins, it would have said so by now (usually says that before it logs your approval comment in fact) [22:21:28] (03CR) 10Esanders: [C: 032] Update OOjs UI to v0.1.0-pre (8b13d2b7f7) [core] - 10https://gerrit.wikimedia.org/r/117328 (owner: 10Jforrester) [22:24:06] (03Merged) 10jenkins-bot: Make method signatures match core [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/117312 (owner: 10Manybubbles) [22:24:39] (03Merged) 10jenkins-bot: Minor code style tweak to simplify Result constructor [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/117318 (owner: 10Chad) [22:24:49] (03CR) 10Hoo man: [C: 04-1] "I thought we merged it... but needs a rebase now :/" [core] - 10https://gerrit.wikimedia.org/r/36330 (owner: 10Alex Monk) [22:25:02] Krenair: :/ I really forgot about that one... [22:25:07] addshore: Just to verify, is there something oyu wanted me to look into? [22:25:16] (or something to show me) - or was that for Krenair [22:25:46] That was for me, I think [22:35:29] (03Merged) 10jenkins-bot: If namespace doesn't have a weight default to .2 [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/117311 (owner: 10Manybubbles) [22:35:33] (03Merged) 10jenkins-bot: Remove some pointless else statements [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/117325 (owner: 10Chad) [22:37:32] (03PS3) 10JGonera: [WIP] Add click tracking to compact personal bar [extensions/VectorBeta] - 10https://gerrit.wikimedia.org/r/117138 [22:40:11] (03CR) 10jenkins-bot: [V: 04-1] [WIP] Add click tracking to compact personal bar [extensions/VectorBeta] - 10https://gerrit.wikimedia.org/r/117138 (owner: 10JGonera) [22:42:47] (03Merged) 10jenkins-bot: jsduck: Clean up odd use of @returns instead of @return [core] - 10https://gerrit.wikimedia.org/r/117198 (owner: 10Krinkle) [22:42:49] (03Merged) 10jenkins-bot: Update OOjs UI to v0.1.0-pre (8b13d2b7f7) [core] - 10https://gerrit.wikimedia.org/r/117328 (owner: 10Jforrester) [22:49:10] James_F: Linky link? [22:49:16] Or maybe the patch doesn't exist [22:57:30] (03PS28) 10Alex Monk: Cross-wiki user rights UI should show target wiki groups instead of local [core] - 10https://gerrit.wikimedia.org/r/36330 [22:57:32] hoo, uploaded (untested) rebase [22:57:44] and ugh, patch number #28. this is getting silly. [23:04:02] rdwrer: One moment. [23:04:41] (03PS7) 10J-squared: Notification for when a user adds you to a course [extensions/EducationProgram] - 10https://gerrit.wikimedia.org/r/113145 [23:23:38] (03PS1) 10Chad: Return boolean from delete jobs [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/117335 [23:24:44] (03PS1) 10Chad: Handle old todo, Title objects have long since been removed [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/117336 [23:25:32] (03CR) 10Chad: [C: 032 V: 032] Add COPYING [extensions/Elastica] - 10https://gerrit.wikimedia.org/r/116251 (owner: 10Reedy) [23:27:25] (03PS2) 10Aaron Schulz: Return boolean from delete jobs [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/117335 (owner: 10Chad) [23:29:25] <^d> AaronSchulz: Maybe I was wanting to indicat. [23:29:27] <^d> Cats are cool. [23:29:50] <^d> Especially indie cats. [23:30:54] ^d: I prefer stray ones [23:31:04] They're flat broke, but they don't care. [23:39:11] (03PS1) 10Aude: Fix undefined property in PoolCounterWork [core] - 10https://gerrit.wikimedia.org/r/117339 [23:39:13] (03PS1) 10Aude: Add visibility in PoolCounter classes [core] - 10https://gerrit.wikimedia.org/r/117340 [23:40:34] ^d: does $updater->deletePages() actually return anything? [23:41:33] (03CR) 10Hoo man: [C: 032] "Looks sensible" [core] - 10https://gerrit.wikimedia.org/r/117339 (owner: 10Aude) [23:41:36] <^d> Does with this patch. [23:41:37] <^d> https://gerrit.wikimedia.org/r/#/c/117335/2/includes/Updater.php [23:42:21] * AaronSchulz likes how there are two Job classes in different NSes [23:42:55] <^d> :) [23:43:20] (03CR) 10Hoo man: [C: 032] "Seems fine (also see parent classes)" [core] - 10https://gerrit.wikimedia.org/r/117340 (owner: 10Aude) [23:43:58] * hoo likes easy peasy code review :D [23:45:17] :) [23:47:44] (03CR) 10Aaron Schulz: [C: 032] Return boolean from delete jobs [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/117335 (owner: 10Chad) [23:49:06] (03Merged) 10jenkins-bot: Fix undefined property in PoolCounterWork [core] - 10https://gerrit.wikimedia.org/r/117339 (owner: 10Aude) [23:49:26] (03Merged) 10jenkins-bot: Return boolean from delete jobs [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/117335 (owner: 10Chad) [23:50:26] (03Merged) 10jenkins-bot: Add visibility in PoolCounter classes [core] - 10https://gerrit.wikimedia.org/r/117340 (owner: 10Aude) [23:51:48] (03PS2) 10Manybubbles: [WIP] Drop 0.90 compatibility [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/117317 [23:57:17] (03CR) 10Chad: "I can't seem to get all the gems installed on 12.04, requires ruby 1.9.2+" [vagrant] - 10https://gerrit.wikimedia.org/r/115679 (owner: 10Manybubbles)