[00:00:34] (03PS1) 10Ori.livneh: Update CentralNotice to tip of wmf_deploy [core] (wmf/1.23wmf16) - 10https://gerrit.wikimedia.org/r/116908 [00:00:38] (03PS1) 10Ori.livneh: Update CentralNotice to tip of wmf_deploy [core] (wmf/1.23wmf15) - 10https://gerrit.wikimedia.org/r/116909 [00:01:33] (03PS1) 10EBernhardson: wfProfileIn/Out -> ProfileSection [extensions/Flow] - 10https://gerrit.wikimedia.org/r/116910 [00:01:40] (03CR) 10Aaron Schulz: [C: 032] Remove another undefined $env and TODO comment for it too [core] - 10https://gerrit.wikimedia.org/r/114482 (owner: 10Umherirrender) [00:03:23] ^d: Worked around it for now by using git.wikimedia.org only [00:03:34] mwalker: ^ could you +1 or +2 116908 & 116909? [00:03:38] took a bit of forcing to actually get it to properly use that remote [00:04:03] ^d: plain switching the remotes didn't work, it would still have messed up refs https://bugzilla.wikimedia.org/show_bug.cgi?id=44129#c41 [00:04:54] <^d> Bleh [00:04:59] (03CR) 10EBernhardson: "oh profile section looks nifty, wfProfileOut implemented through the destructor" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/115689 (owner: 10EBernhardson) [00:06:06] (03Merged) 10jenkins-bot: Remove another undefined $env and TODO comment for it too [core] - 10https://gerrit.wikimedia.org/r/114482 (owner: 10Umherirrender) [00:07:46] mwalker: ping? [00:08:10] pong [00:08:36] (03PS6) 10Bsitu: Makefile command to run phpstorm inspections [extensions/Flow] - 10https://gerrit.wikimedia.org/r/114701 (owner: 10EBernhardson) [00:08:50] ori, ^ [00:09:02] ping pong failed? :D [00:09:14] mwalker: https://gerrit.wikimedia.org/r/116908 & 9 [00:09:20] look ok? [00:10:16] (03CR) 10Mwalker: [C: 032] Update CentralNotice to tip of wmf_deploy [core] (wmf/1.23wmf16) - 10https://gerrit.wikimedia.org/r/116908 (owner: 10Ori.livneh) [00:10:31] (03CR) 10Mwalker: [C: 032] Update CentralNotice to tip of wmf_deploy [core] (wmf/1.23wmf15) - 10https://gerrit.wikimedia.org/r/116909 (owner: 10Ori.livneh) [00:10:39] yepyep [00:10:49] mwalker: i can do the deploy, once they clear jenkins [00:10:54] unless you'd like to [00:11:02] nah; you can go for it [00:11:06] cool [00:12:05] (03CR) 10EBernhardson: [C: 032] Spam-checking moderation doesn't make sense [extensions/Flow] - 10https://gerrit.wikimedia.org/r/116117 (owner: 10Matthias Mullie) [00:12:43] ^d: AW well fuck, apparently not [00:12:50] https://tools.wmflabs.org/snapshots/?action=updatelog [00:12:57] fatal: unresolved deltas left after unpacking [00:12:58] fatal: unpack-objects failed [00:13:00] ugh.. [00:13:18] <^d> Is recloning the repo not an option? [00:13:30] (03Merged) 10jenkins-bot: Spam-checking moderation doesn't make sense [extensions/Flow] - 10https://gerrit.wikimedia.org/r/116117 (owner: 10Matthias Mullie) [00:14:06] Imma re-clone the whole thing and forget about it, ideally one shuld be able to write a shell script that reliably interacts with the repo once an hour and does a git pull and then a tarball, but apparently this is too much for gerrit/git/whatever. I don't want to have to look back a this every other week to fix random shizzle though, so maybe I'll just re-clone every single hour. [00:17:34] Krinkle: do shallow clones at least :) [00:17:48] ebernhardson: No, because those also have issues [00:17:54] with making a tarball? [00:18:05] i know they have issues with upstreaming commits, but for not making commits i thought they were ok [00:18:06] besides it wouldn't save much since I'm moving back and forth between the history like crazy [00:19:44] the thing is, I set this up little over a year ago, and not a month has gone by without it unrecoverably breaking (that is, unrecoverable from the automated script, I was able to fix it manually usuall, until now) [00:22:20] (03CR) 10Bsitu: [SCHEMA CHANGE] Add index on revision user data (032 comments) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/116115 (owner: 10Matthias Mullie) [00:57:27] (03PS1) 10SPQRobin: Fix Uzbek converter [core] - 10https://gerrit.wikimedia.org/r/116914 [01:03:19] (03PS5) 10PleaseStand: Hide message for DBUnexpectedError exceptions [core] - 10https://gerrit.wikimedia.org/r/89512 [01:04:39] when is wmt17 deployed on testwiki? [01:04:46] *wmf [01:05:02] huh: Thursday. [01:05:11] At about 11:00 PST, but it varies [01:05:11] oh, thought it was today [01:05:14] sorry [01:05:31] heh, anything broken? :P [01:05:59] (03CR) 10Aaron Schulz: [C: 032] Hide message for DBUnexpectedError exceptions [core] - 10https://gerrit.wikimedia.org/r/89512 (owner: 10PleaseStand) [01:09:20] (03Merged) 10jenkins-bot: Hide message for DBUnexpectedError exceptions [core] - 10https://gerrit.wikimedia.org/r/89512 (owner: 10PleaseStand) [01:36:47] (03CR) 10Bsitu: [C: 032] Makefile command to run phpstorm inspections [extensions/Flow] - 10https://gerrit.wikimedia.org/r/114701 (owner: 10EBernhardson) [01:37:03] (03Merged) 10jenkins-bot: Makefile command to run phpstorm inspections [extensions/Flow] - 10https://gerrit.wikimedia.org/r/114701 (owner: 10EBernhardson) [01:44:27] (03PS4) 10Bsitu: share code between pre-commit and pre-review hooks [extensions/Flow] - 10https://gerrit.wikimedia.org/r/114764 (owner: 10EBernhardson) [01:47:14] shahyar: I talked to mwalker after our meeting. The PHP implementation of our KnockoutJS subset (knockoff? dropout? :) ) isn't ready, but he still thinks using KnockoutJS for Flow front-end templating would be the best choice [01:47:55] (03CR) 10Bsitu: [C: 032] share code between pre-commit and pre-review hooks [extensions/Flow] - 10https://gerrit.wikimedia.org/r/114764 (owner: 10EBernhardson) [01:48:07] (03Merged) 10jenkins-bot: share code between pre-commit and pre-review hooks [extensions/Flow] - 10https://gerrit.wikimedia.org/r/114764 (owner: 10EBernhardson) [01:52:46] (03PS6) 10Bsitu: pre-review script to run check-i18n and analyze-phpstorm when appropriate [extensions/Flow] - 10https://gerrit.wikimedia.org/r/114703 (owner: 10EBernhardson) [01:54:57] (03CR) 10Bsitu: [C: 032] pre-review script to run check-i18n and analyze-phpstorm when appropriate [extensions/Flow] - 10https://gerrit.wikimedia.org/r/114703 (owner: 10EBernhardson) [01:55:09] (03Merged) 10jenkins-bot: pre-review script to run check-i18n and analyze-phpstorm when appropriate [extensions/Flow] - 10https://gerrit.wikimedia.org/r/114703 (owner: 10EBernhardson) [01:56:28] (03PS1) 10BryanDavis: Convert sync-wikiversions to python [tools/scap] - 10https://gerrit.wikimedia.org/r/116918 [01:56:30] (03CR) 10jenkins-bot: [V: 04-1] Convert sync-wikiversions to python [tools/scap] - 10https://gerrit.wikimedia.org/r/116918 (owner: 10BryanDavis) [01:58:41] spagewmf: sounds good. I'd be open to even using an interim solution on the server-side (eg. a nodejs proxy, v8js php extension). Flow isn't ready for public consumption anyways, it's an internal project. [02:00:14] (03PS2) 10BryanDavis: Convert sync-wikiversions to python [tools/scap] - 10https://gerrit.wikimedia.org/r/116918 [02:00:16] (03CR) 10jenkins-bot: [V: 04-1] Convert sync-wikiversions to python [tools/scap] - 10https://gerrit.wikimedia.org/r/116918 (owner: 10BryanDavis) [02:06:18] (03CR) 10BryanDavis: "I don't know what Jenkins' problem with this is. I tried checking out the prior patch in the chain (Ie50be09) and cherry-picking this patc" [tools/scap] - 10https://gerrit.wikimedia.org/r/116918 (owner: 10BryanDavis) [02:09:47] (03PS6) 10JGonera: [WIP] Add Compact personal bar beta feature [extensions/VectorBeta] - 10https://gerrit.wikimedia.org/r/99586 [02:09:49] (03PS1) 10JGonera: [WIP] Add watchlist count to compact personal bar [extensions/VectorBeta] - 10https://gerrit.wikimedia.org/r/116920 [02:10:18] (03CR) 10JGonera: [C: 04-2] [WIP] Add watchlist count to compact personal bar [extensions/VectorBeta] - 10https://gerrit.wikimedia.org/r/116920 (owner: 10JGonera) [02:11:16] (03CR) 10Spage: "These comments on ExceptionHandling.php motivated me to file bug 62176 to reuse core's MWException subclasses, I made a proof of concept i" (037 comments) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/116631 (owner: 10Spage) [02:55:18] (03PS9) 10Wctaiwan: [WIP] Add "Thanks" for comments on Flow boards [extensions/Thanks] - 10https://gerrit.wikimedia.org/r/115557 [03:01:01] I updated parsoid on a labs instance and it needs simplediff. But `npm install` fails with "SSL Error: CERT_UNTRUSTED". [03:20:54] (03CR) 10Hcohl: [C: 031] Coverage tests for the Math extension [extensions/Math] - 10https://gerrit.wikimedia.org/r/112353 (owner: 10Physikerwelt) [03:25:27] (03PS1) 10Pastakhov: Squashed commit of the following: [extensions/MultiMaps] (REL1_21) - 10https://gerrit.wikimedia.org/r/116922 [03:28:02] (03CR) 10Pastakhov: [C: 032] Squashed commit of the following: [extensions/MultiMaps] (REL1_21) - 10https://gerrit.wikimedia.org/r/116922 (owner: 10Pastakhov) [03:28:12] (03Merged) 10jenkins-bot: Squashed commit of the following: [extensions/MultiMaps] (REL1_21) - 10https://gerrit.wikimedia.org/r/116922 (owner: 10Pastakhov) [03:31:53] (03PS1) 10Pastakhov: Squashed commit of the following: [extensions/MultiMaps] (REL1_22) - 10https://gerrit.wikimedia.org/r/116923 [03:32:30] (03CR) 10Pastakhov: [C: 032] Squashed commit of the following: [extensions/MultiMaps] (REL1_22) - 10https://gerrit.wikimedia.org/r/116923 (owner: 10Pastakhov) [03:32:39] (03Merged) 10jenkins-bot: Squashed commit of the following: [extensions/MultiMaps] (REL1_22) - 10https://gerrit.wikimedia.org/r/116923 (owner: 10Pastakhov) [03:35:29] (03PS3) 10BryanDavis: Add pythonic configuration [tools/scap] - 10https://gerrit.wikimedia.org/r/116455 [03:36:49] is it ok to merge https://gerrit.wikimedia.org/r/112353 [03:42:09] (03CR) 10Pastakhov: [C: 04-2] add 'extNumberFormat' function for extension Foxway ( version 0.6.1 ) [extensions/NumberFormat] - 10https://gerrit.wikimedia.org/r/95111 (owner: 10Pastakhov) [04:13:17] Hey superm401! Doesn't it make more sense to have the `li` inside the `ul` is there a particular benefit of keeping these separate? https://gerrit.wikimedia.org/r/116272 [04:15:30] (03CR) 10BryanDavis: "When enabling this role on a vagrant instance with no other roles enabled I get this error on `vagrant provision`:" [vagrant] - 10https://gerrit.wikimedia.org/r/115679 (owner: 10Manybubbles) [04:19:14] prtksxna, in general you don't want to make things in CSS specific without a reason, or you can have unintended effects/require extra effort later. [04:19:24] For example, say I have one rule for: [04:19:30] ul li.selected [04:19:37] Basically a selected item in an unordered list. [04:19:52] Then there's: [04:19:55] .mw-debug li [04:20:28] The selected item will override the other one, which is probably intended in this case (the selected item is probably intended to look different from other lis) [04:20:32] But then if you have: [04:20:42] .mw-debug ui li [04:21:21] All of a sudden they're the same specificity, and the physical order of the CSS matters. [04:22:07] superm401: Right, my thought process was that `li` would always be inside a `ul`, I didn't think that far. [04:22:22] superm401: I'll upload a new patch in a bit. Sorry for the reordering! [04:22:39] prtksxna, in this case, possibly. But in general, lis may be inside an ol as well (ordered list). [04:23:07] superm401: But they wouldn't want the same styling anyway, no? [04:23:23] prtksxna, same styling between which two? [04:23:43] superm401: ol li ≠ ul li (in terms of styling) [04:24:26] prtksxna, right. I was just noting why 'ul li.selected' is plausible, rather than just 'li.selected'. [04:24:53] superm401: Right, I understood. [04:41:06] (03CR) 10Adamw: [C: 032] Add COPYING [extensions/Campaigns] - 10https://gerrit.wikimedia.org/r/116247 (owner: 10Reedy) [04:41:08] (03Merged) 10jenkins-bot: Add COPYING [extensions/Campaigns] - 10https://gerrit.wikimedia.org/r/116247 (owner: 10Reedy) [05:01:32] (03PS3) 10Prtksxna: mediawiki.debug: Migrate CSS to LESS [core] - 10https://gerrit.wikimedia.org/r/116272 [05:02:12] (03CR) 10Prtksxna: mediawiki.debug: Migrate CSS to LESS (033 comments) [core] - 10https://gerrit.wikimedia.org/r/116272 (owner: 10Prtksxna) [05:06:23] Hey everyone. Question: should there ever be duplicates in the API protection section for a page? Specifically, I'm looking at the Wikipedia "Main page" redirect: http://en.wikipedia.org/w/api.php?action=query&titles=Main+page&prop=info&inprop=protection [05:07:28] superm401: done! [05:09:31] prtksxna, thanks, will try to re-review tonight. [05:09:44] superm401: Thank you :) [05:25:08] shahyar, you might want to post a little more about your experience with Phabricator at https://www.mediawiki.org/wiki/Talk:Project_management_tools/Review/Options [05:25:24] From where I'm sitting it seems like a good candidate, but I've never actually used it. [05:37:46] (03CR) 10Jeroen De Dauw: [C: 031] Add site by navigation id feature to SiteList [core] - 10https://gerrit.wikimedia.org/r/116730 (owner: 10Bene) [05:42:59] RobinHood left :| [05:43:04] its because of cascading protection [05:48:03] Anyone free to review some Extension:Popups patches? [05:52:55] (03PS1) 10Physikerwelt: WIP: Using DB2 as Database backend. [extensions/MathSearch] - 10https://gerrit.wikimedia.org/r/116929 [05:53:03] (03CR) 10jenkins-bot: [V: 04-1] WIP: Using DB2 as Database backend. [extensions/MathSearch] - 10https://gerrit.wikimedia.org/r/116929 (owner: 10Physikerwelt) [05:54:06] (03CR) 10Mattflaschen: "I know this is still a WIP. I'm just commenting now to make sure we're on the same page." (031 comment) [core] - 10https://gerrit.wikimedia.org/r/116735 (owner: 10Phuedx) [06:11:01] (03CR) 10Mattflaschen: "One potential issue (not necessarily a blocker but we need to think about it) is the relation between this validation framework and the va" [core] - 10https://gerrit.wikimedia.org/r/116735 (owner: 10Phuedx) [06:29:47] springle: http://pastebin.com/tNYGm8a4 looks like that is much faster with STRAIGHT_JOIN than without :/ [06:31:15] AaronSchulz: those are all over the place atm. when we removed STRAIGHT_JOIN we fixed a bunch and broke a bunch more [06:31:25] maybe https://gerrit.wikimedia.org/r/#/c/114070/2/includes/specials/SpecialWhatlinkshere.php should be added back if the estimated number of pages in the NS is not low [06:31:44] I hate to do that app layer but not sure how else to work around that [06:32:00] mysql keeps wanting to use namespace,title even if there is no NS condition [06:32:15] well not one on page and nor with equality prop [06:32:20] could add tl_from namespace to links table. don't join page at all, pull out pages in second batch [06:35:12] yeah that could be done...would need a few code changes with pages moves but shouldn't be too bad [06:36:56] enwiki is showing a few, but the big offenders are mid-sized *wiktionary, metawiki, etc where the ratio of *links to pages is askew [06:37:07] http://pastebin.com/WWdHyaYs [06:37:33] right, I found that interesting [06:37:50] another odd thing maybe you can answer [06:38:03] * AaronSchulz was look at enwiktionary [06:39:16] storms of showIndirectLinks are arriving simultaneously from all manner of clients: msnbot, google, non-crawlers [06:39:34] like some caching is expiring somewhere and everything hits the DBs [06:49:09] (03CR) 10Mattflaschen: "I consider this our chance to have a new API, which is hopefully much better for non-linear cases, and at least as good for linear ones (a" (035 comments) [extensions/GuidedTour] - 10https://gerrit.wikimedia.org/r/116228 (owner: 10Mattflaschen) [06:53:23] springle: it might be nice if we took a much different approach to slow/complex queries in general. We really should streamline the GUI and have people use slow/complex queries on slave in labs. [06:53:53] the current way of doing things seems cluttered, DOS-prone, and not terrible sustainable [06:53:56] *terribly [06:54:38] maybe some stuff could be done adaptively, (e.g. disabling NS filters for user contribs if the user has tons of edits) [06:55:00] anything to so with paging large amounts of data will always bet progressively harder [06:55:07] s/to so/to do/ [06:55:59] hmm, I wonder if query grouping in the API could also work too [06:56:15] (e.g. API vs everything else) [06:56:21] I've had success with partitioning recently. LogPager slow q's have dropped off, also contributions [06:56:26] just like we have apaches dedicated to that [06:56:28] but that can only scale so far [06:56:44] api is already grouped for the load balancer [06:57:05] S1 has a dedicated api slave now. others don't (yet) [06:57:39] right, that should at least contain some damage, and more complex queries can be left for there [06:58:10] people keep adding filters to things (e.g. new pages only to contribs) that require scanning that gets worse over time [06:58:19] the kind of thing you are talking about [06:58:43] S1 db1055 is partitioned on user_id for logging and revision. That will buy quirte a bit of time so long as most of those queries continue to filter by user= or user> [07:02:27] (03PS2) 10Deepali: Add appropriate mw-ui button styles to Save, Preview, Show changes and cancel buttons. [core] - 10https://gerrit.wikimedia.org/r/116725 [07:02:40] springle: I'd love to put half a dozen features behind $wgMiserMode...though I'm sure people would offend [07:02:55] * AaronSchulz feels hopeless [07:03:57] (03CR) 10Deepali: "Yes, I have moved it there. Sorry for the inconvenience." [core] - 10https://gerrit.wikimedia.org/r/116783 (owner: 10Deepali) [07:04:25] one of the longer-term plans of the analytics team is to use apache sqoop to replicate the content of the production databases to a hadoop cluster [07:05:36] AaronSchulz: we could also normalize some stuff to reduce DB footprint. we do tend to use varbinary and duplicate strings all over the place [07:05:56] we could talk with them about how that might work and how we could integrate it into mediawiki such that some things are implemented via mapreduce [07:06:55] (03PS1) 10Netbrain: Modified README [extensions/SideBarMenu] - 10https://gerrit.wikimedia.org/r/116930 [07:07:20] (03CR) 10Netbrain: [C: 032 V: 032] Modified README [extensions/SideBarMenu] - 10https://gerrit.wikimedia.org/r/116930 (owner: 10Netbrain) [07:07:36] (03CR) 10Deepali: "Right now I have added mw-ui-destructive for cancel. Please tell if there is a better option than that. Also, should I add mw-ui-destructi" [core] - 10https://gerrit.wikimedia.org/r/116725 (owner: 10Deepali) [07:07:43] (03CR) 10PleaseStand: [C: 04-1] "Per my review of PS1." [core] - 10https://gerrit.wikimedia.org/r/116725 (owner: 10Deepali) [07:08:20] ori: sounds like a worthwhile conversation to have [07:10:26] (03CR) 10Deepali: "Sorry, I meant mw-ui-constryctive for Save Changes." [core] - 10https://gerrit.wikimedia.org/r/116725 (owner: 10Deepali) [07:10:39] (03CR) 10Deepali: "*constructive" [core] - 10https://gerrit.wikimedia.org/r/116725 (owner: 10Deepali) [07:10:44] Service reminder: Labs is not something production projects can depend on. [07:11:35] ori: could work for some things, though that could get expensive fast for others. [07:13:32] (03CR) 10Mattflaschen: [C: 04-1] "Yeah, my understanding was that mw-ui-destructive meant deleting/destroying/hiding something that was already out there (destructive is a " [core] - 10https://gerrit.wikimedia.org/r/116725 (owner: 10Deepali) [07:13:40] ori: Eh, citation needed for longer-term plans. [07:13:59] I can't get the analytics team to agree to short-term plans. [07:14:01] ori: would be nice to experiment with alternative link table storage [07:16:40] (03CR) 10Fomafix: mediawiki.page.ajax.watch: Clean up and simplify code (031 comment) [core] - 10https://gerrit.wikimedia.org/r/116907 (owner: 10Krinkle) [07:18:36] AaronSchulz: what sort of data layout do you have in mind? [07:19:20] AaronSchulz: for showIndirectLinks right now, can we batch it? http://pastebin.com/QP8hxLBc [07:19:25] (03PS1) 10Physikerwelt: Add inputhash as id for mathml element [extensions/Math] (dev) - 10https://gerrit.wikimedia.org/r/116931 [07:19:28] also, what are the half-dozen features? :) [07:19:39] (03CR) 10jenkins-bot: [V: 04-1] Add inputhash as id for mathml element [extensions/Math] (dev) - 10https://gerrit.wikimedia.org/r/116931 (owner: 10Physikerwelt) [07:22:45] would be funny if pl_from had huge range gaps for some templates [07:23:03] AaronSchulz: magically change the increment :) [07:23:59] i suppose it might be fragile for the namespaces with few pages that presently run well [07:24:19] for the narrow problem right now it's mostly just the query planner [07:24:38] * AaronSchulz can grip about NS selectors and filters later [07:26:29] ori: would be cool to try some distributed graph DB and/or something with mapreduce support [07:28:27] (03PS2) 10Physikerwelt: Add inputhash as id for mathml element [extensions/Math] (dev) - 10https://gerrit.wikimedia.org/r/116931 [07:28:40] (03CR) 10jenkins-bot: [V: 04-1] Add inputhash as id for mathml element [extensions/Math] (dev) - 10https://gerrit.wikimedia.org/r/116931 (owner: 10Physikerwelt) [07:29:15] * AaronSchulz wishes his liver/gallblader would stop aching :/ [07:30:37] (03CR) 10Physikerwelt: [C: 032 V: 032] Add inputhash as id for mathml element [extensions/Math] (dev) - 10https://gerrit.wikimedia.org/r/116931 (owner: 10Physikerwelt) [07:30:39] (03CR) 10jenkins-bot: [V: 04-1] Add inputhash as id for mathml element [extensions/Math] (dev) - 10https://gerrit.wikimedia.org/r/116931 (owner: 10Physikerwelt) [07:31:47] AaronSchulz: any idea why mediawiki may be nulling the user_token field when "Keep me logged in" is set? [07:31:59] I nulled all of them in wikitech the other day to force people to log out [07:32:09] now it always sets it to null [07:32:50] (03PS2) 10Physikerwelt: WIP: Using DB2 as Database backend. [extensions/MathSearch] - 10https://gerrit.wikimedia.org/r/116929 [07:32:59] (03CR) 10jenkins-bot: [V: 04-1] WIP: Using DB2 as Database backend. [extensions/MathSearch] - 10https://gerrit.wikimedia.org/r/116929 (owner: 10Physikerwelt) [07:34:16] Ryan_Lane: not sure, we don't have many code paths that null tokens do we? [07:34:23] I don't think so [07:34:27] that's why I'm confused [07:34:33] I thought it would be totally fine to null them [07:34:39] in fact we leave it there regardless of that checkbox [07:35:10] did you actually set the tokens? [07:35:15] there is a script to make new ones [07:35:46] though I thought there was logic to do that on the fly too [07:35:47] ah. what's that script? [07:35:57] (03CR) 10Deepali: Handling svg images in CSSMin::encodeImageAsDataURI() (031 comment) [core] - 10https://gerrit.wikimedia.org/r/116490 (owner: 10Deepali) [07:36:31] resetUserTokens.php [07:36:34] aptly named :) [07:37:26] hoooray [07:37:29] trying that [07:37:48] (03PS3) 10Physikerwelt: WIP: Using DB2 as Database backend. [extensions/MathSearch] - 10https://gerrit.wikimedia.org/r/116929 [07:37:49] well, that's a good script to know about [07:37:56] I'll use that next time I need to do this [07:38:56] that's what I get for fucking around in the database [07:41:41] (03CR) 10Hoo man: [C: 032] "Has tests :) Also per Jeroen" [core] - 10https://gerrit.wikimedia.org/r/116730 (owner: 10Bene) [07:46:35] (03Merged) 10jenkins-bot: Add site by navigation id feature to SiteList [core] - 10https://gerrit.wikimedia.org/r/116730 (owner: 10Bene) [07:54:25] (03PS5) 10Mattflaschen: Store page_id in logging table for deletions and make queryable [core] - 10https://gerrit.wikimedia.org/r/113525 [07:54:59] (03CR) 10Mattflaschen: "Updated the commit message per Krinkle's suggestion." (031 comment) [core] - 10https://gerrit.wikimedia.org/r/113525 (owner: 10Mattflaschen) [07:58:30] AaronSchulz: http://pastebin.com/By2i6X4E .. one option. inner query isn't tempted to index scan page table, and outer filesort is always small. havn't tested it widely yet [07:59:02] (enwiktionary again) [08:10:00] springle: that works as long as there are no dead references in the links tables [08:10:13] yup, that's the catch [08:10:13] (e.g. stale entries to things that are not pages anymore) [08:11:31] springle: you could make the inner limit 102 and the out one 51 or something [08:11:49] somewhat of a guessing game how many bad entries can exist [08:11:54] one would hope that it would just be a few [08:12:03] cheat? nice :) [08:12:51] we do delete forward links with page deletion synchronously, so it's not like it depends on the job queue [08:13:11] there should only a be a tiny portion really (unless we have bigger problems) [08:13:22] try it and see if we get complaints? [08:13:31] could even just be 75 inside [08:13:47] probably would be better than now [08:14:00] 500 wouldn't hurt. just not millions [08:14:56] (03CR) 10Mattflaschen: [C: 04-1] "Per PS1, and see inline." (032 comments) [core] - 10https://gerrit.wikimedia.org/r/116725 (owner: 10Deepali) [08:23:29] (03PS5) 10Mattflaschen: Add mediawiki.ui.button to all pages so wiki content can use it [core] - 10https://gerrit.wikimedia.org/r/114085 [08:24:36] (03CR) 10Mattflaschen: "Rebased." [core] - 10https://gerrit.wikimedia.org/r/114085 (owner: 10Mattflaschen) [08:58:29] (03CR) 10Pginer: Button group adjustments (031 comment) [core] - 10https://gerrit.wikimedia.org/r/116075 (owner: 10Pginer) [09:01:43] (03CR) 10Mattflaschen: [C: 032] "Looks good" [core] - 10https://gerrit.wikimedia.org/r/116272 (owner: 10Prtksxna) [09:02:44] superm401: Yay \o/ [09:06:37] (03Merged) 10jenkins-bot: mediawiki.debug: Migrate CSS to LESS [core] - 10https://gerrit.wikimedia.org/r/116272 (owner: 10Prtksxna) [09:12:24] superm401: For once, I didn't get beaten to the Phabricator review queue. ;-) Approved your account. [09:13:11] Thanks [09:29:28] (03PS1) 10Physikerwelt: Fix bugs in caching for dev branch [extensions/Math] (dev) - 10https://gerrit.wikimedia.org/r/116932 [09:29:50] (03CR) 10jenkins-bot: [V: 04-1] Fix bugs in caching for dev branch [extensions/Math] (dev) - 10https://gerrit.wikimedia.org/r/116932 (owner: 10Physikerwelt) [09:30:49] (03PS2) 10Pginer: Button group adjustments [core] - 10https://gerrit.wikimedia.org/r/116075 [09:31:59] (03PS3) 10Pginer: Button group adjustments [core] - 10https://gerrit.wikimedia.org/r/116075 [09:34:40] (03PS2) 10Physikerwelt: Fix bugs in caching for dev branch [extensions/Math] (dev) - 10https://gerrit.wikimedia.org/r/116932 [09:34:56] (03CR) 10Jarry1250: "MathGenerateTests merely *updates* the stock tests, right? There's no requirement for 3rd parties to make sure that interwikis work? It sh" [extensions/Math] - 10https://gerrit.wikimedia.org/r/112353 (owner: 10Physikerwelt) [09:36:46] (03CR) 10Physikerwelt: [C: 032] Fix bugs in caching for dev branch [extensions/Math] (dev) - 10https://gerrit.wikimedia.org/r/116932 (owner: 10Physikerwelt) [09:37:05] (03Merged) 10jenkins-bot: Fix bugs in caching for dev branch [extensions/Math] (dev) - 10https://gerrit.wikimedia.org/r/116932 (owner: 10Physikerwelt) [09:51:07] (03CR) 10PleaseStand: [C: 04-1] "This doesn't fix the bug entirely (for the reason I just posted on the bug) -- the value of $wgSitename will appear twice in the title bar" [core] - 10https://gerrit.wikimedia.org/r/116080 (owner: 10Brian Wolff) [10:36:36] (03CR) 10Bartosz Dziewoński: Button group adjustments (031 comment) [core] - 10https://gerrit.wikimedia.org/r/116075 (owner: 10Pginer) [10:37:34] (03PS4) 10Bartosz Dziewoński: Button group adjustments [core] - 10https://gerrit.wikimedia.org/r/116075 (owner: 10Pginer) [10:37:49] (03CR) 10Bartosz Dziewoński: [C: 031] Button group adjustments [core] - 10https://gerrit.wikimedia.org/r/116075 (owner: 10Pginer) [10:51:14] (03CR) 10Zfilipin: [C: 032] Updated Ruby version from 2.1.0 to 2.1.1 [extensions/WikiLove] - 10https://gerrit.wikimedia.org/r/116715 (owner: 10Vikassy) [10:51:37] (03Merged) 10jenkins-bot: Updated Ruby version from 2.1.0 to 2.1.1 [extensions/WikiLove] - 10https://gerrit.wikimedia.org/r/116715 (owner: 10Vikassy) [10:51:41] (03CR) 10Zfilipin: [C: 032] Updated Ruby version from 2.1.0 to 2.1.1 [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/116711 (owner: 10Vikassy) [10:52:30] (03Merged) 10jenkins-bot: Updated Ruby version from 2.1.0 to 2.1.1 [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/116711 (owner: 10Vikassy) [11:02:01] (03CR) 10Zfilipin: [C: 032] Updated Ruby version from 2.1.0 to 2.1.1 [extensions/Flow] - 10https://gerrit.wikimedia.org/r/116705 (owner: 10Vikassy) [11:03:08] (03CR) 10Bartosz Dziewoński: Handling svg images in CSSMin::encodeImageAsDataURI() (031 comment) [core] - 10https://gerrit.wikimedia.org/r/116490 (owner: 10Deepali) [11:07:28] (03CR) 10Bartosz Dziewoński: [C: 032] mediawiki.page.ajax.watch: Clean up and simplify code (031 comment) [core] - 10https://gerrit.wikimedia.org/r/116907 (owner: 10Krinkle) [11:11:47] (03Merged) 10jenkins-bot: Updated Ruby version from 2.1.0 to 2.1.1 [extensions/Flow] - 10https://gerrit.wikimedia.org/r/116705 (owner: 10Vikassy) [11:14:43] (03Merged) 10jenkins-bot: mediawiki.page.ajax.watch: Clean up and simplify code [core] - 10https://gerrit.wikimedia.org/r/116907 (owner: 10Krinkle) [11:16:22] (03PS1) 10Yarda: Fix HTTPS protocol detection [core] - 10https://gerrit.wikimedia.org/r/116943 [11:41:58] (03PS1) 1001tonythomas: Deprecated window.$j [core] - 10https://gerrit.wikimedia.org/r/116946 [11:42:34] (03PS2) 1001tonythomas: Deprecated window.$j [core] - 10https://gerrit.wikimedia.org/r/116946 [11:51:04] (03CR) 10Hashar: "Zuul can not merge the file. From the /var/log/zuul/debug.log on gallium:" [tools/scap] - 10https://gerrit.wikimedia.org/r/116918 (owner: 10BryanDavis) [11:52:15] (03CR) 10Hashar: "Caused by I86ec2f36ac9a0f5e6f6aa34c26d5fd4676acd84c 23467bf285875de731c52e793ebd9cb4fa49d8f3" [tools/scap] - 10https://gerrit.wikimedia.org/r/116918 (owner: 10BryanDavis) [11:53:19] (03CR) 10Hashar: [C: 031] "PS3 is a rebase, still good to me." [tools/scap] - 10https://gerrit.wikimedia.org/r/116455 (owner: 10BryanDavis) [12:04:28] (03PS1) 1001tonythomas: Use javascript:void() as href for CharInsert [extensions/CharInsert] - 10https://gerrit.wikimedia.org/r/116950 [12:09:07] (03CR) 10Bartosz Dziewoński: [C: 031] Deprecated window.$j [core] - 10https://gerrit.wikimedia.org/r/116946 (owner: 1001tonythomas) [12:16:22] (03PS5) 10Bartosz Dziewoński: code-quality: Special:PrefixIndex is transcludable [core] - 10https://gerrit.wikimedia.org/r/100114 (owner: 10Danny B.) [12:16:24] (03PS5) 10Bartosz Dziewoński: mediawiki.special: Remove HTML backwards-compatibility styles [core] - 10https://gerrit.wikimedia.org/r/116790 [12:16:26] (03PS3) 10Bartosz Dziewoński: mediawiki.special: Kill width: 98% on borderless tables [core] - 10https://gerrit.wikimedia.org/r/116789 [12:18:02] (03CR) 10Bartosz Dziewoński: [C: 032] "Silly parser tests." [core] - 10https://gerrit.wikimedia.org/r/100114 (owner: 10Danny B.) [12:22:37] (03CR) 10Krinkle: "Needs release notes." [core] - 10https://gerrit.wikimedia.org/r/116946 (owner: 1001tonythomas) [12:22:40] (03Merged) 10jenkins-bot: code-quality: Special:PrefixIndex is transcludable [core] - 10https://gerrit.wikimedia.org/r/100114 (owner: 10Danny B.) [12:33:17] (03CR) 10Hashar: "The reason the change did not get merged automatically by Jenkins is that there is no job created for this repository yet :-]" [ruby/api] - 10https://gerrit.wikimedia.org/r/116499 (owner: 10Zfilipin) [12:33:59] (03CR) 10Krinkle: [C: 04-1] Add support for FormData to mw.Api (031 comment) [core] - 10https://gerrit.wikimedia.org/r/116037 (owner: 10JGonera) [12:34:47] (03PS1) 10Jack Phoenix: Fix for unfriending not working properly (due to an undefined variable). [extensions/SocialProfile] - 10https://gerrit.wikimedia.org/r/116951 [12:36:15] (03CR) 10Jack Phoenix: [C: 032 V: 032] Fix for unfriending not working properly (due to an undefined variable). [extensions/SocialProfile] - 10https://gerrit.wikimedia.org/r/116951 (owner: 10Jack Phoenix) [12:36:34] (03CR) 10Krinkle: "See also my comment in this thread on Patch Set 2. Have you looked into content-type?" [core] - 10https://gerrit.wikimedia.org/r/116037 (owner: 10JGonera) [12:42:09] (03CR) 10Krinkle: [C: 04-1] Add a warning when deprecated parameters of mw.Api are used (031 comment) [core] - 10https://gerrit.wikimedia.org/r/115898 (owner: 10Helder.wiki) [12:42:57] (03CR) 10Krinkle: Add a warning when deprecated parameters of mw.Api are used (031 comment) [core] - 10https://gerrit.wikimedia.org/r/115898 (owner: 10Helder.wiki) [12:43:27] (03PS1) 10Jack Phoenix: Fix for "Mails being sent as HTML instead of text". [extensions/SocialProfile] - 10https://gerrit.wikimedia.org/r/116952 [12:44:19] (03PS5) 10Krinkle: mediawiki.api: Emit warning when deprecated callback parameters are used [core] - 10https://gerrit.wikimedia.org/r/115898 (owner: 10Helder.wiki) [12:44:23] (03CR) 10Jack Phoenix: [C: 032 V: 032] Fix for "Mails being sent as HTML instead of text". [extensions/SocialProfile] - 10https://gerrit.wikimedia.org/r/116952 (owner: 10Jack Phoenix) [12:46:56] (03PS2) 10SPQRobin: Fix Uzbek converter [core] - 10https://gerrit.wikimedia.org/r/116914 [12:47:32] (03PS6) 10Krinkle: mediawiki.api: Emit warning when deprecated callback parameters are used [core] - 10https://gerrit.wikimedia.org/r/115898 (owner: 10Helder.wiki) [12:48:30] (03CR) 10Krinkle: [C: 031] mediawiki.api: Emit warning when deprecated callback parameters are used [core] - 10https://gerrit.wikimedia.org/r/115898 (owner: 10Helder.wiki) [12:54:39] (03PS1) 10Netbrain: Fixed globals in respect to composer classloading [extensions/SideBarMenu] - 10https://gerrit.wikimedia.org/r/116954 [12:55:03] (03CR) 10Netbrain: [C: 032 V: 032] Fixed globals in respect to composer classloading [extensions/SideBarMenu] - 10https://gerrit.wikimedia.org/r/116954 (owner: 10Netbrain) [12:56:22] (03CR) 10Krinkle: "Arr. messed up jsduck inheritance, they can't have the same signature." [core] - 10https://gerrit.wikimedia.org/r/115898 (owner: 10Helder.wiki) [12:56:56] (03PS3) 1001tonythomas: Deprecated window.$j [core] - 10https://gerrit.wikimedia.org/r/116946 [12:57:48] (03CR) 10jenkins-bot: [V: 04-1] Deprecated window.$j [core] - 10https://gerrit.wikimedia.org/r/116946 (owner: 1001tonythomas) [13:03:13] (03PS7) 10Krinkle: mediawiki.api: Emit warning when deprecated callback parameters are used [core] - 10https://gerrit.wikimedia.org/r/115898 (owner: 10Helder.wiki) [13:03:51] (03PS8) 10Krinkle: mediawiki.api: Emit warning when deprecated callback parameters are used [core] - 10https://gerrit.wikimedia.org/r/115898 (owner: 10Helder.wiki) [13:10:37] (03PS9) 10Krinkle: mediawiki.api: Emit warning when deprecated callback parameters are used [core] - 10https://gerrit.wikimedia.org/r/115898 (owner: 10Helder.wiki) [13:10:41] (03CR) 10Krinkle: mediawiki.api: Emit warning when deprecated callback parameters are used (031 comment) [core] - 10https://gerrit.wikimedia.org/r/115898 (owner: 10Helder.wiki) [13:13:02] Krinkle|detached: thanks for https://gerrit.wikimedia.org/r/#/c/115898/9/resources/mediawiki.api/mediawiki.api.parse.js [13:13:07] I was about to ask about that :-) [13:14:02] Or more specifically, about this: https://gerrit.wikimedia.org/r/#/c/115898/4..9/resources/mediawiki.api/mediawiki.api.parse.js,unified [13:14:26] (03CR) 10Physikerwelt: "@Jarry1250: Yes that's right. The maitenance script performs an update of the tests. The idea is that if users discover new bugs, the site" [extensions/Math] - 10https://gerrit.wikimedia.org/r/112353 (owner: 10Physikerwelt) [13:18:18] (03PS4) 1001tonythomas: Deprecated window.$j [core] - 10https://gerrit.wikimedia.org/r/116946 [13:25:48] (03PS1) 10Krinkle: mediawiki.api: Use Promise.then instead of manual Deferred wrapping [core] - 10https://gerrit.wikimedia.org/r/116957 [13:26:00] (03CR) 10Krinkle: [C: 031] mediawiki.api: Emit warning when deprecated callback parameters are used [core] - 10https://gerrit.wikimedia.org/r/115898 (owner: 10Helder.wiki) [13:26:20] (03Draft1) 10Addshore: Clean up ExportDemoTest [core] - 10https://gerrit.wikimedia.org/r/116955 [13:27:02] (03PS2) 10Krinkle: mediawiki.api: Use Promise.then instead of manual Deferred wrapping [core] - 10https://gerrit.wikimedia.org/r/116957 [13:31:19] (03PS1) 10Raimond Spekking: Fix typo [extensions/PageBlock] - 10https://gerrit.wikimedia.org/r/116959 [13:33:37] (03PS2) 10Addshore: Make sure we dont use objects by ref in setMwGlobals [core] - 10https://gerrit.wikimedia.org/r/116958 [13:33:39] (03Restored) 10Hashar: Jenkins job validation (DO NOT SUBMIT) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/86118 (owner: 10Hashar) [13:33:48] (03PS6) 10Hashar: Jenkins job validation (DO NOT SUBMIT) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/86118 [13:34:04] (03CR) 10Manybubbles: "Does that exception come up in the context of the maintenance script that provisioning runs? I don't get the error. Do you have a page t" [vagrant] - 10https://gerrit.wikimedia.org/r/115679 (owner: 10Manybubbles) [13:34:08] (03Draft6) 10Hashar: Jenkins job validation (DO NOT SUBMIT) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/86118 [13:34:26] (03CR) 10Krinkle: Deprecated window.$j (031 comment) [core] - 10https://gerrit.wikimedia.org/r/116946 (owner: 1001tonythomas) [13:35:22] (03PS5) 10Krinkle: Deprecate window.$j [core] - 10https://gerrit.wikimedia.org/r/116946 (owner: 1001tonythomas) [14:04:30] (03PS19) 10Inchikutty: [WIP]UploadWizard:OSM embedding- Geocoding, reverse geocoding [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/112342 [14:05:10] (03CR) 10Hashar: [C: 04-1] "I like this hack. Please add a comment inline for future reference." (031 comment) [core] - 10https://gerrit.wikimedia.org/r/116958 (owner: 10Addshore) [14:06:39] (03PS2) 10Inchikutty: [WIP]UploadWizard:OSM embedding- Geocoding, reverse geocoding [extensions/UploadWizard] (osm) - 10https://gerrit.wikimedia.org/r/116130 [14:09:22] (03PS3) 10Addshore: Make sure we dont use objects by ref in setMwGlobals [core] - 10https://gerrit.wikimedia.org/r/116958 [14:09:32] (03PS9) 10Bartosz Dziewoński: mw.loader.store: Wrap script eval in try/catch [core] - 10https://gerrit.wikimedia.org/r/100930 [14:09:41] (03CR) 10Nikerabbit: mediawiki.api: Use Promise.then instead of manual Deferred wrapping (031 comment) [core] - 10https://gerrit.wikimedia.org/r/116957 (owner: 10Krinkle) [14:19:36] (03CR) 10Hashar: [C: 031] "I guess that would be fine until we have a global ultimately pointing to a database/redis connection :-]" [core] - 10https://gerrit.wikimedia.org/r/116958 (owner: 10Addshore) [14:25:14] (03CR) 10Nikerabbit: Fix HTTPS protocol detection (031 comment) [core] - 10https://gerrit.wikimedia.org/r/116943 (owner: 10Yarda) [14:26:54] (03PS1) 10Phuedx: Icon tweaks [extensions/GettingStarted] - 10https://gerrit.wikimedia.org/r/116969 [14:26:57] (03PS1) 10Phuedx: Icon tweaks [extensions/GuidedTour] - 10https://gerrit.wikimedia.org/r/116970 [14:26:59] (03CR) 10jenkins-bot: [V: 04-1] Icon tweaks [extensions/GettingStarted] - 10https://gerrit.wikimedia.org/r/116969 (owner: 10Phuedx) [14:31:33] (03PS1) 10Physikerwelt: Fix: Correct mode for LaTeXML-SVG [extensions/Math] (dev) - 10https://gerrit.wikimedia.org/r/116971 [14:32:41] (03Draft2) 10Addshore: Use setMwGlobals in ApiEditPageTest [core] - 10https://gerrit.wikimedia.org/r/116956 [14:33:41] (03CR) 10Helder.wiki: mediawiki.api: Use Promise.then instead of manual Deferred wrapping (031 comment) [core] - 10https://gerrit.wikimedia.org/r/116957 (owner: 10Krinkle) [14:34:40] (03CR) 10Krinkle: [C: 032] mw.loader.store: Wrap script eval in try/catch [core] - 10https://gerrit.wikimedia.org/r/100930 (owner: 10Bartosz Dziewoński) [14:36:33] (03PS2) 10Phuedx: Icon tweaks [extensions/GettingStarted] - 10https://gerrit.wikimedia.org/r/116969 [14:38:58] (03CR) 10Physikerwelt: [C: 032] Fix: Correct mode for LaTeXML-SVG [extensions/Math] (dev) - 10https://gerrit.wikimedia.org/r/116971 (owner: 10Physikerwelt) [14:40:26] (03CR) 10Nikerabbit: mediawiki.api: Use Promise.then instead of manual Deferred wrapping (031 comment) [core] - 10https://gerrit.wikimedia.org/r/116957 (owner: 10Krinkle) [14:49:36] (03PS10) 10Krinkle: mw.loader.store: Wrap script eval in try/catch [core] - 10https://gerrit.wikimedia.org/r/100930 (owner: 10Bartosz Dziewoński) [14:49:38] (03CR) 10Krinkle: mw.loader.store: Wrap script eval in try/catch (031 comment) [core] - 10https://gerrit.wikimedia.org/r/100930 (owner: 10Bartosz Dziewoński) [14:50:15] (03CR) 10Krinkle: "Elaborated on comment based on findings locally. Should aid in future debugging. Looks good but would like double check from Bartosz." [core] - 10https://gerrit.wikimedia.org/r/100930 (owner: 10Bartosz Dziewoński) [14:52:28] (03CR) 10Matthias Mullie: [C: 04-1] Cache created objects within the mapper (032 comments) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/113527 (owner: 10EBernhardson) [14:52:53] (03PS2) 10Matthias Mullie: Cache created objects within the mapper [extensions/Flow] - 10https://gerrit.wikimedia.org/r/113527 (owner: 10EBernhardson) [14:55:06] (03CR) 10Matthias Mullie: "I've addresses earlier easy fixed myself. Have 2 more questions." (032 comments) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/113527 (owner: 10EBernhardson) [14:56:19] (03CR) 10Matthias Mullie: Cache created objects within the mapper (031 comment) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/113527 (owner: 10EBernhardson) [14:56:31] (03CR) 10Manybubbles: "We're not ready to enable this voting because tests still fail but this is a good start. For reference, with I893b8f487b3f760fad9962486fd" [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/115193 (owner: 10Manybubbles) [15:01:01] (03CR) 10Chad: [C: 032] Setup jenkins configuration [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/115193 (owner: 10Manybubbles) [15:01:11] (03Merged) 10jenkins-bot: Setup jenkins configuration [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/115193 (owner: 10Manybubbles) [15:13:22] (03Draft2) 10Addshore: Cleanup MediawikiTestCase [core] - 10https://gerrit.wikimedia.org/r/116974 [15:36:16] (03PS1) 10Umherirrender: Add @deprecated hint to $j [core] - 10https://gerrit.wikimedia.org/r/116977 [15:37:06] (03PS2) 10Umherirrender: Add @deprecated hint to $j [core] - 10https://gerrit.wikimedia.org/r/116977 [15:40:54] (03CR) 10jenkins-bot: [V: 04-1] Add @deprecated hint to $j [core] - 10https://gerrit.wikimedia.org/r/116977 (owner: 10Umherirrender) [15:43:51] (03CR) 10Matthias Mullie: [C: 031] fastpath getMulti/gotMulti when using CachingObjectMapper (032 comments) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/113528 (owner: 10EBernhardson) [15:45:43] (03CR) 10Umherirrender: "jsduck error looks unrelated to this change, because line 2355 is not changed." [core] - 10https://gerrit.wikimedia.org/r/116977 (owner: 10Umherirrender) [15:52:00] andre__: You're everywhere :P Just searched for some advice on evolution and... :D [15:52:12] hehe :) [15:52:21] well, that was my open source socialization :) [15:54:45] Despite that I'm on KDE now (and had been on Xfce before), I still use Evolution :) [15:55:16] same here. well, not KDE, but XFCE today :) [15:56:08] Sadly I had to switch because Xfce was messing so hard with Xrandr when I added my 3rd screen :/ [15:57:46] (03CR) 10Krinkle: mediawiki.api: Use Promise.then instead of manual Deferred wrapping (031 comment) [core] - 10https://gerrit.wikimedia.org/r/116957 (owner: 10Krinkle) [15:58:20] (03PS3) 10Krinkle: mediawiki.api: Use Promise.then instead of manual Deferred wrapping [core] - 10https://gerrit.wikimedia.org/r/116957 [16:04:13] Nikerabbit: ^ [16:13:16] (03CR) 10Nikerabbit: [C: 031] mediawiki.api: Use Promise.then instead of manual Deferred wrapping [core] - 10https://gerrit.wikimedia.org/r/116957 (owner: 10Krinkle) [16:13:20] Krinkle: I'm sold [16:19:00] Hi -- who should I ask to get an additional namespace added on test.wikipedia? [16:19:07] *specifically Draft: [16:20:16] theopolisme: Get community consensus and open a bug [16:23:16] (03CR) 10Bartosz Dziewoński: "Hmm, I think we haven't been consistently adding @deprecated for deprecated properties/functions in JS…" [core] - 10https://gerrit.wikimedia.org/r/116977 (owner: 10Umherirrender) [16:23:52] hoo: testwiki has a community? :P [16:24:13] oh, overlooked that [16:24:24] I guess a bug is enough then [16:33:57] Can I ask my question about the MediaWiki api here? [16:38:51] (03CR) 10Swalling: [C: 031] "This is good to go I think. Tested and working in everything except IE7, due an unrelated bug." [extensions/GettingStarted] - 10https://gerrit.wikimedia.org/r/115176 (owner: 10Phuedx) [16:41:00] (03PS1) 10Anomie: mw.language: Fix exceptions and add tests [extensions/Scribunto] - 10https://gerrit.wikimedia.org/r/116984 [16:41:10] (03PS1) 10Matthias Mullie: Reads should be done against DB_SLAVE [extensions/Flow] - 10https://gerrit.wikimedia.org/r/116985 [16:42:14] (03CR) 10Matthias Mullie: [C: 04-1] Use single query for multiple revision lookups by pk (036 comments) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/115416 (owner: 10EBernhardson) [16:45:29] (03CR) 10Matthias Mullie: [C: 031] "LGTM - merge after code freeze" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/115564 (owner: 10EBernhardson) [16:51:37] (03PS2) 10Amire80: Add a link to Special:WhatLinksHere in deleting-backlinks-warning [core] - 10https://gerrit.wikimedia.org/r/114713 [16:52:19] (03CR) 10Amire80: "Rebased. There were two +1s on previous patches ;)" [core] - 10https://gerrit.wikimedia.org/r/114713 (owner: 10Amire80) [16:52:53] (03PS2) 10Amire80: Rephrase ep-undelete-course-no-rights [extensions/EducationProgram] - 10https://gerrit.wikimedia.org/r/114449 [17:14:10] (03PS1) 10Nik: Adjusted publisher library to coding guidelines. [extensions/PubSubHubbub] - 10https://gerrit.wikimedia.org/r/116989 [17:14:27] (03CR) 10Matthias Mullie: [C: 031] "I'm all in favor of dropping definitions." (033 comments) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/115576 (owner: 10EBernhardson) [17:17:55] (03CR) 10Matthias Mullie: [C: 031] "LGTM - to be merged after code freeze" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/112846 (owner: 10EBernhardson) [17:22:31] csteipp: I'm not sure how to go about separating the login issues. They all seem to have appeared more or less simultaneously yesterday afternoon. [17:23:16] chrismcmahon: Do you know around what time? [17:24:52] (03CR) 10Matthias Mullie: [C: 031] "Nice change. Just 1 nitpick; looks good to go then" (031 comment) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/115861 (owner: 10EBernhardson) [17:29:25] (03PS3) 10BryanDavis: Add base class for creating CLI wrappers [tools/scap] - 10https://gerrit.wikimedia.org/r/116456 [17:29:32] (03PS3) 10BryanDavis: Update sphinx documentation [tools/scap] - 10https://gerrit.wikimedia.org/r/116457 [17:29:38] (03PS2) 10BryanDavis: Convert sync_common to cli.Application class [tools/scap] - 10https://gerrit.wikimedia.org/r/116693 [17:29:44] (03PS2) 10BryanDavis: Convert scap to cil.Application class [tools/scap] - 10https://gerrit.wikimedia.org/r/116694 [17:29:48] (03PS1) 10Cscott: Ignore height as well as width for framed images. [core] - 10https://gerrit.wikimedia.org/r/116995 [17:29:51] (03PS3) 10BryanDavis: Implement multiversion/refreshWikiversionsCDB in python [tools/scap] - 10https://gerrit.wikimedia.org/r/116906 [17:30:40] (03CR) 10MarkTraceur: [C: 031] "Marking as +1 so I don't have to come back later and review again." [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/50953 (owner: 10Nischayn22) [17:32:32] (03PS3) 10BryanDavis: Convert sync-wikiversions to python [tools/scap] - 10https://gerrit.wikimedia.org/r/116918 [17:33:05] (03CR) 10BryanDavis: "Patch set 3 was a manual rebase" [tools/scap] - 10https://gerrit.wikimedia.org/r/116918 (owner: 10BryanDavis) [17:33:16] csteipp: best I have is yesterday morning. The overnight builds (SF time) on both beta labs and test2wiki Mar 4 were fine, the lunchtime/afternoon builds both showed the "No active login attempt... " issue. [17:33:56] (03PS1) 10AzaToth: grrrit: Allow filtering based on branches [labs/tools/grrrit] - 10https://gerrit.wikimedia.org/r/116996 [17:34:02] (03PS1) 10AzaToth: grrrit: Pass betacluster messages to QA [labs/tools/grrrit] - 10https://gerrit.wikimedia.org/r/116997 [17:34:07] (03CR) 10Matthias Mullie: "Hooks are ok - some minor remarks about CSS-related stuff." (033 comments) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/115552 (owner: 10Wctaiwan) [17:35:02] (03CR) 10Ori.livneh: "PS1 lgtm too" [extensions/EventLogging] - 10https://gerrit.wikimedia.org/r/116517 (owner: 10Anomie) [17:38:46] (03PS3) 10MarkTraceur: Replacing deprecated $j.browser with $.client [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/74425 (owner: 10Rillke) [17:38:54] (03CR) 10jenkins-bot: [V: 04-1] Replacing deprecated $j.browser with $.client [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/74425 (owner: 10Rillke) [17:38:57] chrismcmahon: Thanks, I'll try and track down what happened during those. So something like Midnight-noon yesterday PST? [17:40:12] csteipp: roughly, yeah. [17:40:31] Well THAT doesn't make any bloody sense [17:41:00] rdwrer: uploadwizardtutorial or whatever keeps logging events with schema rev -1 [17:41:04] (03CR) 10Hashar: [C: 031] "Nice one. I love how any branch named 'betacluster' will end up in qa channel. Thank you very much!" [labs/tools/grrrit] - 10https://gerrit.wikimedia.org/r/116997 (owner: 10AzaToth) [17:41:19] ori: That's a problem [17:41:33] i'm glad you agree [17:41:33] (03CR) 10Matthias Mullie: Fix the maintenance script for updating *_user_wiki (032 comments) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/116223 (owner: 10Bsitu) [17:41:51] Hah. [17:42:01] ori: I can look into it but it's not really scheduled [17:42:11] I just took a small break to look at the worst offenders in my CR backlog [17:42:57] (03CR) 10Matthias Mullie: [C: 031] "LGTM - merge after code freeze" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/116226 (owner: 10Bsitu) [17:43:09] (03CR) 10Hashar: "I would make :.* the default whenever it is not set. That would make the conf more readable. But some people prefer settings to be set " (031 comment) [labs/tools/grrrit] - 10https://gerrit.wikimedia.org/r/116996 (owner: 10AzaToth) [17:46:04] (03PS10) 10Krinkle: [WIP] Set up node-jscs via Grunt (and pass it) [core] - 10https://gerrit.wikimedia.org/r/111963 [17:46:17] (03CR) 10AzaToth: "Non-trivial to do that (for me at least)" (031 comment) [labs/tools/grrrit] - 10https://gerrit.wikimedia.org/r/116996 (owner: 10AzaToth) [17:46:23] (03CR) 10Krinkle: [C: 04-1] "Pending Jenkins setup." [core] - 10https://gerrit.wikimedia.org/r/111963 (owner: 10Krinkle) [17:46:35] (03PS1) 10Andrew Bogott: Make special/SpecialNovaProxy.php region-aware. [extensions/OpenStackManager] - 10https://gerrit.wikimedia.org/r/116998 [17:47:01] ^d: Any thoughts on why I might have to refresh Gerrit pages a few times before they load right? [17:47:25] <^d> Offhand, no. [17:47:25] (03CR) 10Andrew Bogott: [V: 04-1] "Doesn't work!" [extensions/OpenStackManager] - 10https://gerrit.wikimedia.org/r/116998 (owner: 10Andrew Bogott) [17:47:28] Abrowser (Firefox) 19 on Trisquel GNU/Linux [17:47:41] I know I had to switch from fx last time I had issues... [17:49:11] (03CR) 10Krinkle: grrrit: Allow filtering based on branches (031 comment) [labs/tools/grrrit] - 10https://gerrit.wikimedia.org/r/116996 (owner: 10AzaToth) [17:49:40] (03CR) 10Anomie: [C: 04-1] "This isn't actually going to solve the bug." [core] - 10https://gerrit.wikimedia.org/r/116872 (owner: 10MaxSem) [17:52:52] (03CR) 10Matthias Mullie: [C: 04-1] "-1'ed until I've added rev_user_wiki to the index" (031 comment) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/116115 (owner: 10Matthias Mullie) [17:57:55] (03PS11) 10Krinkle: [WIP] Set up node-jscs via Grunt (and pass it) [core] - 10https://gerrit.wikimedia.org/r/111963 [17:58:17] (03CR) 10Krinkle: "Fixed another jscs violation added in another change since last rebase" [core] - 10https://gerrit.wikimedia.org/r/111963 (owner: 10Krinkle) [18:00:52] (03CR) 10Krinkle: "Jenkins build: https://integration.wikimedia.org/ci/job/mediawiki-core-npm/9/" [core] - 10https://gerrit.wikimedia.org/r/111963 (owner: 10Krinkle) [18:06:55] (03CR) 10Anomie: "See the bug for more discussion. While this patch as it is now could be salvaged, it won't solve the bug at hand and has no use case at th" (031 comment) [core] - 10https://gerrit.wikimedia.org/r/116872 (owner: 10MaxSem) [18:09:07] (03PS2) 10Nemo bis: Added fiji hindi localisation to example.i18n.php [test/mediawiki/extensions/examples] - 10https://gerrit.wikimedia.org/r/104377 (owner: 10AalekhN) [18:11:57] (03PS4) 10Anomie: Reformat AUTHORS as wikitext [extensions/EventLogging] - 10https://gerrit.wikimedia.org/r/116517 [18:12:16] (03CR) 10Anomie: "PS4: Restore PS1" [extensions/EventLogging] - 10https://gerrit.wikimedia.org/r/116517 (owner: 10Anomie) [18:13:35] (03CR) 10Rillke: "Thanks for re-basing. What is Jenkins complaining about? This patch has *nothing* to do with "ApiFlickrBlacklistTest" nor does it affect i" [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/74425 (owner: 10Rillke) [18:13:39] (03PS4) 10Krinkle: Various clean up and refactor to make mediawiki-core-npm faster [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/116125 [18:14:23] (03CR) 10Nikerabbit: i18n: Add PLURAL/GENDER support to revreview-reject-summary-* (033 comments) [extensions/FlaggedRevs] - 10https://gerrit.wikimedia.org/r/103119 (owner: 10MegaAlex) [18:15:20] (03CR) 10MarkTraceur: "Hell if I know, I was about to merge this. But my local UW is also experiencing some issues, don't know why really. Probably unrelated to " [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/74425 (owner: 10Rillke) [18:15:46] (03PS3) 10Umherirrender: Add @deprecated hint to $j [core] - 10https://gerrit.wikimedia.org/r/116977 [18:16:37] (03CR) 10Umherirrender: "Patch Set 3: Changed comment style" [core] - 10https://gerrit.wikimedia.org/r/116977 (owner: 10Umherirrender) [18:18:27] (03CR) 10Ragesoss: [C: 04-1] "Breaking it into two statements is good. But the change to the second part doesn't sound right: "You don't have *a* permission to restore " [extensions/EducationProgram] - 10https://gerrit.wikimedia.org/r/114449 (owner: 10Amire80) [18:19:26] (03CR) 10Nemo bis: "thibaultmarin, it's been over a year and you're in https://gerrit.wikimedia.org/r/#/admin/groups/400,members , so I suggest you to just gi" [extensions/PGFTikZ] - 10https://gerrit.wikimedia.org/r/38487 (owner: 10thibaultmarin) [18:20:15] rdwrer: There's various modules still undocumented it seems. Just ran into one now: jquery.client [18:20:18] (not upstream) [18:20:29] Urgh [18:21:58] (03CR) 10Nemo bis: "Thanks for filing upstream as https://sourceforge.net/p/geshi/bugs/226/ , please click the "abandon" button so that it's clear this doens'" [extensions/SyntaxHighlight_GeSHi] - 10https://gerrit.wikimedia.org/r/57065 (owner: 10Johannes Weberhofer) [18:22:06] (03CR) 10Krinkle: Replacing deprecated $j.browser with $.client (031 comment) [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/74425 (owner: 10Rillke) [18:22:23] Nikerabbit: or you could abandon it yourself [18:24:18] (03PS1) 10Krinkle: qunit: Use sinon sandbox for mediawiki.api.parse.test [core] - 10https://gerrit.wikimedia.org/r/117005 [18:24:27] Nemo_bis: what? [18:24:39] Nikerabbit: https://gerrit.wikimedia.org/r/57065 [18:26:38] ori: just wondering, these changes will have no effect on ULS geo location, right? [18:26:58] (03Abandoned) 10Krinkle: Fix API QUnit tests that are not aware of wgDebugToolbar [core] - 10https://gerrit.wikimedia.org/r/110894 (owner: 10Alex Monk) [18:27:59] (03CR) 10Anomie: [C: 031] Show parameter deprecation on Special:ApiSandbox [extensions/ApiSandbox] - 10https://gerrit.wikimedia.org/r/116449 (owner: 10Gerrit Patch Uploader) [18:28:35] (03CR) 10Bartosz Dziewoński: [C: 031] "Thanks, you're right and the changes look okay." [core] - 10https://gerrit.wikimedia.org/r/100930 (owner: 10Bartosz Dziewoński) [18:30:49] Nikerabbit: nope [18:30:57] there's still a Geo object with the data [18:31:30] ori: ok [18:31:38] ori: and no changes expected to that, is there? [18:31:51] (03PS4) 10Bartosz Dziewoński: Make sure we don't use objects by ref in setMwGlobals [core] - 10https://gerrit.wikimedia.org/r/116958 (owner: 10Addshore) [18:31:55] country, city, lat, lon are the same [18:32:12] with the exception that nonalpha characters in city names are replaced with underscores [18:32:16] but you are not using city, iirc [18:32:24] (03CR) 10Bartosz Dziewoński: "Fixed some typos." [core] - 10https://gerrit.wikimedia.org/r/116958 (owner: 10Addshore) [18:34:28] (03CR) 10Alex Monk: Allow multiple prop/list/meta params for action=query (032 comments) [extensions/ApiSandbox] - 10https://gerrit.wikimedia.org/r/112307 (owner: 10Alex Monk) [18:35:18] (03PS10) 10Alex Monk: Allow multiple prop/list/meta params for action=query [extensions/ApiSandbox] - 10https://gerrit.wikimedia.org/r/112307 [18:35:36] csteipp, hi, are you at the office? do you see RobLa? [18:35:54] James_F, hi, are you at the office? do you see RobLa? [18:36:12] qgil: Yes and no. [18:36:33] qgil: Yes, and Robla is on 6th [18:36:52] (03CR) 10Jforrester: [C: 032] "Per Ori." [extensions/EventLogging] - 10https://gerrit.wikimedia.org/r/116517 (owner: 10Anomie) [18:37:20] (03Merged) 10jenkins-bot: Reformat AUTHORS as wikitext [extensions/EventLogging] - 10https://gerrit.wikimedia.org/r/116517 (owner: 10Anomie) [18:37:24] csteipp, ok, we are supposed to have our weekly 1:1. I had to stay in Mountain View today as well. I'm available online. [18:37:35] csteipp, I'll send him an email. Thanks! [18:37:53] (03CR) 10Krinkle: "(Removing from dashboard, looks good jsduck wise)" [extensions/GuidedTour] - 10https://gerrit.wikimedia.org/r/86057 (owner: 10Mattflaschen) [18:40:52] (03CR) 10Bartosz Dziewoński: [C: 04-1] "That rebase didn't go very well, the message key is now duplicated." [core] - 10https://gerrit.wikimedia.org/r/114713 (owner: 10Amire80) [18:42:44] (03PS4) 10Rillke: Replacing deprecated $j.browser with $.client [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/74425 [18:44:13] MatmaRex: cheers for the typo fixes :P [18:44:22] addshore: my pleasure [18:46:07] (03PS3) 10Bartosz Dziewoński: Add a link to Special:WhatLinksHere in deleting-backlinks-warning [core] - 10https://gerrit.wikimedia.org/r/114713 (owner: 10Amire80) [18:47:06] (03CR) 10Rillke: "Couldn't test this yet because I had to re-install my dev VM after a botched update of the OS." [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/74425 (owner: 10Rillke) [18:49:51] (03CR) 10Bartosz Dziewoński: [C: 031] "Fixed." [core] - 10https://gerrit.wikimedia.org/r/114713 (owner: 10Amire80) [18:52:29] (03CR) 10Mwalker: [C: 032] "Cool. In the event that we start having redis/db connections in globals that need to be tested I see that we have three approaches:" [core] - 10https://gerrit.wikimedia.org/r/116958 (owner: 10Addshore) [18:52:39] (03PS1) 10Chad: Up the size from the default of 10 to 5000 since we really want all [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/117009 [18:53:00] (03PS2) 10Chad: Up the size from the default of 10 to 5000 since we really want all [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/117009 [18:53:53] (03CR) 10Addshore: "__sleep and __wakeup seems like the best of those 3 choices!" [core] - 10https://gerrit.wikimedia.org/r/116958 (owner: 10Addshore) [18:53:59] cheers mwalker :) [18:54:03] (03PS1) 10Krinkle: Include all of /resources/mediawiki/* in jsduck index [core] - 10https://gerrit.wikimedia.org/r/117010 [18:54:09] (03CR) 10Mwalker: [C: 032] "Pretty simple; but a good base to build on. Thanks." [core] - 10https://gerrit.wikimedia.org/r/115877 (owner: 10Addshore) [18:54:18] rdwrer: Whenever https://gerrit.wikimedia.org/r/#/c/117010/ :) [18:55:11] (03CR) 10Manybubbles: [C: 032] Up the size from the default of 10 to 5000 since we really want all (031 comment) [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/117009 (owner: 10Chad) [18:55:21] rdwrer: If you're not working on a patch already, you could do a similar one for mediawiki.action/* and mediawiki.page/*, or for a jquery plugin [18:55:52] Krinkle: I'm not - I may not today, got stuff to do [18:55:56] (03PS3) 10Addshore: Cleanup MediawikiTestCase [core] - 10https://gerrit.wikimedia.org/r/116974 [18:56:01] rdwrer: k, no worries [18:56:14] (03CR) 10Bencmq: "Hi Matthias," (033 comments) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/115552 (owner: 10Wctaiwan) [18:56:57] (03PS3) 10Addshore: Use setMwGlobals in ApiEditPageTest [core] - 10https://gerrit.wikimedia.org/r/116956 [18:58:32] (03Merged) 10jenkins-bot: Up the size from the default of 10 to 5000 since we really want all [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/117009 (owner: 10Chad) [18:58:34] (03CR) 10Krinkle: Use setMwGlobals in ApiEditPageTest (031 comment) [core] - 10https://gerrit.wikimedia.org/r/116956 (owner: 10Addshore) [18:59:30] (03PS13) 10Nemo bis: Add link to PD help translatable pages from sidebar [core] - 10https://gerrit.wikimedia.org/r/83221 [19:00:30] (03CR) 10Addshore: Use setMwGlobals in ApiEditPageTest (031 comment) [core] - 10https://gerrit.wikimedia.org/r/116956 (owner: 10Addshore) [19:01:32] (03CR) 10Nemo bis: "PS13 rebase" [core] - 10https://gerrit.wikimedia.org/r/83221 (owner: 10Nemo bis) [19:02:00] (03CR) 10jenkins-bot: [V: 04-1] Add link to PD help translatable pages from sidebar [core] - 10https://gerrit.wikimedia.org/r/83221 (owner: 10Nemo bis) [19:02:44] (03PS1) 10BryanDavis: Use realm specific filename with mwversionsinuse [tools/scap] - 10https://gerrit.wikimedia.org/r/117014 [19:03:03] (03CR) 10Krinkle: [C: 04-1] "Thanks! Looks good, a few minor points." (033 comments) [core] - 10https://gerrit.wikimedia.org/r/116974 (owner: 10Addshore) [19:05:59] Bartosz Dziewoński here? [19:06:52] Technical_13: reporting in [19:06:56] MatmaRex: http://en.wikipedia.org/wiki/Wikipedia:Village_pump_%28technical%29#Bug_report:_Search_settings_in_Preferences [19:07:11] Search "all" broken... [19:09:37] fun, right? :/ [19:10:28] (03PS4) 10Addshore: Cleanup MediawikiTestCase [core] - 10https://gerrit.wikimedia.org/r/116974 [19:10:37] Technical_13: that patch isn't deployed on en.wp yet. [19:10:55] https://gerrit.wikimedia.org/r/#/c/110610/ , click "Included in" – only master amd 1.23wmf16 [19:10:56] ^._ [19:10:57] (03CR) 10Addshore: Cleanup MediawikiTestCase (033 comments) [core] - 10https://gerrit.wikimedia.org/r/116974 (owner: 10Addshore) [19:11:02] en.wp is at wmf15 https://en.wikipedia.org/wiki/Special:Version [19:11:23] (03PS2) 10Krinkle: Include all of /resources/mediawiki/* in jsduck index [core] - 10https://gerrit.wikimedia.org/r/117010 [19:11:30] but i can reproduce the behavior, yeah, this is weird [19:12:25] Says they got it on commons... MediaWiki 1.23wmf16 (75b305c) [19:12:47] yes, and on enwp... [19:13:08] perhaps the patch should be held off until this is figured out? [19:14:15] Technical_13: i can reproduce on en.wp :) really doesn't look related [19:15:01] (03PS1) 10AalekhN: Commit files needed to create VideoJsPlayer [extensions/VideoJsPlayer] - 10https://gerrit.wikimedia.org/r/117019 [19:15:03] Okay. I'll let you submit a ticket on BZ then, and note that wasn't the cause on the enwp discussion. I really have no time to go digging right now. [19:15:09] :/ [19:15:47] D: [19:20:25] (03CR) 10Alex Monk: [C: 032] Show parameter deprecation on Special:ApiSandbox [extensions/ApiSandbox] - 10https://gerrit.wikimedia.org/r/116449 (owner: 10Gerrit Patch Uploader) [19:20:27] (03Merged) 10jenkins-bot: Show parameter deprecation on Special:ApiSandbox [extensions/ApiSandbox] - 10https://gerrit.wikimedia.org/r/116449 (owner: 10Gerrit Patch Uploader) [19:31:13] (03CR) 10Bartosz Dziewoński: [C: 032] mediawiki.api: Emit warning when deprecated callback parameters are used [core] - 10https://gerrit.wikimedia.org/r/115898 (owner: 10Helder.wiki) [19:35:05] (03Merged) 10jenkins-bot: mediawiki.api: Emit warning when deprecated callback parameters are used [core] - 10https://gerrit.wikimedia.org/r/115898 (owner: 10Helder.wiki) [19:38:34] (03PS1) 10Umherirrender: LocalSettings.php must be readable by the server [core] - 10https://gerrit.wikimedia.org/r/117022 [19:41:09] csteipp: manual repro: https://bugzilla.wikimedia.org/show_bug.cgi?id=62244 [19:41:15] (03CR) 10Bartosz Dziewoński: [C: 032] Add @deprecated hint to $j [core] - 10https://gerrit.wikimedia.org/r/116977 (owner: 10Umherirrender) [19:42:49] chrismcmahon: yeah, in labs it's 100%. I'm not able to reproduce either of your prod issues. [19:44:24] csteipp: aye, no manual repro on test2 [19:44:27] (03PS1) 10Bsitu: Fix a typo in class instance variable [extensions/Flow] - 10https://gerrit.wikimedia.org/r/117023 [19:44:34] * chrismcmahon revisits that part [19:44:54] (03Merged) 10jenkins-bot: Add @deprecated hint to $j [core] - 10https://gerrit.wikimedia.org/r/116977 (owner: 10Umherirrender) [19:46:35] (03CR) 10Hashar: "Mwalker serialize() apparently calls __sleep() and the Database class throw an exception there. Might be a safe belt." [core] - 10https://gerrit.wikimedia.org/r/116958 (owner: 10Addshore) [19:50:13] (03CR) 10Hashar: "Well done Nik, thanks a lot." [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/115193 (owner: 10Manybubbles) [19:51:46] (03PS1) 10Addshore: Catch Serialization Exception in MediaWikiTestCase [core] - 10https://gerrit.wikimedia.org/r/117026 [19:51:48] (03CR) 10Umherirrender: [C: 031] Add a link to Special:WhatLinksHere in deleting-backlinks-warning [core] - 10https://gerrit.wikimedia.org/r/114713 (owner: 10Amire80) [19:52:27] (03PS1) 10AalekhN: Correct parameter passed checkImages.php [core] - 10https://gerrit.wikimedia.org/r/117027 [19:54:52] (03PS1) 10Cscott: Sync up with Parsoid parserTests. [core] - 10https://gerrit.wikimedia.org/r/117028 [19:56:45] (03CR) 10Addshore: "We just ran into an issue once this was merged on our Wikibase tests." [core] - 10https://gerrit.wikimedia.org/r/116958 (owner: 10Addshore) [19:58:34] (03CR) 10Hoo man: [C: 032] Catch Serialization Exception in MediaWikiTestCase [core] - 10https://gerrit.wikimedia.org/r/117026 (owner: 10Addshore) [19:59:05] addshore: although you missed a white space after try [19:59:08] :D [19:59:12] (03CR) 10Subramanya Sastry: [C: 032] Sync up with Parsoid parserTests. [core] - 10https://gerrit.wikimedia.org/r/117028 (owner: 10Cscott) [20:02:09] (03Merged) 10jenkins-bot: Catch Serialization Exception in MediaWikiTestCase [core] - 10https://gerrit.wikimedia.org/r/117026 (owner: 10Addshore) [20:03:03] (03Merged) 10jenkins-bot: Sync up with Parsoid parserTests. [core] - 10https://gerrit.wikimedia.org/r/117028 (owner: 10Cscott) [20:03:37] (03CR) 10Alex Monk: [C: 032] Handle API module with no parameters [extensions/ApiSandbox] - 10https://gerrit.wikimedia.org/r/114916 (owner: 10Spage) [20:05:14] (03CR) 10jenkins-bot: [V: 04-1] Handle API module with no parameters [extensions/ApiSandbox] - 10https://gerrit.wikimedia.org/r/114916 (owner: 10Spage) [20:05:19] cheers hoo|away :P [20:08:10] superm401: UI Hack day starting? WMFSF room just freed up [20:08:41] spagewmf, yep, I'm in the room. [20:08:48] There's a link in the calendar. [20:09:12] (03PS3) 10Alex Monk: Handle API module with no parameters [extensions/ApiSandbox] - 10https://gerrit.wikimedia.org/r/114916 (owner: 10Spage) [20:10:38] What does "An error has occurred while searching: Pool queue is full" when requesting https://en.wikipedia.org/w/index.php?title=Special%3ASearch&profile=advanced&search=Swazimac&fulltext=Search&ns0=1&redirs=1&profile=advanced ??? [20:11:01] * Technical_13 thinks he should check operations.... [20:11:45] (03CR) 10Alex Monk: [C: 032] "(latest PS was just a rebase)" [extensions/ApiSandbox] - 10https://gerrit.wikimedia.org/r/114916 (owner: 10Spage) [20:11:47] (03Merged) 10jenkins-bot: Handle API module with no parameters [extensions/ApiSandbox] - 10https://gerrit.wikimedia.org/r/114916 (owner: 10Spage) [20:14:42] (03CR) 10Hashar: "That was fast!" (036 comments) [tools/scap] - 10https://gerrit.wikimedia.org/r/117014 (owner: 10BryanDavis) [20:15:27] (03PS1) 10EBernhardson: Move Collection classes into collection namespace [extensions/Flow] - 10https://gerrit.wikimedia.org/r/117031 [20:15:30] (03PS1) 10EBernhardson: Update annotations in RevisionView [extensions/Flow] - 10https://gerrit.wikimedia.org/r/117032 [20:15:36] (03CR) 10jenkins-bot: [V: 04-1] Move Collection classes into collection namespace [extensions/Flow] - 10https://gerrit.wikimedia.org/r/117031 (owner: 10EBernhardson) [20:15:40] (03CR) 10jenkins-bot: [V: 04-1] Update annotations in RevisionView [extensions/Flow] - 10https://gerrit.wikimedia.org/r/117032 (owner: 10EBernhardson) [20:20:41] (03PS1) 10Addshore: Introduce stashMwGlobals method to MediaWikiTestCase [core] - 10https://gerrit.wikimedia.org/r/117036 [20:21:26] (03PS11) 10Alex Monk: Allow multiple prop/list/meta params for action=query [extensions/ApiSandbox] - 10https://gerrit.wikimedia.org/r/112307 [20:22:34] (03CR) 10Alex Monk: "rebase" [extensions/ApiSandbox] - 10https://gerrit.wikimedia.org/r/112307 (owner: 10Alex Monk) [20:25:54] (03PS12) 10Mattflaschen: [WIP] Add mw-ui-button classes to various buttons [core] - 10https://gerrit.wikimedia.org/r/52169 [20:26:13] (03CR) 10Spage: [C: 032] "PS 5 is just a rebase, concurring with Kaldari's +2." [core] - 10https://gerrit.wikimedia.org/r/114085 (owner: 10Mattflaschen) [20:26:15] (03PS1) 10Anomie: HTMLForm: Clean up 0 handling [core] - 10https://gerrit.wikimedia.org/r/117038 [20:28:06] (03PS2) 10BryanDavis: Use realm specific filename with mwversionsinuse [tools/scap] - 10https://gerrit.wikimedia.org/r/117014 [20:28:23] (03CR) 10Parent5446: ":/ Needs rebase again" [core] - 10https://gerrit.wikimedia.org/r/114400 (owner: 10Bartosz Dziewoński) [20:28:32] i've had a change in gerrit for Extension:InputBox awaiting review for a few months now. anyone willing to take a look? https://gerrit.wikimedia.org/r/#/c/97559/ [20:28:41] (03PS1) 10Addshore: Also stash unset globals in MediaWikiTestCase [core] - 10https://gerrit.wikimedia.org/r/117039 [20:29:51] (03PS5) 10Addshore: Cleanup MediawikiTestCase [core] - 10https://gerrit.wikimedia.org/r/116974 [20:30:35] hi jackmcbarn [20:31:18] btw you have already read https://www.mediawiki.org/wiki/Git/Code_review/Getting_reviews ? [20:31:40] sumanah: yes [20:31:52] most of my changes get reviewed in a few days or weeks [20:31:56] this one has sat since november [20:31:58] ok. hoo|away ^ if you have a chance to take a look at this, that would be great [20:32:33] that sounds frustrating [20:32:37] (jack) [20:32:55] (03Abandoned) 10Mattflaschen: Add appropriate mw-ui button styles to Save, Preview, Show changes and cancel buttons. [core] - 10https://gerrit.wikimedia.org/r/116783 (owner: 10Deepali) [20:33:11] hope you get the merge you want soon :) [20:34:38] (03PS13) 10Mattflaschen: [WIP] Add mw-ui-button classes to various buttons [core] - 10https://gerrit.wikimedia.org/r/52169 [20:34:43] (03PS1) 10Umherirrender: Remove wildcard actions from list=logevents&leaction= [core] - 10https://gerrit.wikimedia.org/r/117041 [20:35:48] (03CR) 10Mattflaschen: "Rebased onto the EditPage one." [core] - 10https://gerrit.wikimedia.org/r/52169 (owner: 10Mattflaschen) [20:38:48] (03CR) 10BryanDavis: "One comment inline." (031 comment) [core] - 10https://gerrit.wikimedia.org/r/117038 (owner: 10Anomie) [20:39:44] (03CR) 10Anomie: "I lean towards -1 on this because it makes it slightly less bad but doesn't really make it good. But not actually -1ing because it does ma" [core] - 10https://gerrit.wikimedia.org/r/117041 (owner: 10Umherirrender) [20:40:55] (03PS2) 10Anomie: HTMLForm: Clean up 0 handling [core] - 10https://gerrit.wikimedia.org/r/117038 [20:42:42] 20 min till RFC review https://www.mediawiki.org/wiki/Architecture_meetings/RFC_review_2014-03-05 in #wikimedia-office [20:42:58] (03CR) 10Umherirrender: "Yes, it only removes unusable entries from the documentation, because I did not know a way to get the real list of actions behind the wild" [core] - 10https://gerrit.wikimedia.org/r/117041 (owner: 10Umherirrender) [20:43:28] (03PS1) 10Addshore: Add basic tests for MediaWikiTestCase [core] - 10https://gerrit.wikimedia.org/r/117042 [20:44:04] (03CR) 10Addshore: "Tests for the methods poked here are added in a follow up at https://gerrit.wikimedia.org/r/#/c/117042/" [core] - 10https://gerrit.wikimedia.org/r/117039 (owner: 10Addshore) [20:44:09] (03CR) 10Addshore: "Tests for the methods poked here are added in a follow up at https://gerrit.wikimedia.org/r/#/c/117042/" [core] - 10https://gerrit.wikimedia.org/r/117036 (owner: 10Addshore) [20:46:46] (03CR) 10Anomie: "We might have to resort to "SELECT DISTINCT log_type, log_action FROM logging WHERE log_type IN (...the wildcard ones...)". Unfortunately " [core] - 10https://gerrit.wikimedia.org/r/117041 (owner: 10Umherirrender) [20:46:48] (03CR) 10BryanDavis: [C: 031] "Looks ok to me technically. I'm not sure how to test." [core] - 10https://gerrit.wikimedia.org/r/117038 (owner: 10Anomie) [20:48:32] spagewmf, seems my Internet econnection is acting up. [20:51:14] (03CR) 10BryanDavis: Use realm specific filename with mwversionsinuse (033 comments) [tools/scap] - 10https://gerrit.wikimedia.org/r/117014 (owner: 10BryanDavis) [20:52:26] (03CR) 10Anomie: "Absent that, I just about say we should keep the wildcards but explain them in the documentation, and adjust the module to actually treat " [core] - 10https://gerrit.wikimedia.org/r/117041 (owner: 10Umherirrender) [20:55:25] (03CR) 10Manybubbles: [C: 031] "My only comment is minor and certainly isn't an objection." (031 comment) [core] - 10https://gerrit.wikimedia.org/r/106517 (owner: 10Daniel Kinzler) [20:57:08] (03CR) 10Daniel Kinzler: "re @Manybubbles" (031 comment) [core] - 10https://gerrit.wikimedia.org/r/106517 (owner: 10Daniel Kinzler) [20:58:52] (03PS2) 10EBernhardson: Update annotations in RevisionView [extensions/Flow] - 10https://gerrit.wikimedia.org/r/117032 [20:58:55] (03PS2) 10EBernhardson: Move Collection classes into collection namespace [extensions/Flow] - 10https://gerrit.wikimedia.org/r/117031 [20:59:00] (03CR) 10BryanDavis: [C: 032] "Anomie tested locally and will poke beta at bit after merge" [core] - 10https://gerrit.wikimedia.org/r/117038 (owner: 10Anomie) [21:02:04] (03CR) 10Mattflaschen: [C: 04-2] "Let's wait until ContentTranslation's change is merged for simplicity." [core] - 10https://gerrit.wikimedia.org/r/114080 (owner: 10Mattflaschen) [21:02:24] RFC review https://www.mediawiki.org/wiki/Architecture_meetings/RFC_review_2014-03-05 in #wikimedia-office now on Password strength - in 30 min, on TitleValue [21:02:35] (03Merged) 10jenkins-bot: HTMLForm: Clean up 0 handling [core] - 10https://gerrit.wikimedia.org/r/117038 (owner: 10Anomie) [21:03:55] (03PS1) 10Chad: Use actual percentage difference formula [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/117043 [21:04:20] (03PS1) 10Hashar: Parsoid: uses ZUUL_COMMIT as a git refspec to build [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/117045 [21:04:52] (03PS2) 10Hashar: Parsoid: uses ZUUL_COMMIT as a git refspec to build [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/117045 [21:05:59] (03CR) 10Anomie: Introducing TitleValue (031 comment) [core] - 10https://gerrit.wikimedia.org/r/106517 (owner: 10Daniel Kinzler) [21:06:10] (03PS3) 10Hashar: Parsoid: uses ZUUL_COMMIT as a git refspec to build [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/117045 [21:09:38] (03CR) 10Hashar: "I have refreshed all the jobs. That should improve things a bit." [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/117045 (owner: 10Hashar) [21:12:55] (03CR) 10Bartosz Dziewoński: mediawiki.api: Use Promise.then instead of manual Deferred wrapping (031 comment) [core] - 10https://gerrit.wikimedia.org/r/116957 (owner: 10Krinkle) [21:16:06] (03CR) 10Daniel Kinzler: Introducing TitleValue (031 comment) [core] - 10https://gerrit.wikimedia.org/r/106517 (owner: 10Daniel Kinzler) [21:16:12] (03CR) 10Bartosz Dziewoński: "PSA: With http://github.com/matmarex/mediawikireleasenotes-driver, fixing release notes merge conflicts is as simple as `git pull && git r" [core] - 10https://gerrit.wikimedia.org/r/114400 (owner: 10Bartosz Dziewoński) [21:16:12] rdwrer: do I remember right that you were looking to implement an OOjs UI dialog in multimedia? [21:16:25] spagewmf: Well, dialog in some ways [21:16:57] conversation, jibberjabber, dialectic. How many ways do you want? :) [21:17:07] spagewmf: http://multimedia-alpha.wmflabs.org/wiki/Lightbox_demo#mediaviewer/File:Sunrise%20over%20fishing%20boats%20in%20Kerala.jpg - click on the "use this file" link in the bottom right corner [21:17:16] I use elements from oojsui in that but not the Dialog widget [21:18:36] (03CR) 10BryanDavis: [C: 032] "Merging based on Antoine's +1 API review" [tools/scap] - 10https://gerrit.wikimedia.org/r/116455 (owner: 10BryanDavis) [21:19:02] (03Merged) 10jenkins-bot: Add pythonic configuration [tools/scap] - 10https://gerrit.wikimedia.org/r/116455 (owner: 10BryanDavis) [21:21:08] (03PS7) 10Bartosz Dziewoński: Warn on account creation when username is adjusted [core] - 10https://gerrit.wikimedia.org/r/114400 [21:21:40] hey rdwrer, it's been some time since you merged some of my patches [21:22:09] MatmaRex: Oh my goodness, yes, we are falling behind on our quota aren't we [21:22:37] MatmaRex: What can I do you for? [21:23:22] i have a bunch of open changesets with no -1s and most of them are trivial or easy to review ;) [21:23:37] rdwrer: interesting, thanks. Are you going to restyle 'oo-ui-widget oo-ui-labeledElement oo-ui-optionWidget oo-ui-buttonedElement oo-ui-buttonedElement-framed oo-ui-buttonOptionWidget' to have Agora look and feel? [21:24:21] MatmaRex: Links > descriptions [21:24:25] https://gerrit.wikimedia.org/r/#/q/owner:%22Bartosz+Dziewo%25C5%2584ski+%253Cmatma.rex%2540gmail.com%253E%22++is:open+-label:Code-Review-1+-label:Code-Review-2,n,z [21:24:28] I am after all a hypertext parser [21:24:34] Ah, mind-reader [21:24:43] devising these searches takes a while :P [21:24:46] spagewmf: I didn't intend to [21:24:56] spagewmf: I figured whoever did would hit us too and we'd get it for free [21:26:16] rdwrer: (we're in the "UI Hack day" demo discussing dialogs) [21:26:47] Ah. [21:27:21] in #wikimedia-office we're now discussing the TitleValue change https://gerrit.wikimedia.org/r/106517 https://www.mediawiki.org/wiki/Requests_for_comment/TitleValue [21:27:32] rdwrer: what's lightbox's IE compatibility goal? [21:27:50] rdwrer: it's like being in the meeting even though you're not in the meeting :) [21:27:50] spagewmf: I don't know if we've set one [21:28:09] https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/230 [21:28:19] No version number [21:28:19] Sec [21:29:13] (03CR) 10Krinkle: [C: 032] mw.loader.store: Wrap script eval in try/catch [core] - 10https://gerrit.wikimedia.org/r/100930 (owner: 10Bartosz Dziewoński) [21:29:39] (03CR) 10Cmcmahon: [C: 032] Forgot to add Amir to authors [ruby/api] - 10https://gerrit.wikimedia.org/r/116499 (owner: 10Zfilipin) [21:29:58] ori: https://en.wikipedia.org/w/index.php?title=MediaWiki_talk%3AEdittools&diff=598308861&oldid=598304192 [21:32:57] (03Merged) 10jenkins-bot: mw.loader.store: Wrap script eval in try/catch [core] - 10https://gerrit.wikimedia.org/r/100930 (owner: 10Bartosz Dziewoński) [21:33:09] (03CR) 10Yuvipanda: [C: 04-1] grrrit: Allow filtering based on branches (031 comment) [labs/tools/grrrit] - 10https://gerrit.wikimedia.org/r/116996 (owner: 10AzaToth) [21:33:12] (03CR) 10Rillke: "Works in FF 27. Are there instructions how to test older browsers? Do we have a test environment?" [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/74425 (owner: 10Rillke) [21:34:18] (03CR) 10Yuvipanda: [C: 031] "This is nice! But needs fix for prev. patch before this can be merged" [labs/tools/grrrit] - 10https://gerrit.wikimedia.org/r/116997 (owner: 10AzaToth) [21:37:40] (03PS1) 10MaxSem: Default $wgMainCacheType to CACHE_ANYTHING [core] - 10https://gerrit.wikimedia.org/r/117091 [21:40:42] (03PS4) 10Hashar: Parsoid: uses ZUUL_COMMIT as a git refspec to build [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/117045 [21:42:57] (03PS5) 10Hashar: Parsoid: uses ZUUL_COMMIT as a git refspec to build [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/117045 [21:43:03] (03CR) 10Brian Wolff: "Umm, doesnt caching db requests in the db not make a lot of sense?" [core] - 10https://gerrit.wikimedia.org/r/117091 (owner: 10MaxSem) [21:43:20] (03CR) 10Hashar: "I forgot to update the parsoidsvc-php-parsertests job as well." [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/117045 (owner: 10Hashar) [21:52:32] (03CR) 10Manybubbles: [C: 032] Use actual percentage difference formula [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/117043 (owner: 10Chad) [21:52:41] (03Merged) 10jenkins-bot: Use actual percentage difference formula [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/117043 (owner: 10Chad) [21:52:55] (03CR) 10Bartosz Dziewoński: "Conflicts with Mark's https://gerrit.wikimedia.org/r/#/c/111620/" [core] - 10https://gerrit.wikimedia.org/r/117010 (owner: 10Krinkle) [21:53:07] (03CR) 10Bartosz Dziewoński: "Conflicts with Timo's https://gerrit.wikimedia.org/r/#/c/117010/" [core] - 10https://gerrit.wikimedia.org/r/111620 (owner: 10MarkTraceur) [21:53:42] Hah. [21:54:26] i have to do this more and more often, eh [21:54:41] (03CR) 10Hashar: [C: 032] "Fine! :-]" [tools/scap] - 10https://gerrit.wikimedia.org/r/117014 (owner: 10BryanDavis) [21:54:50] usually with krinkle's changes too, he loves to reimplement pending changes ;) [21:55:28] rdwrer: Wait, you did mw.debug already? [21:55:31] I thought you didn't. [21:55:36] Apparently I did [21:55:39] My baaad [21:55:43] I was lookign for that change but it wasn't anywhere on my dashboard [21:55:47] be sure to add me as a reviewer :) [21:56:03] rdwrer: I'll rebase, don't worry [21:57:07] Reviewers are silly [21:58:50] rdwrer: Looking through 100s of changes to find one is more silly ;-) [21:58:59] or equally so [21:59:20] Krinkle: project:mediawiki/core topic:jsduck [21:59:29] topic could be anything [21:59:39] But I've been using jsduck [22:06:06] (03PS4) 10Krinkle: mediawiki.debug: Improve jsduck docs [core] - 10https://gerrit.wikimedia.org/r/111620 (owner: 10MarkTraceur) [22:06:08] (03PS3) 10Krinkle: Include all of /resources/mediawiki/* in jsduck index [core] - 10https://gerrit.wikimedia.org/r/117010 [22:06:27] (03CR) 10Krinkle: [C: 031] mediawiki.debug: Improve jsduck docs [core] - 10https://gerrit.wikimedia.org/r/111620 (owner: 10MarkTraceur) [22:06:55] (03PS2) 10MarkTraceur: jquery audit of mw.GroupProgressBar.js [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/86810 [22:07:49] (03CR) 10Krinkle: [C: 04-1] jquery audit of mw.GroupProgressBar.js (031 comment) [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/86810 (owner: 10MarkTraceur) [22:08:23] (03CR) 10jenkins-bot: [V: 04-1] jquery audit of mw.GroupProgressBar.js [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/86810 (owner: 10MarkTraceur) [22:09:46] (03CR) 10Krinkle: "Indeed, -xe is the default for shell scripts. If you override it with a custom hash bang (#!/bin/bash) then you'll need to provide your ow" [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/111136 (owner: 10MarkTraceur) [22:12:29] (03PS5) 10Krinkle: Include all of /resources/mediawiki/* in jsduck index [core] - 10https://gerrit.wikimedia.org/r/111620 (owner: 10MarkTraceur) [22:12:54] (03Abandoned) 10Krinkle: Include all of /resources/mediawiki/* in jsduck index [core] - 10https://gerrit.wikimedia.org/r/117010 (owner: 10Krinkle) [22:13:35] (03CR) 10Krinkle: "Squashed into I74c8dcfeac9754e38f9dec because keeping them separate was suboptimal as there was some errors in mine that Mark corrected (n" [core] - 10https://gerrit.wikimedia.org/r/117010 (owner: 10Krinkle) [22:14:03] (03CR) 10Krinkle: [C: 031] Include all of /resources/mediawiki/* in jsduck index [core] - 10https://gerrit.wikimedia.org/r/111620 (owner: 10MarkTraceur) [22:14:24] rdwrer: If you could +1, then MatmaRex or can merge later. [22:14:28] or I * [22:14:29] (03CR) 10Bartosz Dziewoński: [C: 031] qunit: Use sinon sandbox for mediawiki.api.parse.test (031 comment) [core] - 10https://gerrit.wikimedia.org/r/117005 (owner: 10Krinkle) [22:16:46] (03CR) 10Krinkle: qunit: Use sinon sandbox for mediawiki.api.parse.test (031 comment) [core] - 10https://gerrit.wikimedia.org/r/117005 (owner: 10Krinkle) [22:19:40] (03CR) 10Krinkle: "There are various reliable cloud services that provide different browser versions. SauceLabs is one that has free accounts for OSS purpose" [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/74425 (owner: 10Rillke) [22:20:26] Krinkle: i can merge? i don't want to leave y'all too far behind ;) https://toolserver.org/~nemobis/crstats/core.txt [22:21:41] MatmaRex: We don't mind, I promise :) [22:22:34] (03PS3) 10Deepali: Add appropriate mw-ui button styles to Save, Preview, Show changes and cancel buttons. [core] - 10https://gerrit.wikimedia.org/r/116725 [22:23:15] (03CR) 10Mattflaschen: [C: 04-1] "Per previous review. Had to rebase due to job queue issue fixed since (so we can test this on Labs)." [core] - 10https://gerrit.wikimedia.org/r/116725 (owner: 10Deepali) [22:23:40] (03PS14) 10Mattflaschen: [WIP] Add mw-ui-button classes to various buttons [core] - 10https://gerrit.wikimedia.org/r/52169 [22:30:06] (03CR) 10Bartosz Dziewoński: [C: 032] qunit: Use sinon sandbox for mediawiki.api.parse.test (031 comment) [core] - 10https://gerrit.wikimedia.org/r/117005 (owner: 10Krinkle) [22:31:17] (03PS2) 10Aaron Schulz: Resetting img alt value as "0" [core] - 10https://gerrit.wikimedia.org/r/116483 (owner: 10Lekshmi) [22:34:20] (03Merged) 10jenkins-bot: qunit: Use sinon sandbox for mediawiki.api.parse.test [core] - 10https://gerrit.wikimedia.org/r/117005 (owner: 10Krinkle) [22:35:13] (03CR) 10jenkins-bot: [V: 04-1] Resetting img alt value as "0" [core] - 10https://gerrit.wikimedia.org/r/116483 (owner: 10Lekshmi) [22:35:41] (03CR) 10Aaron Schulz: Resetting img alt value as "0" (031 comment) [core] - 10https://gerrit.wikimedia.org/r/116483 (owner: 10Lekshmi) [22:39:15] (03CR) 10Krinkle: mediawiki.api: Use Promise.then instead of manual Deferred wrapping (031 comment) [core] - 10https://gerrit.wikimedia.org/r/116957 (owner: 10Krinkle) [22:40:22] (03PS1) 10BryanDavis: Fix configuration parser crash [tools/scap] - 10https://gerrit.wikimedia.org/r/117098 [22:42:42] (03PS3) 10Bsitu: [WIP]flow_revision - add new column rev_type_id [extensions/Flow] - 10https://gerrit.wikimedia.org/r/116861 [22:42:45] (03PS2) 10Bsitu: Update flow_revision.rev_type_id [extensions/Flow] - 10https://gerrit.wikimedia.org/r/116874 [22:42:48] (03PS1) 10Bsitu: Have post/header revisions reference rev_type/rev_type_id [extensions/Flow] - 10https://gerrit.wikimedia.org/r/117099 [22:42:51] (03PS2) 10BryanDavis: Fix configuration parser crash [tools/scap] - 10https://gerrit.wikimedia.org/r/117098 [22:43:12] (03CR) 10jenkins-bot: [V: 04-1] Have post/header revisions reference rev_type/rev_type_id [extensions/Flow] - 10https://gerrit.wikimedia.org/r/117099 (owner: 10Bsitu) [22:45:07] (03CR) 10Ori.livneh: [C: 032] Fix configuration parser crash [tools/scap] - 10https://gerrit.wikimedia.org/r/117098 (owner: 10BryanDavis) [22:45:36] (03Merged) 10jenkins-bot: Fix configuration parser crash [tools/scap] - 10https://gerrit.wikimedia.org/r/117098 (owner: 10BryanDavis) [23:15:20] (03PS1) 10Kaldari: Updating mediawiki.ui color variables per design team [core] - 10https://gerrit.wikimedia.org/r/117105 [23:15:43] (03PS2) 10Bsitu: Have post/header revisions reference rev_type/rev_type_id [extensions/Flow] - 10https://gerrit.wikimedia.org/r/117099 [23:16:17] (03CR) 10jenkins-bot: [V: 04-1] Have post/header revisions reference rev_type/rev_type_id [extensions/Flow] - 10https://gerrit.wikimedia.org/r/117099 (owner: 10Bsitu) [23:23:48] (03PS15) 10Mattflaschen: [WIP] Add mw-ui-button classes to various buttons [core] - 10https://gerrit.wikimedia.org/r/52169 [23:23:53] (03PS3) 10Bsitu: Have post/header revisions reference rev_type/rev_type_id [extensions/Flow] - 10https://gerrit.wikimedia.org/r/117099 [23:26:30] Hi, I am working on this bug regarding Semantic Forms. I am not sure how to reproduce this in my wiki. Please tell me. [23:26:32] https://bugzilla.wikimedia.org/show_bug.cgi?id=51505 [23:28:02] (03CR) 10Spage: "mw-ui-primary -> mw-ui-constructive" (031 comment) [core] - 10https://gerrit.wikimedia.org/r/116725 (owner: 10Deepali) [23:29:23] (03PS1) 10JGonera: Make .mw-ui-button height the same for all buttons [core] - 10https://gerrit.wikimedia.org/r/117107 [23:29:40] (03CR) 10Adamw: "Anyone sober yet? :p" [labs/tools/grrrit] - 10https://gerrit.wikimedia.org/r/112311 (owner: 10Adamw) [23:30:22] (03CR) 10Adamw: [C: 032 V: 032] Show the right username in the confirmation for removing articles [extensions/EducationProgram] - 10https://gerrit.wikimedia.org/r/115632 (owner: 10Ragesoss) [23:31:37] (03CR) 10MarkTraceur: [C: 04-1] "Minor issue" (031 comment) [core] - 10https://gerrit.wikimedia.org/r/115835 (owner: 10Gergő Tisza) [23:31:40] tgr: I'll fix. [23:31:57] thx [23:32:45] Hi, I am working on this bug regarding Semantic Forms API. I am not sure how to reproduce this in my wiki. Please tell me. https://bugzilla.wikimedia.org/show_bug.cgi?id=51505 [23:33:37] (03PS1) 10JGonera: Stop make kss from opening browser [core] - 10https://gerrit.wikimedia.org/r/117108 [23:34:41] zeek: Hi, so, have you installed SF on your wiki? [23:34:48] Yes [23:35:18] (03CR) 10Krinkle: Rename RedirectSpecialPage subclasses (031 comment) [core] - 10https://gerrit.wikimedia.org/r/106888 (owner: 10Bartosz Dziewoński) [23:35:19] rdwrer: yes [23:35:27] zeek: And have you tried submitting an edit without a token, via its API? [23:35:50] No this is what I am not sure of... how to use the API [23:36:12] zeek: Go to your wiki - it should have a URL like http://localhost/wiki/index.php [23:36:25] zeek: Then replace index.php with api.php - http://localhost/wiki/api.php [23:36:25] yes then [23:36:28] (03CR) 10Krinkle: Rename RedirectSpecialPage subclasses (031 comment) [core] - 10https://gerrit.wikimedia.org/r/106888 (owner: 10Bartosz Dziewoński) [23:36:57] zeek: The rest of it varies. I don't know how to use the SF API myself, but if you look through that page there will be documentation for it [23:37:48] yeah... got it... let me go through it... thanks rdwrer :) [23:38:24] bd [23:39:01] (03CR) 10Parent5446: [C: 032] Warn on account creation when username is adjusted [core] - 10https://gerrit.wikimedia.org/r/114400 (owner: 10Bartosz Dziewoński) [23:41:00] (03PS1) 10EBernhardson: Cleanup undefined method warnings [extensions/Flow] - 10https://gerrit.wikimedia.org/r/117111 [23:42:52] (03Merged) 10jenkins-bot: Warn on account creation when username is adjusted [core] - 10https://gerrit.wikimedia.org/r/114400 (owner: 10Bartosz Dziewoński) [23:43:17] (03PS1) 10Anomie: HTMLForm: Clean up 0 handling [core] (wmf/1.23wmf15) - 10https://gerrit.wikimedia.org/r/117113 [23:43:41] (03PS1) 10Anomie: HTMLForm: Clean up 0 handling [core] (wmf/1.23wmf16) - 10https://gerrit.wikimedia.org/r/117114 [23:44:16] (03CR) 10TTO: "Thanks for the review, Bartosz." (032 comments) [core] - 10https://gerrit.wikimedia.org/r/110162 (owner: 10TTO) [23:45:28] (03PS4) 10MarkTraceur: Fix jQuery compatibility issues in jquery.color.js [core] - 10https://gerrit.wikimedia.org/r/115835 (owner: 10Gergő Tisza) [23:46:06] (03CR) 10Parent5446: Introducing TitleValue (032 comments) [core] - 10https://gerrit.wikimedia.org/r/106517 (owner: 10Daniel Kinzler) [23:48:07] (03PS1) 10Bsitu: Drop table flow_header_revision [extensions/Flow] - 10https://gerrit.wikimedia.org/r/117115 [23:48:10] (03PS5) 10Krinkle: Optimize all SVGs [core] - 10https://gerrit.wikimedia.org/r/106506 (owner: 10Bartosz Dziewoński) [23:48:16] (03CR) 10Krinkle: "Fixed typo in commit msg" [core] - 10https://gerrit.wikimedia.org/r/106506 (owner: 10Bartosz Dziewoński) [23:48:28] (03CR) 10Anomie: [C: 031] "I need to find time to test this..." (031 comment) [core] - 10https://gerrit.wikimedia.org/r/110162 (owner: 10TTO) [23:48:50] (03CR) 10MarkTraceur: [C: 032] "Thanks, tgr." [core] - 10https://gerrit.wikimedia.org/r/115835 (owner: 10Gergő Tisza) [23:49:46] (03CR) 10jenkins-bot: [V: 04-1] Drop table flow_header_revision [extensions/Flow] - 10https://gerrit.wikimedia.org/r/117115 (owner: 10Bsitu) [23:50:00] (03CR) 10Krinkle: Optimize all SVGs (031 comment) [core] - 10https://gerrit.wikimedia.org/r/106506 (owner: 10Bartosz Dziewoński) [23:52:32] (03PS2) 10EBernhardson: Use single query for multiple revision lookups by pk [extensions/Flow] - 10https://gerrit.wikimedia.org/r/115416 [23:53:00] (03Merged) 10jenkins-bot: Fix jQuery compatibility issues in jquery.color.js [core] - 10https://gerrit.wikimedia.org/r/115835 (owner: 10Gergő Tisza) [23:56:49] (03PS1) 10Krinkle: Remove tests for jquery.delayedBind (deprecated) [core] - 10https://gerrit.wikimedia.org/r/117117 [23:57:17] (03CR) 10Anomie: [C: 032] "Backport" [core] (wmf/1.23wmf16) - 10https://gerrit.wikimedia.org/r/117114 (owner: 10Anomie) [23:57:20] (03CR) 10Anomie: [C: 032] "Backport" [core] (wmf/1.23wmf15) - 10https://gerrit.wikimedia.org/r/117113 (owner: 10Anomie) [23:57:27] (03CR) 10Krinkle: "This would get rid of the deprecation warnings currently curiously showing up in the QUnit run output in Jenkins for core and extensions." [core] - 10https://gerrit.wikimedia.org/r/117117 (owner: 10Krinkle)