[00:05:37] (03PS8) 10Werdna: Extract wiki and external links, file and template usages from text. [extensions/Flow] - 10https://gerrit.wikimedia.org/r/110090 [00:05:41] (03CR) 10jenkins-bot: [V: 04-1] Extract wiki and external links, file and template usages from text. [extensions/Flow] - 10https://gerrit.wikimedia.org/r/110090 (owner: 10Werdna) [00:07:27] (03PS9) 10Werdna: Extract wiki and external links, file and template usages from text. [extensions/Flow] - 10https://gerrit.wikimedia.org/r/110090 [00:07:46] (03CR) 10jenkins-bot: [V: 04-1] Extract wiki and external links, file and template usages from text. [extensions/Flow] - 10https://gerrit.wikimedia.org/r/110090 (owner: 10Werdna) [00:08:01] (03CR) 10Werdna: "PS8 fixes most tests (still can't figure out how to fix ParsoidUtils to ensure it has an existing title)." [extensions/Flow] - 10https://gerrit.wikimedia.org/r/110090 (owner: 10Werdna) [00:11:00] Technical_13: [00:11:04] mw.msg ? [00:11:18] I guess nobody cares [00:23:17] Anyone else here? [00:24:37] [who knows the diff between mw.msg and mw.message] [00:38:37] (03CR) 10PiRSquared17: Show parameter deprecation on Special:ApiSandbox (032 comments) [extensions/ApiSandbox] - 10https://gerrit.wikimedia.org/r/116449 (owner: 10Gerrit Patch Uploader) [01:11:48] (03CR) 10Physikerwelt: "I remove all the reviewers that did not commit to do a code review... otherwise the reviewer list somehow misleading." [extensions/Math] - 10https://gerrit.wikimedia.org/r/112353 (owner: 10Physikerwelt) [01:55:42] (03CR) 10Gergő Tisza: [C: 032] Adding Leaflet scripts to UploadWizard [extensions/UploadWizard] (osm) - 10https://gerrit.wikimedia.org/r/116128 (owner: 10Inchikutty) [01:57:33] (03Merged) 10jenkins-bot: Adding Leaflet scripts to UploadWizard [extensions/UploadWizard] (osm) - 10https://gerrit.wikimedia.org/r/116128 (owner: 10Inchikutty) [02:13:27] (03CR) 10Gergő Tisza: [C: 04-1] Embedding leaflet maps based on OSM data to UploadWizard (032 comments) [extensions/UploadWizard] (osm) - 10https://gerrit.wikimedia.org/r/116129 (owner: 10Inchikutty) [02:41:59] (03PS10) 10Werdna: Extract wiki and external links, file and template usages from text. [extensions/Flow] - 10https://gerrit.wikimedia.org/r/110090 [02:43:19] (03CR) 10Werdna: "PS10 adds stub tests, but with no data provider. I'm sort of stuck on how to create test revision objects and so on." [extensions/Flow] - 10https://gerrit.wikimedia.org/r/110090 (owner: 10Werdna) [02:43:27] (03PS1) 10Physikerwelt: Measure performance [extensions/MathSearch] - 10https://gerrit.wikimedia.org/r/116453 [02:49:51] (03PS2) 10Physikerwelt: Measure performance [extensions/MathSearch] - 10https://gerrit.wikimedia.org/r/116453 [02:57:59] (03CR) 10Physikerwelt: [C: 032 V: 032] Measure performance [extensions/MathSearch] - 10https://gerrit.wikimedia.org/r/116453 (owner: 10Physikerwelt) [03:25:11] (03CR) 10Ori.livneh: [C: 032] "Looks good. I'm not convinced that there needs to be a standalone tool for this -- the whole lot of multiversion scripts could be replaced" [tools/scap] - 10https://gerrit.wikimedia.org/r/116062 (owner: 10BryanDavis) [03:38:02] (03CR) 10jenkins-bot: [V: 04-1] Extract wiki and external links, file and template usages from text. [extensions/Flow] - 10https://gerrit.wikimedia.org/r/110090 (owner: 10Werdna) [03:48:59] (03PS1) 10Gnosygnu: v1.3.1.1 [xowa] - 10https://gerrit.wikimedia.org/r/116454 [03:49:26] (03CR) 10Gnosygnu: [C: 032 V: 032] "approving own commit" [xowa] - 10https://gerrit.wikimedia.org/r/116454 (owner: 10Gnosygnu) [03:52:30] (03CR) 10Ori.livneh: [C: 04-1] "Something is wrong when you are parsing state out of a string that was generated by another part of your program. Shell command lines are " [tools/scap] - 10https://gerrit.wikimedia.org/r/116399 (owner: 10BryanDavis) [04:53:19] (03CR) 10BryanDavis: "> Something is wrong when you are parsing state out of a string that was generated by another part of your program." [tools/scap] - 10https://gerrit.wikimedia.org/r/116399 (owner: 10BryanDavis) [04:54:48] (03PS1) 10BryanDavis: Add pythonic configuration [tools/scap] - 10https://gerrit.wikimedia.org/r/116455 [04:54:50] (03PS1) 10BryanDavis: Add base class for creating CLI wrappers [tools/scap] - 10https://gerrit.wikimedia.org/r/116456 [04:54:52] (03PS1) 10BryanDavis: Update sphinx documentation [tools/scap] - 10https://gerrit.wikimedia.org/r/116457 [04:58:35] (03CR) 10BryanDavis: Add pythonic configuration (031 comment) [tools/scap] - 10https://gerrit.wikimedia.org/r/116455 (owner: 10BryanDavis) [05:13:48] (03PS3) 10Prtksxna: Make EventLogging a soft dependency [extensions/Popups] - 10https://gerrit.wikimedia.org/r/115878 [05:13:50] (03PS4) 10Prtksxna: Use moment.js instead of timeAgo method [extensions/Popups] - 10https://gerrit.wikimedia.org/r/115858 [05:14:17] (03PS9) 10Prtksxna: Flip the starting point of the popup if its on the right side of the screen [extensions/Popups] - 10https://gerrit.wikimedia.org/r/115187 [05:14:19] (03PS9) 10Prtksxna: Limit image size for portrait popups [extensions/Popups] - 10https://gerrit.wikimedia.org/r/115186 [05:14:21] (03PS10) 10Prtksxna: Flip the arrow position if the popup is flipped [extensions/Popups] - 10https://gerrit.wikimedia.org/r/115188 [05:14:23] (03PS4) 10Prtksxna: Use mixin for creating pokeys with the border method [extensions/Popups] - 10https://gerrit.wikimedia.org/r/116052 [05:14:25] (03PS7) 10Prtksxna: Add border around pokey of the popup [extensions/Popups] - 10https://gerrit.wikimedia.org/r/116053 [05:31:23] (03CR) 10Hiong3-eng5: "There are some misspellings but the one from line 255 should be resolved. Thanks." (036 comments) [extensions/WikiLexicalData] - 10https://gerrit.wikimedia.org/r/116277 (owner: 10Purodha) [05:55:43] (03PS1) 10Physikerwelt: remove armourMath and wgContLang (bug 60799) [extensions/Math] - 10https://gerrit.wikimedia.org/r/116458 [05:57:30] (03Abandoned) 10Physikerwelt: remove armourMath and wgContLang (bug 60799) [extensions/Math] - 10https://gerrit.wikimedia.org/r/116458 (owner: 10Physikerwelt) [06:00:19] (03PS1) 10Hiong3-eng5: API ow_express 1.1 initial changes [extensions/WikiLexicalData] - 10https://gerrit.wikimedia.org/r/116459 [06:00:51] (03PS2) 10Physikerwelt: remove armourMath and wgContLang (bug 60799) [extensions/Math] (math2_0_0) - 10https://gerrit.wikimedia.org/r/112324 [06:02:15] (03PS2) 10Physikerwelt: Fix: Allow
as valid Math output [extensions/Math] (math2_0_0) - 10https://gerrit.wikimedia.org/r/112325 [06:02:24] (03PS2) 10Physikerwelt: Change database layout [extensions/Math] (math2_0_0) - 10https://gerrit.wikimedia.org/r/112326 [06:02:32] (03PS2) 10Physikerwelt: Introduce $wgMathValidModes to adjust the selectable math rendering modes in user preferences [extensions/Math] (math2_0_0) - 10https://gerrit.wikimedia.org/r/112327 [06:02:41] (03PS2) 10Physikerwelt: Introduce orthogonal option to enable MathJax [extensions/Math] (math2_0_0) - 10https://gerrit.wikimedia.org/r/112328 [06:18:59] (03PS11) 10Werdna: Extract wiki and external links, file and template usages from text. [extensions/Flow] - 10https://gerrit.wikimedia.org/r/110090 [06:20:06] (03CR) 10Werdna: "PS11: Most of the tests are now written and pass. Just stuck on the links table updating test (the main one I guess) because the state doe" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/110090 (owner: 10Werdna) [06:32:02] (03PS1) 10Shirayuki: i18n: use double-quotation for consistency [core] - 10https://gerrit.wikimedia.org/r/116461 [06:41:38] (03CR) 10Nikerabbit: [C: 032] i18n: use double-quotation for consistency [core] - 10https://gerrit.wikimedia.org/r/116461 (owner: 10Shirayuki) [06:44:52] (03PS1) 10Shirayuki: i18n: use double-quotation for consistency [extensions/OpenStackManager] - 10https://gerrit.wikimedia.org/r/116462 [06:55:51] (03PS6) 10AndyRussG: Stubs and tests for persistence objects [extensions/Campaigns] (wip/editorcampaigns) - 10https://gerrit.wikimedia.org/r/116221 [07:32:49] (03CR) 10AndyRussG: "Hi, all... More on the general discussion, security and architecture review issues raised by MaxSem." [extensions/Campaigns] (wip/editorcampaigns) - 10https://gerrit.wikimedia.org/r/115853 (owner: 10AndyRussG) [07:35:54] (03CR) 10MaxSem: "The extensions you mentioned aren't deployed by WMF so their authors are free to do whatever they want inclding eval( $_GET['eval'] ). WMF" [extensions/Campaigns] (wip/editorcampaigns) - 10https://gerrit.wikimedia.org/r/115853 (owner: 10AndyRussG) [07:39:41] Hi MaxSem, thanks for the comments [07:41:10] I'll look into working on some RFCs [08:20:26] (03PS1) 10Physikerwelt: Fix bugs for 0, and textonly [extensions/Math] (dev) - 10https://gerrit.wikimedia.org/r/116464 [08:21:03] (03CR) 10AndyRussG: "Here's a hypothetical use:" [extensions/Campaigns] (wip/editorcampaigns) - 10https://gerrit.wikimedia.org/r/116153 (owner: 10AndyRussG) [08:24:10] (03CR) 10Physikerwelt: [C: 032 V: 032] Fix bugs for 0, and textonly [extensions/Math] (dev) - 10https://gerrit.wikimedia.org/r/116464 (owner: 10Physikerwelt) [08:34:00] (03PS1) 10Shirayuki: i18n: fix message name "log-show-hide-privatechat" [extensions/MediaWikiChat] - 10https://gerrit.wikimedia.org/r/116465 [08:43:05] (03Merged) 10jenkins-bot: Convert mwversionsinuse to pure python [tools/scap] - 10https://gerrit.wikimedia.org/r/116062 (owner: 10BryanDavis) [08:45:22] (03PS19) 10Jeroen De Dauw: Make it possible for extensions to specify which version of MediaWiki they support via Composer. [core] - 10https://gerrit.wikimedia.org/r/105092 [08:46:48] (03CR) 10jenkins-bot: [V: 04-1] Extract wiki and external links, file and template usages from text. [extensions/Flow] - 10https://gerrit.wikimedia.org/r/110090 (owner: 10Werdna) [08:51:53] (03Merged) 10jenkins-bot: i18n: use double-quotation for consistency [core] - 10https://gerrit.wikimedia.org/r/116461 (owner: 10Shirayuki) [08:58:56] !vagrant [08:58:56] There is no such key, you probably want to try: !vagrant, [08:59:03] this is interesting [08:59:20] @info [08:59:20] http://bots.wmflabs.org/~wm-bot/dump/%23wikimedia-dev.htm [08:59:48] !useragent [08:59:48] The User-Agent string tells the server about your browser (or HTTP library). Wikimedia servers require a User-Agent string to be sent. See http://meta.wikimedia.org/wiki/User-Agent_policy for details. [09:27:37] petan: I'm pretty sure you have the bot programmed to embarrass me. [09:27:52] It feels like every time I try to use it, it chokes and I look like a fool. [09:28:05] !botnoob [09:28:05] I don't know everything about everything. I am mostly for lazy experienced users to echo quick answers to very common mediawiki questions. Please don't randomly experiment with me for help. Everything I know is at http://toolserver.org/~mwbot/botbrain.html and you can visit #mwbot or privately message me. [09:28:13] Heh. [09:50:46] petan: Can you please make wm-bot join the #wikimedia-design channel so that it too can have public logs? [09:50:49] (03CR) 10Tpt: [C: 032] "Thanks" [extensions/LabeledSectionTransclusion] - 10https://gerrit.wikimedia.org/r/116243 (owner: 10Reedy) [09:50:58] (03Merged) 10jenkins-bot: Add COPYING [extensions/LabeledSectionTransclusion] - 10https://gerrit.wikimedia.org/r/116243 (owner: 10Reedy) [09:51:11] prtksxna: yes, anyone with cloak can do that [09:51:24] petan: I don't think I do (what is a cloak?) [09:51:31] @add #wikimedia-design [09:51:49] that you indeed don't have, it's that wikimedia/Petrb I have instead of IP [09:52:15] petan: Oh! I see it! Thanks! [09:52:27] prtksxna: I can't enable public logging there unless channel operators explicitly allow that, on freenode by default, public logging is not allowed [09:52:40] there is no "logging allowed" in topic [09:53:01] petan: Where? [09:53:09] in -design [09:53:21] public logging must be allowed, someone need to approve it [09:53:31] petan: Like who? Who do I need to ping? [09:53:42] /cs access #wikimedia-design list [09:53:52] The people listed there with the +F flag. [09:53:54] Or ... [09:53:59] jorm is likely the best person to talk to [09:54:07] because he is directly involved in -design stuff [09:54:07] /cs info #wikimedia-design [09:54:40] petan: I am in the design team too, can I decide? :P [09:54:54] you are not op in that channel [09:54:55] Why do you want a public log? [09:55:22] public logs are useful :-) [09:55:35] Gloria: Because people go in and out, and a lot of people on the design team don't have bouncers [09:55:44] Gloria: And what petan said :) [09:56:59] I've never found them particularly useful. They usually lack search. [09:57:15] prtksxna: Do you use a bouncer? [09:57:23] petan: I'll ping jorm and let you know, thanks for your help :) [09:57:26] Gloria: I do, yes. [09:57:52] I don't see how other people having bouncers is relevant. [09:58:07] Any bouncer has a logging feature, surely. :-) [09:58:24] znc does for sure, I use it. [09:58:27] Gloria: My server isn't completely reliable, plus those logs aren't public [09:58:42] I'm not sure what the virtue of public logs is. [09:58:44] Gloria: newer versions of znc do, in older versions its a module (which I don't have) [09:59:06] (03PS2) 10Tpt: Adds a beginning of parser tests [extensions/ProofreadPage] - 10https://gerrit.wikimedia.org/r/115356 [09:59:13] Fair enough. [09:59:28] Gloria: these logs are stored in many ways, one of them is SQL server, so reason why they don't have search feature is that nobody implemented it :P [09:59:51] Gloria: I ack my local logs pretty often [09:59:54] Gloria: by the way, that SQL server is directly accessible to anyone from tools project, so anyone can SELECT from the table with logs [10:00:02] petan: grep works for me. :-) [10:00:06] I keep logs on disk. [10:00:08] that too [10:00:19] there is tar.gz with all logs from a channel [10:00:21] in wm-bot's folder [10:00:36] petan: surely you mean in wm-bot's heart [10:00:51] prtksxna: Oh? I rarely refer to logs. [10:00:54] I have gigs of them. [10:01:33] Gloria: If I have a discussion about approach or ideas that I have to implement later I end up acking later to find them. I can't remember conversations very well :( [10:02:01] which is publicly accessible on web (for example http://bots.wmflabs.org/~wm-bot/logs/%23wikimedia-dev/%23wikimedia-dev.tar.gz which has 11MB no gigs) [10:02:02] prtksxna: Use Bugzilla. :-) [10:02:38] Gloria: Sadly, ot everything happens on Bugzilla. [10:02:49] prtksxna: You should track development work in it, though. [10:02:59] Wikimedia-related development work, anyway. [10:03:30] Gloria: Right, but sometimes it doesn't happen is all [10:03:39] You wouldn't be acking public logs. [10:03:46] You've already solved your use-case. [10:04:00] But this is a silly conversation. The -design owners will decide. [10:05:28] (03PS2) 10Hashar: DonationInterface tests depends on ContributionTracking [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/116197 (owner: 10Adamw) [10:05:50] Gloria: Correct, I wouldn't the people without bouncers might want to look at it. [10:05:51] (03CR) 10Hashar: [C: 032] "Job updated!" [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/116197 (owner: 10Adamw) [10:06:01] !vagrant [10:06:01] https://www.mediawiki.org/wiki/MediaWiki-Vagrant [10:06:08] (03Merged) 10jenkins-bot: DonationInterface tests depends on ContributionTracking [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/116197 (owner: 10Adamw) [10:06:35] prtksxna: I think you dropped a verb. [10:06:50] Gloria: I fixed the bug :D [10:06:53] Nice. :-) [10:07:03] What was it? [10:07:03] I am pretty sure next time you use the bot you will find another one :P [10:07:08] !vagrant [10:07:08] https://www.mediawiki.org/wiki/MediaWiki-Vagrant [10:07:09] Probably. [10:07:14] https://bugzilla.wikimedia.org/show_bug.cgi?id=62128 [10:07:15] Gloria: I thought it was a punctuation [10:07:18] Only if a new user is around to be embarrassed in front of. [10:08:35] prtksxna: It? [10:09:07] * prtksxna is confused [10:09:16] Gloria: Lets let it be :) [10:11:46] (03PS3) 10Hashar: analytics-kraken maven job [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/114622 [10:13:10] (03CR) 10Hashar: [C: 032] "Job deployed and triggered by Zuul (non voting)." [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/114622 (owner: 10Hashar) [10:13:26] (03Merged) 10jenkins-bot: analytics-kraken maven job [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/114622 (owner: 10Hashar) [10:14:08] (03PS2) 10Addshore: Increase coverage generation to run every 12 hours [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/115953 [10:15:29] (03CR) 10Hashar: [C: 032] "Job updated!" [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/115953 (owner: 10Addshore) [10:15:46] (03Merged) 10jenkins-bot: Increase coverage generation to run every 12 hours [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/115953 (owner: 10Addshore) [10:17:28] (03Abandoned) 10Hashar: Dummy job for testing [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/116123 (owner: 10MarkTraceur) [10:18:15] (03PS4) 10Hashar: Tweak browsertests URLs [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/115387 [10:21:25] (03PS2) 10Tpt: Addition of a parser test for page= parameter of image inclusion [core] - 10https://gerrit.wikimedia.org/r/102475 [10:23:54] (03CR) 10Hashar: [C: 032] Tweak browsertests URLs [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/115387 (owner: 10Hashar) [10:24:12] (03Merged) 10jenkins-bot: Tweak browsertests URLs [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/115387 (owner: 10Hashar) [10:25:15] (03CR) 10jenkins-bot: [V: 04-1] Addition of a parser test for page= parameter of image inclusion [core] - 10https://gerrit.wikimedia.org/r/102475 (owner: 10Tpt) [10:26:11] (03PS1) 10Hashar: browser tests: BROWSER_LABEL => BROWSER [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/116467 [10:26:43] (03CR) 10Hashar: "Reported by Nik :-] Thanks!" [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/116467 (owner: 10Hashar) [10:28:50] (03CR) 10Hashar: [C: 032] browser tests: BROWSER_LABEL => BROWSER [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/116467 (owner: 10Hashar) [10:29:07] (03Merged) 10jenkins-bot: browser tests: BROWSER_LABEL => BROWSER [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/116467 (owner: 10Hashar) [10:31:44] (03PS8) 10Hashar: Browser tests jobs for CirrusSearch [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/115164 [10:40:51] (03CR) 10Hashar: "Browser tests should be fixed now. I got the job to set BROWSER in addition to the BROWSER_LABEL env variable." [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/115193 (owner: 10Manybubbles) [10:41:05] (03CR) 10Hashar: [C: 032] "Job is passing so that is good enough for now :-]" [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/115164 (owner: 10Hashar) [10:41:22] (03Merged) 10jenkins-bot: Browser tests jobs for CirrusSearch [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/115164 (owner: 10Hashar) [10:51:15] (03CR) 10Santhosh: Create plural rules for variants of zh (Chinese) (031 comment) [core] - 10https://gerrit.wikimedia.org/r/116278 (owner: 10Liangent) [11:12:36] (03CR) 10Liangent: Create plural rules for variants of zh (Chinese) (031 comment) [core] - 10https://gerrit.wikimedia.org/r/116278 (owner: 10Liangent) [11:31:09] (03CR) 10Hashar: "Good thing! I would rather drop the ConfigDict though" (035 comments) [tools/scap] - 10https://gerrit.wikimedia.org/r/116455 (owner: 10BryanDavis) [11:38:57] (03CR) 10Hashar: [C: 031] "Lovely wrapper." [tools/scap] - 10https://gerrit.wikimedia.org/r/116456 (owner: 10BryanDavis) [11:39:45] (03CR) 10Hashar: [C: 031] Update sphinx documentation [tools/scap] - 10https://gerrit.wikimedia.org/r/116457 (owner: 10BryanDavis) [11:45:53] (03CR) 10Purodha: "Line 233: this is correct and meant to be so. See line 223, where this function is called." [extensions/WikiLexicalData] - 10https://gerrit.wikimedia.org/r/116277 (owner: 10Purodha) [11:50:31] (03PS1) 10Purodha: Fix more typos and mrge branch 'master' of ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/WikiLexicalData [extensions/WikiLexicalData] - 10https://gerrit.wikimedia.org/r/116472 [12:03:56] (03PS8) 10Addshore: DNM Send coverage info to Coveralls [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/115951 [12:05:05] (03PS3) 10Addshore: coveralls experiment continued [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/116090 (owner: 10Hashar) [12:05:18] (03CR) 10Addshore: "PS3 just rebased it" [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/116090 (owner: 10Hashar) [12:08:30] ori: you around ? [12:10:52] (03CR) 10Hiong3-eng5: "Kindly read my comment below. Thanks." (031 comment) [extensions/WikiLexicalData] - 10https://gerrit.wikimedia.org/r/116277 (owner: 10Purodha) [12:13:09] (03PS27) 10Hashar: (WIP) (WIP) visualeditor-doitall (WIP) (WIP) [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/100800 [12:31:58] (03PS2) 10Addshore: Split the rest of Action.php into /actions/ [core] - 10https://gerrit.wikimedia.org/r/115672 [12:35:39] (03PS6) 10Addshore: Move QueryPage.php to specialpage folder [core] - 10https://gerrit.wikimedia.org/r/109587 [12:35:50] (03CR) 10Addshore: "PS6 is a rebase" [core] - 10https://gerrit.wikimedia.org/r/109587 (owner: 10Addshore) [12:36:56] (03PS1) 10Matthias Mullie: (bug 59636) should not override global h1 and h2 style [extensions/Flow] - 10https://gerrit.wikimedia.org/r/116474 [12:38:12] (03CR) 10Matthias Mullie: "These comments were more helpful than what was in bugzilla :p" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/105426 (owner: 10Spage) [12:39:40] (03CR) 10Addshore: "I almost feel like we should do the opposite." [core] - 10https://gerrit.wikimedia.org/r/116290 (owner: 10Umherirrender) [13:11:38] (03PS1) 10Addshore: Refactor and GlobalConfigTest and improve coverage [core] - 10https://gerrit.wikimedia.org/r/116478 [13:27:26] (03PS1) 10Matthias Mullie: Header should render even if no header exists yet [extensions/Flow] - 10https://gerrit.wikimedia.org/r/116480 [13:29:38] Nemo_bis: what's --threshold? [13:43:54] (03PS28) 10Hashar: (WIP) (WIP) visualeditor-doitall (WIP) (WIP) [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/100800 [13:46:21] (03CR) 10PiRSquared17: "mw.msg or mw.message?" [extensions/ApiSandbox] - 10https://gerrit.wikimedia.org/r/116449 (owner: 10Gerrit Patch Uploader) [13:50:06] (03CR) 10PiRSquared17: "Siebrand, mind reviewing the latest patchset?" [core] - 10https://gerrit.wikimedia.org/r/104711 (owner: 10Legoktm) [13:53:51] (03PS1) 10Manybubbles: Introduce search timeouts [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/116481 [13:53:55] (03PS2) 10Purodha: Fix even more typos and morge branch 'master' of ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/WikiLexicalData [extensions/WikiLexicalData] - 10https://gerrit.wikimedia.org/r/116472 [13:56:35] liangent: the min percentage of translation [13:56:52] usually MediaWiki core languages are exported if they are at least 18 % translated [14:03:32] (03CR) 10Daniel Kinzler: [C: 04-1] "Definitely an improvement, I have several nitpicks though." (0312 comments) [core] - 10https://gerrit.wikimedia.org/r/80764 (owner: 10Burthsceh) [14:04:42] YuviPanda: did you brion ask this aobut https://gerrit.wikimedia.org/r/#/c/116142/ ? [14:08:38] (03PS1) 10Jackmcbarn: Allow passing parameters to preload [core] - 10https://gerrit.wikimedia.org/r/116482 [14:18:18] (03PS1) 10Lekshmi: Resetting img alt value as "0" [core] - 10https://gerrit.wikimedia.org/r/116483 [14:28:08] (03CR) 10Thiemo Mättig (WMDE): "Jforrester, could you please provide a real, actionable reason for your -1 or change your review?" [extensions/BetaFeatures] - 10https://gerrit.wikimedia.org/r/115885 (owner: 10Thiemo Mättig (WMDE)) [14:37:28] (03CR) 10Addshore: [C: 04-1] Fix incorrect usage of Title::newFromText (031 comment) [extensions/Echo] - 10https://gerrit.wikimedia.org/r/116273 (owner: 10Legoktm) [14:42:54] (03CR) 10Addshore: Load WikiEditor in textarea input (031 comment) [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/112642 (owner: 10Legoktm) [14:45:18] (03CR) 10Addshore: [C: 031] Have AUTHORS list display better on Special:Version/Credits [extensions/BetaFeatures] - 10https://gerrit.wikimedia.org/r/105432 (owner: 10Legoktm) [14:46:13] (03CR) 10Addshore: [C: 04-1] "needs manual rebase" [core] - 10https://gerrit.wikimedia.org/r/55056 (owner: 10John Erling Blad) [15:22:27] (03CR) 10Bartosz Dziewoński: [C: 032] Split the rest of Action.php into /actions/ [core] - 10https://gerrit.wikimedia.org/r/115672 (owner: 10Addshore) [15:25:49] (03Merged) 10jenkins-bot: Split the rest of Action.php into /actions/ [core] - 10https://gerrit.wikimedia.org/r/115672 (owner: 10Addshore) [16:05:47] (03CR) 10Mno2: "I'm seeing there is a abandon button only on patch set 3. I guess it means that I don't have to do anything, have I?" [extensions/BetaFeatures] - 10https://gerrit.wikimedia.org/r/110238 (owner: 10Mno2) [16:08:36] (03CR) 10UltrasonicNXT: [C: 032 V: 032] "Thanks!" [extensions/MediaWikiChat] - 10https://gerrit.wikimedia.org/r/116465 (owner: 10Shirayuki) [16:10:02] (03PS3) 10UltrasonicNXT: WIP - Rewrite [extensions/WikiForum] - 10https://gerrit.wikimedia.org/r/116258 [16:11:59] (03PS29) 10Hashar: (WIP) (WIP) visualeditor-doitall (WIP) (WIP) [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/100800 [16:12:06] (03CR) 10jenkins-bot: [V: 04-1] (WIP) (WIP) visualeditor-doitall (WIP) (WIP) [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/100800 (owner: 10Hashar) [16:13:30] (03CR) 10Hashar: "This now needs the Jenkins plugin "post build script" which I have installed in production. Patch upstreamed at https://review.openstack.o" [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/100800 (owner: 10Hashar) [16:13:46] (03PS2) 10BryanDavis: Add pythonic configuration [tools/scap] - 10https://gerrit.wikimedia.org/r/116455 [16:16:25] (03PS1) 10Deepali: Handling svg images in CSSMin::encodeImageAsDataURI() [core] - 10https://gerrit.wikimedia.org/r/116490 [16:16:57] (03CR) 10BryanDavis: Add pythonic configuration (033 comments) [tools/scap] - 10https://gerrit.wikimedia.org/r/116455 (owner: 10BryanDavis) [16:22:49] (03PS30) 10Hashar: (WIP) (WIP) visualeditor-doitall (WIP) (WIP) [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/100800 [16:22:53] (03CR) 10jenkins-bot: [V: 04-1] (WIP) (WIP) visualeditor-doitall (WIP) (WIP) [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/100800 (owner: 10Hashar) [16:27:51] (03PS3) 10Deepali: Display field "requiredness" on form [core] - 10https://gerrit.wikimedia.org/r/116230 [16:29:19] (03CR) 10Deepali: "Fixed the commit message." [core] - 10https://gerrit.wikimedia.org/r/116230 (owner: 10Deepali) [16:30:43] (03PS1) 10Ottomata: Using newly parametrized wikimetrics_path on wikmetrics::databbase class [vagrant] - 10https://gerrit.wikimedia.org/r/116493 [16:31:21] (03CR) 10Ottomata: [C: 032 V: 032] Using newly parametrized wikimetrics_path on wikmetrics::databbase class [vagrant] - 10https://gerrit.wikimedia.org/r/116493 (owner: 10Ottomata) [16:32:42] (03CR) 10MarkTraceur: "Patchset three is the only thing you *can* abandon." [extensions/BetaFeatures] - 10https://gerrit.wikimedia.org/r/110238 (owner: 10Mno2) [16:34:05] (03CR) 10Anomie: [C: 031] "Seems sane to me. Haven't tested." [core] - 10https://gerrit.wikimedia.org/r/116286 (owner: 10Umherirrender) [16:34:44] (03CR) 10MarkTraceur: "Oh, two replies." [extensions/BetaFeatures] - 10https://gerrit.wikimedia.org/r/110238 (owner: 10Mno2) [16:46:54] (03CR) 10Anomie: [C: 031] "Code looks fine to me, seems to work. I'll leave it to others to decide on mw.msg() (equivalent to mw.message().text(), apparently) versus" (032 comments) [extensions/ApiSandbox] - 10https://gerrit.wikimedia.org/r/116449 (owner: 10Gerrit Patch Uploader) [16:59:08] (03CR) 10Jforrester: "My -1 is verging on a -2; making a regression for all users to support < 5% of users is completely the wrong change to make. Your response" [extensions/BetaFeatures] - 10https://gerrit.wikimedia.org/r/115885 (owner: 10Thiemo Mättig (WMDE)) [16:59:53] (03PS1) 10Zfilipin: Forgot to add Amir to authors [ruby/api] - 10https://gerrit.wikimedia.org/r/116499 [17:00:13] (03CR) 10Anomie: Create Parser::stripInline to avoid code duplication (032 comments) [core] - 10https://gerrit.wikimedia.org/r/114942 (owner: 10Bartosz Dziewoński) [17:05:32] (03CR) 10Anomie: "Breaking BC in this edge case, to make the XML output slightly nicer. I'm really feeling "meh" about the whole thing, especially since the" [core] - 10https://gerrit.wikimedia.org/r/116291 (owner: 10Umherirrender) [17:06:51] (03PS1) 10Matthias Mullie: [WIP] Action menu updates [extensions/Flow] - 10https://gerrit.wikimedia.org/r/116501 [17:08:33] (03CR) 10Jforrester: "Follow-up done in bug 62153." [extensions/BetaFeatures] - 10https://gerrit.wikimedia.org/r/105432 (owner: 10Legoktm) [17:17:46] (03PS1) 10Ottomata: Using /etc/wikimetrics for wikimetrics config files, rather than in /vagrant [vagrant] - 10https://gerrit.wikimedia.org/r/116502 [17:18:08] (03CR) 10Ottomata: [C: 032 V: 032] Using /etc/wikimetrics for wikimetrics config files, rather than in /vagrant [vagrant] - 10https://gerrit.wikimedia.org/r/116502 (owner: 10Ottomata) [17:19:37] (03PS1) 10Thiemo Mättig (WMDE): Added and updated Doxygen comments in content handler and diff namespaces [core] - 10https://gerrit.wikimedia.org/r/116503 [17:20:33] hi Nikerabbit [17:20:37] that sentence made no sense :) [17:22:39] YuviPanda: do I ever? [17:30:28] (03CR) 10Umherirrender: "For JSON: A client has to check, if he gets a array and than can iterate over it. Now the client gets a empty array, so he can still itera" [core] - 10https://gerrit.wikimedia.org/r/116291 (owner: 10Umherirrender) [17:38:24] bd808: Did that scap screencast get put on Commons? [17:38:54] I'm not sure I trust asciinema.org. :-) [17:39:46] Gloria: I'm not sure how to put it on commons. It's javascript magic playing back data stored on their sever [17:40:17] Heh. [17:40:54] Oh well. [17:41:23] (03CR) 10Thiemo Mättig (WMDE): "> regression" [extensions/BetaFeatures] - 10https://gerrit.wikimedia.org/r/115885 (owner: 10Thiemo Mättig (WMDE)) [17:42:25] (03PS1) 10Hoo man: Update Wikidata to fix a Lua issue in client [core] (wmf/1.23wmf16) - 10https://gerrit.wikimedia.org/r/116508 [17:42:58] (03CR) 10Nikerabbit: "I was going to test whether https://github.com/wikimedia/mediawiki-extensions-Translate/blob/master/tag/SpecialPageTranslationMovePage.php" [core] - 10https://gerrit.wikimedia.org/r/80764 (owner: 10Burthsceh) [17:43:21] (03PS1) 10Hoo man: Update Wikidata to fix a Lua issue in client [core] (wmf/1.23wmf15) - 10https://gerrit.wikimedia.org/r/116509 [17:44:18] (03PS2) 10Krinkle: Various clean up and refactor to make mediawiki-core-npm faster [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/116125 [17:45:23] (03CR) 10Hoo man: [C: 032] Update Wikidata to fix a Lua issue in client [core] (wmf/1.23wmf16) - 10https://gerrit.wikimedia.org/r/116508 (owner: 10Hoo man) [17:45:32] (03CR) 10Hoo man: [C: 032] Update Wikidata to fix a Lua issue in client [core] (wmf/1.23wmf15) - 10https://gerrit.wikimedia.org/r/116509 (owner: 10Hoo man) [17:48:08] (03PS1) 10MarkTraceur: Update MultimediaViewer with some JS fixes [core] (wmf/1.23wmf16) - 10https://gerrit.wikimedia.org/r/116510 [17:48:33] (03CR) 10MarkTraceur: [C: 032 V: 032] Update MultimediaViewer with some JS fixes [core] (wmf/1.23wmf16) - 10https://gerrit.wikimedia.org/r/116510 (owner: 10MarkTraceur) [17:49:31] Hm. [17:50:05] (03Merged) 10jenkins-bot: Update Wikidata to fix a Lua issue in client [core] (wmf/1.23wmf16) - 10https://gerrit.wikimedia.org/r/116508 (owner: 10Hoo man) [17:50:07] (03Merged) 10jenkins-bot: Update Wikidata to fix a Lua issue in client [core] (wmf/1.23wmf15) - 10https://gerrit.wikimedia.org/r/116509 (owner: 10Hoo man) [17:53:01] (03PS1) 10Ottomata: Updating wikimetrics module to latest HEAD [vagrant] - 10https://gerrit.wikimedia.org/r/116512 [17:53:10] (03CR) 10Ottomata: [C: 032 V: 032] Updating wikimetrics module to latest HEAD [vagrant] - 10https://gerrit.wikimedia.org/r/116512 (owner: 10Ottomata) [17:53:54] (03CR) 10Parent5446: Allow passing parameters to preload (031 comment) [core] - 10https://gerrit.wikimedia.org/r/116482 (owner: 10Jackmcbarn) [17:55:30] (03PS3) 10Krinkle: Various clean up and refactor to make mediawiki-core-npm faster [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/116125 [17:55:33] (03PS1) 10Krinkle: Clean up comments in defaults.yaml and macro-scm.yaml [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/116514 [17:55:44] (03CR) 10Krinkle: [C: 032] Clean up comments in defaults.yaml and macro-scm.yaml [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/116514 (owner: 10Krinkle) [17:56:22] (03Merged) 10jenkins-bot: Clean up comments in defaults.yaml and macro-scm.yaml [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/116514 (owner: 10Krinkle) [17:56:25] (03CR) 10Krinkle: "Split off comment clean up into a separate change: I3b5c00d22ad0b926" [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/116125 (owner: 10Krinkle) [17:57:38] (03CR) 10Mwjames: "If you do this sort of re-factoring, please add some tests." [core] - 10https://gerrit.wikimedia.org/r/80764 (owner: 10Burthsceh) [17:57:51] (03PS1) 10Anomie: Special:Version: Treat AUTHORS.txt and CREDITS.txt as text, not wikitext [core] - 10https://gerrit.wikimedia.org/r/116515 [17:58:02] (03PS1) 10Anomie: Reformat AUTHORS as wikitext [extensions/BetaFeatures] - 10https://gerrit.wikimedia.org/r/116516 [17:58:11] (03PS1) 10Anomie: Reformat AUTHORS as wikitext [extensions/EventLogging] - 10https://gerrit.wikimedia.org/r/116517 [17:59:06] (03CR) 10Legoktm: [C: 04-1] "Yay, but can you rebase this on top of I5a5857fcfa07598ba4ce9ae5bbb4ce54a567d31e?" [core] - 10https://gerrit.wikimedia.org/r/116478 (owner: 10Addshore) [17:59:36] (03CR) 10Addshore: "Will do!" [core] - 10https://gerrit.wikimedia.org/r/116478 (owner: 10Addshore) [18:01:35] (03PS2) 10Anomie: Special:Version: Treat AUTHORS.txt and CREDITS.txt as text, not wikitext [core] - 10https://gerrit.wikimedia.org/r/116515 [18:02:38] oO [18:03:19] (03PS1) 10Aaron Schulz: Remove useless "src" param when wrapping doGetFileStatMulti() [core] - 10https://gerrit.wikimedia.org/r/116519 [18:22:56] (03CR) 10Aklapper: [C: 04-1] "Yeah, we need to rework this now with 4.4. Sorry. :(" [wikimedia/bugzilla/modifications] - 10https://gerrit.wikimedia.org/r/106883 (owner: 10Tinaj1234) [18:32:13] (03PS8) 10Manybubbles: Setup jenkins configuration [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/115193 [18:33:46] (03PS3) 10Phuedx: Make the toolbar respond to a content overflow [extensions/GettingStarted] - 10https://gerrit.wikimedia.org/r/115176 [18:33:49] (03CR) 10Mattflaschen: [C: 04-1] "I think we're trying not to have classes for browser states, where possible. E.g. we use to have mw-ui-disabled, but it was removed in ht" (032 comments) [core] - 10https://gerrit.wikimedia.org/r/116075 (owner: 10Pginer) [18:34:28] superm401 ^^ 1 character change fixed ie7 ;) [18:34:42] serves me right for not linting before i pushed [18:35:59] phuedx, ah, yeah, my IDE warns about that. [18:36:04] We should be able to get Jenkins to fail. [18:36:25] superm401: mine does /now/ ;) [18:36:32] superm401: agreed. jenkins should scream [18:40:18] phuedx, es3 seems promising, except that it doesn't work. [18:40:24] (03Abandoned) 10Jforrester: Reformat AUTHORS as wikitext [extensions/BetaFeatures] - 10https://gerrit.wikimedia.org/r/116516 (owner: 10Anomie) [18:40:34] It's supposed to support older IE compatibility. [18:40:40] Trying to update my local one now to see if that's it. [18:41:16] (03CR) 10Jforrester: [C: 032] Have AUTHORS list display better on Special:Version/Credits [extensions/BetaFeatures] - 10https://gerrit.wikimedia.org/r/105432 (owner: 10Legoktm) [18:41:22] (03Merged) 10jenkins-bot: Have AUTHORS list display better on Special:Version/Credits [extensions/BetaFeatures] - 10https://gerrit.wikimedia.org/r/105432 (owner: 10Legoktm) [18:42:35] (03CR) 10Jforrester: [C: 031] Special:Version: Treat AUTHORS.txt and CREDITS.txt as text, not wikitext [core] - 10https://gerrit.wikimedia.org/r/116515 (owner: 10Anomie) [18:42:49] phuedx, it works. :) My editor just had an old version loaded up. [18:42:54] Or rather, a different branch. [18:44:05] (03PS2) 10BryanDavis: Extract ProgressReporter for monitoring cluster_ssh progress [tools/scap] - 10https://gerrit.wikimedia.org/r/116399 [18:44:08] (03PS9) 10Manybubbles: Setup jenkins configuration [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/115193 [18:45:46] (03PS2) 10Jforrester: Move AUTHORS to AUTHORS.txt lest Special:Version think it is wikitext [extensions/EventLogging] - 10https://gerrit.wikimedia.org/r/116517 (owner: 10Anomie) [18:46:30] (03PS3) 10Jforrester: Move AUTHORS to AUTHORS.txt lest Special:Version think it is wikitext [extensions/EventLogging] - 10https://gerrit.wikimedia.org/r/116517 (owner: 10Anomie) [18:51:49] (03PS10) 10Manybubbles: Setup jenkins configuration [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/115193 [18:52:12] (03CR) 10jenkins-bot: [V: 04-1] Setup jenkins configuration [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/115193 (owner: 10Manybubbles) [18:53:02] (03CR) 10Anomie: "Not right now, but maybe after SecurePoll. I'm find with only supporting whatever we need for now as long it's documented somewhere." [extensions/ContactPage] - 10https://gerrit.wikimedia.org/r/113883 (owner: 10Reedy) [18:54:49] (03CR) 10Mattflaschen: "Can this check trailing commas? They break old versions of IE." [core] - 10https://gerrit.wikimedia.org/r/111963 (owner: 10Krinkle) [18:55:39] (03CR) 1001tonythomas: [C: 031] Changed deprecated $wgCopyrightIcon [core] - 10https://gerrit.wikimedia.org/r/109903 (owner: 10Lekshmi) [18:56:29] (03CR) 10Krinkle: "That should be covered by jshint (instead of jscs) if possible since that isn't strictly coding style in the case of javascript." [core] - 10https://gerrit.wikimedia.org/r/111963 (owner: 10Krinkle) [18:57:48] (03PS1) 10BryanDavis: Use common MW_DSH_ARGS in sync-wikiversions [tools/scap] - 10https://gerrit.wikimedia.org/r/116525 [18:58:33] (03PS11) 10Manybubbles: Setup jenkins configuration [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/115193 [18:58:43] oh jenkins, on day you'll like my browser tests.... [18:59:36] (03PS9) 10Krinkle: [WIP] Set up node-jscs via Grunt (and pass it) [core] - 10https://gerrit.wikimedia.org/r/111963 [19:01:45] (03CR) 10Anomie: [C: 04-1] "-1 per comments on ApiFlowOld in PS5 (since this is no longer marked WIP)." [extensions/Flow] - 10https://gerrit.wikimedia.org/r/107411 (owner: 10Legoktm) [19:03:52] (03PS1) 10Krinkle: [WIP] jshint: Enable 'es3' option [core] - 10https://gerrit.wikimedia.org/r/116527 [19:04:53] (03CR) 10Mwalker: [C: 032] Special:Version: Treat AUTHORS.txt and CREDITS.txt as text, not wikitext [core] - 10https://gerrit.wikimedia.org/r/116515 (owner: 10Anomie) [19:07:27] (03PS3) 10Bene: Add title to list item of language link [core] - 10https://gerrit.wikimedia.org/r/111159 [19:08:08] (03CR) 10Bartosz Dziewoński: Handling svg images in CSSMin::encodeImageAsDataURI() (033 comments) [core] - 10https://gerrit.wikimedia.org/r/116490 (owner: 10Deepali) [19:08:21] (03CR) 10jenkins-bot: [V: 04-1] [WIP] jshint: Enable 'es3' option [core] - 10https://gerrit.wikimedia.org/r/116527 (owner: 10Krinkle) [19:09:51] (03CR) 10Reedy: "I might get round to doing it myself, just not "now" either." [extensions/ContactPage] - 10https://gerrit.wikimedia.org/r/113883 (owner: 10Reedy) [19:10:05] (03CR) 10Anomie: [C: 031] "Seems sane. Haven't tested." [core] - 10https://gerrit.wikimedia.org/r/115860 (owner: 10Werdna) [19:12:23] (03PS12) 10Manybubbles: Setup jenkins configuration [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/115193 [19:14:13] phuedx, looks like Krinkle is working on putting it in core. I'll do the extensions. [19:15:59] (03CR) 10Kaldari: "If there are no more comments before tomorrow, I'll go ahead and merge it." [core] - 10https://gerrit.wikimedia.org/r/114085 (owner: 10Mattflaschen) [19:17:59] (03CR) 10Jackmcbarn: Allow passing parameters to preload (031 comment) [core] - 10https://gerrit.wikimedia.org/r/116482 (owner: 10Jackmcbarn) [19:19:24] (03CR) 10CSteipp: [C: 031] "I think it's a great feature, haven't tested though" [core] - 10https://gerrit.wikimedia.org/r/115902 (owner: 10Hashar) [19:19:26] (03PS13) 10Manybubbles: Setup jenkins configuration [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/115193 [19:20:05] (03PS2) 10Nemo bis: Remove ArticleFeedbackv5: abandoned [tools/release] - 10https://gerrit.wikimedia.org/r/112643 [19:20:09] (03CR) 10Reedy: [C: 032] Remove ArticleFeedbackv5: abandoned [tools/release] - 10https://gerrit.wikimedia.org/r/112643 (owner: 10Nemo bis) [19:20:11] (03Merged) 10jenkins-bot: Remove ArticleFeedbackv5: abandoned [tools/release] - 10https://gerrit.wikimedia.org/r/112643 (owner: 10Nemo bis) [19:21:15] ssh @gerrit.wikimedia.org -p 29418 GIVES Permission denied (publickey) ... any help? [19:21:24] (03Abandoned) 10Jackmcbarn: When logging feedback, use the page as the target [extensions/ArticleFeedbackv5] - 10https://gerrit.wikimedia.org/r/85338 (owner: 10Jackmcbarn) [19:21:24] ssh @gerrit.wikimedia.org -p 29418 GIVES Permission denied (publickey) ... any help? [19:21:37] rohit-dua: did you add your public key to gerrit? [19:21:43] yes [19:25:14] (03PS1) 10Mattflaschen: Enable ES3 option in jshint [extensions/GettingStarted] - 10https://gerrit.wikimedia.org/r/116531 [19:25:59] rohit-dua: are you using your correct username to connect via ssh ? [19:27:31] tonythomas: thank you. solved.. i was indeed using my other username [19:27:42] rohit-dua: happens ;) [19:28:44] (03PS1) 10Mattflaschen: Enable ES3 option in jshint [extensions/GuidedTour] - 10https://gerrit.wikimedia.org/r/116532 [19:31:29] ori, you might want to set that option (es3) in EventLogging too. [19:31:56] There are a couple issues in the tests. They might be false positives, not sure. Having the option could prevent future bugs, though. [19:32:42] (03PS2) 10Matthias Mullie: (bug 59636) should not override global h1 and h2 style [extensions/Flow] - 10https://gerrit.wikimedia.org/r/116474 [19:32:46] (03PS14) 10Manybubbles: Setup jenkins configuration [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/115193 [19:37:19] (03CR) 10Deepali: Handling svg images in CSSMin::encodeImageAsDataURI() (031 comment) [core] - 10https://gerrit.wikimedia.org/r/116490 (owner: 10Deepali) [19:45:05] (03CR) 10Mwalker: [C: 032] Add getMessage tests with Short and Long Contexts [core] - 10https://gerrit.wikimedia.org/r/114930 (owner: 10Addshore) [19:45:14] Krinkle, I think phuedx was wondering if you wanted to review the GuidedTour jsduck fix one more time: https://gerrit.wikimedia.org/r/#/c/86057/ [19:47:05] awight, I just noticed: https://gerrit.wikimedia.org/r/#/c/107422/ [19:47:07] what's up with it? [19:47:13] e.g. is it still needed? [19:48:51] (03PS2) 10Matthias Mullie: Header should render even if no header exists yet [extensions/Flow] - 10https://gerrit.wikimedia.org/r/116480 [19:49:25] git review -s GIVES .git/hooks/commit-msg: No such file or directory any help? [19:50:44] (03CR) 10Mwjames: "@MarkAHershberger Mark unless there are no further objections or nitpicks to this PR, can be please merge this or it will become one of th" [core] - 10https://gerrit.wikimedia.org/r/105092 (owner: 10Jeroen De Dauw) [19:51:01] rohit-dua: What does "git show HEAD" output? [19:51:40] Off-hand, it sounds like you're trying to submit a commit that has a blank commit summary. [19:51:56] Commit message, rather. [19:51:56] commit a59a042e1a7f1474a11c0bd2585ab2eb71b85c47 [19:51:56] Merge: 5c511f2 12c8449 [19:51:56] Author: Darkdadaah [19:51:56] Date: Sat May 25 08:49:21 2013 +0000 [19:51:56] Merge "TEST 1" [19:52:12] May 25, 2013? [19:52:25] That doesn't seem right... are you sure that's HEAD? [19:52:44] yes i did type git show HEAD [19:53:22] git show HEAD should show your commit. [19:53:25] Did you make a commit? [19:53:32] (03PS2) 10Thiemo Mättig (WMDE): Added and updated Doxygen comments in content handler and diff namespaces [core] - 10https://gerrit.wikimedia.org/r/116503 [19:55:22] andre__: Bug report re: alias field: https://bugzilla.wikimedia.org/show_bug.cgi?id=2007 looks super silly. [19:55:34] "(tracking) Tracking bug (tracking)" [19:55:43] rohit-dua: you need to install the commit-hook [19:55:57] docs used to be on wikitech, but unfortunately seems gone [19:56:06] rdwrer: yeah, feel free to remove the last (tracking). :) [19:56:24] rohit-dua: curl https://gerrit.wikimedia.org/r/tools/hooks/commit-msg > .git/hooks/commit-msg [19:56:24] I don't think that's the bug [19:56:25] rdwrer: I think in Bugzilla 5.0 the Alias will even be part of the title. Not sure if I'll like that [19:56:40] andre__: The problem should probably be resolved by styling the alias helpfully differently [19:56:40] it's "(Alias) Title" [19:56:52] oh, that should be doable. file me a bug report :) [19:56:59] AYE SAH [19:58:39] mwalker|skiretur: yes still needed, but low-priority. [19:58:53] mutante: thank you [19:59:18] andre__: https://bugzilla.wikimedia.org/show_bug.cgi?id=62160 shablam [19:59:37] rdwrer: Dekuju moc (Thanks a lot) [20:00:02] Mon plaisir [20:00:52] Andre ukazuje svou znalost českého jazyka. [20:01:07] not too bad, Mr Google Translate ;) [20:01:24] dobry den [20:01:29] rohit-dua: yw, that adds the special commit message for gerrit to it [20:01:36] andre__: hehe :) [20:02:43] (03Abandoned) 10Mattflaschen: mediawiki.api: Fix token with postWithToken, add test [core] - 10https://gerrit.wikimedia.org/r/83217 (owner: 10Mattflaschen) [20:03:05] please add an eggdrop with googletranslate.tcl version that works to the channels, thx [20:03:35] (03CR) 10Technical 13: Allow passing parameters to preload (031 comment) [core] - 10https://gerrit.wikimedia.org/r/116482 (owner: 10Jackmcbarn) [20:05:33] (03CR) 10Jackmcbarn: Allow passing parameters to preload (031 comment) [core] - 10https://gerrit.wikimedia.org/r/116482 (owner: 10Jackmcbarn) [20:12:56] (03PS10) 10Krinkle: Updates to jsduck setup and comments [extensions/GuidedTour] - 10https://gerrit.wikimedia.org/r/86057 (owner: 10Mattflaschen) [20:14:25] (03CR) 10Krinkle: [C: 031] "Changes made based on reviewing the generated documentation in a browser:" [extensions/GuidedTour] - 10https://gerrit.wikimedia.org/r/86057 (owner: 10Mattflaschen) [20:14:27] marcoil: [20:14:31] rdwrer: ^ [20:14:41] (sorry marc) [20:16:43] anomie: around? [20:16:59] (03CR) 10Technical 13: Allow passing parameters to preload (031 comment) [core] - 10https://gerrit.wikimedia.org/r/116482 (owner: 10Jackmcbarn) [20:17:11] jackmcbarn: Busy at the moment. Can I ping you in a few minutes? [20:17:17] anomie: kk [20:19:16] (03CR) 10Amire80: [C: 032] Forgot to add Amir to authors [ruby/api] - 10https://gerrit.wikimedia.org/r/116499 (owner: 10Zfilipin) [20:20:07] (03CR) 10Mattflaschen: "Reply re callables." (031 comment) [core] - 10https://gerrit.wikimedia.org/r/109850 (owner: 10Ori.livneh) [20:23:25] (03CR) 10MarkAHershberger: [C: 032] "so happy" [core] - 10https://gerrit.wikimedia.org/r/105092 (owner: 10Jeroen De Dauw) [20:23:28] (03CR) 10Anomie: "Not being at all familiar with Flow, I did the best I could." (036 comments) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/110090 (owner: 10Werdna) [20:24:19] jackmcbarn: ping [20:24:40] anomie: i found a slightly [[WP:BEANS]]y issue that's not quite a security bug. can i pm? [20:25:15] jackmcbarn: please do [20:27:17] (03Merged) 10jenkins-bot: Make it possible for extensions to specify which version of MediaWiki they support via Composer. [core] - 10https://gerrit.wikimedia.org/r/105092 (owner: 10Jeroen De Dauw) [20:28:07] (03CR) 10Mattflaschen: "There are only two /*!:" [extensions/GuidedTour] - 10https://gerrit.wikimedia.org/r/86057 (owner: 10Mattflaschen) [20:28:39] (03PS11) 10Mattflaschen: Updates to jsduck setup and comments [extensions/GuidedTour] - 10https://gerrit.wikimedia.org/r/86057 [20:28:59] (03CR) 10Jackmcbarn: Allow passing parameters to preload (031 comment) [core] - 10https://gerrit.wikimedia.org/r/116482 (owner: 10Jackmcbarn) [20:35:26] (03CR) 10Mwjames: "@MarkAHershberger Another thing Mark, could we see that this is backported to 1.22 so we have proper way of defining dependency [0]." [core] - 10https://gerrit.wikimedia.org/r/105092 (owner: 10Jeroen De Dauw) [20:38:39] (03CR) 10Mwjames: "Probably needs a rebase." [core] - 10https://gerrit.wikimedia.org/r/105114 (owner: 10Jeroen De Dauw) [20:47:18] (03CR) 10Chad: [C: 032] Use common MW_DSH_ARGS in sync-wikiversions [tools/scap] - 10https://gerrit.wikimedia.org/r/116525 (owner: 10BryanDavis) [20:47:46] (03Merged) 10jenkins-bot: Use common MW_DSH_ARGS in sync-wikiversions [tools/scap] - 10https://gerrit.wikimedia.org/r/116525 (owner: 10BryanDavis) [20:48:13] (03CR) 10Hashar: "It probably does not work in production which uses: 'udp://..../limiter'. Nothing shown on fluorine :-D" [core] - 10https://gerrit.wikimedia.org/r/115902 (owner: 10Hashar) [20:51:04] (03CR) 10Addshore: [C: 04-1] "Some initial comments, have definitely not managed to look at everything yet!" (039 comments) [core] - 10https://gerrit.wikimedia.org/r/116503 (owner: 10Thiemo Mättig (WMDE)) [20:54:58] (03PS2) 10Jeroen De Dauw: Add ComposerPackageModifierTest integration test [core] - 10https://gerrit.wikimedia.org/r/105114 [20:57:08] (03CR) 10jenkins-bot: [V: 04-1] Add ComposerPackageModifierTest integration test [core] - 10https://gerrit.wikimedia.org/r/105114 (owner: 10Jeroen De Dauw) [21:01:39] (03CR) 10Mwjames: "The error message doesn't make much sense:" [core] - 10https://gerrit.wikimedia.org/r/105114 (owner: 10Jeroen De Dauw) [21:02:41] (03PS1) 10Manybubbles: Speed up Status->getIndicesWithAlias [extensions/Elastica] - 10https://gerrit.wikimedia.org/r/116555 [21:07:14] (03CR) 10Addshore: "I suspect it is due to the" [core] - 10https://gerrit.wikimedia.org/r/105114 (owner: 10Jeroen De Dauw) [21:13:16] (03PS1) 10Aaron Schulz: Commit DB changes as normal on exception-based GUI errors [core] - 10https://gerrit.wikimedia.org/r/116625 [21:23:00] (03PS1) 10Manybubbles: Use Elastica's alias checking functions again [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/116626 [21:23:02] (03CR) 10Chad: [C: 032] Allow configuration of periodic task interval [core] - 10https://gerrit.wikimedia.org/r/115630 (owner: 10Manybubbles) [21:26:12] (03PS15) 10Manybubbles: Setup jenkins configuration [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/115193 [21:26:33] (03CR) 10MarkTraceur: [C: 04-1] "Little one, but otherwise fine." (031 comment) [extensions/GuidedTour] - 10https://gerrit.wikimedia.org/r/86057 (owner: 10Mattflaschen) [21:26:45] (03Merged) 10jenkins-bot: Allow configuration of periodic task interval [core] - 10https://gerrit.wikimedia.org/r/115630 (owner: 10Manybubbles) [21:31:07] (03CR) 10Chad: [C: 032] Introduce search timeouts [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/116481 (owner: 10Manybubbles) [21:31:12] (03Merged) 10jenkins-bot: Introduce search timeouts [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/116481 (owner: 10Manybubbles) [21:31:37] (03PS1) 10CSteipp: Add Updater for Oracle [core] - 10https://gerrit.wikimedia.org/r/116627 [21:34:53] (03PS2) 10Aaron Schulz: Commit DB changes as normal on exception-based GUI errors [core] - 10https://gerrit.wikimedia.org/r/116625 [21:38:40] anomie: around? [21:39:10] PiRSquared: For a few minutes yet [21:39:12] Are the qqq messages editable on TWN after they are created? [21:40:00] PiRSquared: I have no idea. Nemo_bis might know, or Nikerabbit. [21:40:11] Yes [21:40:20] Only en messages shouldn't be edited on tw [21:43:34] (03PS1) 10Reedy: Remove non en-gb messages from en-gb [extensions/ContactPage] - 10https://gerrit.wikimedia.org/r/116630 [21:44:20] Reedy: You do realize we have twn? [21:44:26] I do [21:44:30] I removed them from there last night [21:44:35] [21:44:09] Reedy: once exported you need to remove them at both places at once [21:44:46] Fun :P [21:44:53] Moved messages were fine, deleted ones not so much [21:45:16] feel free to +2 ;) [21:45:25] (03CR) 10Hoo man: [C: 032] Remove non en-gb messages from en-gb [extensions/ContactPage] - 10https://gerrit.wikimedia.org/r/116630 (owner: 10Reedy) [21:45:27] (03Merged) 10jenkins-bot: Remove non en-gb messages from en-gb [extensions/ContactPage] - 10https://gerrit.wikimedia.org/r/116630 (owner: 10Reedy) [21:45:35] convinced :D [21:46:09] (03PS1) 10Spage: Fix error page titles [extensions/Flow] - 10https://gerrit.wikimedia.org/r/116631 [21:46:24] hoo: do you realise we have a FAQ? :D [21:47:16] Nemo_bis: There are a billion FAQs, which one do you mean? :P [21:48:59] (03PS16) 10Manybubbles: Setup jenkins configuration [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/115193 [21:50:09] (03PS1) 10JGonera: Refactor the library [ruby/api] - 10https://gerrit.wikimedia.org/r/116632 [21:50:11] (03PS1) 10JGonera: Adding a basic delete_page function and adding more error handling [ruby/api] - 10https://gerrit.wikimedia.org/r/116633 [21:50:13] (03PS1) 10JGonera: Update readme with #delete_page [ruby/api] - 10https://gerrit.wikimedia.org/r/116634 [21:50:15] (03PS1) 10JGonera: Add Client#create_account [ruby/api] - 10https://gerrit.wikimedia.org/r/116635 [21:50:48] (03CR) 10Spage: "Get someone else to do the work?" (031 comment) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/116631 (owner: 10Spage) [21:53:31] (03CR) 10Chad: "The upstream library is actually MIT. I'm curious if it'd be better if we licensed this as MIT as well...it may not matter." [extensions/Elastica] - 10https://gerrit.wikimedia.org/r/116251 (owner: 10Reedy) [22:14:34] (03PS1) 10Foxtrott: bugfix (multiple definitions appear on the same line) [extensions/Lingo] - 10https://gerrit.wikimedia.org/r/116638 [22:16:50] (03CR) 10Foxtrott: [C: 032 V: 032] bugfix (multiple definitions appear on the same line) [extensions/Lingo] - 10https://gerrit.wikimedia.org/r/116638 (owner: 10Foxtrott) [22:17:06] (03Merged) 10jenkins-bot: bugfix (multiple definitions appear on the same line) [extensions/Lingo] - 10https://gerrit.wikimedia.org/r/116638 (owner: 10Foxtrott) [22:37:29] (03PS1) 10EBernhardson: Only generate date header when rendering is guaranteed [core] - 10https://gerrit.wikimedia.org/r/116648 [22:38:03] (03PS1) 10EBernhardson: New Hook rc/watchlist hook ChangesListBegin [core] - 10https://gerrit.wikimedia.org/r/116649 [22:50:17] (03CR) 10Bartosz Dziewoński: "Sorry, didn't know; I was added as a reviewer, it looked okay so I merged. If this shouldn't have been merged, just revert :)" [extensions/Echo] - 10https://gerrit.wikimedia.org/r/98256 (owner: 10Legoktm) [22:54:41] (03PS4) 10Mattflaschen: Upgrade XDebug, always enable, switch from apt to PECL [vagrant] - 10https://gerrit.wikimedia.org/r/113519 [22:54:51] (03CR) 10Ori.livneh: [C: 032] Upgrade XDebug, always enable, switch from apt to PECL [vagrant] - 10https://gerrit.wikimedia.org/r/113519 (owner: 10Mattflaschen) [22:54:55] (03Merged) 10jenkins-bot: Upgrade XDebug, always enable, switch from apt to PECL [vagrant] - 10https://gerrit.wikimedia.org/r/113519 (owner: 10Mattflaschen) [23:02:14] (03CR) 10Ori.livneh: "The bug is marked as resolved; is this still needed?" [extensions/EventLogging] - 10https://gerrit.wikimedia.org/r/116517 (owner: 10Anomie) [23:02:35] (03CR) 10Chad: [C: 032] Remove useless "src" param when wrapping doGetFileStatMulti() [core] - 10https://gerrit.wikimedia.org/r/116519 (owner: 10Aaron Schulz) [23:03:14] (03CR) 10Jforrester: "Yes. The bug "fix" means that AUTHORS.txt won't get wrongly-parsed as wikitext, but AUTHORS still will, so this change is necessary." [extensions/EventLogging] - 10https://gerrit.wikimedia.org/r/116517 (owner: 10Anomie) [23:06:23] (03CR) 10Anomie: "Either PS1 or PS3 is still needed, yes. Otherwise https://test.wikipedia.org/wiki/Special:Version/Credits/EventLogging will continue to lo" [extensions/EventLogging] - 10https://gerrit.wikimedia.org/r/116517 (owner: 10Anomie) [23:06:25] (03Merged) 10jenkins-bot: Remove useless "src" param when wrapping doGetFileStatMulti() [core] - 10https://gerrit.wikimedia.org/r/116519 (owner: 10Aaron Schulz) [23:07:46] (03PS1) 10Hashar: Actually apply the nature stylesheet [tools/releng] - 10https://gerrit.wikimedia.org/r/116663 [23:07:56] (03CR) 10Hashar: [C: 032] Actually apply the nature stylesheet [tools/releng] - 10https://gerrit.wikimedia.org/r/116663 (owner: 10Hashar) [23:09:16] (03Merged) 10jenkins-bot: Actually apply the nature stylesheet [tools/releng] - 10https://gerrit.wikimedia.org/r/116663 (owner: 10Hashar) [23:09:24] (03PS2) 10Chad: Update to 1.0.1.0 [extensions/Elastica] - 10https://gerrit.wikimedia.org/r/115948 (owner: 10Manybubbles) [23:10:11] (03CR) 10Chad: "Hijacking and going ahead with 1.0.1.0." [extensions/Elastica] - 10https://gerrit.wikimedia.org/r/115948 (owner: 10Manybubbles) [23:34:29] (03CR) 10Werdna: Extract wiki and external links, file and template usages from text. (032 comments) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/110090 (owner: 10Werdna) [23:49:54] (03CR) 10Parent5446: [C: 032] "Unfortunately there's not really a way to test this. But it looks good to me." [core] - 10https://gerrit.wikimedia.org/r/116627 (owner: 10CSteipp) [23:53:38] (03Merged) 10jenkins-bot: Add Updater for Oracle [core] - 10https://gerrit.wikimedia.org/r/116627 (owner: 10CSteipp)