[00:29:08] (03PS10) 10Legoktm: Make abstract Config class truly implementation-agnostic [core] - 10https://gerrit.wikimedia.org/r/109850 (owner: 10Ori.livneh) [00:29:52] (03CR) 10Legoktm: Make abstract Config class truly implementation-agnostic (034 comments) [core] - 10https://gerrit.wikimedia.org/r/109850 (owner: 10Ori.livneh) [00:31:12] (03CR) 10jenkins-bot: [V: 04-1] Make abstract Config class truly implementation-agnostic [core] - 10https://gerrit.wikimedia.org/r/109850 (owner: 10Ori.livneh) [00:36:12] legoktm: Are we there yet? :P [00:36:17] Jenkins says no [00:36:44] yeah, fixing that right now [00:36:52] I'm not sure what Daniel wants to do with the factory thing [00:40:35] the tests need work once we figure out what the interface is going to be. [00:40:43] (03PS11) 10Legoktm: Make abstract Config class truly implementation-agnostic [core] - 10https://gerrit.wikimedia.org/r/109850 (owner: 10Ori.livneh) [00:42:43] (03CR) 10jenkins-bot: [V: 04-1] Make abstract Config class truly implementation-agnostic [core] - 10https://gerrit.wikimedia.org/r/109850 (owner: 10Ori.livneh) [00:42:45] That's to be expected [00:43:25] blegh [00:43:38] oh right [00:43:47] I should probably run these locally first [00:45:16] (03PS12) 10Legoktm: Make abstract Config class truly implementation-agnostic [core] - 10https://gerrit.wikimedia.org/r/109850 (owner: 10Ori.livneh) [01:03:02] (03PS1) 10Purodha: Introduce ow_add_definition functin to API. [extensions/WikiLexicalData] - 10https://gerrit.wikimedia.org/r/116270 [01:11:54] (03PS1) 10Purodha: Fix mistyped file name.:wq [extensions/WikiLexicalData] - 10https://gerrit.wikimedia.org/r/116271 [01:23:40] (03CR) 10Physikerwelt: [C: 032] Add COPYING [extensions/Math] - 10https://gerrit.wikimedia.org/r/116244 (owner: 10Reedy) [02:37:14] (03CR) 10MZMcBride: Fix mistyped file name.:wq (031 comment) [extensions/WikiLexicalData] - 10https://gerrit.wikimedia.org/r/116271 (owner: 10Purodha) [02:42:53] (03CR) 10Hiong3-eng5: "Yes, the file name should be renamed. but it seems not renamed here." [extensions/WikiLexicalData] - 10https://gerrit.wikimedia.org/r/116271 (owner: 10Purodha) [02:59:18] (03CR) 10Hiong3-eng5: Introduce ow_add_definition functin to API. (034 comments) [extensions/WikiLexicalData] - 10https://gerrit.wikimedia.org/r/116270 (owner: 10Purodha) [03:06:40] (03CR) 10Hiong3-eng5: "Oh, its deleted. I think it is better to amend your original patch than create a new commit. :)" [extensions/WikiLexicalData] - 10https://gerrit.wikimedia.org/r/116271 (owner: 10Purodha) [03:20:01] (03PS2) 10Legoktm: Implement design by Prtksxna [extensions/AccountInfo] - 10https://gerrit.wikimedia.org/r/116268 [03:20:52] legoktm: o: [03:20:59] legoktm: Can I see it anywhere? [03:21:13] http://cl.ly/image/2j021N3x0g2l is what it is right now [03:22:14] let me put it on my labs wiki [03:22:15] What's the green? [03:22:33] that's what your current information is [03:22:42] but I want to make that more obvious somehow [03:22:45] Yeah. [03:22:51] Shoot design an e-mail. [03:22:55] https://www.mediawiki.org/wiki/Thread:Extension_talk:AccountInfo/Design [03:23:20] Thx. [03:23:24] This is great. [03:26:08] legoktm: You know I've never used that debug toolbar. [03:26:12] Is it useful? [03:26:26] Depends on what you're trying to debug [03:26:42] Fair enough. [03:26:55] I was messing with some mysql queries and it was useful for that [03:26:55] The line separators seem arbitrary to me. [03:27:07] I was going to e-mail wikitech-l about MariaDB optimizations. [03:27:19] I'm concerned, but I'm not sure if it's justified. [03:27:45] I'm concerned about people not using MariaDB. And I'm concerned about smaller wikis where the optimizer might act different. [03:27:50] I updated legoktm.wmflabs.org/wiki/Special:AccountInfo to include the design patch [03:27:52] differently * [03:28:07] MariaDB is not super different from MySQL right now. [03:28:11] On the HTTP protocol? [03:28:39] legoktm: Either are Blink and WebKit... yet. Give it time. [03:28:59] Hello, I was trying to determine the language direction(ltr or rtl) while implementing a beta feature. Here is my code: https://dpaste.de/nZ8C#L3,4,6 It gives me a recursion error. I know the relevant file is https://github.com/wikimedia/mediawiki-core/blob/master/includes/context/RequestContext.php but I am not able to figure out why it gives me the recurson error. [03:29:34] legoktm: so people will be able to CU themselves? [03:29:46] Jasper_Deng: basically [03:29:47] that actually is something that Google has been doing.... [03:29:51] Gloria: http://dom.as/2013/11/26/how-mysql-engineering-broke-the-backups/#comment-4046 [03:30:35] Jasper_Deng: The Google reports are next to worthless, from what I've seen. [03:30:51] Why would you want to CU yourself? [03:30:55] they provide almost the same amount of info, with geolocation, to boot [03:30:58] huh: in case someone was hacking in [03:31:12] paranoia_level++; [03:31:23] It's not self-CU, exactly. [03:31:56] Why are some stylesheets in mediawiki .css and some .less? [03:32:09] less was only introduced recently [03:32:18] and if you don't need to use less features...css is good enough [03:32:35] legoktm: Right, but the nesting mostly makes the CSS more readble [03:33:07] Jasper_Deng: wouldn't this help vandals know what the CUs/stews will be able to deduce? [03:33:33] not completely [03:33:40] AccountInfo won't give xff [03:33:53] (unless legoktm is going to correct me on that one too) [03:34:18] it will give XFF [03:34:20] legoktm: So moving any css to less won't be considered bad? Does it have any performance implications? [03:34:47] huh: There's an interesting bug report about this. :-) [03:34:50] prtksxna: technically less is slower because it requires a preprocessor, but I'm not sure how much slower...I don't think anyone has pointed out that its too slow [03:35:06] "It's not self-CU, exactly." [03:35:15] What is the difference, other than the special page name? [03:35:24] you can't CU others on your IP [03:35:57] and as you can tell, its purpose is different than CU [03:36:01] huh: Read the RFC and bug report for background. [03:36:12] huh: There's also a chat log... on one of the talk pages, maybe? [03:36:45] https://www.mediawiki.org/wiki/Requests_for_comment/Retained_account_data_self-discovery? [03:37:01] Yep. [03:37:10] The bug report is hopefully linked from that. [03:37:15] Yep [03:37:31] How long are IPs stored on Wikimedia sites currently? [03:37:39] such that CUs can access it [03:37:46] 90 days [03:37:49] approximately [03:37:56] not exactly? [03:37:59] Nope! [03:38:14] no, it's pretty exact [03:38:20] give or take a few seconds [03:38:20] huh: b/c it's enforced by a script [03:38:22] There's a cute algorithm in place for deleting the rows. [03:38:23] ^ [03:38:42] Okay, thanks [03:38:52] You can read the source of CheckUser to see the logic. [03:39:30] Gloria: I'm sure it's not in CU itself, I thought it was a server-side script [03:39:59] I think you're confused. [03:40:21] Or I am. :-) [03:40:34] I mean, the script is in the CU extension, etc. [03:40:48] legoktm: If I change any .css file to .less will everything "just work" or will I have to register it somewhere [03:40:49] why does https://www.mediawiki.org/wiki/Extension:Checkuser not mention it? [03:41:02] Maybe I'm thinking of RecentChanges? [03:41:14] prtksxna: it'll just work :) [03:41:15] One of them uses some access-based algorithm, I'm fairly sure. [03:41:15] idk about recentchanges [03:41:24] legoktm: So apple :P [03:42:22] https://git.wikimedia.org/blob/mediawiki%2Fextensions%2FCheckUser.git/e94ad6b467a5d4b88bebd83f09617a8719ef33d7/CheckUser.hooks.php#L221 [03:42:31] legoktm, Jasper_Deng: Every 100 edit, no? [03:42:37] Unless Wikimedia also runs the maintenance script? [03:42:38] Dunno. [03:42:43] That's what I was remembering. [03:42:49] there's a cron job for the maintence script [03:43:23] ^ [03:43:36] why isn't this documented in the extension documentation? [03:43:56] oh there /is/ a mention of this variable [03:44:35] Who wrote the debug toolbar? [03:45:50] nevermind ^ [03:46:40] Jasper_Deng, legoktm: Is the cron job probabilistic as well? :-) [03:46:46] no [03:46:47] Usually scripts like that are, as I recall. [03:46:52] It iterates through all wikis? [03:46:56] why the heck would you use rand like that? [03:46:59] (just asking) [03:47:06] Job runners do it. [03:47:15] To make it fairer for small wikis. [03:47:25] I guess. [04:00:11] I should get more credit for knowing about that obscure CU algorithm. [04:00:41] Er, I´ll reiterate. I was trying to determine the language direction(ltr or rtl) while implementing a beta feature. Here is my code: https://dpaste.de/nZ8C#L3,4,6 It gives me a recursion error. I know the relevant file is https://github.com/wikimedia/mediawiki-core/blob/master/includes/context/RequestContext.php but I am not able to figure out why it gives me the recurson error. [04:01:32] Niharika: use isRTL [04:01:33] with caps [04:02:37] but that shouldn't cause a recursion error ... [04:03:17] Niharika: does getLanguage() happen to trigger that hook? [04:03:29] that could cause a stack overflow [04:04:04] Other than that, you would need to give stack trace to debug [04:04:45] huh: getLanguage doesn´t trigger the hook..Hang on. I´ll copy the trace. [04:04:52] huh: http://legoktm.wmflabs.org/wiki/Special:AccountInfo [04:05:52] http://legoktm.wmflabs.org/w/index.php?title=Main_Page&diff=3&oldid=1 nice vandalism [04:07:04] https://dpaste.de/tdzK [04:08:25] Niharika: maybe someone else can help, that's a bit too cryptic for me [04:08:29] huh: There is another function in the same file which creates an instance of RequestContext too. [04:08:34] oh? [04:08:47] That could cause the recursion? [04:09:23] Possibly, but I would need to see it myself to tell you [04:09:41] maybe someone else can help [04:09:57] Okay, no problem. Thanks. [04:11:20] Gloria: is there a version of User::isAllowed that takes an action and a page? [04:12:23] Err, what? [04:12:27] What are you trying to do? [04:14:14] See if a user has the correct permissions to create a page before creating it in an extension? [04:14:42] Or does doEditContent already check for blocks, correct permissions, allowed in namespace, etc. ? [04:15:53] Dunno. [04:16:03] Look at what MassMessage does? [04:16:05] It makes edits. [04:16:22] * huh looks [04:17:55] so it uses the API [04:17:57] hm [04:18:13] Sounds sensible to me. [04:18:14] good idea [04:28:15] (03PS2) 10Prtksxna: mediawiki.debug: Migrate CSS to LESS [core] - 10https://gerrit.wikimedia.org/r/116272 [04:42:40] (03CR) 10MZMcBride: "Brian: thank you for working on this." [core] - 10https://gerrit.wikimedia.org/r/116227 (owner: 10Brian Wolff) [04:49:22] huh: $title->userCan( 'edit' ) [04:49:34] that only checks protection, and titleblacklist [04:49:42] legoktm: is that better or worse than using API? [04:49:48] you really should just use the API which will check abusefilter + spamblacklist and everything else [04:50:00] hm, ok [04:50:15] Yep. [05:56:14] (03PS3) 10Legoktm: Implement design by Prtksxna [extensions/AccountInfo] - 10https://gerrit.wikimedia.org/r/116268 [05:56:23] prtksxna, Gloria: ^ [05:56:27] gonna deploy that in a second [06:00:36] (03CR) 10Prtksxna: Implement design by Prtksxna (032 comments) [extensions/AccountInfo] - 10https://gerrit.wikimedia.org/r/116268 (owner: 10Legoktm) [06:01:58] legoktm: ^ [06:02:07] legoktm: Still need to fix the 91 days 0 hours :P [06:05:44] prtksxna: 0.8em looks pretty small on my computer [06:05:54] legoktm: :( 0.9? [06:06:23] that's better, but it's still small [06:06:37] can we just keep it the same size as the parsed user agent? [06:07:06] legoktm: Doesn't make sense, it lesser important information [06:07:08] The drawer might make more sense expanding across all the table columns. [06:07:15] legoktm: Must maintain heirarchiy [06:07:19] I'm not sure why the IP addresses are in a monospace font. [06:07:48] The drawer is also a reasonable place to clarify which data is for the current session. [06:07:54] Maybe. [06:07:58] Gloria: Used to reading it in monospace? [06:08:06] Who is? [06:08:08] -design? [06:08:14] http://hackertyper.net/ [06:08:41] that's why it's in monospace, i mean [06:08:51] ori: Vimum mode on chrome breaks that for me :( [06:09:25] legoktm: Why an extension again? Why not core? [06:09:28] The CU dependency? [06:09:41] yeah [06:09:57] ori: Did you get a change to see my mail? [06:10:02] chance [06:10:26] yeah, sorry := [06:10:33] s/:=/:\ [06:10:36] legoktm: Eh... why a separate extension? [06:11:08] as opposed to putting it in CheckUser? [06:11:22] I don't feel it fits, and the extension can be used without CU even being installed. [06:11:38] Then why not core? [06:12:11] because then implementing CU would be a pain [06:12:37] vimium looks neat [06:12:45] prtksxna: i'm not reading e-mails at the moment, i'm on vacation [06:12:57] i'm on irc to keep tabs on gloria [06:12:59] * Gloria NP: "The Power Of Love" by Celine Dion from "The Colour Of My Love" [06:13:03] ori: Its really nice :) [06:13:13] Vacation or the e-mail? [06:13:13] ori: Oh right, I forgot! [06:13:28] Gloria: vimium [06:13:33] Ah, right. [06:13:39] Such ambiguity. [06:13:46] http://sqlfiddle.com/ :O [06:14:04] 'cause I'm your ladyyyyyyyyyyyyyyyyyyyyyyyyyyyyyyyyyyyyyyyyyyyyyyyy. [06:15:13] (03PS4) 10Legoktm: Implement design by Prtksxna [extensions/AccountInfo] - 10https://gerrit.wikimedia.org/r/116268 [06:15:31] (03CR) 10Legoktm: Implement design by Prtksxna (032 comments) [extensions/AccountInfo] - 10https://gerrit.wikimedia.org/r/116268 (owner: 10Legoktm) [06:15:38] That commit message should be rewritten. [06:15:40] prtksxna: I just went with 0.9 for now [06:15:46] Gloria: be bold! [06:15:50] There's a Co-Author thing. [06:16:05] Maybe one day. [06:18:13] legoktm: Erm, why is IP Address not a link (as you wanted to) [06:18:36] legoktm: edits not showing up for me :( http://localhost:8080/wiki/Special:AccountInfo [06:18:54] didn't get to the link thing yet [06:19:02] legoktm: i can haz screenshot? [06:19:09] prtksxna: you have CU installed right? [06:19:30] prtksxna: http://cl.ly/image/401v1c0A3s14 [06:19:55] * Jasper_Deng guesses legoktm is going to make his extensions, at least new ones like this one, compatible w/ Composer [06:20:22] legoktm: Looks good. No, I didn't [06:20:33] prtksxna: just use the vagrant role ;) [06:20:42] Jasper_Deng: Dunno. I'm not sure about the whole composer thing yet [06:24:12] * prtksxna uses vagrant rols [06:24:16] s/rols/role [06:24:22] brb [06:26:43] http://cl.ly/image/2T030X0S292e [06:37:54] legoktm: Nice :D Uses moment().fromNow()? [06:38:10] legoktm: Also can you put the generated markup into a fiddle? I'll mess with the CSS there :) [06:39:22] prtksxna: no, that's all in PHP :) [06:39:34] legoktm: From page source, please :D [06:41:37] prtksxna: https://dpaste.de/DqAh/raw [06:43:19] (03PS5) 10Legoktm: Implement design by Prtksxna [extensions/AccountInfo] - 10https://gerrit.wikimedia.org/r/116268 [06:43:41] prtksxna: ^ that's the latest CSS too, I had to change the nth-child stuff since we added a new column [06:44:00] legoktm: Ah, right [07:43:48] (03PS6) 10Legoktm: Implement design by Prtksxna [extensions/AccountInfo] - 10https://gerrit.wikimedia.org/r/116268 [07:44:26] (03CR) 10Prtksxna: [C: 031] Implement design by Prtksxna [extensions/AccountInfo] - 10https://gerrit.wikimedia.org/r/116268 (owner: 10Legoktm) [07:49:17] (03PS7) 10Legoktm: New design for Special:AccountInfo [extensions/AccountInfo] - 10https://gerrit.wikimedia.org/r/116268 [07:50:38] (03PS8) 10Legoktm: New design for Special:AccountInfo [extensions/AccountInfo] - 10https://gerrit.wikimedia.org/r/116268 [07:51:19] (03CR) 10Legoktm: [C: 032 V: 032] New design for Special:AccountInfo [extensions/AccountInfo] - 10https://gerrit.wikimedia.org/r/116268 (owner: 10Legoktm) [07:57:50] (03CR) 10Legoktm: [C: 031] "Looks the exact same to me, but I'd prefer if someone who's more proficient at LESS to also look at it." [core] - 10https://gerrit.wikimedia.org/r/116272 (owner: 10Prtksxna) [08:01:08] sleeping ? [08:03:52] (03PS1) 10Legoktm: Fix incorrect usage of Title::newFromText [extensions/Echo] - 10https://gerrit.wikimedia.org/r/116273 [08:39:19] How will I add a custom manifest, say like https://github.com/example42/puppet-exim to my existing vagrant roles ? [08:39:52] I copied the manifests/*.pp to the original manifests.d/ directory, but exim is not showing up in my roles list [08:42:55] legoktm: Hi ! You around ? [09:38:25] (03CR) 10Parent5446: [C: 04-1] "Almost ready. Just a few minor issues." (035 comments) [extensions/Persona] - 10https://gerrit.wikimedia.org/r/112309 (owner: 10Donyu) [11:01:59] Was there any recent change (in the last month or so) with gerrit authentication? I can't seem to be able to ssh into gerrit any more from either of my machines, even though it was working fine before. [11:02:23] (I've checked all the usual suspects locally.) [11:38:33] guillom: Confirmed that the key is still present in your account on gerrit? [11:44:44] rdwrer: yup, still there and still the same [11:45:59] (03PS1) 10Purodha: Re-add renamed file. [extensions/WikiLexicalData] - 10https://gerrit.wikimedia.org/r/116277 [11:46:21] rdwrer: in the meantime, could I bother you for a minute and ask you to run this? http://www.gossamer-threads.com/lists/wiki/wikitech/283396#283396 [11:46:47] (when you have time) [11:47:50] * guillom is late for family lunch, will bbl. [13:37:46] (03PS1) 10Liangent: Create plural rules for variants of zh (Chinese) [core] - 10https://gerrit.wikimedia.org/r/116278 [13:44:49] (03PS2) 10Liangent: Create plural rules for variants of zh (Chinese) [core] - 10https://gerrit.wikimedia.org/r/116278 [13:46:21] (03PS3) 10Liangent: Create plural rules for variants of zh (Chinese) [core] - 10https://gerrit.wikimedia.org/r/116278 [14:39:24] moin @all, short question: if i type "git review -R" and get a "Creating a git remote called 'gerrit'" there is somthing wrong? [14:42:03] eckart: no, that's normal, git-review creates its own remote in addition to the 'origin' one you probably have [14:43:13] phuuu .... thx .... so now iam waiting for the next error ;) [15:12:24] (03PS7) 10Manybubbles: Setup jenkins configuration [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/115193 [15:26:22] (03PS1) 10Foxtrott: Follow-up Icc640545c4: More css stuff [extensions/Lingo] - 10https://gerrit.wikimedia.org/r/116279 [15:26:46] (03CR) 10Foxtrott: [C: 032 V: 032] Follow-up Icc640545c4: More css stuff [extensions/Lingo] - 10https://gerrit.wikimedia.org/r/116279 (owner: 10Foxtrott) [15:39:25] (03PS20) 1001tonythomas: Removed 'Remember my login' preference [core] - 10https://gerrit.wikimedia.org/r/94614 [16:05:30] Gloria: I have read the gerrit tutoria, but cannot get ssh to work [16:05:49] and the gerrit tutorial [16:06:16] huh: Windows or Linux? [16:06:29] huh: Can you please paste the exact SSH command you're running and its output? [16:06:43] If you can SSH into Labs, you should be able to SSH into gerrit.wikimedia.org without issue. [16:07:08] I'm trying to do it from Labs, multichill [16:07:22] (because in Windows you have some weird ssh issues) [16:07:47] is that okay? [16:08:10] yea ... windows, git and gerrit are creepy [16:08:11] Fucking Internet. [16:08:35] Excess Flood? [16:08:41] Wireless stupidity. [16:08:48] Anyway, what's the issue? [16:08:59] I tried to do it instead from Labs [16:09:04] ssh: connect to host gerrit.wikimedia.org port 22: Network is unreachable [16:09:38] should I do it from my own computer? [16:09:52] Yes. [16:10:00] wrongport .. wikimedia gerrit runs at port 29418 [16:10:02] then I'd need to install ssh, git, git-review, maybe other things [16:10:06] It won't work from tools-login. [16:10:11] oh, I have ssh [16:10:13] obviously [16:10:19] but not the others [16:10:32] eckart: Even specifying the appropriate port fails. [16:10:43] And you can connect to gerrit.wikimedia.org over port 22. [16:10:48] works from here ... also with putty [16:10:48] I believe. [16:10:48] Gloria: I tried it on bastion... would it be better in a tools account? [16:11:01] huh: No, do it from your local computeer. [16:11:04] Or from vagrant, I suppose. [16:11:08] ok, I'll try [16:11:12] If you don't want to do it from Windows. [16:11:19] You can use a virtual(ized) environment. [16:11:46] Permission denied (publickey). [16:11:56] huh: Paste the exact command you're running. [16:12:00] I've asked like nine times. [16:12:17] huh, you have to put in your pulic key to wikitech [16:12:33] I'm also fighting with Gerrit. I patched up a bug, I got a bunch of unrelated changes. Did https://www.mediawiki.org/wiki/Gerrit/Tutorial#git_review_complains_about_multiple_commits [16:12:38] (Port 22 will fail. My .ssh/config sets it for me.) [16:12:46] But I still have a couple of leftover I can't get out [16:12:53] multichill: Just ignore them and commit? [16:12:59] You probably won't break anything. [16:13:00] ssh pirsquared@gerrit.wikimedia.org [16:13:04] Permission denied (publickey). [16:13:13] My public key is on wikitech already [16:13:20] huh: Try "ssh -p 29418 pirsquared@gerrit.wikimedia.org" [16:13:45] ohhhhh, thanks [16:14:02] huh: Somewhere on your computer there is likely a directory (a folder) called ".ssh". [16:14:05] You should find that. [16:14:16] it works with the correct port number [16:14:26] You can make a file called "config" inside where you can specify the port number. [16:14:37] what format? [16:14:39] Then you won't need to specify it so often. [16:15:11] http://p.defau.lt/?joVodNUYrg4bS5wuvw8_wg [16:15:15] That's mine. [16:16:03] but linux ? ;) [16:16:22] OS X. I think Windows has the same thing. [16:16:39] Because people usually install some emulator. [16:16:48] windwos is using backslashes ;) [16:17:04] Then it would be in .ssh\config [16:17:08] Shrug. [16:18:16] and yes, there is a hidden directory called .ssh in c:\xxxxx\\ [16:19:35] dont know the exact english called directory behind the c ;) ... in german its called "Dokumente und Einstellungen" ... on XP ... dont have a win7 running at the moment [16:19:38] No, it will be .ssh/config [16:19:44] git bash uses proper file paths [16:19:47] * huh is not using Windows [16:19:53] What are you using? [16:20:04] OS X, but I also can run Linux is needed [16:20:11] as needed [16:20:14] Oh, OS X should be trivial. [16:20:43] huh: Install homebrew. [16:20:47] If you haven't already. [16:21:15] Does that work w/o XCode? [16:21:28] No. [16:21:38] You'll need to download and install XCode as well. [16:21:41] It's several gigs. [16:21:57] Krenair: you are rigt, the git bash use forward slashes, but if you search the file in the normal explorer .... ;) [16:24:01] anyway, has someone get it running to push a patch under windows? my bash is showing "Creating a git remote called gerrit taht maps to ssh:/ ...." since 2 hours *g* [16:24:25] Nobody develops on Windows directly... [16:24:30] You use an emulator of some kind. [16:24:40] Whether that's a virtual box, cygwin, git bash... [16:25:56] i dont deveolpe on my windows .. and i dont use a git/gerrit on my production system .. so should i run a virtual linux on my windows only to push a simple patch? [16:26:13] huh: are you still having ssh issues? [16:26:46] I had ssh issues earlier today, and was wondering if it was on my end or not since it used to work about a month ago. [16:26:58] eckart: If you're using Windows, you probably want to use MediaWiki-Vagrant, yeah. [16:27:10] guillom: What kind of issues? [16:27:32] Gloria: whats that? [16:27:36] eckart, I have it working under windows [16:27:41] Gloria: Good ol' access denied. [16:27:41] !vagrant [16:27:42] There is no such key, you probably want to try: !vagrant, [16:27:44] goodness knows how but I figured it out [16:27:49] !vagrant, [16:28:05] I swear to fucking God that bot gets more and more retarded every day. [16:28:10] :D [16:28:15] lol [16:28:26] https://www.mediawiki.org/wiki/MediaWiki-Vagrant [16:28:31] eckart, maybe I can help though. what command were you running when it stopped? [16:28:57] the last command was git review -R (fro the tutorial) [16:29:18] try using ctrl+c to kill the command, and trying again [16:30:11] (03PS1) 10GBT248: Preferences.php: avoid "Undefined index" if key 'realname' don't exist in $formdata Added additional check for missing key "realname" in $formData which can cause an undefined index: realname (see bug 62029 fo details) [core] - 10https://gerrit.wikimedia.org/r/116282 [16:30:17] Could I bother someone for a quick gerrit query, since I can't get it to work at the moment? https://www.mediawiki.org/wiki/Wikimedia_engineering_report/How_to#Fill_out_the_Metrics_box [16:30:56] aargll [16:31:00] I wonder if petan secretly modifies the bot daily. [16:31:02] Just breaking random shit. [16:31:10] It really isn't rocket science to set up and maintain an IRC bot. [16:32:05] gngngngng ... 2hours waiting for nothing ... [16:32:37] patch uploaded ... i think so .. the bot is teling it :D [16:32:38] guillom: That's not simple, exactly. That query requires tweaking. [16:32:41] yay [16:33:15] Gloria: hm; ok. I usually just use mark's script from http://www.gossamer-threads.com/lists/wiki/wikitech/283396#283396 [16:33:20] (03PS2) 10Alex Monk: Preferences.php: avoid "Undefined index" if key 'realname' don't exist in $formdata [core] - 10https://gerrit.wikimedia.org/r/116282 (owner: 10GBT248) [16:33:40] If it's too complicated, I'll just try harder to get ssh to work. [16:33:51] guillom: Yeah, let's fix your SSH. [16:34:00] guillom: Paste the exact command and error you're receiving. [16:34:29] eckart, did you bother working out the code style from the code around it? [16:34:31] I don't have Mark's script, of course. [16:34:37] Or better, read the CC/PHP page? [16:34:43] Don't abbreviate, please. [16:34:52] Or at least do it in a link. [16:36:18] Gloria: http://pastebin.ca/2650125 [16:36:19] (03CR) 10Alex Monk: [C: 04-1] Preferences.php: avoid "Undefined index" if key 'realname' don't exist in $formdata (032 comments) [core] - 10https://gerrit.wikimedia.org/r/116282 (owner: 10GBT248) [16:36:29] yes and no ... iam getting the error in my apache error log and it tooks me 6hours to find the right position where the error was generated [16:36:50] after found it there are no probs to write the 3 lines ;) [16:37:11] It's not asking for my passphrase, but I have no idea why. [16:39:17] debug3: Could not load "/home/gpaumier/.ssh/wikimedia-key" as a RSA1 public key [16:39:19] doesn't look good [16:39:31] hmm [16:40:04] FTR, I can connect to github with the exact same setup (just a different key). Files locations / permissions are the same. [16:40:41] you sure you put your public key in gerrit? [16:40:46] And it worked 4 weeks ago when I ran that gerrit command, and I haven't touched the keys since. [16:40:52] Yeah, it's been there for ages. [16:41:10] Maybe I'll try to add a second key an see how that goes. [16:41:15] and* [16:42:36]