[00:06:02] (03CR) 10Mwalker: [C: 032] Expand MWException tests [core] - 10https://gerrit.wikimedia.org/r/115608 (owner: 10Addshore) [00:13:35] (03PS7) 10BryanDavis: Remove '--versions', run_on_cluster, build_command, sudo_args and cluster_run [tools/scap] - 10https://gerrit.wikimedia.org/r/116068 (owner: 10Ori.livneh) [00:21:45] (03CR) 10BryanDavis: [C: 04-1] "I'd like to keep support for specifying versions to sync (see comments on I6220c0d) and the short description of the command makes the clu" (033 comments) [tools/scap] - 10https://gerrit.wikimedia.org/r/116068 (owner: 10Ori.livneh) [00:24:58] Is anyone able to explain how Jenkins tests on a MediaWiki extension pull in inter-extension dependencies? [00:25:49] I found that the ContributionTracking schema upgrade causes DonationInterface tests to fail, but after fixing the upstream (CT) bug, there is no improvement in the DI jenkins tests. [00:26:03] for context: https://integration.wikimedia.org/ci/job/mwext-DonationInterface-runtests/328/console [00:35:56] (03PS3) 10Catrope: Update OOjs UI to v0.1.0-pre (51f922ba17) [core] - 10https://gerrit.wikimedia.org/r/116042 (owner: 10Jforrester) [00:36:14] (03CR) 10Jforrester: [C: 031] Update OOjs UI to v0.1.0-pre (51f922ba17) [core] - 10https://gerrit.wikimedia.org/r/116042 (owner: 10Jforrester) [00:37:19] (03CR) 10Catrope: [C: 032] Update OOjs UI to v0.1.0-pre (51f922ba17) [core] - 10https://gerrit.wikimedia.org/r/116042 (owner: 10Jforrester) [00:40:53] (03Merged) 10jenkins-bot: Update OOjs UI to v0.1.0-pre (51f922ba17) [core] - 10https://gerrit.wikimedia.org/r/116042 (owner: 10Jforrester) [00:46:10] self: ok, found a bunch of stuff in integration/jenkins which makes it look like we always use the master branch of core and extensions. [00:55:30] I officially have no clue how MW extensions are being pulled from Jenkins testing. fetch-mw-ext is not called with arguments... [01:07:21] (03PS1) 10Adamw: DonationInterface tests depend on ContributionTracking [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/116197 [01:11:22] (03PS1) 10BryanDavis: Remove obsolete scripts [tools/scap] - 10https://gerrit.wikimedia.org/r/116198 [01:11:24] (03PS1) 10BryanDavis: Replace scap-1 with sync-common [tools/scap] - 10https://gerrit.wikimedia.org/r/116199 [01:22:04] (03CR) 10Adamw: [C: 032] Move hooks to separate file/class [extensions/Campaigns] (wip/editorcampaigns) - 10https://gerrit.wikimedia.org/r/116056 (owner: 10AndyRussG) [01:23:26] (03CR) 10Adamw: [C: 04-1] "It's shiny... but can you justify what DI will be used for?" [extensions/Campaigns] (wip/editorcampaigns) - 10https://gerrit.wikimedia.org/r/116153 (owner: 10AndyRussG) [01:30:43] (03CR) 10MaxSem: "Has there been a cross-team discussion of using Symphony in production? Has it passed security and architecture review?" [extensions/Campaigns] (wip/editorcampaigns) - 10https://gerrit.wikimedia.org/r/115853 (owner: 10AndyRussG) [01:35:32] (03PS1) 10Reedy: Die gracefully if CentralAuthUser class doesn't exist [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/116208 [01:36:07] Reedy: hahahahahah :D [01:36:31] I couldn't find the script I wrote for this last time around :( [01:36:44] at least you did that for me :D [01:37:01] I was already on terbium to hit of :P [01:37:06] (03CR) 10Hoo man: [C: 032] Die gracefully if CentralAuthUser class doesn't exist [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/116208 (owner: 10Reedy) [01:37:10] (03Merged) 10jenkins-bot: Die gracefully if CentralAuthUser class doesn't exist [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/116208 (owner: 10Reedy) [01:37:43] I think there's another minor bug in the HTMLForm additions anomie|away did... [01:37:45] [01:37:54] I see that on enwiki at https://en.wikipedia.org/w/index.php?title=Special%3ACentralAuth&target=TBloemink [01:38:05] In the Set global account status checkbox [01:38:11] Reedy: I think that's broken for longer [01:38:43] I saw taht before, but forgot about it [01:39:48] why can't I see special:centralauth on enwiki, yikes [01:39:55] I mean the steward part [01:40:09] Log in/out? [01:40:15] am logged in [01:40:19] Might just be cached userrights [01:40:29] I mean, log out of enwiki and log back in again [01:40:37] trying [01:41:20] nope [01:42:19] (03Abandoned) 10Mwalker: test [extensions/FundraisingChart] - 10https://gerrit.wikimedia.org/r/116008 (owner: 10Mwalker) [01:42:57] > $u->addGroup( 'sysop' ); $u->removeGroup( 'sysop' ); [01:42:59] still not [01:44:17] sysadmins have that rights globally... stewards haven't [01:44:19] what a mess [01:44:33] I just did User::newFromName( 'Hoo_man' )->invalidateCache(); [01:44:51] Reedy: Tried that before :P [01:45:02] DELETE FROM user WHERE... [01:45:02] It's just how it's supposed to be [01:45:34] could make myself a system administrator (and am eligible for that), not sure it's a sane idea, though [01:45:59] Usernames don't contain underscores. [01:46:16] Gloria: new from name will catch that [01:46:29] Probably. Just the same. [01:46:30] also I did it with 'Hoo man' [01:46:47] mediawiki, fuck yeah [01:47:15] I like how we do it the other way round in Wikidata... spaces in titles, ftw :D [01:48:42] hoo: btw, congrats on becoming a steward [01:49:11] thanks bawolff :) [01:49:36] hop is a steward now? Nice. [01:49:42] hoo * [01:49:49] I should really just disable auto-correct. [01:50:17] > echo wfMessage( 'ipbreasonotherlist' )->text(); [01:50:17] <ipbreasonotherlist> [01:50:18] on en [01:50:21] but meta is fine [01:50:36] * bawolff likes it when people who win steward elections are people I actually know [01:50:52] SPQRobin too [01:51:01] or do you mean know afk too? [01:51:18] ajraddatz, Hoo_man, Meno25, Rschen7754, Savh, Shanmugamp7, SPQRobin, TBloemink [01:51:25] I mean know in the most broad, have actually heard the name of before [01:51:37] So that includes SPQRobin and Rschen7754 [01:51:40] too [01:54:49] Hmm, also reading the steward election page led me to discover there is such a thing as global sysops... [01:54:57] I really need to get out in the community more ;) [01:55:26] hoo: FYI https://github.com/reedy/wikimedia-stuffs/blob/master/updateiwcache [01:56:17] Reedy: Nice :) I need to actually get around fixing this though [01:56:36] fixing? [01:57:04] Reedy: I mean CentralAuth... introduce a new message there and don't really on the one which has been removed from core ages ago [01:57:14] they locally overrode it on meta and didn't tell anyone... [01:57:36] s/really/rely/ [01:57:39] sweet [01:58:05] (03CR) 10Hoo man: [C: 032] Add flaggedrevs-hidereviewed show / hide i18n messages [extensions/FlaggedRevs] - 10https://gerrit.wikimedia.org/r/116054 (owner: 10Aude) [01:58:11] (03Merged) 10jenkins-bot: Add flaggedrevs-hidereviewed show / hide i18n messages [extensions/FlaggedRevs] - 10https://gerrit.wikimedia.org/r/116054 (owner: 10Aude) [01:58:27] Reedy: there's a couple of backports you'll also need to do before 'pedia goes wmf16 [01:58:41] maybe I can handle those myself on Monday, if I have mortal then :P [01:58:53] Déjà vu [01:59:22] https://meta.wikimedia.org/w/index.php?title=MediaWiki:Ipbreasonotherlist&action=history Classical... [02:00:02] * Reedy kicks Jamesofur [02:00:11] OUCH [02:00:14] ah, there are bugs, but nobody cared to CC me [02:00:17] wanta do my wiki? [02:00:19] :D [02:01:03] hoo: I told people :P I filed a bug [02:01:11] hoo: You could become like Snowolf and be CC'd on everything on bugzilla... [02:01:25] I overrode it on commons too, I just didn't want it sitting there looking unusable. [02:01:27] * Jamesofur looks for bug [02:01:27] Reedy: I could also just disable my inbox :P [02:01:40] Jamesofur: Already got it [02:01:42] both actually [02:01:44] coo [02:03:36] Looks like I don't have any more caffeine around (unless I make tea or coffee or so...)... [02:04:36] oh, I actually already wrote a patch for that [02:04:53] Author: Marius Hoch [02:04:53] Date: Wed Dec 18 00:31:55 2013 +0100 [02:04:53] Don't try to use the now removed ipbreasonotherlist message [02:05:00] hoo: I think it's bedtime [02:05:01] * hoo self slaps [02:05:20] not in gerrit, though *sigh* [02:08:56] I see why :P [02:18:43] Reedy: it's not everything :P [02:19:01] It's almost everything :D [02:19:25] * hoo strangles MediaWiki [02:19:28] Eh, I imagine I'm CC'd on more bugs than Snowolf. [02:19:41] Maybe not. I'm not auto-CC'd on anything. [02:20:06] "the old version used an implicted ->parse here (via toString), while the new version uses an explicit ->text" [02:20:16] Reedy: so want to make my wiki? ;) (also why are you still awake/working :P ) [02:20:32] Blame Snowolf [02:20:38] Creating a wiki and creating an accessible wiki are distinct. [02:20:39] * Snowolf is sorry [02:20:50] You need to update DNS. [02:21:04] Jamesofur: Has someone done that? [02:21:05] Gloria: true, I should specify I'd like to access it if possible, though I'd settle for moving forward so that I can poke someone else later [02:21:20] I'd recommend filing an RT ticket about updating DNS. [02:21:23] That requires ops. [02:21:34] At least I think it still does. [02:21:34] He can make the change to the dns git repo though [02:21:35] doubtful, no one has updated the bug at least, other then for the fact that Parsoid apparently not supports it [02:21:46] s/not/now/ [02:21:55] that, yes, [02:22:06] Jamesofur: Reedy says you can submit a change for the DNS tweak. [02:22:07] perhaps it's getting close to time to migrate home here too, though not nearly as late [02:22:10] Do that. :-) [02:22:18] yes, I will do that :) [02:22:23] I can't find the damn bug [02:22:38] https://bugzilla.wikimedia.org/show_bug.cgi?id=61222 [02:22:43] (03CR) 10Hoo man: [C: 032] "Works fine, please have a look at the inline comment" (031 comment) [core] - 10https://gerrit.wikimedia.org/r/116137 (owner: 10Bartosz Dziewoński) [02:22:52] thanks Gloria [02:23:02] (03PS1) 10Hoo man: SpecialRecentchanges: Don't use nonexistent messages for filter selector [core] (wmf/1.23wmf16) - 10https://gerrit.wikimedia.org/r/116215 [02:23:21] Reedy: ^ [02:23:40] Jamesofur: Also needs apache config first [02:23:52] That should be fairly simple/copy and paste exercise [02:24:05] * Jamesofur nods [02:24:34] Jamesofur: Can't you just hijack a currently unused private wiki? [02:24:41] I'm sure there are a few. [02:26:25] possibly, though I know people have seemed highly unhappy about the idea of renames etc. Seemed to make the most sense just starting fresh (though I do think we should get rid of wikis we don't actually need, especially private ones, seems to be just asking for private information to be sitting around) [02:27:26] (03Merged) 10jenkins-bot: SpecialRecentchanges: Don't use nonexistent messages for filter selector [core] - 10https://gerrit.wikimedia.org/r/116137 (owner: 10Bartosz Dziewoński) [02:28:27] hoo: wmf15 too? [02:28:47] don't think so, let me verify [02:29:51] Reedy: Not needed, only wmf16 [02:30:14] Cool [02:33:46] Jamesofur, which wiki do you need parsoid support for? [02:34:04] gwicke: He's talking about the legalteamwiki Parsoid change. [02:34:06] gwicke: it appears you already did it with https://gerrit.wikimedia.org/r/#/c/112716/ [02:34:27] well s/you/James_F [02:34:32] yeah, that's deployed [02:35:31] Jamesofur: Happy to help. [02:35:41] :) [02:45:16] gwicke, did you find time to work on tassembly this week? [02:47:17] mwalker, not very much [02:47:22] https://github.com/gwicke/tassembly [02:48:04] there is nothing major that needs to change though apart from some features [02:48:04] heh; not since tues :) -- kk, I might have some time to work on it on sunday; it'll just be basic initial stuff though [02:48:14] ok; we'll see how far I get [02:48:29] awesome [02:48:48] I think just tassembly without the compilation bit is short enough in any case [02:49:21] kk [02:49:40] you really only need render and things used by that [02:50:36] can check if closures can be faster in hhvm later, but I doubt it based on the numbers from calling closure helpers in the PHP template benchmarks [02:51:17] see the 'using lambda' entries in https://www.mediawiki.org/wiki/Requests_for_comment/HTML_templating_library#Performance [02:51:18] good night [02:52:32] hoo, night [02:52:48] ;) [02:53:45] heh; ya... that's not promising looking [02:57:26] (03PS1) 10Brian Wolff: Fix __toString method of DatabaseMysqli [core] - 10https://gerrit.wikimedia.org/r/116217 [02:59:12] mwalker, I intend to implement the bits needed to run all of the benchmarks & re-run all of them [02:59:33] might hack on it a bit over the weekend [03:00:55] the only thing missing is lambdas I think [03:02:09] (03CR) 10Mno2: "As you can see, I've sent patch set 2 to review and then noticed that there is a line that should not be there. I corrected it and submitt" [extensions/BetaFeatures] - 10https://gerrit.wikimedia.org/r/110238 (owner: 10Mno2) [03:28:40] (03CR) 10Bencmq: Allow extension of post interaction links (032 comments) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/115552 (owner: 10Wctaiwan) [03:29:45] Reedy: we seem to have some *.wikimedia.org private wikis in remnant.conf and some in wikimedia.conf ... do you know where it 'should' be? [03:32:17] (03PS3) 10Bencmq: Allow extension of post interaction links [extensions/Flow] - 10https://gerrit.wikimedia.org/r/115552 (owner: 10Wctaiwan) [03:32:45] (03PS7) 10Mattflaschen: Updates to jsduck setup and comments [extensions/GuidedTour] - 10https://gerrit.wikimedia.org/r/86057 [03:41:59] (03PS8) 10Mattflaschen: Updates to jsduck setup and comments [extensions/GuidedTour] - 10https://gerrit.wikimedia.org/r/86057 [03:45:06] (03PS9) 10Mattflaschen: Updates to jsduck setup and comments [extensions/GuidedTour] - 10https://gerrit.wikimedia.org/r/86057 [03:49:41] (03CR) 10Mattflaschen: "Patch set 7 is a rebase." [extensions/GuidedTour] - 10https://gerrit.wikimedia.org/r/86057 (owner: 10Mattflaschen) [03:51:59] (03CR) 10AndyRussG: "Hi MaxSem, and thanks!!" [extensions/Campaigns] (wip/editorcampaigns) - 10https://gerrit.wikimedia.org/r/115853 (owner: 10AndyRussG) [04:15:21] (03CR) 10Aaron Schulz: [C: 032] Fix __toString method of DatabaseMysqli [core] - 10https://gerrit.wikimedia.org/r/116217 (owner: 10Brian Wolff) [04:16:32] (03CR) 10Santhosh: [C: 032] Fix for CLDR plural rule parser for old browsers without String.trim [core] - 10https://gerrit.wikimedia.org/r/116159 (owner: 10Brion VIBBER) [04:18:55] (03Merged) 10jenkins-bot: Fix __toString method of DatabaseMysqli [core] - 10https://gerrit.wikimedia.org/r/116217 (owner: 10Brian Wolff) [04:19:45] (03Merged) 10jenkins-bot: Fix for CLDR plural rule parser for old browsers without String.trim [core] - 10https://gerrit.wikimedia.org/r/116159 (owner: 10Brion VIBBER) [05:12:26] (03CR) 10Brian Wolff: "The fallback code for if fsockopen is missing totally doesn't work for me. Triggering it causes apache to return a 204 with no content for" [core] - 10https://gerrit.wikimedia.org/r/113038 (owner: 10Aaron Schulz) [05:26:11] (03CR) 10Brian Wolff: "Perhaps we should go back to doing jobs at the end of the request just normally. It seems like the various possible work around all have i" [core] - 10https://gerrit.wikimedia.org/r/113038 (owner: 10Aaron Schulz) [05:33:31] (03PS2) 10Brian Wolff: Added a space between information and discussion links [extensions/BetaFeatures] - 10https://gerrit.wikimedia.org/r/115911 (owner: 10Tinaj1234) [05:33:50] (03CR) 10Brian Wolff: "PS2: Tiny little whitespace nitpick" [extensions/BetaFeatures] - 10https://gerrit.wikimedia.org/r/115911 (owner: 10Tinaj1234) [05:33:54] (03PS3) 10Tinaj1234: Added a space between information and discussion links [extensions/BetaFeatures] - 10https://gerrit.wikimedia.org/r/115911 [05:34:07] (03CR) 10Brian Wolff: [C: 032] "Thank you for the patch" [extensions/BetaFeatures] - 10https://gerrit.wikimedia.org/r/115911 (owner: 10Tinaj1234) [05:34:13] (03Merged) 10jenkins-bot: Added a space between information and discussion links [extensions/BetaFeatures] - 10https://gerrit.wikimedia.org/r/115911 (owner: 10Tinaj1234) [05:35:11] (03PS1) 10Aaron Schulz: Avoid API error/header leakage from jobs API [core] - 10https://gerrit.wikimedia.org/r/116224 [05:35:17] bawolff: ^ [05:35:49] * bawolff tests [05:35:51] surprised that wasn't caught in CR [05:36:06] * AaronSchulz didn't see the warning the first times he tried disabling the API to hit that path [05:38:59] Its still kind of unclear why PiRSquared was getting exceptions about invalid signature [05:39:28] yeah, but I figured there is no reason to go through that code anyway [05:42:56] (03CR) 10Brian Wolff: [C: 04-1] "minor issue with the HTTP status code, otherwise is good" (031 comment) [core] - 10https://gerrit.wikimedia.org/r/116224 (owner: 10Aaron Schulz) [05:45:07] (03PS2) 10Aaron Schulz: Avoid API error/header leakage from jobs API [core] - 10https://gerrit.wikimedia.org/r/116224 [05:45:52] (03CR) 10Brian Wolff: [C: 032] Avoid API error/header leakage from jobs API [core] - 10https://gerrit.wikimedia.org/r/116224 (owner: 10Aaron Schulz) [05:49:24] (03Merged) 10jenkins-bot: Avoid API error/header leakage from jobs API [core] - 10https://gerrit.wikimedia.org/r/116224 (owner: 10Aaron Schulz) [05:50:20] (03PS1) 10Deepali: Add vector svg animated spinner icon [core] - 10https://gerrit.wikimedia.org/r/116225 [06:04:56] (03PS1) 10Bsitu: Remove unique from index (tree_rev_descendant_id, tree_rev_id) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/116226 [06:16:40] (03Abandoned) 10Ori.livneh: Validate --versions arguments to scap [tools/scap] - 10https://gerrit.wikimedia.org/r/116017 (owner: 10BryanDavis) [06:17:40] (03PS1) 10Brian Wolff: Use rgba() for gallery caption background instead of opacity. [core] - 10https://gerrit.wikimedia.org/r/116227 [06:35:00] qgil: For [[MediaWiki/Homepage_redesign/Preview]] - given that I imagine Monteirobrena wants to play with the css, would it make sense to give her access to site css just for that page? [06:35:21] (by which I mean have js load css from her user space) [06:36:38] bawolff, hi, I think the current way of working is fine. She works with her local css, I sync with her from time to time, and if things look good then I update the site css. [06:37:03] bawolff, her internship finishes on March 10, let's see if she stays involved after that [06:37:14] Oh, that's soon [06:38:12] yep, this is why we focus on a % of the discussion (design) while leaving other things for later (e.g. texts) [06:38:45] If there comes a time where she needs more control over css, it would be pretty easy to set it up so that User:Monteirobrena/homepage.css is loaded on just the homepage redesign page, but for everyone [06:47:54] (03PS1) 10Mattflaschen: WIP: Refactor and add non-linear tours [extensions/GuidedTour] - 10https://gerrit.wikimedia.org/r/116228 [06:48:23] (03CR) 10jenkins-bot: [V: 04-1] WIP: Refactor and add non-linear tours [extensions/GuidedTour] - 10https://gerrit.wikimedia.org/r/116228 (owner: 10Mattflaschen) [06:51:10] (03CR) 10Mattflaschen: [C: 04-2] "Doesn't work yet, obviously. However, you can see the direction I'm headed in." [extensions/GuidedTour] - 10https://gerrit.wikimedia.org/r/116228 (owner: 10Mattflaschen) [07:01:40] (03CR) 10Brian Wolff: "If I understand correctly, this will make those links invisible on text browsers (and possibly some screen readers (?)). Well I don't real" [core] - 10https://gerrit.wikimedia.org/r/108221 (owner: 10Westurner) [08:18:01] (03CR) 10Daniel Friesen: [C: 04-1] "- The change from inline-block -> block is liable to break things in some 3rd party skins" [core] - 10https://gerrit.wikimedia.org/r/108221 (owner: 10Westurner) [08:26:56] (03CR) 10Nikerabbit: "Looks like this should also fix it for IE8." [core] - 10https://gerrit.wikimedia.org/r/116159 (owner: 10Brion VIBBER) [09:58:24] (03CR) 10Bartosz Dziewoński: SpecialRecentchanges: Don't use nonexistent messages for filter selector (031 comment) [core] - 10https://gerrit.wikimedia.org/r/116137 (owner: 10Bartosz Dziewoński) [10:01:07] (03PS1) 10Deepali: Display field "requiredness" on form [core] - 10https://gerrit.wikimedia.org/r/116230 [11:27:01] rdwrer: Is http://multimedia-alpha.wmflabs.org/wiki/Lightbox_demo temporarily not working? [11:36:36] (03CR) 10Bartosz Dziewoński: "Not all browsers that support SVGs support animated ones… :(" [core] - 10https://gerrit.wikimedia.org/r/116225 (owner: 10Deepali) [13:36:15] (03CR) 10Deepali: "So, how about keeping animated svg with fallback gif?" [core] - 10https://gerrit.wikimedia.org/r/116225 (owner: 10Deepali) [15:38:11] (03CR) 10Reedy: [C: 04-1] "Good start!" (037 comments) [core] - 10https://gerrit.wikimedia.org/r/116230 (owner: 10Deepali) [15:42:01] (03CR) 10Reedy: [C: 032] SpecialRecentchanges: Don't use nonexistent messages for filter selector [core] (wmf/1.23wmf16) - 10https://gerrit.wikimedia.org/r/116215 (owner: 10Hoo man) [15:46:07] (03Merged) 10jenkins-bot: SpecialRecentchanges: Don't use nonexistent messages for filter selector [core] (wmf/1.23wmf16) - 10https://gerrit.wikimedia.org/r/116215 (owner: 10Hoo man) [15:46:59] MatmaRex: I hope it was ok to close the bugs, I wasn't 100% sure about them yesterday [15:47:45] hoo: yeah, i'm pretty sure they're fixed [15:47:54] ok [15:48:10] MatmaRex: Also the change from ->parse to ->text was wanted, I guess? [15:48:13] hoo: the original one was fixed before, we just introduced a separate regression that we ended up solving without filing a separate bug [15:48:19] hoo: yeah, i commented [15:48:29] it was ->text() earlier, then was broken in the same commit [15:49:12] i'm not a big fan of how a Message is implicitly stringable, but meh [15:49:46] Yep, that leads to nice little bugs... [15:50:19] the worst thing that can happen is some double-escaping, or some HTML visible in text fields, or something [15:50:32] luckily we use an escaped format for this [15:57:01] (03CR) 10Bartosz Dziewoński: "Lego, still working on this? If yes, can you resubmit under your own name? I won't be improving this (sorry!) and it's clogging up my chan" [extensions/FlaggedRevs] - 10https://gerrit.wikimedia.org/r/79775 (owner: 10Bartosz Dziewoński) [15:58:01] (03PS3) 10Bartosz Dziewoński: Create Parser::stripInline to avoid code duplication [core] - 10https://gerrit.wikimedia.org/r/114942 [16:01:12] (03PS4) 10Bartosz Dziewoński: Create Parser::stripInline to avoid code duplication [core] - 10https://gerrit.wikimedia.org/r/114942 [16:04:45] I wonder why Subpage List 3 doesn't show git revision information in special version [16:05:11] No idea why it's enabled anyway [16:10:07] (03PS1) 10Reedy: Add COPYING [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/116237 [16:10:34] (03PS1) 10Reedy: Add COPYING [extensions/Collection] - 10https://gerrit.wikimedia.org/r/116238 [16:10:42] (03CR) 10Hoo man: [C: 032] Add COPYING [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/116237 (owner: 10Reedy) [16:10:44] (03Merged) 10jenkins-bot: Add COPYING [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/116237 (owner: 10Reedy) [16:12:13] (03PS1) 10Reedy: Add COPYING [extensions/GlobalUsage] - 10https://gerrit.wikimedia.org/r/116239 [16:13:16] (03CR) 10Bartosz Dziewoński: [C: 04-1] "Yes, but the problems is that the fallback won't "kick in" and you'll be left with a non-animated SVG. Unless of course you can figure out" [core] - 10https://gerrit.wikimedia.org/r/116225 (owner: 10Deepali) [16:13:18] (03PS1) 10Reedy: Add COPYING [extensions/OAI] - 10https://gerrit.wikimedia.org/r/116240 [16:14:17] (03CR) 10Bartosz Dziewoński: [C: 04-1] "What I said above, also needs a rebase." [core] - 10https://gerrit.wikimedia.org/r/107360 (owner: 1001tonythomas) [16:14:29] (03PS1) 10Reedy: Add COPYING [extensions/CharInsert] - 10https://gerrit.wikimedia.org/r/116242 [16:14:44] InputBox is PD... [16:15:03] really? [16:15:09] (03PS1) 10Reedy: Add COPYING [extensions/LabeledSectionTransclusion] - 10https://gerrit.wikimedia.org/r/116243 [16:15:16] According to its header [16:15:29] oh no, I've like contributed 5 lines to it :D [16:15:42] (03PS1) 10Reedy: Add COPYING [extensions/Math] - 10https://gerrit.wikimedia.org/r/116244 [16:16:00] Was there a decision to add COPYING files to all extensions? [16:16:07] Why wasn't this done before anyway? [16:16:57] The functionality is there in core... [16:17:00] "Why wasn't this done before anyway?" That's not something valid to ask around MediaWiki... [16:17:04] Krinklee: What license is TemplateData? [16:18:09] License Any OSI approved license [16:18:21] for SpamBlacklist [16:18:44] (03PS1) 10Reedy: Add COPYING [extensions/TorBlock] - 10https://gerrit.wikimedia.org/r/116245 [16:19:27] (03PS1) 10Reedy: Add COPYING [extensions/VectorBeta] - 10https://gerrit.wikimedia.org/r/116246 [16:19:44] (03PS1) 10Reedy: Add COPYING [extensions/Campaigns] - 10https://gerrit.wikimedia.org/r/116247 [16:19:47] (03CR) 10Bartosz Dziewoński: [C: 04-1] "Choosing a generator still doesn't show its options." [extensions/ApiSandbox] - 10https://gerrit.wikimedia.org/r/112307 (owner: 10Alex Monk) [16:20:05] (03PS1) 10Reedy: Add COPYING [extensions/CodeEditor] - 10https://gerrit.wikimedia.org/r/116248 [16:20:30] (03PS1) 10Reedy: Add COPYING [extensions/Disambiguator] - 10https://gerrit.wikimedia.org/r/116249 [16:23:07] (03PS1) 10Reedy: Add COPYING [extensions/FeaturedFeeds] - 10https://gerrit.wikimedia.org/r/116250 [16:23:57] hey hoo, you have global editinterface, right? [16:24:04] (03PS1) 10Reedy: Add COPYING [extensions/Elastica] - 10https://gerrit.wikimedia.org/r/116251 [16:24:16] hoo: wanna do some boring busywork, or, know where i can get one too? :P https://gerrit.wikimedia.org/r/#/c/111422/ [16:24:17] MatmaRex: I'm steward now, but it's the same in the end, yes [16:24:26] (see last comment) [16:24:53] MatmaRex: yeah, I cna run mwgrep myself... it's really useful :) [16:26:03] (03PS1) 10Reedy: Add COPYING [extensions/GeoData] - 10https://gerrit.wikimedia.org/r/116252 [16:27:35] (03PS1) 10Reedy: Add COPYING [extensions/PoolCounter] - 10https://gerrit.wikimedia.org/r/116253 [16:27:47] (03CR) 10Bartosz Dziewoński: "I'm going to split this in two parts: the deprecation and the removal, so that I can merge the first one this year, and the second can wai" [core] - 10https://gerrit.wikimedia.org/r/111422 (owner: 10Ori.livneh) [16:28:22] (03PS1) 10Reedy: Add COPYING [extensions/Thanks] - 10https://gerrit.wikimedia.org/r/116254 [16:28:47] (03PS1) 10Reedy: Add COPYING [extensions/TrustedXFF] - 10https://gerrit.wikimedia.org/r/116255 [16:29:01] huh: Still hacking on CentralAuth? [16:29:17] (03PS1) 10Reedy: Add COPYING [extensions/UserDailyContribs] - 10https://gerrit.wikimedia.org/r/116256 [16:29:35] Think I'm done... [16:29:36] for now ;) [16:30:24] lol [16:30:27] 31 outstanding patchsets [16:33:13] (03PS7) 10Bartosz Dziewoński: mediawiki.user: Remove #name and #anonymous [core] - 10https://gerrit.wikimedia.org/r/111422 (owner: 10Ori.livneh) [16:33:15] (03PS1) 10Bartosz Dziewoński: mediawiki.user: Deprecate #bucket [core] - 10https://gerrit.wikimedia.org/r/116257 [16:33:48] Reedy: amateur [16:34:05] lego has 110. [16:34:05] (03CR) 10jenkins-bot: [V: 04-1] mediawiki.user: Remove #name and #anonymous [core] - 10https://gerrit.wikimedia.org/r/111422 (owner: 10Ori.livneh) [16:34:06] I mean 30 that are COPYING [16:34:45] (03CR) 10jenkins-bot: [V: 04-1] mediawiki.user: Deprecate #bucket [core] - 10https://gerrit.wikimedia.org/r/116257 (owner: 10Bartosz Dziewoński) [16:34:58] \o/ reedy! [16:34:59] ugh, stupid release notes. [16:36:21] (03PS8) 10Bartosz Dziewoński: mediawiki.user: Remove #name and #anonymous [core] - 10https://gerrit.wikimedia.org/r/111422 (owner: 10Ori.livneh) [16:36:23] (03PS2) 10Bartosz Dziewoński: mediawiki.user: Deprecate #bucket [core] - 10https://gerrit.wikimedia.org/r/116257 [16:37:14] (03CR) 10Bartosz Dziewoński: [C: 032] "Split off from Ori's https://gerrit.wikimedia.org/r/#/c/111422/ ." [core] - 10https://gerrit.wikimedia.org/r/116257 (owner: 10Bartosz Dziewoński) [16:37:23] (03CR) 10Bartosz Dziewoński: "Deprecation split to https://gerrit.wikimedia.org/r/#/c/116257/ and merged." [core] - 10https://gerrit.wikimedia.org/r/111422 (owner: 10Ori.livneh) [16:38:22] hoo: I'm going to do the WikiSets thing [16:38:35] Maybe some other bugs [16:40:58] (03CR) 10Bartosz Dziewoński: [C: 031] "To be merged when as we eradicate the uses." [core] - 10https://gerrit.wikimedia.org/r/111422 (owner: 10Ori.livneh) [16:41:08] (03Merged) 10jenkins-bot: mediawiki.user: Deprecate #bucket [core] - 10https://gerrit.wikimedia.org/r/116257 (owner: 10Bartosz Dziewoński) [16:42:32] (03CR) 10Bartosz Dziewoński: [C: 04-1] "Needs rebase." [core] - 10https://gerrit.wikimedia.org/r/111620 (owner: 10MarkTraceur) [16:43:07] (03PS1) 10UltrasonicNXT: WIP - Rewrite [extensions/WikiForum] - 10https://gerrit.wikimedia.org/r/116258 [16:43:32] (03CR) 10Bartosz Dziewoński: "Siebrand, Niklas, any input?" [core] - 10https://gerrit.wikimedia.org/r/108514 (owner: 10Gerrit Patch Uploader) [16:44:12] (03CR) 10Bartosz Dziewoński: [C: 04-1] "Needs rebase, we need to figure out if we're doing this or https://gerrit.wikimedia.org/r/#/c/111636/ and abandon one." [core] - 10https://gerrit.wikimedia.org/r/83217 (owner: 10Mattflaschen) [16:44:23] (03CR) 10Bartosz Dziewoński: [C: 04-1] "Needs rebase, we need to figure out if we're doing this or https://gerrit.wikimedia.org/r/#/c/83217/ and abandon one." [core] - 10https://gerrit.wikimedia.org/r/111636 (owner: 10Krinkle) [16:44:53] (03CR) 10Bartosz Dziewoński: [C: 04-1] "RELEASE-NOTES-1.22…" [core] - 10https://gerrit.wikimedia.org/r/74400 (owner: 10Catrope) [16:45:43] (03CR) 10Bartosz Dziewoński: "A month has passed, what now?" [core] - 10https://gerrit.wikimedia.org/r/110589 (owner: 10Brion VIBBER) [16:48:02] (03CR) 10Bartosz Dziewoński: [C: 04-1] "Needs release notes, backwards-compatible CSS would be a good practice but personally I wouldn't bother, this won't really be noticeable a" [core] - 10https://gerrit.wikimedia.org/r/100114 (owner: 10Danny B.) [16:51:00] (03CR) 10Danny B.: [C: 031] "You can't have backward compatibility with feature which breaks validity." [core] - 10https://gerrit.wikimedia.org/r/100114 (owner: 10Danny B.) [16:52:00] (03Abandoned) 10Bartosz Dziewoński: Renamed Special:Version to Special:Software [core] - 10https://gerrit.wikimedia.org/r/107840 (owner: 10Arav93) [16:52:49] :O [16:53:15] (03CR) 10Bartosz Dziewoński: [C: 04-1] "Per Aaron. Reedy, *poke*?" [core] - 10https://gerrit.wikimedia.org/r/106162 (owner: 10Reedy) [16:53:41] MatmaRex: how is Special:Version related to https://bugzilla.wikimedia.org/show_bug.cgi?id=4155 ? [16:53:43] ??? [16:53:51] (03Abandoned) 10Bartosz Dziewoński: BookManagerv2: Invalidate navbar cache when JSON file changes Invalidate all constituent pages in a book when the JSON file changes. [extensions/BookManagerv2] - 10https://gerrit.wikimedia.org/r/105441 (owner: 10Mayankmadan) [16:54:52] (03CR) 10Bartosz Dziewoński: [C: 04-1] "Needs rebase anyway." [core] - 10https://gerrit.wikimedia.org/r/75143 (owner: 10MarkTraceur) [16:55:41] (03CR) 10Bartosz Dziewoński: [C: 032] "Per Niklas earlier, whatever, I assume he knows what he's doing." [core] - 10https://gerrit.wikimedia.org/r/78477 (owner: 10Mwalker) [16:55:56] MatmaRex seems to like to comment on absolutely everything [16:56:35] Danny_B: i'm a reviewer on all of these things [16:56:47] Danny_B: i'm going through ones with no -1 [16:57:25] and therefore adding them there? what is the sense? [16:57:50] (03CR) 10Bartosz Dziewoński: [C: 04-1] [WIP] tablesorter: testcases for the parsers (031 comment) [core] - 10https://gerrit.wikimedia.org/r/99407 (owner: 10TheDJ) [16:58:24] Danny_B: so that hopefully people who were thinking that their patch isn't getting merged because of reviewers being lazy notice and fix [16:58:45] Danny_B: or, so that i can abandon them all in a month or so per no uploader activity [16:59:07] clearly no one is working on this, no point for it to stay on my list of things to review [16:59:18] (03Merged) 10jenkins-bot: Provide direction hinting in the personal toolbar [core] - 10https://gerrit.wikimedia.org/r/78477 (owner: 10Mwalker) [16:59:25] there is nothing to do with my patch. it should have been merged ages ago [16:59:37] now it won't since you added -1 [16:59:57] (03CR) 10Bartosz Dziewoński: [C: 04-1] "Needs rebase again :(" [core] - 10https://gerrit.wikimedia.org/r/83220 (owner: 10Nemo bis) [17:00:23] Danny_B: there are pretty obvious things which i pointed out [17:00:35] Danny_B: i will merge it once you fix them, i read all gerrit mail [17:01:15] Danny_B: by backwards-compatible CSS, i meant adding a rule for "table.mw-prefixindex-list-table" without removing the one for "table#mw-prefixindex-list-table" [17:01:39] Danny_B: this is often necessary because WMF servers cache page HTML for up to 30 days [17:01:47] but probably isn't in this particular case, like i also said [17:01:52] Danny_B, you should thank people active in code review, who help reduce backlog and give a chance for progress, not complain [17:02:45] (03CR) 10Bartosz Dziewoński: [C: 032] "No other eyes on the horizon, let's merge this." [core] - 10https://gerrit.wikimedia.org/r/98250 (owner: 10TheDJ) [17:02:49] Nemo_bis: i complain about useless comments in code review. i don't complain about code review in general [17:02:57] Receiving a -1 and acting on it, even if just on a typo or whitespace issue, greatly increases your chances to get a merge, unlike the months of silence accumulating [17:03:28] No comment is useless unless it's plainly wrong and/or off topic (i.e. not code review) [17:04:05] And you should be ashamed of calling that comment "useless", it's quite aggressive [17:04:08] MatmaRex: afaik there were never release notes for this kind of change [17:04:22] Danny_B: that's bad, there should have been [17:04:30] no need for them [17:04:33] Danny_B: there weren't release notes for all kinds of breaking changes in the past [17:04:35] it does not break anything [17:04:46] this is not breaking change omg [17:04:51] it does potentially break user scripts and user styles [17:04:52] this is fixing change [17:04:53] that's what everyone who brought sites down thought of their changes :) [17:05:02] i wouldn't be surprised if it broke Twinkle or something [17:05:15] jardly [17:05:23] or Huggle or Popups or whatever [17:05:29] there's fucking tons of these shitty scripts out there [17:05:32] hardly [17:05:39] you're surely spending more time complaining than it would take to add two lines to release notes [17:05:46] well, it won't get merged then, lol [17:06:08] (03PS4) 1001tonythomas: Splitted date and time in message 'rclistfrom' [core] - 10https://gerrit.wikimedia.org/r/107360 [17:06:16] wel, it will stay invalid then, bigger lol... (aka kids on the sandbox... :-/ ) [17:06:32] Hello, I need to detect whether the current language is LTR or RTL. I didn´t find anything relevant in RequestContext.php. How do I detect this? [17:06:49] (03CR) 1001tonythomas: "@Bartosz: rebased change !" [core] - 10https://gerrit.wikimedia.org/r/107360 (owner: 1001tonythomas) [17:07:01] (03Merged) 10jenkins-bot: TableSorter: Fix column order when collecting headers [core] - 10https://gerrit.wikimedia.org/r/98250 (owner: 10TheDJ) [17:07:03] (03CR) 10Bartosz Dziewoński: [C: 032] "Don't see why not." [extensions/Echo] - 10https://gerrit.wikimedia.org/r/98256 (owner: 10Legoktm) [17:08:01] Nemo_bis: same could have done MatmaRex - add the notes if he insists on them. i've done the patch like it used to be done in past. git is like wiki, you can rework it if you don't like it. but there is no point to let it go just because you think that something which does not have any influence on functionality (aka release notes) is missing [17:08:08] (03Merged) 10jenkins-bot: Add public setters for EchoEvent attributes [extensions/Echo] - 10https://gerrit.wikimedia.org/r/98256 (owner: 10Legoktm) [17:09:24] Danny_B: HTML validity doesn't matter anyway [17:09:36] since when? [17:09:40] Niharika: $context->getLanguage()->isRtl() or something [17:09:41] since 1995 [17:10:05] MatmaRex: {citation needed} [17:10:13] MatmaRex: when you meant " It might be better to just make the whole message a link if we can't build an inline one neatly." for the rclistfrom, you mean to have the date and time like it was before ? [17:10:28] MatmaRex: here https://gerrit.wikimedia.org/r/#/c/107360/ [17:10:44] (03CR) 10Bartosz Dziewoński: "The dependency has been merged." [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/98257 (owner: 10Legoktm) [17:10:54] (03PS3) 10Legoktm: Make Echo's user-talk notification use the name of the sender [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/98257 [17:11:43] tonythomas: i meant making the entire text like "Show new changes starting from 17:11, 1 March 2014" a link [17:12:53] Oh! ok. where date and time are separate parms or its part of the single link ? [17:13:42] tonythomas: as in doing something like $rclistfrom = $this->makeOptionsLink( $this->msg( 'rclistfrom' )->rawParams( $now, $timenow, $datenow )->parse() ) [17:13:52] (code not tested) [17:14:12] MatmaRex: I will test and upload a new PS. Thanks [17:14:17] :) [17:21:31] Reedy: https://en.wikipedia.org/wiki/Wikipedia:Village_pump_%28proposals%29#Proposal_to_have_a_bot_delete_stale_warnings_from_after_certain_period_of_time requests a comment from you. :) [17:22:54] Technical_13: don't waste his time on that [17:23:29] hoo: feel free to respond for him. ;) [17:23:33] meh [17:23:46] page storage claim is bull... [17:23:55] when they want to delete, let them [17:24:18] yeah, storage space doesn't come into this, it's just a wiki policy matter [17:24:30] "As you know, Wikipedia is a non-profit organization" [17:24:43] Eh? [17:25:55] Isn't storage space at like 70% free space or something of that nature? [17:25:58] Technical_13: don't see how storage space is even relevant [17:26:27] I'm not the one who said it was... [17:26:31] What are we going to do? Remove completely old warnings from the DB and all dumps? [17:26:35] Technical_13: That doesn't even matter... what matters more at a DB level is ram usage, index size and stuff [17:27:18] "Wikipedia:Don't worry about performance" [17:27:27] I was just thinking that it would remove that component completely if a div posted how little effect they have on storage space and that deleting them would actually use more space. [17:27:39] maybe that needs a more obvious name, like Wikipedia:Don't worry about performance, really FFS [17:27:47] lol [17:27:57] perhaps.. [17:29:05] I'll link that in the discussion.. :D [17:29:18] don't quote me on that :P [17:29:31] (I know this channel is publically logged) [17:30:08] Ha! [17:31:40] http://en.wikipedia.org/w/index.php?title=Wikipedia:Village_pump_%28proposals%29&diff=next&oldid=597690623 [17:38:46] MatmaRex: I find nothing relevant here: https://github.com/wikimedia/mediawiki-core/blob/master/includes/context/RequestContext.php#L316 :( [17:38:51] hoo: sorry, was busy yesterday/day before, will work on CA now [17:39:10] no need to excuse ;) [17:39:26] how do I convince somebody to review my code? [17:39:47] ysangkok: link? [17:39:52] Promise us cookies... [17:39:56] huh: https://gerrit.wikimedia.org/r/#/c/113759/ [17:40:17] Technical_13: how many do you want? i'll buy you 10 cookies and pay you in btc [17:40:24] Niharika: the thing you care about is a few lines above – "@return Language" [17:40:35] Niharika: this means that the function is supposed to return a Language object [17:40:39] let's look at the docs: [17:40:41] !class Language [17:40:42] See http://svn.wikimedia.org/doc/classLanguage.html [17:41:10] and here: https://doc.wikimedia.org/mediawiki-core/master/php/html/classLanguage.html#aa58bd1b925c052715e24fb46be739099 a isRTL() method [17:41:23] which returns a bool value, true or false [17:41:27] which seems to be what you want? [17:41:38] MatmaRex: Exactly! Thank you. [17:44:18] ysangkok: nice [17:45:09] MatmaRex, oops, sorry I missed your comment about the ApiSandbox generator thing [17:45:17] (03PS6) 10Alex Monk: Allow multiple prop/list/meta params for action=query [extensions/ApiSandbox] - 10https://gerrit.wikimedia.org/r/112307 [17:45:27] I realised that I was modifying the IDs of some elements but not updating the code which queries for them [17:45:33] PS6 should fix this for the generator stuff [17:45:59] But I also noticed that in applyRemainingFieldParameters there might be more related issues, will investigate [17:46:11] Krenair: ha, thanks. i'll double-check the code later (hopefully later today) and merge, functionality seems to be okay [17:46:12] oh [17:46:31] Krenair: oh, also. the first element of the list (the "(select query)") is a bit awkward to me [17:46:45] that was already there [17:46:48] Krenair: and accidentally selecting it causes all options forms to disappear [17:46:55] I just changed it to allow multi-selection [17:47:28] yeah, but well, you need a dummy option to represent "nothing selected" in a regular [17:47:37] ysangkok: in the test, is it intentionally "ModuleBob" instead of "Module:Bob" ? [17:47:51] hm that's interesting. Selecting "(select query)" along with any other option makes it appear as if nothing is selected [17:47:55] Will fix, thanks MatmaRex [17:48:02] my pleasure [17:48:04] good point [17:48:31] huh: yes, the point is just to use an invalid namespace [17:50:52] ysangkok: I'm afraid I can only comment on some trivial things [17:53:04] huh: i don't know if it makes sense to fix ALL the trivial issues. if the code is too hacky anyway, there's not much point :P [17:54:05] huh: i know the test needs MW style formatting and the variable names could be prettier. and the test should delete the page (which it currently doesn't do cause it doesn't work) and the test should actually test instead of just executing [17:54:53] (03PS18) 10Jeroen De Dauw: Make it possible for extensions to specify which version of MediaWiki they support via Composer. [core] - 10https://gerrit.wikimedia.org/r/105092 [17:54:55] ysangkok: is it possible to give the image Scribunto frame parameters? [17:55:58] huh: like if you can pass parameters to the module when you use it as an image? [17:56:02] Yes [17:56:17] no, not currently [17:56:24] okay [17:56:38] huh: you can use the i18n support for svg's though, that still works [17:57:08] huh: afaik modules can call each other [17:57:16] (03PS7) 10Alex Monk: Allow multiple prop/list/meta params for action=query [extensions/ApiSandbox] - 10https://gerrit.wikimedia.org/r/112307 [17:57:49] huh: i thought about real params but if they were put in the filename it would be really easy to generate a million thumbnails just for one file [17:58:30] (03PS1) 10Hoo man: Fix the reason URL parameter [extensions/CheckUser] - 10https://gerrit.wikimedia.org/r/116259 [17:58:51] MatmaRex: [17:58:52] ^ [17:59:24] (03CR) 10Bartosz Dziewoński: [C: 032] Fix the reason URL parameter [extensions/CheckUser] - 10https://gerrit.wikimedia.org/r/116259 (owner: 10Hoo man) [17:59:26] (03Merged) 10jenkins-bot: Fix the reason URL parameter [extensions/CheckUser] - 10https://gerrit.wikimedia.org/r/116259 (owner: 10Hoo man) [18:01:10] MatmaRex, ugh, I see that here is indeed an issue [18:01:12] With links like Special:ApiSandbox#action=query&list=abusefilters&format=json&abflimit=10&generator=alllinks&galunique=&gallimit=10, applyRemainingFieldParameters ends up getting called [18:01:15] But we don't know which modules each of those are from [18:03:13] Hi eckart [18:03:23] Did you get the SSH key working? [18:03:49] seems so ... [18:04:13] download to my linux server is complete ... with 100-300KiB/s *g* [18:04:36] Krenair: you mean we have no mapping between the module name and its abbreviation? [18:05:04] MatmaRex, we do, it's just I'm not using it yet [18:05:09] but download to the local system stucks on 100% ... very strange ... and all that for 3 lines in the source [18:05:11] That's for the next PS :) [18:05:20] :) [18:08:54] (03PS2) 10Deepali: squashed commit [core] - 10https://gerrit.wikimedia.org/r/116230 [18:17:23] MatmaRex, not sure if I was right about the above actually, but I got it fixed anyway [18:17:35] (03PS8) 10Alex Monk: Allow multiple prop/list/meta params for action=query [extensions/ApiSandbox] - 10https://gerrit.wikimedia.org/r/112307 [18:18:58] (03PS9) 10Alex Monk: Allow multiple prop/list/meta params for action=query [extensions/ApiSandbox] - 10https://gerrit.wikimedia.org/r/112307 [18:52:05] (03PS3) 10Inchikutty: Adding Leaflet scripts to UploadWizard [extensions/UploadWizard] (osm) - 10https://gerrit.wikimedia.org/r/116128 [18:58:01] (03Restored) 10BryanDavis: Validate --versions arguments to scap [tools/scap] - 10https://gerrit.wikimedia.org/r/116017 (owner: 10BryanDavis) [19:01:14] (03CR) 10IAlex: "To be able to disable it (e.g. with Ibf1a28fa56), since I find it mostly useless." [core] - 10https://gerrit.wikimedia.org/r/111946 (owner: 10IAlex) [19:02:42] (03PS2) 10Inchikutty: [WIP]Embedding leaflet maps based on OSM data to UploadWizard [extensions/UploadWizard] (osm) - 10https://gerrit.wikimedia.org/r/116129 [19:07:17] hoo|away: anyway, thanks for your comments :D [19:08:58] (03PS1) 10IAlex: Update messages.inc and rebuild MessagesEn.php. Again. [core] - 10https://gerrit.wikimedia.org/r/116262 [19:15:33] (03PS5) 1001tonythomas: Splitted date and time in message 'rclistfrom' [core] - 10https://gerrit.wikimedia.org/r/107360 [19:16:18] zz_prtksxna: Seems to work [19:21:36] MatmaRex: made the whole message link :) [19:22:47] MatmaRex: and it works alright [19:51:01] How could I get a new private key on my Tool Labs account? [19:52:38] upload it via the appropriate special page after logging in [20:11:38] (03CR) 10Bartosz Dziewoński: [C: 032] Update messages.inc and rebuild MessagesEn.php. Again. [core] - 10https://gerrit.wikimedia.org/r/116262 (owner: 10IAlex) [20:14:33] (03CR) 10EBernhardson: [C: 04-1] "This patch doesn't address the issue, as stated above" [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/98257 (owner: 10Legoktm) [20:15:10] (03Merged) 10jenkins-bot: Update messages.inc and rebuild MessagesEn.php. Again. [core] - 10https://gerrit.wikimedia.org/r/116262 (owner: 10IAlex) [20:17:24] (03CR) 10EBernhardson: "As mentioned in the patch this is for, this approach doesn't enable the end goal. Additionally .odels should control their own internal st" [extensions/Echo] - 10https://gerrit.wikimedia.org/r/98256 (owner: 10Legoktm) [20:50:15] (03CR) 10Legoktm: "Also fixed bug 57492." [core] - 10https://gerrit.wikimedia.org/r/97835 (owner: 10Tpt) [21:00:04] When is Tech News delivered? [21:00:14] [possibly off-topic] [21:22:36] huh: last one was on the 24th: https://en.wikipedia.org/wiki/User_talk:Legoktm#Tech_News:_2014-09 [21:27:29] (03PS2) 10UltrasonicNXT: WIP - Rewrite [extensions/WikiForum] - 10https://gerrit.wikimedia.org/r/116258 [21:32:15] (03CR) 10Legoktm: "Looks exciting. Regarding the Category/Forum/Reply/Thread classes, I noticed you're using global objects like $wgOut, $wgRequest, $wgUser," [extensions/WikiForum] - 10https://gerrit.wikimedia.org/r/116258 (owner: 10UltrasonicNXT) [21:56:50] (03CR) 10Parent5446: [C: 031] Add missing DROP SEQUENCE to postgres' tables.sql [core] - 10https://gerrit.wikimedia.org/r/116166 (owner: 10Umherirrender) [22:09:56] (03CR) 10Parent5446: [C: 032] SpecialUserlogin: Normalize username before passing to User::newFromName [core] - 10https://gerrit.wikimedia.org/r/115329 (owner: 10Bartosz Dziewoński) [22:13:41] (03Merged) 10jenkins-bot: SpecialUserlogin: Normalize username before passing to User::newFromName [core] - 10https://gerrit.wikimedia.org/r/115329 (owner: 10Bartosz Dziewoński) [22:17:05] (03CR) 10Ori.livneh: "Yes. Oops." [tools/scap] - 10https://gerrit.wikimedia.org/r/116017 (owner: 10BryanDavis) [22:17:17] (03Abandoned) 10Ori.livneh: Remove '--versions', run_on_cluster, build_command, sudo_args and cluster_run [tools/scap] - 10https://gerrit.wikimedia.org/r/116068 (owner: 10Ori.livneh) [22:18:36] (03CR) 10Parent5446: [C: 04-1] Warn on account creation when username is adjusted (031 comment) [core] - 10https://gerrit.wikimedia.org/r/114400 (owner: 10Bartosz Dziewoński) [22:28:28] (03CR) 10Ori.livneh: [C: 032] Replace scap-1 with sync-common [tools/scap] - 10https://gerrit.wikimedia.org/r/116199 (owner: 10BryanDavis) [22:28:47] (03CR) 10Ori.livneh: [C: 032] Remove obsolete scripts [tools/scap] - 10https://gerrit.wikimedia.org/r/116198 (owner: 10BryanDavis) [22:29:07] (03Merged) 10jenkins-bot: Remove obsolete scripts [tools/scap] - 10https://gerrit.wikimedia.org/r/116198 (owner: 10BryanDavis) [22:29:35] (03Merged) 10jenkins-bot: Replace scap-1 with sync-common [tools/scap] - 10https://gerrit.wikimedia.org/r/116199 (owner: 10BryanDavis) [23:04:54] Is it possible that a root might install python-dev on bastion1 please [23:05:44] ceradon: this should be done through puppet... feel free to submit a patch [23:06:04] or file a bug so someone knows to do :) [23:11:20] (03PS1) 10Legoktm: Implement design by Prtksxna [extensions/AccountInfo] - 10https://gerrit.wikimedia.org/r/116268 [23:11:44] ceradon: also, I think you're looking for #wikimedia-labs [23:11:59] but you shouldn't be running code on bastions... [23:23:07] (03CR) 10Legoktm: "https://www.mediawiki.org/wiki/Thread:Extension_talk:AccountInfo/Design" [extensions/AccountInfo] - 10https://gerrit.wikimedia.org/r/116268 (owner: 10Legoktm) [23:31:26] (03PS1) 10Foxtrott: bugfixes (template expansion, array index not found, CSS styles) [extensions/Lingo] - 10https://gerrit.wikimedia.org/r/116269 [23:48:38] (03CR) 10Foxtrott: [C: 032 V: 032] bugfixes (template expansion, array index not found, CSS styles) [extensions/Lingo] - 10https://gerrit.wikimedia.org/r/116269 (owner: 10Foxtrott)