[00:07:41] (03PS2) 10Prtksxna: Make EventLogging a soft dependency [extensions/Popups] - 10https://gerrit.wikimedia.org/r/115878 [00:07:43] (03PS3) 10Prtksxna: Use moment.js instead of timeAgo method [extensions/Popups] - 10https://gerrit.wikimedia.org/r/115858 [00:08:55] (03PS1) 10Mwalker: test [extensions/FundraisingChart] - 10https://gerrit.wikimedia.org/r/116008 [00:08:57] (03CR) 10jenkins-bot: [V: 04-1] test [extensions/FundraisingChart] - 10https://gerrit.wikimedia.org/r/116008 (owner: 10Mwalker) [00:14:57] !g 115952 [00:14:58] https://gerrit.wikimedia.org/r/#q,115952,n,z [00:17:07] (03PS2) 10MarkTraceur: test [extensions/FundraisingChart] - 10https://gerrit.wikimedia.org/r/116008 (owner: 10Mwalker) [00:17:09] (03CR) 10jenkins-bot: [V: 04-1] test [extensions/FundraisingChart] - 10https://gerrit.wikimedia.org/r/116008 (owner: 10Mwalker) [00:43:53] (03PS1) 10BryanDavis: Validate --versions arguments to scap [tools/scap] - 10https://gerrit.wikimedia.org/r/116017 [00:45:16] (03PS1) 10Reedy: Make sync-dblist report done, don't echo mediawiki-installation [tools/scap] - 10https://gerrit.wikimedia.org/r/116018 [00:48:16] (03CR) 10Legoktm: [C: 04-1] [WIP] Add "Thanks" for comments on Flow boards (032 comments) [extensions/Thanks] - 10https://gerrit.wikimedia.org/r/115557 (owner: 10Wctaiwan) [00:54:36] (03CR) 10Prtksxna: Use moment.js instead of timeAgo method (031 comment) [extensions/Popups] - 10https://gerrit.wikimedia.org/r/115858 (owner: 10Prtksxna) [00:58:25] (03CR) 10BryanDavis: Make sync-dblist report done, don't echo mediawiki-installation (031 comment) [tools/scap] - 10https://gerrit.wikimedia.org/r/116018 (owner: 10Reedy) [01:00:26] (03PS1) 10Ssmith: initial commit [extensions/FundraisingChart] - 10https://gerrit.wikimedia.org/r/116024 [01:00:28] (03CR) 10jenkins-bot: [V: 04-1] initial commit [extensions/FundraisingChart] - 10https://gerrit.wikimedia.org/r/116024 (owner: 10Ssmith) [01:03:19] (03CR) 10Mwalker: [C: 032 V: 032] "We reviewed this in person; it's not quite ready yet; but we'll do iterative development and then do another full review after we think we" [extensions/FundraisingChart] - 10https://gerrit.wikimedia.org/r/116024 (owner: 10Ssmith) [01:05:20] (03PS2) 10AndyRussG: Add Symfony DI via Composer [extensions/Campaigns] (wip/editorcampaigns) - 10https://gerrit.wikimedia.org/r/115853 [01:06:23] (03PS2) 10Reedy: Make sync-dblist report done, don't echo mediawiki-installation [tools/scap] - 10https://gerrit.wikimedia.org/r/116018 [01:06:41] (03CR) 10Prtksxna: "moment.js is now part of core - http://git.wikimedia.org/commit/mediawiki%2Fcore.git/0244b346fc61f134d03b738802518eeba0ca9788" [extensions/FundraisingChart] - 10https://gerrit.wikimedia.org/r/116024 (owner: 10Ssmith) [01:09:19] (03CR) 10BryanDavis: [C: 032] Make sync-dblist report done, don't echo mediawiki-installation [tools/scap] - 10https://gerrit.wikimedia.org/r/116018 (owner: 10Reedy) [01:09:28] (03Merged) 10jenkins-bot: Make sync-dblist report done, don't echo mediawiki-installation [tools/scap] - 10https://gerrit.wikimedia.org/r/116018 (owner: 10Reedy) [01:13:16] (03PS1) 10Reedy: Add a few more extensions as submodules [extensions] - 10https://gerrit.wikimedia.org/r/116025 [01:13:55] (03CR) 10Reedy: [C: 032] Add a few more extensions as submodules [extensions] - 10https://gerrit.wikimedia.org/r/116025 (owner: 10Reedy) [01:14:07] (03CR) 10Reedy: [V: 032] Add a few more extensions as submodules [extensions] - 10https://gerrit.wikimedia.org/r/116025 (owner: 10Reedy) [01:15:16] (03PS1) 10Reedy: Add .gitreview and .gitignore [extensions/NoUnwrap] - 10https://gerrit.wikimedia.org/r/116027 [01:19:35] (03CR) 10Reedy: [C: 032] Add .gitreview and .gitignore [extensions/NoUnwrap] - 10https://gerrit.wikimedia.org/r/116027 (owner: 10Reedy) [01:20:51] (03PS6) 10Wctaiwan: [WIP] Add "Thanks" for comments on Flow boards [extensions/Thanks] - 10https://gerrit.wikimedia.org/r/115557 [01:28:37] (03PS7) 10Wctaiwan: [WIP] Add "Thanks" for comments on Flow boards [extensions/Thanks] - 10https://gerrit.wikimedia.org/r/115557 [01:29:08] hi csteipp :) [01:29:18] Hey hoo! [01:29:49] (03CR) 10Reedy: initial commit (032 comments) [extensions/FundraisingChart] - 10https://gerrit.wikimedia.org/r/116024 (owner: 10Ssmith) [01:30:05] csteipp, can you go to wikimedia-tech? [01:31:00] (03PS8) 10Wctaiwan: [WIP] Add "Thanks" for comments on Flow boards [extensions/Thanks] - 10https://gerrit.wikimedia.org/r/115557 [01:32:34] (03CR) 10Reedy: initial commit (031 comment) [extensions/FundraisingChart] - 10https://gerrit.wikimedia.org/r/116024 (owner: 10Ssmith) [01:34:01] (03PS1) 10Reedy: Fix leading whitespace to be consistently tabs [extensions/FundraisingChart] - 10https://gerrit.wikimedia.org/r/116033 [01:34:03] (03CR) 10jenkins-bot: [V: 04-1] Fix leading whitespace to be consistently tabs [extensions/FundraisingChart] - 10https://gerrit.wikimedia.org/r/116033 (owner: 10Reedy) [01:34:40] (03PS1) 10Reedy: Add basic .gitignore [extensions/FundraisingChart] - 10https://gerrit.wikimedia.org/r/116034 [01:34:42] (03CR) 10jenkins-bot: [V: 04-1] Add basic .gitignore [extensions/FundraisingChart] - 10https://gerrit.wikimedia.org/r/116034 (owner: 10Reedy) [01:35:08] (03CR) 10Wctaiwan: "As a sidenote, I managed to reproduce the bug in my last comment by navigating away after thanking, and then going back to the page with t" (032 comments) [extensions/Thanks] - 10https://gerrit.wikimedia.org/r/115557 (owner: 10Wctaiwan) [01:39:29] (03CR) 10Reedy: "You should also declare a license for the code" (031 comment) [extensions/FundraisingChart] - 10https://gerrit.wikimedia.org/r/116024 (owner: 10Ssmith) [01:48:36] (03CR) 10Mwalker: "oh... this comment was the reason for the minus one!" (031 comment) [core] - 10https://gerrit.wikimedia.org/r/115608 (owner: 10Addshore) [01:52:40] (03PS1) 10JGonera: Add support for FormData to mw.Api [core] - 10https://gerrit.wikimedia.org/r/116037 [01:55:06] (03PS3) 10Mwalker: test [extensions/FundraisingChart] - 10https://gerrit.wikimedia.org/r/116008 [01:55:10] (03CR) 10jenkins-bot: [V: 04-1] test [extensions/FundraisingChart] - 10https://gerrit.wikimedia.org/r/116008 (owner: 10Mwalker) [01:58:39] (03CR) 10jenkins-bot: [V: 04-1] Add support for FormData to mw.Api [core] - 10https://gerrit.wikimedia.org/r/116037 (owner: 10JGonera) [02:00:23] (03PS7) 10Prtksxna: Flip the starting point of the popup if its on the right side of the screen [extensions/Popups] - 10https://gerrit.wikimedia.org/r/115187 [02:00:25] (03PS7) 10Prtksxna: Limit image size for portrait popups [extensions/Popups] - 10https://gerrit.wikimedia.org/r/115186 [02:00:27] (03PS7) 10Prtksxna: Flip the arrow position if the popup is flipped [extensions/Popups] - 10https://gerrit.wikimedia.org/r/115188 [02:00:43] (03CR) 10Prtksxna: Limit image size for portrait popups (032 comments) [extensions/Popups] - 10https://gerrit.wikimedia.org/r/115186 (owner: 10Prtksxna) [02:01:12] (03CR) 10Prtksxna: Flip the starting point of the popup if its on the right side of the screen (031 comment) [extensions/Popups] - 10https://gerrit.wikimedia.org/r/115187 (owner: 10Prtksxna) [02:01:33] (03CR) 10Prtksxna: "1) But magic numbers spawn fairies! (Done)" [extensions/Popups] - 10https://gerrit.wikimedia.org/r/115188 (owner: 10Prtksxna) [02:01:36] did something change recently in when the userinfo API reports a user as missing? [02:01:47] anomie|away: ^^ [02:02:02] tgr: Not that I know of [02:03:22] anomie|away: ping (rather important) [02:03:29] hoo: ? [02:03:59] anomie|away: Can we revert f88fcb746139b5f1da6c319689a551fb89f17b91 ? [02:04:12] it caused https://bugzilla.wikimedia.org/show_bug.cgi?id=61942 [02:06:27] hoo: Rather than reverting, you could as easily add a ->inContentLanguage() on line 561 of HTMLFormField.php. [02:07:03] anomie|away: If you'd approve that [02:07:55] hoo: Or maybe even better, you could add a flag to HTMLFormField's params to specify content language instead of user language for the message options. [02:08:09] I could, but not today, am half asleep [02:09:07] Adding the inContentLanguage call and deploying it soon seems a decent idea in the meantime [02:09:42] I can do that [02:13:44] (03PS1) 10Hoo man: Use inContentLanguage for dropdown messages in HTMLFormField [core] - 10https://gerrit.wikimedia.org/r/116040 [02:14:12] untested [02:14:20] anomie|away: Reedy: --^ [02:15:05] (03CR) 10Anomie: [C: 032] "Works for now." [core] - 10https://gerrit.wikimedia.org/r/116040 (owner: 10Hoo man) [02:15:51] ok, needs backport and deploys :/ [02:16:12] (03PS1) 10Reedy: Use inContentLanguage for dropdown messages in HTMLFormField [core] (wmf/1.23wmf16) - 10https://gerrit.wikimedia.org/r/116041 [02:16:15] * hoo eyes Reedy [02:16:17] ah :D [02:16:44] gerrit makes the backport very easy [02:17:05] yeah, just a few clicks away [02:17:11] hoo: Any idea if https://bugzilla.wikimedia.org/show_bug.cgi?id=61987 is related? I can't seem to reproduce it on testwiki. [02:17:21] (03CR) 10Reedy: [C: 032] Use inContentLanguage for dropdown messages in HTMLFormField [core] (wmf/1.23wmf16) - 10https://gerrit.wikimedia.org/r/116041 (owner: 10Reedy) [02:18:00] (03PS1) 10Jforrester: Update OOjs UI to v0.1.0-pre (0198123819) [core] - 10https://gerrit.wikimedia.org/r/116042 [02:18:03] anomie|away: That sounds terribly like a gadget for stewards I wrote some time back [02:18:10] and both these users are stewards/ have been stewards [02:19:04] (03Merged) 10jenkins-bot: Use inContentLanguage for dropdown messages in HTMLFormField [core] - 10https://gerrit.wikimedia.org/r/116040 (owner: 10Hoo man) [02:19:29] anomie|away: Probably it's this: https://meta.wikimedia.org/w/index.php?title=User:Snowolf/GS_delete.js [02:19:39] Hi [02:19:41] $('form input[type=submit]').click( [...] $('#mw-input-wpReason-other').attr('value', blockReason); [02:19:47] oh, hi Snowolf [02:21:28] hoo, anomie|away: none of those reasons seem to have to do with what is on the script [02:21:40] (03CR) 10PleaseStand: [C: 04-1] SECURITY: API: Don't find links in the middle of api.php links (031 comment) [core] (REL1_19) - 10https://gerrit.wikimedia.org/r/115961 (owner: 10Mglaser) [02:21:54] Snowolf: I'm pretty sure it's that scirpt [02:22:05] (03Merged) 10jenkins-bot: Use inContentLanguage for dropdown messages in HTMLFormField [core] (wmf/1.23wmf16) - 10https://gerrit.wikimedia.org/r/116041 (owner: 10Reedy) [02:23:48] hoo: Looks like that script is assuming that the first option in the dropdown is "other", instead of actually selecting "other" specifically. [02:24:10] hoo: anomie|away: deployed [02:24:20] anomie|away: Yup... will fix that in a minute [02:24:22] Reedy: Thanks :) [02:31:08] Snowolf: Script fixed [02:31:18] hoo: thanks! [02:32:58] (03PS9) 10Reedy: Switch API to use Config classes [core] - 10https://gerrit.wikimedia.org/r/109271 [02:34:52] (03CR) 10jenkins-bot: [V: 04-1] Switch API to use Config classes [core] - 10https://gerrit.wikimedia.org/r/109271 (owner: 10Reedy) [02:35:31] (03PS2) 10Jforrester: [UNMERGED] Update OOjs UI to v0.1.0-pre (0198123819) [core] - 10https://gerrit.wikimedia.org/r/116042 [02:37:37] (03PS10) 10Reedy: Switch API to use Config classes [core] - 10https://gerrit.wikimedia.org/r/109271 [02:40:01] (03PS9) 10Reedy: Make abstract Config class truly implementation-agnostic [core] - 10https://gerrit.wikimedia.org/r/109850 (owner: 10Ori.livneh) [02:47:04] csteipp: Could we make https://bugzilla.wikimedia.org/show_bug.cgi?id=61362 and friends public, now that the release has gone out? [02:47:37] Yeah, did that not happen?\ [02:48:40] I can't access the link in question, so looks like nope [02:49:08] by "could we", what I really mean is could you (or someone else with access) :) [02:49:19] bawolff: Working on it :) [02:51:18] bawolff: Done [02:51:23] thanks :) [02:55:46] (03CR) 10Manybubbles: [C: 04-1] "-1 because it is pretty horrible. just looking for comments." [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/115991 (owner: 10Manybubbles) [03:01:35] Could someone fix the links to the tarballs on the MW.org download page? The templates are fully protected, so I can't myself... [03:01:49] They should point to releases.wikimedia.org, not download.wikimedia.org [03:04:22] PleaseStand: Which template is it? [03:04:55] bawolff: https://www.mediawiki.org/w/index.php?search=Template%3ARelease-link&title=Special%3ASearch&go=Go [03:05:32] Looks like I was already beaten to it [03:06:44] bawolff: The links are broken. For example, http://dumps.wikimedia.org/mediawiki/1.21/mediawiki-1.21.6.tar.gz doesn't work, http://releases.wikimedia.org/mediawiki/1.21/mediawiki-1.21.6.tar.gz does [03:08:28] Oh I see, only half of them were changed [03:10:39] ?action=purge seemed to fix the page [03:11:05] PleaseStand: You're not an admin there? That's silly. [03:11:10] or somebody else fixed them well I was trying to understand the code [03:11:13] Also that too [03:11:26] * Gloria fixing. [03:12:00] PleaseStand: Fixed. :-) [03:12:23] It seems Nemo had already hinted... [03:16:59] I think this is a sign I don't edit wikis enough if I can't even figure out what to change in a simple template ;) [03:29:38] Hmm, I like how profiling locally tells me that LocalisationCache::readJSONFile is using 414.08% of the time... [03:32:06] Anybody know what's up w/ wikimedia/operations-puppet.git ? Failed twice on clone. [03:32:07] warning: remote HEAD refers to nonexistent ref, unable to checkout. [03:32:38] bawolff: using xdebug? it gets alot of things wrong, i get better luck with xhprof [03:32:57] Using built in mediawiki profiling (e.g. StartProfiler.php [03:33:10] heh [03:33:48] the funny thing about the built in profiling is even stubbed out it hits the top of the xhprof charts :) [03:34:10] lol, that's not re-assuring [03:35:49] Maybe its my install. On Wikipedia everything seems to add to 100% (in my limited test) [03:36:49] although "-total" is taking more seconds then the served by line reports [03:37:36] it always is, the served by time is output before profiling is calculated [03:37:55] when using the full profiler it takes a not-insignificant amount of time to process the profiling info into a report [03:40:59] greg-g: are there lightning deploy windows on Friday? [03:41:40] Hmm, also of interest, $wgStatsMethod defaults to storing in memcached, even when profiling is disabled, which seems weird [03:42:24] (03CR) 10Prtksxna: [C: 031] Add basic .gitignore [extensions/FundraisingChart] - 10https://gerrit.wikimedia.org/r/116034 (owner: 10Reedy) [03:43:54] its somewhat obvious with a patch i have to draw that profiling info: http://i.imgur.com/xICNs5J.png [03:44:27] (03CR) 10Prtksxna: [C: 04-1] "Its considered better to use the HTML Class to build HTML in PHP (instead of strings). I don't know much about this, but you could check o" [extensions/FundraisingChart] - 10https://gerrit.wikimedia.org/r/116033 (owner: 10Reedy) [03:45:57] Oh, that's a cool way of visualizing it (with debug toolbar) [03:46:45] (03CR) 10Prtksxna: [C: 031] "But that is irrelevant to this commit!" [extensions/FundraisingChart] - 10https://gerrit.wikimedia.org/r/116033 (owner: 10Reedy) [03:52:13] (03PS1) 10Brian Wolff: Remove $wgDebugProfiling. It appears to be unused. [core] - 10https://gerrit.wikimedia.org/r/116049 [03:59:04] (03CR) 10PleaseStand: "Still seems to fix the problem though because of the added ^ anchor." [core] (REL1_19) - 10https://gerrit.wikimedia.org/r/115961 (owner: 10Mglaser) [04:02:19] (03CR) 10Legoktm: [C: 04-1] "Missing qqq messages, otherwise looks pretty much ready to merge, pending the Flow patch." [extensions/Thanks] - 10https://gerrit.wikimedia.org/r/115557 (owner: 10Wctaiwan) [04:05:30] (03CR) 10Legoktm: Allow extension of post interaction links (031 comment) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/115552 (owner: 10Wctaiwan) [04:05:42] (03CR) 10Legoktm: Allow extension of post interaction links (031 comment) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/115552 (owner: 10Wctaiwan) [04:13:29] (03PS2) 10Mno2: Show number of users who enabled auto-enroll option [extensions/BetaFeatures] - 10https://gerrit.wikimedia.org/r/110238 [04:20:31] (03PS3) 10Mno2: Show number of users who enabled auto-enroll option [extensions/BetaFeatures] - 10https://gerrit.wikimedia.org/r/110238 [04:25:03] (03CR) 10Aaron Schulz: [C: 032] Remove $wgDebugProfiling. It appears to be unused. [core] - 10https://gerrit.wikimedia.org/r/116049 (owner: 10Brian Wolff) [04:26:58] (03CR) 10Mno2: "Please disregard this patch. The line 29 of file BetaFeatures.php should not be there. It was fixed on patch #3." [extensions/BetaFeatures] - 10https://gerrit.wikimedia.org/r/110238 (owner: 10Mno2) [04:27:32] (03PS1) 10Prtksxna: Use mixin for creating pokeys with the border method [extensions/Popups] - 10https://gerrit.wikimedia.org/r/116052 [04:27:34] (03PS1) 10Prtksxna: Add border around pokey of the popup [extensions/Popups] - 10https://gerrit.wikimedia.org/r/116053 [04:28:18] (03Merged) 10jenkins-bot: Remove $wgDebugProfiling. It appears to be unused. [core] - 10https://gerrit.wikimedia.org/r/116049 (owner: 10Brian Wolff) [04:42:21] (03PS8) 10Prtksxna: Flip the arrow position if the popup is flipped [extensions/Popups] - 10https://gerrit.wikimedia.org/r/115188 [04:42:23] (03PS2) 10Prtksxna: Use mixin for creating pokeys with the border method [extensions/Popups] - 10https://gerrit.wikimedia.org/r/116052 [04:42:25] (03PS2) 10Prtksxna: Add border around pokey of the popup [extensions/Popups] - 10https://gerrit.wikimedia.org/r/116053 [04:51:46] (03PS3) 10Prtksxna: Add border around pokey of the popup [extensions/Popups] - 10https://gerrit.wikimedia.org/r/116053 [04:55:09] (03CR) 10Yuvipanda: "Does it *need* to be done like this? Can't you just use class_exists like how we did for betafeatures?" [extensions/Popups] - 10https://gerrit.wikimedia.org/r/115878 (owner: 10Prtksxna) [04:55:34] (03CR) 10Mwalker: [C: 032] Add basic .gitignore [extensions/FundraisingChart] - 10https://gerrit.wikimedia.org/r/116034 (owner: 10Reedy) [04:55:38] (03CR) 10jenkins-bot: [V: 04-1] Add basic .gitignore [extensions/FundraisingChart] - 10https://gerrit.wikimedia.org/r/116034 (owner: 10Reedy) [04:55:40] (03CR) 10Mwalker: [V: 032] Add basic .gitignore [extensions/FundraisingChart] - 10https://gerrit.wikimedia.org/r/116034 (owner: 10Reedy) [04:55:42] (03CR) 10Mattflaschen: "What is a pokey?" [extensions/Popups] - 10https://gerrit.wikimedia.org/r/116052 (owner: 10Prtksxna) [04:59:21] (03CR) 10Yuvipanda: [C: 04-1] Limit image size for portrait popups (031 comment) [extensions/Popups] - 10https://gerrit.wikimedia.org/r/115186 (owner: 10Prtksxna) [05:00:00] (03CR) 10Yuvipanda: [C: 04-1] Flip the starting point of the popup if its on the right side of the screen (031 comment) [extensions/Popups] - 10https://gerrit.wikimedia.org/r/115187 (owner: 10Prtksxna) [05:01:28] (03CR) 10Yuvipanda: [C: 04-1] Flip the arrow position if the popup is flipped (031 comment) [extensions/Popups] - 10https://gerrit.wikimedia.org/r/115188 (owner: 10Prtksxna) [05:01:31] prtksxna: almost all are minor nits [05:01:45] YuviPanda: For event logging, we just want to load certain modules if the class exists, not the whole extension. [05:02:36] YuviPanda: Also, I dont understand the point of putting the SVG markup elsewhere first [05:03:28] prtksxna: inline xml as such feels a bit wonky. it is a large constant strings, so why not treat it as such? plus when I look at the code that actually manipulates the DOM elements and does the SVG things, having the actual SVG there feels a bit distracting and unclean. [05:05:25] YuviPanda: So why make a function? [05:05:39] prtksxna: I thought that it had some dynamic elements in it, so I said function. apologies for that confusion [05:05:42] YuviPanda: You are saying that I define the string somewhere on top? [05:05:48] prtksxna: yeah [05:05:57] YuviPanda: But it'll be a useless string if there is no SVG :\ [05:06:06] ah, hmm [05:06:13] prtksxna: hmm, fine, let's leave it inline then [05:06:48] (03CR) 10Yuvipanda: [C: 032 V: 032] Use mixin for creating pokeys with the border method [extensions/Popups] - 10https://gerrit.wikimedia.org/r/116052 (owner: 10Prtksxna) [05:07:35] prtksxna: there. I think you might need to rebase some also :( [05:08:16] prtksxna: always use constants in JS instead of magic numbers, except in cases like 'oh divide by two so I get the middle' [05:08:16] and stuff [05:08:22] YuviPanda: How did you merge what is dependent? [05:08:36] prtksxna: i just +2'd it, it didn't get merged :P [05:08:37] Got it [05:08:49] prtksxna: I'll have to do it again when you have it rebased and the dependents are merged, but it's ok [05:08:51] YuviPanda: So lets not merge it [05:08:56] prtksxna: it's not merged :) [05:09:05] YuviPanda: So I don't need to do anything [05:09:11] (03CR) 10Yuvipanda: [C: 04-1] Add border around pokey of the popup (031 comment) [extensions/Popups] - 10https://gerrit.wikimedia.org/r/116053 (owner: 10Prtksxna) [05:09:20] prtksxna: yeah, just ignore my +2. It's just a signal to myself maybe :P [05:09:21] or idk [05:09:27] prtksxna: just treat it as unmerged [05:09:39] prtksxna: I got to everything, right? [05:10:09] YuviPanda: The 3 isn't exactly a magic number, its a hack/wip [05:10:16] [10:31:42] prtksxna: YuviPanda: For event logging, we just want to load certain modules if the class exists, not the whole extension. [05:10:20] prtksxna: even more reason to use a constant? :) [05:10:30] (03CR) 10Mattflaschen: "Please follow this up by updating mediawiki.api.watch.js. There is now a warning every time a user with JavaScript clicks the watchlist s" [core] - 10https://gerrit.wikimedia.org/r/53964 (owner: 10Eranroz) [05:10:34] prtksxna: yeah, that sounds ok. I need to test that though. will merge after testing. EventLogging [05:10:41] wokay [05:12:28] (03CR) 10Prtksxna: "For event logging, we just want to load certain modules if the class exists, not the whole extension." [extensions/Popups] - 10https://gerrit.wikimedia.org/r/115878 (owner: 10Prtksxna) [05:13:12] prtksxna: I'm going to shower now [05:13:27] (03PS8) 10Prtksxna: Flip the starting point of the popup if its on the right side of the screen [extensions/Popups] - 10https://gerrit.wikimedia.org/r/115187 [05:13:28] YuviPanda: ok [05:13:29] (03PS8) 10Prtksxna: Limit image size for portrait popups [extensions/Popups] - 10https://gerrit.wikimedia.org/r/115186 [05:13:31] (03PS9) 10Prtksxna: Flip the arrow position if the popup is flipped [extensions/Popups] - 10https://gerrit.wikimedia.org/r/115188 [05:13:33] (03PS3) 10Prtksxna: Use mixin for creating pokeys with the border method [extensions/Popups] - 10https://gerrit.wikimedia.org/r/116052 [05:13:35] (03PS4) 10Prtksxna: [wip] Add border around pokey of the popup [extensions/Popups] - 10https://gerrit.wikimedia.org/r/116053 [05:14:31] (03CR) 10Prtksxna: Limit image size for portrait popups (031 comment) [extensions/Popups] - 10https://gerrit.wikimedia.org/r/115186 (owner: 10Prtksxna) [05:14:46] (03PS1) 10Aude: add flaggedrevs-hidereviewed show / hide i18n messages [extensions/FlaggedRevs] - 10https://gerrit.wikimedia.org/r/116054 [05:15:03] (03CR) 10Prtksxna: Flip the starting point of the popup if its on the right side of the screen (031 comment) [extensions/Popups] - 10https://gerrit.wikimedia.org/r/115187 (owner: 10Prtksxna) [05:15:51] (03CR) 10Prtksxna: Flip the arrow position if the popup is flipped (031 comment) [extensions/Popups] - 10https://gerrit.wikimedia.org/r/115188 (owner: 10Prtksxna) [05:16:51] (03PS1) 10AndyRussG: Move hooks to separate file/class [extensions/Campaigns] (wip/editorcampaigns) - 10https://gerrit.wikimedia.org/r/116056 [05:19:08] (03CR) 10Prtksxna: "@superm401: The triangle thing that pokes the link http://bug-attachment.wikimedia.org/attachment.cgi?id=14698" [extensions/Popups] - 10https://gerrit.wikimedia.org/r/116052 (owner: 10Prtksxna) [05:22:24] (03CR) 10Mattflaschen: [C: 032] "Watchlist star rotates fine, generated CSS looks right, transform-rotate can be used without importing the keyframes." [core] - 10https://gerrit.wikimedia.org/r/115377 (owner: 10Prtksxna) [05:22:57] superm401: \o/ [05:23:20] superm401: Do you think it makes sense to add basic fades and movements to core? [05:24:07] prtksxna, maybe wait until they're used by core, or by a couple extensions. [05:25:28] superm401: I know that pginer along with Gilles are adding some animations to MMV. There are some required by Popups (that should get deployed soon), if we have them more people would be able to use them! [05:26:01] (03Merged) 10jenkins-bot: mediawiki.less: Use less mixin to reduce code repetition in animation [core] - 10https://gerrit.wikimedia.org/r/115377 (owner: 10Prtksxna) [05:26:15] superm401: Also, they can just .rotate-frames (or whatever) to customise the animation! [05:33:10] (03PS5) 10Prtksxna: [wip] Add border around pokey of the popup [extensions/Popups] - 10https://gerrit.wikimedia.org/r/116053 [05:38:33] (03PS6) 10Prtksxna: Add border around pokey of the popup [extensions/Popups] - 10https://gerrit.wikimedia.org/r/116053 [05:41:46] (03PS1) 10Aaron Schulz: Handle some extra cases in triggerJobs() [core] - 10https://gerrit.wikimedia.org/r/116058 [05:42:29] (03CR) 10jenkins-bot: [V: 04-1] Handle some extra cases in triggerJobs() [core] - 10https://gerrit.wikimedia.org/r/116058 (owner: 10Aaron Schulz) [05:48:34] (03PS1) 10Aaron Schulz: Removed refreshLinks2 comment [core] - 10https://gerrit.wikimedia.org/r/116060 [05:52:15] (03PS2) 10Aaron Schulz: Handle some extra cases in triggerJobs() [core] - 10https://gerrit.wikimedia.org/r/116058 [05:54:28] (03PS1) 10BryanDavis: Convert mwversionsinuse to pure python [tools/scap] - 10https://gerrit.wikimedia.org/r/116062 [05:55:29] (03PS2) 10Aaron Schulz: Convert mwversionsinuse to pure python [tools/scap] - 10https://gerrit.wikimedia.org/r/116062 (owner: 10BryanDavis) [05:55:53] bd808: wait, scap.scap ? :) [05:56:48] AaronSchulz: That's the python method that bin/scap wraps [05:57:00] heh [05:57:05] At one point I had a scap.scap.scap method [05:57:15] That was going too far [05:58:01] scap.scap is actually and alias for scap.main.scap which is a wrapper around scap.tasks.scap. My naming is a mess [06:21:36] (03CR) 10BryanDavis: "This looks like the sort of thing twisted is really made for." (031 comment) [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/115991 (owner: 10Manybubbles) [06:52:41] (03PS1) 10Ryan Lane: Add an wgOpenStackManagerRestrictedRegions option [extensions/OpenStackManager] - 10https://gerrit.wikimedia.org/r/116063 [07:00:51] (03CR) 10Andrew Bogott: [C: 031] Add an wgOpenStackManagerRestrictedRegions option [extensions/OpenStackManager] - 10https://gerrit.wikimedia.org/r/116063 (owner: 10Ryan Lane) [07:05:36] (03PS2) 10Ryan Lane: Add an wgOpenStackManagerRestrictedRegions option [extensions/OpenStackManager] - 10https://gerrit.wikimedia.org/r/116063 [07:08:50] (03CR) 10Andrew Bogott: [C: 032] Add an wgOpenStackManagerRestrictedRegions option [extensions/OpenStackManager] - 10https://gerrit.wikimedia.org/r/116063 (owner: 10Ryan Lane) [07:08:52] (03Merged) 10jenkins-bot: Add an wgOpenStackManagerRestrictedRegions option [extensions/OpenStackManager] - 10https://gerrit.wikimedia.org/r/116063 (owner: 10Ryan Lane) [07:18:03] yurik around? [07:19:15] (03CR) 10Ori.livneh: [C: 04-1] Convert mwversionsinuse to pure python (034 comments) [tools/scap] - 10https://gerrit.wikimedia.org/r/116062 (owner: 10BryanDavis) [07:21:38] (03CR) 10Ori.livneh: [C: 032] Handle some extra cases in triggerJobs() [core] - 10https://gerrit.wikimedia.org/r/116058 (owner: 10Aaron Schulz) [07:23:19] (03CR) 10Ori.livneh: [C: 032] Add JSDuck role to MediaWiki-Vagrant [vagrant] - 10https://gerrit.wikimedia.org/r/115534 (owner: 10Gergő Tisza) [07:23:24] (03Merged) 10jenkins-bot: Add JSDuck role to MediaWiki-Vagrant [vagrant] - 10https://gerrit.wikimedia.org/r/115534 (owner: 10Gergő Tisza) [07:25:04] (03Merged) 10jenkins-bot: Handle some extra cases in triggerJobs() [core] - 10https://gerrit.wikimedia.org/r/116058 (owner: 10Aaron Schulz) [07:29:12] (03CR) 10Ori.livneh: [C: 04-1] "IMO, we should remove this option from scap entirely for now, and always sync everything. My thinking is that it did not solve our perform" (032 comments) [tools/scap] - 10https://gerrit.wikimedia.org/r/116017 (owner: 10BryanDavis) [07:31:28] (03PS3) 10Bartosz Dziewoński: mediawiki.api: Remove misleading comment about JSONP [core] - 10https://gerrit.wikimedia.org/r/110662 [07:31:32] (03CR) 10Ori.livneh: [C: 032] mediawiki.api: Remove misleading comment about JSONP [core] - 10https://gerrit.wikimedia.org/r/110662 (owner: 10Bartosz Dziewoński) [07:32:31] (03CR) 10Aaron Schulz: "I'd be OK with omitting --versions to. It was just expirement." [tools/scap] - 10https://gerrit.wikimedia.org/r/116017 (owner: 10BryanDavis) [07:35:42] (03Merged) 10jenkins-bot: mediawiki.api: Remove misleading comment about JSONP [core] - 10https://gerrit.wikimedia.org/r/110662 (owner: 10Bartosz Dziewoński) [07:48:28] (03PS1) 10Eranroz: Update mw.api.watch according to new Watch API [core] - 10https://gerrit.wikimedia.org/r/116067 [07:49:37] (03CR) 10jenkins-bot: [V: 04-1] Update mw.api.watch according to new Watch API [core] - 10https://gerrit.wikimedia.org/r/116067 (owner: 10Eranroz) [07:53:52] (03PS2) 10Eranroz: Update mw.api.watch according to new Watch API [core] - 10https://gerrit.wikimedia.org/r/116067 [08:15:10] (03PS1) 10Ori.livneh: Remove '--versions', run_on_cluster, build_command, sudo_args and cluster_run [tools/scap] - 10https://gerrit.wikimedia.org/r/116068 [08:15:26] (03CR) 10jenkins-bot: [V: 04-1] Remove '--versions', run_on_cluster, build_command, sudo_args and cluster_run [tools/scap] - 10https://gerrit.wikimedia.org/r/116068 (owner: 10Ori.livneh) [08:17:30] (03PS2) 10Ori.livneh: Remove '--versions', run_on_cluster, build_command, sudo_args and cluster_run [tools/scap] - 10https://gerrit.wikimedia.org/r/116068 [08:17:45] (03CR) 10jenkins-bot: [V: 04-1] Remove '--versions', run_on_cluster, build_command, sudo_args and cluster_run [tools/scap] - 10https://gerrit.wikimedia.org/r/116068 (owner: 10Ori.livneh) [08:20:03] (03PS3) 10Ori.livneh: Remove '--versions', run_on_cluster, build_command, sudo_args and cluster_run [tools/scap] - 10https://gerrit.wikimedia.org/r/116068 [08:33:15] (03PS4) 10Ori.livneh: Remove '--versions', run_on_cluster, build_command, sudo_args and cluster_run [tools/scap] - 10https://gerrit.wikimedia.org/r/116068 [08:33:29] (03CR) 10jenkins-bot: [V: 04-1] Remove '--versions', run_on_cluster, build_command, sudo_args and cluster_run [tools/scap] - 10https://gerrit.wikimedia.org/r/116068 (owner: 10Ori.livneh) [08:34:21] (03PS5) 10Ori.livneh: Remove '--versions', run_on_cluster, build_command, sudo_args and cluster_run [tools/scap] - 10https://gerrit.wikimedia.org/r/116068 [09:30:39] Amgine: Did you see http://lists.wikimedia.org/pipermail/wikitech-l/2014-February/074792.html [09:32:45] restarting jenkins [09:35:55] (03CR) 10Mglaser: "Actually, it's a backport of https://gerrit.wikimedia.org/r/#/c/115907/. It didn't make it to the last release, though, as the Armor link " [core] (REL1_19) - 10https://gerrit.wikimedia.org/r/115961 (owner: 10Mglaser) [09:47:09] (03CR) 10TTO: "Bump! Anything more to do here before a merge?" [core] - 10https://gerrit.wikimedia.org/r/87649 (owner: 10TTO) [10:05:08] bawolff: oh, Finland. :) [10:07:32] (03CR) 10Addshore: Expand MWException tests (031 comment) [core] - 10https://gerrit.wikimedia.org/r/115608 (owner: 10Addshore) [10:13:05] It's probably going to be yet another rotting project in our shelves. I wonder if there's anything it can be integrated with. Popups extension? Metadata hacks magic as for Commons to expose Wiktionary data in machine readable format (for a hundred wikis' formats??)? [10:14:11] Nemo_bis: I thought that was the point of gsoc (Add rotting extensions to our shelves that never get deployed) [10:14:19] or have I just become pessimestic [10:16:06] I'm not really following wiktionary development, but I remember a while back that they really wanted a toolserver style tool that you could feed a page name to, and it would output the definition in machine readable format [10:16:22] So if nobody has done that, that could maybe make a gsoc project [10:16:33] Some of the GSoC projects ended up being used, even [10:16:50] Problem of course is each wiktionary language formats their pages differently, and for the smaller languages, not even consistently [10:17:05] Indeed some do, I think we're averaging about 1 a year that gets used [10:17:11] I don't think anything about making Wiktionary machine-readable could be a GSoC project [10:17:58] We're looking for someone to read and review http://onlinelibrary.wiley.com/doi/10.1002/9781118712696.ch12/summary btw [10:18:34] I don't even know a good bunch of the words in the title of that book :) [10:20:56] Of the 2013 projects, I'd say 4 are in use [10:21:39] i.e. all those about refactoring or improving specific stuff in VisualEditor, ProofreadPage and Wikidata. [10:22:59] Yeah, I like the "Refactoring of ProofreadPage extension" type things, those seem more likely to actually be used vs the do something scary and then hope wmf gives it a positive performance/security review 6 months later [10:23:33] Or 6 years later :) [10:24:27] probably that user should just continue https://www.mediawiki.org/wiki/Summer_of_Code_Past_Projects#Improvement_of_glossary_tools [10:25:51] Personally I'd really like to see the translatesvg stuff happen [10:26:38] Too bad https://www.mediawiki.org/wiki/User:MaxSem/GSoC_analysis hasn't been kept up to date [10:28:05] Example https://www.mediawiki.org/wiki/Talk:Compact_interlanguage_links_as_a_beta_feature [10:28:27] It's easy to update that page with the summary page I just linked [10:38:14] done [10:45:40] Hi! I am Avishek Bhattacharjee, currently learning Android application development. I want to contribute to any of the projects regarding Android application development. Can anyone guide me please? [10:52:45] Try also #wikimedia-mobile [10:53:13] Avishek: In about 5 hours the channel might be a little bit more hopping [10:53:55] bawolff: okay [10:54:10] will ask then.. [10:54:13] thanks [10:54:26] Lots of people (not all though) around here are on San Francisco time [10:54:59] (03PS1) 10Pginer: Button group adjustments [core] - 10https://gerrit.wikimedia.org/r/116075 [10:55:40] bawolff: okay. I am from India. Netaji Subhash Engineering College. [10:56:38] Cool. I know nothing about the mobile side of things, but there are several people who do that sort of stuff, and I think they're always happy to have new people [10:57:18] (03CR) 10Pginer: "Due to the lack of a better playground for Agora. This can be tested by executing this in the browser console:" [core] - 10https://gerrit.wikimedia.org/r/116075 (owner: 10Pginer) [10:58:27] bawolff: okay. Sumanah Harihareshwara told me to ask in this channel. [10:58:38] thanks..:) [11:00:31] This channel is a perfectly good place to ask too [11:02:34] bawolff: yeah. will ask again after 5 hours as you said..:) [11:03:58] (03CR) 10Aude: "also, some point we should think about what if multiple extensions want to use this component. then how do we best manage such situation?" [extensions/Campaigns] (wip/editorcampaigns) - 10https://gerrit.wikimedia.org/r/115853 (owner: 10AndyRussG) [11:19:54] (03PS4) 10Mwalker: test [extensions/FundraisingChart] - 10https://gerrit.wikimedia.org/r/116008 [11:21:08] James_F|Away: creating a dummy VE default assignee in Bugzilla sounds like a very good idea. Something like visualeditor-devs@wikimedia.bugs (make sure the "Bugmail Disabled" checkbox is ticked). I'd like to see "@wikimedia.bugs", the rest I don't care. [11:23:26] (03PS1) 10Hashar: Register some more extensions [extensions] - 10https://gerrit.wikimedia.org/r/116077 [11:23:35] (03PS2) 10Hashar: Register some more extensions [extensions] - 10https://gerrit.wikimedia.org/r/116077 [11:23:43] (03CR) 10Hashar: [C: 032 V: 032] Register some more extensions [extensions] - 10https://gerrit.wikimedia.org/r/116077 (owner: 10Hashar) [11:46:34] (03PS1) 10Addshore: Trick coveralls into thinking we installed using composer [integration/jenkins] - 10https://gerrit.wikimedia.org/r/116078 [11:59:18] (03PS1) 10Brian Wolff: Exceptions were directly outputting {{SITENAME}}. [core] - 10https://gerrit.wikimedia.org/r/116080 [12:02:43] hoo: ? [12:03:00] helderwiki: mh? [12:29:47] (03CR) 10Hashar: [C: 032] "That is ugly :-]" [integration/jenkins] - 10https://gerrit.wikimedia.org/r/116078 (owner: 10Addshore) [12:29:50] (03Merged) 10jenkins-bot: Trick coveralls into thinking we installed using composer [integration/jenkins] - 10https://gerrit.wikimedia.org/r/116078 (owner: 10Addshore) [12:33:22] (03PS1) 10Matthias Mullie: Fixes in TreeRepository [extensions/Flow] - 10https://gerrit.wikimedia.org/r/116083 [12:33:35] (03PS1) 10Addshore: rm service_event_type and make cp -r [integration/jenkins] - 10https://gerrit.wikimedia.org/r/116084 [12:35:06] (03CR) 10Hashar: [C: 032] rm service_event_type and make cp -r [integration/jenkins] - 10https://gerrit.wikimedia.org/r/116084 (owner: 10Addshore) [12:35:20] (03Merged) 10jenkins-bot: rm service_event_type and make cp -r [integration/jenkins] - 10https://gerrit.wikimedia.org/r/116084 (owner: 10Addshore) [12:35:32] (03PS3) 10Matthias Mullie: Non-hacky way to feed title to Parsoid [extensions/Flow] - 10https://gerrit.wikimedia.org/r/115112 [12:36:19] (03CR) 10Matthias Mullie: "I'll fix up Redlinker in a separate patch" (033 comments) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/115112 (owner: 10Matthias Mullie) [12:51:50] (03PS1) 10Matthias Mullie: Non-hacky way to feed title to Redlinker [extensions/Flow] - 10https://gerrit.wikimedia.org/r/116085 [12:57:32] (03PS1) 10Hashar: coveralls is now using --verbose [integration/jenkins] - 10https://gerrit.wikimedia.org/r/116086 [12:57:41] (03CR) 10Hashar: [C: 032] coveralls is now using --verbose [integration/jenkins] - 10https://gerrit.wikimedia.org/r/116086 (owner: 10Hashar) [12:58:15] (03PS2) 10Hashar: coveralls is now using --verbose [integration/jenkins] - 10https://gerrit.wikimedia.org/r/116086 [12:58:21] (03CR) 10Hashar: [C: 032] coveralls is now using --verbose [integration/jenkins] - 10https://gerrit.wikimedia.org/r/116086 (owner: 10Hashar) [12:58:24] (03Merged) 10jenkins-bot: coveralls is now using --verbose [integration/jenkins] - 10https://gerrit.wikimedia.org/r/116086 (owner: 10Hashar) [13:05:43] (03CR) 10Bartosz Dziewoński: [C: 04-1] Button group adjustments (031 comment) [core] - 10https://gerrit.wikimedia.org/r/116075 (owner: 10Pginer) [13:06:10] (03PS1) 10Addshore: Coveralls use src_dir: ./ [integration/jenkins] - 10https://gerrit.wikimedia.org/r/116089 [13:07:06] (03CR) 10Hashar: [C: 032] Coveralls use src_dir: ./ [integration/jenkins] - 10https://gerrit.wikimedia.org/r/116089 (owner: 10Addshore) [13:07:09] (03Merged) 10jenkins-bot: Coveralls use src_dir: ./ [integration/jenkins] - 10https://gerrit.wikimedia.org/r/116089 (owner: 10Addshore) [13:08:14] (03PS2) 10Matthias Mullie: Drop tree_orig_create_time [extensions/Flow] - 10https://gerrit.wikimedia.org/r/115619 [13:09:13] (03PS1) 10Hashar: coderwall experiment continued [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/116090 [13:09:56] (03PS2) 10Addshore: coveralls experiment continued [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/116090 (owner: 10Hashar) [13:10:01] (03CR) 10Addshore: [C: 031] coveralls experiment continued [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/116090 (owner: 10Hashar) [13:12:09] (03PS1) 10Hashar: Mw coverage job had echo "foo" > log/clover.xml [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/116091 [13:12:18] (03CR) 10Hashar: [C: 032] Mw coverage job had echo "foo" > log/clover.xml [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/116091 (owner: 10Hashar) [13:12:42] (03Merged) 10jenkins-bot: Mw coverage job had echo "foo" > log/clover.xml [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/116091 (owner: 10Hashar) [13:13:22] (03PS8) 10Bartosz Dziewoński: ChangesListSpecialPage: Separate all functionality for generating feeds [core] - 10https://gerrit.wikimedia.org/r/110864 [13:15:30] (03CR) 10Bartosz Dziewoński: "Rebased, merge please? ;_;" [core] - 10https://gerrit.wikimedia.org/r/110864 (owner: 10Bartosz Dziewoński) [13:19:22] (03PS1) 10Hashar: Coverage now ignore phpunit ignores [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/116093 [13:19:39] (03CR) 10Hashar: [C: 032] Coverage now ignore phpunit ignores [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/116093 (owner: 10Hashar) [13:20:13] (03PS1) 1001tonythomas: Removed Count column from Special:Statistics Table [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/116094 [13:23:29] (03PS1) 10Anomie: Use inContentLanguage for dropdown messages in HTMLFormField [core] (wmf/1.23wmf15) - 10https://gerrit.wikimedia.org/r/116095 [13:24:30] (03Merged) 10jenkins-bot: Coverage now ignore phpunit ignores [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/116093 (owner: 10Hashar) [13:24:33] (03CR) 10Anomie: [C: 031] "This fixes a regression. Reedy backported to 1.23wmf16 last night, but the regression is present in 1.23wmf15 as well." [core] (wmf/1.23wmf15) - 10https://gerrit.wikimedia.org/r/116095 (owner: 10Anomie) [13:24:41] right [13:24:56] anomie: If I merge, can you deploy? [13:25:23] hoo: In about 35 minutes [13:25:51] ok, feel free to ping me then [13:30:33] (03CR) 10Bartosz Dziewoński: "This broke compatibility with MW 1.19, see bug 62051." [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/42772 (owner: 10Daniel Kinzler) [13:35:07] (03PS1) 10Netbrain: Added composer dependency management Fixed bug where globals were not available to config mechanism Fixed bug where tag parsing occurred more than once. Removed legacy/unused code [extensions/SideBarMenu] - 10https://gerrit.wikimedia.org/r/116098 [13:37:34] Working on this bug: https://bugzilla.wikimedia.org/show_bug.cgi?id=57044. If I remove the 'Wikidata Item ID' won't if remove the same from the page it redirects to ? [13:38:35] The page:https://en.wikipedia.org/w/index.php?title=Main_page&action=info and the page it redirects to: https://en.wikipedia.org/w/index.php?title=Main_Page&action=info [13:40:23] (03CR) 10Netbrain: [C: 032 V: 032] Added composer dependency management Fixed bug where globals were not available to config mechanism Fixed bug where tag parsing occurred mor [extensions/SideBarMenu] - 10https://gerrit.wikimedia.org/r/116098 (owner: 10Netbrain) [13:53:35] (03PS2) 10Hashar: mw-tools-releng-tox-doc-publish [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/115974 [13:53:52] (03PS3) 10Hashar: mw-tools-releng-tox-doc-publish [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/115974 [13:53:55] (03PS2) 10Hashar: Make tox shell wrapper a macro [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/115973 [13:54:17] (03CR) 10Hashar: [C: 032] Make tox shell wrapper a macro [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/115973 (owner: 10Hashar) [13:54:30] (03CR) 10Hashar: [C: 032] mw-tools-releng-tox-doc-publish [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/115974 (owner: 10Hashar) [13:54:45] (03Merged) 10jenkins-bot: Make tox shell wrapper a macro [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/115973 (owner: 10Hashar) [13:55:01] (03Merged) 10jenkins-bot: mw-tools-releng-tox-doc-publish [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/115974 (owner: 10Hashar) [13:57:14] (03CR) 10Manybubbles: "I hear you on twisted. For me with a Java background the multiprocessing module made a ton of sense. Not as good as the java stuff but n" (031 comment) [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/115991 (owner: 10Manybubbles) [14:06:08] hoo: ping [14:06:41] anomie: ok, shall I merge now? [14:06:59] hoo: Go ahead [14:07:35] (03CR) 10Hoo man: [C: 032] "per merge on master (already live for wmf16)" [core] (wmf/1.23wmf15) - 10https://gerrit.wikimedia.org/r/116095 (owner: 10Anomie) [14:08:15] Ok, let's wait for jenkins... [14:08:31] no deploy happening atm, so I guess you can shoot it :D [14:11:20] (03Merged) 10jenkins-bot: Use inContentLanguage for dropdown messages in HTMLFormField [core] (wmf/1.23wmf15) - 10https://gerrit.wikimedia.org/r/116095 (owner: 10Anomie) [14:12:03] hoo: That's the nice thing about this time of day, the SF people are usually still asleep ;) [14:13:09] (03PS1) 10Shirayuki: i18n: fix typo "receiving" [extensions/MediaWikiChat] - 10https://gerrit.wikimedia.org/r/116101 [14:13:24] hoo: busy? https://bugzilla.wikimedia.org/show_bug.cgi?id=62051 [14:16:02] (03PS2) 10Aude: add flaggedrevs-hidereviewed show / hide i18n messages [extensions/FlaggedRevs] - 10https://gerrit.wikimedia.org/r/116054 [14:16:23] MatmaRex: didn't I comment on that one? [14:16:29] Maybe I didn't send my comment... mh [14:17:38] (03PS3) 10Aude: add flaggedrevs-hidereviewed show / hide i18n messages [extensions/FlaggedRevs] - 10https://gerrit.wikimedia.org/r/116054 [14:19:00] (03PS1) 10Deepali: Add better spinner icon for jquery.spinner.js [core] - 10https://gerrit.wikimedia.org/r/116103 [14:21:40] (03PS1) 10Hashar: Assert SSH_AUTH_SOCK exist after parse_args() [tools/scap] - 10https://gerrit.wikimedia.org/r/116104 [14:21:42] MatmaRex: should be out now [14:23:20] hoo: breaking compat is all okay (we have release branches for exts for a reason), it just seemed accidental, the commit mesasge doesn't even mention this, and it causes fatals on 1.19 [14:24:02] Well, there are two or three commits that don't go with 1.19 [14:24:10] I know about that and I'm not happy [14:24:38] we'll have a new LTS soon too [14:25:26] yeah, that's why I would like that discussed... I briefly talked to Chris about that, but we didn't really come to an opinion [14:25:34] (03PS1) 10Hashar: mw-tools-scap-tox-doc-publish [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/116105 [14:25:35] the release branches are a bit of a mess [14:25:37] (03PS1) 10Hashar: mw-tools-scap-tox-doc [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/116106 [14:26:50] a lot of 3rd parties use AbuseFilter yet I have hardly an idea how they obtain etc. it... [14:29:24] (03CR) 10AndyRussG: "Thanks Aude!!" [extensions/Campaigns] (wip/editorcampaigns) - 10https://gerrit.wikimedia.org/r/115853 (owner: 10AndyRussG) [14:30:26] AndyRussG: i don't have great solutions for that [14:30:43] Hi aude [14:30:57] Mmmm [14:30:57] but think composer install should be part of making deployment branches (though we don't have good process for that) [14:31:28] can't run composer in production (unless it used a wmf hosted satis/packagist) [14:31:39] Hmmm [14:32:15] then put libs in vendor directory of core, preferably so they can be shared (in case we want to share something) [14:32:35] (03PS1) 10Hashar: Trigger mw-tools-scap-tox-doc [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/116107 [14:32:40] for now maybe don't worry but we should be thinking about how to handle it nicer [14:32:51] Yeah [14:33:04] * aude sure some point multiple extensions will include the same thing with composer and that will cause issue [14:33:10] unlike js where that's not an issue [14:33:11] (03CR) 10Hashar: [C: 032] "Runs tox -edoc on patch submission in Gerrit \O/" [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/116107 (owner: 10Hashar) [14:33:16] (03Merged) 10jenkins-bot: Trigger mw-tools-scap-tox-doc [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/116107 (owner: 10Hashar) [14:33:46] * aude thinks elastica will be such example [14:34:25] (03Restored) 10Hashar: Jenkins job validation (DO NOT SUBMIT) [tools/scap] - 10https://gerrit.wikimedia.org/r/114782 (owner: 10Hashar) [14:34:27] (03PS2) 10Hashar: Jenkins job validation (DO NOT SUBMIT) [tools/scap] - 10https://gerrit.wikimedia.org/r/114782 [14:34:39] Hmm I don't know elastica [14:34:50] for elastic search (obvious) which cirrus uses [14:34:52] (03CR) 10jenkins-bot: [V: 04-1] Jenkins job validation (DO NOT SUBMIT) [tools/scap] - 10https://gerrit.wikimedia.org/r/114782 (owner: 10Hashar) [14:35:13] anything else that wants to use elastic (e.g. wikibase), then needs to coordinate using the same library (elastica) [14:35:17] or geodata [14:35:49] (03PS2) 10Hashar: Assert SSH_AUTH_SOCK exist after parse_args() [tools/scap] - 10https://gerrit.wikimedia.org/r/116104 [14:35:51] symfony stuff is also likely to be used in multiple extensions [14:36:21] right [14:36:27] (03CR) 10Hashar: [C: 032] "That fix the doc job :-]" [tools/scap] - 10https://gerrit.wikimedia.org/r/116104 (owner: 10Hashar) [14:36:54] (03Merged) 10jenkins-bot: Assert SSH_AUTH_SOCK exist after parse_args() [tools/scap] - 10https://gerrit.wikimedia.org/r/116104 (owner: 10Hashar) [14:36:56] So more like some a solution is needed for shared external libs server-side [14:37:08] (03CR) 10Aude: "jenkins can't run composer (hence for wikidata, we now manage our own jenkins in labs as a work around. not a great solution though)" [extensions/Campaigns] (wip/editorcampaigns) - 10https://gerrit.wikimedia.org/r/115853 (owner: 10AndyRussG) [14:37:13] AndyRussG: think so [14:37:15] (03PS3) 10Hashar: Jenkins job validation (DO NOT SUBMIT) [tools/scap] - 10https://gerrit.wikimedia.org/r/114782 [14:37:25] i think there is a wmf npm thing for parsoid / visual editor [14:38:55] Ah could be... James_F was telling me about something they use for VE, I think it's grunt [14:39:11] grunt builds all the stuff [14:39:23] (we use it also for wikibase, then push the build to gerrit) [14:39:31] then jenkins can do tests [14:39:42] might be overly complicated for campaigns [14:39:47] in theory composer *should* stor such things in like $IP/includes/lib [14:39:47] not per extension [14:39:47] a bit like the common linux distros do it [14:40:23] There might be one or more RFCs about this or related issues [14:40:31] composer does "know" about mediawiki. it can know about package types "mediawiki-extension" vs "library" [14:40:43] put extensions in the extensions directory, libraries in vendor [14:40:54] AndyRussG: there are [14:42:01] aude: but per extension AFAIR... so if two extension need the Awesome library they'll collid [14:42:41] hoo: currently but composer can be run from core root dir [14:43:00] require wikibase and then wikibase goes in right place, libraries go in right place [14:43:14] but we can't possibly use that in production [14:43:18] not yet [14:43:41] will probably be unavoidable in the future, and then we need a wmf hosted packagist / satis [14:43:55] * aude sees things going this direction [14:43:57] wmf has a packagist [14:44:03] ooo [14:44:04] login is on ferna [14:44:07] * fenari, even [14:44:23] i mean self-hosted though? [14:44:37] we can also have stuff in the real packagist [14:44:53] Ah, you mean an own pagackagist thing [14:45:06] Is there a bug for that? [14:45:09] * aude notes i was previously skeptical of composer [14:45:13] hoo: no idea [14:45:24] (03PS1) 10Hashar: Link to Jenkins coverage report for mw/core [integration/docroot] - 10https://gerrit.wikimedia.org/r/116108 [14:45:32] (03CR) 10Hashar: [C: 032] Link to Jenkins coverage report for mw/core [integration/docroot] - 10https://gerrit.wikimedia.org/r/116108 (owner: 10Hashar) [14:45:35] (03Merged) 10jenkins-bot: Link to Jenkins coverage report for mw/core [integration/docroot] - 10https://gerrit.wikimedia.org/r/116108 (owner: 10Hashar) [14:45:40] I was as well, and I'm still a little when it comes to installing multiple extensions with it [14:45:46] * aude setup one on labs... think it's gone now but is puppetized [14:45:54] http://www.mediawiki.org/wiki/Requests_for_comment/Third-party_components [14:46:30] http://www.mediawiki.org/wiki/Requests_for_comment/MediaWiki_libraries [14:46:36] yep [14:46:57] (03CR) 10Hashar: [C: 032] mw-tools-scap-tox-doc-publish [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/116105 (owner: 10Hashar) [14:47:03] (03CR) 10Hashar: [C: 032] mw-tools-scap-tox-doc [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/116106 (owner: 10Hashar) [14:47:15] (03Merged) 10jenkins-bot: mw-tools-scap-tox-doc-publish [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/116105 (owner: 10Hashar) [14:47:31] (03Merged) 10jenkins-bot: mw-tools-scap-tox-doc [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/116106 (owner: 10Hashar) [14:47:47] (03PS2) 10PleaseStand: Exceptions were directly outputting {{SITENAME}}. [core] - 10https://gerrit.wikimedia.org/r/116080 (owner: 10Brian Wolff) [14:48:44] I wonder if any headway has been made, either at the architecture summit or other meetings about RFCs [14:49:00] (03PS1) 10Hashar: Switch sphinx theme to nature [tools/releng] - 10https://gerrit.wikimedia.org/r/116109 [14:49:41] Anyway, it's nice to see discussion of relevant issues... [14:50:03] (03CR) 10Hashar: [C: 032] Switch sphinx theme to nature [tools/releng] - 10https://gerrit.wikimedia.org/r/116109 (owner: 10Hashar) [14:50:26] For campaigns if possible I think I'll just plough ahead and see what happens [14:50:51] (03Merged) 10jenkins-bot: Switch sphinx theme to nature [tools/releng] - 10https://gerrit.wikimedia.org/r/116109 (owner: 10Hashar) [14:51:38] aude: did you by chance see the idea about using Wikibase (linked from the Campaigns change: https://www.mediawiki.org/wiki/Editor_campaigns/Notes#Structured_data_store) ? [14:52:28] (03Abandoned) 10Hashar: Jenkins job validation (DO NOT SUBMIT) [tools/scap] - 10https://gerrit.wikimedia.org/r/114782 (owner: 10Hashar) [14:54:19] AndyRussG: no [14:54:51] AndyRussG: there are regular irc meetings to discuss rfcs [14:55:05] i don't think the libraries / component one has been discussed yet, though [14:55:19] Hmmm [14:55:32] I hope we'll have an architecture session in Zürich [14:55:38] so much to discuss... [14:55:42] I can try to see if it's on the agenda for sometime [14:55:44] for reusing wikibase, you can use our components without wikibase [14:55:57] wikibase data model to handle properties, data values to handle geo / time [14:56:15] aude: right... [14:56:16] at least that's the intention for them to be reusable, [14:56:28] maybe you still need stuff in wikibase [14:56:34] (03PS1) 10Hashar: Publish doc for mediawiki/tools/{releng,scap} [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/116110 [14:56:48] (03CR) 10Hashar: [C: 032] Publish doc for mediawiki/tools/{releng,scap} [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/116110 (owner: 10Hashar) [14:56:53] (03Merged) 10jenkins-bot: Publish doc for mediawiki/tools/{releng,scap} [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/116110 (owner: 10Hashar) [14:56:58] if you did reuse something, then the issue of having libraries in one place for mediawiki becomes issue (though) [14:57:00] hoo: I think the recent architecture summit in SF had a lot to consider, too... [14:57:12] hoo: i'm sure there will be such session [14:57:58] aude: I was kinda thinking more along the lines of a separate Wikibase repo accessible somewhere via API only, no user-faceing UI [14:58:06] AndyRussG: Of course, but there are a billion things moving, so that people need to stay in touch etc. [14:58:08] hmmm, interesting [14:58:30] our api should probably be a separate component :) [14:58:35] basically to persiste campaigns data via structured data rather than silly DB tables [14:58:39] * aude didn't see such use case before [14:59:10] And be able to link it to other structured data (including Wikidata of course) [14:59:14] yep [14:59:42] Also to better encapsulate components for different campagins [15:00:00] * aude nods [15:00:33] there needs to be a component for general campaigns functions [15:00:51] then separate ones for different sorts of campaigns (and collaborations in general, that's the wider use case) [15:01:22] and each one will legitimately want to attach their own sort of data points [15:01:42] for example an edit-a-thon may have a venue [15:02:21] hmmmm [15:02:44] and courses already want to have different sponsoring organizations [15:03:50] * aude off [15:04:48] bye aude [15:11:47] hoo: let me try to find if this stuff is on the agenda for any meetings... I won't be in Zurich [15:12:42] :) [15:13:55] https://www.mediawiki.org/wiki/Architecture_meetings/RFC_review_2014-02-27 [15:14:48] https://www.mediawiki.org/wiki/Architecture_meetings [15:15:56] There must be a way to ask for things to be discussed... [15:20:24] (03PS1) 10Andrew Bogott: Add $wgOpenStackManagerReadOnlyRegions. [extensions/OpenStackManager] - 10https://gerrit.wikimedia.org/r/116112 [15:23:38] (03CR) 10Andrew Bogott: [C: 032] Add $wgOpenStackManagerReadOnlyRegions. [extensions/OpenStackManager] - 10https://gerrit.wikimedia.org/r/116112 (owner: 10Andrew Bogott) [15:23:40] (03Merged) 10jenkins-bot: Add $wgOpenStackManagerReadOnlyRegions. [extensions/OpenStackManager] - 10https://gerrit.wikimedia.org/r/116112 (owner: 10Andrew Bogott) [15:35:16] Bawolff: no. [15:36:15] LaughOutLoud! [15:44:39] (03Restored) 10Hashar: Jenkins validation (DO NOT SUBMIT) [tools/releng] - 10https://gerrit.wikimedia.org/r/115600 (owner: 10Hashar) [15:44:41] (03PS3) 10Hashar: Jenkins validation (DO NOT SUBMIT) [tools/releng] - 10https://gerrit.wikimedia.org/r/115600 [15:52:46] (03Abandoned) 10Hashar: Jenkins validation (DO NOT SUBMIT) [tools/releng] - 10https://gerrit.wikimedia.org/r/115600 (owner: 10Hashar) [15:58:15] (03PS2) 10Matthias Mullie: (bug 61107) Contributions from Flow appear in every namespace [extensions/Flow] - 10https://gerrit.wikimedia.org/r/115908 [15:59:00] (03CR) 10Reedy: [C: 032] Remove "required" messages. HTMLForm takes care of that with validation. [extensions/ContactPage] - 10https://gerrit.wikimedia.org/r/115977 (owner: 10Reedy) [15:59:05] (03Merged) 10jenkins-bot: Remove "required" messages. HTMLForm takes care of that with validation. [extensions/ContactPage] - 10https://gerrit.wikimedia.org/r/115977 (owner: 10Reedy) [16:05:47] (03PS15) 10Reedy: Allow inclusion of additional fields [extensions/ContactPage] - 10https://gerrit.wikimedia.org/r/113883 [16:06:02] (03CR) 10Reedy: [C: 04-1] Allow inclusion of additional fields [extensions/ContactPage] - 10https://gerrit.wikimedia.org/r/113883 (owner: 10Reedy) [16:06:20] (03PS1) 10Matthias Mullie: Add index on revision user data [extensions/Flow] - 10https://gerrit.wikimedia.org/r/116115 [16:06:33] (03CR) 10jenkins-bot: [V: 04-1] Add index on revision user data [extensions/Flow] - 10https://gerrit.wikimedia.org/r/116115 (owner: 10Matthias Mullie) [16:07:28] (03PS2) 10Matthias Mullie: [SCHEMA CHANGE] Add index on revision user data [extensions/Flow] - 10https://gerrit.wikimedia.org/r/116115 [16:09:38] (03CR) 10Hashar: Deprecates $wgRateLimitLog in favor of debug log (031 comment) [core] - 10https://gerrit.wikimedia.org/r/115902 (owner: 10Hashar) [16:09:52] (03PS2) 10Hashar: Deprecates $wgRateLimitLog in favor of debug log [core] - 10https://gerrit.wikimedia.org/r/115902 [16:10:29] (03CR) 10Matthias Mullie: (bug 61107) Contributions from Flow appear in every namespace (034 comments) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/115908 (owner: 10Matthias Mullie) [16:10:33] (03CR) 10Hashar: "Removed the \n from wfDebugLog(). Merci iAlex!" [core] - 10https://gerrit.wikimedia.org/r/115902 (owner: 10Hashar) [16:12:28] (03CR) 10Anomie: "Someone should check whether 1.19 is even vulnerable to the bug. Based on this patch it looks like not." [core] (REL1_19) - 10https://gerrit.wikimedia.org/r/115961 (owner: 10Mglaser) [16:16:35] (03PS1) 10Matthias Mullie: Spam-checking moderation doesn't make sense [extensions/Flow] - 10https://gerrit.wikimedia.org/r/116117 [16:21:30] (03PS6) 10PiRSquared17: Add option to show only creations in Special:Contribs, API [core] - 10https://gerrit.wikimedia.org/r/115189 (owner: 10Gerrit Patch Uploader) [16:24:50] (03CR) 10Anomie: "Never mind, it is. And PleaseStand is right." [core] (REL1_19) - 10https://gerrit.wikimedia.org/r/115961 (owner: 10Mglaser) [16:26:58] (03CR) 10Anomie: [C: 032] Fix number of parameters passed on recursive function call [core] - 10https://gerrit.wikimedia.org/r/115976 (owner: 10Reedy) [16:30:36] (03Merged) 10jenkins-bot: Fix number of parameters passed on recursive function call [core] - 10https://gerrit.wikimedia.org/r/115976 (owner: 10Reedy) [16:31:48] (03CR) 10BryanDavis: Remove '--versions', run_on_cluster, build_command, sudo_args and cluster_run (034 comments) [tools/scap] - 10https://gerrit.wikimedia.org/r/116068 (owner: 10Ori.livneh) [16:36:43] (03CR) 10Anomie: [C: 032] Add option to show only creations in Special:Contribs, API [core] - 10https://gerrit.wikimedia.org/r/115189 (owner: 10Gerrit Patch Uploader) [16:36:48] (03CR) 10BryanDavis: Validate --versions arguments to scap (031 comment) [tools/scap] - 10https://gerrit.wikimedia.org/r/116017 (owner: 10BryanDavis) [16:38:16] (03CR) 10Anomie: "Why'd you lose the "-required" in PS15?" [extensions/ContactPage] - 10https://gerrit.wikimedia.org/r/113883 (owner: 10Reedy) [16:38:53] (03CR) 10Umherirrender: [C: 04-1] "Trailing spacing" [core] - 10https://gerrit.wikimedia.org/r/115970 (owner: 10Mglaser) [16:40:27] (03Merged) 10jenkins-bot: Add option to show only creations in Special:Contribs, API [core] - 10https://gerrit.wikimedia.org/r/115189 (owner: 10Gerrit Patch Uploader) [16:43:02] (03CR) 10Anomie: "Oh, that's from Ib49600ea. I'm not sure I like losing the indication that it's required from before submission, but whatever." [extensions/ContactPage] - 10https://gerrit.wikimedia.org/r/113883 (owner: 10Reedy) [16:44:14] (03CR) 10Reedy: "Maybe HTMLForm should have a way of indicating this... I'll file a bug as a TODO" [extensions/ContactPage] - 10https://gerrit.wikimedia.org/r/113883 (owner: 10Reedy) [16:44:45] (03PS1) 10Anomie: Fix message usage [extensions/ContactPage] - 10https://gerrit.wikimedia.org/r/116119 [16:45:03] Hi! I am Avishek Bhattacharjee, currently learning Android application development. I would like to contribute to any of the projects regarding Android application development. Can anyone guide me please? [16:46:25] (03CR) 10Reedy: [C: 032] Fix message usage [extensions/ContactPage] - 10https://gerrit.wikimedia.org/r/116119 (owner: 10Anomie) [16:46:27] (03Merged) 10jenkins-bot: Fix message usage [extensions/ContactPage] - 10https://gerrit.wikimedia.org/r/116119 (owner: 10Anomie) [16:46:29] (03CR) 10Anomie: Remove "required" messages. HTMLForm takes care of that with validation. (031 comment) [extensions/ContactPage] - 10https://gerrit.wikimedia.org/r/115977 (owner: 10Reedy) [16:47:25] (03CR) 10Umherirrender: [C: 031] "Looks good as a first step in the right way." [core] - 10https://gerrit.wikimedia.org/r/114400 (owner: 10Bartosz Dziewoński) [16:50:40] hey Avishek, just clone our repository and start hacking:) [16:51:10] YuviPanda, app developer ^^^ [16:51:28] (03CR) 10Reedy: "Filed as https://bugzilla.wikimedia.org/show_bug.cgi?id=62064" [extensions/ContactPage] - 10https://gerrit.wikimedia.org/r/113883 (owner: 10Reedy) [16:52:28] MaxSem: okay.. I actually did send a mail to YuviPanda.. he hasn't replied yet. [16:59:31] (03CR) 10Anomie: [C: 04-1] Switch API to use Config classes (031 comment) [core] - 10https://gerrit.wikimedia.org/r/109271 (owner: 10Reedy) [16:59:57] Avishek: You can also connect to the mobile people in #Wikimedia-mobile [17:01:01] (03CR) 10Anomie: "Are they really disabled for performance, or just because they're basically pointless?" [core] - 10https://gerrit.wikimedia.org/r/113909 (owner: 10Burthsceh) [17:01:41] Amgine_: just joined the channel! Thanks! :) [17:01:47] yw [17:01:58] It is pretty quiet on weekends. [17:02:06] Amgine_: Got the same response from #mediawiki [17:03:16] (03PS1) 10Ottomata: Fixing reference to mysql root password variable in wikimetrics role [vagrant] - 10https://gerrit.wikimedia.org/r/116120 [17:03:28] (03PS2) 10Ottomata: Fixing reference to mysql root password variable in wikimetrics role [vagrant] - 10https://gerrit.wikimedia.org/r/116120 [17:03:40] (03CR) 10Ottomata: [C: 032 V: 032] Fixing reference to mysql root password variable in wikimetrics role [vagrant] - 10https://gerrit.wikimedia.org/r/116120 (owner: 10Ottomata) [17:04:33] Amgine_: oh.. well, I am kinda new to FOSS.. Had a chat with Sumanah Harihareshwara.. she introduced me to this channel..:) [17:05:08] Sumanah is great! [17:05:44] Amgine_: Yeah! She is! [17:06:49] Her name is Sumana actually. :P [17:07:35] SumanaH, yes. [17:08:36] does this link work for people? :> https://docs.google.com/spreadsheet/pub?key=0ArUN7tgsOZ8qdDNUWUJvN3dwVHdjWS10UXppWXpSSmc&gid=2 [17:09:23] addshore: Wants to have flash enabled [17:09:30] Niharika: oh.. she had her nick as sumanah actually..:P [17:09:31] ahh true! [17:09:43] maybe I should make a flashless one too [17:09:46] Also, it's googledocs... [17:11:27] I am aware of that :P [17:12:01] for all the obvious reasons, a bunch of people don't use google docs. [17:14:20] (03CR) 10Umherirrender: "IContextSource::getConfig is called often, maybe that method can take the string direct as input param, that will make the code for the ca" [core] - 10https://gerrit.wikimedia.org/r/109271 (owner: 10Reedy) [17:19:01] (03CR) 10Umherirrender: [C: 031] "Was wfMsgNoTrans before (Last change: Ib15e670badd3f6aecae8b60e2f9129a31341ce16)" [core] - 10https://gerrit.wikimedia.org/r/116080 (owner: 10Brian Wolff) [17:20:41] (03CR) 10Umherirrender: [C: 031] Update mw.api.watch according to new Watch API [core] - 10https://gerrit.wikimedia.org/r/116067 (owner: 10Eranroz) [17:21:22] (03CR) 10Addshore: [C: 031] Warn on account creation when username is adjusted [core] - 10https://gerrit.wikimedia.org/r/114400 (owner: 10Bartosz Dziewoński) [17:27:40] (03CR) 10BryanDavis: [C: 04-1] "The argparser needes to allow the deprecated `--extended` command flag which is still used by git-deploy and l10update scripts or this cha" (034 comments) [tools/scap] - 10https://gerrit.wikimedia.org/r/116062 (owner: 10BryanDavis) [17:29:11] (03CR) 10Umherirrender: "Not a blocker, only a info" (034 comments) [core] - 10https://gerrit.wikimedia.org/r/115608 (owner: 10Addshore) [17:29:48] (03CR) 10Bsitu: [C: 04-1] "Will do a rebase to get the latest master change" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/111671 (owner: 10Bsitu) [17:39:03] (03CR) 10Anomie: "I have to wonder why this is being put in the API, since it's entirely unusable except for internal calls? You could as well post to an un" (036 comments) [core] - 10https://gerrit.wikimedia.org/r/113038 (owner: 10Aaron Schulz) [17:42:01] (03PS3) 10Krinkle: [WIP] resourceloader: Fix broken 'skinStyles' loop in file module getModifiedTime [core] - 10https://gerrit.wikimedia.org/r/112837 [17:43:25] (03CR) 10Addshore: Moved job running via $wgJobRunRate to a special API (031 comment) [core] - 10https://gerrit.wikimedia.org/r/113038 (owner: 10Aaron Schulz) [17:43:49] (03CR) 10Umherirrender: [C: 031] "You are right, no need to use {{#special:}} here, because it is only in the link part. When it is used as linktext (or the link has no lin" [core] - 10https://gerrit.wikimedia.org/r/114713 (owner: 10Amire80) [17:49:01] (03CR) 10Umherirrender: [C: 031] Remove 2 false values returned in execute() [core] - 10https://gerrit.wikimedia.org/r/113894 (owner: 10Reedy) [17:49:03] (03PS17) 10Bsitu: [SCHEMA CHANGE] Add corresponding *_user_wiki field to all *_user_id fields [extensions/Flow] - 10https://gerrit.wikimedia.org/r/111671 [17:54:19] (03CR) 10Daniel Kinzler: [C: 04-1] "I'm not very happy with how config objects get constructed." (035 comments) [core] - 10https://gerrit.wikimedia.org/r/109850 (owner: 10Ori.livneh) [17:54:54] (03CR) 10Swalling: [C: 04-1] "This is still the wrong solution from a UX perspective. Any possibility where the user must resubmit the form because of minor whitespace " [core] - 10https://gerrit.wikimedia.org/r/114400 (owner: 10Bartosz Dziewoński) [17:54:56] (03PS1) 10MarkTraceur: Dummy job for testing [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/116123 [17:55:22] (03PS1) 10Krinkle: Customise mediawiki-core-npm to use diffent directory [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/116124 [17:55:25] (03PS1) 10Krinkle: Various clean up and refactor to make mediawiki-core-npm faster [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/116125 [17:58:54] (03CR) 10Daniel Kinzler: "@Bene: you'd have to create tests/phpunit/includes/SkinTemplateTest.php" [core] - 10https://gerrit.wikimedia.org/r/111159 (owner: 10Bene) [17:59:51] (03CR) 10Bartosz Dziewoński: "Steven, if you care so much about users with JS disabled, the signup form has worse usability issues for them: http://i.imgur.com/ceiYCdq." [core] - 10https://gerrit.wikimedia.org/r/114400 (owner: 10Bartosz Dziewoński) [18:00:22] (03CR) 10Krinkle: Update mw.api.watch according to new Watch API (032 comments) [core] - 10https://gerrit.wikimedia.org/r/116067 (owner: 10Eranroz) [18:03:02] (03CR) 10Nikerabbit: [C: 04-1] "Please comment that ->text() calling database to load templates etc. is not going to be a problem." [core] - 10https://gerrit.wikimedia.org/r/116080 (owner: 10Brian Wolff) [18:05:42] (03PS18) 10Bsitu: [SCHEMA CHANGE] Add corresponding *_user_wiki field to all *_user_id fields [extensions/Flow] - 10https://gerrit.wikimedia.org/r/111671 [18:07:12] (03CR) 10Nikerabbit: Button group adjustments (031 comment) [core] - 10https://gerrit.wikimedia.org/r/116075 (owner: 10Pginer) [18:08:00] (03CR) 10Ori.livneh: Remove '--versions', run_on_cluster, build_command, sudo_args and cluster_run (031 comment) [tools/scap] - 10https://gerrit.wikimedia.org/r/116068 (owner: 10Ori.livneh) [18:08:28] (03PS1) 10Inchikutty: Embedding Static Map to UploadWizard [extensions/UploadWizard] (osm) - 10https://gerrit.wikimedia.org/r/116127 [18:08:33] (03PS1) 10Inchikutty: Adding Leaflet scripts to UploadWizard [extensions/UploadWizard] (osm) - 10https://gerrit.wikimedia.org/r/116128 [18:08:37] (03PS6) 10Ori.livneh: Remove '--versions', run_on_cluster, build_command, sudo_args and cluster_run [tools/scap] - 10https://gerrit.wikimedia.org/r/116068 [18:08:39] (03PS1) 10Inchikutty: Embedding leaflet maps based on OSM data to UploadWizard [extensions/UploadWizard] (osm) - 10https://gerrit.wikimedia.org/r/116129 [18:08:42] (03CR) 10jenkins-bot: [V: 04-1] Remove '--versions', run_on_cluster, build_command, sudo_args and cluster_run [tools/scap] - 10https://gerrit.wikimedia.org/r/116068 (owner: 10Ori.livneh) [18:08:44] (03PS1) 10Inchikutty: [WIP]UploadWizard:OSM embedding- Geocoding, reverse geocoding [extensions/UploadWizard] (osm) - 10https://gerrit.wikimedia.org/r/116130 [18:09:50] (03CR) 10UltrasonicNXT: [C: 032 V: 032] "Thanks!" [extensions/MediaWikiChat] - 10https://gerrit.wikimedia.org/r/116101 (owner: 10Shirayuki) [18:15:25] aude: re https://gerrit.wikimedia.org/r/#/c/116054/3 , ugh, this needs backports :/ [18:15:43] MatmaRex: It's on my list ;) [18:15:46] aude: and possibly similar fixes in other extensions [18:15:52] yes [18:15:55] i'm wondering if it wouldn't be easier to fix core [18:16:10] (03PS2) 10Inchikutty: Embedding Static Map to UploadWizard [extensions/UploadWizard] (osm) - 10https://gerrit.wikimedia.org/r/116127 [18:16:23] ok, that one I can't answer... I guess this was done for a reason :P [18:16:25] like making it only use these messages if they're defined, or just always use show/hide [18:16:58] there definitely was a reason, but i somehow missed the implications, heh [18:17:05] (03PS1) 10UltrasonicNXT: Fix multiple kicks problem [extensions/MediaWikiChat] - 10https://gerrit.wikimedia.org/r/116131 [18:17:10] MatmaRex: If you do that, I guess I/ we can review merge and deploy [18:17:29] (03CR) 10UltrasonicNXT: [C: 032 V: 032] Fix multiple kicks problem [extensions/MediaWikiChat] - 10https://gerrit.wikimedia.org/r/116131 (owner: 10UltrasonicNXT) [18:17:34] hoo: i assume you guys did the wikidata one already? [18:17:59] shouldn't be merged, yet [18:18:05] it's not [18:18:17] https://gerrit.wikimedia.org/r/#/c/116096/ yeah [18:18:36] let's link the bug on both and i'll merge [18:18:52] merge what? [18:19:05] the wikibase and flaggedrevs patches? [18:19:16] MatmaRex: Thought you wanted to do that in core? [18:19:18] Or rather both? [18:19:21] and then i'll write and push the core fix to keep this more compatible [18:19:33] yeah, doing both seems reasonable to me [18:19:33] ok, so both [18:19:40] I can review the extension stuff [18:21:13] Krinkle, why are we enforcing single quotes in all strings in JS? it doesn't seem to make much sense in tests: assert.ok( something, "don't do something" ) [18:21:25] I'd have to escape ' if I used single quotes [18:22:17] jgonera: I couldn't care less. There are no magic quotes in javascript ('\n' === "\n"), we want to be consistent (mixed quotes is the worst, leads to bugs, insecurities, and makes it harder to read stuff), and we flipped a coin and settled on single quotes. [18:22:32] The same can be said for html, where double quotes are the convention [18:22:37] you'd have to escape the " in there [18:22:40] '
' [18:22:44] "
" [18:22:50] english text doesn't belong in javascript [18:22:55] why mixed quotes leads to bugs and insecurities? [18:23:00] html not either, but is far more common, so I'd guess that wins [18:23:11] I'm not going to explain that. [18:23:17] ok [18:23:19] Feel free to ask later if you want to learn more :) [18:23:27] I'll just google [18:23:47] but bottom line is, difference is very very minor. It's not "the" reason we use single quotes. Consistency is most importnat, which one is a minor inconvenience. [18:25:07] consistency, yes, but I'd say many languages have both single and double quotes for strings for a reason, e.g. not to escape them when you don't have to [18:25:14] but ok, I guess that's easier [18:26:43] hoo: btw, does this have a bug filed? (let's reuse the old one if not) [18:26:59] (03PS22) 10Inchikutty: Embedding Static Map to UploadWizard [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/107892 [18:27:14] MatmaRex: Don't think so [18:30:26] (03CR) 10MarkTraceur: "If you actually don't want us to review this patch, please abandon it." [extensions/BetaFeatures] - 10https://gerrit.wikimedia.org/r/110238 (owner: 10Mno2) [18:33:00] (03PS1) 10Krinkle: Update js-related job files filter to match ".jscsrc" [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/116135 [18:33:03] (03PS1) 10Krinkle: Enable mediawiki-core-npm (runs jshint+jscs), disable mediawiki-core-jslint [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/116136 [18:33:14] (03PS1) 10Bartosz Dziewoński: SpecialRecentchanges: Don't use nonexistent messages for filter selector [core] - 10https://gerrit.wikimedia.org/r/116137 [18:33:19] hoo: ^ [18:33:44] (03CR) 10Krinkle: [C: 032] "Fixes bug in oojs, visualeditor and other repos where it wouldn't run if jscs config was updated." [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/116135 (owner: 10Krinkle) [18:33:50] * hoo clicks [18:34:38] (03Merged) 10jenkins-bot: Update js-related job files filter to match ".jscsrc" [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/116135 (owner: 10Krinkle) [18:35:01] (03PS4) 10Bartosz Dziewoński: Add flaggedrevs-hidereviewed show / hide i18n messages [extensions/FlaggedRevs] - 10https://gerrit.wikimedia.org/r/116054 (owner: 10Aude) [18:35:16] (03PS24) 10Adamw: Provision WMF Fundraising projects [vagrant] - 10https://gerrit.wikimedia.org/r/94950 [18:37:03] (03PS3) 10Inchikutty: Embedding Static Map to UploadWizard [extensions/UploadWizard] (osm) - 10https://gerrit.wikimedia.org/r/116127 [18:39:22] (03CR) 10Adamw: "No rush on merging this, so I'd rather wait for the long-term solution to the Vagrant-extra business. It's really important to me that th" [vagrant] - 10https://gerrit.wikimedia.org/r/94950 (owner: 10Adamw) [18:41:12] hoo: i updated all the patches and commented on the bug [18:43:07] MatmaRex: Thanks... will have a look [18:44:49] (03CR) 10BryanDavis: Remove '--versions', run_on_cluster, build_command, sudo_args and cluster_run (031 comment) [tools/scap] - 10https://gerrit.wikimedia.org/r/116068 (owner: 10Ori.livneh) [18:45:09] (03CR) 10Bartosz Dziewoński: [C: 031] Add flaggedrevs-hidereviewed show / hide i18n messages [extensions/FlaggedRevs] - 10https://gerrit.wikimedia.org/r/116054 (owner: 10Aude) [18:52:56] (03CR) 10EBernhardson: [C: 032] [SCHEMA CHANGE] Add corresponding *_user_wiki field to all *_user_id fields [extensions/Flow] - 10https://gerrit.wikimedia.org/r/111671 (owner: 10Bsitu) [18:53:33] (03Merged) 10jenkins-bot: [SCHEMA CHANGE] Add corresponding *_user_wiki field to all *_user_id fields [extensions/Flow] - 10https://gerrit.wikimedia.org/r/111671 (owner: 10Bsitu) [19:05:50] (03PS2) 10EBernhardson: Pull flow revision data based on user_wiki and user_id/user_ip [extensions/Flow] - 10https://gerrit.wikimedia.org/r/111952 (owner: 10Bsitu) [19:06:07] (03CR) 10EBernhardson: [C: 032] Pull flow revision data based on user_wiki and user_id/user_ip [extensions/Flow] - 10https://gerrit.wikimedia.org/r/111952 (owner: 10Bsitu) [19:06:25] (03Merged) 10jenkins-bot: Pull flow revision data based on user_wiki and user_id/user_ip [extensions/Flow] - 10https://gerrit.wikimedia.org/r/111952 (owner: 10Bsitu) [19:13:06] (03CR) 10EBernhardson: [C: 032] Fixes in TreeRepository [extensions/Flow] - 10https://gerrit.wikimedia.org/r/116083 (owner: 10Matthias Mullie) [19:13:46] (03Merged) 10jenkins-bot: Fixes in TreeRepository [extensions/Flow] - 10https://gerrit.wikimedia.org/r/116083 (owner: 10Matthias Mullie) [19:24:31] (03PS4) 10Krinkle: resourceloader: Fix broken skinStyles loop in #getModifiedTime [core] - 10https://gerrit.wikimedia.org/r/112837 [19:24:35] (03PS1) 10Krinkle: [WIP] resourceloader: Regression test for bug 62068 [core] - 10https://gerrit.wikimedia.org/r/116143 [19:24:51] (03PS1) 10Bsitu: Some miscellneous fixes to AbstractRevision [extensions/Flow] - 10https://gerrit.wikimedia.org/r/116144 [19:24:54] (03PS5) 10Krinkle: resourceloader: Fix broken skinStyles loop in #getModifiedTime [core] - 10https://gerrit.wikimedia.org/r/112837 [19:25:01] (03PS2) 10Krinkle: [WIP] resourceloader: Regression test for bug 62068 [core] - 10https://gerrit.wikimedia.org/r/116143 [19:26:23] (03CR) 10jenkins-bot: [V: 04-1] [WIP] resourceloader: Regression test for bug 62068 [core] - 10https://gerrit.wikimedia.org/r/116143 (owner: 10Krinkle) [19:27:24] (03CR) 10Catrope: [C: 032] resourceloader: Fix broken skinStyles loop in #getModifiedTime [core] - 10https://gerrit.wikimedia.org/r/112837 (owner: 10Krinkle) [19:28:13] (03PS2) 10UltrasonicNXT: Add fullscreen mode [extensions/MediaWikiChat] - 10https://gerrit.wikimedia.org/r/115949 [19:29:10] (03CR) 10Krinkle: [C: 032] "Pushed mediawiki-core-npm." [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/116124 (owner: 10Krinkle) [19:29:42] (03CR) 10Bartosz Dziewoński: "Hmm, why wasn't it done this way before? Mark?" [extensions/BetaFeatures] - 10https://gerrit.wikimedia.org/r/113885 (owner: 10Reedy) [19:30:20] (03CR) 10UltrasonicNXT: [C: 032 V: 032] Add fullscreen mode [extensions/MediaWikiChat] - 10https://gerrit.wikimedia.org/r/115949 (owner: 10UltrasonicNXT) [19:30:22] (03CR) 10EBernhardson: Non-hacky way to feed title to Parsoid (031 comment) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/115112 (owner: 10Matthias Mullie) [19:30:29] (03CR) 10EBernhardson: Non-hacky way to feed title to Parsoid (031 comment) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/115112 (owner: 10Matthias Mullie) [19:31:08] (03CR) 10MarkTraceur: "I...forget." [extensions/BetaFeatures] - 10https://gerrit.wikimedia.org/r/113885 (owner: 10Reedy) [19:33:47] (03CR) 10Bartosz Dziewoński: [C: 04-1] "The sizes of the new images are non-compatible. I also think that we should replace this with a vector SVG image, if at all." [core] - 10https://gerrit.wikimedia.org/r/116103 (owner: 10Deepali) [19:36:06] rdwrer: i'm pretty sure i've read you say somewhere that this has to be done that way, but i don't remember why either [19:36:16] (03PS3) 10BryanDavis: Convert mwversionsinuse to pure python [tools/scap] - 10https://gerrit.wikimedia.org/r/116062 [19:37:37] Maybe [19:38:06] (03Abandoned) 10UltrasonicNXT: Full screen toggle [extensions/MediaWikiChat] - 10https://gerrit.wikimedia.org/r/114967 (owner: 10Gerrit Patch Uploader) [19:38:15] (03CR) 10EBernhardson: [C: 032] Some miscellneous fixes to AbstractRevision [extensions/Flow] - 10https://gerrit.wikimedia.org/r/116144 (owner: 10Bsitu) [19:40:09] (03CR) 10Krinkle: Remove jquery.delayedBind (031 comment) [core] - 10https://gerrit.wikimedia.org/r/114955 (owner: 10Bartosz Dziewoński) [19:42:41] (03CR) 10Krinkle: "After this the qunit tests in Jenkins are inflated with deprecation warnings due to the unit tests for this module, this makes it harder t" (032 comments) [core] - 10https://gerrit.wikimedia.org/r/114953 (owner: 10Bartosz Dziewoński) [19:43:52] (03CR) 10BryanDavis: "Cleaned up implementation quite a bit and submitted I367ac55 to remove the only use I could find of the deprecated --extended command line" (032 comments) [tools/scap] - 10https://gerrit.wikimedia.org/r/116062 (owner: 10BryanDavis) [19:46:01] (03CR) 10Bartosz Dziewoński: "Sounds reasonable to me if the tests cause problems." [core] - 10https://gerrit.wikimedia.org/r/114953 (owner: 10Bartosz Dziewoński) [19:51:45] (03PS3) 10Eranroz: Update mw.api.watch according to new Watch API [core] - 10https://gerrit.wikimedia.org/r/116067 [19:53:34] (03CR) 10Eranroz: Update mw.api.watch according to new Watch API (032 comments) [core] - 10https://gerrit.wikimedia.org/r/116067 (owner: 10Eranroz) [19:54:27] (03PS2) 10Krinkle: Customise mediawiki-core-npm to use diffent directory [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/116124 [19:54:32] (03CR) 10Krinkle: [C: 032] Customise mediawiki-core-npm to use diffent directory [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/116124 (owner: 10Krinkle) [19:59:45] (03Merged) 10jenkins-bot: Some miscellneous fixes to AbstractRevision [extensions/Flow] - 10https://gerrit.wikimedia.org/r/116144 (owner: 10Bsitu) [19:59:48] (03CR) 10Krinkle: [C: 04-1] "I'd prefer for this to be less intrusive/verbose. The track key may be a bit too generic as well. The message should mention Promise to be" [core] - 10https://gerrit.wikimedia.org/r/115898 (owner: 10Helder.wiki) [20:03:31] (03PS1) 10Krinkle: mw.log.deprecate: Simplify warning message [core] - 10https://gerrit.wikimedia.org/r/116149 [20:04:43] (03Merged) 10jenkins-bot: Customise mediawiki-core-npm to use diffent directory [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/116124 (owner: 10Krinkle) [20:05:16] (03PS5) 10Krinkle: Fix compatibility with MW 1.22, PHP 5.4 and Firefox 26 [extensions/Drafts] - 10https://gerrit.wikimedia.org/r/105200 (owner: 10Gomoko) [20:08:22] (03CR) 10Helder.wiki: [C: 031] "Makes sense." [core] - 10https://gerrit.wikimedia.org/r/116149 (owner: 10Krinkle) [20:09:11] (03Merged) 10jenkins-bot: resourceloader: Fix broken skinStyles loop in #getModifiedTime [core] - 10https://gerrit.wikimedia.org/r/112837 (owner: 10Krinkle) [20:13:42] (03CR) 10Bartosz Dziewoński: [C: 032] mw.log.deprecate: Simplify warning message [core] - 10https://gerrit.wikimedia.org/r/116149 (owner: 10Krinkle) [20:14:25] I killed bZ, fixing [20:14:27] sorry folks! [20:15:13] (03PS1) 10Krinkle: mw.log.deprecate: Use mw.log.warn instead of log.warn [core] - 10https://gerrit.wikimedia.org/r/116150 [20:15:19] fixed [20:15:24] MatmaRex: thx [20:15:28] yay it's back! [20:17:06] (03CR) 10Bartosz Dziewoński: [C: 032] "This is one of the reasons why I don't like when we use local references to things :/" [core] - 10https://gerrit.wikimedia.org/r/116150 (owner: 10Krinkle) [20:17:41] (03CR) 10Krinkle: CSSMin: Clean up the logic in getLocalFileReferences() (031 comment) [core] - 10https://gerrit.wikimedia.org/r/115894 (owner: 10Bartosz Dziewoński) [20:23:15] Nemo_bis: ciao [20:23:37] https://bugzilla.wikimedia.org/show_bug.cgi?id=42026#c22 which should it be added to wmf15? [20:24:17] wmf16? [20:26:47] huh: uh? I meant the page I wrote, not another [20:27:08] (03CR) 10Bartosz Dziewoński: CSSMin: Clean up the logic in getLocalFileReferences() (031 comment) [core] - 10https://gerrit.wikimedia.org/r/115894 (owner: 10Bartosz Dziewoński) [20:27:12] (03PS2) 10Bartosz Dziewoński: CSSMin: Clean up the logic in getLocalFileReferences() [core] - 10https://gerrit.wikimedia.org/r/115894 [20:27:13] A new section in https://www.mediawiki.org/wiki/MediaWiki_1.23#What.27s_new will be fine [20:27:47] It's that major? :O [20:30:24] It is IMHO [20:30:42] Can be refactored if there are things of higher importance. [20:30:51] (03PS2) 10Bartosz Dziewoński: CSSMin: Don't do file_exists on random data in getLocalFileReferences() [core] - 10https://gerrit.wikimedia.org/r/115895 [20:31:21] But I doubt it, almost nothing of interesting ever happens in new MediaWiki core releases. Other than database crashes and job queue catastrophes, that is. :) [20:37:38] (03PS1) 10AndyRussG: Add DI setup that's performed only when needed [extensions/Campaigns] (wip/editorcampaigns) - 10https://gerrit.wikimedia.org/r/116153 [20:39:05] Nemo_bis: done, looks ok? [20:39:32] (03CR) 10Nikerabbit: [C: 031] Add flaggedrevs-hidereviewed show / hide i18n messages [extensions/FlaggedRevs] - 10https://gerrit.wikimedia.org/r/116054 (owner: 10Aude) [20:39:54] (03CR) 10Brian Wolff: "Re PleaseStand: thanks for adding the bug number." [core] - 10https://gerrit.wikimedia.org/r/116080 (owner: 10Brian Wolff) [20:41:00] (03CR) 10Ssmith: "Thanks! yes there are a number of things I'm working to refactor, and that's one of them." [extensions/FundraisingChart] - 10https://gerrit.wikimedia.org/r/116033 (owner: 10Reedy) [20:42:09] (03PS1) 10JGonera: [WIP] Add mobile target to MultimediaViewer dependencies [core] - 10https://gerrit.wikimedia.org/r/116154 [20:42:29] (03CR) 10JGonera: [C: 04-2] "Experiment, do not merge." [core] - 10https://gerrit.wikimedia.org/r/116154 (owner: 10JGonera) [20:44:00] (03CR) 10Nikerabbit: "Well, given that it has to fetch messages, it is probably fine to assume it can load templates and stuff. Just looks a bit scary to pull i" [core] - 10https://gerrit.wikimedia.org/r/116080 (owner: 10Brian Wolff) [20:48:50] huh: yes thanks, can always be expanded later :) [20:52:20] (03Abandoned) 10Ssmith: Fix leading whitespace to be consistently tabs [extensions/FundraisingChart] - 10https://gerrit.wikimedia.org/r/116033 (owner: 10Reedy) [20:55:29] (03CR) 10Bartosz Dziewoński: [C: 032] Update mw.api.watch according to new Watch API [core] - 10https://gerrit.wikimedia.org/r/116067 (owner: 10Eranroz) [20:57:20] ori, does vagrant mw gzip HTTP responses for you? [21:02:01] (03Merged) 10jenkins-bot: mw.log.deprecate: Simplify warning message [core] - 10https://gerrit.wikimedia.org/r/116149 (owner: 10Krinkle) [21:02:03] (03Merged) 10jenkins-bot: mw.log.deprecate: Use mw.log.warn instead of log.warn [core] - 10https://gerrit.wikimedia.org/r/116150 (owner: 10Krinkle) [21:04:04] (03CR) 10Anomie: "This is also causing PHP warnings:" [core] - 10https://gerrit.wikimedia.org/r/113038 (owner: 10Aaron Schulz) [21:05:07] (03PS1) 10UltrasonicNXT: Fix < and > being parsed like html tags [extensions/MediaWikiChat] - 10https://gerrit.wikimedia.org/r/116157 [21:05:37] (03PS2) 10UltrasonicNXT: Fix < and > being parsed like html tags [extensions/MediaWikiChat] - 10https://gerrit.wikimedia.org/r/116157 [21:06:30] (03PS3) 10UltrasonicNXT: Fix < and > being parsed like html tags [extensions/MediaWikiChat] - 10https://gerrit.wikimedia.org/r/116157 [21:06:53] (03CR) 10UltrasonicNXT: [C: 032 V: 032] Fix < and > being parsed like html tags [extensions/MediaWikiChat] - 10https://gerrit.wikimedia.org/r/116157 (owner: 10UltrasonicNXT) [21:11:06] (03Merged) 10jenkins-bot: Update mw.api.watch according to new Watch API [core] - 10https://gerrit.wikimedia.org/r/116067 (owner: 10Eranroz) [21:13:58] (03PS1) 10Brion VIBBER: Fix for CLDR plural rule parser for old browsers without String.trim [core] - 10https://gerrit.wikimedia.org/r/116159 [21:15:17] (03PS15) 10Inchikutty: Adding Leaflet scripts to UploadWizard [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/109063 [21:16:51] (03PS2) 10Brion VIBBER: Fix for CLDR plural rule parser for old browsers without String.trim [core] - 10https://gerrit.wikimedia.org/r/116159 [21:18:08] anomie: hi [21:20:56] thanks for merging the newonly thing, seems fine on beta [21:49:39] (03PS1) 10Umherirrender: Remove AdminSettings.php hint from Installer message [core] - 10https://gerrit.wikimedia.org/r/116162 [21:52:06] (03CR) 10Hoo man: [C: 032] Remove AdminSettings.php hint from Installer message [core] - 10https://gerrit.wikimedia.org/r/116162 (owner: 10Umherirrender) [21:55:28] (03Merged) 10jenkins-bot: Remove AdminSettings.php hint from Installer message [core] - 10https://gerrit.wikimedia.org/r/116162 (owner: 10Umherirrender) [22:04:34] I'm getting the super-helpful "Module mmv.ui.fileEmbed has failed dependencies" error [22:04:56] AFAICT it's a like, I don't see any dependencies that are in error or missing state [22:05:00] lie* [22:05:53] (03PS1) 10EBernhardson: getHex -> getAlphadecimal [extensions/Flow] - 10https://gerrit.wikimedia.org/r/116164 [22:05:58] Then again, there are more dependencies than I realized [22:06:21] Oh, it's circular somehow [22:07:07] (03CR) 10Bsitu: [C: 032] getHex -> getAlphadecimal [extensions/Flow] - 10https://gerrit.wikimedia.org/r/116164 (owner: 10EBernhardson) [22:07:18] (03Merged) 10jenkins-bot: getHex -> getAlphadecimal [extensions/Flow] - 10https://gerrit.wikimedia.org/r/116164 (owner: 10EBernhardson) [22:11:10] MaxSem: Infinite loop in MobileContext->toggleView('mobile') https://bugzilla.wikimedia.org/show_bug.cgi?id=62078 [22:11:26] (03PS1) 10Umherirrender: Add missing DROP SEQUENCE to postgres' tables.sql [core] - 10https://gerrit.wikimedia.org/r/116166 [22:11:30] bd808, yep - looking at that stactrace myself [22:16:03] Hm, disabling the less file in the module fixes the dependency error [22:17:04] We officially need better logging for less errors [22:20:53] (03PS2) 10JGonera: Add support for FormData to mw.Api [core] - 10https://gerrit.wikimedia.org/r/116037 [22:28:59] mw-vagrant's update-guest-additions and Virtualbox 4.3.8 seem to be warring -- first one ruthlessly installs 4.2.18 if ran [22:29:15] then at the next start, VirtualBox again installs 4.3.8 [22:36:16] KillerWalrus: How old is your clone of mw-vagrant? Does it have revision affcb1d in it? `git show affcb1d` [22:50:03] (03PS1) 10Brion VIBBER: Cleaner response for captcha-related createaccount API failure [extensions/ConfirmEdit] - 10https://gerrit.wikimedia.org/r/116170 [22:51:04] (03PS2) 10Brion VIBBER: Cleaner response for captcha-related createaccount API failure [extensions/ConfirmEdit] - 10https://gerrit.wikimedia.org/r/116170 [22:51:34] (03CR) 10Bsitu: [SCHEMA CHANGE] Add corresponding *_user_wiki field to all *_user_id fields (031 comment) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/111671 (owner: 10Bsitu) [22:57:05] rdwrer, will you have some time today to answer a few more questions about mmv? [22:59:13] jgonera: Yeah! How about in 30 minutes or so? [22:59:22] rdwrer, sounds good [23:17:08] (03Abandoned) 10BryanDavis: Rename scap.main functions to avoid duplication [tools/scap] - 10https://gerrit.wikimedia.org/r/114692 (owner: 10BryanDavis) [23:17:28] (03CR) 10Gergő Tisza: "Abandoning, further development will be done one a branch:" [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/107892 (owner: 10Inchikutty) [23:17:31] (03Abandoned) 10BryanDavis: Use verbs in function names [tools/scap] - 10https://gerrit.wikimedia.org/r/114695 (owner: 10BryanDavis) [23:17:51] (03CR) 10Gergő Tisza: [C: 032] Embedding Static Map to UploadWizard [extensions/UploadWizard] (osm) - 10https://gerrit.wikimedia.org/r/116127 (owner: 10Inchikutty) [23:18:00] (03Merged) 10jenkins-bot: Embedding Static Map to UploadWizard [extensions/UploadWizard] (osm) - 10https://gerrit.wikimedia.org/r/116127 (owner: 10Inchikutty) [23:20:04] (03CR) 10Aaron Schulz: [C: 032] Removed refreshLinks2 comment [core] - 10https://gerrit.wikimedia.org/r/116060 (owner: 10Aaron Schulz) [23:20:24] (03PS2) 10Inchikutty: Adding Leaflet scripts to UploadWizard [extensions/UploadWizard] (osm) - 10https://gerrit.wikimedia.org/r/116128 [23:23:29] (03PS2) 10BryanDavis: Validate --versions arguments to scap [tools/scap] - 10https://gerrit.wikimedia.org/r/116017 [23:23:35] (03CR) 10jenkins-bot: [V: 04-1] Validate --versions arguments to scap [tools/scap] - 10https://gerrit.wikimedia.org/r/116017 (owner: 10BryanDavis) [23:23:39] (03Merged) 10jenkins-bot: Removed refreshLinks2 comment [core] - 10https://gerrit.wikimedia.org/r/116060 (owner: 10Aaron Schulz) [23:25:11] (03CR) 10Gergő Tisza: "Please add the Leaflet js file to .jshintignore so the console log ( https://integration.wikimedia.org/ci/job/mwext-UploadWizard-jslint/78" [extensions/UploadWizard] (osm) - 10https://gerrit.wikimedia.org/r/116128 (owner: 10Inchikutty) [23:25:33] (03PS2) 10AndyRussG: Add DI setup that's performed only when needed [extensions/Campaigns] (wip/editorcampaigns) - 10https://gerrit.wikimedia.org/r/116153 [23:28:37] (03PS2) 10Aaron Schulz: Avoid showing crazy staleness times at ActiveUsers [core] - 10https://gerrit.wikimedia.org/r/115522 [23:29:44] (03CR) 10Gergő Tisza: "Please add the Leaflet type to docs/external.js so that it can be used in documentation. (You can try it out immediately by documenting th" [extensions/UploadWizard] (osm) - 10https://gerrit.wikimedia.org/r/116129 (owner: 10Inchikutty) [23:30:06] (03CR) 10BryanDavis: "I'd like to keep the functionality for now and revisit the need for it or better default behavior after the rest of scap/bin has been port" [tools/scap] - 10https://gerrit.wikimedia.org/r/116017 (owner: 10BryanDavis) [23:31:50] (03PS3) 10BryanDavis: Validate --versions arguments to scap [tools/scap] - 10https://gerrit.wikimedia.org/r/116017 [23:33:09] (03CR) 10Gergő Tisza: "Will be abandoned, development will continue on a branch:" [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/109263 (owner: 10Inchikutty) [23:33:30] (03CR) 10Gergő Tisza: "Earlier unaddressed comments are at" [extensions/UploadWizard] (osm) - 10https://gerrit.wikimedia.org/r/116129 (owner: 10Inchikutty) [23:37:13] (03Abandoned) 10Gergő Tisza: Adding Leaflet scripts to UploadWizard [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/109063 (owner: 10Inchikutty) [23:37:24] (03CR) 10Gergő Tisza: "Previous comments at https://gerrit.wikimedia.org/r/#/c/109063/" [extensions/UploadWizard] (osm) - 10https://gerrit.wikimedia.org/r/116128 (owner: 10Inchikutty) [23:38:15] (03CR) 10Gergő Tisza: "Previous comments were at https://gerrit.wikimedia.org/r/#/c/107892/" [extensions/UploadWizard] (osm) - 10https://gerrit.wikimedia.org/r/116127 (owner: 10Inchikutty) [23:38:51] (03PS23) 10Inchikutty: Embedding Static Map to UploadWizard [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/107892 [23:39:03] (03Abandoned) 10Gergő Tisza: Embedding Static Map to UploadWizard [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/107892 (owner: 10Inchikutty) [23:41:39] (03CR) 10Gergő Tisza: "Will be abandoned, development continues on a branch:" [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/112342 (owner: 10Inchikutty) [23:42:04] (03CR) 10Gergő Tisza: "There are some unaddressed comments at https://gerrit.wikimedia.org/r/#/c/112342/" [extensions/UploadWizard] (osm) - 10https://gerrit.wikimedia.org/r/116130 (owner: 10Inchikutty) [23:43:04] (03PS1) 10MaxSem: Update MobileFrontend to wmf/1.23wmf16 tip [core] (wmf/1.23wmf16) - 10https://gerrit.wikimedia.org/r/116176 [23:43:19] (03CR) 10MaxSem: [C: 032 V: 032] Update MobileFrontend to wmf/1.23wmf16 tip [core] (wmf/1.23wmf16) - 10https://gerrit.wikimedia.org/r/116176 (owner: 10MaxSem) [23:45:23] (03CR) 10CSteipp: "Correct, we don't usually put master's patches in the release notes unless there's a structural change, since the previous version also ha" [core] - 10https://gerrit.wikimedia.org/r/115970 (owner: 10Mglaser) [23:52:30] rdwrer, you have time now? [23:55:41] jgonera: Yup! [23:55:47] Sorry about the slowness [23:56:09] jgonera: I can come to you? [23:56:38] rdwrer, are you on the couch? [23:56:57] jgonera: The one near tewwy's desk; I can just come to you though [23:57:19] rdwrer, nah, I need to move, be right there