[09:42:28] <grrrit-wm>	 (03CR) 10MaxSem: resourceloader: Add method to get the startup modules load url (031 comment) [core] - 10https://gerrit.wikimedia.org/r/102344 (owner: 10Dr0ptp4kt)
[09:46:32] <grrrit-wm>	 (03CR) 10Prtksxna: [C: 032 V: 032] "Thanks Kartik :)" [extensions/Popups] - 10https://gerrit.wikimedia.org/r/115869 (owner: 10KartikMistry)
[09:49:57] <grrrit-wm>	 (03PS3) 10Prtksxna: Make animation mixin cleaner [extensions/Popups] - 10https://gerrit.wikimedia.org/r/115376 
[09:50:47] <grrrit-wm>	 (03CR) 10Ori.livneh: [C: 032] Add logstash log formatter [tools/scap] - 10https://gerrit.wikimedia.org/r/115855 (owner: 10BryanDavis)
[09:51:04] <grrrit-wm>	 (03Merged) 10jenkins-bot: Add logstash log formatter [tools/scap] - 10https://gerrit.wikimedia.org/r/115855 (owner: 10BryanDavis)
[09:53:00] <grrrit-wm>	 (03PS4) 10Jdlrobson: Cleanup search placeholder black/gray text mess [core] - 10https://gerrit.wikimedia.org/r/111516 
[09:53:43] <grrrit-wm>	 (03CR) 10Ori.livneh: [C: 032] Cleanup search placeholder black/gray text mess [core] - 10https://gerrit.wikimedia.org/r/111516 (owner: 10Jdlrobson)
[09:54:21] <tinaj1234_>	  I was working on this bug: https://bugzilla.wikimedia.org/show_bug.cgi?id=61372. If I'm to write a function to display the warning, should it be something which recognizes all deprecated functions with ok and err as parameters and then display the warning ?
[09:57:09] <grrrit-wm>	 (03Merged) 10jenkins-bot: Cleanup search placeholder black/gray text mess [core] - 10https://gerrit.wikimedia.org/r/111516 (owner: 10Jdlrobson)
[09:57:33] <grrrit-wm>	 (03PS13) 10Ori.livneh: Moved job running via $wgJobRunRate to a special API [core] - 10https://gerrit.wikimedia.org/r/113038 (owner: 10Aaron Schulz)
[09:58:13] <grrrit-wm>	 (03PS14) 10Aaron Schulz: Moved job running via $wgJobRunRate to a special API [core] - 10https://gerrit.wikimedia.org/r/113038 
[10:02:03] <grrrit-wm>	 (03PS1) 10Addshore: Add tests exceptions [core] - 10https://gerrit.wikimedia.org/r/115877 
[10:02:14] <grrrit-wm>	 (03PS2) 10Prtksxna: Use moment.js instead of timeAgo method [extensions/Popups] - 10https://gerrit.wikimedia.org/r/115858 
[10:02:16] <grrrit-wm>	 (03PS1) 10Prtksxna: Make EventLogging a soft dependency [extensions/Popups] - 10https://gerrit.wikimedia.org/r/115878 
[10:02:52] <grrrit-wm>	 (03PS6) 10Prtksxna: Flip the starting point of the popup if its on the right side of the screen [extensions/Popups] - 10https://gerrit.wikimedia.org/r/115187 
[10:02:54] <grrrit-wm>	 (03PS6) 10Prtksxna: Limit image size for portrait popups [extensions/Popups] - 10https://gerrit.wikimedia.org/r/115186 
[10:02:57] <grrrit-wm>	 (03PS6) 10Prtksxna: Flip the arrow position if the popup is flipped [extensions/Popups] - 10https://gerrit.wikimedia.org/r/115188 
[10:11:30] <grrrit-wm>	 (03CR) 10Prtksxna: "I know I am doing something wrong here. I am not sure how to access global variables from within the function. I tried [1] but that doesn'" [extensions/Popups] - 10https://gerrit.wikimedia.org/r/115878 (owner: 10Prtksxna)
[10:22:52] <matanya>	 got senil, how do i restore a file or a change i did and commited to gerrit?
[10:24:29] <tonythomas>	 matanya:  you can always do git checkout master <file_name> to get the master copy in your branch 
[10:24:39] <grrrit-wm>	 (03CR) 10Addshore: Expand MWException tests (032 comments) [core] - 10https://gerrit.wikimedia.org/r/115608 (owner: 10Addshore)
[10:24:48] <matanya>	 thanks tonythomas 
[10:25:40] <grrrit-wm>	 (03PS3) 10Addshore: Expand MWException tests [core] - 10https://gerrit.wikimedia.org/r/115608 
[10:25:48] <tonythomas>	 matanya: np  :)
[10:31:34] <grrrit-wm>	 (03PS21) 10Inchikutty: Embedding Static Map to UploadWizard [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/107892 
[10:31:37] <grrrit-wm>	 (03CR) 10Addshore: Add getMessage tests with Short and Long Contexts (032 comments) [core] - 10https://gerrit.wikimedia.org/r/114930 (owner: 10Addshore)
[10:37:00] <grrrit-wm>	 (03CR) 10Gilles: [C: 031] Fix jQuery compatibility issues in jquery.color.js [core] - 10https://gerrit.wikimedia.org/r/115835 (owner: 10Gergő Tisza)
[10:49:46] <grrrit-wm>	 (03PS1) 10Hashar: mediawiki-core-code-coverage now archive clover file [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/115883 
[11:00:49] <grrrit-wm>	 (03PS2) 10Addshore: Add getMessage tests with Short and Long Contexts [core] - 10https://gerrit.wikimedia.org/r/114930 
[11:01:16] <grrrit-wm>	 (03CR) 10Phuedx: "I think that it should be a separate change. This change makes the toolbar respond to content overflow rather than minimising the chance o" [extensions/GettingStarted] - 10https://gerrit.wikimedia.org/r/115176 (owner: 10Phuedx)
[11:02:57] <grrrit-wm>	 (03CR) 10Inchikutty: "Yeah, connectivity is adjustable..Not as slow as it used to be :)" [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/107892 (owner: 10Inchikutty)
[11:13:42] <grrrit-wm>	 (03CR) 10Bartosz Dziewoński: "I can not fathom *why*, but apparently Jon is vehemently opposed to not using deprecated things, and I have better things to do than to co" [core] - 10https://gerrit.wikimedia.org/r/110964 (owner: 10Bartosz Dziewoński)
[11:13:46] <grrrit-wm>	 (03Abandoned) 10Bartosz Dziewoński: Vector: Use the new ::-moz-placeholder pseudo-element for Firefox 19+ [core] - 10https://gerrit.wikimedia.org/r/110964 (owner: 10Bartosz Dziewoński)
[11:17:45] <grrrit-wm>	 (03CR) 10Bartosz Dziewoński: "Ugh, annnnd it doesn't merge now." [core] - 10https://gerrit.wikimedia.org/r/95566 (owner: 10Spage)
[11:26:49] <grrrit-wm>	 (03PS2) 10Bartosz Dziewoński: minor LESS CSS fixes (zero units, dimensions) [core] - 10https://gerrit.wikimedia.org/r/95566 (owner: 10Spage)
[11:27:20] <grrrit-wm>	 (03CR) 10Bartosz Dziewoński: [C: 032] "Rebased, and changed my mind. Let's just clear up some backlog." [core] - 10https://gerrit.wikimedia.org/r/95566 (owner: 10Spage)
[11:27:41] <grrrit-wm>	 (03PS1) 10Thiemo Mättig (WMDE): Fix Beta checkboxes not rendering in Opera 12 (Windows) [extensions/BetaFeatures] - 10https://gerrit.wikimedia.org/r/115885 
[11:31:54] <grrrit-wm>	 (03Merged) 10jenkins-bot: minor LESS CSS fixes (zero units, dimensions) [core] - 10https://gerrit.wikimedia.org/r/95566 (owner: 10Spage)
[11:34:11] <grrrit-wm>	 (03CR) 10Bartosz Dziewoński: "Whoa, I've never expected anyone other than me to work on Opera 12 thingies." (033 comments) [extensions/BetaFeatures] - 10https://gerrit.wikimedia.org/r/115885 (owner: 10Thiemo Mättig (WMDE))
[11:43:38] <grrrit-wm>	 (03CR) 10Jackmcbarn: Allow finding the shortest name of a special page (031 comment) [core] - 10https://gerrit.wikimedia.org/r/115696 (owner: 10Jackmcbarn)
[12:05:44] <MatmaRex>	 Nikerabbit: around? i need someone to make a decision :) siebrand and i disagree on some i18n matters here: https://gerrit.wikimedia.org/r/#/c/109296/ , and the reporter of the bug this fixes just poked me again to ask what's up with this
[12:08:09] <Nikerabbit>	 MatmaRex: You want clearer position from my original comment?
[12:08:22] <Nikerabbit>	 I'll think it over lunch
[12:08:32] <MatmaRex>	 Nikerabbit: i expact a +2 or a -2 :)
[12:08:35] <MatmaRex>	 expect*
[12:14:06] <grrrit-wm>	 (03PS1) 10Phuedx: Increase the toolbar message container's width [extensions/GettingStarted] - 10https://gerrit.wikimedia.org/r/115891 
[12:14:43] <grrrit-wm>	 (03CR) 10Phuedx: Make the toolbar respond to a content overflow (031 comment) [extensions/GettingStarted] - 10https://gerrit.wikimedia.org/r/115176 (owner: 10Phuedx)
[12:16:36] <grrrit-wm>	 (03PS2) 10Matthias Mullie: Add preview of new comment to watchlist/rc/history [extensions/Flow] - 10https://gerrit.wikimedia.org/r/115113 
[12:35:28] <grrrit-wm>	 (03CR) 10Nikerabbit: [C: 04-1] "After considering the following points, I'm okay with merging this after the issues pointed in inline comments have been fixed." [core] - 10https://gerrit.wikimedia.org/r/109296 (owner: 10Microchip08)
[12:36:26] <Nikerabbit>	 MatmaRex: how about that?
[12:38:06] <MatmaRex>	 Nikerabbit: thank you. on it.
[12:43:08] <grrrit-wm>	 (03PS2) 10Bartosz Dziewoński: Make show/hide link in RC individually localizable [core] - 10https://gerrit.wikimedia.org/r/109296 (owner: 10Microchip08)
[12:43:41] <grrrit-wm>	 (03CR) 10Bartosz Dziewoński: [C: 031] "I took the liberty of updating the code, as it's a trivial change. Thanks Niklas." [core] - 10https://gerrit.wikimedia.org/r/109296 (owner: 10Microchip08)
[12:46:33] <grrrit-wm>	 (03CR) 10Nikerabbit: [C: 032] Make show/hide link in RC individually localizable [core] - 10https://gerrit.wikimedia.org/r/109296 (owner: 10Microchip08)
[12:48:26] <Nemo_bis>	 progress!
[12:48:43] <MatmaRex>	 unclogging the backlog!
[12:48:49] <Nemo_bis>	 We just realised one of the wishes of Utar, sounded impossible
[12:49:00] <Nemo_bis>	 The Ukrainian translators may hide us (and the world) a bit less
[12:49:05] <Nemo_bis>	 * hate
[12:49:30] <Nemo_bis>	 How many new options for subtle differences from Russian does that empower them to introduce?
[12:49:44] <MatmaRex>	 heh
[12:50:07] <grrrit-wm>	 (03Merged) 10jenkins-bot: Make show/hide link in RC individually localizable [core] - 10https://gerrit.wikimedia.org/r/109296 (owner: 10Microchip08)
[12:59:45] <grrrit-wm>	 (03CR) 10PiRSquared17: [C: 031] "Fixed?" [core] - 10https://gerrit.wikimedia.org/r/104711 (owner: 10Legoktm)
[13:00:51] <grrrit-wm>	 (03CR) 10Microchip08: [C: 031] "(This is my first review; apologies if this is wrong.)" [core] - 10https://gerrit.wikimedia.org/r/111736 (owner: 10Parent5446)
[13:02:12] <grrrit-wm>	 (03CR) 10Nikerabbit: Allow finding the shortest name of a special page (031 comment) [core] - 10https://gerrit.wikimedia.org/r/115696 (owner: 10Jackmcbarn)
[13:04:08] <grrrit-wm>	 (03CR) 10Krinkle: [C: 032] "Pushed mediawiki-core-qunit and all 8 mwext*qunit jobs." [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/95309 (owner: 10Krinkle)
[13:04:29] <grrrit-wm>	 (03Merged) 10jenkins-bot: qunit macro: Make log/ directory writable instead of just the file [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/95309 (owner: 10Krinkle)
[13:11:34] <grrrit-wm>	 (03CR) 10Hoo man: [C: 04-2] "I don't like the idea at all (per Nikerabbit's comment)." [core] - 10https://gerrit.wikimedia.org/r/115696 (owner: 10Jackmcbarn)
[13:12:24] <grrrit-wm>	 (03PS3) 10Krinkle: mwconf: Enable $wgDBerrorLog and $wgRateLimitLog [integration/jenkins] - 10https://gerrit.wikimedia.org/r/95311 
[13:12:44] <grrrit-wm>	 (03CR) 10Krinkle: mwconf: Enable $wgDBerrorLog and $wgRateLimitLog (032 comments) [integration/jenkins] - 10https://gerrit.wikimedia.org/r/95311 (owner: 10Krinkle)
[13:12:58] <grrrit-wm>	 (03PS2) 10Hashar: mediawiki-core-code-coverage now archive clover file [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/115883 
[13:13:02] <grrrit-wm>	 (03PS3) 10Hashar: mediawiki-core-code-coverage now archives clover file [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/115883 
[13:13:11] <grrrit-wm>	 (03CR) 10Hashar: [C: 032] mediawiki-core-code-coverage now archives clover file [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/115883 (owner: 10Hashar)
[13:13:36] <grrrit-wm>	 (03Merged) 10jenkins-bot: mediawiki-core-code-coverage now archives clover file [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/115883 (owner: 10Hashar)
[13:14:44] <grrrit-wm>	 (03PS4) 10Krinkle: mwconf: Enable $wgDBerrorLog and $wgRateLimitLog [integration/jenkins] - 10https://gerrit.wikimedia.org/r/95311 
[13:15:18] <grrrit-wm>	 (03CR) 10Prtksxna: "The code looks good to me now :) I'll test it tomorrow :D" [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/107892 (owner: 10Inchikutty)
[13:15:24] <grrrit-wm>	 (03CR) 10Krinkle: [C: 032] "Here goes nothing.." [integration/jenkins] - 10https://gerrit.wikimedia.org/r/95311 (owner: 10Krinkle)
[13:15:27] <grrrit-wm>	 (03Merged) 10jenkins-bot: mwconf: Enable $wgDBerrorLog and $wgRateLimitLog [integration/jenkins] - 10https://gerrit.wikimedia.org/r/95311 (owner: 10Krinkle)
[13:15:59] <grrrit-wm>	 (03PS3) 10Krinkle: PathRouter: Fix documentation typo [core] - 10https://gerrit.wikimedia.org/r/115403 
[13:16:53] <grrrit-wm>	 (03PS1) 10Bartosz Dziewoński: CSSMin: Clean up the logic in getLocalFileReferences() [core] - 10https://gerrit.wikimedia.org/r/115894 
[13:16:55] <grrrit-wm>	 (03PS1) 10Bartosz Dziewoński: CSSMin: Don't do file_exists on random data in getLocalFileReferences() [core] - 10https://gerrit.wikimedia.org/r/115895 
[13:18:38] <grrrit-wm>	 (03PS1) 10IAlex: Update messages.inc and rebuild MessagesEn.php [core] - 10https://gerrit.wikimedia.org/r/115896 
[13:21:43] <grrrit-wm>	 (03CR) 10Krinkle: [C: 031] resourceloader: Add method to get the startup modules load url (031 comment) [core] - 10https://gerrit.wikimedia.org/r/102344 (owner: 10Dr0ptp4kt)
[13:27:28] <grrrit-wm>	 (03CR) 10Thiemo Mättig (WMDE): "I still love my Opera 12 even if it starts to rod a little bit. :-(" (033 comments) [extensions/BetaFeatures] - 10https://gerrit.wikimedia.org/r/115885 (owner: 10Thiemo Mättig (WMDE))
[13:30:41] <grrrit-wm>	 (03CR) 10Thiemo Mättig (WMDE): Fix Beta checkboxes not rendering in Opera 12 (Windows) (031 comment) [extensions/BetaFeatures] - 10https://gerrit.wikimedia.org/r/115885 (owner: 10Thiemo Mättig (WMDE))
[13:32:31] <grrrit-wm>	 (03CR) 10Bartosz Dziewoński: [C: 032] Update messages.inc and rebuild MessagesEn.php [core] - 10https://gerrit.wikimedia.org/r/115896 (owner: 10IAlex)
[13:34:41] <grrrit-wm>	 (03PS1) 10Helder.wiki: Add a warning when deprecated parameters of mw.Api are used [core] - 10https://gerrit.wikimedia.org/r/115898 
[13:35:20] <grrrit-wm>	 (03PS1) 10Addshore: use --prefer-source for composer travis [core] - 10https://gerrit.wikimedia.org/r/115899 
[13:35:51] <grrrit-wm>	 (03PS2) 10Helder.wiki: Add a warning when deprecated parameters of mw.Api are used [core] - 10https://gerrit.wikimedia.org/r/115898 
[13:36:07] <grrrit-wm>	 (03PS1) 10Bartosz Dziewoński: Make 'quotation-marks' message non-optional (again) [core] - 10https://gerrit.wikimedia.org/r/115900 
[13:36:24] <grrrit-wm>	 (03Merged) 10jenkins-bot: Update messages.inc and rebuild MessagesEn.php [core] - 10https://gerrit.wikimedia.org/r/115896 (owner: 10IAlex)
[13:36:30] <grrrit-wm>	 (03CR) 10Bartosz Dziewoński: "The 'quotation-marks' message has been previously very intentionally made non-optional in I9282c787. Follow-up: https://gerrit.wikimedia.o" [core] - 10https://gerrit.wikimedia.org/r/108288 (owner: 10Raimond Spekking)
[13:38:06] <grrrit-wm>	 (03CR) 10Hoo man: [C: 032] "Decent workaround" [core] - 10https://gerrit.wikimedia.org/r/115899 (owner: 10Addshore)
[13:38:55] <grrrit-wm>	 (03PS1) 10Bartosz Dziewoński: Fix grammar in 'deleting-backlinks-warning' message [core] - 10https://gerrit.wikimedia.org/r/115901 
[13:40:05] <addshore>	 hoo: its the recognised fix ;p
[13:40:33] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] Fix grammar in 'deleting-backlinks-warning' message [core] - 10https://gerrit.wikimedia.org/r/115901 (owner: 10Bartosz Dziewoński)
[13:41:41] <grrrit-wm>	 (03PS2) 10Bartosz Dziewoński: Fix grammar in 'deleting-backlinks-warning' message [core] - 10https://gerrit.wikimedia.org/r/115901 
[13:43:07] <grrrit-wm>	 (03PS1) 10Hashar: Deprecates $wgRateLimitLog in favor of debug log [core] - 10https://gerrit.wikimedia.org/r/115902 
[13:43:59] <grrrit-wm>	 (03Merged) 10jenkins-bot: use --prefer-source for composer travis [core] - 10https://gerrit.wikimedia.org/r/115899 (owner: 10Addshore)
[13:46:14] <grrrit-wm>	 (03CR) 10IAlex: "Otherwise looks good." (031 comment) [core] - 10https://gerrit.wikimedia.org/r/115902 (owner: 10Hashar)
[13:48:07] <Krinkle>	 MatmaRex: https://gerrit.wikimedia.org/r/#/c/111962/1
[13:49:03] <MatmaRex>	 meh, whatever
[13:49:04] <grrrit-wm>	 (03CR) 10Bartosz Dziewoński: [C: 032] jquery.tablesorter.test: Re-organise variables [core] - 10https://gerrit.wikimedia.org/r/111962 (owner: 10Krinkle)
[13:49:16] <Krinkle>	 Thx a bunch
[13:49:23] <MatmaRex>	 np
[13:50:51] <grrrit-wm>	 (03PS1) 10Mglaser: SECURITY: Disallow non-whitelisted namespaces [core] - 10https://gerrit.wikimedia.org/r/115903 
[13:51:41] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] SECURITY: Disallow non-whitelisted namespaces [core] - 10https://gerrit.wikimedia.org/r/115903 (owner: 10Mglaser)
[13:52:02] <Krinkle>	 addshore: Maybe install xdiff as well in the travis build?
[13:52:10] <Krinkle>	 and 'intl'
[13:52:18] <addshore>	 Krinkle: maybe, Im poking it quite a lot right now
[13:52:25] <Krinkle>	 cool
[13:52:29] <addshore>	 seeing if we could get per change coverage infomation working
[13:52:40] <Krinkle>	 addshore: We can also use the build matrix to test in 5.3, 5.4 and 5.5 as well
[13:52:50] <Krinkle>	 that will need a modification to the script: though to not be hhvm specific
[13:52:52] <addshore>	 and we can, but it takes about 15 mins to get to just 50%
[13:53:04] <addshore>	 Krinkle: indeed, I just added 5.3 and looks like some tests actually fail ;p
[13:53:19] <Krinkle>	 addshore: In a fork I assume?
[13:53:24] <addshore>	 yus ;p
[14:06:21] <grrrit-wm>	 (03CR) 10Bartosz Dziewoński: "This probably isn't the right branch for this patch." [core] - 10https://gerrit.wikimedia.org/r/115903 (owner: 10Mglaser)
[14:07:22] <grrrit-wm>	 (03PS2) 10Mglaser: SECURITY: Disallow non-whitelisted namespaces [core] - 10https://gerrit.wikimedia.org/r/115903 
[14:07:48] <grrrit-wm>	 (03PS1) 10Addshore: Make travis test php 5.3, 5.4 and 5.5 [core] - 10https://gerrit.wikimedia.org/r/115905 
[14:07:49] <hoo>	 MatmaRex: It is, we also want that on master ;)
[14:07:51] <addshore>	 Krinkle: ^^
[14:07:58] <hoo>	 Will take care of them
[14:09:03] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] Make travis test php 5.3, 5.4 and 5.5 [core] - 10https://gerrit.wikimedia.org/r/115905 (owner: 10Addshore)
[14:09:04] <MatmaRex>	 hoo: huh, that looked like a backport
[14:09:26] <hoo>	 MatmaRex: No, it's only yet live in production
[14:09:26] <MatmaRex>	 especially since it's apparently authored nearly a month ago
[14:09:42] <addshore>	 mhhm
[14:10:08] <hoo>	 hi mglaser :)
[14:10:15] <mglaser>	 hi hoo
[14:10:18] <mglaser>	 :)
[14:10:45] <mglaser>	 I just rebased the change and am waiting for Jenkins to verify (hopefully)
[14:10:53] <hoo>	 If it does, I'll approve it
[14:11:02] <mglaser>	 thx
[14:13:33] <grrrit-wm>	 (03PS1) 10Mglaser: SECURITY: Make token comparison constant time [core] - 10https://gerrit.wikimedia.org/r/115906 
[14:15:13] <grrrit-wm>	 (03CR) 10Hoo man: [C: 032] "Per Code review on the bug (By Aaron)" [core] - 10https://gerrit.wikimedia.org/r/115903 (owner: 10Mglaser)
[14:15:19] <grrrit-wm>	 (03PS2) 10Addshore: Make travis test php 5.3, 5.4 and 5.5 [core] - 10https://gerrit.wikimedia.org/r/115905 
[14:15:53] <grrrit-wm>	 (03CR) 10Addshore: "A branch of core with this travis.yml is currently running here:" [core] - 10https://gerrit.wikimedia.org/r/115905 (owner: 10Addshore)
[14:15:54] <Krinkle>	 addshore: is that --withphpunitdir needed? Shouldn't that work by default after php config rehash, and composer install etc. ?
[14:16:46] <grrrit-wm>	 (03CR) 10Hoo man: [C: 032] "Looks good, also per the earlier code review on the bug (by Aaron)" [core] - 10https://gerrit.wikimedia.org/r/115906 (owner: 10Mglaser)
[14:16:47] <addshore>	 I thought I would use the exact same version as is sued in the hhvm test :)
[14:18:46] <addshore>	 heh, I made a test build running coverage and its been going for 35 mines and is just getting to 95%
[14:18:48] <grrrit-wm>	 (03PS1) 10Mglaser: SECURITY: API: Don't find links in the middle of api.php links [core] - 10https://gerrit.wikimedia.org/r/115907 
[14:18:56] <grrrit-wm>	 (03PS1) 10Matthias Mullie: (bug 61107) Contributions from Flow appear in every namespace [extensions/Flow] - 10https://gerrit.wikimedia.org/r/115908 
[14:19:39] <grrrit-wm>	 (03Merged) 10jenkins-bot: SECURITY: Disallow non-whitelisted namespaces [core] - 10https://gerrit.wikimedia.org/r/115903 (owner: 10Mglaser)
[14:20:33] <grrrit-wm>	 (03Merged) 10jenkins-bot: SECURITY: Make token comparison constant time [core] - 10https://gerrit.wikimedia.org/r/115906 (owner: 10Mglaser)
[14:20:36] <grrrit-wm>	 (03CR) 10Krinkle: [C: 032] resourceloader: Add method to get the startup modules load url [core] - 10https://gerrit.wikimedia.org/r/102344 (owner: 10Dr0ptp4kt)
[14:20:40] <Krinkle>	 dr0ptp4kt: 
[14:23:01] <grrrit-wm>	 (03CR) 10Hoo man: SECURITY: API: Don't find links in the middle of api.php links (031 comment) [core] - 10https://gerrit.wikimedia.org/r/115907 (owner: 10Mglaser)
[14:23:11] <hoo>	 mglaser: ^ want to make that tiny change?
[14:24:45] <mglaser>	 hoo, sec
[14:25:12] <grrrit-wm>	 (03Merged) 10jenkins-bot: resourceloader: Add method to get the startup modules load url [core] - 10https://gerrit.wikimedia.org/r/102344 (owner: 10Dr0ptp4kt)
[14:26:08] <Krinkle>	 MatmaRex: Hm.. https://gerrit.wikimedia.org/r/#/c/111962/ was cancelled? Im trying to rebase jscs
[14:26:14] <Krinkle>	 I don't see your review anymore
[14:28:10] <MatmaRex>	 oh
[14:28:16] <MatmaRex>	 i put it on ps1 somehow
[14:28:20] <grrrit-wm>	 (03CR) 10Bartosz Dziewoński: [C: 032] jquery.tablesorter.test: Re-organise variables [core] - 10https://gerrit.wikimedia.org/r/111962 (owner: 10Krinkle)
[14:28:27] <MatmaRex>	 sorry :)
[14:28:55] <MatmaRex>	 it's silly that gerrit let me do that, though…
[14:31:08] <grrrit-wm>	 (03CR) 10Raimond Spekking: [C: 032] Make 'quotation-marks' message non-optional (again) [core] - 10https://gerrit.wikimedia.org/r/115900 (owner: 10Bartosz Dziewoński)
[14:31:37] <grrrit-wm>	 (03PS2) 10Mglaser: SECURITY: API: Don't find links in the middle of api.php links [core] - 10https://gerrit.wikimedia.org/r/115907 
[14:31:37] <mglaser>	 hoo, done
[14:32:09] <grrrit-wm>	 (03Merged) 10jenkins-bot: jquery.tablesorter.test: Re-organise variables [core] - 10https://gerrit.wikimedia.org/r/111962 (owner: 10Krinkle)
[14:32:40] <hoo>	 mglaser: Ok :) Waiting for jenkins
[14:32:50] <grrrit-wm>	 (03PS1) 10Tinaj1234: Added a space between information and discussion links [extensions/BetaFeatures] - 10https://gerrit.wikimedia.org/r/115911 
[14:33:09] <grrrit-wm>	 (03PS1) 10Mglaser: SECURITY: Make token comparison constant time [core] (REL1_22) - 10https://gerrit.wikimedia.org/r/115912 
[14:34:18] <grrrit-wm>	 (03Merged) 10jenkins-bot: Make 'quotation-marks' message non-optional (again) [core] - 10https://gerrit.wikimedia.org/r/115900 (owner: 10Bartosz Dziewoński)
[14:38:20] <hoo>	 mglaser: Will you self merge the backports?
[14:39:31] <mglaser>	 hoo, I assume that's ok. What do you think?
[14:40:01] <hoo>	 as long as they work in the exact same way than on master, I guess that's ok
[14:40:09] <hoo>	 if in doubt, just ping me ;)
[14:40:16] <hoo>	 s/than/as/
[14:40:27] <mglaser>	 hoo :), thx
[14:41:37] <mglaser>	 hoo, could you +2 this one in master: https://gerrit.wikimedia.org/r/#/c/115907/1 ?
[14:43:20] <grrrit-wm>	 (03CR) 10Hoo man: [C: 032] "Also per CR on the bug (already in production)" [core] - 10https://gerrit.wikimedia.org/r/115907 (owner: 10Mglaser)
[14:43:49] <mglaser>	 thanks a lot
[14:46:27] <grrrit-wm>	 (03PS1) 10Mglaser: SECURITY: Make token comparison constant time [core] (REL1_21) - 10https://gerrit.wikimedia.org/r/115914 
[14:47:19] <grrrit-wm>	 (03Merged) 10jenkins-bot: SECURITY: API: Don't find links in the middle of api.php links [core] - 10https://gerrit.wikimedia.org/r/115907 (owner: 10Mglaser)
[14:49:41] <grrrit-wm>	 (03PS1) 10Mglaser: SECURITY: API: Don't find links in the middle of api.php links [core] (REL1_22) - 10https://gerrit.wikimedia.org/r/115915 
[14:50:40] <aude>	 oooh, all the security  things
[14:50:42] <grrrit-wm>	 (03PS1) 10Mglaser: SECURITY: API: Don't find links in the middle of api.php links [core] (REL1_21) - 10https://gerrit.wikimedia.org/r/115916 
[14:53:36] <grrrit-wm>	 (03Abandoned) 10Hashar: (bug 28085) Allow login with e-mail address [core] - 10https://gerrit.wikimedia.org/r/42084 (owner: 10devunt)
[14:54:59] <grrrit-wm>	 (03Abandoned) 10Hashar: Moving extension to Git. Was stored in a wiki page. [extensions/CategoryMagicWords] - 10https://gerrit.wikimedia.org/r/42768 (owner: 10Rotsee)
[14:55:09] <mglaser>	 aude, I'm sorry for spamming with security fixes...
[14:55:21] <grrrit-wm>	 (03CR) 10Thiemo Mättig (WMDE): [C: 031] "Looks like this could be a reasonable replacement for the "all languages" JavaScript hack on the main page." (031 comment) [core] - 10https://gerrit.wikimedia.org/r/101895 (owner: 10Aude)
[14:56:43] <grrrit-wm>	 (03Abandoned) 10Hashar: Start the 404 handling code. [core] - 10https://gerrit.wikimedia.org/r/17801 (owner: 10Daniel Friesen)
[14:57:19] <grrrit-wm>	 (03Abandoned) 10Hashar: Added div#loginend after the login form [core] - 10https://gerrit.wikimedia.org/r/30636 (owner: 10Massaf)
[14:57:56] <grrrit-wm>	 (03Abandoned) 10Hashar: Removed 'Secure your account' list of login tips [core] - 10https://gerrit.wikimedia.org/r/30635 (owner: 10Massaf)
[15:00:02] <grrrit-wm>	 (03Abandoned) 10Hashar: Improved style [extensions/PDBHandler] - 10https://gerrit.wikimedia.org/r/47382 (owner: 10Emw)
[15:00:06] <grrrit-wm>	 (03Abandoned) 10Hashar: Initial commit of PDBHandler [extensions/PDBHandler] - 10https://gerrit.wikimedia.org/r/46897 (owner: 10Emw)
[15:00:10] <grrrit-wm>	 (03Abandoned) 10Hashar: Initial commit of PDBHandler [extensions/PDBHandler] - 10https://gerrit.wikimedia.org/r/49791 (owner: 10Emw)
[15:00:15] <grrrit-wm>	 (03Abandoned) 10Hashar: Made fixes per review, and did other refactoring [extensions/PDBHandler] - 10https://gerrit.wikimedia.org/r/49786 (owner: 10Emw)
[15:00:19] <grrrit-wm>	 (03Abandoned) 10Hashar: Initial commit of PDBHandler [extensions/PDBHandler] - 10https://gerrit.wikimedia.org/r/47547 (owner: 10Emw)
[15:00:23] <grrrit-wm>	 (03Abandoned) 10Hashar: Further fixed indentation whitespace styling [extensions/PDBHandler] - 10https://gerrit.wikimedia.org/r/47384 (owner: 10Emw)
[15:00:28] <grrrit-wm>	 (03Abandoned) 10Hashar: Changed back to minified Three.js [extensions/PDBHandler] - 10https://gerrit.wikimedia.org/r/47383 (owner: 10Emw)
[15:02:22] <grrrit-wm>	 (03Abandoned) 10Hashar: Add .mw-search to all standard skins. [core] - 10https://gerrit.wikimedia.org/r/27969 (owner: 10Daniel Friesen)
[15:02:47] <grrrit-wm>	 (03Abandoned) 10Hashar: Update MathCaptcha to support recent versions of Math. [extensions/ConfirmEdit] - 10https://gerrit.wikimedia.org/r/49384 (owner: 10Daniel Friesen)
[15:03:09] <grrrit-wm>	 (03Abandoned) 10Hashar: Major improvements to RDFa and tweaks to Microdata support. [core] - 10https://gerrit.wikimedia.org/r/67608 (owner: 10Daniel Friesen)
[15:03:29] <grrrit-wm>	 (03Abandoned) 10Hashar: Add support for skin classes that are not prefixed with 'Skin'. [core] - 10https://gerrit.wikimedia.org/r/56426 (owner: 10Daniel Friesen)
[15:05:11] <grrrit-wm>	 (03Abandoned) 10Hashar: Always quote attribute values ending in a backslash [core] - 10https://gerrit.wikimedia.org/r/67603 (owner: 10Daniel Friesen)
[15:05:31] <grrrit-wm>	 (03Abandoned) 10Hashar: Update p2wiki skin metadata and skin id handling. - Cleanup license blurb - Update author lines - Update other attributes - Cleanup credit style - Use a proper fixed 'p2wiki' for the skin name. [extensions/skins] - 10https://gerrit.wikimedia.org/r/81648 (owner: 10Daniel Friesen)
[15:08:15] <grrrit-wm>	 (03PS1) 10Hoo man: Update Wikidata to fix snaks in items with multiple references [core] (wmf/1.23wmf15) - 10https://gerrit.wikimedia.org/r/115919 
[15:13:45] <grrrit-wm>	 (03Abandoned) 10Hashar: Add JS tests, and make them work. [extensions/EtherEditor] - 10https://gerrit.wikimedia.org/r/14153 (owner: 10MarkTraceur)
[15:13:50] <grrrit-wm>	 (03Abandoned) 10Hashar: Change the behavior on no users being connected [extensions/EtherEditor] - 10https://gerrit.wikimedia.org/r/20231 (owner: 10MarkTraceur)
[15:18:47] <grrrit-wm>	 (03Abandoned) 10Hashar: Added Map interface using Leaflet library. [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/12352 (owner: 10Drecodeam)
[15:18:54] <grrrit-wm>	 (03Abandoned) 10Hashar: Defined functions for adding Map to every image detail section [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/12353 (owner: 10Drecodeam)
[15:18:58] <grrrit-wm>	 (03Abandoned) 10Hashar: Add AFT to mobile pages [extensions/ArticleFeedbackv5] - 10https://gerrit.wikimedia.org/r/23577 (owner: 10Matthias Mullie)
[15:23:16] <grrrit-wm>	 (03PS1) 10Mglaser: SECURITY: Disallow non-whitelisted namespaces [core] (REL1_22) - 10https://gerrit.wikimedia.org/r/115921 
[15:31:06] <grrrit-wm>	 (03PS1) 10AndyRussG: Fixes course deletion via delete tab (new bug) [extensions/EducationProgram] - 10https://gerrit.wikimedia.org/r/115922 
[15:34:50] <grrrit-wm>	 (03PS4) 10Krinkle: [WIP] Set up node-jscs via Grunt (and pass it) [core] - 10https://gerrit.wikimedia.org/r/111963 
[15:34:52] <grrrit-wm>	 (03PS1) 10Krinkle: jshintignore: Add jquery.fullscreen.js [core] - 10https://gerrit.wikimedia.org/r/115923 
[15:36:04] <grrrit-wm>	 (03CR) 10Bartosz Dziewoński: [C: 032] jshintignore: Add jquery.fullscreen.js [core] - 10https://gerrit.wikimedia.org/r/115923 (owner: 10Krinkle)
[15:40:04] <grrrit-wm>	 (03Merged) 10jenkins-bot: jshintignore: Add jquery.fullscreen.js [core] - 10https://gerrit.wikimedia.org/r/115923 (owner: 10Krinkle)
[15:48:35] <grrrit-wm>	 (03CR) 10Ragesoss: [C: 04-1] "This fixes one bug, but the bug itself prevents problems from the related bug, which is that the Delete tab shows up for all users without" [extensions/EducationProgram] - 10https://gerrit.wikimedia.org/r/115922 (owner: 10AndyRussG)
[15:48:49] <grrrit-wm>	 (03PS5) 10Krinkle: [WIP] Set up node-jscs via Grunt (and pass it) [core] - 10https://gerrit.wikimedia.org/r/111963 
[15:49:00] <grrrit-wm>	 (03CR) 10Krinkle: "Resolved various merge conflicts and re-did part of it using a newer version of jscs." [core] - 10https://gerrit.wikimedia.org/r/111963 (owner: 10Krinkle)
[15:51:01] <grrrit-wm>	 (03PS1) 10Mglaser: SECURITY: Disallow non-whitelisted namespaces [core] (REL1_21) - 10https://gerrit.wikimedia.org/r/115925 
[16:09:09] <grrrit-wm>	 (03PS1) 10Mglaser: SECURITY: Disallow non-whitelisted namespaces [core] (REL1_19) - 10https://gerrit.wikimedia.org/r/115927 
[16:09:54] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] SECURITY: Disallow non-whitelisted namespaces [core] (REL1_19) - 10https://gerrit.wikimedia.org/r/115927 (owner: 10Mglaser)
[16:19:36] <grrrit-wm>	 (03PS6) 10Krinkle: [WIP] Set up node-jscs via Grunt (and pass it) [core] - 10https://gerrit.wikimedia.org/r/111963 
[16:22:22] <grrrit-wm>	 (03CR) 10Krinkle: "(Don't merge until jenkins job for mediawiki-core-npm/grunttest has been setup)" [core] - 10https://gerrit.wikimedia.org/r/111963 (owner: 10Krinkle)
[16:29:11] <grrrit-wm>	 (03PS1) 10Mglaser: SECURITY: Disallow non-whitelisted namespaces [core] (REL1_19) - 10https://gerrit.wikimedia.org/r/115929 
[16:38:29] <grrrit-wm>	 (03PS1) 10Legoktm: Use FormatJson instead of json_* functions [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/115930 
[16:38:51] <Krinkle>	 addshore: Rather interesting failures on travis for php 54
[16:38:54] <Krinkle>	 https://travis-ci.org/addshore/mediawiki-core/jobs/19731380
[16:38:58] <Krinkle>	 -'Sun, 01 Jan 0101 00:00:00 GMT'
[16:38:59] <Krinkle>	 +'Sat, 01 Jan 0101 00:00:00 GMT'
[16:39:09] <Krinkle>	 -'Tue, 09 Aug 0117 12:34:56 GMT'
[16:39:09] <Krinkle>	 +'Mon, 09 Aug 0117 12:34:56 GMT'
[16:39:15] <Krinkle>	 -    0 => 'ø'
[16:39:16] <Krinkle>	 +    0 => ''
[16:39:22] <Krinkle>	 Good luck, have fun :)
[16:39:47] <Krinkle>	 addshore: I suppose 5.3 (passing) should also be kept passing (not allow failure)
[16:40:00] <Krinkle>	 anyway, no rush, it's going great. Love what you're doing.
[16:41:06] <grrrit-wm>	 (03CR) 10Jforrester: [C: 04-1] "Is there a way to fix this without introducing the regression of using a raster image instead of a vector one for the vast majority of bro" [extensions/BetaFeatures] - 10https://gerrit.wikimedia.org/r/115885 (owner: 10Thiemo Mättig (WMDE))
[16:41:21] <addshore>	 Krinkle: indeed, as when I first tested it it failed :D
[16:41:44] <addshore>	 oddly that test also fails for Adrian in our office!
[16:42:23] <addshore>	 also talking to the scrutinizer-ci.com guys to see if we can actually get mediawiki-core to run there without blowing up ;p
[16:44:53] <Krinkle>	 hashar: Good to know, scm: mwcore doesn't work together with label: hasNpm
[16:44:57] <Krinkle>	 16:44:12 ERROR: Reference path does not exist: /srv/ssd/gerrit/mediawiki/core.git 
[16:45:03] <hashar>	 :-(
[16:45:05] <Krinkle>	 makes sense but oh well
[16:45:11] <Krinkle>	 doesn't have to be there, don't worry.
[16:45:17] <Krinkle>	 I'll just use use-remote-zuul
[16:45:23] <hashar>	 yeah the job/architecture has grown out of control.
[16:45:36] <hashar>	 the aim is to avoid cloning the whole mediawiki/core repository
[16:45:38] <addshore>	 hashar: where is the jenkins job that does the coverage? I might try and make a change to push the result to coveralls in a while
[16:45:39] <Krinkle>	 hashar: I'd really like to get rid of all these different 'defaults' and 'scm'
[16:46:18] <Krinkle>	 hashar: Using '--depth 1' would help a lot, no?
[16:47:08] <hashar>	 Krinkle: possibly yeah
[16:47:24] <hashar>	 addshore: in jenkins job builder config files at  integration/jenkins-jobs-builder-config.git
[16:47:39] <hashar>	 addshore: what is coveralls?
[16:47:41] <bd808|deploy>	 1.23wmf16 branch cut
[16:48:04] <addshore>	 https://coveralls.io/ ;p Test Coverage History & Statistics
[16:48:19] <addshore>	 basiically you just sent it the clover coverage file and it does everything else
[16:48:45] <addshore>	 I tried to get travis running the coverage on every change but that just takes an unrealistic ammount of time
[16:49:05] <hashar>	 yeah you want it to be timed once per day
[16:49:36] <addshore>	 or twice ;p
[16:52:00] <Krinkle>	 hashar: Hm.. strange
[16:52:02] <Krinkle>	 https://integration.wikimedia.org/ci/job/mwext-VisualEditor-npm/1180/console
[16:52:07] <Krinkle>	 Apparently that error is "normal"
[16:52:14] <Krinkle>	 16:34:24 ERROR: Reference path does not exist: /srv/ssd/gerrit/mediawiki/extensions/VisualEditor.git
[16:52:14] <Krinkle>	 16:34:35 Fetching upstream changes from origin
[16:52:17] <Krinkle>	 it just continues without that
[16:52:19] <Krinkle>	 wat?
[16:52:35] <Krinkle>	 I thought it was somethign I did wrong in mediawiki-core-npm (experimental, don't worry)
[16:52:38] <Krinkle>	 apparently not
[16:52:49] <Krinkle>	 so that's for local cache or something?
[16:53:09] <Krinkle>	 and then tries on zuul.eqiad.wmnet if it can't find it
[16:53:50] <Krinkle>	 If it's just cache, seems like something we might want to setup there. If it is more (push mirror, instead of pull cache), then we probably dont' want that in labs..
[16:54:42] <hashar>	 Krinkle: yeah doc sucks sorry about that :(
[16:55:13] <Krinkle>	 Ah, found it
[16:55:16] <Krinkle>	 hashar: defaults.yaml
[16:55:18] <Krinkle>	 'Gerrit replication'
[16:55:20] <hashar>	 Krinkle: on the production slaves there is a gerrit replication. So the jobs clone from the Zuul repository and uses as reference the local replication to speed up cloning by avoiding networking  and doing hardlink
[16:55:30] <hashar>	 Krinkle: on slave there is no Gerrit replication though :/
[16:55:32] <Krinkle>	 hashar: So if that's Gerrit replication, why does it need both that and zuul.eqiad.wmnet?
[16:55:42] <Krinkle>	 (I mean, for non-npm stuff, regular slaves)
[16:55:53] <hashar>	 Krinkle: also if you clone 'master' from zuul.eqiad.wmnet you would get the master branch in the zuul repository which is not the master branch in Gerrit
[16:56:15] <Krinkle>	 https://github.com/wikimedia/integration-jenkins-job-builder-config/blob/master/defaults.yaml#L15-L63
[16:56:20] <hashar>	 Krinkle: I need to write down all of that some where and rethink how the cloning occur.  It is over complicated right now
[16:58:49] <grrrit-wm>	 (03PS7) 10Krinkle: [WIP] Set up node-jscs via Grunt (and pass it) [core] - 10https://gerrit.wikimedia.org/r/111963 
[16:59:33] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] [WIP] Set up node-jscs via Grunt (and pass it) [core] - 10https://gerrit.wikimedia.org/r/111963 (owner: 10Krinkle)
[16:59:43] <Nikerabbit>	 brion: did you submit a patch yet?
[16:59:48] <grrrit-wm>	 (03PS8) 10Krinkle: [WIP] Set up node-jscs via Grunt (and pass it) [core] - 10https://gerrit.wikimedia.org/r/111963 
[17:00:02] <brion>	 Nikerabbit: got behind on some stuff, should have it ready tomorrow :(
[17:00:20] <Nikerabbit>	 brion: that's okay, I will get to it some time later
[17:00:26] <grrrit-wm>	 (03CR) 10Jackmcbarn: "Do you have any idea of how to accomplish the same goal in a better way?" (031 comment) [core] - 10https://gerrit.wikimedia.org/r/115696 (owner: 10Jackmcbarn)
[17:00:26] <brion>	 spiff. thanks!
[17:00:31] <Krinkle>	 hashar: Also, I'm not sure what this is, but I quite often see this http://i.imgur.com/8S6bcQi.png
[17:00:40] <Krinkle>	 hashar: 0/0, queued, and nothing happens for 10-20 seonds
[17:01:37] <grrrit-wm>	 (03Abandoned) 10Jackmcbarn: Use shorter link in edit summary [extensions/FlaggedRevs] - 10https://gerrit.wikimedia.org/r/115806 (owner: 10Jackmcbarn)
[17:07:47] <grrrit-wm>	 (03CR) 10Legoktm: "Is this security release going to be announced? I didn't see a pre-release announcement like is normally done... (<http://lists.wikimedia." [core] - 10https://gerrit.wikimedia.org/r/115907 (owner: 10Mglaser)
[17:07:51] <legoktm>	 there's a security release today?
[17:07:52] <legoktm>	 I didn't see any announcement about it
[17:08:36] <grrrit-wm>	 (03CR) 10Legoktm: [C: 032] SECURITY: API: Don't find links in the middle of api.php links [core] (REL1_22) - 10https://gerrit.wikimedia.org/r/115915 (owner: 10Mglaser)
[17:08:49] <grrrit-wm>	 (03CR) 10Legoktm: [C: 032] SECURITY: API: Don't find links in the middle of api.php links [core] (REL1_21) - 10https://gerrit.wikimedia.org/r/115916 (owner: 10Mglaser)
[17:12:29] <addshore>	 Krinkle: who should I talk to about getting a repo on gerrit to dump a copy of https://github.com/satooshi/php-coveralls into ?
[17:12:46] <addshore>	 with all of its dependancies :P
[17:12:54] <grrrit-wm>	 (03Merged) 10jenkins-bot: SECURITY: API: Don't find links in the middle of api.php links [core] (REL1_22) - 10https://gerrit.wikimedia.org/r/115915 (owner: 10Mglaser)
[17:13:06] <hashar>	 addshore: I guess there is no debian package for it ? :D
[17:13:13] <addshore>	 no ;p
[17:13:32] <hashar>	 addshore: so I did that for phpunit.  Somehow managed to use composer to get everything in a repo
[17:13:41] <hashar>	 addshore: and submitted it in  integration/phpunit.git
[17:13:50] <hashar>	 addshore: then added integration/phpunit.git to the git-deploy system 
[17:14:12] <grrrit-wm>	 (03Merged) 10jenkins-bot: SECURITY: API: Don't find links in the middle of api.php links [core] (REL1_21) - 10https://gerrit.wikimedia.org/r/115916 (owner: 10Mglaser)
[17:14:27] <hashar>	 addshore: please have a look at the README / composer.json files of integration/phpunit.git and integration/phpcs.git
[17:14:42] <hashar>	 addshore: creating a repo integration/php-coveralls for ya
[17:14:57] <addshore>	 :) will take a look at the readmes in a sec :)
[17:15:11] <addshore>	 still trying to make scrutinizer work for us right now ;p
[17:15:44] <hashar>	 addshore: if you can, avoid a full git clone.  You can use git archive if that is possible
[17:15:50] <hashar>	 addshore: or as timo suggested,  git clone -depth 1
[17:16:22] <grrrit-wm>	 (03CR) 10UltrasonicNXT: "Any comment on this?" [core] - 10https://gerrit.wikimedia.org/r/111532 (owner: 10UltrasonicNXT)
[17:16:33] <hashar>	 addshore: repo created: git clone ssh://gerrit.wikimedia.org:29418/integration/php-coveralls
[17:16:40] <addshore>	 cheers!
[17:16:55] <grrrit-wm>	 (03PS2) 10AndyRussG: Fix several issues with course deletion [extensions/EducationProgram] - 10https://gerrit.wikimedia.org/r/115922 
[17:16:59] <hashar>	 can be added to git-deploy somewhere under operations/puppet.git
[17:19:25] <hashar>	 addshore: the repo should be added to manifests/role/deployment.pp  just like the phpcs one. Then one with access on tin.eqiad.wmnet can deploy it :]
[17:20:00] * aude  no deploy

[17:24:29] <grrrit-wm>	 (03CR) 10Wctaiwan: "I removed the code related to the client-side storage of previous thanks since the bug Kaldari described in the 7th comment at https://ger" [extensions/Thanks] - 10https://gerrit.wikimedia.org/r/115557 (owner: 10Wctaiwan)
[17:29:46] <grrrit-wm>	 (03CR) 10Aaron Schulz: "What's the use of 'caches'?" [core] - 10https://gerrit.wikimedia.org/r/111946 (owner: 10IAlex)
[17:34:18] <grrrit-wm>	 (03CR) 10Thiemo Mättig (WMDE): "> Is there a way to fix this without introducing the regression" [extensions/BetaFeatures] - 10https://gerrit.wikimedia.org/r/115885 (owner: 10Thiemo Mättig (WMDE))
[17:35:37] <grrrit-wm>	 (03CR) 10Ragesoss: [C: 032] Fix several issues with course deletion [extensions/EducationProgram] - 10https://gerrit.wikimedia.org/r/115922 (owner: 10AndyRussG)
[17:35:44] <grrrit-wm>	 (03Merged) 10jenkins-bot: Fix several issues with course deletion [extensions/EducationProgram] - 10https://gerrit.wikimedia.org/r/115922 (owner: 10AndyRussG)
[17:36:26] <grrrit-wm>	 (03CR) 10Aaron Schulz: [C: 032] Allow to disable specific groups in $wgDebugLogGroups [core] - 10https://gerrit.wikimedia.org/r/111906 (owner: 10IAlex)
[17:37:28] <grrrit-wm>	 (03CR) 10Ragesoss: [C: 031] "works as expected!" [extensions/EducationProgram] - 10https://gerrit.wikimedia.org/r/113145 (owner: 10J-squared)
[17:40:18] <grrrit-wm>	 (03Merged) 10jenkins-bot: Allow to disable specific groups in $wgDebugLogGroups [core] - 10https://gerrit.wikimedia.org/r/111906 (owner: 10IAlex)
[17:46:11] <grrrit-wm>	 (03CR) 10Bartosz Dziewoński: [C: 032] Use FormatJson instead of json_* functions [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/115930 (owner: 10Legoktm)
[17:46:20] <grrrit-wm>	 (03Merged) 10jenkins-bot: Use FormatJson instead of json_* functions [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/115930 (owner: 10Legoktm)
[17:55:11] <grrrit-wm>	 (03PS1) 10Aude: Fix several issues with course deletion [extensions/EducationProgram] (wmf/1.23wmf15) - 10https://gerrit.wikimedia.org/r/115941 
[17:56:39] <grrrit-wm>	 (03CR) 10Aude: [C: 032] Fix several issues with course deletion [extensions/EducationProgram] (wmf/1.23wmf15) - 10https://gerrit.wikimedia.org/r/115941 (owner: 10Aude)
[17:56:45] <grrrit-wm>	 (03Merged) 10jenkins-bot: Fix several issues with course deletion [extensions/EducationProgram] (wmf/1.23wmf15) - 10https://gerrit.wikimedia.org/r/115941 (owner: 10Aude)
[17:56:56] <grrrit-wm>	 (03PS1) 10Aude: Fix several issues with course deletion [extensions/EducationProgram] (wmf/1.23wmf16) - 10https://gerrit.wikimedia.org/r/115942 
[17:57:10] <grrrit-wm>	 (03CR) 10Aude: [C: 032] Fix several issues with course deletion [extensions/EducationProgram] (wmf/1.23wmf16) - 10https://gerrit.wikimedia.org/r/115942 (owner: 10Aude)
[17:57:17] <grrrit-wm>	 (03Merged) 10jenkins-bot: Fix several issues with course deletion [extensions/EducationProgram] (wmf/1.23wmf16) - 10https://gerrit.wikimedia.org/r/115942 (owner: 10Aude)
[17:59:01] <grrrit-wm>	 (03PS1) 10Aude: Update EducationProgram [core] (wmf/1.23wmf15) - 10https://gerrit.wikimedia.org/r/115943 
[17:59:01] <dr0ptp4kt>	 Krinkle, sorry, i left my irc client running without setting myself to away. what's up? i saw you did some stuff in rl, haven't read it yet, though.
[18:09:43] <superm401>	 Is gerrit-reviewer-bot working for anyone else?
[18:09:58] <superm401>	 It's not for me anymore on the GettingStarted repo.
[18:10:10] <superm401>	 I forgot who maintains that/where it is maintained.
[18:11:31] <grrrit-wm>	 (03PS1) 10Aude: update EducationProgram [core] (wmf/1.23wmf16) - 10https://gerrit.wikimedia.org/r/115944 
[18:11:44] <grrrit-wm>	 (03PS2) 10Aude: Update EducationProgram [core] (wmf/1.23wmf16) - 10https://gerrit.wikimedia.org/r/115944 
[18:13:00] <grrrit-wm>	 (03CR) 10Aude: [C: 031] Update Wikidata to fix snaks in items with multiple references [core] (wmf/1.23wmf15) - 10https://gerrit.wikimedia.org/r/115919 (owner: 10Hoo man)
[18:17:06] <grrrit-wm>	 (03PS1) 10Addshore: Initial commit of 0.6.1 + dependencies [integration/php-coveralls] - 10https://gerrit.wikimedia.org/r/115945 
[18:19:47] <legoktm>	 superm401: valhallasw runs it, I pinged him in #pywikipediabot 
[18:20:08] <superm401>	 Thanks, legoktm.
[18:22:28] <grrrit-wm>	 (03PS1) 10Addshore: Add README.md [integration/php-coveralls] - 10https://gerrit.wikimedia.org/r/115946 
[18:25:43] <grrrit-wm>	 (03CR) 10Alex Monk: "I note that the bug is also not public..." [core] - 10https://gerrit.wikimedia.org/r/115907 (owner: 10Mglaser)
[18:29:05] <addshore>	 hmm /puppet/manifests/role/deployment.pp seems right
[18:35:37] <brion>	 AHO! srcset has landed on chrome 34: http://www.chromestatus.com/features/4644337115725824
[18:35:42] <brion>	 time to test some betas
[18:36:19] <grrrit-wm>	 (03CR) 10Hoo man: "Markus told me that the releases were announced, I didn't verify that back then. Once the releases are live, I guess we can make the bugs " [core] - 10https://gerrit.wikimedia.org/r/115907 (owner: 10Mglaser)
[18:38:15] <grrrit-wm>	 (03PS1) 10Manybubbles: Update to 1.0.0.0 [extensions/Elastica] - 10https://gerrit.wikimedia.org/r/115948 
[18:39:44] <grrrit-wm>	 (03CR) 10Manybubbles: [C: 04-1] "This requires 1.0 so we can't merge until we upgrade the cluster, unfortunately. If you want to develop stuff that won't be released in t" [extensions/Elastica] - 10https://gerrit.wikimedia.org/r/115948 (owner: 10Manybubbles)
[18:41:00] <legoktm>	 Krenair: I have no clue what's going on with that.
[18:43:09] <grrrit-wm>	 (03CR) 10GWicke: "The point is to document the formats rather than calling them input/output. We already routinely convert from 'output' to 'input' in Parso" [core] - 10https://gerrit.wikimedia.org/r/89141 (owner: 10Arlolra)
[18:44:27] <grrrit-wm>	 (03CR) 10Cscott: [C: 031] "LGTM. I agree with gwicke that we'd like to treat 'html-php' as a synonym for 'html' on the PHP side, and probably automatically skip any" [core] - 10https://gerrit.wikimedia.org/r/89141 (owner: 10Arlolra)
[18:45:30] <grrrit-wm>	 (03PS1) 10UltrasonicNXT: Add fullscreen mode [extensions/MediaWikiChat] - 10https://gerrit.wikimedia.org/r/115949 
[18:55:22] <grrrit-wm>	 (03PS1) 10Addshore: DNM Send coverage info to Coveralls [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/115951 
[18:55:29] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] DNM Send coverage info to Coveralls [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/115951 (owner: 10Addshore)
[18:58:25] <grrrit-wm>	 (03PS2) 10Addshore: DNM Send coverage info to Coveralls [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/115951 
[19:00:01] <grrrit-wm>	 (03CR) 10Bsitu: (bug 61107) Contributions from Flow appear in every namespace (033 comments) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/115908 (owner: 10Matthias Mullie)
[19:06:24] <grrrit-wm>	 (03PS1) 10Addshore: Increase coverage generation to run every 12 hours [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/115953 
[19:08:12] <grrrit-wm>	 (03CR) 10Bsitu: [C: 031] Add preview of new comment to watchlist/rc/history [extensions/Flow] - 10https://gerrit.wikimedia.org/r/115113 (owner: 10Matthias Mullie)
[19:08:36] <hoo>	 mglaser: hi... saw the comments on one of the security patcheS?
[19:11:11] <mglaser>	 hoo, just have to catch up. I a notice on the bug not being public
[19:11:28] <grrrit-wm>	 (03PS1) 10Addshore: Fix incorrect @covers tags in LinksUpdateTest [core] - 10https://gerrit.wikimedia.org/r/115954 
[19:12:06] <grrrit-wm>	 (03PS15) 10Aaron Schulz: Moved job running via $wgJobRunRate to a special API [core] - 10https://gerrit.wikimedia.org/r/113038 
[19:12:18] <hoo>	 mglaser: Ok, I can move the bugs around, if needed (but you should also be able to do that... just check that there's no private data in there first)
[19:12:26] <grrrit-wm>	 (03CR) 10Legoktm: [C: 032] Fix incorrect @covers tags in LinksUpdateTest [core] - 10https://gerrit.wikimedia.org/r/115954 (owner: 10Addshore)
[19:12:46] <mglaser>	 hoo, I think they should only be made public once the tarballs are out
[19:13:03] <hoo>	 yep
[19:13:07] <grrrit-wm>	 (03CR) 10Ori.livneh: [C: 032] "TODOs" [core] - 10https://gerrit.wikimedia.org/r/113038 (owner: 10Aaron Schulz)
[19:13:14] <hoo>	 but that's scheduled for tonight, right?
[19:14:06] <legoktm>	 er
[19:14:11] <legoktm>	 why is it not going out right away?
[19:14:23] <legoktm>	 the patch is already out, it's not that hard to figure out the bug
[19:14:25] <grrrit-wm>	 (03CR) 10Yuvipanda: [C: 032 V: 032] Make animation mixin cleaner [extensions/Popups] - 10https://gerrit.wikimedia.org/r/115376 (owner: 10Prtksxna)
[19:14:53] <hoo>	 legoktm: Sure, but they might contain attack examples or so
[19:14:57] <hoo>	 not the case here
[19:14:59] <hoo>	 AFAIR
[19:15:01] <legoktm>	 right
[19:15:19] <legoktm>	 I don't understand why the announcement isn't going out now though
[19:15:32] <ori>	 hexmode, mglaser: flagging https://gerrit.wikimedia.org/r/113038 for your attention. it's a significant patch and because of how things are set up at wikimedia it likely won't be tested very thoroughly on our infrastructure before hitting 3rd parties.
[19:15:43] <grrrit-wm>	 (03CR) 10Yuvipanda: [C: 04-1] Limit image size for portrait popups (032 comments) [extensions/Popups] - 10https://gerrit.wikimedia.org/r/115186 (owner: 10Prtksxna)
[19:16:10] * addshore  waits for hashar :P

[19:16:16] <addshore>	 wonder if he will pop back tonight
[19:16:24] <James_F>	 andre__: How would you feel about me creating a dummy "VE bug" Bugzilla user so that accepted VE bugs (which we're having to use "ASSIGNED" for) doesn't scare people away from contributing by cookie-licking?
[19:16:27] <grrrit-wm>	 (03CR) 10Yuvipanda: [C: 04-1] Flip the starting point of the popup if its on the right side of the screen (031 comment) [extensions/Popups] - 10https://gerrit.wikimedia.org/r/115187 (owner: 10Prtksxna)
[19:16:42] <James_F>	 andre__: (Though it's 21:16 for you so you're probably not around.)
[19:16:44] <MatmaRex>	 ori: hey, it can't get any worse!
[19:17:07] <grrrit-wm>	 (03Merged) 10jenkins-bot: Fix incorrect @covers tags in LinksUpdateTest [core] - 10https://gerrit.wikimedia.org/r/115954 (owner: 10Addshore)
[19:17:13] <hexmode>	 ori: ty
[19:17:36] <grrrit-wm>	 (03CR) 10Yuvipanda: [C: 04-1] "1. No magic numbers, again :) Use constants!" [extensions/Popups] - 10https://gerrit.wikimedia.org/r/115188 (owner: 10Prtksxna)
[19:18:00] <grrrit-wm>	 (03Merged) 10jenkins-bot: Moved job running via $wgJobRunRate to a special API [core] - 10https://gerrit.wikimedia.org/r/113038 (owner: 10Aaron Schulz)
[19:18:03] <yuvipanda>	 zz_prtksxna: reviewed :)
[19:18:32] <hexmode>	 ori: hrm... since you say you want us to "socialize" that, maybe we should wait till next month instead of trying to push it today
[19:18:52] <mglaser>	 hoo, legoktm, it's going out tonight
[19:19:03] <legoktm>	 mglaser: what timezone is "tonight" in?
[19:19:18] <mglaser>	 legoktm, UTC+1 :)
[19:19:30] <mglaser>	 so it's already, say, evening
[19:19:56] <legoktm>	 ok, that sounds good
[19:23:56] <grrrit-wm>	 (03PS5) 10Wctaiwan: [WIP] Add "Thanks" for comments on Flow boards [extensions/Thanks] - 10https://gerrit.wikimedia.org/r/115557 
[19:26:01] <grrrit-wm>	 (03CR) 10Wctaiwan: [WIP] Add "Thanks" for comments on Flow boards (031 comment) [extensions/Thanks] - 10https://gerrit.wikimedia.org/r/115557 (owner: 10Wctaiwan)
[19:28:58] <ebernhardson>	 because, why the hell not:  $x = 'foo'; var_dump( $x['bar'] ); // outputs string(1) "f"
[19:38:03] <grrrit-wm>	 (03CR) 10AndyRussG: [C: 04-1] "Great work!! Apologies for missing a few things earlier...!" (035 comments) [extensions/EducationProgram] - 10https://gerrit.wikimedia.org/r/113145 (owner: 10J-squared)
[19:48:00] <valhallasw>	 superm401: gerrit reviewer bot is up again -- it's job was stuck in an error state. Check http://tools.wmflabs.org/gerrit-reviewer-bot/ for progress.
[19:48:31] <superm401>	 Thanks, valhallasw
[19:48:46] <mglaser_>	 thanks valhallasw
[19:50:20] <grrrit-wm>	 (03CR) 10PiRSquared17: ""I'm hoping we can get this merged before the end of 2013."" (032 comments) [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/7300 (owner: 10Szymon Świerkosz)
[19:50:33] <grrrit-wm>	 (03CR) 10EBernhardson: [C: 04-1] "while looking at this i realized, this is probably an unnecessary column?" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/115619 (owner: 10Matthias Mullie)
[19:51:17] <grrrit-wm>	 (03PS2) 10EBernhardson: Prefix tables with /*_*/ [extensions/Flow] - 10https://gerrit.wikimedia.org/r/115620 (owner: 10Matthias Mullie)
[19:51:37] <grrrit-wm>	 (03CR) 10EBernhardson: [C: 032] "PS2: reparented against master" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/115620 (owner: 10Matthias Mullie)
[19:51:48] <grrrit-wm>	 (03Merged) 10jenkins-bot: Prefix tables with /*_*/ [extensions/Flow] - 10https://gerrit.wikimedia.org/r/115620 (owner: 10Matthias Mullie)
[19:54:23] <grrrit-wm>	 (03CR) 10PiRSquared17: "What still needs to be done?" [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/78946 (owner: 10Legoktm)
[19:56:29] <grrrit-wm>	 (03CR) 10EBernhardson: "couple minor comments." (033 comments) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/115112 (owner: 10Matthias Mullie)
[19:58:51] <grrrit-wm>	 (03PS1) 10Mglaser: SECURITY: Make token comparison constant time [core] (REL1_19) - 10https://gerrit.wikimedia.org/r/115957 
[20:04:00] <grrrit-wm>	 (03CR) 10EBernhardson: [C: 032] Fix bug in 9f2b1140 where it was impossible to edit a post if you had a non-post URL hash [extensions/Flow] - 10https://gerrit.wikimedia.org/r/115859 (owner: 10Werdna)
[20:04:12] <grrrit-wm>	 (03Merged) 10jenkins-bot: Fix bug in 9f2b1140 where it was impossible to edit a post if you had a non-post URL hash [extensions/Flow] - 10https://gerrit.wikimedia.org/r/115859 (owner: 10Werdna)
[20:15:51] <valhallasw>	 287 mails to go, so the backlog is almost gone
[20:17:56] <grrrit-wm>	 (03CR) 10Hashar: "cced Jeroen. I guess we can get this change merged now? :-]" [core] - 10https://gerrit.wikimedia.org/r/115905 (owner: 10Addshore)
[20:18:41] <grrrit-wm>	 (03CR) 10Addshore: "Yes, should be no problem with it :)" [core] - 10https://gerrit.wikimedia.org/r/115905 (owner: 10Addshore)
[20:18:46] <addshore>	 hashar: :P
[20:19:04] <hashar>	 addshore: have you tested it ?
[20:19:08] <addshore>	 yup
[20:19:15] <addshore>	 there is a link to it as a comment
[20:19:55] <grrrit-wm>	 (03CR) 10Hashar: [C: 032] "And here we go!" [core] - 10https://gerrit.wikimedia.org/r/115905 (owner: 10Addshore)
[20:20:00] <addshore>	 :D
[20:20:15] <addshore>	 currently just trying to decode exactly what the src_dir param expects for coveralls..
[20:20:27] <grrrit-wm>	 (03PS1) 10Mglaser: SECURITY: API: Don't find links in the middle of api.php links [core] (REL1_19) - 10https://gerrit.wikimedia.org/r/115961 
[20:21:36] <grrrit-wm>	 (03CR) 10Hashar: [C: 032 V: 032] Initial commit of 0.6.1 + dependencies [integration/php-coveralls] - 10https://gerrit.wikimedia.org/r/115945 (owner: 10Addshore)
[20:21:54] <grrrit-wm>	 (03CR) 10Hashar: [C: 032 V: 032] Add README.md [integration/php-coveralls] - 10https://gerrit.wikimedia.org/r/115946 (owner: 10Addshore)
[20:22:02] <valhallasw>	 superm401, mglaser, the backlog is gone! Enjoy your patches-to-review ;-)
[20:22:14] <superm401>	 valhallasw, thank you. :)
[20:22:25] <grrrit-wm>	 (03PS3) 10Addshore: DNM Send coverage info to Coveralls [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/115951 
[20:22:48] <valhallasw>	 and feel free to poke me on irc/send a talk page message/send an email if the reviewer bot is malfunctioning again
[20:23:09] <addshore>	 :> hashar I will be rather happy if this all works first time xD
[20:23:22] <mglaser>	 valhallasw you saved my evening ;)
[20:23:44] <addshore>	 also working at poking scrutinizer with a stick to see if we can make it run over our code also :D
[20:24:34] <grrrit-wm>	 (03Merged) 10jenkins-bot: Make travis test php 5.3, 5.4 and 5.5 [core] - 10https://gerrit.wikimedia.org/r/115905 (owner: 10Addshore)
[20:27:40] <addshore>	 also hashar need someone in the admin group on github to add mediawiki-core as a repo on coveralls and get the repo_key
[20:28:40] <hashar>	 addshore: I should be able to do that
[20:28:46] <addshore>	 [=
[20:29:39] <hashar>	 addshore: is that in web hook configuration?
[20:30:32] <addshore>	 the repo_key
[20:30:37] <addshore>	 apparently it should be at the bottom somewhere
[20:31:33] <addshore>	 infact just go to https://coveralls.io/r/wikimedia/mediawiki-core and you should see it
[20:32:22] <addshore>	 hashar: Note: Do not make your repo token public. (not sure if this is a big deal really) but I guess you should put it somewhere secret rather than in the jenkins config repo :P
[20:32:38] <hashar>	 access denied on that coveralls page obviously :-]
[20:33:16] <hashar>	 need to add 'hashar'
[20:34:26] <hashar>	 addshore: agh I am not an admin for the wikimedia group on coveralls.io
[20:34:55] <grrrit-wm>	 (03PS4) 10Addshore: DNM Send coverage info to Coveralls [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/115951 
[20:35:11] <addshore>	 JeroenDeDauw: around?
[20:35:35] <addshore>	 infact aude can also add you :)
[20:35:51] <addshore>	 oh wait, no
[20:35:56] <addshore>	 hashar: your in the group...
[20:36:32] <addshore>	 you perhaps have to go here first and turn it on https://coveralls.io/repos/new
[20:36:54] <hashar>	 addshore: yeah, can't find the wikimedia repositories there :D
[20:36:59] <addshore>	 O_o
[20:37:04] <hashar>	 tried on https://coveralls.io/repos/new?name=wikimedia  "add repo from wikimedia"
[20:37:07] <addshore>	 but... but... https://github.com/orgs/wikimedia/teams/owners :P
[20:37:30] <hashar>	 seems coveralls can't see me as owning the wikimedia group :/
[20:37:34] <addshore>	 add me and i'll have a go? ;p
[20:38:48] <mglaser>	 hoo, would you have some time to review the backports? I could self-merge them, but I'd feel more comfortable to have another pair of eyes go over them ;)
[20:39:39] <hoo>	 mglaser: I can do, but not now, will eat something...
[20:39:44] <hoo>	 be back in 20 mins.
[20:39:47] <mglaser>	 k
[20:41:51] <grrrit-wm>	 (03PS1) 10Reedy: Some cleanup post rewrite [extensions/ContactPage] - 10https://gerrit.wikimedia.org/r/115964 
[20:41:53] <grrrit-wm>	 (03CR) 10Mwalker: [C: 04-1] Expand MWException tests [core] - 10https://gerrit.wikimedia.org/r/115608 (owner: 10Addshore)
[20:42:15] <hashar>	 addshore: maybe jeroen can add it
[20:42:55] <addshore>	 hashar: did you lick the refresh repos button? :) https://coveralls.io/refresh
[20:43:02] <addshore>	 ...click, not lick!
[20:43:02] <hashar>	 addshore: yup
[20:43:14] <grrrit-wm>	 (03CR) 10Aude: [C: 032] Update EducationProgram [core] (wmf/1.23wmf16) - 10https://gerrit.wikimedia.org/r/115944 (owner: 10Aude)
[20:43:18] <hashar>	 addshore: I suspect the "wikimedia" organisation on coveralls is not linked with the one from github
[20:43:38] <hashar>	 addshore: if I try to add a repository, nothing show up in the list
[20:43:44] <addshore>	 impossible :) its a one to one relationship with github
[20:43:51] <hashar>	 ahh
[20:44:02] <hashar>	 well https://coveralls.io/r/wikimedia  shows wikibase related repositories
[20:44:13] <grrrit-wm>	 (03CR) 10Aude: [C: 032] Update Wikidata to fix snaks in items with multiple references [core] (wmf/1.23wmf15) - 10https://gerrit.wikimedia.org/r/115919 (owner: 10Hoo man)
[20:44:30] <hashar>	 addshore: and the link to add a repo ( https://coveralls.io/repos/new?name=wikimedia ) shows nothing :]
[20:44:38] * aude  is busy :)

[20:45:19] <addshore>	 hashar: did you try searching on the https://coveralls.io/repos/new page though? :P should show a different list
[20:45:20] <addshore>	 :D
[20:45:21] <grrrit-wm>	 (03CR) 10EBernhardson: Cache the last revision of a collection (031 comment) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/115828 (owner: 10Bsitu)
[20:45:29] <hashar>	 addshore: yeah same
[20:45:33] <addshore>	 hmm, unless it expects a .coveralls.yml to be in the repo :/
[20:45:57] <hashar>	 addshore: I only see my personal repositories and some other group I am a owner for.  Nothing for wikimedia though :D
[20:46:00] <addshore>	 hmm, no, as I can see lots of repos without that
[20:46:33] <addshore>	 I see everything I have access to :P
[20:46:37] <hashar>	 hehe
[20:46:50] <grrrit-wm>	 (03Merged) 10jenkins-bot: Update EducationProgram [core] (wmf/1.23wmf16) - 10https://gerrit.wikimedia.org/r/115944 (owner: 10Aude)
[20:47:36] <addshore>	 never fear, brion is here? ;p
[20:47:42] <grrrit-wm>	 (03Merged) 10jenkins-bot: Update Wikidata to fix snaks in items with multiple references [core] (wmf/1.23wmf15) - 10https://gerrit.wikimedia.org/r/115919 (owner: 10Hoo man)
[20:47:54] <brion>	 hm?
[20:48:40] <hashar>	 addshore: sorry :(
[20:49:43] <grrrit-wm>	 (03PS1) 10Mwalker: Inform Zuul about the FundraisingChart extension [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/115967 
[20:50:07] <hashar>	 addshore: maybe my Wikimedia membership is not public
[20:50:13] <addshore>	 brion: any chance as a github wikimedia admin you could quickly pop to https://coveralls.io/repos/new and enable coveralls for wikimedia/mediawiki-core and give the repo_key to hashar ? :)
[20:50:22] <grrrit-wm>	 (03PS1) 10Mwalker: Add jobs for FundraisingChart extension [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/115968 
[20:50:30] <addshore>	 hashar: I see you in the list ;p I think coveralls maybe just doesnt like you :/
[20:50:48] <hashar>	 addshore: well when browsing https://github.com/hashar  Wikimedia is not in my list of Organizations :]
[20:50:49] <grrrit-wm>	 (03CR) 10EBernhardson: [C: 04-1] Allow extension of post interaction links (031 comment) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/115552 (owner: 10Wctaiwan)
[20:50:52] <grrrit-wm>	 (03PS1) 10Manybubbles: Remove dumb log message left over from debugging [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/115969 
[20:51:04] <brion>	 addshore: is there documentation on how to do that? and what coveralls is? :)
[20:51:15] <grrrit-wm>	 (03CR) 10EBernhardson: Re-arrange execution order in UUID::create() (031 comment) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/115837 (owner: 10Bsitu)
[20:51:51] <addshore>	 brion: coverall is a test coverage history and statistics service ;p 
[20:52:10] <brion>	 where's the data come from? does it have to be hooked into jenkins etc to be useful?
[20:52:19] <addshore>	 and if you go to https://coveralls.io/repos/new and login with github you should see wikimedia/mediawiki-core in the list witha  big on switch next to it :)
[20:52:34] <addshore>	 brion: > https://gerrit.wikimedia.org/r/#/c/115951/
[20:53:25] <grrrit-wm>	 (03CR) 10EBernhardson: [C: 04-1] (bug 61107) Contributions from Flow appear in every namespace (031 comment) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/115908 (owner: 10Matthias Mullie)
[20:53:45] <hashar>	 addshore: fixed :-]
[20:53:53] <grrrit-wm>	 (03PS2) 10Reedy: Some cleanup post rewrite [extensions/ContactPage] - 10https://gerrit.wikimedia.org/r/115964 
[20:53:54] <hashar>	 addshore: I was not publicly a member of Wikimedia hehe
[20:53:58] <brion>	 aha
[20:53:59] <brion>	 :D
[20:54:07] <addshore>	 hashar: hiding his affiliation! pah!
[20:54:08] <hashar>	 embarrassing 
[20:54:11] <grrrit-wm>	 (03PS2) 10Matthias Mullie: Add $tablesUsed for test [extensions/Flow] - 10https://gerrit.wikimedia.org/r/115621 
[20:54:14] <hashar>	 I guess that is the default
[20:54:18] <addshore>	 you dont want to be associated with us? :/
[20:54:34] <hashar>	 https://coveralls.io/r/wikimedia/mediawiki-core  \O/
[20:55:07] <grrrit-wm>	 (03CR) 10Addshore: "-1 but not further comments seem to have appeared :/" [core] - 10https://gerrit.wikimedia.org/r/115608 (owner: 10Addshore)
[20:55:11] <addshore>	 hashar: :D
[20:55:32] <grrrit-wm>	 (03CR) 10Reedy: [C: 032] Some cleanup post rewrite [extensions/ContactPage] - 10https://gerrit.wikimedia.org/r/115964 (owner: 10Reedy)
[20:55:34] <grrrit-wm>	 (03Merged) 10jenkins-bot: Some cleanup post rewrite [extensions/ContactPage] - 10https://gerrit.wikimedia.org/r/115964 (owner: 10Reedy)
[20:55:51] <hashar>	 addshore: so now i have the repo key
[20:56:06] <hashar>	 addshore: but no way to publish it myself since I dont have access to the internal puppet repo
[20:57:08] <addshore>	 I'm sure someone would love to do that for you hashar :P
[20:57:12] <grrrit-wm>	 (03CR) 10Aude: [C: 032] Update EducationProgram [core] (wmf/1.23wmf15) - 10https://gerrit.wikimedia.org/r/115943 (owner: 10Aude)
[20:57:24] <grrrit-wm>	 (03CR) 10EBernhardson: [C: 032] "setting the propertsy directly is ok, although i suppose it opens up the possibility for easier errors if it were to inherit from a class " [extensions/Flow] - 10https://gerrit.wikimedia.org/r/115621 (owner: 10Matthias Mullie)
[20:57:27] <hashar>	 addshore: I can just put it in a file somewhere :-]
[20:57:34] <addshore>	 or that ;p
[20:57:45] * addshore  cant wait to see if this works ;p

[20:57:45] <grrrit-wm>	 (03PS12) 10Reedy: Allow inclusion of additional fields [extensions/ContactPage] - 10https://gerrit.wikimedia.org/r/113883 
[20:58:03] <grrrit-wm>	 (03Merged) 10jenkins-bot: Add $tablesUsed for test [extensions/Flow] - 10https://gerrit.wikimedia.org/r/115621 (owner: 10Matthias Mullie)
[20:58:05] <hashar>	 addshore: can't coverall pull from github directly?
[20:58:35] <addshore>	 coveralls doesnt actually run the tests to get the coverage, hence the need to provide the clover file
[20:58:55] <hashar>	 addshore: and the job we have already has a huggggggge clover.xml file :D
[20:59:07] <addshore>	 how huge is huge? :/
[20:59:14] <hashar>	 38MB uncompressed
[20:59:20] <addshore>	 meh, should be fine xD
[20:59:56] <hashar>	 we talked about that internally, I copy pasted the email in reply to your post on qa list
[21:00:14] <hashar>	 change I made this afternoon is that the clover.xml is now archived in the build report ( https://integration.wikimedia.org/ci/job/mediawiki-core-code-coverage/381/ )
[21:00:18] <addshore>	 I did try making travis run the tests with coverage but it takes about 50 mins and can only set up the coverage on 5.3/4/5 not on hhvm and 5.3/4/5 all fail currently ;p
[21:00:19] <hashar>	 should show a clover.xml.bz2
[21:00:27] <addshore>	 hashar: I saw it :)
[21:00:56] <grrrit-wm>	 (03Merged) 10jenkins-bot: Update EducationProgram [core] (wmf/1.23wmf15) - 10https://gerrit.wikimedia.org/r/115943 (owner: 10Aude)
[21:01:06] <addshore>	 I fixed the covers tags the job was complaining about https://gerrit.wikimedia.org/r/#/c/115954/
[21:02:08] <grrrit-wm>	 (03PS13) 10Reedy: Allow inclusion of additional fields [extensions/ContactPage] - 10https://gerrit.wikimedia.org/r/113883 
[21:02:11] <addshore>	 got to try and get this into scrutinizer before we can get any further on that front https://github.com/scrutinizer-ci/php-analyzer/pull/133
[21:02:20] <grrrit-wm>	 (03PS1) 10Mglaser: Updated Release Notes with security fixes [core] - 10https://gerrit.wikimedia.org/r/115970 
[21:02:22] <grrrit-wm>	 (03CR) 10Reedy: [C: 04-1] "Still needs fixing up" [extensions/ContactPage] - 10https://gerrit.wikimedia.org/r/113883 (owner: 10Reedy)
[21:02:30] <hashar>	 addshore: token is on the gallium server (which is where the coverage job run) under /var/lib/jenkins-slave/coveralls.io.token
[21:02:36] <hashar>	 addshore: which is not very secure
[21:02:42] <addshore>	 xD
[21:03:02] <addshore>	 it getting out wouldnt exactly let someone take over the world so I wouldnt worry ;p
[21:03:12] <hashar>	 indeed
[21:03:55] <grrrit-wm>	 (03CR) 10MarkAHershberger: [C: 032] SECURITY: Make token comparison constant time [core] (REL1_22) - 10https://gerrit.wikimedia.org/r/115912 (owner: 10Mglaser)
[21:04:06] <hashar>	 addshore: want some notification?
[21:04:15] <hashar>	 addshore: I mean by email
[21:04:21] <grrrit-wm>	 (03PS14) 10Reedy: Allow inclusion of additional fields [extensions/ContactPage] - 10https://gerrit.wikimedia.org/r/113883 
[21:04:23] <addshore>	 would be nice :P
[21:04:40] <grrrit-wm>	 (03CR) 10Reedy: [C: 04-1] Allow inclusion of additional fields [extensions/ContactPage] - 10https://gerrit.wikimedia.org/r/113883 (owner: 10Reedy)
[21:04:50] <grrrit-wm>	 (03CR) 10MarkAHershberger: [C: 032] SECURITY: Disallow non-whitelisted namespaces [core] (REL1_22) - 10https://gerrit.wikimedia.org/r/115921 (owner: 10Mglaser)
[21:04:52] <hoo>	 mglaser: Is Mark taking care of that now?
[21:05:48] <hashar>	 addshore: added
[21:05:50] <grrrit-wm>	 (03CR) 10MarkAHershberger: [C: 032] SECURITY: Disallow non-whitelisted namespaces [core] (REL1_19) - 10https://gerrit.wikimedia.org/r/115929 (owner: 10Mglaser)
[21:06:25] <grrrit-wm>	 (03CR) 10MarkAHershberger: [C: 032] SECURITY: Disallow non-whitelisted namespaces [core] (REL1_21) - 10https://gerrit.wikimedia.org/r/115925 (owner: 10Mglaser)
[21:06:57] <addshore>	 right then hashar just need to get the php-coveralls thing deployed and ammend my final patch then
[21:07:33] <grrrit-wm>	 (03Merged) 10jenkins-bot: SECURITY: Make token comparison constant time [core] (REL1_22) - 10https://gerrit.wikimedia.org/r/115912 (owner: 10Mglaser)
[21:08:12] <grrrit-wm>	 (03CR) 10MarkAHershberger: [C: 032] SECURITY: Make token comparison constant time [core] (REL1_19) - 10https://gerrit.wikimedia.org/r/115957 (owner: 10Mglaser)
[21:09:09] <grrrit-wm>	 (03Merged) 10jenkins-bot: SECURITY: Disallow non-whitelisted namespaces [core] (REL1_22) - 10https://gerrit.wikimedia.org/r/115921 (owner: 10Mglaser)
[21:10:07] <grrrit-wm>	 (03Merged) 10jenkins-bot: SECURITY: Disallow non-whitelisted namespaces [core] (REL1_19) - 10https://gerrit.wikimedia.org/r/115929 (owner: 10Mglaser)
[21:10:27] <grrrit-wm>	 (03CR) 10MarkAHershberger: [C: 032] SECURITY: Make token comparison constant time [core] (REL1_21) - 10https://gerrit.wikimedia.org/r/115914 (owner: 10Mglaser)
[21:10:39] <grrrit-wm>	 (03PS5) 10Addshore: DNM Send coverage info to Coveralls [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/115951 
[21:10:48] <addshore>	 hashar: ^^ now includes the token fetching
[21:11:39] <grrrit-wm>	 (03Merged) 10jenkins-bot: SECURITY: Disallow non-whitelisted namespaces [core] (REL1_21) - 10https://gerrit.wikimedia.org/r/115925 (owner: 10Mglaser)
[21:12:40] <grrrit-wm>	 (03Merged) 10jenkins-bot: SECURITY: Make token comparison constant time [core] (REL1_19) - 10https://gerrit.wikimedia.org/r/115957 (owner: 10Mglaser)
[21:13:39] <addshore>	 heh hashar phpunit segfaults on travis too
[21:13:45] <hashar>	 addshore: :-]
[21:15:11] <JeroenDeDauw>	 A me appeard!
[21:15:18] <addshore>	 too late JeroenDeDauw ;p
[21:15:28] <addshore>	 JeroenDeDauw: food? ;p
[21:15:36] <grrrit-wm>	 (03PS1) 10Hashar: Make tox shell wrapper a macro [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/115973 
[21:15:39] <grrrit-wm>	 (03PS1) 10Hashar: mw-tools-releng-tox-doc-publish [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/115974 
[21:15:50] <grrrit-wm>	 (03CR) 10Hashar: [C: 04-2] Make tox shell wrapper a macro [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/115973 (owner: 10Hashar)
[21:15:58] <grrrit-wm>	 (03CR) 10Hashar: [C: 04-2] mw-tools-releng-tox-doc-publish [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/115974 (owner: 10Hashar)
[21:16:07] <grrrit-wm>	 (03CR) 10Ssmith: [C: 032 V: 032] Inform Zuul about the FundraisingChart extension [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/115967 (owner: 10Mwalker)
[21:16:50] <grrrit-wm>	 (03CR) 10Ssmith: [C: 032] Add jobs for FundraisingChart extension [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/115968 (owner: 10Mwalker)
[21:17:27] <grrrit-wm>	 (03Merged) 10jenkins-bot: SECURITY: Make token comparison constant time [core] (REL1_21) - 10https://gerrit.wikimedia.org/r/115914 (owner: 10Mglaser)
[21:17:53] <JeroenDeDauw>	 addshore: yeah - my pancackes and fuit salad just arrived
[21:18:08] <grrrit-wm>	 (03PS1) 10Hashar: Make sure make-release use https git urls [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/115975 
[21:18:23] <JeroenDeDauw>	 addshore: to late for what?
[21:18:36] <addshore>	 turn coveralls on for mediawiki-core ;p
[21:18:40] <grrrit-wm>	 (03Abandoned) 10Mglaser: SECURITY: Disallow non-whitelisted namespaces [core] (REL1_19) - 10https://gerrit.wikimedia.org/r/115927 (owner: 10Mglaser)
[21:18:59] <mwalker>	 hashar, if you're going to be doing a zuul/jenkins update -- mind deploying https://gerrit.wikimedia.org/r/#/c/115968/ and https://gerrit.wikimedia.org/r/#/c/115967/ for me?
[21:20:31] <grrrit-wm>	 (03CR) 10Hashar: [C: 032] Make sure make-release use https git urls [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/115975 (owner: 10Hashar)
[21:21:06] <grrrit-wm>	 (03PS2) 10Hashar: Make sure make-release use https git urls [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/115975 
[21:21:19] <grrrit-wm>	 (03CR) 10Hashar: [C: 032] Make sure make-release use https git urls [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/115975 (owner: 10Hashar)
[21:21:21] * JeroenDeDauw  wonders if scrutinizer still bails out on core because it has over 9 million issues

[21:21:37] <addshore>	 JeroenDeDauw: hehe
[21:21:42] <hashar>	 :D
[21:21:45] <grrrit-wm>	 (03Merged) 10jenkins-bot: Make sure make-release use https git urls [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/115975 (owner: 10Hashar)
[21:21:52] <addshore>	 JeroenDeDauw: https://github.com/scrutinizer-ci/php-analyzer/pull/133
[21:22:19] <addshore>	 also JeroenDeDauw https://github.com/scrutinizer-ci/scrutinizer/issues/147
[21:22:34] <addshore>	 currently it taks them about 25 / 30 mins just to clone core before doing the analysis
[21:22:38] <grrrit-wm>	 (03PS1) 10Reedy: Fix number of parameters passed on recursive function call [core] - 10https://gerrit.wikimedia.org/r/115976 
[21:22:41] <addshore>	 but I spent some time talking to someone from them today :)
[21:22:59] <hashar>	 addshore: yeah they should use git-archive : -]
[21:23:12] <hashar>	 addshore: there is no point in fetching the whole repo unless they are reusing it 
[21:24:45] <addshore>	 hehe :)
[21:25:35] <addshore>	 its a shame the repo that actually has this bit of code in is private :<
[21:27:13] <addshore>	 hashar: https://gerrit.wikimedia.org/r/#/c/115947/ just got merged ;p
[21:27:56] <hashar>	 addshore: yeah andrew otto lovesss merging :]
[21:28:16] <hashar>	 addshore: going out to bed though so we will have to follow up tomorrow sorry
[21:28:25] <addshore>	 haha :) okay
[21:29:56] <addshore>	 hashar: you could always merge the final change and cross your fingers for the coverage job tonight ;p
[21:30:33] <JeroenDeDauw>	 addshore: :)
[21:32:01] <grrrit-wm>	 (03CR) 10Hashar: DNM Send coverage info to Coveralls (031 comment) [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/115951 (owner: 10Addshore)
[21:32:51] <hashar>	 addshore: you would want to make the coverall stuff a shell script in integration/jenkins.git that will be easier to amend / hack (i.e. no need to update the jenkins job)
[21:33:03] <addshore>	 will do :)
[21:35:02] <grrrit-wm>	 (03PS1) 10Reedy: Remove "required" messages. HTMLForm takes care of that with validation. [extensions/ContactPage] - 10https://gerrit.wikimedia.org/r/115977 
[21:35:38] <werdna>	 anomie: https://gerrit.wikimedia.org/r/#/c/110090/
[21:37:04] <grrrit-wm>	 (03PS1) 10Addshore: Add mw-send-to-coveralls script [integration/jenkins] - 10https://gerrit.wikimedia.org/r/115979 
[21:37:38] <grrrit-wm>	 (03PS2) 10Addshore: Add mw-send-to-coveralls script [integration/jenkins] - 10https://gerrit.wikimedia.org/r/115979 
[21:39:05] <grrrit-wm>	 (03PS1) 10Mglaser: Updated Release Notes and version number for 1.22.3 [core] (REL1_22) - 10https://gerrit.wikimedia.org/r/115980 
[21:39:40] <grrrit-wm>	 (03PS6) 10Addshore: DNM Send coverage info to Coveralls [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/115951 
[21:40:07] <grrrit-wm>	 (03CR) 10Reedy: Allow inclusion of additional fields (031 comment) [extensions/ContactPage] - 10https://gerrit.wikimedia.org/r/113883 (owner: 10Reedy)
[21:42:53] <grrrit-wm>	 (03PS2) 10Reedy: Remove "required" messages. HTMLForm takes care of that with validation. [extensions/ContactPage] - 10https://gerrit.wikimedia.org/r/115977 
[21:43:28] <grrrit-wm>	 (03CR) 10Mglaser: [C: 032 V: 032] "Need to merge in order to produce the tarball" [core] (REL1_22) - 10https://gerrit.wikimedia.org/r/115980 (owner: 10Mglaser)
[21:44:18] <grrrit-wm>	 (03PS1) 10Hashar: Update make-release phpunit path [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/115981 
[21:46:44] <grrrit-wm>	 (03CR) 10Martineznovo: "This is WORSE than the actual problem: fsockopen is disabled on many hosts for security reasons, where this code will break. And now there" [core] - 10https://gerrit.wikimedia.org/r/113038 (owner: 10Aaron Schulz)
[21:47:53] <jdlrobson>	 James_F: I took a look at trying to opt into the skin but there seems like there may be an issue with the hook https://www.mediawiki.org/w/index.php?title=Manual_talk:Hooks/UserSaveOptions
[21:49:04] <mglaser>	 hashar, are you working on the mediawiki-core-release job?
[21:49:25] <hashar>	 mglaser: yeah noticed is has been blatantly failing :D
[21:49:42] <hashar>	 mglaser: I fixed the repo it is cloning from and hopefully the phpunit call
[21:51:09] <grrrit-wm>	 (03PS1) 10Hashar: mediawiki-core-release can now run in parallel [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/115983 
[21:51:29] <hashar>	 mglaser: I have retriggered a random previous tag and the job pass now https://integration.wikimedia.org/ci/job/mediawiki-core-release/81/console :-]
[21:51:34] <hashar>	 mglaser: including phpunit tests!!!
[21:51:50] <hashar>	 mglaser: whenever a tag is pushed by hexmode that should trigger some jobs
[21:51:55] <hashar>	 we will see :]
[21:52:59] <James_F>	 jdlrobson: Fun. :-(
[21:53:05] <mglaser>	 hashar, very nice. Will push a tag in the next few seconds ;)
[21:54:06] <mglaser>	 hashar, tag pushed, job started!!
[21:54:20] <hexmode>	 \o/
[21:54:35] <hashar>	 addshore: php-coveralls is now deployed :-]
[21:54:46] <addshore>	 :P
[21:55:07] <hashar>	 mglaser: hexmode: once the job is done, please pay careful attention at the resulting code :-]
[21:55:11] <addshore>	 you know you want to just build the job and cross your fingers ;p
[21:55:16] <addshore>	 but night ;p :)
[21:55:56] <hashar>	 mglaser: hexmode: will have to make the cloning process faster somehow :-]
[21:56:18] <grrrit-wm>	 (03PS3) 10Bsitu: Re-arrange execution order in UUID::create() [extensions/Flow] - 10https://gerrit.wikimedia.org/r/115837 
[21:56:24] <hexmode>	 I already have 4 clones
[21:56:33] <hexmode>	 mglaser has one or two
[21:56:41] <hexmode>	 so we're on a roll!
[21:56:44] <grrrit-wm>	 (03CR) 10Hashar: [C: 032] Update make-release phpunit path [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/115981 (owner: 10Hashar)
[21:56:51] <grrrit-wm>	 (03CR) 10Hashar: [C: 032] mediawiki-core-release can now run in parallel [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/115983 (owner: 10Hashar)
[21:57:02] <grrrit-wm>	 (03Merged) 10jenkins-bot: Update make-release phpunit path [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/115981 (owner: 10Hashar)
[21:57:18] <grrrit-wm>	 (03Merged) 10jenkins-bot: mediawiki-core-release can now run in parallel [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/115983 (owner: 10Hashar)
[21:58:39] <sumanah>	 hi mglaser & hexmode! :) are either of you interested in today's RFC meeting? (in 2 hrs)
[21:59:47] <hexmode>	 sumanah: got too much happening that I'm missing out on.  I should come to the next one, though.
[21:59:52] <sumanah>	 ok
[22:00:10] <sumanah>	 hexmode: any RFCs in particular that you have authored or want to get feedback on soon?
[22:00:20] <hexmode>	 not atm
[22:01:27] <hexmode>	 I've got to respond to quim's gsoc prodding
[22:03:02] <hashar>	 1.22.3 apparently generated https://integration.wikimedia.org/ci/job/mediawiki-core-release/82/
[22:04:31] <mglaser>	 hashar yay!
[22:04:44] <hashar>	 gotta review it now :-D
[22:05:41] <mglaser>	 yes, that's the plan ;)
[22:07:36] <grrrit-wm>	 (03PS3) 10Addshore: Add mw-send-to-coveralls script [integration/jenkins] - 10https://gerrit.wikimedia.org/r/115979 
[22:08:28] <grrrit-wm>	 (03PS4) 10Addshore: Add mw-send-to-coveralls script [integration/jenkins] - 10https://gerrit.wikimedia.org/r/115979 
[22:09:26] <grrrit-wm>	 (03CR) 10Hashar: [C: 032] Add mw-send-to-coveralls script [integration/jenkins] - 10https://gerrit.wikimedia.org/r/115979 (owner: 10Addshore)
[22:09:29] <grrrit-wm>	 (03Merged) 10jenkins-bot: Add mw-send-to-coveralls script [integration/jenkins] - 10https://gerrit.wikimedia.org/r/115979 (owner: 10Addshore)
[22:12:04] <grrrit-wm>	 (03PS1) 10Hashar: chmod +x mw-send-to-coveralls.sh [integration/jenkins] - 10https://gerrit.wikimedia.org/r/115986 
[22:12:15] <grrrit-wm>	 (03CR) 10Hashar: [C: 032] chmod +x mw-send-to-coveralls.sh [integration/jenkins] - 10https://gerrit.wikimedia.org/r/115986 (owner: 10Hashar)
[22:12:18] <grrrit-wm>	 (03Merged) 10jenkins-bot: chmod +x mw-send-to-coveralls.sh [integration/jenkins] - 10https://gerrit.wikimedia.org/r/115986 (owner: 10Hashar)
[22:12:49] <huh>	 legoktm: 1. How is PS4 https://gerrit.wikimedia.org/r/#/c/104711/ ?
[22:13:06] <huh>	 2. What still needs to be done? https://gerrit.wikimedia.org/r/#/c/78946/
[22:17:49] <grrrit-wm>	 (03PS7) 10Hashar: DNM Send coverage info to Coveralls [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/115951 (owner: 10Addshore)
[22:18:04] <grrrit-wm>	 (03CR) 10Hashar: "fixed path to shell script (missing a s at the end)" [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/115951 (owner: 10Addshore)
[22:18:35] <grrrit-wm>	 (03PS1) 10Mglaser: Updated Release notes and version number for 1.21.6 [core] (REL1_21) - 10https://gerrit.wikimedia.org/r/115988 
[22:18:46] <grrrit-wm>	 (03CR) 10EBernhardson: [C: 032] Re-arrange execution order in UUID::create() [extensions/Flow] - 10https://gerrit.wikimedia.org/r/115837 (owner: 10Bsitu)
[22:19:40] <grrrit-wm>	 (03Merged) 10jenkins-bot: Re-arrange execution order in UUID::create() [extensions/Flow] - 10https://gerrit.wikimedia.org/r/115837 (owner: 10Bsitu)
[22:19:55] <sumanah>	 RFC meeting in about an hour and a half, in #wikimedia-office .
[22:21:00] <grrrit-wm>	 (03CR) 10Manybubbles: [C: 032] Remove dumb log message left over from debugging [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/115969 (owner: 10Manybubbles)
[22:21:10] <grrrit-wm>	 (03Merged) 10jenkins-bot: Remove dumb log message left over from debugging [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/115969 (owner: 10Manybubbles)
[22:21:21] <grrrit-wm>	 (03PS2) 10Bsitu: Cache the last revision of a collection [extensions/Flow] - 10https://gerrit.wikimedia.org/r/115828 
[22:24:18] <grrrit-wm>	 (03CR) 10Mglaser: [C: 032 V: 032] "Need to merge in order to produce the tarball" [core] (REL1_21) - 10https://gerrit.wikimedia.org/r/115988 (owner: 10Mglaser)
[22:25:03] <grrrit-wm>	 (03PS1) 10Hashar: Fix symlink not generated properly on Windows [integration/php-coveralls] - 10https://gerrit.wikimedia.org/r/115989 
[22:25:18] <grrrit-wm>	 (03CR) 10Hashar: [C: 032 V: 032] Fix symlink not generated properly on Windows [integration/php-coveralls] - 10https://gerrit.wikimedia.org/r/115989 (owner: 10Hashar)
[22:25:21] <grrrit-wm>	 (03CR) 10Addshore: ":D" [integration/php-coveralls] - 10https://gerrit.wikimedia.org/r/115989 (owner: 10Hashar)
[22:25:37] <grrrit-wm>	 (03CR) 10EBernhardson: Cache the last revision of a collection (031 comment) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/115828 (owner: 10Bsitu)
[22:29:37] <grrrit-wm>	 (03PS3) 10EBernhardson: Cache the last revision of a collection [extensions/Flow] - 10https://gerrit.wikimedia.org/r/115828 (owner: 10Bsitu)
[22:33:12] <grrrit-wm>	 (03CR) 10EBernhardson: [C: 032] Cache the last revision of a collection [extensions/Flow] - 10https://gerrit.wikimedia.org/r/115828 (owner: 10Bsitu)
[22:33:24] <grrrit-wm>	 (03Merged) 10jenkins-bot: Cache the last revision of a collection [extensions/Flow] - 10https://gerrit.wikimedia.org/r/115828 (owner: 10Bsitu)
[22:34:57] <grrrit-wm>	 (03PS1) 10Mglaser: Updated Release notes and version number for 1.19.12 [core] (REL1_19) - 10https://gerrit.wikimedia.org/r/115990 
[22:35:08] <grrrit-wm>	 (03PS1) 10Manybubbles: Hacky python script to reply production logs [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/115991 
[22:37:32] <grrrit-wm>	 (03CR) 10Hoo man: [C: 04-1] "also trailing spaces" (032 comments) [core] (REL1_19) - 10https://gerrit.wikimedia.org/r/115990 (owner: 10Mglaser)
[22:39:53] <grrrit-wm>	 (03CR) 10Manybubbles: "Not a good script, but it does work. Also, seems to have trouble with keeping up. It seems to go backwards in time." [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/115991 (owner: 10Manybubbles)
[22:43:19] <hashar>	 mglaser: hexmode I am heading to bed sorry. at least the job seems to be working now :]
[22:43:24] <hashar>	 have a good release!
[22:43:41] <mglaser>	 hashar, the script seems to be working fine. Thanks a lot!
[22:43:48] <hashar>	 \O/
[22:43:57] <grrrit-wm>	 (03CR) 10EBernhardson: [C: 04-1] Add preview of new comment to watchlist/rc/history (031 comment) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/115113 (owner: 10Matthias Mullie)
[22:45:27] <grrrit-wm>	 (03CR) 10PleaseStand: "> This is WORSE than the actual problem: fsockopen is disabled on many hosts for security reasons, where this code will break. And now the" (037 comments) [core] - 10https://gerrit.wikimedia.org/r/113038 (owner: 10Aaron Schulz)
[22:47:09] <grrrit-wm>	 (03PS2) 10Mglaser: Updated Release notes and version number for 1.19.12 [core] (REL1_19) - 10https://gerrit.wikimedia.org/r/115990 
[22:48:24] <mglaser>	 hoo, I updated the release notes
[22:48:35] <mglaser>	 could you have a look?
[22:48:59] <hoo>	 Looks good, still has trailing spaces, not sure we care about those in release notes
[22:49:23] <hoo>	 oh, wait
[22:50:04] <grrrit-wm>	 (03CR) 10Hoo man: [C: 04-1] "Still trailing white spaces" (031 comment) [core] (REL1_19) - 10https://gerrit.wikimedia.org/r/115990 (owner: 10Mglaser)
[22:50:21] <hoo>	 You had file twice in that sentence
[22:51:27] <grrrit-wm>	 (03PS3) 10EBernhardson: Add preview of new comment to watchlist/rc/history [extensions/Flow] - 10https://gerrit.wikimedia.org/r/115113 (owner: 10Matthias Mullie)
[22:52:13] <grrrit-wm>	 (03CR) 10EBernhardson: [C: 032] "PS3: updated 'summary' format to use rawParam and htmlspecialchars to prevent parsing as wikitext." [extensions/Flow] - 10https://gerrit.wikimedia.org/r/115113 (owner: 10Matthias Mullie)
[22:52:26] <grrrit-wm>	 (03Merged) 10jenkins-bot: Add preview of new comment to watchlist/rc/history [extensions/Flow] - 10https://gerrit.wikimedia.org/r/115113 (owner: 10Matthias Mullie)
[22:53:32] <grrrit-wm>	 (03PS3) 10Mglaser: Updated Release notes and version number for 1.19.12 [core] (REL1_19) - 10https://gerrit.wikimedia.org/r/115990 
[22:55:01] <grrrit-wm>	 (03CR) 10Hoo man: [C: 032] "I'm ok with this" [core] (REL1_19) - 10https://gerrit.wikimedia.org/r/115990 (owner: 10Mglaser)
[22:55:05] <hoo>	 there you go ;)
[22:55:08] <grrrit-wm>	 (03PS1) 10Jack Phoenix: Swap addOnloadHook to something that actually works. [extensions/CodeReview] - 10https://gerrit.wikimedia.org/r/115994 
[22:56:12] <mglaser>	 hoo, so I have to change the other versions release notes as well. They're already merged. What's the best way to do this? Commit separatel? Or can I still amend the changes?
[22:57:04] <hoo>	 mglaser: Once they're merged, you can't... you have to upload new changes for that
[22:57:19] <mglaser>	 fair enough ;)
[22:57:33] <grrrit-wm>	 (03Merged) 10jenkins-bot: Updated Release notes and version number for 1.19.12 [core] (REL1_19) - 10https://gerrit.wikimedia.org/r/115990 (owner: 10Mglaser)
[22:59:13] <grrrit-wm>	 (03CR) 10Bsitu: [C: 032] Add missing use statement and annotations [extensions/Flow] - 10https://gerrit.wikimedia.org/r/115528 (owner: 10EBernhardson)
[22:59:25] <grrrit-wm>	 (03Merged) 10jenkins-bot: Add missing use statement and annotations [extensions/Flow] - 10https://gerrit.wikimedia.org/r/115528 (owner: 10EBernhardson)
[23:02:42] <grrrit-wm>	 (03PS1) 10Addshore: Create symlink to vendor if non exists [integration/jenkins] - 10https://gerrit.wikimedia.org/r/115996 
[23:02:59] <grrrit-wm>	 (03CR) 10Hashar: "You will have to generate the jobs in Jenkins. You can follow the tutorial at https://www.mediawiki.org/wiki/Continuous_integration/Tutori" [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/115968 (owner: 10Mwalker)
[23:03:38] <grrrit-wm>	 (03CR) 10Bartosz Dziewoński: [C: 032] Swap addOnloadHook to something that actually works. [extensions/CodeReview] - 10https://gerrit.wikimedia.org/r/115994 (owner: 10Jack Phoenix)
[23:03:52] <grrrit-wm>	 (03Merged) 10jenkins-bot: Swap addOnloadHook to something that actually works. [extensions/CodeReview] - 10https://gerrit.wikimedia.org/r/115994 (owner: 10Jack Phoenix)
[23:04:01] <grrrit-wm>	 (03PS3) 10Bsitu: No need to call same function three times [extensions/Flow] - 10https://gerrit.wikimedia.org/r/115529 (owner: 10EBernhardson)
[23:05:45] <grrrit-wm>	 (03CR) 10Bsitu: [C: 032] No need to call same function three times [extensions/Flow] - 10https://gerrit.wikimedia.org/r/115529 (owner: 10EBernhardson)
[23:05:56] <grrrit-wm>	 (03Merged) 10jenkins-bot: No need to call same function three times [extensions/Flow] - 10https://gerrit.wikimedia.org/r/115529 (owner: 10EBernhardson)
[23:08:19] <grrrit-wm>	 (03CR) 10Hoo man: [C: 031] "Good to merge and deploy (which I can't)" [integration/jenkins] - 10https://gerrit.wikimedia.org/r/115996 (owner: 10Addshore)
[23:09:14] <mwalker>	 rdwrer, can I steal your brain for a second?
[23:10:03] <grrrit-wm>	 (03PS4) 10Reedy: Add messages for Trademark Licensing form for foundationwiki [extensions/WikimediaMessages] - 10https://gerrit.wikimedia.org/r/110243 
[23:10:41] <grrrit-wm>	 (03PS5) 10Reedy: Add messages for Trademark Licensing form for foundationwiki [extensions/WikimediaMessages] - 10https://gerrit.wikimedia.org/r/110243 
[23:10:43] <grrrit-wm>	 (03PS1) 10Mglaser: Updated Release notes [core] (REL1_21) - 10https://gerrit.wikimedia.org/r/115998 
[23:10:50] <grrrit-wm>	 (03PS6) 10Reedy: Add messages for Trademark Licensing form for foundationwiki [extensions/WikimediaMessages] - 10https://gerrit.wikimedia.org/r/110243 
[23:10:54] <grrrit-wm>	 (03CR) 10Cmcmahon: [C: 032] "lgtm" [integration/jenkins] - 10https://gerrit.wikimedia.org/r/115996 (owner: 10Addshore)
[23:11:19] <hoo>	 mglaser: That has the error again
[23:11:26] <mglaser>	 hoo, could you look at https://gerrit.wikimedia.org/r/115998
[23:11:57] <hoo>	 mglaser: It says files ... files again
[23:12:15] <mglaser>	 ah
[23:12:18] <mglaser>	 sec
[23:13:57] <grrrit-wm>	 (03PS2) 10Mglaser: Updated Release notes [core] (REL1_21) - 10https://gerrit.wikimedia.org/r/115998 
[23:14:12] <mglaser>	 hoo, better?
[23:15:09] <grrrit-wm>	 (03CR) 10Hoo man: [C: 032] "Nice" [core] (REL1_21) - 10https://gerrit.wikimedia.org/r/115998 (owner: 10Mglaser)
[23:15:15] <hoo>	 Yep, that one's good :)
[23:15:42] <mglaser>	 thx
[23:16:07] <mglaser>	 can you look at one more (I need about 2 minutes to prepare)
[23:16:18] <hoo>	 sure
[23:18:28] <grrrit-wm>	 (03CR) 10PleaseStand: "Posting some comments I had saved as a draft." (034 comments) [core] - 10https://gerrit.wikimedia.org/r/105138 (owner: 10Skizzerz)
[23:19:41] <grrrit-wm>	 (03Merged) 10jenkins-bot: Updated Release notes [core] (REL1_21) - 10https://gerrit.wikimedia.org/r/115998 (owner: 10Mglaser)
[23:25:59] <grrrit-wm>	 (03PS1) 10Mglaser: Updated release notes [core] (REL1_22) - 10https://gerrit.wikimedia.org/r/116000 
[23:26:08] <mglaser>	 hoo, there you go
[23:26:23] <mglaser>	 happy to hear your comments
[23:28:08] <hoo>	 looking
[23:28:51] <hoo>	 mglaser: files ... files again :D
[23:29:39] <mglaser>	 Argh!
[23:29:47] <mglaser>	 it's late... sry
[23:30:19] <hoo>	 mglaser: Will be away for a few seconds, as I'll change some network stuff
[23:30:21] <mglaser>	 hoo, anything else?
[23:30:24] <mglaser>	 k
[23:30:28] <hoo>	 Don't think so
[23:31:23] <grrrit-wm>	 (03PS2) 10Mglaser: Updated release notes [core] (REL1_22) - 10https://gerrit.wikimedia.org/r/116000 
[23:37:25] <hoo>	 mglaser: Accidently pulled my power plug while changing my network plug... :P
[23:39:02] <grrrit-wm>	 (03CR) 10Hoo man: [C: 032] Updated release notes [core] (REL1_22) - 10https://gerrit.wikimedia.org/r/116000 (owner: 10Mglaser)
[23:41:04] <mglaser>	 hoo ;)
[23:42:41] <grrrit-wm>	 (03Merged) 10jenkins-bot: Updated release notes [core] (REL1_22) - 10https://gerrit.wikimedia.org/r/116000 (owner: 10Mglaser)
[23:54:25] <grrrit-wm>	 (03CR) 10EBernhardson: [C: 031] Allow extension of post interaction links (031 comment) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/115552 (owner: 10Wctaiwan)
[23:55:56] <sumanah>	 https://www.mediawiki.org/wiki/Architecture_meetings/RFC_review_2014-02-27 discussion (we hope) of styling in templates, grid system, scoping site CSS, and similar UX/UI styling RFCs and progress - #wikimedia-office in a few min