[00:05:36] <grrrit-wm>	 (03CR) 10Mattflaschen: [C: 04-1] "Doesn't work, since mediawiki.mixins.rotation.less now depends on mediawiki.mixins.less, but doesn't import it." [core] - 10https://gerrit.wikimedia.org/r/115377 (owner: 10Prtksxna)
[00:05:53] <grrrit-wm>	 (03CR) 10TTO: "I agree that this should be reverted." [core] - 10https://gerrit.wikimedia.org/r/115206 (owner: 10Bartosz Dziewoński)
[00:10:14] <grrrit-wm>	 (03PS1) 10Gergő Tisza: Add JSDuck role to MediaWiki-Vagrant [vagrant] - 10https://gerrit.wikimedia.org/r/115534 
[00:11:49] <huh>	 Withoutaname: hi
[00:25:06] <grrrit-wm>	 (03CR) 10Chad: [C: 031] "This is fine by me and sorts out basically all of the issues I see. Feel free to remove the WIP and self-merge when you're ready for this " [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/115215 (owner: 10Manybubbles)
[00:25:58] <grrrit-wm>	 (03CR) 10Mattflaschen: "> What if we moved prefix handling Config, but make it agnostic about the actual prefix to use? Then GlobalVarConfig could do it's wg-ugli" [core] - 10https://gerrit.wikimedia.org/r/109850 (owner: 10Ori.livneh)
[00:39:35] <grrrit-wm>	 (03PS6) 10Manybubbles: WIP:1.0 updates [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/115215 
[00:45:06] <grrrit-wm>	 (03PS2) 10Anomie: Remove STRAIGHT_JOIN from ApiQueryLogEvents [core] - 10https://gerrit.wikimedia.org/r/115381 
[00:49:09] <grrrit-wm>	 (03CR) 10Springle: [C: 032] Remove STRAIGHT_JOIN from ApiQueryLogEvents [core] - 10https://gerrit.wikimedia.org/r/115381 (owner: 10Anomie)
[00:50:08] <grrrit-wm>	 (03PS17) 10Bsitu: Add diff view of changes to board header [extensions/Flow] - 10https://gerrit.wikimedia.org/r/109431 
[00:50:38] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] Add diff view of changes to board header [extensions/Flow] - 10https://gerrit.wikimedia.org/r/109431 (owner: 10Bsitu)
[00:51:46] <AaronSchulz>	 springle: I wonder if the change tag table will need a timestamp field someday
[00:52:35] <grrrit-wm>	 (03PS4) 10MaxSem: WIP: Elasticsearch support [extensions/GeoData] - 10https://gerrit.wikimedia.org/r/115413 
[00:52:39] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] WIP: Elasticsearch support [extensions/GeoData] - 10https://gerrit.wikimedia.org/r/115413 (owner: 10MaxSem)
[00:53:03] <MaxSem>	 ^d & manybubbles|away, how does ^^ look? (until // TODO: below)
[00:53:34] <AaronSchulz>	 if we programmatically made sure it equaled the revision/logging/whatever field and added a redundant equality to the WHERE (or ON clause) that could hint equality propagation and let mysql use change tag indexes to resolve the ORDER BYs right? (assume we had ct_tag,ct_timestamp indexed)
[00:53:44] <^d>	 MaxSem: Looking
[00:54:20] <AaronSchulz>	 springle: does equality propagation help with ORDER BY? At least it could in theory.
[00:54:35] <grrrit-wm>	 (03PS18) 10Bsitu: Add diff view of changes to board header [extensions/Flow] - 10https://gerrit.wikimedia.org/r/109431 
[00:55:34] <grrrit-wm>	 (03PS2) 10EBernhardson: [WIP] Combined board history [extensions/Flow] - 10https://gerrit.wikimedia.org/r/115532 
[00:55:37] <grrrit-wm>	 (03PS2) 10EBernhardson: Sort the combined header+topic revisions after merging [extensions/Flow] - 10https://gerrit.wikimedia.org/r/115531 
[00:55:40] <grrrit-wm>	 (03PS2) 10EBernhardson: Split reusable parts out of ContributionsQuery [extensions/Flow] - 10https://gerrit.wikimedia.org/r/115530 
[00:55:43] <grrrit-wm>	 (03PS2) 10EBernhardson: No need to call same function three times [extensions/Flow] - 10https://gerrit.wikimedia.org/r/115529 
[00:55:46] <grrrit-wm>	 (03PS2) 10EBernhardson: Add missing use statement and annotations [extensions/Flow] - 10https://gerrit.wikimedia.org/r/115528 
[00:57:58] <springle>	 AaronSchulz: yes, may be worth it, however may require a distinct switch to order by the ct field. EP won't cut it there (i think)
[00:58:16] <springle>	 have to try that
[00:59:31] <AaronSchulz>	 let me know if you check...maybe make a bug :)
[01:01:34] <grrrit-wm>	 (03CR) 10Manybubbles: [C: 04-1] "Bool filter for the win. Reading material if you want it:" (037 comments) [extensions/GeoData] - 10https://gerrit.wikimedia.org/r/115413 (owner: 10MaxSem)
[01:04:36] <^d>	 MaxSem: On the right track. manybubbles|away left comments.
[01:05:56] <grrrit-wm>	 (03PS4) 10Bsitu: Add new Hook 'SendWatchlistEmailNotification' [core] - 10https://gerrit.wikimedia.org/r/114682 
[01:06:58] <grrrit-wm>	 (03Abandoned) 10Bsitu: Remove namespace restriction [extensions/Echo] - 10https://gerrit.wikimedia.org/r/114627 (owner: 10Bsitu)
[01:07:40] <MaxSem>	 thanks!
[01:08:12] <grrrit-wm>	 (03CR) 10Chad: [C: 032] Add new Hook 'SendWatchlistEmailNotification' [core] - 10https://gerrit.wikimedia.org/r/114682 (owner: 10Bsitu)
[01:11:43] <grrrit-wm>	 (03Merged) 10jenkins-bot: Add new Hook 'SendWatchlistEmailNotification' [core] - 10https://gerrit.wikimedia.org/r/114682 (owner: 10Bsitu)
[01:14:55] <grrrit-wm>	 (03PS3) 10Bsitu: Prevent double email notifications on talk page edit [extensions/Echo] - 10https://gerrit.wikimedia.org/r/114683 
[01:22:33] <grrrit-wm>	 (03PS1) 10Wctaiwan: Allow extension of post interaction links [extensions/Flow] - 10https://gerrit.wikimedia.org/r/115552 
[01:45:08] <grrrit-wm>	 (03PS1) 10Aaron Schulz: Removed pointless cache bypass in Swift backend [core] - 10https://gerrit.wikimedia.org/r/115553 
[01:46:45] <grrrit-wm>	 (03PS1) 10Aaron Schulz: Removed pointless cache bypass in Swift backend [core] (wmf/1.23wmf15) - 10https://gerrit.wikimedia.org/r/115554 
[01:47:31] <grrrit-wm>	 (03CR) 10Aaron Schulz: [C: 032] Removed pointless cache bypass in Swift backend [core] (wmf/1.23wmf15) - 10https://gerrit.wikimedia.org/r/115554 (owner: 10Aaron Schulz)
[01:50:53] <grrrit-wm>	 (03Merged) 10jenkins-bot: Removed pointless cache bypass in Swift backend [core] (wmf/1.23wmf15) - 10https://gerrit.wikimedia.org/r/115554 (owner: 10Aaron Schulz)
[01:54:34] <grrrit-wm>	 (03PS1) 10Awjrichards: Set wgCookieDomain to host name [vagrant] - 10https://gerrit.wikimedia.org/r/115555 
[01:55:27] <grrrit-wm>	 (03CR) 10Legoktm: Allow extension of post interaction links (033 comments) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/115552 (owner: 10Wctaiwan)
[01:57:54] <James_F>	 bd808: BTW, re. deployments, there's a theoretically-entirely-not-hairy-but deployment on Monday afternoon that RoanKattouw_away will handle.
[01:58:35] <James_F>	 bd808: Per Greg's orders, notifying you. :-)
[01:58:44] <bd808>	 James_F: Thanks for the heads up.
[01:59:01] <bd808>	 Roan can probably handle things better than me :)
[01:59:28] <James_F>	 bd808: (Just enabling the PHP side of Parsoid for all public wikis; it's possible that it'll overload the Parsoid cluster, in which case we'll revert, but we're not expecting anything to be noticable).
[01:59:36] * James_F  grins.

[02:05:38] <MaxSem>	 ^d, manybubbles|away - ewww, looks like I'll need to use nested docs to retrieve only coordinates I need
[02:06:10] <manybubbles|away>	 MaxSem: we've been trying to avoid nested docs
[02:06:37] <manybubbles|away>	 we use highlighting to get what we need but I don't know if it'd work for you
[02:06:48] <manybubbles|away>	 might be stuck with nested docs
[02:06:50] <MaxSem>	 essentially, my problem is http://elasticsearch-users.115913.n3.nabble.com/Can-ES-return-only-the-part-of-an-array-that-match-the-query-td4026958.html
[02:07:31] <manybubbles|away>	 yeah
[02:07:42] <manybubbles|away>	 I know the issue
[02:07:57] <MaxSem>	 or search will result in hundreds of coordinates when only one is needed:(
[02:10:24] <grrrit-wm>	 (03PS5) 10MaxSem: WIP: Elasticsearch support [extensions/GeoData] - 10https://gerrit.wikimedia.org/r/115413 
[02:10:54] <manybubbles|away>	 hmmmmm.......   I wonder if I can do something about that in ES - I'lll have a think
[02:11:05] <MaxSem>	 is ^^ better btw?
[02:15:29] <grrrit-wm>	 (03CR) 10Manybubbles: WIP: Elasticsearch support (031 comment) [extensions/GeoData] - 10https://gerrit.wikimedia.org/r/115413 (owner: 10MaxSem)
[02:15:32] <manybubbles|away>	 better
[02:15:34] <manybubbles|away>	 !
[02:15:34] <wm-bot>	 There is no such key, you probably want to try: !?>, !@, !@param, !1.17, !1.18, !2.0, !3x, !42, !a, !abusefilter, !access, !ack, !actionpaths, !actions, !adminsettings, !allmessages, !allowoverride, !amend, !ampersand, !analytics, !ancient, !anglebrackets, !announce, !annoyinglittlebug, !anonnotice, !answer, !api, !audit, !auth, !authentication, !autoblock, !autoconfirmed, !autoload, !autothumb, !backup, !bestcase, !blacklist, !blame, !blank, !bleedingedge, !blocking, !boilerplate, !bom, !bot, !botbrain2, !botnoob, !branch, !branchpoints, !browser, !bugsearch, !bugzilla, !bunching, !bureaucracy, !bzapi, !bzsource, !cache, !captcha, !cat, !categories, !centralauth, !chansearch, !chanspam, !charinsert, !cheatsheet, !checkuser, !ci, !cia, !cite, !class, !cloak, !cms, !code, !codereview, !collapse, !colon, !commit, !commons, !compare, !compression, !config, !console, !cookies, !cooluris, !copyhelp, !copying, !copyinghelp, !copytemplates, !core, !corehack, !corn, !createandpromote, !createpage, !credit, !cron, !css, !csshideheader, !csv2wp, !damneditcount, !db, !dbtable, !debbug, !debianubuntu, !debug, !defaultsettings, !defenestrate, !deleteuser, !deployments, !details, !developer, !developers, !devsecurity, !diff3, !dismissablesitenotice, !displaytitle, !documentation, !doesntwork, !domdocument, !downgrade, !download, !doxygen, !dpl, !draft, !dump, !dumphtml, !easy, !echo, !editbuttons, !editing, !edittoken, !email, !emailconfirmed, !enableapi, !enotif, !enwp, !errors, !es, !etherpad, !events, !evilglobals, !exclamation, !export, !exporttemplate, !extensiondistributor, !extensionmatrix, !extensions, !externalauth, !externaleditor, !externalimages, !extranamespace, !f5, !fail, !false, !faq, !feature, !feeds, !file, !filecache, !filepermissions, !filesize, !filetype, !fileurl, !firebug, !flash, !footer, !foreignfilerepos, !fu, !gadget, !gadgets, !gallery, !gerritapi, !gerritdocs, !gerriterror, !gerrithelp, !gerritkeys, !gerritsearch, !gethelp, !gfi, !git, !git-access, !gitaccount, !gitauthor, !gitcheat, !gitemail, !gitrepo, !git-review, !giturl, !gnu, !google, !googleanalytics, !googleit, !grep, !gsocapp, !gsod, !hacker, !HAL, !hdss, !help, !helpfor, !hetdeploy, !hiddencategories, !hidetabs, !hidetoc, !highlight, !hooks, !hosting, !howto, !html, !html9, !humor, !i18n, !iamabot, !icon, !ie6, !iframe, !iis, !iis404, !imabot, !imageauth, !imagelink, !imagemagic, !imagemap, !images, !img_auth, !import, !important, !importhelp, !importimages, !importsources, !info, !infobox, !inputbox, !install, !installlinux, !installmacosx, !instantcommons, !interface, !internalapi, !interwiki, !invalidupload, !is, !itsalwaysbugzilla, !javascript, !jobqueue, !jquery, !labs, !langlinks, !lazy, !ldap, !ldapdebug, !ldapsupport, !line, !links, !list, !listinfo, !lists, !localhost, !lockdown, !logo, !lowercase, !lsb, !lua, !lucene, !magicwords, !mailarchive, !mainpage, !mainpagetitle, !man, !manapi, !maps, !maxlag, !mediawiki, !meetings, !memcached, !memory, !migrate, !mime, !moderation, !moin, !monday, !moo, !morbo, !move, !mssql, !multiplecommits, !multiplewiki, !mwbot, !mw-config, !mwdumper, !mwhelp, !mysql, !namespaces, !networkauth, !newgit, !newusergroup, !newwindow, !next, !nightly, !nofollow, !noob, !noshell, !nosql, !not, !notes, !nowiki, !nuke, !nullpath, !numberedparams, !ogg, !omgevilbug, !openid, !opw, !oracle, !oversight, !packagefix, !padindex, !pagecss, !paranoid, !parser, !parserconf, !parserfunctions, !passthru, !passwordsql, !patch, !pdhelp, !performance, !petan, !phase3, !php, !php4, !php531, !phpinfo, !phpmyadmin, !phpshell, !phpsucks, !ping, !pipetrick, !plainlinks, !player, !poem, !ppp, !prefsrant, !preventaccess, !profiling, !protect, !protocols, !punehackathon, !purge, !putty, !pywikipediabot, !query, !queue, !rangeblocking, !rawr, !rcbot, !recaptcha, !redirect, !redlinks, !refresh, !releasedate, !renameuser, !repeat, !reportbug, !reports, !requestcontext, !research, !resetpass, !resetpassword, !resourceloader, !rest, !revdelete, !revert, !reviewqueue, !rfc, !rights, !rightssql, !robots, !rollback, !rt, !rtam, !rtfm, !ruby, !safemode, !sandbox, !sarcasm, !sb, !scap, !scarytranscluding, !schema, !search, !secrets, !security, !selfmerge, !selinux, !semantichelp, !semanticmediawiki, !sequel, !serversuperglobal, !session, !sharedlogins, !shell, !shellrequest, !shorturls, !sitemap, !sitenotice, !siwae, !sm, !smtp, !smw, !sofixit, !songs, !sop, !sortkey, !sorttable, !sourceforge, !spam, !specialpages, !sqlite, !sqllog, !sqlsearch, !srv193, !start, !stfu, !stringfunctions, !stroopwafels, !subpages, !subst, !suggest, !sul, !sumanah, !supported, !svg, !svnauthor, !svnprops, !svn-rev, !svnsearch, !syntax, !syntaxhighlight, !sysadmin, !t_paamayim_nekudotayim, !tabcompletion, !table, !tables.sql, !tabs, !tag, !tautology, !telepathy, !temp, !templates, !test, !test2, !testing, !tests, !testswarm, !testwiki, !thankyou, !the_mask, !thisbotisnotstupid, !thisisalongkey, !threads, !thumb, !tias, !tidy, !tidyforidiots, !timezone, !toc, !toolserver, !tooquiet, !transclusion, !translatewiki, !true, !ts, !tso, !tss, !tunemysql, !twn, !ui, !umask, !undo, !unicode_test, !uninstall, !unreviewedcode, !update.php, !upgrade, !upload, !uploadbyurl, !useful, !useragent, !userapproval, !variables, !vector, !version, !versionlifecycle, !viewvc, !votes, !vulnerability, !wallofshame, !webinspector, !webrequest, !webscale, !welcome, !wf, !wiki, !wiki2pdf, !wiki2xml, !wikia, !wikiacode, !wikibugs, !wikidata, !wikieditor, !wikimania, !wikimedia, !wikipmediawiki, !wip, !wmf, !wmf-deployment, !wmo, !worstcase, !wtf, !wysiwyg, !xampp, !xkcd, !xml, !yoda, !sanitizer, !index.php, !wikipedia, !pastelocalsettings, !flow, !opsschool, !vagrant, !packages, !subversion, !1.20, !patrol, !wm-bot, !wp, !memoserv, !submodules, !cs, !5.4, !$wgServer, !visualeditor, !master, !unicorn, !rewriteproblems, !parsoid, !pong, !adsense, !github, !sourcecode, !technews, !reboot, !hook, !seen, !tryflow, !sidebar, !htmlform, !bzqs, !apiinternal, !apiclient, !pastebin, !dirtydiffs, !parsoid-web, !parsoid-test, !link, !smart, !autopromote, !vebug, !VE-table, !veq, !maintenance, !bugsong, !ext, !tea, !ask, !jobs, !farm, !newbug, !templateproblems, !mw, !blink, !logs, !jsduck, !packagessimple, !skins, !skinning, !job, !codesearch, !ie, !bribe, !gitblit, !ajax, !wg, !stash, !csv2wiki, !repos, !sleep, !jjb, !card, !ping2, !wm-bot-ping, !IE10, !jenkins, !log, !ulsfo, !lts, !python, !lmgtfy, !gci, !roadmap, !e_test, !htmllogs, !kiwix, !fileupload, !math, !stalemaintpages, !lst, !fishbowl, !sal, !wptemplates, !nyan, !speed, !xy, !support, !hss, !dontdothat, !1.21, !1.22, !rebase, !collapsible, !mleb, !technext, !workforus, !autowikibrowser, !flaggedrevs, !namespaceprotection, !, !!, !oauth, 
[02:15:44] <manybubbles|away>	 thanks bot
[02:15:56] <manybubbles|away>	 I bet we could do something with source filtering
[02:16:00] <manybubbles|away>	 I could use it too
[02:23:04] <grrrit-wm>	 (03PS1) 10Wctaiwan: Flow Thanks [extensions/Thanks] - 10https://gerrit.wikimedia.org/r/115557 
[02:24:35] <grrrit-wm>	 (03CR) 10MaxSem: WIP: Elasticsearch support (031 comment) [extensions/GeoData] - 10https://gerrit.wikimedia.org/r/115413 (owner: 10MaxSem)
[02:38:47] <grrrit-wm>	 (03CR) 10MaxSem: WIP: Elasticsearch support (031 comment) [extensions/GeoData] - 10https://gerrit.wikimedia.org/r/115413 (owner: 10MaxSem)
[02:50:24] <grrrit-wm>	 (03CR) 10Mwalker: [C: 032] Add test for ThrottledError exception [core] - 10https://gerrit.wikimedia.org/r/115421 (owner: 10Addshore)
[02:52:37] <grrrit-wm>	 (03CR) 10Mwalker: [C: 032] Add test for BadTitleError exception [core] - 10https://gerrit.wikimedia.org/r/115422 (owner: 10Addshore)
[03:11:16] <grrrit-wm>	 (03PS1) 10EBernhardson: Remove unnecessary branching in validation [extensions/Flow] - 10https://gerrit.wikimedia.org/r/115564 
[03:58:38] <grrrit-wm>	 (03PS5) 10Greg Grossmeier: Dev and deploy flowchart using blockdiag [tools/releng] - 10https://gerrit.wikimedia.org/r/115425 
[05:00:49] <Gloria>	 TimStarling: Hi.
[05:01:07] <TimStarling>	 hi
[05:01:29] <Gloria>	 TimStarling: Did you have any thoughts about people using Special page transclusion as an API in Scribunto/Lua modules?
[05:01:40] <Gloria>	 It seems pretty rough.
[05:02:05] <TimStarling>	 sounds pretty ugly'
[05:02:17] <TimStarling>	 and prone to bitrot
[05:02:20] <Gloria>	 I posted to wikitech-l about it. It'd be nice to nip it in the bud.
[05:02:24] <Gloria>	 Yeah, but what's the alternative?
[05:03:21] <Gloria>	 There was talk about a JSON Lua module, I think.
[05:03:30] <Gloria>	 That might help.
[05:04:37] <Gloria>	 Also, I keep meaning to remind you to update your English Wikipedia user page. It's slightly out of date. :-)
[05:04:44] <TimStarling>	 well, the alternative is to not do that thing
[05:05:08] <Gloria>	 I think the history suggests that people will do what works.
[05:05:21] <Gloria>	 For now, {{Special:ListFiles/}} is a decent enough API to get a user's uploads.
[05:05:31] <Gloria>	 And {{Special:PrefixIndex/}} is a decent enough API to get pages by prefix.
[05:05:41] <Gloria>	 I'm sure someone has hacked up {{#categorytree:}} to get category membership...
[05:05:58] <Amgine>	 api.php ftw.
[05:09:21] <Gloria>	 http://lists.wikimedia.org/pipermail/wikitech-l/2014-February/074589.html has the two examples I've come across.
[05:31:18] <grrrit-wm>	 (03PS19) 10Bsitu: Add diff view of changes to board header [extensions/Flow] - 10https://gerrit.wikimedia.org/r/109431 
[05:35:28] <grrrit-wm>	 (03CR) 10Legoktm: [C: 04-1] "Good work so far!" (0310 comments) [extensions/Thanks] - 10https://gerrit.wikimedia.org/r/115557 (owner: 10Wctaiwan)
[05:40:40] <grrrit-wm>	 (03CR) 10PleaseStand: "> I agree that this should be reverted." [core] - 10https://gerrit.wikimedia.org/r/115206 (owner: 10Bartosz Dziewoński)
[05:51:00] <grrrit-wm>	 (03CR) 10Prtksxna: "@superm401 Alright, should I make a separate animations.mixins file and keep everything there? The transform-rotate mixin could be used at" [core] - 10https://gerrit.wikimedia.org/r/115377 (owner: 10Prtksxna)
[06:06:18] <grrrit-wm>	 (03PS1) 10TTO: Revert "DefaultSettings.php: Remove $wgPasswordSenderName" [core] - 10https://gerrit.wikimedia.org/r/115574 
[06:06:30] <grrrit-wm>	 (03PS2) 10TTO: Revert "DefaultSettings.php: Remove $wgPasswordSenderName" [core] - 10https://gerrit.wikimedia.org/r/115574 
[06:15:40] <grrrit-wm>	 (03Abandoned) 10Adamw: Example fix for implicitly declared globals [core] - 10https://gerrit.wikimedia.org/r/76208 (owner: 10Adamw)
[06:18:26] <grrrit-wm>	 (03PS3) 10Adamw: (bug 56849) Pass true oldid for atomic page save [core] - 10https://gerrit.wikimedia.org/r/94584 
[06:21:46] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] (bug 56849) Pass true oldid for atomic page save [core] - 10https://gerrit.wikimedia.org/r/94584 (owner: 10Adamw)
[06:38:42] <grrrit-wm>	 (03PS1) 10EBernhardson: [SCHEMA CHANGE] Drop the definition model [extensions/Flow] - 10https://gerrit.wikimedia.org/r/115576 
[06:38:49] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] [SCHEMA CHANGE] Drop the definition model [extensions/Flow] - 10https://gerrit.wikimedia.org/r/115576 (owner: 10EBernhardson)
[06:42:33] <grrrit-wm>	 (03CR) 10Mattflaschen: [C: 04-1] "Works good overall. I tested with long messages at page load (requiring it to always be expanded), and with resizing." (036 comments) [extensions/GettingStarted] - 10https://gerrit.wikimedia.org/r/115176 (owner: 10Phuedx)
[06:45:43] <grrrit-wm>	 (03CR) 10PleaseStand: Avoid showing crazy staleness times at ActiveUsers (031 comment) [core] - 10https://gerrit.wikimedia.org/r/115522 (owner: 10Aaron Schulz)
[06:45:47] <sumanah>	 hey ori 
[06:46:10] <ori>	 hello
[06:46:35] <sumanah>	 ori: happy late February. there's old grey ice on the sidewalks here
[06:48:01] <ori>	 i can imagine. happy late february to you too.
[06:49:27] <grrrit-wm>	 (03CR) 10Aaron Schulz: Avoid showing crazy staleness times at ActiveUsers (031 comment) [core] - 10https://gerrit.wikimedia.org/r/115522 (owner: 10Aaron Schulz)
[06:52:37] <superm401>	 ori, you there?
[06:53:15] <ori>	 superm401: half. is this about the vagrant box download thing?
[06:54:15] <superm401>	 ori, yep.
[06:54:36] <superm401>	 And the rest of my comment at https://gerrit.wikimedia.org/r/#/c/115114/1
[06:55:04] <superm401>	 I would also like if you review the XDebug one when you get a chance: https://gerrit.wikimedia.org/r/#/c/113519/
[06:55:12] <ori>	 it was a bad, sloppy commit
[06:55:23] <ori>	 mine, i mean; not the xdebug change
[06:55:29] <ori>	 i should just revert it
[06:55:51] <superm401>	 ori, I haven't tested out the shared folders enough to know if that part is sound.
[06:55:55] <grrrit-wm>	 (03CR) 10Bencmq: Allow extension of post interaction links (031 comment) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/115552 (owner: 10Wctaiwan)
[06:56:02] <ori>	 neither have i :)
[06:56:09] <superm401>	 :)
[06:56:18] <superm401>	 However, it would definitely be good to revert the other parts, especially the 2 GB.
[06:56:23] <ori>	 nah, i kid. it's reasonably well-tested. but it should not have been accompanied by some unrelated detritus
[06:56:31] <superm401>	 Though if you want to just keep the box download part, that's okay.
[06:56:43] <superm401>	 1.2.6 is reasonable, as long as it's documented (I did a followup for that).
[06:57:28] <superm401>	 After all the latest is 1.4.3.
[06:58:15] <superm401>	 ori, I'm off for tonight, but I can review any followup to that if you want.
[06:59:36] <ori>	 superm401: I'll revert and submit changes separately. And yeah, reviews would be very helpful. Thanks! I'll take a look at the xdebug change again.
[07:00:55] <grrrit-wm>	 (03CR) 10Ori.livneh: "As I conceded on IRC, this was a bad, sloppy commit. I'll revert it for now and resubmit it as a series of discrete patches." [vagrant] - 10https://gerrit.wikimedia.org/r/115114 (owner: 10Ori.livneh)
[07:01:01] <grrrit-wm>	 (03PS1) 10Ori.livneh: Revert "Use NFS by default on non-Windows hosts" [vagrant] - 10https://gerrit.wikimedia.org/r/115579 
[07:02:17] <grrrit-wm>	 (03CR) 10Ori.livneh: [C: 032] Revert "Use NFS by default on non-Windows hosts" [vagrant] - 10https://gerrit.wikimedia.org/r/115579 (owner: 10Ori.livneh)
[07:02:20] <grrrit-wm>	 (03Merged) 10jenkins-bot: Revert "Use NFS by default on non-Windows hosts" [vagrant] - 10https://gerrit.wikimedia.org/r/115579 (owner: 10Ori.livneh)
[07:04:17] <grrrit-wm>	 (03CR) 10Ori.livneh: [C: 032] Removed pointless cache bypass in Swift backend [core] - 10https://gerrit.wikimedia.org/r/115553 (owner: 10Aaron Schulz)
[07:06:29] <grrrit-wm>	 (03PS11) 10Aaron Schulz: Moved job running via $wgJobRunRate to a special API [core] - 10https://gerrit.wikimedia.org/r/113038 
[07:07:20] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] Moved job running via $wgJobRunRate to a special API [core] - 10https://gerrit.wikimedia.org/r/113038 (owner: 10Aaron Schulz)
[07:07:57] <grrrit-wm>	 (03Merged) 10jenkins-bot: Removed pointless cache bypass in Swift backend [core] - 10https://gerrit.wikimedia.org/r/115553 (owner: 10Aaron Schulz)
[07:11:33] <grrrit-wm>	 (03PS12) 10Aaron Schulz: Moved job running via $wgJobRunRate to a special API [core] - 10https://gerrit.wikimedia.org/r/113038 
[09:18:46] <grrrit-wm>	 (03CR) 10Krinkle: "@AaronSchulz : "[[gerrit:65162]]" doesn't work in a commit message. Aside from it being preferred practice to use hashes instead of numeri" [core] - 10https://gerrit.wikimedia.org/r/108188 (owner: 10Nullzero)
[09:23:07] <grrrit-wm>	 (03CR) 10Matthias Mullie: [C: 032] Add diff view of changes to board header [extensions/Flow] - 10https://gerrit.wikimedia.org/r/109431 (owner: 10Bsitu)
[09:23:20] <grrrit-wm>	 (03Merged) 10jenkins-bot: Add diff view of changes to board header [extensions/Flow] - 10https://gerrit.wikimedia.org/r/109431 (owner: 10Bsitu)
[09:37:09] <grrrit-wm>	 (03CR) 10Parent5446: [C: 032] "Why the hell was a variable that was deprecated in *this version* removed in the first place?" [core] - 10https://gerrit.wikimedia.org/r/115574 (owner: 10TTO)
[09:40:52] <grrrit-wm>	 (03Merged) 10jenkins-bot: Revert "DefaultSettings.php: Remove $wgPasswordSenderName" [core] - 10https://gerrit.wikimedia.org/r/115574 (owner: 10TTO)
[09:44:19] <hashar>	 good morning
[09:45:37] <Withoutaname>	 thanks to Tim Landscheidt
[09:45:46] <Withoutaname>	 does he have a nick here?
[09:46:20] <hashar>	 Withoutaname: yes :]
[09:48:13] <hashar>	 Withoutaname: his nickname is scfc_de , he is in #wikimedia-labs right now
[09:48:20] <grrrit-wm>	 (03CR) 10Phe: [C: 031] Increases size of the Special:IndexPages input [extensions/ProofreadPage] - 10https://gerrit.wikimedia.org/r/115197 (owner: 10Tpt)
[09:50:27] <grrrit-wm>	 (03CR) 10Phe: [C: 031] Fix fatal error when usebetatoolbar option was activated and not showtoolbar [extensions/ProofreadPage] - 10https://gerrit.wikimedia.org/r/115205 (owner: 10Tpt)
[09:54:03] <grrrit-wm>	 (03CR) 10Tpt: [C: 032] "Reviewed by Phe" [extensions/ProofreadPage] - 10https://gerrit.wikimedia.org/r/115197 (owner: 10Tpt)
[09:54:12] <grrrit-wm>	 (03Merged) 10jenkins-bot: Increases size of the Special:IndexPages input [extensions/ProofreadPage] - 10https://gerrit.wikimedia.org/r/115197 (owner: 10Tpt)
[09:57:49] <grrrit-wm>	 (03CR) 10Mglaser: "I have tested it on IPv4 with various hostnames, IP-Adresses and non-standard ports. For IPv6, I checked the values of host and port, but " [core] - 10https://gerrit.wikimedia.org/r/109634 (owner: 10Mglaser)
[09:59:32] <grrrit-wm>	 (03Abandoned) 10Hashar: Blockdiag integration example [tools/releng] - 10https://gerrit.wikimedia.org/r/115408 (owner: 10Hashar)
[10:31:25] <grrrit-wm>	 (03CR) 10Tpt: [C: 032] "Reviewed by Phe" [extensions/ProofreadPage] - 10https://gerrit.wikimedia.org/r/115205 (owner: 10Tpt)
[10:31:33] <grrrit-wm>	 (03Merged) 10jenkins-bot: Fix fatal error when usebetatoolbar option was activated and not showtoolbar [extensions/ProofreadPage] - 10https://gerrit.wikimedia.org/r/115205 (owner: 10Tpt)
[10:40:29] <grrrit-wm>	 (03CR) 10Matthias Mullie: Makefile command to run phpstorm inspections (033 comments) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/114701 (owner: 10EBernhardson)
[10:40:35] <grrrit-wm>	 (03PS4) 10Matthias Mullie: Makefile command to run phpstorm inspections [extensions/Flow] - 10https://gerrit.wikimedia.org/r/114701 (owner: 10EBernhardson)
[11:21:50] <grrrit-wm>	 (03PS6) 10Hashar: Dev and deploy flowchart using blockdiag [tools/releng] - 10https://gerrit.wikimedia.org/r/115425 (owner: 10Greg Grossmeier)
[11:21:52] <grrrit-wm>	 (03PS2) 10Hashar: Boilerplate to get blockdiag doc generated with sphinx [tools/releng] - 10https://gerrit.wikimedia.org/r/115407 
[11:21:54] <grrrit-wm>	 (03PS1) 10Hashar: Tweak css for blockdiag so img can be larger [tools/releng] - 10https://gerrit.wikimedia.org/r/115595 
[11:24:17] <grrrit-wm>	 (03CR) 10Hashar: [C: 031] "Greg, I have moved your files under /source/devdeployflow so the diag can be generated directly by sphinx when running 'tox'." [tools/releng] - 10https://gerrit.wikimedia.org/r/115425 (owner: 10Greg Grossmeier)
[11:34:27] <grrrit-wm>	 (03PS1) 10Rillke: Add cc-IGO (internal governed organization) [extensions/WikimediaMessages] - 10https://gerrit.wikimedia.org/r/115597 
[11:37:45] <grrrit-wm>	 (03PS2) 10Rillke: Add cc-IGO (international governed organization) [extensions/WikimediaMessages] - 10https://gerrit.wikimedia.org/r/115597 
[11:44:53] <grrrit-wm>	 (03PS1) 10Hashar: mw-tools-release-tox-doc [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/115598 
[11:45:16] <grrrit-wm>	 (03PS1) 10Hashar: Trigger mw-tools-release-tox-doc [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/115599 
[11:45:28] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] Trigger mw-tools-release-tox-doc [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/115599 (owner: 10Hashar)
[11:45:34] <grrrit-wm>	 (03CR) 10Hashar: [C: 032] mw-tools-release-tox-doc [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/115598 (owner: 10Hashar)
[11:45:38] <grrrit-wm>	 (03CR) 10Hashar: [C: 032] Trigger mw-tools-release-tox-doc [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/115599 (owner: 10Hashar)
[11:45:42] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] Trigger mw-tools-release-tox-doc [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/115599 (owner: 10Hashar)
[11:45:52] <grrrit-wm>	 (03Merged) 10jenkins-bot: mw-tools-release-tox-doc [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/115598 (owner: 10Hashar)
[11:48:09] <grrrit-wm>	 (03PS2) 10Hashar: Trigger mw-tools-release-tox-doc [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/115599 
[11:48:28] <grrrit-wm>	 (03CR) 10Hashar: [C: 032] Trigger mw-tools-release-tox-doc [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/115599 (owner: 10Hashar)
[11:48:32] <grrrit-wm>	 (03Merged) 10jenkins-bot: Trigger mw-tools-release-tox-doc [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/115599 (owner: 10Hashar)
[11:50:53] <grrrit-wm>	 (03PS1) 10Hashar: Jenkins validation (DO NOT SUBMIT) [tools/releng] - 10https://gerrit.wikimedia.org/r/115600 
[11:51:54] <grrrit-wm>	 (03PS1) 10Hashar: Revert "Trigger mw-tools-release-tox-doc" [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/115601 
[11:52:00] <grrrit-wm>	 (03CR) 10Hashar: [C: 032] Revert "Trigger mw-tools-release-tox-doc" [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/115601 (owner: 10Hashar)
[11:52:04] <grrrit-wm>	 (03Merged) 10jenkins-bot: Revert "Trigger mw-tools-release-tox-doc" [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/115601 (owner: 10Hashar)
[11:53:03] <grrrit-wm>	 (03PS1) 10Hashar: rename mediawiki/tools/{release,releng} [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/115602 
[11:53:59] <grrrit-wm>	 (03CR) 10Hashar: [C: 032] rename mediawiki/tools/{release,releng} [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/115602 (owner: 10Hashar)
[11:54:17] <grrrit-wm>	 (03Merged) 10jenkins-bot: rename mediawiki/tools/{release,releng} [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/115602 (owner: 10Hashar)
[11:56:05] <grrrit-wm>	 (03PS1) 10Hashar: Triggers mw-tools-releng-tox-doc [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/115604 
[11:56:14] <grrrit-wm>	 (03CR) 10Hashar: [C: 032] Triggers mw-tools-releng-tox-doc [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/115604 (owner: 10Hashar)
[11:56:27] <grrrit-wm>	 (03Merged) 10jenkins-bot: Triggers mw-tools-releng-tox-doc [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/115604 (owner: 10Hashar)
[11:57:48] <grrrit-wm>	 (03PS2) 10Hashar: Jenkins validation (DO NOT SUBMIT) [tools/releng] - 10https://gerrit.wikimedia.org/r/115600 
[11:58:12] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] Jenkins validation (DO NOT SUBMIT) [tools/releng] - 10https://gerrit.wikimedia.org/r/115600 (owner: 10Hashar)
[12:30:50] <grrrit-wm>	 (03PS1) 10Lekshmi: editintro given a css class of its own [core] - 10https://gerrit.wikimedia.org/r/115607 
[12:44:19] <grrrit-wm>	 (03PS4) 10Matthias Mullie: Makefile command to check i18n for matching en and qqq keys [extensions/Flow] - 10https://gerrit.wikimedia.org/r/114702 (owner: 10EBernhardson)
[12:45:09] <grrrit-wm>	 (03CR) 10Matthias Mullie: [C: 032] "Pushed anew, without dependant patch (which is was not really dependant on) so we can merge it now" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/114702 (owner: 10EBernhardson)
[12:45:27] <grrrit-wm>	 (03Merged) 10jenkins-bot: Makefile command to check i18n for matching en and qqq keys [extensions/Flow] - 10https://gerrit.wikimedia.org/r/114702 (owner: 10EBernhardson)
[13:02:11] <grrrit-wm>	 (03PS1) 10Addshore: Expand MWException tests [core] - 10https://gerrit.wikimedia.org/r/115608 
[13:04:47] <grrrit-wm>	 (03PS6) 10Addshore: Remove unused stuff from tests [core] - 10https://gerrit.wikimedia.org/r/109470 
[14:05:32] <grrrit-wm>	 (03PS1) 10Matthias Mullie: Fix tree_orig_create_time length [extensions/Flow] - 10https://gerrit.wikimedia.org/r/115619 
[14:05:36] <grrrit-wm>	 (03PS1) 10Matthias Mullie: Prefix tables with /*_*/ [extensions/Flow] - 10https://gerrit.wikimedia.org/r/115620 
[14:05:38] <grrrit-wm>	 (03PS1) 10Matthias Mullie: Add $tablesUsed for test [extensions/Flow] - 10https://gerrit.wikimedia.org/r/115621 
[14:51:17] <grrrit-wm>	 (03CR) 10Matthias Mullie: No need to load workflow in formatters (033 comments) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/112846 (owner: 10EBernhardson)
[14:54:31] <grrrit-wm>	 (03PS1) 10Manybubbles: Allow configuration of periodic task interval [core] - 10https://gerrit.wikimedia.org/r/115630 
[14:58:14] <grrrit-wm>	 (03CR) 10Manybubbles: WIP: Elasticsearch support (031 comment) [extensions/GeoData] - 10https://gerrit.wikimedia.org/r/115413 (owner: 10MaxSem)
[14:58:38] <grrrit-wm>	 (03CR) 10Manybubbles: WIP: Elasticsearch support (031 comment) [extensions/GeoData] - 10https://gerrit.wikimedia.org/r/115413 (owner: 10MaxSem)
[14:59:20] <grrrit-wm>	 (03PS1) 10Ragesoss: Show the right username in the confirmation for removing articles [extensions/EducationProgram] - 10https://gerrit.wikimedia.org/r/115632 
[15:00:16] <MaxSem>	 good morning manybubbles
[15:00:29] <manybubbles>	 good afternoon!
[15:02:26] <grrrit-wm>	 (03CR) 10Bartosz Dziewoński: [C: 032] Put callback function within class in SiteConfigurationTest [core] - 10https://gerrit.wikimedia.org/r/109640 (owner: 10Addshore)
[15:02:52] <grrrit-wm>	 (03PS7) 10Manybubbles: WIP:1.0 updates [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/115215 
[15:06:07] <grrrit-wm>	 (03Merged) 10jenkins-bot: Put callback function within class in SiteConfigurationTest [core] - 10https://gerrit.wikimedia.org/r/109640 (owner: 10Addshore)
[15:27:21] <grrrit-wm>	 (03CR) 10Aklapper: "Lekshmi: Any context *why* this change is proposed? I admit I am confused why I was added as a potential reviewer." [core] - 10https://gerrit.wikimedia.org/r/115607 (owner: 10Lekshmi)
[15:31:16] <grrrit-wm>	 (03CR) 10Bartosz Dziewoński: [C: 04-1] "This patch obviously doesn't work and causes a fatal. Please test the code before pushing it for review." [core] - 10https://gerrit.wikimedia.org/r/115607 (owner: 10Lekshmi)
[15:33:51] <grrrit-wm>	 (03PS6) 10MaxSem: WIP: Elasticsearch support [extensions/GeoData] - 10https://gerrit.wikimedia.org/r/115413 
[15:37:51] <grrrit-wm>	 (03PS2) 10Lekshmi: editintro given a css class of its own [core] - 10https://gerrit.wikimedia.org/r/115607 
[15:37:54] <MaxSem>	 manybubbles, so what should I do with multiple coordinates? why you don't like nested docs
[15:37:55] <MaxSem>	 ?
[15:38:14] <manybubbles>	 MaxSem: I suppose nested docs is the thing
[15:38:28] <manybubbles>	 we've been avoiding them (for redirects) because each nested doc costs memory
[15:38:41] <manybubbles>	 the nesting relationship has to be kept in memory
[15:38:56] <manybubbles>	 and there are other funky restrictions like nested docs having to be on the same shard as the parent
[15:39:15] <manybubbles>	 but we don't have anything better for you
[15:39:25] <MaxSem>	 my nested docs aren't large
[15:39:42] <MaxSem>	 thought there can be a load of them
[15:40:04] <manybubbles>	 not on the same scale as redirects i ho[e
[15:40:06] <manybubbles>	 hope
[15:40:12] <manybubbles>	 I mean, some pages will have a ton
[15:40:17] <manybubbles>	 but, like how many are we talking about total?
[15:41:09] <MaxSem>	 manybubbles, ~1.5M geo tags on enwiki total, several pages come close to the limit of 2000 coords/page
[15:41:30] <manybubbles>	 should be ok
[15:41:39] <manybubbles>	 If I know Elasticsearch they keep the links pretty small
[15:41:45] <manybubbles>	 so we're talking only a couple of megs to maintain that
[15:42:05] <manybubbles>	 so probably ok
[15:45:35] <grrrit-wm>	 (03CR) 10Bartosz Dziewoński: [C: 04-1] editintro given a css class of its own [core] - 10https://gerrit.wikimedia.org/r/115607 (owner: 10Lekshmi)
[15:51:17] <grrrit-wm>	 (03PS2) 10Addshore: Expand MWException tests [core] - 10https://gerrit.wikimedia.org/r/115608 
[16:02:43] <grrrit-wm>	 (03PS2) 10Anomie: API: Make more continuations unique [core] - 10https://gerrit.wikimedia.org/r/103589 
[16:05:22] <grrrit-wm>	 (03CR) 10Krinkle: [C: 04-1] "Untested, glanced over code." (0331 comments) [core] - 10https://gerrit.wikimedia.org/r/104318 (owner: 10EBernhardson)
[16:07:50] <grrrit-wm>	 (03CR) 10Krinkle: [C: 04-1] Uninstall GetHumanTimestamp hook for testing core (031 comment) [core] - 10https://gerrit.wikimedia.org/r/99349 (owner: 10saper)
[16:09:21] <grrrit-wm>	 (03PS2) 10Krinkle: PathRouter: Fix documentation typo [core] - 10https://gerrit.wikimedia.org/r/115403 
[16:11:53] <grrrit-wm>	 (03CR) 10Aklapper: [C: 04-1] "Please always test patches before committing them. See https://www.mediawiki.org/wiki/How_to_become_a_MediaWiki_hacker#Set_up_your_environ" [core] - 10https://gerrit.wikimedia.org/r/115607 (owner: 10Lekshmi)
[16:21:38] <grrrit-wm>	 (03CR) 10Phuedx: "This works nicely. I've got one question about the use of single quotes, which'll probably boil to style." (031 comment) [vagrant] - 10https://gerrit.wikimedia.org/r/115429 (owner: 10Mattflaschen)
[16:25:17] <grrrit-wm>	 (03PS2) 10Phuedx: Make the toolbar respond to a content overflow [extensions/GettingStarted] - 10https://gerrit.wikimedia.org/r/115176 
[16:30:40] <grrrit-wm>	 (03CR) 10Phuedx: Make the toolbar respond to a content overflow (035 comments) [extensions/GettingStarted] - 10https://gerrit.wikimedia.org/r/115176 (owner: 10Phuedx)
[16:52:53] <Krinkle>	 ori: I just shaved off 4kb off of every commonswiki and wikidata page view :)
[16:54:14] <Krinkle>	 using proper unescaped unicode json for wpAvailableLanguages.js
[16:54:19] <Krinkle>	 https://commons.wikimedia.org/w/index.php?title=MediaWiki:Common.js&action=history
[16:54:27] <Krinkle>	 https://www.wikidata.org/w/index.php?title=MediaWiki:Common.js&action=history
[16:59:38] <Isarra>	 Neat.
[17:00:57] <grrrit-wm>	 (03PS17) 10Daniel Kinzler: Introducing TitleValue [core] - 10https://gerrit.wikimedia.org/r/106517 
[17:06:06] <Nemo_bis>	 Even better would be making ULS work for anons, of course
[17:08:37] <grrrit-wm>	 (03PS1) 10Umherirrender: Add a 'revdelete-selected-file' message on Special:RevisionDelete [core] - 10https://gerrit.wikimedia.org/r/115640 
[17:13:24] <grrrit-wm>	 (03PS2) 10Krinkle: [WIP] resourceloader: Fix broken 'skinStyles' loop in file module getModifiedTime [core] - 10https://gerrit.wikimedia.org/r/112837 
[17:13:58] <grrrit-wm>	 (03CR) 10Krinkle: "Need a fix for this soon. Since this code specific spot of the code is untestable right now, I'll create a follow-up draft for the test an" [core] - 10https://gerrit.wikimedia.org/r/112837 (owner: 10Krinkle)
[17:18:19] <grrrit-wm>	 (03PS8) 10Manybubbles: 1.0 updates [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/115215 
[17:21:48] <grrrit-wm>	 (03PS3) 10Umherirrender: Split revdelete-text on Special:RevisionDelete for each type [core] - 10https://gerrit.wikimedia.org/r/115426 
[17:23:00] <grrrit-wm>	 (03CR) 10Umherirrender: "Patch Set 3: Changed type from image to file, both words are already mixed on that page, so new message keys can use file here." [core] - 10https://gerrit.wikimedia.org/r/115426 (owner: 10Umherirrender)
[17:23:52] <grrrit-wm>	 (03PS1) 10Andrew Bogott: Add puppetcopy and puppetcopyregion args to createInstance. [extensions/OpenStackManager] - 10https://gerrit.wikimedia.org/r/115644 
[17:24:19] <grrrit-wm>	 (03PS18) 10Daniel Kinzler: Introducing TitleValue [core] - 10https://gerrit.wikimedia.org/r/106517 
[17:24:29] <grrrit-wm>	 (03CR) 10Andrew Bogott: [C: 032 V: 032] Add puppetcopy and puppetcopyregion args to createInstance. [extensions/OpenStackManager] - 10https://gerrit.wikimedia.org/r/115644 (owner: 10Andrew Bogott)
[17:25:08] <grrrit-wm>	 (03CR) 10Manybubbles: [C: 032] "Made some minor changes after Chad gave it his blessing so self merging so we get on Beta sooner rather than later." [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/115215 (owner: 10Manybubbles)
[17:25:25] <grrrit-wm>	 (03Merged) 10jenkins-bot: 1.0 updates [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/115215 (owner: 10Manybubbles)
[17:26:13] <DanielK_WMDE>	 manybubbles, ^demon|away, brion, TimStarling, anomie: new version of TitleValue is up.
[17:26:32] <brion>	 woot
[17:26:40] <DanielK_WMDE>	 https://gerrit.wikimedia.org/r/106517 
[17:26:50] * brion  bookmarks for later reading

[17:27:20] <DanielK_WMDE>	 just give +2, no need for reading :P
[17:27:28] <addshore>	 xD
[17:28:02] <addshore>	 is anyone around that is in the Admin group for wikimedia on github?
[17:28:19] <DanielK_WMDE>	 brion maybe?
[17:28:25] <brion>	 addshore: what can i do for ya
[17:30:05] <addshore>	 hmm actually I have just noticed an issue and now dont need anything :D
[17:30:13] <addshore>	 though I will probably be poking again in a few days ;p
[17:30:13] <brion>	 heh :D
[17:30:17] <brion>	 ok
[17:31:00] <brion>	 ok i better get going to the office
[17:31:02] <grrrit-wm>	 (03CR) 10Greg Grossmeier: [C: 032 V: 032] "Thanks!" [tools/releng] - 10https://gerrit.wikimedia.org/r/115425 (owner: 10Greg Grossmeier)
[17:37:37] <grrrit-wm>	 (03CR) 10Greg Grossmeier: [C: 032 V: 032] "Yep." [tools/releng] - 10https://gerrit.wikimedia.org/r/115407 (owner: 10Hashar)
[17:46:57] <grrrit-wm>	 (03PS3) 10Daniel Kinzler: Refactor SpecialCategories [core] - 10https://gerrit.wikimedia.org/r/107842 
[17:47:09] <DanielK_WMDE>	 \o/
[17:50:22] <grrrit-wm>	 (03PS1) 10Manybubbles: README updates [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/115649 
[17:50:57] <grrrit-wm>	 (03CR) 10Manybubbles: [C: 032] ""Just" a readme update so pretty safe to self +2 with Chad on vacation." [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/115649 (owner: 10Manybubbles)
[17:51:15] <grrrit-wm>	 (03Merged) 10jenkins-bot: README updates [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/115649 (owner: 10Manybubbles)
[17:51:32] <grrrit-wm>	 (03CR) 10Hashar: "greg-g: that one is to make the image to overflow and take more space than the browser window :-]" [tools/releng] - 10https://gerrit.wikimedia.org/r/115595 (owner: 10Hashar)
[17:51:36] <grrrit-wm>	 (03PS2) 10EBernhardson: [SCHEMA CHANGE] Drop the definition model [extensions/Flow] - 10https://gerrit.wikimedia.org/r/115576 
[17:51:43] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] [SCHEMA CHANGE] Drop the definition model [extensions/Flow] - 10https://gerrit.wikimedia.org/r/115576 (owner: 10EBernhardson)
[17:52:04] <grrrit-wm>	 (03PS3) 10Krinkle: qunit macro: Make log/ directory writable instead of just the file [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/95309 
[17:53:36] <se4598>	 legoktm: you here?
[17:54:10] <grrrit-wm>	 (03CR) 10Krinkle: "Needs rebase with conflict resolution. Depends on I8c892abc46ed57." [integration/jenkins] - 10https://gerrit.wikimedia.org/r/95311 (owner: 10Krinkle)
[17:57:59] <grrrit-wm>	 (03CR) 10Krinkle: "I disagree, since the readability goes both ways (some of the arrays re-use old variables, this way they're all together). But if you pref" [core] - 10https://gerrit.wikimedia.org/r/111962 (owner: 10Krinkle)
[17:58:41] <grrrit-wm>	 (03CR) 10Anomie: [C: 032] Support interwiki searches in API [core] - 10https://gerrit.wikimedia.org/r/112913 (owner: 10Chad)
[17:59:52] <grrrit-wm>	 (03PS3) 10EBernhardson: [SCHEMA CHANGE] Drop the definition model [extensions/Flow] - 10https://gerrit.wikimedia.org/r/115576 
[17:59:58] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] [SCHEMA CHANGE] Drop the definition model [extensions/Flow] - 10https://gerrit.wikimedia.org/r/115576 (owner: 10EBernhardson)
[18:03:01] <grrrit-wm>	 (03PS20) 10Inchikutty: Embedding Static Map to UploadWizard [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/107892 
[18:04:00] <grrrit-wm>	 (03Merged) 10jenkins-bot: Support interwiki searches in API [core] - 10https://gerrit.wikimedia.org/r/112913 (owner: 10Chad)
[18:06:08] <grrrit-wm>	 (03PS4) 10EBernhardson: [SCHEMA CHANGE] Drop the definition model [extensions/Flow] - 10https://gerrit.wikimedia.org/r/115576 
[18:06:20] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] [SCHEMA CHANGE] Drop the definition model [extensions/Flow] - 10https://gerrit.wikimedia.org/r/115576 (owner: 10EBernhardson)
[18:07:00] <grrrit-wm>	 (03CR) 10Inchikutty: "Sorry for being late.( Experiencing Internet connectivity issues.)" [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/107892 (owner: 10Inchikutty)
[18:07:11] <Nemo_bis>	 thanks anomie 
[18:08:34] <grrrit-wm>	 (03PS17) 10Jeroen De Dauw: Make it possible for extensions to specify which version of MediaWiki they support via Composer. [core] - 10https://gerrit.wikimedia.org/r/105092 
[18:22:13] <grrrit-wm>	 (03CR) 10EBernhardson: "hmm, we should be able to get this working on osx but i know nothing about it." [extensions/Flow] - 10https://gerrit.wikimedia.org/r/114701 (owner: 10EBernhardson)
[18:27:21] <grrrit-wm>	 (03CR) 10Bsitu: No need to load workflow in formatters (031 comment) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/112846 (owner: 10EBernhardson)
[18:31:04] <grrrit-wm>	 (03PS1) 10Manybubbles: Remove Elastica submodule [extensions/Elastica] - 10https://gerrit.wikimedia.org/r/115654 
[18:31:06] <grrrit-wm>	 (03PS1) 10Manybubbles: Squash master to REL1_22 [extensions/Elastica] - 10https://gerrit.wikimedia.org/r/115655 
[18:31:28] <grrrit-wm>	 (03Abandoned) 10Manybubbles: Remove Elastica submodule [extensions/Elastica] - 10https://gerrit.wikimedia.org/r/115654 (owner: 10Manybubbles)
[18:31:32] <grrrit-wm>	 (03Abandoned) 10Manybubbles: Squash master to REL1_22 [extensions/Elastica] - 10https://gerrit.wikimedia.org/r/115655 (owner: 10Manybubbles)
[18:32:56] <grrrit-wm>	 (03PS1) 10Manybubbles: Remove Elastica submodule [extensions/Elastica] (REL1_22) - 10https://gerrit.wikimedia.org/r/115656 
[18:32:58] <grrrit-wm>	 (03PS1) 10Manybubbles: Squash master to REL1_22 [extensions/Elastica] (REL1_22) - 10https://gerrit.wikimedia.org/r/115657 
[18:34:43] <grrrit-wm>	 (03CR) 10Manybubbles: [C: 04-1] "-1 until I test with Cirrus REL1_22" [extensions/Elastica] (REL1_22) - 10https://gerrit.wikimedia.org/r/115656 (owner: 10Manybubbles)
[18:34:47] <grrrit-wm>	 (03CR) 10Manybubbles: [C: 04-1] "-1 until I test with Cirrus REL1_22" [extensions/Elastica] (REL1_22) - 10https://gerrit.wikimedia.org/r/115657 (owner: 10Manybubbles)
[18:46:53] <grrrit-wm>	 (03PS5) 10EBernhardson: [SCHEMA CHANGE] Drop the definition model [extensions/Flow] - 10https://gerrit.wikimedia.org/r/115576 
[18:47:03] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] [SCHEMA CHANGE] Drop the definition model [extensions/Flow] - 10https://gerrit.wikimedia.org/r/115576 (owner: 10EBernhardson)
[18:50:46] <aude>	 greg-g: around?
[18:50:55] <greg-g>	 yeah, for 10 minutes :)
[18:51:17] <aude>	 we'd like to deploy small fix which affects display of references on wikidata
[18:51:20] <aude>	 https://gerrit.wikimedia.org/r/#/c/115590/
[18:51:38] <aude>	 looks like there is open time to do that?
[18:52:11] <grrrit-wm>	 (03PS6) 10EBernhardson: [SCHEMA CHANGE] Drop the definition model [extensions/Flow] - 10https://gerrit.wikimedia.org/r/115576 
[18:52:19] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] [SCHEMA CHANGE] Drop the definition model [extensions/Flow] - 10https://gerrit.wikimedia.org/r/115576 (owner: 10EBernhardson)
[18:52:49] <greg-g>	 aude: lightning deploy?
[18:52:54] <addshore>	 :>
[18:52:55] <greg-g>	 ugh, that's late for you
[18:52:56] <greg-g>	 :/
[18:53:05] <tonythomas>	 paravoid: Hi ! you around ?
[18:53:20] <paravoid>	 I am but I'm a bit busy atm; what's up?
[18:53:28] <aude>	 greg-g:  it's a bit late but can work
[18:53:32] <greg-g>	 k
[18:53:38] <greg-g>	 let's do that if that's ok
[18:53:43] <aude>	 ok
[18:53:45] <greg-g>	 ya'll ok doing it yourselves?
[18:53:56] <aude>	 i sorted out ssh / gerrit so can do it
[18:54:05] <greg-g>	 cool
[18:54:10] <grrrit-wm>	 (03PS7) 10EBernhardson: [SCHEMA CHANGE] Drop the definition model [extensions/Flow] - 10https://gerrit.wikimedia.org/r/115576 
[18:54:14] <aude>	 as long as someone is around in case i have trouble with it still
[18:54:18] <greg-g>	 nice thing about LD is that others will be around to help if need be
[18:54:22] <greg-g>	 :) :)
[18:54:24] <aude>	 perfect
[18:54:35] <grrrit-wm>	 (03PS1) 10Cmcmahon: Replace fragile checks with checks for spinner on save [extensions/Flow] - 10https://gerrit.wikimedia.org/r/115659 
[18:54:54] <grrrit-wm>	 (03CR) 10Cmcmahon: [V: 032] Replace fragile checks with checks for spinner on save [extensions/Flow] - 10https://gerrit.wikimedia.org/r/115659 (owner: 10Cmcmahon)
[19:02:55] <jgonera>	 I'm trying to enable profiling on a vagrant instance, but it does not work. I was trying to follow http://www.mediawiki.org/wiki/Manual:How_to_debug and http://www.mediawiki.org/wiki/Manual:Profileinfo.php
[19:03:28] <jgonera>	 no matter where I put $wgEnableProfileInfo = true; http://127.0.0.1:8080/profileinfo.php gives me a 404
[19:03:54] <grrrit-wm>	 (03PS1) 10Aude: Update Wikidata build, fix display of references [core] (wmf/1.23wmf15) - 10https://gerrit.wikimedia.org/r/115662 
[19:04:24] <jgonera>	 awjr, do you have any experience with profiling mw?
[19:04:39] <awjr>	 jgonera: a little but not in vagrant
[19:04:55] <jgonera>	 awjr, should not be relevant, I just want to make the profiler work
[19:05:18] <awjr>	 let's see, i havent done it in a while
[19:05:57] <grrrit-wm>	 (03CR) 10Aude: "shall deploy this during lightning deploy" [core] (wmf/1.23wmf15) - 10https://gerrit.wikimedia.org/r/115662 (owner: 10Aude)
[19:07:16] <awjr>	 wow some of that documentation is really outdated
[19:08:19] <jgonera>	 yeah, it seems so...
[19:08:40] <awjr>	 jgonera: are you wanting to log profile info to the db?
[19:09:04] <jgonera>	 awjr, I don't really care where it ends up, I just want to see it ;)
[19:10:35] <awjr>	 jgonera: ok, if you have $wgEnableProfileInfo = true and something set for $wgDebugLogFile, i think you'll see profile info show up in the debug log file
[19:11:27] <awjr>	 jgonera: i think htat's the most straightforward way to do it
[19:11:44] <jgonera>	 where, by default, is that file?
[19:11:53] <jgonera>	 oh wait
[19:11:58] <jgonera>	 ok, that's not a bool
[19:12:14] <awjr>	 jgonera: correct, there is no default location
[19:12:21] <awjr>	 the default is an empty string
[19:12:34] <awjr>	 so you'll need to give it a fiel path
[19:12:36] <awjr>	 *file path
[19:12:59] <awjr>	 you may need to touch the file or otherwise make sure the file will be writable
[19:14:25] <jgonera>	 I think I got it ;)
[19:14:27] <jgonera>	 thanks awjr 
[19:14:32] <awjr>	 \o/
[19:15:27] <awjr>	 np jgonera
[19:18:19] <Nikerabbit>	 brion: let me know what you need
[19:19:02] <brion>	 Nikerabbit: i'll whip up the config settings later today, i'll need you to review and merge them when you have a chance and make sure it works :D
[19:21:39] <Nikerabbit>	 brion: sure, like last time? Is tomorrow okay?
[19:21:46] <grrrit-wm>	 (03PS16) 10Bsitu: No need to load workflow in formatters [extensions/Flow] - 10https://gerrit.wikimedia.org/r/112846 (owner: 10EBernhardson)
[19:21:47] <brion>	 Nikerabbit: tomorrow would be perfect yeah
[19:28:10] <Nemo_bis>	 jgonera: did you see my reply on json i18n?
[19:28:41] <jgonera>	 Nemo_bis, I guess I haven't
[19:29:50] <grrrit-wm>	 (03PS2) 10Wctaiwan: Allow extension of post interaction links [extensions/Flow] - 10https://gerrit.wikimedia.org/r/115552 
[19:30:30] <Nemo_bis>	 jgonera: see https://gerrit.wikimedia.org/r/102940
[19:31:35] <grrrit-wm>	 (03CR) 10Wctaiwan: Allow extension of post interaction links (032 comments) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/115552 (owner: 10Wctaiwan)
[19:32:00] <jgonera>	 Nemo_bis, thanks!
[19:33:07] <grrrit-wm>	 (03CR) 10Bartosz Dziewoński: "There are some non-code matches for the removed preference left:" [core] - 10https://gerrit.wikimedia.org/r/94614 (owner: 1001tonythomas)
[19:33:28] <grrrit-wm>	 (03PS1) 10Manybubbles: Squash master to REL1_22 [extensions/CirrusSearch] (REL1_22) - 10https://gerrit.wikimedia.org/r/115667 
[19:34:04] <jgonera>	 awjr, not sure how much I should trust the profiler as it shows negative values for some functions sometimes...
[19:34:05] <grrrit-wm>	 (03CR) 10Manybubbles: [C: 04-1] "-1 while testing but I wanted to get this up somewhere because it was a pain to make and I don't want to lose it." [extensions/CirrusSearch] (REL1_22) - 10https://gerrit.wikimedia.org/r/115667 (owner: 10Manybubbles)
[19:34:33] <awjr>	 jgonera: hmm it's possible the profiler invocation for those particular functions is messed up
[19:34:51] <awjr>	 like maybe wfProfileOut switched with wfProfileIn
[19:34:54] <awjr>	 or… things are totally f'd up :p
[19:35:19] <jgonera>	 awjr, I just added wfProfileIn and Out myself in one place and it reported negative time ;)
[19:35:27] <awjr>	 lol
[19:35:33] <awjr>	 maybe it really did take negative time
[19:36:00] <jgonera>	 I'd love to believe in that, I would just run this code in a loop until MW loads in 0ms
[19:36:15] <awjr>	 heehehehe
[19:36:46] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] Squash master to REL1_22 [extensions/CirrusSearch] (REL1_22) - 10https://gerrit.wikimedia.org/r/115667 (owner: 10Manybubbles)
[19:37:01] <awjr>	 jgonera: i think MaxSem has some experience with profiler stuff, he may have better insights than i
[19:38:23] <MaxSem>	 jgonera, I personally send profiling results to debug log
[19:38:56] <awjr>	 MaxSem: i think he's doing that but he's also getting negative values for some profiled functinos
[19:39:18] <MaxSem>	 mimatching in/out calls?
[19:39:25] <jgonera>	 MaxSem, nope
[19:39:39] <MaxSem>	 also, VMs are terrible for performance engineering
[19:40:02] <awjr>	 that is true, any profile metrics taken on a vm should be taken with large grains of salt
[19:40:19] <jgonera>	 yeah, but I want to know why MW on vagrant is so painfully slow
[19:40:20] <awjr>	 but they can still be useful depending on what you're lokoing for
[19:40:25] <jgonera>	 I can't reproduce it without vagrant
[19:40:32] <awjr>	 ha
[19:40:41] <jgonera>	 it's like 5 seconds per page load
[19:40:57] <awjr>	 hmm do you have memcached and apc set up?
[19:40:59] <MaxSem>	 same stuff for me
[19:41:11] <jgonera>	 a 404 sent by Apache loads instantaneously so it must be MW
[19:41:26] <awjr>	 mw can be seriously slow out of the box
[19:41:26] <jgonera>	 awjr, as far as I know vagrant instance of MW uses redis for cache
[19:41:36] <awjr>	 ah right
[19:41:45] <jgonera>	 not sure about APC but I even tried hhvm and it didn't change a thing
[19:41:57] <awjr>	 hmm
[19:42:02] <jgonera>	 awjr, it can be, but I think it shouldn't be
[19:42:03] <awjr>	 have you checked resource allocation for the vm?
[19:42:26] <jgonera>	 awjr, it's the only web app I worked on in my life that would be that slow with just a handful of rows in the db
[19:42:35] <awjr>	 yeah :(
[19:43:10] <jgonera>	 awjr, do you know how to check that in vagrant?
[19:43:50] <awjr>	 not off the top of my head
[19:44:33] <awjr>	 you might be able to do it through the virtualbox interface, but there's probably some vagrant config file that manages that stuff for headless
[19:44:53] <awjr>	 ahha
[19:44:59] <awjr>	 jgonera: http://www.mediawiki.org/wiki/Vagrant#How_do_I....3F
[19:45:08] <jgonera>	 awjr, it's set to 2GB memory and 2 cores, that should be more than enough
[19:45:12] <awjr>	 @_@
[19:45:13] <awjr>	 yeah.
[19:45:20] <awjr>	 :(
[19:45:37] <awjr>	 i imagine ori has some insight into this
[19:46:24] <jgonera>	 awjr, is it also something around 4-5s per page load for you when using vagrant?
[19:46:39] <grrrit-wm>	 (03CR) 10Jdlrobson: "Added some kind of test may be useful to this patchset." (031 comment) [core] - 10https://gerrit.wikimedia.org/r/102344 (owner: 10Dr0ptp4kt)
[19:46:53] <awjr>	 i havent added any pages besides the main page yet, i was just trying to get the mobile view switcher working properly yesterday
[19:46:59] <awjr>	 lemme see
[19:48:22] <awjr>	 jgonera: appears to be < 3s for me on average
[19:48:44] <awjr>	 im getting btwn 2.5 and 2.8s for really light pages
[19:48:49] <awjr>	 (note i am in desktop view)
[19:49:09] <jgonera>	 that's... acceptable, but I'd say it would be nice if it was < 0.5s
[19:49:10] <grrrit-wm>	 (03PS19) 10Bartosz Dziewoński: Removed 'Remember my login' preference [core] - 10https://gerrit.wikimedia.org/r/94614 (owner: 1001tonythomas)
[19:49:26] <awjr>	 yeah it would, although we don't get that in production unless a page is cached
[19:49:35] <grrrit-wm>	 (03CR) 10Bartosz Dziewoński: [C: 031] Removed 'Remember my login' preference [core] - 10https://gerrit.wikimedia.org/r/94614 (owner: 1001tonythomas)
[19:49:43] <awjr>	 jgonera: next step: set up varnish in vagrant :)
[19:50:00] <grrrit-wm>	 (03PS1) 10Addshore: Split the rest of Action.php into /actions/ [core] - 10https://gerrit.wikimedia.org/r/115672 
[19:50:05] <grrrit-wm>	 (03PS12) 10Dr0ptp4kt: Add support to get just the startup module URL with version. [core] - 10https://gerrit.wikimedia.org/r/102344 
[19:50:25] <dr0ptp4kt>	 jdlrobson, just updated the commit message to take out the dependency
[19:50:28] <dr0ptp4kt>	 ^^
[19:50:40] <dr0ptp4kt>	 thx for adding the test
[19:51:04] <awjr>	 jgonera: getting production-like varnish configured in vagrant is one of the things we're discussing for the zurich hackathon
[19:51:51] <jgonera>	 awjr, haha, that's not fixing the problem though, I want to have up to date pages when developing
[19:52:14] <awjr>	 jgonera: rewrite mediawiki in assembly
[19:52:14] <jgonera>	 btw, those 4-5s are with browser cache disabled (which I also want when developing)
[19:52:26] <awjr>	 yeah, my timings were with browser cache disabled too
[19:52:49] <jgonera>	 awjr, I don't think it's a matter of programming language choice ;)
[19:52:58] <awjr>	 hehehe i know i know
[19:53:26] <awjr>	 i just wanted to imagine what that would be like...
[19:55:23] <dr0ptp4kt>	 jdlrobson i misread...you're saying to add a test
[19:55:30] <dr0ptp4kt>	 ha! lemme look...
[19:55:47] <jdlrobson>	 dr0ptp4kt: yup i figured that might be useful for explaining what you are fixing
[19:56:00] <PiRCarre>	 hi
[19:57:18] <grrrit-wm>	 (03CR) 1001tonythomas: "@Bartosz: Thanks for the PS" [core] - 10https://gerrit.wikimedia.org/r/94614 (owner: 1001tonythomas)
[20:01:10] <huh>	 Anyone here?
[20:01:33] <mutante>	 !ask
[20:01:33] <wm-bot>	 Hi, how can we help you? Just ask your question.
[20:01:49] <mutante>	 !netsplit
[20:01:50] <mutante>	 !split
[20:01:57] <mutante>	 oh well, that:)
[20:04:49] <huh>	 !test
[20:04:49] <wm-bot>	 This is a nifty test of niftiness ... http://z0r.de/2650 << lookie, isn't that cool? :)
[20:05:07] <rdwrer>	 ...
[20:05:49] <huh>	 nomadrolled?
[20:05:49] <huh>	 thanks, nomad
[20:07:04] <grrrit-wm>	 (03PS2) 10Manybubbles: Squash master to REL1_22 [extensions/CirrusSearch] (REL1_22) - 10https://gerrit.wikimedia.org/r/115667 
[20:08:31] <grrrit-wm>	 (03CR) 10Multichill: [C: 031] "That's an odd license. Not sure if the addition of the qqq message will work. Siebrand, can you check?" [extensions/WikimediaMessages] - 10https://gerrit.wikimedia.org/r/115597 (owner: 10Rillke)
[20:10:07] <grrrit-wm>	 (03PS3) 10Manybubbles: Squash master to REL1_22 [extensions/CirrusSearch] (REL1_22) - 10https://gerrit.wikimedia.org/r/115667 
[20:10:34] <grrrit-wm>	 (03CR) 10Manybubbles: [C: 032 V: 032] "Merging now that Cirrus' REL1_22 is ready as well." [extensions/Elastica] (REL1_22) - 10https://gerrit.wikimedia.org/r/115656 (owner: 10Manybubbles)
[20:10:55] <grrrit-wm>	 (03CR) 10Manybubbles: [C: 032 V: 032] "Merging now that Cirrus' REL1_22 is ready as well." [extensions/Elastica] (REL1_22) - 10https://gerrit.wikimedia.org/r/115657 (owner: 10Manybubbles)
[20:11:54] <grrrit-wm>	 (03CR) 10Bartosz Dziewoński: "I've tested this now and noticed that it splits the single link in two :/ That is pretty unintuitive. It might be better to just make the " [core] - 10https://gerrit.wikimedia.org/r/107360 (owner: 1001tonythomas)
[20:12:05] <grrrit-wm>	 (03CR) 10Manybubbles: [C: 032 V: 032] "Overriding Jenkins bot's opinion and merging anyway. His complaints are due to a missing jshintrc file but we can live without one in the" [extensions/CirrusSearch] (REL1_22) - 10https://gerrit.wikimedia.org/r/115667 (owner: 10Manybubbles)
[20:12:37] <grrrit-wm>	 (03PS1) 10Jforrester: Update OOjs UI to v0.1.0-pre (064484f9af) [core] - 10https://gerrit.wikimedia.org/r/115676 
[20:14:46] <grrrit-wm>	 (03PS13) 10Dr0ptp4kt: Add support to get just the startup module URL with version. [core] - 10https://gerrit.wikimedia.org/r/102344 
[20:15:03] <grrrit-wm>	 (03PS2) 10Wctaiwan: [WIP] Add "Thanks" for comments on Flow boards [extensions/Thanks] - 10https://gerrit.wikimedia.org/r/115557 
[20:16:05] <grrrit-wm>	 (03PS3) 10Wctaiwan: [WIP] Add "Thanks" for comments on Flow boards [extensions/Thanks] - 10https://gerrit.wikimedia.org/r/115557 
[20:18:12] <grrrit-wm>	 (03PS4) 10Gerrit Patch Uploader: Add 'newonly' option to Special:Contributions and related i18n message [core] - 10https://gerrit.wikimedia.org/r/115189 
[20:18:14] <grrrit-wm>	 (03CR) 10Gerrit Patch Uploader: "This commit was uploaded using the Gerrit Patch Uploader [1]." [core] - 10https://gerrit.wikimedia.org/r/115189 (owner: 10Gerrit Patch Uploader)
[20:21:11] <grrrit-wm>	 (03CR) 10Krinkle: Add support to get just the startup module URL with version. (033 comments) [core] - 10https://gerrit.wikimedia.org/r/102344 (owner: 10Dr0ptp4kt)
[20:21:18] <grrrit-wm>	 (03PS1) 10Manybubbles: Get Cirrus's browser tests working [vagrant] - 10https://gerrit.wikimedia.org/r/115679 
[20:21:22] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] Get Cirrus's browser tests working [vagrant] - 10https://gerrit.wikimedia.org/r/115679 (owner: 10Manybubbles)
[20:21:24] <grrrit-wm>	 (03PS14) 10Krinkle: resourceloader: Add method to get the startup modules load url [core] - 10https://gerrit.wikimedia.org/r/102344 (owner: 10Dr0ptp4kt)
[20:21:28] <grrrit-wm>	 (03CR) 10Krinkle: [C: 031] resourceloader: Add method to get the startup modules load url [core] - 10https://gerrit.wikimedia.org/r/102344 (owner: 10Dr0ptp4kt)
[20:21:42] <huh>	 Krinkle hey
[20:21:57] <Krinkle>	 huh: Hi
[20:22:01] <huh>	 Is there going to be a mw.loader replacement for importScript?
[20:22:12] <huh>	 and also importStylesheet
[20:23:00] <Krinkle>	 huh: A day or so ago a test bot of yours running on tool labs (under your local-pirsquared account) was continuously join/parting #cvn-commons, #cvn-meta and other channels.
[20:23:00] <grrrit-wm>	 (03PS2) 10Manybubbles: Get Cirrus's browser tests working [vagrant] - 10https://gerrit.wikimedia.org/r/115679 
[20:23:21] <huh>	 Krinkle: and I fixed it
[20:23:35] <Krinkle>	 huh: There is a bug about that, the answer is no, because there is nothing to migrate. They work fine as they are, and have nothing to do with mw.loader (which is about ResourceLoader, and user scripts are not ResourceLoader modules)
[20:23:45] <grrrit-wm>	 (03CR) 10Manybubbles: "I'm sure I did everything wrong in this commit, but it does get Cirrus' browser test passing which is pretty cool." [vagrant] - 10https://gerrit.wikimedia.org/r/115679 (owner: 10Manybubbles)
[20:23:47] <huh>	 But aren't they deprecated?
[20:23:58] <Krinkle>	 These select methods are explicitly not marked deprecated.
[20:24:58] <Krinkle>	 However user scripts in general, yes, are kind of deprecated. Or rather, I'd argue they were and never can be part of anything serious because of their nature. They are just pure HTML / JS / CSS, loaded using action=raw and bare <script> and <link> tags. Not integrated with MediaWiki in any way whatsoever.
[20:25:00] <Krinkle>	 huh: 
[20:26:06] <Krinkle>	 There is Gadgets for anything notable / trusted / popular enough sharing site-wide. And there is interest in the Gadgets extension to be extended to the user level (as opposed to site-wide level, where'd you'd be able to install gadgets that aren't managed site-wide)
[20:26:08] <grrrit-wm>	 (03CR) 10Technical 13: [C: 04-1] "For now pending the answer to my question in the comment..." (031 comment) [core] - 10https://gerrit.wikimedia.org/r/115189 (owner: 10Gerrit Patch Uploader)
[20:26:14] <Krinkle>	 Which would be the first version of proper user modules.
[20:27:16] <Krinkle>	 user scripts won't be deprecated, because technically they don't exist. There is very little (if anything) that makes user scripts work. You don't even need importScript, that's just a shortcut for adding a script tag and pointing it at action=raw and executing raw wikitext pages (which can be named *.js but don't have to be) as javascript.
[20:27:54] <grrrit-wm>	 (03CR) 10PiRSquared17: "Replied, but anomie suggested this course of action." (031 comment) [core] - 10https://gerrit.wikimedia.org/r/115189 (owner: 10Gerrit Patch Uploader)
[20:29:20] <grrrit-wm>	 (03CR) 10Dr0ptp4kt: "I see all things were addressed in PS14. Thanks for that!" (033 comments) [core] - 10https://gerrit.wikimedia.org/r/102344 (owner: 10Dr0ptp4kt)
[20:29:34] <huh>	 T13|sleeps: hey
[20:29:34] <grrrit-wm>	 (03CR) 10Dr0ptp4kt: [C: 031] resourceloader: Add method to get the startup modules load url [core] - 10https://gerrit.wikimedia.org/r/102344 (owner: 10Dr0ptp4kt)
[20:29:37] <huh>	 anomie: ping
[20:29:45] <anomie>	 huh: pong
[20:30:10] <dr0ptp4kt>	 ^^^Krinkle, need anything else?
[20:30:11] <huh>	 Please see 115189
[20:30:20] <huh>	 https://gerrit.wikimedia.org/r/115189
[20:30:22] <huh>	 anomie: ^
[20:32:04] <Krinkle>	 dr0ptp4kt: nope, looks good. btw, regarding some of the changes I undid, I'm not saying either is better, just keeping the patch clean :) Feel free to submit a cleanup patch, I'm sure there's lots of things that could be made cleaner if you feel like doing that. I'd be happy help with explaining anything you run into.
[20:32:20] <Krinkle>	 dr0ptp4kt: One thing I did notice just now, should this static method have the if only==scripts condition still?
[20:32:35] <Krinkle>	 Not sure how that will behave, though it doesnt' affect core at this point.
[20:34:43] <dr0ptp4kt>	 Krinkle, i appreciate the cleanup. lemme check on that condition real quick
[20:35:43] <Krinkle>	 OK (just to emphasise, though I did clean up a bit, I meant I actually undid some of your cleanup that I think is interesting but better suited for a separate patch)
[20:36:24] <grrrit-wm>	 (03CR) 10Technical 13: Add 'newonly' option to Special:Contributions and related i18n message (032 comments) [core] - 10https://gerrit.wikimedia.org/r/115189 (owner: 10Gerrit Patch Uploader)
[20:37:00] <grrrit-wm>	 (03CR) 10Anomie: [C: 04-1] Add 'newonly' option to Special:Contributions and related i18n message (033 comments) [core] - 10https://gerrit.wikimedia.org/r/115189 (owner: 10Gerrit Patch Uploader)
[20:37:06] <anomie>	 huh: ^
[20:40:24] <huh>	 anomie: I'll fix the deprecation, but then should I remove (deprecated) from the description?
[20:40:26] <huh>	 Also, what's wrong with foo?
[20:40:26] <grrrit-wm>	 (03CR) 10Anomie: Add 'newonly' option to Special:Contributions and related i18n message (031 comment) [core] - 10https://gerrit.wikimedia.org/r/115189 (owner: 10Gerrit Patch Uploader)
[20:40:31] <anomie>	 huh: Yes, because the API will automatically put "deprecated" on the description.
[20:40:31] <anomie>	 huh: The 'foo' should be 'top', shouldn't it?
[20:40:31] <anomie>	 ... no, wait. the 'foo' is useless. I was confused there.
[20:41:16] <huh>	 anomie: if it's an array that will be inverted ... not sure what the best way to do it is?
[20:41:16] * anomie  would have just done $show[] = 'top' then

[20:41:16] <huh>	 Oh?
[20:41:16] <huh>	 Will that make isset true?
[20:41:35] <huh>	 Yes, I'm a total n00b XD
[20:41:38] <anomie>	 huh: I forgot that the array was yet to be inverted at that point, so I thought 'foo' was being the key and not the value.
[20:41:55] <grrrit-wm>	 (03CR) 10Technical 13: Add 'newonly' option to Special:Contributions and related i18n message (032 comments) [core] - 10https://gerrit.wikimedia.org/r/115189 (owner: 10Gerrit Patch Uploader)
[20:41:58] <huh>	 T13|sleeps/anome: I think I'll fix these immediately
[20:42:03] <anomie>	 huh: That's why isset(), so whichever thing in the array winds up with value 0 doesn't get skipped
[20:42:03] <huh>	 anything else to do?
[20:42:33] <anomie>	 huh: I haven't tested it yet, but I don't see anything else by looking at it.
[20:42:33] <huh>	 anomie: can I put a message for the deprecation?
[20:42:50] <huh>	 I have it working on a test wiki http://abusefilter-global-main.instance-proxy.wmflabs.org/ too
[20:43:13] <huh>	 (sorry for the horrible domain name)
[20:43:28] <anomie>	 huh: The API handles it automatically. See https://en.wikipedia.org/w/api.php?format=jsonfm&action=query&title=Foo&prop=langlinks&llurl=1, and https://en.wikipedia.org/w/api.php?action=help&querymodules=langlinks
[20:44:09] <grrrit-wm>	 (03PS2) 10IAlex: Misc fixes to UploadSourceField [core] - 10https://gerrit.wikimedia.org/r/104944 
[20:44:16] <T13|sleeps>	 huh ?
[20:44:28] <huh>	 anomie: yes, but is it possible to say what it was deprecated in favor of?
[20:44:34] <huh>	 Not that it really matters
[20:44:34] <grrrit-wm>	 (03PS2) 10IAlex: Send the full title to the 'nogomatch' debug log group [core] - 10https://gerrit.wikimedia.org/r/111663 
[20:44:38] <anomie>	 huh: If you want
[20:44:58] <grrrit-wm>	 (03PS2) 10IAlex: Correct the destionation of checkLastModified debug messages [core] - 10https://gerrit.wikimedia.org/r/111833 
[20:45:18] <T13|sleeps>	 I still think deprecated != superseded
[20:45:35] <grrrit-wm>	 (03PS2) 10IAlex: Add two new debug log groups [core] - 10https://gerrit.wikimedia.org/r/111946 
[20:45:53] <grrrit-wm>	 (03CR) 10PiRSquared17: Add 'newonly' option to Special:Contributions and related i18n message (031 comment) [core] - 10https://gerrit.wikimedia.org/r/115189 (owner: 10Gerrit Patch Uploader)
[20:46:00] <grrrit-wm>	 (03CR) 10Catrope: [C: 032] Update OOjs UI to v0.1.0-pre (064484f9af) [core] - 10https://gerrit.wikimedia.org/r/115676 (owner: 10Jforrester)
[20:46:16] <grrrit-wm>	 (03PS2) 10IAlex: Allow to disable specific groups in $wgDebugLogGroups [core] - 10https://gerrit.wikimedia.org/r/111906 
[20:46:23] <huh>	 T13|sleeps: it will be removed later, for now I think we should be nice and allow backwards compatibility?
[20:46:26] <huh>	 anome agree?
[20:46:28] <huh>	 *anomie
[20:47:06] <anomie>	 huh: Definitely keep BC
[20:47:29] <T13|sleeps>	 It's been replaced with a superior 'top' && '!top' pair, it's not removed. 
[20:47:51] <huh>	 T13|sleeps: right now uctoponly -> top
[20:48:01] <huh>	 I don't see a problem with that.
[20:48:48] <anomie>	 T13|sleeps: BC means that clients don't have to change their code, not just that they can achieve the same effect with a different query.
[20:48:53] <huh>	 ^
[20:49:06] <T13|sleeps>	 Not what I'm saying.
[20:49:10] <huh>	 They may notice the warning too, and fix it
[20:49:43] <dr0ptp4kt>	 Krinkle, sorry for delay. had to hunt down the correct patchset. the only==scripts condition holds.
[20:49:55] <dr0ptp4kt>	 Krinkle, if you'll +2 i'll jump for joy
[20:50:16] <dr0ptp4kt>	 Krinkle, and the changes you made were solid.
[20:50:48] <Krinkle>	 dr0ptp4kt: OK, so why does the static getter for the modules url need to have that condition though? It seems a bit weird that it would return an empty string if the relevant context is not only=scripts
[20:51:11] <Krinkle>	 getScript is already in the correct condition, I don't know what context you'd be in elsewhere. But I imagine if you wnat that url, you want that url.
[20:51:37] <Krinkle>	 Anyway, convince me. I didn't change it because I wasn't sure.
[20:52:05] <grrrit-wm>	 (03CR) 10Technical 13: "waits for patch 5..." (032 comments) [core] - 10https://gerrit.wikimedia.org/r/115189 (owner: 10Gerrit Patch Uploader)
[20:54:14] <grrrit-wm>	 (03Merged) 10jenkins-bot: Update OOjs UI to v0.1.0-pre (064484f9af) [core] - 10https://gerrit.wikimedia.org/r/115676 (owner: 10Jforrester)
[20:55:26] <huh>	 T13|sleeps: just waiting for the patch to go through
[20:55:31] <huh>	 quite slow
[20:56:13] <grrrit-wm>	 (03PS1) 10Ottomata: Updating wikimetrics submodule to lastest lint change [vagrant] - 10https://gerrit.wikimedia.org/r/115685 
[20:56:25] <grrrit-wm>	 (03CR) 10Hashar: [C: 032] Tweak css for blockdiag so img can be larger [tools/releng] - 10https://gerrit.wikimedia.org/r/115595 (owner: 10Hashar)
[20:56:36] <grrrit-wm>	 (03Abandoned) 10Hashar: Jenkins validation (DO NOT SUBMIT) [tools/releng] - 10https://gerrit.wikimedia.org/r/115600 (owner: 10Hashar)
[20:56:38] <grrrit-wm>	 (03CR) 10Ottomata: [C: 032 V: 032] Updating wikimetrics submodule to lastest lint change [vagrant] - 10https://gerrit.wikimedia.org/r/115685 (owner: 10Ottomata)
[20:57:23] <grrrit-wm>	 (03Merged) 10jenkins-bot: Tweak css for blockdiag so img can be larger [tools/releng] - 10https://gerrit.wikimedia.org/r/115595 (owner: 10Hashar)
[20:57:30] <huh>	 anomie / T13|sleeps am I correct to assume the only remaining issues are with the API?
[20:57:57] <anomie>	 huh: I haven't checked the rest of it yet
[20:58:04] <grrrit-wm>	 (03PS5) 10Gerrit Patch Uploader: Add 'newonly' option to Special:Contributions and related i18n message [core] - 10https://gerrit.wikimedia.org/r/115189 
[20:58:06] <grrrit-wm>	 (03CR) 10Gerrit Patch Uploader: "This commit was uploaded using the Gerrit Patch Uploader [1]." [core] - 10https://gerrit.wikimedia.org/r/115189 (owner: 10Gerrit Patch Uploader)
[20:58:08] <dr0ptp4kt>	 Krinkle, i see what you mean. i think this would work: rename the function to getStartupScriptModulesUrl, and then instead of $context->getOnly() icall $context->shouldIncludeScripts()
[20:58:15] <huh>	 T13|sleeps: check now ;)
[20:58:26] <grrrit-wm>	 (03PS1) 10Aude: Update README, elastica is no longer a git submodule [extensions/Elastica] - 10https://gerrit.wikimedia.org/r/115686 
[20:59:27] <Krinkle>	 dr0ptp4kt: Why would it need a condition at all though? I'm not getting the part where you'd call this method and then want the function to apply additional logic in deciding whether you want the url or not, and then presumably need to double-check the return value before you can use it.
[20:59:44] <Krinkle>	 seems like an odd separation of concerns. I'd be happy with an example though.
[20:59:46] <huh>	 anomie: this has definitely been a learning experience. Thanks for your helpful comments
[20:59:55] <Krinkle>	 I don't mind it using only=scripts instead of shouldIncludeScripts for now
[21:01:02] <huh>	 I hope this will be done in under 4 more patchsets
[21:07:38] <dr0ptp4kt>	 Krinkle, i'm comfortable with removal of the wrapping if(). want me to do that? do you think we should rename it to make it clear that it is going to return a url getting script things? or is the function name sufficiently clear now as 'getStartupModulesUrl' (i.e., does it sufficiently imply a url for js)?
[21:08:18] <huh>	 T13|sleeps: plz review
[21:10:16] <dr0ptp4kt>	 Krinkle, that is to say, keep the body of the if(), just not the condition of it
[21:13:02] <grrrit-wm>	 (03CR) 10Mattflaschen: "Hmm, I'm not sure we should put all the animations in one file." (031 comment) [core] - 10https://gerrit.wikimedia.org/r/115377 (owner: 10Prtksxna)
[21:14:05] <dr0ptp4kt>	 Krinkle, grabbing food quickly. bbiab
[21:17:54] <Krinkle>	 dr0ptp4kt: yeah, that's also why I renamed the method slightly. I think I see your point now. The url it returns neglects the ResourceLoaderContext's "only" mode, and always does only=scripts
[21:17:58] <Krinkle>	 However considering the startup logic is limited to just scripts, this is more an implementation detail than a limitation.
[21:17:58] <Krinkle>	 If there were some kind of load.php?action=startupmodules then that wouldn't even have an 'only' parameter. This is internally re-using modules=.. to list them out and use only=scripts to get it to work right. It isn't overriding the 'only' parameter in the way it might seem.
[21:17:58] <Krinkle>	 so it returning always returning a script url is sensible