[00:07:34] (03PS8) 10Physikerwelt: phpunit test for XQuery generation [extensions/MathSearch] - 10https://gerrit.wikimedia.org/r/111468 (owner: 10Etienne) [00:08:09] (03CR) 10Physikerwelt: [C: 032] phpunit test for XQuery generation [extensions/MathSearch] - 10https://gerrit.wikimedia.org/r/111468 (owner: 10Etienne) [00:08:14] (03Merged) 10jenkins-bot: phpunit test for XQuery generation [extensions/MathSearch] - 10https://gerrit.wikimedia.org/r/111468 (owner: 10Etienne) [00:10:27] (03CR) 10Manybubbles: [C: 032] Multiply by 100 for percentages, not 200 [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/115319 (owner: 10Chad) [00:10:38] (03Merged) 10jenkins-bot: Multiply by 100 for percentages, not 200 [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/115319 (owner: 10Chad) [00:14:12] (03PS1) 10Bsitu: Do not log expected Flow exceptions [extensions/Flow] - 10https://gerrit.wikimedia.org/r/115322 [00:14:30] (03CR) 10Dzahn: [C: 032] Add hook in core for bmo's 'Needinfo' Bugzilla extension. [wikimedia/bugzilla/modifications] - 10https://gerrit.wikimedia.org/r/114168 (owner: 10Aklapper) [00:14:37] (03CR) 10Dzahn: [V: 032] Add hook in core for bmo's 'Needinfo' Bugzilla extension. [wikimedia/bugzilla/modifications] - 10https://gerrit.wikimedia.org/r/114168 (owner: 10Aklapper) [00:15:03] (03CR) 10EBernhardson: [C: 032] Do not log expected Flow exceptions [extensions/Flow] - 10https://gerrit.wikimedia.org/r/115322 (owner: 10Bsitu) [00:15:14] (03Merged) 10jenkins-bot: Do not log expected Flow exceptions [extensions/Flow] - 10https://gerrit.wikimedia.org/r/115322 (owner: 10Bsitu) [00:18:03] (03CR) 10Dzahn: "deployed on zirconium" [wikimedia/bugzilla/modifications] - 10https://gerrit.wikimedia.org/r/114168 (owner: 10Aklapper) [00:19:12] (03CR) 10Dzahn: [C: 032 V: 032] Replace custom template file by using existing Bugzilla hook [wikimedia/bugzilla/modifications] - 10https://gerrit.wikimedia.org/r/114145 (owner: 10Aklapper) [00:23:42] (03PS1) 10Catrope: Update VisualEditor for cherry-pick [core] (wmf/1.23wmf15) - 10https://gerrit.wikimedia.org/r/115324 [00:24:12] (03CR) 10Catrope: [C: 032 V: 032] Update VisualEditor for cherry-pick [core] (wmf/1.23wmf15) - 10https://gerrit.wikimedia.org/r/115324 (owner: 10Catrope) [00:27:22] (03PS2) 10Prtksxna: [WIP] Flip the starting point of the popup if its on the right side of the screen [extensions/Popups] - 10https://gerrit.wikimedia.org/r/115187 [00:27:24] (03PS2) 10Prtksxna: Limit image size for portrait popups [extensions/Popups] - 10https://gerrit.wikimedia.org/r/115186 [00:27:26] (03PS2) 10Prtksxna: [WIP] Flip the arrow position if the popup is flipped [extensions/Popups] - 10https://gerrit.wikimedia.org/r/115188 [00:31:22] (03CR) 10Dzahn: "deployed" [wikimedia/bugzilla/modifications] - 10https://gerrit.wikimedia.org/r/114145 (owner: 10Aklapper) [00:31:46] (03CR) 10Bsitu: [C: 04-1] "Need to address issues caught by phpstorm, :)" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/109431 (owner: 10Bsitu) [00:33:45] (03CR) 10Dzahn: [C: 032 V: 032] Delete unused and duplicated file. [wikimedia/bugzilla/modifications] - 10https://gerrit.wikimedia.org/r/113460 (owner: 10Aklapper) [00:36:36] stuff you stumple upon at random... https://ru.wikipedia.org/wiki/KPHP [00:36:46] (it's proprietary...) [00:38:02] the k is from "kitten"... :P [00:38:39] * ebernhardson wonders why everything is in russian except the banner [00:39:09] ebernhardson: Someone needs to translate it... but nobody seems to yet care enough :P [00:42:55] (03CR) 10Dzahn: "deployed..eh ..deleted..eh .. same thing:)" [wikimedia/bugzilla/modifications] - 10https://gerrit.wikimedia.org/r/113460 (owner: 10Aklapper) [00:45:45] * hoo gives up... no source nor binary of that floating around apparently :P [00:45:53] (03CR) 10Parent5446: [C: 032] "I tried testing this patch, only to discover that MediaWiki simply does not work with Oracle anyway. I had to make six different manual co" [core] - 10https://gerrit.wikimedia.org/r/110991 (owner: 10Umherirrender) [00:49:16] https://ru.wikipedia.org/w/index.php?title=KPHP&diff=61269626&oldid=60391479 yeah :P Can't review that :D [00:49:33] (03Merged) 10jenkins-bot: Add sequence support for upsert in DatabaseOracle [core] - 10https://gerrit.wikimedia.org/r/110991 (owner: 10Umherirrender) [00:49:40] (03CR) 10Parent5446: "Could this possibly be rebased? Also, since the creation of this patch, there is a new patch for user.user_password_expires that is missin" [core] - 10https://gerrit.wikimedia.org/r/111735 (owner: 10Freakolowsky) [00:55:11] (03CR) 10Parent5446: Add a PSR-3 based logging interface. [core] - 10https://gerrit.wikimedia.org/r/112699 (owner: 10BryanDavis) [00:56:01] StevenW, superm401 : qgil/brena redesign https://www.mediawiki.org/wiki/MediaWiki/Homepage_redesign/Preview has blue hyperlink text in [Get MediaWiki] because wrapping a around a hyperlink doesn't override the hyperlink color. How did you fix this with {{blue button}} ? [00:56:24] I didn't fix it. [00:56:36] (03CR) 10Parent5446: [C: 032] Add new Hook 'SendWatchlistEmailNotification' [core] - 10https://gerrit.wikimedia.org/r/114682 (owner: 10Bsitu) [00:56:38] Except by using crappy deprecated HTML [00:57:14] (03CR) 10jenkins-bot: [V: 04-1] Add new Hook 'SendWatchlistEmailNotification' [core] - 10https://gerrit.wikimedia.org/r/114682 (owner: 10Bsitu) [00:57:37] OK, I'll file a bug, I think mw-ui-xxx should do the right thing. In our tests we add the classes to the hyperlink or button, but templates can't do that [00:59:17] (03CR) 10Parent5446: [C: 04-1] "This is probably not a good idea, because it encourages making the MediaWiki home directory writeable by the web server, which should not " [core] - 10https://gerrit.wikimedia.org/r/114966 (owner: 10Mjnovice) [00:59:43] Is Parent5446 on IRC? [00:59:47] Rarely. [01:01:04] he hops on irc if you ask him by e-mail [01:01:14] ask him for that* [01:02:19] spagewmf: you may want to look at https://commons.wikimedia.org/wiki/Template:Clickable_button maybe theres something which help you [01:03:11] (03PS1) 10Prtksxna: Minor type changes/Fix contrast [extensions/Popups] - 10https://gerrit.wikimedia.org/r/115327 [01:06:13] se4598: button appearance: aggh, my eyes! template source: aggh! should just work, some day. [01:09:54] spagewmf: https://www.mediawiki.org/wiki/User:Se4598/Test works for me if you preview in editmode ( I think it's likely a race condition with the MediaWiki:Common.js thing) [01:12:02] not pretty and adding mw-ui-button as trigger for load makes it uglier [01:12:24] dunno, I'm off [01:13:13] se4598: we'd like to deprecate and some day abandon jQuery classes like ui-button ui-widget... in favor of mw-ui- classes, and https://gerrit.wikimedia.org/r/#/c/114085/ will avoid any race conditions. [01:19:03] anomie: ping [01:23:06] (03CR) 10BryanDavis: "Mwjames: Did you see the discussion between myself and Jeroen about the reasons for management of the monolog imports in this way?" [core] - 10https://gerrit.wikimedia.org/r/112699 (owner: 10BryanDavis) [01:24:29] (03CR) 10PiRSquared17: [C: 04-1] "Replied to Anomie. -1 for now" (032 comments) [core] - 10https://gerrit.wikimedia.org/r/115189 (owner: 10Gerrit Patch Uploader) [01:29:08] ori: if i already have a role enabled in vagrant (like mobilefrontend) but i make changes to the puppet manifest for that role, how do i get those changes reflected in my instance? disable/reenable/provision the role? [01:29:13] or is there something more graceful? [01:29:48] I think vagrant provision should be good enough [01:30:00] interesting [01:30:10] so vagrant provision will cause puppet to run again? [01:30:53] (03CR) 10SPQRobin: "This only appears to change the behaviour for some of these parser functions, since most of them already use the page content language in " [core] - 10https://gerrit.wikimedia.org/r/110342 (owner: 10Nikerabbit) [01:30:57] awjr: Yes. `vagrant provision` is roughly equivalent to `puppetd -tv` [01:31:08] cool thanks bd808 and legoktm [01:34:26] legoktm, production does use cURL right? [01:34:38] I mean, PHP has the extension installed and everything, right? [01:34:44] uhhh [01:34:47] I think so? [01:35:12] context? [01:35:31] does parsoid take a super long time to provision with vagrant? [01:35:37] <^d> Krenair: Yes. [01:35:44] Am poking around with MW's http request stuff, legoktm. [01:35:51] <^d> We use curl in prod. [01:36:17] <^d> (Requires a proxy though, we don't define the default proxy) [01:36:29] <^d> So with 'proxy' passed to the $options array [01:36:38] Apparently the parsoid team observed cURL not sending an Accept-Encoding header... which cURL should be doing. [01:37:33] <^d> Meh, proxy only when going external :) [01:37:52] Specifically I'm looking at https://bugzilla.wikimedia.org/show_bug.cgi?id=61507 [01:38:56] <^d> Krenair: $this->curlOptions[CURLOPT_ENCODING] = ""; # Enable compression [01:39:00] From what I can tell: The PHP backend happily sends the accept-encoding header like that, but returns encoded content. [01:39:03] cURL already has CURLOPT_ENCODING set to "", which should make it accept identity, deflate and gzip [01:40:14] <^d> Krenair: "Added in cURL 7.10." [01:40:20] <^d> Wonder what version we have in prod :) [01:40:47] <^d> cURL Information => 7.22.0 [01:40:54] So it should be fine. [01:44:50] awjr, try our shiny new deb: 'deb http://parsoid.wmflabs.org:8080/debian wmf-production/' [01:45:58] nice gwicke, is that preferable to using the vagrant role? [01:49:46] (03PS3) 10Bartosz Dziewoński: Warn on account creation when username is adjusted [core] - 10https://gerrit.wikimedia.org/r/114400 [01:49:50] (03PS1) 10Bartosz Dziewoński: SpecialUserlogin: Normalize username before passing to User::newFromName [core] - 10https://gerrit.wikimedia.org/r/115329 [01:50:05] awjr, depends on who you ask [01:50:11] :p [01:50:17] (03Abandoned) 10Bartosz Dziewoński: User: Be less stringent in getCanonicalName() [core] - 10https://gerrit.wikimedia.org/r/114379 (owner: 10Bartosz Dziewoński) [01:50:31] we are maintaining the deb, and are only waiting for a more official repo before we go public with it [01:50:43] the idea is to avoid duplication between various setups [01:51:32] I have not used vagrant, so would be interested in tweaking the config a bit if necessary to make it work out of the box [01:51:42] by adding a vagrant prefix for example [01:52:01] gwicke: i suspect it shouldn't be a big deal to make vagrant use your deb [01:52:05] or maybe it does already [01:53:15] awjr, IIRC there were problems with the outdated npm on Vagrant no longer working with npmjs.org [01:53:20] actually it looks like it git clones from source [01:53:23] our deb contains all dependencies, which avoids that problem [01:53:36] oh so maybe my attempts to get vagrant running with the visualeditor role are in vain [01:55:01] i have a somewhat complex virtual environment using vmware fusion that i use for development but im hoping to be able to emulte it, or at least most of it, using vagrant so im just taking it out for a spin now [01:56:40] k [01:58:11] awjr, can you check which prefix the VE config in Vagrant normally sets for the local wiki? [01:58:25] I can then match that in the deb [02:00:35] there's no conflict at all between roles and packages [02:00:42] a role can clone a repository, or it can install a package [02:02:10] gwicke: what do you mean by 'prefix'? [02:03:32] ori, the interwiki prefix [02:03:57] maps a prefix to an API URI [02:03:59] 'localhost' [02:04:03] parsoidConfig.setInterwiki( 'localhost', '<%= scope.lookupvar("mediawiki::server_url") %>/w/api.php' ); [02:04:31] i can change it if you like [02:04:35] what does that expand to normally? [02:04:50] 127.0.0.1:8080/w/api.php, but -- [02:05:47] our config lives in /etc/parsoid/settings.js [02:06:11] yeah, it'd be nice if it worked out of the box and did not require generating an alternative [02:06:27] we can either overwrite that from puppet, or just set up a default prefix that works without puppet [02:07:00] alternatives are not necessary, it is a config file which debian handles fine [02:07:19] a default prefix would work [02:09:14] would localhost/w/api.php work? [02:09:50] ori, that's the default [02:10:01] if apache is listening on 80 that will already work [02:10:20] we did however move parsoid from 8000 to 8142 to avoid conflicts [02:10:28] 80 will work [02:10:36] apache on the guest is listening on both 80 and 8080 [02:10:41] so that will need to be changed in the VE config [02:10:49] we'll move prod soon as well [02:11:02] but it's port 8080 on the host that is forwarded to port 80 on the guest [02:11:17] the reason being that binding port 80 on the host environment may require elevated privs [02:11:31] so as long as the requests only originate in the vm itself, hitting port 80 is fine [02:11:47] yeah, it's all localhost [02:12:05] cool, so the default config should work [02:12:06] ori, 'deb http://parsoid.wmflabs.org:8080/debian wmf-production/', apt-get update && apt-get install parsoid [02:12:28] why not apt.wikimedia.org? [02:13:23] ori, that's root-only etc [02:13:43] I am pushing for a longer-term public repo, but Faidon did not have much time recently [02:14:09] ok, i'll give it a shot [02:14:15] it might be release.wikimedia.org [02:14:17] there are a few packages outside apt.wikimedia.org that we use, like hhvm [02:14:27] so i've thought about concentrating them in a launchpad ppa [02:14:31] we also want to have a private sibling [02:14:32] What's this http://ubuntu.wikimedia.org/ubuntu/ubuntu/ubuntu/ubuntu/ ? [02:14:59] huh: http://en.wikipedia.org/wiki/Buffalo_buffalo_Buffalo_buffalo_buffalo_buffalo_Buffalo_buffalo [02:15:34] ori, I'm not in favor of a ppa [02:15:45] setting up mini-dinstall takes a few minutes [02:16:28] the main hold-back is figuring out how to structure the repo [02:17:05] we'd like to support snapshot releases (basically wmf deploys) and major-version + security upgrades [02:17:21] it should be possible to run the latter with unattended-upgrades [02:17:34] so that security upgrades are installed automatically as they become available [02:29:38] (03CR) 10Spage: [C: 031] "Wikis have too many templates like [[commons:Template:Clickable_button]] dependent on jquery.ui.button that don't work if JavaScript isn't" [core] - 10https://gerrit.wikimedia.org/r/114085 (owner: 10Mattflaschen) [02:33:59] (03PS15) 10Bsitu: Add diff view of changes to board header [extensions/Flow] - 10https://gerrit.wikimedia.org/r/109431 [02:35:26] (03PS16) 10Bsitu: Add diff view of changes to board header [extensions/Flow] - 10https://gerrit.wikimedia.org/r/109431 [02:43:01] (03PS1) 10Physikerwelt: Test and bugfix of qvar (?x) support [extensions/MathSearch] - 10https://gerrit.wikimedia.org/r/115334 [02:47:41] Technical_13: Hi! [02:47:53] huh!? [02:48:15] Just popping in before bed. What's up? [02:48:42] Technical_13: not much, did you see anomie's comment https://gerrit.wikimedia.org/r/#/c/115189/ ? [02:49:02] I -1 it for now, but it does seem to work. It may not be efficient. [02:49:18] (03PS2) 10Physikerwelt: Test and bugfix of qvar (?x) support [extensions/MathSearch] - 10https://gerrit.wikimedia.org/r/115334 [02:50:46] (03CR) 10Physikerwelt: [C: 032] Test and bugfix of qvar (?x) support [extensions/MathSearch] - 10https://gerrit.wikimedia.org/r/115334 (owner: 10Physikerwelt) [02:50:51] (03Merged) 10jenkins-bot: Test and bugfix of qvar (?x) support [extensions/MathSearch] - 10https://gerrit.wikimedia.org/r/115334 (owner: 10Physikerwelt) [02:54:17] This would make more sense to me as another pair of options under 'show'. [02:54:22] That comment? [02:56:14] 'show' => array(ApiBase::PARAM_ISMULTI => true,ApiBase::PARAM_TYPE => array('minor','!minor','patrolled','!patrolled','toponly','!toponly','newonly','!newonly')), [02:56:22] huh: ^^^ I think that is what he was suggesting [02:56:58] top only, no top, new only, no new... [02:58:54] And I don't agree with him there. [02:59:21] Why would anyone ever want to filter out new pages and eclude just those? [03:00:42] huh: I've commented as such... [03:05:47] I'm not familiar with the database structure all that much to comment on the other comment by Anomie... [03:06:22] (03CR) 10Technical 13: "Re to Anomie about 'show'" (031 comment) [core] - 10https://gerrit.wikimedia.org/r/115189 (owner: 10Gerrit Patch Uploader) [03:19:41] Technical_13: hi [03:19:49] I was referring to the other comment actually [03:20:45] Technical_13: I'm fairly sure that my patch words, but I can't find anyone else to comment about the efficientcy [03:20:49] *works [03:20:51] the database one? Yeah, I'm not familiar with what keys do what. [03:21:05] springle hasn't looked at it yet? [03:21:14] I added them as a reviewer [03:21:48] I think this could really help. Aren't there some other tools for new pages list already? [03:22:08] (03CR) 10Mattflaschen: "> I don't like the idea of having" [core] - 10https://gerrit.wikimedia.org/r/109850 (owner: 10Ori.livneh) [03:22:59] There's a tool... umm I know Cyberpower678 is on the maint for it but I don't remeber if it is an X!tool or a Quentinv57 tool or a Scottytool... [03:23:12] I want to say X! [03:28:06] ok [03:30:49] there's a link to it from {{Rfp links}} on enwp [[en:template:rfp links]] [03:30:52] !link [03:30:52] http://www.mediawiki.org/wiki/$wiki_encoded_* [03:30:58] @link [03:30:58] https://www.mediawiki.org/wiki/Template:Rfp_links http://enwp.org/template:rfp_links [03:31:27] and if I remember correctly, the tool is broken when trying to look up new pages in any namespace except =0 [03:32:20] meh.. that's not it... let me find a link [03:34:10] http://en.wikipedia.org/wiki/Template:Rfplinks http://tools.wmflabs.org/xtools/pages/index.php?name=PiRSquared17&lang=en&wiki=wikipedia&namespace=0&redirects=0 huh [03:36:39] (03PS2) 10Physikerwelt: Identification of identifiers [extensions/MathSearch] - 10https://gerrit.wikimedia.org/r/115107 [03:37:03] (03PS3) 10Physikerwelt: Identification of identifiers [extensions/MathSearch] - 10https://gerrit.wikimedia.org/r/115107 [03:39:47] (03CR) 10Physikerwelt: [C: 032 V: 032] Identification of identifiers [extensions/MathSearch] - 10https://gerrit.wikimedia.org/r/115107 (owner: 10Physikerwelt) [03:40:36] (03CR) 10Springle: [C: 031] Add 'newonly' option to Special:Contributions and related i18n message * Add to Special:Contributions * Add to i18n files * Add 'ucnewonly' (031 comment) [core] - 10https://gerrit.wikimedia.org/r/115189 (owner: 10Gerrit Patch Uploader) [03:40:51] (03CR) 10Parent5446: "You could just do a git submodule. It's really not that bad. You just have to run one extra command." [core] - 10https://gerrit.wikimedia.org/r/112699 (owner: 10BryanDavis) [03:47:15] (03CR) 10Mwjames: "Yes, I have seen the arguments but that doesn't really change the fact that either you do dependency management in a way it is supposed to" [core] - 10https://gerrit.wikimedia.org/r/112699 (owner: 10BryanDavis) [03:50:08] springle: thanks for the comment :-) [03:52:07] yw [04:01:01] Why is it that every time I spin up a new labs instance and enable role::labsnfs::client the nfs mounts fail? :( [04:02:10] Any labs roots around who can poke deployment-scap.pmtpa.wmflabs for me and get /home to mount? [04:03:12] Are you supposed to modify the release notes when you submit a patch? [04:03:48] to core [04:04:01] huh: I think the answer to that is "it depends on the patch" [04:05:06] Usually if the change is release note worth somebody will ask for it to be added [04:05:44] bd808: https://gerrit.wikimedia.org/r/115189 release note worthy? [04:05:59] Sorry, I'm kinda new to this [04:06:24] * bd808 looks [04:07:35] It adds API options and an option to Special:Contributions [04:11:38] Adding api options is probably release note worthy but Anomie could tell you for sure. [04:14:17] huh: One piece of advice I can give on release notes is to wait to add them until you're close to being done with the patch. They tend to cause conflicts on rebase that can be a pain if you are trying to keep the patch up to date with other changes in core. [04:17:21] thanks [04:17:26] for the advice [04:38:45] (03PS3) 10MZMcBride: Add 'newonly' option to Special:Contributions and related i18n message [core] - 10https://gerrit.wikimedia.org/r/115189 (owner: 10Gerrit Patch Uploader) [04:45:32] superm401: re: Config, if you have some time, could you also look at my comments about killing Config::setConfigConfig and just putting that in the constructor? [04:47:26] legoktm, I'll see if I can later. I think Tyler has stronger feelings than me on that though. [04:47:55] In my view, either could work, with some facade work in the class. [04:48:03] alright :P [04:48:41] legoktm, the constructor is probably a bit cleaner, though I don't really have any dependency injection experience in PHP (i do in other environments). So I could be wrong. [04:48:58] I'm not really sure how dependency injection works either. [04:50:06] spagewmf, sorry for the delayed response. I didn't fix it in mw.ui. However, it works if mw.ui is inside the link (which is possible with wikitext). [04:50:26] That means the mw.ui classes naturally override the wikitext. [04:50:33] Sorry, I mean override the link coloring. [04:51:13] superm401: yes, I figured that out for the new mw.org prototype. So I think the bug I filed can be WONTFIX [04:52:45] spagewmf, it's probably better to fix it if it can be done without a lot of bloat. [04:52:51] It's more friendly to template to authors to allow both ways. [04:52:53] (03CR) 10EBernhardson: [C: 032] Third level of nesting [extensions/Flow] - 10https://gerrit.wikimedia.org/r/115110 (owner: 10Matthias Mullie) [04:52:58] "to template authors" [04:53:06] (03Merged) 10jenkins-bot: Third level of nesting [extensions/Flow] - 10https://gerrit.wikimedia.org/r/115110 (owner: 10Matthias Mullie) [04:54:57] superm401: I dunno https://bugzilla.wikimedia.org/show_bug.cgi?id=61886 [05:04:45] (03CR) 10EBernhardson: [C: 031] "havnt tested. It looks better than what we have" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/115112 (owner: 10Matthias Mullie) [05:05:11] (03CR) 10EBernhardson: [C: 032] Move cutting of index data into index code [extensions/Flow] - 10https://gerrit.wikimedia.org/r/112917 (owner: 10Matthias Mullie) [05:05:22] (03Merged) 10jenkins-bot: Move cutting of index data into index code [extensions/Flow] - 10https://gerrit.wikimedia.org/r/112917 (owner: 10Matthias Mullie) [05:17:39] (03CR) 10EBernhardson: [C: 032] (Bug 61715) Make history entries look at most recent revision [extensions/Flow] - 10https://gerrit.wikimedia.org/r/114679 (owner: 10Matthias Mullie) [05:17:52] (03Merged) 10jenkins-bot: (Bug 61715) Make history entries look at most recent revision [extensions/Flow] - 10https://gerrit.wikimedia.org/r/114679 (owner: 10Matthias Mullie) [05:18:18] (03CR) 10EBernhardson: [C: 032] Get rid of references to the no longer existing .flow-icon-permalink [extensions/Flow] - 10https://gerrit.wikimedia.org/r/114990 (owner: 10Matthias Mullie) [05:18:29] (03CR) 10jenkins-bot: [V: 04-1] Get rid of references to the no longer existing .flow-icon-permalink [extensions/Flow] - 10https://gerrit.wikimedia.org/r/114990 (owner: 10Matthias Mullie) [05:22:48] (03PS2) 10EBernhardson: Get rid of references to the no longer existing .flow-icon-permalink [extensions/Flow] - 10https://gerrit.wikimedia.org/r/114990 (owner: 10Matthias Mullie) [05:23:11] (03CR) 10EBernhardson: [C: 032] "PS2: removed extra comma" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/114990 (owner: 10Matthias Mullie) [05:23:22] (03Merged) 10jenkins-bot: Get rid of references to the no longer existing .flow-icon-permalink [extensions/Flow] - 10https://gerrit.wikimedia.org/r/114990 (owner: 10Matthias Mullie) [05:24:36] (03PS2) 10Matthias Mullie: Bind to specific elements instead of random [extensions/Flow] - 10https://gerrit.wikimedia.org/r/114991 [05:24:47] (03CR) 10EBernhardson: [C: 032] Bind to specific elements instead of random [extensions/Flow] - 10https://gerrit.wikimedia.org/r/114991 (owner: 10Matthias Mullie) [05:24:50] (03CR) 10jenkins-bot: [V: 04-1] Bind to specific elements instead of random [extensions/Flow] - 10https://gerrit.wikimedia.org/r/114991 (owner: 10Matthias Mullie) [05:24:56] (03PS2) 10Matthias Mullie: Some minor optimizations when checking permissions [extensions/Flow] - 10https://gerrit.wikimedia.org/r/114992 [05:27:28] (03PS3) 10EBernhardson: Bind to specific elements instead of random [extensions/Flow] - 10https://gerrit.wikimedia.org/r/114991 (owner: 10Matthias Mullie) [05:27:59] (03CR) 10EBernhardson: [C: 032] "PS3: added missing semicolon" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/114991 (owner: 10Matthias Mullie) [05:28:10] (03Merged) 10jenkins-bot: Bind to specific elements instead of random [extensions/Flow] - 10https://gerrit.wikimedia.org/r/114991 (owner: 10Matthias Mullie) [05:29:06] (03PS3) 10Matthias Mullie: Some minor optimizations when checking permissions [extensions/Flow] - 10https://gerrit.wikimedia.org/r/114992 [05:30:32] (03CR) 10EBernhardson: [C: 032] Some minor optimizations when checking permissions [extensions/Flow] - 10https://gerrit.wikimedia.org/r/114992 (owner: 10Matthias Mullie) [05:30:44] (03Merged) 10jenkins-bot: Some minor optimizations when checking permissions [extensions/Flow] - 10https://gerrit.wikimedia.org/r/114992 (owner: 10Matthias Mullie) [05:35:08] (03PS1) 10MZMcBride: Flow: use the default link and redlink colors for usernames above posts [extensions/Flow] - 10https://gerrit.wikimedia.org/r/115339 [06:10:30] (03PS1) 10Legoktm: Remove dependence upon $wgPasswordSenderName [extensions/Echo] - 10https://gerrit.wikimedia.org/r/115341 [06:11:45] (03CR) 10Legoktm: "Erk, this kinda broke Echo :/" [core] - 10https://gerrit.wikimedia.org/r/115206 (owner: 10Bartosz Dziewoński) [06:12:21] (03CR) 10TTO: "Yeah, I was just going to say, don't just go round randomly removing stuff from core... you never know what extensions might be using it." [core] - 10https://gerrit.wikimedia.org/r/115206 (owner: 10Bartosz Dziewoński) [06:16:50] (03CR) 10TTO: "I should add that the "Contest" extension also uses this variable." [core] - 10https://gerrit.wikimedia.org/r/115206 (owner: 10Bartosz Dziewoński) [06:26:35] Arrgghh! The same gerrit issue again :\ [06:28:22] (03PS3) 10Prtksxna: [WIP] Flip the starting point of the popup if its on the right side of the screen [extensions/Popups] - 10https://gerrit.wikimedia.org/r/115187 [06:28:24] (03PS3) 10Prtksxna: Limit image size for portrait popups [extensions/Popups] - 10https://gerrit.wikimedia.org/r/115186 [06:28:26] (03PS3) 10Prtksxna: [WIP] Flip the arrow position if the popup is flipped [extensions/Popups] - 10https://gerrit.wikimedia.org/r/115188 [06:28:33] Eggcelent! [06:34:28] (03PS2) 10Legoktm: jquery.delayedBind → jquery.throttle-debounce [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/115222 (owner: 10Bartosz Dziewoński) [06:35:41] (03CR) 10Legoktm: [C: 032] "Thanks, works perfectly. I incremented the version number for the b/c breakage." [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/115222 (owner: 10Bartosz Dziewoński) [06:35:48] (03Merged) 10jenkins-bot: jquery.delayedBind → jquery.throttle-debounce [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/115222 (owner: 10Bartosz Dziewoński) [06:38:35] Parent5446 is from NY, right? [07:12:43] can someone help me how to solve this rebase problem ... 111735 ... my git-ish is a bit rusty :D [08:08:56] (03CR) 10Nikerabbit: """"" [core] - 10https://gerrit.wikimedia.org/r/112699 (owner: 10BryanDavis) [08:24:24] (03PS1) 10Aude: Add visibility to DifferenceEngine methods [core] - 10https://gerrit.wikimedia.org/r/115347 [08:37:29] (03CR) 10QChris: "This change got merged upstream." [gerrit] (wmf) - 10https://gerrit.wikimedia.org/r/115316 (owner: 10QChris) [08:38:11] (03PS5) 10Umherirrender: Document $wgResourceLoaderMaxage in DefaultSettings.php [core] - 10https://gerrit.wikimedia.org/r/110637 [08:39:43] (03PS6) 10Krinkle: Document $wgResourceLoaderMaxage in DefaultSettings.php [core] - 10https://gerrit.wikimedia.org/r/110637 (owner: 10Umherirrender) [08:39:54] (03CR) 10Krinkle: [C: 032] "grammar fix" [core] - 10https://gerrit.wikimedia.org/r/110637 (owner: 10Umherirrender) [08:41:22] (03CR) 10Krinkle: [C: 031] "@Mark: Oops! I blame the trailing line comments that should not be." [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/114697 (owner: 1001tonythomas) [08:44:10] (03Merged) 10jenkins-bot: Document $wgResourceLoaderMaxage in DefaultSettings.php [core] - 10https://gerrit.wikimedia.org/r/110637 (owner: 10Umherirrender) [08:45:59] (03CR) 10Krinkle: "Global search https://github.com/search?q=%22mediawiki.ui%22+%40wikimedia&type=Code&ref=searchresults" [core] - 10https://gerrit.wikimedia.org/r/114080 (owner: 10Mattflaschen) [08:46:03] (03CR) 10Krinkle: [C: 031] Remove button styles from mediawiki.ui [core] - 10https://gerrit.wikimedia.org/r/114080 (owner: 10Mattflaschen) [08:46:48] (03CR) 10Krinkle: [C: 031] "Needs rebase to resolve merge conflict." [core] - 10https://gerrit.wikimedia.org/r/94614 (owner: 1001tonythomas) [08:54:38] (03PS1) 10Gerrit Patch Uploader: Workaround for scrolling bug in IE8 [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/115349 [08:54:47] (03CR) 10Gerrit Patch Uploader: "This commit was uploaded using the Gerrit Patch Uploader [1]." [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/115349 (owner: 10Gerrit Patch Uploader) [08:56:58] (03CR) 10Krinkle: Fix jsduck docstring for mw.Api ajax() (034 comments) [core] - 10https://gerrit.wikimedia.org/r/114002 (owner: 10Gergő Tisza) [08:57:04] (03PS3) 10Krinkle: mediawiki.api: Fix documentation of ajax() to mention exposed jqXHR [core] - 10https://gerrit.wikimedia.org/r/114002 (owner: 10Gergő Tisza) [08:57:08] (03CR) 10Parent5446: [C: 04-1] "Good first step. Left some inline comments." (039 comments) [extensions/OpenBadges] - 10https://gerrit.wikimedia.org/r/115238 (owner: 10Aizhuli90) [09:00:22] (03PS3) 10Krinkle: Fix compatibility with MW 1.22, PHP 5.4 and Firefox 26 [extensions/Drafts] - 10https://gerrit.wikimedia.org/r/105200 (owner: 10Gomoko) [09:05:01] (03CR) 10Krinkle: Fix compatibility with MW 1.22, PHP 5.4 and Firefox 26 (031 comment) [extensions/Drafts] - 10https://gerrit.wikimedia.org/r/105200 (owner: 10Gomoko) [09:27:16] Is the stuff coming from the MediaWikiAPI considered "Untrusted Data"? [09:35:07] (03CR) 10Krinkle: Avoid failing if calling the exposed mw.page.watch.updateWatchLink (031 comment) [core] - 10https://gerrit.wikimedia.org/r/111796 (owner: 10Thiemo Mättig (WMDE)) [09:36:14] (03CR) 10Matthias Mullie: "There hasn't been any activity on this patch for awhile, but the commit message still says WIP." [extensions/Flow] - 10https://gerrit.wikimedia.org/r/107411 (owner: 10Legoktm) [09:37:01] (03CR) 10Krinkle: [C: 04-1] Avoid failing if calling the exposed mw.page.watch.updateWatchLink (031 comment) [core] - 10https://gerrit.wikimedia.org/r/111796 (owner: 10Thiemo Mättig (WMDE)) [09:39:09] (03Abandoned) 10Krinkle: ResourceLoader: Pass printable parameter to load.php. [core] - 10https://gerrit.wikimedia.org/r/69276 (owner: 10Mattflaschen) [09:47:34] legoktm: What's CommonMessages? [09:48:08] (03PS1) 10MaxSem: Add license information [extensions/wikihiero] - 10https://gerrit.wikimedia.org/r/115352 [09:48:16] ori, thx for Vagrant hhvm fix. I fetched latest vagrant, FYI config.vm.box_download_insecure requires a recent vagrant, and Ubuntu machines don't have nfsd configured by default [10:01:48] (03PS1) 10Tpt: Adds a beginning of parser tests [extensions/ProofreadPage] - 10https://gerrit.wikimedia.org/r/115356 [10:01:57] (03CR) 10jenkins-bot: [V: 04-1] Adds a beginning of parser tests [extensions/ProofreadPage] - 10https://gerrit.wikimedia.org/r/115356 (owner: 10Tpt) [10:03:38] !ping [10:03:38] Pong. [10:04:00] is anyone having problems with wm-bot? I received a weird bug report this morning [10:07:20] (03PS1) 10Hashar: Create job operations-debs-archiva-debian-glue [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/115357 [10:08:35] (03CR) 10Hashar: [C: 032] "That creates http://integration.wikimedia.org/ci/job/operations-debs-archiva-debian-glue :-]" [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/115357 (owner: 10Hashar) [10:08:55] (03Merged) 10jenkins-bot: Create job operations-debs-archiva-debian-glue [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/115357 (owner: 10Hashar) [10:09:30] (03PS1) 10Hashar: Trigger operations-debs-archiva-debian-glue [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/115358 [10:10:00] (03CR) 10Hashar: [C: 032] "And lets trigger the Jenkins job from Zuul :-]" [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/115358 (owner: 10Hashar) [10:10:05] (03Merged) 10jenkins-bot: Trigger operations-debs-archiva-debian-glue [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/115358 (owner: 10Hashar) [10:18:42] (03PS4) 10Prtksxna: Flip the starting point of the popup if its on the right side of the screen [extensions/Popups] - 10https://gerrit.wikimedia.org/r/115187 [10:18:44] (03PS4) 10Prtksxna: Limit image size for portrait popups [extensions/Popups] - 10https://gerrit.wikimedia.org/r/115186 [10:18:46] (03PS4) 10Prtksxna: Flip the arrow position if the popup is flipped [extensions/Popups] - 10https://gerrit.wikimedia.org/r/115188 [10:23:15] (03CR) 10Nemo bis: "Hi, thanks for your first (non-test) patch (you can click "abandon" on the test patch). In case you missed it, the link on how to upload a" [extensions/OpenBadges] - 10https://gerrit.wikimedia.org/r/115238 (owner: 10Aizhuli90) [10:47:29] (03CR) 10Hashar: "We have a bug in Gerrit 2.8.1 which cause it to gives wrong information to Zuul and it can't find out whether the user is trusted or not (" [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/110881 (owner: 10Se4598) [10:48:00] (03PS3) 10Hashar: CirrusSearch dependencies for tests [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/115199 [10:48:37] (03CR) 10Hashar: [C: 032] "Has been deployed. The failures where from TimedMediaHandler for which I got some workaround set and bug filled to get the tests fixed." [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/115199 (owner: 10Hashar) [10:48:54] (03Merged) 10jenkins-bot: CirrusSearch dependencies for tests [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/115199 (owner: 10Hashar) [11:07:40] (03CR) 10Aklapper: [C: 032 V: 032] +sidebar userscript [wikimedia/bugzilla/triagescripts] - 10https://gerrit.wikimedia.org/r/105618 (owner: 10Merlijn van Deen) [11:10:01] I have installed git-review but I don't see any git-review/git-review.conf in .config folder [11:10:02] any reason? [11:43:59] (03CR) 10MaxSem: [C: 032] Add license information [extensions/wikihiero] - 10https://gerrit.wikimedia.org/r/115352 (owner: 10MaxSem) [11:44:08] (03Merged) 10jenkins-bot: Add license information [extensions/wikihiero] - 10https://gerrit.wikimedia.org/r/115352 (owner: 10MaxSem) [11:51:06] (03PS1) 10Addshore: Remove doc about a file that doesnt exist [core] - 10https://gerrit.wikimedia.org/r/115367 [11:52:19] (03CR) 10Aude: [C: 032] Remove doc about a file that doesnt exist [core] - 10https://gerrit.wikimedia.org/r/115367 (owner: 10Addshore) [11:55:53] (03Merged) 10jenkins-bot: Remove doc about a file that doesnt exist [core] - 10https://gerrit.wikimedia.org/r/115367 (owner: 10Addshore) [11:56:00] (03CR) 10Helder.wiki: Ticking 'Search in all namespaces' in prefs should disable other checkboxes (031 comment) [core] - 10https://gerrit.wikimedia.org/r/110610 (owner: 1001tonythomas) [12:04:27] for https://bugzilla.wikimedia.org/show_bug.cgi?id=30959 manipulating the showCustomIntro on page 2111 in /includes/EditPage.php https://doc.wikimedia.org/mediawiki-core/master/php/html/EditPage_8php_source.html as http://pastebin.com/1v6XtYAw works?? [12:05:21] (03CR) 10Helder.wiki: Don't use parsed wikitext when dealing with CSS/JS (032 comments) [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/115214 (owner: 10Chad) [12:17:23] (03CR) 10Nikerabbit: Add license information (031 comment) [extensions/wikihiero] - 10https://gerrit.wikimedia.org/r/115352 (owner: 10MaxSem) [12:17:55] (03CR) 10Bartosz Dziewoński: "Hmph. We might have done this too quickly… should we revert this?" [core] - 10https://gerrit.wikimedia.org/r/115206 (owner: 10Bartosz Dziewoński) [12:17:57] (03CR) 10Bartosz Dziewoński: [C: 032] Remove dependence upon $wgPasswordSenderName [extensions/Echo] - 10https://gerrit.wikimedia.org/r/115341 (owner: 10Legoktm) [12:18:06] (03Merged) 10jenkins-bot: Remove dependence upon $wgPasswordSenderName [extensions/Echo] - 10https://gerrit.wikimedia.org/r/115341 (owner: 10Legoktm) [12:26:27] (03PS4) 10Brian Wolff: Don't insert timestamp if parsing time failed [extensions/Popups] - 10https://gerrit.wikimedia.org/r/114710 [12:26:30] (03CR) 10Gilles: [C: 032] Fix ForeignDBViaLBRepo favicon [core] - 10https://gerrit.wikimedia.org/r/115314 (owner: 10Gergő Tisza) [12:26:51] (03CR) 10PiRSquared17: "MZM, does this look good?" [core] - 10https://gerrit.wikimedia.org/r/115189 (owner: 10Gerrit Patch Uploader) [12:30:12] (03Merged) 10jenkins-bot: Fix ForeignDBViaLBRepo favicon [core] - 10https://gerrit.wikimedia.org/r/115314 (owner: 10Gergő Tisza) [12:30:35] (03CR) 10Matthias Mullie: [C: 04-1] "This only removes the variable declaration. Less files using the variable will fail to compile." [extensions/Flow] - 10https://gerrit.wikimedia.org/r/115339 (owner: 10MZMcBride) [12:30:47] (03PS2) 10Matthias Mullie: Flow: use the default link and redlink colors for usernames above posts [extensions/Flow] - 10https://gerrit.wikimedia.org/r/115339 (owner: 10MZMcBride) [12:31:07] (03CR) 10Matthias Mullie: [C: 031] "LGTM - merge at will" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/115339 (owner: 10MZMcBride) [12:34:35] (03PS18) 1001tonythomas: Removed 'Remember my login' preference [core] - 10https://gerrit.wikimedia.org/r/94614 [12:36:00] (03CR) 10Bartosz Dziewoński: [C: 032] Flow: use the default link and redlink colors for usernames above posts [extensions/Flow] - 10https://gerrit.wikimedia.org/r/115339 (owner: 10MZMcBride) [12:36:13] (03Merged) 10jenkins-bot: Flow: use the default link and redlink colors for usernames above posts [extensions/Flow] - 10https://gerrit.wikimedia.org/r/115339 (owner: 10MZMcBride) [12:41:13] (03PS2) 10Gerrit Patch Uploader: Workaround for a scrolling bug in IE8 [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/115349 [12:41:20] (03CR) 10Gerrit Patch Uploader: "This commit was uploaded using the Gerrit Patch Uploader [1]." [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/115349 (owner: 10Gerrit Patch Uploader) [12:46:35] (03CR) 10Parent5446: [C: 031] Removed 'Remember my login' preference [core] - 10https://gerrit.wikimedia.org/r/94614 (owner: 1001tonythomas) [12:59:15] (03PS1) 1001tonythomas: Improved way to tick all namespaces when Select all is ticked [core] - 10https://gerrit.wikimedia.org/r/115373 [13:01:26] (03CR) 1001tonythomas: "Check https://gerrit.wikimedia.org/r/#/c/115373/ for improved version" (031 comment) [core] - 10https://gerrit.wikimedia.org/r/110610 (owner: 1001tonythomas) [13:04:03] what should I do if my port 29418 is blocked??? [13:04:50] (03PS1) 10Odder: Namespace translation for Urdu [extensions/Scribunto] - 10https://gerrit.wikimedia.org/r/115374 [13:07:08] (03CR) 10Technical 13: [C: 031] "Still looks good to me." [core] - 10https://gerrit.wikimedia.org/r/115189 (owner: 10Gerrit Patch Uploader) [13:09:32] (03CR) 10PiRSquared17: [C: 031] "+1, but is this releasenotes-worthy?" [core] - 10https://gerrit.wikimedia.org/r/115189 (owner: 10Gerrit Patch Uploader) [13:17:59] (03CR) 10Technical 13: [C: 031] "Tested it on enwp in console on Firefox, and it seems to work just fine and I don't see anything obviously wrong with the code." [core] - 10https://gerrit.wikimedia.org/r/115373 (owner: 1001tonythomas) [13:24:12] (03CR) 10Technical 13: "It adds a new checkbox/feature to Special:Contribs and it adds a new function to the API, I'd say yes." [core] - 10https://gerrit.wikimedia.org/r/115189 (owner: 10Gerrit Patch Uploader) [13:30:47] anyone around know mediawiki vagrant? anyone ever had success getting it to run jobs embedded in the web process (the default)? [13:32:17] manybubbles|away: I could configure it to run browsertests [13:32:24] (03CR) 10Bartosz Dziewoński: [C: 032] "Thanks, I could reproduce this, and the patch does seem to fix the issue! Fascinating." [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/115349 (owner: 10Gerrit Patch Uploader) [13:32:29] (03Merged) 10jenkins-bot: Workaround for a scrolling bug in IE8 [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/115349 (owner: 10Gerrit Patch Uploader) [13:32:35] tonythomas: thanks [13:33:37] manybubbles: np [13:42:17] (03CR) 10Helder.wiki: [C: 031] Improved way to tick all namespaces when Select all is ticked [core] - 10https://gerrit.wikimedia.org/r/115373 (owner: 1001tonythomas) [13:46:47] (03PS2) 1001tonythomas: Add new Hook 'SendWatchlistEmailNotification'. [core] - 10https://gerrit.wikimedia.org/r/114682 (owner: 10Bsitu) [13:47:46] (03CR) 1001tonythomas: "rebased the change." [core] - 10https://gerrit.wikimedia.org/r/114682 (owner: 10Bsitu) [13:48:53] (03CR) 10Bartosz Dziewoński: [C: 032] Improved way to tick all namespaces when Select all is ticked [core] - 10https://gerrit.wikimedia.org/r/115373 (owner: 1001tonythomas) [13:51:06] (03PS1) 10Prtksxna: Make animation mixin cleaner [extensions/Popups] - 10https://gerrit.wikimedia.org/r/115376 [13:52:16] (03Merged) 10jenkins-bot: Improved way to tick all namespaces when Select all is ticked [core] - 10https://gerrit.wikimedia.org/r/115373 (owner: 1001tonythomas) [14:10:25] Does one need special permissions to push a path to mediawiki core? [14:11:03] A patchset for review I mean [14:11:49] (03PS4) 10Manybubbles: Setup jenkins configuration [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/115193 [14:12:00] (03CR) 10Manybubbles: "Lets try again after some new configuration." [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/115193 (owner: 10Manybubbles) [14:13:38] (03CR) 10jenkins-bot: [V: 04-1] Setup jenkins configuration [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/115193 (owner: 10Manybubbles) [14:15:51] (03PS1) 10Prtksxna: mediawiki.less: Use less mixin to reduce code repetition in animation [core] - 10https://gerrit.wikimedia.org/r/115377 [14:20:06] (03CR) 10Prtksxna: [C: 04-1] Embedding Static Map to UploadWizard (031 comment) [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/107892 (owner: 10Inchikutty) [14:22:29] (03CR) 10Thiemo Mättig (WMDE): [C: 031] Avoid failing if calling the exposed mw.page.watch.updateWatchLink (032 comments) [core] - 10https://gerrit.wikimedia.org/r/111796 (owner: 10Thiemo Mättig (WMDE)) [14:27:04] (03PS5) 10Manybubbles: Setup jenkins configuration [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/115193 [14:40:51] (03CR) 10Manybubbles: [C: 04-1] "I aborted the jenkins job and it counted as a success. It was failing badly." [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/115193 (owner: 10Manybubbles) [14:41:22] (03CR) 10Matthias Mullie: [C: 04-1] "Looks mostly good. I'm happy with the Block improvements in here." (034 comments) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/109431 (owner: 10Bsitu) [14:41:55] (03PS1) 10Gerrit Patch Uploader: Workaround for a scrolling bug in IE8 on resize [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/115378 [14:42:01] (03CR) 10Gerrit Patch Uploader: "This commit was uploaded using the Gerrit Patch Uploader [1]." [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/115378 (owner: 10Gerrit Patch Uploader) [14:42:29] rdwrer: There are some more SVG related changes that I'd like you to take a look at https://gerrit.wikimedia.org/r/#/c/115188/ https://gerrit.wikimedia.org/r/#/c/115186/ Let me know whether you'll have the time! [14:48:50] (03PS6) 10Manybubbles: Setup jenkins configuration [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/115193 [14:52:48] (03CR) 10MaxSem: Add license information (031 comment) [extensions/wikihiero] - 10https://gerrit.wikimedia.org/r/115352 (owner: 10MaxSem) [15:06:49] (03PS1) 10Anomie: Remove STRAIGHT_JOIN from ApiQueryLogEvents [core] - 10https://gerrit.wikimedia.org/r/115381 [15:13:50] (03PS2) 10Manybubbles: WIP:1.0 updates [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/115215 [15:24:24] (03CR) 10Krinkle: Avoid failing if calling the exposed mw.page.watch.updateWatchLink (031 comment) [core] - 10https://gerrit.wikimedia.org/r/111796 (owner: 10Thiemo Mättig (WMDE)) [15:34:29] (03CR) 10Anomie: Add 'newonly' option to Special:Contributions and related i18n message (032 comments) [core] - 10https://gerrit.wikimedia.org/r/115189 (owner: 10Gerrit Patch Uploader) [15:37:30] (03CR) 10Nikerabbit: Add license information (032 comments) [extensions/wikihiero] - 10https://gerrit.wikimedia.org/r/115352 (owner: 10MaxSem) [15:42:49] Nikerabbit, ping [15:43:41] (03CR) 10Nikerabbit: [C: 032] Namespace translation for Urdu [extensions/Scribunto] - 10https://gerrit.wikimedia.org/r/115374 (owner: 10Odder) [15:43:58] MaxSem: pon [15:44:03] y [15:44:49] so the only mention of GPL at https://en.wikipedia.org/wiki/Special:Version is in the GPLv2 form [15:45:01] vák [15:45:44] (03Merged) 10jenkins-bot: Namespace translation for Urdu [extensions/Scribunto] - 10https://gerrit.wikimedia.org/r/115374 (owner: 10Odder) [15:45:59] (03CR) 10Krinkle: Avoid failing if calling the exposed mw.page.watch.updateWatchLink (031 comment) [core] - 10https://gerrit.wikimedia.org/r/111796 (owner: 10Thiemo Mättig (WMDE)) [15:49:02] (03CR) 10Krinkle: [C: 031] mediawiki.api: Fix documentation of ajax() to mention exposed jqXHR [core] - 10https://gerrit.wikimedia.org/r/114002 (owner: 10Gergő Tisza) [15:49:43] MaxSem: only one though [15:49:51] MaxSem: I'm using http://spdx.org/licenses/ everywhere [15:50:31] yep:) so I'd like to establish a convention sooner rather than later [15:51:00] (03CR) 10Krinkle: "It's not just about reviewing code quality of 12 lines. It's also about reproducing the actual bug, ensuring that bug is fixed afterwards," [core] - 10https://gerrit.wikimedia.org/r/109124 (owner: 10Bartosz Dziewoński) [15:51:15] Nikerabbit, these are machine-readable identifiers [15:51:56] MaxSem: you can also use the full name ;) Though you might find it too long for the column [15:52:12] nice, there is WTFPL too [15:52:15] localize them?:) [15:52:26] Nemo_bis, guess who's spreading it [15:53:26] Anyone else getting "A database query error has occurred. This may indicate a bug in the software." after updating core lately? [15:53:27] (03PS1) 10Hashar: Tweak browsertests URLs [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/115387 [15:53:35] Getting it on the main page unconditionally it seems [15:54:17] what query Krinkle? [15:54:52] User::loadFromDatabase localhost 1054 Unknown column 'user_password_expires' in 'field list' (localhostSELECT user_id,user_name,user_real_name,user_password,user_newpassword,user_newpass_time,user_email,user_touched,user_token,user_email_authenticated,user_email_token,user_email_token_expires,user_password_expires,user_registration,user_editcount FROM `user` WHERE user_id = '1' LIMIT 1 [15:55:30] Works after runnig update.php but this sounds like a serious problem [15:55:47] Things shouldn't break that fatally with a slightly updated schema [15:55:53] what, people not following upgrade instructions?;) [15:56:08] There should be at least several weeks between a breaking change like that and the clean up in the schema [15:56:30] how else can we deploy? [15:56:37] well [15:56:51] these changes were applied on WMF before it was merged [15:57:47] yup, but nobody told 3rd parties running on master... [15:57:55] the order should be: Code doesn't use column anymore and remove from install schema, (> 1 week time), sql patch in update.php to drop column as clean up [15:58:20] Ah, this is a new column? [15:58:46] I'd guess it is new [15:58:51] it is [15:59:03] Still not ideal, but whatev. SNAFU enough that I don't have time for it. [15:59:28] Nikerabbit, so how about localising the license names?:) [15:59:35] Hm. https://www.mediawiki.org/wiki/Development_policy#Database_patches [15:59:55] MaxSem: PITA; how about removing them? [16:00:28] I wonder how many of those are in WikimediaMessages. [16:02:39] (03CR) 10BryanDavis: "> What are these requirements exactly? Bundling code directly does not mean that it will get reviewed." [core] - 10https://gerrit.wikimedia.org/r/112699 (owner: 10BryanDavis) [16:04:28] Nikerabbit: my fork of https://www.mediawiki.org/wiki/Extension:MessageCommons [16:04:42] Nikerabbit: I'll upload the code later today [16:04:48] (03PS4) 10Krinkle: mediawiki.notification: Hide #mw-notification-area when it's empty [core] - 10https://gerrit.wikimedia.org/r/109124 (owner: 10Bartosz Dziewoński) [16:05:02] legoktm: just wondering what's the use case [16:05:04] (03PS5) 10Bartosz Dziewoński: mediawiki.notification: Hide #mw-notification-area when it's empty [core] - 10https://gerrit.wikimedia.org/r/109124 [16:05:11] (03CR) 10Krinkle: [C: 031] mediawiki.notification: Hide #mw-notification-area when it's empty [core] - 10https://gerrit.wikimedia.org/r/109124 (owner: 10Bartosz Dziewoński) [16:05:11] for shoutwiki [16:05:33] * MatmaRex stabs Krinkle with a +1 [16:05:39] (03CR) 10Krinkle: "Added release notes. +1 or amend when they're good to go." [core] - 10https://gerrit.wikimedia.org/r/109124 (owner: 10Bartosz Dziewoński) [16:06:01] legoktm: is it doing something similar to what can be done with https://gerrit.wikimedia.org/r/#/c/98078/ ? [16:06:03] Hm.. no 1-22 notes? Do we no longer backport? [16:06:16] as in, sharing translated messages in a farm [16:06:17] legoktm: oh, sounds better than having thousands ns8 pages multiplied by thousands wikis as done by editthis :P [16:06:36] Krinkle: i generally assume mark and markus will figure that part out [16:06:43] Krinkle: notes? what are those? things you take at lectures? [16:06:47] Krinkle: i think you accidentally a word in the release notes [16:07:23] MatmaRex: The practice last I checked is to write the commit in master. If there is no 1-22 file in master, that means there is no where for them to go. If I put them in 1-23 then they'll have to be removed after the backport. [16:07:32] Nikerabbit: right, it uses that hook. the main part of the extension is just a script that exports ns8 to JSON files [16:07:37] I'll just post the code now :P [16:07:59] Anyway, I assume someone put this in place and they can figure it out. [16:07:59] legoktm: looking forward to it ;) [16:08:06] Krinkle: this would be easier if our release managers were reachable on irc daily :/ [16:08:20] also, are we backporting that? [16:08:59] (or, if our release notes process didn't suck, but no one wants to implement the solution i created) [16:09:21] Hm? IRC helps release notes? [16:09:32] Nemo_bis: no, but it helps coordination [16:09:44] Coordination helps release notes? [16:10:01] * Nemo_bis suspects nothing can help release notes [16:10:14] (03PS6) 10Bartosz Dziewoński: mediawiki.notification: Hide #mw-notification-area when it's empty [core] - 10https://gerrit.wikimedia.org/r/109124 [16:10:34] yes, it makes for less moving things between files on multiple branches [16:10:37] (03CR) 10Krinkle: [C: 032] mediawiki.notification: Hide #mw-notification-area when it's empty [core] - 10https://gerrit.wikimedia.org/r/109124 (owner: 10Bartosz Dziewoński) [16:10:41] (03CR) 10PiRSquared17: [C: 04-1] Add 'newonly' option to Special:Contributions and related i18n message [core] - 10https://gerrit.wikimedia.org/r/115189 (owner: 10Gerrit Patch Uploader) [16:10:45] thanks Krinkle [16:10:53] i have more trivial patches, btw. [16:11:26] (03CR) 10PiRSquared17: "oops" (033 comments) [core] - 10https://gerrit.wikimedia.org/r/115189 (owner: 10Gerrit Patch Uploader) [16:12:16] until we had release managers, the proces was to keep release notes for active release branches in master, just like all other files we actively make changes to. That way all changes are in master, the backport is a clean cherry-pick, and there it's pretty straight forward in that you wouldn't accidentally end up with no release notes for a change, or double ones (one in 1.22.x and again in 1.23.0) [16:12:31] (03CR) 10Bartosz Dziewoński: "> No no, sorry about the naming but commonPrint has nothing to do with the common{Elements,Content,Interface} styles. It should always be " [core] - 10https://gerrit.wikimedia.org/r/114984 (owner: 10Bartosz Dziewoński) [16:13:13] Krinkle: the problem is that this requires people agreeing on whether to backport a patch before it's merged [16:13:32] That's never been a problem, those decisions are pretty uncontroversial. [16:13:34] Krinkle: and i don't think i've ever seen anyone respond to a flag request for release version on bugzilla, for example [16:13:55] What's a "a flag request for release version"? [16:14:05] I think I'm the only person responding to those [16:14:14] If you mean the backport to stable flag [16:14:20] uh, yes [16:14:36] Maybe we should add more people to the notification for that [16:14:37] another issue is that there's just htis one flag, and we have two supported versions at any time [16:14:38] (03Merged) 10jenkins-bot: mediawiki.notification: Hide #mw-notification-area when it's empty [core] - 10https://gerrit.wikimedia.org/r/109124 (owner: 10Bartosz Dziewoński) [16:14:51] Doesn't sound an issue [16:14:59] it does for me [16:15:05] Why [16:15:17] because it's not clear what the requestee is requesting, duh [16:15:18] We only have one target milestone only, too [16:15:29] That's what comments are for, I'm told [16:15:41] i dislike lack of structure [16:15:44] I found the introduction of that flag rather confusing. We have too many labels and stuff going on. I always used Target Milestone for that, seemed to work pretty well. [16:16:14] speaking of which, mglaser said this morning that perhaps they'll start using it [16:16:19] Bug opened, target determined, patch written, the merger is responsibility for backporting as well, done. [16:16:34] s/done/closed+resolved/ [16:16:47] You can propose changes to the process on the talk page [16:17:03] (03PS1) 10Legoktm: Initial commit of code [extensions/CommonMessages] - 10https://gerrit.wikimedia.org/r/115390 [16:17:06] we should totally document the process, whatever it is [16:17:07] Nikerabbit: ^ [16:17:10] or document that there is none [16:17:12] it's already documented [16:17:17] link? [16:17:37] The main problem before the flag was that when stuff is fixed in master the bug is marked RESOLVED FIXED and everyone loses track of it [16:17:45] generally in the past, things were only backported if i backported them myself [16:17:52] https://www.mediawiki.org/wiki/Backporting_fixes [16:17:57] Not hard to find. :) [16:18:04] and i don't like being the sole person making the decision, etc. [16:18:15] Do you mean your things or all things [16:18:20] all things [16:18:24] Nemo_bis: No, for a large part (in my observation) is that the bug is marked fixed when it is merged, and the merger should create cherry-picks for backports right afterwards and merge those. [16:18:26] i was hoping the release managers would help with that, but they don't [16:18:36] (other than security fixes, which chris does of course) [16:18:57] Krinkle: talk page is available [16:18:58] There wasn't a difference between it being fixed in master and not yet backported, that's only someone forgetting to finish the merge. [16:19:19] Krinkle: you're the only person I ever saw applying this process [16:19:28] Nemo_bis: that page does notdocument the current state as far as i can tell [16:19:29] It's the Krinkle-merge, not a MediaWiki thing [16:19:32] Don't have time or priority for that. If it works for them, fine by me. If they need us to do part of the release workflow, I'd be happy to do that with everyone else when they tell us to. [16:19:35] MatmaRex: it does [16:19:36] i've never seen this done [16:19:45] "This" what? [16:20:02] the backport_to_stable flag, the release manager determining, etc [16:20:10] the only person who srets that flag is, again, myself [16:20:12] sets* [16:20:15] well, i used to, i stopped [16:20:29] MatmaRex: sets the flag to what? [16:20:49] "Someone proposes it to be backported to the Stable/Supported versions of MediaWiki by setting the "Backport_to_Stable" flag to "?" on the bug." [16:20:55] Krinkle: if you do backports with your own process that's fine too. :) As long as the fields and values have the same meaning for everyone. [16:21:10] MatmaRex: are you saying you're the only person asking backports? [16:21:29] Nemo_bis: i've never seen such requests, and i've never seen them fulfilled, frankly [16:21:35] am i very wrong? [16:21:43] MatmaRex: why would you see them? Are you among the notified people? [16:21:55] Do you do queries on that flag? :) [16:22:03] no, but i follow a couple thousand bugs by now, i think [16:22:08] and i read the backlog on #mediawiki [16:22:27] I regularly receive notifications for those [16:22:33] and i've merged hundreds of changes, haven't seen them cherry-picked [16:22:53] backports are the exception [16:23:20] which is kind of my point, we don't backport almost anything [16:24:04] we don't even fix issues like, i dunno, an extension shipped by default throwing fatals if you enable it (remember 1.21?) [16:24:34] AFAIK we don't fix those in master either [16:24:41] or, i dunno, the release notes saying that this is not a release yet (that's 1.22) [16:24:42] I mean, every release breaks all extensions [16:24:54] Nemo_bis: that's not what i meant [16:25:02] Nemo_bis: we shipped an incompatible version of Vector in the tarball [16:25:08] it fataled when you enabled it [16:25:18] this was, as far as i know, never fixed [16:25:28] there was a bug filed against the appropriate version [16:25:55] I'm not sure how this relates to the backport process [16:26:21] tangenially, but it has somewhat shattered my faith in our release process [16:26:24] Probably that RELX_Y branch should have been at an earlier revision? [16:26:33] The release process is thoroughly broken [16:26:35] also 1.22.1 breaking SMW [16:26:50] Krinkle: still around? can i ask you to make an executive decision on https://gerrit.wikimedia.org/r/#/c/114984/ ? [16:26:53] legoktm: more than 1.22.0 that is? [16:27:07] Krinkle: dantman and i disagree on certain skinning-related things, you're probably the best person to provide a third opinion [16:27:31] Nemo_bis: yes, a public method was made private or something [16:27:48] (that was basically a botched backport) [16:27:57] MatmaRex: what public method? [16:28:01] (and is one of the reason why i want someone to check all the backports, including mine) [16:28:04] Nemo_bis: 1.22.1 had a backported patch from 1.23 which changed the visibility of a variable from public to protected, no one noticed that that part of the change was reverted in master, and no one tested it with SMW either... [16:28:06] there's a bug about that, i don't remember [16:28:15] Nemo_bis: https://bugzilla.wikimedia.org/show_bug.cgi?id=60054 [16:28:18] (03CR) 10Nikerabbit: Initial commit of code (036 comments) [extensions/CommonMessages] - 10https://gerrit.wikimedia.org/r/115390 (owner: 10Legoktm) [16:28:20] Let's see, I found 54 "Backport_to_Stable requested" emails in my trash [16:28:52] legoktm: right, that's the kind of stuff which should see a rejection of a backport request :) [16:29:15] Nikerabbit: ty :) [16:30:23] legoktm: TranslateUtils::getMessageContent (or something like that) might be useful comparison for you [16:30:23] meh, https://bugzilla.wikimedia.org/show_bug.cgi?id=57026 is not even marked fixed, what was the patch backported for? hmm [16:31:43] Nikerabbit: thanks, I'll take a look [16:34:00] (03PS4) 10Hashar: Browser tests jobs for CirrusSearch [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/115164 [16:34:03] (03CR) 10jenkins-bot: [V: 04-1] Browser tests jobs for CirrusSearch [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/115164 (owner: 10Hashar) [16:36:58] (03PS5) 10Hashar: Browser tests jobs for CirrusSearch [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/115164 [16:38:02] MatmaRex: FYI you seem to have originated 10 % of backport requests in the last few months, with me and Andre at 20 % each [16:38:14] heh [16:39:39] More worrying is that we have some backport requests which are one year old against two releases abovve [16:41:19] But there wasn't any actual response to http://lists.wikimedia.org/pipermail/mediawiki-l/2014-February/042476.html [16:43:04] I really expect our Tarball Release Managers to look at them. [16:43:14] plus there's a shared search for that in Bugzilla too. [16:44:02] (03CR) 10PiRSquared17: "@anomie" (031 comment) [core] - 10https://gerrit.wikimedia.org/r/115189 (owner: 10Gerrit Patch Uploader) [16:44:27] (03PS1) 10Cmcmahon: Needs latest mediawiki_selenium to talk to SauceLab [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/115394 [16:45:22] (03PS2) 10Hashar: Tweak browsertests URLs [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/115387 [16:45:27] (03PS6) 10Hashar: Browser tests jobs for CirrusSearch [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/115164 [16:45:41] (03CR) 10Cmcmahon: [C: 032] Needs latest mediawiki_selenium to talk to SauceLab [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/115394 (owner: 10Cmcmahon) [16:45:50] (03Merged) 10jenkins-bot: Needs latest mediawiki_selenium to talk to SauceLab [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/115394 (owner: 10Cmcmahon) [16:45:59] Nemo_bis, maybe you could point to your email about backporting as a reply to the "Monthly point releases" thread on wikitech-l? Just an diea [16:46:02] *idea [16:47:05] I don't believe in wikitech-l [16:47:30] Hi Nemo_bis. I shall have to look at logs to understand that statement :) [16:48:17] Nemo_bis, still it's a very related discussion (monthly tarball releases process should have a "check for backporting requests in bugzilla" item) :) [16:48:27] * sumanah reads. [16:48:59] (03PS1) 10MarkAHershberger: Add sequence support for upsert in DatabaseOracle [core] (REL1_22) - 10https://gerrit.wikimedia.org/r/115395 [16:49:36] (03CR) 10MarkAHershberger: [C: 032] "backport" [core] (REL1_22) - 10https://gerrit.wikimedia.org/r/115395 (owner: 10MarkAHershberger) [16:50:14] the irony [16:50:37] oh cool. activity! :) [16:50:39] hey hexmode - check out the recent logs in this channel :) [16:53:21] sumanah, guillom andre__ have you received the hangou invitation? [16:53:37] Google keeps changing the UX month to month... [16:53:42] I'll check [16:53:44] not yet [16:54:07] (03Merged) 10jenkins-bot: Add sequence support for upsert in DatabaseOracle [core] (REL1_22) - 10https://gerrit.wikimedia.org/r/115395 (owner: 10MarkAHershberger) [16:54:07] yes I got it qgil [16:54:16] sumanah, please add your points to https://www.mediawiki.org/wiki/Engineering_Community_Team/Meetings#2014-02-25 [16:54:34] ah, up there. Damn UI. [16:54:43] sorr yfor disappearing, i got disconnected [16:54:54] did i miss something? [16:56:53] * MatmaRex has read the logs, not much apparently [16:59:00] guillom, andre__ ping? [16:59:15] you are supposed to join the hangour [16:59:17] t [17:00:02] qgil: I don't see any link :/ [17:00:21] Never mind, I see the invite [17:00:52] (03PS1) 1001tonythomas: Implementing HTML Email [core] - 10https://gerrit.wikimedia.org/r/115399 [17:02:19] (03CR) 1001tonythomas: "Actual code: https://code.google.com/p/mediawiki4intranet/source/browse/custisinstall/patches/Y-000-html-emails.diff?name=mw4install" [core] - 10https://gerrit.wikimedia.org/r/115399 (owner: 1001tonythomas) [17:04:21] (03CR) 10jenkins-bot: [V: 04-1] Implementing HTML Email [core] - 10https://gerrit.wikimedia.org/r/115399 (owner: 1001tonythomas) [17:08:31] (03PS2) 1001tonythomas: Implementing HTML Email [core] - 10https://gerrit.wikimedia.org/r/115399 [17:12:50] (03PS3) 10Manybubbles: WIP:1.0 updates [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/115215 [17:14:42] '''hangour''': boring [[staff meeting]]s conducted via [[videochat]], lasting at least an hour. ''From'': hang + hour [17:17:15] see also: [[harrangue]], [[hangout]] [17:17:57] :) [17:18:58] (03CR) 10Technical 13: "correct, it should still be 2 because you are concatenating another span, not adding another cell." [core] - 10https://gerrit.wikimedia.org/r/115189 (owner: 10Gerrit Patch Uploader) [17:21:13] (03CR) 10Chad: [C: 04-1] "So I'm not a fan of using the array syntax for 1.0 compat. It seems like a pretty major API change from Elastica." (031 comment) [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/115215 (owner: 10Manybubbles) [17:23:40] MatmaRex: Checking [17:24:50] (03CR) 10Manybubbles: "The Elastica API already had you use the array syntax when the field came back as an array. In 1.0 all fields always come back as an arra" (031 comment) [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/115215 (owner: 10Manybubbles) [17:25:20] Krinkle: oh also, a second part of that patch would be moving isarra's normalize CSS to the same "hierarchy" (https://gerrit.wikimedia.org/r/110908) [17:25:52] (the disagreement on the normalize patch is what made me creating this one). thanks [17:27:36] (03CR) 10Krinkle: [C: 04-1] "I'm not sure whether renaming all this has a worthwhile net benefit. Aside from bringing legacy.commonPrint out of legacy, what is the ben" [core] - 10https://gerrit.wikimedia.org/r/114984 (owner: 10Bartosz Dziewoński) [17:28:19] (03CR) 10Chad: [C: 031] "Looks good, one question inline." (031 comment) [core] - 10https://gerrit.wikimedia.org/r/114682 (owner: 10Bsitu) [17:29:15] hey ^d, any luck with that gist?:) [17:29:37] <^d> Didn't get to it yesterday beyond getting GeoData cloned and in my LocalSettings. [17:29:47] <^d> Lemme try that gist and see. [17:34:24] why was I sure that comment in Title::getNsText() was written by Brion ;) [17:34:36] is it profanity-laced? [17:34:56] Slightly. [17:35:03] It's also very true and 8 years old :) [17:35:19] <^d> MaxSem: Got it. [17:35:42] <^d> Swap $config['coordinates'] = array( [17:35:48] brion: getting the namespace of an external title... eek. [17:35:49] <^d> For $config['properties']['coordinates'] = array( [17:36:05] <^d> DanielK_WMDE__, brion: I've run up against that. [17:36:10] <^d> Trying to fix....interwiki things [17:36:15] <^d> (Recently) [17:36:19] heh [17:36:21] that should just throw an exception [17:36:35] <^d> It happens. Oh man it totally happens. [17:36:40] <^d> Interwiki searches dude! [17:37:15] ^d: yea, that's why the functionality of "external link target" should not be conflated with "page title". [17:37:42] ExternalMediaWikiLink extends ExternalWikiLink extends Link. [17:37:47] <^d> SpecialSearch::showInterwikiHit() [17:37:49] just saying :P [17:38:03] <^d> Theory is nice. [17:38:04] ^d: yea, just don't use Title objects there. [17:38:08] <^d> I'm saying it happens :( [17:39:00] ^d, thanks - trying [17:39:26] sure, and i'm just preaching to the choir [17:39:44] <^d> We should start a band. [17:39:59] <^d> :) [17:40:25] smash hit: The Refactoring Blues [17:40:41] Or the Debugger Rhapsody? [17:42:54] Debuggy Woogie. [17:44:36] (03PS1) 10Krinkle: PathRouter: Fix documentation typo [core] - 10https://gerrit.wikimedia.org/r/115403 [17:45:07] <^d> MaxSem: That work? I made the change, re-ran updateSearchIndexConfig and the mapping showed up. [17:46:43] (03PS1) 10Greg Grossmeier: Added .gitreview [tools/releng] - 10https://gerrit.wikimedia.org/r/115404 [17:46:55] (03PS4) 10Gomoko: Fix compatibility with MW 1.22, PHP 5.4 and Firefox 26 [extensions/Drafts] - 10https://gerrit.wikimedia.org/r/105200 [17:48:04] <^d> MaxSem: Also, we pass the MappingConfigBuilder as the second parameter to the hook, it has some convenience functions for building fields (dunno if they'll be useful to you) [17:48:54] (03PS1) 10Greg Grossmeier: Added README [tools/releng] - 10https://gerrit.wikimedia.org/r/115405 [17:50:28] Amgine_: bwahaha! [17:51:11] (03CR) 10Hashar: [C: 031] "self merge you should :-]" [tools/releng] - 10https://gerrit.wikimedia.org/r/115404 (owner: 10Greg Grossmeier) [17:52:09] (03CR) 10Greg Grossmeier: [C: 032] Added .gitreview [tools/releng] - 10https://gerrit.wikimedia.org/r/115404 (owner: 10Greg Grossmeier) [17:52:25] [17:52:35] (03CR) 10Greg Grossmeier: [V: 032] Added .gitreview [tools/releng] - 10https://gerrit.wikimedia.org/r/115404 (owner: 10Greg Grossmeier) [17:52:56] (03CR) 10Greg Grossmeier: [C: 032 V: 032] Added README [tools/releng] - 10https://gerrit.wikimedia.org/r/115405 (owner: 10Greg Grossmeier) [17:53:13] (03PS2) 10Greg Grossmeier: Added README [tools/releng] - 10https://gerrit.wikimedia.org/r/115405 [17:53:20] (03CR) 10Greg Grossmeier: [C: 032 V: 032] Added README [tools/releng] - 10https://gerrit.wikimedia.org/r/115405 (owner: 10Greg Grossmeier) [17:53:37] (03PS1) 10Hashar: Boilerplate to get blockdiag doc generated with sphinx [tools/releng] - 10https://gerrit.wikimedia.org/r/115407 [17:53:39] (03PS1) 10Hashar: Blockdiag integration example [tools/releng] - 10https://gerrit.wikimedia.org/r/115408 [17:54:28] (03CR) 10Hashar: [C: 04-2] "That is for example purpose, we do not want this change in the repo." [tools/releng] - 10https://gerrit.wikimedia.org/r/115408 (owner: 10Hashar) [17:57:44] (03PS3) 10MarkTraceur: Removed "|other_fields=" from default {{Information}} template [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/114697 (owner: 1001tonythomas) [17:58:31] (03CR) 10MarkTraceur: [C: 032] "@Krinkle, indeed." [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/114697 (owner: 1001tonythomas) [17:58:39] (03Merged) 10jenkins-bot: Removed "|other_fields=" from default {{Information}} template [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/114697 (owner: 1001tonythomas) [18:00:08] <^d> MaxSem: Question about the data. Most of this looks like it won't be a big deal (numbers are tiny to store :)). Just curious about the scale of pages it's on. [18:00:15] <^d> Roughly NS_MAIN for each wiki? [18:00:16] <^d> Less? [18:00:25] <^d> Probably less. [18:00:43] ^d, ~2M geotags on enwiki [18:00:57] some pages have up to 2000 tags [18:00:57] <^d> ~2M, not bad. [18:01:03] (03CR) 10Hashar: [C: 04-1] "Instead of tox, might be easier to simply use the Sphinx default Makefile. So folks just need to 'make html'." [tools/releng] - 10https://gerrit.wikimedia.org/r/115407 (owner: 10Hashar) [18:01:06] NS_MAIN would probably be about the maximum [18:01:09] <^d> Oh hmm. [18:01:15] Though you might get users doing it if they're into that sort of thing [18:01:17] Or files [18:06:42] ^d, Validating mapping for page type...different...failed! [18:06:42] Couldn't update mappings. Here is elasticsearch's error message: MergeMappingException[Merge failed with failures {[mapper [text_bytes] has different index values]}] [18:08:02] (03CR) 10Isarra: "This establishes a more intuitive and general structure for common skin resources, or skin-related resources. Moving these is but the firs" [core] - 10https://gerrit.wikimedia.org/r/114984 (owner: 10Bartosz Dziewoński) [18:08:05] ^d, nvm - nuked the content and it worked [18:12:02] <^d> OuKB: Yeah, we can sometimes get a little wonky if the index isn't exactly like we expect. [18:12:12] <^d> Worth filing a bug from the first one so we can tighten it up. [18:12:43] I'm not sure how even to characterize it:) [18:13:16] <^d> Eh, file a bug with the error message. Worst case we'll look it and say nothing we can do. [18:13:23] <^d> (Better than forgetting :)) [18:17:47] (03PS1) 10MaxSem: WIP: Elasticsearch support [extensions/GeoData] - 10https://gerrit.wikimedia.org/r/115413 [18:17:56] (03CR) 10jenkins-bot: [V: 04-1] WIP: Elasticsearch support [extensions/GeoData] - 10https://gerrit.wikimedia.org/r/115413 (owner: 10MaxSem) [18:18:13] gj jerkins-bot [18:19:22] (03PS2) 10MaxSem: WIP: Elasticsearch support [extensions/GeoData] - 10https://gerrit.wikimedia.org/r/115413 [18:24:50] (03PS1) 10EBernhardson: Use single query for multiple revision lookups by pk [extensions/Flow] - 10https://gerrit.wikimedia.org/r/115416 [18:30:43] (03CR) 10Chad: "What if we moved prefix handling Config, but make it agnostic about the actual prefix to use? Then GlobalVarConfig could do it's wg-ugline" [core] - 10https://gerrit.wikimedia.org/r/109850 (owner: 10Ori.livneh) [18:37:08] (03PS1) 10Chad: Be explicit about function calls [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/115417 [18:37:33] (03PS1) 10Aude: Update Wikidata build [core] (wmf/1.23wmf15) - 10https://gerrit.wikimedia.org/r/115418 [18:38:25] (03CR) 10jenkins-bot: [V: 04-1] Update Wikidata build [core] (wmf/1.23wmf15) - 10https://gerrit.wikimedia.org/r/115418 (owner: 10Aude) [18:39:11] rage [18:39:26] my line. [18:40:03] (03PS2) 10Aude: Update Wikidata build [core] (wmf/1.23wmf15) - 10https://gerrit.wikimedia.org/r/115418 [18:43:25] Reedy: around? [18:44:32] we'd like https://gerrit.wikimedia.org/r/#/c/115418/ and https://gerrit.wikimedia.org/r/#/c/115366/ in for deployment [18:44:49] and https://gerrit.wikimedia.org/r/#/c/115393/ after deployment for wikidata on wmf15 [18:48:23] <^d> AaronSchulz: Heh, https://gerrit.wikimedia.org/r/#/c/115417/ [18:58:01] Hi, I Ankesh Anand, eager to contribute to mediawiki via GSoC this year. I am interested in one of the project ideas, should I go ahead and add my name to the list of the page (https://www.mediawiki.org/wiki/Google_Summer_of_Code_2014) ? [18:59:01] ankesh11: You should talk to the mentor(s) listed on the project, I think :) [19:11:30] rdwrer: Thanks. Will do that. [19:12:35] greg-g: poke [19:12:54] or ^d [19:30:49] ori, looks like you may have committed extra code by mistake in https://gerrit.wikimedia.org/r/#/c/115114/ ? [19:31:20] I killed grrrit-wm [19:31:27] I'm going to have to leave now, though :( [19:31:29] legoktm: rdwrer ^ [19:32:17] Hrm [19:32:21] So am I [19:32:28] We'll have to live without for a bit I guess [19:32:34] yeah [19:32:35] Kill gerrit on your way out. [19:32:36] probably [20:08:13] (03PS1) 10Mattflaschen: Vagrantfile now requires 1.2.6 [vagrant] - 10https://gerrit.wikimedia.org/r/115423 [20:08:15] (03CR) 10Mattflaschen: "This makes some changes to the box download that are not mentioned in the commit message. Specifically, it unconditionally sets box_downl" [vagrant] - 10https://gerrit.wikimedia.org/r/115114 (owner: 10Ori.livneh) [20:08:19] (03PS1) 10Greg Grossmeier: Dev and deploy flowchart using blockdiag [tools/releng] - 10https://gerrit.wikimedia.org/r/115425 [20:08:23] (03PS2) 10Greg Grossmeier: Dev and deploy flowchart using blockdiag [tools/releng] - 10https://gerrit.wikimedia.org/r/115425 [20:08:25] (03PS3) 1001tonythomas: Add new Hook 'SendWatchlistEmailNotification' [core] - 10https://gerrit.wikimedia.org/r/114682 (owner: 10Bsitu) [20:08:27] (03CR) 10Bsitu: Add diff view of changes to board header (032 comments) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/109431 (owner: 10Bsitu) [20:08:30] (03PS3) 10Greg Grossmeier: Dev and deploy flowchart using blockdiag [tools/releng] - 10https://gerrit.wikimedia.org/r/115425 [20:08:32] (03PS1) 10Umherirrender: Split revdelete-text on Special:RevisionDelete for each type [core] - 10https://gerrit.wikimedia.org/r/115426 [20:08:34] (03PS4) 10Greg Grossmeier: Dev and deploy flowchart using blockdiag [tools/releng] - 10https://gerrit.wikimedia.org/r/115425 [20:08:48] (03PS2) 10Umherirrender: Split revdelete-text on Special:RevisionDelete for each type [core] - 10https://gerrit.wikimedia.org/r/115426 [20:08:52] (03CR) 10Umherirrender: "Patch Set 2: Fixed spacing" [core] - 10https://gerrit.wikimedia.org/r/115426 (owner: 10Umherirrender) [20:08:58] (03PS1) 10Mattflaschen: Add GettingStarted categories so people can test without more config [vagrant] - 10https://gerrit.wikimedia.org/r/115429 [20:09:00] (03PS2) 10Mattflaschen: Add GettingStarted categories so people can test without more config [vagrant] - 10https://gerrit.wikimedia.org/r/115429 [20:09:02] (03CR) 10Mattflaschen: "2 is just whitespace." [vagrant] - 10https://gerrit.wikimedia.org/r/115429 (owner: 10Mattflaschen) [20:09:04] (03PS1) 10EBernhardson: Do not log expected Flow exceptions [extensions/Flow] (wmf/1.23wmf15) - 10https://gerrit.wikimedia.org/r/115430 [20:09:12] (03PS1) 10EBernhardson: UUID models are immutable, so cache them [extensions/Flow] (wmf/1.23wmf15) - 10https://gerrit.wikimedia.org/r/115431 [20:09:17] (03PS1) 10EBernhardson: (Bug 61715) Make history entries look at most recent revision [extensions/Flow] (wmf/1.23wmf15) - 10https://gerrit.wikimedia.org/r/115432 [20:09:22] (03CR) 10jenkins-bot: [V: 04-1] (Bug 61715) Make history entries look at most recent revision [extensions/Flow] (wmf/1.23wmf15) - 10https://gerrit.wikimedia.org/r/115432 (owner: 10EBernhardson) [20:09:25] (03CR) 10EBernhardson: [C: 032] Do not log expected Flow exceptions [extensions/Flow] (wmf/1.23wmf15) - 10https://gerrit.wikimedia.org/r/115430 (owner: 10EBernhardson) [20:09:28] (03Merged) 10jenkins-bot: Do not log expected Flow exceptions [extensions/Flow] (wmf/1.23wmf15) - 10https://gerrit.wikimedia.org/r/115430 (owner: 10EBernhardson) [20:09:44] sorry for the flood [20:09:46] bot is back [20:19:19] (03CR) 10Chad: "hooks.txt also needs updating to mention third param. Once that's done lgtm and we'll merge." [core] - 10https://gerrit.wikimedia.org/r/114682 (owner: 10Bsitu) [20:39:23] (03PS3) 10MaxSem: WIP: Elasticsearch support [extensions/GeoData] - 10https://gerrit.wikimedia.org/r/115413 [20:44:25] (03CR) 10Chad: [C: 031] "Hmm, you're right. I guess it'll be fine...just seemed weird :)" (031 comment) [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/115215 (owner: 10Manybubbles) [20:50:38] (03CR) 10Mwalker: "I'm fine with this change, but the CS errors only say 'Add a new line to the end of the file' so if you do that all checks will pass and t" [core] - 10https://gerrit.wikimedia.org/r/115421 (owner: 10Addshore) [20:52:41] (03CR) 10Addshore: [C: 04-1] "will do" [core] - 10https://gerrit.wikimedia.org/r/115421 (owner: 10Addshore) [20:53:10] (03CR) 10Addshore: [C: 04-1] "will ammend per comment in https://gerrit.wikimedia.org/r/#/c/115421/" [core] - 10https://gerrit.wikimedia.org/r/115422 (owner: 10Addshore) [21:19:33] (03PS6) 10Chad: WIP: Support interwiki searches in API [core] - 10https://gerrit.wikimedia.org/r/112913 [21:20:06] (03PS3) 10Hashar: Tweak browsertests URLs [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/115387 [21:20:23] (03PS7) 10Hashar: Browser tests jobs for CirrusSearch [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/115164 [21:25:15] (03PS7) 10Chad: Support interwiki searches in API [core] - 10https://gerrit.wikimedia.org/r/112913 [21:25:28] <^d> anomie: I took the WIP off ^ [21:25:35] <^d> I think I've fixed all the problems. [21:25:42] * anomie reviews [21:28:31] (03Abandoned) 10EBernhardson: (Bug 61715) Make history entries look at most recent revision [extensions/Flow] (wmf/1.23wmf15) - 10https://gerrit.wikimedia.org/r/115432 (owner: 10EBernhardson) [21:29:14] (03CR) 10EBernhardson: [C: 032] UUID models are immutable, so cache them [extensions/Flow] (wmf/1.23wmf15) - 10https://gerrit.wikimedia.org/r/115431 (owner: 10EBernhardson) [21:29:28] (03Merged) 10jenkins-bot: UUID models are immutable, so cache them [extensions/Flow] (wmf/1.23wmf15) - 10https://gerrit.wikimedia.org/r/115431 (owner: 10EBernhardson) [21:30:47] (03PS1) 10EBernhardson: Update Flow in wmf/1.23wmf15 with two cherry picks [core] (wmf/1.23wmf15) - 10https://gerrit.wikimedia.org/r/115516 [21:35:19] (03PS3) 10Addshore: Add test for ThrottledError exception [core] - 10https://gerrit.wikimedia.org/r/115421 [21:36:02] (03PS3) 10Addshore: Add test for BadTitleError exception [core] - 10https://gerrit.wikimedia.org/r/115422 [21:38:07] (03PS1) 10Addshore: Fix typo in MWExceptionHandlerTest [core] - 10https://gerrit.wikimedia.org/r/115517 [21:39:53] (03PS1) 10Aaron Schulz: Deprecated useless BagOStuff::replace method [core] - 10https://gerrit.wikimedia.org/r/115518 [21:42:00] (03CR) 10Anomie: [C: 04-1] "Backwards test on line 202." (032 comments) [core] - 10https://gerrit.wikimedia.org/r/112913 (owner: 10Chad) [21:46:02] (03PS4) 10Manybubbles: WIP:1.0 updates [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/115215 [21:51:56] (03CR) 10Anomie: Support interwiki searches in API (031 comment) [core] - 10https://gerrit.wikimedia.org/r/112913 (owner: 10Chad) [21:52:41] https://code.google.com/p/chromium/issues/detail?id=346857 [21:53:19] (03CR) 10Chad: Support interwiki searches in API (031 comment) [core] - 10https://gerrit.wikimedia.org/r/112913 (owner: 10Chad) [21:54:34] (03CR) 10Hashar: "I have no idea what you are doing but the browser tests are finally passing! :-]" [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/115215 (owner: 10Manybubbles) [21:54:43] (03PS1) 10Aaron Schulz: Replace replace() call with set() [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/115519 [21:54:52] (03PS8) 10Chad: Support interwiki searches in API [core] - 10https://gerrit.wikimedia.org/r/112913 [21:56:34] (03CR) 10Manybubbles: "I'm working on getting them passing consistently in vagrant. I think because it is slow it need something similar to jenkins. Not sure t" [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/115215 (owner: 10Manybubbles) [22:02:01] Krinkle: you should update OSX ;) [22:05:28] anomie: hi [22:05:49] Is it better to use ucshow= or its own param? [22:06:21] Can someone else comment on that? Not sure about API argument guidelines [22:10:08] (03CR) 10Chad: [C: 032] Fix messy variable usage in debug & remove unused global [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/115420 (owner: 10Chad) [22:10:15] (03Merged) 10jenkins-bot: Fix messy variable usage in debug & remove unused global [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/115420 (owner: 10Chad) [22:10:31] (03Abandoned) 10Chad: I am not sure why this is suddenly necessary [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/114512 (owner: 10Chad) [22:12:51] (03CR) 10Hashar: [C: 032] "Fair :-]" [core] - 10https://gerrit.wikimedia.org/r/115517 (owner: 10Addshore) [22:14:03] (03CR) 10Matthias Mullie: Add diff view of changes to board header (032 comments) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/109431 (owner: 10Bsitu) [22:14:06] (03CR) 10EBernhardson: [C: 032] Update Flow in wmf/1.23wmf15 with two cherry picks [core] (wmf/1.23wmf15) - 10https://gerrit.wikimedia.org/r/115516 (owner: 10EBernhardson) [22:16:08] sleep time. Have fun folks [22:16:34] (03Merged) 10jenkins-bot: Fix typo in MWExceptionHandlerTest [core] - 10https://gerrit.wikimedia.org/r/115517 (owner: 10Addshore) [22:17:29] (03Merged) 10jenkins-bot: Update Flow in wmf/1.23wmf15 with two cherry picks [core] (wmf/1.23wmf15) - 10https://gerrit.wikimedia.org/r/115516 (owner: 10EBernhardson) [22:25:30] (03CR) 10Daniel Friesen: ""I disagree, it has quite a lot to do, being another standard common skin module. The three-step hierarchy you're trying to enforce is art" [core] - 10https://gerrit.wikimedia.org/r/114984 (owner: 10Bartosz Dziewoński) [22:26:29] is there any guide about porting i18n to JSON? [22:27:04] any tool to automatically convert the gigantic PHP array? [22:29:17] jgonera: is the PHP array serialized? [22:29:46] huh, well, it's not, but it could be [22:29:59] this is related to my first question though [22:30:01] about i18n [22:30:23] json_encode( $arrayname ) [22:30:24] ? [22:30:27] i suppose i'm also not understanding the question, a little php to turn the array into json is easy but i think thats not what you want? [22:30:48] well, yes, but that doesn't split it automatically into separate json files (per language) [22:31:00] I know it's not hard to write a script, I'm asking if someone has already written one ;) [22:31:06] Oh [22:31:08] :) [22:31:14] oh, yea i would have just wrote a script to start with :P [22:31:34] it would probably only be a few lines anyway [22:31:38] not sure if one exists [22:31:55] jgonera: maybe https://www.mediawiki.org/wiki/Manual:GenerateJsonI18n.php ? [22:32:01] :P [22:32:06] I just googled for it [22:32:39] hah [22:32:43] thanks, huh [22:32:48] I google too, but didn't find it [22:33:05] I searched for "php i18n json mediawiki" (without quotes) [22:38:47] (03PS1) 10Aaron Schulz: Avoid showing crazy staleness times at ActiveUsers [core] - 10https://gerrit.wikimedia.org/r/115522 [22:49:44] (03PS5) 10Manybubbles: WIP:1.0 updates [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/115215 [22:59:07] (03PS2) 10Anomie: LuaStandalone: Release functions when no longer referenced [extensions/Scribunto] - 10https://gerrit.wikimedia.org/r/93073 [22:59:11] (03CR) 10Aaron Schulz: [C: 032] LuaStandalone: Release functions when no longer referenced [extensions/Scribunto] - 10https://gerrit.wikimedia.org/r/93073 (owner: 10Anomie) [23:02:41] (03Merged) 10jenkins-bot: LuaStandalone: Release functions when no longer referenced [extensions/Scribunto] - 10https://gerrit.wikimedia.org/r/93073 (owner: 10Anomie) [23:04:22] * AaronSchulz wonders where the API actually checks $wgEnableAPI... [23:13:36] AaronSchulz: What a terrible thing to have to wonder. [23:14:15] rdwrer, does mmv use any core JS classes other than Title and Api? [23:14:32] Hm. [23:14:55] jgonera: Maybe Uri, but I'm not sure, and I sorta doubt it [23:15:02] ok [23:15:18] jgonera: Oh, duh, Message [23:16:00] ah, ok, this one is a given ;) [23:24:12] rdwrer, do you know why my mw instance would get 10x slower after loading mmv in LocalSettings? [23:24:21] ...um [23:24:22] No. [23:24:30] jgonera: Did you load CMD too? [23:24:34] I don't need any database updates? [23:24:36] CMD? [23:24:37] Shouldn't [23:24:41] CommonsMetadata [23:24:55] yes [23:25:06] that's why? [23:25:10] That might cause a slowdown depending on your template setup [23:25:17] If you have Information templates etc. [23:28:35] rdwrer, still slow as hell, any other external stuff it might be trying to get? any templates it might be trying to use? [23:28:47] I don't think so. [23:29:31] it's weird, the whole HTML is there, the title changes in the browser but the page still takes like half a minute to display [23:32:34] all that even without enabling it in beta features... [23:33:12] That is indeed super weird [23:33:20] Maybe something changed recently that I'm not seeing locally [23:35:00] rdwrer, I guess I'll try it later on a vagrant instance [23:40:02] (03CR) 10Mattflaschen: "Thanks, Krinkle." [core] - 10https://gerrit.wikimedia.org/r/114080 (owner: 10Mattflaschen) [23:58:02] (03PS1) 10EBernhardson: Cleanup unused and undefined classes [extensions/Flow] - 10https://gerrit.wikimedia.org/r/115528 [23:58:06] (03PS1) 10EBernhardson: No need to call same function three times [extensions/Flow] - 10https://gerrit.wikimedia.org/r/115529 [23:58:09] (03PS1) 10EBernhardson: Split reusable parts out of ContributionsQuery [extensions/Flow] - 10https://gerrit.wikimedia.org/r/115530 [23:58:11] (03PS1) 10EBernhardson: Sort the combined header+topic revisions after merging [extensions/Flow] - 10https://gerrit.wikimedia.org/r/115531 [23:58:15] (03PS1) 10EBernhardson: [WIP] Combined board history [extensions/Flow] - 10https://gerrit.wikimedia.org/r/115532 [23:58:19] (03CR) 10jenkins-bot: [V: 04-1] Cleanup unused and undefined classes [extensions/Flow] - 10https://gerrit.wikimedia.org/r/115528 (owner: 10EBernhardson) [23:58:27] (03CR) 10jenkins-bot: [V: 04-1] No need to call same function three times [extensions/Flow] - 10https://gerrit.wikimedia.org/r/115529 (owner: 10EBernhardson) [23:58:34] (03CR) 10jenkins-bot: [V: 04-1] Split reusable parts out of ContributionsQuery [extensions/Flow] - 10https://gerrit.wikimedia.org/r/115530 (owner: 10EBernhardson) [23:58:41] (03CR) 10jenkins-bot: [V: 04-1] Sort the combined header+topic revisions after merging [extensions/Flow] - 10https://gerrit.wikimedia.org/r/115531 (owner: 10EBernhardson) [23:58:48] (03CR) 10jenkins-bot: [V: 04-1] [WIP] Combined board history [extensions/Flow] - 10https://gerrit.wikimedia.org/r/115532 (owner: 10EBernhardson)