[01:36:53] (03CR) 10Parent5446: Introducing TitleValue (031 comment) [core] - 10https://gerrit.wikimedia.org/r/106517 (owner: 10Daniel Kinzler) [01:46:19] Anyone here? [02:04:22] huh: More or less... rather less than more, acutally :P [02:05:03] hi hoo [02:05:11] hi Jasper_Deng :) [02:11:03] Can someone give me the TL;DR of how to upgrade from 1.21 to 1.23? [02:11:08] hoo, Jasper_Deng [02:11:24] it should be no different than any other upgrade [02:11:25] I read https://www.mediawiki.org/wiki/Manual:Upgrading but it is quite long and detailed [02:11:35] not sure which way to do it [02:11:53] Command line or web? [02:12:05] ultimately what you need to do is to copy in the new files and run update.php to sync the databases [02:12:11] huh: copy over the files, run `php maintenance/update.php`, that's it [02:12:16] ^ [02:12:25] refer to the manual when you get errors. :P [02:13:26] yep, for such a "minor" update that should enough [02:13:34] remember to also update your extensions ;) [02:14:07] + be [05:30:15] (03PS12) 1001tonythomas: Ticking search in all namespaces should tick all the remaining ones. [core] - 10https://gerrit.wikimedia.org/r/110610 [06:12:23] (03PS1) 10Gerrit Patch Uploader: Add 'centralauth-admin-title' message, adding username to HTML title of Special:CentralAuth/Username [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/114961 [06:12:29] (03CR) 10Gerrit Patch Uploader: "This commit was uploaded using the Gerrit Patch Uploader [1]." [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/114961 (owner: 10Gerrit Patch Uploader) [06:14:04] Blame me [06:52:27] MatmaRex: You are right. The shell runs a much older php version than the server process. [06:53:39] MatmaRex: Many thanks for this useful bit of information! [09:01:52] (03CR) 10Legoktm: "I'll try and finish this up..." (031 comment) [core] - 10https://gerrit.wikimedia.org/r/109850 (owner: 10Ori.livneh) [09:10:40] (03PS6) 10Legoktm: Make abstract Config class truly implementation-agnostic [core] - 10https://gerrit.wikimedia.org/r/109850 (owner: 10Ori.livneh) [09:12:24] (03CR) 10jenkins-bot: [V: 04-1] Make abstract Config class truly implementation-agnostic [core] - 10https://gerrit.wikimedia.org/r/109850 (owner: 10Ori.livneh) [09:29:01] (03PS7) 10Legoktm: Make abstract Config class truly implementation-agnostic [core] - 10https://gerrit.wikimedia.org/r/109850 (owner: 10Ori.livneh) [09:37:08] (03CR) 10Legoktm: "PS6: Rebase" [core] - 10https://gerrit.wikimedia.org/r/109850 (owner: 10Ori.livneh) [09:37:44] (03CR) 10Legoktm: Make abstract Config class truly implementation-agnostic (035 comments) [core] - 10https://gerrit.wikimedia.org/r/109850 (owner: 10Ori.livneh) [09:39:36] (03PS1) 10Gerrit Patch Uploader: Use current lang, debug and skin for AJAX call [extensions/CategoryTree] - 10https://gerrit.wikimedia.org/r/114964 [09:39:38] (03CR) 10Gerrit Patch Uploader: "This commit was uploaded using the Gerrit Patch Uploader [1]." [extensions/CategoryTree] - 10https://gerrit.wikimedia.org/r/114964 (owner: 10Gerrit Patch Uploader) [10:07:59] ori, just saw Opera's warning that LocalStorage on enwiki is full:] [10:08:34] I should really stop using that crap though:P [10:11:00] "As of now, most browsers that have implemented Web Storage, including Opera, have placed the storage limit at 5 Mb per domain." [10:12:04] reading that literally they provide 625 kB of storage, which I can't believe we are fulling [10:12:17] hehe [10:12:38] even if limits are the same, buggier browsers have more ways to reach them;) [10:23:16] (03PS1) 10Mjnovice: Automatically copies the LocalSettings.php file to the desired location, fixes bug 60534. [core] - 10https://gerrit.wikimedia.org/r/114966 [10:23:22] (03PS1) 10Gerrit Patch Uploader: Full screen toggle [extensions/MediaWikiChat] - 10https://gerrit.wikimedia.org/r/114967 [10:23:24] (03CR) 10Gerrit Patch Uploader: "This commit was uploaded using the Gerrit Patch Uploader [1]." [extensions/MediaWikiChat] - 10https://gerrit.wikimedia.org/r/114967 (owner: 10Gerrit Patch Uploader) [10:31:47] 1 quick test: go to enwiki, login, enable a couple of beta features including VE, open a page for editing --> 5.06M [10:32:05] let's gzip it?:P [10:47:34] MB, MiB or Mb? :) [10:55:16] (03PS1) 10Gerrit Patch Uploader: Prevent long words breaking container and making a horizontal scroll bar appear [extensions/MediaWikiChat] - 10https://gerrit.wikimedia.org/r/114968 [10:55:18] (03CR) 10Gerrit Patch Uploader: "This commit was uploaded using the Gerrit Patch Uploader [1]." [extensions/MediaWikiChat] - 10https://gerrit.wikimedia.org/r/114968 (owner: 10Gerrit Patch Uploader) [11:15:35] (03CR) 10Hoo man: [C: 04-1] Add 'centralauth-admin-title' message, adding username to HTML title of Special:CentralAuth/Username (032 comments) [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/114961 (owner: 10Gerrit Patch Uploader) [11:33:38] hoo: php fatal due https://gerrit.wikimedia.org/r/114914 ? [11:34:09] se4598_2: Yep... will fix in a second [11:34:24] Damn, that ... luckily there's the beta cluster [11:37:19] se4598_2: https://gerrit.wikimedia.org/r/114969 if you have merge rights, go ahead ;) [11:38:08] I haven't :) [11:38:53] se4598_2: Ok... I guess I'll write some unit tests for that class now... damn you untested classes :P [11:54:40] (03CR) 10PiRSquared17: Add 'centralauth-admin-title' message, adding username to HTML title of Special:CentralAuth/Username (031 comment) [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/114961 (owner: 10Gerrit Patch Uploader) [11:56:56] (03PS2) 10Gerrit Patch Uploader: Add 'centralauth-admin-title' message, adding username to HTML title of Special:CentralAuth/Username [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/114961 [11:56:58] (03CR) 10Gerrit Patch Uploader: "This commit was uploaded using the Gerrit Patch Uploader [1]." [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/114961 (owner: 10Gerrit Patch Uploader) [12:24:15] (03PS1) 10UltrasonicNXT: Use months in timestamps [extensions/Comments] - 10https://gerrit.wikimedia.org/r/114972 [12:30:22] (03PS3) 10Hoo man: Add the username to the HTML title of Special:CentralAuth [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/114961 (owner: 10Gerrit Patch Uploader) [12:31:52] (03PS4) 10Hoo man: Add the username to the HTML title of Special:CentralAuth [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/114961 (owner: 10Gerrit Patch Uploader) [12:32:57] (03CR) 10Hoo man: "Updated the commit message, use spaces instead of tabs in CentralAuth.i18n.php" [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/114961 (owner: 10Gerrit Patch Uploader) [12:37:49] (03CR) 10Hoo man: [C: 032] "Thanks for the patch :)" [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/114961 (owner: 10Gerrit Patch Uploader) [12:37:52] (03Merged) 10jenkins-bot: Add the username to the HTML title of Special:CentralAuth [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/114961 (owner: 10Gerrit Patch Uploader) [12:38:16] hoo: Can you help me setup mail service for Mediawiki ? [12:38:58] maybe I can help a little ... ;) [12:40:03] hoo: Thanks. Can a mailserver be setup for a wiki running in a localhost ? [12:40:17] I mean, is it possible for my local wiki to send mails ? [12:40:30] Sure ;) [12:43:42] hoo: using smtp of say gmail ? [12:44:27] hoo: I followed steps here https://help.ubuntu.com/community/MediaWiki#Email_Support [12:45:08] but doesn't seem to work [12:46:05] mh [12:46:50] tonythomas: Does it give you an exception or so? [12:47:14] of course. ! I will paste that in a moment [12:47:24] :) [12:47:36] hoo: just FYI: either your fix doesn't work or it's somewhere stuck and still not on beta (presumably the latter) [12:47:46] mh [12:48:44] hoo: btw, any idea whether gmail uses ssl or tls ? [12:48:45] se4598_2: Beta code update seems to be broken [12:49:00] tonythomas: No idea, sorry [12:49:14] hoo: thats ok. I tried with both [12:49:34] I get this error: could not send your confirmation mail. Please check your email address for invalid characters. [12:49:34] Mailer returned: Failed to connect to tls://smtp.gmail.com:465 [SMTP: Failed to connect socket: Connection timed out (code: -1, response: )] [12:49:38] se4598_2: Well... maybe that's just l10n update... I guess it will be on beta in about a minute ;) [12:51:28] tonythomas: mh... maybe try changing tls:// for ssl:// ? [12:51:45] hoo: ok [12:53:25] hoo: When I click sent a confirmation code in Special:ConfirmEmail its taking sufficient time though [12:53:37] got the new error Mailer returned: Failed to connect to ssl://smtp.gmail.com:465 [SMTP: Failed to connect socket: Connection timed out (code: -1, response: )] [12:54:00] I will paste my Localhost settings in pastebin .. Can you please go through ? [12:54:07] I guess so, yes [12:55:39] http://pastebin.com/1VW1nSa4 [12:55:51] mwversionsinuse is broken on beta [12:56:28] but ok in production [12:57:50] tonythomas: mh, for the time out I'd mostly bet on a network/ firewall issue [12:57:50] ho hoo should the $wgPasswordSender be "apache@localhost" ? [12:57:52] $wgPasswordSender = "apache@localhost"; [12:58:20] that should probably have you gmail address, as gmail AFAIR doesn't like sending emails with other addresses than your own [12:58:20] thats correct ? [12:58:33] pl [12:58:34] ok [12:59:35] hoo: why are we having 2 use of same variable $wgPasswordSender ? [12:59:50] where? [13:00:28] in the ubuntu doc / pastebin [13:00:33] in https://help.ubuntu.com/community/MediaWiki#Email_Support [13:00:57] se4598_2: yeah ! [13:01:21] just a mistake I assume [13:01:26] yeah... [13:01:42] ok. Trying with the new one [13:02:42] Nah ! Its again showing Mailer returned: Failed to connect to ssl://smtp.gmail.com:465 [SMTP: Failed to connect socket: Connection timed out (code: -1, response: )] [13:03:35] hoo: beta-mediawiki-config-update is broken since 2 days or so with i10n, and the other change is younger (maybe is it hanging somewhere in the submodule?); re mwversionsinuse: AFAIR Reedy has done something there [13:03:59] se4598_2: Maybe I'll ahve a look at that later, yikes :/ [13:04:10] not my department, though :P [13:06:16] tonythomas: Please check your settings regarding PHP network connectivity [13:07:08] i installed php-pear , mail and Net_SMTP packages as given in the doc [13:07:21] if I could get into some mail IRC [13:07:36] tonythomas: Is your PHP installation able to open sockets at all? [13:16:26] hoo: is there a way to check it ? [13:20:15] tonythomas: http://www.php.net/manual/en/function.socket-connect.php#94350 try that with smtp.gmail.com on port 465 [13:20:29] haven't tested but looks promising as simple test case [13:21:29] hoo: ok [13:30:00] hoo: I gave $address="smtp.gmail.com"; [13:30:00] $port = '465'; and tested the file [13:30:04] I get the error [13:30:12] Unable to connect [13:30:12] Connection timed out [13:30:24] looks like something is defienetly wrong :( [13:33:00] tonythomas: ok, sounds like that, yes... if you want to make double sure, you can test google.com on port 80 [13:33:31] Connection successful on IP google.com, port 80 [13:33:48] hoo: looks like the firewall is doing the trick [13:33:56] Probably, yes [13:36:02] (03CR) 10Technical 13: "Not sure why Gerrit's not giving me the option to +1 it, but, I've looked the patch over and it looks right to me." [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/94698 (owner: 10Legoktm) [13:36:40] (03CR) 10Nemo bis: "AalekhN, I don't understand (grammatically) your question: can you please rephrase?" [core] - 10https://gerrit.wikimedia.org/r/106625 (owner: 10AalekhN) [13:50:18] (03CR) 10Addshore: "Because it is already merged ;p" [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/94698 (owner: 10Legoktm) [14:26:00] (03PS12) 10MegaAlex: Add link to PD help translatable pages from sidebar [core] - 10https://gerrit.wikimedia.org/r/83221 (owner: 10Nemo bis) [14:27:52] MatmaRex: how about crossing the 50 +2 mark :P [14:37:42] (03PS2) 10MegaAlex: Add personal tools messages for messages login, userlogout, createaccount [core] - 10https://gerrit.wikimedia.org/r/100724 [14:55:43] Nemo_bis: add me as a reviewer [14:55:48] oh, i am a reviewer [14:55:56] ... [14:56:00] you even +1 [14:56:44] i am a reviewer on like a hundred open changes, i can't remember every one. :P [14:57:17] i'll look at these two later today [15:01:38] (03PS3) 10MegaAlex: i18n: Add PLURAL/GENDER support to revreview-reject-summary-* [extensions/FlaggedRevs] - 10https://gerrit.wikimedia.org/r/103119 [15:04:53] ogni scarrafone è bello a mamma sua [15:05:13] AKA everyone thinks their own patches the most memorable [15:09:30] yuvipanda: ping [15:10:12] yuvipanda: http://en.wikipedia.org/wiki/Wikipedia_talk:WikiLove#WikiLove_seems_broken [15:16:15] how appropriate one week after the 14th [15:16:36] I blame the roman pontifex (actually, pontifices, both of them) [15:26:22] hoo: I tried an alternate connection, and the mail reached perfectly [15:26:42] \o/ :) [15:27:49] :) [15:28:31] (03CR) 10Jackmcbarn: [C: 04-1] "The way you have this written right now, the user needs to try to download the file for the code to write it to execute. You should do it " [core] - 10https://gerrit.wikimedia.org/r/114966 (owner: 10Mjnovice) [16:26:50] (03PS1) 10Gerrit Patch Uploader: When global account is deleted, remove rows from global_user_groups [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/114981 [16:26:52] (03CR) 10Gerrit Patch Uploader: "This commit was uploaded using the Gerrit Patch Uploader [1]." [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/114981 (owner: 10Gerrit Patch Uploader) [16:42:01] (03PS2) 10Umherirrender: Remove another undefined $env and TODO comment for it too [core] - 10https://gerrit.wikimedia.org/r/114482 [16:45:32] Nemo_bis: can you handle or get someone to handle the TWN part of https://gerrit.wikimedia.org/r/#/c/100724/ ? [16:49:23] (03PS10) 10Umherirrender: API: Return set values for action=options [core] - 10https://gerrit.wikimedia.org/r/92928 [16:52:02] MatmaRex: what part? by definition you don't have to worry about the twn site if you do the right thing about message keys and docs; Raymond is in reviewers and will do whatever nneeds doing [16:52:37] "(I think this can be merged now, no? Assuming somebody from TWN will copy the current translations.)" [16:52:43] i said this in december [16:52:56] would have merged then if someone confirmed [16:53:02] instead i forgot about the patch, eh [16:53:36] I didn't see anything needing a reply in there and I still don't [16:53:57] you say you assume you can merge without problem, nobody said the contrary [16:54:59] (03CR) 10Bartosz Dziewoński: [C: 032] Add personal tools messages for messages login, userlogout, createaccount [core] - 10https://gerrit.wikimedia.org/r/100724 (owner: 10MegaAlex) [16:58:19] (03Merged) 10jenkins-bot: Add personal tools messages for messages login, userlogout, createaccount [core] - 10https://gerrit.wikimedia.org/r/100724 (owner: 10MegaAlex) [17:23:20] yuvipanda: https://en.wikipedia.org/wiki/Wikipedia_talk:WikiLove#WikiLove_seems_broken -- Can you please fix it or help Ocaasi and I fix it? Thanks. [17:30:06] hey T13|needsCoffee [17:30:38] T13|needsCoffee: from what Ocassi said, it doesn't need code changes on wikilove's style, but just needs a different icon? [17:31:24] The problem is that WikiLove isn't forcing a max icon size like it used to. [17:31:50] forcing the user to download a large image and then making it small via CSS does not sound like a terrible idea [17:31:51] Because of the change to a
  • , that is lost. [17:32:00] why not just specify a smaller image? [17:32:15] I think they are .svg, in which case they really have no size. [17:32:37] I could be wrong on that though [17:33:05] you can still specify sizes on them in the URL, I believe [17:33:10] in that case they get sent back as CSS [17:33:39] Either way, relying on a user (who may just be copying an existing script and has no idea how to resize and image or ask for it resized) to resize an image is poor dummyproofing. [17:34:31] T13|needsCoffee: err? if you are randomly copy pasting bits of JS into your wiki page, sounds like you are going to get used to random stuff breaking every time anyway. [17:34:32] Let me look at the code again, it's not fresh in my mind.. [17:34:35] ok [17:36:06] Wouldn't adding class="mw-wikilove-inside" to the li make sure that it isn't broken no matter what is used for an icon? [17:36:53] or to the img tag itself [17:37:12] In general I don't think depending on internal implementation details like this is a good idea. [17:38:04] My larger wonder is why this is causing the linking to not show up in the preview mode. [17:38:25] because that shouldn't be affected by this icon at all. [17:38:49] the internal HTML structure of the buttons, etc were completely changed when we changed the styles. Might've been something from there [17:38:57] https://en.wikipedia.org/wiki/File:WikiLove_issue_%282%29.png all of the bullet points at least should be links [17:40:20] ah hmm [17:40:25] are you sure that wasn't always the case? [17:40:29] oh, hmm. [17:40:31] it wasn't [17:40:32] I remember [17:40:42] not sure why that's happening, T13|needsCoffee [17:42:35] I'm actually right in the middle of rebuilding http://en.wikipedia.org/w/index.php?title=Wikipedia:WikiProject_Articles_for_creation/Participants/Message to use a new template I created ( http://enwp.org/Template:Mailing_list_member ), but I'll be happy to resize those images and then see if I can't figure out the other part. [17:42:55] as soon as I'm done with it. :) [17:43:04] hexmode: Are you there? [17:46:31] T13|needsCoffee: :) [18:05:57] l10n updates broken on beta - https://bugzilla.wikimedia.org/show_bug.cgi?id=61830 <-- hoo: is that caused by/related to what you say earlier mwversionsinuse broken? [18:05:58] (03CR) 10Nemo bis: [C: 031] Some corrections to interwiki_local_x_intro messages [extensions/Interwiki] - 10https://gerrit.wikimedia.org/r/113541 (owner: 10Martineznovo) [18:06:49] se4598_2: I guess so... aude was hacking on that earlier [18:06:54] maybe she can comment [18:09:30] (03CR) 10UltrasonicNXT: [C: 032 V: 032] "Cool, cheers for this one, good thinking." [extensions/MediaWikiChat] - 10https://gerrit.wikimedia.org/r/114968 (owner: 10Gerrit Patch Uploader) [18:13:38] (03CR) 10Bartosz Dziewoński: Add link to PD help translatable pages from sidebar (033 comments) [core] - 10https://gerrit.wikimedia.org/r/83221 (owner: 10Nemo bis) [18:13:42] Nemo_bis: ^ [18:13:47] let me just fix that and i'll merge [18:13:48] also [18:13:52] 'tooltip-n-help' => 'The place to find out', [18:13:55] wtf is this message [18:14:59] hmmm, actually [18:15:25] tooltips are chaos [18:16:15] (03CR) 10Bartosz Dziewoński: [C: 04-1] "You changed the documentation of the 'newarticletext' message and the code that uses it, but not the message itself; it looks all broken n" [core] - 10https://gerrit.wikimedia.org/r/83221 (owner: 10Nemo bis) [18:16:40] (03CR) 10Hoo man: [C: 04-1] When global account is deleted, remove rows from global_user_groups (031 comment) [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/114981 (owner: 10Gerrit Patch Uploader) [18:18:51] (03CR) 10UltrasonicNXT: [C: 04-1] "Which skins have you tested this on? It needs some work for the skin we use on Brickimedia, Refreshed." [extensions/MediaWikiChat] - 10https://gerrit.wikimedia.org/r/114967 (owner: 10Gerrit Patch Uploader) [18:19:35] surely some rebase hell happened [18:20:49] (03CR) 10UltrasonicNXT: "I have tried fullscreen before, but I've found it very hard to get skin-compatible. I think I'd decided the only way was to not render ins" [extensions/MediaWikiChat] - 10https://gerrit.wikimedia.org/r/114967 (owner: 10Gerrit Patch Uploader) [18:29:50] (03PS2) 10Gerrit Patch Uploader: When global account is deleted, remove rows from global_user_groups [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/114981 [18:29:52] (03CR) 10Gerrit Patch Uploader: "This commit was uploaded using the Gerrit Patch Uploader [1]." [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/114981 (owner: 10Gerrit Patch Uploader) [18:29:57] hoo: [18:31:06] (03CR) 10PiRSquared17: "Fixed per comment" (031 comment) [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/114981 (owner: 10Gerrit Patch Uploader) [18:33:14] se4598_2: hoo i have a patch for it [18:33:19] :) [18:33:25] unfortunately requires someone willig to merge on a sunday [18:33:35] aude: Is it on gerrit, yet? [18:33:40] * aude could deploy it [18:34:07] https://gerrit.wikimedia.org/r/114980 [18:34:12] lol [18:34:47] aude: XD [18:35:02] for real? hahah :D [18:35:12] :D [18:35:18] That got through code review? [18:35:36] apparently yes [18:40:16] aude: go ahead and self merge, I'd say [18:40:26] * hoo kills CentralAuth slowly [18:40:35] hoo: can't [18:40:40] * aude needs to ask for merge rights [18:40:41] *sigh* [18:40:54] Right... I wanted to talk to Reedy about that, but forgot [18:41:03] Ariel told me to talk to him... [18:43:06] anyway, it's been broken for a few days [18:43:21] maybe not that urgent [18:44:11] (03PS1) 10Bartosz Dziewoński: Resources.php: Create a section for MediaWiki UI [core] - 10https://gerrit.wikimedia.org/r/114985 [18:46:09] ^ trivial, comment-only changes [18:46:48] (03CR) 10Hoo man: [C: 032] Resources.php: Create a section for MediaWiki UI [core] - 10https://gerrit.wikimedia.org/r/114985 (owner: 10Bartosz Dziewoński) [18:46:50] Request: GET http://www.mediawiki.org/wiki/Extension:WikiLove, from 10.64.32.104 via cp1065 cp1065 ([10.64.0.102]:3128), Varnish XID 136972649 Forwarded for: 166.182.83.178, 10.64.32.104 Error: 503, Service Unavailable at Sun, 23 Feb 2014 18:46:29 GMT [18:47:00] T13|needsCoffee: hi [18:47:05] mediawiki wiki is down? [18:47:11] thanks hoo [18:47:17] Can confirm [18:47:22] Thanks... [18:47:26] maybe ask in -ops or -tech [18:47:36] ? [18:47:36] Nah, I can wait... [18:47:44] wfm [18:48:27] Just trying to find out what the optimal image size is for WikiLove icons.. [18:48:31] <+icinga-wm> PROBLEM - Apache HTTP on mw1081 is CRITICAL: CRITICAL - Socket timeout after 10 seconds [18:48:35] maybe there is an issue [18:48:40] i hope not! [18:48:53] works for me [18:49:03] cp1065 looks good [18:49:04] bug 60970 ? [18:49:06] nope [18:49:08] se4598_2: Yep, back for me too. [18:49:18] +icinga-wm> RECOVERY - Apache HTTP on mw1081 is OK: HTTP OK: HTTP/1.1 301 Moved Permanently - 808 bytes in 0.049 second response time [18:49:24] maybe just intermittent something [18:49:34] mh, probably [18:49:41] going to eat [18:49:53] huh: Will later on approve your patch, it looks good :) [18:50:07] http://gdash.wikimedia.org/dashboards/reqerror/ [18:50:08] (03Merged) 10jenkins-bot: Resources.php: Create a section for MediaWiki UI [core] - 10https://gerrit.wikimedia.org/r/114985 (owner: 10Bartosz Dziewoński) [18:50:13] T13|needsCoffee: https://gdash.wikimedia.org/dashboards/reqerror/ see anything? [18:50:45] huh: a long flat red line? [18:51:08] Flatline is good in this case ;) [18:51:23] and a blue line that had a spike near 85K for a few minutes.. [18:52:18] T13|needsCoffee: is it over then? [18:52:20] https://www.mediawiki.org/wiki/Extension:WikiLove unfortunetly doesn't mention an optimal icon size.. yuvipanda do you know what the size should be? [18:52:30] huh: all over but the crying.. [19:04:58] (03CR) 10Mdupont: [C: 031] "Looks harmless." [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/108473 (owner: 10Brian Wolff) [19:23:39] (03Draft1) 10Bartosz Dziewoński: Create mediawiki.skinbase.* modules grouping basic common CSS [core] - 10https://gerrit.wikimedia.org/r/114984 [19:28:07] Draft1, eh? [19:28:48] eh. [19:29:21] eh. [19:29:31] that actually means i published a draft. [19:29:39] it was secret, now it's not. [19:39:10] !sal [19:39:10] is that stupid bot broken again? [19:39:11] https://wikitech.wikimedia.org/wiki/Server_Admin_Log [19:39:19] !ping [19:39:19] petan: wm-bot is not responding again [19:39:19] Pong. [19:39:23] !ping [19:39:23] Pong. [19:39:29] MatmaRex: Do you see it speaking in here? [19:39:32] It's responding. [19:39:53] I see a hyperlink and two longs. [19:39:55] From wm-bot. [19:40:00] it does respond [19:40:13] two pongs * [19:40:15] Fucking auto-correct. [19:40:18] MatmaRex: fix your irc client [19:40:34] lol [19:40:44] D: [19:40:44] (03CR) 10UltrasonicNXT: "https://www.mediawiki.org/wiki/Taking_over_output_in_your_special_page" [extensions/MediaWikiChat] - 10https://gerrit.wikimedia.org/r/114967 (owner: 10Gerrit Patch Uploader) [19:41:18] i see the messages now [19:41:18] it responded after i complained to petan [19:41:33] :P [19:41:46] it eventually trolls since I implemented AI to it [19:42:08] Silly bot. [19:42:09] [14:39] !sal [14:39] is that stupid bot broken again? [14:39] https://wikitech.wikimedia.org/wiki/Server_Admin_Log [14:39] !ping [14:39] petan: wm-bot is not responding again [14:39] Pong. [19:42:09] (03CR) 10Jack Phoenix: "I'm not sure why we need the mediawiki. nomenclature in ResourceLoader module names; unlike with CSS classes and IDs, it's not possible (t" [core] - 10https://gerrit.wikimedia.org/r/114984 (owner: 10Bartosz Dziewoński) [19:42:09] lol [19:42:11] Give it two more seconds in the future MatmaRex... :p [19:42:28] you see [19:42:31] it's freenode lagging [19:42:43] Technical_13 has all messages in same second [19:42:45] petan: freenode doesn't lag... pfft. [19:42:50] so it's freenode broken not my bot [19:43:07] Technical_13: not lagging? and why u think you have all messages in 1 second in your log :D [19:43:30] because webchat doesn't display seconds, just minutes. [19:43:34] ah lol [19:43:51] that explain why you have 14 minutes when everyone else has 4x [19:44:17] Yeah, that is 2:39 PM [19:44:37] * Technical_13 is a silly American... [20:07:56] (03CR) 10Hoo man: [C: 032] "Works like a charm, thanks :)" [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/114981 (owner: 10Gerrit Patch Uploader) [20:07:59] (03Merged) 10jenkins-bot: When global account is deleted, remove rows from global_user_groups [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/114981 (owner: 10Gerrit Patch Uploader) [20:47:11] (03PS2) 10Matthias Mullie: (Bug 61715) Make history entries look at most recent revision [extensions/Flow] - 10https://gerrit.wikimedia.org/r/114679 [20:47:14] (03PS1) 10Matthias Mullie: Get rid of references to the no longer existing .flow-icon-permalink [extensions/Flow] - 10https://gerrit.wikimedia.org/r/114990 [20:47:17] (03PS1) 10Matthias Mullie: Bind to specific elements instead of random [extensions/Flow] - 10https://gerrit.wikimedia.org/r/114991 [20:47:20] (03PS1) 10Matthias Mullie: Some minor optimizations when checking permissions [extensions/Flow] - 10https://gerrit.wikimedia.org/r/114992 [20:47:38] (03CR) 10jenkins-bot: [V: 04-1] Get rid of references to the no longer existing .flow-icon-permalink [extensions/Flow] - 10https://gerrit.wikimedia.org/r/114990 (owner: 10Matthias Mullie) [20:47:49] (03CR) 10jenkins-bot: [V: 04-1] Bind to specific elements instead of random [extensions/Flow] - 10https://gerrit.wikimedia.org/r/114991 (owner: 10Matthias Mullie) [20:49:00] (03PS1) 10Tim Starling: Revert "Add ss_active_users in SiteStats::isSane" [core] - 10https://gerrit.wikimedia.org/r/114993 [20:49:45] (03CR) 10jenkins-bot: [V: 04-1] Revert "Add ss_active_users in SiteStats::isSane" [core] - 10https://gerrit.wikimedia.org/r/114993 (owner: 10Tim Starling) [20:49:52] TimStarling: Already one it [20:49:54] * on [20:50:00] (03PS2) 10Ori.livneh: Revert "Add ss_active_users in SiteStats::isSane" [core] - 10https://gerrit.wikimedia.org/r/114993 (owner: 10Tim Starling) [20:50:02] (03PS1) 10Hoo man: Make SiteStats sanity checks more sane [core] - 10https://gerrit.wikimedia.org/r/114994 [20:51:14] the delete/insert pair dates to 2007 apparently [20:51:30] Original File: maintenance/initStats.inc [20:51:32] hoo: TimStarling: shouldn't we just update the field instead? or is the query too expensive? [20:51:52] MatmaRex: That's what replace does ;) Update if present, insert instead AFAIR [20:51:59] no, i mean [20:52:02] well, because it started in maintenance, it was probably called by the installer [20:52:08] // Count active users if need be [20:52:08] if ( $options['activeUsers'] ) { [20:52:08] SiteStatsUpdate::cacheUpdate( wfGetDB( DB_MASTER ) ); [20:52:08] } [20:52:17] why not always do this in this code path? [20:52:21] now, the installer has its own bitrotting version of the same code [20:54:02] actually DatabaseUpdater::checkStats() still calls this code [20:54:16] just DatabaseUpdater::doActiveUsersInit() is rotting [20:54:45] (03CR) 10jenkins-bot: [V: 04-1] Make SiteStats sanity checks more sane [core] - 10https://gerrit.wikimedia.org/r/114994 (owner: 10Hoo man) [20:56:19] (03PS2) 10Hoo man: Make SiteStats sanity checks more sane [core] - 10https://gerrit.wikimedia.org/r/114994 [20:58:56] what was wrong with replace? [20:59:08] TimStarling: It does delete and insert as well [20:59:11] well, apart from $uniqueIndexes being wrong [20:59:16] upsert is the one I was thinking of [20:59:36] not on mysql [20:59:56] on mysql it calls DatabaseBase::nativeReplace() [21:00:21] mh [21:03:44] (03PS3) 10Hoo man: Make SiteStats sanity checks more sane [core] - 10https://gerrit.wikimedia.org/r/114994 [21:05:20] that one should work DB independent... mh [21:06:21] TimStarling: Are you ok with that? [21:06:25] (03PS23) 10Inchikutty: Embedding leaflet maps based on OSM data to UploadWizard [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/109263 [21:07:29] (03CR) 10jenkins-bot: [V: 04-1] Make SiteStats sanity checks more sane [core] - 10https://gerrit.wikimedia.org/r/114994 (owner: 10Hoo man) [21:07:36] neither replace nor upsert have the same function parameters as insert [21:09:08] I mean, $uniqueIndexes is wrong [21:09:39] array_keys( $conds ) will do it, I guess [21:10:06] or array( 'ss_row_id' ) [21:10:36] did Ori code himself as a bot? [21:10:46] he did a PS2 but hasn't said a word :) [21:10:47] (03PS4) 10Hoo man: Make SiteStats sanity checks more sane [core] - 10https://gerrit.wikimedia.org/r/114994 [21:10:48] -- Pointless index to assuage developer superstitions [21:10:48] CREATE UNIQUE INDEX /*i*/ss_row_id ON /*_*/site_stats (ss_row_id); [21:10:59] better update that comment eh? [21:11:02] lol [21:13:26] (03PS18) 10Inchikutty: [WIP]UploadWizard:OSM embedding- Geocoding, reverse geocoding [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/112342 [21:13:45] it's unique on plwiki and enwiki [21:14:23] and metawiki [21:14:27] that's a fair sample isn't it? [21:16:29] Data_free: 16257122304 [21:16:36] on wikidatawiki... [21:22:34] (03CR) 10Tim Starling: Make SiteStats sanity checks more sane (031 comment) [core] - 10https://gerrit.wikimedia.org/r/114994 (owner: 10Hoo man) [21:23:14] back later [21:23:21] ok, will amend, I guess [21:39:58] (03PS5) 10Hoo man: Make SiteStats (re)initializing more sane [core] - 10https://gerrit.wikimedia.org/r/114994 [21:40:41] (03CR) 10Hoo man: "Simplified the logic, per Tim's suggestion" [core] - 10https://gerrit.wikimedia.org/r/114994 (owner: 10Hoo man) [21:43:18] (03PS6) 10Hoo man: Make SiteStats (re)initializing more sane [core] - 10https://gerrit.wikimedia.org/r/114994 [21:56:16] guillom: can you please mark my new version of https://meta.wikimedia.org/wiki/Tech/News/2014/09 ready for translation? [21:57:31] se4598_2: done [21:57:50] thanks [22:01:07] (03PS1) 10Parent5446: Add projects for Persona and OpenBadges extensions [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/115092 [22:01:15] (03CR) 10jenkins-bot: [V: 04-1] Add projects for Persona and OpenBadges extensions [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/115092 (owner: 10Parent5446) [22:02:07] (03CR) 10Parent5446: [C: 04-1] Add projects for Persona and OpenBadges extensions (031 comment) [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/115092 (owner: 10Parent5446) [22:02:10] (03CR) 10MaxSem: Add projects for Persona and OpenBadges extensions (031 comment) [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/115092 (owner: 10Parent5446) [22:03:26] (03PS2) 10Parent5446: Add projects for Persona and OpenBadges extensions [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/115092 [22:04:26] (03CR) 10MaxSem: [C: 04-1] Add projects for Persona and OpenBadges extensions (031 comment) [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/115092 (owner: 10Parent5446) [22:06:18] (03CR) 10Parent5446: Add projects for Persona and OpenBadges extensions (031 comment) [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/115092 (owner: 10Parent5446) [22:06:36] (03PS3) 10Parent5446: Add projects for Persona and OpenBadges extensions [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/115092 [22:07:10] (03CR) 10Parent5446: "First time using this repo. ;)" [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/115092 (owner: 10Parent5446) [22:19:12] (03CR) 10Isarra: "What Jack said." [core] - 10https://gerrit.wikimedia.org/r/114984 (owner: 10Bartosz Dziewoński) [22:33:58] (03CR) 10Tim Starling: [C: 031] Make SiteStats (re)initializing more sane [core] - 10https://gerrit.wikimedia.org/r/114994 (owner: 10Hoo man) [23:03:14] (03CR) 10Nemo bis: "Superseded by https://gerrit.wikimedia.org/r/#/c/114994/ , I understand?" [core] - 10https://gerrit.wikimedia.org/r/114993 (owner: 10Tim Starling) [23:04:08] (03Abandoned) 10Tim Starling: Revert "Add ss_active_users in SiteStats::isSane" [core] - 10https://gerrit.wikimedia.org/r/114993 (owner: 10Tim Starling) [23:31:40] (03CR) 10Springle: "General question:" [core] - 10https://gerrit.wikimedia.org/r/114994 (owner: 10Hoo man) [23:32:43] (03CR) 10Bartosz Dziewoński: [C: 04-1] "Left some rather nitpicky :) comments inline. Looks good to merge to me otherwise, personally I don't see much value in this feature, but " (036 comments) [core] - 10https://gerrit.wikimedia.org/r/110610 (owner: 1001tonythomas) [23:34:05] (03CR) 10Hoo man: "This should use a PoolCounter to avoid such a stampede, yes... but that's another issue (on top of this)." [core] - 10https://gerrit.wikimedia.org/r/114994 (owner: 10Hoo man) [23:34:49] (03CR) 10Jack Phoenix: [C: 032 V: 032] "Looks sane to me. Might be worthwhile of applying this patch to all other social extensions that duplicate this code (SocialProfile defini" [extensions/Comments] - 10https://gerrit.wikimedia.org/r/114972 (owner: 10UltrasonicNXT)