[00:00:26] (03Abandoned) 10Bartosz Dziewoński: Making agora-field-styling direction neutral [core] - 10https://gerrit.wikimedia.org/r/93089 (owner: 10Ebrahim) [00:08:28] (03CR) 10Reedy: [C: 032] "Seems to work fine from my testing :)" [core] - 10https://gerrit.wikimedia.org/r/114066 (owner: 10Anomie) [00:08:48] (03PS9) 10Reedy: WIP: Allow inclusion of additional fields [extensions/ContactPage] - 10https://gerrit.wikimedia.org/r/113883 [00:11:52] (03Merged) 10jenkins-bot: HTMLForm: Allow i18n of 'options' [core] - 10https://gerrit.wikimedia.org/r/114066 (owner: 10Anomie) [00:16:27] hoo: Hi. [00:17:43] hi Gloria [00:18:02] hoo: I saw your edit at Meta-Wiki removing Asher from the list of sysadmins. [00:18:15] Yes [00:18:28] did I get that wrong? [00:18:42] I thought he decided to stick around as a volunteer. [00:18:45] nope, it's correct [00:18:51] But I'm looking at the file now and it seems his account has been disabled. [00:18:52] he did for a while, now he's gone [00:19:04] Aha. Okay. Sorry for the ping. :-) [00:19:08] $enabled = false [00:19:11] * Gloria nods. [00:19:40] I missed the change disabling his account. I need to improve my stalking skills. [00:21:31] That page still refers to a CTO in the intro, BTW. [00:22:30] One day He or She will come and it shall be glorious [00:23:46] Gloria: I've talked to Sumana about that page earlier and she agrees that it needs a bit of love (she then mailed Guillaume, let's see where that goes) [00:24:38] I don't think it requires two full-time staff members to edit a wiki page. :-) [00:24:47] https://meta.wikimedia.org/w/index.php?title=System_administrators&diff=7563754&oldid=7563210 [00:24:49] Gloria: :D [00:25:07] This was rather about getting the list of users completed etc. [00:25:14] * Gloria nods. [00:25:17] We should automate it. ;-) [00:25:27] The puppet manifest has most of the info. [00:26:41] Except of the IRC nicks, yes... but pulling it all from there might be a bit work [00:27:04] anyway, it's almost 1:30 over here... good night ;) [00:27:26] Night. [00:30:39] (03CR) 10Bartosz Dziewoński: "I suggest abandoning and WONTFIXing the bug." [core] - 10https://gerrit.wikimedia.org/r/72877 (owner: 10Spage) [00:34:21] (03CR) 10Mattflaschen: [C: 032] "Looks good. Minor note about quoting inline." (031 comment) [extensions/GuidedTour] - 10https://gerrit.wikimedia.org/r/113875 (owner: 10Phuedx) [00:34:56] (03Merged) 10jenkins-bot: Convert CSS to LESS [extensions/GuidedTour] - 10https://gerrit.wikimedia.org/r/113875 (owner: 10Phuedx) [00:38:35] (03CR) 10Bartosz Dziewoński: "This apparently fixed bug 24074." [core] - 10https://gerrit.wikimedia.org/r/94406 (owner: 10Bartosz Dziewoński) [00:39:12] (03CR) 10Reedy: WIP: Allow inclusion of additional fields (034 comments) [extensions/ContactPage] - 10https://gerrit.wikimedia.org/r/113883 (owner: 10Reedy) [00:43:08] (03PS1) 10MarkTraceur: Add oojs-ui to the core documentation generator [core] - 10https://gerrit.wikimedia.org/r/114373 [00:44:35] (03CR) 10Mattflaschen: "Krinkle, my comment wasn't in regards to the current implementation, but about Matmarex's abandoned patch (https://gerrit.wikimedia.org/r/" [core] - 10https://gerrit.wikimedia.org/r/111957 (owner: 10Krinkle) [00:47:00] (03CR) 10Ori.livneh: "Looks good. Let's walk through this tomorrow if you don't mind. Do you need to worry about URL length limitations?" (031 comment) [core] - 10https://gerrit.wikimedia.org/r/107759 (owner: 10Aaron Schulz) [00:49:05] (03PS10) 10Reedy: WIP: Allow inclusion of additional fields [extensions/ContactPage] - 10https://gerrit.wikimedia.org/r/113883 [00:49:52] (03Abandoned) 10Chad: Remove Calendar and Quiz extensions -- unused on cluster [tools/release] - 10https://gerrit.wikimedia.org/r/114330 (owner: 10Chad) [00:49:54] (03CR) 10Reedy: WIP: Allow inclusion of additional fields (031 comment) [extensions/ContactPage] - 10https://gerrit.wikimedia.org/r/113883 (owner: 10Reedy) [00:51:24] (03CR) 10Reedy: "Would this be better in it's own config file?" [extensions/WikimediaMessages] - 10https://gerrit.wikimedia.org/r/110243 (owner: 10Reedy) [00:52:46] (03PS1) 10Kaldari: Removing bogus width from thumbinner [core] - 10https://gerrit.wikimedia.org/r/114375 [00:56:27] (03CR) 10jenkins-bot: [V: 04-1] Removing bogus width from thumbinner [core] - 10https://gerrit.wikimedia.org/r/114375 (owner: 10Kaldari) [01:00:15] Anyone want to review https://gerrit.wikimedia.org/r/#/c/114142/ - I would really like to see it make it into 1.23wmf15 [01:01:01] bawolff: Did you add Mark B.? [01:01:07] I did [01:01:30] because he reverted the last attempt to fix the issue on account of it blowing up the site [01:01:50] bawolff: it looks good; have you tested it? [01:01:55] yep [01:02:12] and the current behaviour is pretty broken (as you can see on Commons:Main_Page [01:02:58] bawolff: how did things explode last time? [01:03:40] Basically the configuration was changed to disable all caching on pages with [01:03:40] oh, I remember [01:03:43] bawolff: Fair enough, though unless CategoryTree is planning a round II, I really doubt he cares. [01:03:44] which includes some busy pages [01:04:11] In my commit it just reduces the cache time, which should hopefully be sufficient performance wise [01:04:34] it's still a bit scary that breaking this entirely is as easy as changing if ( $wgCategoryTreeDisableCache === true ) to if ( $wgCategoryTreeDisableCache == true ) [01:05:17] could you maybe change that to: if ( is_bool( $wgCategoryTreeDisableCache ) && $wgCategoryTreeDisableCache == true ) ? [01:05:17] Sadly, this isn't even the first time this has happened. If I remember correctly we had the exact same problem with caching this extension a year ago [01:05:24] it's strictly speaking redundant but helps readers of the code [01:05:35] I can do that [01:06:02] errr, is_bool( $wgCategoryTreeDisableCache ) && $wgCategoryTreeDisableCache === true [01:06:08] i dropped the extra '=' thus enacting the very concern i was raising :P [01:07:38] Also, lots of Main page types pages seem to have {{CURRENTTIME}} on them, which reduces cache time to an hour, so I don't think the reduce to six hours should be a big deal [01:08:22] yeah, i'm happy to merge given the is_bool thing [01:11:49] (03PS1) 10Matthias Mullie: Revert "Add missing flow-anon-warning qqq" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/114377 [01:12:03] (03PS1) 10EBernhardson: Revert "Anonymous editor warning" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/114378 [01:12:06] (03CR) 10jenkins-bot: [V: 04-1] Revert "Anonymous editor warning" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/114378 (owner: 10EBernhardson) [01:12:21] (03CR) 10Matthias Mullie: [C: 032] "Anon stuff not going out yet" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/114377 (owner: 10Matthias Mullie) [01:12:33] (03Merged) 10jenkins-bot: Revert "Add missing flow-anon-warning qqq" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/114377 (owner: 10Matthias Mullie) [01:13:27] (03PS3) 10Brian Wolff: Unbreak this extension by killing $wgCategoryTreeDynamicTag [extensions/CategoryTree] - 10https://gerrit.wikimedia.org/r/114142 [01:15:03] (03CR) 10Ori.livneh: [C: 032] Unbreak this extension by killing $wgCategoryTreeDynamicTag [extensions/CategoryTree] - 10https://gerrit.wikimedia.org/r/114142 (owner: 10Brian Wolff) [01:15:05] (03Merged) 10jenkins-bot: Unbreak this extension by killing $wgCategoryTreeDynamicTag [extensions/CategoryTree] - 10https://gerrit.wikimedia.org/r/114142 (owner: 10Brian Wolff) [01:15:12] Thanks :) [01:15:49] thank you! [01:16:05] Also if I ever invent a programming language, I'm going to make == be identical comparision, and something else be equal with type coercion, because the === vs == thing causes nothing but problems [01:16:31] (03PS2) 10EBernhardson: Revert "Anonymous editor warning" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/114378 [01:16:48] <^d> I should grep for people doing !=/== true/false again [01:16:53] <^d> Cleaned that up ages ago [01:18:21] (03PS1) 10Bartosz Dziewoński: User: Be less stringent in getCanonicalName() [core] - 10https://gerrit.wikimedia.org/r/114379 [01:18:30] bawolff: this fixes a bug you reported! ^ [01:18:43] (and i really hope doesn't break anything badly) [01:19:31] MatmaRex: Woo [01:19:48] (03CR) 10EBernhardson: [C: 032] Revert "Anonymous editor warning" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/114378 (owner: 10EBernhardson) [01:19:59] (03Merged) 10jenkins-bot: Revert "Anonymous editor warning" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/114378 (owner: 10EBernhardson) [01:23:06] MatmaRex: I was very confused reading over that bug, I totally forgot consecutive spaces get collapsed in titles [01:23:59] (03PS2) 10Chad: Use ssh for submodules, makes it easier to manage from [tools/release] - 10https://gerrit.wikimedia.org/r/114331 [01:24:58] bawolff: this also affects a whole lot of other things [01:25:19] basically all of our title normalization was not done and is done now [01:26:12] yeah, that's kind of scary [01:26:38] Particularly could that lock someone out of their account if they registered it a long time ago when normalization rules were different [01:26:56] (03PS2) 10Kaldari: Removing bogus width from thumbinner [core] - 10https://gerrit.wikimedia.org/r/114375 [01:27:50] (03PS14) 10CSteipp: Password Expiration [core] - 10https://gerrit.wikimedia.org/r/92037 [01:28:44] (03CR) 10jenkins-bot: [V: 04-1] Password Expiration [core] - 10https://gerrit.wikimedia.org/r/92037 (owner: 10CSteipp) [01:29:22] (03PS2) 10Reedy: Add messages for Trademark Licensing form for foundationwiki [extensions/WikimediaMessages] - 10https://gerrit.wikimedia.org/r/110243 [01:29:24] (03CR) 10jenkins-bot: [V: 04-1] Add messages for Trademark Licensing form for foundationwiki [extensions/WikimediaMessages] - 10https://gerrit.wikimedia.org/r/110243 (owner: 10Reedy) [01:29:28] gwicke: Do I need to change anything in parsoid due to https://gerrit.wikimedia.org/r/#/c/114375/ ? [01:30:51] (03PS3) 10Reedy: Add messages for Trademark Licensing form for foundationwiki [extensions/WikimediaMessages] - 10https://gerrit.wikimedia.org/r/110243 [01:32:36] kaldari, our HTML for images is different (figure and figcaption), so no need to change it [01:32:50] (03CR) 10Reedy: [C: 032] Use ssh for submodules, makes it easier to manage from [tools/release] - 10https://gerrit.wikimedia.org/r/114331 (owner: 10Chad) [01:32:52] (03Merged) 10jenkins-bot: Use ssh for submodules, makes it easier to manage from [tools/release] - 10https://gerrit.wikimedia.org/r/114331 (owner: 10Chad) [01:33:20] kaldari, the VE folks already have CSS that renders the parsoid HTML the same way as the PHP parser's divs [01:33:36] (03PS2) 10Reedy: Remove UserThrottle [tools/release] - 10https://gerrit.wikimedia.org/r/113898 [01:33:45] (03CR) 10Reedy: [C: 032] Remove UserThrottle [tools/release] - 10https://gerrit.wikimedia.org/r/113898 (owner: 10Reedy) [01:33:47] (03Merged) 10jenkins-bot: Remove UserThrottle [tools/release] - 10https://gerrit.wikimedia.org/r/113898 (owner: 10Reedy) [01:34:24] (03PS1) 10Chad: Revert "Use ssh for submodules, makes it easier to manage from" [tools/release] - 10https://gerrit.wikimedia.org/r/114380 [01:34:32] (03CR) 10Chad: [C: 032] Revert "Use ssh for submodules, makes it easier to manage from" [tools/release] - 10https://gerrit.wikimedia.org/r/114380 (owner: 10Chad) [01:34:34] (03Merged) 10jenkins-bot: Revert "Use ssh for submodules, makes it easier to manage from" [tools/release] - 10https://gerrit.wikimedia.org/r/114380 (owner: 10Chad) [01:34:46] gwicke: hmm, looks like parsoid also adds the 2px to figures though (under tha assumption that all images have a 1px border) [01:37:47] (03CR) 10Deskana: [C: 032] Move Subject to be third field on form [extensions/ContactPage] - 10https://gerrit.wikimedia.org/r/114101 (owner: 10Reedy) [01:37:50] (03Merged) 10jenkins-bot: Move Subject to be third field on form [extensions/ContactPage] - 10https://gerrit.wikimedia.org/r/114101 (owner: 10Reedy) [01:38:44] kaldari, afaik we don't set any inline styles on figures [01:39:23] gwicke: hmm, maybe it's VE's javascript doing it then [01:39:43] hmm, that would indeed be bad [01:40:08] also afaik no reason to do so [01:40:23] RoanKattouw, ^^ [01:40:25] gwicke: Firebug shows…
[01:40:49] hmm, that's bad [01:40:53] for an image with width 250px [01:41:38] Yeah that's VE [01:41:47] Sorry :( [01:42:00] It's only in specific cases, mooeypoo knows more [01:42:23] I suppose we should just measure the border or something [01:42:32] Or ideally we wouldn't need that inline width, but I don't know the details [01:42:59] to me it sounds as if a padding could do the same trick [01:43:18] (03PS1) 10Matthias Mullie: Fix topic history; bundling i18n params were not converted [extensions/Flow] - 10https://gerrit.wikimedia.org/r/114386 [01:43:22] maybe the issue is the width of the caption? [01:45:00] (03CR) 10Reedy: [C: 04-1] Add messages for Trademark Licensing form for foundationwiki (031 comment) [extensions/WikimediaMessages] - 10https://gerrit.wikimedia.org/r/110243 (owner: 10Reedy) [01:45:43] (03CR) 10Kaldari: [C: 04-2] "Apparently needed for captions" [core] - 10https://gerrit.wikimedia.org/r/114375 (owner: 10Kaldari) [01:46:02] bawolff: hmmm [01:47:07] bawolff: i'm pretty sure that such usernames would cause quite a lot of issues for the unfortunate users already [01:47:08] gwicke: Yeah you're probably right [01:47:57] (03CR) 10EBernhardson: [C: 032] Fix topic history; bundling i18n params were not converted [extensions/Flow] - 10https://gerrit.wikimedia.org/r/114386 (owner: 10Matthias Mullie) [01:48:07] (03Merged) 10jenkins-bot: Fix topic history; bundling i18n params were not converted [extensions/Flow] - 10https://gerrit.wikimedia.org/r/114386 (owner: 10Matthias Mullie) [01:48:49] RoanKattouw: do you have a sec to explain the rationale for l10nupdate / wikidev permission split? [01:50:52] ori: I'll come to your desk in 5 [01:53:23] (03PS2) 10Mattflaschen: Add mediawiki.ui.button to all pages so wiki content can use it [core] - 10https://gerrit.wikimedia.org/r/114085 [01:54:12] (03CR) 10jenkins-bot: [V: 04-1] Add mediawiki.ui.button to all pages so wiki content can use it [core] - 10https://gerrit.wikimedia.org/r/114085 (owner: 10Mattflaschen) [01:55:58] (03PS3) 10Mattflaschen: Add mediawiki.ui.button to all pages so wiki content can use it [core] - 10https://gerrit.wikimedia.org/r/114085 [01:56:06] (03Abandoned) 10Kaldari: Removing bogus width from thumbinner [core] - 10https://gerrit.wikimedia.org/r/114375 (owner: 10Kaldari) [01:56:49] (03CR) 10jenkins-bot: [V: 04-1] Add mediawiki.ui.button to all pages so wiki content can use it [core] - 10https://gerrit.wikimedia.org/r/114085 (owner: 10Mattflaschen) [02:01:05] (03PS4) 10Mattflaschen: Add mediawiki.ui.button to all pages so wiki content can use it [core] - 10https://gerrit.wikimedia.org/r/114085 [02:11:47] (03PS1) 10Bsitu: Show most recent items for watchlist but recentchanges [extensions/Flow] - 10https://gerrit.wikimedia.org/r/114390 [02:21:07] (03CR) 10Aaron Schulz: [C: 031] "I guess the schema change can start." [core] - 10https://gerrit.wikimedia.org/r/92037 (owner: 10CSteipp) [02:25:34] (03CR) 10Mattflaschen: "Added to SkinTemplate. This way it is loaded by most skins. However, it can be dropped by specific skins (e.g. mobile), though I think i" [core] - 10https://gerrit.wikimedia.org/r/114085 (owner: 10Mattflaschen) [02:28:38] (03CR) 10Bartosz Dziewoński: "Matt actually just provided a case for custom skins not using the default modules ;) https://gerrit.wikimedia.org/r/#/c/114085/" [core] - 10https://gerrit.wikimedia.org/r/113169 (owner: 10Mattflaschen) [02:40:21] (03CR) 10Technical 13: [C: 04-1] "Why does it have to go in the "other" section instead of in the regular iwm? This seems like a hackish way to accomplish this to me, and " [extensions/WikimediaMaintenance] - 10https://gerrit.wikimedia.org/r/112920 (owner: 10Gerrit Patch Uploader) [02:48:10] (03Abandoned) 10Reedy: Allow addition of extra fields and append those values back onto the email text before sending it [extensions/ContactPage] - 10https://gerrit.wikimedia.org/r/110276 (owner: 10Reedy) [02:55:53] (03CR) 10Mattflaschen: "Yes, according to my grepping (explained at https://gerrit.wikimedia.org/r/#/c/98869)." [core] - 10https://gerrit.wikimedia.org/r/114080 (owner: 10Mattflaschen) [02:58:35] (03Abandoned) 10Welterkj: use imagemap class for HTML rendering [extensions/GraphViz] - 10https://gerrit.wikimedia.org/r/111475 (owner: 10Welterkj) [03:04:38] (03PS3) 10AndyRussG: Prevent deletion of institutions with courses [extensions/EducationProgram] - 10https://gerrit.wikimedia.org/r/112866 [03:13:28] (03PS1) 10Bartosz Dziewoński: Warn on account creation when username is adjusted [core] - 10https://gerrit.wikimedia.org/r/114400 [03:17:25] (03CR) 10jenkins-bot: [V: 04-1] Warn on account creation when username is adjusted [core] - 10https://gerrit.wikimedia.org/r/114400 (owner: 10Bartosz Dziewoński) [03:18:17] ehhh [03:18:28] Krinkle: jsduck job segfaults. ^ [03:18:42] this is the second time this happened to me [03:19:52] (03CR) 10Bartosz Dziewoński: "Ignore jenkins, it's being stupid again." [core] - 10https://gerrit.wikimedia.org/r/114400 (owner: 10Bartosz Dziewoński) [03:22:43] MatmaRex: fixing [03:23:19] (03PS1) 10Krinkle: jsduck: Set `--processes 0` to avoid ruby parallel from being run [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/114401 [03:23:29] Krinkle: related: https://bugzilla.wikimedia.org/60138 [03:24:18] (03CR) 10Krinkle: [C: 032] "Pushed mediawiki-core-jsduck to Jenkins." [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/114401 (owner: 10Krinkle) [03:24:37] (03Merged) 10jenkins-bot: jsduck: Set `--processes 0` to avoid ruby parallel from being run [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/114401 (owner: 10Krinkle) [03:24:58] Krinkle: can you make ops upgrade? ruby 1.8 is eol [03:25:17] most likely not. [03:25:28] lolol [03:25:33] (03PS1) 10Mattflaschen: Break out rotation mixin into its own file [core] - 10https://gerrit.wikimedia.org/r/114404 [03:25:37] Doing stuff like that globally is impossible without having us paranoia test everything everywhere [03:25:46] basically not until we upgrade ubuntu [03:26:01] unless we're sure we know everything that uses ruby everywhere in everyway on every machine anywhere in the stuffs [03:26:08] (03CR) 10Parent5446: [C: 04-1] User: Be less stringent in getCanonicalName() (031 comment) [core] - 10https://gerrit.wikimedia.org/r/114379 (owner: 10Bartosz Dziewoński) [03:26:11] Have to wait for 14.04 [03:26:12] should be able to upgrade within jenkins job runners though [03:26:18] D: [03:26:20] especially when they're in labs [03:26:35] (03CR) 10Mattflaschen: "There are no uses in extensions, based on my grep of a 1.23wmf14 checkout." [core] - 10https://gerrit.wikimedia.org/r/114404 (owner: 10Mattflaschen) [03:26:36] Jenkins job runners are destined to be exclusively lab runners, they have no place in production. [03:26:44] what exactly on the cluster uses ruby, anyway? [03:26:58] because i think that nothing except for jsduck [03:27:11] browser tests, but they are ran by a third-party afaik [03:27:19] Who knows right? But I'm sure ops will go nuts if you suggest upgrading a core language engine on the cluster. [03:27:20] (03PS2) 10Mattflaschen: Break out rotation mixin into its own file [core] - 10https://gerrit.wikimedia.org/r/114404 [03:27:49] It probably won't even work because of ubuntu's own default packages that depend on it, regardless of what we intentionally use it for. [03:28:03] you could probably just s/ruby/ruby19/ in a couple of places and install the ruby19 package [03:28:23] or ruby20 or newer, if it has a package already maybe [03:28:28] Does somewant want to delete an orphan rotting class? kthx https://gerrit.wikimedia.org/r/#/c/113891/ [03:29:11] https://github.com/search?q=HTMLCaptchaField+%40wikimedia&type=Code [03:29:22] (03CR) 10Krinkle: [C: 032] "Yay!" [extensions/ConfirmEdit] - 10https://gerrit.wikimedia.org/r/113891 (owner: 10Reedy) [03:29:25] (03Merged) 10jenkins-bot: Remove unused/incomplete stale HTMLCaptchaField [extensions/ConfirmEdit] - 10https://gerrit.wikimedia.org/r/113891 (owner: 10Reedy) [03:32:06] (03PS3) 10Mattflaschen: Break out rotation mixin into its own file [core] - 10https://gerrit.wikimedia.org/r/114404 [03:32:31] (03CR) 10Mattflaschen: "On second thought, mediawiki.mixins.rotation is better since that's the name of the mixin." [core] - 10https://gerrit.wikimedia.org/r/114404 (owner: 10Mattflaschen) [03:33:10] (03Abandoned) 10Reedy: Fixup some bits of code, parameter type documentation etc [extensions/DPLforum] - 10https://gerrit.wikimedia.org/r/47311 (owner: 10Reedy) [03:34:31] (03PS6) 10Reedy: Minor parameter documentation improvements [extensions/VipsScaler] - 10https://gerrit.wikimedia.org/r/76006 [03:38:11] (03PS7) 10Reedy: Minor parameter documentation improvements [extensions/VipsScaler] - 10https://gerrit.wikimedia.org/r/76006 [03:38:30] (03CR) 10Reedy: Minor parameter documentation improvements (033 comments) [extensions/VipsScaler] - 10https://gerrit.wikimedia.org/r/76006 (owner: 10Reedy) [03:40:55] (03PS11) 10Reedy: Allow inclusion of additional fields [extensions/ContactPage] - 10https://gerrit.wikimedia.org/r/113883 [03:41:14] (03CR) 10Brian Wolff: Minor parameter documentation improvements (031 comment) [extensions/VipsScaler] - 10https://gerrit.wikimedia.org/r/76006 (owner: 10Reedy) [03:42:08] bawolff: I was more amused by $this->input = $input->getOutput(); [03:42:23] what [03:42:40] line 379 [03:43:01] wow, that's great [03:45:28] (03PS8) 10Reedy: Minor parameter documentation improvements [extensions/VipsScaler] - 10https://gerrit.wikimedia.org/r/76006 [03:47:39] (03PS1) 10Reedy: Remove undefined $env and TODO comment for it too [core] - 10https://gerrit.wikimedia.org/r/114409 [03:50:44] (03CR) 10Bartosz Dziewoński: User: Be less stringent in getCanonicalName() (031 comment) [core] - 10https://gerrit.wikimedia.org/r/114379 (owner: 10Bartosz Dziewoński) [03:56:59] (03PS2) 10Mattflaschen: Don't print mediawiki.notification messages [core] - 10https://gerrit.wikimedia.org/r/113169 [03:59:15] Hey Krinkle o/ [04:01:09] prtksxna: Hi [04:01:16] (03CR) 10Mattflaschen: "> Matt actually just provided a case for custom skins not using the default modules ;) https://gerrit.wikimedia.org/r/#/c/114085/" [core] - 10https://gerrit.wikimedia.org/r/113169 (owner: 10Mattflaschen) [04:01:45] Krinkle: Do you think you'll have time to see https://gerrit.wikimedia.org/r/#/c/113951/ [04:01:57] Krinkle: It has SVG/JS/CSS changes, I don't know whom to ask to review [04:13:25] (03CR) 10Adamw: [C: 032] "I like it. Minor gripes, but I think it will work..." (038 comments) [extensions/EducationProgram] - 10https://gerrit.wikimedia.org/r/112866 (owner: 10AndyRussG) [04:13:35] (03Merged) 10jenkins-bot: Prevent deletion of institutions with courses [extensions/EducationProgram] - 10https://gerrit.wikimedia.org/r/112866 (owner: 10AndyRussG) [04:14:19] (03CR) 10Krinkle: Add Triangle/Pokey to the NavigationPopups (034 comments) [extensions/Popups] - 10https://gerrit.wikimedia.org/r/113951 (owner: 10Prtksxna) [04:15:00] (03CR) 10Krinkle: Add Triangle/Pokey to the NavigationPopups (031 comment) [extensions/Popups] - 10https://gerrit.wikimedia.org/r/113951 (owner: 10Prtksxna) [04:15:32] prtksxna: Can't review svg and visuals because I don't have it installed at the moment. [04:15:39] Some other time :) [04:15:42] I've left static review though [04:29:32] legoktm: re: XMPP being moribund.. Facebook just put 19 billion dollars on the table to acquire WhatsApp [04:30:23] [[en:WhatsApp]]: "WhatsApp uses a customized version of the open standard Extensible Messaging and Presence Protocol (XMPP). Upon installation, it creates a user account using one's phone number as username (Jabber ID: [phone number]@s.whatsapp.net). WhatsApp software automatically compares all the phone numbers from the device's address book with its central database of WhatsApp users to automatically add contacts to the user's [04:30:23] WhatsApp contact list." [04:44:39] (03CR) 10Krinkle: "@DanielFriesen: Just semantics, but see bug 61577 for more about that." [core] - 10https://gerrit.wikimedia.org/r/113169 (owner: 10Mattflaschen) [04:50:40] (03CR) 10Adamw: Prevent deletion of institutions with courses (031 comment) [extensions/EducationProgram] - 10https://gerrit.wikimedia.org/r/112866 (owner: 10AndyRussG) [05:15:10] (03PS3) 10AndyRussG: Course desc. editable normally, remove some fields [extensions/EducationProgram] - 10https://gerrit.wikimedia.org/r/113912 [05:15:22] (03PS1) 10BryanDavis: Replace dsh with scap.ssh [tools/scap] - 10https://gerrit.wikimedia.org/r/114419 [05:21:51] (03CR) 10BryanDavis: "Not sure what problem Jenkins has "rebasing" this. It's up to date. :(" [tools/scap] - 10https://gerrit.wikimedia.org/r/114419 (owner: 10BryanDavis) [05:22:27] (03PS2) 10BryanDavis: Replace usage of dsh with scap.ssh [tools/scap] - 10https://gerrit.wikimedia.org/r/114419 [05:23:17] ori: ha, I saw that today [05:23:20] (03CR) 10Adamw: [C: 032] Course desc. editable normally, remove some fields [extensions/EducationProgram] - 10https://gerrit.wikimedia.org/r/113912 (owner: 10AndyRussG) [05:23:27] (03Merged) 10jenkins-bot: Course desc. editable normally, remove some fields [extensions/EducationProgram] - 10https://gerrit.wikimedia.org/r/113912 (owner: 10AndyRussG) [05:24:09] kal [05:24:20] ^w [05:26:08] <^demon|zzz> Ohai I just promoted bunches of code reviewurz [05:26:11] <^demon|zzz> https://www.mediawiki.org/w/index.php?title=Gerrit%2FProject_ownership&diff=910687&oldid=910368 [05:26:17] <^demon|zzz> 1 extension, 2 core, 2 wmf [05:26:52] <^demon|zzz> So yeah, welcome newbies. Plz review all the code now. [05:42:46] (03PS1) 10Yuvipanda: Include eventlogging for Popups [vagrant] - 10https://gerrit.wikimedia.org/r/114421 [05:43:05] prtksxna: ^ should fix it, I think. [05:43:12] I'm also not able to ssh [05:43:13] hmm [05:44:54] YuviPanda: I am trying to SSH [05:45:12] YuviPanda: Seems stuck, waiting… [05:45:23] me too [05:45:24] weird [05:45:39] bd808: reviewing [05:45:54] ori: Awesome [05:46:21] YuviPanda: Still stuck :\ [05:46:25] prtksxna: yeah [05:47:08] YuviPanda: That wasn't the case yesterday [05:47:15] yeah [05:47:20] YuviPanda: Yesterday I was getting a weird error message about the ResourceLoader [05:47:21] but chicken. is still reachable [05:47:26] prtksxna: I still get it :D [05:47:40] prtksxna: we didn't have EventLogging installed [05:47:42] YuviPanda: Oh! Right, that is still on [05:47:48] YuviPanda: Right [05:47:57] bd808: https://gerrit.wikimedia.org/r/#/c/114421/ trivial merge? [05:47:58] YuviPanda: I wonder how everything was working on my local machine [05:48:08] prtksxna: you had EventLogging installed, you just didn't know it :P) [05:48:12] from another role, perhaps [05:48:36] YuviPanda: Oh :P [05:48:41] (03CR) 10BryanDavis: [C: 032] Include eventlogging for Popups [vagrant] - 10https://gerrit.wikimedia.org/r/114421 (owner: 10Yuvipanda) [05:48:44] (03Merged) 10jenkins-bot: Include eventlogging for Popups [vagrant] - 10https://gerrit.wikimedia.org/r/114421 (owner: 10Yuvipanda) [05:48:52] ty bd808! [05:48:56] YuviPanda: Then I wonder why I was still getting errors for the GET request, because I didn't set it up? [05:48:59] prtksxna: that patch when merged should take care of it [05:49:14] prtksxna: labs-vagrant enable-role eventlogging && labs-vagrant provision should fix it [05:49:18] if only we could reach it... [05:49:22] if only… [05:49:31] let me try restarting [05:50:10] Antoine and I had ssh issues into labs this morning. Rebooting the instances fixed it for us but YMMV [05:51:03] bd808: hmm, right. I've rebooted [05:51:09] Both of our projects had nodes with high uptimes where the fs autoloader had freaked out and wouldn't mount /home [05:51:35] hmm, this one is relatively recent [05:51:54] nope, ssh still not responding [05:54:19] YuviPanda: I can ssh to the bastion but not beyond. I tried nodes in 3 differnet projects [05:54:29] bd808: ah, so not just me then :) [05:55:04] prtksxna: ^ everything's fucked, so we're ok for now :) give it a bit until the labs people wake up [05:55:42] YuviPanda: Oh, alright [05:56:53] legoktm: https://gerrit.wikimedia.org/r/#/c/114079/5/GlobalCssJs.php why? [05:57:46] YuviPanda: those messages are 'global.js' and 'global.css' which add filter text...except if that feature isn't enabled it doesn't make sense for those messages to "exist" [05:57:56] legoktm: hmm, right. [05:58:50] (03PS6) 10Yuvipanda: Add flag to enable/disable site-wide global CSS/JS [extensions/GlobalCssJs] - 10https://gerrit.wikimedia.org/r/114079 [05:58:53] legoktm: updated. note that this is *completely* untested :P [05:58:57] I assume you have a testing setup [05:59:02] I do! [05:59:29] but no vagrant role :| [06:00:08] legoktm: I guess once this gets deployed we can just point it to meta? :P [06:00:24] legoktm: Zurich will probably have a Vagrant role for CA / WikiFarm [06:00:38] it's not that hard to set up CA [06:00:43] it takes like 5 minutes [06:00:55] if someone puppetized it, it would take like 30 seconds [06:01:07] legoktm: right. [06:01:10] more difficult is setting up multiple wikis [06:01:26] but that's just fiddling with apache config [06:02:35] legoktm: right. [06:03:12] (03CR) 10Technical 13: [C: 031] "I looked through the code and saw no issues. I don't have a local setup at the moment, and as such an unable to actually test it." [core] - 10https://gerrit.wikimedia.org/r/114400 (owner: 10Bartosz Dziewoński) [06:04:35] Is it acceptable to add emacs file specific variables to the files that I commit? [06:04:38] prtksxna: chicken's alive again [06:04:57] º╲˚\╭ᴖ_ᴖ╮/˚╱º Y A Y ! [06:05:06] prtksxna: I just add a .vimrc file in the root directory of vagrant and have vim source that. I think emacs also has a similar thing [06:05:22] YuviPanda: Ah ok [06:05:49] prtksxna: bd808 fixed it! :) [06:07:10] Thanks bd808! What was the problem though? [06:08:11] prtksxna: labs infrastructure issue [06:08:26] Ah! [06:11:32] YuviPanda: vagrant should have a better vimrc [06:11:42] (03PS9) 10Physikerwelt: Coverage tests for the Math extension [extensions/Math] - 10https://gerrit.wikimedia.org/r/112353 [06:11:47] in the end you may choose to deploy your own vimrc on top of it anyway, but still, the default experience could be a lot better [06:11:51] tuned for our coding conventions, for one [06:12:00] ori: you mean the vagrant repo or the vagrant machine? [06:12:03] Hi, I am installing MediaWiki Vagrant. It is getting hanged after "notice: /Stage[main]/Git/Package[git]/ensure: ensure changed 'purged' to 'latest'". [06:13:39] ori: either way I'd agree. At least a minimal one with setexpandtab off [06:13:50] (03CR) 10jenkins-bot: [V: 04-1] Coverage tests for the Math extension [extensions/Math] - 10https://gerrit.wikimedia.org/r/112353 (owner: 10Physikerwelt) [06:29:08] I can't get emacs to run properly with tab stuff, and I can't use TextMate anymore, I just cant :\ [06:30:12] prtksxna: I think its a sign that you should join the vi side :P [06:30:25] bawolff: http://nooooooooooooooo.com/ [06:30:52] i just heard douglas crockford troll his audience about this actually [06:30:54] it was pretty funny [06:31:00] he said, if you take all the code you wrote last year [06:31:07] (03PS10) 10Physikerwelt: Coverage tests for the Math extension [extensions/Math] - 10https://gerrit.wikimedia.org/r/112353 [06:31:12] and just type it up, it would probably take you a day or two at the most [06:31:29] so what are you doing the rest of the time? [06:32:31] so it's probably not worth your time to optimize that environment past a certain point [06:33:08] (03CR) 10jenkins-bot: [V: 04-1] Coverage tests for the Math extension [extensions/Math] - 10https://gerrit.wikimedia.org/r/112353 (owner: 10Physikerwelt) [06:33:44] ori: Makes a lot of sense [06:38:38] (03CR) 10Isarra: [C: 031] "Seems to work as advertised." [core] - 10https://gerrit.wikimedia.org/r/114400 (owner: 10Bartosz Dziewoński) [06:42:58] hi yurik did you check the mail i sent you? i wanted to know what to do about editing now? if we r planning to postpone it then how long cz project deadline is 10th march. [06:56:30] (03PS1) 10Spage: update Permalink browser test for code changes [extensions/Flow] - 10https://gerrit.wikimedia.org/r/114426 [06:59:36] (03CR) 10Spage: [C: 032] "Test passes for me on ee-flow with Firefox, while current code fails everywhere according to https://wmf.ci.cloudbees.com/view/r-fl/ , so " [extensions/Flow] - 10https://gerrit.wikimedia.org/r/114426 (owner: 10Spage) [06:59:47] (03Merged) 10jenkins-bot: update Permalink browser test for code changes [extensions/Flow] - 10https://gerrit.wikimedia.org/r/114426 (owner: 10Spage) [07:06:11] (03PS1) 10Krinkle: QUnit.newMwEnvironment: Use inherit instead of $.extend to save mw.config [core] - 10https://gerrit.wikimedia.org/r/114427 [07:10:02] (03CR) 10jenkins-bot: [V: 04-1] QUnit.newMwEnvironment: Use inherit instead of $.extend to save mw.config [core] - 10https://gerrit.wikimedia.org/r/114427 (owner: 10Krinkle) [07:28:00] (03PS1) 10Krinkle: QUnit.newMwEnvironment: Disable mw.log when copying mw.config [core] - 10https://gerrit.wikimedia.org/r/114432 [07:28:35] (03PS1) 10Krinkle: QUnit.newMwEnvironment: Disable mw.log#warn while copying mw.config [core] - 10https://gerrit.wikimedia.org/r/114433 [07:30:20] (03Abandoned) 10Krinkle: QUnit.newMwEnvironment: Disable mw.log#warn while copying mw.config [core] - 10https://gerrit.wikimedia.org/r/114433 (owner: 10Krinkle) [07:30:34] (03PS2) 10Krinkle: QUnit.newMwEnvironment: Disable mw.log#warn while copying mw.config [core] - 10https://gerrit.wikimedia.org/r/114427 [07:30:46] (03Abandoned) 10Krinkle: QUnit.newMwEnvironment: Disable mw.log when copying mw.config [core] - 10https://gerrit.wikimedia.org/r/114432 (owner: 10Krinkle) [07:37:47] (03PS11) 10Physikerwelt: Coverage tests for the Math extension [extensions/Math] - 10https://gerrit.wikimedia.org/r/112353 [07:38:48] (03PS3) 10Krinkle: QUnit.newMwEnvironment: Disable mw.log#warn while copying mw.config [core] - 10https://gerrit.wikimedia.org/r/114427 [07:39:52] (03CR) 10jenkins-bot: [V: 04-1] Coverage tests for the Math extension [extensions/Math] - 10https://gerrit.wikimedia.org/r/112353 (owner: 10Physikerwelt) [07:54:16] (03PS3) 10Hashar: Compile texvccheck in testsuite [extensions/Math] - 10https://gerrit.wikimedia.org/r/114154 [07:57:49] (03PS4) 10Physikerwelt: Compile texvccheck in testsuite [extensions/Math] - 10https://gerrit.wikimedia.org/r/114154 (owner: 10Hashar) [07:59:11] (03PS5) 10Physikerwelt: Compile texvccheck in testsuite [extensions/Math] - 10https://gerrit.wikimedia.org/r/114154 (owner: 10Hashar) [08:00:17] (03PS6) 10Physikerwelt: Compile texvccheck in testsuite [extensions/Math] - 10https://gerrit.wikimedia.org/r/114154 (owner: 10Hashar) [08:00:54] (03CR) 10Physikerwelt: [C: 032] Compile texvccheck in testsuite [extensions/Math] - 10https://gerrit.wikimedia.org/r/114154 (owner: 10Hashar) [08:01:04] (03Merged) 10jenkins-bot: Compile texvccheck in testsuite [extensions/Math] - 10https://gerrit.wikimedia.org/r/114154 (owner: 10Hashar) [08:01:29] (03PS12) 10Physikerwelt: Coverage tests for the Math extension [extensions/Math] - 10https://gerrit.wikimedia.org/r/112353 [08:02:11] (03PS13) 10Physikerwelt: Coverage tests for the Math extension [extensions/Math] - 10https://gerrit.wikimedia.org/r/112353 [08:04:25] (03CR) 10jenkins-bot: [V: 04-1] Coverage tests for the Math extension [extensions/Math] - 10https://gerrit.wikimedia.org/r/112353 (owner: 10Physikerwelt) [08:08:31] (03CR) 10Aaron Schulz: "Of course this needs to be fixed:" [core] - 10https://gerrit.wikimedia.org/r/92037 (owner: 10CSteipp) [08:17:09] (03PS14) 10Physikerwelt: Coverage tests for the Math extension [extensions/Math] - 10https://gerrit.wikimedia.org/r/112353 [08:19:24] (03CR) 10jenkins-bot: [V: 04-1] Coverage tests for the Math extension [extensions/Math] - 10https://gerrit.wikimedia.org/r/112353 (owner: 10Physikerwelt) [08:28:02] (03PS15) 10Physikerwelt: Coverage tests for the Math extension [extensions/Math] - 10https://gerrit.wikimedia.org/r/112353 [08:29:21] (03PS8) 10Aaron Schulz: Added concurrent HEAD request support for Swift [core] - 10https://gerrit.wikimedia.org/r/107759 [08:30:15] (03CR) 10jenkins-bot: [V: 04-1] Coverage tests for the Math extension [extensions/Math] - 10https://gerrit.wikimedia.org/r/112353 (owner: 10Physikerwelt) [08:32:05] (03PS1) 10Yuvipanda: Minor typo fix [extensions/PageImages] - 10https://gerrit.wikimedia.org/r/114438 [08:32:13] trivial merge, anyone? ^ :) [08:32:57] (03CR) 10Ori.livneh: [C: 032] Minor typo fix [extensions/PageImages] - 10https://gerrit.wikimedia.org/r/114438 (owner: 10Yuvipanda) [08:32:57] rdwrer: ^ typo merge? [08:32:59] (03Merged) 10jenkins-bot: Minor typo fix [extensions/PageImages] - 10https://gerrit.wikimedia.org/r/114438 (owner: 10Yuvipanda) [08:33:00] ah [08:33:02] thanks ori [08:33:17] didn't test [08:33:24] but you know, live dangerously [08:33:49] ori: YES, my plan to finally bring down the cluster is sucessful! [08:36:33] (03PS6) 10Bartosz Dziewoński: mediawiki.notification: Return the Notification object from .notify calls [core] - 10https://gerrit.wikimedia.org/r/110667 [08:36:45] (03CR) 10Ori.livneh: [C: 032] "Nice" [core] - 10https://gerrit.wikimedia.org/r/110667 (owner: 10Bartosz Dziewoński) [08:37:32] (03PS1) 10Rcdeboer: Link directly to media file when [[Media:...]] namespace is used within an imagemap. [extensions/ImageMap] - 10https://gerrit.wikimedia.org/r/114439 [08:37:39] YuviPanda: Fixing bugs often brings down the cluster [08:37:57] We've built our infrastructure around a complex set of bugs that are vital to the system, and hold it in place [08:38:00] rdwrer: but mediawiki has no bugs [08:38:10] YuviPanda: It not having bugs, is a bug. [08:38:28] rdwrer: indeed. let's rewrite it in perl6, should take care of that [08:39:11] Probably! [08:39:17] rdwrer: you should also go to sleep :P [08:39:21] Yeh. [08:40:17] rdwrer: also, the licensing nut in you might like https://bugzilla.wikimedia.org/show_bug.cgi?id=61580 [08:40:45] (03Merged) 10jenkins-bot: mediawiki.notification: Return the Notification object from .notify calls [core] - 10https://gerrit.wikimedia.org/r/110667 (owner: 10Bartosz Dziewoński) [08:41:52] ++YuviPanda [08:50:10] (03PS9) 10Aaron Schulz: Added concurrent HEAD request support for Swift [core] - 10https://gerrit.wikimedia.org/r/107759 [08:50:19] (03CR) 10Ori.livneh: [C: 032] "Code looks sane. If anything breaks I'm sure you'll know how to fix it." [core] - 10https://gerrit.wikimedia.org/r/107759 (owner: 10Aaron Schulz) [08:54:27] (03Merged) 10jenkins-bot: Added concurrent HEAD request support for Swift [core] - 10https://gerrit.wikimedia.org/r/107759 (owner: 10Aaron Schulz) [09:17:00] (03PS1) 10Spage: Update page elements used by Edit existing title [extensions/Flow] - 10https://gerrit.wikimedia.org/r/114442 [09:18:25] (03Abandoned) 10Rcdeboer: Just testing [test/mediawiki/extensions/examples] - 10https://gerrit.wikimedia.org/r/92631 (owner: 10Rcdeboer) [09:18:48] (03CR) 10Ori.livneh: [C: 04-1] Replace usage of dsh with scap.ssh (037 comments) [tools/scap] - 10https://gerrit.wikimedia.org/r/114419 (owner: 10BryanDavis) [09:19:13] (03CR) 10Spage: [C: 032] "This passes in Firefox on ee-flow and all tests are failing on beta labs, so +2ing in order to get cloudbees better." [extensions/Flow] - 10https://gerrit.wikimedia.org/r/114442 (owner: 10Spage) [09:19:25] (03Merged) 10jenkins-bot: Update page elements used by Edit existing title [extensions/Flow] - 10https://gerrit.wikimedia.org/r/114442 (owner: 10Spage) [09:49:18] (03CR) 10Brian Wolff: [C: 032] "There's one in Jpeg.php too. Looks like a copy/paste error from e288e403" [core] - 10https://gerrit.wikimedia.org/r/114409 (owner: 10Reedy) [09:53:08] (03Merged) 10jenkins-bot: Remove undefined $env and TODO comment for it too [core] - 10https://gerrit.wikimedia.org/r/114409 (owner: 10Reedy) [09:59:11] (03Merged) 10jenkins-bot: Minor parameter documentation improvements [extensions/VipsScaler] - 10https://gerrit.wikimedia.org/r/76006 (owner: 10Reedy) [10:25:11] (03PS2) 10UltrasonicNXT: Allow removal of style attribute [extensions/MediaWikiChat] - 10https://gerrit.wikimedia.org/r/114447 [10:26:06] (03CR) 10UltrasonicNXT: [C: 032 V: 032] Allow removal of style attribute [extensions/MediaWikiChat] - 10https://gerrit.wikimedia.org/r/114447 (owner: 10UltrasonicNXT) [10:45:52] (03PS1) 10Amire80: Rephrase ep-undelete-course-no-rights [extensions/EducationProgram] - 10https://gerrit.wikimedia.org/r/114449 [11:07:54] (03CR) 10Bartosz Dziewoński: [C: 032] QUnit.newMwEnvironment: Disable mw.log#warn while copying mw.config [core] - 10https://gerrit.wikimedia.org/r/114427 (owner: 10Krinkle) [11:11:43] (03Merged) 10jenkins-bot: QUnit.newMwEnvironment: Disable mw.log#warn while copying mw.config [core] - 10https://gerrit.wikimedia.org/r/114427 (owner: 10Krinkle) [11:20:34] (03CR) 10Bartosz Dziewoński: [C: 032] Add oojs-ui to the core documentation generator [core] - 10https://gerrit.wikimedia.org/r/114373 (owner: 10MarkTraceur) [11:24:09] (03CR) 10jenkins-bot: [V: 04-1] Add oojs-ui to the core documentation generator [core] - 10https://gerrit.wikimedia.org/r/114373 (owner: 10MarkTraceur) [11:26:18] Krinkle|detached: so, whatever you did to the jsduck job didn't help, it's still segfaulting. https://gerrit.wikimedia.org/r/#/c/114373/ [11:27:52] (03CR) 10Bartosz Dziewoński: [V: 032] Add oojs-ui to the core documentation generator [core] - 10https://gerrit.wikimedia.org/r/114373 (owner: 10MarkTraceur) [11:28:33] (03CR) 10Bartosz Dziewoński: "JSDuck segfaulting is https://bugzilla.wikimedia.org/60138" [core] - 10https://gerrit.wikimedia.org/r/114373 (owner: 10MarkTraceur) [12:00:33] (03CR) 10Bartosz Dziewoński: [C: 032] "Ugh, I don't like this. I suppose there's no nice way to add the @keyframes conditionally :(" [core] - 10https://gerrit.wikimedia.org/r/114404 (owner: 10Mattflaschen) [12:00:37] (03CR) 10jenkins-bot: [V: 04-1] Break out rotation mixin into its own file [core] - 10https://gerrit.wikimedia.org/r/114404 (owner: 10Mattflaschen) [12:02:18] (03CR) 10Bartosz Dziewoński: "jenkins lies, this can be merged. https://bugzilla.wikimedia.org/show_bug.cgi?id=hash-mismatch" [core] - 10https://gerrit.wikimedia.org/r/114404 (owner: 10Mattflaschen) [12:02:22] (03PS4) 10Mattflaschen: Break out rotation mixin into its own file [core] - 10https://gerrit.wikimedia.org/r/114404 [12:02:26] (03CR) 10Bartosz Dziewoński: [C: 032] Break out rotation mixin into its own file [core] - 10https://gerrit.wikimedia.org/r/114404 (owner: 10Mattflaschen) [12:03:21] (03CR) 10Bartosz Dziewoński: [C: 032] Don't print mediawiki.notification messages [core] - 10https://gerrit.wikimedia.org/r/113169 (owner: 10Mattflaschen) [12:06:46] (03Merged) 10jenkins-bot: Break out rotation mixin into its own file [core] - 10https://gerrit.wikimedia.org/r/114404 (owner: 10Mattflaschen) [12:07:33] (03Merged) 10jenkins-bot: Don't print mediawiki.notification messages [core] - 10https://gerrit.wikimedia.org/r/113169 (owner: 10Mattflaschen) [12:09:27] (03Restored) 10Bartosz Dziewoński: use imagemap class for HTML rendering [extensions/GraphViz] - 10https://gerrit.wikimedia.org/r/111475 (owner: 10Welterkj) [12:12:25] (03CR) 10Aklapper: [C: 032 V: 032] "This is awesome, thanks! Works as expected locally (Firefox 27)." [wikimedia/bugzilla/triagescripts] - 10https://gerrit.wikimedia.org/r/114339 (owner: 10Merlijn van Deen) [12:16:22] (03CR) 10Bartosz Dziewoński: "The simplest way to fix the issue would be to revert 739dca730c7f8ab812b5c69d220b2f8232980335 when merging this, as I suppose the rewrite " [extensions/GraphViz] - 10https://gerrit.wikimedia.org/r/111475 (owner: 10Welterkj) [12:26:52] (03PS1) 10UltrasonicNXT: Add max message length [extensions/MediaWikiChat] - 10https://gerrit.wikimedia.org/r/114452 [12:35:13] (03CR) 10Scott Martin: "Technical 13, this is already under discussion at Bugzilla bug 4676. Please don't fork the conversation to yet another venue." [extensions/WikimediaMaintenance] - 10https://gerrit.wikimedia.org/r/112920 (owner: 10Gerrit Patch Uploader) [12:58:40] (03CR) 10Hashar: [C: 032] json-lint: fixing whitespaces [integration/jenkins] - 10https://gerrit.wikimedia.org/r/114161 (owner: 10Hashar) [12:58:43] (03Merged) 10jenkins-bot: json-lint: fixing whitespaces [integration/jenkins] - 10https://gerrit.wikimedia.org/r/114161 (owner: 10Hashar) [13:17:12] (03CR) 10PiRSquared17: "Technical 13: Please keep discussion on the RfC. Nobody will read this." [extensions/WikimediaMaintenance] - 10https://gerrit.wikimedia.org/r/112920 (owner: 10Gerrit Patch Uploader) [13:49:36] (03CR) 10Technical 13: "That's not an advantage in my opinion, and it still doesn't answer why the code has to be in the "misc because the software doesn't like i" [extensions/WikimediaMaintenance] - 10https://gerrit.wikimedia.org/r/112920 (owner: 10Gerrit Patch Uploader) [13:56:45] (03PS1) 10Hashar: Non voting jshint jobs now have a bug report [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/114460 [13:57:06] (03CR) 10Hashar: [C: 032] Non voting jshint jobs now have a bug report [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/114460 (owner: 10Hashar) [13:57:10] (03Merged) 10jenkins-bot: Non voting jshint jobs now have a bug report [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/114460 (owner: 10Hashar) [14:00:01] (03PS3) 10Gerrit Patch Uploader: Rework mediawiki.feedback.js [core] - 10https://gerrit.wikimedia.org/r/105457 [14:00:03] (03CR) 10Gerrit Patch Uploader: "This commit was uploaded using the Gerrit Patch Uploader [1]." [core] - 10https://gerrit.wikimedia.org/r/105457 (owner: 10Gerrit Patch Uploader) [14:08:28] (03PS1) 10Hashar: json-lint.php: report json_last_error_msg() on error [integration/jenkins] - 10https://gerrit.wikimedia.org/r/114462 [14:08:40] (03CR) 10Hashar: [C: 032] json-lint.php: report json_last_error_msg() on error [integration/jenkins] - 10https://gerrit.wikimedia.org/r/114462 (owner: 10Hashar) [14:08:42] (03Merged) 10jenkins-bot: json-lint.php: report json_last_error_msg() on error [integration/jenkins] - 10https://gerrit.wikimedia.org/r/114462 (owner: 10Hashar) [14:16:59] (03PS1) 10Tpt: Improves JavaScript code quality [extensions/ProofreadPage] - 10https://gerrit.wikimedia.org/r/114463 [14:19:58] I am installing the Extension:Translate in MediaWiki Vagrant. I am supposed to clone into the /vagrant/mediawiki/extensions directory right? [14:23:05] BPositive: isn't there a MLEB role? [14:24:00] MLEB? [14:24:17] I cloned it into extensions directory [14:24:34] Nemo_bis: As paravoid suggested, I had added the Email bounce bug project to the https://www.mediawiki.org/wiki/Mentorship_programs/Possible_projects#Featured_project_ideas [14:25:55] ok tonythomas01 [14:26:23] I am getting a database error [14:26:25] A database query error has occurred. This may indicate a bug in the software. [14:26:25] Query: [14:26:25] SELECT tmi_value FROM `translate_messageindex` WHERE tmi_key = '0:main_Page' LIMIT 1 [14:26:25] Function: DatabaseMessageIndex::get [14:26:25] Error: 1146 Table 'wiki.translate_messageindex' doesn't exist (localhost) [14:26:28] Nemo_bis: Now, have to find some mentors ready to help [14:26:42] BPositive: Run update.php. [14:27:01] It´ll be in the maintenance directory. [14:27:44] BPositive: Move to the maintenance directory and run ´´php update.php´´ [14:28:10] I was just about to confirm that :) [14:31:28] Niharika, require_once(/vagrant/LocalSettings.php): failed to open stream: on running update.php Am I missing out on setting any environment variable? [14:31:31] (03PS2) 10Hashar: Improves JavaScript code quality [extensions/ProofreadPage] - 10https://gerrit.wikimedia.org/r/114463 (owner: 10Tpt) [14:33:07] BPositive: Shouldn´t it be vagrant/mediawiki/LocalSettings.php? [14:34:02] Yeah, thats what it should be [14:34:15] (03CR) 10Tpt: [C: 032] "Cosmetic changes" [extensions/ProofreadPage] - 10https://gerrit.wikimedia.org/r/114463 (owner: 10Tpt) [14:34:21] (03Merged) 10jenkins-bot: Improves JavaScript code quality [extensions/ProofreadPage] - 10https://gerrit.wikimedia.org/r/114463 (owner: 10Tpt) [14:35:04] (03CR) 10UltrasonicNXT: [C: 032 V: 032] Add max message length [extensions/MediaWikiChat] - 10https://gerrit.wikimedia.org/r/114452 (owner: 10UltrasonicNXT) [14:35:34] BPositive: No, wait. [14:35:52] It´s the same in my local system, and it works fine. [14:36:25] (03PS1) 10Hashar: mwext-ProofreadPage-jslint is now voting [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/114465 [14:36:41] (03CR) 10Hashar: [C: 032] mwext-ProofreadPage-jslint is now voting [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/114465 (owner: 10Hashar) [14:36:45] (03Merged) 10jenkins-bot: mwext-ProofreadPage-jslint is now voting [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/114465 (owner: 10Hashar) [14:38:47] Niharika, that got resolved. Thanks. [14:39:01] Getting some new error now - "Exception from line 75 of /home/pratik/vagrant/mediawiki/includes/clientpool/RedisConnectionPool.php: RedisConnectionPool requires a Redis client library" [14:40:17] I´ll let someone who´s an expert in this answer it. No idea. [14:40:41] Niharika, I'm fixing it. Will let you know if I am not able to go ahead :) [14:41:32] BPositive: Okay. [14:42:51] Solved. One more now - "DB connection error: Access denied for user 'root'@'localhost' (using password: YES) (localhost)" [14:42:59] Have you faced this before Niharika ? [14:44:11] Niharika, sorry. That got solved too :D [14:44:14] BPositive: No, I haven´t. Have no idea. Sorry. [14:44:21] Oh awesome. :D [14:44:29] Any more errors BPositive? :P [14:46:00] Niharika, nope, the extension is installed! Thank you! :) [14:46:15] You´re welcome. :) [14:59:21] (03Abandoned) 10Bartosz Dziewoński: (Bug 38487) Replaced the with in jquery.wikiEditor.toolbar.config.js [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/53010 (owner: 10Rahul21) [15:03:41] (03PS1) 10Hashar: Ensure jshint uses default settings [extensions/CleanChanges] - 10https://gerrit.wikimedia.org/r/114471 [15:07:45] (03CR) 10Nikerabbit: [C: 032] Ensure jshint uses default settings [extensions/CleanChanges] - 10https://gerrit.wikimedia.org/r/114471 (owner: 10Hashar) [15:07:46] (03Merged) 10jenkins-bot: Ensure jshint uses default settings [extensions/CleanChanges] - 10https://gerrit.wikimedia.org/r/114471 (owner: 10Hashar) [15:10:13] (03PS1) 10Hashar: mwext-CleanChanges-jslint is now voting [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/114472 [15:10:30] (03CR) 10Hashar: [C: 032] mwext-CleanChanges-jslint is now voting [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/114472 (owner: 10Hashar) [15:10:35] (03Merged) 10jenkins-bot: mwext-CleanChanges-jslint is now voting [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/114472 (owner: 10Hashar) [15:10:45] (03PS1) 10Yuvipanda: Make createaccount API return 'Success' [core] - 10https://gerrit.wikimedia.org/r/114473 [15:11:48] Nikerabbit: thank you :-] [15:14:23] (03PS2) 10Yuvipanda: Make ApiCreateAccount return camelcase statuses [core] - 10https://gerrit.wikimedia.org/r/114473 [15:17:56] (03CR) 10jenkins-bot: [V: 04-1] Make ApiCreateAccount return camelcase statuses [core] - 10https://gerrit.wikimedia.org/r/114473 (owner: 10Yuvipanda) [15:20:00] (03PS3) 10Yuvipanda: Make ApiCreateAccount return camelcase statuses [core] - 10https://gerrit.wikimedia.org/r/114473 [15:22:53] anomie: yurik MaxSem asked me to poke you guys about https://bugzilla.wikimedia.org/show_bug.cgi?id=61663 too [15:24:18] yuvipanda: Is the change adding that 'result' deployed anywhere yet? [15:24:31] anomie: been on the cluster for a week or two. [15:25:52] anomie: specifically, the action itself is old - but it didn't work in cluster because it didn't have ConfirmEdit integration, which was done a few weeks ago and deployed a couple of weeks ago [15:26:40] yuvipanda: Hmm. Send a notice to mediawiki-api-announce then. It'll be moderated, but I can approve that. Then I'll +2. [15:26:41] (03PS1) 10Ragesoss: Remove the "field" and "level" options in the course edit view [extensions/EducationProgram] - 10https://gerrit.wikimedia.org/r/114476 [15:26:50] anomie: woo! ok! [15:27:27] yuvipanda: Ping me when the notice is sent [15:27:36] anomie: yeah, composing now [15:27:52] Reedy: Can you merge/push https://gerrit.wikimedia.org/r/#/c/114131/ ? Thanks :) [15:28:14] (03PS1) 10Hashar: Jobs for mw/ext/Git2Pages [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/114477 [15:28:29] (03CR) 10Hashar: [C: 032] Jobs for mw/ext/Git2Pages [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/114477 (owner: 10Hashar) [15:28:51] (03Merged) 10jenkins-bot: Jobs for mw/ext/Git2Pages [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/114477 (owner: 10Hashar) [15:30:02] (03PS1) 10Hashar: Triggers for mw/ext/Git2Pages [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/114478 [15:30:39] (03CR) 10Hashar: [C: 032] Triggers for mw/ext/Git2Pages [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/114478 (owner: 10Hashar) [15:30:44] (03Merged) 10jenkins-bot: Triggers for mw/ext/Git2Pages [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/114478 (owner: 10Hashar) [15:31:46] (03PS1) 10Hashar: Jenkins job validation (DO NOT SUBMIT) [extensions/Git2Pages] - 10https://gerrit.wikimedia.org/r/114479 [15:32:01] (03Abandoned) 10Hashar: Jenkins job validation (DO NOT SUBMIT) [extensions/Git2Pages] - 10https://gerrit.wikimedia.org/r/114479 (owner: 10Hashar) [15:32:13] (03PS3) 10Terrrydactyl: Added unit testing. [extensions/Git2Pages] - 10https://gerrit.wikimedia.org/r/53268 [15:32:46] * anomie wonders if yuvipanda's patch will make it into 1.23wmf15 or will just miss it. [15:32:59] depends on how fast I write email, perhaps? :) [15:33:15] (03CR) 10Hashar: "I have added jobs in Jenkins / Zuul https://gerrit.wikimedia.org/r/#/q/I2e476803ed4b19104195be9154216e978a3171b1,n,z" [extensions/Git2Pages] - 10https://gerrit.wikimedia.org/r/53268 (owner: 10Terrrydactyl) [15:33:48] yuvipanda: I see the new branch hasn't shown up in git yet, anyway. I don't know exactly how or when Reedy makes the cut. [15:34:08] anomie: usually happens a bit later, when more people are in SF office. [15:35:21] anomie: sent. First time I'm writing any form of 'announce' mail, though. [15:35:46] (03PS1) 10MaxSem: Add COPYING [extensions/PageImages] - 10https://gerrit.wikimedia.org/r/114480 [15:36:05] (03CR) 10Multichill: "See https://bugzilla.wikimedia.org/show_bug.cgi?id=61666 for a related bug." [extensions/FlaggedRevs] - 10https://gerrit.wikimedia.org/r/103936 (owner: 10Legoktm) [15:36:35] (03CR) 10Yuvipanda: [C: 04-1] "Trailing spaces yo!" [extensions/PageImages] - 10https://gerrit.wikimedia.org/r/114480 (owner: 10MaxSem) [15:37:01] yuvipanda: Hmm, it hasn't shown up yet. I wonder if it's being slow, or if it just competely rejected your message (maybe you have to be subscribed for it to even show up for moderation) [15:37:13] anomie: I subscribed to it right before sending [15:37:20] anomie, that's my previous experience with -announce [15:37:39] yuvipanda: Oh, good. You thought of that before I did (: [15:37:46] (03PS2) 10Ragesoss: Remove the "field" and "level" options in the course edit view [extensions/EducationProgram] - 10https://gerrit.wikimedia.org/r/114476 [15:37:55] anomie: hmm, 'To ensure the low-traffic character of this list, not everyone can post. If you need to send e-mails to this list, contact the list administrator and request permission to do so. ' [15:38:03] (03CR) 10MaxSem: [C: 032] "...are oerfectly valid." [extensions/PageImages] - 10https://gerrit.wikimedia.org/r/114480 (owner: 10MaxSem) [15:38:05] (03Merged) 10jenkins-bot: Add COPYING [extensions/PageImages] - 10https://gerrit.wikimedia.org/r/114480 (owner: 10MaxSem) [15:38:06] anomie: I can just pastebin my email [15:38:30] yuvipanda: Or just forward it to me. [15:39:12] anomie: forwarded to wikimedia.org [15:40:16] anomie: I wonder if we should backport this also. Having testwiki return something but enwiki return something else sounds painful (for me at least - am working on create account support in the app) [15:41:26] (03CR) 10Anomie: [C: 032] Make ApiCreateAccount return camelcase statuses [core] - 10https://gerrit.wikimedia.org/r/114473 (owner: 10Yuvipanda) [15:42:07] yuvipanda: Ah, I think I see. The list is set to automatically discard any moderated messages. :/ [15:42:14] heh [15:44:50] (03Merged) 10jenkins-bot: Make ApiCreateAccount return camelcase statuses [core] - 10https://gerrit.wikimedia.org/r/114473 (owner: 10Yuvipanda) [15:45:34] (03PS1) 10Umherirrender: Remove another undefined $env and TODO comment for it too [core] - 10https://gerrit.wikimedia.org/r/114482 [15:51:39] (03PS1) 10Yuvipanda: Make ApiCreateAccount return camelcase statuses [core] (wmf/1.23wmf14) - 10https://gerrit.wikimedia.org/r/114483 [15:51:46] anomie: ^ [15:51:54] I think that's the one that'll go to enwiki? [15:53:04] (03PS4) 10Terrrydactyl: Added unit testing. [extensions/Git2Pages] - 10https://gerrit.wikimedia.org/r/53268 [15:53:59] yuvipanda: That'd go to enwiki, yes. You'd want to talk to greg-g about backporting, and probably about using the lightning deploy window to do so. [15:54:19] anomie: hmm, I thought if it gets merged it'll get pushed when Reedy pushes things? [15:54:25] but yeah, I'll talk to greg-g [15:55:15] (03CR) 10Bartosz Dziewoński: [C: 032] "This patch has been dormant for nearly a year and I'm afraid it's abandoned, so let's just merge it if the tests pass." [extensions/Git2Pages] - 10https://gerrit.wikimedia.org/r/53268 (owner: 10Terrrydactyl) [15:55:20] (03CR) 10jenkins-bot: [V: 04-1] Added unit testing. [extensions/Git2Pages] - 10https://gerrit.wikimedia.org/r/53268 (owner: 10Terrrydactyl) [15:55:52] yuvipanda: I think he just updates the "which wiki uses which version" config. [15:56:00] ah, hmm. [15:56:00] right [15:57:18] anomie: this needs a patch in ConfirmEdit too. pushing. [15:57:42] (03PS1) 10Yuvipanda: Expect camelcase status codes from action=createaccount [extensions/ConfirmEdit] - 10https://gerrit.wikimedia.org/r/114484 [15:57:54] anomie: ^ [15:58:16] yuvipanda: I wonder if that should check both cases, or just lc the result before comparing? [15:58:24] (03CR) 10Yurik: [C: 031] Make ApiCreateAccount return camelcase statuses [core] (wmf/1.23wmf14) - 10https://gerrit.wikimedia.org/r/114483 (owner: 10Yuvipanda) [15:58:29] That way there's not such a hard version requirement [15:58:42] anomie: where? In ConfirmEdit? [15:58:46] yuvipanda: Yes [15:58:46] anomie: or in my client code? [15:59:01] anomie: hmm. the code in ConfirmEdit is very recent [15:59:04] yuvipanda: Client code wouldn't hurt too, but I was referring to your ConfirmEdit patch [15:59:54] anomie: the ConfirmEdit code that checks is about 4 weeks old, and depends on hooks introduced in mediawiki core at the same time. [16:00:11] (03CR) 10Anomie: [C: 032] "May as well." [extensions/ConfirmEdit] - 10https://gerrit.wikimedia.org/r/114484 (owner: 10Yuvipanda) [16:00:13] (03Merged) 10jenkins-bot: Expect camelcase status codes from action=createaccount [extensions/ConfirmEdit] - 10https://gerrit.wikimedia.org/r/114484 (owner: 10Yuvipanda) [16:00:21] anomie: thanks :) [16:02:09] (03PS3) 10AndyRussG: Remove the "field" and "level" options in the course edit view [extensions/EducationProgram] - 10https://gerrit.wikimedia.org/r/114476 (owner: 10Ragesoss) [16:07:13] (03CR) 10Ragesoss: [C: 031] "I've reviewed the further changes in PS3, and approve." [extensions/EducationProgram] - 10https://gerrit.wikimedia.org/r/114476 (owner: 10Ragesoss) [16:08:23] yuvipanda: hi there, you rang? [16:08:27] (03CR) 10AndyRussG: [C: 032] Remove the "field" and "level" options in the course edit view [extensions/EducationProgram] - 10https://gerrit.wikimedia.org/r/114476 (owner: 10Ragesoss) [16:08:30] (03CR) 10Cmcmahon: [C: 032] Moved tests from browsertests repository [extensions/WikiLove] - 10https://gerrit.wikimedia.org/r/113104 (owner: 10Zfilipin) [16:08:30] greg-g: yes sir! [16:08:33] (03Merged) 10jenkins-bot: Moved tests from browsertests repository [extensions/WikiLove] - 10https://gerrit.wikimedia.org/r/113104 (owner: 10Zfilipin) [16:08:36] let me find links [16:08:36] (03Merged) 10jenkins-bot: Remove the "field" and "level" options in the course edit view [extensions/EducationProgram] - 10https://gerrit.wikimedia.org/r/114476 (owner: 10Ragesoss) [16:08:47] greg-g: https://bugzilla.wikimedia.org/61663 [16:09:43] greg-g: (tiny) breaking change for the API. anomie merged it on master, so I guess it'll go to testwiki today. Having the API return two different case of status messages across the cluster would be painful, so was hoping we could get it deployed across the cluster. [16:09:57] greg-g: I can probably convince MaxSem to do a LD if you give us a time. [16:10:52] yuvipanda: so, how long has it been this way? [16:10:58] ie: how breaking? :) [16:11:19] greg-g: for about 2 weeks now. [16:11:29] k, do we know of any third-party users of it? [16:11:31] greg-g: MaxSem grepped the logs, found only me :D [16:11:50] heh, sweet [16:12:16] ok then, yeah, let's have it go out with the deploy today, and then we can LD the fix to the rest of the cluster [16:12:28] greg-g: \o/ thanks :) [16:12:46] np, thanks for making things sensible :) [16:12:48] (03PS2) 10Bartosz Dziewoński: User: Be less stringent in getCanonicalName() [core] - 10https://gerrit.wikimedia.org/r/114379 [16:13:55] greg-g: :) Should I ping you after the train goes out to testwiki? [16:14:03] (03PS3) 10Bartosz Dziewoński: User: Be less stringent in getCanonicalName() [core] - 10https://gerrit.wikimedia.org/r/114379 [16:16:15] (03CR) 10PiRSquared17: "I consider that an advantage. When I switch from one wiki to the other, I usually put the prefix in the search box or the URL bar. Search " [extensions/WikimediaMaintenance] - 10https://gerrit.wikimedia.org/r/112920 (owner: 10Gerrit Patch Uploader) [16:21:03] yuvipanda: yeah, sounds good [16:23:00] (03PS2) 10Aude: update wikidata extension branches [tools/release] - 10https://gerrit.wikimedia.org/r/113974 [16:23:04] (03CR) 10Reedy: [C: 032] update wikidata extension branches [tools/release] - 10https://gerrit.wikimedia.org/r/113974 (owner: 10Aude) [16:23:06] (03Merged) 10jenkins-bot: update wikidata extension branches [tools/release] - 10https://gerrit.wikimedia.org/r/113974 (owner: 10Aude) [16:24:40] aude: s/branches/branch/ [16:24:52] got /me confused :P [16:25:25] :) [16:25:35] sudo -u aude git rebase [16:46:28] (03PS7) 10Bartosz Dziewoński: mw.loader.store: Wrap script eval in try/catch [core] - 10https://gerrit.wikimedia.org/r/100930 [16:46:36] (03PS8) 10Bartosz Dziewoński: mw.loader.store: Wrap script eval in try/catch [core] - 10https://gerrit.wikimedia.org/r/100930 [16:47:05] (03CR) 10Bartosz Dziewoński: "Krinkle, I hope this is good enough for you." [core] - 10https://gerrit.wikimedia.org/r/100930 (owner: 10Bartosz Dziewoński) [16:49:26] (03CR) 10Yuvipanda: [C: 032] Remove $wgTitles from all over the place [extensions/MassEditRegex] - 10https://gerrit.wikimedia.org/r/114126 (owner: 10Chad) [16:52:51] (03PS2) 10Chad: Remove $wgTitles from all over the place [extensions/MassEditRegex] - 10https://gerrit.wikimedia.org/r/114126 [16:52:59] (03CR) 10Yuvipanda: [C: 032 V: 032] Remove $wgTitles from all over the place [extensions/MassEditRegex] - 10https://gerrit.wikimedia.org/r/114126 (owner: 10Chad) [16:53:25] https://www.mediawiki.org/wiki/MediaWiki_1.23/wmf15/Changelog [17:07:39] (03CR) 10Bartosz Dziewoński: "Bump? How long can it take to review 12 lines of code?" [core] - 10https://gerrit.wikimedia.org/r/109124 (owner: 10Bartosz Dziewoński) [17:08:26] MatmaRex: It's inversely proportional to... [17:10:26] Reedy: …the priority of the bug? it's on high [17:10:37] You must be new around here... [17:10:38] since october [17:16:29] (03PS6) 10Etienne: WIP: phpunit test for XQuery generation [extensions/MathSearch] - 10https://gerrit.wikimedia.org/r/111468 [17:23:46] (03PS15) 10CSteipp: Password Expiration [core] - 10https://gerrit.wikimedia.org/r/92037 [17:24:38] (03CR) 10jenkins-bot: [V: 04-1] Password Expiration [core] - 10https://gerrit.wikimedia.org/r/92037 (owner: 10CSteipp) [17:25:03] MatmaRex: thanks [17:28:45] greg-g, are you getting a fatal exception at https://www.mediawiki.org/wiki/Talk:MediaWiki/Homepage_redesign/Design_Document ? [17:29:48] qgil: is slow, but wfm [17:30:10] yuvipanda, yes, wfm now as well. It didn't a monute ago after several reloads [17:30:26] qgil: hmm, a deploy is in progress right now, maybe related? [17:30:28] bd808: Reedy ^ [17:30:39] (transient fatals) [17:31:02] Only testwiki should be affected if any [17:31:16] Reedy: oh, not going to mw.org? ok [17:31:23] but even testwiki should still be on wmf14 [17:33:01] Reedy: "PHP Fatal error: Unsupported operand types in /usr/local/apache/common-local/php-1.23wmf15/languages/Language.php on line 516" [17:33:41] I've seen those come and go.. [17:33:42] 69 times and counting in fatalmonitor [17:33:45] Where's that appearing? [17:34:07] mw1151 & mw1152 [17:34:16] <^d> Vague php error that means "you're doing something with an array that you can't" [17:34:21] APC madness [17:34:25] ? [17:34:32] 2 apaches [17:35:16] It seems to only be those two [17:35:23] $this->namespaceNames = $wgExtraNamespaces + $this->namespaceNames + $validNamespaces; [17:35:34] $this->namespaceNames is coming from "some cache" [17:36:27] (03CR) 10Bartosz Dziewoński: [C: 04-1] "I didn't review the code much, but this causes two bugs for me on Opera 12:" [extensions/ApiSandbox] - 10https://gerrit.wikimedia.org/r/112307 (owner: 10Alex Monk) [17:40:11] (03PS1) 10Mattflaschen: Fix jshint by noting global requirement for VE file [extensions/WikimediaEvents] - 10https://gerrit.wikimedia.org/r/114500 [17:41:53] (03PS16) 10CSteipp: Password Expiration [core] - 10https://gerrit.wikimedia.org/r/92037 [17:42:25] (03CR) 10CSteipp: "PS16: rebase release notes" [core] - 10https://gerrit.wikimedia.org/r/92037 (owner: 10CSteipp) [17:45:38] (03CR) 10Mattflaschen: [C: 04-1] "Needs rebase" [core] - 10https://gerrit.wikimedia.org/r/83221 (owner: 10Nemo bis) [17:46:41] (03CR) 10Hashar: [C: 031] Fix jshint by noting global requirement for VE file [extensions/WikimediaEvents] - 10https://gerrit.wikimedia.org/r/114500 (owner: 10Mattflaschen) [17:53:14] (03CR) 10CSteipp: [C: 04-2] "Waiting on schema change to merge this" [core] - 10https://gerrit.wikimedia.org/r/92037 (owner: 10CSteipp) [17:56:48] (03CR) 10Bartosz Dziewoński: Allow multiple prop/list/meta params for action=query (036 comments) [extensions/ApiSandbox] - 10https://gerrit.wikimedia.org/r/112307 (owner: 10Alex Monk) [18:04:06] are there any features of OutputPage that can be used to start outputing content before the backend has finished processing? [18:04:28] particularly the , but perhaps even enough content to fill "above the fold" [18:05:20] i've poked at it, but not seeing anything. OutputPage::output seems like a one-shot output [18:07:49] That's part of the intent of Output page, from what I understand of it. So in case a hook later on sets a header, all the headers and content go out properly [18:09:17] Exactly [18:09:26] so, how do you reduce time to first byte [18:09:27] while you can force it to do such evil things, that wont end well [18:09:53] optimize core ;) [18:09:56] :P [18:10:06] hey csteipp. do you know if the captcha images are cached in varnish? [18:10:09] But seriously, I think Ori is working on that [18:10:12] they seem a bit slow to load, so just checking [18:10:21] yuvipanda: No, they shouldn't be [18:10:28] hmm, ok [18:10:31] They have a unique name each time they are loaded [18:10:39] oh? so the id isn't a unique identifier? [18:10:53] csteipp: perhaps that's why it is slower than a thumb. [18:11:12] No, that references a token on the user's session, which points to the answer [18:11:38] yuvipanda: Yeah, I wouldn't doubt it. Is that a problem? [18:12:23] csteipp: yeah. on the app a captcha is required to create an account, and on my (reasonably fastish) connection it is at least 5-7s to load just the image. [18:12:28] csteipp: and then if you get it wrong another similar wait [18:14:23] yuvipanda: Hmm. Yeah, there's no good way to put the image in varnish (I'm planning to have them regenerate on solve soon, so even if you made the names static now, that wouldn't work soon) [18:15:01] csteipp: ah, hmm. how soon? :) [18:15:10] q2 I hope [18:15:21] csteipp: but I still think perf for those is important. Captchas are already bad-ish UX wise, slow captchas even worse [18:15:34] csteipp: I suppose I"ll file a bug now and try to catch ori's interest [18:16:54] csteipp: filed https://bugzilla.wikimedia.org/show_bug.cgi?id=61693. Do comment with any info you might have [18:17:03] MatmaRex: I never pushed the jsduck update to jenkins [18:17:12] andre__: can you tell me how I can mark a bug as a 'performance' related one? [18:17:16] MatmaRex: We're locked out of Jenkins' configuration API [18:17:23] andre__: nevermind, found it [18:17:29] yuvipanda: Go for it. I started working on making a captcha service in go, with the intent of having MW pull the image and answer from it. But you could access the image directly. But you're still having to go to a web server. Cache doesn't work. [18:17:53] csteipp: right. but I'm sure we can figure something out that makes it faster than how it is now [18:18:03] MatmaRex: It's broken and wont accept any API requests, it's authentication thing is broken.. Im 100% certain the tokens are correct. [18:18:11] heh [18:19:27] yuvipanda: you add a keyword :) [18:19:34] andre__: yeah, just figured it out :) [18:19:40] should've tried before asking. will do next time [18:21:33] (03PS2) 10Matthias Mullie: Show most recent items for watchlist but recentchanges [extensions/Flow] - 10https://gerrit.wikimedia.org/r/114390 (owner: 10Bsitu) [18:22:18] ori: Do you have any idea what the difference between "500 resp/min" (the red line) and "5xx resp/min" (the blue line) is in this graph: https://gdash.wikimedia.org/dashboards/reqerror/ [18:23:46] (03CR) 10Matthias Mullie: Show most recent items for watchlist but recentchanges (031 comment) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/114390 (owner: 10Bsitu) [18:23:59] ori: nevermind, I just figured it out :) [18:25:01] (03PS3) 10Matthias Mullie: Show most recent items for watchlist but recentchanges [extensions/Flow] - 10https://gerrit.wikimedia.org/r/114390 (owner: 10Bsitu) [18:25:15] (03CR) 10Chad: "Hmm. The other option I see is keeping it here, but making it a new top-level parameter. As you and Brion point out there's problems with " [core] - 10https://gerrit.wikimedia.org/r/112913 (owner: 10Chad) [18:26:06] (03CR) 10EBernhardson: [C: 032] Show most recent items for watchlist but recentchanges [extensions/Flow] - 10https://gerrit.wikimedia.org/r/114390 (owner: 10Bsitu) [18:26:17] (03Merged) 10jenkins-bot: Show most recent items for watchlist but recentchanges [extensions/Flow] - 10https://gerrit.wikimedia.org/r/114390 (owner: 10Bsitu) [18:36:03] (03PS1) 10BryanDavis: Restore find_nearest_host to scap-1 [tools/scap] - 10https://gerrit.wikimedia.org/r/114511 [18:37:29] MatmaRex, when you said the diff looks scary, were you in unified or side-by-side? [18:37:57] Reedy: Review plz? ^^ [18:37:58] Krenair: neither, i was in meld :) [18:38:02] Nemo_bis: Nikerabbit see my last comment on https://bugzilla.wikimedia.org/show_bug.cgi?id=47310 [18:38:10] oh [18:38:38] (03PS1) 10Chad: I am not sure why this is suddenly necessary [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/114512 [18:38:38] Krenair: it didn't look like just wrapping some code in loops and i didn't feel like grinding through that just yet :) [18:41:11] <^d> Commit summary of the day? [18:43:10] yuvipanda: hmm, shouldn't it be CDATA in the first place? [18:43:13] (03CR) 10Chad: "More array fun in Ia6cdddd9. Underlying Elastica issues probably need sorting." [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/114512 (owner: 10Chad) [18:43:19] or html escaped [18:43:26] (03CR) 10Chad: "More array fun in I9b7ad8ee. Underlying Elastica issues probably need sorting." [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/112940 (owner: 10Chad) [18:44:08] Nikerabbit: hmm, probably. so will Translate let it through properly if it is in a CData? [18:44:11] CDATA [18:44:40] yuvipanda: I'm still confused whether raw html is okay in messages or not... but yeah it should round-trip, or if not I will fix it immediately, as that should be trivial to fix [18:44:56] Nikerabbit: yeah, as long as it round trips I'm okay with it :) [18:45:12] Nikerabbit: in fact the bug itself is about the fact that it does not roundtrip, and that anything that looks like a tag gets lost [18:45:27] Nikerabbit: I can modify the summary to make that clear if that's better [18:46:18] yuvipanda: I was under the impression there was an unescaped tag inside... if that is not the case, then I was wrong [18:46:46] Nikerabbit: there was an unescaped tag inside. I don't think it was in a CDATA, but I can put it inside one. It doesn't matter to me. [18:47:15] yuvipanda: well, let's try the CDATA then? [18:47:37] Nikerabbit: hmm, ok. Let me put CDATA in all of the wikipedia app's things [18:47:48] on that note, brion - Nikerabbit is here, can you get him to merge wikipedia app into twn? [18:48:19] omg /me hjides [18:48:26] hehe [18:48:49] yuvipanda: i'll write up the provisional config later so he's not on the spot right now ;) [18:48:54] brion: FIND THE WABBIT! FIND THE WABBIT! FIND THE WAAAAAABBBBIIITTTT! :) [18:49:41] (03PS5) 10Chad: WIP: Support interwiki searches in API [core] - 10https://gerrit.wikimedia.org/r/112913 [18:50:09] <^d> brion: info and prop were bad parameters so I made a new one. [18:50:11] <^d> :p [18:50:16] * Nikerabbit eats a carrot innocuously [18:50:34] * yuvipanda sets a JSDuck on Nikerabbit [18:56:50] (03PS1) 10BryanDavis: Stop quoting host list for scap-1 [tools/scap] - 10https://gerrit.wikimedia.org/r/114514 [18:57:09] ori: ^ [18:57:50] (03Abandoned) 10BryanDavis: Restore find_nearest_host to scap-1 [tools/scap] - 10https://gerrit.wikimedia.org/r/114511 (owner: 10BryanDavis) [18:57:52] (03CR) 10Ori.livneh: [C: 032] Stop quoting host list for scap-1 [tools/scap] - 10https://gerrit.wikimedia.org/r/114514 (owner: 10BryanDavis) [18:57:55] (03Merged) 10jenkins-bot: Stop quoting host list for scap-1 [tools/scap] - 10https://gerrit.wikimedia.org/r/114514 (owner: 10BryanDavis) [19:11:08] (03CR) 10MaxSem: Upgrade XDebug, always enable, switch from apt to PECL (032 comments) [vagrant] - 10https://gerrit.wikimedia.org/r/113519 (owner: 10Mattflaschen) [19:24:56] (03CR) 10Ori.livneh: [C: 032] Fix jshint by noting global requirement for VE file [extensions/WikimediaEvents] - 10https://gerrit.wikimedia.org/r/114500 (owner: 10Mattflaschen) [19:24:59] (03Merged) 10jenkins-bot: Fix jshint by noting global requirement for VE file [extensions/WikimediaEvents] - 10https://gerrit.wikimedia.org/r/114500 (owner: 10Mattflaschen) [19:34:45] (03PS1) 10Mattflaschen: Make jshint voting for WikimediaEvents [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/114519 [19:44:06] (03PS3) 10EBernhardson: Reimagine recent changes formatting [extensions/Flow] - 10https://gerrit.wikimedia.org/r/114335 [19:44:09] (03PS2) 10EBernhardson: Tweak Special:Contributions formatting [extensions/Flow] - 10https://gerrit.wikimedia.org/r/114344 [19:49:36] (03PS3) 10Mattflaschen: Upgrade XDebug, always enable, switch from apt to PECL [vagrant] - 10https://gerrit.wikimedia.org/r/113519 [19:50:36] (03CR) 10Mattflaschen: "Patch set 3 responds to comments. See inline." (032 comments) [vagrant] - 10https://gerrit.wikimedia.org/r/113519 (owner: 10Mattflaschen) [19:50:48] (03CR) 10Anomie: [C: 04-1] Allow inclusion of additional fields (034 comments) [extensions/ContactPage] - 10https://gerrit.wikimedia.org/r/113883 (owner: 10Reedy) [19:53:14] anomie: I had actually left comments about HTMLSelectAndOtherField and such on an older commit [19:53:36] Same for options-message [19:53:49] Reedy: Yeah, I didn't see the older-commit comments until after I reviewed [19:54:03] https://gerrit.wikimedia.org/r/#/c/113883/9/ContactPage_body.php,unified [20:00:24] (03PS1) 10Bsitu: Add user based agent blacklist support [extensions/Echo] - 10https://gerrit.wikimedia.org/r/114524 [20:01:23] (03PS5) 10Welterkj: use imagemap class for HTML rendering [extensions/GraphViz] - 10https://gerrit.wikimedia.org/r/111475 [20:01:52] ebernhardson: time to first byte is a useful metric because since most web frameworks flush the output buffer at once, which means that as a measurement it abstracts away most client latency and gives you a view into how long back-end processing is taking [20:02:24] ori: hmm, i suppose perhaps i was spoiled by Symfony2 which has lots of handling for outputing early :) [20:03:04] right, but if you emit the first byte really early and then take a really long time to deliver the remainder of the page, all that means is that the TTFB metric is no longer particularly good at representing backend response time [20:03:36] (03CR) 10Hashar: [C: 032] Make jshint voting for WikimediaEvents [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/114519 (owner: 10Mattflaschen) [20:03:40] (03Merged) 10jenkins-bot: Make jshint voting for WikimediaEvents [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/114519 (owner: 10Mattflaschen) [20:04:13] ebernhardson: what are the really expensive things, in terms of flow backend processing? [20:04:25] ori: right, but it gives the user a much better experience if you can deliver the content for "above the fold" before doing any heavy processing. In particular with flow we could probably output the board header and the before ever loading a topic [20:04:38] * ori nods [20:05:03] ori: within my local profiling, the biggest part taking up time is the rendering [20:05:04] * yuvipanda rewrites MW into a one-page-app, watches everything crawl to a stop [20:05:42] (03PS1) 10Hashar: mwext-RSS-jslint has no .js, make it voting [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/114526 [20:05:54] (03CR) 10Hashar: [C: 032] mwext-RSS-jslint has no .js, make it voting [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/114526 (owner: 10Hashar) [20:06:07] (03CR) 10Anomie: WIP: Support interwiki searches in API (032 comments) [core] - 10https://gerrit.wikimedia.org/r/112913 (owner: 10Chad) [20:06:20] (03PS2) 10Hashar: mwext-RSS-jslint has no .js, make it voting [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/114526 [20:06:24] ori: some of that is i18n messages that we should probably re-use instead of re-rendering each time(but {{GENDER|foo}} can cause difficulties there [20:06:31] (03CR) 10Hashar: [C: 032] mwext-RSS-jslint has no .js, make it voting [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/114526 (owner: 10Hashar) [20:06:35] (03Merged) 10jenkins-bot: mwext-RSS-jslint has no .js, make it voting [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/114526 (owner: 10Hashar) [20:06:51] ebernhardson: is there a particular file where most of this work is contained? [20:06:57] !jenkins mwext-RSS-jslint [20:07:26] hashar: thanks for the wikimediaevents thing [20:07:28] ori: hmm, not a single file, rendering is all done within the templates/ directory. [20:08:53] (03CR) 10Welterkj: "Rebased this change onto master and manually resolved the merge conflict in GraphViz.php. Sorry for my clumsiness in Gerrit (need to do m" [extensions/GraphViz] - 10https://gerrit.wikimedia.org/r/111475 (owner: 10Welterkj) [20:10:25] ori: well I have just complained about jshint not passing :] [20:30:55] (03CR) 10Chad: WIP: Support interwiki searches in API (031 comment) [core] - 10https://gerrit.wikimedia.org/r/112913 (owner: 10Chad) [20:31:18] (03CR) 10Chad: WIP: Support interwiki searches in API (031 comment) [core] - 10https://gerrit.wikimedia.org/r/112913 (owner: 10Chad) [20:31:46] * yuvipanda lobs https://bugzilla.wikimedia.org/show_bug.cgi?id=61693 at ori to have a look at when he has a bit of 'spare' time [20:34:45] (03PS1) 10Jforrester: [WIP] Add VisualEditor support [extensions/SyntaxHighlight_GeSHi] - 10https://gerrit.wikimedia.org/r/114529 [20:34:47] yuvipanda: will do; i have reservations about relative ts btw [20:34:52] may not be a good idea, will update the bug [20:35:39] ori: yeah, I'm not convinced of having a great way to do them without potentially killng perf a fair bit so let's be cautious [20:40:32] (03PS1) 10Hashar: analytics-kraken [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/114530 [20:42:14] (03CR) 10Hashar: [C: 032] analytics-kraken [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/114530 (owner: 10Hashar) [20:42:25] (03Merged) 10jenkins-bot: analytics-kraken [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/114530 (owner: 10Hashar) [21:01:23] (03PS1) 10Bsitu: Test commit [extensions/Echo] - 10https://gerrit.wikimedia.org/r/114539 [21:01:32] (03CR) 10jenkins-bot: [V: 04-1] Test commit [extensions/Echo] - 10https://gerrit.wikimedia.org/r/114539 (owner: 10Bsitu) [21:03:10] (03Abandoned) 10Bsitu: Test commit [extensions/Echo] - 10https://gerrit.wikimedia.org/r/114539 (owner: 10Bsitu) [21:15:28] (03PS4) 10J-squared: Notification for when another user adds you to a course Create separate notification types for each role [extensions/EducationProgram] - 10https://gerrit.wikimedia.org/r/113145 [21:22:40] (03PS5) 10J-squared: Notification for when another user adds you to a course Create separate notification types for each role [extensions/EducationProgram] - 10https://gerrit.wikimedia.org/r/113145 [21:23:53] (03CR) 10J-squared: "Thanks for the icon and notes, Ragesoss! I added campus volunteer and online volunteer roles, and updated the icon." [extensions/EducationProgram] - 10https://gerrit.wikimedia.org/r/113145 (owner: 10J-squared) [21:26:15] (03CR) 10Alex Monk: [C: 04-1] Allow multiple prop/list/meta params for action=query (034 comments) [extensions/ApiSandbox] - 10https://gerrit.wikimedia.org/r/112307 (owner: 10Alex Monk) [21:28:32] (03CR) 10BryanDavis: "Bug: 61689" [tools/scap] - 10https://gerrit.wikimedia.org/r/114514 (owner: 10BryanDavis) [21:36:01] (03PS1) 10Hashar: analytics-kraken maven job [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/114622 [21:38:50] (03Abandoned) 10Manybubbles: Search links [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/105202 (owner: 10Manybubbles) [21:39:33] (03CR) 10Hashar: "Hey Analytics folks. This configuration produce the job http://integration.wikimedia.org/ci/job/analytics-kraken/ which is now triggered " [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/114622 (owner: 10Hashar) [21:41:23] (03PS1) 10Bsitu: Remove namespace restriction [extensions/Echo] - 10https://gerrit.wikimedia.org/r/114627 [21:41:33] (03CR) 10jenkins-bot: [V: 04-1] Remove namespace restriction [extensions/Echo] - 10https://gerrit.wikimedia.org/r/114627 (owner: 10Bsitu) [21:45:02] (03PS2) 10Hashar: analytics-kraken maven job [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/114622 [21:46:30] (03CR) 10Hashar: "I have removed the -Dmaven.test.skip=true option and simply invoke:" [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/114622 (owner: 10Hashar) [21:48:07] (03CR) 10GWicke: [C: 032] Support >2 and JSON-formatted options in parser tests. [core] - 10https://gerrit.wikimedia.org/r/114163 (owner: 10Cscott) [21:52:03] (03Merged) 10jenkins-bot: Support >2 and JSON-formatted options in parser tests. [core] - 10https://gerrit.wikimedia.org/r/114163 (owner: 10Cscott) [21:52:36] (03CR) 10Hashar: "The tests failures already have a bug apparently https://bugzilla.wikimedia.org/show_bug.cgi?id=54046" [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/114622 (owner: 10Hashar) [21:54:15] (03PS2) 10Bsitu: Remove namespace restriction [extensions/Echo] - 10https://gerrit.wikimedia.org/r/114627 [21:54:23] (03CR) 10jenkins-bot: [V: 04-1] Remove namespace restriction [extensions/Echo] - 10https://gerrit.wikimedia.org/r/114627 (owner: 10Bsitu) [21:54:31] (03PS1) 10Reedy: Update usages of wikiversions.dat to wikiversions.json [tools/scap] - 10https://gerrit.wikimedia.org/r/114632 [22:00:03] (03CR) 10Reedy: Allow inclusion of additional fields (032 comments) [extensions/ContactPage] - 10https://gerrit.wikimedia.org/r/113883 (owner: 10Reedy) [22:03:26] (03CR) 10Hashar: "Workaround for https://bugzilla.wikimedia.org/show_bug.cgi?id=60138" [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/114401 (owner: 10Krinkle) [22:16:15] (03PS4) 10Alex Monk: Allow multiple prop/list/meta params for action=query [extensions/ApiSandbox] - 10https://gerrit.wikimedia.org/r/112307 [22:16:49] (03CR) 10Alex Monk: Allow multiple prop/list/meta params for action=query (037 comments) [extensions/ApiSandbox] - 10https://gerrit.wikimedia.org/r/112307 (owner: 10Alex Monk) [22:20:50] (03PS3) 10Mattflaschen: Store page_id in logging table for deletions and make queryable [core] - 10https://gerrit.wikimedia.org/r/113525 [22:22:13] hashar: So, could you reproduce the auth error? [22:22:20] How did you push the jsduck jobs? [22:27:36] (03CR) 10Mattflaschen: "This is ready for review." [core] - 10https://gerrit.wikimedia.org/r/113525 (owner: 10Mattflaschen) [22:29:34] Krinkle: just pushed them as usual. No error [22:29:43] Krinkle: it might be related to varnish being in between you and Jenkins [22:29:51] Krinkle: or some weird crazy configuration issue :( [22:34:20] (03CR) 10Alex Monk: Allow multiple prop/list/meta params for action=query (031 comment) [extensions/ApiSandbox] - 10https://gerrit.wikimedia.org/r/112307 (owner: 10Alex Monk) [22:34:35] (03PS5) 10Alex Monk: Allow multiple prop/list/meta params for action=query [extensions/ApiSandbox] - 10https://gerrit.wikimedia.org/r/112307 [22:36:22] (03PS1) 10Foxtrott: 'class' attribute for all components [skins/chameleon] - 10https://gerrit.wikimedia.org/r/114635 [22:41:34] (03PS1) 10Ori.livneh: Update Schema:Echo revision to r7572295 [extensions/Echo] - 10https://gerrit.wikimedia.org/r/114638 [22:41:43] (03CR) 10Swalling: [C: 04-1] "After discussion on the Design-l mailing list I've become convinced a warning of any kind is the wrong design solution here. Any possibili" [core] - 10https://gerrit.wikimedia.org/r/114400 (owner: 10Bartosz Dziewoński) [22:42:28] (03CR) 10Bartosz Dziewoński: "The user does not need to resubmit the form with this patch." [core] - 10https://gerrit.wikimedia.org/r/114400 (owner: 10Bartosz Dziewoński) [22:44:46] (03CR) 10Swalling: [C: 032] "Simple schema revision update. Updating to version with enum makes sense and was requested by research analysts." [extensions/Echo] - 10https://gerrit.wikimedia.org/r/114638 (owner: 10Ori.livneh) [22:46:44] (03CR) 10Mattflaschen: "Issue with commit message, rest not reviewed yet." (031 comment) [core] - 10https://gerrit.wikimedia.org/r/114400 (owner: 10Bartosz Dziewoński) [22:48:45] how long does a review take, on average? [22:50:03] (03PS1) 10Ori.livneh: Update Echo to master for I84e8f874e [core] (wmf/1.23wmf14) - 10https://gerrit.wikimedia.org/r/114641 [22:50:46] (03PS1) 10Ori.livneh: Update Echo to master for I84e8f874e [core] (wmf/1.23wmf15) - 10https://gerrit.wikimedia.org/r/114642 [22:51:09] greg-g: could I LD a trivial schema update? [22:51:21] (03CR) 10Isarra: "Applying changes on blur is easily missed, and potentially rather confusing because to the user it's strange behaviour that doesn't even e" [core] - 10https://gerrit.wikimedia.org/r/114400 (owner: 10Bartosz Dziewoński) [22:51:36] ori: yep, saw it [22:51:58] (03CR) 10Ori.livneh: [C: 032 V: 032] Update Echo to master for I84e8f874e [core] (wmf/1.23wmf14) - 10https://gerrit.wikimedia.org/r/114641 (owner: 10Ori.livneh) [22:52:07] (03CR) 10Ori.livneh: [C: 032 V: 032] Update Echo to master for I84e8f874e [core] (wmf/1.23wmf15) - 10https://gerrit.wikimedia.org/r/114642 (owner: 10Ori.livneh) [22:54:47] (03CR) 10Swalling: "It should be easily missed. It's completely trivial a change to make the first letter capitalized or remove trailing whitespace." [core] - 10https://gerrit.wikimedia.org/r/114400 (owner: 10Bartosz Dziewoński) [22:55:27] hi [22:57:41] (03CR) 10Hashar: [C: 04-2] "I ran the linter on all mediawiki extensions and found some invalid json files (some progress in https://bugzilla.wikimedia.org/show_bug.c" [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/113958 (owner: 10Hashar) [23:06:30] (03PS1) 10MaxSem: Update MobileFrontend to wmf/1.23wmf15 tip [core] (wmf/1.23wmf15) - 10https://gerrit.wikimedia.org/r/114646 [23:07:16] (03PS1) 10MaxSem: Expect camelcase status codes from action=createaccount [extensions/ConfirmEdit] (wmf/1.23wmf14) - 10https://gerrit.wikimedia.org/r/114647 [23:07:24] (03CR) 10MaxSem: [C: 032] Expect camelcase status codes from action=createaccount [extensions/ConfirmEdit] (wmf/1.23wmf14) - 10https://gerrit.wikimedia.org/r/114647 (owner: 10MaxSem) [23:07:31] (03Merged) 10jenkins-bot: Expect camelcase status codes from action=createaccount [extensions/ConfirmEdit] (wmf/1.23wmf14) - 10https://gerrit.wikimedia.org/r/114647 (owner: 10MaxSem) [23:09:35] (03PS1) 10MaxSem: Update ConfirmEdit to wmf/1.23wmf15 tip [core] (wmf/1.23wmf14) - 10https://gerrit.wikimedia.org/r/114648 [23:10:16] (03PS2) 10Yuvipanda: Make ApiCreateAccount return camelcase statuses [core] (wmf/1.23wmf14) - 10https://gerrit.wikimedia.org/r/114483 [23:24:15] (03PS1) 10Yaron Koren: Changed $article->doPurge() to only be called for SMW < 1.9 [extensions/ApprovedRevs] - 10https://gerrit.wikimedia.org/r/114652 [23:28:52] (03CR) 10Yaron Koren: [C: 032 V: 031] Changed $article->doPurge() to only be called for SMW < 1.9 [extensions/ApprovedRevs] - 10https://gerrit.wikimedia.org/r/114652 (owner: 10Yaron Koren) [23:28:54] (03Merged) 10jenkins-bot: Changed $article->doPurge() to only be called for SMW < 1.9 [extensions/ApprovedRevs] - 10https://gerrit.wikimedia.org/r/114652 (owner: 10Yaron Koren) [23:30:02] (03CR) 10Foxtrott: [C: 032 V: 032] 'class' attribute for all components [skins/chameleon] - 10https://gerrit.wikimedia.org/r/114635 (owner: 10Foxtrott) [23:32:44] (03PS1) 10Krinkle: Create VisualEditor-jsduck job [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/114654 [23:37:30] (03CR) 10Krinkle: [C: 032] "Pushed 'VisualEditor-jsduck' to Jenkins." [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/114654 (owner: 10Krinkle) [23:37:47] (03Merged) 10jenkins-bot: Create VisualEditor-jsduck job [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/114654 (owner: 10Krinkle) [23:39:34] (03PS1) 10Krinkle: mwext-MultimediaViewer-doc-test: Remove redundant 'voting' setting [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/114658 [23:39:44] (03PS13) 10Inchikutty: UploadWizard:OSM embedding- Geocoding, reverse geocoding [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/112342 [23:40:30] (03PS1) 10Krinkle: Enable VisualEditor-jsduck [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/114659 [23:40:54] (03CR) 10Krinkle: [C: 032] mwext-MultimediaViewer-doc-test: Remove redundant 'voting' setting [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/114658 (owner: 10Krinkle) [23:40:59] (03Merged) 10jenkins-bot: mwext-MultimediaViewer-doc-test: Remove redundant 'voting' setting [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/114658 (owner: 10Krinkle) [23:41:10] (03CR) 10Krinkle: [C: 032] Enable VisualEditor-jsduck [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/114659 (owner: 10Krinkle) [23:41:14] (03Merged) 10jenkins-bot: Enable VisualEditor-jsduck [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/114659 (owner: 10Krinkle) [23:45:18] (03CR) 10Bartosz Dziewoński: "I disagree. Reasoning for this has been provided many times over on the design list thread and, in fact, in this commit message here. Plea" [core] - 10https://gerrit.wikimedia.org/r/114400 (owner: 10Bartosz Dziewoński) [23:45:55] (03CR) 10Bartosz Dziewoński: Warn on account creation when username is adjusted (031 comment) [core] - 10https://gerrit.wikimedia.org/r/114400 (owner: 10Bartosz Dziewoński) [23:46:16] (03PS2) 10Bartosz Dziewoński: Warn on account creation when username is adjusted [core] - 10https://gerrit.wikimedia.org/r/114400 [23:46:20] (03PS14) 10Inchikutty: [WIP]:UploadWizard:OSM embedding- Geocoding, reverse geocoding [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/112342 [23:48:53] (03PS2) 10MaxSem: Update ConfirmEdit to wmf/1.23wmf14 tip [core] (wmf/1.23wmf14) - 10https://gerrit.wikimedia.org/r/114648 [23:53:09] (03CR) 10Isarra: [C: 031] "Still looks good, and I'd also like to thank Matt for being lovely." [core] - 10https://gerrit.wikimedia.org/r/114400 (owner: 10Bartosz Dziewoński)