[00:00:09] (03CR) 10Ori.livneh: [C: 04-1] "AFAIK we retain the ability to run the "old" scap by running scap-old, which is a nice safety to have. I share the enthusiasm for killing " [tools/scap] - 10https://gerrit.wikimedia.org/r/113996 (owner: 10BryanDavis) [00:06:24] (03PS10) 10Mattflaschen: [WIP] Add mw-ui-button classes to various buttons [core] - 10https://gerrit.wikimedia.org/r/52169 [00:07:00] (03CR) 10J-squared: "I created separate notifications for adding a student vs adding an instructor (instructor includes campus ambassadors and volunteers, per " (033 comments) [extensions/EducationProgram] - 10https://gerrit.wikimedia.org/r/113145 (owner: 10J-squared) [00:07:13] (03PS16) 10TTO: Merge Poem extension into core [core] - 10https://gerrit.wikimedia.org/r/106861 [00:07:15] (03PS11) 10Mattflaschen: [WIP] Add mw-ui-button classes to various buttons [core] - 10https://gerrit.wikimedia.org/r/52169 [00:08:13] (03CR) 10Reedy: "Need to switch my ContactPage config over for my extended trademark contact form. Currently it's just a list of checkboxes rather than mul" [core] - 10https://gerrit.wikimedia.org/r/114066 (owner: 10Anomie) [00:09:21] (03CR) 10Mattflaschen: "Rebased to latest master. Removed mw-ui-primary everywhere, and started to use the new classes. I didn't consult design yet on this roun" [core] - 10https://gerrit.wikimedia.org/r/52169 (owner: 10Mattflaschen) [00:10:53] https://commons.wikimedia.org/wiki/File:14-01-21-palma-de-mallorca-RalfR-013.jpg looks pretty broken [00:11:18] yikes [00:12:17] page_latest: 0 [00:12:40] (03PS1) 10TTO: Amend release note for $wgPasswordSenderName [core] - 10https://gerrit.wikimedia.org/r/114111 [00:12:44] hoo: It also appears in Special:newimages despite not having an image somehow [00:12:54] wow [00:12:59] neat [00:13:02] (03CR) 10TTO: "In my opinion, something is "deprecated" when it still works, but will soon be removed. It is a warning to migrate away from whatever it i" [core] - 10https://gerrit.wikimedia.org/r/104707 (owner: 10Theopolisme) [00:13:10] bawolff: There's no revision for it either [00:13:21] probably just an "empty" page row floating around [00:13:34] Are there more of these (please say no) [00:14:19] not recently. There's been some intermitent cases I heard of, but I assumed most of them were rather old [00:14:32] at least so far as I've heard [00:15:01] (03CR) 10Matthias Mullie: "1 doubt about spamfilterChecked." (031 comment) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/113681 (owner: 10EBernhardson) [00:15:10] This one I noticed from viewing Special:newimages [00:15:34] (03CR) 10Matthias Mullie: [C: 032] Prefer passing UUID objects in query [extensions/Flow] - 10https://gerrit.wikimedia.org/r/113682 (owner: 10EBernhardson) [00:16:29] hoo: https://commons.wikimedia.org/wiki/File:Lophophorus_impejanus_%28Himalayan_Monal%29_1.JPG was also reported recently [00:16:39] but that's different as it actually has the image attached [00:18:33] very weird [00:19:18] (03CR) 10Matthias Mullie: [C: 032] cleanup some static analysis warnings [extensions/Flow] - 10https://gerrit.wikimedia.org/r/113683 (owner: 10EBernhardson) [00:20:02] Some sort of error handling in the upload code isn't working properly I guess [00:20:17] log_page is also 0 for the log item [00:21:58] (03CR) 10EBernhardson: de-duplicate spam filter calling code (031 comment) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/113681 (owner: 10EBernhardson) [00:23:53] (03CR) 10Bartosz Dziewoński: [C: 032] Amend release note for $wgPasswordSenderName [core] - 10https://gerrit.wikimedia.org/r/114111 (owner: 10TTO) [00:24:03] (03PS8) 10Matthias Mullie: Test permissions on multiple revisions in 1 object [extensions/Flow] - 10https://gerrit.wikimedia.org/r/112844 [00:24:29] Hmm, nothing checks to see if $wikiPage->doEditContent returns success in file/LocalFile.php [00:26:45] ori: ping [00:27:12] (03CR) 10BryanDavis: "Keeping scap-2 to retain old-scap functionality is fine. I'd already forgotten that we'd done that." [tools/scap] - 10https://gerrit.wikimedia.org/r/113996 (owner: 10BryanDavis) [00:27:14] (03Merged) 10jenkins-bot: Amend release note for $wgPasswordSenderName [core] - 10https://gerrit.wikimedia.org/r/114111 (owner: 10TTO) [00:32:37] (03CR) 10Physikerwelt: "I'm not a fan of checking in the node modules too. But I think that's the most pragmatic solution at the moment. If we find a way to conve" [services/mathoid] - 10https://gerrit.wikimedia.org/r/113025 (owner: 10Physikerwelt) [00:34:19] !tvrage info \0 [00:40:02] ysangkok: Hi, I was just looking at your patch at https://gerrit.wikimedia.org/r/#/c/113759/ [00:40:36] bawolff: thanks [00:41:14] I haven't really looked at it in detail, but certainly looks like a cool idea [00:42:03] Wow, this one is really broken - https://commons.wikimedia.org/wiki/File:Den_vernede_r%C3%B8de_telefonkiosken_p%C3%A5_Gamletorvet_p%C3%A5_Gj%C3%B8vik-2.jpg it has multiple file versions but history went goodbye [00:42:22] * bawolff subsequently got distracted by commons db integrity issues. [00:44:50] it would be better if the static files were also served dynamically, i think it's very unclean that the extension changes when the mime-type in the file changes [00:45:27] and i don't know how to serve error messages properly... there is no way to know how wide the image containing the error message should be [00:46:56] of course, it would be best not even to put the error message in the image, but i'm not sure how to do that... [00:48:11] on big sites, files are served behind varnish anyway, so it's not like static file hosting is gaining much [00:52:49] (03Abandoned) 10Ori.livneh: Make the OS reap children by explicitly setting a SIG_IGN handler to SIGCHLD [tools/scap] - 10https://gerrit.wikimedia.org/r/114107 (owner: 10Ori.livneh) [00:58:36] hoo: Well https://dpaste.de/PdNF is rather concerning [00:59:17] bawolff: yikes... at least the file's not missing [00:59:22] //upload.wikimedia.org/wikipedia/commons/9/9f/14-01-21-palma-de-mallorca-RalfR-013.jpg [01:00:13] (03PS2) 10EBernhardson: de-duplicate spam filter calling code [extensions/Flow] - 10https://gerrit.wikimedia.org/r/113681 [01:00:17] (03CR) 10jenkins-bot: [V: 04-1] de-duplicate spam filter calling code [extensions/Flow] - 10https://gerrit.wikimedia.org/r/113681 (owner: 10EBernhardson) [01:00:45] hoo: So there's caching issues on top of that, as https://commons.wikimedia.org/wiki/File:14-01-21-palma-de-mallorca-RalfR-013.jpg was behaving as if the file was missing until I purged it [01:02:52] ouch [01:02:55] (03PS3) 10EBernhardson: de-duplicate spam filter calling code [extensions/Flow] - 10https://gerrit.wikimedia.org/r/113681 [01:03:00] I just blanked the main page by trying to edit it [01:03:10] Note to self: Don't try that again [01:07:33] Reedy: Around? [01:12:03] hoo: sort of [01:13:00] Reedy: Is that file https://commons.wikimedia.org/wiki/File:14-01-21-palma-de-mallorca-RalfR-013.jpg locally deletable? If not, is it acceptable to like delete hte page row entry for it (it's a file with page table entry, but 0 revisions) [01:14:38] "14-01-21-palma-de-mallorca-RalfR-013.jpg" has been deleted (undelete). See the deletion log for a record of recent deletions. Depending on the reason for deletion, you may want to remove any links to this page. [01:15:28] (03CR) 10EBernhardson: [C: 032] Test permissions on multiple revisions in 1 object [extensions/Flow] - 10https://gerrit.wikimedia.org/r/112844 (owner: 10Matthias Mullie) [01:15:38] (03Merged) 10jenkins-bot: Test permissions on multiple revisions in 1 object [extensions/Flow] - 10https://gerrit.wikimedia.org/r/112844 (owner: 10Matthias Mullie) [01:16:12] damn, I can't even restore the file -.- [01:16:19] could you *hides* [01:16:54] File:14-01-21-palma-de-mallorca-RalfR-013.jpg has been restored [01:16:54] Consult the deletion log for a record of recent deletions and restorations. [01:16:54] Undelete failed: No matching pages found in the deletion archive. [01:17:41] well, it worked... [01:17:53] (03CR) 10Matthias Mullie: [C: 032] "This is good for now; don't really have a good idea to foolproof the checks" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/113681 (owner: 10EBernhardson) [01:18:05] (03Merged) 10jenkins-bot: de-duplicate spam filter calling code [extensions/Flow] - 10https://gerrit.wikimedia.org/r/113681 (owner: 10EBernhardson) [01:18:16] I think db integrity failure sums up the situation [01:18:36] (03PS1) 10MarkTraceur: Add mwe-upwiz-upload-error-duplicate-archive to RL def [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/114117 [01:19:09] (03CR) 10Brian Wolff: [C: 032] Add mwe-upwiz-upload-error-duplicate-archive to RL def [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/114117 (owner: 10MarkTraceur) [01:19:16] (03Merged) 10jenkins-bot: Add mwe-upwiz-upload-error-duplicate-archive to RL def [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/114117 (owner: 10MarkTraceur) [01:24:59] (03CR) 10Jforrester: [C: 031] Add flag to enable/disable site-wide global CSS/JS [extensions/GlobalCssJs] - 10https://gerrit.wikimedia.org/r/114079 (owner: 10Yuvipanda) [01:32:03] (03CR) 10Aaron Schulz: "I guess the circular dependency is only between very related classes, and the object reference graph is still acyclic so I guess that's fi" [core] - 10https://gerrit.wikimedia.org/r/77645 (owner: 10Parent5446) [01:33:37] (03PS4) 10BryanDavis: Replace scap-2 with python [tools/scap] - 10https://gerrit.wikimedia.org/r/113996 [01:41:10] (03PS5) 10Ori.livneh: Remove external script dependencies from sync_common [tools/scap] - 10https://gerrit.wikimedia.org/r/113996 (owner: 10BryanDavis) [01:51:03] (03PS2) 10Matthias Mullie: Prefer passing UUID objects in query [extensions/Flow] - 10https://gerrit.wikimedia.org/r/113682 (owner: 10EBernhardson) [01:51:06] (03CR) 10BryanDavis: [C: 04-1] "Notes on Ori's addition." (033 comments) [tools/scap] - 10https://gerrit.wikimedia.org/r/113996 (owner: 10BryanDavis) [01:51:11] (03CR) 10Matthias Mullie: [C: 032] Prefer passing UUID objects in query [extensions/Flow] - 10https://gerrit.wikimedia.org/r/113682 (owner: 10EBernhardson) [01:51:25] (03Merged) 10jenkins-bot: Prefer passing UUID objects in query [extensions/Flow] - 10https://gerrit.wikimedia.org/r/113682 (owner: 10EBernhardson) [01:51:33] (03PS1) 10Bsitu: Add missing 'use' statements [extensions/Flow] - 10https://gerrit.wikimedia.org/r/114120 [01:51:46] (03PS2) 10Matthias Mullie: cleanup some static analysis warnings [extensions/Flow] - 10https://gerrit.wikimedia.org/r/113683 (owner: 10EBernhardson) [01:52:13] (03CR) 10Matthias Mullie: [C: 032] cleanup some static analysis warnings [extensions/Flow] - 10https://gerrit.wikimedia.org/r/113683 (owner: 10EBernhardson) [01:52:25] (03Merged) 10jenkins-bot: cleanup some static analysis warnings [extensions/Flow] - 10https://gerrit.wikimedia.org/r/113683 (owner: 10EBernhardson) [01:52:38] (03CR) 10Matthias Mullie: [C: 032] Add missing 'use' statements [extensions/Flow] - 10https://gerrit.wikimedia.org/r/114120 (owner: 10Bsitu) [01:52:50] (03Merged) 10jenkins-bot: Add missing 'use' statements [extensions/Flow] - 10https://gerrit.wikimedia.org/r/114120 (owner: 10Bsitu) [01:57:33] (03CR) 10Matthias Mullie: [C: 031] "Looks good at first sight; need to do some testing" (031 comment) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/112846 (owner: 10EBernhardson) [02:10:31] (03CR) 10Mattflaschen: "Reply inline." (031 comment) [core] - 10https://gerrit.wikimedia.org/r/113525 (owner: 10Mattflaschen) [02:15:52] (03PS2) 10Mattflaschen: WIP: Store the page_id in the logging table for deletions. [core] - 10https://gerrit.wikimedia.org/r/113525 [02:16:03] (03CR) 10Mattflaschen: "Patch set 2 is just a comment change." [core] - 10https://gerrit.wikimedia.org/r/113525 (owner: 10Mattflaschen) [02:25:10] AaronSchulz, would appreciate you looking at https://gerrit.wikimedia.org/r/#/c/113525/ to see if it looks error-safe, and also if it can be simplified. [02:25:37] It's WIP since I still need to add the read part (updating the log API), but that should be it for the write part if it looks good. [02:36:09] (03PS6) 10Ori.livneh: Remove external script dependencies from sync_common [tools/scap] - 10https://gerrit.wikimedia.org/r/113996 (owner: 10BryanDavis) [02:36:48] if $x contains strip markers, will $frame->expand($x) leave them stripped? [02:37:04] I believe so [02:38:50] (03PS7) 10Ori.livneh: Remove external script dependencies from sync_common [tools/scap] - 10https://gerrit.wikimedia.org/r/113996 (owner: 10BryanDavis) [02:39:45] (03PS8) 10Ori.livneh: Remove external script dependencies from sync_common [tools/scap] - 10https://gerrit.wikimedia.org/r/113996 (owner: 10BryanDavis) [02:42:04] (03PS1) 10Ori.livneh: Make pyflakes shut up about unused imports [tools/scap] - 10https://gerrit.wikimedia.org/r/114123 [02:42:38] (03CR) 10Ori.livneh: [C: 032] "trivial" [tools/scap] - 10https://gerrit.wikimedia.org/r/114123 (owner: 10Ori.livneh) [02:42:40] (03Merged) 10jenkins-bot: Make pyflakes shut up about unused imports [tools/scap] - 10https://gerrit.wikimedia.org/r/114123 (owner: 10Ori.livneh) [02:42:52] (03PS9) 10BryanDavis: Remove external script dependencies from sync_common [tools/scap] - 10https://gerrit.wikimedia.org/r/113996 [02:43:59] (03CR) 10Mattflaschen: "I can add the separate file if people still are convinced it's better (e.g. there is a skin where this won't work)" [core] - 10https://gerrit.wikimedia.org/r/113169 (owner: 10Mattflaschen) [02:48:55] (03PS2) 10Aaron Schulz: Removed STRAIGHT_JOIN; the is slower when a namespace has a few pages [core] - 10https://gerrit.wikimedia.org/r/114070 [02:49:27] (03CR) 10Springle: [C: 032] Removed STRAIGHT_JOIN; the is slower when a namespace has a few pages [core] - 10https://gerrit.wikimedia.org/r/114070 (owner: 10Aaron Schulz) [02:53:07] (03Merged) 10jenkins-bot: Removed STRAIGHT_JOIN; the is slower when a namespace has a few pages [core] - 10https://gerrit.wikimedia.org/r/114070 (owner: 10Aaron Schulz) [03:29:46] (03CR) 10Jdlrobson: [C: 04-1] "Please consider adding on a skin basis. Mobile is jot ready for MediaWiki.ui buttons..." [core] - 10https://gerrit.wikimedia.org/r/114085 (owner: 10Mattflaschen) [03:32:17] (03CR) 10BryanDavis: [C: 04-1] Remove external script dependencies from sync_common (032 comments) [tools/scap] - 10https://gerrit.wikimedia.org/r/113996 (owner: 10BryanDavis) [03:33:01] (03CR) 10Isarra: "While the 'legacy' modules may need some cleanup and whatnot, the noprint class ain't going anywhere. It's not just skins that use it, but" [core] - 10https://gerrit.wikimedia.org/r/113169 (owner: 10Mattflaschen) [03:44:53] (03PS10) 10BryanDavis: Remove external script dependencies from sync_common [tools/scap] - 10https://gerrit.wikimedia.org/r/113996 [03:50:14] (03CR) 10BryanDavis: [C: 031] Remove external script dependencies from sync_common [tools/scap] - 10https://gerrit.wikimedia.org/r/113996 (owner: 10BryanDavis) [03:58:39] What is the 51 in refs/changes/51/113951/2? [04:00:51] In gerrit ^ [04:02:57] prtksxna: I think it's the last two digits of the Gerrit change ID. [04:03:01] 113951 --> 51 [04:03:06] 113996 --> 96 [04:03:19] 12345 --> 45 [04:03:29] The number after the slash is the patch set number. [04:03:57] prtksxna: The idea is to ensure that no directory gets too big. [04:04:16] If everything were in refs/changes/, it would become quite large. [04:04:35] This divides it by 100 (00–99) pieces, I guess. [04:04:46] Gloria: Oh, so just the last digits? That pretty cool :) [04:04:48] Gloria: Thanks :) [04:04:56] s/by/into/ [04:04:58] No problem. [04:05:15] prtksxna: MediaWiki does something similar with its images directory. [04:05:25] You'll notice images are sorted into a/12/foo.png or whatever. [04:05:33] It's based on the md5 hash of the file name, as I recall. [04:05:45] Same principle: avoid very large file system directories. [04:05:58] Gloria: Ah! But how does it matter how large a folder becomes? [04:06:02] Example: https://upload.wikimedia.org/wikipedia/mediawiki/4/4d/Pageview-logic.png [04:06:11] (03PS1) 10BryanDavis: Avoid creating ssh orphans [tools/scap] - 10https://gerrit.wikimedia.org/r/114124 [04:06:16] prtksxna: Have you ever had a folder with over a million files? :-) [04:06:23] It gets slow. [04:06:31] Gloria: I havent :P [04:06:35] Gloria: I see [04:06:58] https://upload.wikimedia.org/wikipedia/mediawiki/4/4d/Pageview-logic.png <-- Example. [04:07:21] 4/4d comes from... [04:07:29] $ echo -n "Pageview-logic.png" | openssl dgst -md5 [04:07:29] 4d2e97787a765a055416983265cb41b5 [04:08:06] It's a neat party trick, anyway. [04:08:31] :) [04:08:55] I asked because I was writing a bash script to quickly push changes to my labs instance [04:09:01] Thanks a lot Gloria :D [04:09:19] Bash scripts + string manipulation is usually pretty ugly. [04:09:27] Though getting the last two digits of a string shouldn't be difficult. [04:10:31] Gloria: Yup, I'll just use tail -c 3 [04:10:58] I think you can do it without tail. [04:11:26] tail will spawn a new process unnecessarily, won't it? [04:12:10] Gloria: Hm, what do you suggest? [04:12:37] last_three_of_var=${var:-3} [04:12:58] If you are using bash anyway [04:13:27] bd808: Yes, bash. I'll try that out. Thanks :) [04:13:34] Look for "Substring Expansion" in the bash man page [04:14:13] bd808 knows the score. [04:15:15] Modern bash is actually a pretty feature rich programming environment but about as readable as perl4 [04:15:15] Or use a real programming language. ;-) [04:15:51] * bd808 rewrites Gloria in python [04:15:54] bash is a nice way to distract yourself for a day or two, but if you're interested in doing other things, use a real language. [04:16:03] Python 3.4 or newer, please. [04:16:08] BASIC [04:16:40] Anyone even remember how to code in BASIC? [04:17:04] I was just googling to remind myself :) [04:17:05] T13|sleeps: GOTO 3 [04:17:44] ? "Hello world!" [04:18:03] Gloria: zz_yuvipanda suggested I try my hand at this :) [04:18:23] It's a good learning exercise. [04:18:56] Gloria: I'd point out that the 4/4d thing doesn't go to real folders anymore :P [04:19:21] bawolff: Where do we store files these days? THE CLOUD? [04:19:34] It goes to real folders for most MediaWiki wikis, I imagine. [04:20:02] Actually yes, we use swift as what is technically a private "cloud" (I think, I try to avoid cloud terminology so I don't really know what those words mean) [04:20:13] Yeah, normal people get real folders [04:20:24] What does Swift use instead of directories? [04:20:41] Swift is a "storage service with a REST interface" [04:20:58] Same question. [04:21:41] * bawolff has no idea how swift works or what it actually does with the files [04:21:47] https://en.wikipedia.org/wiki/Swift_(software) [04:21:55] Somewhere is has files and folders but they are not necessarily organized the same way as the URIs that are used for access [04:22:12] I catually have avoided digging into the guts so far [04:22:16] *actually [04:22:34] Gloria: https://en.wikipedia.org/wiki/OpenStack#Object_Storage_.28Swift.29 [04:22:38] bd808: http://pastie.org/pastes/8747433/text [04:23:20] bawolff: Right. That doesn't really discuss what we're discussing, though. [04:23:29] prtksxna: Lame. I'll see if I can figure out where I steered you wrong. [04:23:30] bd808: ${var:-3} isn't working for me, am I doing something wrong? [04:23:44] You have to define var first. [04:23:46] Did you do that? [04:23:58] Hmm. [04:24:06] Gloria: Which one? I defined "K" [04:24:13] Sorry, I see the paste now. [04:24:20] prtksxna: Run "echo $SHELL". [04:24:26] Gloria: I have this now \o/ https://gist.github.com/prtksxna/9085873 [04:24:40] Gloria: /bin/bash [04:25:12] prtksxna: Quote marks. :-) [04:25:16] bash is super-sensitive about them. [04:25:31] Gloria: I followed this http://thornelabs.net/2013/08/21/a-simple-way-to-send-multiple-line-commands-over-ssh.html [04:26:06] You can use cowsay -f sodomized or something more interesting. [04:26:09] prtksxna: K=12345; echo $K; L=${K: -3}; echo $L [04:26:17] The space is imporant [04:27:01] Oh, I thought it was quote marks. [04:27:12] "Note that a negative offset must be separated from the colon by at least one space to avoid being confused with the :- expansion." [04:27:17] bash is also sensitive about spaces. [04:27:23] * bd808 just read that bit [04:27:24] bd808: Works with the space, thanks [04:27:33] eee too much fuss [04:27:40] $ brew install cowsay [04:27:43] All better. [04:28:13] hehe [04:28:49] Gloria: I don't have the -f cowfile :\ [04:28:55] Lame. [04:29:17] :( [04:29:22] The sodomized variant is adorbz. [04:29:35] https://gist.github.com/prtksxna/9085873 <-- You can kill the tail here. [04:29:37] For nerd cred. [04:31:36] Gloria: Already did :D [04:31:48] Nice. [04:32:10] Gloria: Also using fortune -s now :P [04:32:51] There used to be a cowsay template on the English Wikipedia. [04:32:57] RIP. [04:34:49] Oh :| [04:57:07] (03PS11) 10Ori.livneh: Remove external script dependencies from sync_common [tools/scap] - 10https://gerrit.wikimedia.org/r/113996 (owner: 10BryanDavis) [04:57:39] bd808: ^ [04:57:48] * bd808 looks [04:59:39] bd808: brrrr... hash randomization is only the default in 3.3+ [04:59:43] so still need to shuffle [05:01:46] I like the new tricks though. Did you test it this time? :) [05:02:25] ori: Can I have a minute please? [05:03:04] I'm on the laptop that can't access prod so I can't test at the moment [05:03:49] prtksxna: what's up? [05:04:24] ori: I made the changes that you had mentioned on https://gerrit.wikimedia.org/r/#/c/112661/ Do you think you could merge? [05:04:32] bd808: and yes, tested. i don't think randomization is required, actually. if you look at the scap-proxies there's a clear winner for each host iirc [05:05:30] ori: Also, can you help me resolve this bug https://bugzilla.wikimedia.org/show_bug.cgi?id=52287 [05:05:45] (03CR) 10Chad: [C: 032 V: 032] "Self-merging because I kept asking for review but nobody cared." [extensions/BiblioPlus] - 10https://gerrit.wikimedia.org/r/111481 (owner: 10Chad) [05:05:47] ori: That's probably true with the current rsync hosts. Not necessarily universally true [05:05:54] ori: I have most of the code in the Popups extension and some extra stuff for command and scroll clicks [05:06:07] prtksxna: ok, i'll review. hang on just a moment, since bd808 is on his way to bed, probably [05:06:11] (03CR) 10Chad: [C: 032 V: 032] "Self-merging because I kept asking for review but nobody cared." [extensions/Wikilog] - 10https://gerrit.wikimedia.org/r/111504 (owner: 10Chad) [05:06:28] ori: Sure :) [05:06:55] (03CR) 10Chad: [C: 032 V: 032] "Self-merging because I kept asking for review but nobody cared." [extensions/GraphViz] - 10https://gerrit.wikimedia.org/r/111499 (owner: 10Chad) [05:07:03] (03CR) 10Chad: [C: 032 V: 032] "Self-merging because I kept asking for review but nobody cared." [extensions/GoogleMaps] - 10https://gerrit.wikimedia.org/r/111491 (owner: 10Chad) [05:07:08] (03CR) 10Chad: [C: 032 V: 032] "Self-merging because I kept asking for review but nobody cared." [extensions/ExtTab] - 10https://gerrit.wikimedia.org/r/111488 (owner: 10Chad) [05:07:38] ^d: http://www.youtube.com/watch?v=DJGYEF4MNq4&feature=kp [05:08:13] <^d> https://www.youtube.com/watch?v=kjTOWH3q1eA [05:09:12] (03CR) 10Chad: [C: 032 V: 032] Get title from article rather than $wgTitle [extensions/Video] - 10https://gerrit.wikimedia.org/r/111529 (owner: 10Chad) [05:09:32] ori: You could shuffle the original list and use collections.OrderedDict I suppose [05:09:54] Or you could keep a list of matches at the same ttl, shuffle and pop [05:15:44] (03PS12) 10Ori.livneh: Remove external script dependencies from sync_common [tools/scap] - 10https://gerrit.wikimedia.org/r/113996 (owner: 10BryanDavis) [05:16:46] Or you could keep a list of matches at the same ttl, shuffle and pop <-- nah, it's faster to abort the search when there's a hit [05:18:50] * ori boggles at jenkins [05:19:04] (03CR) 10BryanDavis: [C: 031] "ori's changes look good to me." [tools/scap] - 10https://gerrit.wikimedia.org/r/113996 (owner: 10BryanDavis) [05:19:24] (03CR) 10Ori.livneh: [C: 032] Remove external script dependencies from sync_common [tools/scap] - 10https://gerrit.wikimedia.org/r/113996 (owner: 10BryanDavis) [05:19:26] (03Merged) 10jenkins-bot: Remove external script dependencies from sync_common [tools/scap] - 10https://gerrit.wikimedia.org/r/113996 (owner: 10BryanDavis) [05:20:09] jenkins is dumb sometimes [05:20:29] "I can't merge that… oh wait I guess I didn't try" [05:22:19] ^d: are you guys going to deploy tomorrow in the end? [05:22:35] <^d> In the end? [05:22:43] the calendar says 'hold', so i wasn't sure [05:22:58] <^d> Ah, that's a standing hold, we usually don't use it. [05:23:13] <^d> Only thing I can think of is one minor performance fix Nik might sneak out then if he didn't do it today. [05:24:05] bd808: if nik doesn't need to deploy, or is done quickly, want to try updating scap tomorrow at 10 AM mountain? [05:24:12] updating and scapping [05:25:09] ori: I've got my 1-on-1 with Rob then [05:25:16] exactly! [05:25:28] he'll be impressed [05:25:52] i might try then if you're busy [05:26:00] * bd808 nods [05:26:10] Use tee to record the logs [05:26:32] * bd808 needs to get a udp2log bit written for python [05:26:59] Do we already have that somewhere? An appender that sends to the udp2log relay? [05:27:42] (03PS1) 10Chad: Remove final usage of $wgArticle anywhere in git [extensions/BlueSpiceFoundation] - 10https://gerrit.wikimedia.org/r/114125 [05:27:43] yes, it's called socket.sendto [05:27:45] ships with python [05:28:06] <^d> $wgArticle is finally gone from everything forever :) [05:28:18] quick, -2 the patch! [05:28:19] (03CR) 10Mattflaschen: [C: 04-1] "Use the .background-image mixin from https://www.mediawiki.org/wiki/Manual:Coding_conventions/LESS#Less ." [extensions/GuidedTour] - 10https://gerrit.wikimedia.org/r/113875 (owner: 10Phuedx) [05:28:28] RIP, $wgArticle. [05:29:19] bd808: is it really down to dsh and mw-update-l10n? [05:29:23] bd808: After you finish scap, can you fix the server admin log implementation? [05:29:24] as far as shelling out? [05:30:08] ori: I think so. mw-update-l10n is a big pile of shell though [05:30:26] wrapped around a lot of "interesting" php [05:30:33] Heh. [05:30:52] that's still pretty l33t [05:31:06] Gloria: a better SAL is on my list of someday projects [05:31:17] Mine's longer. [05:31:28] Mine's longer, Sal. [05:31:44] https://bugzilla.wikimedia.org/show_bug.cgi?id=57343 is the bug, I suppose. [05:31:56] (03PS1) 10Chad: Remove $wgTitles from all over the place [extensions/MassEditRegex] - 10https://gerrit.wikimedia.org/r/114126 [05:32:03] ori: The Wikimedia Shop is down. [05:32:13] oh? [05:32:33] https://shop.wikimedia.org [05:32:34] This store is powered by Shopify Ecommerce Solutions [05:32:43] https://bugzilla.wikimedia.org/show_bug.cgi?id=61527 [05:33:07] <^d> #noswag4u [05:33:20] that was an interesting reaction on their part [05:34:03] Given that it was suddenly broken JavaScript + ecommerce, taking the store down temporarily seems sensible to me. [05:34:39] I'm pretty sure it was divine retribution for trying to close https://bugzilla.wikimedia.org/show_bug.cgi?id=37797 today. [05:35:15] l10n is hard yo [05:35:38] t-shirts have a US bias [05:36:01] * bd808 heads to bed [05:36:06] > [05:36:06] translation [05:36:07] I apologize for writing in English, but fuck you. [05:36:07] > [05:36:33] I'm my own biggest fan. [05:36:39] bd808: good night! [05:36:45] <^d> Gloria: I'm your biggest fan. [05:36:51] <3 [05:36:59] I wrote a haiku today at work. [05:37:13] Or at least it had seventeen syllables. [05:38:12] But who's counting. [05:38:31] That's delegation. [05:38:36] Or reappropriation? [05:38:40] Not abdication! [05:40:24] There's been an increase in Wikimedia-related spam lately. [05:41:20] Only mind is real -- [05:41:20] truth, a play of shadows. [05:41:20] Cookie diets work. [05:42:39] Some cousin of that. [05:45:05] (03CR) 10Mattflaschen: "Phuedx, in the future, can you also update MW.org (https://www.mediawiki.org/wiki/Manual:Hooks/TitleMoveComplete) after such hook changes " [core] - 10https://gerrit.wikimedia.org/r/113789 (owner: 10Phuedx) [05:49:07] (03CR) 10Bene: "But where should I put the tests because I don't see any existing ones?" [core] - 10https://gerrit.wikimedia.org/r/111159 (owner: 10Bene) [05:54:37] (03PS3) 10Physikerwelt: WIP: Generate SVG from LaTeXML output [extensions/Math] (dev) - 10https://gerrit.wikimedia.org/r/113762 [05:54:49] (03CR) 10jenkins-bot: [V: 04-1] WIP: Generate SVG from LaTeXML output [extensions/Math] (dev) - 10https://gerrit.wikimedia.org/r/113762 (owner: 10Physikerwelt) [05:56:44] ori: Let me know when you are free, sorry that I am pushing this! [06:16:19] prtksxna: have you tested it? [06:16:28] ori: yup :) [06:19:36] (03CR) 10Ori.livneh: [C: 04-1] "small typo, looks good otherwise" (031 comment) [extensions/Popups] - 10https://gerrit.wikimedia.org/r/112661 (owner: 10Prtksxna) [06:20:02] prtksxna: fix it & i'll merge [06:21:39] ori: /o\ stupid typo [06:21:47] (03PS3) 10Prtksxna: Add Triangle/Pokey to the NavigationPopups [extensions/Popups] - 10https://gerrit.wikimedia.org/r/113951 [06:21:49] (03PS16) 10Prtksxna: Add EventLogging [extensions/Popups] - 10https://gerrit.wikimedia.org/r/112661 [06:21:53] ori: ^ [06:22:34] (03CR) 10Prtksxna: Add EventLogging (031 comment) [extensions/Popups] - 10https://gerrit.wikimedia.org/r/112661 (owner: 10Prtksxna) [06:22:40] (03PS4) 10Physikerwelt: WIP: Generate SVG from LaTeXML output [extensions/Math] (dev) - 10https://gerrit.wikimedia.org/r/113762 [06:22:48] (03CR) 10jenkins-bot: [V: 04-1] WIP: Generate SVG from LaTeXML output [extensions/Math] (dev) - 10https://gerrit.wikimedia.org/r/113762 (owner: 10Physikerwelt) [06:22:54] (03CR) 10Ori.livneh: [C: 032] Add EventLogging [extensions/Popups] - 10https://gerrit.wikimedia.org/r/112661 (owner: 10Prtksxna) [06:25:21] oh, jenkins isn't voting on that yet [06:25:29] ori: Also, does it make sense to add the middle/command click stuff along with https://bugzilla.wikimedia.org/show_bug.cgi?id=52287 [06:25:37] ori: Yeah, no jenkins on that yet :\ [06:26:26] (03CR) 10Ori.livneh: [V: 032] Add EventLogging [extensions/Popups] - 10https://gerrit.wikimedia.org/r/112661 (owner: 10Prtksxna) [06:27:20] prtksxna: what do you mean? add it to the bug? [06:27:26] if so: yes, I think it's useful [06:27:48] ori: To the solution, I was thinking of submitting a path (if you don't mind, you have already taken up the bug) [06:27:55] s/path/patch [06:28:30] anything that cancels the native event is inelegant, IMO [06:28:36] it may be the best thing available [06:28:49] (03PS5) 10Physikerwelt: WIP: Generate SVG from LaTeXML output [extensions/Math] (dev) - 10https://gerrit.wikimedia.org/r/113762 [06:29:12] but i'd be a bit reluctant to add that approach to EL, to be honest. but I'm not firm in opposing it either. [06:29:24] ori: I saw another solution that you had suggested about adding something to the URL [06:29:47] ori: But that might make the URL un sharable and cause random events to get fired… [06:30:07] ori: Here -> https://trello.com/c/CsCMKJ0Q/81-personal-bar-clickthrough [06:30:58] prtksxna: the URLs that juliusz asked me about were POSTs that are handled with a 302 redirect to a different URL anyhow [06:31:04] so the params would not be user-visible [06:31:19] ori: Ah! Ok, I wonder why Dario pointed me to it then… [06:31:53] another approach is to use localstorage. it is a synchronous API. in other words, you can manipulate the contents of localstorage in an onbeforeunload handler without having to cancel navigation [06:32:32] you'd have code on the target page that checks if there is a queued event and submits it then [06:32:34] ori: But then when should we finally send it off? [06:32:44] the landing page [06:33:09] ori: Oh so clear up the queue on every page load [06:33:20] ori: And add to the queue when a link is clicked? [06:33:33] you could, yeah [06:33:34] yes [06:33:37] ori: That makes sense too [06:33:39] the reason *that* approach is problematic is -- well, localStorage is near-ubiquitous, but not completely [06:34:05] ori: I was just on v [06:34:10] and it also breaks the timing model of EventLogging, which is currently very simple: events are always dispatched instantly, and are received when they are logged (minus transit times) [06:34:11] oopsm http://caniuse.com/#search=localStorage [06:34:41] ori: Oh! The timestamp *could* be a part of the event that is being logged [06:34:54] yes, but we timestamp server-side [06:35:01] That way we can queue up events and send them later, as you had suggested for Popups [06:35:04] because the accuracy is known and the order definite [06:35:15] ori: Like timezone and stuff… [06:35:19] trusting local system time, yeah [06:35:52] ori: localStorage seems to have pretty good support [06:36:05] ori: But there is the problem of timestamps as you say [06:36:13] ori: So delaying a link is our only hope? [06:36:45] At bottom, I suppose that there is something about logging clicks that rubs me the wrong way. Users don't tend to appreciate it, and it's not possible to do without committing some act of violence against the browser. I think sometimes it's the only way to understand how a feature is being used and it is thus occasionally warranted, [06:36:59] but I'm reluctant to make it part of the architecture. [06:37:42] ori: Hmm, but what choice do we have, everyone is going to implement the hijack anyway… [06:38:43] Maybe that's just the right sort of barrier to prevent people from being too casual with it. [06:39:21] I try not to be too bossy with EventLogging because it doesn't belong to me in any real way, and I don't claim to have some special insight into the ethics of data collection and analysis, so I try not to opine too loudly [06:39:40] You shouldn't let my reservations discourage you if you think it's the right thing to do [06:40:15] ori: That makes a lot of sense too, but someone might implement the hijack in an incorrect manner (like I did without the timeout) and that is pretty bad too [06:40:21] ori: I am not sure what is worse [06:40:38] yeah, valid point [06:40:59] certainly having a more-or-less canonical implementation + explanation on mediawiki.org would be valuable and unobjectionable [06:41:50] ori: I just wanted to help, if submitting the patch is going to bring in a lot of pointless discussion about whats right and wrong (who knows anyway) then I am not sure what I should do [06:42:51] I'm not, either :) [06:43:00] :) [06:43:02] I think I [06:43:30] I think I'll work on some stuff and share it with you, once the code is fine, I'll put it on wikitech-l and leave the country :P [06:43:58] * prtksxna is sorry about the half message, he is using a new keyboard [06:44:01] that'd be awesome. and i'd really appreciate it! [06:44:22] \o/ [06:44:39] * ori goes to eat a late dinner. [06:52:11] ori: see you [06:53:10] (03CR) 10Mattflaschen: [C: 04-1] "This isn't deployed anywhere in core. If we merge this, we need to be careful just to ride the train (rather than deploying GettingStarte" (032 comments) [extensions/WikimediaEvents] - 10https://gerrit.wikimedia.org/r/113261 (owner: 10Phuedx) [07:02:56] hi yurik [07:41:09] (03PS1) 10Purodha: Better message wording. See also https://translatewiki.net/wiki/Thread:Support/About_MediaWiki:Prefs-help-watchlist-token2/en [core] - 10https://gerrit.wikimedia.org/r/114130 [07:49:52] So I'm trying to figure out how things like https://commons.wikimedia.org/wiki/File:Planet-4D_2D_representation_of_the_neighbors_of_note_0_%28do%29.jpg could happen (db inconsistency in page_latest field). So far the only way I can think of this happening is if $dbw->rollback() didn't actually rollback the commit (Although quite likely I'm missing something). Are there situations where... [07:49:54] ...$dbw->rollback() would be ineffectual? [08:09:50] (03CR) 10Nikerabbit: Removed STRAIGHT_JOIN; the is slower when a namespace has a few pages (031 comment) [core] - 10https://gerrit.wikimedia.org/r/114070 (owner: 10Aaron Schulz) [08:59:47] (03PS4) 10Bartosz Dziewoński: Preload mediawiki.notification when we know we're going to need it soon [core] - 10https://gerrit.wikimedia.org/r/113540 [08:59:52] (03CR) 10Ori.livneh: [C: 032] Preload mediawiki.notification when we know we're going to need it soon [core] - 10https://gerrit.wikimedia.org/r/113540 (owner: 10Bartosz Dziewoński) [09:01:10] * YuviPanda trebuchets that bug about 'relative time' on ori again [09:01:28] oh, shit, right. [09:01:30] * ori looks. [09:01:34] sorry 'bout that. [09:01:40] (https://bugzilla.wikimedia.org/show_bug.cgi?id=30857) [09:02:55] ori: if we do the JS bit, it'll also load momentjs on all pageviews. If you think the perf cost is too much, I'm happy to let it die for now. [09:03:12] first things first: [09:03:40] the screenshot shows sue's bookmark toolbar circa 2011 [09:03:47] on which we find: http://www.huxtablehotness.com/ [09:03:51] hahahaa [09:03:52] "In which I review the sartorial choices of the characters on The Cosby Show one episode at a time." [09:04:01] that is awesome [09:04:08] (03Merged) 10jenkins-bot: Preload mediawiki.notification when we know we're going to need it soon [core] - 10https://gerrit.wikimedia.org/r/113540 (owner: 10Bartosz Dziewoński) [09:04:18] I think I just snorted lemon juice out of my nose [09:04:20] hi ori [09:04:27] it's still going! [09:04:35] hey niklas [09:07:56] (03CR) 10Yurik: "Makes calling code cleaner. Fixed requested cleanups." (033 comments) [core] - 10https://gerrit.wikimedia.org/r/102845 (owner: 10Yurik) [09:08:11] (03PS2) 10Yurik: Added ApiResult::NO_SIZE_CHECK flag for addValue() [core] - 10https://gerrit.wikimedia.org/r/102845 [09:08:21] (03PS3) 10Yurik: Added ApiResult::NO_SIZE_CHECK flag for addValue() [core] - 10https://gerrit.wikimedia.org/r/102845 [09:08:27] lol [09:10:24] People should really be more careful about their screenshots :) [09:10:35] YuviPanda: do you have a patch? [09:11:18] ori: not yet, but if you think the approach is workable I'll get a patch done. [09:11:26] I think you're right to be concerned about adding top-loading JavaScript code, but at the same time it sounds like a good feature that could be made to perform well and that would be worth the investment of time [09:11:57] but I can't bless it as performing well enough or too poorly by just working it out in my head [09:12:16] ori: right, I understand that. Just wanted to make sure I wasn't missing any fundamental 'nope. WONTFIX' reasons. [09:12:25] ori: I'll poke again when I have a patch. shouldn't be too hard to start with. [09:13:09] yeah, I think the initial patch could be quite naive and straightforward, no need to to pull all the stops yet [09:14:06] ori: sweet. There's another bug I thought you should see. moment [09:14:17] ori: https://bugzilla.wikimedia.org/show_bug.cgi?id=57891 [09:14:31] ori: the extension itself is fairly small and trivial, but I guess it'll have performance implications. [09:16:54] nemo has an awesome ninja trick that i would love to learn some day [09:17:29] ori: comment 24? [09:17:33] it's the atomic jab-and-move-forward [09:18:05] heh [09:18:37] he says his piece but closes the quibbling phase of the discussion in a single motion [09:18:59] :D [09:19:26] * YuviPanda quibbles [09:19:52] Nemo_bis: are you taking apprentices? [09:20:23] YuviPanda: o/ [09:22:04] ori: I'm afraid it takes many years of painful training [09:23:02] Nemo_bis: :P [09:23:20] Anyways, I hope you took my comment in the right spirit, more a compliment than a tease [09:24:10] hi prtksxna [09:25:24] (03PS2) 10BryanDavis: Add sphinx configuration [tools/scap] - 10https://gerrit.wikimedia.org/r/114060 [09:25:38] (03CR) 10Ori.livneh: [C: 032] Add sphinx configuration [tools/scap] - 10https://gerrit.wikimedia.org/r/114060 (owner: 10BryanDavis) [09:25:39] (03Merged) 10jenkins-bot: Add sphinx configuration [tools/scap] - 10https://gerrit.wikimedia.org/r/114060 (owner: 10BryanDavis) [09:25:50] ori: it definitely sounded like a compliment, though I'm not sure exactly what parts of my "technique" you have in mind :) [09:26:56] Yuvi and I were just admiring https://bugzilla.wikimedia.org/show_bug.cgi?id=57891#c24 [09:27:52] Ah. :) [09:27:59] It was an experiment. [09:28:11] I think the technical term would be captatio benevolentiae though [09:29:07] (03CR) 10Hashar: "The Jenkins job uses git build package, so if the job manage to build a debian package the configuration must be right :-D" [services/mathoid] - 10https://gerrit.wikimedia.org/r/113349 (owner: 10Hashar) [09:29:49] YuviPanda: Wrote the bash script :) [09:30:08] prtksxna: :D [09:30:14] YuviPanda: Learnt all about Deferreds :) [09:30:31] YuviPanda: ori merged the EL code :) [09:30:31] prtksxna: eating will check in a bit? [09:30:43] YuviPanda: k o/ [09:30:47] prtksxna: great day so far? ;) [09:30:54] ori: So what above on painful training is correct, that partly comes from 4 years of experience in internal dynamics of a collegial body during discussions [09:31:03] YuviPanda: Now. The refactor! :P [09:32:09] oooof, this is thorny [09:34:56] YuviPanda: overheard on #mediawiki: I would like to contribute for this GSOC for Wikimedia mobile team by developing mobile applications. I have experience in developing apps in Andriod, BB10, Firefox OS. I would like to learn about Ubuntu touch also. How can i contribute [09:47:29] (03CR) 10Hashar: "Gabriel wrote:" [services/mathoid] - 10https://gerrit.wikimedia.org/r/113349 (owner: 10Hashar) [09:47:57] (03CR) 10TTO: "Jon, could you please answer Siebrand's concerns? Specifically, I am interested to know what exactly you "heavily protested against" "a fe" [core] - 10https://gerrit.wikimedia.org/r/111390 (owner: 10TTO) [09:49:21] (03CR) 10TTO: "Test now added." [core] - 10https://gerrit.wikimedia.org/r/113329 (owner: 10TTO) [09:51:13] (03CR) 10Hashar: [C: 031] "Loving parser tests :-D" [extensions/ParserFunctions] - 10https://gerrit.wikimedia.org/r/113518 (owner: 10Brian Wolff) [09:52:25] ori: oh, saw that. let me poke back in a bit (still eating) [09:53:14] (03CR) 10SPQRobin: [C: 04-1] "Well, as I said, this patch doesn't seem to change anything in practice. When you're viewing a certain page, that title is automatically c" [extensions/WikimediaIncubator] - 10https://gerrit.wikimedia.org/r/113650 (owner: 10Ebe123) [10:03:20] (03CR) 10SPQRobin: [C: 04-1] "The "pretty useless actually" comment refers to it being a configuration variable. But that doesn't mean it's completely useless; it serve" [extensions/WikimediaIncubator] - 10https://gerrit.wikimedia.org/r/113880 (owner: 10Ebe123) [10:42:33] (03PS1) 10UltrasonicNXT: Stop smileys removing adjacent spaces [extensions/MediaWikiChat] - 10https://gerrit.wikimedia.org/r/114140 [10:43:33] (03CR) 10Physikerwelt: [C: 032] "It's an official patch for MathJax from the lead developer of MathJax... so it should definitely go to master" [extensions/Math] - 10https://gerrit.wikimedia.org/r/113764 (owner: 10Physikerwelt) [10:43:42] (03CR) 10UltrasonicNXT: [C: 032 V: 032] Stop smileys removing adjacent spaces [extensions/MediaWikiChat] - 10https://gerrit.wikimedia.org/r/114140 (owner: 10UltrasonicNXT) [11:02:25] (03CR) 10UltrasonicNXT: "Can I just ask, what's the point of this if only you can see it?" [extensions/MediaWikiChat] - 10https://gerrit.wikimedia.org/r/113998 (owner: 10Gerrit Patch Uploader) [11:09:06] (03CR) 10Krusher: "I don't understand, /me express actions wich can be seen by everyone, much like in the IRC." [extensions/MediaWikiChat] - 10https://gerrit.wikimedia.org/r/113998 (owner: 10Gerrit Patch Uploader) [11:09:58] (03CR) 10UltrasonicNXT: "Sorry, yeah, just nocied that myself. Ignore me, I'm being stupid ;)" [extensions/MediaWikiChat] - 10https://gerrit.wikimedia.org/r/113998 (owner: 10Gerrit Patch Uploader) [11:10:40] (03CR) 10UltrasonicNXT: "Are you keen on having the *asterisk there? I would prefer to remove it." [extensions/MediaWikiChat] - 10https://gerrit.wikimedia.org/r/113998 (owner: 10Gerrit Patch Uploader) [11:24:25] (03PS6) 10Physikerwelt: Mathoid 0.2.1 [services/mathoid] - 10https://gerrit.wikimedia.org/r/113025 [11:25:42] (03PS2) 10UltrasonicNXT: Support for /me command [extensions/MediaWikiChat] - 10https://gerrit.wikimedia.org/r/113998 (owner: 10Gerrit Patch Uploader) [11:30:17] (03CR) 10Physikerwelt: "git buildpackage works now." [services/mathoid] - 10https://gerrit.wikimedia.org/r/113025 (owner: 10Physikerwelt) [12:15:36] (03PS1) 10Brian Wolff: Unbreak this extension by killing $wgCategoryTreeDynamicTag [extensions/CategoryTree] - 10https://gerrit.wikimedia.org/r/114142 [12:16:09] Nemo_bis: ---^ [12:16:41] * bawolff finally found the bug report after I had figured out everything by myself [12:17:18] haha [12:17:46] Ah right, the mysterious bug which brought the cluster down for whatever reason [12:20:41] (03PS2) 10Phuedx: Convert CSS to LESS [extensions/GuidedTour] - 10https://gerrit.wikimedia.org/r/113875 [12:21:17] (03PS2) 10Nemo bis: Unbreak this extension by killing $wgCategoryTreeDynamicTag [extensions/CategoryTree] - 10https://gerrit.wikimedia.org/r/114142 (owner: 10Brian Wolff) [12:22:17] Nemo_bis: I think the exact same thing (caching issues with that extension causing performance problems) even happened before like a year ago [12:23:28] Morale of this story though is that when someone reafactors something, they should grep to make sure they change all calling functions... [12:23:43] and that the extension actually works the way WMF has it configured [12:25:11] (03CR) 10Phuedx: "Done. Thanks for the pointers Mattflaschen. PS2 also addresses style guide violations in the LESS files." [extensions/GuidedTour] - 10https://gerrit.wikimedia.org/r/113875 (owner: 10Phuedx) [12:26:01] Ah, if we had release notes that people can rely upon when upgrading code! [12:38:14] can anyone give more info on bug https://bugzilla.wikimedia.org/show_bug.cgi?id=30959 [12:40:05] Lekshmi: Did my last comment on the bug help? [12:41:20] yeah [12:49:05] (03Abandoned) 10Ebe123: Make MediaWiki:wminc-error-unprefixed-suggest show correctly capitalised title [extensions/WikimediaIncubator] - 10https://gerrit.wikimedia.org/r/113650 (owner: 10Ebe123) [12:49:43] (03Abandoned) 10Ebe123: Remove global $wmincLangCodeLength [extensions/WikimediaIncubator] - 10https://gerrit.wikimedia.org/r/113880 (owner: 10Ebe123) [13:02:23] (03PS7) 10Hashar: git-buildpckage configuration [services/mathoid] - 10https://gerrit.wikimedia.org/r/113349 [13:03:48] (03CR) 10Hashar: [C: 04-1] "> I think that jenkins can not build without the debian branches" [services/mathoid] - 10https://gerrit.wikimedia.org/r/113025 (owner: 10Physikerwelt) [13:04:11] (03Abandoned) 10Hashar: git-buildpckage configuration [services/mathoid] - 10https://gerrit.wikimedia.org/r/113349 (owner: 10Hashar) [13:05:02] Shall I add a div tag in $wgOut->addWikiTextTitleTidy() (line 2117) of https://doc.wikimedia.org/mediawiki-core/master/php/html/EditPage_8php_source.html [13:12:43] yeah. You may want to use Html::rawElement( 'div', array( 'class' => 'mw-editintro' ), ); instead of writing the div out by hand [13:27:44] (03PS1) 10Aklapper: Replace custom template file by using existing Bugzilla hook [wikimedia/bugzilla/modifications] - 10https://gerrit.wikimedia.org/r/114145 [13:28:37] (03CR) 10Aklapper: [C: 031] "Tested on Labs instance and works as expected. Can go onto production." [wikimedia/bugzilla/modifications] - 10https://gerrit.wikimedia.org/r/114145 (owner: 10Aklapper) [13:40:40] will this serve the purpose http://pastebin.com/U9wdZzFH for (line 2117) of https://doc.wikimedia.org/mediawiki-core/master/php/html for https://bugzilla.wikimedia.org/show_bug.cgi?id=30959 [13:52:10] (03PS3) 10UltrasonicNXT: Support for /me command [extensions/MediaWikiChat] - 10https://gerrit.wikimedia.org/r/113998 (owner: 10Gerrit Patch Uploader) [14:11:46] (03CR) 10Aklapper: "Seeing http://bzr.mozilla.org/bugzilla/4.4/view/head:/template/en/default/global/user-error.html.tmpl#L21 I wonder if we could use Bugzill" [wikimedia/bugzilla/modifications] - 10https://gerrit.wikimedia.org/r/106883 (owner: 10Tinaj1234) [14:14:50] Hie, is there any way i can look for the email id of a wikimedia developer, if its not mentioned on his user page...? [14:19:14] zeek: on gerrit, their email addresses are shown on each commmit and comment. [14:19:32] https://gerrit.wikimedia.org/r/#/q/status:open,n,z [14:20:04] hexmode: Hie mark, I was going through the mentorship program and I think I can work on the project of "catalogue of mediawiki extension".. can you please guide me on how can i do some initial work... [14:20:10] whym: thankx :) [14:32:20] (03PS6) 10Physikerwelt: Generate SVG from LaTeXML output [extensions/Math] (dev) - 10https://gerrit.wikimedia.org/r/113762 [14:33:14] (03CR) 10Physikerwelt: [C: 032] Generate SVG from LaTeXML output [extensions/Math] (dev) - 10https://gerrit.wikimedia.org/r/113762 (owner: 10Physikerwelt) [14:38:43] (03PS4) 10UltrasonicNXT: Support for /me command [extensions/MediaWikiChat] - 10https://gerrit.wikimedia.org/r/113998 (owner: 10Gerrit Patch Uploader) [14:39:07] (03CR) 10UltrasonicNXT: [C: 032 V: 032] Support for /me command [extensions/MediaWikiChat] - 10https://gerrit.wikimedia.org/r/113998 (owner: 10Gerrit Patch Uploader) [14:50:33] (03PS4) 10Zfilipin: Moved tests from browsertests repository [extensions/WikiLove] - 10https://gerrit.wikimedia.org/r/113104 [14:56:58] (03CR) 1001tonythomas: "Should I rebase and upload a new PS ?" [core] - 10https://gerrit.wikimedia.org/r/99422 (owner: 1001tonythomas) [15:01:59] hey ! Should we have a can merge Yes/No indicator in the gerrit outgoing reviews page ? So that the user can understand which all needs a rebase, since some patch take a long time to review ? [15:02:45] I personally always found it difficult to go through every patch and checkind whether it is fit for merge. [15:03:28] (03PS5) 10Zfilipin: Moved tests from browsertests repository [extensions/WikiLove] - 10https://gerrit.wikimedia.org/r/113104 [15:04:50] bd808: Hie Bryan... How are you doing? I was going through the project "New media types supported in Commons" and wanted to learn more about what parametres are improtant regarding file types and how can I go through them.. [15:07:32] zeek: Good questions. I inherited that area for mentoring. I'm ready to help someone work out the technical bits but I don't have great input about what makes a good additional type. [15:07:57] You night look through the bugs listed at https://commons.wikimedia.org/wiki/Commons:File_types#Unsupported_file_types [15:08:07] *You might [15:08:51] One big part of a successful project in this area would be showing that there is strong community support for the new type [15:09:04] yes I went through this. I was searching for things like... "security risk involved with x3d format.." but couldn't find anything much... [15:09:10] (03CR) 10Zfilipin: "The tests are already running (and passing):" [extensions/WikiLove] - 10https://gerrit.wikimedia.org/r/113104 (owner: 10Zfilipin) [15:09:32] And how can we achieve that ? [15:10:01] the objective to show there is good support in comunity for it [15:11:42] bd808: ^ [15:12:23] zeek: one potential security risk in x3d is that it uses xml with namespaces. This has an inherent potential for malicious code injection and denial of service attacks. A successful integration would need to maintain a whitelist of allowed namespaces and filter out all others. [15:15:03] Community support would come from drafting a proposal and circulating it via mailing lists and on wiki discussion. [15:15:39] bd808: ok... I am not much able to understand the scale of the project as of now.. but I would like to work on it if you feel I can do so.... [15:16:10] zeek: Someone like bawolff or Gloria could give much better guidance on getting community support [15:17:52] zeek: It all starts with a project proposal. I'm not going to have the time to write something like that for you. So you need to be passionate enough about some project to research it and describe what should be done at a high level and who it will benefit. [15:18:47] bd808: Definitely I'll do the work.. Just need your guidance... :) [15:19:36] Asking for help with specific parts of a rough proposal on wikitech-l may find you some collaborators on drafting a good proposal. [15:26:17] bd808: All right, but just tell me something on how to begin. Like, how to proceed, the initial step... in the development phase wise... I will ask about the community support by talking to bawolff. [15:28:53] zeek: Pick a media type, learn about it, describe why it should be supported and what support will look like and then find out if anyone wants that to happen. Or talk to Quim (qgil here on irc) and see if he has better ideas about how a GSoC project gets kicked off. [15:29:48] Ok thanks. This is helpful. :) [15:30:05] \o/ [15:34:22] (03CR) 1001tonythomas: "Should I rebase and send in a new PS ?" [core] - 10https://gerrit.wikimedia.org/r/94614 (owner: 1001tonythomas) [15:34:28] (03PS1) 10Hashar: Compile texvc in testsuite [extensions/Math] - 10https://gerrit.wikimedia.org/r/114154 [15:34:50] (03CR) 10jenkins-bot: [V: 04-1] Compile texvc in testsuite [extensions/Math] - 10https://gerrit.wikimedia.org/r/114154 (owner: 10Hashar) [15:37:46] (03CR) 10Hashar: "texvc managed to compile but for some reason the sha1 of images are different. The test works on my computer though :-(" [extensions/Math] - 10https://gerrit.wikimedia.org/r/114154 (owner: 10Hashar) [15:41:35] (03PS4) 10Welterkj: use imagemap class for HTML rendering [extensions/GraphViz] - 10https://gerrit.wikimedia.org/r/111475 [15:47:22] (03CR) 10Welterkj: "Patch set 4 is to apply dos2unix to the remaining files (i18n already done at Siebrand's request) and to add a missing $wgAutoloadClasses " [extensions/GraphViz] - 10https://gerrit.wikimedia.org/r/111475 (owner: 10Welterkj) [15:48:55] (03CR) 10Ragesoss: "Nice job, JJ! It is working as expected; I tried my best to break it, but couldn't do it. :)" [extensions/EducationProgram] - 10https://gerrit.wikimedia.org/r/113145 (owner: 10J-squared) [15:53:54] (03CR) 10Anomie: [C: 04-1] "Fail:" (032 comments) [extensions/ParserFunctions] - 10https://gerrit.wikimedia.org/r/113518 (owner: 10Brian Wolff) [16:08:48] Krinkle: I am not sure there is a need to edit two years old bugs https://bugzilla.wikimedia.org/show_bug.cgi?id=37593 :D [16:08:53] (03CR) 10Yuvipanda: [C: 032] "*very* slightly better :)" [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/113975 (owner: 10Chad) [16:09:04] (03Merged) 10jenkins-bot: RequestContext is better than $wgLang. Slightly [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/113975 (owner: 10Chad) [16:09:16] hashar: It was to disambiguate from a recent bug since it looked like a duplicate [16:09:25] :-] [16:09:31] adding 'labs' and 'nova' to the title [16:09:45] make it easy to ignore > maxage closed bugs and I won't have to [16:09:46] Krinkle: yeah I am sure you did it on purpose, it confused me when I received the mail notif [16:11:32] (03CR) 10Anomie: "Code seems ok, haven't tested. But I still don't really buy the "Makes calling code cleaner" argument when there's likely no other code th" [core] - 10https://gerrit.wikimedia.org/r/102845 (owner: 10Yurik) [16:11:35] we had rabbitmq?! [16:13:38] (03CR) 10Bartosz Dziewoński: [C: 032] Better message wording. See also https://translatewiki.net/wiki/Thread:Support/About_MediaWiki:Prefs-help-watchlist-token2/en [core] - 10https://gerrit.wikimedia.org/r/114130 (owner: 10Purodha) [16:15:46] (03CR) 10Legoktm: [C: 04-1] Add flag to enable/disable site-wide global CSS/JS (031 comment) [extensions/GlobalCssJs] - 10https://gerrit.wikimedia.org/r/114079 (owner: 10Yuvipanda) [16:17:29] (03Merged) 10jenkins-bot: Better message wording. See also https://translatewiki.net/wiki/Thread:Support/About_MediaWiki:Prefs-help-watchlist-token2/en [core] - 10https://gerrit.wikimedia.org/r/114130 (owner: 10Purodha) [16:19:43] <^d> Nemo_bis: I'm going to give Wikiversities Cirrus this morning. [16:19:49] <^d> Well, start the process and build them out. [16:19:51] <^d> :) [16:24:13] (03PS1) 10Chad: Update CirrusSearch and Elastica to master [core] (wmf/1.23wmf13) - 10https://gerrit.wikimedia.org/r/114157 [16:24:56] (03PS1) 10Chad: Update CirrusSearch and Elastica to master [core] (wmf/1.23wmf14) - 10https://gerrit.wikimedia.org/r/114159 [16:30:14] (03CR) 10Anomie: [C: 04-1] "One minor issue (line 167). Other than that, looks good to me. The TODOs don't seem to be regressing anything, so I don't object to leavin" (034 comments) [extensions/ContactPage] - 10https://gerrit.wikimedia.org/r/113879 (owner: 10Reedy) [16:32:07] ^d: nice :) then we'll only lack Wikiquote for a full sisterprojects search on it.wiki :) [16:32:49] <^d> Hmm, let's sneak itwikiquote in there too. [16:32:58] <^d> It's easy enough and you guys are awesome beta testers :) [16:34:05] <^d> Then we'll have all Italian projects for when we turn on IW searches for beta testing :) [16:38:09] (03CR) 10Anomie: WIP: Allow inclusion of additional fields (031 comment) [extensions/ContactPage] - 10https://gerrit.wikimedia.org/r/113883 (owner: 10Reedy) [16:38:57] (03CR) 10Chad: "New week, pinggggggg :D" [core] - 10https://gerrit.wikimedia.org/r/112913 (owner: 10Chad) [16:40:22] (03CR) 10Chad: "Hmm, now that I think about it I wonder if we should just make it it's own module rather than tacking it on here." [core] - 10https://gerrit.wikimedia.org/r/112913 (owner: 10Chad) [16:41:12] hashar: Any idea what is/was up with the certificates for npm? [16:44:58] Krinkle: no clue [16:45:03] (03CR) 10Bartosz Dziewoński: "Probably only release notes need rebasing, let me just do this and merge." [core] - 10https://gerrit.wikimedia.org/r/99422 (owner: 1001tonythomas) [16:45:05] Krinkle: did you get it fixed by upgrading node / npm ? [16:45:17] Krinkle: node 0.10 reached the slave01 when node got updated in apt.wm.org [16:45:26] Krinkle: but it node is back to 0.8 [16:45:27] hashar: See bug, yeah I manually upgraded npm, not node [16:45:31] though node should be upgraded too [16:45:36] so if the self cert is provided by node that explain the issue [16:45:38] for more subtle regressions I didn't see [16:45:54] so node.js is more or less planned to be updated in apt.wm.o [16:45:57] pending parsoid team [16:46:13] npm , I have no clue. We can probably backport the package from Ubuntu recent versions [16:46:20] grunt-cli, we will need a package for it [16:46:53] hashar: No, it is npm, that is the package manager for it [16:46:56] we just need to install it [16:47:06] this is exactly why we have those slaves in labs [16:47:22] we install over 100+ other npm packages during random jenkins jobs that use npm [16:47:25] (locally though) [16:47:28] (and wiped0 [16:47:31] hashar, we are waiting for ops to upgrade.. [16:47:39] \O/ [16:47:45] Krinkle: but that should not be done manually :-] [16:48:31] and puppet apparently doesn't support npm as a package provider :/ [16:48:47] hashar: I'm sure puppet has a way to do an exec only once per newly provisioned host. Or even if it is executed each time, that's fine and harmless. npm doesn't do anything if the package is installed already. [16:49:08] just like directories and users, we don't create packages for that. [16:49:14] They're just manifest statements. [16:49:48] Anyway, I don't know, and when stuff is broken I don't want to know :) I'm open to any solution. [16:50:02] (03CR) 10Chad: [C: 032 V: 032] Remove final usage of $wgArticle anywhere in git [extensions/BlueSpiceFoundation] - 10https://gerrit.wikimedia.org/r/114125 (owner: 10Chad) [16:50:06] I would get nodejs package upgraded (already on track) [16:50:14] and npm backported from ubuntu [16:50:20] grunt-cli, ideally should be packaged as well [16:50:30] at worth we can use what you proposed: Exec[] in puppet :] [16:51:18] http://forge.puppetlabs.com/puppetlabs/nodejs [16:51:19] haha evil [16:51:35] packaging grunt-cli doesn't make sense, period (unless the package is a bash script that runs `npm install`) [16:51:57] I am not going to enter that debate [16:52:15] If we'd use grunt in production for something, then it would make sense. [16:52:22] But we're using it within jenkins jobs that all use different versions and local paths. [16:52:58] (03CR) 10Anomie: "Interwiki search? Could be, I suppose. Especially if you think people might want to iw-search without searching the local wiki." [core] - 10https://gerrit.wikimedia.org/r/112913 (owner: 10Chad) [16:53:59] (03PS6) 10Bartosz Dziewoński: Removed 'Enable simplified search bar (Vector skin only)' from MW user Preference [core] - 10https://gerrit.wikimedia.org/r/99422 (owner: 1001tonythomas) [16:55:08] (03Abandoned) 10Anomie: Fix TestFileIterator to never return 0 tests [core] - 10https://gerrit.wikimedia.org/r/112033 (owner: 10Anomie) [16:55:16] Krinkle: yeah so we can just Exec[] in puppet or amend the npm jobs to install grunt-cli [16:55:28] Krinkle: as long as we have nothing to handle manually :-] [16:55:47] (03CR) 10Bartosz Dziewoński: [C: 032] Removed 'Enable simplified search bar (Vector skin only)' from MW user Preference [core] - 10https://gerrit.wikimedia.org/r/99422 (owner: 1001tonythomas) [16:58:55] (03CR) 10Krinkle: [C: 031] "Looks good, maybe omit "-php" from the macro name though." [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/113958 (owner: 10Hashar) [16:59:16] (03Merged) 10jenkins-bot: Removed 'Enable simplified search bar (Vector skin only)' from MW user Preference [core] - 10https://gerrit.wikimedia.org/r/99422 (owner: 1001tonythomas) [16:59:38] (03CR) 10Chad: [C: 032] Update CirrusSearch and Elastica to master [core] (wmf/1.23wmf14) - 10https://gerrit.wikimedia.org/r/114159 (owner: 10Chad) [16:59:46] (03CR) 10Chad: [C: 032] Update CirrusSearch and Elastica to master [core] (wmf/1.23wmf13) - 10https://gerrit.wikimedia.org/r/114157 (owner: 10Chad) [17:00:56] (03PS2) 10Hashar: Add json-lint.php command to -jslint jobs [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/113958 [17:02:10] (03PS3) 10Hashar: Add json-lint.php command to -jslint jobs [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/113958 [17:04:55] (03CR) 10Krinkle: "fixme: Inconsistent coding style." (033 comments) [integration/jenkins] - 10https://gerrit.wikimedia.org/r/107163 (owner: 10Hashar) [17:05:02] (03Merged) 10jenkins-bot: Update CirrusSearch and Elastica to master [core] (wmf/1.23wmf14) - 10https://gerrit.wikimedia.org/r/114159 (owner: 10Chad) [17:05:04] (03Merged) 10jenkins-bot: Update CirrusSearch and Elastica to master [core] (wmf/1.23wmf13) - 10https://gerrit.wikimedia.org/r/114157 (owner: 10Chad) [17:05:15] (03CR) 10Krinkle: "(phpcs maybe :-), if it can catch that )" [integration/jenkins] - 10https://gerrit.wikimedia.org/r/107163 (owner: 10Hashar) [17:05:26] Krinkle: bah write a patch dont you ? :] [17:05:37] It would, but it was already merged. [17:05:46] follow up ! :D [17:05:58] no worries though, but I'd rather move on in my review dashboard to non-nitpicks. [17:06:06] I have been writing a ton of python and the space convention is very different :-( [17:06:15] hehe [17:06:26] but within the same file, my eyes :P [17:08:07] (03PS1) 10Hashar: json-lint: fixing whitespaces [integration/jenkins] - 10https://gerrit.wikimedia.org/r/114161 [17:08:15] (03CR) 10Hashar: "Thanks, done with https://gerrit.wikimedia.org/r/114161" [integration/jenkins] - 10https://gerrit.wikimedia.org/r/107163 (owner: 10Hashar) [17:08:35] Krinkle: ^^^ [17:09:35] (03PS1) 10Bartosz Dziewoński: mediawiki.mixins.less: Add a link to source of the .background-image-svg technique [core] - 10https://gerrit.wikimedia.org/r/114162 [17:09:53] (03CR) 10Bartosz Dziewoński: [C: 032] "Trivial." [core] - 10https://gerrit.wikimedia.org/r/114162 (owner: 10Bartosz Dziewoński) [17:10:16] (03PS2) 10Krinkle: json-lint: fixing whitespaces [integration/jenkins] - 10https://gerrit.wikimedia.org/r/114161 (owner: 10Hashar) [17:10:25] (03CR) 10Krinkle: [C: 031] "2 more spaces." [integration/jenkins] - 10https://gerrit.wikimedia.org/r/114161 (owner: 10Hashar) [17:10:52] git-review is fast on small repos [17:11:01] I wouldn't have made a patch otherwise :) [17:11:20] * Krinkle goes to make a few other patches in other repos [17:14:09] (03Merged) 10jenkins-bot: mediawiki.mixins.less: Add a link to source of the .background-image-svg technique [core] - 10https://gerrit.wikimedia.org/r/114162 (owner: 10Bartosz Dziewoński) [17:17:12] (03CR) 1001tonythomas: "@Bartosz: Thanks :)" [core] - 10https://gerrit.wikimedia.org/r/99422 (owner: 1001tonythomas) [17:26:31] who would i poke about getting shell access to deployment-bastion in wmflabs? [17:27:53] hashar: ^ [17:28:22] hoo: what ? :-] [17:28:29] ah ebernhardson hello [17:28:31] ;) [17:28:34] hello :) [17:28:56] ebernhardson: you need to fill in form 3938x0 signed by your manager with a carbon copy of your NDA with wikimedia [17:28:59] btw i'm putting together a wikitech thread...but i have a feeling it needs more strong data about why before i jump into the lions den :P [17:29:09] ebernhardson: then fill a request in the internal tracker and wait 3 days for consensu. [17:29:18] * hashar is kidding obviously [17:29:22] :) [17:29:48] beta is basically a labs project, a bunch of ops / platform teams can had people to it [17:30:02] ebernhardson: what do you need ? Simple access I guess ? [17:30:15] hashar: yea i just need to poke at mwscript and the exceptions log to figure out a bug [17:30:22] \O/ [17:30:24] (03PS1) 10Cscott: Support >2 and JSON-formatted options in parser tests. [core] - 10https://gerrit.wikimedia.org/r/114163 [17:30:44] ebernhardson: added ya :-] [17:30:48] hashar: perfect, thanks [17:31:08] * ebernhardson is going to guess it needs a minute to sync  [17:31:09] ebernhardson: the main work machine is deployment-bastion.pmtpa.wmflabs the logs are in /data/project/logs (they come from udp2log ) [17:31:47] ebernhardson: https://wikitech.wikimedia.org/wiki/beta is the page you want bookmarked. It points to bunch of outdated (obviously) documentation [17:32:23] hashar: always outdated :) although looks like it might be more accurate than where i found deployment-bastion first: https://wikitech.wikimedia.org/wiki/Nova_Resource:Deployment-prep/Overview [17:32:26] ebernhardson: I highly recommend reading "How code is updated" . tl;dr mw/core and extensions are updated by Jenkins jobs running as the 'mwdeploy' user [17:32:57] ebernhardson: yeah gotta update that overview page. As usual be bold :-] [17:33:15] s/fenari/tin [17:33:17] step 1 :) [17:33:44] ebernhardson: in the Office I know S Page and some feature team are using the beta cluster constantly [17:34:08] ebernhardson: if you had a mwscript command in mind, can you try it ? [17:35:02] hashar: looks to work, thanks1 [17:35:02] ! [17:35:05] ebernhardson: granted you sudo :-] [17:35:18] I have an alias: alias mwdeploy='sudo su --login --shell /bin/bash mwdeploy' [17:35:24] since the code is deployed using mwdeploy [17:35:34] but anything file you touch there would be overwritten by Jenkins every six minutes [17:35:45] and found my problem, seems somehow the flow production parsoid config made it into beta [17:35:51] so best way to test is to get your code behind a feature switch ($wgFeature = false) [17:36:07] and enable it on beta using operations/mediawiki-config.git wmf-config/*-labs.php [17:36:16] ah yeah [17:36:18] ok [17:36:21] so beta use the same conf as production [17:36:29] aka the evil operations/mediawiki-config.git [17:36:33] which is a lot of fun sometime [17:36:35] :) [17:36:47] you can override the settings on beta using the *-labs.php README might have some explanations [17:37:03] else you can poke folks from my team (git log in operations/mediawiki-config.git would give you names :D ) [17:38:15] hashar: excellent, thanks for all the pointers [17:38:22] ebernhardson: and you can get beta cluster fatals on logstash https://logstash.wmflabs.org/#/dashboard/elasticsearch/fatalmonitor (set up by bd808) [17:38:46] if you feel like an encyclopedist, feel free to add a wiki page "beta for newcomers" or something :] [17:39:00] hashar: when i update mediawiki-config to fix this, will jenkins auto deploy that to beta too? [17:39:07] * ebernhardson is guessing yes [17:39:08] yes [17:39:11] awsome [17:39:15] a few seconds after it get merged [17:39:28] it even touch InitializeSettings.php for you [17:39:41] the jobs are at https://integration.wikimedia.org/dashboard/ [17:39:46] (sorry that is a lot of informations) [17:40:27] basically, push to gerrit, review, merge, deploy on tin [17:47:12] and I am off *wave* [17:47:13] :-) [17:49:33] (03PS1) 10Aklapper: Add hook in core for bmo's 'Needinfo' Bugzilla extension. [wikimedia/bugzilla/modifications] - 10https://gerrit.wikimedia.org/r/114168 [17:51:32] (03PS2) 10Cscott: Support >2 and JSON-formatted options in parser tests. [core] - 10https://gerrit.wikimedia.org/r/114163 [17:54:24] (03PS2) 10Physikerwelt: Compile texvccheck in testsuite [extensions/Math] - 10https://gerrit.wikimedia.org/r/114154 (owner: 10Hashar) [17:54:26] (03PS1) 10Cmcmahon: Update locators for title/post Save elements [extensions/Flow] - 10https://gerrit.wikimedia.org/r/114171 [17:54:29] (03CR) 10jenkins-bot: [V: 04-1] Update locators for title/post Save elements [extensions/Flow] - 10https://gerrit.wikimedia.org/r/114171 (owner: 10Cmcmahon) [17:56:06] (03CR) 10Cmcmahon: [C: 032] "maintenance" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/114171 (owner: 10Cmcmahon) [17:56:18] (03Merged) 10jenkins-bot: Update locators for title/post Save elements [extensions/Flow] - 10https://gerrit.wikimedia.org/r/114171 (owner: 10Cmcmahon) [17:58:22] <^d> itwikiquote's done building. itwikiversity is in a batch process I'm running on all wikiversities so will be awhile. [17:58:27] <^d> Nemo_bis: ^ [17:58:43] nice :) [18:02:43] ^d: I'm unclear where I should be seeing interwiki searches in production now if anywhere [18:02:52] <^d> Nope, not in production yet. [18:02:55] <^d> It's still pretty wonky. [18:03:20] Ah, ok [18:03:56] (03PS1) 10Cmcmahon: Don't check for 'Block', only very privileged users will have this [extensions/Flow] - 10https://gerrit.wikimedia.org/r/114172 [18:04:47] (03PS1) 10Umherirrender: Add space after math_failure message [extensions/Math] - 10https://gerrit.wikimedia.org/r/114173 [18:09:01] (03PS1) 10Matthias Mullie: Fix outdated changetype; flow-* prefixes were dropped a long time ago [extensions/Flow] - 10https://gerrit.wikimedia.org/r/114175 [18:09:05] (03CR) 10Umherirrender: "Was removed on I99973bcf7b3a663eeecda136e32b70c26055dbb8" [extensions/Math] - 10https://gerrit.wikimedia.org/r/114173 (owner: 10Umherirrender) [18:12:03] (03PS7) 10Physikerwelt: Coverage tests for the Math extension [extensions/Math] - 10https://gerrit.wikimedia.org/r/112353 [18:14:11] (03CR) 10jenkins-bot: [V: 04-1] Coverage tests for the Math extension [extensions/Math] - 10https://gerrit.wikimedia.org/r/112353 (owner: 10Physikerwelt) [18:16:13] (03PS1) 10Matthias Mullie: Bit more obvious way to tell if post isFormatted [extensions/Flow] - 10https://gerrit.wikimedia.org/r/114176 [18:17:30] (03CR) 10EBernhardson: [C: 032] Bit more obvious way to tell if post isFormatted [extensions/Flow] - 10https://gerrit.wikimedia.org/r/114176 (owner: 10Matthias Mullie) [18:17:42] (03Merged) 10jenkins-bot: Bit more obvious way to tell if post isFormatted [extensions/Flow] - 10https://gerrit.wikimedia.org/r/114176 (owner: 10Matthias Mullie) [18:21:21] (03CR) 10Physikerwelt: [V: 032] "k... let's try to avoid error messages at all" [extensions/Math] - 10https://gerrit.wikimedia.org/r/114173 (owner: 10Umherirrender) [18:21:36] (03CR) 10Physikerwelt: [C: 032] "k... let's try to avoid error messages at all" [extensions/Math] - 10https://gerrit.wikimedia.org/r/114173 (owner: 10Umherirrender) [18:21:44] (03Merged) 10jenkins-bot: Add space after math_failure message [extensions/Math] - 10https://gerrit.wikimedia.org/r/114173 (owner: 10Umherirrender) [18:24:13] (03CR) 10Yuvipanda: Add flag to enable/disable site-wide global CSS/JS (031 comment) [extensions/GlobalCssJs] - 10https://gerrit.wikimedia.org/r/114079 (owner: 10Yuvipanda) [18:25:44] (03CR) 10Umherirrender: "@Reedy and @Catrope, can you have a look on this patch set? Thanks." [core] - 10https://gerrit.wikimedia.org/r/109956 (owner: 10Umherirrender) [18:27:53] (03PS4) 10Yuvipanda: Add flag to enable/disable site-wide global CSS/JS [extensions/GlobalCssJs] - 10https://gerrit.wikimedia.org/r/114079 [18:27:54] legoktm: ^ [18:28:11] (03CR) 10Krinkle: Add flag to enable/disable site-wide global CSS/JS (032 comments) [extensions/GlobalCssJs] - 10https://gerrit.wikimedia.org/r/114079 (owner: 10Yuvipanda) [18:28:45] Krinkle: ^ see PS4 [18:29:53] YuviPanda: Be sure to make the registration conditional as well [18:30:20] Krinkle: does that matter? If we aren't adding it anywhere. [18:30:23] Otherwise it only controls loading, as opposed to the registration/usage of the module in general. [18:30:27] YuviPanda: startup module [18:30:32] and availability to other modules [18:30:37] adds bulk [18:30:44] Krinkle: right. fair enough. [18:33:38] (03PS8) 10Physikerwelt: Coverage tests for the Math extension [extensions/Math] - 10https://gerrit.wikimedia.org/r/112353 [18:34:39] Hi, I am installing MediaWiki Vagrant on my Ubuntu machine and on running 'vagrant up', I get the following error [18:34:43] "err: /Stage[main]/Mediawiki::Phpsh/Package[phpsh]/ensure: change from absent to 1.3.4 failed: Could not update: Execution of '/usr/bin/pip install -q phpsh==1.3.4' returned 1: Cannot fetch index base URL http://pypi.python.org/simple/" [18:35:32] (03CR) 10jenkins-bot: [V: 04-1] Coverage tests for the Math extension [extensions/Math] - 10https://gerrit.wikimedia.org/r/112353 (owner: 10Physikerwelt) [18:35:34] I am behind a proxy server. I tried setting the https_proxy environment variable as well but that does not seem to work. [18:52:08] RoanKattouw_away: Reedy: https://gerrit.wikimedia.org/r/#/c/109956/ [18:54:37] (03PS5) 10Phuedx: Log title moves using the PageMove schema [extensions/WikimediaEvents] - 10https://gerrit.wikimedia.org/r/113261 [18:55:37] (03CR) 10Phuedx: Log title moves using the PageMove schema (031 comment) [extensions/WikimediaEvents] - 10https://gerrit.wikimedia.org/r/113261 (owner: 10Phuedx) [18:57:18] (03CR) 10Krinkle: "Similar patches were previously rejected on the basis of it causing maintenance hazards I don't think we're ready to deal with. (read more" (031 comment) [core] - 10https://gerrit.wikimedia.org/r/114085 (owner: 10Mattflaschen) [18:57:36] (03PS5) 10Krinkle: mediawiki.log: Move #warn and #deprecate to mediawiki.js and add tracking [core] - 10https://gerrit.wikimedia.org/r/111957 [18:57:41] (03CR) 10Ori.livneh: [C: 032] mediawiki.log: Move #warn and #deprecate to mediawiki.js and add tracking [core] - 10https://gerrit.wikimedia.org/r/111957 (owner: 10Krinkle) [18:58:57] (03CR) 10Krinkle: "@Matt: The try/catch has to happen each time. We don't catch because of support (that's what the feature test is for, and that rules out o" [core] - 10https://gerrit.wikimedia.org/r/111957 (owner: 10Krinkle) [19:02:09] (03Merged) 10jenkins-bot: mediawiki.log: Move #warn and #deprecate to mediawiki.js and add tracking [core] - 10https://gerrit.wikimedia.org/r/111957 (owner: 10Krinkle) [19:02:52] (03PS1) 10Matthias Mullie: Fix typo [extensions/Flow] - 10https://gerrit.wikimedia.org/r/114185 [19:04:22] (03CR) 10EBernhardson: [C: 032] Fix typo [extensions/Flow] - 10https://gerrit.wikimedia.org/r/114185 (owner: 10Matthias Mullie) [19:04:33] (03Merged) 10jenkins-bot: Fix typo [extensions/Flow] - 10https://gerrit.wikimedia.org/r/114185 (owner: 10Matthias Mullie) [19:05:56] (03PS1) 10Bsitu: Ignore non-flow javascript error [extensions/Flow] - 10https://gerrit.wikimedia.org/r/114187 [19:09:15] (03PS4) 10MarkTraceur: Grep for jsduck warnings and exit nonzero for them [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/113033 [19:09:23] (03CR) 10MarkTraceur: [C: 032] "Effing fast forward commits" [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/113033 (owner: 10MarkTraceur) [19:09:51] (03Merged) 10jenkins-bot: Grep for jsduck warnings and exit nonzero for them [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/113033 (owner: 10MarkTraceur) [19:17:14] (03CR) 10Catrope: [C: 032] Unroll array_map in ResourceLoaderFileModule::readStyleFiles [core] - 10https://gerrit.wikimedia.org/r/109956 (owner: 10Umherirrender) [19:17:16] mwalker: the Set-Cookie would be on the primary request for the page, not a special geoip endpoint; it wouldn't be needed for ipv4 users [19:18:01] anomie: can you look at https://gerrit.wikimedia.org/r/#/c/110210/ ? No one seems to want to :/ [19:18:32] AaronSchulz: Sure [19:20:51] (03Merged) 10jenkins-bot: Unroll array_map in ResourceLoaderFileModule::readStyleFiles [core] - 10https://gerrit.wikimedia.org/r/109956 (owner: 10Umherirrender) [19:21:01] (03CR) 10Anomie: UploadStash us_props fix for Postgres (031 comment) [core] - 10https://gerrit.wikimedia.org/r/110210 (owner: 10Aaron Schulz) [19:21:04] hey ori - just wanted to let you know I'll be diving into perf guideline stuff today [19:21:30] woot, that's awesome [19:22:44] ori: basically my plan is to gather up whatever we already have written, + notes from the Arch Summit & some other sessions, and start a skeleton [19:23:28] ori: in the end I figure we oughta have a 100-word TL;DR kind of thing, the kind of thing we could turn into a poster, + some details [19:23:41] ("some details" means the big long HOWTO) [19:23:49] ori: sound right? [19:25:11] (03CR) 10Matthias Mullie: [C: 032] Ignore non-flow javascript error [extensions/Flow] - 10https://gerrit.wikimedia.org/r/114187 (owner: 10Bsitu) [19:25:21] (03Merged) 10jenkins-bot: Ignore non-flow javascript error [extensions/Flow] - 10https://gerrit.wikimedia.org/r/114187 (owner: 10Bsitu) [19:27:18] (03PS2) 10Aaron Schulz: UploadStash us_props fix for Postgres [core] - 10https://gerrit.wikimedia.org/r/110210 [19:27:41] anomie: huh, strange typo [19:29:51] (03CR) 10Anomie: UploadStash us_props fix for Postgres (031 comment) [core] - 10https://gerrit.wikimedia.org/r/110210 (owner: 10Aaron Schulz) [19:31:51] (03CR) 10Aaron Schulz: UploadStash us_props fix for Postgres (031 comment) [core] - 10https://gerrit.wikimedia.org/r/110210 (owner: 10Aaron Schulz) [19:32:39] heh, https://gerrit.wikimedia.org/r/#/c/110210/ doesn't load either [19:32:46] (03Abandoned) 10Aaron Schulz: UploadStash us_props fix for Postgres [core] - 10https://gerrit.wikimedia.org/r/110210 (owner: 10Aaron Schulz) [19:36:30] ^d: https://gerrit.wikimedia.org/r/#/c/114006/ [19:36:57] (03CR) 10Chad: [C: 032] Added some profiling calls to Swift backend [core] - 10https://gerrit.wikimedia.org/r/114006 (owner: 10Aaron Schulz) [19:38:17] sumanah: yes, i think that's the right idea [19:38:29] ori: great! [19:39:19] sumanah: thanks again for lending your time to this [19:40:24] :D [19:40:33] (03Merged) 10jenkins-bot: Added some profiling calls to Swift backend [core] - 10https://gerrit.wikimedia.org/r/114006 (owner: 10Aaron Schulz) [19:58:23] (03CR) 10Kaldari: [C: 04-1] "I agree with Jon that this should be loaded as part of the skins. It's essentially the same thing as much of the styling in common/shared." [core] - 10https://gerrit.wikimedia.org/r/114085 (owner: 10Mattflaschen) [19:59:07] (03PS5) 10Yuvipanda: Add flag to enable/disable site-wide global CSS/JS [extensions/GlobalCssJs] - 10https://gerrit.wikimedia.org/r/114079 [19:59:21] Krinkle: legoktm ^ [20:00:53] (03PS1) 10UltrasonicNXT: Fix concat operator (this is JS, not PHP) [extensions/MediaWikiChat] - 10https://gerrit.wikimedia.org/r/114198 [20:02:27] (03CR) 10UltrasonicNXT: [C: 032 V: 032] Fix concat operator (this is JS, not PHP) [extensions/MediaWikiChat] - 10https://gerrit.wikimedia.org/r/114198 (owner: 10UltrasonicNXT) [20:16:23] (03CR) 10Ori.livneh: [C: 04-1] "Looks good, tiny quibble inline" (031 comment) [tools/scap] - 10https://gerrit.wikimedia.org/r/114124 (owner: 10BryanDavis) [20:16:27] ^ bd808 [20:16:38] * bd808 looks [20:21:21] (03PS2) 10BryanDavis: Avoid creating ssh orphans [tools/scap] - 10https://gerrit.wikimedia.org/r/114124 [20:21:37] (03CR) 10BryanDavis: Avoid creating ssh orphans (031 comment) [tools/scap] - 10https://gerrit.wikimedia.org/r/114124 (owner: 10BryanDavis) [20:22:26] (03PS3) 10BryanDavis: Avoid creating ssh orphans [tools/scap] - 10https://gerrit.wikimedia.org/r/114124 [20:22:30] (03CR) 10Ori.livneh: [C: 032] Avoid creating ssh orphans [tools/scap] - 10https://gerrit.wikimedia.org/r/114124 (owner: 10BryanDavis) [20:22:32] (03Merged) 10jenkins-bot: Avoid creating ssh orphans [tools/scap] - 10https://gerrit.wikimedia.org/r/114124 (owner: 10BryanDavis) [20:23:25] (03PS5) 10BryanDavis: Add bootstrap initialization for l10n update in new branches [tools/scap] - 10https://gerrit.wikimedia.org/r/113260 [20:24:21] (03PS13) 10Alex Monk: Feedback includes browser info, given user permission [core] - 10https://gerrit.wikimedia.org/r/32700 (owner: 10Nischayn22) [20:24:46] bd808: i lost scrollback; did you get the OK from greg for a scap? [20:25:15] (03CR) 10jenkins-bot: [V: 04-1] Feedback includes browser info, given user permission [core] - 10https://gerrit.wikimedia.org/r/32700 (owner: 10Nischayn22) [20:25:27] ori: I never asked. I warned him about the changes we'd made. [20:25:27] bd808: if so (and if greg-g agrees), i think we should probably do one before merging the l10n change, and another one after [20:25:45] (03PS10) 10Reedy: Rewrite ContactPage to use HTMLForm [extensions/ContactPage] - 10https://gerrit.wikimedia.org/r/113879 [20:26:03] greg-g: would a no-op scap be ok? [20:26:04] (03CR) 10Reedy: Rewrite ContactPage to use HTMLForm (033 comments) [extensions/ContactPage] - 10https://gerrit.wikimedia.org/r/113879 (owner: 10Reedy) [20:26:30] * bd808 got outtyped by ori [20:27:10] ori: I think greg-g is at lunch at the moment [20:27:24] (03PS1) 10Chad: Remove Calendar and Quiz extensions -- unused on cluster [tools/release] - 10https://gerrit.wikimedia.org/r/114330 [20:27:43] * greg-g loos back [20:27:54] bd808: ori: sounds like a plan [20:28:08] (03PS14) 10Alex Monk: Feedback includes browser info, given user permission [core] - 10https://gerrit.wikimedia.org/r/32700 (owner: 10Nischayn22) [20:28:11] Excellent. We can fall in the hole before anyone else does [20:28:13] cool. bd808, you wanna do it or should i? [20:28:15] (03PS2) 10Reedy: Move Subject to be third field on form [extensions/ContactPage] - 10https://gerrit.wikimedia.org/r/114101 [20:28:34] ori: I'd like to do it. [20:28:42] I'll yell if I run into trouble [20:28:44] well, you can't! [20:28:47] i'm joking [20:28:48] (03PS3) 10Reedy: Move Subject to be third field on form [extensions/ContactPage] - 10https://gerrit.wikimedia.org/r/114101 [20:28:49] godspeed, etc. [20:28:59] (03CR) 10jenkins-bot: [V: 04-1] Feedback includes browser info, given user permission [core] - 10https://gerrit.wikimedia.org/r/32700 (owner: 10Nischayn22) [20:29:21] (03PS15) 10Alex Monk: Feedback includes browser info, given user permission [core] - 10https://gerrit.wikimedia.org/r/32700 (owner: 10Nischayn22) [20:30:19] (03PS1) 10Chad: Use ssh for submodules, makes it easier to manage from [tools/release] - 10https://gerrit.wikimedia.org/r/114331 [20:32:54] (03CR) 10Ori.livneh: "There are other roles that require more RAM (like ottomata's Hadoop stuff) and so far we've relied on simply documenting the requirement i" [vagrant] - 10https://gerrit.wikimedia.org/r/94950 (owner: 10Adamw) [20:33:02] ^ awight [20:35:07] (03CR) 10Ori.livneh: [C: 032] Log title moves using the PageMove schema [extensions/WikimediaEvents] - 10https://gerrit.wikimedia.org/r/113261 (owner: 10Phuedx) [20:35:09] (03Merged) 10jenkins-bot: Log title moves using the PageMove schema [extensions/WikimediaEvents] - 10https://gerrit.wikimedia.org/r/113261 (owner: 10Phuedx) [20:35:47] ori: git pull failed for 2 cluster hosts. Retrying on them. [20:35:59] bd808: which two? [20:36:19] mw1097 and mw1109 [20:36:45] could be leftover permissions mess [20:37:09] yeah, will fix [20:37:30] I may have just hit the same time as puppet was running there [20:37:41] they say "Already up-to-date" now [20:37:55] bd808: ah, yeah. they're fine. [20:38:15] bd808: i mistook the fact that they're owned by root to be an issue [20:38:28] I think it was a race with the puppet auto-update code [20:38:35] * ori nods [20:58:14] (03CR) 10Reedy: WIP: Allow inclusion of additional fields (031 comment) [extensions/ContactPage] - 10https://gerrit.wikimedia.org/r/113883 (owner: 10Reedy) [20:58:28] (03PS1) 10EBernhardson: Reimagine recent changes formatting [extensions/Flow] - 10https://gerrit.wikimedia.org/r/114335 [21:00:52] (03CR) 10Bsitu: [C: 031] Move cutting of index data into index code [extensions/Flow] - 10https://gerrit.wikimedia.org/r/112917 (owner: 10Matthias Mullie) [21:01:50] (03CR) 10Reedy: [C: 04-2] "Eh?" (032 comments) [tools/release] - 10https://gerrit.wikimedia.org/r/114330 (owner: 10Chad) [21:17:45] What did 'escapenoentities' do for wfMsg() as an option? Not escape HTML entities? [21:20:17] actually, hm, I found that... but can it be replicated with wfMessage()? [21:20:20] (03Restored) 10Aaron Schulz: UploadStash us_props fix for Postgres [core] - 10https://gerrit.wikimedia.org/r/110210 (owner: 10Aaron Schulz) [21:21:32] (03CR) 10Ori.livneh: [C: 032] Add bootstrap initialization for l10n update in new branches [tools/scap] - 10https://gerrit.wikimedia.org/r/113260 (owner: 10BryanDavis) [21:21:47] (03PS3) 10Aaron Schulz: UploadStash us_props fix for Postgres [core] - 10https://gerrit.wikimedia.org/r/110210 [21:23:20] (03PS1) 10Aaron Schulz: Added some profiling calls to Swift backend [core] (wmf/1.23wmf14) - 10https://gerrit.wikimedia.org/r/114338 [21:23:24] (03CR) 10Aaron Schulz: [C: 032] Added some profiling calls to Swift backend [core] (wmf/1.23wmf14) - 10https://gerrit.wikimedia.org/r/114338 (owner: 10Aaron Schulz) [21:24:25] (03CR) 10Bartosz Dziewoński: "gerrit tells me this can't be merged due to a merge conflict." [extensions/GraphViz] - 10https://gerrit.wikimedia.org/r/111475 (owner: 10Welterkj) [21:25:30] (03CR) 10Legoktm: Add flag to enable/disable site-wide global CSS/JS (031 comment) [extensions/GlobalCssJs] - 10https://gerrit.wikimedia.org/r/114079 (owner: 10Yuvipanda) [21:26:41] (03PS1) 10Merlijn van Deen: Add meta-history bug link expansion [wikimedia/bugzilla/triagescripts] - 10https://gerrit.wikimedia.org/r/114339 [21:26:45] (03CR) 10jenkins-bot: [V: 04-1] UploadStash us_props fix for Postgres [core] - 10https://gerrit.wikimedia.org/r/110210 (owner: 10Aaron Schulz) [21:27:37] (03Merged) 10jenkins-bot: Added some profiling calls to Swift backend [core] (wmf/1.23wmf14) - 10https://gerrit.wikimedia.org/r/114338 (owner: 10Aaron Schulz) [21:28:34] (03PS4) 10Aaron Schulz: UploadStash us_props fix for Postgres [core] - 10https://gerrit.wikimedia.org/r/110210 [21:37:55] (03PS2) 10Reedy: Refactor out HTMLFormField class and type normalisation code [core] - 10https://gerrit.wikimedia.org/r/113889 [21:39:19] (03PS3) 10Reedy: Refactor out HTMLFormField class and type normalisation code [core] - 10https://gerrit.wikimedia.org/r/113889 [21:39:31] (03PS4) 10Reedy: Refactor out HTMLFormField class and type normalisation code [core] - 10https://gerrit.wikimedia.org/r/113889 [21:39:46] can I bother someone to review or merge https://gerrit.wikimedia.org/r/112921 ? short and has plenty of comments already that have been addressed. [21:40:27] greg-g: wanna check out ^ ? [21:41:14] (03CR) 10Anomie: [C: 032] Rewrite ContactPage to use HTMLForm [extensions/ContactPage] - 10https://gerrit.wikimedia.org/r/113879 (owner: 10Reedy) [21:41:17] (03Merged) 10jenkins-bot: Rewrite ContactPage to use HTMLForm [extensions/ContactPage] - 10https://gerrit.wikimedia.org/r/113879 (owner: 10Reedy) [21:41:28] (03CR) 10Reedy: WIP: Allow inclusion of additional fields (031 comment) [extensions/ContactPage] - 10https://gerrit.wikimedia.org/r/113883 (owner: 10Reedy) [21:41:32] sumanah: dennyvrandecic I wouldn't feel comfortable doing that, I assume someone from -mobile would be able to review it? [21:41:37] anomie: do we even use that extension anymore? [21:41:51] mwalker: We're going to be using it more... [21:42:02] mwalker: I think so. And Legal is going to start using it more after we finish Reedy's changes [21:42:08] ah; cool! [21:42:14] * mwalker goes back to lurking [21:42:37] it's the ContactPageFundraiser mutation I want to get killed/removed [21:42:57] greg-g: i think so, too. Poking brion [21:43:25] hm? [21:43:28] dennyvrandecic: :) [21:43:31] hiya btw [21:44:13] would you mind reviewing or merging https://gerrit.wikimedia.org/r/#/c/112921/ if you have time? it is sitting around, lonely, waiting, longing to belong... [21:44:21] brion^ [21:44:22] :) [21:44:25] greg-g: hiya :) [21:44:36] dennyvrandecic: main further thing i'd recommend is only outputting the link on actual wiki pages [21:44:47] since other things may not be handled fully by the app (yet!) [21:44:55] understood [21:45:37] brion: is this the same as if context->shouldDisplayMobileView ? [21:46:11] or shall I check for if not special page? [21:46:44] dennyvrandecic: not sure offhand, been a while since i poked MF directly much [21:47:18] but yeah basically -- if you're a non-special page with no fancy URL parameters you're probably fine to add the link [21:47:24] and if not, then you probably should leave it off for now [21:47:30] ok. will do so. [21:47:32] thx [21:47:35] dennyvrandecic: There's a #wikimedia-mobile channel [21:47:44] ah, wasn't aware [21:47:53] back when I hacked on MF for WMDE, I found reviewers there ;) [21:48:00] hoo: thanks [21:48:13] yeah we're mostly in a meeting right now though except for those in different timezones atm :D [21:48:52] i am not in a hurry. just wanted to poke about it [21:48:55] (03PS2) 10EBernhardson: Reimagine recent changes formatting [extensions/Flow] - 10https://gerrit.wikimedia.org/r/114335 [21:48:58] (03PS1) 10EBernhardson: Tweak Special:Contributions formatting [extensions/Flow] - 10https://gerrit.wikimedia.org/r/114344 [21:49:59] dennyvrandecic: no worries. :) i've starred the commit so i should see if you poke another update on it [21:50:28] brion: thx. I probably will some time this afternoon. [21:50:52] awesome [21:50:54] as said, no hurry, just want to avoid it getting stale [21:51:33] yep. always wise :D [21:55:12] (03PS1) 10Phuedx: WIP: Center GettingStarted modal in IE6/7 [extensions/GettingStarted] - 10https://gerrit.wikimedia.org/r/114347 [21:55:17] ^ superm401 [21:55:28] Thanks, phuedx [21:57:19] (03CR) 10Anomie: [C: 031] "Doesn't blow up when I hit the codepath using MySQL. Do we have a PostgreSQL user to test it?" [core] - 10https://gerrit.wikimedia.org/r/110210 (owner: 10Aaron Schulz) [22:02:32] superm401: i tested it in ie6/7/8, and chrome, firefox, and safari head [22:03:15] phuedx, nice. [22:03:46] (03PS1) 10Bsitu: OBOD should be cleared when visiting Flow-enabled talk page [extensions/Flow] - 10https://gerrit.wikimedia.org/r/114349 [22:12:43] csteipp: how is the https://www.mediawiki.org/wiki/Requests_for_comment/Passwords going? last action was "csteipp will research and update the rfc with estimate for online attacks to compromise accounts to get autoconfirmed access. " [22:13:26] sumanah: I added https://www.mediawiki.org/wiki/Requests_for_comment/Passwords#Threats last week for that [22:13:42] csteipp: I skimmed and missed that, sorry! [22:13:44] cool [22:13:58] So it should be ready for another look I think [22:13:59] csteipp: do you think it's ready for more discussion Friday in RFC review? [22:14:38] sumanah: I think it's ready, but isn't Tim out still? [22:14:39] (03PS5) 10Reedy: WIP: Allow inclusion of additional fields [extensions/ContactPage] - 10https://gerrit.wikimedia.org/r/113883 [22:15:16] csteipp: he is. if you'd rather wait till the next meeting, when he's back.... [22:15:26] er, would you? [22:15:30] I think that would be good [22:15:34] oh ok [22:16:00] Unless it's the next week, because I'm offline most of the week. Week of 3/3> [22:16:45] how about around Feb 26? [22:17:19] I'm offline most of the week of Feb 24th. March 5th maybe? [22:17:40] oh I see [22:21:18] (03PS6) 10Reedy: WIP: Allow inclusion of additional fields [extensions/ContactPage] - 10https://gerrit.wikimedia.org/r/113883 [22:21:46] (03CR) 10Reedy: WIP: Allow inclusion of additional fields (034 comments) [extensions/ContactPage] - 10https://gerrit.wikimedia.org/r/113883 (owner: 10Reedy) [22:21:51] csteipp: ok, sorry, I misunderstood, sure, let's say around March 5 [22:22:10] sumanah: Cool, works for me! [22:23:11] thanks csteipp [22:26:30] (03PS7) 10Reedy: WIP: Allow inclusion of additional fields [extensions/ContactPage] - 10https://gerrit.wikimedia.org/r/113883 [22:27:52] (03PS8) 10Reedy: WIP: Allow inclusion of additional fields [extensions/ContactPage] - 10https://gerrit.wikimedia.org/r/113883 [22:53:29] brion: gwicke - how would you feel about 9am your time on Friday? :/ [22:56:55] sumanah, fine with me [22:57:13] and I know brion has been trying to wake up early these days :) [23:01:29] [23:03:27] sumanah: works for me [23:03:38] sumanah: https://www.mediawiki.org/wiki/Developers/Maintainers is that still worth updating or do we consider it historical? [23:05:01] hoo: I think it is worth updating [23:05:15] Ok, will add myself to a few places then [23:05:28] at some point, someone oughta revamp it but that is not something I am concentrating on right now [23:05:28] (03CR) 10Kaldari: [C: 031] "Is this safe to merge immediately?" [core] - 10https://gerrit.wikimedia.org/r/114080 (owner: 10Mattflaschen) [23:05:58] sumanah: https://meta.wikimedia.org/w/index.php?title=System_administrators << that one needs a bit of love also... I just updated it a little, but there have been many changes [23:06:50] hoo: I agree that it needs improvement [23:07:05] * sumanah has no plans to improve it [23:07:10] mh [23:08:14] (03CR) 10BryanDavis: [C: 032] Refactor out HTMLFormField class and type normalisation code [core] - 10https://gerrit.wikimedia.org/r/113889 (owner: 10Reedy) [23:10:26] hoo: "mh"? [23:11:40] (03Merged) 10jenkins-bot: Refactor out HTMLFormField class and type normalisation code [core] - 10https://gerrit.wikimedia.org/r/113889 (owner: 10Reedy) [23:11:55] sumanah: Well, I think everyone with access should be listed there... users should be able to see who has access (to their data) without having to search through puppet files [23:14:02] I agree, hoo - it's one of many things that ought to happen ... I will ask Guillaume to take a look [23:14:56] automated. [23:16:39] hoo, I think BZ admins need to be split off that page [23:16:53] basile, sumanah ^ [23:17:08] It makes no sense to have them there [23:17:26] * sumanah leaves the topic, has to get other things done right now [23:17:53] Krenair: well, but it's at least easier to keep current if things are in a single place [23:18:22] hoo, want to add gerrit admins, RT admins, OTRS admins, etc. etc. to that list too then? [23:19:51] Krenair: hoo - you are sensible people and I welcome your changes! [23:26:26] (03PS5) 10Anomie: HTMLForm: Allow i18n of 'options' [core] - 10https://gerrit.wikimedia.org/r/114066 [23:26:39] :) [23:32:22] (03CR) 10Aaron Schulz: [C: 032] Fix Oracle 1.23 missing patches [core] - 10https://gerrit.wikimedia.org/r/111735 (owner: 10Freakolowsky) [23:33:00] (03CR) 10jenkins-bot: [V: 04-1] Fix Oracle 1.23 missing patches [core] - 10https://gerrit.wikimedia.org/r/111735 (owner: 10Freakolowsky)