[00:25:29] (03CR) 10Krinkle: jquery.suggestions, mediawiki.searchSuggest: Don't use jquery.autoEllipsis (031 comment) [core] - 10https://gerrit.wikimedia.org/r/111180 (owner: 10Bartosz Dziewoński) [00:29:31] (03PS4) 10Reedy: Rewriting ContactPage to use HTMLForm [extensions/ContactPage] - 10https://gerrit.wikimedia.org/r/113879 [00:31:11] (03PS5) 10Reedy: Rewriting ContactPage to use HTMLForm [extensions/ContactPage] - 10https://gerrit.wikimedia.org/r/113879 [00:58:09] (03PS1) 10Reedy: WIP: Allow inclusion of additional fields [extensions/ContactPage] - 10https://gerrit.wikimedia.org/r/113883 [00:59:00] (03CR) 10Reedy: "This has been replaced. Keeping open for ease to find for reference" [extensions/ContactPage] - 10https://gerrit.wikimedia.org/r/110276 (owner: 10Reedy) [01:03:13] (03PS1) 10MaxSem: Add a role for wikidiff2 [vagrant] - 10https://gerrit.wikimedia.org/r/113884 [01:07:08] (03PS1) 10Reedy: Make NewHTMLCheckField extends HTMLCheckField [extensions/BetaFeatures] - 10https://gerrit.wikimedia.org/r/113885 [01:11:55] (03CR) 10Reedy: "This was originally done against https://meta.wikimedia.org/wiki/Trademark/Request_a_license_form" [extensions/WikimediaMessages] - 10https://gerrit.wikimedia.org/r/110243 (owner: 10Reedy) [01:17:17] (03PS1) 10Roman Tsukanov: Removed messages from $wgIgnoredMessages in maintenance/language/messageTypes.inc [core] - 10https://gerrit.wikimedia.org/r/113886 [01:17:19] (03PS1) 10Roman Tsukanov: Improved message texts. [core] - 10https://gerrit.wikimedia.org/r/113887 [01:17:21] (03PS1) 10Roman Tsukanov: Added documentation for messages in MessagesQqq.php [core] - 10https://gerrit.wikimedia.org/r/113888 [01:17:32] (03PS6) 10Reedy: Rewriting ContactPage to use HTMLForm [extensions/ContactPage] - 10https://gerrit.wikimedia.org/r/113879 [01:18:07] (03PS2) 10Reedy: WIP: Allow inclusion of additional fields [extensions/ContactPage] - 10https://gerrit.wikimedia.org/r/113883 [01:23:48] (03Abandoned) 10Roman Tsukanov: Removed messages from $wgIgnoredMessages in maintenance/language/messageTypes.inc [core] - 10https://gerrit.wikimedia.org/r/113886 (owner: 10Roman Tsukanov) [01:24:03] (03Abandoned) 10Roman Tsukanov: Improved message texts. [core] - 10https://gerrit.wikimedia.org/r/113887 (owner: 10Roman Tsukanov) [01:24:22] (03Abandoned) 10Roman Tsukanov: Added documentation for messages in MessagesQqq.php [core] - 10https://gerrit.wikimedia.org/r/113888 (owner: 10Roman Tsukanov) [01:31:47] (03PS1) 10Reedy: Output fieldname when exceptioning over bad descriptor class [core] - 10https://gerrit.wikimedia.org/r/113889 [01:31:50] ^ easy [01:35:24] (03PS3) 10Reedy: WIP: Allow inclusion of additional fields [extensions/ContactPage] - 10https://gerrit.wikimedia.org/r/113883 [01:40:08] (03PS4) 10Reedy: WIP: Allow inclusion of additional fields [extensions/ContactPage] - 10https://gerrit.wikimedia.org/r/113883 [01:59:55] (03PS18) 10Gergő Tisza: Embedding Static Map to UploadWizard [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/107892 (owner: 10Inchikutty) [02:00:57] (03CR) 10Gergő Tisza: "A few minor code layout fixes." [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/107892 (owner: 10Inchikutty) [02:04:49] (03CR) 10Gergő Tisza: [C: 031] "Nice work, Anu! I think the current code is fine; next step is to set up a prototype for this and followup patches, and get feedback on ho" [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/107892 (owner: 10Inchikutty) [02:14:16] (03PS1) 10Reedy: Remove unused/incomplete stale HTMLCaptchaField [extensions/ConfirmEdit] - 10https://gerrit.wikimedia.org/r/113891 [02:21:32] (03CR) 10Reedy: Rewriting ContactPage to use HTMLForm (032 comments) [extensions/ContactPage] - 10https://gerrit.wikimedia.org/r/113879 (owner: 10Reedy) [02:27:06] (03CR) 10Reedy: Rewriting ContactPage to use HTMLForm (031 comment) [extensions/ContactPage] - 10https://gerrit.wikimedia.org/r/113879 (owner: 10Reedy) [02:28:18] (03PS1) 10Reedy: Add EmailUser hooks used for Captcha inclusion [extensions/ContactPage] - 10https://gerrit.wikimedia.org/r/113892 [02:30:42] (03PS13) 10Inchikutty: Adding Leaflet scripts to UploadWizard [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/109063 [02:32:19] (03CR) 10Gergő Tisza: [C: 032] "Only rebases since previous +2." [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/109063 (owner: 10Inchikutty) [02:35:41] (03CR) 10Reedy: "Part of me does wonder if this should've just subclassed SpecialEmailUser..." [extensions/ContactPage] - 10https://gerrit.wikimedia.org/r/113879 (owner: 10Reedy) [02:36:27] (03PS1) 10Reedy: Remove 2 false values returned in execute() [core] - 10https://gerrit.wikimedia.org/r/113894 [02:38:01] (03CR) 10Reedy: Rewriting ContactPage to use HTMLForm (031 comment) [extensions/ContactPage] - 10https://gerrit.wikimedia.org/r/113879 (owner: 10Reedy) [03:01:04] (03CR) 10Roman Tsukanov: "Thanks for your tips. Will fix ASAP." [core] - 10https://gerrit.wikimedia.org/r/113794 (owner: 10Roman Tsukanov) [03:03:01] (03PS2) 10BryanDavis: Add detailed duration timing [tools/scap] - 10https://gerrit.wikimedia.org/r/113652 [03:14:34] Hmm, so I feel like the the "typography update" makes things look nicer in chrome, but less nice in my (oldish) firefox [03:16:39] (03PS3) 10BryanDavis: Add detailed duration timing [tools/scap] - 10https://gerrit.wikimedia.org/r/113652 [03:18:44] (03PS1) 10Reedy: Remove UserThrottle [tools/release] - 10https://gerrit.wikimedia.org/r/113898 [03:22:21] (03PS4) 10BryanDavis: Add detailed duration timing [tools/scap] - 10https://gerrit.wikimedia.org/r/113652 [03:54:20] ori: I think we'll go with the sessionId that you suggested rather than pageId and userId :D [03:54:37] ori: I'll update the patch and let you know :) Thanks :) [04:09:55] (03PS12) 10Prtksxna: Add EventLogging [extensions/Popups] - 10https://gerrit.wikimedia.org/r/112661 [04:10:15] \o/ ^^ Got rid of userId and sessionId ^^ \o/ [04:10:42] legoktm ori :D ^ [04:13:31] (03CR) 10Prtksxna: Add EventLogging (031 comment) [extensions/Popups] - 10https://gerrit.wikimedia.org/r/112661 (owner: 10Prtksxna) [04:15:21] (03PS1) 10Brian Wolff: Revert "Transclude translation for preference edit section to ensure consistency of translation" [core] - 10https://gerrit.wikimedia.org/r/113902 [04:19:41] hi there! i'm a beginner in wikimedia-vagrant env. I had installed it a few days ago, and it was working fine on localhost:8080 but now no ports are working, i have tried with httpd.conf file, but vrything seems fine there. Can anyone help? [04:28:59] ds406: Can you SSH into your vagrant box? [04:29:57] no, its not working too [04:32:34] the connection was refused.. :( [04:32:48] ds406: Try running `vagrant up` [04:33:58] prtksxna: should i do that in same wikimedia folder, as i did during wikimedia-vag install? [04:34:25] ds406: Any child folder would do as well [04:36:38] (03CR) 10Physikerwelt: "It's save to be merged, since it's only used by mathoid, which is not used by any production system yet." [extensions/Math] - 10https://gerrit.wikimedia.org/r/113764 (owner: 10Physikerwelt) [04:40:51] prtksxna : Thanks a lot, it wotked :) [04:41:00] ds406: (y) [04:41:37] ds406: My vagrant shuts down randomly too, its best to check if its up before anything else :) [04:42:01] remind me again why vagrant is easier :P [04:43:27] bawolff: Better than setting everything up myself :D I suck at that :\ [04:43:56] That's what apt-get is for ;) [Other than mediawiki of course] [04:44:11] (03PS23) 10Adamw: Provision WMF Fundraising projects [vagrant] - 10https://gerrit.wikimedia.org/r/94950 [04:44:58] except maybe PHPUnit, as that really is a pain to set up by hand [04:44:58] bawolff: Surely you mean brew install, which isn't as smooth sailing :( [04:46:06] prtksxna: Come join the penguin side, we have candy and better package managers ;) [04:46:23] bawolff: But no Logic Pro or Final Cut [04:46:52] bawolff: I want to come to the penguin side, but these applications just won't let me [04:47:08] bawolff: What are you running? [04:47:14] Debian [04:47:40] I totally lack all artistic skill, so I don't need Logic Pro or final cut :) [04:47:46] (03PS1) 10Burthsceh: fix element scope from r92975, p to div [core] - 10https://gerrit.wikimedia.org/r/113904 [04:48:09] bawolff: Maybe you lack those skills because you can't install it :P [04:48:37] bawolff: Maybe I'll switch sides, some day, once I have a desktop to run all that stuff :) [04:48:44] s/it/them [04:49:16] Maybe I should start going with that, I don't suck at art, I just can't get the programs running [04:49:28] Until someone shoves gimp in my face [04:49:36] lol [04:49:50] Or a piano, or a piece of paper :P [04:49:55] * legoktm shoves PS8 Pro Expert Limited edition in bawolff's face [04:50:03] Now $500 for DLC! [04:50:16] legoktm: Shove it in my face too if its for free :D [04:51:18] It took me 3 years after getting my laptop before I took the time to figure out how to get my microphone to work (In typical linux fashion, one line change in super obscure config file) [04:51:37] That stuff scares me lot :\ [04:53:18] Other then the microphone thing though, it mostly just worked [04:55:11] bawolff: I don't think I'll switch till I have desktop that runs MacOS [05:09:17] (03PS1) 10Andrew Bogott: Replace a missing $ before a varname [extensions/OpenStackManager] - 10https://gerrit.wikimedia.org/r/113905 [05:09:43] (03CR) 10Andrew Bogott: [C: 032 V: 032] Replace a missing $ before a varname [extensions/OpenStackManager] - 10https://gerrit.wikimedia.org/r/113905 (owner: 10Andrew Bogott) [05:14:07] (03PS1) 10Legoktm: [WIP] Initial import of code [extensions/AccountInfo] - 10https://gerrit.wikimedia.org/r/113906 [05:14:21] I wonder, have we ever considered letting people do API queries (at least anonoymous ones, like you can do with jsonp) via lua. Seems like people could do cool things with that [05:14:21] I just saw an interesting hack at https://commons.wikimedia.org/wiki/Module:MyUploads that made me think of that [05:14:33] bawolff: there's an open bug for that! [05:14:44] Oh even better [05:14:48] * legoktm finds [05:14:57] https://bugzilla.wikimedia.org/show_bug.cgi?id=49726 [05:16:00] oh, I've even commented on it [05:16:30] Guess I've read enough bugs that they all blend together [05:16:38] :P [05:18:30] legoktm: Do you think it makes sense for me to comment on https://bugzilla.wikimedia.org/show_bug.cgi?id=503 [05:18:48] probably! [05:20:00] bawolff: Yeah, someone did the same with {{Special:PrefixIndex}}, I think. [05:20:03] Horrifying, really. [05:20:36] 134 lines to parse what... [05:21:03] Let me guess, was this an attempt to get around the expensive parser function limit? [05:21:06] legoktm: Eh, why not just output the exact string and leave it at that? [05:21:23] bawolff: How else would you get subpages of a page? [05:21:29] In a Lua module. [05:22:03] We should make special page transclusion as an expensive parser function. Its about ten billion times more expensive then {{#ifexist:...}} [05:22:23] Even the cached ones? [05:22:45] When you transclude a special page it disables the cache of the current page [05:23:02] Fun. [05:23:11] I'm surprised that isn't abused more often. [05:23:21] its not that well known [05:23:42] Spread the word. [05:24:29] Cached special pages generally still involve fetching about 200 rows from the db (vs #ifexist: fetching 1) so they are still a little bit more expensive then #ifexist even ignoring the caching thing, but not that much [05:28:56] Gloria: exact string of...? [05:29:38] legoktm: The User-Agent. [05:29:55] User agent's are ugly [05:30:03] Well, [05:30:16] What I want to do is display a "pretty version" and have the tooltip be the raw one [05:31:01] hmm, we should transclude RC into main page [05:32:29] YuviPanda: Fun fact, used to also disable page caching (doesn't anymore), and it was on commons main page at the time [05:32:41] heh [05:32:47] Up until people starting getting pool counter errors due to how often that page was parsed [05:36:33] man, #wikimedia-design is actually *active*! \o/ [05:36:45] YuviPanda: Yeah it is :D [05:37:17] (03PS5) 10Adamw: SmashPig payments listener and role [vagrant] - 10https://gerrit.wikimedia.org/r/96227 [05:41:38] (03PS6) 10Adamw: SmashPig payments listener and role [vagrant] - 10https://gerrit.wikimedia.org/r/96227 [05:42:34] (03PS3) 10Adamw: Enable STOMP; add some helpful gateway default config [vagrant] - 10https://gerrit.wikimedia.org/r/105423 [05:47:21] (03PS3) 10Adamw: include the Fundraising Stats Dashboard in role::fundraising [vagrant] - 10https://gerrit.wikimedia.org/r/109064 [05:47:24] (03CR) 10jenkins-bot: [V: 04-1] include the Fundraising Stats Dashboard in role::fundraising [vagrant] - 10https://gerrit.wikimedia.org/r/109064 (owner: 10Adamw) [05:50:26] (03PS4) 10Adamw: include the Fundraising Stats Dashboard in role::fundraising [vagrant] - 10https://gerrit.wikimedia.org/r/109064 [05:55:38] (03PS1) 10Burthsceh: Change descriptions of prohibitions to fit when using as generators [core] - 10https://gerrit.wikimedia.org/r/113909 [05:56:45] (03CR) 10Adamw: "@Ori.livneh: more or less passes lint, if you want to give another once-over..." [vagrant] - 10https://gerrit.wikimedia.org/r/94950 (owner: 10Adamw) [05:59:45] (03CR) 10Burthsceh: "If you think to remove these prohibition are prefer, please create a changes and abondon this change." [core] - 10https://gerrit.wikimedia.org/r/113909 (owner: 10Burthsceh) [06:12:08] (03CR) 10Yuvipanda: [C: 032 V: 032] "Seems to work" [extensions/Popups] - 10https://gerrit.wikimedia.org/r/113090 (owner: 10Prtksxna) [06:12:21] \o/ [06:13:44] (03PS13) 10Prtksxna: Add EventLogging [extensions/Popups] - 10https://gerrit.wikimedia.org/r/112661 [06:26:12] (03CR) 10Brian Wolff: "I imagine its because some places skipping the callback is important, in others it doesn't matter (lcfirst doesn't really need it, as you " [core] - 10https://gerrit.wikimedia.org/r/110342 (owner: 10Nikerabbit) [06:39:31] (03CR) 10Nemo bis: "Thanks for the patch. Yuvi, apparently it's one of the imported scripts with local modifications (r110686)." [core] - 10https://gerrit.wikimedia.org/r/113798 (owner: 10Kipod) [06:39:41] (03PS2) 10Legoktm: Initial import of code [extensions/AccountInfo] - 10https://gerrit.wikimedia.org/r/113906 [06:40:49] YuviPanda: want to sanity check ^ and then +2? :) [06:41:00] sure, in another patch now, give me a bit [06:41:04] ok [06:41:09] I'm writing the vagrant role right now :P [06:41:38] (03PS2) 10Kipod: remove junk line that duplicates another line [core] - 10https://gerrit.wikimedia.org/r/113798 [06:41:47] (03CR) 10Yuvipanda: [C: 032] "Fair enough :)" [core] - 10https://gerrit.wikimedia.org/r/113798 (owner: 10Kipod) [06:41:51] legoktm: hehe :D [06:43:03] (03CR) 10Nemo bis: "Thanks for your first patch and welcome in MediaWiki. The error detected by jenkins is:" [extensions/Scribunto] - 10https://gerrit.wikimedia.org/r/113759 (owner: 10Ysangkok) [06:43:28] (03PS1) 10Physikerwelt: Add makefile [services/mathoid] - 10https://gerrit.wikimedia.org/r/113913 [06:43:46] legoktm: looking onw [06:43:50] :D [06:44:12] legoktm: you should mention where it is imported from [06:44:25] the UserAgentParser? it's in the doc bloc [06:44:29] k [06:45:03] (03Abandoned) 10Physikerwelt: Remove version from the npm dependency for now [services/mathoid] - 10https://gerrit.wikimedia.org/r/113027 (owner: 10Physikerwelt) [06:45:06] legoktm: I mean, the commit message just says 'initial import' [06:45:12] oh [06:45:19] "from my computer" ? [06:45:20] xD [06:45:43] legoktm: :P [06:45:44] (03Merged) 10jenkins-bot: remove junk line that duplicates another line [core] - 10https://gerrit.wikimedia.org/r/113798 (owner: 10Kipod) [06:45:53] legoktm: if you just wrote it all, you should just say 'Initial commit' rather than import :P [06:45:56] (03Abandoned) 10Physikerwelt: Prepere for next build [services/mathoid] - 10https://gerrit.wikimedia.org/r/113026 (owner: 10Physikerwelt) [06:46:39] (03PS3) 10Legoktm: Initial commit [extensions/AccountInfo] - 10https://gerrit.wikimedia.org/r/113906 [06:46:46] :OOOO [06:46:53] that gerrit bug got fixed! [06:47:01] which [06:47:20] the one where if you edited via the web interface it would use the old commit message [06:47:34] https://bugzilla.wikimedia.org/show_bug.cgi?id=52016 [06:47:45] ah [06:47:49] is this one reason why people were crying for Gerrit to die in a fire? [06:47:51] MatmaRex already marked it as fixed :P [06:48:36] Jasper_Deng: Its ok, we can think of other reasons [06:50:57] (03PS1) 10Legoktm: Add role for AccountInfo extension [vagrant] - 10https://gerrit.wikimedia.org/r/113914 [06:51:04] YuviPanda: ^ [06:51:29] legoktm: looking. I'll merge the vagrant one first, probably :D [06:52:09] legoktm: you should make AccountInfo depend on CheckUser [06:52:28] legoktm: look at Popups, for example [06:52:31] ok [06:52:50] I'm not sure a hard dependency would be very nice. [06:52:58] Gloria: this is just a vagrant role [06:53:03] Oh. [06:53:07] NEVER MIND THEN. [06:53:28] vagrant roles should be configured in 'typical' configurations, and I suppose this would typically be done with CU [06:53:51] (03CR) 10Physikerwelt: "I remember GWicke did not see an advantage in having different branches. I think it would be nice to use git-tag's that correlate with the" [services/mathoid] - 10https://gerrit.wikimedia.org/r/113025 (owner: 10Physikerwelt) [06:54:56] (03PS2) 10Legoktm: Add role for AccountInfo extension [vagrant] - 10https://gerrit.wikimedia.org/r/113914 [06:55:20] YuviPanda: done ^ [06:55:33] testing [06:57:00] (03CR) 10Physikerwelt: "Hashar: What do you think? I don't have a strong preference concerning that... However I think it would be good if the community agrees on" [services/mathoid] - 10https://gerrit.wikimedia.org/r/113349 (owner: 10Hashar) [07:00:20] legoktm: hmm, errors [07:00:25] oh? [07:00:27] let me test it [07:00:51] YuviPanda: er, is the vagrant role giving errors or the extension? [07:00:54] legoktm: https://dpaste.de/rwJQ [07:00:57] role [07:01:46] YuviPanda: er, did you pull my patch for the extension? [07:01:52] oh [07:01:54] the current repo in gerrit is empty [07:01:57] right [07:01:58] grr [07:03:11] (03CR) 10Yuvipanda: [C: 032] Add role for AccountInfo extension [vagrant] - 10https://gerrit.wikimedia.org/r/113914 (owner: 10Legoktm) [07:03:14] (03Merged) 10jenkins-bot: Add role for AccountInfo extension [vagrant] - 10https://gerrit.wikimedia.org/r/113914 (owner: 10Legoktm) [07:04:30] (03CR) 10Yuvipanda: Initial commit (031 comment) [extensions/AccountInfo] - 10https://gerrit.wikimedia.org/r/113906 (owner: 10Legoktm) [07:04:39] legoktm: looks good except for one minor minor nit [07:04:48] eh [07:04:51] that's an upstream file [07:04:55] I don't want to modify it [07:05:19] I just wget'd that file from github [07:06:35] legoktm: https://github.com/donatj/PhpUserAgent/pull/17 [07:06:44] LOL [07:06:51] ok, I'll fix it :P [07:06:58] (03CR) 10Yuvipanda: [C: 032 V: 032] "Should update the parser again once https://github.com/donatj/PhpUserAgent/pull/17 is merged" [extensions/AccountInfo] - 10https://gerrit.wikimedia.org/r/113906 (owner: 10Legoktm) [07:07:01] legoktm: nah, 'tis ok [07:07:05] ok :D [07:07:14] legoktm: although OMG GITHUB IS SO MUCH BETTER THAN GERRIT JESUS FUXKING CHRIST! [07:07:16] sigh [07:07:23] also, [07:07:32] do you know how I convert my labs instance to not use the instance-proxy? [07:08:14] legoktm: what do you mean? [07:08:22] do you mean from Special:NovaProxy? [07:08:26] right now my instance is accessible via http://legoktm.instance-proxy.wmflabs.org/wiki/Special:Version [07:08:27] or just instance-proxy? [07:08:30] ah [07:08:31] right [07:08:41] I want it to be legoktm.wmflabs.org or something [07:08:49] legoktm: go to 'Manage Web Proxies' in sidebar [07:09:10] legoktm: select the project this is in, do 'add proxy', specify domain name and select instance, and viola! be done :) [07:09:50] Successfully created new proxy legoktm.wmflabs.org for backend legoktm.pmtpa.wmflabs:80. [07:09:51] yay! [07:10:04] oh [07:10:07] now I need to fix the config [07:10:38] legoktm: :D you also get HTTPS and SPDY for free now [07:10:43] yay [07:10:43] https://legoktm.wmflabs.org should work fine [07:11:38] should that be redirecting me to the instance-proxy? [07:12:14] ah fixed [07:12:19] $wgServer was hardcoded [07:13:05] legoktm: heh. [07:13:21] legoktm: you can have as many domains as you want, btw. [07:13:31] lol [07:18:00] (03PS2) 10Roman Tsukanov: Added summary description for Special:ProtectedPages and Special:ProtectedTitles. Added documentation for messages in MessagesQqq.php. Removed messages from $wgIgnoredMessages in maintenance/language/messageTypes.inc. [core] - 10https://gerrit.wikimedia.org/r/113794 [07:18:32] Gloria: http://legoktm.wmflabs.org/wiki/Special:AccountInfo enjoy! [07:18:36] legoktm: btw, 'Information is retained for 90 d 0.0 s.' [07:18:40] yeahhhh [07:18:44] I don't know what's up with that [07:18:44] legoktm: pfft, use https :P [07:19:01] $this->msg( 'accountinfo-length-cu' )->timeperiodParams( $wgCUDMaxAge )->escaped() [07:19:04] is that not right? [07:19:25] wouldn't know, I haven't used that before :P [07:20:34] Oh [07:20:39] I think I know how to make it better. [07:24:53] ugh [07:24:59] YuviPanda: best I can do is "Information is retained for 90 days 0 hours." [07:25:09] do the hours matter? [07:25:26] it's still better than 0.0 s [07:25:49] (03PS1) 10Legoktm: Make time formatting better [extensions/AccountInfo] - 10https://gerrit.wikimedia.org/r/113915 [07:26:23] there [07:26:31] these are some pretty bad defaults [07:26:46] (03PS3) 10Physikerwelt: Add makefile [services/mathoid] - 10https://gerrit.wikimedia.org/r/113025 [07:26:52] (03PS2) 10Legoktm: Make time formatting better [extensions/AccountInfo] - 10https://gerrit.wikimedia.org/r/113915 [07:27:16] legoktm: looking [07:27:39] (03PS5) 10Hashar: git-buildpckage configuration [services/mathoid] - 10https://gerrit.wikimedia.org/r/113349 [07:27:55] (03CR) 10Yuvipanda: [C: 032 V: 032] "Better than before but could be better!" [extensions/AccountInfo] - 10https://gerrit.wikimedia.org/r/113915 (owner: 10Legoktm) [07:28:02] lol [07:28:10] (03Abandoned) 10Physikerwelt: Add makefile [services/mathoid] - 10https://gerrit.wikimedia.org/r/113913 (owner: 10Physikerwelt) [07:28:47] (03PS1) 10Yuvipanda: labs-vagrant: Fix minor typo [vagrant] - 10https://gerrit.wikimedia.org/r/113916 [07:28:51] legoktm: ^ minor patch [07:29:04] (03CR) 10Legoktm: [C: 032] labs-vagrant: Fix minor typo [vagrant] - 10https://gerrit.wikimedia.org/r/113916 (owner: 10Yuvipanda) [07:29:08] (03Merged) 10jenkins-bot: labs-vagrant: Fix minor typo [vagrant] - 10https://gerrit.wikimedia.org/r/113916 (owner: 10Yuvipanda) [07:29:11] heh, I noticed that earlier :P [07:29:27] :D [07:45:54] Woo, the free font thread has no reached 100 messages [07:46:35] the eye glazeth over [07:47:01] Oh, I thought it was up to 120 or so [07:47:13] 130 in my client [07:47:28] Hmm, sometimes gmail decides to randomly not group some mails [07:47:32] Maybe including design/wikitech cross-post [07:47:53] Yeah, that's why [07:48:09] 26734 N Feb 15 Greg Grossmeier (2.6K) └─>Re: [Design] [Wikitech-l] Should MediaWiki CSS prefer non-free fonts? [07:48:20] 26735 N Feb 15 Greg Grossmeier (2.6K) ├=>Re: [Wikitech-l] [Design] Should MediaWiki CSS prefer non-free fonts? [07:48:31] Few of those in there [07:48:49] I don't think we'll actually reach a conclusion since it still feels like people talking past each other [07:48:53] Also wow, thanks mutt, those space characters are super useful [07:49:04] * YuviPanda licenses Helvetica Neue for the Android app [07:49:10] I'm not even looking at this thread until at least tomorrow [07:49:16] Maybe Wednesday [07:49:24] I just can't find the energy to care [07:49:25] but tomorrow *is* wednesday! [07:49:34] Bloody date lines! [07:49:54] heh [07:50:13] using mutt... you're way more hard core than me :P [07:50:32] bawolff: Not sure that's necessarily true, but I'll take it [07:50:40] * rdwrer redoes his business cards [07:50:50] "Mark Holmquist: Way More Hardcore than Bawolff" [07:51:07] I'm using gmail, which is pretty much the opposite of hard core when it comes to mail clients [07:51:34] Soft core? [07:52:49] I think the fonts thread can be summed up as: Side 1) We want to change the font, Side 2) but why, side 1) because we want to change the font, repeat [07:53:40] with a lot of other random issues mixed in [07:53:55] like, why are you using a mailing list to discuss stuff? [07:54:05] and, why is the foundation pushing non-free things? [07:54:12] mailing lists! the horror! [07:54:13] heh, +1 to bawolff [07:54:28] * YuviPanda invites bawolff to a hangout [07:54:36] lol [07:54:45] also you are all on IRC too much! get a life! [07:54:56] oh, that wasn't on the list. fine [07:55:14] legoktm: I'm waiting for someone to make a huge fuss over the foundation actually making an iOS app [07:55:21] surprised it hasn't happened yet [07:55:24] eek [07:55:26] what's this? [07:55:31] I mean [07:55:35] developing for closed source platforms? [07:55:45] if specifying a non free font name is bad enough for this much volume... [07:55:46] I AM OUTRAGED. [07:56:15] heh [07:56:56] bawolff: https://www.mediawiki.org/wiki/User:MarkTraceur thank you, two userboxes was far too few [07:56:59] I'm still surprised that the MP4 vote managed to get not just one, but two /. articles [07:57:20] rdwrer: lol [08:00:32] rdwrer: bawolff https://www.mediawiki.org/wiki/User:Yuvipanda [08:01:08] <3333 [08:01:32] although I'm not sure if I merit en-3 [08:01:49] I think that's warranted, at least [08:01:51] wcpanda [08:01:57] heh [08:02:01] I join in the fun: https://www.mediawiki.org/wiki/User:Bawolff [08:02:13] Hahaha [08:02:58] wow, I found https://gerrit.wikimedia.org/r/#/c/95555/ prtksxna [08:03:22] rdwrer: ^ [08:03:32] YuviPanda: Ooh! Nice [08:03:38] YuviPanda: Hope we can use this eventually [08:03:42] yeah [08:03:49] Already in MMV [08:03:58] Assuming YuviPanda knows this, and pinged me for it [08:04:17] Oh wait, we're totally gonna break VE again when that goes in, aren't we [08:04:21] why? [08:04:28] rdwrer: this is also about 4 months old [08:04:39] I'm rebasing it now [08:04:42] YuviPanda: We did when oojs went into core [08:04:45] It was hilarious. [08:04:47] ah [08:04:48] wait [08:04:51] VE has momentjs in it? [08:04:57] Maybe not? I dunno. [08:05:05] Maybe we'll just break ourselves. [08:05:42] okay. [08:05:44] heh [08:05:44] I joined in: https://www.mediawiki.org/wiki/User:Legoktm [08:05:48] (03PS2) 10Yuvipanda: [WIP] Add Moment.js library for working with date and time [core] - 10https://gerrit.wikimedia.org/r/95555 (owner: 10Krinkle) [08:05:56] haha [08:06:08] Oh my [08:06:19] lol [08:06:45] legoktm: rdwrer bawolff ^ has a +1 from langeng, I wonder who would be happy to merge... [08:07:05] YuviPanda: I bet tgr would!!! [08:07:06] * rdwrer hides [08:07:09] giant js library, not me :P [08:07:17] I can tomorrowish maybe [08:07:25] When I also have time to do the anti-commit for MMV [08:08:05] right [08:08:13] I could do that, actually [08:08:30] getting moment into core would be rather nice [08:09:51] i can merge if the lang folks are fine with it [08:09:57] tgr: siebrand gave it a +1 [08:10:04] tgr: so I guess they are :) [08:10:05] when i proposed it, they had a long list of objections [08:10:38] tgr: yeah, from what he says I guess he agrees with Krinkle|detached that we can work with moment to make it happen upstream [08:11:08] (03PS1) 10Gerrit Patch Uploader: (Bug 61478) Parse {{int:...}} in editwarning [core] - 10https://gerrit.wikimedia.org/r/113918 [08:11:14] (03CR) 10Gerrit Patch Uploader: "This commit was uploaded using the Gerrit Patch Uploader [1]." [core] - 10https://gerrit.wikimedia.org/r/113918 (owner: 10Gerrit Patch Uploader) [08:11:29] YuviPanda: Hi! The Wikidata team may have on opinion on the subject as they have sealed with date time parsing in Wikibase [08:12:09] hmm, perhaps. [08:12:35] rdwrer: why does multimediaviewer *require* JSDuck?! [08:13:05] at least on vagrant [08:13:06] :| [08:14:19] YuviPanda: I've added Daniel and Jeroen as "Reviewer" [08:14:27] Tpt_: thanks! [08:17:15] (03CR) 10Gergő Tisza: [C: 032] [WIP] Add Moment.js library for working with date and time [core] - 10https://gerrit.wikimedia.org/r/95555 (owner: 10Krinkle) [08:18:20] eh [08:18:45] (03PS3) 10Legoktm: Add Moment.js library for working with date and time [core] - 10https://gerrit.wikimedia.org/r/95555 (owner: 10Krinkle) [08:18:49] wooo! [08:19:08] tgr: probably shouldn't merge a patch with "[WIP]" in the commit message :P [08:19:11] hehe [08:19:13] too late [08:19:24] or not [08:19:28] depending on what jenkins does [08:19:41] If you -2 it before jenkins finishes [08:19:49] YuviPanda: That's definitely tgr's domain [08:19:51] someone has to re +2 it [08:19:52] (03CR) 10Yuvipanda: [C: 04-2] Add Moment.js library for working with date and time [core] - 10https://gerrit.wikimedia.org/r/95555 (owner: 10Krinkle) [08:19:56] hmm [08:19:58] I did [08:19:59] bawolff: now what? [08:20:18] that should prevent jenkins-bot from merging when the tests come back positive [08:20:40] right [08:20:42] and then it'll complain [08:20:45] and then we +2 again [08:21:03] Although I don't know what changing the commit message would have done. That might have stopped it too [08:21:15] hmm [08:21:28] mysterious ways of jenkins-bot [08:21:43] eh [08:21:54] noticed that right after clicking publish [08:22:17] ok [08:22:34] YuviPanda: jsduck is required so you don't have to install it by hand [08:22:37] tgr: I'll remove my -2 now, can you +2 PS3? [08:22:49] tgr: it errors out on my machine, and why would I want jsduck on my vagrant? [08:23:00] tgr: it should be a separate role, not a hard dependency [08:23:12] unless MultimediaViewer can't run without JSDuck, which feels weird [08:23:20] (03PS3) 10Brian Wolff: Added summary to Special:ProtectedPages and Special:ProtectedTitles. [core] - 10https://gerrit.wikimedia.org/r/113794 (owner: 10Roman Tsukanov) [08:23:22] (03CR) 10Yuvipanda: Add Moment.js library for working with date and time [core] - 10https://gerrit.wikimedia.org/r/95555 (owner: 10Krinkle) [08:23:27] (03PS4) 10Roman Tsukanov: Added summary to Special:ProtectedPages and Special:ProtectedTitles. [core] - 10https://gerrit.wikimedia.org/r/113794 [08:23:32] tgr: can you try +2 again? ^ [08:23:32] gerrit will refuse the commit if there is a jsduck error so you need to be able to check locally somehow [08:23:44] tgr: sure, I agree. but why have it be a hard dependency? [08:23:46] (03CR) 10Brian Wolff: [C: 032] "Thank you for the patch" [core] - 10https://gerrit.wikimedia.org/r/113794 (owner: 10Roman Tsukanov) [08:24:15] i can make it a separate role [08:24:24] tgr: please do :) [08:24:35] and yes, it is broken atm, will fix that in the next few days [08:25:08] (03CR) 10Gergő Tisza: [C: 032] Add Moment.js library for working with date and time [core] - 10https://gerrit.wikimedia.org/r/95555 (owner: 10Krinkle) [08:25:15] (03PS1) 10Yuvipanda: Remove hard dependency on failing JSDuck for MMV [vagrant] - 10https://gerrit.wikimedia.org/r/113919 [08:25:21] tgr: ^ worked for me. [08:25:37] tgr: also, if that were the case, I'd need jsduck on my *host* system, since that's where I do all my git operations from [08:28:14] there is no reason they have to be on the same system, unless you want to do something tricky like bisect or a pre-push hook [08:28:42] (03Merged) 10jenkins-bot: Added summary to Special:ProtectedPages and Special:ProtectedTitles. [core] - 10https://gerrit.wikimedia.org/r/113794 (owner: 10Roman Tsukanov) [08:29:08] Gloria: I probably can't use text-overflow, it only works for a single line :\ http://html5hub.com/ellipse-my-text/#i.7vbeg24rdegxz3 [08:29:09] gerrit uses an old version of jsduck which gives different errors than the current one, so i figured most people do not want that on their machine [08:29:31] (03Merged) 10jenkins-bot: Add Moment.js library for working with date and time [core] - 10https://gerrit.wikimedia.org/r/95555 (owner: 10Krinkle) [08:30:55] tgr: no, but I do all my development on my host machine, rather than the vagrant one [08:31:08] tgr: so I would want to integrate it into my flow somewehre there [08:31:12] rather than in the vagrant machine [08:33:48] legoktm: Remember the truncating problem? [08:33:55] yeah [08:34:18] legoktm: Once can't *really* fix it, the number of characters isn't a very good measure of how much space it'll end up taking :\ [08:34:27] ugh :| [08:35:02] legoktm: "मे".length >> 2 [08:35:20] legoktm: Add a bindu and its 3 characters :\ [08:35:31] there's probably a JS library that measures real length and not characters. [08:35:52] legoktm: The real width ends up depending on the OS too and how it renders it :\ [08:36:07] sigh [08:36:29] legoktm: Shoot me now [08:36:36] * YuviPanda shoots prtksxna [08:36:45] * prtksxna ducks [08:36:50] prtksxna: https://www.youtube.com/watch?v=LyPFQKpRnd0 [08:36:56] prtksxna: rabbits, you mean [08:37:21] YuviPanda: lol [08:37:33] prtksxna: :D [08:37:37] :P [08:37:59] prtksxna: moment.js merged, thanks to Krinkle|detached and tgr! [08:38:06] prtksxna: want to migrate your code to it at some point? [08:39:07] YuviPanda: YES :D Add to bugzilla? [08:39:12] prtksxna: ok [08:39:13] Is SSL/HTTPS still terminated by a nginx (-cluster)? [08:40:33] I believe so [08:40:44] that's more of a #wikimedia-tech or #wikimedia-operations question though [08:41:15] se4598: it is. [08:41:18] yeah, noticed I was posting to the wrong channel [08:41:36] thanks [08:45:09] (03PS1) 10Yuvipanda: Update moment.js to 2.5.1 [core] - 10https://gerrit.wikimedia.org/r/113923 [08:45:10] tgr: ^ [08:45:42] rdwrer: legoktm bawolff ^ [08:45:58] YuviPanda: if you still have the jsduck error around, could you copy to https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/142 ? [08:46:55] (03CR) 10Gergő Tisza: [C: 032] "Sorry for the trouble. I'll turn it into a separate role." [vagrant] - 10https://gerrit.wikimedia.org/r/113919 (owner: 10Yuvipanda) [08:46:58] (03Merged) 10jenkins-bot: Remove hard dependency on failing JSDuck for MMV [vagrant] - 10https://gerrit.wikimedia.org/r/113919 (owner: 10Yuvipanda) [08:47:09] tgr: it is at https://dpaste.de/NnwW [08:47:16] tgr: and I don't think I've a mingle account :D [08:48:43] tgr: I also updated momentjs to the latest version :) [08:49:35] (03PS1) 10Prtksxna: Move thumbnail creation to its own method [extensions/Popups] - 10https://gerrit.wikimedia.org/r/113924 [08:49:37] (03PS1) 10Prtksxna: Use div with background-image for landscape [extensions/Popups] - 10https://gerrit.wikimedia.org/r/113925 [08:49:40] (03PS1) 10Prtksxna: Limit container height for landscape popup's extract [extensions/Popups] - 10https://gerrit.wikimedia.org/r/113926 [08:53:27] (03CR) 10Gergő Tisza: [C: 032] Update moment.js to 2.5.1 [core] - 10https://gerrit.wikimedia.org/r/113923 (owner: 10Yuvipanda) [08:55:02] legoktm: See the sad fix I am resorted to use https://gerrit.wikimedia.org/r/113926 [08:57:06] (03Merged) 10jenkins-bot: Update moment.js to 2.5.1 [core] - 10https://gerrit.wikimedia.org/r/113923 (owner: 10Yuvipanda) [08:57:32] :| [08:59:05] legoktm: Just clip out the text… [08:59:16] * prtksxna picks up a knife [09:01:49] tgr: thanks! [09:02:19] * prtksxna slashes  [09:02:32] YuviPanda: Surely you mean, "tha…" [09:02:39] prtksxna: haha :D [09:05:32] YuviPanda: I'll raise the bug? [09:05:37] prtksxna: ya! [09:16:44] YuviPanda, prtksxna: are you working on a JS text-overflow module? [09:16:55] tgr: prtksxna wants one :) [09:17:05] tgr: I do. I do. [09:18:07] we need one for multimediaviewer too [09:18:49] tgr: I can't seem to figure out a way it can happen when there are multiple lines of text and different languages [09:19:01] but then maybe i'll just wait it out :P [09:19:07] tgr: If its a single line once can use `text-overflow` in CSS [09:19:29] tgr: And you can't properly put a character limit if there are different scripts involved :( [09:19:57] well, i suppose, add characters one by one, measure block height [09:20:29] tgr: Right, but is that the only solution :'( [09:20:51] there is actually a core module for it, but the code is ehh [09:21:13] tgr: link please? [09:21:38] https://www.mediawiki.org/wiki/ResourceLoader/Default_modules#jquery.autoEllipsis [09:21:47] * prtksxna clicks [09:22:46] or maybe that's single line? [09:23:04] not sure, but i know we looked at it and decided not to [09:23:32] tgr: Looking at the code… [09:28:27] Much Code. Very lines. [09:35:39] tgr: This looks pretty complicated [09:41:48] prtksxna: Also be aware of non-text content [09:42:00] It's really hard to sort that out sometimes [09:47:40] rdwrer: like? tables? [09:47:50] Good example [09:48:02] HTML elements in general, we tried to deal with but weren't totally able to [09:48:07] There were commits... [09:48:50] rdwrer: Oh :( [09:49:10] rdwrer: BTW, I was waiting for your reply here https://gerrit.wikimedia.org/r/#/c/111983/3/Popups.i18n.php [09:49:57] rdwrer: There are pages that just start with HTML, eh? I guess I'll deal with those later… [09:50:15] Hm. [09:50:29] prtksxna: I think the HTML could go in the message [09:52:27] rdwrer: Erm, 1 or 2? [09:54:20] Uh, on the patchset [09:54:36] rdwrer: My options in the comment - https://gerrit.wikimedia.org/r/#/c/111983/3/Popups.i18n.php [09:54:43] Ah. [09:54:46] 1. [09:54:48] I think. [09:55:28] But yeah, your auto-shortener would be nice-to-have for other extensions, and they don't necessarily deal with text only content [09:55:32] Sometimes block elements [09:55:36] Sometimes unpredictable crap [09:55:45] Actually, almost always unpredictable crap [09:56:00] Ah wow, never mind, it's bedtime, I'll catch you up more tomorrow :) [09:56:03] Er, today. [09:56:04] Wow. [09:58:32] rdwrer: Are you alright? [09:58:43] rdwrer: Did you recently take a drink from a stranger? :P [10:09:40] (03CR) 10Ori.livneh: [C: 04-1] "Mostly good. Some comments in-line." (036 comments) [extensions/Popups] - 10https://gerrit.wikimedia.org/r/112661 (owner: 10Prtksxna) [10:26:21] (03CR) 10Yuvipanda: [C: 032 V: 032] Move thumbnail creation to its own method [extensions/Popups] - 10https://gerrit.wikimedia.org/r/113924 (owner: 10Prtksxna) [10:26:34] (03CR) 10Yuvipanda: [C: 032 V: 032] Use div with background-image for landscape [extensions/Popups] - 10https://gerrit.wikimedia.org/r/113925 (owner: 10Prtksxna) [10:27:04] (03CR) 10Yuvipanda: [C: 032 V: 032] "Simplistic solution that seems to work for now." [extensions/Popups] - 10https://gerrit.wikimedia.org/r/113926 (owner: 10Prtksxna) [10:27:41] YuviPanda: Than… [10:27:53] prtksxna: heh... [10:31:29] (03PS1) 10Prtksxna: Use .text instead of .html for the extract [extensions/Popups] - 10https://gerrit.wikimedia.org/r/113936 [10:31:33] YuviPanda: ^ [10:33:02] (03PS2) 10Prtksxna: Use .text instead of .html for the extract [extensions/Popups] - 10https://gerrit.wikimedia.org/r/113936 [10:34:11] (03CR) 10Yuvipanda: [C: 032 V: 032] Use .text instead of .html for the extract [extensions/Popups] - 10https://gerrit.wikimedia.org/r/113936 (owner: 10Prtksxna) [10:56:30] (03CR) 10TTO: "Sorry to jump in here, but I would call this a total "removal" rather than just a "deprecation". $wgPasswordSenderName is now no longer us" [core] - 10https://gerrit.wikimedia.org/r/104707 (owner: 10Theopolisme) [11:09:58] * prtksxna just saw some PHP code that will haunt him till the end of time… [11:10:04] thanks YuviPanda legoktm [11:10:18] prtksxna: you haven't even looked at the mw parser yet :P [11:10:27] YuviPanda: And I won't [11:11:36] prtksxna: hehe :D [11:12:45] YuviPanda: This was worse than some of the stuff I've seen on 4chan [11:13:12] prtksxna: pfft, that's nothing. really [11:13:30] it's reasonably clean code [11:13:47] I am not questioning that :) [11:13:57] prtksxna: :D [11:14:00] (03CR) 10Parent5446: [C: 032] Include the reason when firing the TitleMoveComplete hook [core] - 10https://gerrit.wikimedia.org/r/113789 (owner: 10Phuedx) [11:14:59] (03PS4) 10Physikerwelt: Mathoid 0.1.3 [services/mathoid] - 10https://gerrit.wikimedia.org/r/113025 [11:15:13] (03CR) 10Phuedx: "This is no longer blocked." [extensions/WikimediaEvents] - 10https://gerrit.wikimedia.org/r/113261 (owner: 10Phuedx) [11:15:53] (03CR) 10Physikerwelt: "You can try at" [services/mathoid] - 10https://gerrit.wikimedia.org/r/113025 (owner: 10Physikerwelt) [11:16:23] (03CR) 10Prtksxna: Add `redirects to` message at the top of the popup (031 comment) [extensions/Popups] - 10https://gerrit.wikimedia.org/r/111983 (owner: 10Prtksxna) [11:16:28] (03PS16) 10Prtksxna: Add `redirects to` message at the top of the popup [extensions/Popups] - 10https://gerrit.wikimedia.org/r/111983 [11:16:31] (03CR) 10Physikerwelt: Mathoid 0.1.3 (035 comments) [services/mathoid] - 10https://gerrit.wikimedia.org/r/113025 (owner: 10Physikerwelt) [11:17:54] (03Merged) 10jenkins-bot: Include the reason when firing the TitleMoveComplete hook [core] - 10https://gerrit.wikimedia.org/r/113789 (owner: 10Phuedx) [11:20:21] (03CR) 10Ori.livneh: Log title moves using the PageMove schema (031 comment) [extensions/WikimediaEvents] - 10https://gerrit.wikimedia.org/r/113261 (owner: 10Phuedx) [11:28:29] (03CR) 10Yuvipanda: [C: 032 V: 032] "Assuming page titles can't have HTML. Seems to handle things like '&' fine." [extensions/Popups] - 10https://gerrit.wikimedia.org/r/111983 (owner: 10Prtksxna) [11:29:00] (03PS5) 10Physikerwelt: Mathoid 0.1.3 [services/mathoid] - 10https://gerrit.wikimedia.org/r/113025 [11:53:53] (03CR) 10Mdale: [C: 032 V: 032] "looks good." [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/108646 (owner: 10Brian Wolff) [11:54:36] (03PS14) 10Prtksxna: Add EventLogging [extensions/Popups] - 10https://gerrit.wikimedia.org/r/112661 [11:54:37] YuviPanda: ^ [11:55:06] prtksxna: I'm going to let ori merge that whenever. He should get to it tomorrow, I guess [11:55:17] (03CR) 10Prtksxna: Add EventLogging (036 comments) [extensions/Popups] - 10https://gerrit.wikimedia.org/r/112661 (owner: 10Prtksxna) [11:55:33] YuviPanda: Makes sense [11:55:50] prtksxna: I'll be back in a few mins if you want to talk about cleanup :) [11:56:08] YuviPanda: Should we discuss the code clean up now. I don't feel like looking at the triangle stuff right now [11:56:15] prtksxna: 5 mins? [11:56:16] YuviPanda: sounds good. [11:56:19] prtksxna: ok! [12:00:28] (03PS1) 10Burthsceh: fix escaping fragment of Title [core] - 10https://gerrit.wikimedia.org/r/113943 [12:00:34] (03CR) 10Nuria: "Took me a while to understand how formats are specified and parsed but looks great." (031 comment) [extensions/EventLogging] - 10https://gerrit.wikimedia.org/r/113457 (owner: 10Ori.livneh) [12:04:42] prtksxna: i'mback [12:04:43] 'sup [12:04:52] YuviPanda: hang? [12:05:55] prtksxna: ok [12:06:51] YuviPanda: Start like this https://github.com/wikimedia/mediawiki-extensions-MultimediaViewer/blob/master/resources/mmv/mmv.base.js [12:07:16] (03PS3) 10Ysangkok: Support for modules-as-images [extensions/Scribunto] - 10https://gerrit.wikimedia.org/r/113759 [12:07:19] (03CR) 10jenkins-bot: [V: 04-1] Support for modules-as-images [extensions/Scribunto] - 10https://gerrit.wikimedia.org/r/113759 (owner: 10Ysangkok) [12:08:39] (03PS4) 10Ysangkok: Support for modules-as-images [extensions/Scribunto] - 10https://gerrit.wikimedia.org/r/113759 [12:08:40] (03CR) 10jenkins-bot: [V: 04-1] Support for modules-as-images [extensions/Scribunto] - 10https://gerrit.wikimedia.org/r/113759 (owner: 10Ysangkok) [12:11:41] (03PS5) 10Ysangkok: Support for modules-as-images [extensions/Scribunto] - 10https://gerrit.wikimedia.org/r/113759 [12:11:49] (03PS1) 1001tonythomas: Added the $wgPFEnableStringFunctions = true in ParserFunctions tests [extensions/ParserFunctions] - 10https://gerrit.wikimedia.org/r/113945 [12:11:52] (03CR) 10jenkins-bot: [V: 04-1] Added the $wgPFEnableStringFunctions = true in ParserFunctions tests [extensions/ParserFunctions] - 10https://gerrit.wikimedia.org/r/113945 (owner: 1001tonythomas) [12:13:21] (03CR) 10Ysangkok: "Thanks for your feedback Nemo bis, I expanded the commit message and changed to PHP 5.3 syntax." [extensions/Scribunto] - 10https://gerrit.wikimedia.org/r/113759 (owner: 10Ysangkok) [12:15:24] (03PS2) 1001tonythomas: Added the $wgPFEnableStringFunctions = true in ParserFunctions tests [extensions/ParserFunctions] - 10https://gerrit.wikimedia.org/r/113945 [12:15:26] (03CR) 10jenkins-bot: [V: 04-1] Added the $wgPFEnableStringFunctions = true in ParserFunctions tests [extensions/ParserFunctions] - 10https://gerrit.wikimedia.org/r/113945 (owner: 1001tonythomas) [12:19:27] (03CR) 10Phuedx: Log title moves using the PageMove schema (031 comment) [extensions/WikimediaEvents] - 10https://gerrit.wikimedia.org/r/113261 (owner: 10Phuedx) [12:37:37] (03PS1) 10Yuvipanda: DO NOT MERGE [extensions/Popups] - 10https://gerrit.wikimedia.org/r/113947 [12:37:51] prtksxna: ^ [12:38:29] (03PS1) 10UltrasonicNXT: Parse messages on send, not receive [extensions/MediaWikiChat] - 10https://gerrit.wikimedia.org/r/113948 [12:39:07] (03PS6) 10Ysangkok: Support for modules-as-images [extensions/Scribunto] - 10https://gerrit.wikimedia.org/r/113759 [12:39:12] YuviPanda: Thanks [12:39:17] prtksxna: :D [12:39:26] prtksxna: poke me if you need anything :) [12:39:36] prtksxna: I like this collaboration since I don't have to touch CSS or deal with layout issues :D [12:39:37] YuviPanda: Will do :) [12:39:47] YuviPanda: Hehe [12:39:51] :D [12:40:20] (03CR) 10UltrasonicNXT: [C: 032 V: 032] Parse messages on send, not receive [extensions/MediaWikiChat] - 10https://gerrit.wikimedia.org/r/113948 (owner: 10UltrasonicNXT) [12:42:08] prtksxna: ##javascript is also a good resource :) [12:42:21] YuviPanda: I do read from time to time [12:42:27] prtksxna: :) you can ask also [12:42:31] YuviPanda: Need to add license text too :P [12:42:37] YuviPanda: :) [12:42:40] hmm? [12:42:44] where [12:42:54] YuviPanda: To all the files, like here - https://github.com/wikimedia/mediawiki-extensions-MultimediaViewer/blob/master/resources/mmv/mmv.js [12:42:57] ah [12:42:57] :D [12:43:07] prtksxna: meh, I think a COPYING file is enough, but don't tell rdwrer that [12:43:45] YuviPanda: Then I should remove it from the PHP files too rdwrer :P [12:44:04] prtksxna: heh :P I'm not getting involved in this discussion [12:44:04] (03CR) 10Bartosz Dziewoński: "This is some truly mad hackery. You'll fit right in in the community ;) I added some people working on file storage and multimedia in gene" [extensions/Scribunto] - 10https://gerrit.wikimedia.org/r/113759 (owner: 10Ysangkok) [12:48:38] (03CR) 10Daniel Kinzler: [C: 032] Give alreadyrolled error when rollback will be a null edit [core] - 10https://gerrit.wikimedia.org/r/102550 (owner: 10Umherirrender) [12:52:21] (03Merged) 10jenkins-bot: Give alreadyrolled error when rollback will be a null edit [core] - 10https://gerrit.wikimedia.org/r/102550 (owner: 10Umherirrender) [13:03:47] Gloria: This is a problem regarding browser tests or a jenkins bot issue ? https://bugzilla.wikimedia.org/show_bug.cgi?id=61410 [13:06:28] (03PS1) 10Lekshmi: Merge "Add ParserOutput::addJsConfigVars" [core] - 10https://gerrit.wikimedia.org/r/113950 [13:07:49] (03CR) 10jenkins-bot: [V: 04-1] Merge "Add ParserOutput::addJsConfigVars" [core] - 10https://gerrit.wikimedia.org/r/113950 (owner: 10Lekshmi) [13:08:18] how can I use the variable $wgPFEnableStringFunctions in the ParserExtension tests file ? When I gave $wgPFEnableStringFunctions = true in tests/ExpressionTest.php, jenkins bot wont approve [13:17:31] (03PS7) 10Ysangkok: Support for modules-as-images [extensions/Scribunto] - 10https://gerrit.wikimedia.org/r/113759 [13:17:35] (03PS12) 10Lekshmi: Changed deprecated $wgCopyrightIcon [core] - 10https://gerrit.wikimedia.org/r/109903 [13:19:09] (03CR) 10Nemo bis: "TTO, thanks for your updates to . I don't k" [core] - 10https://gerrit.wikimedia.org/r/104707 (owner: 10Theopolisme) [13:24:04] (03CR) 10Helder.wiki: "Related:" [core] - 10https://gerrit.wikimedia.org/r/95555 (owner: 10Krinkle) [13:30:14] (03CR) 10Ysangkok: "I removed the trailing "?>", and ran stylize.php." [extensions/Scribunto] - 10https://gerrit.wikimedia.org/r/113759 (owner: 10Ysangkok) [13:30:41] (03PS1) 10Prtksxna: Add Triangle/Pokey to the NavigationPopups [extensions/Popups] - 10https://gerrit.wikimedia.org/r/113951 [13:31:11] (03Abandoned) 10Prtksxna: [DONT MERGE] Add Triangle/Pokey to the NavigationPopups [extensions/Popups] - 10https://gerrit.wikimedia.org/r/111773 (owner: 10Prtksxna) [13:35:29] tonythomas01: Not sure off-hand. I added hashar and legoktm to the change. [13:36:20] Gloria: Thanks! But, adding $wgPFEnableStringFunctions = true anywhere in that file should work alright right ? [13:37:35] tonythomas01: Should. :-) [13:38:07] Gloria: I gave it like that, and jenkins again dont looks approving [13:41:20] (03PS3) 1001tonythomas: Added the $wgPFEnableStringFunctions = true in ParserFunctions tests [extensions/ParserFunctions] - 10https://gerrit.wikimedia.org/r/113945 [13:41:27] (03CR) 10jenkins-bot: [V: 04-1] Added the $wgPFEnableStringFunctions = true in ParserFunctions tests [extensions/ParserFunctions] - 10https://gerrit.wikimedia.org/r/113945 (owner: 1001tonythomas) [13:41:34] Gloria: tonythomas01: we have a bug about wgPFEnableStringFunctions [13:41:50] and anomie wrote a patch for Mediawiki core to ensure the test suite always has 1 test [13:42:02] but yeah, in test context wgPFEnableStringFunctions should be set to true [13:42:07] We might have two bugs now. ;-) [13:42:20] I thought about adding a new configuration file for extension, something like TestSettings.php [13:42:22] And perhaps two patches. [13:42:32] which would be include()d automatically [13:42:44] Why a separate file? [13:42:53] not sure ;-] [13:43:17] usually you set the globals in the phpunit test files under extensions/YourExtension/tests/SomethingTest.php [13:43:27] but for parser tests, it uses mediawiki core parser tests engine [13:43:30] which just load the .txt file [13:43:38] there is no real way to set a global [13:43:50] though maybe the parser test .txt config format let one add a global config [13:44:00] but I dont think it works [13:44:55] (03PS4) 1001tonythomas: Added the $wgPFEnableStringFunctions = true in ParserFunctions tests [extensions/ParserFunctions] - 10https://gerrit.wikimedia.org/r/113945 [13:44:56] ah [13:44:57] https://gerrit.wikimedia.org/r/#/c/112033/ [13:45:00] (03CR) 10jenkins-bot: [V: 04-1] Added the $wgPFEnableStringFunctions = true in ParserFunctions tests [extensions/ParserFunctions] - 10https://gerrit.wikimedia.org/r/113945 (owner: 1001tonythomas) [13:45:00] here is mw/core change [13:45:04] :( [13:45:33] tonythomas01: na that does not work :-] [13:45:41] tonythomas01: the tests are executed by MediaWiki core directly [13:45:46] hashar: Thats what I was wondering [13:46:01] ah hold on [13:46:03] I might have a trick [13:46:10] hashar: ok [13:46:14] wikidata had a similar issue [13:46:33] so [13:46:47] The jobs have a special setting " $wgWikimediaJenkinsCI = true ; " [13:46:59] so what you could do is in the ParserFunctions.php file add something like: [13:47:24] if ( $wgWikimediaJenkinsCI === true ) { [13:47:24] $wgPFEnableStringFunctions = true; # whatever the bug number is [13:47:24] } [13:47:32] hashar: ok :) [13:47:37] that feature is not documented, no idea where to document it [13:47:59] I will add it, and wait for what jenkins says [13:48:48] worth a try [13:48:49] hashar: this wgWikimediaJenkinsCI is the variable set when jenkins run the test ? [13:48:54] yeah [13:48:56] hashar: just to know [13:48:58] undocumented feature :D [13:49:07] jenkins does something like: [13:49:09] install mediawiki/core [13:49:13] hashar: its available in every extenstion like ? [13:49:15] oh ! [13:49:24] add a bunch of config files at the end of LocalSettings.php [13:49:26] then run the tests [13:49:45] oh. ok ! I will upload one then [13:50:37] if you have any idea where to document that, I will be happy to write the doc :D [13:51:07] hashar: In the ParserFunctions.php, we already have this $wgPFEnableStringFunctions = false; statement [13:51:12] line 30 [13:51:24] so you want to add the hack below [13:51:28] but, that is not the jenkins triggered one though [13:51:29] ok [13:51:49] I can document it in the same file right ? [13:51:56] maybe I should write some tutorial under https://www.mediawiki.org/wiki/Continuous_integration/Tutorials [13:52:02] something like "how to integrate my extension" :-D [13:52:09] hashar: ok :) [13:52:37] ah https://www.mediawiki.org/wiki/Continuous_integration/Tutorials/Adding_a_MediaWiki_extension [13:52:40] there is already one [13:53:24] yeah ! [13:56:23] (03PS2) 10Prtksxna: Add Triangle/Pokey to the NavigationPopups [extensions/Popups] - 10https://gerrit.wikimedia.org/r/113951 [13:56:25] (03PS15) 10Prtksxna: Add EventLogging [extensions/Popups] - 10https://gerrit.wikimedia.org/r/112661 [14:00:09] (03PS5) 1001tonythomas: Added the $wgPFEnableStringFunctions = true in ParserFunctions tests [extensions/ParserFunctions] - 10https://gerrit.wikimedia.org/r/113945 [14:00:34] tonythomas01: I have added something at the end of https://www.mediawiki.org/wiki/Continuous_integration/Tutorials/Adding_a_MediaWiki_extension#For_your_own_extension [14:00:45] not sure it is very clear, feel free to rephrase / amend / highlight [14:00:52] (03CR) 10Prtksxna: "I will always remember you…" [extensions/Popups] - 10https://gerrit.wikimedia.org/r/111773 (owner: 10Prtksxna) [14:01:03] hashar: ok. Can you go through the new change https://gerrit.wikimedia.org/r/113945 ? [14:01:27] tonythomas01: can you check whether the tests have been run http://integration.wikimedia.org/ci/job/mwext-ParserFunctions-testextensions-master/116/testReport/(root)/ ? [14:01:40] (03CR) 10Manybubbles: [C: 032] "Verified by switching on language to Hebrew and letting Cirrus register itself as a betafeature on my development machine. Code looks goo" [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/113796 (owner: 10Amire80) [14:01:54] (03Merged) 10jenkins-bot: Add rtl icon for the beta feature preference [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/113796 (owner: 10Amire80) [14:05:49] (03CR) 10Hashar: "So this is for the ParserFunctions extensions which has parser tests needing a global setting to be set. It is not currently to set such " [core] - 10https://gerrit.wikimedia.org/r/112033 (owner: 10Anomie) [14:06:10] (03CR) 10Hashar: "Added doc for wgWikimediaJenkinsCI at the bottom of https://www.mediawiki.org/wiki/Continuous_integration/Tutorials/Adding_a_MediaWiki_ex" [core] - 10https://gerrit.wikimedia.org/r/112033 (owner: 10Anomie) [14:08:05] (03CR) 10Hashar: "Two tiny typo :-]" (032 comments) [extensions/ParserFunctions] - 10https://gerrit.wikimedia.org/r/113945 (owner: 1001tonythomas) [14:08:09] tonythomas01: seems it works [14:08:19] tonythomas01: there is two tiny typo I commented on https://gerrit.wikimedia.org/r/#/c/113945/ [14:08:27] tonythomas01: can fix them myself if you want [14:08:32] then we can merge in this change [14:08:32] hashar: I will fix it [14:08:34] ok [14:10:46] (03CR) 10Amire80: "Thanks a lot!" [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/113796 (owner: 10Amire80) [14:10:54] (03PS6) 1001tonythomas: Added the $wgPFEnableStringFunctions = true in ParserFunctions tests [extensions/ParserFunctions] - 10https://gerrit.wikimedia.org/r/113945 [14:11:03] (03CR) 10Manybubbles: [C: 04-1] "Doesn't work with 0.90.10 which is in production. One way to handle this particular funkiness is to wrap all of our getSettings calls wit" [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/112940 (owner: 10Chad) [14:13:00] hashar: looks good ? [14:13:08] (03CR) 10Hashar: [C: 032] "Excellent work! Thank you very much!" [extensions/ParserFunctions] - 10https://gerrit.wikimedia.org/r/113945 (owner: 1001tonythomas) [14:13:12] tonythomas01: merging :-] [14:13:14] (03Merged) 10jenkins-bot: Added the $wgPFEnableStringFunctions = true in ParserFunctions tests [extensions/ParserFunctions] - 10https://gerrit.wikimedia.org/r/113945 (owner: 1001tonythomas) [14:13:18] well jenkins does for us [14:13:20] hashar: welcome ;) [14:13:27] now we can rebase all changes [14:13:33] ie https://gerrit.wikimedia.org/r/113518 [14:13:36] which is failing in Jenkins [14:13:58] (03PS2) 10Brian Wolff: Decode html entities before comparing strings in #ifeq: and #switch [extensions/ParserFunctions] - 10https://gerrit.wikimedia.org/r/113518 [14:14:06] ok:) I am out for dinner [14:14:26] tonythomas01: thank you! [14:15:53] (03CR) 10Hashar: [C: 04-1] "Jenkins bug has been fixed by Tony, had to enable a global setting when the tests are run on Jenkins." [extensions/ParserFunctions] - 10https://gerrit.wikimedia.org/r/113518 (owner: 10Brian Wolff) [14:16:54] !gerrit 112029 [14:35:51] (03PS2) 10Manybubbles: Make failure messages less spammy [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/113469 (owner: 10Chad) [14:36:44] (03CR) 10Manybubbles: [C: 032] "Made a minor fix, manually caused update failures and verified that they worked. Code reviewed everything else." [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/113469 (owner: 10Chad) [14:36:49] (03Merged) 10jenkins-bot: Make failure messages less spammy [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/113469 (owner: 10Chad) [14:39:41] (03CR) 10Manybubbles: [C: 032] Move decode results portion of findUpdates() to its own method [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/113468 (owner: 10Chad) [14:39:47] (03Merged) 10jenkins-bot: Move decode results portion of findUpdates() to its own method [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/113468 (owner: 10Chad) [14:42:06] (03CR) 10Bartosz Dziewoński: [C: 04-1] "Superseded by https://gerrit.wikimedia.org/r/#/c/113918/ ?" [core] - 10https://gerrit.wikimedia.org/r/113902 (owner: 10Brian Wolff) [14:46:39] (03PS2) 10Bartosz Dziewoński: Parse {{int:...}} in editwarning [core] - 10https://gerrit.wikimedia.org/r/113918 (owner: 10Gerrit Patch Uploader) [14:48:43] (03PS1) 10Hashar: Add json-lint.php command to -jslint jobs [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/113958 [14:49:14] (03CR) 10Hashar: "Timo : what is your thought ? :-]" [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/113958 (owner: 10Hashar) [14:52:22] mutante, can we run the February 10, 2014 - February 17, 2014 report again? [14:55:57] (03PS1) 10Yuvipanda: Show relative 'last modified at' at bottom of each page [core] - 10https://gerrit.wikimedia.org/r/113960 [14:57:11] (03CR) 10Bartosz Dziewoński: [C: 032] Parse {{int:...}} in editwarning [core] - 10https://gerrit.wikimedia.org/r/113918 (owner: 10Gerrit Patch Uploader) [14:58:12] (03CR) 10Yuvipanda: [C: 04-1] "This looks uncacheable for anons, and I suspect similar efforts to have relative timestamps elsewhere would have similar issues. Ugh." [core] - 10https://gerrit.wikimedia.org/r/113960 (owner: 10Yuvipanda) [14:58:48] ori: ^ I made this patch, then realized that it would be uncacheable to a point of not being able to do it this way at all. if you can confirm, I'll abandon it [15:00:43] (03Merged) 10jenkins-bot: Parse {{int:...}} in editwarning [core] - 10https://gerrit.wikimedia.org/r/113918 (owner: 10Gerrit Patch Uploader) [15:06:26] (03PS1) 10Aude: add check for $wgWikimediaJenkinsCI isset [extensions/ParserFunctions] - 10https://gerrit.wikimedia.org/r/113964 [15:06:35] would be awesome to have that reviewed ^ [15:06:43] causing annoying notice [15:06:51] * hoo looks [15:07:12] aude: Why so many brackets? [15:07:15] requires having that variable in my local settings [15:07:26] hoo: not required but don't hurt [15:07:51] (03CR) 10Hoo man: [C: 032] add check for $wgWikimediaJenkinsCI isset [extensions/ParserFunctions] - 10https://gerrit.wikimedia.org/r/113964 (owner: 10Aude) [15:07:56] (03Merged) 10jenkins-bot: add check for $wgWikimediaJenkinsCI isset [extensions/ParserFunctions] - 10https://gerrit.wikimedia.org/r/113964 (owner: 10Aude) [15:08:01] yay [15:08:06] (03PS1) 10UltrasonicNXT: Fix smileys [extensions/MediaWikiChat] - 10https://gerrit.wikimedia.org/r/113965 [15:08:07] aude: Ok, but don't introduce such into Wikibase :P [15:08:17] no! [15:08:23] (03Abandoned) 10Bartosz Dziewoński: Merge "Add ParserOutput::addJsConfigVars" [core] - 10https://gerrit.wikimedia.org/r/113950 (owner: 10Lekshmi) [15:08:56] (03PS4) 10Manybubbles: Don't search text wrapped in nosearch class [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/112500 [15:09:12] (03CR) 10UltrasonicNXT: [C: 032 V: 032] Fix smileys [extensions/MediaWikiChat] - 10https://gerrit.wikimedia.org/r/113965 (owner: 10UltrasonicNXT) [15:09:13] blablablablablaaaaaaa [15:09:19] brussels airport is so boring [15:09:29] hi werdna [15:10:59] <^d> werdna: Go around asking where their sprouts are in your most American-sounding accent. [15:11:06] <^d> Airport will become less boring. [15:11:07] hah [15:11:31] * aude wants to go to singapore http://www.brenontheroad.com/singapore-airport-a-disneyland-for-backpackers/ [15:11:41] (03CR) 10Manybubbles: "Any movement on whether or not this is a good idea?" [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/112500 (owner: 10Manybubbles) [15:11:41] sounds totally awesome [15:12:18] wow :) [15:12:25] (03CR) 10Chad: "I'm still on edge about it. Maybe we need an RFC?" [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/112500 (owner: 10Manybubbles) [15:12:39] MatmaRex: are you planning to go over the svg files from the upstream libs as well? [15:12:45] aude: I've got 1h30 in HKG [15:12:47] that's nice enough [15:12:50] and 3 h in Heathrow [15:12:54] ah, ok [15:12:58] but the clueless check in agent didn't tag my bags through [15:13:02] so I might need to clear immigration [15:13:06] aude: yup singapore is crazy [15:13:13] zurich is also nice (be sure to allow time for the observation deck) [15:13:19] aude: you can basically live in the aiarport [15:13:20] (03CR) 10Manybubbles: "You wanna start one?" [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/112500 (owner: 10Manybubbles) [15:13:24] :) [15:13:26] Nikerabbit: i might do that if you accept the fact that i won't submit them for each one separately :> [15:13:57] (03CR) 10Chad: [C: 04-2] "Yeah I'll gather some thoughts today and spam appropriate venues." [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/112500 (owner: 10Manybubbles) [15:14:33] MatmaRex: well, it's only two repos, but if you send the files I can submit them to the right place [15:14:52] * guillom waves at werdna, hashar, aude, MatmaRex and Nikerabbit. [15:14:59] Hello hello. [15:15:37] salut guillom :) [15:16:20] Now I want to go to Singapore, if only to see that airport. [15:16:48] werdna: Where are you flying to this time? [15:17:05] home [15:17:07] hooome [15:17:37] werdna: Does this concept still apply to you at all? [15:18:37] <^d> guillom: Home for werdna is 32k feet, right? [15:18:47] :D [15:19:16] Sydney! [15:19:19] Finally [15:19:23] and I'm staying put [15:19:25] until Wikimania [15:19:28] or so [15:19:45] no hackathon? [15:19:47] and of course just when I decided that, I met a Finnish girl [15:19:51] no, I won't be in Zürich [15:19:54] :( [15:19:56] * ^d either [15:20:01] * aude cries [15:20:11] * ^d cries a bit too [15:20:12] Nikerabbit: huh, is ime-active.svg the same image as input.svg? D: [15:20:19] Hi all. Can anyone tell me whether it's possible to make VisualEditor work with other skins besides the default one (Vector)? For now, I've heavily modified Vector as a workaround, but would like to know if there's a more long-term solution. [15:20:24] Me neither. I guess we'll meet in London then. [15:20:28] <^d> Ok. Tummy rumbling. Time for breakfast, etc. [15:21:34] lol, world_map.svg is 70K [15:21:55] danielxvu: does it not work out of the box? [15:22:25] MatmaRex: ask md5sum? :P [15:22:53] werdna: As of right now, VisualEditor only works with Vector and Monobook, I believe. [15:23:48] werdna: There is a hard-coded whitelist of supported skins that I've found, but simply adding a custom skin's name to the array doesn't work. [15:24:05] is there doc somewhere? [15:24:20] MatmaRex: I haven't checked, possibly [15:25:18] werdna: You mean a source that says only Vector is supported? If so, it says so on this page - http://www.mediawiki.org/wiki/VisualEditor [15:25:43] https://www.mediawiki.org/w/index.php?title=Manual:Hooks/ArticleAfterFetchContent&diff=cur&oldid=743115 [15:25:44] Hm [15:25:46] MatmaRex: looks same with different size [15:25:54] Pretty sure this is still called... [15:28:16] MatmaRex: and ime-inactive looks unused [15:29:12] (03PS1) 10Rillke: Typography [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/113971 [15:29:25] oh heh, i see why the world map svg is so big [15:29:37] it had thousands of tiny paths in it [15:29:43] like less than a pixel of area [15:30:26] MatmaRex: anticipating 2000 dpi displays ;) [15:30:47] danielxvu, it should support Vector, Monobook, and Apex. [15:33:21] Krenair: I'm aware of that... my organization is requiring me to develop a custom MediaWiki skin for their intranet however. It seemed easier to just modify the Vector skin instead of adding support for VisualEditor to a brand new skin. But this isn't really an ideal solution since the Vector skin will probably be updated again and again in the future, and I don't want to have to modify it each time there is a new version. [15:41:00] (03CR) 10Aklapper: "I'd like to have a broader discussion on this with more input, maybe in Bugzilla, potentially even on wikitech-l. If the custom "Vector" s" [wikimedia/bugzilla/modifications] - 10https://gerrit.wikimedia.org/r/106761 (owner: 1001tonythomas) [15:46:57] Nikerabbit: can i just zip the files and send them to you, and you handle the boring testing and committing part? [15:47:01] (03CR) 10Nikerabbit: "Ugh new context global?" [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/113796 (owner: 10Amire80) [15:50:33] (03CR) 10Chad: "I've been super careful about not using any of these global objects in my extensions. I feel dirty now." [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/113796 (owner: 10Amire80) [15:50:55] <^demon|breakfast> Nikerabbit: Ewwww. [15:51:45] Feeling dirty during breakfast is ok, you can still have a shower before going to the "office" [15:52:20] <^demon|breakfast> Nikerabbit: I'm not seeing an obvious method, but can't we get this from the $user? [15:52:37] MatmaRex: yeah.. [15:52:51] <^demon|breakfast> No, that'd be too obvious. [15:52:56] ^demon|breakfast: there is $user->getLanguage() which does not follow uselang=xx [15:53:07] sorry, $user->getOption( 'language' ) [15:53:53] <^demon|breakfast> bleh, that won't do [15:54:20] RequestContext::getMain()->getLanguage() ? [15:54:44] $lang = new Language( User->getOption( 'language ' ) ); [15:55:09] although you could run into an infinite loop if you call that in this hook [15:55:14] still won't follow uselang [15:55:18] ^demon|breakfast: then the two options are 1) extend the hook to provide context 2) implement post processing in core [15:55:40] or somehow use css to add the image [15:56:00] <^demon|breakfast> Or just revert the patch because it introduced unacceptable global usage and ask the author to re-submit :D [15:56:43] <^demon|breakfast> The beta stuff won't be around forever anyway. I plan to rip it out with a crowbar once it's default everywhere. [15:56:50] thanks for finding that duplicate bug for cs.wiki, andre__! [15:56:52] <^demon|breakfast> It's funky and doesn't always work. [15:57:05] (03PS2) 10Nemo bis: Typography [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/113971 (owner: 10Rillke) [15:57:10] ragesoss, heh, I only realized while reading the discussion cs.wp :) [16:00:47] (03CR) 10M4tx: [C: 031] Typography [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/113971 (owner: 10Rillke) [16:01:31] (03CR) 10Yuvipanda: [C: 032] Typography [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/113971 (owner: 10Rillke) [16:01:40] (03Merged) 10jenkins-bot: Typography [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/113971 (owner: 10Rillke) [16:08:45] (03PS1) 10Aude: update wikidata extension branches [tools/release] - 10https://gerrit.wikimedia.org/r/113974 [16:10:47] (03PS2) 10Aklapper: Error message for invalid login changed. [wikimedia/bugzilla/modifications] - 10https://gerrit.wikimedia.org/r/106883 (owner: 10Tinaj1234) [16:12:57] qgil: Hi and welcome back :) I don't see a hangout link in the ECT meeting invite. Do you? [16:13:54] (03CR) 10Manybubbles: "Then replace it with reading the language from the context?" [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/113796 (owner: 10Amire80) [16:17:14] why can't i edit a Module page through the API test suite? [16:17:41] i get "The modification you tried to make was aborted by an extension hook" [16:17:57] ysangkok: Probably you placed invalid Lua [16:18:07] which makes Scribunto forbid you to edit AFAIR [16:18:17] ah yeah ok that makes sense [16:18:43] is it better if i test my extension though the API or though the native calls? [16:19:05] it seems simpler through the api... [16:19:36] Depends... the API tests are testing more (integration tests) [16:19:47] but are also less specific, of course [16:20:08] well i just want to save a page so i can test my Repo class [16:20:36] but i don't want to call directly into the repo, cause i want mediawiki to generate thumbnails from the images in the repo and save them [16:21:09] Not sure what you're talking about (what repo?) [16:21:49] (03PS1) 10Chad: RequestContext is better than $wgLang. Slightly [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/113975 [16:21:57] hoo: i'm making a class that derives from FileRepo [16:22:22] uh... haven't yet worked with that [16:22:25] hoo: https://gerrit.wikimedia.org/r/#/c/113759/ [16:22:43] making images with lua. so crazy, it just might work, heh [16:23:25] :P [16:23:25] uh, oh... what's that good for...? [16:24:03] well, it would make it possible to move stuff like EasyTimeline to user space instead of extensions [16:25:48] i wonder if we have a bug open to reimplement easytimeline… [16:26:37] ysangkok: mh... is it possible (or planned) to be able to pass parameters into it? [16:26:44] ha, we sort of do. https://bugzilla.wikimedia.org/show_bug.cgi?id=27156 [16:27:05] eg. for getting localized stuff or so [16:28:04] hoo: i considered that, but where would they be? in the title? I think it's bad enough that the extension is going in there... why not just make multiple localized modules that call into the same lib? [16:28:05] (03CR) 10Hashar: "gwicke wrote:" [services/mathoid] - 10https://gerrit.wikimedia.org/r/113349 (owner: 10Hashar) [16:28:18] hmm [16:28:35] we support setting language via [[file:whatever.svg|lang=de]] [16:28:41] (or something very much like that) [16:28:58] and we have some SVG files with translations on commons, i believe [16:29:00] (03CR) 10Hashar: "So essentially, this change let us have source and debian in the same branch (master), and you don't have to split the debian directory el" [services/mathoid] - 10https://gerrit.wikimedia.org/r/113349 (owner: 10Hashar) [16:29:02] (03CR) 10GWicke: "I read a bit more on git-buildpackage on the weekend, and it seems that it can do automatic version increments, tagging and changelog gene" [services/mathoid] - 10https://gerrit.wikimedia.org/r/113349 (owner: 10Hashar) [16:30:57] hmm i didn't know about that [16:31:33] but anything that works for svg's should work for modules-as-images too [16:32:18] can't seem to find any docs on this particular feature... [16:35:48] (03PS2) 10Umherirrender: Add CURRENTDAY1/LOCALDAY1 aliases for CURRENTDAY/LOCALDAY [core] - 10https://gerrit.wikimedia.org/r/110705 [16:37:24] MatmaRex: help me out? docs on "|lang=de"? [16:37:37] (03CR) 10Aklapper: "After our upgrade to 4.4 and deleting the custom file, I needed to 1) copy http://bzr.mozilla.org/bugzilla/4.4/view/head:/template/en/defa" [wikimedia/bugzilla/modifications] - 10https://gerrit.wikimedia.org/r/106883 (owner: 10Tinaj1234) [16:37:40] (03PS1) 10UltrasonicNXT: Sanity check [extensions/MediaWikiChat] - 10https://gerrit.wikimedia.org/r/113977 [16:38:03] (03CR) 10UltrasonicNXT: [C: 032 V: 032] Sanity check [extensions/MediaWikiChat] - 10https://gerrit.wikimedia.org/r/113977 (owner: 10UltrasonicNXT) [16:38:43] ysangkok: docs? heh [16:38:48] could be tough [16:40:49] (03PS6) 10Hashar: git-buildpckage configuration [services/mathoid] - 10https://gerrit.wikimedia.org/r/113349 [16:40:58] (03CR) 10GWicke: [C: 031] git-buildpckage configuration [services/mathoid] - 10https://gerrit.wikimedia.org/r/113349 (owner: 10Hashar) [16:42:31] ysangkok: here's the commit that added the feature: https://gerrit.wikimedia.org/r/#/c/25838/ [16:42:57] and example file: https://commons.wikimedia.org/wiki/File:Gerrit_patchset_25838_test.svg [16:43:27] ah thanks [16:49:03] well that is a great feature, even seems standards compliant. i'm testing it with modules-as-images as we speak [16:50:23] (03PS1) 10UltrasonicNXT: Unescape after DB [extensions/MediaWikiChat] - 10https://gerrit.wikimedia.org/r/113981 [16:50:39] (03CR) 10UltrasonicNXT: [C: 032 V: 032] Unescape after DB [extensions/MediaWikiChat] - 10https://gerrit.wikimedia.org/r/113981 (owner: 10UltrasonicNXT) [16:52:40] (03CR) 10Anomie: [C: 04-1] Rewriting ContactPage to use HTMLForm (0312 comments) [extensions/ContactPage] - 10https://gerrit.wikimedia.org/r/113879 (owner: 10Reedy) [16:53:05] (03CR) 10GWicke: "I'm not a huge fan of checking in node_modules directly. In this case all dependencies are pure JS, which might make this a viable option " [services/mathoid] - 10https://gerrit.wikimedia.org/r/113025 (owner: 10Physikerwelt) [16:53:18] (03CR) 10Helder.wiki: "The deprecated code is working. My point is that the non-deprecated hook is not working, and as such it should be either fixed (e.g. as in" [core] - 10https://gerrit.wikimedia.org/r/110347 (owner: 10Helder.wiki) [16:55:27] it already works! [16:55:30] hoo: there you go :P [17:03:48] (03CR) 10Anomie: [C: 031] "Code seems ok, although I wonder why this isn't part of I79eeb244." (031 comment) [extensions/ContactPage] - 10https://gerrit.wikimedia.org/r/113892 (owner: 10Reedy) [17:06:23] (03PS1) 10Aude: Fix compatibility of ApiTestCaseVideoUpload with ApiTestCase [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/113985 [17:06:32] (03PS1) 10UltrasonicNXT: Fix a horrible nbsp shinnanigan [extensions/MediaWikiChat] - 10https://gerrit.wikimedia.org/r/113986 [17:06:47] (03CR) 10UltrasonicNXT: [C: 032 V: 032] Fix a horrible nbsp shinnanigan [extensions/MediaWikiChat] - 10https://gerrit.wikimedia.org/r/113986 (owner: 10UltrasonicNXT) [17:11:13] (03CR) 10Physikerwelt: "It should not depend on npm 1.3 I removed that dependency." [services/mathoid] - 10https://gerrit.wikimedia.org/r/113349 (owner: 10Hashar) [17:19:44] (03CR) 10Anomie: Rewriting ContactPage to use HTMLForm (031 comment) [extensions/ContactPage] - 10https://gerrit.wikimedia.org/r/113879 (owner: 10Reedy) [17:25:07] (03CR) 10Isarra: "Unless there's anything else that needs to be addressed, could someone maybe please merge this?" [core] - 10https://gerrit.wikimedia.org/r/110908 (owner: 10Isarra) [17:28:04] (03PS1) 10Isarra: Fixed description, and some css fixes [skins/GreyStuff] - 10https://gerrit.wikimedia.org/r/113987 [17:29:12] (03PS1) 10EBernhardson: Repoint bundle install cwd [vagrant] - 10https://gerrit.wikimedia.org/r/113988 [17:29:18] (03CR) 10Isarra: "Wait, what? IE6? o__O" [skins/GreyStuff] - 10https://gerrit.wikimedia.org/r/113987 (owner: 10Isarra) [17:30:12] (03CR) 10Ori.livneh: [C: 032] "Thanks!" [vagrant] - 10https://gerrit.wikimedia.org/r/113988 (owner: 10EBernhardson) [17:30:16] (03Merged) 10jenkins-bot: Repoint bundle install cwd [vagrant] - 10https://gerrit.wikimedia.org/r/113988 (owner: 10EBernhardson) [17:36:10] (03CR) 10Anomie: WIP: Allow inclusion of additional fields (036 comments) [extensions/ContactPage] - 10https://gerrit.wikimedia.org/r/113883 (owner: 10Reedy) [17:36:22] is there any known timeframe for dropping support for PHP 5.3.2? [17:36:33] leaving 5.4 as the minimum [17:36:54] <^d> Hmm. [17:37:20] <^d> Too many distros probably still shipping 5.3 by default :\ [17:37:28] * prtksxna pesters ori  [17:37:30] <^d> Current Ubuntu LTS does. [17:37:33] * prtksxna goes to sleep [17:37:55] * YuviPanda wonders about next LTS [17:38:08] <^d> Hmm, I wonder what's in 14.04 [17:38:12] (03PS2) 10Isarra: Fixed description, and some css fixes [skins/GreyStuff] - 10https://gerrit.wikimedia.org/r/113987 [17:38:16] <^d> 5.5.something would be nice. [17:38:22] <^d> 5.4.something would be acceptable. [17:40:16] <^d> Looks like it'll be 5.5.8 [17:40:22] <^d> TrevorParscal: Float the idea on wikitech-l? I wouldn't mind bumping it myself, but it'll be hard to do so before April at the earliest (when new Ubuntu LTS comes out) [17:42:26] hmm, march 2013 php 5.3 went security fixes only, if they follow their stated plan 5.3 should be EOL next month then? [17:42:47] ^d: I will [17:43:14] (03CR) 10Jack Phoenix: [C: 032 V: 032] "I liked the old description more, though. ;-)" [skins/GreyStuff] - 10https://gerrit.wikimedia.org/r/113987 (owner: 10Isarra) [17:45:01] legoktm: Wishful thinking that you're watching https://bugzilla.wikimedia.org/show_bug.cgi?id=60748 [17:51:05] (03CR) 10Hoo man: [C: 032] "Trivial one :)" [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/113985 (owner: 10Aude) [17:51:08] (03Merged) 10jenkins-bot: Fix compatibility of ApiTestCaseVideoUpload with ApiTestCase [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/113985 (owner: 10Aude) [17:53:59] (03PS5) 10EBernhardson: Anonymous editor warning [extensions/Flow] - 10https://gerrit.wikimedia.org/r/109445 (owner: 10Werdna) [17:54:24] (03CR) 10EBernhardson: [C: 032] "PS5: rebase" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/109445 (owner: 10Werdna) [17:54:34] (03Merged) 10jenkins-bot: Anonymous editor warning [extensions/Flow] - 10https://gerrit.wikimedia.org/r/109445 (owner: 10Werdna) [17:57:23] (03CR) 10EBernhardson: [C: 031] "looks good, need o run it through some tests still" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/112917 (owner: 10Matthias Mullie) [18:10:10] (03CR) 10Matthias Mullie: [C: 032] Prefer instanceof over is_a [extensions/Flow] - 10https://gerrit.wikimedia.org/r/113635 (owner: 10EBernhardson) [18:10:39] (03CR) 10Matthias Mullie: [C: 032] couple spelling errors [extensions/Flow] - 10https://gerrit.wikimedia.org/r/113634 (owner: 10EBernhardson) [18:14:02] (03CR) 10Matthias Mullie: [C: 032] Cleanup unused local variables [extensions/Flow] - 10https://gerrit.wikimedia.org/r/113628 (owner: 10EBernhardson) [18:14:12] (03PS1) 10UltrasonicNXT: Fix smileys in links [extensions/MediaWikiChat] - 10https://gerrit.wikimedia.org/r/113995 [18:14:16] (03Merged) 10jenkins-bot: Cleanup unused local variables [extensions/Flow] - 10https://gerrit.wikimedia.org/r/113628 (owner: 10EBernhardson) [18:14:36] (03CR) 10UltrasonicNXT: [C: 032 V: 032] Fix smileys in links [extensions/MediaWikiChat] - 10https://gerrit.wikimedia.org/r/113995 (owner: 10UltrasonicNXT) [18:17:45] (03PS1) 10BryanDavis: Remove external script dependencies from sync_common [tools/scap] - 10https://gerrit.wikimedia.org/r/113996 [18:19:29] and now for a psa: you can fix wrong php.net documentation at https://edit.php.net/ [18:20:05] :) [18:20:18] They're going to hate me very soon. [18:21:26] (03PS2) 10BryanDavis: Remove external script dependencies from sync_common [tools/scap] - 10https://gerrit.wikimedia.org/r/113996 [18:22:31] (03CR) 10Mattflaschen: [C: 032] "Looks good, works locally." [extensions/GettingStarted] - 10https://gerrit.wikimedia.org/r/113459 (owner: 10Phuedx) [18:22:34] (03Merged) 10jenkins-bot: Convert CSS to LESS [extensions/GettingStarted] - 10https://gerrit.wikimedia.org/r/113459 (owner: 10Phuedx) [18:23:47] (03CR) 10Bartosz Dziewoński: "Yeah, but I think that doesn't touch the prolog at all, and it seems desirable to "canonicalize" it." [core] - 10https://gerrit.wikimedia.org/r/106506 (owner: 10Bartosz Dziewoński) [18:25:00] (03PS1) 10Gerrit Patch Uploader: Support for /me command [extensions/MediaWikiChat] - 10https://gerrit.wikimedia.org/r/113998 [18:25:02] (03CR) 10Gerrit Patch Uploader: "This commit was uploaded using the Gerrit Patch Uploader [1]." [extensions/MediaWikiChat] - 10https://gerrit.wikimedia.org/r/113998 (owner: 10Gerrit Patch Uploader) [18:27:50] (03CR) 10Krinkle: Return jqXHR from mw.Api calls (031 comment) [core] - 10https://gerrit.wikimedia.org/r/111704 (owner: 10Gergő Tisza) [18:30:02] ^d: is it just me, or are gerrit fetches getting slower and slower every day? [18:30:18] hmm, it did seem uncharacteristically slow today [18:30:20] ^d: does the gc cron run? :P [18:30:28] <^d> who knows. [18:30:43] you can probably find out i suppose [18:31:25] (03CR) 1001tonythomas: [C: 04-1] "Whitespace issues" (032 comments) [extensions/MediaWikiChat] - 10https://gerrit.wikimedia.org/r/113998 (owner: 10Gerrit Patch Uploader) [18:34:02] Krinkle: what do you think about using {jQuery.Promise} to document promise return types formally? [18:34:39] (03CR) 1001tonythomas: [C: 031] Changed deprecated $wgCopyrightIcon [core] - 10https://gerrit.wikimedia.org/r/109903 (owner: 10Lekshmi) [18:34:54] i have been doing that for MultimediaViewer for a while, makes the documentation a lot more readable IMO [18:35:49] tgr: Can you give a more specific example? Might not be obvious that way as it looks like made-up syntax [18:36:05] tgr: You always forget the period between "Promise" and "<" though :) [18:36:13] in terms of production logging, do wfDebugLog calls go anywhere? I know on test and test2 they are logged, but for everything else [18:36:45] rdwrer: Also, description above @class in external.js and likely other places as well ( https://doc.wikimedia.org/MultimediaViewer/master/source/external.html ) [18:36:58] Krinkle: Bah, complications [18:37:10] I'll make big fix patches and break everything, it'll be great [18:37:12] (03PS4) 10Bartosz Dziewoński: Optimize all SVGs (attempt 2) [core] - 10https://gerrit.wikimedia.org/r/106506 [18:37:38] ebernhardson: maybe logstash? ask bd808 [18:38:15] rdwrer: https://doc.wikimedia.org/MultimediaViewer/master/source/mmv.ui.fileReuse.html#FileReuse-method-openDialog [18:38:19] rdwrer: There as well [18:38:19] (03PS5) 10Chad: Removed deprecated $wgDisabledActions [core] - 10https://gerrit.wikimedia.org/r/109891 (owner: 10Tinaj1234) [18:38:31] Yes yes yes [18:38:34] (03CR) 10Chad: [C: 032] Removed deprecated $wgDisabledActions [core] - 10https://gerrit.wikimedia.org/r/109891 (owner: 10Tinaj1234) [18:38:36] rdwrer: /**
@
@( more tags ) [18:38:41] k, cool :) [18:38:43] for the mw.Api call you commented on, that would be {jQuery.Promise.} (thanks rdwrer) [18:38:45] Krinkle: Calm y'self, I'll do a consistency update at some point [18:38:59] I AM CALM!!! [18:39:01] :P [18:39:24] ebernhardson: wfDebugLog messages in prod end up in /a/mw-log on fluorine and in logstash [18:39:29] tgr: In @return? [18:39:44] yes [18:39:45] (03CR) 10Bartosz Dziewoński: [C: 04-1] "Merely rebased." [core] - 10https://gerrit.wikimedia.org/r/106506 (owner: 10Bartosz Dziewoński) [18:39:46] Then how would we indicate the done() signature? [18:39:59] that is the done signature [18:40:14] (Object, jqXHR) I mean [18:42:21] (03Merged) 10jenkins-bot: Removed deprecated $wgDisabledActions [core] - 10https://gerrit.wikimedia.org/r/109891 (owner: 10Tinaj1234) [18:43:27] (03CR) 10Aaron Schulz: Password Expiration (031 comment) [core] - 10https://gerrit.wikimedia.org/r/92037 (owner: 10CSteipp) [18:43:46] (03CR) 10Jhall: [C: 031] Moved tests from browsertests repository [extensions/WikiLove] - 10https://gerrit.wikimedia.org/r/113104 (owner: 10Zfilipin) [18:47:02] bd808: i'm looking through that, but i'm not seeing expected data. Reviwing the code involved, perhaps we only send groups in wgDebugLogGroups to fluorine ? [18:48:13] (03CR) 10Daniel Friesen: [C: 04-1] Add Normalize.css as an available resource. [core] - 10https://gerrit.wikimedia.org/r/110908 (owner: 10Isarra) [18:48:53] ebernhardson: Oh yes. The group must be in $wgDebugLogGroups to end up being sent to the log aggregators. [18:49:11] (03CR) 10Brian Wolff: "Do we still have to worry about register globals for things like this?" [extensions/ParserFunctions] - 10https://gerrit.wikimedia.org/r/113964 (owner: 10Aude) [18:49:35] rdwrer: did you see my comments on that page? I don't think we can do that with PHP in most pages without killing cacheability for anons [18:50:07] (03CR) 10Aaron Schulz: [C: 04-1] "I get:" [core] - 10https://gerrit.wikimedia.org/r/92037 (owner: 10CSteipp) [18:50:11] tgr: I think the commit in quesiton changed the error signature, but OK, then where do the error arguments go? [18:50:44] not unless I messed something up [18:51:38] the error arguments still wouldn't be show, but 99% of the time you don't care about them, so it's not that bad [18:52:15] ideally, there should be a convention that all deferred rejects have a similar signature [18:52:44] an error string, or a custom MediaWiki error class, or something like that [18:53:17] rejections are passed up the deferred chain when you use .then() and similar, so it is impossible to keep track otherwise [18:53:28] YuviPanda: Can we not solve that the same way we deal with caching of existing i18n? [18:53:56] rdwrer: no, because it will change with time? [18:54:05] rdwrer: if I have something saying '5 days ago', I will need to invalidate it tomorrow [18:54:08] Ohhhh. [18:54:10] rdwrer: if it says '5 hours ago' then next hour [18:54:47] rdwrer: yeaaah [18:55:55] (03PS1) 10Gergő Tisza: Fix jsdoc for I49977b5f9d155cc7332377c906a31f5689bec8b4 [core] - 10https://gerrit.wikimedia.org/r/114002 [18:55:58] (03PS10) 10EBernhardson: Tests for PostCollection [extensions/Flow] - 10https://gerrit.wikimedia.org/r/112797 (owner: 10Matthias Mullie) [18:56:00] Krinkle: so it would look like ^^ [18:56:18] (03CR) 10EBernhardson: [C: 032] "PS10: removed unnecessary defined('MW_UNIT_TEST') calls" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/112797 (owner: 10Matthias Mullie) [18:57:05] (03Merged) 10jenkins-bot: Tests for PostCollection [extensions/Flow] - 10https://gerrit.wikimedia.org/r/112797 (owner: 10Matthias Mullie) [19:02:33] (03CR) 10Matthias Mullie: [C: 04-1] Use consistent return type (033 comments) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/113633 (owner: 10EBernhardson) [19:04:18] YuviPanda: Replied [19:06:28] (03CR) 10Matthias Mullie: [C: 032] Remove unused class aliases [extensions/Flow] - 10https://gerrit.wikimedia.org/r/113629 (owner: 10EBernhardson) [19:06:44] (03Merged) 10jenkins-bot: Remove unused class aliases [extensions/Flow] - 10https://gerrit.wikimedia.org/r/113629 (owner: 10EBernhardson) [19:07:15] (03Abandoned) 10Brian Wolff: Revert "Transclude translation for preference edit section to ensure consistency of translation" [core] - 10https://gerrit.wikimedia.org/r/113902 (owner: 10Brian Wolff) [19:11:26] rdwrer: the default anon html cache is 30days, so even if we do it *per* day, it'll be a 30x increase in invalidations [19:11:36] rdwrer: will probably bring you ori's wrath :D [19:11:44] rdwrer: saw the JS based solution I suggested? [19:14:09] Ugh. [19:14:24] YuviPanda: I didn't see, will look [19:14:33] rdwrer: ok. [19:15:02] Hm, I like it. [19:15:21] rdwrer: there would be a 'flash' as content changes, because the content of the messages would be different [19:15:47] YuviPanda: We could hide the timestamps in js-enabled clients, do the replacement, then add a class (or remove a class) that shows the element [19:16:15] rdwrer: then you'll have empty space that suddenly has text in it, and if the JS loads slowly you'll have sometimes critical info missing (in history page, for example) [19:16:37] rdwrer: former will also trigger relayouts, because we don't know the size of the text beforehand [19:16:51] Hrm. [19:17:50] rdwrer: we could do this with ESI nicely, except we don't have ESI support anywhere [19:17:57] (03CR) 10Aaron Schulz: "Oh, the release notes should mention the schema change too" [core] - 10https://gerrit.wikimedia.org/r/92037 (owner: 10CSteipp) [19:18:25] Yeah. [19:18:26] (03PS3) 10EBernhardson: Use consistent return type [extensions/Flow] - 10https://gerrit.wikimedia.org/r/113633 [19:18:46] YuviPanda: Do I feel a "We need HTML templating, man" coming on? [19:19:05] rdwrer: we do, but HTML templating won't solve this problem :) [19:19:16] chrismcmalunch , greg-g: regarding https://gerrit.wikimedia.org/r/#/c/113311/ (qa_automation group for Flow tests on test2wiki), I guess QA needs a lightning deploy in which the change is deployed and then someone with admin rights on test2wiki does some setup, then test. If Flow's deploy today goes well we could do it then [19:19:40] YuviPanda: Guess not, though I see a vector towards it there [19:19:56] rdwrer: I looked around, and a lot of folks suggest the JS based solution http://signalvnoise.com/posts/1557-javascript-makes-relative-times-compatible-with-caching [19:20:30] rdwrer: most problems in life can be solved by reducing the amount of PHP involved, and producing HTML is no exception :) [19:21:37] And how. [19:23:16] rdwrer: responded on the bug. [19:23:26] rdwrer: with the JS solution we can also update the times as time goes on [19:25:01] Ooh, pretty. :) [19:25:31] rdwrer: yeah, and we can do it rather efficiently too! Just update the ones that are hours, minutes, or seconds! And we can even schedule them appropriately to be as efficient as possible [19:25:47] YuviPanda: Why not the ones that are days? [19:25:57] rdwrer: we could schedule them a day later, yes. [19:26:02] setTimeout() should work with days too [19:26:05] true. [19:26:08] well, sure [19:26:17] we could do those. should be rather efficient [19:27:25] Wouldn't even need jQuery IMO, should be able to load it topside [19:27:28] rdwrer: I'll happily write the code, but since this is going to be delivered on every page load, might potentially be top loaded, and also modifies the DOM after load in place, I want a +1 from ori before going on [19:27:34] rdwrer: oooh, yes. should be. [19:27:44] rdwrer: we don't top load jQuery? [19:27:45] Sounds right to me [19:27:46] I can help :) [19:27:53] rdwrer: \o/ [19:28:24] rdwrer: so it'll add a class + a data attribute serverside, and then have JS that looks for those and 'does the needful' [19:28:51] (03Abandoned) 10Yuvipanda: Show relative 'last modified at' at bottom of each page [core] - 10https://gerrit.wikimedia.org/r/113960 (owner: 10Yuvipanda) [19:29:28] YuviPanda: "yes" but I'm not sure whether top-loaded things will race-condition [19:29:44] (03CR) 10Umherirrender: "Patch Set 6: Rebased (included now the new summary message on the special page)" [core] - 10https://gerrit.wikimedia.org/r/98252 (owner: 10Umherirrender) [19:29:50] rdwrer: hmm? [19:29:53] YuviPanda: Bonus points for getting a method named doTheNeedful past Krinkle. [19:29:53] rdwrer: is that about jQuery? [19:29:55] or? [19:30:03] No, just...it would be fun [19:30:04] Anyway [19:30:20] YuviPanda: That sounds about right to me, yes [19:30:23] rdwrer: we could call the class 'timeNeedful' and then it would be appropriate [19:30:33] No [19:30:35] TimeNeedful [19:31:34] heh :D [19:31:38] time-needful [19:32:31] (03CR) 10Matthias Mullie: [C: 032] Cleanup potential bad method calls [extensions/Flow] - 10https://gerrit.wikimedia.org/r/113630 (owner: 10EBernhardson) [19:33:10] (03PS1) 10Aaron Schulz: Added some profiling calls to Swift backend [core] - 10https://gerrit.wikimedia.org/r/114006 [19:35:38] rdwrer: summarized the discussion on bz [19:36:23] q'kay thanks [19:36:37] rdwrer: and re: CLDR, that is what my patch used :) [19:37:20] rdwrer: MMV works fine with core's momentjs now? [19:38:41] Seems to [19:38:44] The tests passed, e.g. [19:39:33] rdwrer: woo ok [19:40:25] YuviPanda: i tested with the version that was committed initially, and that worked fine [19:40:27] (03CR) 10Krinkle: Fix jsdoc for I49977b5f9d155cc7332377c906a31f5689bec8b4 (031 comment) [core] - 10https://gerrit.wikimedia.org/r/114002 (owner: 10Gergő Tisza) [19:40:45] tgr: hmm, should test with current version too, I guess. it was a jump from 2.4 - 2.5.1 [19:41:43] well, date logic is run when the lightbox opens, so if it breaks, we'll notice soon enough [19:42:18] That's good news I guess [19:42:57] tgr: ok :) [19:44:00] (03PS1) 10Aaron Schulz: Actually write-back the container cache in SwiftFileBackend [core] (wmf/1.23wmf14) - 10https://gerrit.wikimedia.org/r/114010 [19:44:06] (03CR) 10Aaron Schulz: [C: 032] Actually write-back the container cache in SwiftFileBackend [core] (wmf/1.23wmf14) - 10https://gerrit.wikimedia.org/r/114010 (owner: 10Aaron Schulz) [19:44:52] (03PS2) 10Gergő Tisza: Fix jsduck docstring for mw.Api ajax() [core] - 10https://gerrit.wikimedia.org/r/114002 [19:45:48] (03CR) 10Reedy: Rewriting ContactPage to use HTMLForm (031 comment) [extensions/ContactPage] - 10https://gerrit.wikimedia.org/r/113879 (owner: 10Reedy) [19:46:15] spagewmf: if chrismcmalunch agrees, yeah, that should be fine [19:46:21] (sorry, was in meeting) [19:46:38] greg-g np, I added to Deployments page [19:47:53] (03PS1) 10EBernhardson: Add code to prevent exception for new db columns [extensions/Flow] (wmf/1.23wmf13) - 10https://gerrit.wikimedia.org/r/114021 [19:48:05] (03PS1) 10EBernhardson: Add code to prevent exception for new db columns [extensions/Flow] (wmf/1.23wmf14) - 10https://gerrit.wikimedia.org/r/114025 [19:49:25] (03Merged) 10jenkins-bot: Actually write-back the container cache in SwiftFileBackend [core] (wmf/1.23wmf14) - 10https://gerrit.wikimedia.org/r/114010 (owner: 10Aaron Schulz) [19:50:44] (03PS1) 10EBernhardson: Fix topic preview [extensions/Flow] (wmf/1.23wmf14) - 10https://gerrit.wikimedia.org/r/114049 [19:52:14] (03PS1) 10EBernhardson: Associative array should not be accessed by numeric index [extensions/Flow] (wmf/1.23wmf14) - 10https://gerrit.wikimedia.org/r/114050 [19:53:14] (03PS1) 10EBernhardson: Flow watchlist data tweaks [extensions/Flow] (wmf/1.23wmf14) - 10https://gerrit.wikimedia.org/r/114051 [19:54:03] (03PS1) 10EBernhardson: Gracefully handle empty pagination result [extensions/Flow] (wmf/1.23wmf14) - 10https://gerrit.wikimedia.org/r/114052 [19:56:06] (03Abandoned) 10Raimond Spekking: Localisation updates from https://translatewiki.net. [extensions/DataTransfer] - 10https://gerrit.wikimedia.org/r/114046 (owner: 10L10n-bot) [19:56:13] (03Abandoned) 10Raimond Spekking: Localisation updates from https://translatewiki.net. [extensions/CreateRedirect] - 10https://gerrit.wikimedia.org/r/114045 (owner: 10L10n-bot) [19:56:23] (03Abandoned) 10Raimond Spekking: Localisation updates from https://translatewiki.net. [extensions/ConfirmEdit] - 10https://gerrit.wikimedia.org/r/114036 (owner: 10L10n-bot) [19:56:31] (03Abandoned) 10Raimond Spekking: Localisation updates from https://translatewiki.net. [extensions/DeleteBatch] - 10https://gerrit.wikimedia.org/r/114047 (owner: 10L10n-bot) [19:56:43] (03CR) 10Raimond Spekking: [C: 032] Localisation updates from https://translatewiki.net. [core] - 10https://gerrit.wikimedia.org/r/114008 (owner: 10L10n-bot) [19:57:42] (03Abandoned) 10Raimond Spekking: Localisation updates from https://translatewiki.net. [extensions/AdminLinks] - 10https://gerrit.wikimedia.org/r/114011 (owner: 10L10n-bot) [19:57:53] (03Abandoned) 10Raimond Spekking: Localisation updates from https://translatewiki.net. [extensions/ApprovedRevs] - 10https://gerrit.wikimedia.org/r/114016 (owner: 10L10n-bot) [19:57:59] (03Abandoned) 10Raimond Spekking: Localisation updates from https://translatewiki.net. [extensions/ArticleFeedbackv5] - 10https://gerrit.wikimedia.org/r/114017 (owner: 10L10n-bot) [19:58:14] (03Abandoned) 10Raimond Spekking: Localisation updates from https://translatewiki.net. [extensions/BatchUserRights] - 10https://gerrit.wikimedia.org/r/114019 (owner: 10L10n-bot) [19:58:35] (03Abandoned) 10Raimond Spekking: Localisation updates from https://translatewiki.net. [extensions/ApiExplorer] - 10https://gerrit.wikimedia.org/r/114014 (owner: 10L10n-bot) [19:58:42] (03Abandoned) 10Raimond Spekking: Localisation updates from https://translatewiki.net. [extensions/APC] - 10https://gerrit.wikimedia.org/r/114013 (owner: 10L10n-bot) [20:00:27] (03Merged) 10jenkins-bot: Localisation updates from https://translatewiki.net. [core] - 10https://gerrit.wikimedia.org/r/114008 (owner: 10L10n-bot) [20:00:32] (03Abandoned) 10Raimond Spekking: Localisation updates from https://translatewiki.net. [extensions/Contributors] - 10https://gerrit.wikimedia.org/r/114042 (owner: 10L10n-bot) [20:01:03] (03Abandoned) 10Raimond Spekking: Localisation updates from https://translatewiki.net. [extensions/ContactPage] - 10https://gerrit.wikimedia.org/r/114037 (owner: 10L10n-bot) [20:01:11] (03Abandoned) 10Raimond Spekking: Localisation updates from https://translatewiki.net. [extensions/Configure] - 10https://gerrit.wikimedia.org/r/114035 (owner: 10L10n-bot) [20:01:16] (03Abandoned) 10Raimond Spekking: Localisation updates from https://translatewiki.net. [extensions/CommunityVoice] - 10https://gerrit.wikimedia.org/r/114034 (owner: 10L10n-bot) [20:01:30] (03Abandoned) 10Raimond Spekking: Localisation updates from https://translatewiki.net. [extensions/Collection] - 10https://gerrit.wikimedia.org/r/114033 (owner: 10L10n-bot) [20:01:38] (03Abandoned) 10Raimond Spekking: Localisation updates from https://translatewiki.net. [extensions/CodeReview] - 10https://gerrit.wikimedia.org/r/114032 (owner: 10L10n-bot) [20:01:45] (03Abandoned) 10Raimond Spekking: Localisation updates from https://translatewiki.net. [extensions/Convert2Wiki] - 10https://gerrit.wikimedia.org/r/114043 (owner: 10L10n-bot) [20:01:50] (03Abandoned) 10Raimond Spekking: Localisation updates from https://translatewiki.net. [extensions/CreatePage] - 10https://gerrit.wikimedia.org/r/114044 (owner: 10L10n-bot) [20:02:34] (03Abandoned) 10Raimond Spekking: Localisation updates from https://translatewiki.net. [extensions/CheckUser] - 10https://gerrit.wikimedia.org/r/114028 (owner: 10L10n-bot) [20:02:52] (03Abandoned) 10Raimond Spekking: Localisation updates from https://translatewiki.net. [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/114026 (owner: 10L10n-bot) [20:03:02] (03Abandoned) 10Raimond Spekking: Localisation updates from https://translatewiki.net. [extensions/CategoryTree] - 10https://gerrit.wikimedia.org/r/114024 (owner: 10L10n-bot) [20:03:24] (03Abandoned) 10Raimond Spekking: Localisation updates from https://translatewiki.net. [extensions/Cite] - 10https://gerrit.wikimedia.org/r/114030 (owner: 10L10n-bot) [20:03:34] (03Abandoned) 10Raimond Spekking: Localisation updates from https://translatewiki.net. [extensions/CloseWikis] - 10https://gerrit.wikimedia.org/r/114031 (owner: 10L10n-bot) [20:03:42] (03Abandoned) 10Raimond Spekking: Localisation updates from https://translatewiki.net. [extensions/ContributionScores] - 10https://gerrit.wikimedia.org/r/114040 (owner: 10L10n-bot) [20:05:11] (03PS9) 10Bsitu: Add diff view of changes to board header [extensions/Flow] - 10https://gerrit.wikimedia.org/r/109431 [20:05:15] (03CR) 10jenkins-bot: [V: 04-1] Add diff view of changes to board header [extensions/Flow] - 10https://gerrit.wikimedia.org/r/109431 (owner: 10Bsitu) [20:05:26] (03Abandoned) 10Raimond Spekking: Localisation updates from https://translatewiki.net. [extensions/ApiSandbox] - 10https://gerrit.wikimedia.org/r/114015 (owner: 10L10n-bot) [20:06:58] sorry for flooding. finished now [20:10:30] (03PS10) 10Bsitu: Add diff view of changes to board header [extensions/Flow] - 10https://gerrit.wikimedia.org/r/109431 [20:10:33] (03CR) 10jenkins-bot: [V: 04-1] Add diff view of changes to board header [extensions/Flow] - 10https://gerrit.wikimedia.org/r/109431 (owner: 10Bsitu) [20:11:05] http://tools.wmflabs.org/styleguide/mobile/index.html is 403 Forbidden! "This URI is managed by the styleguide tool, maintained by Spage, Jdlrobson, and Mattflaschen." [20:11:13] is there a trick to running php_codecoverage on mediawiki? it seems just to hang even though i excluded a lot [20:15:57] (03PS1) 10BryanDavis: Add sphinx configuration [tools/scap] - 10https://gerrit.wikimedia.org/r/114060 [20:17:56] (03CR) 10Aaron Schulz: [C: 032] Call WikiPage::doViewUpdates also on missing article page view [core] - 10https://gerrit.wikimedia.org/r/108071 (owner: 10Umherirrender) [20:21:38] (03Merged) 10jenkins-bot: Call WikiPage::doViewUpdates also on missing article page view [core] - 10https://gerrit.wikimedia.org/r/108071 (owner: 10Umherirrender) [20:22:57] (03PS11) 10Bsitu: Add diff view of changes to board header [extensions/Flow] - 10https://gerrit.wikimedia.org/r/109431 [20:23:19] hmm i need processUncoveredFilesFromWhitelist="true" [20:24:42] (03PS5) 10BryanDavis: Add detailed duration timing [tools/scap] - 10https://gerrit.wikimedia.org/r/113652 [20:33:56] superm401: https://gerrit.wikimedia.org/r/#/c/104011/ is HTMLForm change and UserLogin change [20:34:39] (03PS12) 10Bsitu: Add diff view of changes to board header [extensions/Flow] - 10https://gerrit.wikimedia.org/r/109431 [20:35:03] (03CR) 10Bsitu: Add diff view of changes to board header [extensions/Flow] - 10https://gerrit.wikimedia.org/r/109431 (owner: 10Bsitu) [20:38:51] how do i get the html of the body of a FilePage? i tried WikiFilePage but it doesn't return anything when i do getContent. and i can't call loadData(), it's protected... [20:39:42] (03PS1) 10Anomie: HTMLForm: Allow i18n of 'options' [core] - 10https://gerrit.wikimedia.org/r/114066 [20:41:03] (03CR) 10jenkins-bot: [V: 04-1] HTMLForm: Allow i18n of 'options' [core] - 10https://gerrit.wikimedia.org/r/114066 (owner: 10Anomie) [20:56:50] jgonera: https://gerrit.wikimedia.org/r/#/c/104011/ [20:59:46] (03CR) 10EBernhardson: [C: 032] Add code to prevent exception for new db columns [extensions/Flow] (wmf/1.23wmf14) - 10https://gerrit.wikimedia.org/r/114025 (owner: 10EBernhardson) [20:59:49] (03PS2) 10Anomie: HTMLForm: Allow i18n of 'options' [core] - 10https://gerrit.wikimedia.org/r/114066 [20:59:58] (03CR) 10EBernhardson: [C: 032] Associative array should not be accessed by numeric index [extensions/Flow] (wmf/1.23wmf14) - 10https://gerrit.wikimedia.org/r/114050 (owner: 10EBernhardson) [21:00:07] (03CR) 10EBernhardson: [C: 032] Gracefully handle empty pagination result [extensions/Flow] (wmf/1.23wmf14) - 10https://gerrit.wikimedia.org/r/114052 (owner: 10EBernhardson) [21:00:21] (03CR) 10EBernhardson: [C: 032] Flow watchlist data tweaks [extensions/Flow] (wmf/1.23wmf14) - 10https://gerrit.wikimedia.org/r/114051 (owner: 10EBernhardson) [21:00:34] (03CR) 10EBernhardson: [C: 032] Fix topic preview [extensions/Flow] (wmf/1.23wmf14) - 10https://gerrit.wikimedia.org/r/114049 (owner: 10EBernhardson) [21:00:37] (03PS3) 10Anomie: HTMLForm: Allow i18n of 'options' [core] - 10https://gerrit.wikimedia.org/r/114066 [21:00:42] (03CR) 10Bartosz Dziewoński: "@Ori, I could, but I'm not sure what good will that do, especially since everything in these files is wrapped in $(). But alright." [core] - 10https://gerrit.wikimedia.org/r/113540 (owner: 10Bartosz Dziewoński) [21:01:28] i shout start time'ing git fetches and e-mailing this to someone. [21:01:30] (03Merged) 10jenkins-bot: Add code to prevent exception for new db columns [extensions/Flow] (wmf/1.23wmf14) - 10https://gerrit.wikimedia.org/r/114025 (owner: 10EBernhardson) [21:01:33] (03Merged) 10jenkins-bot: Associative array should not be accessed by numeric index [extensions/Flow] (wmf/1.23wmf14) - 10https://gerrit.wikimedia.org/r/114050 (owner: 10EBernhardson) [21:01:33] should* [21:01:45] (03Merged) 10jenkins-bot: Gracefully handle empty pagination result [extensions/Flow] (wmf/1.23wmf14) - 10https://gerrit.wikimedia.org/r/114052 (owner: 10EBernhardson) [21:01:48] (03Merged) 10jenkins-bot: Flow watchlist data tweaks [extensions/Flow] (wmf/1.23wmf14) - 10https://gerrit.wikimedia.org/r/114051 (owner: 10EBernhardson) [21:01:52] (03Merged) 10jenkins-bot: Fix topic preview [extensions/Flow] (wmf/1.23wmf14) - 10https://gerrit.wikimedia.org/r/114049 (owner: 10EBernhardson) [21:02:18] (03CR) 10jenkins-bot: [V: 04-1] HTMLForm: Allow i18n of 'options' [core] - 10https://gerrit.wikimedia.org/r/114066 (owner: 10Anomie) [21:02:31] (03PS3) 10Bartosz Dziewoński: Preload mediawiki.notification when we know we're going to need it soon [core] - 10https://gerrit.wikimedia.org/r/113540 [21:04:34] spagewmf, mediawiki.ui.button patch: https://gerrit.wikimedia.org/r/#/c/98869 [21:06:29] (03PS1) 10Aaron Schulz: Removed STRAIGHT_JOIN; the is slower when a namespace has a few pages [core] - 10https://gerrit.wikimedia.org/r/114070 [21:06:51] MatmaRex: email to wikitech-l? :) [21:08:37] legoktm: Around? [21:09:00] YuviPanda: hm? [21:09:04] ah [21:09:08] MatmaRex: fetch times [21:09:09] what for? :P [21:09:21] MatmaRex: idk, just trying to get some more dramaz [21:09:29] :D [21:12:20] (03PS1) 10Bartosz Dziewoński: mediawiki.js: Clean up docs of 'async' parameter to some functions [core] - 10https://gerrit.wikimedia.org/r/114072 [21:13:03] (03CR) 10Aklapper: "Could somebody please review the 15 lines patch of this contributor?" [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/101494 (owner: 10Apsdehal) [21:13:42] (03CR) 10EBernhardson: [C: 032] Add code to prevent exception for new db columns [extensions/Flow] (wmf/1.23wmf13) - 10https://gerrit.wikimedia.org/r/114021 (owner: 10EBernhardson) [21:13:54] (03Merged) 10jenkins-bot: Add code to prevent exception for new db columns [extensions/Flow] (wmf/1.23wmf13) - 10https://gerrit.wikimedia.org/r/114021 (owner: 10EBernhardson) [21:15:05] spagewmf, https://bugzilla.wikimedia.org/show_bug.cgi?id=29693 [21:15:30] sumanah: Probably won't be in Zurich :/ I'd love to go but exams... OTOH, Wikimania should be between university and employment, so ideal (and in London, too!) [21:19:42] (03PS4) 10Anomie: HTMLForm: Allow i18n of 'options' [core] - 10https://gerrit.wikimedia.org/r/114066 [21:20:40] (03CR) 10Brian Wolff: [C: 04-1] "Parent's comments from December still apply" [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/101494 (owner: 10Apsdehal) [21:21:34] (03PS1) 10EBernhardson: cherrypick updates to Flow in 1.23wmf14 [core] (wmf/1.23wmf14) - 10https://gerrit.wikimedia.org/r/114076 [21:21:44] (03PS1) 10EBernhardson: Prepare Flow for schema change in 1.23wmf13 [core] (wmf/1.23wmf13) - 10https://gerrit.wikimedia.org/r/114077 [21:22:38] hey jarry1250__ - oh too bad! we will miss you in Zurich. But I do hope to see you in London, then! What is the employment gonna be, btw? [21:27:22] ugagaaa [21:27:27] MatmaRex: added screenshots [21:28:45] sumanah: I'm tempted to screw my exams and go anyway :P But looking forward to y'all hitting up London. Employment should be with the UK Treasury ("Her Majesty's Treasury" FWIW, not that you USians appreciate these flourishes...), assuming they don't work out that I'm secretly a terrorist [21:29:01] Nikerabbit: ugh [21:29:02] Wait, damn. [21:29:20] Now they know :P [21:29:27] (03CR) 10Brian Wolff: "And that's embarrasing, I was looking at the wrong patchset..." [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/101494 (owner: 10Apsdehal) [21:30:07] jarry1250__: :) congrats and I hope it works out! [21:30:45] superm401: I added the mediawiki.ui.button double-load issue to https://bugzilla.wikimedia.org/show_bug.cgi?id=40284 [21:30:54] sumanah: Thanks :) I'll be much relieved come August, I have to say [21:31:01] spagewmf, alright, thanks. [21:32:28] Nikerabbit: at a glance and guessing, that looks as if safari's svg renderer couldn't handle masks properly [21:32:33] MatmaRex: maybe buggy old svg libraries... it's not a huge issue as only safari is having this problem in latest version [21:32:47] as if it was rendering the mask to a bitmap, then applying that bitmap, scaled up, as a mask [21:32:53] (03PS1) 10Yuvipanda: Add flag to enable/disable site-wide global CSS/JS [extensions/GlobalCssJs] - 10https://gerrit.wikimedia.org/r/114079 [21:34:29] Nikerabbit: we could just get rid of the magic in that SVG [21:38:28] (03PS1) 10Mattflaschen: Remove button styles from mediawiki.ui [core] - 10https://gerrit.wikimedia.org/r/114080 [21:38:32] (03CR) 10Matthias Mullie: [C: 04-1] "Just a couple more nitpicks" (0315 comments) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/113631 (owner: 10EBernhardson) [21:39:04] (03PS3) 10Matthias Mullie: Annotate model classes [extensions/Flow] - 10https://gerrit.wikimedia.org/r/113631 (owner: 10EBernhardson) [21:39:46] MatmaRex: do you know how to do that? [21:40:39] (03CR) 10Mattflaschen: "Change that did the split is https://gerrit.wikimedia.org/r/#/c/98869 ." [core] - 10https://gerrit.wikimedia.org/r/114080 (owner: 10Mattflaschen) [21:40:53] i mean, just get rid of the mask business and use a regular shape, just like it was done before [21:41:05] the file size will go up a kilobyte or three [21:41:11] (03PS2) 10Yuvipanda: Add flag to enable/disable site-wide global CSS/JS [extensions/GlobalCssJs] - 10https://gerrit.wikimedia.org/r/114079 [21:41:22] (03CR) 10Matthias Mullie: Anonymous editor warning (031 comment) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/109445 (owner: 10Werdna) [21:41:41] (03PS11) 10Inchikutty: [WIP] UploadWizard:OSM embedding- Geocoding, reverse geocoding [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/112342 [21:42:06] MatmaRex: to clarify, did you add the bitmask as an optimization? [21:42:39] (03CR) 10Mattflaschen: "All of those are merged, so I put up https://gerrit.wikimedia.org/r/#/c/114080/" [core] - 10https://gerrit.wikimedia.org/r/98869 (owner: 10Kaldari) [21:42:49] as filesize optimisation i guess [21:42:55] let me just kill that [21:42:57] (03CR) 10Mattflaschen: "Sorry, forgot to say: That removes the button styling from mediawiki.ui (#3)." [core] - 10https://gerrit.wikimedia.org/r/98869 (owner: 10Kaldari) [21:43:00] (03PS3) 10Matthias Mullie: Cleanup potential bad method calls [extensions/Flow] - 10https://gerrit.wikimedia.org/r/113630 (owner: 10EBernhardson) [21:43:20] (03CR) 10Matthias Mullie: [C: 032] Cleanup potential bad method calls [extensions/Flow] - 10https://gerrit.wikimedia.org/r/113630 (owner: 10EBernhardson) [21:43:22] (sorry, be right back) [21:43:31] (03Merged) 10jenkins-bot: Cleanup potential bad method calls [extensions/Flow] - 10https://gerrit.wikimedia.org/r/113630 (owner: 10EBernhardson) [21:43:39] (03CR) 10Brian Wolff: [C: 04-1] "Ok, looking at the right patch this time." [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/101494 (owner: 10Apsdehal) [21:43:48] (03PS3) 10Yuvipanda: Add flag to enable/disable site-wide global CSS/JS [extensions/GlobalCssJs] - 10https://gerrit.wikimedia.org/r/114079 [21:44:50] MatmaRex: no hurries, I'm off to sleep anyway [21:44:52] (03PS2) 10J-squared: Initial notification for when another user adds you to a course [extensions/EducationProgram] - 10https://gerrit.wikimedia.org/r/113145 [21:44:55] (03PS1) 10J-squared: Create separate notification types for student/instructor roles [extensions/EducationProgram] - 10https://gerrit.wikimedia.org/r/114083 [21:45:37] (03PS1) 10Matthias Mullie: Add missing flow-anon-warning qqq [extensions/Flow] - 10https://gerrit.wikimedia.org/r/114084 [21:46:28] (03PS4) 10Matthias Mullie: Annotate model classes [extensions/Flow] - 10https://gerrit.wikimedia.org/r/113631 (owner: 10EBernhardson) [21:46:53] (03CR) 10Matthias Mullie: [C: 032] Annotate model classes [extensions/Flow] - 10https://gerrit.wikimedia.org/r/113631 (owner: 10EBernhardson) [21:47:04] (03CR) 10jenkins-bot: [V: 04-1] Annotate model classes [extensions/Flow] - 10https://gerrit.wikimedia.org/r/113631 (owner: 10EBernhardson) [21:51:48] (03PS5) 10Matthias Mullie: Annotate model classes [extensions/Flow] - 10https://gerrit.wikimedia.org/r/113631 (owner: 10EBernhardson) [21:52:09] (03CR) 10Matthias Mullie: [C: 032] Annotate model classes [extensions/Flow] - 10https://gerrit.wikimedia.org/r/113631 (owner: 10EBernhardson) [21:52:19] (03Merged) 10jenkins-bot: Annotate model classes [extensions/Flow] - 10https://gerrit.wikimedia.org/r/113631 (owner: 10EBernhardson) [21:52:46] rdwrer: let me know how using oojs goes :D [21:53:45] (03PS1) 10Mattflaschen: Add mediawiki.ui.button to all pages so wiki content can use it [core] - 10https://gerrit.wikimedia.org/r/114085 [21:54:21] YuviPanda: It's been a bit complicated but I like the system overall [21:54:38] rdwrer: hmm, reminds me a bit of Java, and I don't know if that is good or bad :P [21:54:43] but i was just skimming docs [21:55:04] <^d> ooooooo, js [21:55:10] OOjs [21:55:28] <^d> ew, js ;-) [21:55:48] YuviPanda: MVC rather does that. :-) [21:55:48] * YuviPanda trebuchets https://bugzilla.wikimedia.org/show_bug.cgi?id=30857 on to ori [21:55:53] (03CR) 10Mattflaschen: "Follow-up to add the new button-only module (mediawiki.ui.button) to all pages is https://gerrit.wikimedia.org/r/114085" [core] - 10https://gerrit.wikimedia.org/r/87296 (owner: 10Mattflaschen) [21:56:04] James_F: perhaps, but when the rest of the code is Mediawiki, it feels odd :D [21:56:17] YuviPanda: Solution: Stop using MediaWiki. ;-) [21:56:19] (03CR) 10Mattflaschen: "Follow-up to load it by default is all pages is https://gerrit.wikimedia.org/r/114085" [core] - 10https://gerrit.wikimedia.org/r/98869 (owner: 10Kaldari) [21:56:30] YuviPanda: woops, i missed that thread entirely. i'll reply [21:56:36] James_F: I have! I'm rebuilding it in Java now, am I not? :D (Android app) [21:57:07] YuviPanda: My sympathies. [21:57:36] James_F: :D At least I can use whatever font I want... [21:58:03] <^d> What we really need a PHP Web Toolkit. [21:58:06] <^d> So I can write Javascript in PHP. [21:58:13] ori: thanks! [21:58:39] ^d: You jest, but actually TrevorParscal is looking at writing some of OOjs UI into OOphp UI so that it can be used server-side (e.g. for non-JS clients). [21:59:06] ^d: ahem, ahem. http://www.php.net/manual/en/book.v8js.php [21:59:15] <^d> I wouldn't mind. [21:59:27] also http://phpjs.org/ [21:59:32] <^d> Then I'd never have to write JS (not that I do anyway) [22:02:00] (03CR) 10GWicke: [C: 032] "I did not test git-buildpackage, but the config looks good to me." [services/mathoid] - 10https://gerrit.wikimedia.org/r/113349 (owner: 10Hashar) [22:02:43] btw James_F - we were trying appear.in recently and it looks pretty usable, in case you want to try it for your team [22:03:24] sumanah: Ooh, intersting. [22:03:40] YES [22:03:52] unfortunately it's ff/Chrome only [22:03:53] sumanah: Thanks! [22:03:56] Welcome! [22:04:02] sumanah: And Opera, it claims. [22:04:04] (03CR) 10EBernhardson: [C: 032] Prepare Flow for schema change in 1.23wmf13 [core] (wmf/1.23wmf13) - 10https://gerrit.wikimedia.org/r/114077 (owner: 10EBernhardson) [22:04:07] oh sorry [22:04:17] sumanah: Don't forget Opera. Its adherents really really want you to remember it. :-) [22:04:20] the screensharing evidently only works in very recent Chrome versions [22:04:28] James_F: :D [22:05:02] ok, off to see more of this coworking space [22:07:18] (03CR) 10Matthias Mullie: [C: 031] "LGTM" (031 comment) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/113632 (owner: 10EBernhardson) [22:07:45] (03PS3) 10Matthias Mullie: Ensure getHumanTimestamp parameter is really MWTimestamp|null [extensions/Flow] - 10https://gerrit.wikimedia.org/r/113632 (owner: 10EBernhardson) [22:07:48] (03Merged) 10jenkins-bot: Prepare Flow for schema change in 1.23wmf13 [core] (wmf/1.23wmf13) - 10https://gerrit.wikimedia.org/r/114077 (owner: 10EBernhardson) [22:07:53] (03CR) 10Matthias Mullie: [C: 032] Ensure getHumanTimestamp parameter is really MWTimestamp|null [extensions/Flow] - 10https://gerrit.wikimedia.org/r/113632 (owner: 10EBernhardson) [22:08:49] (03Merged) 10jenkins-bot: Ensure getHumanTimestamp parameter is really MWTimestamp|null [extensions/Flow] - 10https://gerrit.wikimedia.org/r/113632 (owner: 10EBernhardson) [22:09:00] (03CR) 10GWicke: "Should this be moved to the mathoid repository?" [extensions/Math] - 10https://gerrit.wikimedia.org/r/113764 (owner: 10Physikerwelt) [22:09:19] (03CR) 10Matthias Mullie: [C: 032] Use consistent return type [extensions/Flow] - 10https://gerrit.wikimedia.org/r/113633 (owner: 10EBernhardson) [22:09:22] (03CR) 10jenkins-bot: [V: 04-1] Use consistent return type [extensions/Flow] - 10https://gerrit.wikimedia.org/r/113633 (owner: 10EBernhardson) [22:10:01] (03PS4) 10Matthias Mullie: Use consistent return type [extensions/Flow] - 10https://gerrit.wikimedia.org/r/113633 (owner: 10EBernhardson) [22:10:10] (03CR) 10Matthias Mullie: [C: 032] Use consistent return type [extensions/Flow] - 10https://gerrit.wikimedia.org/r/113633 (owner: 10EBernhardson) [22:10:22] (03Merged) 10jenkins-bot: Use consistent return type [extensions/Flow] - 10https://gerrit.wikimedia.org/r/113633 (owner: 10EBernhardson) [22:11:01] (03PS3) 10Matthias Mullie: couple spelling errors [extensions/Flow] - 10https://gerrit.wikimedia.org/r/113634 (owner: 10EBernhardson) [22:11:21] (03CR) 10Matthias Mullie: [C: 032] couple spelling errors [extensions/Flow] - 10https://gerrit.wikimedia.org/r/113634 (owner: 10EBernhardson) [22:11:31] (03Merged) 10jenkins-bot: couple spelling errors [extensions/Flow] - 10https://gerrit.wikimedia.org/r/113634 (owner: 10EBernhardson) [22:11:34] (03PS21) 10Inchikutty: [WIP]Embedding leaflet maps based on OSM data to UploadWizard [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/109263 [22:12:09] (03PS3) 10Matthias Mullie: Prefer instanceof over is_a [extensions/Flow] - 10https://gerrit.wikimedia.org/r/113635 (owner: 10EBernhardson) [22:12:12] (03CR) 10EBernhardson: [C: 032] cherrypick updates to Flow in 1.23wmf14 [core] (wmf/1.23wmf14) - 10https://gerrit.wikimedia.org/r/114076 (owner: 10EBernhardson) [22:12:16] (03CR) 10Matthias Mullie: [C: 032] Prefer instanceof over is_a [extensions/Flow] - 10https://gerrit.wikimedia.org/r/113635 (owner: 10EBernhardson) [22:12:57] Who can spot the i18n fail on this page: https://commons.wikimedia.org/wiki/Special:FileDuplicateSearch/File:Fl._84,_Nr._117-118.JPG ;) [22:13:06] (03Merged) 10jenkins-bot: Prefer instanceof over is_a [extensions/Flow] - 10https://gerrit.wikimedia.org/r/113635 (owner: 10EBernhardson) [22:15:27] (03Merged) 10jenkins-bot: cherrypick updates to Flow in 1.23wmf14 [core] (wmf/1.23wmf14) - 10https://gerrit.wikimedia.org/r/114076 (owner: 10EBernhardson) [22:22:46] (03PS3) 10QChris: Add a message to the edit form when external text is loaded [extensions/ExternalArticles] - 10https://gerrit.wikimedia.org/r/66231 (owner: 10Samwilson) [22:24:53] (03PS2) 10Ebe123: Remove global $wmincLangCodeLength [extensions/WikimediaIncubator] - 10https://gerrit.wikimedia.org/r/113880 [22:24:59] (03PS12) 10Inchikutty: [WIP] UploadWizard:OSM embedding- Geocoding, reverse geocoding [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/112342 [22:29:24] (03CR) 10EBernhardson: [C: 032] Add missing flow-anon-warning qqq [extensions/Flow] - 10https://gerrit.wikimedia.org/r/114084 (owner: 10Matthias Mullie) [22:29:36] (03Merged) 10jenkins-bot: Add missing flow-anon-warning qqq [extensions/Flow] - 10https://gerrit.wikimedia.org/r/114084 (owner: 10Matthias Mullie) [22:31:41] (03CR) 10Dzahn: [C: 04-1] "voting it down because it didn't have a vote but the reason for not merging is what Andre said above" [wikimedia/bugzilla/modifications] - 10https://gerrit.wikimedia.org/r/106761 (owner: 1001tonythomas) [22:32:07] (03CR) 10Dzahn: [C: 04-1] Remove padlock icon from links in Wikimedia Bugzilla installation [wikimedia/bugzilla/modifications] - 10https://gerrit.wikimedia.org/r/106761 (owner: 1001tonythomas) [22:33:06] (03CR) 10QChris: "Unfortunately this situation looks more like hitting a gerrit" [extensions/ExternalArticles] - 10https://gerrit.wikimedia.org/r/66230 (owner: 10Samwilson) [22:54:31] (03PS1) 10Ori.livneh: mw.loader#version -> mw.loader#getVersion [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/114094 [22:54:58] (03PS8) 10Ysangkok: Support for modules-as-images [extensions/Scribunto] - 10https://gerrit.wikimedia.org/r/113759 [22:55:11] (03CR) 10Ori.livneh: [C: 032] "trivial" [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/114094 (owner: 10Ori.livneh) [22:55:15] (03Merged) 10jenkins-bot: mw.loader#version -> mw.loader#getVersion [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/114094 (owner: 10Ori.livneh) [23:03:27] (03PS7) 10Reedy: Rewriting ContactPage to use HTMLForm [extensions/ContactPage] - 10https://gerrit.wikimedia.org/r/113879 [23:04:11] (03Abandoned) 10Reedy: Add EmailUser hooks used for Captcha inclusion [extensions/ContactPage] - 10https://gerrit.wikimedia.org/r/113892 (owner: 10Reedy) [23:04:20] (03CR) 10Reedy: Rewriting ContactPage to use HTMLForm (034 comments) [extensions/ContactPage] - 10https://gerrit.wikimedia.org/r/113879 (owner: 10Reedy) [23:04:49] (03CR) 10Reedy: [C: 04-1] "Path 7 squashes in the "captcha" commit" [extensions/ContactPage] - 10https://gerrit.wikimedia.org/r/113879 (owner: 10Reedy) [23:08:53] (03CR) 10Reedy: WIP: Allow inclusion of additional fields (032 comments) [extensions/ContactPage] - 10https://gerrit.wikimedia.org/r/113883 (owner: 10Reedy) [23:14:59] (03CR) 10Ori.livneh: mediawiki.js: Clean up docs of 'async' parameter to some functions (031 comment) [core] - 10https://gerrit.wikimedia.org/r/114072 (owner: 10Bartosz Dziewoński) [23:15:08] ^ MatmaRex simple fix [23:17:45] ori: ugh, it's going to sound bad however we phrase it, but alright [23:17:46] (03PS3) 10Brian Wolff: Decode html entities before comparing strings in #ifeq: and #switch [extensions/ParserFunctions] - 10https://gerrit.wikimedia.org/r/113518 [23:18:05] (03CR) 10Brian Wolff: "ps3: rebase" [extensions/ParserFunctions] - 10https://gerrit.wikimedia.org/r/113518 (owner: 10Brian Wolff) [23:20:02] ori: actually, i don't like how that version says "default" – that implies you can override that behavior [23:20:04] and you can't [23:20:22] (03PS8) 10Reedy: Rewriting ContactPage to use HTMLForm [extensions/ContactPage] - 10https://gerrit.wikimedia.org/r/113879 [23:20:37] (03CR) 10Reedy: Rewriting ContactPage to use HTMLForm (035 comments) [extensions/ContactPage] - 10https://gerrit.wikimedia.org/r/113879 (owner: 10Reedy) [23:22:45] (03CR) 10Bartosz Dziewoński: mediawiki.js: Clean up docs of 'async' parameter to some functions (031 comment) [core] - 10https://gerrit.wikimedia.org/r/114072 (owner: 10Bartosz Dziewoński) [23:23:13] (03PS1) 10Reedy: Move Subject to be third field on form [extensions/ContactPage] - 10https://gerrit.wikimedia.org/r/114101 [23:25:31] (03CR) 10Reedy: [C: 04-1] Rewriting ContactPage to use HTMLForm (034 comments) [extensions/ContactPage] - 10https://gerrit.wikimedia.org/r/113879 (owner: 10Reedy) [23:26:44] (03CR) 10Reedy: [C: 04-1] "I think it's going to make more sense to get the parent path finalised (and/or merged) before working on this further due to additions/ref" [extensions/ContactPage] - 10https://gerrit.wikimedia.org/r/113883 (owner: 10Reedy) [23:27:26] (03PS3) 10J-squared: Notification for when another user adds you to a course Create separate notification types for student/instructor roles [extensions/EducationProgram] - 10https://gerrit.wikimedia.org/r/113145 [23:32:56] (03CR) 10Reedy: Rewriting ContactPage to use HTMLForm (032 comments) [extensions/ContactPage] - 10https://gerrit.wikimedia.org/r/113879 (owner: 10Reedy) [23:37:49] (03Abandoned) 10EBernhardson: Replace missing parent:: call [extensions/Flow] - 10https://gerrit.wikimedia.org/r/113657 (owner: 10EBernhardson) [23:38:11] (03PS4) 10Brian Wolff: Decode html entities before comparing strings in #ifeq: and #switch [extensions/ParserFunctions] - 10https://gerrit.wikimedia.org/r/113518 [23:38:32] (03CR) 10Brian Wolff: "PS4: parser tests" [extensions/ParserFunctions] - 10https://gerrit.wikimedia.org/r/113518 (owner: 10Brian Wolff) [23:42:51] (03CR) 10Matthias Mullie: [C: 031] Update docblock annotations (032 comments) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/113679 (owner: 10EBernhardson) [23:44:01] (03PS2) 10Matthias Mullie: Update docblock annotations [extensions/Flow] - 10https://gerrit.wikimedia.org/r/113679 (owner: 10EBernhardson) [23:44:09] (03CR) 10Matthias Mullie: [C: 032] Update docblock annotations [extensions/Flow] - 10https://gerrit.wikimedia.org/r/113679 (owner: 10EBernhardson) [23:44:40] (03Merged) 10jenkins-bot: Update docblock annotations [extensions/Flow] - 10https://gerrit.wikimedia.org/r/113679 (owner: 10EBernhardson) [23:46:15] (03PS9) 10Reedy: Rewrite ContactPage to use HTMLForm [extensions/ContactPage] - 10https://gerrit.wikimedia.org/r/113879 [23:46:42] (03CR) 10Reedy: Rewrite ContactPage to use HTMLForm (033 comments) [extensions/ContactPage] - 10https://gerrit.wikimedia.org/r/113879 (owner: 10Reedy) [23:47:10] (03PS1) 10Ori.livneh: Make the OS reap children by explicitly setting a SIG_IGN handler to SIGCHLD [tools/scap] - 10https://gerrit.wikimedia.org/r/114107 [23:47:13] ^ bd808 [23:47:24] (03CR) 10Reedy: "I think that's this commit straightened out" [extensions/ContactPage] - 10https://gerrit.wikimedia.org/r/113879 (owner: 10Reedy) [23:48:33] (03PS2) 10Matthias Mullie: Cleanup undefined variable warnings [extensions/Flow] - 10https://gerrit.wikimedia.org/r/113680 (owner: 10EBernhardson) [23:48:47] (03CR) 10Matthias Mullie: [C: 032] Cleanup undefined variable warnings [extensions/Flow] - 10https://gerrit.wikimedia.org/r/113680 (owner: 10EBernhardson) [23:48:58] (03Merged) 10jenkins-bot: Cleanup undefined variable warnings [extensions/Flow] - 10https://gerrit.wikimedia.org/r/113680 (owner: 10EBernhardson) [23:49:25] (03CR) 10Ori.livneh: [C: 032] mediawiki.js: Clean up docs of 'async' parameter to some functions (031 comment) [core] - 10https://gerrit.wikimedia.org/r/114072 (owner: 10Bartosz Dziewoński) [23:52:15] (03CR) 10EBernhardson: [C: 032] Use Collection instead of manually fetching from storage [extensions/Flow] - 10https://gerrit.wikimedia.org/r/113492 (owner: 10Matthias Mullie) [23:52:26] (03Merged) 10jenkins-bot: Use Collection instead of manually fetching from storage [extensions/Flow] - 10https://gerrit.wikimedia.org/r/113492 (owner: 10Matthias Mullie) [23:52:53] (03PS5) 10Matthias Mullie: restore should look at previous revision for correct value [extensions/Flow] - 10https://gerrit.wikimedia.org/r/112840 [23:53:07] (03Merged) 10jenkins-bot: mediawiki.js: Clean up docs of 'async' parameter to some functions [core] - 10https://gerrit.wikimedia.org/r/114072 (owner: 10Bartosz Dziewoński) [23:54:04] (03CR) 10EBernhardson: [C: 032] restore should look at previous revision for correct value [extensions/Flow] - 10https://gerrit.wikimedia.org/r/112840 (owner: 10Matthias Mullie) [23:54:14] (03Merged) 10jenkins-bot: restore should look at previous revision for correct value [extensions/Flow] - 10https://gerrit.wikimedia.org/r/112840 (owner: 10Matthias Mullie) [23:54:58] (03PS7) 10Matthias Mullie: Test permissions on multiple revisions in 1 object [extensions/Flow] - 10https://gerrit.wikimedia.org/r/112844 [23:55:03] (03CR) 10Ori.livneh: [C: 032] "Very nice." [tools/scap] - 10https://gerrit.wikimedia.org/r/113652 (owner: 10BryanDavis) [23:55:05] (03Merged) 10jenkins-bot: Add detailed duration timing [tools/scap] - 10https://gerrit.wikimedia.org/r/113652 (owner: 10BryanDavis) [23:55:19] (03PS3) 10BryanDavis: Remove external script dependencies from sync_common [tools/scap] - 10https://gerrit.wikimedia.org/r/113996