[00:35:30] still got 10 COPYING patchsets left open... [03:15:03] (03PS1) 10Foxtrott: Enable responsive behaviour on mobile browsers [skins/chameleon] - 10https://gerrit.wikimedia.org/r/113649 [03:16:53] (03PS2) 10Foxtrott: Enable responsive behaviour on mobile browsers [skins/chameleon] - 10https://gerrit.wikimedia.org/r/113649 [03:17:57] (03CR) 10Foxtrott: [C: 032 V: 032] Enable responsive behaviour on mobile browsers [skins/chameleon] - 10https://gerrit.wikimedia.org/r/113649 (owner: 10Foxtrott) [03:32:23] (03PS1) 10Ebe123: Make MediaWiki:wminc-error-unprefixed-suggest show correctly capitalised title [extensions/WikimediaIncubator] - 10https://gerrit.wikimedia.org/r/113650 [04:07:00] (03PS8) 10Bsitu: Add diff view of changes to board header [extensions/Flow] - 10https://gerrit.wikimedia.org/r/109431 [04:07:05] (03CR) 10jenkins-bot: [V: 04-1] Add diff view of changes to board header [extensions/Flow] - 10https://gerrit.wikimedia.org/r/109431 (owner: 10Bsitu) [04:37:47] (03PS1) 10Aaron Schulz: Actually write-back the container cache in SwiftFileBackend [core] - 10https://gerrit.wikimedia.org/r/113651 [05:19:37] (03CR) 10MZMcBride: "Does anyone (Anomie, Catrope, Krinkle) have additional reviews? If not, I think we should probably go ahead and merge this." [extensions/GlobalCssJs] - 10https://gerrit.wikimedia.org/r/94837 (owner: 10Legoktm) [05:36:20] (03PS1) 10BryanDavis: Add detailed duration timing [tools/scap] - 10https://gerrit.wikimedia.org/r/113652 [05:40:23] (03PS1) 10TTO: Remove unused setting $wgImageMagickIdentifyCommand [core] - 10https://gerrit.wikimedia.org/r/113653 [05:44:58] (03PS2) 10TTO: Remove unused setting $wgImageMagickIdentifyCommand [core] - 10https://gerrit.wikimedia.org/r/113653 [06:34:43] :w [06:59:14] (03PS1) 10EBernhardson: Replace missing parent:: call [extensions/Flow] - 10https://gerrit.wikimedia.org/r/113657 [07:33:15] (03PS2) 10Aaron Schulz: Actually write-back the container cache in SwiftFileBackend [core] - 10https://gerrit.wikimedia.org/r/113651 [07:33:18] (03CR) 10Ori.livneh: [C: 032] Actually write-back the container cache in SwiftFileBackend [core] - 10https://gerrit.wikimedia.org/r/113651 (owner: 10Aaron Schulz) [07:37:46] (03Merged) 10jenkins-bot: Actually write-back the container cache in SwiftFileBackend [core] - 10https://gerrit.wikimedia.org/r/113651 (owner: 10Aaron Schulz) [08:31:33] moizsyed seems to be having connection issues. [11:36:28] hello, i have a problem using the api from mediawiki with java. i am getting an internal error while accessing the action=upload function. Is there any know issue? http://pastebin.de/40068 [13:46:50] okay, found it ... uploading files of a not allowed filetype by api produce this error. if you switch format to json, everthing works as designed [14:07:22] Good connection... [14:31:32] Can anyone here tell me how to allow multiple CORS headers (to allow multiple sites)? [14:32:58] https://github.com/enwikipedia-acc/waca/blob/master/api.php#L20 is what we have so far, but it doesn't work from meta (obviously) and it doesn't work without the https:// prefix (stumped me for a bit). [14:46:25] is T13 trying to load http resources from https pages? no wonder [16:29:27] so I wanted to make it possible to reference Scribunto modules as images, and I made a patch. Should I create a bug and link the patch from there? [16:29:49] MatmaRex: see above [16:33:40] ysangkok: you could, but it's perfectly okay to just push the patch to gerrit [16:41:28] (03PS2) 10EBernhardson: Prefer instanceof over is_a [extensions/Flow] - 10https://gerrit.wikimedia.org/r/113635 [16:41:31] (03PS2) 10EBernhardson: couple spelling errors [extensions/Flow] - 10https://gerrit.wikimedia.org/r/113634 [16:41:34] (03PS2) 10EBernhardson: Use consistent return type [extensions/Flow] - 10https://gerrit.wikimedia.org/r/113633 [16:41:37] (03PS2) 10EBernhardson: Ensure getHumanTimestamp parameter is really MWTimestamp|null [extensions/Flow] - 10https://gerrit.wikimedia.org/r/113632 [16:41:40] (03PS2) 10EBernhardson: Cleanup unused local variables [extensions/Flow] - 10https://gerrit.wikimedia.org/r/113628 [16:41:43] (03PS2) 10EBernhardson: Remove unused class aliases [extensions/Flow] - 10https://gerrit.wikimedia.org/r/113629 [16:41:46] (03PS2) 10EBernhardson: Cleanup potential bad method calls [extensions/Flow] - 10https://gerrit.wikimedia.org/r/113630 [16:41:49] (03PS2) 10EBernhardson: Annotate model classes [extensions/Flow] - 10https://gerrit.wikimedia.org/r/113631 [16:41:52] (03PS1) 10EBernhardson: Update docblock annotations [extensions/Flow] - 10https://gerrit.wikimedia.org/r/113679 [16:41:55] (03PS1) 10EBernhardson: Cleanup undefined variable warnings [extensions/Flow] - 10https://gerrit.wikimedia.org/r/113680 [16:41:58] (03PS1) 10EBernhardson: de-duplicate spam filter calling code [extensions/Flow] - 10https://gerrit.wikimedia.org/r/113681 [16:42:01] (03PS1) 10EBernhardson: Prefer passing UUID objects in query [extensions/Flow] - 10https://gerrit.wikimedia.org/r/113682 [16:42:04] (03PS1) 10EBernhardson: cleanup some static analysis warnings [extensions/Flow] - 10https://gerrit.wikimedia.org/r/113683 [16:42:07] (03CR) 10jenkins-bot: [V: 04-1] de-duplicate spam filter calling code [extensions/Flow] - 10https://gerrit.wikimedia.org/r/113681 (owner: 10EBernhardson) [16:50:21] (03PS2) 10EBernhardson: Replace missing parent:: call [extensions/Flow] - 10https://gerrit.wikimedia.org/r/113657 [16:52:43] (03CR) 10UltrasonicNXT: "Well I think the only things left to sort out here are the resizing (the users sidebar doesn't resize with the main area), and the adding " [extensions/MediaWikiChat] - 10https://gerrit.wikimedia.org/r/113164 (owner: 10Gerrit Patch Uploader) [16:59:07] (03CR) 10BryanDavis: Replace dependency on DSH with a simple Python OpenSSH wrapper (031 comment) [tools/scap] - 10https://gerrit.wikimedia.org/r/113660 (owner: 10Ori.livneh) [18:00:23] (03CR) 10Alex Monk: [C: 04-1] Feedback includes browser info, given user permission [core] - 10https://gerrit.wikimedia.org/r/32700 (owner: 10Nischayn22) [18:01:13] So Krenair broke the silence [18:24:05] (03PS1) 10Aklapper: Upgrade custom code to Bugzilla 4.4.2 [wikimedia/bugzilla/modifications] - 10https://gerrit.wikimedia.org/r/113685 [18:32:43] (03CR) 10Aklapper: "Not sure who could review this - http://git.wikimedia.org/summary/wikimedia%2Fbugzilla%2Fwikibugs.git lists recent committers." [wikimedia/bugzilla/wikibugs] - 10https://gerrit.wikimedia.org/r/104199 (owner: 10Merlijn van Deen) [18:34:21] having connection issues moizsye__ ? [18:51:47] (03PS3) 10Isarra: (bug 61010) Add IE support to vertical-gradient mixin. [core] - 10https://gerrit.wikimedia.org/r/112066 [18:51:50] (03CR) 10jenkins-bot: [V: 04-1] (bug 61010) Add IE support to vertical-gradient mixin. [core] - 10https://gerrit.wikimedia.org/r/112066 (owner: 10Isarra) [18:55:01] (03CR) 10Bartosz Dziewoński: [C: 04-1] "As currently written, this patch causes the gradient to be messed-up on IE due to the bug we've discussed before (http://i.imgur.com/BhCg0" [core] - 10https://gerrit.wikimedia.org/r/112066 (owner: 10Isarra) [18:56:31] (03CR) 10Bartosz Dziewoński: "Ignore jenkins, the V-1 is probably caused by https://bugzilla.wikimedia.org/show_bug.cgi?id=hash-mismatch ." [core] - 10https://gerrit.wikimedia.org/r/112066 (owner: 10Isarra) [19:20:58] why do all the MetadataExtractor classes not derive from the same base class? [19:21:53] Probably all developed seperately [19:21:53] i wish to get width/height on an arbitrary file, but getWidth returns false on svgs... [19:22:12] You should get a file object from MW, and have that give you the metadata [19:22:48] yes, but getWidth returns false on svgs... so apparently it doesn't use metadataextractor [19:23:35] SVGReader looks to deal with width [19:24:34] yes exactly... but i'm looking for how to get the appropriate reader for an arbitrary file type [19:24:41] svgreader won't do if i'm reading a png... [19:25:28] (03CR) 10leucosticte: "Oh, I guess the patches for rc_id and fa_id should actually specify NOT NULL AUTO_INCREMENT; I'll have to submit a new patch." [core] - 10https://gerrit.wikimedia.org/r/112825 (owner: 10leucosticte) [19:25:56] (03CR) 10Aaron Schulz: [C: 032] Actually write-back the container cache in SwiftFileBackend [core] (wmf/1.23wmf13) - 10https://gerrit.wikimedia.org/r/113654 (owner: 10Aaron Schulz) [19:26:03] (03CR) 10leucosticte: "ipb_id too." [core] - 10https://gerrit.wikimedia.org/r/112825 (owner: 10leucosticte) [19:29:36] (03Merged) 10jenkins-bot: Actually write-back the container cache in SwiftFileBackend [core] (wmf/1.23wmf13) - 10https://gerrit.wikimedia.org/r/113654 (owner: 10Aaron Schulz) [19:35:50] (03CR) 10Bartosz Dziewoński: "Wouldn't it be cleaner to add a print-only stylesheet to the mediawiki.notification module with .mw-notification { display: none; } ?" [core] - 10https://gerrit.wikimedia.org/r/113169 (owner: 10Mattflaschen) [19:45:08] (03PS7) 10Aaron Schulz: Added concurrent HEAD request support for Swift [core] - 10https://gerrit.wikimedia.org/r/107759 [19:54:11] (03CR) 10Isarra: "What are you talking about? In no way does this absolutely cause the gradient to become messed up in IE; it's only if it's given improper " [core] - 10https://gerrit.wikimedia.org/r/112066 (owner: 10Isarra) [19:57:42] (03CR) 10Isarra: "How would adding an entire extra file be cleaner?" [core] - 10https://gerrit.wikimedia.org/r/113169 (owner: 10Mattflaschen) [20:21:38] (03CR) 10Bartosz Dziewoński: "By not introducing an implicit dependency on the mediawiki.legacy.commonPrint module, which defines the 'noprint' class." [core] - 10https://gerrit.wikimedia.org/r/113169 (owner: 10Mattflaschen) [20:35:47] (03PS5) 10Umherirrender: Give alreadyrolled error when rollback will be a null edit [core] - 10https://gerrit.wikimedia.org/r/102550 [20:35:52] (03PS3) 10Umherirrender: Add ParserOutput::addJsConfigVars [core] - 10https://gerrit.wikimedia.org/r/108333 [21:12:28] Krinkle|detached: Thanks for the GlobalCssJs merge! [21:12:38] legoktm: Yo yo yo. [21:15:00] * Gloria looks around for a wild Brion. [21:15:14] Alas. [21:15:40] Okay, where did MobileFrontend go... [21:15:56] Apparently now a Product. Cute. [21:18:31] Oh, good. "eargasm" is already defined on Wiktionary. [21:25:55] http://bug-attachment.wikimedia.org/attachment.cgi?id=14604 [21:26:09] Just the user experience I wanted... [21:34:31] (03PS3) 10BryanDavis: Add bootstrap initialization for l10n update in new branches [tools/scap] - 10https://gerrit.wikimedia.org/r/113260 [21:38:16] (03PS4) 10BryanDavis: Add bootstrap initialization for l10n update in new branches [tools/scap] - 10https://gerrit.wikimedia.org/r/113260 [21:46:59] (03PS2) 10Legoktm: Remove user option [extensions/GlobalCssJs] - 10https://gerrit.wikimedia.org/r/101626 [21:47:33] (03CR) 10Legoktm: "PS2: Rebase." [extensions/GlobalCssJs] - 10https://gerrit.wikimedia.org/r/101626 (owner: 10Legoktm) [21:47:55] legoktm: Are you about? [21:52:29] (03CR) 10Alex Monk: Make Questy answers in arrays case-insensitive (031 comment) [extensions/ConfirmEdit] - 10https://gerrit.wikimedia.org/r/33153 (owner: 10leucosticte) [21:53:14] (03CR) 10Alex Monk: [C: 04-1] Make Questy answers in arrays case-insensitive [extensions/ConfirmEdit] - 10https://gerrit.wikimedia.org/r/33153 (owner: 10leucosticte) [21:53:28] (03PS3) 10Legoktm: Display a notice on top of the edit window when editing global.css/js [extensions/GlobalCssJs] - 10https://gerrit.wikimedia.org/r/94842 [21:54:11] (03CR) 10Jack Phoenix: [C: 031] "If the noprint class is only defined by what is nowadays considered a "legacy" module, that certainly sounds like a bug for which a new ti" [core] - 10https://gerrit.wikimedia.org/r/113169 (owner: 10Mattflaschen) [22:05:23] (03CR) 10Legoktm: "I filed bug 61448 about using the new hook." [extensions/WikimediaMessages] - 10https://gerrit.wikimedia.org/r/111693 (owner: 10Wctaiwan) [22:07:02] anyone know offhand the interwiki links for the various wikimania2013/2012 sites? [22:07:37] [[wm2012:]] [22:07:40] [[wm2013:]] [22:08:43] (03PS1) 10Legoktm: "Resource Loader" --> "ResourceLoader" in code comments [extensions/GlobalCssJs] - 10https://gerrit.wikimedia.org/r/113756 [22:09:04] (03CR) 10Legoktm: [C: 032] "Trivial." [extensions/GlobalCssJs] - 10https://gerrit.wikimedia.org/r/113756 (owner: 10Legoktm) [22:09:06] (03Merged) 10jenkins-bot: "Resource Loader" --> "ResourceLoader" in code comments [extensions/GlobalCssJs] - 10https://gerrit.wikimedia.org/r/113756 (owner: 10Legoktm) [22:09:33] (03CR) 10Legoktm: Load scripts and styles via ResourceLoader (031 comment) [extensions/GlobalCssJs] - 10https://gerrit.wikimedia.org/r/94837 (owner: 10Legoktm) [22:24:51] danke [22:27:28] ugh. commons doesn't have the foundation employee template. [22:30:48] (03CR) 10Bartosz Dziewoński: [C: 032] Remove user option [extensions/GlobalCssJs] - 10https://gerrit.wikimedia.org/r/101626 (owner: 10Legoktm) [22:30:50] (03Merged) 10jenkins-bot: Remove user option [extensions/GlobalCssJs] - 10https://gerrit.wikimedia.org/r/101626 (owner: 10Legoktm) [22:31:27] (03PS3) 10Alex Monk: Allow multiple prop/list/meta params for action=query [extensions/ApiSandbox] - 10https://gerrit.wikimedia.org/r/112307 [22:31:47] legoktm, MatmaRex: You guys ever managed to break that? ^ [22:37:43] break what? [22:37:49] the apisandbox thing? didn't have time :( [22:40:39] (03CR) 10Bartosz Dziewoński: "We have quite an inconsistency with the naming of the common* modules, feel free to open a bug." [core] - 10https://gerrit.wikimedia.org/r/113169 (owner: 10Mattflaschen) [22:42:20] MatmaRex: \o/ [22:42:39] brion: Yo. [22:42:56] no titanfall, brion? [22:42:59] sup [22:43:06] brion: I hit http://bug-attachment.wikimedia.org/attachment.cgi?id=14604 on my phone today. [22:43:14] That auto-collapse is... pretty aggressive. [22:43:31] To the point that the page almost looks broken. I filed a bug for the mobile folks to poke at. [22:43:43] heh [22:43:53] I saw your gzip patches, BTW. Yay for reducing bandwidth. [22:43:59] wiktionary sections are particularly...... particular [22:44:06] they don't really fit the model MobileFrontend is expecting [22:44:17] Yeah... I considered just requesting MobileFrontend be turned off there. [22:44:25] On Wiktionary ™, as it's known. [22:44:33] Silliness abounds. [22:45:30] https://bugzilla.wikimedia.org/show_bug.cgi?id=61447 is the bug, if you're interested. [22:45:33] * Gloria flees. [23:07:48] Anyone know how Chrome on Linux picks its default "sans-serif" font? It doesn't seem to use the system default, but uses either Liberation Sans or Arial. [23:10:03] robla: Chrome (not Chromium) embeds fonts afaik [23:12:15] I'm not 100% sure, but I remember Google developing their own metric-equivalent fonts for Cambria, Calibri, Candara etc. [23:13:03] paravoid: I'm pretty sure it's using "Liberation Sans" for me, but I suspect that's because fc-match returns LS in response to "Arial" [23:13:27] (on my machine) [23:13:53] they might be shipping LS though [23:15:06] hm, what I'm saying is just ChromeOS [23:15:16] not chrome in general [23:16:12] ah, ok [23:18:02] I've figured out that Firefox on my Linux box uses DejaVu Sans, which I'd expect given that fc-match resolves "sans-serif" to DejaVu Sans on my machine. Chrome is doing something different [23:20:57] robla: there's a font settings under advanced settings [23:21:40] paravoid: yeah, I just filed a bug about that :-) [23:22:39] https://code.google.com/p/chromium/issues/detail?id=344225 [23:26:21] (03PS1) 10Ysangkok: initial prototype for modules-as-images [extensions/Scribunto] - 10https://gerrit.wikimedia.org/r/113759 [23:26:24] (03CR) 10jenkins-bot: [V: 04-1] initial prototype for modules-as-images [extensions/Scribunto] - 10https://gerrit.wikimedia.org/r/113759 (owner: 10Ysangkok) [23:29:18] so now i put my patch in gerrit but i made a silly mistake [23:29:25] should i just abandon it at try again? [23:34:33] (03CR) 10Ysangkok: "A sample config:" [extensions/Scribunto] - 10https://gerrit.wikimedia.org/r/113759 (owner: 10Ysangkok) [23:35:34] (03CR) 10Ysangkok: "(the module is available as an image as e.g. Module:Bananas.svg)" [extensions/Scribunto] - 10https://gerrit.wikimedia.org/r/113759 (owner: 10Ysangkok) [23:46:27] (03PS8) 10Inchikutty: [WIP] UploadWizard:OSM embedding- Geocoding, reverse geocoding [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/112342 [23:48:00] ysangkok: do you just need to make a correction, or is it like .... wrong repo and stuff? :) [23:48:42] for most things you can just amend the commit locally, resubmit, and it'll show an updated patch set on gerrit [23:55:11] (03PS9) 10Inchikutty: [WIP] UploadWizard:OSM embedding- Geocoding, reverse geocoding [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/112342 [23:56:34] brion: a file in the wrong directory [23:56:56] ysangkok: yeah just go ahead and fix it, amend the commit (git commit --amend) and do 'git review' again [23:57:03] ok thanks [23:58:30] (03PS2) 10Ysangkok: initial prototype for modules-as-images [extensions/Scribunto] - 10https://gerrit.wikimedia.org/r/113759 [23:58:32] (03CR) 10jenkins-bot: [V: 04-1] initial prototype for modules-as-images [extensions/Scribunto] - 10https://gerrit.wikimedia.org/r/113759 (owner: 10Ysangkok)