[00:02:07] <AaronSchulz>	 ^d: parse is 2.6sec, down from 36 \o/
[00:02:11] <AaronSchulz>	 thanks
[00:02:16] <^d>	 :)
[00:03:05] <AaronSchulz>	 greg-g: I *think* that's the last of the math problems for now
[00:04:43] <grrrit-wm>	 (03PS2) 10TTO: Deprecate wgSkipSkin in favor of wgSkipSkins [core] - 10https://gerrit.wikimedia.org/r/113341 
[00:04:46] <ori>	 AaronSchulz: \o/
[00:06:05] <grrrit-wm>	 (03PS5) 10Inchikutty: [WIP] UploadWizard:OSM embedding- Geocoding, reverse geocoding [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/112342 
[00:06:39] <grrrit-wm>	 (03CR) 10TTO: "Good work finding the revision! I'll add that release note just as you wrote it. I like it." [core] - 10https://gerrit.wikimedia.org/r/113341 (owner: 10TTO)
[00:09:18] <grrrit-wm>	 (03CR) 10Ori.livneh: [C: 04-1] "Needs manual rebase" [tools/scap] - 10https://gerrit.wikimedia.org/r/112832 (owner: 10BryanDavis)
[00:12:07] <grrrit-wm>	 (03PS8) 10Matthias Mullie: Move cutting of index data into index code [extensions/Flow] - 10https://gerrit.wikimedia.org/r/112917 
[00:13:50] <grrrit-wm>	 (03Abandoned) 10Matthias Mullie: User User cache when loading usernames [extensions/Flow] - 10https://gerrit.wikimedia.org/r/100373 (owner: 10Matthias Mullie)
[00:14:29] <greg-g>	 AaronSchulz: yay!
[00:15:09] <grrrit-wm>	 (03CR) 10TTO: "Yep, this should fix 12330. That bug is very close to being a dupe of bug 954." [core] - 10https://gerrit.wikimedia.org/r/110162 (owner: 10TTO)
[00:15:30] <grrrit-wm>	 (03PS11) 10TTO: Add $wgLocalInterwikis to handle multiple local prefixes [core] - 10https://gerrit.wikimedia.org/r/110162 
[00:15:31] <grrrit-wm>	 (03PS5) 10TTO: Allow additional interwiki prefixes on local interwiki links [core] - 10https://gerrit.wikimedia.org/r/113329 
[00:16:27] <grrrit-wm>	 (03CR) 10TTO: "> this should fix 12330" [core] - 10https://gerrit.wikimedia.org/r/110162 (owner: 10TTO)
[00:16:49] <grrrit-wm>	 (03CR) 10TTO: "PS11: rebased" [core] - 10https://gerrit.wikimedia.org/r/110162 (owner: 10TTO)
[00:19:26] <grrrit-wm>	 (03CR) 10EBernhardson: Test permissions on multiple revisions in 1 object (031 comment) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/112844 (owner: 10Matthias Mullie)
[00:19:47] <grrrit-wm>	 (03CR) 10Matthias Mullie: [C: 031] Consolidate history i18n parameters into AbstractFormatter (031 comment) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/113157 (owner: 10EBernhardson)
[00:19:50] <grrrit-wm>	 (03PS3) 10Matthias Mullie: Consolidate history i18n parameters into AbstractFormatter [extensions/Flow] - 10https://gerrit.wikimedia.org/r/113157 (owner: 10EBernhardson)
[00:20:10] <grrrit-wm>	 (03CR) 10Matthias Mullie: [C: 032] "Yay for less duplicate code" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/113157 (owner: 10EBernhardson)
[00:20:21] <grrrit-wm>	 (03Merged) 10jenkins-bot: Consolidate history i18n parameters into AbstractFormatter [extensions/Flow] - 10https://gerrit.wikimedia.org/r/113157 (owner: 10EBernhardson)
[00:22:04] <grrrit-wm>	 (03PS2) 10BryanDavis: Touch ExtensionMessages-VERSION if not present [tools/scap] - 10https://gerrit.wikimedia.org/r/113260 
[00:22:15] <grrrit-wm>	 (03PS6) 10TTO: Allow additional interwiki prefixes on local interwiki links [core] - 10https://gerrit.wikimedia.org/r/113329 
[00:23:06] <grrrit-wm>	 (03CR) 10Anomie: [C: 032] "A little "git blame" archaeology is all it took ;)" [core] - 10https://gerrit.wikimedia.org/r/113341 (owner: 10TTO)
[00:25:03] <grrrit-wm>	 (03CR) 10BryanDavis: [C: 04-1] "I don't think this actually works. Testing in a dev environment seems to cause an exception:" [tools/scap] - 10https://gerrit.wikimedia.org/r/113260 (owner: 10BryanDavis)
[00:26:28] <grrrit-wm>	 (03Merged) 10jenkins-bot: Deprecate wgSkipSkin in favor of wgSkipSkins [core] - 10https://gerrit.wikimedia.org/r/113341 (owner: 10TTO)
[00:31:41] <grrrit-wm>	 (03PS2) 10BryanDavis: Rearrange modules to make more sense [tools/scap] - 10https://gerrit.wikimedia.org/r/112832 
[00:32:05] <grrrit-wm>	 (03PS1) 10Brian Wolff: Url encode page title for add subtitles link. [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/113489 
[00:32:09] <grrrit-wm>	 (03PS1) 10Matthias Mullie: Fix variable [extensions/Flow] - 10https://gerrit.wikimedia.org/r/113490 
[00:32:14] <grrrit-wm>	 (03CR) 10BryanDavis: "Patch set 2 is a manual rebase." [tools/scap] - 10https://gerrit.wikimedia.org/r/112832 (owner: 10BryanDavis)
[00:32:30] <grrrit-wm>	 (03CR) 10Matthias Mullie: [C: 032] Fix variable [extensions/Flow] - 10https://gerrit.wikimedia.org/r/113490 (owner: 10Matthias Mullie)
[00:32:39] <grrrit-wm>	 (03Merged) 10jenkins-bot: Fix variable [extensions/Flow] - 10https://gerrit.wikimedia.org/r/113490 (owner: 10Matthias Mullie)
[00:34:01] <grrrit-wm>	 (03PS4) 10EBernhardson: Test permissions on multiple revisions in 1 object [extensions/Flow] - 10https://gerrit.wikimedia.org/r/112844 (owner: 10Matthias Mullie)
[00:34:04] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] Test permissions on multiple revisions in 1 object [extensions/Flow] - 10https://gerrit.wikimedia.org/r/112844 (owner: 10Matthias Mullie)
[00:34:40] <grrrit-wm>	 (03CR) 10EBernhardson: "PS4: RevisionablePermissionsTest -> RevisionCollectionPermissionsTest" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/112844 (owner: 10Matthias Mullie)
[00:41:28] <grrrit-wm>	 (03PS1) 10EBernhardson: Add missing use statement [extensions/Flow] - 10https://gerrit.wikimedia.org/r/113491 
[00:41:41] <grrrit-wm>	 (03CR) 10EBernhardson: [C: 032] Add missing use statement [extensions/Flow] - 10https://gerrit.wikimedia.org/r/113491 (owner: 10EBernhardson)
[00:41:51] <grrrit-wm>	 (03Merged) 10jenkins-bot: Add missing use statement [extensions/Flow] - 10https://gerrit.wikimedia.org/r/113491 (owner: 10EBernhardson)
[00:44:13] <grrrit-wm>	 (03PS1) 10Matthias Mullie: Use Collection instead of manually fetching from storage [extensions/Flow] - 10https://gerrit.wikimedia.org/r/113492 
[00:44:38] <grrrit-wm>	 (03PS1) 10Matthias Mullie: Revert "Fix variable" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/113493 
[00:44:46] <grrrit-wm>	 (03CR) 10Matthias Mullie: [C: 032] Revert "Fix variable" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/113493 (owner: 10Matthias Mullie)
[00:44:57] <grrrit-wm>	 (03Merged) 10jenkins-bot: Revert "Fix variable" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/113493 (owner: 10Matthias Mullie)
[00:45:35] <grrrit-wm>	 (03PS1) 10Matthias Mullie: Fix variable [extensions/Flow] - 10https://gerrit.wikimedia.org/r/113494 
[00:46:28] <grrrit-wm>	 (03CR) 10Matthias Mullie: [C: 032] Fix variable [extensions/Flow] - 10https://gerrit.wikimedia.org/r/113494 (owner: 10Matthias Mullie)
[00:46:37] <grrrit-wm>	 (03Merged) 10jenkins-bot: Fix variable [extensions/Flow] - 10https://gerrit.wikimedia.org/r/113494 (owner: 10Matthias Mullie)
[00:56:22] <grrrit-wm>	 (03CR) 10Matthias Mullie: "This one's rather important." [extensions/Flow] - 10https://gerrit.wikimedia.org/r/112797 (owner: 10Matthias Mullie)
[01:02:31] <grrrit-wm>	 (03CR) 10Brian Wolff: [C: 04-1] "Don't worry about making multiple commits - that's all part of the process." (033 comments) [core] - 10https://gerrit.wikimedia.org/r/112323 (owner: 10Kunalgrover05)
[01:04:45] <grrrit-wm>	 (03PS5) 10Matthias Mullie: Test permissions on multiple revisions in 1 object [extensions/Flow] - 10https://gerrit.wikimedia.org/r/112844 
[01:04:48] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] Test permissions on multiple revisions in 1 object [extensions/Flow] - 10https://gerrit.wikimedia.org/r/112844 (owner: 10Matthias Mullie)
[01:09:51] <grrrit-wm>	 (03PS6) 10Matthias Mullie: Test permissions on multiple revisions in 1 object [extensions/Flow] - 10https://gerrit.wikimedia.org/r/112844 
[01:09:54] <grrrit-wm>	 (03PS4) 10Matthias Mullie: restore should look at previous revision for correct value [extensions/Flow] - 10https://gerrit.wikimedia.org/r/112840 
[01:09:57] <grrrit-wm>	 (03PS9) 10Matthias Mullie: Tests for PostCollection [extensions/Flow] - 10https://gerrit.wikimedia.org/r/112797 
[01:12:07] <grrrit-wm>	 (03PS4) 10Nemo bis: Tweak documentation for Title::getLocalUrl [core] - 10https://gerrit.wikimedia.org/r/111164 
[01:12:15] <grrrit-wm>	 (03CR) 10Brian Wolff: [C: 032] Tweak documentation for Title::getLocalUrl [core] - 10https://gerrit.wikimedia.org/r/111164 (owner: 10Nemo bis)
[01:16:24] <grrrit-wm>	 (03Merged) 10jenkins-bot: Tweak documentation for Title::getLocalUrl [core] - 10https://gerrit.wikimedia.org/r/111164 (owner: 10Nemo bis)
[01:27:16] <grrrit-wm>	 (03PS7) 10Bsitu: Add diff view of changes to board header [extensions/Flow] - 10https://gerrit.wikimedia.org/r/109431 
[01:27:21] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] Add diff view of changes to board header [extensions/Flow] - 10https://gerrit.wikimedia.org/r/109431 (owner: 10Bsitu)
[01:40:03] <grrrit-wm>	 (03PS1) 10Adamw: update DonationInterface submodule [core] (fundraising/REL1_22) - 10https://gerrit.wikimedia.org/r/113505 
[01:40:13] <grrrit-wm>	 (03CR) 10Adamw: [C: 032 V: 032] update DonationInterface submodule [core] (fundraising/REL1_22) - 10https://gerrit.wikimedia.org/r/113505 (owner: 10Adamw)
[01:52:06] <grrrit-wm>	 (03PS6) 10Matthias Mullie: Extract wiki and external links, file and template usages from text. [extensions/Flow] - 10https://gerrit.wikimedia.org/r/110090 (owner: 10Werdna)
[01:52:09] <grrrit-wm>	 (03PS1) 10Matthias Mullie: Use new history params callback stuff for history [extensions/Flow] - 10https://gerrit.wikimedia.org/r/113506 
[01:52:17] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] Extract wiki and external links, file and template usages from text. [extensions/Flow] - 10https://gerrit.wikimedia.org/r/110090 (owner: 10Werdna)
[01:52:24] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] Use new history params callback stuff for history [extensions/Flow] - 10https://gerrit.wikimedia.org/r/113506 (owner: 10Matthias Mullie)
[01:53:39] <grrrit-wm>	 (03PS2) 10Matthias Mullie: Use new history params callback stuff for history [extensions/Flow] - 10https://gerrit.wikimedia.org/r/113506 
[01:54:40] <grrrit-wm>	 (03CR) 10Matthias Mullie: "I just rebased (PS6) - need to go through the code in more detail yet" (034 comments) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/110090 (owner: 10Werdna)
[01:57:17] <grrrit-wm>	 (03PS1) 10Jforrester: Update OOjs to v1.0.7-pre (9c04f3e917) [core] - 10https://gerrit.wikimedia.org/r/113507 
[01:58:46] <grrrit-wm>	 (03CR) 10Catrope: [C: 032] Update OOjs to v1.0.7-pre (9c04f3e917) [core] - 10https://gerrit.wikimedia.org/r/113507 (owner: 10Jforrester)
[02:00:21] <grrrit-wm>	 (03PS1) 10Jforrester: Update OOjs UI to v0.1.0-pre (424b40373e) [core] - 10https://gerrit.wikimedia.org/r/113508 
[02:00:54] <grrrit-wm>	 (03CR) 10Catrope: [C: 032] Update OOjs UI to v0.1.0-pre (424b40373e) [core] - 10https://gerrit.wikimedia.org/r/113508 (owner: 10Jforrester)
[02:01:22] <grrrit-wm>	 (03CR) 10Bsitu: [C: 032] Use new history params callback stuff for history [extensions/Flow] - 10https://gerrit.wikimedia.org/r/113506 (owner: 10Matthias Mullie)
[02:01:34] <grrrit-wm>	 (03Merged) 10jenkins-bot: Use new history params callback stuff for history [extensions/Flow] - 10https://gerrit.wikimedia.org/r/113506 (owner: 10Matthias Mullie)
[02:03:04] <grrrit-wm>	 (03Merged) 10jenkins-bot: Update OOjs to v1.0.7-pre (9c04f3e917) [core] - 10https://gerrit.wikimedia.org/r/113507 (owner: 10Jforrester)
[02:04:23] <grrrit-wm>	 (03Merged) 10jenkins-bot: Update OOjs UI to v0.1.0-pre (424b40373e) [core] - 10https://gerrit.wikimedia.org/r/113508 (owner: 10Jforrester)
[02:08:07] <grrrit-wm>	 (03PS1) 10Adamw: update DonationInterface submodule [core] (fundraising/REL1_22) - 10https://gerrit.wikimedia.org/r/113511 
[02:08:17] <grrrit-wm>	 (03CR) 10Adamw: [C: 032 V: 032] update DonationInterface submodule [core] (fundraising/REL1_22) - 10https://gerrit.wikimedia.org/r/113511 (owner: 10Adamw)
[02:13:41] <grrrit-wm>	 (03PS1) 10Jforrester: Add scripts to generate update builds of OOjs and OOjs UI [core] - 10https://gerrit.wikimedia.org/r/113514 
[02:22:19] <grrrit-wm>	 (03PS1) 10Jforrester: Note OOjs and OOjs-UI presence in the RELEASE-NOTES [core] - 10https://gerrit.wikimedia.org/r/113517 
[02:40:03] <grrrit-wm>	 (03PS6) 10Inchikutty: [WIP] UploadWizard:OSM embedding- Geocoding, reverse geocoding [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/112342 
[02:41:46] <grrrit-wm>	 (03PS1) 10Brian Wolff: Decode html entities before comparing strings in #ifeq: and #switch [extensions/ParserFunctions] - 10https://gerrit.wikimedia.org/r/113518 
[02:41:52] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] Decode html entities before comparing strings in #ifeq: and #switch [extensions/ParserFunctions] - 10https://gerrit.wikimedia.org/r/113518 (owner: 10Brian Wolff)
[02:43:19] <grrrit-wm>	 (03PS7) 10Inchikutty: [WIP] UploadWizard:OSM embedding- Geocoding, reverse geocoding [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/112342 
[02:44:55] <grrrit-wm>	 (03CR) 10Brian Wolff: "02:41:51 There was 1 failure:" [extensions/ParserFunctions] - 10https://gerrit.wikimedia.org/r/113518 (owner: 10Brian Wolff)
[02:52:02] <grrrit-wm>	 (03PS11) 10Jforrester: Feedback includes browser info, given user permission [core] - 10https://gerrit.wikimedia.org/r/32700 (owner: 10Nischayn22)
[02:52:16] <grrrit-wm>	 (03CR) 10Jforrester: "PS11 is a rebase." [core] - 10https://gerrit.wikimedia.org/r/32700 (owner: 10Nischayn22)
[02:57:37] <grrrit-wm>	 (03CR) 10Brian Wolff: "I filed bug 61410 for unit tests being broken." [extensions/ParserFunctions] - 10https://gerrit.wikimedia.org/r/113518 (owner: 10Brian Wolff)
[03:01:46] <grrrit-wm>	 (03PS12) 10Jforrester: Feedback includes browser info, given user permission [core] - 10https://gerrit.wikimedia.org/r/32700 (owner: 10Nischayn22)
[03:26:04] <superm401>	 ori, is it possible to remove a MediaWiki-Vagrant role?
[03:26:25] <ori>	 superm401: what do you mean? with respect to a given VM, or the repository?
[03:26:32] <superm401>	 ori, the repo.
[03:26:33] <superm401>	 I'm trying to upgrade XDebug beyond what's in Ubuntu's repo, and it seems PECL might be easiest.
[03:26:49] <superm401>	 But that would mean removing php5-xdebug.
[03:27:07] <ori>	 go for it
[03:27:11] <superm401>	 However, that is in both the role and puppet/modules/php/manifests/init.pp
[03:27:21] <superm401>	 It seems for back-compat, it might be best to have remote_debug always on.
[03:27:21] <ori>	 that's ok, remove it from both
[03:27:41] <superm401>	 Or we can just tell people to enable the remote_debug role if it stops working.
[03:27:56] <superm401>	 I also think I should do an ensure absent for the apt package so it won't clash.
[03:28:03] <ori>	 i don't want to turn backward-compatibility into a bigger requirement than it really is; VMs are cheap and vagrant's value proposition rests with ease-of-use rather than long-term stability
[03:28:32] <superm401>	 Okay.  It's only two commands to fix anyway (enable_role remote_debug, provision).
[03:29:01] <ori>	 what about making the PECL xdebug part of the default role?
[03:30:00] <superm401>	 ori, yeah, that's kind of what I was saying, remove the role, and make it always on.
[03:30:33] <ori>	 what are the costs? does it add some performance overhead?
[03:30:43] <ori>	 i guess i should re-read the role so i know what exactly you're referring to
[03:30:48] <superm401>	 ori, I don't think so, unless you pass some special header or URL param to enable it.
[03:31:00] <ori>	 ah, right
[03:31:23] <ori>	 yeah, i think that's the right way to go
[03:31:41] <ori>	 it doesn't really fit the notion of a "role" very well anyway
[03:32:22] <ori>	 and in general we configure things for ease of development/debugging so it makes sense to have that be the default
[03:33:04] <superm401>	 Right, and I think it's supposed to only noticeably impact perf if one of http://xdebug.org/docs/remote#browser_session is set (i.e. you're using the browser extension).
[03:33:27] <grrrit-wm>	 (03PS4) 10Prtksxna: [WIP] Truncate extract to 250 characters [WIP] [extensions/Popups] - 10https://gerrit.wikimedia.org/r/113063 
[03:33:40] <superm401>	 Okay, will remove the role and absent the old package.
[03:40:54] <ori>	 superm401: i wonder if we should have a ppa on launchpad for mediawiki-vagrant
[03:41:01] <ori>	 containing all the custom packages
[03:41:08] <ori>	 it's very easy to copy packages from other PPAs
[03:41:30] <ori>	 e.g. i just copied xdebug 2.2.3 for precise: https://launchpad.net/~ori-livneh/+archive/mediawiki-vagrant/+packages
[03:41:36] <superm401>	 ori, what's the use case?
[03:41:58] <superm401>	 Oh, I was going to use PECL, since it's mentioned at http://xdebug.org/docs/install, and I didn't see any mention of the PPAs.
[03:42:00] <ori>	 well, we already use the git-maintainers ppa, so we would just use a single ppa
[03:42:41] <ori>	 it would be the sole complement to apt.wm.o and the standard ubuntu repos in terms of packages
[03:42:54] <ori>	 i wouldn't want that to be tied to my personal account tho
[03:43:21] <superm401>	 I don't think it's a big deal either way (even a lot of regular machines have multiple files in sources.list.d), but I can see how there's a certain cleanness to that.
[03:43:51] <superm401>	 And it might save a little time on apt-get update.
[03:44:18] <ori>	 you can create teams in launchpad for free
[03:45:08] <superm401>	 Or we could put it in apt.wikimedia.org.
[03:45:16] <superm401>	 Don't know how rigorous the inclusion policy is for that.
[03:47:13] <ori>	 oops gotta run, bbl
[04:21:58] <superm401>	 ori, so, removing roles does not work well.
[04:22:23] <superm401>	 You get 'Could not find class role::remote_debug for mediawiki-vagrant.dev at /tmp/vagrant-puppet/manifests/manifests.d/vagrant-managed.pp:8 on node mediawiki-vagrant.dev'
[04:22:33] <superm401>	 I'm just going to make it a role class enabled by default, like role::mysql
[04:37:03] <ori>	 superm401: nah, removing roles has to work. i think it does, but if it doesn't i'll just fix it.
[04:37:58] <superm401>	 ori, okay, I don't think that fix is a blocker, but when it's done you can un-role it.
[04:38:05] <superm401>	 Still testing the PECL version.
[04:42:23] <superm401>	 ori, PECL works, and fixes the bug that caused me to dig into this (it was showing "CLASSNAME Title" instead of the actual members of the Title object).
[04:56:16] <grrrit-wm>	 (03PS1) 10Mattflaschen: Upgrade XDebug, always enable, switch from apt to PECL [vagrant] - 10https://gerrit.wikimedia.org/r/113519 
[04:58:37] <grrrit-wm>	 (03PS1) 10Ori.livneh: Prune invalid roles from vagrant-managed.pp [vagrant] - 10https://gerrit.wikimedia.org/r/113520 
[04:58:39] <grrrit-wm>	 (03PS1) 10Ori.livneh: Make 'remote_debug' PHP settings the default; retire role [vagrant] - 10https://gerrit.wikimedia.org/r/113521 
[04:58:51] <ori>	 superm401: i'll review yours if you review mine :P
[04:59:39] <superm401>	 ori, deal, but first I want to finish what originally triggered me to fix the debugger. :)
[05:21:42] <grrrit-wm>	 (03PS1) 10leucosticte: Implement way to get the ID of a deleted page from deletion logs. WikiPage::doDeleteArticleReal will tell ManualLogEntry::insert() what the page_id is, so it can be stored in log_page; then ApiQueryLogEvents will provide that data. [core] - 10https://gerrit.wikimedia.org/r/113523 
[05:37:30] <grrrit-wm>	 (03CR) 10Mattflaschen: [C: 04-1] "ApiQueryLogEvents seems generally fine. However, I haven't fully reviewed it." (031 comment) [core] - 10https://gerrit.wikimedia.org/r/113523 (owner: 10leucosticte)
[05:44:45] <grrrit-wm>	 (03Abandoned) 10leucosticte: Implement way to get the ID of a deleted page from deletion logs. WikiPage::doDeleteArticleReal will tell ManualLogEntry::insert() what the page_id is, so it can be stored in log_page; then ApiQueryLogEvents will provide that data. [core] - 10https://gerrit.wikimedia.org/r/113523 (owner: 10leucosticte)
[05:56:54] <grrrit-wm>	 (03PS1) 10Ori.livneh: remove deprecated %n and %l format specifiers [extensions/EventLogging] - 10https://gerrit.wikimedia.org/r/113524 
[05:57:27] <grrrit-wm>	 (03PS2) 10Ori.livneh: remove deprecated %n and %l format specifiers; version 0.7 [extensions/EventLogging] - 10https://gerrit.wikimedia.org/r/113524 
[05:58:02] <grrrit-wm>	 (03CR) 10Ori.livneh: [C: 032] remove deprecated %n and %l format specifiers; version 0.7 [extensions/EventLogging] - 10https://gerrit.wikimedia.org/r/113524 (owner: 10Ori.livneh)
[05:58:34] <grrrit-wm>	 (03Merged) 10jenkins-bot: remove deprecated %n and %l format specifiers; version 0.7 [extensions/EventLogging] - 10https://gerrit.wikimedia.org/r/113524 (owner: 10Ori.livneh)
[07:14:59] <grrrit-wm>	 (03PS1) 10Mattflaschen: WIP: Store the page_id in the logging table for deletions. [core] - 10https://gerrit.wikimedia.org/r/113525 
[07:16:19] <grrrit-wm>	 (03PS2) 10EBernhardson: No need to load workflow in formatters [extensions/Flow] - 10https://gerrit.wikimedia.org/r/112846 
[07:16:35] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] No need to load workflow in formatters [extensions/Flow] - 10https://gerrit.wikimedia.org/r/112846 (owner: 10EBernhardson)
[07:17:26] <grrrit-wm>	 (03CR) 10Mattflaschen: "I put the actual log_page part up at https://gerrit.wikimedia.org/r/113525" [core] - 10https://gerrit.wikimedia.org/r/113523 (owner: 10leucosticte)
[07:20:50] <grrrit-wm>	 (03PS3) 10EBernhardson: No need to load workflow in formatters [extensions/Flow] - 10https://gerrit.wikimedia.org/r/112846 
[07:21:43] <grrrit-wm>	 (03CR) 10Mattflaschen: "This solves the database part, but not the logevents API. If this part makes sense, I'm hoping to use leucosticte's ApiQueryLogEvents wor" [core] - 10https://gerrit.wikimedia.org/r/113525 (owner: 10Mattflaschen)
[07:28:32] <superm401>	 ori, I'm going to rebase my xdebug change on top of your prune one, and change it not to be a role.  That will make it easy to test the prune change.
[07:29:52] <grrrit-wm>	 (03CR) 10Mattflaschen: "I'm basically doing the same thing in https://gerrit.wikimedia.org/r/113519 , but with a class used within a class (basically, composition" [vagrant] - 10https://gerrit.wikimedia.org/r/113521 (owner: 10Ori.livneh)
[07:43:50] <grrrit-wm>	 (03CR) 10Mattflaschen: [C: 032] "Looks good, and works perfectly. Tested by removing role::remote_debug" [vagrant] - 10https://gerrit.wikimedia.org/r/113520 (owner: 10Ori.livneh)
[07:43:54] <grrrit-wm>	 (03Merged) 10jenkins-bot: Prune invalid roles from vagrant-managed.pp [vagrant] - 10https://gerrit.wikimedia.org/r/113520 (owner: 10Ori.livneh)
[07:48:25] <grrrit-wm>	 (03PS2) 10Mattflaschen: Upgrade XDebug, always enable, switch from apt to PECL [vagrant] - 10https://gerrit.wikimedia.org/r/113519 
[08:53:28] <grrrit-wm>	 (03CR) 10Hashar: [C: 032] Rearrange modules to make more sense [tools/scap] - 10https://gerrit.wikimedia.org/r/112832 (owner: 10BryanDavis)
[08:53:31] <grrrit-wm>	 (03Merged) 10jenkins-bot: Rearrange modules to make more sense [tools/scap] - 10https://gerrit.wikimedia.org/r/112832 (owner: 10BryanDavis)
[08:53:51] <grrrit-wm>	 (03PS1) 10Gomoko: Typo correction [extensions/Drafts] - 10https://gerrit.wikimedia.org/r/113526 
[08:54:48] <grrrit-wm>	 (03PS1) 10EBernhardson: Cache created objects within the mapper [extensions/Flow] - 10https://gerrit.wikimedia.org/r/113527 
[08:54:51] <grrrit-wm>	 (03PS1) 10EBernhardson: fastpath getMulti/gotMulti when using CachingObjectMapper [extensions/Flow] - 10https://gerrit.wikimedia.org/r/113528 
[09:33:19] <grrrit-wm>	 (03PS2) 10Gomoko: Corrections for PHP 5.4 and FF 26 [extensions/Drafts] - 10https://gerrit.wikimedia.org/r/105200 
[09:49:51] <grrrit-wm>	 (03CR) 10Gomoko: "See bug report 61414" [core] - 10https://gerrit.wikimedia.org/r/104905 (owner: 10Gomoko)
[09:50:20] <grrrit-wm>	 (03Abandoned) 10Gomoko: Typo correction [extensions/Drafts] - 10https://gerrit.wikimedia.org/r/113526 (owner: 10Gomoko)
[10:28:56] <grrrit-wm>	 (03Abandoned) 10Umherirrender: Expand cleanupPreferences.php script to handle unused preferences [core] - 10https://gerrit.wikimedia.org/r/101233 (owner: 10Umherirrender)
[10:58:23] <grrrit-wm>	 (03CR) 10Bartosz Dziewoński: [C: 032] Note OOjs and OOjs-UI presence in the RELEASE-NOTES [core] - 10https://gerrit.wikimedia.org/r/113517 (owner: 10Jforrester)
[11:02:11] <grrrit-wm>	 (03Merged) 10jenkins-bot: Note OOjs and OOjs-UI presence in the RELEASE-NOTES [core] - 10https://gerrit.wikimedia.org/r/113517 (owner: 10Jforrester)
[11:51:21] <grrrit-wm>	 (03PS3) 10Nemo bis: Fixing issue of multiple quality prefixes in summary [extensions/ProofreadPage] - 10https://gerrit.wikimedia.org/r/113064 (owner: 10Xelgen)
[11:51:52] <grrrit-wm>	 (03PS4) 10Nemo bis: Fixing issue of multiple quality prefixes in summary [extensions/ProofreadPage] - 10https://gerrit.wikimedia.org/r/113064 (owner: 10Xelgen)
[11:53:01] <grrrit-wm>	 (03CR) 10Nemo bis: "Thanks for your patches, I hope to see more. :) I've tweaked the commit message a bit; this section might also be of use for your next com" [extensions/ProofreadPage] - 10https://gerrit.wikimedia.org/r/113064 (owner: 10Xelgen)
[11:55:37] <grrrit-wm>	 (03CR) 10Nemo bis: "This needs/follows up on If92eaa980e36ac6497a8b97c7272c8393ce431bf, right? Welcome and thanks for fixing hard-coded configuration in exten" [extensions/WikimediaMessages] - 10https://gerrit.wikimedia.org/r/111693 (owner: 10Wctaiwan)
[12:00:01] <grrrit-wm>	 (03CR) 10Nemo bis: "+1 on i18n (Siebrand's request for int was satisfied), but needs rebase. <https://www.mediawiki.org/wiki/Gerrit/Advanced_usage#Build_faile" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/111710 (owner: 10Wctaiwan)
[12:08:17] <grrrit-wm>	 (03PS5) 10Tpt: Fixing issue of multiple quality prefixes in summary [extensions/ProofreadPage] - 10https://gerrit.wikimedia.org/r/113064 (owner: 10Xelgen)
[12:10:05] <grrrit-wm>	 (03CR) 10Tpt: "PS5: fix a bad use of the String.replace() method" [extensions/ProofreadPage] - 10https://gerrit.wikimedia.org/r/113064 (owner: 10Xelgen)
[12:10:42] <grrrit-wm>	 (03Abandoned) 10Umherirrender: Give warning on account creation when user name is adjusted silently [core] - 10https://gerrit.wikimedia.org/r/104926 (owner: 10Umherirrender)
[12:10:49] <grrrit-wm>	 (03CR) 10Tpt: [C: 032] "I merge the two changes one just after the other in order to avoid you a difficult git manipulation." [extensions/ProofreadPage] - 10https://gerrit.wikimedia.org/r/112806 (owner: 10Xelgen)
[12:10:54] <grrrit-wm>	 (03Merged) 10jenkins-bot: page.edit.js: Preserve content of edit summary on quality change [extensions/ProofreadPage] - 10https://gerrit.wikimedia.org/r/112806 (owner: 10Xelgen)
[12:11:06] <grrrit-wm>	 (03CR) 10Tpt: [C: 032] Fixing issue of multiple quality prefixes in summary [extensions/ProofreadPage] - 10https://gerrit.wikimedia.org/r/113064 (owner: 10Xelgen)
[12:11:11] <grrrit-wm>	 (03Merged) 10jenkins-bot: Fixing issue of multiple quality prefixes in summary [extensions/ProofreadPage] - 10https://gerrit.wikimedia.org/r/113064 (owner: 10Xelgen)
[12:21:11] <danrivcap>	 hi I saw wikimedia has implemented Configuration Management and I am interested in the proccess and what is the advantages to do CM in wikimedia
[12:22:30] <whym_away>	 are you talking about https://www.mediawiki.org/wiki/Configuration_management ?
[12:22:58] <whym_away>	 danrivcap: or maybe https://www.mediawiki.org/wiki/MediaWiki-Vagrant ?
[12:24:30] <whym_away>	 I have no specific knowledge on both, but from what I remember, the former is not yet implemented, the latter is fully working.
[12:25:16] <danrivcap>	 borh are in my interest
[12:25:32] <danrivcap>	 I am researching about CM in opensource proyects
[12:29:35] <danrivcap>	 and how they manage configuration between versions and envirornments
[12:34:14] <whym_away>	 danrivcap: ok so this is some of how we manage configurations (and there are many other parts I'm sure): https://gerrit.wikimedia.org/r/#/q/status:open+project:operations/mediawiki-config,n,z
[12:35:09] <whym_away>	 danrivcap: for IRC convesation I also recommend getting here in daytime in pacific standard time
[12:35:26] <whym_away>	 and weekdays
[12:35:37] <whym_away>	 most of the relevant persons would be active in that time
[12:36:41] <whym_away>	 wikitech-l would be fine for asking for pointers, too
[12:36:41] <danrivcap>	 I know, it is difficult but I ill try
[12:36:50] <whym_away>	 https://lists.wikimedia.org/mailman/listinfo/wikitech-l
[12:42:32] <grrrit-wm>	 (03CR) 10Bartosz Dziewoński: "Moving all of the rules to the mediawiki.searchSuggest.css file means that code using plain jquery.suggestions will no longer apply any so" [core] - 10https://gerrit.wikimedia.org/r/111180 (owner: 10Bartosz Dziewoński)
[12:43:57] <MatmaRex>	 can somebody who has them all checked out grep all extensions for 'jquery.suggestions' for me?
[13:06:52] <Nemo_bis>	 all the 4500 of them? :)
[13:07:18] <Nemo_bis>	 MatmaRex: you can use /mnt/user-store/git on toolserver
[13:08:21] <Nemo_bis>	 hmm ls: cannot access ../matmarex/public_html: No such file or directory
[13:08:25] <MatmaRex>	 toolserver or tools?
[13:08:34] <MatmaRex>	 i think i already burned-bridges on toolserver
[13:08:44] <Nemo_bis>	 looks so from the error above
[13:08:48] <Nemo_bis>	 worse for you ;)
[13:08:54] <MatmaRex>	 heh
[13:11:48] <Nemo_bis>	 there is /data/project/supercalifragilisticexpialidocious though
[13:24:58] <Punitkoura>	 where can I find code providing the feed feature for recent changes ?
[13:31:11] <MatmaRex>	 Punitkoura: currently mostly in includes/specialpage/ChangesListSpecialPage.php, includes/specials/SpecialRecentchanges.php and includes/ChangesFeed.php
[13:31:22] <MatmaRex>	 Punitkoura: i have a change pending that would consolidate this a little bit: https://gerrit.wikimedia.org/r/#/c/110864/
[13:36:55] <grrrit-wm>	 (03PS6) 10Bartosz Dziewoński: ChangesListSpecialPage: Remove all functionality for generating feeds [core] - 10https://gerrit.wikimedia.org/r/110864 
[13:38:24] <grrrit-wm>	 (03CR) 10Bartosz Dziewoński: "Rebased." [core] - 10https://gerrit.wikimedia.org/r/110864 (owner: 10Bartosz Dziewoński)
[13:48:34] <grrrit-wm>	 (03PS7) 10Bartosz Dziewoński: ChangesListSpecialPage: Separate all functionality for generating feeds [core] - 10https://gerrit.wikimedia.org/r/110864 
[13:49:01] <grrrit-wm>	 (03CR) 10Bartosz Dziewoński: "Some minor cleanup. Merge, anyone? :)" [core] - 10https://gerrit.wikimedia.org/r/110864 (owner: 10Bartosz Dziewoński)
[14:00:43] <grrrit-wm>	 (03CR) 10UltrasonicNXT: Flood control, Tab nick completion, Nick mention hilight, new sounds, Check to disable sounds, Settings to disable mediawiki parsing, resize (031 comment) [extensions/MediaWikiChat] - 10https://gerrit.wikimedia.org/r/113164 (owner: 10Gerrit Patch Uploader)
[14:46:01] <grrrit-wm>	 (03CR) 10Krusher: Flood control, Tab nick completion, Nick mention hilight, new sounds, Check to disable sounds, Settings to disable mediawiki parsing, resize (031 comment) [extensions/MediaWikiChat] - 10https://gerrit.wikimedia.org/r/113164 (owner: 10Gerrit Patch Uploader)
[15:19:58] <Krenair>	 Shouldn't the footer on email notifications say 6th floor rather than 3rd?
[15:28:12] <grrrit-wm>	 (03CR) 10Umherirrender: "Would be nice, if this can be merged without jenkins." [extensions/ParserFunctions] - 10https://gerrit.wikimedia.org/r/110582 (owner: 10Umherirrender)
[15:37:21] <Punitkoura>	 I am trying to solve a bug on recent changes
[15:37:38] <Punitkoura>	 basically to change the message titles
[15:38:03] <Punitkoura>	 Please could someone guide me to the files containing code pertaining to that
[15:43:02] <grrrit-wm>	 (03PS5) 10Umherirrender: Add sequence support for upsert in DatabaseOracle [core] - 10https://gerrit.wikimedia.org/r/110991 
[15:47:31] <Punitkoura>	 where can I add the wgdebug log file name?
[15:48:12] <grrrit-wm>	 (03CR) 10Umherirrender: "Maybe superseeded by I06f66f44b623dbebf599bd1ea5416820c448d825, when that gets merged, but I have no problem when this gets merged first, " [core] - 10https://gerrit.wikimedia.org/r/112121 (owner: 10Umherirrender)
[15:56:35] <grrrit-wm>	 (03PS2) 10Jean-Frédéric: add Art Photo template to GWToolset [extensions/GWToolset] - 10https://gerrit.wikimedia.org/r/113369 (owner: 10Dan-nl)
[15:58:57] <grrrit-wm>	 (03CR) 10Jean-Frédéric: [C: 031] "Amended the commit on two points:" [extensions/GWToolset] - 10https://gerrit.wikimedia.org/r/113369 (owner: 10Dan-nl)
[16:05:11] <grrrit-wm>	 (03CR) 10leucosticte: [C: 031] "I didn't test it, but it looks okay. +0.5, then, I guess. ;)" (032 comments) [core] - 10https://gerrit.wikimedia.org/r/113525 (owner: 10Mattflaschen)
[16:08:44] <grrrit-wm>	 (03CR) 10leucosticte: "Oh, sorry, I missed the comment you placed in the code explaining why you moved the log entry publication. It makes sense to me now. Good " [core] - 10https://gerrit.wikimedia.org/r/113525 (owner: 10Mattflaschen)
[16:11:20] <grrrit-wm>	 (03PS1) 10Bartosz Dziewoński: mediawiki.js: Add missing bug number reference [core] - 10https://gerrit.wikimedia.org/r/113539 
[16:16:58] <MatmaRex>	 ^ trivial
[16:17:20] <grrrit-wm>	 (03PS1) 10Bartosz Dziewoński: Preload mediawiki.notification when we know we're going to need it soon [core] - 10https://gerrit.wikimedia.org/r/113540 
[16:17:21] <MatmaRex>	 also rather trivial ^
[16:17:22] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] Preload mediawiki.notification when we know we're going to need it soon [core] - 10https://gerrit.wikimedia.org/r/113540 (owner: 10Bartosz Dziewoński)
[16:17:42] <MatmaRex>	 !bug hash-mismatch
[16:18:35] <grrrit-wm>	 (03CR) 10Bartosz Dziewoński: "False merge failure probably caused by https://bugzilla.wikimedia.org/show_bug.cgi?id=hash-mismatch , please ignore it. This is based on m" [core] - 10https://gerrit.wikimedia.org/r/113540 (owner: 10Bartosz Dziewoński)
[16:19:57] <grrrit-wm>	 (03PS2) 10Bartosz Dziewoński: Preload mediawiki.notification when we know we're going to need it soon [core] - 10https://gerrit.wikimedia.org/r/113540 
[16:21:47] <Punitkoura>	  I am trying to solve a bug on recent changes.  basically to change the message titles.  Please could someone guide me to the files containing code pertaining to that?
[16:29:56] <grrrit-wm>	 (03PS3) 10UltrasonicNXT: Flood control, Tab nick completion, Nick mention hilight, new sounds, Check to disable sounds, Settings to disable mediawiki parsing, resizeable window. Does not include OGG files, so sounds won't work until added. [extensions/MediaWikiChat] - 10https://gerrit.wikimedia.org/r/113164 (owner: 10Gerrit Patch Uploader)
[16:32:15] <grrrit-wm>	 (03CR) 10UltrasonicNXT: "Bit of code style, made mentions fade out, and stopped autocompletion for your own name there." [extensions/MediaWikiChat] - 10https://gerrit.wikimedia.org/r/113164 (owner: 10Gerrit Patch Uploader)
[16:32:52] <grrrit-wm>	 (03PS1) 10Martineznovo: Some corrections to interwiki_local_x_intro messages [extensions/Interwiki] - 10https://gerrit.wikimedia.org/r/113541 
[16:33:27] <grrrit-wm>	 (03PS4) 10UltrasonicNXT: Flood control, Tab nick completion, Nick mention hilight, new sounds, Check to disable sounds, Settings to disable mediawiki parsing, resizeable window. Does not include OGG files, so sounds won't work until added. [extensions/MediaWikiChat] - 10https://gerrit.wikimedia.org/r/113164 (owner: 10Gerrit Patch Uploader)
[16:36:37] <Punitkoura>	 I am trying to solve a bug on recent changes.  basically to change the message titles.  Please could someone guide me to the files containing code pertaining to that?
[16:40:48] <grrrit-wm>	 (03PS5) 10UltrasonicNXT: Flood control, Tab nick completion, Nick mention hilight, new sounds, Check to disable sounds, Settings to disable mediawiki parsing, resizeable window. Does not include OGG files, so sounds won't work until added. [extensions/MediaWikiChat] - 10https://gerrit.wikimedia.org/r/113164 (owner: 10Gerrit Patch Uploader)
[16:48:12] <Punitkoura>	 Umm
[16:48:42] <Punitkoura>	 Could someone guide me to the class responsible for creating content on the Recent changes page?
[16:57:21] <Punitkoura>	 Could someone point me to the code used to generate the title and description of Recent Changes page?
[16:59:18] <Krenair>	 Punitkoura, okay, so to do something like this, first you'll want to know the message name. You can find these by going to the page with uselang=qqx. The message key for Special:RecentChanges' title is 'recentchanges'.
[17:03:38] <Krenair>	 Punitkoura, for most messages from there you should be able to just grep for that text and usually it'll come up.
[17:05:27] <Krenair>	 However specialpages like this rely on SpecialPage::getDescription by default, which just takes the special page name, makes it lowercase and looks up the message with that. In this case, that's 'recentchanges'
[17:07:07] <Krenair>	 The description is dealt with in a similar way in SpecialPage::outputHeader - it lowercases the name, adds '-summary' and looks up the message with that key
[17:07:58] <Punitkoura>	 ok, but I am not able to understand what does the uselang parameter do.
[17:08:37] <Punitkoura>	 and to do grep how should I open up the page in command line Krenair
[17:09:18] <Punitkoura>	 I am trying to change the title of the messages that are displayed in the Recent Changes feed, Krenair
[17:09:23] <Krenair>	 uselang changes the language of the page it sends back to you. 'qqx' is a special 'language' which actually just shows you the message keys of everything and what parameters were passed
[17:10:11] <Krenair>	 To use grep, just open a up a terminal, browse to your clone of core, and run the command. Usually it'll be something like: grep <pattern> <filename/file pattern>
[17:10:37] <Krenair>	 (there are other tools which do similar things but I find grep fairly simple to use)
[17:12:11] <Krenair>	 Punitkoura, so you want to change the title at the top of Special:RecentChanges. All you need to do is go to languages/messages/Messages<YourLangCode>.php and modify the values of the key 'recentchanges'
[17:12:17] <Krenair>	 value*
[17:12:44] <Punitkoura>	 Actually I am trying to solve the bug https://bugzilla.wikimedia.org/show_bug.cgi?id=17869#c4
[17:13:22] <Punitkoura>	 It requires me to change the title of messages when Users are created or removed
[17:14:17] <Krenair>	 Oh okay, so this is about the atom/rss feed stuff.
[17:14:40] <Punitkoura>	 yes
[17:14:58] <Punitkoura>	 and I am having a hard time trying to figure out the code
[17:15:58] <Punitkoura>	 could you direct me to the relevant files Krenair ?
[17:17:00] <Krenair>	 Sorry, I had thought you were trying to do something completely different, it wasn't very clear Punitkoura 
[17:18:10] <Punitkoura>	 I am sorry for that... Krenair. I am myself confused .
[17:20:04] <grrrit-wm>	 (03CR) 10Freakolowsky: [C: 031] Add sequence support for upsert in DatabaseOracle [core] - 10https://gerrit.wikimedia.org/r/110991 (owner: 10Umherirrender)
[17:26:33] <grrrit-wm>	 (03PS1) 10UltrasonicNXT: Fix kick logging [extensions/MediaWikiChat] - 10https://gerrit.wikimedia.org/r/113543 
[17:33:23] <grrrit-wm>	 (03CR) 10UltrasonicNXT: [V: 032] "Not sure how that got in!" [extensions/MediaWikiChat] - 10https://gerrit.wikimedia.org/r/113543 (owner: 10UltrasonicNXT)
[17:33:58] <grrrit-wm>	 (03CR) 10UltrasonicNXT: [C: 032] "Not sure how that got in!" [extensions/MediaWikiChat] - 10https://gerrit.wikimedia.org/r/113543 (owner: 10UltrasonicNXT)
[17:38:04] <huh>	 I know I asked this before but I want to be extra sure.
[17:38:19] <huh>	 May I submit a patch for something before there is community consensus?
[17:51:47] <huh>	 I'll just assume yes.
[17:52:14] <grrrit-wm>	 (03PS4) 10Wctaiwan: Make terms of use non-WMF specific [extensions/Flow] - 10https://gerrit.wikimedia.org/r/111710 
[17:52:17] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] Make terms of use non-WMF specific [extensions/Flow] - 10https://gerrit.wikimedia.org/r/111710 (owner: 10Wctaiwan)
[17:53:38] <Punitkoura>	 Excuse me, could someone explain the significance of system messages. 
[17:54:16] <Punitkoura>	 How do we interpret these messages? and do they represent real variable/functions ?
[17:54:39] <Punitkoura>	 I know that we can see these messages using uselang = qqx
[17:55:28] <Punitkoura>	 but I am not able to find out much about the messages 
[18:06:12] <huh>	 Punitkoura: they are strings
[18:06:21] <huh>	 not functions
[18:06:29] <grrrit-wm>	 (03CR) 10Anomie: [V: 032] mb_substr() expects parameter 2 to be long, string given [extensions/ParserFunctions] - 10https://gerrit.wikimedia.org/r/110582 (owner: 10Umherirrender)
[18:06:53] <huh>	 Punitkoura: what exactly do you mean?
[18:07:05] <huh>	 does https://www.mediawiki.org/wiki/I18n help?
[18:08:14] <Punitkoura>	 huh: ok. Actually I am trying to find the code responsible for generating the rss/atom feed of Recent Changes. Could you help me out?
[18:09:29] <huh>	 Punitkoura: that's in core
[18:09:58] <huh>	 Or is it?
[18:10:25] <Punitkoura>	 huh: I know it is in Core. Could you be more specific?
[18:11:02] <huh>	 sure, __rsrc__
[18:11:14] <huh>	 Punitkoura: meant to paste https://doc.wikimedia.org/mediawiki-core/master/php/html/Feed_8php.html
[18:11:18] <huh>	 sorry for writing something else
[18:12:01] <huh>	 Punitkoura: also https://www.mediawiki.org/wiki/Manual:$wgFeedClasses
[18:12:36] <huh>	 Punitkoura: https://doc.wikimedia.org/mediawiki-core/master/php/html/Feed_8php.html you can view the source of any of these classes there
[18:12:42] <huh>	 Does that help?
[18:13:13] <huh>	 ...
[18:15:36] <huh>	 Punitkoura: how can I help?
[18:17:05] <Punitkoura>	 huh: You have already helped me. I am just going through the files you sent me. Thanks :-)
[18:19:31] <huh>	 Punitkoura: Wikimedia also has Extension:RSS installed
[18:19:59] <Punitkoura>	 huh: by default?
[18:20:32] <huh>	 no, only on some wikis
[18:20:49] <Punitkoura>	 ok
[18:20:56] <huh>	 like mediawiki.org
[18:23:42] <Punitkoura>	 huh: actually I am trying to solve the bug https://bugzilla.wikimedia.org/show_bug.cgi?id=17869
[18:23:46] <grrrit-wm>	 (03PS5) 10Wctaiwan: Make terms of use non-WMF specific [extensions/Flow] - 10https://gerrit.wikimedia.org/r/111710 
[18:24:22] <Punitkoura>	 huh: any ideas?
[18:24:46] <huh>	 Punitkoura: I've never written any serious code for Wikimedia, so I doubt I can help
[18:24:48] <huh>	 sorry
[18:24:59] <Punitkoura>	 ok sure :-)
[18:25:00] <huh>	 Also I'm not familiar with RSS/atom
[18:27:49] <huh>	 Punitkoura: personally, the current RSS seems fine
[18:28:03] <huh>	 it's already in the <description>
[18:28:42] <Punitkoura>	 huh: yes. the description covers it
[18:28:44] <Nemo_bis>	 Punitkoura: you already had been answered this question
[18:29:06] <Nemo_bis>	 14.31 < MatmaRex> Punitkoura: currently mostly in includes/specialpage/ChangesListSpecialPage.php, includes/specials/SpecialRecentchanges.php and includes/ChangesFeed.php
[18:29:10] <Nemo_bis>	 14.31 < MatmaRex> Punitkoura: i have a change pending that would consolidate this a little bit: https://gerrit.wikimedia.org/r/#/c/110864/
[18:29:16] <Nemo_bis>	 5 hours ago
[18:29:26] <Nemo_bis>	 let me know where to post this answer so that you don't lose it again
[18:29:45] <huh>	 Oh, it's in SpecialRecentchanges, Nemo_bis ?
[18:29:54] <Nemo_bis>	 of course, RC code is a mess
[18:30:09] <huh>	 yeah, bad design if it's in the Special page code
[18:30:34] <Punitkoura>	 Nemo_bis : I know, but I don't seem to figure anything out from these three pages
[18:31:00] <huh>	 that's a mess
[18:32:12] <Punitkoura>	 Nemo_bis : I am sorry if I have offended you. 
[18:33:29] <Nemo_bis>	 pages?
[18:33:38] <Nemo_bis>	 I'm not offended, you're only harming yourself
[18:34:05] <Punitkoura>	 Nemo_bis : I mean files
[18:34:28] <Nemo_bis>	 You could probably review the change you've been pointed to, in order to understand the code better https://gerrit.wikimedia.org/r/#/c/110864/
[18:34:45] <Punitkoura>	 Ok thanks 
[18:34:48] <Nemo_bis>	 If you understand this change to improve the quality of the code, you'll probably also understand how to fix the bug or whatever you want to work on
[18:37:45] <Punitkoura>	 Nemo_bis : I'll do that. thanks
[18:39:47] <grrrit-wm>	 (03PS2) 10Umherirrender: Call WikiPage::doViewUpdates also on missing article page view [core] - 10https://gerrit.wikimedia.org/r/108071 
[18:40:47] <grrrit-wm>	 (03PS13) 10Legoktm: Add preliminary MS SQL support [core] - 10https://gerrit.wikimedia.org/r/105138 (owner: 10Skizzerz)
[18:44:48] <grrrit-wm>	 (03CR) 10Ori.livneh: "are you sure you want to loader.load, rather than loader.using?" [core] - 10https://gerrit.wikimedia.org/r/113540 (owner: 10Bartosz Dziewoński)
[18:45:13] <grrrit-wm>	 (03CR) 10Legoktm: [C: 032] "PS13 was rebase to fix conflict in the RELEASE-NOTES file." [core] - 10https://gerrit.wikimedia.org/r/105138 (owner: 10Skizzerz)
[18:48:21] <grrrit-wm>	 (03Merged) 10jenkins-bot: Add preliminary MS SQL support [core] - 10https://gerrit.wikimedia.org/r/105138 (owner: 10Skizzerz)
[19:00:44] <grrrit-wm>	 (03PS1) 10Ori.livneh: Save current title as 'title' attribute [extensions/EventLogging] - 10https://gerrit.wikimedia.org/r/113545 
[19:01:19] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] Save current title as 'title' attribute [extensions/EventLogging] - 10https://gerrit.wikimedia.org/r/113545 (owner: 10Ori.livneh)
[19:01:32] <grrrit-wm>	 (03CR) 10Bartosz Dziewoński: "Yes. I don't need to wait for the module to load here, as that's done inside mw.notify(). Instead, I want the module loading and the API c" [core] - 10https://gerrit.wikimedia.org/r/113540 (owner: 10Bartosz Dziewoński)
[19:02:37] <ori>	 MatmaRex: mean mw.loader.using( 'mediawiki.notification' ); (with no callbacks)
[19:02:48] <ori>	 rather than mw.loader.load( 'mediawiki.notification' ), which will block
[19:02:50] <grrrit-wm>	 (03CR) 10Bartosz Dziewoński: [C: 031] Call WikiPage::doViewUpdates also on missing article page view [core] - 10https://gerrit.wikimedia.org/r/108071 (owner: 10Umherirrender)
[19:02:59] <ori>	 s/mean/I mean/
[19:04:15] <MatmaRex>	 mw.loader.load won't block afaik
[19:04:37] <MatmaRex>	 people write broken scripts that expect that all the time
[19:05:35] <MatmaRex>	 there is an 'async' parameter, but that apparently doesn't do anything usually (the docs are a bit unclear)
[19:06:32] <ori>	 MatmaRex: i'm just boggling at the code, too. it looks like it is async by default for http[s]://...foo.js calls
[19:06:35] <ori>	 but not for modules
[19:07:08] <MatmaRex>	 basically the parameter only does something if we are before document-ready
[19:07:11] <MatmaRex>	 afaik
[19:07:38] <ori>	 man, do we ever need to clean up mediawiki.js
[19:08:09] <MatmaRex>	 heh
[19:08:19] <MatmaRex>	 there's load of functions which take that parameter
[19:08:44] <MatmaRex>	 most of them are documented that it only does things if we're before $.reddy
[19:08:47] <MatmaRex>	 ready*
[19:08:59] <MatmaRex>	 every one has that documented with different wording, thought
[19:09:01] <grrrit-wm>	 (03PS1) 10Ori.livneh: Get rid of mw.loader.go [core] - 10https://gerrit.wikimedia.org/r/113546 
[19:09:02] <MatmaRex>	 though*
[19:09:19] <MatmaRex>	 ori: cleanup: https://gerrit.wikimedia.org/r/#/c/113539/
[19:09:20] <grrrit-wm>	 (03CR) 10Ori.livneh: "# mwgrep loader.go" [core] - 10https://gerrit.wikimedia.org/r/113546 (owner: 10Ori.livneh)
[19:09:40] <grrrit-wm>	 (03PS2) 10Bartosz Dziewoński: mediawiki.js: Add missing bug number reference [core] - 10https://gerrit.wikimedia.org/r/113539 
[19:09:44] <grrrit-wm>	 (03CR) 10Ori.livneh: [C: 032] mediawiki.js: Add missing bug number reference [core] - 10https://gerrit.wikimedia.org/r/113539 (owner: 10Bartosz Dziewoński)
[19:10:08] <MatmaRex>	 cached pages from before 2013, heh
[19:10:16] <MatmaRex>	 that was never part of "public" interface, no?
[19:12:53] <grrrit-wm>	 (03PS2) 10Ori.livneh: Get rid of mw.loader.go and mw.loader.version [core] - 10https://gerrit.wikimedia.org/r/113546 
[19:12:56] <ori>	 right
[19:13:09] <MatmaRex>	 heh, it was even removed once already
[19:13:32] <MatmaRex>	 http://mediawiki.org/wiki/Special:Code/MediaWiki/97608
[19:14:06] <grrrit-wm>	 (03Merged) 10jenkins-bot: mediawiki.js: Add missing bug number reference [core] - 10https://gerrit.wikimedia.org/r/113539 (owner: 10Bartosz Dziewoński)
[19:14:16] <ori>	 right, it was supposed to be removed 30 days after that i guess
[19:14:22] <grrrit-wm>	 (03CR) 10Bartosz Dziewoński: [C: 032] Get rid of mw.loader.go and mw.loader.version [core] - 10https://gerrit.wikimedia.org/r/113546 (owner: 10Ori.livneh)
[19:14:41] <ori>	 sweet, thanks
[19:16:24] <ori>	 only 2,308 lines left
[19:16:35] <MatmaRex>	 ori: did anyone go and clean up the usages for https://gerrit.wikimedia.org/r/#/c/111422/ ? "mediawiki.user: Remove #name and #anonymous; deprecate #bucket"
[19:17:08] <MatmaRex>	 i added you as a reviewer to a bunch of changes and i'm now looking for some of yours to merge quickly ;)
[19:18:08] <grrrit-wm>	 (03CR) 10Ori.livneh: "mw.user.name usage: <http://p.defau.lt/?SfYUXxfPrEI060PIHY3peg>" [core] - 10https://gerrit.wikimedia.org/r/111422 (owner: 10Ori.livneh)
[19:18:22] <grrrit-wm>	 (03Merged) 10jenkins-bot: Get rid of mw.loader.go and mw.loader.version [core] - 10https://gerrit.wikimedia.org/r/113546 (owner: 10Ori.livneh)
[19:18:26] <huh>	 MatmaRex: is it okay to submit a patch for something under discussion?
[19:18:27] <ori>	 i don't have the staff permission bit on my account, too much headache
[19:19:08] <huh>	 I asked about it already but I want to be sure.
[19:19:11] <MatmaRex>	 huh: probably. expect a prompt -2, thought
[19:19:12] <ori>	 huh: yes, especially if the implementation can clarify things for the discussion. but it can also be done in a passive-aggressive way ("this is happening, you can't stop it!"), in which case it's still "okay" but crappy to do
[19:19:17] <MatmaRex>	 i have a few -2d patches for this resaon myself
[19:21:25] <ori>	 MatmaRex: taking my son to the park but happy to look at stuff later on, got anything specific you want me to review?
[19:21:54] <MatmaRex>	 nothing urgent :)
[19:22:09] <MatmaRex>	 have fun!
[19:22:21] <ori>	 :) thanks, enjoy yr weekend
[19:27:26] <huh>	 Anyone know which special page lists top translators per language?
[19:27:28] <huh>	 Nemo_bis?
[19:30:06] <grrrit-wm>	 (03PS1) 10Bartosz Dziewoński: Remove a HTML backwards-compatibility hack from 2011 [core] - 10https://gerrit.wikimedia.org/r/113548 
[19:51:53] <Nemo_bis>	 huh: yes, Special:SupportedLanguages, but it was disabled on Wikimedia wikis
[19:52:05] <Nemo_bis>	 there is a bug open that you can follow
[20:48:08] <grrrit-wm>	 (03PS1) 10UltrasonicNXT: Add mwchat-sidebar-user class to sidebar elements [extensions/MediaWikiChat] - 10https://gerrit.wikimedia.org/r/113549 
[20:50:01] <grrrit-wm>	 (03CR) 10UltrasonicNXT: [C: 032 V: 032] Add mwchat-sidebar-user class to sidebar elements [extensions/MediaWikiChat] - 10https://gerrit.wikimedia.org/r/113549 (owner: 10UltrasonicNXT)
[20:57:29] <grrrit-wm>	 (03CR) 10Mdale: [C: 032 V: 032] "looks good to me." [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/113489 (owner: 10Brian Wolff)
[20:57:34] <grrrit-wm>	 (03Merged) 10jenkins-bot: Url encode page title for add subtitles link. [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/113489 (owner: 10Brian Wolff)
[21:00:27] <grrrit-wm>	 (03PS2) 10Nemo bis: Added functions to access mime type and subtype separately [extensions/MediaFunctions] - 10https://gerrit.wikimedia.org/r/47438 (owner: 10Olenz)
[21:06:15] <grrrit-wm>	 (03PS6) 10Legoktm: Make terms of use non-WMF specific [extensions/Flow] - 10https://gerrit.wikimedia.org/r/111710 (owner: 10Wctaiwan)
[21:06:23] <grrrit-wm>	 (03PS4) 10Legoktm: Add support for Flow's terms of use [extensions/WikimediaMessages] - 10https://gerrit.wikimedia.org/r/111693 (owner: 10Wctaiwan)
[21:08:03] <grrrit-wm>	 (03CR) 10Legoktm: [C: 032] "Tested, looks good." [extensions/Flow] - 10https://gerrit.wikimedia.org/r/111710 (owner: 10Wctaiwan)
[21:08:08] <grrrit-wm>	 (03CR) 10Legoktm: [C: 032] "Tested, looks good." [extensions/WikimediaMessages] - 10https://gerrit.wikimedia.org/r/111693 (owner: 10Wctaiwan)
[21:08:10] <grrrit-wm>	 (03Merged) 10jenkins-bot: Add support for Flow's terms of use [extensions/WikimediaMessages] - 10https://gerrit.wikimedia.org/r/111693 (owner: 10Wctaiwan)
[21:08:13] <grrrit-wm>	 (03Merged) 10jenkins-bot: Make terms of use non-WMF specific [extensions/Flow] - 10https://gerrit.wikimedia.org/r/111710 (owner: 10Wctaiwan)
[21:25:02] <grrrit-wm>	 (03PS1) 10EBernhardson: Cleanup unused local variables [extensions/Flow] - 10https://gerrit.wikimedia.org/r/113628 
[21:25:05] <grrrit-wm>	 (03PS1) 10EBernhardson: Remove unused class aliases [extensions/Flow] - 10https://gerrit.wikimedia.org/r/113629 
[21:25:08] <grrrit-wm>	 (03PS1) 10EBernhardson: Cleanup potential bad method calls [extensions/Flow] - 10https://gerrit.wikimedia.org/r/113630 
[21:25:11] <grrrit-wm>	 (03PS1) 10EBernhardson: Annotate model classes [extensions/Flow] - 10https://gerrit.wikimedia.org/r/113631 
[21:25:14] <grrrit-wm>	 (03PS1) 10EBernhardson: Ensure getHumanTimestamp parameter is really MWTimestamp|null [extensions/Flow] - 10https://gerrit.wikimedia.org/r/113632 
[21:25:17] <grrrit-wm>	 (03PS1) 10EBernhardson: Use consistent return type [extensions/Flow] - 10https://gerrit.wikimedia.org/r/113633 
[21:25:20] <grrrit-wm>	 (03PS1) 10EBernhardson: couple spelling errors [extensions/Flow] - 10https://gerrit.wikimedia.org/r/113634 
[21:25:23] <grrrit-wm>	 (03PS1) 10EBernhardson: Prefer instanceof over is_a [extensions/Flow] - 10https://gerrit.wikimedia.org/r/113635 
[21:26:32] <helderwiki>	 ori: It just ocurred me that some wikis migh be using importScript or mw.loader.load to import JS from User namespace into MediaWiki namespace, and one of those scripts could eventually be using some of the functions which were deprecated and removed recently...
[21:27:48] <helderwiki>	 Could you search for regex "importScript\(\s*['\"]User" or something like that using mwgrep?
[21:30:31] <huh>	 Was importScript removed?
[21:34:21] <Sveta>	 huh: The documentation mentions no replacement, so I assume not.
[22:48:18] <grrrit-wm>	 (03PS1) 10BryanDavis: Improve logging output and consistency [tools/scap] - 10https://gerrit.wikimedia.org/r/113642 
[23:01:32] <grrrit-wm>	 (03PS2) 10BryanDavis: Improve logging output and consistency [tools/scap] - 10https://gerrit.wikimedia.org/r/113642 
[23:02:06] <grrrit-wm>	 (03CR) 10Legoktm: [C: 04-1] "Noting that there are some regexes on <https://meta.wikimedia.org/wiki/Spam_blacklist> which do have urlencoded characters in them, so we " (031 comment) [extensions/SpamBlacklist] - 10https://gerrit.wikimedia.org/r/57935 (owner: 10Anubhavagarwal)
[23:05:38] <grrrit-wm>	 (03CR) 10Ori.livneh: [C: 04-1] "Very happy to see this." (031 comment) [tools/scap] - 10https://gerrit.wikimedia.org/r/113642 (owner: 10BryanDavis)
[23:06:54] <grrrit-wm>	 (03PS1) 10Jack Phoenix: Gave Cologne Blue's div#article class="mw-body" for consistency with other skins. [core] - 10https://gerrit.wikimedia.org/r/113643 
[23:07:21] <grrrit-wm>	 (03PS3) 10BryanDavis: Improve logging output and consistency [tools/scap] - 10https://gerrit.wikimedia.org/r/113642 
[23:09:16] <grrrit-wm>	 (03CR) 10Isarra: [C: 031] "Yup." [core] - 10https://gerrit.wikimedia.org/r/113643 (owner: 10Jack Phoenix)
[23:09:51] <grrrit-wm>	 (03CR) 10BryanDavis: "Ori: I've been thinking about the same sort of timing logging idea. I was thinking about having both a context manager and a decorator to " [tools/scap] - 10https://gerrit.wikimedia.org/r/113642 (owner: 10BryanDavis)
[23:13:53] <grrrit-wm>	 (03CR) 10Isarra: "So I'm thinking of trying to redo this in a way that's a bit simpler, but I'm also not so sure about creating an entire new class for it e" [core] - 10https://gerrit.wikimedia.org/r/108045 (owner: 10Jack Phoenix)
[23:22:39] <grrrit-wm>	 (03PS2) 10Bartosz Dziewoński: CologneBlue: Add class="mw-body" to div#article for consistency with other skins [core] - 10https://gerrit.wikimedia.org/r/113643 (owner: 10Jack Phoenix)
[23:23:39] <grrrit-wm>	 (03CR) 10Bartosz Dziewoński: [C: 032] CologneBlue: Add class="mw-body" to div#article for consistency with other skins [core] - 10https://gerrit.wikimedia.org/r/113643 (owner: 10Jack Phoenix)
[23:25:09] <grrrit-wm>	 (03CR) 10Bartosz Dziewoński: (bug 61010) Add IE support to vertical-gradient mixin. [core] - 10https://gerrit.wikimedia.org/r/112066 (owner: 10Isarra)
[23:26:48] <grrrit-wm>	 (03PS1) 10BryanDavis: Improve pydoc [tools/scap] - 10https://gerrit.wikimedia.org/r/113645 
[23:26:54] <grrrit-wm>	 (03Merged) 10jenkins-bot: CologneBlue: Add class="mw-body" to div#article for consistency with other skins [core] - 10https://gerrit.wikimedia.org/r/113643 (owner: 10Jack Phoenix)
[23:33:59] <grrrit-wm>	 (03Abandoned) 10Bartosz Dziewoński: Module storage: randomly choose between Function and $.globalEval [core] (wmf/1.23wmf5) - 10https://gerrit.wikimedia.org/r/100721 (owner: 10Ori.livneh)
[23:37:16] <Reedy>	 wmf5? lols
[23:38:11] <Gloria>	 Hilarious.
[23:38:29] <MatmaRex>	 you find these kinds of things when you randomly go through somebody's pending changesets.
[23:39:01] <Reedy>	 Don't suppose gerrit does not branch?
[23:39:24] <MatmaRex>	 um?
[23:39:59] <Reedy>	 ie https://gerrit.wikimedia.org/r/#/q/status:open+project:mediawiki/core+branch:master,n,z
[23:40:07] <Reedy>	 so filter where branch is not master
[23:41:58] <MatmaRex>	 jus use -branch:…
[23:41:59] <MatmaRex>	 https://gerrit.wikimedia.org/r/#/q/status:open+project:mediawiki/core+-branch:master,n,z
[23:42:10] <MatmaRex>	 no more surprises i can see
[23:42:25] <MatmaRex>	 well
[23:42:37] <MatmaRex>	 a patch for REL1_19 last updated in september is a little suprising
[23:42:39] <MatmaRex>	 but not that much
[23:45:49] <p858snake|l>	 but... but... lts
[23:46:29] <Reedy>	 legacy!