[00:03:04] (03CR) 10MarkTraceur: [C: 032 V: 032] "Let's do this" [core] (wmf/1.23wmf13) - 10https://gerrit.wikimedia.org/r/113300 (owner: 10MarkTraceur) [00:03:13] (03PS1) 10AndyRussG: Fix course talk notification for deleted pages [extensions/EducationProgram] - 10https://gerrit.wikimedia.org/r/113301 [00:08:32] (03CR) 10EBernhardson: [C: 032] Update flow to fix pagination [core] (wmf/1.23wmf13) - 10https://gerrit.wikimedia.org/r/113276 (owner: 10EBernhardson) [00:11:18] (03CR) 10Mattflaschen: "We need to either wait for https://gerrit.wikimedia.org/r/#/c/113112/ to rollout, or do a cherry-pick." [extensions/GuidedTour] - 10https://gerrit.wikimedia.org/r/113113 (owner: 10Bartosz Dziewoński) [00:12:00] (03Merged) 10jenkins-bot: Update flow to fix pagination [core] (wmf/1.23wmf13) - 10https://gerrit.wikimedia.org/r/113276 (owner: 10EBernhardson) [00:13:32] (03PS11) 10Prtksxna: Add `redirects to` message at the top of the popup [extensions/Popups] - 10https://gerrit.wikimedia.org/r/111983 [00:14:43] (03PS1) 10MarkTraceur: Backport fix for MultimediaViewer's keystroke handling [core] (wmf/1.23wmf14) - 10https://gerrit.wikimedia.org/r/113303 [00:14:49] (03CR) 10Prtksxna: Add time ago in words at the bottom of the popup (031 comment) [extensions/Popups] - 10https://gerrit.wikimedia.org/r/111977 (owner: 10Prtksxna) [00:14:55] (03CR) 10MarkTraceur: [C: 032] Backport fix for MultimediaViewer's keystroke handling [core] (wmf/1.23wmf14) - 10https://gerrit.wikimedia.org/r/113303 (owner: 10MarkTraceur) [00:15:05] (03CR) 10MarkTraceur: [V: 032] Backport fix for MultimediaViewer's keystroke handling [core] (wmf/1.23wmf14) - 10https://gerrit.wikimedia.org/r/113303 (owner: 10MarkTraceur) [00:15:28] can somebody tell me how FSFileBackend::doStoreInternal can assume the directory tree exists? [00:16:08] because something should have called prepare() before hand [00:16:10] (03CR) 10Prtksxna: [WIP] Add EventLogging [WIP] (031 comment) [extensions/Popups] - 10https://gerrit.wikimedia.org/r/112661 (owner: 10Prtksxna) [00:16:26] doPrepareInternal [00:16:40] thanks! [00:22:39] (03PS1) 10Mattflaschen: mediawiki.jqueryMsg: Support {{GENDER:}} with empty first parameter [core] (wmf/1.23wmf14) - 10https://gerrit.wikimedia.org/r/113304 [00:23:25] (03PS1) 10Mattflaschen: mediawiki.jqueryMsg: Support {{GENDER:}} with empty first parameter [core] (wmf/1.23wmf13) - 10https://gerrit.wikimedia.org/r/113305 [00:24:27] (03CR) 10Mattflaschen: [C: 032] mediawiki.jqueryMsg: Support {{GENDER:}} with empty first parameter [core] (wmf/1.23wmf14) - 10https://gerrit.wikimedia.org/r/113304 (owner: 10Mattflaschen) [00:26:06] (03CR) 10Mattflaschen: [C: 032] mediawiki.jqueryMsg: Support {{GENDER:}} with empty first parameter [core] (wmf/1.23wmf13) - 10https://gerrit.wikimedia.org/r/113305 (owner: 10Mattflaschen) [00:26:42] (03CR) 10EBernhardson: Consolidate formatters into Flow\\Formatter namespace (033 comments) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/113154 (owner: 10EBernhardson) [00:27:54] (03Merged) 10jenkins-bot: mediawiki.jqueryMsg: Support {{GENDER:}} with empty first parameter [core] (wmf/1.23wmf14) - 10https://gerrit.wikimedia.org/r/113304 (owner: 10Mattflaschen) [00:29:26] (03Merged) 10jenkins-bot: mediawiki.jqueryMsg: Support {{GENDER:}} with empty first parameter [core] (wmf/1.23wmf13) - 10https://gerrit.wikimedia.org/r/113305 (owner: 10Mattflaschen) [00:31:37] (03PS4) 10Matthias Mullie: Move cutting of index data into index code [extensions/Flow] - 10https://gerrit.wikimedia.org/r/112917 [00:31:40] (03CR) 10jenkins-bot: [V: 04-1] Move cutting of index data into index code [extensions/Flow] - 10https://gerrit.wikimedia.org/r/112917 (owner: 10Matthias Mullie) [00:32:43] (03PS5) 10Matthias Mullie: Move cutting of index data into index code [extensions/Flow] - 10https://gerrit.wikimedia.org/r/112917 [00:37:17] (03PS1) 10Bartosz Dziewoński: mediawiki.jqueryMsg: Don't throw parse errors in the user's face [core] - 10https://gerrit.wikimedia.org/r/113307 [00:38:43] (03PS2) 10Bartosz Dziewoński: mediawiki.jqueryMsg: Don't throw parse errors in the user's face [core] - 10https://gerrit.wikimedia.org/r/113307 [00:40:02] (03PS1) 10JGonera: [WIP] Add links to headings for easy section link retrieval [core] - 10https://gerrit.wikimedia.org/r/113308 [00:40:39] (03CR) 10JGonera: [C: 04-2] "Don't merge, parser tests fail because headings can already contain links from wikitext." [core] - 10https://gerrit.wikimedia.org/r/113308 (owner: 10JGonera) [00:42:54] (03CR) 10jenkins-bot: [V: 04-1] mediawiki.jqueryMsg: Don't throw parse errors in the user's face [core] - 10https://gerrit.wikimedia.org/r/113307 (owner: 10Bartosz Dziewoński) [00:43:06] (03PS1) 10Ori.livneh: Do not attempt to validate schema titles [extensions/EventLogging] - 10https://gerrit.wikimedia.org/r/113310 [00:43:13] (03PS5) 10Matthias Mullie: Alternative way of dealing with edit conflicts [extensions/Flow] - 10https://gerrit.wikimedia.org/r/108635 [00:43:16] (03CR) 10MZMcBride: "Possibly related: https://www.mediawiki.org/wiki/Requests_for_comment/Clickable_section_anchors" [core] - 10https://gerrit.wikimedia.org/r/113308 (owner: 10JGonera) [00:43:29] (03CR) 10Ori.livneh: [C: 032 V: 032] Do not attempt to validate schema titles [extensions/EventLogging] - 10https://gerrit.wikimedia.org/r/113310 (owner: 10Ori.livneh) [00:43:49] (03CR) 10jenkins-bot: [V: 04-1] [WIP] Add links to headings for easy section link retrieval [core] - 10https://gerrit.wikimedia.org/r/113308 (owner: 10JGonera) [00:44:35] (03CR) 10MarkTraceur: [C: 032] "Sounds good, shouldn't cause trouble with any existing calls." [core] - 10https://gerrit.wikimedia.org/r/111704 (owner: 10Gergő Tisza) [00:44:43] (03CR) 10Matthias Mullie: Move cutting of index data into index code (031 comment) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/112917 (owner: 10Matthias Mullie) [00:48:00] (03Merged) 10jenkins-bot: Return jqXHR from mw.Api calls [core] - 10https://gerrit.wikimedia.org/r/111704 (owner: 10Gergő Tisza) [00:49:23] (03CR) 10Matthias Mullie: [C: 032] Consolidate formatters into Flow\\Formatter namespace [extensions/Flow] - 10https://gerrit.wikimedia.org/r/113154 (owner: 10EBernhardson) [00:49:35] (03Merged) 10jenkins-bot: Consolidate formatters into Flow\\Formatter namespace [extensions/Flow] - 10https://gerrit.wikimedia.org/r/113154 (owner: 10EBernhardson) [00:50:37] (03PS3) 10Bartosz Dziewoński: mediawiki.jqueryMsg: Don't throw parse errors in the user's face [core] - 10https://gerrit.wikimedia.org/r/113307 [00:56:37] (03CR) 10Matthias Mullie: "This can be submitted, but 2 follow-up patches should preferably be merged along with this one:" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/112042 (owner: 10Matthias Mullie) [00:57:55] (03CR) 10Bartosz Dziewoński: "Dependency merged and backported." [extensions/GuidedTour] - 10https://gerrit.wikimedia.org/r/113113 (owner: 10Bartosz Dziewoński) [00:58:59] (03CR) 10J-squared: "Thanks for your comments, Ragesoss! What context is the incorrect notification formatting appearing in? Can you describe the steps to repr" (031 comment) [extensions/EducationProgram] - 10https://gerrit.wikimedia.org/r/113145 (owner: 10J-squared) [01:04:09] (03CR) 10Matthias Mullie: [C: 031] "I like the approach; removes some duplicate code. I'll take a closer look tomorrow" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/113157 (owner: 10EBernhardson) [01:04:28] (03PS2) 10Mattflaschen: mediawiki.jqueryMsg: Deprecate window.gM [core] - 10https://gerrit.wikimedia.org/r/113159 (owner: 10Bartosz Dziewoński) [01:04:36] (03CR) 10Mattflaschen: [C: 032] mediawiki.jqueryMsg: Deprecate window.gM [core] - 10https://gerrit.wikimedia.org/r/113159 (owner: 10Bartosz Dziewoński) [01:08:47] (03Merged) 10jenkins-bot: mediawiki.jqueryMsg: Deprecate window.gM [core] - 10https://gerrit.wikimedia.org/r/113159 (owner: 10Bartosz Dziewoński) [01:17:05] (03PS1) 10JGonera: Reduce TOC padding slightly in new typography [extensions/VectorBeta] - 10https://gerrit.wikimedia.org/r/113315 [01:18:48] (03CR) 10Ragesoss: "Ah, I see. I was testing on my install that I had been breaking with course page moves, so the link broke on the testing page that I chang" [extensions/EducationProgram] - 10https://gerrit.wikimedia.org/r/113145 (owner: 10J-squared) [01:48:51] (03CR) 10TTO: "Sorry :(" [extensions/FlaggedRevs] - 10https://gerrit.wikimedia.org/r/76460 (owner: 10TTO) [01:49:41] (03PS1) 10JGonera: Optically align heading serif font with sans-serif content font [extensions/VectorBeta] - 10https://gerrit.wikimedia.org/r/113320 [01:58:06] (03PS8) 10TTO: Add $wgLocalInterwikis to handle multiple local prefixes [core] - 10https://gerrit.wikimedia.org/r/110162 [02:00:15] or rather it's broken in two different ways and one of them is related to the lightbox patch :/ [02:14:23] (03CR) 10Ragesoss: [C: 032] Fix course talk notification for deleted pages [extensions/EducationProgram] - 10https://gerrit.wikimedia.org/r/113301 (owner: 10AndyRussG) [02:14:32] (03Merged) 10jenkins-bot: Fix course talk notification for deleted pages [extensions/EducationProgram] - 10https://gerrit.wikimedia.org/r/113301 (owner: 10AndyRussG) [02:17:03] (03PS5) 10Brian Wolff: Add Special:ListDuplicatedFiles expensive query special page. [core] - 10https://gerrit.wikimedia.org/r/85446 [02:17:22] (03CR) 10Brian Wolff: "*bump*" [core] - 10https://gerrit.wikimedia.org/r/85446 (owner: 10Brian Wolff) [02:26:27] where is the concatenation of wikiId + name + zone built? [02:26:54] thumbnails are being saved in a directory like that, i would like to customize it [02:37:51] ori, about the eventlogging errors, i reviewed the code and have absolutely no idea how that could happen [02:38:02] are you still seeing those errors? [02:43:44] (03PS1) 10Jforrester: Update OOjs UI to v0.1.0-pre (7d3223b8f4) [core] - 10https://gerrit.wikimedia.org/r/113325 [02:47:22] i used containerPaths... [02:53:38] ysangkok: FileBackend adds the wiki ID and FileRepo adds the repo name (not the same as the backend name) and the zone name [02:54:17] containerPaths should also be used for legacy reasons (or if it's the only way to get the deleted zone out of the doc root or something) [02:54:43] by "out of" I really mean "not web accessible" [02:54:54] ok, thanks [02:55:33] some things like the Math/Score/Timeline extension don't use FileRepo, but still follow that convention and set a "repo" name and zone [02:55:33] ori, fixed the memory_limit fix in phpsh: https://github.com/atdt/phpsh/pull/2 [02:55:42] * AaronSchulz goes to eat [02:55:43] I really thought it was right before, but it must have been placebo effect. [02:56:06] (03CR) 10Catrope: [C: 032] Update OOjs UI to v0.1.0-pre (7d3223b8f4) [core] - 10https://gerrit.wikimedia.org/r/113325 (owner: 10Jforrester) [02:59:17] (03Merged) 10jenkins-bot: Update OOjs UI to v0.1.0-pre (7d3223b8f4) [core] - 10https://gerrit.wikimedia.org/r/113325 (owner: 10Jforrester) [03:01:52] (03CR) 10Mattflaschen: [C: 04-1] "Don't tag this as fixing the parse error bugs." [core] - 10https://gerrit.wikimedia.org/r/113307 (owner: 10Bartosz Dziewoński) [03:03:42] ori, the problem is, sometimes the memory limit won't be hit, even when you do the same thing, but you can still check with: [03:03:44] echo ini_get( 'memory_limit' ); [03:13:29] (03CR) 10Mattflaschen: "It seems like it would also make sense to remove this validation from the PHP module: https://git.wikimedia.org/blob/mediawiki%2Fextension" [extensions/EventLogging] - 10https://gerrit.wikimedia.org/r/113310 (owner: 10Ori.livneh) [03:18:43] I made a patch for Scribunto which enables Lua script to be refereced as SVG images: https://github.com/ysangkok/scribunto/commit/085abfa95a10cf38acbbfab0f1af2863ea3e0177 [03:18:44] (03CR) 10Mattflaschen: [C: 032] "Works fine." [extensions/GuidedTour] - 10https://gerrit.wikimedia.org/r/113113 (owner: 10Bartosz Dziewoński) [03:19:18] (03Merged) 10jenkins-bot: Add explicit {{GENDER:}} support to guidedtour-tour-firstedit-edit-page-title [extensions/GuidedTour] - 10https://gerrit.wikimedia.org/r/113113 (owner: 10Bartosz Dziewoński) [03:19:31] ysangkok, cool, did you submit a pull request? [03:19:50] superm401: no, I don't think it's ready yet. There are some hacks [03:20:40] I would like feedback so that I can get it ready. Or do you think it's better to just submit the request now? [03:27:02] (03CR) 10Roycwang: "You should use $hostnameParts[0] as realServer ,or there will be an error" [core] - 10https://gerrit.wikimedia.org/r/109634 (owner: 10Mglaser) [03:30:01] (03CR) 10Mattflaschen: "Ready for review. Core fix is deployed to all production wikis (wmf13 and wmf14)." [extensions/GettingStarted] - 10https://gerrit.wikimedia.org/r/111262 (owner: 10Mattflaschen) [03:55:57] (03PS1) 10Ori.livneh: Update phpsh to 1.3.4 [vagrant] - 10https://gerrit.wikimedia.org/r/113328 [03:57:46] (03CR) 10Mattflaschen: [C: 032] Update phpsh to 1.3.4 [vagrant] - 10https://gerrit.wikimedia.org/r/113328 (owner: 10Ori.livneh) [03:57:49] (03Merged) 10jenkins-bot: Update phpsh to 1.3.4 [vagrant] - 10https://gerrit.wikimedia.org/r/113328 (owner: 10Ori.livneh) [04:42:48] (03CR) 10EBernhardson: "for the linked bug, these setters wont be enough. The EchoEvent object is only used for notifications delivered via the web, email notifi" [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/98257 (owner: 10Legoktm) [04:44:22] (03PS1) 10TTO: Allow additional interwiki prefixes on local interwiki links [core] - 10https://gerrit.wikimedia.org/r/113329 [05:05:19] just wondering if some people who understand Jenkins could have a look at https://bugzilla.wikimedia.org/show_bug.cgi?id=61246 [05:05:34] as you can see from scanning down the "V" column of https://gerrit.wikimedia.org/r/#/projects/mediawiki/core,dashboards/default this is affecting me only [05:05:52] I can't understand how it would be anything on my end [05:39:50] tto: that...is weird. I guess hashar or Krinkle|detached are the best people to look into that. [06:01:43] Krinkle: ^ [06:02:29] tto: This most likely means someone screwed up in adding you to the test-pipeline whitelist for running phpunit tests [06:02:53] in that it now excludes you from the non-phpunit pipeline and doesn't include in the phpunit pipeline [06:03:11] Nice to know that someone thought to whitelist me :) [06:03:31] https://github.com/wikimedia/integration-zuul-config/commit/5d5fe1bfd542ce587a5760e4ea683c5107a96339 [06:04:07] Yep, forgot a # [06:04:21] Surprised this didn't break anything else [06:04:32] crap yaml, way too tolerant [06:04:47] why is yaml being used here? seems like a weird choice [06:05:00] (03CR) 10Krinkle: "fixme: The regex is now broken as it has trailing text after the regex that is not preceded by # for comment" [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/110661 (owner: 10Brian Wolff) [06:05:12] tto: because... openstack/jenkins-job-builder takes yaml [06:05:41] thanks for the sleuthing, Krinkle [06:06:17] yaml just seems like an obscure format to choose: json is the more usual format, I would have thought [06:07:25] (03PS1) 10Krinkle: Follows-up 5d5fe1bfd5: Fix invalid regex list item [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/113336 [06:08:05] (03CR) 10Krinkle: [C: 032] Follows-up 5d5fe1bfd5: Fix invalid regex list item [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/113336 (owner: 10Krinkle) [06:08:09] (03Merged) 10jenkins-bot: Follows-up 5d5fe1bfd5: Fix invalid regex list item [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/113336 (owner: 10Krinkle) [06:09:36] tto: [#wikimedia-operations] : !log Reloading Zuul to deploy Ie02531143511f418a6 [06:10:14] tto: Rebase one of your patches and see if it works now [06:10:20] (or make a small change in the commit message) [06:10:41] (03PS5) 10TTO: Stop using prettifyIP for user links [core] - 10https://gerrit.wikimedia.org/r/92263 [06:11:13] usually takes a couple of minutes for mw/core [06:12:45] (03CR) 10jenkins-bot: [V: 04-1] Stop using prettifyIP for user links [core] - 10https://gerrit.wikimedia.org/r/92263 (owner: 10TTO) [06:12:56] ...and of course it had to be a -1! [06:13:06] Thanks very much for fixing it though, Krinkle [06:14:21] yw [06:16:18] (03CR) 10Krinkle: "Fixed in Ie02531143511." [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/110661 (owner: 10Brian Wolff) [06:17:35] (03CR) 10Krinkle: mediawiki.log: Move #warn and #deprecate to mediawiki.js and add tracking (031 comment) [core] - 10https://gerrit.wikimedia.org/r/111957 (owner: 10Krinkle) [06:18:48] (03CR) 10TTO: "Hm, obviously this approach isn't right. Both 0:0:0:0:0:0:0:1 and 0000:0000:0000:0000:0000:0000:0000:0001 stay as is, where I think it wou" [core] - 10https://gerrit.wikimedia.org/r/92263 (owner: 10TTO) [06:21:12] (03PS2) 10TTO: Allow additional interwiki prefixes on local interwiki links [core] - 10https://gerrit.wikimedia.org/r/113329 [06:21:16] (03PS4) 10Krinkle: mediawiki.log: Move #warn and #deprecate to mediawiki.js and add tracking [core] - 10https://gerrit.wikimedia.org/r/111957 [06:21:34] (03CR) 10Krinkle: "Fix typo in the comment added to mediawiki.log.js." [core] - 10https://gerrit.wikimedia.org/r/111957 (owner: 10Krinkle) [06:22:01] (03CR) 10jenkins-bot: [V: 04-1] Allow additional interwiki prefixes on local interwiki links [core] - 10https://gerrit.wikimedia.org/r/113329 (owner: 10TTO) [06:22:14] (03PS1) 10Mattflaschen: Remove openTask cookie on logout [extensions/GettingStarted] - 10https://gerrit.wikimedia.org/r/113337 [06:25:30] (03CR) 10TTO: "The release note should not have been added under "Configuration changes"." [core] - 10https://gerrit.wikimedia.org/r/105443 (owner: 10Umherirrender) [06:25:32] (03CR) 10Mattflaschen: mediawiki.log: Move #warn and #deprecate to mediawiki.js and add tracking (031 comment) [core] - 10https://gerrit.wikimedia.org/r/111957 (owner: 10Krinkle) [06:26:39] (03PS9) 10TTO: Add $wgLocalInterwikis to handle multiple local prefixes [core] - 10https://gerrit.wikimedia.org/r/110162 [06:29:24] (03PS3) 10TTO: Allow additional interwiki prefixes on local interwiki links [core] - 10https://gerrit.wikimedia.org/r/113329 [06:30:12] (03CR) 10jenkins-bot: [V: 04-1] Add $wgLocalInterwikis to handle multiple local prefixes [core] - 10https://gerrit.wikimedia.org/r/110162 (owner: 10TTO) [06:32:27] (03CR) 10MZMcBride: "Who's maintaining Echo?" [extensions/Echo] - 10https://gerrit.wikimedia.org/r/93508 (owner: 10Gerrit Patch Uploader) [06:32:53] (03CR) 10jenkins-bot: [V: 04-1] Allow additional interwiki prefixes on local interwiki links [core] - 10https://gerrit.wikimedia.org/r/113329 (owner: 10TTO) [06:33:51] (03PS7) 10Gerrit Patch Uploader: Remove namespace restriction for mention notifications [extensions/Echo] - 10https://gerrit.wikimedia.org/r/93508 [06:34:08] Gloria: the 'Core Features' team, from what i understand [06:34:11] (03CR) 10MZMcBride: "Oh, I remember this change now. There's a failing test." [extensions/Echo] - 10https://gerrit.wikimedia.org/r/93508 (owner: 10Gerrit Patch Uploader) [06:34:12] #wikimedia-corefeatures [06:34:20] YuviPanda: I'm in there. [06:34:28] Getting double-pinged by grrrit-wm, it's great. [06:34:30] ah, rhetorical question :P [06:34:31] (03CR) 10TTO: "Seemingly the Setup.php code isn't run for the unit tests, so I will change the test to use wgLocalInterwikis instead." [core] - 10https://gerrit.wikimedia.org/r/110162 (owner: 10TTO) [06:34:34] Gloria: heh :D [06:34:55] (03PS10) 10TTO: Add $wgLocalInterwikis to handle multiple local prefixes [core] - 10https://gerrit.wikimedia.org/r/110162 [06:35:11] ori: Quick, +2! [06:35:18] ori: jenkins-bot has stopped complaining. [06:35:48] (03CR) 10Ori.livneh: "recheck" [extensions/Echo] - 10https://gerrit.wikimedia.org/r/93508 (owner: 10Gerrit Patch Uploader) [06:36:34] > https://integration.wikimedia.org/ci/job/mwext-Echo-testextensions-master/1148/console : FAILURE in 8s [06:36:38] It's no longer running that test, I guess. [06:37:16] (03CR) 10TTO: "recheck" [core] - 10https://gerrit.wikimedia.org/r/111390 (owner: 10TTO) [06:37:55] (03PS8) 10Legoktm: Remove namespace restriction for mention notifications [extensions/Echo] - 10https://gerrit.wikimedia.org/r/93508 (owner: 10Gerrit Patch Uploader) [06:38:08] (03CR) 10jenkins-bot: [V: 04-1] Remove namespace restriction for mention notifications [extensions/Echo] - 10https://gerrit.wikimedia.org/r/93508 (owner: 10Gerrit Patch Uploader) [06:38:10] recheck only runs the +1 tests [06:38:23] wat [06:38:29] (03PS4) 10TTO: Allow additional interwiki prefixes on local interwiki links [core] - 10https://gerrit.wikimedia.org/r/113329 [06:38:31] stupid jenkins [06:38:47] Grah. [06:38:51] (03PS9) 10Legoktm: Remove namespace restriction for mention notifications [extensions/Echo] - 10https://gerrit.wikimedia.org/r/93508 (owner: 10Gerrit Patch Uploader) [06:39:28] (03CR) 10jenkins-bot: [V: 04-1] Remove namespace restriction for mention notifications [extensions/Echo] - 10https://gerrit.wikimedia.org/r/93508 (owner: 10Gerrit Patch Uploader) [06:41:07] ori, legoktm: Okay, what do we do about that change? [06:41:19] I still can't reproduce the failure locally [06:41:27] Gloria: other then rebase it every so often? [06:41:33] than [06:41:46] and it is specific to that change, running the tests via jenkins on current master passes fine [06:41:49] * ori seppukus. [06:42:00] Can we just ignore jenkins? [06:42:02] I'm fine with that. [06:42:03] * YuviPanda gives ori a japanese sword [06:42:07] * Gloria NP: "I'll Stand By You" by The Pretenders from "Last Of The Independents" [06:42:15] no, because then whenever someone uploads a new patch it'll -1 it [06:42:23] That's someone else's problem, though. [06:42:55] Worst case we should just mark the test as skipped [06:42:56] i think bsitu has been handed enough of those during his tenure at the wmf :P [06:43:20] anyways, to state the obvious, [06:43:25] ori, legoktm: Okay, what do we do about that change? [06:43:31] figure out why the test is failing [06:43:38] and fix it [06:43:40] I looked at some point. [06:43:49] It give me a small headache. [06:43:53] gave [06:43:53] gives [06:44:03] I forgives you. [06:44:04] NICE TRY. [06:49:41] (03CR) 10Mattflaschen: [C: 032] "Works perfectly (for both edits and cancels), and is much cleaner than the workaround I sketched out." [extensions/GettingStarted] - 10https://gerrit.wikimedia.org/r/112880 (owner: 10Phuedx) [06:49:44] (03Merged) 10jenkins-bot: Delay showing the task toolbar after VisualEditor edit [extensions/GettingStarted] - 10https://gerrit.wikimedia.org/r/112880 (owner: 10Phuedx) [07:00:05] (03CR) 10TTO: "I honestly have no idea what I was talking about back in September. PS4 is indeed much better in English." [core] - 10https://gerrit.wikimedia.org/r/83662 (owner: 10Jforrester) [07:30:45] (03CR) 10Jasper Deng: [C: 04-1] "I think it should be consistent everywhere, even if it means a massive renaming of IP talk pages, because the recommended way to show IPv6" [core] - 10https://gerrit.wikimedia.org/r/92263 (owner: 10TTO) [07:32:35] (03CR) 10Parent5446: "@Aaron: let me know what you think about this in the next patchset." (0312 comments) [core] - 10https://gerrit.wikimedia.org/r/77645 (owner: 10Parent5446) [07:32:42] (03PS18) 10Parent5446: Added password hashing API [core] - 10https://gerrit.wikimedia.org/r/77645 [07:33:32] (03CR) 10jenkins-bot: [V: 04-1] Added password hashing API [core] - 10https://gerrit.wikimedia.org/r/77645 (owner: 10Parent5446) [07:54:22] (03PS7) 10Parent5446: default entry point for extension + sqlite db update [extensions/TwoFactorAuthentication] - 10https://gerrit.wikimedia.org/r/104508 (owner: 10Hashar) [07:54:27] (03CR) 10jenkins-bot: [V: 04-1] default entry point for extension + sqlite db update [extensions/TwoFactorAuthentication] - 10https://gerrit.wikimedia.org/r/104508 (owner: 10Hashar) [07:57:03] (03PS8) 10Parent5446: default entry point for extension + sqlite db update [extensions/TwoFactorAuthentication] - 10https://gerrit.wikimedia.org/r/104508 (owner: 10Hashar) [08:19:54] (03CR) 10AndyRussG: [C: 04-1] "w00t! \o/ Congrats, way to go!" (034 comments) [extensions/EducationProgram] - 10https://gerrit.wikimedia.org/r/113145 (owner: 10J-squared) [08:23:41] (03CR) 10Aaron Schulz: Added password hashing API (031 comment) [core] - 10https://gerrit.wikimedia.org/r/77645 (owner: 10Parent5446) [08:27:11] (03CR) 10Aaron Schulz: "I still need to look at this more later. I like the splitting of the factory/password classes." (032 comments) [core] - 10https://gerrit.wikimedia.org/r/77645 (owner: 10Parent5446) [08:27:16] (03CR) 10Mxn: [C: 04-1] "Explained why the proposed changes won’t work. Suggested some straightforward solutions." (033 comments) [extensions/ConfirmEdit] - 10https://gerrit.wikimedia.org/r/113122 (owner: 10Norayr) [08:29:15] (03CR) 10Mxn: now captcha.py can generate captchas with unicode characters. (031 comment) [extensions/ConfirmEdit] - 10https://gerrit.wikimedia.org/r/113122 (owner: 10Norayr) [08:33:31] (03CR) 10Nikerabbit: "Just FYI: this is what i hacked to enable captchas in Finnish" [extensions/ConfirmEdit] - 10https://gerrit.wikimedia.org/r/113122 (owner: 10Norayr) [08:55:58] Thanks Nikerabbit for your patch :) [09:01:42] (03CR) 10Nemo bis: "Thanks Nikerabbit for the patch, +1 to Mxn's proposal to use a library." (031 comment) [extensions/ConfirmEdit] - 10https://gerrit.wikimedia.org/r/113122 (owner: 10Norayr) [09:05:42] (03PS19) 10Parent5446: Added password hashing API [core] - 10https://gerrit.wikimedia.org/r/77645 [10:07:10] (03PS1) 10TTO: Deprecate wgSkipSkin in favor of wgSkipSkins [core] - 10https://gerrit.wikimedia.org/r/113341 [10:41:34] (03CR) 10Hashar: [V: 032] add gitreview file [services/mathoid] - 10https://gerrit.wikimedia.org/r/112875 (owner: 10Physikerwelt) [10:51:16] (03PS2) 10Hashar: Add makefile [services/mathoid] - 10https://gerrit.wikimedia.org/r/113024 (owner: 10Physikerwelt) [10:52:23] (03CR) 10Hashar: [C: 032 V: 032] "Bumped .PHONY at top of file. Made it clean all install" [services/mathoid] - 10https://gerrit.wikimedia.org/r/113024 (owner: 10Physikerwelt) [10:54:25] (03CR) 10Hashar: Prepere for next build (031 comment) [services/mathoid] - 10https://gerrit.wikimedia.org/r/113026 (owner: 10Physikerwelt) [10:54:33] (03CR) 10Bartosz Dziewoński: "Okay." [core] - 10https://gerrit.wikimedia.org/r/113307 (owner: 10Bartosz Dziewoński) [10:54:45] (03PS4) 10Bartosz Dziewoński: mediawiki.jqueryMsg: Don't throw parse errors in the user's face [core] - 10https://gerrit.wikimedia.org/r/113307 [10:59:04] (03PS1) 10Hashar: mathoidsvc-debian-glue [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/113347 [10:59:10] !jenkins mathoidsvc-debian-glue [10:59:49] (03CR) 10Hashar: [C: 032] mathoidsvc-debian-glue [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/113347 (owner: 10Hashar) [11:00:05] (03Merged) 10jenkins-bot: mathoidsvc-debian-glue [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/113347 (owner: 10Hashar) [11:01:10] (03PS1) 10Hashar: Trigger mathoidsvc-debian-glue [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/113348 [11:01:22] (03CR) 10Hashar: [C: 032] Trigger mathoidsvc-debian-glue [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/113348 (owner: 10Hashar) [11:01:26] (03Merged) 10jenkins-bot: Trigger mathoidsvc-debian-glue [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/113348 (owner: 10Hashar) [11:04:12] (03PS1) 10Hashar: Jenkins job validation (DO NOT SUBMIT) [services/mathoid] - 10https://gerrit.wikimedia.org/r/113349 [11:04:31] (03PS2) 10Physikerwelt: npm version of debian package [services/mathoid] - 10https://gerrit.wikimedia.org/r/113025 [11:04:40] (03PS2) 10Hashar: Jenkins job validation (DO NOT SUBMIT) [services/mathoid] - 10https://gerrit.wikimedia.org/r/113349 [11:05:16] (03PS3) 10Hashar: Jenkins job validation (DO NOT SUBMIT) [services/mathoid] - 10https://gerrit.wikimedia.org/r/113349 [11:09:56] (03CR) 10Phuedx: [C: 032] Remove white-space: normal override. [extensions/GettingStarted] - 10https://gerrit.wikimedia.org/r/111262 (owner: 10Mattflaschen) [11:09:59] (03Merged) 10jenkins-bot: Remove white-space: normal override. [extensions/GettingStarted] - 10https://gerrit.wikimedia.org/r/111262 (owner: 10Mattflaschen) [11:10:51] (03PS4) 10Hashar: git-buildpckage configuration [services/mathoid] - 10https://gerrit.wikimedia.org/r/113349 [11:13:21] (03CR) 10Hashar: "This is merely to be able to run git-buildpackage via Jenkins at https://integration.wikimedia.org/ci/job/mathoidsvc-debian-glue to work" [services/mathoid] - 10https://gerrit.wikimedia.org/r/113349 (owner: 10Hashar) [11:15:07] (03CR) 10Hashar: "You might want to have the /debian directory in a different branch (i.e.: debian). That would let you update source and the Debian packag" [services/mathoid] - 10https://gerrit.wikimedia.org/r/113025 (owner: 10Physikerwelt) [11:15:39] (03CR) 10Hashar: "Please squash this change with previous https://gerrit.wikimedia.org/r/#/c/113025/" [services/mathoid] - 10https://gerrit.wikimedia.org/r/113026 (owner: 10Physikerwelt) [11:17:16] (03CR) 10Hashar: npm version of debian package (031 comment) [services/mathoid] - 10https://gerrit.wikimedia.org/r/113025 (owner: 10Physikerwelt) [11:36:56] (03CR) 10Norayr: "giving up on further changes, suggestion to use a range in future versions." (031 comment) [extensions/ConfirmEdit] - 10https://gerrit.wikimedia.org/r/113122 (owner: 10Norayr) [11:44:27] (03CR) 10Phuedx: [C: 032] Remove openTask cookie on logout [extensions/GettingStarted] - 10https://gerrit.wikimedia.org/r/113337 (owner: 10Mattflaschen) [11:44:30] (03Merged) 10jenkins-bot: Remove openTask cookie on logout [extensions/GettingStarted] - 10https://gerrit.wikimedia.org/r/113337 (owner: 10Mattflaschen) [11:52:48] MatmaRex: Do you know if mw.log.deprecate can be used also in cases like these? [11:52:49] https://github.com/wikimedia/mediawiki-core/blob/master/resources/mediawiki.api/mediawiki.api.parse.js#L11-L12 [11:52:56] (03PS2) 10Physikerwelt: Add MediaWiki extension MathSearch [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/112935 [11:52:57] (bug 61372) [11:54:39] helderwiki: nope, it can only be used to deprecate functions/properties [11:54:40] helderwiki: you can just use mw.log.warn instead [11:54:49] hmm... [11:54:57] ok [11:55:31] (03CR) 10Hashar: [C: 032] "Will do the Zuul triggers" [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/112935 (owner: 10Physikerwelt) [11:55:39] MatmaRex: do you think it is good idea to add warnings for those deprecated parameters of mw.Api methods? [11:55:47] (03Merged) 10jenkins-bot: Add MediaWiki extension MathSearch [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/112935 (owner: 10Physikerwelt) [11:56:00] it sounds okay to me [11:57:03] (03PS1) 10Hashar: Triggers mw/ext/MathSearch [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/113352 [11:57:46] (03CR) 10Hashar: [C: 032] Triggers mw/ext/MathSearch [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/113352 (owner: 10Hashar) [11:57:54] (03Merged) 10jenkins-bot: Triggers mw/ext/MathSearch [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/113352 (owner: 10Hashar) [11:59:52] (03PS1) 10Hashar: Jenkins job validation (DO NOT SUBMIT) [extensions/MathSearch] - 10https://gerrit.wikimedia.org/r/113353 [11:59:54] (03CR) 10jenkins-bot: [V: 04-1] Jenkins job validation (DO NOT SUBMIT) [extensions/MathSearch] - 10https://gerrit.wikimedia.org/r/113353 (owner: 10Hashar) [12:00:01] (03CR) 10Hashar: "should be fine now hopefully test change is https://gerrit.wikimedia.org/r/113353" [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/112935 (owner: 10Physikerwelt) [12:00:38] (03PS2) 10Hashar: Jenkins job validation (DO NOT SUBMIT) [extensions/MathSearch] - 10https://gerrit.wikimedia.org/r/113353 [12:00:48] (03CR) 10jenkins-bot: [V: 04-1] Jenkins job validation (DO NOT SUBMIT) [extensions/MathSearch] - 10https://gerrit.wikimedia.org/r/113353 (owner: 10Hashar) [12:33:05] (03CR) 10Phe: [C: 031] Adds inprop=preload support [extensions/ProofreadPage] - 10https://gerrit.wikimedia.org/r/113166 (owner: 10Tpt) [12:40:28] (03CR) 10Tpt: [C: 032] "Reviewed by Phe" [extensions/ProofreadPage] - 10https://gerrit.wikimedia.org/r/113166 (owner: 10Tpt) [12:40:36] (03Merged) 10jenkins-bot: Adds inprop=preload support [extensions/ProofreadPage] - 10https://gerrit.wikimedia.org/r/113166 (owner: 10Tpt) [12:53:44] (03CR) 10Siebrand: "of course..." [core] - 10https://gerrit.wikimedia.org/r/27206 (owner: 10Siebrand) [12:59:08] (03CR) 10Hashar: [C: 031] "Apparently tests are being run now :-D" [extensions/TwoFactorAuthentication] - 10https://gerrit.wikimedia.org/r/104508 (owner: 10Hashar) [13:01:09] (03CR) 10Siebrand: [C: 04-1] "i18n/L10n reviewed." (032 comments) [extensions/Popups] - 10https://gerrit.wikimedia.org/r/111983 (owner: 10Prtksxna) [13:02:09] (03PS1) 10Thiemo Mättig (WMDE): Performance of mediawiki.searchSuggest.js [core] - 10https://gerrit.wikimedia.org/r/113357 [13:04:03] (03CR) 10Daniel Kinzler: Introducing TitleValue (031 comment) [core] - 10https://gerrit.wikimedia.org/r/106517 (owner: 10Daniel Kinzler) [13:06:07] so... anyone up for the RFC chat on refactoring Title and Linker (aka "the TitleValue thing")? [13:06:27] DanielK_WMDE: I'm so here [13:06:33] where are we supposed to do it? [13:06:43] #mediawiki-rfc i guess [13:06:48] but we can just as well do it here [13:07:18] it's just you, aude, me, and... I dunno, ori? are you around? [13:07:40] I though anomie was coming too [13:09:56] manybubbles: when is that chat ? [13:10:02] now [13:10:03] I think I have dropped a bunch of mails [13:10:13] I think we'll use #mediawiki-rfc [13:10:20] awesome [13:16:07] (03PS1) 10Physikerwelt: MathSearch requires MySQL [extensions/MathSearch] - 10https://gerrit.wikimedia.org/r/113358 [13:16:12] (03CR) 10jenkins-bot: [V: 04-1] MathSearch requires MySQL [extensions/MathSearch] - 10https://gerrit.wikimedia.org/r/113358 (owner: 10Physikerwelt) [13:22:40] (03CR) 10Bartosz Dziewoński: [C: 032] Performance of mediawiki.searchSuggest.js [core] - 10https://gerrit.wikimedia.org/r/113357 (owner: 10Thiemo Mättig (WMDE)) [13:25:43] (03PS2) 10Physikerwelt: MathSearch requires MySQL [extensions/MathSearch] - 10https://gerrit.wikimedia.org/r/113358 [13:25:55] (03Merged) 10jenkins-bot: Performance of mediawiki.searchSuggest.js [core] - 10https://gerrit.wikimedia.org/r/113357 (owner: 10Thiemo Mättig (WMDE)) [13:26:00] (03PS3) 10Thiemo Mättig (WMDE): Avoid failing if calling the exposed mw.page.watch.updateWatchLink [core] - 10https://gerrit.wikimedia.org/r/111796 [13:26:32] (03PS3) 10Physikerwelt: MathSearch requires MySQL [extensions/MathSearch] - 10https://gerrit.wikimedia.org/r/113358 [13:26:49] (03CR) 10Physikerwelt: [C: 032] MathSearch requires MySQL [extensions/MathSearch] - 10https://gerrit.wikimedia.org/r/113358 (owner: 10Physikerwelt) [13:29:40] (03CR) 10jenkins-bot: [V: 04-1] MathSearch requires MySQL [extensions/MathSearch] - 10https://gerrit.wikimedia.org/r/113358 (owner: 10Physikerwelt) [13:29:45] (03Merged) 10jenkins-bot: MathSearch requires MySQL [extensions/MathSearch] - 10https://gerrit.wikimedia.org/r/113358 (owner: 10Physikerwelt) [13:36:57] (03PS1) 10Physikerwelt: Delete MWS submodule [extensions/MathSearch] - 10https://gerrit.wikimedia.org/r/113359 [13:37:32] (03PS2) 10Physikerwelt: Delete MWS submodule [extensions/MathSearch] - 10https://gerrit.wikimedia.org/r/113359 [13:38:18] (03CR) 10Physikerwelt: [C: 032] Delete MWS submodule [extensions/MathSearch] - 10https://gerrit.wikimedia.org/r/113359 (owner: 10Physikerwelt) [13:38:31] (03CR) 10Thiemo Mättig (WMDE): [C: 04-1] "I think this needs some browser tests. I will do all I can and report back." (032 comments) [core] - 10https://gerrit.wikimedia.org/r/111180 (owner: 10Bartosz Dziewoński) [13:39:11] (03CR) 10Manybubbles: [C: 031] "Not +1 in the "we should merge this" sense but +1 in the "most of my objections have evaporated" sense." (036 comments) [core] - 10https://gerrit.wikimedia.org/r/106517 (owner: 10Daniel Kinzler) [13:45:01] (03CR) 10Thiemo Mättig (WMDE): ".suggestions-special is not shortened any more and spans multiple lines now. You can test this when entering a very long search (with or w" [core] - 10https://gerrit.wikimedia.org/r/111180 (owner: 10Bartosz Dziewoński) [13:49:01] (03CR) 10Daniel Kinzler: Introducing TitleValue (035 comments) [core] - 10https://gerrit.wikimedia.org/r/106517 (owner: 10Daniel Kinzler) [13:50:23] how does mediawiki know if thumbnails are stale or not? [13:50:45] (03PS4) 10Werdna: Anonymous editor warning [extensions/Flow] - 10https://gerrit.wikimedia.org/r/109445 [13:53:11] (03CR) 10Werdna: "PS4 is a rebase. I think the "logged out while editing" thing should be a separate patchset." [extensions/Flow] - 10https://gerrit.wikimedia.org/r/109445 (owner: 10Werdna) [14:00:03] i'm deriving from FileBackendStore and it seems that it caches a lot [14:00:25] (03PS1) 10Umherirrender: Moved Release notes for Ia0dc5895 [core] - 10https://gerrit.wikimedia.org/r/113362 [14:01:06] i put $this->clearCache() in my doGetFileStat call to make sure stale stat calls aren't getting used [14:01:18] now it takes a long time, but it's still fetching stale data [14:01:37] my thumbnails are stored seperately, in a plain FSFFileBackend [14:02:06] so i think the thumbnails are cached correctly, but mediawiki might not be picking up that there's a new version because that stat call was cached... [14:14:16] (03PS2) 10Aklapper: [4.4] Upgrade InlineHistory extension [wikimedia/bugzilla/modifications] - 10https://gerrit.wikimedia.org/r/97994 [14:17:10] (03CR) 10Dzahn: [C: 032 V: 032] [4.4] Upgrade InlineHistory extension [wikimedia/bugzilla/modifications] - 10https://gerrit.wikimedia.org/r/97994 (owner: 10Aklapper) [14:18:59] (03CR) 10Dzahn: "no-op, this was already deployed on zirconium which is 4.4, we're just getting things in sync after the switch now" [wikimedia/bugzilla/modifications] - 10https://gerrit.wikimedia.org/r/97994 (owner: 10Aklapper) [14:19:42] (03PS6) 10Aklapper: [4.4] Upgrade two template files and reapply our custom changes [wikimedia/bugzilla/modifications] - 10https://gerrit.wikimedia.org/r/98005 [14:22:00] (03PS1) 10Umherirrender: Show 'Indexing by robots' status correct on action=info [core] - 10https://gerrit.wikimedia.org/r/113364 [14:23:04] (03PS2) 10Umherirrender: Show 'Indexing by robots' status correct on action=info [core] - 10https://gerrit.wikimedia.org/r/113364 [14:23:48] (03CR) 10Dzahn: [C: 032 V: 032] "no-op, just syncing with 4.4, already applied on zirconium" [wikimedia/bugzilla/modifications] - 10https://gerrit.wikimedia.org/r/98005 (owner: 10Aklapper) [14:23:50] (03CR) 10Manybubbles: Introducing TitleValue (032 comments) [core] - 10https://gerrit.wikimedia.org/r/106517 (owner: 10Daniel Kinzler) [14:24:44] (03CR) 10Thiemo Mättig (WMDE): "Sorry for the last comment. This is a bug at wikidata.org. It does not load mediawiki.searchSuggest.css. You patch did not changed that." [core] - 10https://gerrit.wikimedia.org/r/111180 (owner: 10Bartosz Dziewoński) [14:25:21] (03PS2) 10Aklapper: [4.4] Upgrade "Login"/"Email address" string to use upstream code [wikimedia/bugzilla/modifications] - 10https://gerrit.wikimedia.org/r/98008 [14:27:17] (03CR) 10Dzahn: [C: 032 V: 032] "already applied on zirconium, sync after 4.4 switch" [wikimedia/bugzilla/modifications] - 10https://gerrit.wikimedia.org/r/98008 (owner: 10Aklapper) [14:29:29] (03PS2) 10Aklapper: [4.4] Upgrade files to 4.4 and reapply one-liner custom patches [wikimedia/bugzilla/modifications] - 10https://gerrit.wikimedia.org/r/98025 [14:31:22] (03CR) 10Dzahn: [C: 032 V: 032] [4.4] Upgrade files to 4.4 and reapply one-liner custom patches [wikimedia/bugzilla/modifications] - 10https://gerrit.wikimedia.org/r/98025 (owner: 10Aklapper) [14:31:58] (03CR) 10Dzahn: "no-op" [wikimedia/bugzilla/modifications] - 10https://gerrit.wikimedia.org/r/98025 (owner: 10Aklapper) [14:32:18] (03PS3) 10Aklapper: [4.4] Sync with upstream 4.4 [wikimedia/bugzilla/modifications] - 10https://gerrit.wikimedia.org/r/98028 [14:33:28] (03CR) 10Manybubbles: [C: 032] Moved Ruby code that multiple repositories use to mediawiki_selenium Ruby gem [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/112672 (owner: 10Zfilipin) [14:33:36] (03Merged) 10jenkins-bot: Moved Ruby code that multiple repositories use to mediawiki_selenium Ruby gem [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/112672 (owner: 10Zfilipin) [14:34:31] (03CR) 10Dzahn: [C: 032] "sync with zirconium. no-op" [wikimedia/bugzilla/modifications] - 10https://gerrit.wikimedia.org/r/98028 (owner: 10Aklapper) [14:34:43] (03CR) 10Dzahn: [V: 032] "sync with zirconium. no-op" [wikimedia/bugzilla/modifications] - 10https://gerrit.wikimedia.org/r/98028 (owner: 10Aklapper) [14:35:30] (03PS2) 10Aklapper: [4.4] Sync MoreBugUrl extension with upstream [wikimedia/bugzilla/modifications] - 10https://gerrit.wikimedia.org/r/98031 [14:36:38] (03CR) 10Dzahn: [C: 032 V: 032] "sync with zirconium. already applied" [wikimedia/bugzilla/modifications] - 10https://gerrit.wikimedia.org/r/98031 (owner: 10Aklapper) [14:37:35] (03PS2) 10Aklapper: [4.4] Sync custom file with upstream 4.4 and reapply custom patch [wikimedia/bugzilla/modifications] - 10https://gerrit.wikimedia.org/r/98032 [14:39:33] (03CR) 10Dzahn: [C: 032 V: 032] "just sync with zirconium, already applied" [wikimedia/bugzilla/modifications] - 10https://gerrit.wikimedia.org/r/98032 (owner: 10Aklapper) [14:42:37] (03PS3) 10Manybubbles: Moved tests from browsertests repository [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/113131 (owner: 10Zfilipin) [14:42:46] (03CR) 10Manybubbles: [C: 032] Moved tests from browsertests repository [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/113131 (owner: 10Zfilipin) [14:42:50] (03Merged) 10jenkins-bot: Moved tests from browsertests repository [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/113131 (owner: 10Zfilipin) [14:43:35] (03PS7) 10Aklapper: [4.4] Sync MoreBugUrl extension, add our custom patches [wikimedia/bugzilla/modifications] - 10https://gerrit.wikimedia.org/r/98035 [14:47:04] (03CR) 10Dzahn: [C: 032 V: 032] "already applied on zirconium, sync after 4.4 upgrade" [wikimedia/bugzilla/modifications] - 10https://gerrit.wikimedia.org/r/98035 (owner: 10Aklapper) [14:49:31] (03CR) 10Anomie: [C: 031] "Should probably be formally announced in RELEASE-NOTES. Something like "$wgSkipSkin, which has been replaceable by $wgSkipSkins since 2005" [core] - 10https://gerrit.wikimedia.org/r/113341 (owner: 10TTO) [14:49:36] (03PS3) 10Physikerwelt: Jenkins job validation (DO NOT SUBMIT) [extensions/MathSearch] - 10https://gerrit.wikimedia.org/r/113353 (owner: 10Hashar) [14:50:15] (03Abandoned) 10Physikerwelt: Jenkins job validation (DO NOT SUBMIT) [extensions/MathSearch] - 10https://gerrit.wikimedia.org/r/113353 (owner: 10Hashar) [14:51:55] (03CR) 10Dzahn: "checked every single file, yes, no-op, the deleted file is replaced by upstream version and so on" [wikimedia/bugzilla/modifications] - 10https://gerrit.wikimedia.org/r/98035 (owner: 10Aklapper) [14:52:14] (03PS2) 10Aklapper: [4.4] Sync custom file with upstream 4.4 and reapply custom patch [wikimedia/bugzilla/modifications] - 10https://gerrit.wikimedia.org/r/101643 [14:53:13] (03CR) 10Anomie: [C: 031] "Haven't tested, looks good." [core] - 10https://gerrit.wikimedia.org/r/110162 (owner: 10TTO) [14:53:22] (03CR) 10Dzahn: [C: 032 V: 032] [4.4] Sync custom file with upstream 4.4 and reapply custom patch [wikimedia/bugzilla/modifications] - 10https://gerrit.wikimedia.org/r/101643 (owner: 10Aklapper) [14:54:04] (03CR) 10Dzahn: "this was also already applied. done with the 4.4 syncs" [wikimedia/bugzilla/modifications] - 10https://gerrit.wikimedia.org/r/101643 (owner: 10Aklapper) [14:54:11] (03CR) 10Physikerwelt: "yes git buildpackage would be great. what branch names do you suggest. Is https://wikitech.wikimedia.org/wiki/Git-buildpackage up to date" [services/mathoid] - 10https://gerrit.wikimedia.org/r/113349 (owner: 10Hashar) [14:56:10] (03CR) 10Bartosz Dziewoński: "Possibly related: https://bugzilla.wikimedia.org/show_bug.cgi?id=12330#c2" [core] - 10https://gerrit.wikimedia.org/r/110162 (owner: 10TTO) [14:56:46] (03PS2) 10TTO: Update custom Component label to match 4.4 styling [wikimedia/bugzilla/modifications] - 10https://gerrit.wikimedia.org/r/113095 [14:57:00] (03PS3) 10Aklapper: duplicates.cgi: Add "Resolution" and "Priority" columns [wikimedia/bugzilla/modifications] - 10https://gerrit.wikimedia.org/r/105938 [14:59:45] (03CR) 10Dzahn: [C: 032 V: 032] Update custom Component label to match 4.4 styling [wikimedia/bugzilla/modifications] - 10https://gerrit.wikimedia.org/r/113095 (owner: 10TTO) [15:00:42] (03CR) 10Dzahn: "deployed" [wikimedia/bugzilla/modifications] - 10https://gerrit.wikimedia.org/r/113095 (owner: 10TTO) [15:03:41] (03CR) 10Dzahn: [C: 031] "looks we're ready for this one next, now" [wikimedia/bugzilla/modifications] - 10https://gerrit.wikimedia.org/r/105938 (owner: 10Aklapper) [15:04:29] (03PS1) 10Zfilipin: Renamed the feature to Smoke test [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/113366 [15:04:40] (03CR) 10Dzahn: "andre, and another one, now the other pending 4.4 sync changes are in" [wikimedia/bugzilla/modifications] - 10https://gerrit.wikimedia.org/r/106883 (owner: 10Tinaj1234) [15:05:06] (03CR) 10Dzahn: "urgh, needs manual rebase now" [wikimedia/bugzilla/modifications] - 10https://gerrit.wikimedia.org/r/106883 (owner: 10Tinaj1234) [15:05:21] (03CR) 10Manybubbles: [C: 032] Renamed the feature to Smoke test [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/113366 (owner: 10Zfilipin) [15:05:27] (03Merged) 10jenkins-bot: Renamed the feature to Smoke test [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/113366 (owner: 10Zfilipin) [15:21:47] (03PS14) 10Daniel Kinzler: Introducing TitleValue [core] - 10https://gerrit.wikimedia.org/r/106517 [15:22:36] (03CR) 10Daniel Kinzler: "PS14 addresses some concerns raised during an RFC session with Nik and Katie." [core] - 10https://gerrit.wikimedia.org/r/106517 (owner: 10Daniel Kinzler) [15:23:17] (03CR) 10jenkins-bot: [V: 04-1] Introducing TitleValue [core] - 10https://gerrit.wikimedia.org/r/106517 (owner: 10Daniel Kinzler) [15:23:47] (03CR) 10Dzahn: [C: 032 V: 032] duplicates.cgi: Add "Resolution" and "Priority" columns [wikimedia/bugzilla/modifications] - 10https://gerrit.wikimedia.org/r/105938 (owner: 10Aklapper) [15:27:11] greg-g: you asked for that :) ^ works? [15:35:51] (03PS1) 10Dan-nl: add Art Photo template to GWToolset [extensions/GWToolset] - 10https://gerrit.wikimedia.org/r/113369 [15:43:29] <^d> DanielK_WMDE: The ns# bit. The "ns" just seemed a bit redundant. [15:46:46] (03PS3) 10Thiemo Mättig (WMDE): jquery.suggestions, mediawiki.searchSuggest: Don't use jquery.autoEllipsis [core] - 10https://gerrit.wikimedia.org/r/111180 (owner: 10Bartosz Dziewoński) [15:52:36] (03CR) 10Aklapper: [C: 031] "Tested locally (still setting up Labs after the 4.4 upgrade) and the patch works as expected plus is simple. +1 & thanks!" [wikimedia/bugzilla/modifications] - 10https://gerrit.wikimedia.org/r/113170 (owner: 10Tim Landscheidt) [16:01:24] (03PS1) 10Manybubbles: Make reindex process less brittle [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/113371 [16:01:56] (03CR) 10Dzahn: [C: 04-1] "ok, well, now on 4.4 we don't have that file, /template/en/custom/global/ does not have user-error.html.tmpl.,so it's using /en/default/gl" [wikimedia/bugzilla/modifications] - 10https://gerrit.wikimedia.org/r/106883 (owner: 10Tinaj1234) [16:04:07] (03CR) 10Dzahn: [C: 032 V: 032] Add exemption to the CVE linker for Ubuntu security links [wikimedia/bugzilla/modifications] - 10https://gerrit.wikimedia.org/r/113170 (owner: 10Tim Landscheidt) [16:05:28] (03CR) 10Dzahn: "deployed,please confirm" [wikimedia/bugzilla/modifications] - 10https://gerrit.wikimedia.org/r/113170 (owner: 10Tim Landscheidt) [16:13:27] mutante: yay! [16:13:41] :) [16:19:56] (03PS1) 10UltrasonicNXT: Prevent the sending of purely-whitespace messages [extensions/MediaWikiChat] - 10https://gerrit.wikimedia.org/r/113372 [16:21:01] ^d: yea, got rid of it. working on some fixes, will push soon [16:22:03] <^d> DanielK_WMDE: Btw, I'll be glad to see this go forward now...I've finally come around I think. Let's be bold and try new things :) [16:22:11] (03CR) 10UltrasonicNXT: "Wow, thanks for this, this is amazing!" [extensions/MediaWikiChat] - 10https://gerrit.wikimedia.org/r/113164 (owner: 10Gerrit Patch Uploader) [16:22:11] <^d> Otherwise we'll be stuck on 1.x forever [16:22:29] <^d> (A 1.x mindset, that is) [16:24:54] ^d: yay :) maybe say something to that effect on gerrit or on the RFC page? would be good to document the growing consensus. [16:32:06] (03CR) 10Chad: [C: 031] "From just skimming things it looks like this has come a long way from the proposal I was so skeptical of a year or so ago. This is looking" [core] - 10https://gerrit.wikimedia.org/r/106517 (owner: 10Daniel Kinzler) [16:34:35] ^d: thanks [16:36:19] (03CR) 10UltrasonicNXT: [C: 032 V: 032] Prevent the sending of purely-whitespace messages [extensions/MediaWikiChat] - 10https://gerrit.wikimedia.org/r/113372 (owner: 10UltrasonicNXT) [16:42:05] (03CR) 10Anomie: Introducing TitleValue (0325 comments) [core] - 10https://gerrit.wikimedia.org/r/106517 (owner: 10Daniel Kinzler) [16:42:44] hey gwicke! [16:42:53] do you happen to know how i can run just a specific parser test? [16:42:58] running them all takes forever :/ [16:51:54] (03PS4) 10Werdna: Extract wiki and external links, file and template usages from text. [extensions/Flow] - 10https://gerrit.wikimedia.org/r/110090 [16:51:57] (03CR) 10jenkins-bot: [V: 04-1] Extract wiki and external links, file and template usages from text. [extensions/Flow] - 10https://gerrit.wikimedia.org/r/110090 (owner: 10Werdna) [16:54:06] (03CR) 10UltrasonicNXT: Flood control, Tab nick completion, Nick mention hilight, new sounds, Check to disable sounds, Settings to disable mediawiki parsing, resize (031 comment) [extensions/MediaWikiChat] - 10https://gerrit.wikimedia.org/r/113164 (owner: 10Gerrit Patch Uploader) [16:54:08] (03PS4) 10Zfilipin: Moved tests from browsertests repository [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/112895 [16:54:29] anomie: thanks for the thorough review, following up now [16:54:59] (03CR) 10Cmcmahon: [C: 032] Moved tests from browsertests repository [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/112895 (owner: 10Zfilipin) [16:55:05] (03Merged) 10jenkins-bot: Moved tests from browsertests repository [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/112895 (owner: 10Zfilipin) [16:55:16] (03PS5) 10Werdna: Extract wiki and external links, file and template usages from text. [extensions/Flow] - 10https://gerrit.wikimedia.org/r/110090 [16:55:29] (03CR) 10jenkins-bot: [V: 04-1] Extract wiki and external links, file and template usages from text. [extensions/Flow] - 10https://gerrit.wikimedia.org/r/110090 (owner: 10Werdna) [16:55:48] (03CR) 10Werdna: "PS4: Fix all the bugs in recording things in the links tables." [extensions/Flow] - 10https://gerrit.wikimedia.org/r/110090 (owner: 10Werdna) [16:58:13] (03PS3) 10Zfilipin: Moved tests from browsertests repository [extensions/WikiLove] - 10https://gerrit.wikimedia.org/r/113104 [16:59:06] (03CR) 10GWicke: "I don't see why we should move the debian dir to a different branch, as this is a native debian project. Making it easy for developers to " [services/mathoid] - 10https://gerrit.wikimedia.org/r/113349 (owner: 10Hashar) [17:10:59] (03CR) 10UltrasonicNXT: Flood control, Tab nick completion, Nick mention hilight, new sounds, Check to disable sounds, Settings to disable mediawiki parsing, resize (031 comment) [extensions/MediaWikiChat] - 10https://gerrit.wikimedia.org/r/113164 (owner: 10Gerrit Patch Uploader) [17:11:32] (03CR) 10Ori.livneh: [C: 032] Convert scap-1 to python [tools/scap] - 10https://gerrit.wikimedia.org/r/112487 (owner: 10BryanDavis) [17:11:34] (03Merged) 10jenkins-bot: Convert scap-1 to python [tools/scap] - 10https://gerrit.wikimedia.org/r/112487 (owner: 10BryanDavis) [17:11:54] omg. thanks Ori [17:19:41] MatmaRex: i have a new toy i want to show off [17:20:22] <^d> mwgrep? [17:20:23] <^d> :p [17:20:48] yep [17:21:00] MatmaRex: http://p.defau.lt/?0eceD4Xb6nlpDWffK05MsQ [17:21:19] (03PS1) 10Mattflaschen: Add WikimediaEvents role [vagrant] - 10https://gerrit.wikimedia.org/r/113375 [17:21:35] ori: ha [17:21:42] superm401: vagrant is an MMORPG [17:22:00] <^d> More like choose your own adventure :p [17:22:05] ori, heh, yep. I've been thinking maybe it could use Composer for some of the simpler ones. [17:22:15] that is totally cool [17:22:15] If we go ahead and add that to some extensions. [17:22:18] ori: can it also check user scripts? :D [17:22:43] * MatmaRex wonders how that works [17:22:44] ori, whoa, that's really cool. [17:23:01] <^d> MatmaRex: elasticsearch magic :) [17:23:20] ^d, oh, it's all pages? Nice. :) [17:23:27] <^d> All indexes. [17:23:31] Right [17:23:33] <^d> Limited to MW namespace at the moment. [17:23:48] it's ^d and manybubble's content indexing that makes it possible [17:24:11] It would also be possible to write a version hitting Common.js and looping through the gadgets directly, but it would be a *lot* slower. [17:24:24] Would be nice to seach user scripts too, like legoktm said. [17:24:30] (03CR) 10Krusher: Flood control, Tab nick completion, Nick mention hilight, new sounds, Check to disable sounds, Settings to disable mediawiki parsing, resize (033 comments) [extensions/MediaWikiChat] - 10https://gerrit.wikimedia.org/r/113164 (owner: 10Gerrit Patch Uploader) [17:25:02] MatmaRex: i'll look into exposing it somehow. but for now feel free to make requests if you need to query something [17:25:19] <^d> Well, we want to expose all of the indexes to labs. [17:25:27] oh, well, that's awesome [17:25:31] ori: okay, first one: gM [17:25:33] :D [17:25:40] MatmaRex: gM? [17:25:56] <^d> ori: It's on the medium-ish term roadmap to replicate the indexes to labs once move to eqiad's done. [17:25:59] gM. [17:26:19] MatmaRex: http://p.defau.lt/?QmG9qvIaMJz5xm_7U1rAxQ [17:26:28] it's a jquerymsg thing, window.gM, mostly same as mw.message(…).parse() [17:26:36] that many D: [17:26:42] the price for less outages would likely be slower deployment, waiting for even more +1 before anything gets merged [17:26:55] MatmaRex: eh the first one matched 'wgMonthNames' [17:27:01] <^d> mutante: Read: better code :p [17:27:03] heh [17:27:09] well, that is deprecated too :P [17:27:18] ^d: well, yea, it tends to get better with more reviews [17:28:22] (03CR) 10Chad: [C: 032] Make reindex process less brittle [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/113371 (owner: 10Manybubbles) [17:28:28] (03Merged) 10jenkins-bot: Make reindex process less brittle [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/113371 (owner: 10Manybubbles) [17:29:42] ori: what does that tool do? [17:30:32] does it accept regexes as input? [17:30:41] helderwiki: fast substring search through .js and .css titles in the mediawiki ns [17:30:53] helderwiki: it doesn't but could if that was a requirement [17:31:25] :-) [17:32:29] I have a small list of regexes I use to update scripts on WMF wikis, so, it would be nice to add support for regexes [17:33:27] https://github.com/Krinkle/mw-gadgets-jsUpdater/blob/master/src/jsUpdater.js#L31 [17:33:33] (03CR) 10Parent5446: [C: 032] "Yep I figured it out. Turns out overriding the constructor messes everything up for PHPUnit." [extensions/TwoFactorAuthentication] - 10https://gerrit.wikimedia.org/r/104508 (owner: 10Hashar) [17:33:38] (03Merged) 10jenkins-bot: default entry point for extension + sqlite db update [extensions/TwoFactorAuthentication] - 10https://gerrit.wikimedia.org/r/104508 (owner: 10Hashar) [17:33:42] (or my current fork of that: https://pt.wikibooks.org/wiki/Utilizador:Helder.wiki/Tools/jsUpdater.js ) [17:34:20] ori: is the tool publicly available? [17:34:39] (03CR) 10Matthias Mullie: [C: 032] Tag browser tests with @clean [extensions/Flow] - 10https://gerrit.wikimedia.org/r/112874 (owner: 10Hashar) [17:34:42] (03CR) 10jenkins-bot: [V: 04-1] Tag browser tests with @clean [extensions/Flow] - 10https://gerrit.wikimedia.org/r/112874 (owner: 10Hashar) [17:35:35] (03CR) 10Daniel Kinzler: "re @anomie" (0322 comments) [core] - 10https://gerrit.wikimedia.org/r/106517 (owner: 10Daniel Kinzler) [17:35:58] ori: care to have a look at the TitleValue stuff? https://gerrit.wikimedia.org/r/#/c/106517/ [17:38:23] ^d: is there a way to run a single parser test?... [17:38:34] running them all takes forever [17:38:48] <^d> I think there's a --regex parameter or something. [17:39:34] there's --filter, which works fine for matchign regular tests, but doesn't seem to work with individual parser tests [17:39:45] or maybe i was doing it wrong? [17:40:27] <^d> Hmm. [17:40:45] ^d: technically, the "name" of the parser test is the name of the dataset. the test is called ParserTests::testParserTest. [17:40:48] not useful for filtering [17:40:55] <^d> Bleh [17:41:21] (03PS5) 1001tonythomas: Add link to Bugzilla etiquette page in footer [wikimedia/bugzilla/modifications] - 10https://gerrit.wikimedia.org/r/106757 [17:41:34] <^d> DanielK_WMDE: Maybe with ./tests/parserTests.php? [17:41:35] i guess i can just comment outt all other tests :P [17:41:40] <^d> Instead of phpunit [17:41:56] oh, right, that might work [17:42:08] <^d> Ah yes, it has --regex [17:42:56] ^d: so it does, thanks! [17:43:03] though it seems to fail to initialize some stuff [17:43:03] <^d> yw [17:43:06] <^d> Bleh [17:43:12] <^d> We can't win! [17:43:13] <^d> :( [17:43:16] Notice: Undefined index: localhost (wikidata2) in /var/www/daniel/wikidata/includes/profiler/Profiler.php on line 311 [17:43:21] crud [17:44:14] (03CR) 10Aklapper: [C: 031] "Looks good to me now. Thanks everybody!" [wikimedia/bugzilla/modifications] - 10https://gerrit.wikimedia.org/r/106757 (owner: 1001tonythomas) [17:44:23] even if i turn off profiling? what gives? [17:45:28] PHP Notice: LCStoreDB::startWrite: Transaction already in progress (from LocalFile::recordUpload2) [17:45:33] grr [17:45:55] Error: 1146 Table 'wikidata2.parsertest_sites' doesn't exist (localhost) [17:46:14] parserTests.php seems broken [17:51:34] (03PS1) 10Matthias Mullie: Fix CU formatter test [extensions/Flow] - 10https://gerrit.wikimedia.org/r/113379 [17:53:07] helderwiki: it can only run from the cluster, so it's restricted to wmfers with shell for now. but ^d says it'll be available in labs sometime. [17:53:16] DanielK_WMDE: i'll try! [17:53:17] (03PS1) 10EBernhardson: Gracefully handle empty pagination result [extensions/Flow] - 10https://gerrit.wikimedia.org/r/113380 [17:53:23] great! [17:54:01] (03PS1) 10Matthias Mullie: Remove old CU formatter [extensions/Flow] - 10https://gerrit.wikimedia.org/r/113381 [17:56:06] (03CR) 10UltrasonicNXT: "What's the JS function 'ie' for? You don't use it..." [extensions/MediaWikiChat] - 10https://gerrit.wikimedia.org/r/113164 (owner: 10Gerrit Patch Uploader) [17:57:07] (03CR) 10EBernhardson: [C: 032] Remove old CU formatter [extensions/Flow] - 10https://gerrit.wikimedia.org/r/113381 (owner: 10Matthias Mullie) [17:57:16] (03Merged) 10jenkins-bot: Remove old CU formatter [extensions/Flow] - 10https://gerrit.wikimedia.org/r/113381 (owner: 10Matthias Mullie) [17:57:41] <^d> helderwiki: We've got a bug for this if you want to follow along, 43652. [17:58:05] <^d> tl;dr: medium term I want to replicate the search indexes to labs like the databases for free querying. [17:58:19] (03CR) 10EBernhardson: [C: 032] Fix CU formatter test [extensions/Flow] - 10https://gerrit.wikimedia.org/r/113379 (owner: 10Matthias Mullie) [17:58:21] I'm already watching that bug... o.O [17:58:25] (03CR) 10UltrasonicNXT: Flood control, Tab nick completion, Nick mention hilight, new sounds, Check to disable sounds, Settings to disable mediawiki parsing, resize (033 comments) [extensions/MediaWikiChat] - 10https://gerrit.wikimedia.org/r/113164 (owner: 10Gerrit Patch Uploader) [17:58:28] (03Merged) 10jenkins-bot: Fix CU formatter test [extensions/Flow] - 10https://gerrit.wikimedia.org/r/113379 (owner: 10Matthias Mullie) [17:58:38] ^d: thanks! [17:59:47] (03PS3) 10Matthias Mullie: Split permission-logic into separate method [extensions/Flow] - 10https://gerrit.wikimedia.org/r/112158 [18:00:04] (03CR) 10EBernhardson: [C: 032] Don't propagate permissions to older revisions [extensions/Flow] - 10https://gerrit.wikimedia.org/r/112042 (owner: 10Matthias Mullie) [18:00:14] (03Merged) 10jenkins-bot: Don't propagate permissions to older revisions [extensions/Flow] - 10https://gerrit.wikimedia.org/r/112042 (owner: 10Matthias Mullie) [18:00:17] (03CR) 10EBernhardson: [C: 032] Split permission-logic into separate method [extensions/Flow] - 10https://gerrit.wikimedia.org/r/112158 (owner: 10Matthias Mullie) [18:00:20] (03CR) 10Matthias Mullie: [C: 032] Gracefully handle empty pagination result [extensions/Flow] - 10https://gerrit.wikimedia.org/r/113380 (owner: 10EBernhardson) [18:00:24] (03Merged) 10jenkins-bot: Split permission-logic into separate method [extensions/Flow] - 10https://gerrit.wikimedia.org/r/112158 (owner: 10Matthias Mullie) [18:00:32] (03Merged) 10jenkins-bot: Gracefully handle empty pagination result [extensions/Flow] - 10https://gerrit.wikimedia.org/r/113380 (owner: 10EBernhardson) [18:01:23] ori: did you ran the grepper for "mw.user.name" too? [18:02:50] helderwiki: http://p.defau.lt/?LKGQJQwUx_wd9NAztJ114g [18:03:11] (03PS4) 10Matthias Mullie: Tests for PostRevisionable [extensions/Flow] - 10https://gerrit.wikimedia.org/r/112797 [18:03:20] (03CR) 10jenkins-bot: [V: 04-1] Tests for PostRevisionable [extensions/Flow] - 10https://gerrit.wikimedia.org/r/112797 (owner: 10Matthias Mullie) [18:03:59] (03PS5) 10Matthias Mullie: Tests for PostRevisionable [extensions/Flow] - 10https://gerrit.wikimedia.org/r/112797 [18:04:48] ori: great! No Portuguese wikis to fix :-) [18:06:53] (03CR) 10Ori.livneh: [C: 032] Add WikimediaEvents role [vagrant] - 10https://gerrit.wikimedia.org/r/113375 (owner: 10Mattflaschen) [18:06:56] (03Merged) 10jenkins-bot: Add WikimediaEvents role [vagrant] - 10https://gerrit.wikimedia.org/r/113375 (owner: 10Mattflaschen) [18:09:28] (03PS3) 10Matthias Mullie: Make sure permission checks also check against current revisions [extensions/Flow] - 10https://gerrit.wikimedia.org/r/112160 [18:09:35] (03CR) 10jenkins-bot: [V: 04-1] Make sure permission checks also check against current revisions [extensions/Flow] - 10https://gerrit.wikimedia.org/r/112160 (owner: 10Matthias Mullie) [18:10:28] (03PS4) 10Matthias Mullie: Make sure permission checks also check against current revisions [extensions/Flow] - 10https://gerrit.wikimedia.org/r/112160 [18:12:49] (03PS5) 10Matthias Mullie: Make sure permission checks also check against current revisions [extensions/Flow] - 10https://gerrit.wikimedia.org/r/112160 [18:15:19] (03PS10) 10Ori.livneh: Remove namespace restriction for mention notifications [extensions/Echo] - 10https://gerrit.wikimedia.org/r/93508 (owner: 10Gerrit Patch Uploader) [18:15:29] (03CR) 10jenkins-bot: [V: 04-1] Remove namespace restriction for mention notifications [extensions/Echo] - 10https://gerrit.wikimedia.org/r/93508 (owner: 10Gerrit Patch Uploader) [18:17:44] (03PS3) 10Matthias Mullie: Some permission fixes [extensions/Flow] - 10https://gerrit.wikimedia.org/r/112161 [18:21:23] (03CR) 10JGonera: mediawiki.log: Move #warn and #deprecate to mediawiki.js and add tracking (031 comment) [core] - 10https://gerrit.wikimedia.org/r/111957 (owner: 10Krinkle) [18:23:09] (03CR) 10J-squared: "Thanks for the details and link!" [extensions/EducationProgram] - 10https://gerrit.wikimedia.org/r/113145 (owner: 10J-squared) [18:23:26] (03PS4) 10Matthias Mullie: Tag browser tests with @clean [extensions/Flow] - 10https://gerrit.wikimedia.org/r/112874 (owner: 10Hashar) [18:23:46] (03CR) 10Matthias Mullie: [C: 032] Tag browser tests with @clean [extensions/Flow] - 10https://gerrit.wikimedia.org/r/112874 (owner: 10Hashar) [18:23:50] (03Abandoned) 10EBernhardson: Track revision length within recent changes [extensions/Flow] - 10https://gerrit.wikimedia.org/r/113155 (owner: 10EBernhardson) [18:23:56] (03Merged) 10jenkins-bot: Tag browser tests with @clean [extensions/Flow] - 10https://gerrit.wikimedia.org/r/112874 (owner: 10Hashar) [18:25:39] (03PS11) 10Ori.livneh: Remove namespace restriction for mention notifications [extensions/Echo] - 10https://gerrit.wikimedia.org/r/93508 (owner: 10Gerrit Patch Uploader) [18:25:45] (03CR) 10jenkins-bot: [V: 04-1] Remove namespace restriction for mention notifications [extensions/Echo] - 10https://gerrit.wikimedia.org/r/93508 (owner: 10Gerrit Patch Uploader) [18:30:00] (03PS2) 10Matthias Mullie: Add some more details to RC tables [extensions/Flow] - 10https://gerrit.wikimedia.org/r/112169 [18:30:12] (03PS1) 10Kaldari: Removing the max-width for now per Erik [extensions/VectorBeta] - 10https://gerrit.wikimedia.org/r/113383 [18:30:39] (03CR) 10Kaldari: [C: 032] Reduce TOC padding slightly in new typography [extensions/VectorBeta] - 10https://gerrit.wikimedia.org/r/113315 (owner: 10JGonera) [18:30:42] (03Merged) 10jenkins-bot: Reduce TOC padding slightly in new typography [extensions/VectorBeta] - 10https://gerrit.wikimedia.org/r/113315 (owner: 10JGonera) [18:30:51] (03PS1) 10EBernhardson: Cleanup some static analysis warnings [extensions/Flow] - 10https://gerrit.wikimedia.org/r/113384 [18:32:14] (03PS2) 10EBernhardson: Catch and log exceptions with RC formatting [extensions/Flow] - 10https://gerrit.wikimedia.org/r/113156 [18:34:26] (03CR) 10Aaron Schulz: [C: 032] "Thanks" [core] - 10https://gerrit.wikimedia.org/r/113362 (owner: 10Umherirrender) [18:34:53] (03PS2) 10EBernhardson: Consolidate history i18n parameters into AbstractFormatter [extensions/Flow] - 10https://gerrit.wikimedia.org/r/113157 [18:36:22] (03CR) 10Krusher: Flood control, Tab nick completion, Nick mention hilight, new sounds, Check to disable sounds, Settings to disable mediawiki parsing, resize (032 comments) [extensions/MediaWikiChat] - 10https://gerrit.wikimedia.org/r/113164 (owner: 10Gerrit Patch Uploader) [18:37:23] (03CR) 10Matthias Mullie: [C: 032] "hooray" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/113384 (owner: 10EBernhardson) [18:37:33] (03Merged) 10jenkins-bot: Cleanup some static analysis warnings [extensions/Flow] - 10https://gerrit.wikimedia.org/r/113384 (owner: 10EBernhardson) [18:37:52] (03Merged) 10jenkins-bot: Moved Release notes for Ia0dc5895 [core] - 10https://gerrit.wikimedia.org/r/113362 (owner: 10Umherirrender) [18:38:46] (03CR) 10Matthias Mullie: [C: 032] Catch and log exceptions with RC formatting [extensions/Flow] - 10https://gerrit.wikimedia.org/r/113156 (owner: 10EBernhardson) [18:38:56] (03Merged) 10jenkins-bot: Catch and log exceptions with RC formatting [extensions/Flow] - 10https://gerrit.wikimedia.org/r/113156 (owner: 10EBernhardson) [18:39:31] Can someone please walk me through the process of modifying code, testing and uploading for a bug? [18:39:41] I am using vagrant developing environment [18:40:18] I am having a hard time figuring out how to modify and test the code [18:43:50] Punitkoura: well, modifying is the easy part (if you know what to modify): use a text editor. [18:44:12] to test, go to the tests/phpunit/ directory and run: php phpunit.php [18:44:24] and of course, manually test that what you did does what you wanted it to do. [18:44:58] i don't know how to push your change to gerrit from a vagrant install though - you'd need your ssh credentials on the vagrant vm, i suppose. [18:45:11] * DanielK_WMDE has never used vagrant [18:45:45] mediawiki and extensions are cloned into a directory on the host environment that is shared with the vm [18:45:57] specifically, mediawiki/ under the mediawiki-vagrant repository root [18:46:21] ah, great, ori knows the details! [18:46:22] so you can push the change from either environment, but yeah, doing so on the guest requires copying keys over [18:47:10] <^d> I'd use vagrant more if I could get it working fine with parallels. [18:47:45] <^d> (Getting it working with non-virtualbox providers might be a nice roadmappy-type item) [18:47:50] and then the changes would take effect when I reboot the vm? [18:48:23] (03CR) 10Bartosz Dziewoński: "I had a patch related to the silly !Object.defineProperty check, it ended up abandoned. https://gerrit.wikimedia.org/r/#/c/92067/1" [core] - 10https://gerrit.wikimedia.org/r/111957 (owner: 10Krinkle) [18:51:31] Punitkoura: no, the change should take effect immediately [18:52:01] i don't know whether vagrant keeps modifications between reboots at all [18:52:38] Punitkoura: that is, if it is a change to PHP (or JS or CSS), and no cachign is interfering with your tests. [18:52:58] other changes (like apache config) may require you to restart services [18:53:24] (03CR) 10UltrasonicNXT: Flood control, Tab nick completion, Nick mention hilight, new sounds, Check to disable sounds, Settings to disable mediawiki parsing, resize (031 comment) [extensions/MediaWikiChat] - 10https://gerrit.wikimedia.org/r/113164 (owner: 10Gerrit Patch Uploader) [18:53:40] (03PS1) 10EBernhardson: Cleanup all undefined class analysis warnings [extensions/Flow] - 10https://gerrit.wikimedia.org/r/113385 [18:54:27] ok thanks Daniel [18:54:36] (03CR) 10EBernhardson: [C: 04-1] Add some more details to RC tables (031 comment) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/112169 (owner: 10Matthias Mullie) [18:56:25] (03CR) 10Dzahn: [C: 032 V: 032] Add link to Bugzilla etiquette page in footer [wikimedia/bugzilla/modifications] - 10https://gerrit.wikimedia.org/r/106757 (owner: 1001tonythomas) [18:56:27] (03PS3) 10Matthias Mullie: Add some more details to RC tables [extensions/Flow] - 10https://gerrit.wikimedia.org/r/112169 [18:57:48] (03PS2) 10UltrasonicNXT: Flood control, Tab nick completion, Nick mention hilight, new sounds, Check to disable sounds, Settings to disable mediawiki parsing, resizeable window. Does not include OGG files, so sounds won't work until added. [extensions/MediaWikiChat] - 10https://gerrit.wikimedia.org/r/113164 (owner: 10Gerrit Patch Uploader) [18:58:06] hi dr0ptp4kt [18:58:37] dr0ptp4kt: is Dan Garry around perchance? (in the SF office) [18:58:43] hola and holla, sumana [18:58:48] :D [18:58:53] i think he just walked in, one sec sumanah [18:59:19] sumanah: I think he's in a meeting, but maybe just getting out [18:59:39] Pinged him for you [18:59:49] Et voila. [18:59:58] Hello! [19:00:08] CALL HIM AND HE COMETH! [19:00:42] <^d> dr0ptp4kt: You said something about search? [19:00:45] <^d> In -operations? [19:00:50] (03CR) 10Matthias Mullie: Add some more details to RC tables (031 comment) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/112169 (owner: 10Matthias Mullie) [19:00:59] I am needed? [19:01:04] (03CR) 10EBernhardson: [C: 032] Some permission fixes [extensions/Flow] - 10https://gerrit.wikimedia.org/r/112161 (owner: 10Matthias Mullie) [19:01:07] yeah, you said domainsdontmatter! [19:01:13] (03Merged) 10jenkins-bot: Some permission fixes [extensions/Flow] - 10https://gerrit.wikimedia.org/r/112161 (owner: 10Matthias Mullie) [19:01:14] ^d ^ [19:01:16] ^^ [19:01:26] <^d> Hehe :) [19:01:45] and i said search is the hotness [19:01:54] sumanah: brion doesn't seem to be around. i guess i'll be online for another hour or two. getting feedback from him on gerrit is probably more useful than chatting with him anyway, though. [19:02:01] hey Deskana! just wanted to ask you quickly about some Wikidata-related stuff if now is good [19:02:06] (03CR) 10Krusher: Flood control, Tab nick completion, Nick mention hilight, new sounds, Check to disable sounds, Settings to disable mediawiki parsing, resize (031 comment) [extensions/MediaWikiChat] - 10https://gerrit.wikimedia.org/r/113164 (owner: 10Gerrit Patch Uploader) [19:02:10] sumanah: Sure. [19:02:16] DanielK_WMDE: well they are different kinds of useful, but if that's what you need right now, then that makes sense, sure [19:02:24] thanks dr0ptp4kt & rdwrer [19:02:28] (03CR) 10EBernhardson: [C: 032] Add some more details to RC tables [extensions/Flow] - 10https://gerrit.wikimedia.org/r/112169 (owner: 10Matthias Mullie) [19:02:30] <^d> dr0ptp4kt: Old and busted. New hotness. Old and busted... [19:02:39] (03Merged) 10jenkins-bot: Add some more details to RC tables [extensions/Flow] - 10https://gerrit.wikimedia.org/r/112169 (owner: 10Matthias Mullie) [19:02:47] Mais bien sur [19:02:51] anomie did a pretty thorough review earlier, that was helpful. it's keeping me busy for hours :) [19:02:56] :) [19:03:05] hope i can get everything fixed until i have to go [19:03:32] <^d> sumanah: Did you also see that DanielK_WMDE has converted me? [19:03:34] Deskana: so are you generally the one updating the statuses that go into https://www.mediawiki.org/wiki/Wikimedia_Platform_Engineering ? [19:03:55] you can call me the convertonator... [19:04:09] ^d: to metrics? to vim? to a new religion? to what? no I didn't know.... [19:04:24] sumanah: to a more modularized approach [19:04:35] oh this makes a great deal more sense [19:04:38] <^d> I gave him a +1 on TitleValue and said "let's be bold or we'll end up in a 1.x mindset forever" [19:04:39] sumanah: Sometimes I do it, but for the most part it's the engineers. [19:04:49] ^d: great! [19:05:03] (03PS3) 10EBernhardson: Make a method to check permissions against only the specific revision [extensions/Flow] - 10https://gerrit.wikimedia.org/r/112162 (owner: 10Matthias Mullie) [19:05:13] (03CR) 10jenkins-bot: [V: 04-1] Make a method to check permissions against only the specific revision [extensions/Flow] - 10https://gerrit.wikimedia.org/r/112162 (owner: 10Matthias Mullie) [19:05:17] (03CR) 10EBernhardson: [C: 032] "PS3: rebased" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/112162 (owner: 10Matthias Mullie) [19:05:24] (03CR) 10jenkins-bot: [V: 04-1] Make a method to check permissions against only the specific revision [extensions/Flow] - 10https://gerrit.wikimedia.org/r/112162 (owner: 10Matthias Mullie) [19:05:34] Deskana: cool. I see https://www.mediawiki.org/wiki/Wikidata_deployment is in "recently completed" [19:05:40] The Church Of Separation Of Concerns And Its Profet JeroenDeDauw! [19:06:02] Deskana: but last status is Status: (2014-01-monthly) .... is there anything WMF Platform needs to do there? [19:06:07] (like, continuing?) [19:06:11] (03CR) 10Dzahn: "deployed, lgtm, new links in Bugzilla footer work" [wikimedia/bugzilla/modifications] - 10https://gerrit.wikimedia.org/r/106757 (owner: 1001tonythomas) [19:06:53] (03CR) 10Matthias Mullie: [C: 032] Cleanup all undefined class analysis warnings (031 comment) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/113385 (owner: 10EBernhardson) [19:07:02] (03Merged) 10jenkins-bot: Cleanup all undefined class analysis warnings [extensions/Flow] - 10https://gerrit.wikimedia.org/r/113385 (owner: 10EBernhardson) [19:07:36] sumanah: Wikidata isn't mentioned at all on https://www.mediawiki.org/wiki/Wikimedia_Platform_Engineering for me. [19:07:57] Deskana: you expand the "recently completed" section in MW Core and it windowshades to reveal Wikidata support [19:07:58] (03CR) 10AndyRussG: "Hi again..." [extensions/EducationProgram] - 10https://gerrit.wikimedia.org/r/113145 (owner: 10J-squared) [19:08:06] (03CR) 10Bsitu: Add diff view of changes to board header (031 comment) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/109431 (owner: 10Bsitu) [19:08:11] sumanah: Ahh, my bad. I didn't realise it could be expanded. [19:08:11] (03CR) 10Dzahn: "one odd thing here to add. this also fixed a broken
  • Logged in as$nbsp; in line 43 of the footer. but you can't see that in t" [wikimedia/bugzilla/modifications] - 10https://gerrit.wikimedia.org/r/106757 (owner: 1001tonythomas) [19:08:42] Deskana, I'm sure you are not the only one. [19:09:00] sumanah: Considering I was just in a meeting that talked about Wikidata deployments, I question the classification of this project as "recently completed". [19:09:11] * sumanah laughs slightly helplessly [19:09:26] Deskana: feel free to edit https://www.mediawiki.org/wiki/Wikimedia_Platform_Engineering and move it back into the current projects section! [19:11:36] sumanah: That page says "Sumana Harihareswara (lead — on leave)" :P [19:11:53] hoo: I should edit a bunch of those. thanks for the reminder [19:12:17] sumanah: It also seems a bit misleading to describe it as a current project... but it's certainly more misleading to declare it completed, so I will do. [19:13:29] (03CR) 10Mattflaschen: "It's better performance not to throw and catch and error every time. I don't know how much of a difference it is, but I think the version" [core] - 10https://gerrit.wikimedia.org/r/111957 (owner: 10Krinkle) [19:14:25] Deskana: totally makes sense. You may want to generally rearrange the MW Core projects on that page or make additional project pages: https://www.mediawiki.org/wiki/Wikimedia_Engineering/Project_documentation_howto [19:14:34] (03CR) 10Dzahn: [C: 031] "heh yea, that's how you tell our code from upstream, gerrit marks theirs in red for you:) i know, but in this case it's actually nicer to " [wikimedia/bugzilla/modifications] - 10https://gerrit.wikimedia.org/r/113073 (owner: 10Aklapper) [19:15:47] (03CR) 10Dzahn: "i take that back, he's right for this one" [wikimedia/bugzilla/modifications] - 10https://gerrit.wikimedia.org/r/113073 (owner: 10Aklapper) [19:20:27] (03PS4) 10Matthias Mullie: Make a method to check permissions against only the specific revision [extensions/Flow] - 10https://gerrit.wikimedia.org/r/112162 [19:21:06] (03CR) 10Matthias Mullie: "This one was dependant on another change (and using Revisionable terminology) - fixed that again" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/112162 (owner: 10Matthias Mullie) [19:21:33] (03PS2) 10Dzahn: Fix UI regression in side bar introduced in bug 59889 [wikimedia/bugzilla/modifications] - 10https://gerrit.wikimedia.org/r/113073 (owner: 10Aklapper) [19:23:53] (03PS2) 10Matthias Mullie: restore should look at previous revision for correct value [extensions/Flow] - 10https://gerrit.wikimedia.org/r/112840 [19:27:09] hi jarry1250__! good to see you. Will I see you in Zurich and/or at Wikimania? [19:29:30] (03CR) 10EBernhardson: Alternative way of dealing with edit conflicts (031 comment) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/108635 (owner: 10Matthias Mullie) [19:30:01] sumanah: Received order, thanks very much :) [19:30:19] :) thanks for the LibrePlanet work rdwrer [19:30:25] Of course! [19:31:00] (03PS6) 10EBernhardson: Alternative way of dealing with edit conflicts [extensions/Flow] - 10https://gerrit.wikimedia.org/r/108635 (owner: 10Matthias Mullie) [19:31:08] rdwrer: it's in the Boston area, right? do you think Rachel Thomas would be interested in coming? [19:31:16] Possibly! [19:31:22] (03CR) 10EBernhardson: [C: 032] "PS6: added missing function parameter" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/108635 (owner: 10Matthias Mullie) [19:31:24] I'm not very much in contact with her [19:31:31] (03Merged) 10jenkins-bot: Alternative way of dealing with edit conflicts [extensions/Flow] - 10https://gerrit.wikimedia.org/r/108635 (owner: 10Matthias Mullie) [19:32:10] I should almost certainly ask SJ to rally troops for us. [19:32:12] (03PS1) 10Matthias Mullie: Return null instead of failing when requesting previous revision if there is none [extensions/Flow] - 10https://gerrit.wikimedia.org/r/113389 [19:34:30] (03PS2) 10EBernhardson: Make tipsies disappear on cancel & tipsy-click [extensions/Flow] - 10https://gerrit.wikimedia.org/r/113057 (owner: 10Matthias Mullie) [19:34:45] (03CR) 10EBernhardson: [C: 032] "PS2: rebased" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/113057 (owner: 10Matthias Mullie) [19:34:54] (03Merged) 10jenkins-bot: Make tipsies disappear on cancel & tipsy-click [extensions/Flow] - 10https://gerrit.wikimedia.org/r/113057 (owner: 10Matthias Mullie) [19:38:09] (03PS1) 10Ori.livneh: Bump schema revision to 7494934 [extensions/NavigationTiming] - 10https://gerrit.wikimedia.org/r/113390 [19:43:57] (03PS3) 10Umherirrender: Show 'Indexing by robots' status correct on action=info [core] - 10https://gerrit.wikimedia.org/r/113364 [19:44:05] (03CR) 10Chad: [C: 032] Bump schema revision to 7494934 [extensions/NavigationTiming] - 10https://gerrit.wikimedia.org/r/113390 (owner: 10Ori.livneh) [19:44:09] (03CR) 10IAlex: [C: 032] Show 'Indexing by robots' status correct on action=info [core] - 10https://gerrit.wikimedia.org/r/113364 (owner: 10Umherirrender) [19:45:24] (03Merged) 10jenkins-bot: Bump schema revision to 7494934 [extensions/NavigationTiming] - 10https://gerrit.wikimedia.org/r/113390 (owner: 10Ori.livneh) [19:47:59] (03Merged) 10jenkins-bot: Show 'Indexing by robots' status correct on action=info [core] - 10https://gerrit.wikimedia.org/r/113364 (owner: 10Umherirrender) [19:50:16] (03PS1) 10Ori.livneh: role::navigationtiming: set $wgNavigationTimingSamplingFactor = 1 [vagrant] - 10https://gerrit.wikimedia.org/r/113391 [19:52:02] (03CR) 10Ori.livneh: [C: 032] role::navigationtiming: set $wgNavigationTimingSamplingFactor = 1 [vagrant] - 10https://gerrit.wikimedia.org/r/113391 (owner: 10Ori.livneh) [19:52:05] (03Merged) 10jenkins-bot: role::navigationtiming: set $wgNavigationTimingSamplingFactor = 1 [vagrant] - 10https://gerrit.wikimedia.org/r/113391 (owner: 10Ori.livneh) [19:53:06] (03PS6) 10Bsitu: Add diff view of changes to board header [extensions/Flow] - 10https://gerrit.wikimedia.org/r/109431 [19:53:28] (03CR) 10Bsitu: [C: 04-2] "rebased only" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/109431 (owner: 10Bsitu) [19:53:57] (03CR) 10EBernhardson: [C: 032] Make sure permission checks also check against current revisions [extensions/Flow] - 10https://gerrit.wikimedia.org/r/112160 (owner: 10Matthias Mullie) [19:54:07] (03Merged) 10jenkins-bot: Make sure permission checks also check against current revisions [extensions/Flow] - 10https://gerrit.wikimedia.org/r/112160 (owner: 10Matthias Mullie) [19:55:27] (03CR) 10EBernhardson: Make a method to check permissions against only the specific revision (031 comment) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/112162 (owner: 10Matthias Mullie) [19:55:33] (03PS5) 10EBernhardson: Make a method to check permissions against only the specific revision [extensions/Flow] - 10https://gerrit.wikimedia.org/r/112162 (owner: 10Matthias Mullie) [19:56:01] (03CR) 10EBernhardson: [C: 032] "PS5: address !instanceof vs === null" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/112162 (owner: 10Matthias Mullie) [19:56:05] (03PS1) 10Ori.livneh: Update NavigationTiming to master [core] (wmf/1.23wmf14) - 10https://gerrit.wikimedia.org/r/113393 [19:56:08] (03PS1) 10Ori.livneh: Update NavigationTiming to master [core] (wmf/1.23wmf13) - 10https://gerrit.wikimedia.org/r/113394 [19:56:20] (03CR) 10Ori.livneh: [C: 032] Update NavigationTiming to master [core] (wmf/1.23wmf14) - 10https://gerrit.wikimedia.org/r/113393 (owner: 10Ori.livneh) [19:56:29] (03CR) 10Ori.livneh: [C: 032] Update NavigationTiming to master [core] (wmf/1.23wmf13) - 10https://gerrit.wikimedia.org/r/113394 (owner: 10Ori.livneh) [19:56:48] anomie, have a sec? [19:56:56] (03Merged) 10jenkins-bot: Make a method to check permissions against only the specific revision [extensions/Flow] - 10https://gerrit.wikimedia.org/r/112162 (owner: 10Matthias Mullie) [19:57:03] yurik: sure [19:57:29] (03CR) 10Ori.livneh: [V: 032] Update NavigationTiming to master [core] (wmf/1.23wmf14) - 10https://gerrit.wikimedia.org/r/113393 (owner: 10Ori.livneh) [19:57:37] (03CR) 10Ori.livneh: [V: 032] Update NavigationTiming to master [core] (wmf/1.23wmf13) - 10https://gerrit.wikimedia.org/r/113394 (owner: 10Ori.livneh) [19:58:21] anomie, i was analyzing some usage patterns for the continue, it seems that it would be very convinient in some cases to have a one value continue - so instead of merging original request + all name-value pairs, just take one "continue" value and pass it in... what do you think? [19:58:51] that basically means we would have to do escaped merge of all continue values into one [19:59:28] yurik: I think you're over-complicating things. It's not hard for clients to use your "simple" continue, why try to make an even-simpler continue? [20:00:09] example: in a number of internal use cases the client has to expose the continuation state as part of the link [20:00:10] yurik: BTW, https://gerrit.wikimedia.org/r/#/c/111954/ [20:00:36] oh yes, i saw it, really need to look closely into it, sry [20:01:26] yurik: If you're making internal API calls and then returning links with the continuation to the user, you can easily enough handle packaging the continuation in your code that calls the API. [20:01:43] anomie, take a look at https://gerrit.wikimedia.org/r/#/c/113255/1/includes/api/ApiMobileLangLinks.php -- this is a patch by max that i'm reviewing atm, and on line 45 [20:02:11] having one param avoids all the clients from doing the packaging logic [20:02:36] On the other hand, it then means we have *three* continuation methods. Overly complex. [20:02:36] (03PS1) 10Mwalker: Merge remote-tracking branch 'gerrit/REL1_22' into fundraising/REL1_22 [core] (fundraising/REL1_22) - 10https://gerrit.wikimedia.org/r/113395 [20:02:48] (03PS2) 10Mattflaschen: Log title moves using the PageMove schema [extensions/WikimediaEvents] - 10https://gerrit.wikimedia.org/r/113261 (owner: 10Phuedx) [20:02:53] (03CR) 10Mwalker: [C: 032] Merge remote-tracking branch 'gerrit/REL1_22' into fundraising/REL1_22 [core] (fundraising/REL1_22) - 10https://gerrit.wikimedia.org/r/113395 (owner: 10Mwalker) [20:02:59] (03CR) 10Mwalker: [V: 032] Merge remote-tracking branch 'gerrit/REL1_22' into fundraising/REL1_22 [core] (fundraising/REL1_22) - 10https://gerrit.wikimedia.org/r/113395 (owner: 10Mwalker) [20:03:08] not really - because we can convert everyone to the new method very easily :) [20:03:42] since by definition if client merges the reply, it will simply have just one instead of two+ [20:04:10] we will simply return one name-value pair in the continue block instead of multiple [20:04:11] yurik: Oh, ugh. Why in the world is an API module doing "new ApiMain"?? [20:04:32] that's actually pretty common for internal calls [20:04:43] i think opensearch or something else does it too [20:04:59] (03CR) 10Mattflaschen: "That's just a trivial doc fix to note that they're page IDs, and a corresponding bump to the schema for the same reason, plus a typo." [extensions/WikimediaEvents] - 10https://gerrit.wikimedia.org/r/113261 (owner: 10Phuedx) [20:05:07] do we have a shortcut for internal calls from api? [20:06:07] anomie, both ApiFeedWatchlist & apiParse do that too [20:06:30] (03CR) 10Aklapper: [C: 031] "Deployed PS2 on boogs.wmflabs.org, and created two saved reports to test that section is only displayed if reports exist. All working as e" [wikimedia/bugzilla/modifications] - 10https://gerrit.wikimedia.org/r/113073 (owner: 10Aklapper) [20:10:06] yurik: Also ugh. [20:10:48] anomie, apimain is based on the request object. When internal calls are made, apimain is always created. Did you ever see any other approach? [20:10:59] the cost is fairly low IIRC [20:11:10] but in any case, this is besides the point [20:18:00] (03CR) 10Dzahn: [C: 032 V: 032] Fix UI regression in side bar introduced in bug 59889 [wikimedia/bugzilla/modifications] - 10https://gerrit.wikimedia.org/r/113073 (owner: 10Aklapper) [20:19:35] ugh! help! isValidInterwiki( 'en' ) returns false for me. [20:19:38] why would that be?? [20:20:22] DanielK_WMDE: What's that JS? [20:20:34] * What's that? JA? [20:20:36] * JS [20:21:28] hm? [20:21:38] no, in PHP. [20:21:40] $this->assertTrue( Interwiki::isValidInterwiki( 'en' ) ); [20:21:48] fails. every time. with any language code i tried. [20:21:50] wtf? [20:21:53] what am i doing wrong? [20:22:11] sorry... that function name sounded very JSish [20:26:50] DanielK_WMDE: mh... guess you already tried the obvious stuff like checking your DB? [20:27:22] hoo: why would the DB matter? shouldn't any valid language code work? [20:27:43] oh, right - must be in the interwiki table... and turns magic if it's also a language code. [20:27:44] DanielK_WMDE: Nope, that's not how that's supposed to work [20:27:45] hm. [20:27:49] interwiki table, it is [20:28:40] yep, it's there. but i guess it's not there in the clone during unit tests... [20:28:42] gah [20:29:02] grr. who do i ask about this? [20:29:50] AaronSchulz: can you give me a hint how to use interwiki prefixes in test cases? the test clone of the interwiki table is empty, it seems. [20:29:56] so, do i just inject stuff there? [20:30:00] how do other tests do that? [20:30:04] The Wikidata team does a lot with interwiki, you should as them... no seriously, I doubt anyone maintains that [20:30:23] hoo: with interwiki? like, what? [20:30:35] we use the new sites table. same issue, different thing [20:31:38] I know... but there's no one really doing anything with that these days (I guess... and hope) [20:32:08] but you can't test anythign related to interwiki linking without that... [20:32:12] that class serves multiple purposes, nice.... general data fetcher (static), but also it can be a value object for an Interwiki... [20:32:19] so, i guess that means we have no tests for anything related to interwiki linking? [20:32:21] yay. [20:32:23] (03CR) 10Mattflaschen: [C: 031] "Looks good to merge, but I'm giving Halfak a chance to review." [extensions/WikimediaEvents] - 10https://gerrit.wikimedia.org/r/113261 (owner: 10Phuedx) [20:33:49] ooohhhh! TitleTest uses "localtestiw" and "remotetestiw"! [20:33:49] * AaronSchulz doesn't like interwiki prefixes anyway [20:33:53] still debugging math slowness atm [20:34:05] DanielK_WMDE: You could hook into InterwikiLoadPrefix or stuff things into the DB, that's all we have... [20:34:12] AaronSchulz: sorry for bugging you, i think i got a lead now! [20:34:38] hoo: i'll try doing what TitleTest does, seems like there are some magic interwikis defined for testing [20:34:58] DanielK_WMDE: Not magic... might be taht MediaWikiTestCase loads them [20:35:25] yea, or Interwiki has a hardcoded special case. whatever :P [20:35:42] hm... doesn't seem like it?? [20:35:45] what gives? [20:37:23] DanielK_WMDE: Ah I see how they're doing it [20:37:36] yea, me too! [20:37:38] You can set wgLocalInterwiki and then that will work [20:37:39] hahaha, omg! [20:37:53] no, look what they do for remotetestiw! [20:38:03] they do hook into InterwikiLoadPrefix [20:38:09] eek! [20:38:14] bahaha [20:38:25] m( [20:38:55] static functions & global state, ftw! [20:39:29] \o/ [20:39:36] this cost me an hour :( [20:39:49] hoo: thanks for baring with me :P [20:40:05] heh ;) Enough messy code for now... [20:48:26] (03PS15) 10Daniel Kinzler: Introducing TitleValue [core] - 10https://gerrit.wikimedia.org/r/106517 [20:48:44] two parser tests still failing locally... [20:48:53] oh, well. enough for today. [20:49:36] (03CR) 10Nemo bis: "> I'm of mixed opinions of it this should display anything [...]" [core] - 10https://gerrit.wikimedia.org/r/106625 (owner: 10AalekhN) [20:52:33] (03CR) 10jenkins-bot: [V: 04-1] Introducing TitleValue [core] - 10https://gerrit.wikimedia.org/r/106517 (owner: 10Daniel Kinzler) [20:53:54] (03PS1) 10Ori.livneh: Add support for "%{fieldName}i"-style format specifiers [extensions/EventLogging] - 10https://gerrit.wikimedia.org/r/113457 [20:54:26] (03CR) 10jenkins-bot: [V: 04-1] Add support for "%{fieldName}i"-style format specifiers [extensions/EventLogging] - 10https://gerrit.wikimedia.org/r/113457 (owner: 10Ori.livneh) [20:55:45] (03PS2) 10Ori.livneh: Add support for "%{fieldName}i"-style format specifiers [extensions/EventLogging] - 10https://gerrit.wikimedia.org/r/113457 [20:55:51] Nemo_bis: What did I say that about? [20:56:12] (03CR) 10Nemo bis: "Thanks for your patch, it now needs rebase though. :( https://www.mediawiki.org/wiki/Gerrit/Advanced_usage#Build_failed_due_to_merge_confl" [core] - 10https://gerrit.wikimedia.org/r/66319 (owner: 10Worden.lee) [20:57:54] (03CR) 10Nemo bis: "And this one needs rebase too. It would use comments on the concept though." [core] - 10https://gerrit.wikimedia.org/r/85199 (owner: 10Ejegg) [20:57:54] oh, hm. [20:58:04] (03PS3) 10Ori.livneh: Add support for "%{fieldName}i"-style format specifiers [extensions/EventLogging] - 10https://gerrit.wikimedia.org/r/113457 [20:59:24] (03CR) 10Ori.livneh: "Relevant: " [extensions/EventLogging] - 10https://gerrit.wikimedia.org/r/113457 (owner: 10Ori.livneh) [21:03:07] (03PS1) 10Phuedx: Convert CSS to LESS [extensions/GettingStarted] - 10https://gerrit.wikimedia.org/r/113459 [21:03:30] (03CR) 10Yuvipanda: [C: 032] Removing the max-width for now per Erik [extensions/VectorBeta] - 10https://gerrit.wikimedia.org/r/113383 (owner: 10Kaldari) [21:03:42] (03Merged) 10jenkins-bot: Removing the max-width for now per Erik [extensions/VectorBeta] - 10https://gerrit.wikimedia.org/r/113383 (owner: 10Kaldari) [21:04:34] (03CR) 10Kaldari: [C: 032] Optically align heading serif font with sans-serif content font [extensions/VectorBeta] - 10https://gerrit.wikimedia.org/r/113320 (owner: 10JGonera) [21:04:38] (03Merged) 10jenkins-bot: Optically align heading serif font with sans-serif content font [extensions/VectorBeta] - 10https://gerrit.wikimedia.org/r/113320 (owner: 10JGonera) [21:06:03] (03CR) 10Nemo bis: "Welcome and thanks for your patch! Remember, you can just click the "abandon" button to indicate this was a test patch that needs no code " [extensions/OpenBadges] - 10https://gerrit.wikimedia.org/r/112310 (owner: 10Aizhuli90) [21:07:58] (03CR) 10Nemo bis: "Gomoko, thanks for sharing your patch and welcome. A bug report would help get more visibility for the idea, if you wish. It's IMHO unlike" [core] - 10https://gerrit.wikimedia.org/r/104905 (owner: 10Gomoko) [21:08:36] (03PS1) 10Aklapper: Delete unused and duplicated file. [wikimedia/bugzilla/modifications] - 10https://gerrit.wikimedia.org/r/113460 [21:09:23] (03CR) 10Aklapper: [C: 031] "Deleted on boogs (Labs) and the world did not collapse. +1." [wikimedia/bugzilla/modifications] - 10https://gerrit.wikimedia.org/r/113460 (owner: 10Aklapper) [21:09:31] (03CR) 10Nemo bis: "Thank you for working on this extension. There is interest about it, so don't forget to remind people about this patch, e.g. on IRC at #me" [extensions/Drafts] - 10https://gerrit.wikimedia.org/r/105200 (owner: 10Gomoko) [21:10:20] (03PS16) 10Daniel Kinzler: Introducing TitleValue [core] - 10https://gerrit.wikimedia.org/r/106517 [21:12:32] (03PS1) 10Aklapper: Remove Sitemap extension from Git. Was removed from server already. Also see bug 33406. [wikimedia/bugzilla/modifications] - 10https://gerrit.wikimedia.org/r/113461 [21:12:43] still one test failing, comments welcome. not sure about that one actually, it seems quite strange [21:14:08] (03CR) 10jenkins-bot: [V: 04-1] Introducing TitleValue [core] - 10https://gerrit.wikimedia.org/r/106517 (owner: 10Daniel Kinzler) [21:14:18] (03PS2) 10Aklapper: Remove Sitemap extension from Git. Was removed from server already. Also see bug 33406. [wikimedia/bugzilla/modifications] - 10https://gerrit.wikimedia.org/r/113461 [21:14:37] (03CR) 10Aklapper: [C: 031] Remove Sitemap extension from Git. Was removed from server already. Also see bug 33406. [wikimedia/bugzilla/modifications] - 10https://gerrit.wikimedia.org/r/113461 (owner: 10Aklapper) [21:15:33] yurik: if you have any idea what causes this, let me know: https://integration.wikimedia.org/ci/job/mediawiki-core-phpunit-api/19915/console [21:15:42] ...ideally, here: https://gerrit.wikimedia.org/r/#/c/106517/ [21:15:46] i'm about to go offline. [21:16:50] (03CR) 10Nemo bis: "Welcome, Hatul, and thanks for the patch. This issue however is a can of worms, I'm afraid it's not very suitable as first approach to Med" [core] - 10https://gerrit.wikimedia.org/r/103744 (owner: 10Hatul) [21:17:25] (03CR) 10Brian Wolff: [C: 04-1] "Re nemo: Was that about showing the input box when someone does just {{Special:Whatlinkshere}} - I would prefer it not be shown, but don't" (031 comment) [core] - 10https://gerrit.wikimedia.org/r/106625 (owner: 10AalekhN) [21:19:34] DanielK_WMDE, no idea [21:22:43] (03CR) 10Nemo bis: "Thanks for the patch and welcome, an ambitious first patch! Indeed this needs some more high-level discussion to define the goals better a" [core] - 10https://gerrit.wikimedia.org/r/99162 (owner: 10Kambiz Darabi) [21:22:56] (03PS3) 10EBernhardson: Make history entries also check previous revisions if restored [extensions/Flow] - 10https://gerrit.wikimedia.org/r/112163 (owner: 10Matthias Mullie) [21:23:22] (03CR) 10EBernhardson: [C: 032] "rebased" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/112163 (owner: 10Matthias Mullie) [21:23:26] (03CR) 10Halfak: [C: 031] Log article deletions using the PageDeletion schema [extensions/WikimediaEvents] - 10https://gerrit.wikimedia.org/r/113263 (owner: 10Phuedx) [21:23:32] (03Merged) 10jenkins-bot: Make history entries also check previous revisions if restored [extensions/Flow] - 10https://gerrit.wikimedia.org/r/112163 (owner: 10Matthias Mullie) [21:23:35] (03CR) 10Anomie: "Any particular reason not to convert it to HTMLForm and let that handle laying out all the form fields? Then we get all sorts of field typ" [extensions/ContactPage] - 10https://gerrit.wikimedia.org/r/110276 (owner: 10Reedy) [21:25:03] (03CR) 10Halfak: [C: 04-1] "I forgot a field specifying the schema. See: https://meta.wikimedia.org/w/index.php?title=Schema%3APageMove&diff=7495717&oldid=7495133" [extensions/WikimediaEvents] - 10https://gerrit.wikimedia.org/r/113261 (owner: 10Phuedx) [21:25:31] (03CR) 10Anomie: "Oh, checkboxes are there already." [extensions/ContactPage] - 10https://gerrit.wikimedia.org/r/110276 (owner: 10Reedy) [21:25:49] (03PS2) 10EBernhardson: Check permissions in RecentChanges & Contributions feeds [extensions/Flow] - 10https://gerrit.wikimedia.org/r/112583 (owner: 10Matthias Mullie) [21:26:01] (03CR) 10EBernhardson: "PS2: rebased" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/112583 (owner: 10Matthias Mullie) [21:26:10] (03CR) 10Nemo bis: "And it still does... Christian, are you able to make the gerrit dabase behave? Sam, you can probably rebase this patch to make it independ" [extensions/ExternalArticles] - 10https://gerrit.wikimedia.org/r/66230 (owner: 10Samwilson) [21:28:25] (03PS5) 10Nemo bis: Changed Special:GlobalUsers to inherit from AlphabeticPager [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/97531 (owner: 10Zsaigol) [21:29:13] (03PS1) 10Matthias Mullie: Revisionable->Collection [extensions/Flow] - 10https://gerrit.wikimedia.org/r/113463 [21:30:15] (03PS2) 10Spage: Return null instead of failing when requesting previous revision if there is none [extensions/Flow] - 10https://gerrit.wikimedia.org/r/113389 (owner: 10Matthias Mullie) [21:30:18] (03CR) 10EBernhardson: [C: 032] Check permissions in RecentChanges & Contributions feeds (031 comment) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/112583 (owner: 10Matthias Mullie) [21:30:31] (03Merged) 10jenkins-bot: Check permissions in RecentChanges & Contributions feeds [extensions/Flow] - 10https://gerrit.wikimedia.org/r/112583 (owner: 10Matthias Mullie) [21:30:43] (03PS2) 10Matthias Mullie: Use more permissive isRevisionAllowed on helper tools. [extensions/Flow] - 10https://gerrit.wikimedia.org/r/112596 [21:30:48] (03CR) 10EBernhardson: [C: 032] Use more permissive isRevisionAllowed on helper tools. [extensions/Flow] - 10https://gerrit.wikimedia.org/r/112596 (owner: 10Matthias Mullie) [21:30:58] (03Merged) 10jenkins-bot: Use more permissive isRevisionAllowed on helper tools. [extensions/Flow] - 10https://gerrit.wikimedia.org/r/112596 (owner: 10Matthias Mullie) [21:32:13] (03CR) 10Ori.livneh: [C: 032] "Merging for now to unkludge vanadium, but reviews more than welcome." [extensions/EventLogging] - 10https://gerrit.wikimedia.org/r/113457 (owner: 10Ori.livneh) [21:32:30] (03CR) 10Nemo bis: "Hi, thanks for the patch. "HTML works on Chrome 31" is a bit too weak to make reviewers confident, I suggest to spend a few minutes testin" [core] - 10https://gerrit.wikimedia.org/r/108221 (owner: 10Westurner) [21:32:42] (03Merged) 10jenkins-bot: Add support for "%{fieldName}i"-style format specifiers [extensions/EventLogging] - 10https://gerrit.wikimedia.org/r/113457 (owner: 10Ori.livneh) [21:32:57] (03CR) 10Legoktm: [C: 04-1] Changed Special:GlobalUsers to inherit from AlphabeticPager (031 comment) [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/97531 (owner: 10Zsaigol) [21:35:02] (03CR) 10Nemo bis: "Still needs rebase." [core] - 10https://gerrit.wikimedia.org/r/61283 (owner: 10Poke) [21:36:04] (03PS12) 10Ori.livneh: Remove namespace restriction for mention notifications [extensions/Echo] - 10https://gerrit.wikimedia.org/r/93508 (owner: 10Gerrit Patch Uploader) [21:36:13] (03CR) 10jenkins-bot: [V: 04-1] Remove namespace restriction for mention notifications [extensions/Echo] - 10https://gerrit.wikimedia.org/r/93508 (owner: 10Gerrit Patch Uploader) [21:37:05] (03PS6) 10Matthias Mullie: Tests for PostCollection [extensions/Flow] - 10https://gerrit.wikimedia.org/r/112797 [21:37:16] (03CR) 10jenkins-bot: [V: 04-1] Tests for PostCollection [extensions/Flow] - 10https://gerrit.wikimedia.org/r/112797 (owner: 10Matthias Mullie) [21:37:53] (03CR) 10Nemo bis: "Thanks for your first gerrit patch and welcome. Adding MaxSem because he reviewed the original patch." [core] - 10https://gerrit.wikimedia.org/r/111126 (owner: 10Nx) [21:38:12] (03PS13) 10Ori.livneh: Remove namespace restriction for mention notifications [extensions/Echo] - 10https://gerrit.wikimedia.org/r/93508 (owner: 10Gerrit Patch Uploader) [21:40:21] (03CR) 10Reedy: "Laziness mostly..." [extensions/ContactPage] - 10https://gerrit.wikimedia.org/r/110276 (owner: 10Reedy) [21:42:01] (03CR) 10Spage: [C: 031] "Fixes it for me. Usual confusion about strict testing for null vs. loose !." (031 comment) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/113389 (owner: 10Matthias Mullie) [21:42:37] (03CR) 10Nemo bis: "Thanks for your first patch and welcome. It's still not clear in the commit message, and most importantly release notes, what happens to w" [core] - 10https://gerrit.wikimedia.org/r/109903 (owner: 10Lekshmi) [21:43:50] (03PS2) 10EBernhardson: Move destroy-form functionality in its own function, instead of binding cancel [extensions/Flow] - 10https://gerrit.wikimedia.org/r/109310 (owner: 10Matthias Mullie) [21:44:03] (03CR) 10EBernhardson: [C: 032] Move destroy-form functionality in its own function, instead of binding cancel [extensions/Flow] - 10https://gerrit.wikimedia.org/r/109310 (owner: 10Matthias Mullie) [21:44:13] (03Merged) 10jenkins-bot: Move destroy-form functionality in its own function, instead of binding cancel [extensions/Flow] - 10https://gerrit.wikimedia.org/r/109310 (owner: 10Matthias Mullie) [21:44:37] (03PS2) 10Matthias Mullie: Test permissions on multiple revisions in 1 object [extensions/Flow] - 10https://gerrit.wikimedia.org/r/112844 [21:44:48] (03CR) 10jenkins-bot: [V: 04-1] Test permissions on multiple revisions in 1 object [extensions/Flow] - 10https://gerrit.wikimedia.org/r/112844 (owner: 10Matthias Mullie) [21:45:22] (03CR) 10Nemo bis: "(And congratulations for your first patch, only now I notice! But I'm still curious about what above, would be useful to answer in commit " [extensions/ParserFunctions] - 10https://gerrit.wikimedia.org/r/87643 (owner: 10Lambdafu) [21:45:55] (03PS14) 10Ori.livneh: Remove namespace restriction for mention notifications [extensions/Echo] - 10https://gerrit.wikimedia.org/r/93508 (owner: 10Gerrit Patch Uploader) [21:46:02] (03CR) 10jenkins-bot: [V: 04-1] Remove namespace restriction for mention notifications [extensions/Echo] - 10https://gerrit.wikimedia.org/r/93508 (owner: 10Gerrit Patch Uploader) [21:46:10] (03CR) 10EBernhardson: [C: 032] Make error reporting more verbose. [extensions/Flow] - 10https://gerrit.wikimedia.org/r/107149 (owner: 10Matthias Mullie) [21:46:22] (03Merged) 10jenkins-bot: Make error reporting more verbose. [extensions/Flow] - 10https://gerrit.wikimedia.org/r/107149 (owner: 10Matthias Mullie) [21:46:42] (03CR) 10EBernhardson: [C: 032] Revisionable->Collection [extensions/Flow] - 10https://gerrit.wikimedia.org/r/113463 (owner: 10Matthias Mullie) [21:46:45] (03CR) 10jenkins-bot: [V: 04-1] Revisionable->Collection [extensions/Flow] - 10https://gerrit.wikimedia.org/r/113463 (owner: 10Matthias Mullie) [21:46:57] (03PS1) 10Kaldari: Removing the max-width for now per Erik [extensions/VectorBeta] (wmf/1.23wmf14) - 10https://gerrit.wikimedia.org/r/113467 [21:47:09] (03CR) 10Dzahn: [C: 032 V: 032] "yes, this is already gone, doesn't exist on new server on purpose" [wikimedia/bugzilla/modifications] - 10https://gerrit.wikimedia.org/r/113461 (owner: 10Aklapper) [21:47:21] (03CR) 10Kaldari: [C: 032] Removing the max-width for now per Erik [extensions/VectorBeta] (wmf/1.23wmf14) - 10https://gerrit.wikimedia.org/r/113467 (owner: 10Kaldari) [21:47:24] (03Merged) 10jenkins-bot: Removing the max-width for now per Erik [extensions/VectorBeta] (wmf/1.23wmf14) - 10https://gerrit.wikimedia.org/r/113467 (owner: 10Kaldari) [21:48:11] (03CR) 10Nemo bis: "No need to be sorry. :) Thanks and congratulations for your first patch." [core] - 10https://gerrit.wikimedia.org/r/112323 (owner: 10Kunalgrover05) [21:48:41] (03CR) 10EBernhardson: [C: 032] Return null instead of failing when requesting previous revision if there is none [extensions/Flow] - 10https://gerrit.wikimedia.org/r/113389 (owner: 10Matthias Mullie) [21:48:50] (03Merged) 10jenkins-bot: Return null instead of failing when requesting previous revision if there is none [extensions/Flow] - 10https://gerrit.wikimedia.org/r/113389 (owner: 10Matthias Mullie) [21:50:02] legoktm: yt? [21:50:02] (03CR) 10Nemo bis: "Needs rebase again. :( " [core] - 10https://gerrit.wikimedia.org/r/5130 (owner: 10Joancreus) [21:50:55] ori: somewhat [21:51:00] (03CR) 10Nemo bis: "Thanks again for the patch, needs rebase however. I see there are some pending questions for the reviewers?" [core] - 10https://gerrit.wikimedia.org/r/67173 (owner: 10Worden.lee) [21:51:16] I am attempting to re-install Tiger on a very old macbook [21:51:31] (03CR) 10Ori.livneh: [C: 04-1] "To understand why the test is failing, see DiscussionParser.php, lines 78-99, and think about its effect on 'end( $events )' in the test." [extensions/Echo] - 10https://gerrit.wikimedia.org/r/93508 (owner: 10Gerrit Patch Uploader) [21:51:36] ^ legoktm [21:51:40] will do [21:51:45] :) [21:51:50] (03PS2) 10EBernhardson: Revisionable->Collection [extensions/Flow] - 10https://gerrit.wikimedia.org/r/113463 (owner: 10Matthias Mullie) [21:52:11] (03CR) 10EBernhardson: [C: 032] Revisionable->Collection [extensions/Flow] - 10https://gerrit.wikimedia.org/r/113463 (owner: 10Matthias Mullie) [21:52:22] (03Merged) 10jenkins-bot: Revisionable->Collection [extensions/Flow] - 10https://gerrit.wikimedia.org/r/113463 (owner: 10Matthias Mullie) [21:53:37] (03CR) 10Nemo bis: "Thank you very much for your patch and welcome in MediaWiki/gerrit. If I understand correctly, the followup to Tyler's review is in the ot" [core] - 10https://gerrit.wikimedia.org/r/105158 (owner: 10Cargan) [21:54:00] (03PS2) 10Nemo bis: Add edit page permission check [core] - 10https://gerrit.wikimedia.org/r/105167 (owner: 10Cargan) [21:54:16] (03CR) 10Poke: "So there’s actual interest in it? I thought that was not the case, which is why I didn’t bother to rebase it yet." [core] - 10https://gerrit.wikimedia.org/r/61283 (owner: 10Poke) [21:57:42] (03CR) 10jenkins-bot: [V: 04-1] Add edit page permission check [core] - 10https://gerrit.wikimedia.org/r/105167 (owner: 10Cargan) [22:01:47] (03CR) 10Nemo bis: "Hi, thanks for your patch. You didn't reply to the comments above, is the other patch "More cleanup" meant to address them or what?" [extensions/SignupAPI] - 10https://gerrit.wikimedia.org/r/22861 (owner: 10Akshay) [22:02:45] (03PS1) 10Chad: Move decode results portion of findUpdates() to its own method [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/113468 [22:03:03] (03PS1) 10Chad: Make failure messages less spammy [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/113469 [22:04:07] (03PS7) 10Nemo bis: Insert configuration settings check [extensions/PubSubHubbub] - 10https://gerrit.wikimedia.org/r/109078 (owner: 10Alexander.lehmann) [22:04:26] (03CR) 10Nemo bis: "Thanks for your (first and) second patch ;) needs rebase though." [extensions/PubSubHubbub] - 10https://gerrit.wikimedia.org/r/109078 (owner: 10Alexander.lehmann) [22:09:35] (03CR) 10Nemo bis: "Thanks Bpetty for your patch and a belated welcome. Given that you -1'd this commit, should we assume saper's is where this will be follow" [extensions/Collection] - 10https://gerrit.wikimedia.org/r/87293 (owner: 10Bpetty) [22:10:13] (03CR) 10Umherirrender: "Please add a test like 'localtestiw:remotetestiw:' or 'localtestiw:remotetestiw:Page' to TitleTest.php" [core] - 10https://gerrit.wikimedia.org/r/113329 (owner: 10TTO) [22:10:28] ori: were you able to reproduce the failure locally? I'm still not able to :/ [22:11:03] (03CR) 10Nemo bis: "Congrats and thanks for your first merged patch around here. :)" [extensions/Annotator] - 10https://gerrit.wikimedia.org/r/110157 (owner: 10Chiborg) [22:11:31] legoktm: did you understand my point tho? [22:12:19] not really... [22:12:34] I'm not sure why anything in that section would affect using end() [22:12:47] (03PS2) 10Nemo bis: Remove permission info from JSON [extensions/Annotator] - 10https://gerrit.wikimedia.org/r/110378 (owner: 10Chiborg) [22:13:03] legoktm: because it's creating another event [22:13:10] legoktm: so the 'last event' becomes the secondary event [22:13:19] (03CR) 10Nemo bis: "Ib10140fc seems to indicate that this would only be merged later, hence I added a link to the commit message. Hope it's ok." [extensions/Annotator] - 10https://gerrit.wikimedia.org/r/110378 (owner: 10Chiborg) [22:14:14] right, but shouldn't it have already been doing that since it was a user talk page edit? [22:14:26] (03CR) 10Nemo bis: "Thanks for the patch. :)" [extensions/MathSearch] - 10https://gerrit.wikimedia.org/r/111468 (owner: 10Etienne) [22:16:35] (03PS3) 10Nemo bis: Initial import [extensions/PopupPages] - 10https://gerrit.wikimedia.org/r/51843 (owner: 10Hypergrove) [22:17:22] (03PS1) 10Kaldari: Update VectorBeta to remove max-width [core] (wmf/1.23wmf14) - 10https://gerrit.wikimedia.org/r/113472 [22:17:54] (03CR) 10Kaldari: [C: 032] Update VectorBeta to remove max-width [core] (wmf/1.23wmf14) - 10https://gerrit.wikimedia.org/r/113472 (owner: 10Kaldari) [22:21:15] (03CR) 10Mattflaschen: "Looks good, works locally." [extensions/WikimediaEvents] - 10https://gerrit.wikimedia.org/r/113263 (owner: 10Phuedx) [22:21:28] (03CR) 10Mattflaschen: [C: 032] Log article deletions using the PageDeletion schema [extensions/WikimediaEvents] - 10https://gerrit.wikimedia.org/r/113263 (owner: 10Phuedx) [22:21:31] (03Merged) 10jenkins-bot: Log article deletions using the PageDeletion schema [extensions/WikimediaEvents] - 10https://gerrit.wikimedia.org/r/113263 (owner: 10Phuedx) [22:21:33] (03Merged) 10jenkins-bot: Update VectorBeta to remove max-width [core] (wmf/1.23wmf14) - 10https://gerrit.wikimedia.org/r/113472 (owner: 10Kaldari) [22:24:26] ori: right, but shouldn't it have already been doing that since it was a user talk page edit? [22:28:20] (03CR) 10Mattflaschen: "I don't know anything about varnishncsa, but I definitely like having more readable format specifiers." [extensions/EventLogging] - 10https://gerrit.wikimedia.org/r/113457 (owner: 10Ori.livneh) [22:34:48] (03CR) 10Nemo bis: "Thanks for your patch, welcome. I understand that the current version of it is at https://gerrit.wikimedia.org/r/109016 , right? You proba" [extensions/Tabs] - 10https://gerrit.wikimedia.org/r/109000 (owner: 10Joeytje50) [22:37:35] (03CR) 10Nemo bis: "Hi, thanks for your patch and welcome. We usually don't +1 own patches, it makes it slightly harder to see from the changes list whether a" [test/mediawiki/extensions/examples] - 10https://gerrit.wikimedia.org/r/91834 (owner: 10Jshm) [22:37:49] (03CR) 10Bpetty: "The original purpose of this change is in order to provide a more adequate fix for this:" [core] - 10https://gerrit.wikimedia.org/r/87482 (owner: 10saper) [22:38:32] (03PS2) 10Nemo bis: Incremental update: zimdiff and zimpatch [openzim] - 10https://gerrit.wikimedia.org/r/82449 (owner: 10Kiran mathew koshy 1993) [22:38:58] (03PS1) 10Kaldari: Removing the max-width for now per Erik [extensions/VectorBeta] (wmf/1.23wmf13) - 10https://gerrit.wikimedia.org/r/113474 [22:39:31] (03CR) 10Kaldari: [C: 032] Removing the max-width for now per Erik [extensions/VectorBeta] (wmf/1.23wmf13) - 10https://gerrit.wikimedia.org/r/113474 (owner: 10Kaldari) [22:39:34] (03Merged) 10jenkins-bot: Removing the max-width for now per Erik [extensions/VectorBeta] (wmf/1.23wmf13) - 10https://gerrit.wikimedia.org/r/113474 (owner: 10Kaldari) [22:39:41] hurray thanks Erik [22:41:14] (03CR) 10Bpetty: "I marked patch set #2 as -1 since it forgot to declare the $wgServer global (so it shouldn't have actually worked). Patch set #3 fixes tha" [extensions/Collection] - 10https://gerrit.wikimedia.org/r/87293 (owner: 10Bpetty) [22:41:46] superm401: i had a really good idea for the title validation issue [22:42:10] ori, yep? [22:42:28] superm401: JSON schema allows for a 'title' attribute [22:42:42] superm401: on each page save, the *current* title should be saved as the title attribute [22:42:55] as part of the JSON object that is the page content [22:43:19] (03PS1) 10Kaldari: Update VectorBeta to remove max-width [core] (wmf/1.23wmf13) - 10https://gerrit.wikimedia.org/r/113476 [22:43:23] validation should be performed by resolving the revision id to a revision and comparing the title against the revision's JSON's title property [22:43:34] (03CR) 10Kaldari: [C: 032] Update VectorBeta to remove max-width [core] (wmf/1.23wmf13) - 10https://gerrit.wikimedia.org/r/113476 (owner: 10Kaldari) [22:43:49] ori, interesting. [22:44:43] Cool, so 'title' is a built-in proprety of schemas with JsonSchema. [22:44:56] superm401: yeah! how convenient is that? [22:45:13] (03PS15) 10Nemo bis: [WIP] Embedding Static Map to UploadWizard [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/107892 (owner: 10Inchikutty) [22:45:23] So, you would do it as a pre-save transform, right? [22:45:45] And then the nice thing is you can still sanity-check the input. [22:46:14] (03CR) 10Nemo bis: "Did some minor copyediting of the commit message. Thanks again for working on UploadWizard, we love it. ;-)" [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/107892 (owner: 10Inchikutty) [22:46:18] ^ ori [22:46:31] superm401: yep [22:47:38] (03Merged) 10jenkins-bot: Update VectorBeta to remove max-width [core] (wmf/1.23wmf13) - 10https://gerrit.wikimedia.org/r/113476 (owner: 10Kaldari) [22:49:19] (03CR) 10Nemo bis: "Hi, thanks for your patch. What do you mean "The job queue need to be synchronized"? We also have a delayed jobs feature in core now, you " [extensions/BlameMaps] - 10https://gerrit.wikimedia.org/r/25903 (owner: 10Michael Shavlovsky) [22:52:13] (03CR) 10EBernhardson: Move cutting of index data into index code (036 comments) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/112917 (owner: 10Matthias Mullie) [22:53:47] (03PS16) 10Inchikutty: Embedding Static Map to UploadWizard [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/107892 [23:45:28] https://graphite.wikimedia.org/render/?width=762&height=520&_salt=1392412036.017&from=-24days&target=mostDeviant%285%2CMediaWiki.FileBackendStore.*-global-swift-eqiad.count%29 :( [23:46:40] gwicke: maybe you can CR https://gerrit.wikimedia.org/r/#/c/113480/ too? [23:46:54] * AaronSchulz pinged Moritz already [23:48:17] AaronSchulz, looking [23:48:45] sounds like an ugly bug [23:48:53] I can confirm the mindless re-PUTs by polling after page view and seeing Last-Modified bump in swift [23:52:50] <^d> AaronSchulz: I dunno where the bot went. [23:52:54] <^d> I just merged that for you. [23:53:27] labs is having issues [23:54:49] (03PS20) 10Inchikutty: [WIP]Embedding leaflet maps based on OSM data to UploadWizard [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/109263 [23:55:00] (03PS1) 10Aaron Schulz: Update the DB output hash if outdated according to texvc [extensions/Math] - 10https://gerrit.wikimedia.org/r/113480 [23:55:02] (03PS2) 10Aaron Schulz: Update the DB output hash if outdated according to texvc [extensions/Math] - 10https://gerrit.wikimedia.org/r/113480 [23:55:04] (03CR) 10Matthias Mullie: Move cutting of index data into index code (036 comments) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/112917 (owner: 10Matthias Mullie) [23:55:07] (03PS6) 10Matthias Mullie: Move cutting of index data into index code [extensions/Flow] - 10https://gerrit.wikimedia.org/r/112917 [23:55:10] (03CR) 10jenkins-bot: [V: 04-1] Move cutting of index data into index code [extensions/Flow] - 10https://gerrit.wikimedia.org/r/112917 (owner: 10Matthias Mullie) [23:55:15] (03CR) 10Chad: [C: 032] Update the DB output hash if outdated according to texvc [extensions/Math] - 10https://gerrit.wikimedia.org/r/113480 (owner: 10Aaron Schulz) [23:55:17] (03Merged) 10jenkins-bot: Update the DB output hash if outdated according to texvc [extensions/Math] - 10https://gerrit.wikimedia.org/r/113480 (owner: 10Aaron Schulz) [23:56:34] (03PS1) 10Aaron Schulz: Update the DB output hash if outdated according to texvc [extensions/Math] (wmf/1.23wmf13) - 10https://gerrit.wikimedia.org/r/113481 [23:57:03] (03CR) 10Aaron Schulz: [C: 032] Update the DB output hash if outdated according to texvc [extensions/Math] (wmf/1.23wmf13) - 10https://gerrit.wikimedia.org/r/113481 (owner: 10Aaron Schulz) [23:57:10] (03Merged) 10jenkins-bot: Update the DB output hash if outdated according to texvc [extensions/Math] (wmf/1.23wmf13) - 10https://gerrit.wikimedia.org/r/113481 (owner: 10Aaron Schulz) [23:58:46] <^d> There's the bot. [23:58:53] (03PS4) 10Inchikutty: [WIP] UploadWizard:OSM embedding- Geocoding, reverse geocoding [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/112342 [23:59:20] (03PS7) 10Matthias Mullie: Move cutting of index data into index code [extensions/Flow] - 10https://gerrit.wikimedia.org/r/112917 [23:59:30] (03CR) 10jenkins-bot: [V: 04-1] Move cutting of index data into index code [extensions/Flow] - 10https://gerrit.wikimedia.org/r/112917 (owner: 10Matthias Mullie) [23:59:33] (03CR) 10TTO: "https://translatewiki.net/w/i.php?title=MediaWiki:Sp-translate-data-MagicWords/es&diff=5318953&oldid=5195499" [core] - 10https://gerrit.wikimedia.org/r/112852 (owner: 10TTO)