[00:01:13] (03Merged) 10jenkins-bot: Limit attempts to render the same thumbnail after failures [core] - 10https://gerrit.wikimedia.org/r/107419 (owner: 10Aaron Schulz) [00:02:16] (03CR) 10Dzahn: [C: 032] "BZ has been upgraded" [wikimedia/bugzilla/modifications] - 10https://gerrit.wikimedia.org/r/107423 (owner: 10Aklapper) [00:02:25] (03CR) 10Dzahn: [V: 032] "BZ has been upgraded" [wikimedia/bugzilla/modifications] - 10https://gerrit.wikimedia.org/r/107423 (owner: 10Aklapper) [00:03:25] (03PS3) 10Bsitu: Flow watchlist data tweaks [extensions/Flow] - 10https://gerrit.wikimedia.org/r/113042 [00:06:03] (03PS1) 10Dzahn: Revert "[4.4] Update custom search-links so Saved Reports are displayed" [wikimedia/bugzilla/modifications] - 10https://gerrit.wikimedia.org/r/113048 [00:07:48] (03CR) 10Dzahn: [C: 032 V: 032] "unfortunately even though this was tested it caused this:" [wikimedia/bugzilla/modifications] - 10https://gerrit.wikimedia.org/r/113048 (owner: 10Dzahn) [00:12:56] <^d> ebernhardson: Are you around the office place? [00:13:08] ^d: yea over in the flow corner [00:14:52] <^d> What corner is that? [00:18:55] gwicke: look at https://gerrit.wikimedia.org/r/#/c/107759/ first ;) [00:19:57] (03PS1) 10Aklapper: Fix brokenness in Gerrit change 107423. [wikimedia/bugzilla/modifications] - 10https://gerrit.wikimedia.org/r/113051 [00:21:06] (03PS2) 10Aklapper: [4.4] Update custom search-links so Saved Reports are displayed [wikimedia/bugzilla/modifications] - 10https://gerrit.wikimedia.org/r/113051 [00:22:54] <^d> ebernhardson: Anyway, I was trying to sketch out something resembling a data structure in Elastic for Flow stuff. [00:23:01] <^d> But realized I didn't know enough :) [00:23:31] (03CR) 10Dzahn: [C: 032 V: 032] [4.4] Update custom search-links so Saved Reports are displayed [wikimedia/bugzilla/modifications] - 10https://gerrit.wikimedia.org/r/113051 (owner: 10Aklapper) [00:23:32] ^d: https://gerrit.wikimedia.org/r/#/c/110657/ is fairly small, c'mon :) [00:24:10] AaronSchulz, the other one is shinier though ;) [00:24:36] (03CR) 10Chad: [C: 032] Added some lock()/unlock() support for SQLite using lock file emulation [core] - 10https://gerrit.wikimedia.org/r/110657 (owner: 10Aaron Schulz) [00:24:41] * AaronSchulz worries over https://gerrit.wikimedia.org/r/#/c/105138/ [00:24:48] ^d: can't that just be an extension? ;) [00:25:23] <^d> MSSQL? Not touching it. [00:25:26] <^d> I got yelled at last time. [00:25:33] * ^d is going to just ignore it [00:26:31] <^d> AaronSchulz: https://gerrit.wikimedia.org/r/#/c/112630/, https://gerrit.wikimedia.org/r/#/c/112641/ and https://gerrit.wikimedia.org/r/#/c/111535/ are all easy too :) [00:28:15] (03CR) 10Aaron Schulz: [C: 032] Remove undocumented and unused searchx parameter [core] - 10https://gerrit.wikimedia.org/r/112630 (owner: 10Chad) [00:28:26] (03CR) 10Hoo man: [C: 032] Return early when page id is less than 1 [core] - 10https://gerrit.wikimedia.org/r/112641 (owner: 10Chad) [00:30:22] (03PS1) 10Prtksxna: [WIP] Scratchpad [WIP] [extensions/Popups] - 10https://gerrit.wikimedia.org/r/113055 [00:32:02] (03CR) 10Dzahn: [C: 032 V: 032] Display useful links on Bugzilla front page [wikimedia/bugzilla/modifications] - 10https://gerrit.wikimedia.org/r/106650 (owner: 10Aklapper) [00:32:33] (03Merged) 10jenkins-bot: Added some lock()/unlock() support for SQLite using lock file emulation [core] - 10https://gerrit.wikimedia.org/r/110657 (owner: 10Aaron Schulz) [00:33:03] (03CR) 10Aaron Schulz: [C: 032] Actually make Parser::pstPass2() private [core] - 10https://gerrit.wikimedia.org/r/111535 (owner: 10Chad) [00:33:31] (03Merged) 10jenkins-bot: Remove undocumented and unused searchx parameter [core] - 10https://gerrit.wikimedia.org/r/112630 (owner: 10Chad) [00:33:33] (03Merged) 10jenkins-bot: Return early when page id is less than 1 [core] - 10https://gerrit.wikimedia.org/r/112641 (owner: 10Chad) [00:35:15] (03PS3) 10Aklapper: [4.4] Sync index frontpage with upstream changes [wikimedia/bugzilla/modifications] - 10https://gerrit.wikimedia.org/r/98013 [00:37:26] (03CR) 10Dzahn: [C: 032] [4.4] Sync index frontpage with upstream changes [wikimedia/bugzilla/modifications] - 10https://gerrit.wikimedia.org/r/98013 (owner: 10Aklapper) [00:37:34] (03CR) 10Dzahn: [V: 032] [4.4] Sync index frontpage with upstream changes [wikimedia/bugzilla/modifications] - 10https://gerrit.wikimedia.org/r/98013 (owner: 10Aklapper) [00:38:02] (03PS2) 10Aklapper: Display useful links on Bugzilla front page [wikimedia/bugzilla/modifications] - 10https://gerrit.wikimedia.org/r/106650 [00:40:00] (03Abandoned) 10Aaron Schulz: Hide bots by default on Special:ActiveUsers [core] - 10https://gerrit.wikimedia.org/r/111317 (owner: 10Aaron Schulz) [00:40:08] (03PS1) 10Matthias Mullie: Make tipsies disappear on cancel & tipsy-click [extensions/Flow] - 10https://gerrit.wikimedia.org/r/113057 [00:42:49] (03CR) 10Mattflaschen: [C: 04-1] "This works perfectly for the first VisualEditor save. However, if you save it again without a true page reload, it fails." (031 comment) [extensions/GettingStarted] - 10https://gerrit.wikimedia.org/r/112880 (owner: 10Phuedx) [00:42:55] (03CR) 10Dzahn: [C: 032 V: 032] Display useful links on Bugzilla front page [wikimedia/bugzilla/modifications] - 10https://gerrit.wikimedia.org/r/106650 (owner: 10Aklapper) [00:47:18] (03Merged) 10jenkins-bot: Actually make Parser::pstPass2() private [core] - 10https://gerrit.wikimedia.org/r/111535 (owner: 10Chad) [00:53:47] (03PS9) 10Matthias Mullie: Add *Collection classes [extensions/Flow] - 10https://gerrit.wikimedia.org/r/111366 [00:54:18] (03Abandoned) 10Matthias Mullie: Add path from Revision object to Revisionable object [extensions/Flow] - 10https://gerrit.wikimedia.org/r/112159 (owner: 10Matthias Mullie) [00:56:16] (03CR) 10Matthias Mullie: "Also; tests are at https://gerrit.wikimedia.org/r/#/c/112797/" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/111366 (owner: 10Matthias Mullie) [00:56:28] (03PS2) 10Prtksxna: Change border color [extensions/Popups] - 10https://gerrit.wikimedia.org/r/113055 [00:56:30] (03PS1) 10Prtksxna: Remove drop shadow [extensions/Popups] - 10https://gerrit.wikimedia.org/r/113059 [00:56:32] (03PS1) 10Prtksxna: Reduce font size for timestamp [extensions/Popups] - 10https://gerrit.wikimedia.org/r/113060 [00:57:01] (03PS4) 10Bsitu: Flow watchlist data tweaks [extensions/Flow] - 10https://gerrit.wikimedia.org/r/113042 [00:57:58] hey legoktm, you around? [01:01:11] (03PS1) 10Bsitu: revision change type name flow-edit-post should be edit-post [extensions/Flow] - 10https://gerrit.wikimedia.org/r/113062 [01:01:25] (03PS1) 10Prtksxna: [WIP] Truncate extract to 250 characters [WIP] [extensions/Popups] - 10https://gerrit.wikimedia.org/r/113063 [01:05:33] (03PS1) 10Xelgen: Fixing issue of multiple quality prefixes in summary As Tpt noticed, my previous patch would case multiple quality prefixes, if radiobuttons were clicked multiple time. This patch elimantes issue, in a way suggested by Tpt, with minor modification to RegE [extensions/ProofreadPage] - 10https://gerrit.wikimedia.org/r/113064 [01:17:48] (03PS1) 10Matthias Mullie: Remove Flow's mw.ui overrides [extensions/Flow] - 10https://gerrit.wikimedia.org/r/113066 [01:18:02] (03CR) 10Matthias Mullie: [C: 04-2] Remove Flow's mw.ui overrides [extensions/Flow] - 10https://gerrit.wikimedia.org/r/113066 (owner: 10Matthias Mullie) [01:19:36] (03CR) 10Matthias Mullie: [C: 031] "LGTM - merge after code freeze" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/113062 (owner: 10Bsitu) [01:19:50] (03PS6) 10AndyRussG: No undeletion of courses of deleted institutions [extensions/EducationProgram] - 10https://gerrit.wikimedia.org/r/110143 [01:19:56] (03CR) 10Xelgen: "Hi! And thanks for quick review." [extensions/ProofreadPage] - 10https://gerrit.wikimedia.org/r/112806 (owner: 10Xelgen) [01:21:11] (03CR) 10Xelgen: "Forgot the most important piece, URL of new change:" [extensions/ProofreadPage] - 10https://gerrit.wikimedia.org/r/112806 (owner: 10Xelgen) [01:23:58] (03PS7) 10AndyRussG: No undeletion of courses of deleted institutions [extensions/EducationProgram] - 10https://gerrit.wikimedia.org/r/110143 [01:26:40] (03CR) 10Parent5446: [C: 04-1] "So this kind of defeats the entire purpose of using Monolog. The purpose of Monolog is to provide an extensible logging framework, so ther" [core] - 10https://gerrit.wikimedia.org/r/112699 (owner: 10BryanDavis) [01:32:37] (03CR) 10Ori.livneh: Added password hashing API (031 comment) [core] - 10https://gerrit.wikimedia.org/r/77645 (owner: 10Parent5446) [01:36:13] (03PS2) 10Prtksxna: [WIP] Truncate extract to 250 characters [WIP] [extensions/Popups] - 10https://gerrit.wikimedia.org/r/113063 [01:39:54] (03CR) 10BryanDavis: "> Is there a reason you're not just using Monolog directly?" [core] - 10https://gerrit.wikimedia.org/r/112699 (owner: 10BryanDavis) [01:40:24] (03PS16) 10Parent5446: Added password hashing API [core] - 10https://gerrit.wikimedia.org/r/77645 [01:40:35] (03CR) 10Parent5446: "PS16: Rebase" [core] - 10https://gerrit.wikimedia.org/r/77645 (owner: 10Parent5446) [01:46:29] (03CR) 10Matthias Mullie: [C: 031] "LGTM - merge after code freeze" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/112794 (owner: 10Bsitu) [01:47:12] (03PS1) 10Bsitu: Associative array should not be accessed by numeric index [extensions/Flow] - 10https://gerrit.wikimedia.org/r/113070 [01:47:26] (03CR) 10Krinkle: "fixme: 1) These files should not be mixed in the src dir for oojs, but instead be in their own oojs-ui lib dir. See VisualEditor's reposit" [core] - 10https://gerrit.wikimedia.org/r/98887 (owner: 10Catrope) [01:47:47] (03PS17) 10Parent5446: Added password hashing API [core] - 10https://gerrit.wikimedia.org/r/77645 [01:47:57] (03CR) 10Adamw: [C: 032 V: 032] No undeletion of courses of deleted institutions [extensions/EducationProgram] - 10https://gerrit.wikimedia.org/r/110143 (owner: 10AndyRussG) [01:48:00] (03CR) 10Parent5446: Added password hashing API (031 comment) [core] - 10https://gerrit.wikimedia.org/r/77645 (owner: 10Parent5446) [01:48:19] (03CR) 10Krinkle: "fixme: 3) Why is there a .gitignore file?" [core] - 10https://gerrit.wikimedia.org/r/98887 (owner: 10Catrope) [01:48:23] (03CR) 10TTO: Implement listing for tracking categories (032 comments) [core] - 10https://gerrit.wikimedia.org/r/112323 (owner: 10Kunalgrover05) [01:50:05] (03CR) 10Matthias Mullie: [C: 04-1] "-1 because commit msg tells me not to review it yet ;)" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/109431 (owner: 10Bsitu) [01:51:12] (03CR) 10Matthias Mullie: [C: 031] "LGTM - merge after code freeze" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/113070 (owner: 10Bsitu) [01:52:08] (03CR) 10Matthias Mullie: [C: 031] "LGTM - merge after code freeze" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/112493 (owner: 10Bsitu) [01:53:44] (03PS1) 10Krinkle: oojs-ui: Fix up addition to core [core] - 10https://gerrit.wikimedia.org/r/113071 [01:55:00] (03PS2) 10Krinkle: oojs-ui: Fix up addition to core [core] - 10https://gerrit.wikimedia.org/r/113071 [01:55:27] (03CR) 10Krinkle: "Fixed in I01f99deb3967d731d7b." [core] - 10https://gerrit.wikimedia.org/r/98887 (owner: 10Catrope) [01:55:46] (03PS3) 10Krinkle: oojs-ui: Fix up addition to core [core] - 10https://gerrit.wikimedia.org/r/113071 [01:59:01] (03PS1) 10Prtksxna: [WIP] Change size of thumbnails in popup [WIP] [extensions/Popups] - 10https://gerrit.wikimedia.org/r/113072 [02:00:04] (03PS7) 10TTO: Add $wgLocalInterwikis to handle multiple local prefixes [core] - 10https://gerrit.wikimedia.org/r/110162 [02:00:37] (03CR) 10jenkins-bot: [V: 04-1] oojs-ui: Fix up addition to core [core] - 10https://gerrit.wikimedia.org/r/113071 (owner: 10Krinkle) [02:23:31] (03PS1) 10Aklapper: Fix UI regression in side bar introduced in bug 59889 [wikimedia/bugzilla/modifications] - 10https://gerrit.wikimedia.org/r/113073 [02:25:44] (03CR) 10Dzahn: "andre_, this ok to take now? maybe tomorrow though ..." [wikimedia/bugzilla/modifications] - 10https://gerrit.wikimedia.org/r/106883 (owner: 10Tinaj1234) [02:26:03] (03CR) 10Dzahn: "Tinaj1234, we are on 4.4 now" [wikimedia/bugzilla/modifications] - 10https://gerrit.wikimedia.org/r/106883 (owner: 10Tinaj1234) [02:28:28] (03CR) 10Dzahn: [C: 032 V: 032] [4.4] Apply custom changes to attachment.cgi [wikimedia/bugzilla/modifications] - 10https://gerrit.wikimedia.org/r/106713 (owner: 10Aklapper) [02:29:59] (03CR) 10AndyRussG: Prevent deletion of institutions with courses (031 comment) [extensions/EducationProgram] - 10https://gerrit.wikimedia.org/r/112866 (owner: 10AndyRussG) [02:31:31] (03PS3) 1001tonythomas: Added Link to Bugzilla Etiquette in footer [wikimedia/bugzilla/modifications] - 10https://gerrit.wikimedia.org/r/106757 [02:33:23] (03PS6) 10Aklapper: [4.4] Sync MoreBugUrl extension, add our custom patches [wikimedia/bugzilla/modifications] - 10https://gerrit.wikimedia.org/r/98035 [02:43:20] (03PS3) 10Spage: Move cutting of index data into index code [extensions/Flow] - 10https://gerrit.wikimedia.org/r/112917 (owner: 10Matthias Mullie) [02:53:38] (03CR) 10Aklapper: [C: 04-1] "https://www.bugzilla.org/ does not work (it's external and not under our control, and while we prefer HTTPS here not everybody else has it" [wikimedia/bugzilla/modifications] - 10https://gerrit.wikimedia.org/r/106757 (owner: 1001tonythomas) [03:23:19] (03CR) 10Spage: [C: 032] "I agree with everything Matthias wrote, but We HAVE to address the bug, so I'm merging this and will test on ee-flow and beta labs. Whatev" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/112750 (owner: 10Bsitu) [03:23:42] (03Merged) 10jenkins-bot: Loading new topics is broken [extensions/Flow] - 10https://gerrit.wikimedia.org/r/112750 (owner: 10Bsitu) [04:01:09] (03PS5) 10Pastakhov: add maximum number of allowed loops $wgPhpTagsMaxLoops [extensions/PhpTags] - 10https://gerrit.wikimedia.org/r/112680 [04:01:51] (03CR) 10Pastakhov: [C: 032] add maximum number of allowed loops $wgPhpTagsMaxLoops [extensions/PhpTags] - 10https://gerrit.wikimedia.org/r/112680 (owner: 10Pastakhov) [04:01:57] (03Merged) 10jenkins-bot: add maximum number of allowed loops $wgPhpTagsMaxLoops [extensions/PhpTags] - 10https://gerrit.wikimedia.org/r/112680 (owner: 10Pastakhov) [04:15:47] prtksxna: hey [05:15:52] How does one take i18n into considerations with regular expressions like these? /^[a-z0-9]+$/i [05:16:14] ohai legoktm [05:16:33] what are you trying to do? [05:17:00] I want to return null if the string has punctuations [05:17:30] I need the string to be alphanumeric [05:18:26] legoktm: Also, I wanted to ask you what you do! You've been very helpful the last few weeks but I have no idea what you do :P [05:18:27] What are you trying to do? [05:18:35] You answered how you're trying to do it. [05:18:40] What is it? [05:18:49] Gloria: Checking if a string is alphanumeric [05:18:52] prtksxna: Why? [05:18:59] What are you doing? [05:19:13] Gloria: I am trying to truncate an extract nicely [05:19:28] Gloria: So I want to clip at ~250 characters and then add an ellipses [05:19:37] In what language? :-) [05:19:41] Gloria: And I do no wish for the sentence to end in a puncutation :) [05:19:45] There are usually pre-built functions for doing that. [05:19:48] Gloria: All :\ [05:19:58] No, sorry. [05:19:58] Gloria: Could you point me in the right direction please? [05:20:01] I mean in what programming language. [05:20:06] Python, PHP, Perl? [05:20:11] JS I think. [05:20:12] Gloria: JavaScript [05:20:29] There's probably a jQuery module or two to do that already, surely. [05:20:43] There might even be one in MediaWiki core. [05:20:48] But I think you can truncate with CSS now? [05:20:54] prtksxna: I work with the E2 team on Flow / Echo and I also wrote MassMessage, and I work on cross-wiki extensions and some other stuff [05:20:55] legoktm: Is that right? [05:21:00] I have no clue. [05:21:06] legoktm: I thought he was asking what you do in meatspace. [05:21:14] oh [05:21:21] I go to school :P [05:21:26] Gloria: I have this right now http://pastie.org/8728596 [05:21:31] prtksxna: Have you looked at text-overflow in CSS? [05:21:41] * prtksxna looks at text-overflow [05:22:09] legoktm: I mean at WMF only :) [05:22:14] hey guys, any of you know how to add google doubleclick head script into mediawiki ? [05:22:56] !css [05:22:56] To change styles for your wiki, go to one of the MediaWiki:xxx.css wiki page (NOT a file) and put your custom styles there (sysop/admin rights required). MediaWiki:Common.css is for all skins and should be used for content styles. MediaWiki:Vector.css is for the Vector skin (default), etc. For more information, see !skins and [05:23:04] Gloria: Hmm, that works, but I need to clip at 250 characters and have no broken words [05:23:05] bierepedia: https://www.mediawiki.org/wiki/Extension:Google_AdSense_2 maybe? [05:23:17] You can probably edit "MediaWiki:Common.js" or install an extension, yeah. [05:23:21] bierepedia: ^ [05:23:24] Gloria: Could you please take a look at that pastie? [05:23:35] prtksxna: I looked. [05:23:45] prtksxna: why does it need to be limited to 250? I feel like using the regex is just going to run into a lot of i18n issues [05:23:55] going to look at adsense [05:23:57] prtksxna: When asking a question like the one you originally asked, include the pastebin link. :-) [05:24:05] (03PS5) 10BryanDavis: Convert scap-1 to python [tools/scap] - 10https://gerrit.wikimedia.org/r/112487 [05:24:05] It'll help people know exactly what you're talking about. [05:24:14] Gloria tried and failed with the common.js [05:24:18] legoktm: For the sake of the design :) Me too, that is why I asked here [05:24:21] bierepedia: What'd you try exactly? [05:24:33] Gloria: Alright, I'll remember to do that to begin with :) [05:24:37] :-) [05:24:49] prtksxna: Language::truncate does exactly what you need apparently [05:24:53] * Truncate a string to a specified length in bytes, appending an optional [05:24:53] * string (e.g. for ellipses) [05:25:13] Gloria adding the js lines into the common.js and refreshing with ctrl-r [05:25:26] bierepedia: What links did you add? [05:25:31] bierepedia: What lines did you add? [05:25:36] Sorry, typo. [05:25:54] legoktm: But this is PHP, no? [05:25:55] Gloria the one google gave me in doubleclick [05:26:05] prtksxna: PHP and JavaScript are somewhat synced in MediaWiki. [05:26:06] prtksxna: yeah :/ [05:26:12] without the [05:37:14] prtksxna: well, I don't think it'll take a few weeks :P [05:37:30] legoktm: To get committed, reviewed, merged, and deployed? [05:38:03] hum yeah I see a problem and I just fixed it but still don't work [05:38:08] deployment isn't necessary yet since prtksxna's extension isn't deployed [05:38:13] bierepedia: Where'd you put that in LocalSettings.php? [05:38:37] You can't just insert HTML into MediaWiki's output very easily from LocalSettings.php. [05:38:38] legoktm: Hmm, I should do it anyway [05:38:51] I think it'll take about a week, but I'm also an optimist [05:39:01] legoktm: If it isn't done till the time I'll need it, I'll put a place holder function in my code and replace it once its merged [05:39:05] Would that be acceptable? [05:39:08] Right. [05:39:08] yup [05:39:29] I use an extention to make that happen [05:39:47] Extracting technical information from you is like pulling teeth. :-) [05:39:56] It's snowing here, I'm going outside. [05:40:12] Gloria I'm using wikibanner [05:40:28] Gloria where you from... it is midnight here [05:42:47] It's past midnight here. [05:42:50] I'm in D.C. [05:43:01] 00:43 here [05:43:14] twinsies [05:43:16] And in Montréal we are tired of snow !!! [05:47:14] (03PS6) 10BryanDavis: Convert scap-1 to python [tools/scap] - 10https://gerrit.wikimedia.org/r/112487 [05:47:36] why is it so complicated to add banners in mediawiki ? [05:47:55] (03PS2) 10Prtksxna: Change size of thumbnails in popup [extensions/Popups] - 10https://gerrit.wikimedia.org/r/113072 [05:48:07] (03PS3) 10Prtksxna: [WIP] Truncate extract to 250 characters [WIP] [extensions/Popups] - 10https://gerrit.wikimedia.org/r/113063 [05:49:23] (03PS3) 10Santhosh: Avoid array_map to get useful debug information about LESS errors [core] - 10https://gerrit.wikimedia.org/r/106486 [05:50:48] (03PS22) 10Prtksxna: [DONT MERGE] Add Triangle/Pokey to the NavigationPopups [extensions/Popups] - 10https://gerrit.wikimedia.org/r/111773 [05:51:09] I'm going to seek an other ads management system that will do the same. [06:09:57] (03PS1) 10UltrasonicNXT: Revert my commit, and TWN's one - this message is actually in use! [extensions/MediaWikiChat] - 10https://gerrit.wikimedia.org/r/113089 [06:10:28] (03CR) 10UltrasonicNXT: [C: 032 V: 032] Revert my commit, and TWN's one - this message is actually in use! [extensions/MediaWikiChat] - 10https://gerrit.wikimedia.org/r/113089 (owner: 10UltrasonicNXT) [06:13:24] (03PS1) 10Prtksxna: Position timestamp div from the bottom [extensions/Popups] - 10https://gerrit.wikimedia.org/r/113090 [06:24:28] perhaps dumb question - how long do IP autoblocks last? I thought 24 hours? [06:25:05] Sounds about right. [06:25:20] Though the timer may reset if there's attempted activity during the 24 hours, maybe. [06:25:31] And the autoblocks can sometimes linger after an unblock. [06:25:58] Risker: $wgAutoblockExpiry = 86400; [06:26:02] That's the default, in seconds. [06:26:03] So one day. [06:26:07] thanks [06:26:33] (03PS2) 10Xelgen: Fixing issue of multiple quality prefixes in summary As Tpt noticed, my previous patch would case multiple quality prefixes, if radiobuttons were clicked multiple time. This patch elimantes issue, in a way suggested by Tpt, with minor modification to RegE [extensions/ProofreadPage] - 10https://gerrit.wikimedia.org/r/113064 [06:26:47] and it sticks to the IP regardless of the type of block on the user? [06:27:03] Well, the type of block determines whether it's an autoblock. [06:27:09] I can't remember what the default is. [06:27:19] (03PS3) 10Santhosh: Unroll array_map in ResourceLoaderFileModule::readStyleFiles [core] - 10https://gerrit.wikimedia.org/r/109956 (owner: 10Umherirrender) [06:27:23] It's one of those confusing checkboxes. [06:27:28] On the block form. [06:27:52] Gloria: account creation blocked, prevent user from editing talk page, autoblock any IP address used are all checked [06:28:08] (03Abandoned) 10Santhosh: Avoid array_map to get useful debug information about LESS errors [core] - 10https://gerrit.wikimedia.org/r/106486 (owner: 10Santhosh) [06:28:39] Risker: All right. [06:37:19] Thanks, Gloria [06:40:06] (03CR) 10Tpt: "Hi! Thanks a lot for the change and these long explanations." [extensions/ProofreadPage] - 10https://gerrit.wikimedia.org/r/112806 (owner: 10Xelgen) [07:16:34] (03CR) 10TTO: "recheck" [core] - 10https://gerrit.wikimedia.org/r/110162 (owner: 10TTO) [07:21:33] (03CR) 10Spage: "This fix seems to work on ee-flow and beta labs, but it won't backport to 1.23wmf13." [extensions/Flow] - 10https://gerrit.wikimedia.org/r/112750 (owner: 10Bsitu) [08:04:42] kart_: I had to change the function name because somehow, BetaFeatures looks for the function by name onGetPreferences only, in my local repo. So I had to swap the names. I will revert them in the next patch. [08:22:35] Niharika: no problem :) [08:45:03] (03PS3) 10Yurik: Search result as a category page parser function [core] - 10https://gerrit.wikimedia.org/r/109853 [08:46:12] Tim-away, when you have a sec, could you +2 https://gerrit.wikimedia.org/r/#/c/109853/ pls :) [08:47:21] (03CR) 10Yuvipanda: [C: 032 V: 032] Remove drop shadow [extensions/Popups] - 10https://gerrit.wikimedia.org/r/113059 (owner: 10Prtksxna) [08:47:41] (03CR) 10Yuvipanda: [C: 032 V: 032] Change border color [extensions/Popups] - 10https://gerrit.wikimedia.org/r/113055 (owner: 10Prtksxna) [08:48:23] (03CR) 10Yuvipanda: [C: 032 V: 032] Reduce font size for timestamp [extensions/Popups] - 10https://gerrit.wikimedia.org/r/113060 (owner: 10Prtksxna) [08:49:07] (03CR) 10Yuvipanda: [C: 032 V: 032] Change size of thumbnails in popup [extensions/Popups] - 10https://gerrit.wikimedia.org/r/113072 (owner: 10Prtksxna) [08:58:33] yurik: considering its about ~7:30p tim time, he probably won't be seeing that till tomorrow [09:20:32] (03PS1) 10Hashar: Create job operations-debs-git-fat-debian-glue [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/113093 [09:20:44] (03CR) 10Hashar: [C: 032] Create job operations-debs-git-fat-debian-glue [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/113093 (owner: 10Hashar) [09:21:05] (03Merged) 10jenkins-bot: Create job operations-debs-git-fat-debian-glue [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/113093 (owner: 10Hashar) [09:22:25] (03PS1) 10Hashar: Trigger operations-debs-git-fat-debian-glue [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/113094 [09:30:37] (03Abandoned) 10TTO: Fix double-bolding of bug field labels with Arial font [wikimedia/bugzilla/modifications] - 10https://gerrit.wikimedia.org/r/105921 (owner: 10TTO) [09:30:51] yurik i have made a course Introduction to Wikipedia API which consists of basic intro like parsing, basic querying . i was wondering what should be the title of the 2nd course as it has lesser knwn functions [09:31:29] would it be appropriiate if we name it Advanced [09:43:48] (03PS1) 10TTO: Update custom Component label to match 4.4 styling [wikimedia/bugzilla/modifications] - 10https://gerrit.wikimedia.org/r/113095 [09:53:59] (03CR) 10Thiemo Mättig (WMDE): [C: 031] "> These parameters are required per the function documentation." [core] - 10https://gerrit.wikimedia.org/r/111796 (owner: 10Thiemo Mättig (WMDE)) [09:58:07] (03PS4) 10TTO: Add link to Bugzilla etiquette page in footer [wikimedia/bugzilla/modifications] - 10https://gerrit.wikimedia.org/r/106757 (owner: 1001tonythomas) [10:01:41] (03PS4) 10TTO: Stop using prettifyIP for user links [core] - 10https://gerrit.wikimedia.org/r/92263 [10:11:19] (03CR) 10Odder: [C: 04-1] "Trailing tabs left behind…" [wikimedia/bugzilla/modifications] - 10https://gerrit.wikimedia.org/r/113073 (owner: 10Aklapper) [10:17:43] (03CR) 10TTO: "James: Any interest in fixing this patch? It's a really good idea, just needed a little bit of work." [core] - 10https://gerrit.wikimedia.org/r/83662 (owner: 10Jforrester) [10:34:43] (03CR) 10Grunny: Added password hashing API (034 comments) [core] - 10https://gerrit.wikimedia.org/r/77645 (owner: 10Parent5446) [10:41:46] !jenkins operations-debs-vips [10:41:46] https://integration.wikimedia.org/ci/job/operations-debs-vips [10:42:19] (03PS1) 10Hashar: Create job operations-debs-vips-debian-glue [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/113096 [10:43:13] (03PS1) 10Hashar: Trigger operations-debs-vips-debian-glue [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/113097 [10:43:23] (03CR) 10Hashar: [C: 032] Create job operations-debs-vips-debian-glue [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/113096 (owner: 10Hashar) [10:43:31] (03CR) 10Hashar: [C: 032] Trigger operations-debs-vips-debian-glue [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/113097 (owner: 10Hashar) [10:43:36] (03Merged) 10jenkins-bot: Trigger operations-debs-vips-debian-glue [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/113097 (owner: 10Hashar) [10:43:39] (03Merged) 10jenkins-bot: Create job operations-debs-vips-debian-glue [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/113096 (owner: 10Hashar) [11:17:23] (03CR) 10Phuedx: [C: 032] "This works well. Making this optimisation for individual tasks isn't a requirement at the moment. If it ever is a requirement, then it'll " [extensions/GettingStarted] - 10https://gerrit.wikimedia.org/r/112838 (owner: 10Mattflaschen) [11:17:30] (03Merged) 10jenkins-bot: Avoid unnecessary network call if there are no categories [extensions/GettingStarted] - 10https://gerrit.wikimedia.org/r/112838 (owner: 10Mattflaschen) [13:05:36] YuviPanda: Too many var statements. [13:05:47] YuviPanda: Too many I tell you! Its taking over! [13:06:08] I like that better than having two massive lines declaring 50 variables that I have no idea what they are used for because they are declared too far away from first use [13:06:52] YuviPanda: I know, but jshit [13:06:57] oops [13:07:03] more accurate, that one :) [13:07:06] :P [13:07:09] hahaha [13:07:11] I have that check turned off for the code I maintain [13:07:27] either way, I am not saying your patch should be like that too :P [13:07:29] YuviPanda: But this one is adhering to it, so I'll continue… [13:07:37] sure, fair enough :) [13:07:41] prtksxna: I only said *I* didn't like it :P [13:07:50] not you shouldn't do it [13:08:04] YuviPanda: We'll *mix things up* while doing the refactoring :) [13:08:10] :) [13:08:14] it'll need to be properly object oriented [13:08:18] and also have unit tests [13:08:25] it's a mess of functions now [13:08:34] YuviPanda: underscores in variable names, no spaces after brackets, Badass Lvl. 99 :D [13:08:42] YuviPanda: Yes, it fills me with sorrow [13:08:53] heh [13:10:10] YuviPanda: If you see the very first var in the code, I document where everything is, so, your argument is invalid. Gimme back my money! [13:10:30] (03PS1) 10Bartosz Dziewoński: mediawiki.jqueryMsg: Support {{GENDER:}} with empty first parameter [core] - 10https://gerrit.wikimedia.org/r/113112 [13:10:30] https://www.mediawiki.org/wiki/GENDER:Template: [13:10:46] prtksxna: I disagree, but am not arguing :P [13:11:15] YuviPanda: :P [13:11:25] YuviPanda: Any idea why I get logged out of my local MediaWiki so often? [13:11:50] prtksxna: it hates you, most likely [13:11:55] :'( [13:12:16] (03CR) 10Aklapper: [C: 031] "+1 (and thanks for working on this!)." [wikimedia/bugzilla/modifications] - 10https://gerrit.wikimedia.org/r/113095 (owner: 10TTO) [13:12:30] YuviPanda: did you test the code? the extension isn't loading for me [13:13:01] prtksxna: i did, it worked? [13:13:14] prtksxna: oh, damn. wait [13:13:25] YuviPanda: You added a new file? [13:13:29] prtksxna: get rid of the inclusion of ext.popups.timeago.js from Popups.php [13:13:30] should work [13:13:41] I had code in a separate file when testing and then also accidentlaly commited that too [13:13:47] YuviPanda: got it [13:14:11] YuviPanda: I don't think you committed it, just added it to RL [13:14:22] prtksxna: yeah, you need to get rid of it from RL [13:14:34] YuviPanda: yup, done [13:14:35] (03PS1) 10Bartosz Dziewoński: Add explicit {{GENDER:}} support to guidedtour-tour-firstedit-edit-page-title [extensions/GuidedTour] - 10https://gerrit.wikimedia.org/r/113113 [13:14:35] https://www.mediawiki.org/wiki/GENDER:Template: [13:14:38] should work [13:15:26] (03PS13) 10Prtksxna: Add time ago in words at the bottom of the popup [extensions/Popups] - 10https://gerrit.wikimedia.org/r/111977 [13:15:54] (03PS5) 10Addshore: Move QueryPage.php to specialpage folder [core] - 10https://gerrit.wikimedia.org/r/109587 [13:16:25] YuviPanda: pushed [13:16:27] (03CR) 10Addshore: "PS5 is a rebase" [core] - 10https://gerrit.wikimedia.org/r/109587 (owner: 10Addshore) [13:17:06] prtksxna: :) [13:17:13] (03Abandoned) 10Addshore: Remove unused uses in files touched by CI:I363b6bd9e [extensions/Flow] - 10https://gerrit.wikimedia.org/r/110391 (owner: 10Addshore) [13:17:20] YuviPanda: Now, who will *actually* review it? [13:17:36] prtksxna: I can't, because I submitted a patchset :P [13:18:16] YuviPanda: hm, i hope someone does :) [13:18:52] prtksxna: :) I might be slowly backing off over time - my commits to the app have slowed down a bit, and you seem to have things under control :D You just need to find a 'mergeing' partner [13:18:54] *merging [13:19:09] YuviPanda: Oh! Don't gooo! [13:19:14] :P [13:19:42] YuviPanda: I guess you spent more time than you thought on timeAgo? [13:19:59] prtksxna: nope. it was maybe 20mins. just spread out over 2 days :P [13:20:16] YuviPanda: lol [13:20:16] prtksxna: I wrote most of the code, and then went and played with LightTable for some time, then back to Android, and then back to this [13:20:28] YuviPanda: icy [13:47:25] 18 GB of DNA arrays it seems https://archive.org/details/wiki-arraywikibmegatechedu [13:55:22] (03CR) 10Hashar: [C: 04-1] Grep for jsduck warnings and exit nonzero for them (032 comments) [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/113033 (owner: 10MarkTraceur) [14:00:07] (03CR) 10Hashar: Grep for jsduck warnings and exit nonzero for them (031 comment) [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/113033 (owner: 10MarkTraceur) [14:02:51] (03CR) 10Aklapper: "Odder: Blame upstream." [wikimedia/bugzilla/modifications] - 10https://gerrit.wikimedia.org/r/113073 (owner: 10Aklapper) [14:33:59] (03PS1) 10Norayr: now captcha.py can generate captchas with unicode characters. I have tested it on several mediawikis, where I use Armenian captchas cause bots usually are unable to recognize them. I don't know python, if you need me to change something, let me know. [extensions/ConfirmEdit] - 10https://gerrit.wikimedia.org/r/113122 [15:22:50] (03PS2) 10Bartosz Dziewoński: mediawiki.jqueryMsg: Support {{GENDER:}} with empty first parameter [core] - 10https://gerrit.wikimedia.org/r/113112 [15:22:51] https://www.mediawiki.org/wiki/GENDER:Template: [15:29:45] (03CR) 10Norayr: "when I say "bots" I meant human bots. They were able to read Latin letter captchas. Whereas we had only Armenian language mediawikis, so w" [extensions/ConfirmEdit] - 10https://gerrit.wikimedia.org/r/113122 (owner: 10Norayr) [15:35:15] (03PS2) 10Phuedx: Delay showing the task toolbar after VisualEditor edit [extensions/GettingStarted] - 10https://gerrit.wikimedia.org/r/112880 [15:49:51] (03PS1) 10Zfilipin: WIP Moved tests from browsertests repository [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/113131 [16:00:16] (03CR) 10Phuedx: "This works well. I can't speak with authority about whether or not this is hacky in the context of mediawiki.jqueryMsg, but I think the ch" (034 comments) [core] - 10https://gerrit.wikimedia.org/r/113112 (owner: 10Bartosz Dziewoński) [16:00:37] ^ sorry about that being late MatmaRex, my computer's playing up atm [16:00:39] brb [16:00:41] gonna restart [16:04:50] (03PS5) 10Addshore: Remove unused stuff from tests [core] - 10https://gerrit.wikimedia.org/r/109470 [16:05:34] (03PS2) 10Zfilipin: WIP Moved tests from browsertests repository [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/113131 [16:13:26] (03PS1) 10Matthias Mullie: Loading new topics is broken [extensions/Flow] (wmf/1.23wmf13) - 10https://gerrit.wikimedia.org/r/113139 [16:13:49] (03CR) 10Matthias Mullie: [C: 032] Loading new topics is broken [extensions/Flow] (wmf/1.23wmf13) - 10https://gerrit.wikimedia.org/r/113139 (owner: 10Matthias Mullie) [16:13:59] (03Merged) 10jenkins-bot: Loading new topics is broken [extensions/Flow] (wmf/1.23wmf13) - 10https://gerrit.wikimedia.org/r/113139 (owner: 10Matthias Mullie) [16:19:26] (03PS3) 10Bartosz Dziewoński: mediawiki.jqueryMsg: Support {{GENDER:}} with empty first parameter [core] - 10https://gerrit.wikimedia.org/r/113112 [16:19:26] https://www.mediawiki.org/wiki/GENDER:Template: [16:19:27] (03CR) 10Bartosz Dziewoński: [C: 032] Vector: Remove misleading comment [core] - 10https://gerrit.wikimedia.org/r/112693 (owner: 10Bartosz Dziewoński) [16:19:30] (03CR) 10Bartosz Dziewoński: [C: 032] Vector: Consistently use lowercase in #rrggbb colors [core] - 10https://gerrit.wikimedia.org/r/112694 (owner: 10Bartosz Dziewoński) [16:23:09] (03CR) 10Ocean behind ears: "Might this have caused bug # 61318" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/111123 (owner: 10EBernhardson) [16:24:27] (03Merged) 10jenkins-bot: Vector: Remove misleading comment [core] - 10https://gerrit.wikimedia.org/r/112693 (owner: 10Bartosz Dziewoński) [16:24:29] (03Merged) 10jenkins-bot: Vector: Consistently use lowercase in #rrggbb colors [core] - 10https://gerrit.wikimedia.org/r/112694 (owner: 10Bartosz Dziewoński) [16:25:14] (03CR) 10Ocean behind ears: "My bad, didn't notice that this was for an extension. Disregard above." [extensions/Flow] - 10https://gerrit.wikimedia.org/r/111123 (owner: 10EBernhardson) [16:28:04] (03CR) 10Phuedx: [C: 031] mediawiki.jqueryMsg: Support {{GENDER:}} with empty first parameter [core] - 10https://gerrit.wikimedia.org/r/113112 (owner: 10Bartosz Dziewoński) [16:28:04] https://www.mediawiki.org/wiki/GENDER:Template: [16:32:26] <^d> @linkie-off [16:32:26] Permission denied [16:32:42] <^d> Can someone turn that crap off in here too? [16:42:24] @linkie-off [16:42:24] Permission denied [16:42:28] heh [16:42:30] @trusted [16:42:30] I trust: petan|wk.*wikimedia/Petrb (2admin), .*@mediawiki/Krinkle (2admin), .*@wikimedia/Krinkle (2admin), .*@wikimedia/.* (2trusted), .*@wikipedia/.* (2trusted), .*@mediawiki/..* (2trusted), .*@wikipedia/MZMcBride (2admin), .*@wikinews/bawolff (2admin), .*@wikipedia/matma-rex (2admin), .*@wikimedia/qchris (2trusted), [16:42:56] ^d: apparently Krinkle|detached, MatmaRex and Mz can [16:43:15] <^d> We should trust more in here? [16:43:23] <^d> I think we do in #mediawiki [16:43:46] <^d> Oh, admin. [16:43:53] <^d> Not trusted. [16:44:31] ^d: yeah [16:44:36] hmm? [16:44:41] <^d> @linkie-off [16:44:41] Permission denied [16:44:56] i enjoy linkie :( [16:45:06] <^d> {{just because I write about a template doesn't mean I'm talking about a template on mw.org}} [16:45:06] https://www.mediawiki.org/wiki/Template:just_because_I_write_about_a_template_doesn't_mean_I'm_talking_about_a_template_on_mw.org [16:45:09] it would be better if it didn't suck tho [16:45:12] @linkie-off [16:45:12] Links will not be automatically translated in this channel now [16:46:01] (03CR) 10Manybubbles: [C: 032] Fixed typo in file name [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/113108 (owner: 10Zfilipin) [16:46:07] (03Merged) 10jenkins-bot: Fixed typo in file name [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/113108 (owner: 10Zfilipin) [16:47:27] (03CR) 10Manybubbles: [C: 032] Begin indexing namespace text forms [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/112914 (owner: 10Chad) [16:47:33] (03Merged) 10jenkins-bot: Begin indexing namespace text forms [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/112914 (owner: 10Chad) [17:00:20] (03CR) 10Chad: "Hope we don't change the core method, will amend if so ;-)" [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/112914 (owner: 10Chad) [17:00:47] (03CR) 10Rtdwivedi: "What else needs to be done to merge this change?" [extensions/ProofreadPage] - 10https://gerrit.wikimedia.org/r/106524 (owner: 10Tpt) [17:16:43] (03CR) 10Rtdwivedi: [C: 031] Introduce Context [extensions/ProofreadPage] - 10https://gerrit.wikimedia.org/r/108678 (owner: 10Tpt) [17:17:21] (03PS4) 10Etienne: WIP: phpunit test for XQuery generation [extensions/MathSearch] - 10https://gerrit.wikimedia.org/r/111468 [17:17:51] (03CR) 10Matthias Mullie: Make sure permission checks also check against current revisions (031 comment) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/112160 (owner: 10Matthias Mullie) [17:22:00] (03Abandoned) 10Reedy: Revert "Add sequence support for externallinks table" [core] - 10https://gerrit.wikimedia.org/r/107415 (owner: 10Reedy) [17:22:26] (03PS1) 10Reedy: Remove 107415 [tools/release] - 10https://gerrit.wikimedia.org/r/113143 [17:23:12] (03CR) 10Aaron Schulz: [C: 032 V: 032] Format protection_expiry timestamp in ISO format for API results [extensions/FlaggedRevs] - 10https://gerrit.wikimedia.org/r/76460 (owner: 10TTO) [17:23:32] (03CR) 10Reedy: [C: 032] Remove 107415 [tools/release] - 10https://gerrit.wikimedia.org/r/113143 (owner: 10Reedy) [17:23:34] (03Merged) 10jenkins-bot: Remove 107415 [tools/release] - 10https://gerrit.wikimedia.org/r/113143 (owner: 10Reedy) [17:25:04] (03PS4) 10Swalling: mediawiki.jqueryMsg: Support {{GENDER:}} with empty first parameter [core] - 10https://gerrit.wikimedia.org/r/113112 (owner: 10Bartosz Dziewoński) [17:28:17] xylophone: sorry I do not know enough to help [17:28:28] xylophone: you could try posting to wikitech-l [17:28:29] !lists [17:28:35] ok [17:28:41] sumanah [17:28:54] xylophone: https://lists.wikimedia.org/mailman/listinfo/wikitech-l [17:30:51] sumanah could you tell me how to install an extension to the wikimedia core [17:31:01] xylophone: which extension? [17:31:02] (03PS1) 10J-squared: Initial notification for when another user adds you to a course [extensions/EducationProgram] - 10https://gerrit.wikimedia.org/r/113145 [17:31:08] (03CR) 10MZMcBride: "Possibly related: bug 5309" [extensions/ConfirmEdit] - 10https://gerrit.wikimedia.org/r/113122 (owner: 10Norayr) [17:31:11] Multimedia Viewer [17:31:24] I was trying to solve a bug [17:31:49] no bug solving! interferes with work. [17:34:49] xylophone: Amgine is joking. [17:35:01] xylophone: ok. does that extension have instructions about how to install it? [17:35:23] xylophone: Let's look at https://www.mediawiki.org/wiki/Extension:MultimediaViewer [17:35:35] ok [17:35:45] xylophone: have you already followed the Installation instructions there? [17:36:05] sumanah: MultimediaViewer has a vagrant role [17:36:13] probably the easier way [17:36:20] ok! [17:36:26] tgr: point to the instructions? [17:36:31] (03PS5) 10Etienne: WIP: phpunit test for XQuery generation [extensions/MathSearch] - 10https://gerrit.wikimedia.org/r/111468 [17:36:37] actually I am using the vagrant vm model. so therefore I am a bit confused [17:36:51] sumanah: https://www.mediawiki.org/wiki/MediaWiki-Vagrant [17:36:59] tgr: xylophone asked "should I create a new ssh key for the vagrant vm, or will my local computer suffice." - got any ideas? [17:37:11] then vagrant enable-role multimediaviewer, vagrant provision [17:37:19] what os? [17:37:25] linux [17:37:37] ubuntu [17:37:40] then just use vagrant ssh instead of plain ssh [17:37:54] vagrant has a default ssh key [17:38:00] i have done that and have access to the vagrant shell [17:38:17] i don't understand the question then [17:38:35] I have now done the ssh part. [17:39:05] I just need some way to modify the extension code, and test it, so that I could solve the bug [17:39:10] https://bugzilla.wikimedia.org/show_bug.cgi?id=57308 [17:39:10] tgr: thank you, I have now updated https://www.mediawiki.org/wiki/Extension:MultimediaViewer#Installation [17:39:33] ah ok, sorry, missed the beginning of the conversation [17:39:49] you will need your own ssh key to submit code to gerrit [17:40:01] ok I have done that [17:40:04] as long as you just modify code and test locally, you don't need it [17:40:15] have you already set up your Gerrit account xylophone? https://www.mediawiki.org/wiki/Gerrit [17:40:22] yes i have done that [17:40:30] and have uploaded my ssh public key [17:42:16] I guess tgr you have filed the bug report? [17:42:24] https://bugzilla.wikimedia.org/show_bug.cgi?id=57308 [17:42:37] tgr: btw is there a master list of roles available for our vagrant stuff? [17:43:01] I just added multimedia to https://www.mediawiki.org/wiki/MediaWiki-Vagrant/Roles [17:43:25] does DiffViewHeader hook support 4th parameter(&$out) on 1.22? [17:44:54] (03CR) 10J-squared: "Here's an initial version of the notification when another user adds you to a course. Some questions/points of discussion (see inline comm" (032 comments) [extensions/EducationProgram] - 10https://gerrit.wikimedia.org/r/113145 (owner: 10J-squared) [17:47:16] (03PS4) 10Krinkle: oojs-ui: Fix up addition to core [core] - 10https://gerrit.wikimedia.org/r/113071 [17:47:38] sumanah: vagrant list-roles [17:47:46] thanks [17:48:04] you can check the source file comments for info on what is what [17:48:08] (03CR) 10Ocean behind ears: "Causes bug 61318" [core] - 10https://gerrit.wikimedia.org/r/42278 (owner: 10Umherirrender) [17:48:14] its in puppet/manifest/roles oorc [17:48:32] (03PS2) 10Nemo bis: now captcha.py can generate captchas with unicode characters. [extensions/ConfirmEdit] - 10https://gerrit.wikimedia.org/r/113122 (owner: 10Norayr) [17:48:45] (03CR) 10Jforrester: [C: 032] oojs-ui: Fix up addition to core [core] - 10https://gerrit.wikimedia.org/r/113071 (owner: 10Krinkle) [17:49:34] (03CR) 10Jforrester: [C: 04-1] oojs-ui: Fix up addition to core (031 comment) [core] - 10https://gerrit.wikimedia.org/r/113071 (owner: 10Krinkle) [17:49:56] (03CR) 10Krinkle: [C: 031] "Would like double check from Reedy or Catrope." [core] - 10https://gerrit.wikimedia.org/r/109956 (owner: 10Umherirrender) [17:52:32] (03PS1) 10IAlex: Explicitely return null from WikiPage::newFromID() [core] - 10https://gerrit.wikimedia.org/r/113149 [17:53:02] (03CR) 10Hoo man: [C: 032] Explicitely return null from WikiPage::newFromID() [core] - 10https://gerrit.wikimedia.org/r/113149 (owner: 10IAlex) [17:53:16] (03PS4) 10Krinkle: mediawiki.feedback: Add jsduck documentation [core] - 10https://gerrit.wikimedia.org/r/111624 (owner: 10MarkTraceur) [17:53:19] (03CR) 10Nemo bis: "Hm, Nikerabbit has some experience creating non-ASCII captchas (), added to revie" [extensions/ConfirmEdit] - 10https://gerrit.wikimedia.org/r/113122 (owner: 10Norayr) [17:53:44] (03CR) 10Krinkle: mediawiki.feedback: Add jsduck documentation (031 comment) [core] - 10https://gerrit.wikimedia.org/r/111624 (owner: 10MarkTraceur) [17:54:04] (03CR) 10Krinkle: [C: 032] "Linked "launch()" reference." [core] - 10https://gerrit.wikimedia.org/r/111624 (owner: 10MarkTraceur) [17:57:20] (03CR) 10Ragesoss: "Nice work J-squared! The basic functionality works for the first case I tested." [extensions/EducationProgram] - 10https://gerrit.wikimedia.org/r/113145 (owner: 10J-squared) [17:57:37] (03Merged) 10jenkins-bot: Explicitely return null from WikiPage::newFromID() [core] - 10https://gerrit.wikimedia.org/r/113149 (owner: 10IAlex) [17:58:25] (03Merged) 10jenkins-bot: mediawiki.feedback: Add jsduck documentation [core] - 10https://gerrit.wikimedia.org/r/111624 (owner: 10MarkTraceur) [17:58:29] (03PS5) 10Krinkle: oojs-ui: Fix up addition to core [core] - 10https://gerrit.wikimedia.org/r/113071 [18:01:04] (03Abandoned) 10Matthias Mullie: Don't trigger code onUserSaveSettings when run as maintenance script [extensions/Echo] - 10https://gerrit.wikimedia.org/r/83202 (owner: 10Matthias Mullie) [18:01:49] (03PS16) 1001tonythomas: Removed 'Remember my login' preference [core] - 10https://gerrit.wikimedia.org/r/94614 [18:02:48] (03CR) 10jenkins-bot: [V: 04-1] Removed 'Remember my login' preference [core] - 10https://gerrit.wikimedia.org/r/94614 (owner: 1001tonythomas) [18:03:54] (03CR) 10Norayr: "I can point you to the live mediawiki which works with this patch if you need." [extensions/ConfirmEdit] - 10https://gerrit.wikimedia.org/r/113122 (owner: 10Norayr) [18:05:17] (03PS6) 10Krinkle: oojs-ui: Fix up addition to core [core] - 10https://gerrit.wikimedia.org/r/113071 [18:10:25] (03CR) 10Anomie: Add $wgLocalInterwikis to handle multiple local prefixes (031 comment) [core] - 10https://gerrit.wikimedia.org/r/110162 (owner: 10TTO) [18:13:30] (03PS1) 10EBernhardson: Consolidate formatters into Flow\\Formatter namespace [extensions/Flow] - 10https://gerrit.wikimedia.org/r/113154 [18:13:33] (03PS1) 10EBernhardson: Track revision length within recent changes [extensions/Flow] - 10https://gerrit.wikimedia.org/r/113155 [18:13:36] (03PS1) 10EBernhardson: Catch and log exceptions with RC formatting [extensions/Flow] - 10https://gerrit.wikimedia.org/r/113156 [18:13:39] (03PS1) 10EBernhardson: Consolidate history i18n parameters into AbstractFormatter [extensions/Flow] - 10https://gerrit.wikimedia.org/r/113157 [18:15:09] (03CR) 10Bartosz Dziewoński: [V: 032] "Test failures are unrelated, let's just merge this." [extensions/ParserFunctions] - 10https://gerrit.wikimedia.org/r/112029 (owner: 10Anomie) [18:15:47] (03PS1) 10Aaron Schulz: Tweaked generated paths for ExternalStoreMwstore [core] - 10https://gerrit.wikimedia.org/r/113158 [18:15:56] (03PS17) 1001tonythomas: Removed 'Remember my login' preference [core] - 10https://gerrit.wikimedia.org/r/94614 [18:16:56] (03CR) 10Jforrester: [C: 032] oojs-ui: Fix up addition to core [core] - 10https://gerrit.wikimedia.org/r/113071 (owner: 10Krinkle) [18:17:38] (03CR) 10Krinkle: oojs-ui: Fix up addition to core (031 comment) [core] - 10https://gerrit.wikimedia.org/r/113071 (owner: 10Krinkle) [18:18:44] (03CR) 10Catrope: [C: 032] oojs-ui: Fix up addition to core [core] - 10https://gerrit.wikimedia.org/r/113071 (owner: 10Krinkle) [18:19:07] is the mobileFrontend repo given as extension-mobilefront end in github ? [18:19:38] https://github.com/wikimedia/mediawiki-extensions-MobileFrontend [18:21:18] (03Merged) 10jenkins-bot: oojs-ui: Fix up addition to core [core] - 10https://gerrit.wikimedia.org/r/113071 (owner: 10Krinkle) [18:21:29] (03CR) 10Matthias Mullie: Consolidate formatters into Flow\\Formatter namespace (033 comments) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/113154 (owner: 10EBernhardson) [18:21:35] (03PS1) 10Bartosz Dziewoński: mediawiki.jqueryMsg: Deprecate window.gM [core] - 10https://gerrit.wikimedia.org/r/113159 [18:24:37] (03PS11) 10Daniel Kinzler: Introducing TitleValue [core] - 10https://gerrit.wikimedia.org/r/106517 [18:25:27] (03CR) 10jenkins-bot: [V: 04-1] Introducing TitleValue [core] - 10https://gerrit.wikimedia.org/r/106517 (owner: 10Daniel Kinzler) [18:26:40] (03CR) 10Matthias Mullie: "This change is equivalent to https://gerrit.wikimedia.org/r/#/c/112169/" (031 comment) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/113155 (owner: 10EBernhardson) [18:28:56] grr@jenkins [18:32:29] (03PS12) 10Daniel Kinzler: Introducing TitleValue [core] - 10https://gerrit.wikimedia.org/r/106517 [18:33:21] (03CR) 10Daniel Kinzler: "PS12 is a rebase. It may have reverted some changes to Title::splitAndSecure, because the respective code was moved to MediaWikiTitleCodec" [core] - 10https://gerrit.wikimedia.org/r/106517 (owner: 10Daniel Kinzler) [18:34:06] (03CR) 10jenkins-bot: [V: 04-1] Introducing TitleValue [core] - 10https://gerrit.wikimedia.org/r/106517 (owner: 10Daniel Kinzler) [18:35:25] (03CR) 10Aaron Schulz: [C: 031] "Waiting on break statement cleanup patch (and whatever else was going in that)" [core] - 10https://gerrit.wikimedia.org/r/105443 (owner: 10Umherirrender) [18:36:08] wow, i made the sample test fail :P [18:38:16] (03CR) 10Bartosz Dziewoński: "This probably makes bug 36138 a WONTFIX." [core] - 10https://gerrit.wikimedia.org/r/111422 (owner: 10Ori.livneh) [18:40:19] (03PS13) 10Daniel Kinzler: Introducing TitleValue [core] - 10https://gerrit.wikimedia.org/r/106517 [18:40:59] (03CR) 10Bartosz Dziewoński: "I have a feeling this commit does too many things." [core] - 10https://gerrit.wikimedia.org/r/111957 (owner: 10Krinkle) [18:43:47] (03CR) 10jenkins-bot: [V: 04-1] Introducing TitleValue [core] - 10https://gerrit.wikimedia.org/r/106517 (owner: 10Daniel Kinzler) [18:46:38] anomie: did you see https://en.wikipedia.org/wiki/User_talk:AnomieBOT#CHUUClerk:_Cannot_find_info_for_username_in_WP:CHUU.23None_.28SUL_request.29_.E2.86.92_User:bonu_-_Fixed ? [18:48:08] jackmcbarn: I should probably look back at that one of these days. The evening after that message I had a bunch of stuff happen that took my attention away from stuff for a few weeks. [18:49:01] kk, just wanted to make sure you saw it before it got archived [18:53:00] anomie: i updated the TitleValue patch with a partially changed design. my bit a little more to your liking. [18:53:12] seems like i broke some parser tests now... [18:53:17] manybubbles: --^^ [18:53:41] DanielK_WMDE: cool. parsers tests can be fixed:) [18:53:43] DanielK_WMDE: Wont be able to make it to the meeting tomorrow, probably... [18:53:50] RfC review thing, I mean [18:55:05] DanielK_WMDE: I'm wondering how many people can actually come [18:55:09] me and anomie [18:55:20] and you, but aren't you going to leave like right after that? [18:55:27] yea... maybe try and convince tim? it's midnight for him, not *too* terrible [18:55:42] ^d: https://gerrit.wikimedia.org/r/#/c/113158/1 easy :) [18:55:44] * anomie knows nothing about any meeting [18:55:59] anomie: it was on wikitech-l [18:56:04] rfc review re TitleValue [18:56:09] [Wikitech-l] RFC discussion Friday 14 Feb: TitleValue [18:56:24] The discussion will be in #wikimedia-office at 13:00 UTC on Friday the 14th [18:56:33] anomie: RFC meeting about TitleValue on IRC tomorrow, at 2pm my time - that's 8am eastern, i think. [18:56:48] hey sumanah!" [18:56:53] Thanks sumanah [18:56:59] can you try to convince tim? i'm off in a minute... [18:57:11] Hmm. 8am, I may have something else going on at that time. [18:57:12] DanielK_WMDE: I'm not gonna try to persuade the parent of 2 young children, no [18:57:33] (03CR) 10Bartosz Dziewoński: mediawiki.notification: Return the Notification object from .notify calls (031 comment) [core] - 10https://gerrit.wikimedia.org/r/110667 (owner: 10Bartosz Dziewoński) [18:57:44] sumanah: well... i might :) [18:57:52] (03PS5) 10Bartosz Dziewoński: mediawiki.notification: Return the Notification object from .notify calls [core] - 10https://gerrit.wikimedia.org/r/110667 [18:57:58] (03CR) 10Chad: [C: 032] Tweaked generated paths for ExternalStoreMwstore [core] - 10https://gerrit.wikimedia.org/r/113158 (owner: 10Aaron Schulz) [18:58:08] but i know what you mean. [18:58:51] anyway, i think tim will just tell me to bugger off if he doesn't want to attend. i just want to make sure he has it on his radar. [18:59:19] but he's amazingly on top of all the wikitech stuff, usually. [18:59:41] anyway. off for now... [19:02:06] (03Merged) 10jenkins-bot: Tweaked generated paths for ExternalStoreMwstore [core] - 10https://gerrit.wikimedia.org/r/113158 (owner: 10Aaron Schulz) [19:02:17] see ya DanielK_WMDE [19:02:21] anomie: you are welcome! [19:02:56] (03CR) 10Hoo man: [C: 04-1] now captcha.py can generate captchas with unicode characters. (031 comment) [extensions/ConfirmEdit] - 10https://gerrit.wikimedia.org/r/113122 (owner: 10Norayr) [19:08:23] ^^ would make for fun captcha's :) [19:10:18] anomie, if you're around (or someone else happens to know it) I'd like to have a template to subst: to insert characters by codepoint. If I make that in Lua, what should it output? a Lua string of UTF-8 bytes? [19:10:37] (03CR) 10Anomie: now captcha.py can generate captchas with unicode characters. (032 comments) [extensions/ConfirmEdit] - 10https://gerrit.wikimedia.org/r/113122 (owner: 10Norayr) [19:10:51] (it's probably useful only to me, but I can live with that) [19:11:48] ebernhardson: :) i18n for captchas is a good idea :D [19:12:03] * YuviPanda gives ebernhardson klingon captchas [19:12:06] MartijnH: Yes, a Lua string of UTF-8 bytes [19:12:20] thanks, that should be doable [19:12:22] MartijnH: You can use mw.ustring to easily do it. [19:13:10] I'll check the reference [19:13:57] sumanah: But we have to be careful... not everyone wanting to just leave a note or correct a link in ruwp can necessarily read/write Кириллица :П [19:13:59] * :P [19:14:00] I was thinking of that for the password RFC, too: "must contain at least one non-ASCII character" would make it really "fun" for US people to log in ;) [19:14:02] is it full utf-8, or do I need to use composite pairs for stuff beyond the BMP? [19:14:15] hoo: oh that's a good point [19:14:23] * sumanah leaves this discussion to people who have thought about it! [19:14:27] MartijnH: I don't think utf-8 uses composite pairs? [19:15:24] well, anything may use composite pairs, and I've seen a bunch of implementations that say they are UTF-8, but don't support non BMP [19:15:51] s/composite/surrogate/, actually [19:16:09] I quote wikipedia " In November 2003 UTF-8 was restricted by RFC 3629 to end at U+10FFFF, in order to match the constraints of the UTF-16 character encoding. This removed all 5- and 6-byte sequences, and about half of the 4-byte sequences." [19:16:16] so that's actually according to spec [19:21:09] it looks like ustring doesn't do any codepoint -> string logic, only the other way around - or I'm overlooking something? [19:23:37] if not and you think it should, it'd be a fun excercise to write it for me [19:24:38] (03CR) 10MarkTraceur: Grep for jsduck warnings and exit nonzero for them (033 comments) [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/113033 (owner: 10MarkTraceur) [19:25:28] MartijnH: I wrote the whole thing already ;) https://www.mediawiki.org/wiki/Extension:Scribunto/Lua_reference_manual#mw.ustring.char [19:25:40] (03CR) 10Bsitu: [C: 032] Write operations return boolean true/false, not result obj [extensions/Flow] - 10https://gerrit.wikimedia.org/r/112712 (owner: 10Matthias Mullie) [19:25:53] (03Merged) 10jenkins-bot: Write operations return boolean true/false, not result obj [extensions/Flow] - 10https://gerrit.wikimedia.org/r/112712 (owner: 10Matthias Mullie) [19:25:54] sweet :) [19:26:31] does it take codepoints as numeric values or hex strings [19:26:37] (03CR) 10Tpt: [C: 032] Refactoring of Page: pages edition PHP code [extensions/ProofreadPage] - 10https://gerrit.wikimedia.org/r/106524 (owner: 10Tpt) [19:26:46] (03Merged) 10jenkins-bot: Refactoring of Page: pages edition PHP code [extensions/ProofreadPage] - 10https://gerrit.wikimedia.org/r/106524 (owner: 10Tpt) [19:26:49] easy to find otu [19:26:57] MartijnH: It takes them as integers, you can represent them as decimal or octal or whatever you want [19:27:30] * anomie|meeting looks, guess octal isn't directly an option in Lua [19:28:13] (03CR) 10Tpt: [C: 032] "Reviewed by Aarti" [extensions/ProofreadPage] - 10https://gerrit.wikimedia.org/r/108678 (owner: 10Tpt) [19:28:20] (03Merged) 10jenkins-bot: Introduce Context [extensions/ProofreadPage] - 10https://gerrit.wikimedia.org/r/108678 (owner: 10Tpt) [19:28:28] (03CR) 10Bsitu: [C: 032] Fix typo that leads to fatal in unused code-path [extensions/Flow] - 10https://gerrit.wikimedia.org/r/112713 (owner: 10Matthias Mullie) [19:28:37] (03Merged) 10jenkins-bot: Fix typo that leads to fatal in unused code-path [extensions/Flow] - 10https://gerrit.wikimedia.org/r/112713 (owner: 10Matthias Mullie) [19:37:25] (03CR) 10Ragesoss: "For i18n, you should add a "qqq" translation as well as English. qqq is for message documentation, so instead of the message itself this i" [extensions/EducationProgram] - 10https://gerrit.wikimedia.org/r/113145 (owner: 10J-squared) [19:41:11] (03PS1) 10Gerrit Patch Uploader: Flood control, Tab nick completion, Nick mention hilight, new sounds, Check to disable sounds, Settings to disable mediawiki parsing, resizeable window. Does not include OGG files, so sounds won't work until added. [extensions/MediaWikiChat] - 10https://gerrit.wikimedia.org/r/113164 [19:41:13] (03CR) 10Gerrit Patch Uploader: "This commit was uploaded using the Gerrit Patch Uploader [1]." [extensions/MediaWikiChat] - 10https://gerrit.wikimedia.org/r/113164 (owner: 10Gerrit Patch Uploader) [19:41:15] (03CR) 10EBernhardson: [C: 04-1] "same concerns with :not selector" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/108535 (owner: 10Matthias Mullie) [19:43:06] (03CR) 10EBernhardson: [C: 031] "depends on unmerged patch" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/108634 (owner: 10Matthias Mullie) [19:43:18] (03PS3) 10Werdna: Anonymous editor warning [extensions/Flow] - 10https://gerrit.wikimedia.org/r/109445 [19:44:30] (03CR) 10EBernhardson: "I think was also need a warning when your session expires, e.g. you were logged in but by" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/109445 (owner: 10Werdna) [19:44:45] (03CR) 10EBernhardson: "e.g. you were logged in when receiving the page but are now logged out." [extensions/Flow] - 10https://gerrit.wikimedia.org/r/109445 (owner: 10Werdna) [19:45:43] (03PS1) 10Tpt: Improve tags parser code [extensions/ProofreadPage] - 10https://gerrit.wikimedia.org/r/113165 [19:46:03] (03CR) 10EBernhardson: [C: 032] Add code to prevent exception for new db columns [extensions/Flow] - 10https://gerrit.wikimedia.org/r/112794 (owner: 10Bsitu) [19:46:14] (03Merged) 10jenkins-bot: Add code to prevent exception for new db columns [extensions/Flow] - 10https://gerrit.wikimedia.org/r/112794 (owner: 10Bsitu) [19:46:58] YuviPanda: I don't think integration/jenkins-job-builder-config patches get sent to grrrit-wm properly [19:47:06] why [19:47:11] Oh, wait, maybe they do [19:47:15] Last one didn't though [19:48:40] Oh, hurr [19:48:42] It's still open. [19:49:28] (03PS4) 10Umherirrender: Use TablePager on Special:ProtectedPages (using log_search) [core] - 10https://gerrit.wikimedia.org/r/105443 [19:49:31] (03PS2) 10MarkTraceur: Grep for jsduck warnings and exit nonzero for them [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/113033 [19:50:03] (03CR) 10MarkTraceur: [C: 032] "Deployed" [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/113033 (owner: 10MarkTraceur) [19:50:12] (03PS3) 10MarkTraceur: Grep for jsduck warnings and exit nonzero for them [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/113033 [19:50:15] (03CR) 10Umherirrender: "Patch Set 4: Removed a unreachable break;" [core] - 10https://gerrit.wikimedia.org/r/105443 (owner: 10Umherirrender) [19:51:33] are there limits on wikiid size? or more specifically, if you want a database table to store wiki ids how wide does it need to be? [19:53:17] (03CR) 10Krusher: "MediaWikiChat.i18n.php.orig file is unneeded... my bad" [extensions/MediaWikiChat] - 10https://gerrit.wikimedia.org/r/113164 (owner: 10Gerrit Patch Uploader) [19:59:01] (03CR) 10Aaron Schulz: [C: 032] Use TablePager on Special:ProtectedPages (using log_search) [core] - 10https://gerrit.wikimedia.org/r/105443 (owner: 10Umherirrender) [19:59:27] (03PS1) 10Tpt: Adds inprop=preload support [extensions/ProofreadPage] - 10https://gerrit.wikimedia.org/r/113166 [20:01:23] (03Abandoned) 10Umherirrender: Use TablePager on Special:ProtectedPages [core] - 10https://gerrit.wikimedia.org/r/98573 (owner: 10Umherirrender) [20:02:24] (03Merged) 10jenkins-bot: Use TablePager on Special:ProtectedPages (using log_search) [core] - 10https://gerrit.wikimedia.org/r/105443 (owner: 10Umherirrender) [20:04:24] (03PS1) 10Mattflaschen: Don't print mediawiki.notification messages [core] - 10https://gerrit.wikimedia.org/r/113169 [20:04:43] (03CR) 10EBernhardson: "LMGTM, juST A FEW MORE NIT PICKS" (034 comments) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/111671 (owner: 10Bsitu) [20:05:39] (03CR) 10Bsitu: Move cutting of index data into index code (031 comment) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/112917 (owner: 10Matthias Mullie) [20:07:40] ebernhardson: LMGTM - looks mostly good to me? :) [20:08:17] (03PS1) 10Tim Landscheidt: Add exemption to the CVE linker for Ubuntu security links [wikimedia/bugzilla/modifications] - 10https://gerrit.wikimedia.org/r/113170 [20:08:50] Hi everyone, I have a problem with a .webm file I just uploaded : https://commons.wikimedia.org/wiki/File:Art_%26_Feminism_Wikipedia_Edit-a-thon,_February_1,_2014.webm [20:09:02] rdwrer: ^ [20:09:20] the video plays fine, but when i try to create captions the timed text editor chops off the URL at the ampersand [20:09:33] can anyone help me with this? [20:09:34] (really beautiful colors on that preview image, btw) [20:09:35] victorgrigas: rdwrer is part of the multimedia team and might be able to help! [20:09:40] (03CR) 10JGonera: mediawiki.log: Move #warn and #deprecate to mediawiki.js and add tracking (031 comment) [core] - 10https://gerrit.wikimedia.org/r/111957 (owner: 10Krinkle) [20:10:53] Oh, victorgrigas, you should talk here [20:11:36] victorgrigas: Talk in the channel please [20:11:42] I'm not sure about captions, sadly [20:11:59] I'll explore a bit after lunch though [20:12:39] (03PS4) 10Umherirrender: Use TablePager on Special:ProtectedTitles [core] - 10https://gerrit.wikimedia.org/r/98252 [20:13:09] victorgrigas: you could try replacing it with & or %26 [20:13:11] ok [20:13:19] (03CR) 10Umherirrender: "Patch Set 4: Rebased" [core] - 10https://gerrit.wikimedia.org/r/98252 (owner: 10Umherirrender) [20:13:31] how do i change a file name thats already been uploadeD? [20:14:31] I think this is a bug? if anyone else uploads a video with an ampersand in i, then they won't have captions either [20:15:03] (03CR) 10Reedy: "Code shouldn't have passed php -l" (031 comment) [extensions/FlaggedRevs] - 10https://gerrit.wikimedia.org/r/76460 (owner: 10TTO) [20:15:06] victorgrigas: oh, i didn't realize the & is in the filename [20:15:13] thats definitely a bug [20:15:41] you can move the file, not sure if you need admin permissions for that though [20:15:49] can it be reported? and what should i do in the meantime? re-upload the file under a different name? [20:16:06] (03CR) 10Reedy: "Same at 228" [extensions/FlaggedRevs] - 10https://gerrit.wikimedia.org/r/76460 (owner: 10TTO) [20:16:22] (03PS1) 10Reedy: Fix syntax error in api/actions/ApiStabilize.php [extensions/FlaggedRevs] - 10https://gerrit.wikimedia.org/r/113171 [20:16:32] victorgrigas: https://commons.wikimedia.org/wiki/Commons:File_renaming#How_to_rename_a_file.3F [20:16:53] (03CR) 10Reedy: "Fixed in //gerrit.wikimedia.org/r/113171" [extensions/FlaggedRevs] - 10https://gerrit.wikimedia.org/r/76460 (owner: 10TTO) [20:17:02] (03CR) 10Reedy: "https://gerrit.wikimedia.org/r/113171" [extensions/FlaggedRevs] - 10https://gerrit.wikimedia.org/r/76460 (owner: 10TTO) [20:17:11] legoktm: hmm, how important are editnotices? I guess we won't be supporting them in the Mobile App for now [20:17:12] yeah, you shoulod file a bug [20:17:14] (03PS1) 10Reedy: Fix syntax error in api/actions/ApiStabilize.php [extensions/FlaggedRevs] (wmf/1.23wmf14) - 10https://gerrit.wikimedia.org/r/113172 [20:17:22] YuviPanda: pretty important.... [20:17:52] (03CR) 10Reedy: [C: 032] Fix syntax error in api/actions/ApiStabilize.php [extensions/FlaggedRevs] (wmf/1.23wmf14) - 10https://gerrit.wikimedia.org/r/113172 (owner: 10Reedy) [20:18:01] (03CR) 10Legoktm: [C: 032 V: 032] Fix syntax error in api/actions/ApiStabilize.php [extensions/FlaggedRevs] - 10https://gerrit.wikimedia.org/r/113171 (owner: 10Reedy) [20:18:12] Jenkins not like FR? [20:18:25] (03CR) 10Reedy: [V: 032] Fix syntax error in api/actions/ApiStabilize.php [extensions/FlaggedRevs] (wmf/1.23wmf14) - 10https://gerrit.wikimedia.org/r/113172 (owner: 10Reedy) [20:18:30] legoktm: I think they'll need to look better on mobile first. As is they will be terrible [20:18:35] right. [20:18:36] legoktm: AF has the same issue. [20:18:41] Reedy: no one ever turned on jenkins for FR [20:18:44] legoktm: and I need to fix it by making AF support 'variants' [20:18:48] or 'targets' [20:18:54] targets? [20:19:04] Awesome [20:19:21] legoktm: lets you have different responses to different 'targest' [20:19:27] hm [20:20:57] legoktm: so Mediawiki:abusefilter-delete-warning/mobile will be for mobile, for example [20:21:08] (03PS1) 10Reedy: Fix syntax errors in FlaggedRevs [core] (wmf/1.23wmf14) - 10https://gerrit.wikimedia.org/r/113174 [20:22:10] (03CR) 10Reedy: [C: 032 V: 032] Fix syntax errors in FlaggedRevs [core] (wmf/1.23wmf14) - 10https://gerrit.wikimedia.org/r/113174 (owner: 10Reedy) [20:23:20] (03PS5) 10Umherirrender: Use TablePager on Special:ProtectedTitles [core] - 10https://gerrit.wikimedia.org/r/98252 [20:23:50] (03PS4) 10Jforrester: Better text for in core [core] - 10https://gerrit.wikimedia.org/r/83662 [20:24:09] (03CR) 10Jforrester: "PS4 is a rebase." [core] - 10https://gerrit.wikimedia.org/r/83662 (owner: 10Jforrester) [20:24:20] (03CR) 10Umherirrender: "Patch Set 5: Throw exception in formatValue for unknown field instead of return english text" [core] - 10https://gerrit.wikimedia.org/r/98252 (owner: 10Umherirrender) [20:25:36] (03PS5) 10Jforrester: Better text for in core [core] - 10https://gerrit.wikimedia.org/r/83662 [20:27:46] (03CR) 10Jforrester: "PS5 consists of s/your edits will be/you will have your edits/g" [core] - 10https://gerrit.wikimedia.org/r/83662 (owner: 10Jforrester) [20:27:48] (03Abandoned) 10Umherirrender: Store timestamp, user and reason for page protections in the db [core] - 10https://gerrit.wikimedia.org/r/98175 (owner: 10Umherirrender) [20:38:51] MatmaRex, what was the first approach you tried for the GENDER with no parameters? [20:42:01] superm401: hmm [20:42:31] It seems like making literalWithoutBar 0 or more might work. [20:42:53] i think that, in templateWithReplacement and templateWithOutReplacement, i changed replacement to choice(replacement, makeStringParser('')) [20:43:02] (same with paramExpression instead of replacement) [20:43:06] or something like that [20:43:25] the choice() probably returns some nested structure, i didn't bother debugging this [20:43:50] i think i also tried nOrMore() instead of choice(), and it was throwing too [20:45:07] Is this a proper bug report? https://bugzilla.wikimedia.org/show_bug.cgi?id=61336 [20:48:53] victorgrigas, yeah, either we should fully support files with ampersand or cleanup the filename at upload time (as is done in other cases). [20:49:43] victorgrigas, sounds like just a URL-encoding issue. [20:50:18] yeah that sounds logical to me [20:50:37] what would it take to get fixed? [20:51:00] i don't want to re-upload the file i uploaded and I'm planning a blog post tomorrow or monday [20:51:13] & I'm hoping that people will see it and want to translate the captions [20:52:01] victorgrigas: you could get some commons admin to rename it, perhaps [20:52:10] victorgrigas: ragesoss could do it, but I think Reedy has the rights too [20:52:33] victorgrigas, yeah, just click Move on the file page. [20:52:38] There is a nice dialog that pops up. [20:53:12] victorgrigas, might be hidden by the tab dropdown. [20:54:04] is there a way for javascript to cleanly get the current revision id of the page being viewed? [20:54:56] ok just requested that - thanks for showing me that - i didn't know it was a feature! [20:55:13] jackmcbarn: wgCurRevisionId? [20:55:16] jackmcbarn: mw.config.get('wgCurRevisionId') [20:55:38] jackmcbarn, what do you mean "current" [20:55:47] wgCurRevisionId is misleading, it's really the topc one. [20:55:51] Sorry, top one. [20:55:59] (it's not set when action!=view, i think, there's a bug about that) [20:56:01] jackmcbarn, what do you want to happen if they visit an oldid page? [20:56:24] the revision id of the revision being viewed i meant [20:56:42] so if they're viewing the latest version, then someone edits the page, and they don't refresh, it should still give me the old one [20:56:44] jackmcbarn, that's what I thought, but wanted to check: wgRevisionId . ^ ori, MatmaRex [20:56:52] (03CR) 10Legoktm: [C: 032 V: 032] Add time ago in words at the bottom of the popup [extensions/Popups] - 10https://gerrit.wikimedia.org/r/111977 (owner: 10Prtksxna) [20:56:57] legoktm: \o/ [20:56:59] :D [20:57:26] thanks [20:57:28] (03PS10) 10Prtksxna: Add `redirects to` message at the top of the popup [extensions/Popups] - 10https://gerrit.wikimedia.org/r/111983 [20:57:34] legoktm: this one? https://gerrit.wikimedia.org/r/#/c/111983/ [20:58:13] looking [20:58:13] (03CR) 10MarkTraceur: [C: 04-1] "Release notes, then I'll merge." [core] - 10https://gerrit.wikimedia.org/r/112956 (owner: 10Gergő Tisza) [20:58:16] tgr: ^^ [20:58:33] (03PS2) 10Prtksxna: Position timestamp div from the bottom [extensions/Popups] - 10https://gerrit.wikimedia.org/r/113090 [21:00:57] YuviPanda: The styling of the page title is werid to me [21:02:26] legoktm: hmm, -1 it? but if the code looks ok, you could just add a note and merge it, so he can follow up with a CSS fix later [21:03:06] (03CR) 10Hashar: "Sorry I am lagging with my reviews :/ Been busy with browser tests..." [tools/scap] - 10https://gerrit.wikimedia.org/r/112487 (owner: 10BryanDavis) [21:04:55] (03CR) 10Legoktm: "It's a bit weird to me have "redirects to
Pagename" and Pagename has some funky styling to it. I think having it all on one line woul" [extensions/Popups] - 10https://gerrit.wikimedia.org/r/111983 (owner: 10Prtksxna) [21:05:19] (03CR) 10Aaron Schulz: Added password hashing API (038 comments) [core] - 10https://gerrit.wikimedia.org/r/77645 (owner: 10Parent5446) [21:05:25] legoktm: thanks :) [21:05:40] (03PS3) 10Gergő Tisza: Add jquery-throttle-debounce to core [core] - 10https://gerrit.wikimedia.org/r/112956 [21:06:11] legoktm: anything I can look at for you? [21:07:40] (03CR) 10Legoktm: Add tests for API's assert={user|bot} (031 comment) [core] - 10https://gerrit.wikimedia.org/r/108291 (owner: 10Legoktm) [21:08:10] YuviPanda: https://gerrit.wikimedia.org/r/#/c/112302/ and https://gerrit.wikimedia.org/r/#/c/107322/ ? [21:08:15] both are pretty simple [21:09:13] legoktm: right now, 112302 should be a NOP, I guess [21:09:17] legoktm: let me test and merge :) [21:09:26] legoktm: can you also add a patch to Popups marking it as a betafeature? [21:09:32] sure [21:09:38] I have one for VectorBeta too [21:09:44] sweet [21:09:53] https://gerrit.wikimedia.org/r/#/c/112303/ [21:09:57] legoktm: hmm, what happens when betafeatures is not installed? [21:10:03] do these extensions crash? [21:10:04] it just goes into 'other' [21:10:06] right [21:11:40] let me verify that... [21:12:22] legoktm: ok :D [21:12:34] legoktm: verify that and I'll merge [21:13:30] yup! [21:13:36] YuviPanda: works fine if BF isn't installed [21:13:42] sweet [21:13:42] Best Friend? [21:14:19] (03PS1) 10Legoktm: Set extension type to 'betafeatures' [extensions/Popups] - 10https://gerrit.wikimedia.org/r/113184 [21:14:53] legoktm: heh, should betafeattures itself be under betafeatures? :P [21:15:01] I don't think so [21:15:32] heh [21:16:27] (03CR) 10Yuvipanda: [C: 032] Add custom extension type for Beta features [extensions/BetaFeatures] - 10https://gerrit.wikimedia.org/r/112302 (owner: 10Legoktm) [21:16:41] (03CR) 10Yuvipanda: [C: 032 V: 032] Set extension type to 'betafeatures' [extensions/Popups] - 10https://gerrit.wikimedia.org/r/113184 (owner: 10Legoktm) [21:17:01] YuviPanda: https://gerrit.wikimedia.org/r/#/c/112303/ [21:17:05] legoktm: link me to the one for vectorbeta? I'll let rdwrer handle multimediaviewer [21:17:10] ^ that one [21:17:27] (03CR) 10Yuvipanda: [C: 032] "Seems appropriate since this is only available as a BF" [extensions/VectorBeta] - 10https://gerrit.wikimedia.org/r/112303 (owner: 10Legoktm) [21:17:36] woot [21:17:49] legoktm: I got everything other than the cache patch, right? [21:17:53] (03Merged) 10jenkins-bot: Add custom extension type for Beta features [extensions/BetaFeatures] - 10https://gerrit.wikimedia.org/r/112302 (owner: 10Legoktm) [21:17:55] yup [21:18:38] legoktm: ok! :) [21:18:48] legoktm: I'll take a look at that momentarily! [21:18:50] legoktm: thanks! :) [21:18:50] (03Merged) 10jenkins-bot: Set extension type to 'betafeatures' [extensions/VectorBeta] - 10https://gerrit.wikimedia.org/r/112303 (owner: 10Legoktm) [21:18:53] :D [21:19:16] Will do, thanks YuviPanda [21:25:00] (03CR) 10CSteipp: Password Expiration (039 comments) [core] - 10https://gerrit.wikimedia.org/r/92037 (owner: 10CSteipp) [21:26:02] (03PS13) 10CSteipp: Password Expiration [core] - 10https://gerrit.wikimedia.org/r/92037 [21:29:52] (03CR) 10jenkins-bot: [V: 04-1] Password Expiration [core] - 10https://gerrit.wikimedia.org/r/92037 (owner: 10CSteipp) [21:30:41] (03CR) 10EBernhardson: [C: 032] Fix topic preview [extensions/Flow] - 10https://gerrit.wikimedia.org/r/113046 (owner: 10Bsitu) [21:30:51] (03Merged) 10jenkins-bot: Fix topic preview [extensions/Flow] - 10https://gerrit.wikimedia.org/r/113046 (owner: 10Bsitu) [21:33:51] (03CR) 10Bsitu: [C: 032] Fix missing i18n msgs for edit conflicts [extensions/Flow] - 10https://gerrit.wikimedia.org/r/113037 (owner: 10Matthias Mullie) [21:34:06] (03Merged) 10jenkins-bot: Fix missing i18n msgs for edit conflicts [extensions/Flow] - 10https://gerrit.wikimedia.org/r/113037 (owner: 10Matthias Mullie) [21:35:16] (03CR) 10EBernhardson: "one minor logic issue, prefer true cases rather than negation" (031 comment) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/113042 (owner: 10Bsitu) [21:37:17] hoo: hey, got a sec? [21:37:21] (03PS5) 10EBernhardson: Flow watchlist data tweaks [extensions/Flow] - 10https://gerrit.wikimedia.org/r/113042 (owner: 10Bsitu) [21:37:34] (03CR) 10EBernhardson: [C: 032] Flow watchlist data tweaks [extensions/Flow] - 10https://gerrit.wikimedia.org/r/113042 (owner: 10Bsitu) [21:37:45] (03Merged) 10jenkins-bot: Flow watchlist data tweaks [extensions/Flow] - 10https://gerrit.wikimedia.org/r/113042 (owner: 10Bsitu) [21:38:01] (03PS1) 10Yuvipanda: Update LESS file with modifications from the app [extensions/MobileApp] - 10https://gerrit.wikimedia.org/r/113257 [21:38:01] ori: I guess so, yes [21:38:04] legoktm: trivial merge? ^ [21:38:59] (03CR) 10EBernhardson: [C: 032] revision change type name flow-edit-post should be edit-post [extensions/Flow] - 10https://gerrit.wikimedia.org/r/113062 (owner: 10Bsitu) [21:39:10] (03Merged) 10jenkins-bot: revision change type name flow-edit-post should be edit-post [extensions/Flow] - 10https://gerrit.wikimedia.org/r/113062 (owner: 10Bsitu) [21:39:29] hoo: so, we're trying to eliminate as much as possible interface modifications after DOMContentLoaded, and I'm wondering if you could do some work to make the add interlanguage links link be added in PHP [21:40:01] (03CR) 10Legoktm: [C: 032 V: 032] Update LESS file with modifications from the app [extensions/MobileApp] - 10https://gerrit.wikimedia.org/r/113257 (owner: 10Yuvipanda) [21:40:06] legoktm: ty! [21:40:22] the actual interface could still be lazy-loaded and triggered by a handler that is bound to the element at page load time, but ideally the link itself should be part of the HTML output coming from php [21:41:15] I see... in theory we could add that link in PHP with display: none or so and then show it in JS in case the conditions are met... [21:41:42] problem is, that we can only decide whether we want to show that link or not in JS [21:43:17] (03PS1) 10BryanDavis: Touch ExtensionMessages-VERSION if not present [tools/scap] - 10https://gerrit.wikimedia.org/r/113260 [21:43:23] ori: ^ [21:43:44] (03CR) 10Raimond Spekking: Add time ago in words at the bottom of the popup (031 comment) [extensions/Popups] - 10https://gerrit.wikimedia.org/r/111977 (owner: 10Prtksxna) [21:44:11] (03CR) 10EBernhardson: [C: 032] (bug 60983) Apply redlinker to flow-parsoid API [extensions/Flow] - 10https://gerrit.wikimedia.org/r/112931 (owner: 10Matthias Mullie) [21:44:13] hoo: what are the conditions? [21:44:20] (03Merged) 10jenkins-bot: (bug 60983) Apply redlinker to flow-parsoid API [extensions/Flow] - 10https://gerrit.wikimedia.org/r/112931 (owner: 10Matthias Mullie) [21:45:01] ori: User logged in and browser supports CORS [21:45:17] second one can't be checked server side [21:45:43] (03CR) 10Bsitu: [C: 032] Basic test to demonstrate history bundling issue [extensions/Flow] - 10https://gerrit.wikimedia.org/r/112831 (owner: 10EBernhardson) [21:45:53] (03Merged) 10jenkins-bot: Basic test to demonstrate history bundling issue [extensions/Flow] - 10https://gerrit.wikimedia.org/r/112831 (owner: 10EBernhardson) [21:46:42] hoo: couldn't you simply have the link point to the page on wikidata, and then client-side, if user is logged in and supports CORS, bind a handler that cancels navigation to wikidatawiki and replaces it with the in-place editing interface instead? [21:47:14] ori: We decided to not to do that for UI consistency reasons [21:49:25] hoo: OK, I'm not militant about it, but if there's a way to revisit that decision... maybe I'll file a bug and CC Lydia? [21:49:32] since it sounds like this has "product-y" implications [21:50:19] ori: Yeah... that was kind of weird when I did it first... we changed it around several times unless everyone was somehow ok with it [21:50:45] I guess I can bring that topic up again... also a matter of no-JS UI ... [21:54:49] (03PS1) 10Phuedx: Log title moves using the PageMove schema [extensions/WikimediaEvents] - 10https://gerrit.wikimedia.org/r/113261 [21:55:32] (03PS5) 10Matthias Mullie: Move flow( 'setupEditForm' ) to base/action.js [extensions/Flow] - 10https://gerrit.wikimedia.org/r/108535 [21:55:35] (03CR) 10jenkins-bot: [V: 04-1] Move flow( 'setupEditForm' ) to base/action.js [extensions/Flow] - 10https://gerrit.wikimedia.org/r/108535 (owner: 10Matthias Mullie) [21:55:45] (03CR) 10Matthias Mullie: Move flow( 'setupEditForm' ) to base/action.js (035 comments) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/108535 (owner: 10Matthias Mullie) [21:55:57] (03CR) 10MarkTraceur: [C: 032] "Merging the MMV patch next! Thanks, Gergo." [core] - 10https://gerrit.wikimedia.org/r/112956 (owner: 10Gergő Tisza) [21:56:07] (03PS1) 10Ori.livneh: Round 'mediaWikiLoadComplete' to comply with schema [extensions/NavigationTiming] - 10https://gerrit.wikimedia.org/r/113262 [21:56:09] (03PS1) 10Phuedx: Log article deletions using the PageDeletion schema [extensions/WikimediaEvents] - 10https://gerrit.wikimedia.org/r/113263 [21:56:49] (03PS6) 10Matthias Mullie: Move flow( 'setupEditForm' ) to base/action.js [extensions/Flow] - 10https://gerrit.wikimedia.org/r/108535 [21:58:07] (03CR) 10BryanDavis: [C: 032] Round 'mediaWikiLoadComplete' to comply with schema [extensions/NavigationTiming] - 10https://gerrit.wikimedia.org/r/113262 (owner: 10Ori.livneh) [21:58:09] (03Merged) 10jenkins-bot: Round 'mediaWikiLoadComplete' to comply with schema [extensions/NavigationTiming] - 10https://gerrit.wikimedia.org/r/113262 (owner: 10Ori.livneh) [21:58:51] (03CR) 10Matthias Mullie: [C: 032] Flow mention should respect Echo mention preference [extensions/Flow] - 10https://gerrit.wikimedia.org/r/112493 (owner: 10Bsitu) [21:58:58] (03CR) 10Matthias Mullie: [C: 032] Associative array should not be accessed by numeric index [extensions/Flow] - 10https://gerrit.wikimedia.org/r/113070 (owner: 10Bsitu) [21:59:00] (03Merged) 10jenkins-bot: Flow mention should respect Echo mention preference [extensions/Flow] - 10https://gerrit.wikimedia.org/r/112493 (owner: 10Bsitu) [21:59:06] (03CR) 10Matthias Mullie: [C: 032] fire wikipage.content hook on new posts [extensions/Flow] - 10https://gerrit.wikimedia.org/r/112126 (owner: 10Bencmq) [21:59:09] (03Merged) 10jenkins-bot: Associative array should not be accessed by numeric index [extensions/Flow] - 10https://gerrit.wikimedia.org/r/113070 (owner: 10Bsitu) [21:59:15] (03Merged) 10jenkins-bot: fire wikipage.content hook on new posts [extensions/Flow] - 10https://gerrit.wikimedia.org/r/112126 (owner: 10Bencmq) [21:59:27] (03PS1) 10Jforrester: Update OOjs UI to v0.1.0-pre (7788dc6700) [core] - 10https://gerrit.wikimedia.org/r/113264 [21:59:49] I guess jenkins is taking a massive shit right now? [22:00:12] Yes. [22:00:17] (03Merged) 10jenkins-bot: Add jquery-throttle-debounce to core [core] - 10https://gerrit.wikimedia.org/r/112956 (owner: 10Gergő Tisza) [22:00:47] hoo: OK, really appreciate it! [22:01:42] (03Abandoned) 10Matthias Mullie: Users probably shouldn't see deleted entries too, unless they have sufficient permissions [extensions/Flow] - 10https://gerrit.wikimedia.org/r/102172 (owner: 10Matthias Mullie) [22:01:51] You're welcome ;) [22:04:16] (03CR) 10EBernhardson: "perhaps i should have read the commit message before reviewing, but overall looks like a good direction." (039 comments) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/109431 (owner: 10Bsitu) [22:05:44] (03CR) 10Trevor Parscal: [C: 032] Update OOjs UI to v0.1.0-pre (7788dc6700) [core] - 10https://gerrit.wikimedia.org/r/113264 (owner: 10Jforrester) [22:06:32] (03PS1) 10Ori.livneh: Bump EventCapsule schema ref to 6862080 [extensions/EventLogging] - 10https://gerrit.wikimedia.org/r/113267 [22:07:14] (03PS15) 10EBernhardson: Add corresponding *_user_wiki field to all *_user_id fields [extensions/Flow] - 10https://gerrit.wikimedia.org/r/111671 (owner: 10Bsitu) [22:07:17] (03CR) 10Norayr: "tried to answer your comments" (033 comments) [extensions/ConfirmEdit] - 10https://gerrit.wikimedia.org/r/113122 (owner: 10Norayr) [22:07:51] (03CR) 10EBernhardson: [C: 04-2] "This is ready to go, but per the commit message https://gerrit.wikimedia.org/r/#/c/112794/ needs to be deployed and the schema change need" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/111671 (owner: 10Bsitu) [22:07:56] (03CR) 10Nuria: [C: 031] Bump EventCapsule schema ref to 6862080 [extensions/EventLogging] - 10https://gerrit.wikimedia.org/r/113267 (owner: 10Ori.livneh) [22:08:06] (03PS16) 10EBernhardson: [SCHEMA CHANGE] Add corresponding *_user_wiki field to all *_user_id fields [extensions/Flow] - 10https://gerrit.wikimedia.org/r/111671 (owner: 10Bsitu) [22:08:09] (03CR) 10Ori.livneh: [C: 032] Bump EventCapsule schema ref to 6862080 [extensions/EventLogging] - 10https://gerrit.wikimedia.org/r/113267 (owner: 10Ori.livneh) [22:08:41] (03Merged) 10jenkins-bot: Bump EventCapsule schema ref to 6862080 [extensions/EventLogging] - 10https://gerrit.wikimedia.org/r/113267 (owner: 10Ori.livneh) [22:09:17] (03CR) 10jenkins-bot: [V: 04-1] Update OOjs UI to v0.1.0-pre (7788dc6700) [core] - 10https://gerrit.wikimedia.org/r/113264 (owner: 10Jforrester) [22:09:22] (03CR) 10Matthias Mullie: [C: 031] "Patch ok to merge whenever ready with preparations" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/111671 (owner: 10Bsitu) [22:14:04] (03CR) 10Aaron Schulz: Added password hashing API (035 comments) [core] - 10https://gerrit.wikimedia.org/r/77645 (owner: 10Parent5446) [22:16:13] (03CR) 10EBernhardson: [C: 032] Move flow( 'setupEditForm' ) to base/action.js [extensions/Flow] - 10https://gerrit.wikimedia.org/r/108535 (owner: 10Matthias Mullie) [22:16:22] (03PS6) 10Matthias Mullie: Move flow( 'loadReplyForm' ) to base/action.js [extensions/Flow] - 10https://gerrit.wikimedia.org/r/108634 [22:16:25] (03Merged) 10jenkins-bot: Move flow( 'setupEditForm' ) to base/action.js [extensions/Flow] - 10https://gerrit.wikimedia.org/r/108535 (owner: 10Matthias Mullie) [22:16:32] (03CR) 10EBernhardson: [C: 032] Move flow( 'loadReplyForm' ) to base/action.js [extensions/Flow] - 10https://gerrit.wikimedia.org/r/108634 (owner: 10Matthias Mullie) [22:16:50] (03CR) 10EBernhardson: "needs rebase" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/108635 (owner: 10Matthias Mullie) [22:19:41] (03PS1) 10Ori.livneh: Don't log NewEditorEdit for anons [extensions/WikimediaEvents] - 10https://gerrit.wikimedia.org/r/113269 [22:20:33] (03CR) 10Mattflaschen: [C: 032] "Looks good. Tested locally manually and with QUnit." [core] - 10https://gerrit.wikimedia.org/r/113112 (owner: 10Bartosz Dziewoński) [22:21:10] greg-g: could we get into the LD window today? we have one patch for wmf13 and 14, basically pagination is currently always returning 1 topic [22:21:17] (03PS1) 10Ori.livneh: Update NavigationTiming to master [core] (wmf/1.23wmf13) - 10https://gerrit.wikimedia.org/r/113270 [22:21:43] (03PS1) 10Ori.livneh: Update NavigationTiming to master [core] (wmf/1.23wmf14) - 10https://gerrit.wikimedia.org/r/113271 [22:22:09] (03PS2) 10Ori.livneh: Don't log NewEditorEdit for anons [extensions/WikimediaEvents] - 10https://gerrit.wikimedia.org/r/113269 [22:23:29] (03CR) 10BryanDavis: [C: 032] "I would have also accepted if ( !!$user->isAnon() ) since Ori does a lot of javascript." [extensions/WikimediaEvents] - 10https://gerrit.wikimedia.org/r/113269 (owner: 10Ori.livneh) [22:23:32] (03Merged) 10jenkins-bot: Don't log NewEditorEdit for anons [extensions/WikimediaEvents] - 10https://gerrit.wikimedia.org/r/113269 (owner: 10Ori.livneh) [22:24:16] ebernhardson: yeah, you and holmquist and gwicke are in it [22:24:22] plz add to calendar [22:24:30] (03CR) 10EBernhardson: "js coding standards: The only exception are constructors used with the new operator. Those names must start with an uppercase letter (Uppe" (031 comment) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/108535 (owner: 10Matthias Mullie) [22:24:42] greg-g: ok thanks [22:24:45] hmm, /me needs to bug holmquist to do that too [22:24:53] rdwrer: ^^^ [22:24:58] (03CR) 10Isarra: "Bug 61008 isn't a blocker; the effect of that is the same whether the filter is in the mixin or it's added manually. Folks figure out the " [core] - 10https://gerrit.wikimedia.org/r/112066 (owner: 10Isarra) [22:25:07] * greg-g flailed looking for marktracuer for too long [22:25:16] (03Merged) 10jenkins-bot: mediawiki.jqueryMsg: Support {{GENDER:}} with empty first parameter [core] - 10https://gerrit.wikimedia.org/r/113112 (owner: 10Bartosz Dziewoński) [22:27:20] (03CR) 10Ori.livneh: [C: 032] Update NavigationTiming to master [core] (wmf/1.23wmf13) - 10https://gerrit.wikimedia.org/r/113270 (owner: 10Ori.livneh) [22:27:24] (03CR) 10Mattflaschen: mediawiki.log: Move #warn and #deprecate to mediawiki.js and add tracking (031 comment) [core] - 10https://gerrit.wikimedia.org/r/111957 (owner: 10Krinkle) [22:27:35] (03CR) 10Ori.livneh: [C: 032] Update NavigationTiming to master [core] (wmf/1.23wmf14) - 10https://gerrit.wikimedia.org/r/113271 (owner: 10Ori.livneh) [22:29:21] (03PS1) 10Ori.livneh: Update WikimediaEvents to master [core] (wmf/1.23wmf13) - 10https://gerrit.wikimedia.org/r/113274 [22:29:40] (03PS1) 10Ori.livneh: Update WikimediaEvents to master [core] (wmf/1.23wmf14) - 10https://gerrit.wikimedia.org/r/113275 [22:31:40] What [22:31:40] (03PS1) 10EBernhardson: Update flow to fix pagination [core] (wmf/1.23wmf13) - 10https://gerrit.wikimedia.org/r/113276 [22:31:42] Oh, right [22:31:44] Was doing [22:32:35] Reedy: gerrit doesn't seem to know about a wmf/1.23wmf14 branch for Flow, but i see them on some other extensions and core. oversight? [22:33:10] (03Merged) 10jenkins-bot: Update NavigationTiming to master [core] (wmf/1.23wmf13) - 10https://gerrit.wikimedia.org/r/113270 (owner: 10Ori.livneh) [22:33:12] (03Merged) 10jenkins-bot: Update NavigationTiming to master [core] (wmf/1.23wmf14) - 10https://gerrit.wikimedia.org/r/113271 (owner: 10Ori.livneh) [22:33:22] ebernhardson: I don't do that manually ;) [22:33:23] Reedy: neverming, i see it in `git ls-remote` the branch command is just having issues. PEBKAC [22:33:23] (03CR) 10Ori.livneh: [C: 032] Update WikimediaEvents to master [core] (wmf/1.23wmf13) - 10https://gerrit.wikimedia.org/r/113274 (owner: 10Ori.livneh) [22:33:39] (03CR) 10Ori.livneh: [C: 032] Update WikimediaEvents to master [core] (wmf/1.23wmf14) - 10https://gerrit.wikimedia.org/r/113275 (owner: 10Ori.livneh) [22:33:41] Reedy: yea, it seemed odd like omething that should be automated [22:37:01] (03PS18) 10Inchikutty: [WIP]Embedding leaflet maps based on OSM data to UploadWizard [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/109263 [22:37:17] (03CR) 10Trevor Parscal: [C: 032] Update OOjs UI to v0.1.0-pre (7788dc6700) [core] - 10https://gerrit.wikimedia.org/r/113264 (owner: 10Jforrester) [22:38:14] (03PS1) 10EBernhardson: Loading new topics is broken [extensions/Flow] (wmf/1.23wmf14) - 10https://gerrit.wikimedia.org/r/113278 [22:39:02] (03Merged) 10jenkins-bot: Update WikimediaEvents to master [core] (wmf/1.23wmf13) - 10https://gerrit.wikimedia.org/r/113274 (owner: 10Ori.livneh) [22:39:06] (03Abandoned) 10EBernhardson: Loading new topics is broken [extensions/Flow] (wmf/1.23wmf14) - 10https://gerrit.wikimedia.org/r/113278 (owner: 10EBernhardson) [22:39:11] (03Merged) 10jenkins-bot: Update WikimediaEvents to master [core] (wmf/1.23wmf14) - 10https://gerrit.wikimedia.org/r/113275 (owner: 10Ori.livneh) [22:40:57] (03CR) 10Legoktm: [WIP] Add EventLogging [WIP] (031 comment) [extensions/Popups] - 10https://gerrit.wikimedia.org/r/112661 (owner: 10Prtksxna) [22:40:59] (03Merged) 10jenkins-bot: Update OOjs UI to v0.1.0-pre (7788dc6700) [core] - 10https://gerrit.wikimedia.org/r/113264 (owner: 10Jforrester) [22:41:01] (03CR) 10Bsitu: [C: 032] Unimplemented LocalBufferedCache::merge could lead to corrupt cache [extensions/Flow] - 10https://gerrit.wikimedia.org/r/112791 (owner: 10Matthias Mullie) [22:41:04] (03PS1) 10Mattflaschen: Use normal mw.message call [extensions/GuidedTour] - 10https://gerrit.wikimedia.org/r/113279 [22:41:49] (03CR) 10jenkins-bot: [V: 04-1] Use normal mw.message call [extensions/GuidedTour] - 10https://gerrit.wikimedia.org/r/113279 (owner: 10Mattflaschen) [22:42:00] (03Merged) 10jenkins-bot: Unimplemented LocalBufferedCache::merge could lead to corrupt cache [extensions/Flow] - 10https://gerrit.wikimedia.org/r/112791 (owner: 10Matthias Mullie) [22:43:39] (03PS2) 10Mattflaschen: Use normal mw.message call [extensions/GuidedTour] - 10https://gerrit.wikimedia.org/r/113279 [22:44:16] (03CR) 10Bartosz Dziewoński: "The false V-1 was probably caused by https://bugzilla.wikimedia.org/show_bug.cgi?id=53895" [extensions/GuidedTour] - 10https://gerrit.wikimedia.org/r/113279 (owner: 10Mattflaschen) [22:47:08] (03PS1) 10Ori.livneh: Don't log 'desktop-beta' as mobileMode [extensions/NavigationTiming] - 10https://gerrit.wikimedia.org/r/113284 [22:47:16] (03CR) 10GWicke: [C: 04-2] "The .gitreview file is added when you first use git review. Afaik there is no need to check this into the repository (we don't have it in " [services/mathoid] - 10https://gerrit.wikimedia.org/r/112875 (owner: 10Physikerwelt) [22:47:29] jgonera: cld you review https://gerrit.wikimedia.org/r/#/c/113284/ ? [22:47:40] gwicke: not true [22:48:55] (03PS14) 10Inchikutty: [WIP]Embedding Static Map to UploadWizard [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/107892 [22:49:04] (03CR) 10GWicke: [C: 032] "We could also move this into debian/rules." [services/mathoid] - 10https://gerrit.wikimedia.org/r/113024 (owner: 10Physikerwelt) [22:49:53] hoo, you are right- overlooked it [22:50:02] thanks [22:50:10] ;) You're welcome [22:50:33] (03CR) 10EBernhardson: [C: 04-1] Add some more details to RC tables (034 comments) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/112169 (owner: 10Matthias Mullie) [22:51:18] (03CR) 10GWicke: [C: 032] "Turns out we actually *have* a .gitreview file in the parsoid repo, and it is needed. So nevermind ;)" [services/mathoid] - 10https://gerrit.wikimedia.org/r/112875 (owner: 10Physikerwelt) [22:53:26] (03CR) 10Bartosz Dziewoński: [C: 032] Use normal mw.message call [extensions/GuidedTour] - 10https://gerrit.wikimedia.org/r/113279 (owner: 10Mattflaschen) [22:53:47] (03CR) 10EBernhardson: [C: 032] Add *Collection classes [extensions/Flow] - 10https://gerrit.wikimedia.org/r/111366 (owner: 10Matthias Mullie) [22:53:53] (03PS6) 10Matthias Mullie: Don't propagate permissions to older revisions [extensions/Flow] - 10https://gerrit.wikimedia.org/r/112042 [22:53:58] (03Merged) 10jenkins-bot: Add *Collection classes [extensions/Flow] - 10https://gerrit.wikimedia.org/r/111366 (owner: 10Matthias Mullie) [22:58:09] (03PS10) 10Inchikutty: Adding Leaflet scripts to UploadWizard [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/109063 [22:59:56] (03CR) 10EBernhardson: [C: 031] Split permission-logic into separate method [extensions/Flow] - 10https://gerrit.wikimedia.org/r/112158 (owner: 10Matthias Mullie) [23:05:22] tgr: hey [23:05:32] tgr: ValidationError: u'User clicked on the lightbox close button.' is not one of [u'thumbnail-link-click', u'enlarge-link-click', u'fullscreen-link-click', u'defullscreen-link-click', u'site-link-click', u'close-link-click'] (for Schema:MediaViewer) [23:05:37] tgr: seeing that in the logs [23:06:09] (03CR) 10JGonera: [C: 031] "Sorry for that... That should've been implemented in a different way." [extensions/NavigationTiming] - 10https://gerrit.wikimedia.org/r/113284 (owner: 10Ori.livneh) [23:06:25] ori, is it a problem in itself? [23:06:43] jgonera: could you +2 if it looks OK? [23:07:19] tgr: well, those events don't make it to the database, because they are not valid [23:07:24] and they inflate the invalid event logs [23:07:41] yeah, i mean is the error spam a problem? [23:07:51] (03CR) 10JGonera: [C: 032] Don't log 'desktop-beta' as mobileMode [extensions/NavigationTiming] - 10https://gerrit.wikimedia.org/r/113284 (owner: 10Ori.livneh) [23:07:56] (03Merged) 10jenkins-bot: Don't log 'desktop-beta' as mobileMode [extensions/NavigationTiming] - 10https://gerrit.wikimedia.org/r/113284 (owner: 10Ori.livneh) [23:08:01] so should we port back a fix? [23:08:32] otherwise i'm not sure if we care very much about those logs being wrong for a week [23:08:46] tgr: that's fine, as long as there is a fix upstream [23:08:47] ori: I'm not quite sure how to go with https://gerrit.wikimedia.org/r/#/c/113038/ . Would be nice to comment if you get the chance. [23:10:05] (03PS7) 10Bsitu: Use provided language for link messages [extensions/Flow] - 10https://gerrit.wikimedia.org/r/112038 (owner: 10EBernhardson) [23:10:34] (03PS2) 10EBernhardson: Consolidate formatters into Flow\\Formatter namespace [extensions/Flow] - 10https://gerrit.wikimedia.org/r/113154 [23:10:37] (03CR) 10jenkins-bot: [V: 04-1] Consolidate formatters into Flow\\Formatter namespace [extensions/Flow] - 10https://gerrit.wikimedia.org/r/113154 (owner: 10EBernhardson) [23:10:43] (03CR) 10Bsitu: [C: 032] "Rebased" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/112038 (owner: 10EBernhardson) [23:10:46] Ugh, this Kolega2357 guy in #mediawiki... It's impossible to make him understand that he does not understand wgFilterLogTypes [23:10:54] (03Merged) 10jenkins-bot: Use provided language for link messages [extensions/Flow] - 10https://gerrit.wikimedia.org/r/112038 (owner: 10EBernhardson) [23:11:09] AaronSchulz: starred, will get to it today [23:11:52] gwicke: are you still super busy? [23:12:32] oh. progress. [23:16:15] (03Abandoned) 10Chad: Add namespace-wide page notice functionality [core] - 10https://gerrit.wikimedia.org/r/105434 (owner: 10TTO) [23:16:45] (03PS3) 10EBernhardson: Consolidate formatters into Flow\\Formatter namespace [extensions/Flow] - 10https://gerrit.wikimedia.org/r/113154 [23:16:55] (03CR) 10jenkins-bot: [V: 04-1] Consolidate formatters into Flow\\Formatter namespace [extensions/Flow] - 10https://gerrit.wikimedia.org/r/113154 (owner: 10EBernhardson) [23:17:03] (03CR) 10Chad: [C: 032] Differentiate missing texvccheck from missing texvc [extensions/Math] - 10https://gerrit.wikimedia.org/r/112589 (owner: 10Physikerwelt) [23:17:14] (03Merged) 10jenkins-bot: Differentiate missing texvccheck from missing texvc [extensions/Math] - 10https://gerrit.wikimedia.org/r/112589 (owner: 10Physikerwelt) [23:17:37] (03CR) 10Nemo bis: now captcha.py can generate captchas with unicode characters. (031 comment) [extensions/ConfirmEdit] - 10https://gerrit.wikimedia.org/r/113122 (owner: 10Norayr) [23:24:03] (03PS4) 10EBernhardson: Consolidate formatters into Flow\\Formatter namespace [extensions/Flow] - 10https://gerrit.wikimedia.org/r/113154 [23:24:41] (03CR) 10Chad: Introducing TitleValue (031 comment) [core] - 10https://gerrit.wikimedia.org/r/106517 (owner: 10Daniel Kinzler) [23:25:32] (03CR) 10Bartosz Dziewoński: [C: 032] Use normal mw.message call [extensions/GuidedTour] - 10https://gerrit.wikimedia.org/r/113279 (owner: 10Mattflaschen) [23:26:01] (03Merged) 10jenkins-bot: Use normal mw.message call [extensions/GuidedTour] - 10https://gerrit.wikimedia.org/r/113279 (owner: 10Mattflaschen) [23:26:14] (03CR) 10Wikinaut: "okay, thanks" [extensions/Math] - 10https://gerrit.wikimedia.org/r/112589 (owner: 10Physikerwelt) [23:27:20] (03PS1) 10Ori.livneh: Update EventLogging to master [core] (wmf/1.23wmf13) - 10https://gerrit.wikimedia.org/r/113292 [23:27:38] (03CR) 10GWicke: "Looks good! A few small ideas inline." (035 comments) [services/mathoid] - 10https://gerrit.wikimedia.org/r/113025 (owner: 10Physikerwelt) [23:28:24] (03CR) 10GWicke: [C: 031] npm version of debian package [services/mathoid] - 10https://gerrit.wikimedia.org/r/113025 (owner: 10Physikerwelt) [23:28:45] (03PS1) 10Ori.livneh: Update NavigationTiming to master [core] (wmf/1.23wmf14) - 10https://gerrit.wikimedia.org/r/113293 [23:30:43] (03CR) 10Ori.livneh: [C: 032 V: 032] Update EventLogging to master [core] (wmf/1.23wmf13) - 10https://gerrit.wikimedia.org/r/113292 (owner: 10Ori.livneh) [23:30:56] (03CR) 10Ori.livneh: [C: 032 V: 032] Update NavigationTiming to master [core] (wmf/1.23wmf14) - 10https://gerrit.wikimedia.org/r/113293 (owner: 10Ori.livneh) [23:31:01] (03PS19) 10Inchikutty: [WIP]Embedding leaflet maps based on OSM data to UploadWizard [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/109263 [23:34:58] (03CR) 10GWicke: "For production debs we'll need to pull in node_modules without the network, either from a separate repository (submodule?) or by just copy" [services/mathoid] - 10https://gerrit.wikimedia.org/r/113025 (owner: 10Physikerwelt) [23:46:36] (03CR) 10EBernhardson: [C: 032] "not sure there is any benefit here, we don't ever pass the View object around, but can't hurt." [extensions/Flow] - 10https://gerrit.wikimedia.org/r/111717 (owner: 10Legoktm) [23:46:48] (03Merged) 10jenkins-bot: Turn \Flow\View into a ContextSource [extensions/Flow] - 10https://gerrit.wikimedia.org/r/111717 (owner: 10Legoktm) [23:48:15] (03PS3) 10Inchikutty: [WIP] UploadWizard:OSM embedding- Geocoding, reverse geocoding [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/112342 [23:48:46] (03CR) 10EBernhardson: [C: 04-2] "this patch will be unnecessary, currently its board-history because its not a full page history, its just the board level history(new topi" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/111924 (owner: 10Legoktm) [23:49:57] (03CR) 10EBernhardson: [C: 031] Pull flow revision data based on user_wiki and user_id/user_ip [extensions/Flow] - 10https://gerrit.wikimedia.org/r/111952 (owner: 10Bsitu) [23:51:20] (03CR) 10EBernhardson: "hello, jenkins-bot? where are you? :)" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/108634 (owner: 10Matthias Mullie) [23:53:11] (03PS7) 10Matthias Mullie: Move flow( 'loadReplyForm' ) to base/action.js [extensions/Flow] - 10https://gerrit.wikimedia.org/r/108634 [23:53:23] (03CR) 10EBernhardson: [C: 032] "one more time" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/108634 (owner: 10Matthias Mullie) [23:53:33] (03Merged) 10jenkins-bot: Move flow( 'loadReplyForm' ) to base/action.js [extensions/Flow] - 10https://gerrit.wikimedia.org/r/108634 (owner: 10Matthias Mullie) [23:56:41] given a revision object, how do i get the title of the page as it was at the time the revision was made? [23:57:14] (03PS1) 10MarkTraceur: Backport fix for MultimediaViewer's keystroke handling [core] (wmf/1.23wmf13) - 10https://gerrit.wikimedia.org/r/113300 [23:57:46] (03CR) 10EBernhardson: [C: 031] "looks good, havn't tried it" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/113057 (owner: 10Matthias Mullie)